Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA

[Maxime Coquelin]

On 09/28/2018 01:23 PM, Xiaolong Ye wrote:

The vdpa sample application creates vhost-user sockets by using the
vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
virtio ring compatible devices to serve virtio driver directly to enable
datapath acceleration. As vDPA driver can help to set up vhost datapath,
this application doesn't need to launch dedicated worker threads for vhost
enqueue/dequeue operations.

Reviewed-by: Maxime coquelin 
Acked-by: Xiao Wang 
Signed-off-by: Xiaolong Ye 
---
  MAINTAINERS|   2 +
  doc/guides/rel_notes/release_18_11.rst |   8 +
  doc/guides/sample_app_ug/index.rst |   1 +
  doc/guides/sample_app_ug/vdpa.rst  | 120 +++
  examples/Makefile  |   2 +-
  examples/vdpa/Makefile |  32 ++
  examples/vdpa/main.c   | 462 +
  examples/vdpa/meson.build  |  16 +
  8 files changed, 642 insertions(+), 1 deletion(-)
  create mode 100644 doc/guides/sample_app_ug/vdpa.rst
  create mode 100644 examples/vdpa/Makefile
  create mode 100644 examples/vdpa/main.c
  create mode 100644 examples/vdpa/meson.build

diff --git a/MAINTAINERS b/MAINTAINERS
index 5967c1dd3..5656f18e8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -683,6 +683,8 @@ F: doc/guides/sample_app_ug/vhost.rst
  F: examples/vhost_scsi/
  F: doc/guides/sample_app_ug/vhost_scsi.rst
  F: examples/vhost_crypto/
+F: examples/vdpa/
+F: doc/guides/sample_app_ug/vdpa.rst
  
  Vhost PMD

  M: Maxime Coquelin 
diff --git a/doc/guides/rel_notes/release_18_11.rst 
b/doc/guides/rel_notes/release_18_11.rst
index bc9b74ec4..dd53a9ecf 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -67,6 +67,14 @@ New Features
SR-IOV option in Hyper-V and Azure. This is an alternative to the previous
vdev_netvsc, tap, and failsafe drivers combination.
  
+* **Add a new sample for vDPA**

+
+  The vdpa sample application creates vhost-user sockets by using the
+  vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
+  virtio ring compatible devices to serve virtio driver directly to enable
+  datapath acceleration. As vDPA driver can help to set up vhost datapath,
+  this application doesn't need to launch dedicated worker threads for vhost
+  enqueue/dequeue operations.
  
  API Changes

  ---
diff --git a/doc/guides/sample_app_ug/index.rst 
b/doc/guides/sample_app_ug/index.rst
index 5bedf4f6f..74b12af85 100644
--- a/doc/guides/sample_app_ug/index.rst
+++ b/doc/guides/sample_app_ug/index.rst
@@ -45,6 +45,7 @@ Sample Applications User Guides
  vhost
  vhost_scsi
  vhost_crypto
+vdpa
  netmap_compatibility
  ip_pipeline
  test_pipeline
diff --git a/doc/guides/sample_app_ug/vdpa.rst 
b/doc/guides/sample_app_ug/vdpa.rst
new file mode 100644
index 0..745f196ca
--- /dev/null
+++ b/doc/guides/sample_app_ug/vdpa.rst
@@ -0,0 +1,120 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 Intel Corporation.
+
+Vdpa Sample Application
+===
+
+The vdpa sample application creates vhost-user sockets by using the
+vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
+virtio ring compatible devices to serve virtio driver directly to enable
+datapath acceleration. As vDPA driver can help to set up vhost datapath,
+this application doesn't need to launch dedicated worker threads for vhost
+enqueue/dequeue operations.
+
+Testing steps
+-
+
+This section shows the steps of how to start VMs with vDPA vhost-user
+backend and verify network connection & live migration.
+
+Build
+~
+
+To compile the sample application see :doc:`compiling`.
+
+The application is located in the ``vdpa`` sub-directory.
+
+Start the vdpa example
+~~
+
+.. code-block:: console
+
+./vdpa [EAL options]  -- [--client] [--interactive|-i] or [--iface 
SOCKET_PATH]
+
+where
+
+* --client means running vdpa app in client mode, in the client mode, QEMU 
needs
+  to run as the server mode and take charge of socket file creation.
+* --iface specifies the path prefix of the UNIX domain socket file, e.g.
+  /tmp/vhost-user-, then the socket files will be named as /tmp/vhost-user-
+  (n starts from 0).
+* --interactive means run the vdpa sample in interactive mode, currently 4
+  internal cmds are supported:
+
+  1. help: show help message
+  2. list: list all available vdpa devices
+  3. create: create a new vdpa port with socket file and vdpa device address
+  4. quit: unregister vhost driver and exit the application
+
+Take IFCVF driver for example:
+
+.. code-block:: console
+
+./vdpa -c 0x2 -n 4 --socket-mem 1024,1024 \
+-w :06:00.3,vdpa=1 -w :06:00.4,vdpa=1 \
+-- --interactive
+
+.. note::
+Here :06:00.3 and :06:00.4 refer to virtio ring compatible devices,
+and we need to bind vfio-pci 

[dpdk-dev] [PATCH] net/i40e: select fdir config automatically

[Xiaoyun Li]

I40e driver needed users to config exact fdir mode to create rte_flow
rules but it shouldn't. This patch allows users to create rte_flow rules
without configuring fdir mode and let the driver select the config
automatically.

Signed-off-by: Xiaoyun Li 
---
 drivers/net/i40e/i40e_flow.c | 33 -
 1 file changed, 28 insertions(+), 5 deletions(-)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index c67b264de..70ff33ac0 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -3127,6 +3127,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
struct rte_flow_error *error,
union i40e_filter_t *filter)
 {
+   struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
struct i40e_fdir_filter_conf *fdir_filter =
&filter->fdir_filter;
int ret;
@@ -3148,14 +3149,29 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
 
if (dev->data->dev_conf.fdir_conf.mode !=
RTE_FDIR_MODE_PERFECT) {
-   rte_flow_error_set(error, ENOTSUP,
-  RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
-  NULL,
-  "Check the mode in fdir_conf.");
-   return -rte_errno;
+   /* Enable fdir when fdir flow is added at first time. */
+   ret = i40e_fdir_setup(pf);
+   if (ret != I40E_SUCCESS) {
+   rte_flow_error_set(error, ENOTSUP,
+  RTE_FLOW_ERROR_TYPE_HANDLE,
+  NULL, "Failed to setup fdir.");
+   return -rte_errno;
+   }
+   ret = i40e_fdir_configure(dev);
+   if (ret < 0) {
+   rte_flow_error_set(error, ENOTSUP,
+  RTE_FLOW_ERROR_TYPE_HANDLE,
+  NULL, "Failed to configure fdir.");
+   goto err;
+   }
+
+   dev->data->dev_conf.fdir_conf.mode = RTE_FDIR_MODE_PERFECT;
}
 
return 0;
+err:
+   i40e_fdir_teardown(pf);
+   return -rte_errno;
 }
 
 /* Parse to get the action info of a tunnel filter
@@ -4708,6 +4724,13 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
case RTE_ETH_FILTER_FDIR:
ret = i40e_flow_add_del_fdir_filter(dev,
   &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
+
+   /* If the last flow is destroyed, disable fdir. */
+   if (!ret && !TAILQ_FIRST(&pf->fdir.fdir_list)) {
+   i40e_fdir_teardown(pf);
+   dev->data->dev_conf.fdir_conf.mode =
+  RTE_FDIR_MODE_NONE;
+   }
break;
case RTE_ETH_FILTER_HASH:
ret = i40e_config_rss_filter_del(dev,
-- 
2.17.1

Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA

[Ye Xiaolong]

On 09/28, Maxime Coquelin wrote:
>> +ret = rte_eal_init(argc, argv);
>> +if (ret < 0)
>> +rte_exit(EXIT_FAILURE, "eal init failed\n");
>> +argc -= ret;
>> +argv += ret;
>> +
>> +data_init();
>
>You need to check return from data_init().
>If this is fine for you, I can change to below code when applying:
>
>ret = data_init();
>if (ret < 0)
>rte_exit(EXIT_FAILURE, "data init failed\n");
>
> 

I'm fine with this change.

Thanks,
Xiaolong

[dpdk-dev] [PATCH v4 1/4] net/enetc: add ENETC PMD with basic operations

[Gagandeep Singh]

This patch introduces the enetc PMD with basic
initialisation functions includes probe, teardown,
hardware initialisation

Signed-off-by: Gagandeep Singh 
---
 config/common_base  |   5 +
 config/common_linuxapp  |   5 +
 drivers/net/Makefile|   1 +
 drivers/net/enetc/Makefile  |  22 ++
 drivers/net/enetc/base/enetc_hw.h   | 217 +
 drivers/net/enetc/enetc.h   |  90 +++
 drivers/net/enetc/enetc_ethdev.c| 251 
 drivers/net/enetc/enetc_logs.h  |  40 
 drivers/net/enetc/meson.build   |  10 +
 drivers/net/enetc/rte_pmd_enetc_version.map |   4 +
 drivers/net/meson.build |   1 +
 mk/rte.app.mk   |   1 +
 12 files changed, 647 insertions(+)
 create mode 100644 drivers/net/enetc/Makefile
 create mode 100644 drivers/net/enetc/base/enetc_hw.h
 create mode 100644 drivers/net/enetc/enetc.h
 create mode 100644 drivers/net/enetc/enetc_ethdev.c
 create mode 100644 drivers/net/enetc/enetc_logs.h
 create mode 100644 drivers/net/enetc/meson.build
 create mode 100644 drivers/net/enetc/rte_pmd_enetc_version.map

diff --git a/config/common_base b/config/common_base
index 4bcbaf923..a7fc48667 100644
--- a/config/common_base
+++ b/config/common_base
@@ -217,6 +217,11 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
 CONFIG_RTE_LIBRTE_DPAA2_PMD=n
 CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
 
+#
+# Compile NXP ENETC PMD Driver
+#
+CONFIG_RTE_LIBRTE_ENETC_PMD=n
+
 #
 # Compile burst-oriented Amazon ENA PMD driver
 #
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 9c5ea9d89..485e1467d 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -44,3 +44,8 @@ CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=y
+
+#
+# NXP ENETC PMD Driver
+#
+CONFIG_RTE_LIBRTE_ENETC_PMD=y
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 664398de9..3ad436045 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -24,6 +24,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += dpaa2
 endif
 DIRS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += e1000
 DIRS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += ena
+DIRS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc
 DIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) += failsafe
 DIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k
diff --git a/drivers/net/enetc/Makefile b/drivers/net/enetc/Makefile
new file mode 100644
index 0..519153868
--- /dev/null
+++ b/drivers/net/enetc/Makefile
@@ -0,0 +1,22 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 NXP
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_enetc.a
+
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+EXPORT_MAP := rte_pmd_enetc_version.map
+LIBABIVER := 1
+
+SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_ethdev.c
+
+LDLIBS += -lrte_eal
+LDLIBS += -lrte_ethdev
+LDLIBS += -lrte_bus_pci
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/enetc/base/enetc_hw.h 
b/drivers/net/enetc/base/enetc_hw.h
new file mode 100644
index 0..c962b9ca1
--- /dev/null
+++ b/drivers/net/enetc/base/enetc_hw.h
@@ -0,0 +1,217 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2018 NXP
+ */
+
+#ifndef _ENETC_HW_H_
+#define _ENETC_HW_H_
+#include 
+
+#define BIT(x) ((uint64_t)1 << ((x)))
+
+/* ENETC device IDs */
+#define ENETC_DEV_ID_VF0xef00
+#define ENETC_DEV_ID   0xe100
+
+/* ENETC register block BAR */
+#define ENETC_BAR_REGS 0x0
+
+/* SI regs, offset: 0h */
+#define ENETC_SIMR 0x0
+#define ENETC_SIMR_EN  BIT(31)
+
+#define ENETC_SIPMAR0  0x80
+#define ENETC_SIPMAR1  0x84
+
+#define ENETC_SICAPR0  0x900
+#define ENETC_SICAPR1  0x904
+
+#define ENETC_SIMSITRV(n)  (0xB00 + (n) * 0x4)
+#define ENETC_SIMSIRRV(n)  (0xB80 + (n) * 0x4)
+
+#define ENETC_SICCAPR  0x1200
+
+/* enum for BD type */
+enum enetc_bdr_type {TX, RX};
+
+#define ENETC_BDR(type, n, off)(0x8000 + (type) * 0x100 + (n) 
* 0x200 \
+   + (off))
+/* RX BDR reg offsets */
+#define ENETC_RBMR 0x0 /* RX BDR mode register*/
+#define ENETC_RBMR_EN  BIT(31)
+
+#define ENETC_RBSR 0x4  /* Rx BDR status register*/
+#define ENETC_RBBSR0x8  /* Rx BDR buffer size register*/
+#define ENETC_RBCIR0xc  /* Rx BDR consumer index register*/
+#define ENETC_RBBAR0   0x10 /* Rx BDR base address register 0 */
+#define ENETC_RBBAR1   0x14 /* Rx BDR base address register 1*/
+#define ENETC_RBPIR0x18 /* Rx BDR producer index register*/
+#define ENETC_RBLENR   0x20 /* Rx BDR length reg

[dpdk-dev] [PATCH v4 2/4] net/enetc: enable Rx and Tx

[Gagandeep Singh]

Add RX and TX queue setup, datapath functions

Signed-off-by: Gagandeep Singh 
---
 drivers/net/enetc/Makefile|   3 +-
 drivers/net/enetc/base/enetc_hw.h |  19 +-
 drivers/net/enetc/enetc.h |  25 ++-
 drivers/net/enetc/enetc_ethdev.c  | 326 +-
 drivers/net/enetc/enetc_rxtx.c| 239 ++
 drivers/net/enetc/meson.build |   3 +-
 6 files changed, 602 insertions(+), 13 deletions(-)
 create mode 100644 drivers/net/enetc/enetc_rxtx.c

diff --git a/drivers/net/enetc/Makefile b/drivers/net/enetc/Makefile
index 519153868..9895501db 100644
--- a/drivers/net/enetc/Makefile
+++ b/drivers/net/enetc/Makefile
@@ -14,8 +14,9 @@ EXPORT_MAP := rte_pmd_enetc_version.map
 LIBABIVER := 1
 
 SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_ethdev.c
+SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_rxtx.c
 
-LDLIBS += -lrte_eal
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
 LDLIBS += -lrte_ethdev
 LDLIBS += -lrte_bus_pci
 
diff --git a/drivers/net/enetc/base/enetc_hw.h 
b/drivers/net/enetc/base/enetc_hw.h
index c962b9ca1..c74c94875 100644
--- a/drivers/net/enetc/base/enetc_hw.h
+++ b/drivers/net/enetc/base/enetc_hw.h
@@ -104,16 +104,19 @@ enum enetc_bdr_type {TX, RX};
 #define ETH_ADDR_LEN   6
 
 /* general register accessors */
-#define enetc_rd_reg(reg)  rte_read32((reg))
-#define enetc_wr_reg(reg, val) rte_write32((val), (reg))
-#define enetc_rd(hw, off)  enetc_rd_reg((hw)->reg + (off))
-#define enetc_wr(hw, off, val) enetc_wr_reg((hw)->reg + (off), val)
+#define enetc_rd_reg(reg)  rte_read32((void *)(reg))
+#define enetc_wr_reg(reg, val) rte_write32((val), (void *)(reg))
+#define enetc_rd(hw, off)  enetc_rd_reg((size_t)(hw)->reg + (off))
+#define enetc_wr(hw, off, val) enetc_wr_reg((size_t)(hw)->reg + (off), val)
 /* port register accessors - PF only */
-#define enetc_port_rd(hw, off) enetc_rd_reg((hw)->port + (off))
-#define enetc_port_wr(hw, off, val)enetc_wr_reg((hw)->port + (off), val)
+#define enetc_port_rd(hw, off) enetc_rd_reg((size_t)(hw)->port + (off))
+#define enetc_port_wr(hw, off, val) \
+   enetc_wr_reg((size_t)(hw)->port + (off), val)
 /* global register accessors - PF only */
-#define enetc_global_rd(hw, off)   enetc_rd_reg((hw)->global + (off))
-#define enetc_global_wr(hw, off, val)  enetc_wr_reg((hw)->global + (off), val)
+#define enetc_global_rd(hw, off) \
+   enetc_rd_reg((size_t)(hw)->global + (off))
+#define enetc_global_wr(hw, off, val) \
+   enetc_wr_reg((size_t)(hw)->global + (off), val)
 /* BDR register accessors, see ENETC_BDR() */
 #define enetc_bdr_rd(hw, t, n, off) \
enetc_rd(hw, ENETC_BDR(t, n, off))
diff --git a/drivers/net/enetc/enetc.h b/drivers/net/enetc/enetc.h
index 9fa7c726c..140daf0dd 100644
--- a/drivers/net/enetc/enetc.h
+++ b/drivers/net/enetc/enetc.h
@@ -18,7 +18,11 @@
 #define MAX_RX_RINGS   1
 
 /* Max BD counts per Ring. */
-#define MAX_BD_COUNT   256
+#define MAX_BD_COUNT   64000
+/* Min BD counts per Ring. */
+#define MIN_BD_COUNT   32
+/* BD ALIGN */
+#define BD_ALIGN   8
 
 /*
  * upper_32_bits - return bits 32-63 of a number
@@ -87,4 +91,23 @@ struct enetc_eth_adapter {
 #define ENETC_REG_WRITE(addr, val) (*(uint32_t *)addr = val)
 #define ENETC_REG_WRITE_RELAXED(addr, val) (*(uint32_t *)addr = val)
 
+/*
+ * RX/TX ENETC function prototypes
+ */
+uint16_t enetc_xmit_pkts(void *txq, struct rte_mbuf **tx_pkts,
+   uint16_t nb_pkts);
+uint16_t enetc_recv_pkts(void *rxq, struct rte_mbuf **rx_pkts,
+   uint16_t nb_pkts);
+
+
+int enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const int buff_cnt);
+
+static inline int
+enetc_bd_unused(struct enetc_bdr *bdr)
+{
+   if (bdr->next_to_clean > bdr->next_to_use)
+   return bdr->next_to_clean - bdr->next_to_use - 1;
+
+   return bdr->bd_count + bdr->next_to_clean - bdr->next_to_use - 1;
+}
 #endif /* _ENETC_H_ */
diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c
index 47e2a8ebf..2d90d8fd5 100644
--- a/drivers/net/enetc/enetc_ethdev.c
+++ b/drivers/net/enetc/enetc_ethdev.c
@@ -19,6 +19,15 @@ static void enetc_dev_infos_get(struct rte_eth_dev *dev,
struct rte_eth_dev_info *dev_info);
 static int enetc_link_update(struct rte_eth_dev *dev, int wait_to_complete);
 static int enetc_hardware_init(struct enetc_eth_hw *hw);
+static int enetc_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
+   uint16_t nb_rx_desc, unsigned int socket_id,
+   const struct rte_eth_rxconf *rx_conf,
+   struct rte_mempool *mb_pool);
+static void enetc_rx_queue_release(void *rxq);
+static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
+   uint16_t nb_tx_desc, unsigned int socket_id,
+   const struct rte_eth_txconf *tx_conf);
+static void enetc

[dpdk-dev] [PATCH v4 0/4] introduces the enetc PMD driver

[Gagandeep Singh]

*ENETC* PMD driver which integrates with the existing PCI bus.
Document is also part of the set

v3->v4 Change-log:
* fixed patch set

v2->v3 Change-log:
* Added a release note
* commom part of documentation is removed
* cflag Werror added in Makefile
* private list of RX/TX queues removed
* added the dev_start and dev_stop APIs
* added rx/tx queue release APIs
* packet parse type feature enabled

v1->v2 Change-log:
* document improvement
* checkpatch warnings removed

Gagandeep Singh (4):
  net/enetc: add ENETC PMD with basic operations
  net/enetc: enable Rx and Tx
  net/enetc: support packet parse type
  doc: add usage doc for ENETC PMD

 MAINTAINERS |   7 +
 config/common_base  |   5 +
 config/common_linuxapp  |   5 +
 doc/guides/nics/enetc.rst   | 110 
 doc/guides/nics/features/enetc.ini  |  11 +
 doc/guides/nics/index.rst   |   1 +
 doc/guides/rel_notes/release_18_11.rst  |   6 +
 drivers/net/Makefile|   1 +
 drivers/net/enetc/Makefile  |  23 +
 drivers/net/enetc/base/enetc_hw.h   | 220 
 drivers/net/enetc/enetc.h   | 113 
 drivers/net/enetc/enetc_ethdev.c| 592 
 drivers/net/enetc/enetc_logs.h  |  40 ++
 drivers/net/enetc/enetc_rxtx.c  | 239 
 drivers/net/enetc/meson.build   |  11 +
 drivers/net/enetc/rte_pmd_enetc_version.map |   4 +
 drivers/net/meson.build |   1 +
 mk/rte.app.mk   |   1 +
 18 files changed, 1390 insertions(+)
 create mode 100644 doc/guides/nics/enetc.rst
 create mode 100644 doc/guides/nics/features/enetc.ini
 create mode 100644 drivers/net/enetc/Makefile
 create mode 100644 drivers/net/enetc/base/enetc_hw.h
 create mode 100644 drivers/net/enetc/enetc.h
 create mode 100644 drivers/net/enetc/enetc_ethdev.c
 create mode 100644 drivers/net/enetc/enetc_logs.h
 create mode 100644 drivers/net/enetc/enetc_rxtx.c
 create mode 100644 drivers/net/enetc/meson.build
 create mode 100644 drivers/net/enetc/rte_pmd_enetc_version.map

-- 
2.17.1

[dpdk-dev] [PATCH v4 3/4] net/enetc: support packet parse type

[Gagandeep Singh]

Signed-off-by: Gagandeep Singh 
---
 drivers/net/enetc/enetc_ethdev.c | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c
index 2d90d8fd5..8f4da8533 100644
--- a/drivers/net/enetc/enetc_ethdev.c
+++ b/drivers/net/enetc/enetc_ethdev.c
@@ -28,6 +28,7 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, 
uint16_t tx_queue_id,
uint16_t nb_tx_desc, unsigned int socket_id,
const struct rte_eth_txconf *tx_conf);
 static void enetc_tx_queue_release(void *txq);
+static const uint32_t *enetc_supported_ptypes_get(struct rte_eth_dev *dev);
 
 /*
  * The set of PCI devices this driver supports
@@ -50,6 +51,7 @@ static const struct eth_dev_ops enetc_ops = {
.rx_queue_release = enetc_rx_queue_release,
.tx_queue_setup   = enetc_tx_queue_setup,
.tx_queue_release = enetc_tx_queue_release,
+   .dev_supported_ptypes_get = enetc_supported_ptypes_get,
 };
 
 /**
@@ -165,6 +167,23 @@ enetc_dev_close(struct rte_eth_dev *dev __rte_unused)
PMD_INIT_FUNC_TRACE();
 }
 
+static const uint32_t *
+enetc_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)
+{
+   static const uint32_t ptypes[] = {
+   RTE_PTYPE_L2_ETHER,
+   RTE_PTYPE_L3_IPV4,
+   RTE_PTYPE_L3_IPV6,
+   RTE_PTYPE_L4_TCP,
+   RTE_PTYPE_L4_UDP,
+   RTE_PTYPE_L4_SCTP,
+   RTE_PTYPE_L4_ICMP,
+   RTE_PTYPE_UNKNOWN
+   };
+
+   return ptypes;
+}
+
 /* return 0 means link status changed, -1 means not changed */
 static int
 enetc_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)
-- 
2.17.1

[dpdk-dev] [PATCH v4 4/4] doc: add usage doc for ENETC PMD

[Gagandeep Singh]

Add enetc usage document to compile and run the
DPDK application on enetc supported platform.
This document introduces the enetc driver, supported
platforms and supported features.

Signed-off-by: Gagandeep Singh 
---
 MAINTAINERS|   7 ++
 doc/guides/nics/enetc.rst  | 110 +
 doc/guides/nics/features/enetc.ini |  11 +++
 doc/guides/nics/index.rst  |   1 +
 doc/guides/rel_notes/release_18_11.rst |   6 ++
 5 files changed, 135 insertions(+)
 create mode 100644 doc/guides/nics/enetc.rst
 create mode 100644 doc/guides/nics/features/enetc.ini

diff --git a/MAINTAINERS b/MAINTAINERS
index 9fd258fad..b67f2afa4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -643,6 +643,13 @@ F: drivers/net/dpaa2/
 F: doc/guides/nics/dpaa2.rst
 F: doc/guides/nics/features/dpaa2.ini
 
+NXP enetc
+M: Gagandeep Singh 
+M: Pankaj Chauhan 
+F: drivers/net/enetc/
+F: doc/guides/nics/enetc.rst
+F: doc/guides/nics/features/enetc.ini
+
 QLogic bnx2x
 M: Harish Patil 
 M: Rasesh Mody 
diff --git a/doc/guides/nics/enetc.rst b/doc/guides/nics/enetc.rst
new file mode 100644
index 0..8038bf205
--- /dev/null
+++ b/doc/guides/nics/enetc.rst
@@ -0,0 +1,110 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright 2018 NXP
+
+ENETC Poll Mode Driver
+==
+
+The ENETC NIC PMD (**librte_pmd_enetc**) provides poll mode driver
+support for the inbuilt NIC found in the **NXP LS1028** SoC.
+
+More information can be found at `NXP Official Website
+`_.
+
+ENETC
+-
+
+This section provides an overview of the NXP ENETC
+and how it is integrated into the DPDK.
+
+Contents summary
+
+- ENETC overview
+- ENETC features
+- PCI bus driver
+- NIC driver
+- Supported ENETC SoCs
+- Prerequisites
+- Driver compilation and testing
+
+ENETC Overview
+~~
+
+ENETC is a PCI Integrated End Point(IEP). IEP implements
+peripheral devices in an SoC such that software sees them as PCIe device.
+ENETC is an evolution of BDR(Buffer Descriptor Ring) based networking
+IPs.
+
+This infrastructure simplifies adding support for IEP and facilitates in 
following:
+
+- Device discovery and location
+- Resource requirement discovery and allocation (e.g. interrupt assignment,
+  device register address)
+- Event reporting
+
+ENETC Features
+~~
+
+- Link Status
+- Packet type information
+
+NIC Driver (PMD)
+
+
+ENETC PMD is traditional DPDK PMD which provides necessary interface between
+RTE framework and ENETC internal drivers.
+
+- Driver registers the device vendor table in PCI subsystem.
+- RTE framework scans the PCI bus for connected devices.
+- This scanning will invoke the probe function of ENETC driver.
+- The probe function will set the basic device registers and also setups BD 
rings.
+- On packet Rx the respective BD Ring status bit is set which is then used for
+  packet processing.
+- Then Tx is done first followed by Rx.
+
+Supported ENETC SoCs
+
+
+- LS1028
+
+Prerequisites
+~
+
+There are three main pre-requisities for executing ENETC PMD on a ENETC
+compatible board:
+
+1. **ARM 64 Tool Chain**
+
+   For example, the `*aarch64* Linaro Toolchain 
`_.
+
+2. **Linux Kernel**
+
+   It can be obtained from `NXP's Github hosting 
`_.
+
+3. **Rootfile system**
+
+   Any *aarch64* supporting filesystem can be used. For example,
+   Ubuntu 16.04 LTS (Xenial) or 18.04 (Bionic) userland which can be obtained
+   from `here 
`_.
+
+The following dependencies are not part of DPDK and must be installed
+separately:
+
+- **NXP Linux LSDK**
+
+  NXP Layerscape software development kit (LSDK) includes support for family
+  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
+  and corresponding boards.
+
+  It includes the Linux board support packages (BSPs) for NXP SoCs,
+  a fully operational tool chain, kernel and board specific modules.
+
+  LSDK and related information can be obtained from:  `LSDK 
`_
+
+Driver compilation and testing
+~~
+
+Follow instructions available in the document
+:ref:`compiling and testing a PMD for a NIC `
+to launch **testpmd**
+
+To compile in performance mode, please set ``CONFIG_RTE_CACHE_LINE_SIZE=64``
diff --git a/doc/guides/nics/features/enetc.ini 
b/doc/guides/nics/features/enetc.ini
n

Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA

[Maxime Coquelin]

On 09/28/2018 04:33 PM, Ye Xiaolong wrote:

On 09/28, Maxime Coquelin wrote:

+   ret = rte_eal_init(argc, argv);
+   if (ret < 0)
+   rte_exit(EXIT_FAILURE, "eal init failed\n");
+   argc -= ret;
+   argv += ret;
+
+   data_init();


You need to check return from data_init().
If this is fine for you, I can change to below code when applying:

ret = data_init();
if (ret < 0)
rte_exit(EXIT_FAILURE, "data init failed\n");




I'm fine with this change.


Or even better, get rid of data_init and
call rte_vdpa_get_device_num(); in main directly.


Thanks,
Xiaolong

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

[Igor Ryzhov]

Hi Dan, Ferruh,

Why do we need "struct rte_eth_link" as a parameter at all?
Only link status is used in the function – let's use it only:

rte_kni_update_link(struct rte_kni *kni, int link_status) /* 0 – down, 1 –
up */

It will also solve your differences as we won't have any "redundant"
information to print :)

Best regards,
Igor

On Fri, Sep 28, 2018 at 2:52 AM Dan Gora  wrote:

> On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit 
> wrote:
> >> Well, yes the link_status (link up, link down) _is_ applied to the KNI
> >> interface.  When that occurs, most people want to know what the link
> >> speed is that the link came up at.
> >
> > +1 to this, people would like to know link speed of the interface.
> > Are you printing link speed of interface? You are printing whatever user
> pass to
> > API.
>
> There is no such thing as "link speed of the interface".  The link
> speed is the speed of the underlying Ethernet link that the interface
> corresponds to.  This is true for all other ethernet interfaces in the
> kernel.
>
> > I guess you trust to user to provide correct values there, but since
> only link
> > up & down matters, what prevents user to leave other fields, like speed,
> just
> > random values?
>
> Nothing.  What prevents anyone from providing random values for
> anything?  The point of the API was to make it super simple, just:
>
> rte_eth_link_get_nowait(portid, &link);
> rte_kni_update_link(p[portid]->kni[i], &link);
>
> No messing around with the link info retrieved from
> rte_eth_link_get(_nowait), just dump in the struct that was returned.
>

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

[Ferruh Yigit]

On 9/28/2018 12:51 AM, Dan Gora wrote:
> On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit  wrote:
>>> Well, yes the link_status (link up, link down) _is_ applied to the KNI
>>> interface.  When that occurs, most people want to know what the link
>>> speed is that the link came up at.
>>
>> +1 to this, people would like to know link speed of the interface.
>> Are you printing link speed of interface? You are printing whatever user 
>> pass to
>> API.
> 
> There is no such thing as "link speed of the interface".  The link
> speed is the speed of the underlying Ethernet link that the interface
> corresponds to.  This is true for all other ethernet interfaces in the
> kernel.

This is an API to set link status of KNI interface, KNI interface is a virtual
interface and no need to be backed by a physical interface at all.

Only kni sample application uses it in a way to match a physical interface to a
KNI interface, but please check KNI PMD where you can have multiple KNI
interface without any physical device at all.

> 
>> I guess you trust to user to provide correct values there, but since only 
>> link
>> up & down matters, what prevents user to leave other fields, like speed, just
>> random values?
> 
> Nothing.  What prevents anyone from providing random values for
> anything?  The point of the API was to make it super simple, just:
> 
> rte_eth_link_get_nowait(portid, &link);
> rte_kni_update_link(p[portid]->kni[i], &link);

You are only thinking about this use case. Normally the input to API should be
verified right, for this case there is no way to verify it and vales are not
used at all, it is just printed in API.

OK to print link information but please do so in sample application before
calling API, not in API please.

> 
> No messing around with the link info retrieved from
> rte_eth_link_get(_nowait), just dump in the struct that was returned.
> 

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

[Bruce Richardson]

On Fri, Sep 28, 2018 at 02:00:00AM +0100, Wang, Yipeng1 wrote:
> Reply inlined:
> 
> >-Original Message-
> >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa Nagarahalli
> >Sent: Thursday, September 6, 2018 10:12 AM
> >To: Richardson, Bruce ; De Lara Guarch, Pablo 
> >
> >Cc: dev@dpdk.org; honnappa.nagaraha...@dpdk.org; gavin...@arm.com; 
> >steve.cap...@arm.com; ola.liljed...@arm.com;
> >n...@arm.com; Honnappa Nagarahalli 
> >Subject: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys
> >
> >Reader-writer concurrency issue, caused by moving the keys
> >to their alternative locations during key insert, is solved
> >by introducing a global counter(tbl_chng_cnt) indicating a
> >change in table.
> >
> >@@ -662,6 +679,20 @@ rte_hash_cuckoo_move_insert_mw(const struct rte_hash *h,
> > curr_bkt = curr_node->bkt;
> > }
> >
> >+/* Inform the previous move. The current move need
> >+ * not be informed now as the current bucket entry
> >+ * is present in both primary and secondary.
> >+ * Since there is one writer, load acquires on
> >+ * tbl_chng_cnt are not required.
> >+ */
> >+__atomic_store_n(&h->tbl_chng_cnt,
> >+ h->tbl_chng_cnt + 1,
> >+ __ATOMIC_RELEASE);
> >+/* The stores to sig_alt and sig_current should not
> >+ * move above the store to tbl_chng_cnt.
> >+ */
> >+__atomic_thread_fence(__ATOMIC_RELEASE);
> >+
> [Wang, Yipeng] I believe for X86 this fence should not be compiled to any 
> code, otherwise
> we need macros for the compile time check.
> 
> >@@ -926,30 +957,56 @@ __rte_hash_lookup_with_hash(const struct rte_hash *h, 
> >const void *key,
> > uint32_t bucket_idx;
> > hash_sig_t alt_hash;
> > struct rte_hash_bucket *bkt;
> >+uint32_t cnt_b, cnt_a;
> > int ret;
> >
> >-bucket_idx = sig & h->bucket_bitmask;
> >-bkt = &h->buckets[bucket_idx];
> >-
> > __hash_rw_reader_lock(h);
> >
> >-/* Check if key is in primary location */
> >-ret = search_one_bucket(h, key, sig, data, bkt);
> >-if (ret != -1) {
> >-__hash_rw_reader_unlock(h);
> >-return ret;
> >-}
> >-/* Calculate secondary hash */
> >-alt_hash = rte_hash_secondary_hash(sig);
> >-bucket_idx = alt_hash & h->bucket_bitmask;
> >-bkt = &h->buckets[bucket_idx];
> >+do {
> [Wang, Yipeng] As far as I know, the MemC3 paper "MemC3: Compact and 
> Concurrent
> MemCache with Dumber Caching and Smarter Hashing"
> as well as OvS cmap uses similar version counter to implement read-write 
> concurrency for hash table,
> but one difference is reader checks even/odd of the version counter to make 
> sure there is no
> concurrent writer. Could you just double check and confirm that this is not 
> needed for your implementation?
> 
> >--- a/lib/librte_hash/rte_hash.h
> >+++ b/lib/librte_hash/rte_hash.h
> >@@ -156,7 +156,7 @@ rte_hash_count(const struct rte_hash *h);
> >  *   - -ENOSPC if there is no space in the hash for this key.
> >  */
> > int
> >-rte_hash_add_key_data(const struct rte_hash *h, const void *key, void 
> >*data);
> >+rte_hash_add_key_data(struct rte_hash *h, const void *key, void *data);
> >
> > /**
> >  * Add a key-value pair with a pre-computed hash value
> >@@ -180,7 +180,7 @@ rte_hash_add_key_data(const struct rte_hash *h, const 
> >void *key, void *data);
> >  *   - -ENOSPC if there is no space in the hash for this key.
> >  */
> > int32_t
> >-rte_hash_add_key_with_hash_data(const struct rte_hash *h, const void *key,
> >+rte_hash_add_key_with_hash_data(struct rte_hash *h, const void *key,
> > hash_sig_t sig, void *data);
> >
> > /**
> >@@ -200,7 +200,7 @@ rte_hash_add_key_with_hash_data(const struct rte_hash 
> >*h, const void *key,
> >  * array of user data. This value is unique for this key.
> >  */
> > int32_t
> >-rte_hash_add_key(const struct rte_hash *h, const void *key);
> >+rte_hash_add_key(struct rte_hash *h, const void *key);
> >
> > /**
> >  * Add a key to an existing hash table.
> >@@ -222,7 +222,7 @@ rte_hash_add_key(const struct rte_hash *h, const void 
> >*key);
> >  * array of user data. This value is unique for this key.
> >  */
> > int32_t
> >-rte_hash_add_key_with_hash(const struct rte_hash *h, const void *key, 
> >hash_sig_t sig);
> >+rte_hash_add_key_with_hash(struct rte_hash *h, const void *key, hash_sig_t 
> >sig);
> >
> > /
> 
> I think the above changes will break ABI by changing the parameter type? 
> Other people may know better on this.

Just removing a const should not change the ABI, I believe, since the const
is just advisory hint to the compiler. Actual parameter size and count
remains unchanged so I don't believe there is an issue. 
[ABI experts, please correct me if I'm wrong on this]

/Bruce

Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA

[Ye Xiaolong]

On 09/28, Maxime Coquelin wrote:
>
>
>On 09/28/2018 04:33 PM, Ye Xiaolong wrote:
>> On 09/28, Maxime Coquelin wrote:
>> > > +ret = rte_eal_init(argc, argv);
>> > > +if (ret < 0)
>> > > +rte_exit(EXIT_FAILURE, "eal init failed\n");
>> > > +argc -= ret;
>> > > +argv += ret;
>> > > +
>> > > +data_init();
>> > 
>> > You need to check return from data_init().
>> > If this is fine for you, I can change to below code when applying:
>> > 
>> > ret = data_init();
>> > if (ret < 0)
>> > rte_exit(EXIT_FAILURE, "data init failed\n");
>> > 
>> > 
>> 
>> I'm fine with this change.
>
>Or even better, get rid of data_init and
>call rte_vdpa_get_device_num(); in main directly.

Sounds better, as we've removed unnecessary static variable initialization in  
data_init, it does nothing but call rte_vdpa_get_device_num, we can remove this
wrap. Would you do this change when applying or you perfer I send a new 
revision?

Thanks,
Xiaolong


>
>> Thanks,
>> Xiaolong
>> 

Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA

[Maxime Coquelin]

On 09/28/2018 05:17 PM, Ye Xiaolong wrote:

On 09/28, Maxime Coquelin wrote:



On 09/28/2018 04:33 PM, Ye Xiaolong wrote:

On 09/28, Maxime Coquelin wrote:

+   ret = rte_eal_init(argc, argv);
+   if (ret < 0)
+   rte_exit(EXIT_FAILURE, "eal init failed\n");
+   argc -= ret;
+   argv += ret;
+
+   data_init();


You need to check return from data_init().
If this is fine for you, I can change to below code when applying:

ret = data_init();
if (ret < 0)
 rte_exit(EXIT_FAILURE, "data init failed\n");




I'm fine with this change.


Or even better, get rid of data_init and
call rte_vdpa_get_device_num(); in main directly.


Sounds better, as we've removed unnecessary static variable initialization in
data_init, it does nothing but call rte_vdpa_get_device_num, we can remove this
wrap. Would you do this change when applying or you perfer I send a new
revision?


Please send a new revision, and in the commit message,
fix first letter of my family name with an upper case,
and move my R-b below your sign-off.

Thanks!
Maxime


Thanks,
Xiaolong





Thanks,
Xiaolong

Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

[Ferruh Yigit]

On 9/28/2018 4:43 AM, Xiaoyun Li wrote:
> Some users want to use their own epoll instances to control both
> DPDK rxq interrupt fds and their own other fds. So added a function
> to get rxq interrupt fd based on port id and queue id.
> 
> Signed-off-by: Xiaoyun Li 

<...>

> @@ -2719,6 +2719,9 @@ int rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, 
> int op, void *data);
>  int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
> int epfd, int op, void *data);
>  
> +int rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id,
> +  int *fd);


Hi Xiaoyun,

API is missing documentation, please add doxygen comments.

New APIs need to be experimental, at least for one release.
Also can you please add it to .map file otherwise shared lib build will fail

Re: [dpdk-dev] [PATCH] net/i40e: select fdir config automatically

[Xing, Beilei]

> -Original Message-
> From: Li, Xiaoyun
> Sent: Friday, September 28, 2018 3:25 PM
> To: Yigit, Ferruh ; Zhang, Qi Z
> ; Xing, Beilei ; dev@dpdk.org
> Cc: Li, Xiaoyun 
> Subject: [PATCH] net/i40e: select fdir config automatically
> 
> I40e driver needed users to config exact fdir mode to create rte_flow rules
> but it shouldn't. This patch allows users to create rte_flow rules without
> configuring fdir mode and let the driver select the config automatically.
> 
> Signed-off-by: Xiaoyun Li 
> ---
>  drivers/net/i40e/i40e_flow.c | 33 -
>  1 file changed, 28 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> c67b264de..70ff33ac0 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -3127,6 +3127,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev
> *dev,
>   struct rte_flow_error *error,
>   union i40e_filter_t *filter)
>  {
> + struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data-
> >dev_private);
>   struct i40e_fdir_filter_conf *fdir_filter =
>   &filter->fdir_filter;
>   int ret;
> @@ -3148,14 +3149,29 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev
> *dev,
> 
>   if (dev->data->dev_conf.fdir_conf.mode !=
>   RTE_FDIR_MODE_PERFECT) {
> - rte_flow_error_set(error, ENOTSUP,
> -RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
> -NULL,
> -"Check the mode in fdir_conf.");
> - return -rte_errno;
> + /* Enable fdir when fdir flow is added at first time. */
> + ret = i40e_fdir_setup(pf);
> + if (ret != I40E_SUCCESS) {
> + rte_flow_error_set(error, ENOTSUP,
> +RTE_FLOW_ERROR_TYPE_HANDLE,
> +NULL, "Failed to setup fdir.");
> + return -rte_errno;
> + }
> + ret = i40e_fdir_configure(dev);
> + if (ret < 0) {
> + rte_flow_error_set(error, ENOTSUP,
> +RTE_FLOW_ERROR_TYPE_HANDLE,
> +NULL, "Failed to configure fdir.");
> + goto err;
> + }
> +
> + dev->data->dev_conf.fdir_conf.mode =
> RTE_FDIR_MODE_PERFECT;
>   }
> 
>   return 0;
> +err:
> + i40e_fdir_teardown(pf);
> + return -rte_errno;
>  }
> 
>  /* Parse to get the action info of a tunnel filter @@ -4708,6 +4724,13 @@
> i40e_flow_destroy(struct rte_eth_dev *dev,
>   case RTE_ETH_FILTER_FDIR:
>   ret = i40e_flow_add_del_fdir_filter(dev,
>  &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
> +
> + /* If the last flow is destroyed, disable fdir. */
> + if (!ret && !TAILQ_FIRST(&pf->fdir.fdir_list)) {

How about TAILQ_EMPTY which is more intuitive? 

> + i40e_fdir_teardown(pf);
> + dev->data->dev_conf.fdir_conf.mode =
> +RTE_FDIR_MODE_NONE;
> + }

Do you consider FDIR teardown after FDIR flush?

>   break;
>   case RTE_ETH_FILTER_HASH:
>   ret = i40e_config_rss_filter_del(dev,
> --
> 2.17.1

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

[Van Haaren, Harry]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, September 28, 2018 9:26 AM
> To: Wang, Yipeng1 
> Cc: Honnappa Nagarahalli ; De Lara Guarch,
> Pablo ; dev@dpdk.org; gavin...@arm.com;
> steve.cap...@arm.com; ola.liljed...@arm.com; n...@arm.com
> Subject: Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving
> keys
> 
> On Fri, Sep 28, 2018 at 02:00:00AM +0100, Wang, Yipeng1 wrote:
> > Reply inlined:
> >
> > >-Original Message-
> > >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa Nagarahalli
> > >Sent: Thursday, September 6, 2018 10:12 AM
> > >To: Richardson, Bruce ; De Lara Guarch, Pablo
> 
> > >Cc: dev@dpdk.org; honnappa.nagaraha...@dpdk.org; gavin...@arm.com;
> steve.cap...@arm.com; ola.liljed...@arm.com;
> > >n...@arm.com; Honnappa Nagarahalli 
> > >Subject: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving
> keys
> > >
> > >Reader-writer concurrency issue, caused by moving the keys
> > >to their alternative locations during key insert, is solved
> > >by introducing a global counter(tbl_chng_cnt) indicating a
> > >change in table.



> > > /**
> > >@@ -200,7 +200,7 @@ rte_hash_add_key_with_hash_data(const struct rte_hash
> *h, const void *key,
> > >  * array of user data. This value is unique for this key.
> > >  */
> > > int32_t
> > >-rte_hash_add_key(const struct rte_hash *h, const void *key);
> > >+rte_hash_add_key(struct rte_hash *h, const void *key);
> > >
> > > /**
> > >  * Add a key to an existing hash table.
> > >@@ -222,7 +222,7 @@ rte_hash_add_key(const struct rte_hash *h, const void
> *key);
> > >  * array of user data. This value is unique for this key.
> > >  */
> > > int32_t
> > >-rte_hash_add_key_with_hash(const struct rte_hash *h, const void *key,
> hash_sig_t sig);
> > >+rte_hash_add_key_with_hash(struct rte_hash *h, const void *key,
> hash_sig_t sig);
> > >
> > > /
> >
> > I think the above changes will break ABI by changing the parameter type?
> Other people may know better on this.
> 
> Just removing a const should not change the ABI, I believe, since the const
> is just advisory hint to the compiler. Actual parameter size and count
> remains unchanged so I don't believe there is an issue.
> [ABI experts, please correct me if I'm wrong on this]


[Certainly no ABI expert, but...]

I think this is an API break, not ABI break.

Given application code as follows, it will fail to compile - even though
running the new code as a .so wouldn't cause any issues (AFAIK).

void do_hash_stuff(const struct rte_hash *h, ...)
{
/* parameter passed in is const, but updated function prototype is 
non-const */
rte_hash_add_key_with_hash(h, ...);
}

This means that we can't recompile apps against latest patch without application
code changes, if the app was passing a const rte_hash struct as the first 
parameter.


-Harry

Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

[Li, Xiaoyun]

OK. Thanks.

> -Original Message-
> From: Yigit, Ferruh
> Sent: Friday, September 28, 2018 16:33
> To: Li, Xiaoyun ; tho...@monjalon.net; Zhang, Helin
> ; damar...@cisco.com; Kinsella, Ray
> ; dev@dpdk.org
> Subject: Re: [PATCH] ethdev: get rxq interrupt fd
> 
> On 9/28/2018 4:43 AM, Xiaoyun Li wrote:
> > Some users want to use their own epoll instances to control both DPDK
> > rxq interrupt fds and their own other fds. So added a function to get
> > rxq interrupt fd based on port id and queue id.
> >
> > Signed-off-by: Xiaoyun Li 
> 
> <...>
> 
> > @@ -2719,6 +2719,9 @@ int rte_eth_dev_rx_intr_ctl(uint16_t port_id,
> > int epfd, int op, void *data);  int rte_eth_dev_rx_intr_ctl_q(uint16_t
> port_id, uint16_t queue_id,
> >   int epfd, int op, void *data);
> >
> > +int rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t
> queue_id,
> > +int *fd);
> 
> 
> Hi Xiaoyun,
> 
> API is missing documentation, please add doxygen comments.
> 
> New APIs need to be experimental, at least for one release.
> Also can you please add it to .map file otherwise shared lib build will fail

[dpdk-dev] [Bug 93] crypto vdev create will reset the dev_started flag when one dpdk process has been up the crypto vdev

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=93

Bug ID: 93
   Summary: crypto vdev create will reset the dev_started flag
when one dpdk process has been up the crypto vdev
   Product: DPDK
   Version: 17.05
  Hardware: All
OS: All
Status: CONFIRMED
  Severity: major
  Priority: Normal
 Component: cryptodev
  Assignee: dev@dpdk.org
  Reporter: wenjing.1@nokia-sbell.com
  Target Milestone: ---

when use crypto vdev in one group primary/secondary processes, when one process
up the crypto vdev , if anther dpdk process startup with same dpdk crypto vdev
paramters, that will lead to the up vdev started flag set to 0.

from the code, if we want to use the vdev in secondary process , it must be
create in primary dpdk process first,and the secondary process which want use
the crypto vdev need startup with same dpdk vdev parameters(--vdev).but when
one dpdk process start after the crypto vdev up in one process , the vdev
started flag will reset to 0. this seem not an expected result,this will broke
the active cryptodev using.

test step:

 1: create one crypto vdev in primary dpdk process and then configured
and start the crypto vdev . 
 2: startup secondary dpdk process with same crypto vdev
parameters(crypto vdev will create in rte_eal_init())


expected result: crypto vdev stats normal in first process  
actual result:  crypto vdev dev_started set to 0

same issue with up crypto vdev in one secondary process and startup other
secondary process with same crypto parameters

this issue will result in different dpdk process can configured and start
crypto vdev independently in such scenario, it seem not an expected result. 

from the code we can see 
rte_cryptodev_pmd_allocate {
..

if (cryptodev->data == NULL) {
struct rte_cryptodev_data *cryptodev_data =
cryptodev_globals.data[dev_id];

int retval = rte_cryptodev_data_alloc(dev_id, &cryptodev_data,
socket_id);

cryptodev->data = cryptodev_data;

... 

cryptodev->data->dev_id = dev_id;
cryptodev->data->socket_id = socket_id;
cryptodev->data->dev_started = 0;  

cryptodev->attached = RTE_CRYPTODEV_ATTACHED;

cryptodev_globals.nb_devs++;
}

}

in this function "cryptodev->data->dev_started = 0;" will executed in all dpdk
process which config with same dpdk crypto vdev, it's better add some condition
to set to zero, such as if the dev_started set to 1,dev_started not set here.


would you please help to check and fixed it?


thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

[Ferruh Yigit]

On 8/24/2018 3:05 PM, Chas Williams wrote:
> 
> 
> On Fri, Aug 24, 2018 at 6:39 AM Ferruh Yigit  > wrote:
> 
> On 8/23/2018 4:21 PM, Chas Williams wrote:
> >
> >
> > On Thu, Aug 23, 2018 at 9:15 AM Ferruh Yigit  
> > >> wrote:
> >
> >     On 8/6/2018 4:50 PM, Chas Williams wrote:
> >     > On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon 
>  
> >     >> wrote:
> >     >
> >     >> 02/08/2018 15:38, Doherty, Declan:
> >     >>> On 01/08/2018 2:18 PM, Radu Nicolau wrote:
> >      When a bonding port is stopped also stop and deactivate all 
> slaves.
> >      Otherwise slaves will be still listed as active.
> >     
> >      Fixes: 69bce062132b ("net/bonding: do not clear active slave 
> count")
> >      Cc: sta...@dpdk.org 
> >
> >     
> >      Signed-off-by: Radu Nicolau  
> >     >>
> >     >>>
> >     >>> Acked-by: Declan Doherty  
> >     >>
> >     >>
> >     >> Waiting for opinion from the other bonding maintainer (Chas)
> >     >> who started to review and has some doubts.
> >     >>
> >     >
> >     > The slaves being listed as active is not a bug.  If the slaves 
> are not
> >     > deactivated, then they should be considered activated.  
> Previously,
> >     > stopping the bonding PMD just reset the active slave count.  
> That's
> >     > not the right way to deactivate slaves.  This was fixed by 
> 69bce062132b.
> >     >
> >     > This patch is new behavior of explicitly deactivating the slaves 
> when
> >     > the bonding PMD is stopped.
> >     >
> >     > As I mentioned, I think this makes life difficult for those of us 
> using
> >     > an external state machine.  However, that should probably be fixed
> >     > differently then.
> >     >
> >     >
> >     >>
> >     >> Chas, please do you agree with Declan's ack?
> >     >>
> >     >>
> >     >>
> >     > Change the Fixes line.
> >
> >     Hi Chas,
> >
> >     Are you OK with the rest of the patch if Fixes line fixed?
> >     If already have a proposed fixes line I can fix it while merging.
> >
> >
> > Yes, the rest of the patch is fine as long as the Fixes is correct.
> > Try this:
> >
> >     Fixes: 2efb58cbab6e ("bond: new link bonding library")
> >
> > And it's really new behavior.  Perhaps Fixes: isn't quite right.
> > The current code works fine with activated slaves existing outside
> > of the stop/star.
> 
> From your description dropping Fixes line seems OK, but it will effect if 
> the
> patch backported or not.
> 
> 
> Then dont' drop the Fixes line.  See below.
>  
> 
> Isn't it clear from bonding requirement what should slave ports' status 
> be when
> bonding port it stopped?
> 
> 
> I am guessing the author's original intent was to deactivate all the
> slaves because he reset the activate slave count to 0.  However, that
> didn't actually deactivate a slave and later activating an already
> active slave after another start would result in some odd failures.

Yes, intention seems as you said, there is an unit test that expects active
slave count to be 0 after bond port stopped.
Your change to remove setting active slave count to zero on bond stop causes
that test fail.
To fix the unit test, all slaves stopped and deactivated.

I think it is still clear if that expectation from unit test coming from bonding
requirement and development assumption. But will get the patch, with updated
fixes line, to fix the unit test.

> 
> In a more existential sense, what does active mean?  In the case of
> 802.3ad, a slave is potentially active until the protocol says otherwise
> which means a timeout.  So the stopped/started aspect of the port
> isn't necessarily a concern.  If you are just briefly stopping a
> port to reconfigure, perhaps you don't want to renegotiate the
> 802.3ad state.  Of course, if you reconfigure a port, there is a
> good chance you want to renegotiate with the other end anyway.
> 
> TL;DR -- fine with this patch.  Add new Fixes line so backported.
> 
> 
> 
> 

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

[Ferruh Yigit]

On 9/28/2018 11:00 AM, Ferruh Yigit wrote:
> On 8/24/2018 3:05 PM, Chas Williams wrote:
>>
>>
>> On Fri, Aug 24, 2018 at 6:39 AM Ferruh Yigit > > wrote:
>>
>> On 8/23/2018 4:21 PM, Chas Williams wrote:
>> >
>> >
>> > On Thu, Aug 23, 2018 at 9:15 AM Ferruh Yigit > 
>> > >> wrote:
>> >
>> >     On 8/6/2018 4:50 PM, Chas Williams wrote:
>> >     > On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon 
>> > 
>> >     >> wrote:
>> >     >
>> >     >> 02/08/2018 15:38, Doherty, Declan:
>> >     >>> On 01/08/2018 2:18 PM, Radu Nicolau wrote:
>> >      When a bonding port is stopped also stop and deactivate all 
>> slaves.
>> >      Otherwise slaves will be still listed as active.
>> >     
>> >      Fixes: 69bce062132b ("net/bonding: do not clear active slave 
>> count")
>> >      Cc: sta...@dpdk.org 
>> >
>> >     
>> >      Signed-off-by: Radu Nicolau > 
>> >     >>
>> >     >>>
>> >     >>> Acked-by: Declan Doherty > 
>> >     > >>
>> >     >>
>> >     >> Waiting for opinion from the other bonding maintainer (Chas)
>> >     >> who started to review and has some doubts.
>> >     >>
>> >     >
>> >     > The slaves being listed as active is not a bug.  If the slaves 
>> are not
>> >     > deactivated, then they should be considered activated.  
>> Previously,
>> >     > stopping the bonding PMD just reset the active slave count.  
>> That's
>> >     > not the right way to deactivate slaves.  This was fixed by 
>> 69bce062132b.
>> >     >
>> >     > This patch is new behavior of explicitly deactivating the slaves 
>> when
>> >     > the bonding PMD is stopped.
>> >     >
>> >     > As I mentioned, I think this makes life difficult for those of 
>> us using
>> >     > an external state machine.  However, that should probably be 
>> fixed
>> >     > differently then.
>> >     >
>> >     >
>> >     >>
>> >     >> Chas, please do you agree with Declan's ack?
>> >     >>
>> >     >>
>> >     >>
>> >     > Change the Fixes line.
>> >
>> >     Hi Chas,
>> >
>> >     Are you OK with the rest of the patch if Fixes line fixed?
>> >     If already have a proposed fixes line I can fix it while merging.
>> >
>> >
>> > Yes, the rest of the patch is fine as long as the Fixes is correct.
>> > Try this:
>> >
>> >     Fixes: 2efb58cbab6e ("bond: new link bonding library")
>> >
>> > And it's really new behavior.  Perhaps Fixes: isn't quite right.
>> > The current code works fine with activated slaves existing outside
>> > of the stop/star.
>>
>> From your description dropping Fixes line seems OK, but it will effect 
>> if the
>> patch backported or not.
>>
>>
>> Then dont' drop the Fixes line.  See below.
>>  
>>
>> Isn't it clear from bonding requirement what should slave ports' status 
>> be when
>> bonding port it stopped?
>>
>>
>> I am guessing the author's original intent was to deactivate all the
>> slaves because he reset the activate slave count to 0.  However, that
>> didn't actually deactivate a slave and later activating an already
>> active slave after another start would result in some odd failures.
> 
> Yes, intention seems as you said, there is an unit test that expects active
> slave count to be 0 after bond port stopped.
> Your change to remove setting active slave count to zero on bond stop causes
> that test fail.
> To fix the unit test, all slaves stopped and deactivated.
> 
> I think it is still clear if that expectation from unit test coming from 
> bonding
> requirement and development assumption. But will get the patch, with updated
> fixes line, to fix the unit test.

it is still _not_ clear ...

bonding requirement _or_ development assumption. ...

> 
>>
>> In a more existential sense, what does active mean?  In the case of
>> 802.3ad, a slave is potentially active until the protocol says otherwise
>> which means a timeout.  So the stopped/started aspect of the port
>> isn't necessarily a concern.  If you are just briefly stopping a
>> port to reconfigure, perhaps you don't want to renegotiate the
>> 802.3ad state.  Of course, if you reconfigure a port, there is a
>> good chance you want to renegotiate with the other end anyway.
>>
>> TL;DR -- fine with this patch.  Add new Fixes line so backported.
>>
>>
>>
>>
> 

Re: [dpdk-dev] [PATCH v4 1/5] eventdev: add eth Tx adapter APIs

[Jerin Jacob]

-Original Message-
> Date: Thu, 20 Sep 2018 23:11:12 +0530
> From: Nikhil Rao 
> To: jerin.ja...@caviumnetworks.com, olivier.m...@6wind.com,
>  marko.kovace...@intel.com, john.mcnam...@intel.com
> CC: dev@dpdk.org, Nikhil Rao 
> Subject: [PATCH v4 1/5] eventdev: add eth Tx adapter APIs
> X-Mailer: git-send-email 1.8.3.1
> 
> 
> The ethernet Tx adapter abstracts the transmit stage of an
> event driven packet processing application. The transmit
> stage may be implemented with eventdev PMD support or use a
> rte_service function implemented in the adapter. These APIs
> provide a common configuration and control interface and
> an transmit API for the eventdev PMD implementation.
> 
> The transmit port is specified using mbuf::port. The transmit
> queue is specified using the rte_event_eth_tx_adapter_txq_set()
> function.
> 
> Signed-off-by: Nikhil Rao 
> Acked-by: Jerin Jacob 

Applied this series to dpdk-next-eventdev/master with following minor
documentation change. Thanks.

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index b47a5c50e..a09377a60 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -532,7 +532,9 @@ struct rte_mbuf {
struct {
uint32_t lo;
uint32_t hi;
-   /**< @see rte_event_eth_tx_adapter_txq_set */
+   /**< The event eth Tx adapter uses this field to store
+* Tx queue id. @see rte_event_eth_tx_adapter_txq_set()
+*/

[dpdk-dev] [PATCH v2] ethdev: get rxq interrupt fd

[Xiaoyun Li]

Some users want to use their own epoll instances to control both
DPDK rxq interrupt fds and their own other fds. So added a function
to get rxq interrupt fd based on port id and queue id.

Signed-off-by: Xiaoyun Li 
---
v2:
 * Added missing API doxygen comments.
 * Set the new API to be experimental and added it in .map file.
---
 lib/librte_ethdev/rte_ethdev.c   | 37 
 lib/librte_ethdev/rte_ethdev.h   | 22 ++
 lib/librte_ethdev/rte_ethdev_version.map |  1 +
 3 files changed, 60 insertions(+)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index ef99f7068..7c580ec68 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -3433,6 +3433,43 @@ rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, int 
op, void *data)
return 0;
 }
 
+int __rte_experimental
+rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id,
+int *fd)
+{
+   struct rte_intr_handle *intr_handle;
+   struct rte_eth_dev *dev;
+   unsigned int efd_idx;
+   uint32_t vec;
+
+   RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+   dev = &rte_eth_devices[port_id];
+
+   if (queue_id >= dev->data->nb_rx_queues) {
+   RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", queue_id);
+   return -EINVAL;
+   }
+
+   if (!dev->intr_handle) {
+   RTE_ETHDEV_LOG(ERR, "RX Intr handle unset\n");
+   return -ENOTSUP;
+   }
+
+   intr_handle = dev->intr_handle;
+   if (!intr_handle->intr_vec) {
+   RTE_ETHDEV_LOG(ERR, "RX Intr vector unset\n");
+   return -EPERM;
+   }
+
+   vec = intr_handle->intr_vec[queue_id];
+   efd_idx = (vec >= RTE_INTR_VEC_RXTX_OFFSET) ?
+   (vec - RTE_INTR_VEC_RXTX_OFFSET) : vec;
+   *fd = intr_handle->efds[efd_idx];
+
+   return 0;
+}
+
 const struct rte_memzone *
 rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,
 uint16_t queue_id, size_t size, unsigned align,
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 012577b0a..8f6a5d08b 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -2719,6 +2719,28 @@ int rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, 
int op, void *data);
 int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
  int epfd, int op, void *data);
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * Get interrupt fd per Rx queue.
+ *
+ * @param port_id
+ *   The port identifier of the Ethernet device.
+ * @param queue_id
+ *   The index of the receive queue from which to retrieve input packets.
+ *   The value must be in the range [0, nb_rx_queue - 1] previously supplied
+ *   to rte_eth_dev_configure().
+ * @param fd
+ *   The interrupt fd which the requested Rx queue associated to.
+ * @return
+ *   - On success, zero.
+ *   - On failure, a negative value.
+ */
+int __rte_experimental
+rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id,
+int *fd);
+
 /**
  * Turn on the LED on the Ethernet device.
  * This function turns on the LED on the Ethernet device.
diff --git a/lib/librte_ethdev/rte_ethdev_version.map 
b/lib/librte_ethdev/rte_ethdev_version.map
index 38f117f01..c98f9fa4a 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -235,6 +235,7 @@ EXPERIMENTAL {
rte_eth_dev_owner_new;
rte_eth_dev_owner_set;
rte_eth_dev_owner_unset;
+   rte_eth_dev_rx_intr_ctl_q_get_fd;
rte_eth_dev_rx_offload_name;
rte_eth_dev_tx_offload_name;
rte_eth_switch_domain_alloc;
-- 
2.17.1

Re: [dpdk-dev] [PATCH v4 3/4] net/enetc: support packet parse type

[Shreyansh Jain]

On Friday 28 September 2018 01:16 PM, Gagandeep Singh wrote:

Signed-off-by: Gagandeep Singh 
---
  drivers/net/enetc/enetc_ethdev.c | 19 +++
  1 file changed, 19 insertions(+)



Commit message is missing in this patch.

Re: [dpdk-dev] [PATCH v2] crypto/openssl: support truncated HMAC operations

[Akhil Goyal]

On 9/28/2018 3:02 AM, Dmitry Eremin-Solenikov wrote:

On 25/09/18 17:46, Akhil Goyal wrote:


On 9/16/2018 8:48 AM, Dmitry Eremin-Solenikov wrote:

IPsec requires truncated HMAC operations support. Extend OpenSSL crypto
PMD to support truncated HMAC operations necessary for IPsec.

Signed-off-by: Dmitry Eremin-Solenikov

---
Changes since V1:
   - support all digest sizes from half of corresponding digest size up to
     full length.

Why can't we extend this to digest size starting from 1 to full length?
Why is there a limitation for half of corresponding digest size?

Mainly because there is little point in supporting such truncated
digests. It won't be cryptographically safe.
I believe we shall let the application decide the digest size and not 
make this a limitation of PMD.



---
   drivers/crypto/openssl/rte_openssl_pmd.c | 19 
   drivers/crypto/openssl/rte_openssl_pmd_ops.c | 24 ++--
   2 files changed, 22 insertions(+), 21 deletions(-)

diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
b/drivers/crypto/openssl/rte_openssl_pmd.c
index 7d263aba3bbd..c635f1e2493c 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1509,15 +1509,7 @@ process_openssl_auth_op(struct openssl_qp *qp,
struct rte_crypto_op *op,
     srclen = op->sym->auth.data.length;
   -    if (sess->auth.operation == RTE_CRYPTO_AUTH_OP_VERIFY)
-    dst = qp->temp_digest;
-    else {
-    dst = op->sym->auth.digest.data;
-    if (dst == NULL)
-    dst = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
-    op->sym->auth.data.offset +
-    op->sym->auth.data.length);
-    }
+    dst = qp->temp_digest;
     switch (sess->auth.mode) {
   case OPENSSL_AUTH_AS_AUTH:
@@ -1540,6 +1532,15 @@ process_openssl_auth_op(struct openssl_qp *qp,
struct rte_crypto_op *op,
   sess->auth.digest_length) != 0) {
   op->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;
   }
+    } else {
+    uint8_t *auth_dst;
+
+    auth_dst = op->sym->auth.digest.data;
+    if (auth_dst == NULL)
+    auth_dst = rte_pktmbuf_mtod_offset(mbuf_dst, uint8_t *,
+    op->sym->auth.data.offset +
+    op->sym->auth.data.length);
+    memcpy(auth_dst, dst, sess->auth.digest_length);
   }
     if (status != 0)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index de2284390b12..6d3e21de404d 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
@@ -26,9 +26,9 @@ static const struct rte_cryptodev_capabilities
openssl_pmd_capabilities[] = {
   .increment = 1
   },
   .digest_size = {
-    .min = 16,
+    .min = 8,
   .max = 16,
-    .increment = 0
+    .increment = 1
   },
   .iv_size = { 0 }
   }, }
@@ -68,9 +68,9 @@ static const struct rte_cryptodev_capabilities
openssl_pmd_capabilities[] = {
   .increment = 1
   },
   .digest_size = {
-    .min = 20,
+    .min = 10,
   .max = 20,
-    .increment = 0
+    .increment = 1
   },
   .iv_size = { 0 }
   }, }
@@ -110,9 +110,9 @@ static const struct rte_cryptodev_capabilities
openssl_pmd_capabilities[] = {
   .increment = 1
   },
   .digest_size = {
-    .min = 28,
+    .min = 14,
   .max = 28,
-    .increment = 0
+    .increment = 1
   },
   .iv_size = { 0 }
   }, }
@@ -152,9 +152,9 @@ static const struct rte_cryptodev_capabilities
openssl_pmd_capabilities[] = {
   .increment = 1
   },
   .digest_size = {
-    .min = 32,
+    .min = 16,
   .max = 32,
-    .increment = 0
+    .increment = 1
   },
   .iv_size = { 0 }
   }, }
@@ -194,9 +194,9 @@ static const struct rte_cryptodev_capabilities
openssl_pmd_capabilities[] = {
   .increment = 1
   },
   .digest_size = {
-    .min = 48,
+    .min = 24,
   .max = 48,
-    .increment = 0
+    .increment = 1
   },
   .iv_size = { 0 }
   }, }
@@ -236,9 +236,9 @@ static const struct rte_cryptodev_capabilities
openssl_pmd_capabilities[] = {
   .incre

Re: [dpdk-dev] [PATCH 2/2] examples/ip_pipeline: add vxlan encap

[Dumitrescu, Cristian]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Friday, September 7, 2018 4:59 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] examples/ip_pipeline: add vxlan encap
> 
> Add CLI support for VXLAN encap.
> 
> Signed-off-by: Cristian Dumitrescu 
> ---
>  examples/ip_pipeline/cli.c | 181
> -
>  1 file changed, 177 insertions(+), 4 deletions(-)
> 

Applied on next-pipeline tree.

Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_table: add hash func header files

[Dumitrescu, Cristian]

> -Original Message-
> From: Laatz, Kevin
> Sent: Tuesday, September 25, 2018 4:32 PM
> To: dev@dpdk.org
> Cc: jianbo@arm.com; gavin...@arm.com;
> jerin.ja...@caviumnetworks.com; Dumitrescu, Cristian
> ; Laatz, Kevin 
> Subject: [PATCH v4 1/3] lib/librte_table: add hash func header files
> 
> This commit adds rte_table_hash_func.h and rte_table_hash_func_arm64.h
> to
> librte_table. This reduces code duplication by removing duplicate header
> files within two folders and consolidating them into a single one. This
> also adds a scalar implementation of the x86_64 intrinsic for crc32 as a
> generic fallback.
> 
> Signed-off-by: Cristian Dumitrescu 
> Signed-off-by: Kevin Laatz 
> Acked-by: Gavin Hu 
> ---

Patchset applied to next-pipeline tree, thanks!

Re: [dpdk-dev] [PATCH v2 00/15] add flow API support to softnic

[Dumitrescu, Cristian]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Reshma Pattan
> Sent: Tuesday, September 11, 2018 3:21 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 00/15] add flow API support to softnic
> 
> This patch series adds the flow API support
> for the softnic.
> 
> This patch set also introduce a new cli command
> to provide mapping of flow group and direction
> to softnic pipeline and table.
> 
> v2: added missing code to patch #9/10
> reworded commit titles.
> 
> Reshma Pattan (15):
>   net/softnic: add infrastructure for flow API
>   net/softnic: map flow attributes to pipeline table
>   net/softnic: add new cli for flow attribute map
>   net/softnic: replace some pointers with arrays
>   net/softnic: add free table and find out port functions
>   net/softnic: add function to get eth device from softnic
>   net/softnic: implement flow validate API
>   net/softnic: validate and map flow rule with acl table match
>   net/softnic: parse flow protocol for acl table match
>   net/softnic: validate and map flow with hash table match
>   net/softnic: validate and map flow action with table action
>   net/softnic: add flow create API
>   net/softnic: add flow destroy API
>   net/softnic: add flow query API
>   net/softnic: add parsing for raw flow item
> 
>  drivers/net/softnic/Makefile|1 +
>  drivers/net/softnic/meson.build |1 +
>  drivers/net/softnic/rte_eth_softnic.c   |   16 +
>  drivers/net/softnic/rte_eth_softnic_cli.c   |  115 +-
>  drivers/net/softnic/rte_eth_softnic_flow.c  | 1824
> +++
>  drivers/net/softnic/rte_eth_softnic_internals.h |   98 +-
>  drivers/net/softnic/rte_eth_softnic_pipeline.c  |   61 +-
>  7 files changed, 2086 insertions(+), 30 deletions(-)
>  create mode 100644 drivers/net/softnic/rte_eth_softnic_flow.c
> 
> --
> 2.14.4

Series applied to next-pipeline tree, thanks!

Re: [dpdk-dev] [PATCH v2 2/2] test/event: add adapter tests to meson build

[Jerin Jacob]

-Original Message-
> Date: Thu, 27 Sep 2018 12:09:24 +0100
> From: Bruce Richardson 
> To: Nikhil Rao 
> CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, dev@dpdk.org,
>  Abhinandan Gujjar , "Erik G. Carrillo"
>  
> Subject: Re: [PATCH v2 2/2] test/event: add adapter tests to meson build
> User-Agent: Mutt/1.10.1 (2018-07-13)
> 
> 
> On Thu, Sep 27, 2018 at 11:16:15AM +0530, Nikhil Rao wrote:
> > Add tests for event eth Rx, crypto and timer adapters to
> > meson build
> >
> > Cc: Abhinandan Gujjar 
> > Cc: Erik G. Carrillo 
> >
> > Signed-off-by: Nikhil Rao 
> > ---
> Acked-by: Bruce Richardson 

Applied to dpdk-next-eventdev/master. Thanks.


> 

Re: [dpdk-dev] [PATCH v4 0/4] introduces the enetc PMD driver

[Shreyansh Jain]

On Friday 28 September 2018 01:15 PM, Gagandeep Singh wrote:

*ENETC* PMD driver which integrates with the existing PCI bus.
Document is also part of the set

v3->v4 Change-log:
* fixed patch set

v2->v3 Change-log:
* Added a release note
* commom part of documentation is removed
* cflag Werror added in Makefile
* private list of RX/TX queues removed
* added the dev_start and dev_stop APIs
* added rx/tx queue release APIs
* packet parse type feature enabled

v1->v2 Change-log:
* document improvement
* checkpatch warnings removed

Gagandeep Singh (4):
   net/enetc: add ENETC PMD with basic operations
   net/enetc: enable Rx and Tx
   net/enetc: support packet parse type
   doc: add usage doc for ENETC PMD



Please feel free to use my ACK in the next version of this series (which 
you would have to send for 3rd/4 patch which doesn't have a commit message).


Acked-by: Shreyansh Jain 

Re: [dpdk-dev] [PATCH v2 1/2] test: fix event timer compiler warning

[Jerin Jacob]

-Original Message-
> Date: Thu, 27 Sep 2018 12:08:56 +0100
> From: Bruce Richardson 
> To: Nikhil Rao 
> CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, dev@dpdk.org,
>  erik.g.carri...@intel.com, sta...@dpdk.org
> Subject: Re: [PATCH v2 1/2] test: fix event timer compiler warning
> User-Agent: Mutt/1.10.1 (2018-07-13)
> 
> 
> On Thu, Sep 27, 2018 at 11:16:14AM +0530, Nikhil Rao wrote:
> > Limit the number of objects passed to rte_mempool_put_bulk()
> > to the size of the object table. This fix eliminates a compiler
> > warning (array-bounds) triggered when the march command line
> > parameter to gcc is set to nehalem.
> >
> > Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")
> > Cc: erik.g.carri...@intel.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Nikhil Rao 
> > ---
> Acked-by: Bruce Richardson 

Applied to dpdk-next-eventdev/master. Thanks.

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

[Ilya Maximets]

On 27.09.2018 11:28, Ilya Maximets wrote:
> On 26.09.2018 10:26, Maxime Coquelin wrote:
>> This patch opens a userfaultfd and sends it back to Qemu's
>> VHOST_USER_POSTCOPY_ADVISE request.
>>
>> Signed-off-by: Dr. David Alan Gilbert 
>> Signed-off-by: Maxime Coquelin 
>> ---
>>  lib/librte_vhost/vhost.h  |  2 ++
>>  lib/librte_vhost/vhost_user.c | 37 +++
>>  lib/librte_vhost/vhost_user.h |  3 ++-
>>  3 files changed, 41 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
>> index 25ffd7614..21722d8a8 100644
>> --- a/lib/librte_vhost/vhost.h
>> +++ b/lib/librte_vhost/vhost.h
>> @@ -363,6 +363,8 @@ struct virtio_net {
>>  int slave_req_fd;
>>  rte_spinlock_t  slave_req_lock;
>>  
>> +int postcopy_ufd;
>> +
>>  /*
>>   * Device id to identify a specific backend device.
>>   * It's set to -1 for the default software implementation.
>> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
>> index a9b429598..bdfe2cac0 100644
>> --- a/lib/librte_vhost/vhost_user.c
>> +++ b/lib/librte_vhost/vhost_user.c
>> @@ -24,9 +24,13 @@
>>  #include 
>>  #include 
>>  #include 
>> +#include 
>> +#include 
> 
> Maybe we need compile time check for this header existence?
> Otherwise, this will bump minimal kernel version for default linux build
> to something like 4.3.

We'll need a config option here (disabled by default) and guard all
the postcopy related code.
Meson build will be able to detect the header file and enable
the config if possible. Like this:

lib/librte_vhost/meson.build:
if cc.has_header('linux/userfaultfd.h')
   dpdk_conf.set10('RTE_LIBRTE_VHOST_POSTCOPY', true)
endif

Best regards, Ilya Maximets.

Re: [dpdk-dev] [PATCH] net/i40e: select fdir config automatically

[Li, Xiaoyun]

Will correct it in v2. Thanks.

> -Original Message-
> From: Xing, Beilei
> Sent: Friday, September 28, 2018 16:40
> To: Li, Xiaoyun ; Yigit, Ferruh
> ; Zhang, Qi Z ;
> dev@dpdk.org
> Subject: RE: [PATCH] net/i40e: select fdir config automatically
> 
> 
> 
> > -Original Message-
> > From: Li, Xiaoyun
> > Sent: Friday, September 28, 2018 3:25 PM
> > To: Yigit, Ferruh ; Zhang, Qi Z
> > ; Xing, Beilei ;
> > dev@dpdk.org
> > Cc: Li, Xiaoyun 
> > Subject: [PATCH] net/i40e: select fdir config automatically
> >
> > I40e driver needed users to config exact fdir mode to create rte_flow
> > rules but it shouldn't. This patch allows users to create rte_flow
> > rules without configuring fdir mode and let the driver select the config
> automatically.
> >
> > Signed-off-by: Xiaoyun Li 
> > ---
> >  drivers/net/i40e/i40e_flow.c | 33 -
> >  1 file changed, 28 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index
> > c67b264de..70ff33ac0 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -3127,6 +3127,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev
> > *dev,
> > struct rte_flow_error *error,
> > union i40e_filter_t *filter)
> >  {
> > +   struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data-
> > >dev_private);
> > struct i40e_fdir_filter_conf *fdir_filter =
> > &filter->fdir_filter;
> > int ret;
> > @@ -3148,14 +3149,29 @@ i40e_flow_parse_fdir_filter(struct
> rte_eth_dev
> > *dev,
> >
> > if (dev->data->dev_conf.fdir_conf.mode !=
> > RTE_FDIR_MODE_PERFECT) {
> > -   rte_flow_error_set(error, ENOTSUP,
> > -  RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
> > -  NULL,
> > -  "Check the mode in fdir_conf.");
> > -   return -rte_errno;
> > +   /* Enable fdir when fdir flow is added at first time. */
> > +   ret = i40e_fdir_setup(pf);
> > +   if (ret != I40E_SUCCESS) {
> > +   rte_flow_error_set(error, ENOTSUP,
> > +  RTE_FLOW_ERROR_TYPE_HANDLE,
> > +  NULL, "Failed to setup fdir.");
> > +   return -rte_errno;
> > +   }
> > +   ret = i40e_fdir_configure(dev);
> > +   if (ret < 0) {
> > +   rte_flow_error_set(error, ENOTSUP,
> > +  RTE_FLOW_ERROR_TYPE_HANDLE,
> > +  NULL, "Failed to configure fdir.");
> > +   goto err;
> > +   }
> > +
> > +   dev->data->dev_conf.fdir_conf.mode =
> > RTE_FDIR_MODE_PERFECT;
> > }
> >
> > return 0;
> > +err:
> > +   i40e_fdir_teardown(pf);
> > +   return -rte_errno;
> >  }
> >
> >  /* Parse to get the action info of a tunnel filter @@ -4708,6
> > +4724,13 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
> > case RTE_ETH_FILTER_FDIR:
> > ret = i40e_flow_add_del_fdir_filter(dev,
> >&((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
> > +
> > +   /* If the last flow is destroyed, disable fdir. */
> > +   if (!ret && !TAILQ_FIRST(&pf->fdir.fdir_list)) {
> 
> How about TAILQ_EMPTY which is more intuitive?
> 
> > +   i40e_fdir_teardown(pf);
> > +   dev->data->dev_conf.fdir_conf.mode =
> > +  RTE_FDIR_MODE_NONE;
> > +   }
> 
> Do you consider FDIR teardown after FDIR flush?
> 
> > break;
> > case RTE_ETH_FILTER_HASH:
> > ret = i40e_config_rss_filter_del(dev,
> > --
> > 2.17.1

Re: [dpdk-dev] [PATCH v5 00/10] net/softnic: implement metering and policing API

[Dumitrescu, Cristian]

> -Original Message-
> From: Singh, Jasvinder
> Sent: Wednesday, September 26, 2018 2:09 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian 
> Subject: [PATCH v5 00/10] net/softnic: implement metering and policing API
> 
> This series is prepared on top of following patchset;
> https://mails.dpdk.org/archives/dev/2018-September/111379.html
> 
> v5 changes
> - fix wrong parameter in memcpy for table meter profile update
> 
> v4 changes
> - introduce the table meter profile check in softnic pipeline table meter
>   profile add function (rte_eth_softnic_thread.c)
> - change the table action check function to more generic form
>   softnic_table_is_action_enabled() (rte_eth_softnic_flow.c)
> 
> v3 changes:
> - update pipeline table with meter profiles
> - update pipeline table with dscp table entry update
> 
> v2 changes:
> - fix copyright year for rte_eth_softnic_meter.c
> - Place all checks in a separate functions while creating meter object
> - Use softnic_pipeline_table_mtr_profile_add() api to add meter profile
>   instead of implementing new function
> - Use stats type indicator to determine the stats_mask for meter stats read
> 

Series applied to next-pipeline tree, thanks!

Re: [dpdk-dev] [PATCH v8 1/4] lib/librte_power: traffic pattern aware power control

[Hunt, David]

Hi Liang,


On 17/9/2018 2:30 PM, Liang Ma wrote:

1. Abstract

For packet processing workloads such as DPDK polling is continuous.
This means CPU cores always show 100% busy independent of how much work
those cores are doing. It is critical to accurately determine how busy
a core is hugely important for the following reasons:

* No indication of overload conditions

* User do not know how much real load is on a system meaning resulted in
  wasted energy as no power management is utilized

Compared to the original l3fwd-power design, instead of going to sleep
after detecting an empty poll, the new mechanism just lowers the core
frequency. As a result, the application does not stop polling the device,
which leads to improved handling of bursts of traffic.

When the system become busy, the empty poll mechanism can also increase the
core frequency (including turbo) to do best effort for intensive traffic.
This gives us more flexible and balanced traffic awareness over the
standard l3fwd-power application.

2. Proposed solution

The proposed solution focuses on how many times empty polls are executed.
The less the number of empty polls, means current core is busy with
processing workload, therefore, the higher frequency is needed. The high
empty poll number indicates the current core not doing any real work
therefore, we can lower the frequency to safe power.

In the current implementation, each core has 1 empty-poll counter which
assume 1 core is dedicated to 1 queue. This will need to be expanded in the
future to support multiple queues per core.

2.1 Power state definition:

LOW:  Not currently used, reserved for future use.

MED:  the frequency is used to process modest traffic workload.

HIGH: the frequency is used to process busy traffic workload.

2.2 There are two phases to establish the power management system:

a.Initialization/Training phase. The training phase is necessary
  in order to figure out the system polling baseline numbers from
  idle to busy. The highest poll count will be during idle, where
  all polls are empty. These poll counts will be different between
  systems due to the many possible processor micro-arch, cache
  and device configurations, hence the training phase.
  In the training phase, traffic is blocked so the training
  algorithm can average the empty-poll numbers for the LOW, MED and
  HIGH  power states in order to create a baseline.
  The core's counter are collected every 10ms, and the Training
  phase will take 2 seconds.
  Training is disabled as default configuration. the default
  parameter is applied. Simple App still can trigger training


Typo: "Simple" should be "Sample"

Suggest adding: Once the training phase has been executed once on a 
system, the application
can then be started with the relevant thresholds provided on the command 
line, allowing the

application to start passing start traffic immediately.


  if that's needed.

b.Normal phase. When the training phase is complete, traffic is
  started. The run-time poll counts are compared with the
  baseline and the decision will be taken to move to MED power
  state or HIGH power state. The counters are calculated every 10ms.


Propose changing the first sentence:  Traffic starts immediately based 
on the default
thresholds, or based on the user supplied thresholds via the command 
line parameters.






3. Proposed  API

1.  rte_power_empty_poll_stat_init(struct ep_params **eptr,
uint8_t *freq_tlb, struct ep_policy *policy);
which is used to initialize the power management system.
  
2.  rte_power_empty_poll_stat_free(void);

which is used to free the resource hold by power management system.
  
3.  rte_power_empty_poll_stat_update(unsigned int lcore_id);

which is used to update specific core empty poll counter, not thread safe
  
4.  rte_power_poll_stat_update(unsigned int lcore_id, uint8_t nb_pkt);

which is used to update specific core valid poll counter, not thread safe
  
5.  rte_power_empty_poll_stat_fetch(unsigned int lcore_id);

which is used to get specific core empty poll counter.
  
6.  rte_power_poll_stat_fetch(unsigned int lcore_id);

which is used to get specific core valid poll counter.

7.  rte_empty_poll_detection(struct rte_timer *tim, void *arg);
which is used to detect empty poll state changes then take action.

ChangeLog:
v2: fix some coding style issues.
v3: rename the filename, API name.
v4: no change.
v5: no change.
v6: re-work the code layout, update API.
v7: fix minor typo and lift node num limit.
v8: disable training as default option.

Signed-off-by: Liang Ma 

Reviewed-by: Lei Yao 
---
  lib/librte_power/Makefile   |   6 +-
  lib/librte_power/meson.build|   5 +-
  lib/librte_power/rte_power_empty_poll.c | 539 
  lib/librte_powe

Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA

[Ye Xiaolong]

On 09/28, Maxime Coquelin wrote:
>
>
>On 09/28/2018 05:17 PM, Ye Xiaolong wrote:
>> On 09/28, Maxime Coquelin wrote:
>> > 
>> > 
>> > On 09/28/2018 04:33 PM, Ye Xiaolong wrote:
>> > > On 09/28, Maxime Coquelin wrote:
>> > > > > +ret = rte_eal_init(argc, argv);
>> > > > > +if (ret < 0)
>> > > > > +rte_exit(EXIT_FAILURE, "eal init failed\n");
>> > > > > +argc -= ret;
>> > > > > +argv += ret;
>> > > > > +
>> > > > > +data_init();
>> > > > 
>> > > > You need to check return from data_init().
>> > > > If this is fine for you, I can change to below code when applying:
>> > > > 
>> > > > ret = data_init();
>> > > > if (ret < 0)
>> > > >  rte_exit(EXIT_FAILURE, "data init failed\n");
>> > > > 
>> > > > 
>> > > 
>> > > I'm fine with this change.
>> > 
>> > Or even better, get rid of data_init and
>> > call rte_vdpa_get_device_num(); in main directly.
>> 
>> Sounds better, as we've removed unnecessary static variable initialization in
>> data_init, it does nothing but call rte_vdpa_get_device_num, we can remove 
>> this
>> wrap. Would you do this change when applying or you perfer I send a new
>> revision?
>
>Please send a new revision, and in the commit message,
>fix first letter of my family name with an upper case,
>and move my R-b below your sign-off.

Got it.

Thanks,
Xiaolong
>
>Thanks!
>Maxime
>
>> Thanks,
>> Xiaolong
>> 
>> 
>> > 
>> > > Thanks,
>> > > Xiaolong
>> > > 

Re: [dpdk-dev] [PATCH] event/octeontx: add Tx adapter support

[Jerin Jacob]

-Original Message-
> Date: Fri, 31 Aug 2018 16:04:05 +0530
> From: Pavan Nikhilesh 
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
>  anoob.jos...@caviumnetworks.com, nikhil@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh 
> Subject: [dpdk-dev] [PATCH] event/octeontx: add Tx adapter support
> X-Mailer: git-send-email 2.18.0
> 
> Add Tx adapter support and move few routines around to avoid code
> duplication.
> 
> Signed-off-by: Pavan Nikhilesh 
> ---
>  This patch depends on the Tx adapter series
>  http://patches.dpdk.org/project/dpdk/list/?series=1121

This series pulled into next-eventdev now.
I have rebased next-eventdev to latest master.

Please check with following build error with 
"x86_64-native-linuxapp-gcc+shared+debug" target + next-evendev tree master.

LD librte_pmd_octeontx_ssovf.so.1
/usr/bin/ld: ssovf_worker.o: in function `sso_event_tx_adapter_enqueue':
ssovf_worker.c:(.text+0x296): undefined reference to `rte_eth_devices'
collect2: error: ld returned 1 exit status
make[4]: *** [/export/dpdk-next-eventdev/mk/rte.lib.mk:100:
librte_pmd_octeontx_ssovf.so.1] Error 1
make[3]: *** [/export/dpdk-next-eventdev/mk/rte.subdir.mk:35: octeontx]
Error 2
make[2]: *** [/export/dpdk-next-eventdev/mk/rte.subdir.mk:37: event]
Error 2
make[1]: *** [/export/dpdk-next-eventdev/mk/rte.sdkbuild.mk:49: drivers]
Error 2
make: *** [/export/dpdk-next-eventdev/mk/rte.sdkroot.mk:101: all] Error





> 
>  drivers/event/octeontx/ssovf_evdev.c  | 80 +++
>  drivers/event/octeontx/ssovf_evdev.h  |  3 +
>  drivers/event/octeontx/ssovf_worker.c | 44 +++
>  drivers/event/octeontx/ssovf_worker.h |  1 +
>  drivers/net/octeontx/octeontx_rxtx.c  | 34 
>  drivers/net/octeontx/octeontx_rxtx.h  | 33 +++
>  6 files changed, 161 insertions(+), 34 deletions(-)

[dpdk-dev] [PATCH v3] port: add sym crypto port

[Fan Zhang]

From: "Zhang, Roy Fan" 

This patch adds the symmetric crypto support to port library.
The crypto port acts as a shim layer to DPDK cryptodev library and
supports in-place crypto workload processing.

Signed-off-by: Zhang, Roy Fan 
Acked-by: Dumitrescu, Cristian 
---
v3:
- fixed a compile issue

v2:
- added experimental flags
- enabled meson build

 lib/librte_port/Makefile  |   4 +-
 lib/librte_port/meson.build   |   8 +-
 lib/librte_port/rte_port_sym_crypto.c | 553 ++
 lib/librte_port/rte_port_sym_crypto.h |  97 ++
 lib/librte_port/rte_port_version.map  |   8 +
 5 files changed, 666 insertions(+), 4 deletions(-)
 create mode 100644 lib/librte_port/rte_port_sym_crypto.c
 create mode 100644 lib/librte_port/rte_port_sym_crypto.h

diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile
index 8df4864ed..1b83f6f2b 100644
--- a/lib/librte_port/Makefile
+++ b/lib/librte_port/Makefile
@@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y)
 LDLIBS += -lpcap
 endif
 LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev
-LDLIBS += -lrte_ip_frag -lrte_sched
+LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev
 ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
 LDLIBS += -lrte_kni
 endif
@@ -38,6 +38,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
 SRCS-$(CONFIG_RTE_LIBRTE_PORT) += rte_port_kni.c
 endif
 SRCS-$(CONFIG_RTE_LIBRTE_PORT) += rte_port_source_sink.c
+SRCS-$(CONFIG_RTE_LIBRTE_PORT) += rte_port_sym_crypto.c
 
 # install includes
 SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include += rte_port.h
@@ -53,5 +54,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
 SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include += rte_port_kni.h
 endif
 SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include += rte_port_source_sink.h
+SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include += rte_port_sym_crypto.h
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/lib/librte_port/meson.build b/lib/librte_port/meson.build
index f3d8b4434..0d11456f0 100644
--- a/lib/librte_port/meson.build
+++ b/lib/librte_port/meson.build
@@ -9,7 +9,8 @@ sources = files(
'rte_port_ras.c',
'rte_port_ring.c',
'rte_port_sched.c',
-   'rte_port_source_sink.c')
+   'rte_port_source_sink.c',
+   'rte_port_sym_crypto.c')
 headers = files(
'rte_port_ethdev.h',
'rte_port_fd.h',
@@ -18,8 +19,9 @@ headers = files(
'rte_port.h',
'rte_port_ring.h',
'rte_port_sched.h',
-   'rte_port_source_sink.h')
-deps += ['ethdev', 'sched', 'ip_frag']
+   'rte_port_source_sink.h',
+   'rte_port_sym_crypto.h')
+deps += ['ethdev', 'sched', 'ip_frag', 'cryptodev']
 
 if dpdk_conf.has('RTE_LIBRTE_KNI')
sources += files('rte_port_kni.c')
diff --git a/lib/librte_port/rte_port_sym_crypto.c 
b/lib/librte_port/rte_port_sym_crypto.c
new file mode 100644
index 0..aa3de4fdf
--- /dev/null
+++ b/lib/librte_port/rte_port_sym_crypto.c
@@ -0,0 +1,553 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+#include 
+
+#include 
+#include 
+
+#include "rte_port_sym_crypto.h"
+
+/*
+ * Port Crypto Reader
+ */
+#ifdef RTE_PORT_STATS_COLLECT
+
+#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_IN_ADD(port, val) \
+   port->stats.n_pkts_in += val
+#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_DROP_ADD(port, val) \
+   port->stats.n_pkts_drop += val
+
+#else
+
+#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_IN_ADD(port, val)
+#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_DROP_ADD(port, val)
+
+#endif
+
+struct rte_port_sym_crypto_reader {
+   struct rte_port_in_stats stats;
+
+   uint8_t cryptodev_id;
+   uint16_t queue_id;
+   struct rte_crypto_op *ops[RTE_PORT_IN_BURST_SIZE_MAX];
+   rte_port_sym_crypto_reader_callback_fn f_callback;
+   void *arg_callback;
+};
+
+static void *
+rte_port_sym_crypto_reader_create(void *params, int socket_id)
+{
+   struct rte_port_sym_crypto_reader_params *conf =
+   params;
+   struct rte_port_sym_crypto_reader *port;
+
+   /* Check input parameters */
+   if (conf == NULL) {
+   RTE_LOG(ERR, PORT, "%s: params is NULL\n", __func__);
+   return NULL;
+   }
+
+   /* Memory allocation */
+   port = rte_zmalloc_socket("PORT", sizeof(*port),
+   RTE_CACHE_LINE_SIZE, socket_id);
+   if (port == NULL) {
+   RTE_LOG(ERR, PORT, "%s: Failed to allocate port\n", __func__);
+   return NULL;
+   }
+
+   /* Initialization */
+   port->cryptodev_id = conf->cryptodev_id;
+   port->queue_id = conf->queue_id;
+   port->f_callback = conf->f_callback;
+   port->arg_callback = conf->arg_callback;
+
+   return port;
+}
+
+static int
+rte_port_sym_crypto_reader_rx(void *port, struct rte_mbuf **pkts, uint32_t 
n_pkts)
+{
+   struct rte_port_sym_crypto_reader *p =
+   port;
+   uint16_t rx_ops_cnt, i, n = 0;
+
+   rx_ops_cnt = rte_cryptodev_dequeue_burst(p->cryptodev_id, p->

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

[Ferruh Yigit]

On 8/6/2018 4:50 PM, Chas Williams wrote:
> On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon  wrote:
> 
>> 02/08/2018 15:38, Doherty, Declan:
>>> On 01/08/2018 2:18 PM, Radu Nicolau wrote:
 When a bonding port is stopped also stop and deactivate all slaves.
 Otherwise slaves will be still listed as active.

 Fixes: 69bce062132b ("net/bonding: do not clear active slave count")
 Cc: sta...@dpdk.org

 Signed-off-by: Radu Nicolau 
>>>
>>> Acked-by: Declan Doherty 

Fixes: 2efb58cbab6e ("bond: new link bonding library")

Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v2] net/i40e: select fdir config automatically

[Xiaoyun Li]

I40e driver needed users to config exact fdir mode to create rte_flow
rules but it shouldn't. This patch allows users to create rte_flow rules
without configuring fdir mode and let the driver select the config
automatically. And remove the workaround in flow_filtering example.

Signed-off-by: Xiaoyun Li 
---
v2:
 * Added fdir teardown in i40e_flow_flush_fdir_filter.
 * Replace TAILQ_FIRST with TAILQ_EMPTY which is more intuitive.
 * Remove the workaround in flow_filtering example since the driver will
 * set the fdir config automatically.
---
 drivers/net/i40e/i40e_flow.c   | 35 +-
 examples/flow_filtering/main.c | 16 
 2 files changed, 30 insertions(+), 21 deletions(-)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index c67b264de..68ae00a27 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -3127,6 +3127,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
struct rte_flow_error *error,
union i40e_filter_t *filter)
 {
+   struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
struct i40e_fdir_filter_conf *fdir_filter =
&filter->fdir_filter;
int ret;
@@ -3148,14 +3149,29 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
 
if (dev->data->dev_conf.fdir_conf.mode !=
RTE_FDIR_MODE_PERFECT) {
-   rte_flow_error_set(error, ENOTSUP,
-  RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
-  NULL,
-  "Check the mode in fdir_conf.");
-   return -rte_errno;
+   /* Enable fdir when fdir flow is added at first time. */
+   ret = i40e_fdir_setup(pf);
+   if (ret != I40E_SUCCESS) {
+   rte_flow_error_set(error, ENOTSUP,
+  RTE_FLOW_ERROR_TYPE_HANDLE,
+  NULL, "Failed to setup fdir.");
+   return -rte_errno;
+   }
+   ret = i40e_fdir_configure(dev);
+   if (ret < 0) {
+   rte_flow_error_set(error, ENOTSUP,
+  RTE_FLOW_ERROR_TYPE_HANDLE,
+  NULL, "Failed to configure fdir.");
+   goto err;
+   }
+
+   dev->data->dev_conf.fdir_conf.mode = RTE_FDIR_MODE_PERFECT;
}
 
return 0;
+err:
+   i40e_fdir_teardown(pf);
+   return -rte_errno;
 }
 
 /* Parse to get the action info of a tunnel filter
@@ -4708,6 +4724,13 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
case RTE_ETH_FILTER_FDIR:
ret = i40e_flow_add_del_fdir_filter(dev,
   &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
+
+   /* If the last flow is destroyed, disable fdir. */
+   if (!ret && !TAILQ_EMPTY(&pf->fdir.fdir_list)) {
+   i40e_fdir_teardown(pf);
+   dev->data->dev_conf.fdir_conf.mode =
+  RTE_FDIR_MODE_NONE;
+   }
break;
case RTE_ETH_FILTER_HASH:
ret = i40e_config_rss_filter_del(dev,
@@ -4900,6 +4923,8 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)
pf->fdir.inset_flag[pctype] = 0;
}
 
+   i40e_fdir_teardown(pf);
+
return ret;
 }
 
diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index b3f85b563..a73d120e3 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -131,22 +131,6 @@ init_port(void)
DEV_TX_OFFLOAD_SCTP_CKSUM  |
DEV_TX_OFFLOAD_TCP_TSO,
},
-   /*
-* Initialize fdir_conf of rte_eth_conf.
-* Fdir is used in flow filtering for I40e,
-* so rte_flow rules involve some fdir
-* configurations. In long term it's better
-* that drivers don't require any fdir
-* configuration for rte_flow, but we need to
-* get this workaround so that sample app can
-* run on I40e.
-*/
-   .fdir_conf = {
-   .mode = RTE_FDIR_MODE_PERFECT,
-   .pballoc = RTE_FDIR_PBALLOC_64K,
-   .status = RTE_FDIR_REPORT_STATUS,
-   .drop_queue = 127,
-   },
};
struct rte_eth_txconf txq_conf;
struct rte_eth_rxconf rxq_conf;
-- 
2.17.1

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

[Joseph, Anoob]

Hi Fiona,

Did you get a chance to look at this?

Thanks,
Anoob
On 24-09-2018 17:06, Joseph, Anoob wrote:

Hi Fiona,

Can you please comment on this?

We are adding all capabilities of octeontx-crypto PMD as a macro in 
otx_cryptodev_capabilites.h file and then we are using it from 
otx_cryptodev_ops.c. This is the approach followed by QAT crypto PMD. 
As per my understanding, this is to ensure that cryptodev_ops file 
remains simple. For other PMDs with fewer number of capabilities, the 
structure can be populated in the .c file itself without the size of 
the file coming into the picture.


But this would cause checkpatch to report error. Akhil's suggestion is 
to move the entire definition to a header and include it from the .c 
file. I believe, the QAT approach was to avoid variable definition in 
the header. What do you think would be a better approach here?


Thanks,
Anoob
On 17-09-2018 18:05, Joseph, Anoob wrote:

Hi Akhil,

On 17-09-2018 17:31, Akhil Goyal wrote:

External Email

diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c 
b/drivers/crypto/octeontx/otx_cryptodev_ops.c

index d25f9c1..cc0030e 100644
--- a/drivers/crypto/octeontx/otx_cryptodev_ops.c
+++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c
@@ -10,9 +10,15 @@
  #include "cpt_pmd_logs.h"

  #include "otx_cryptodev.h"
+#include "otx_cryptodev_capabilities.h"
  #include "otx_cryptodev_hw_access.h"
  #include "otx_cryptodev_ops.h"

+static const struct rte_cryptodev_capabilities otx_capabilities[] = {
+ OTX_SYM_CAPABILITIES,
+ RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
+};
+


better to have otx_capabilities structure defined in the 
otx_cryptodev_capabilities.h


I don't see any value addition of creating a macro in one file using 
in a separate structure in another file


which doesn't have anything new in that structure. It would also 
give checkpatch error.


You can directly have a capability structure without the #define.

This was the convention followed in qat driver.

https://git.dpdk.org/dpdk/tree/drivers/crypto/qat/qat_sym_capabilities.h

I guess it was to avoid variable definition in header. May be Pablo 
too can comment on this. I'll make the change accordingly.


Thanks,
Anoob

Re: [dpdk-dev] [PATCH v2] examples/eventdev_pipeline: add Tx adapter support

[Jerin Jacob]

-Original Message-
> Date: Wed, 26 Sep 2018 18:26:37 +0530
> From: "Rao, Nikhil" 
> To: Pavan Nikhilesh ,
>  jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com,
>  anoob.jos...@caviumnetworks.com
> CC: dev@dpdk.org, "Rao, Nikhil" 
> Subject: Re: [PATCH v2] examples/eventdev_pipeline: add Tx adapter support
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
>  Thunderbird/60.0
> 
> On 9/24/2018 3:42 PM, Pavan Nikhilesh wrote:
> > Redo the worker pipelines and offload transmission to service cores
> > seamlessly through Tx adapter.
> > 
> > Signed-off-by: Pavan Nikhilesh 
> > ---
> >   v2 Changes:
> >   - Updated enqueue,dequeue depth thresholds.
> >   - remove redundant capability checks.
> 
> Reviewed-by: Nikhil Rao 
> Tested-by: Nikhil Rao 


Applied to dpdk-next-eventdev/master. Thanks.

Re: [dpdk-dev] [PATCH v8 2/4] examples/l3fwd-power: simple app update for new API

[Hunt, David]

Hi Liang,

A few tweaks below:


On 17/9/2018 2:30 PM, Liang Ma wrote:

Add the support for new traffic pattern aware power control
power management API.

Example:
./l3fwd-power -l xxx   -n 4   -w :xx:00.0 -w :xx:00.1 -- -p 0x3
-P --config="(0,0,xx),(1,0,xx)" --empty-poll="0,0,0" -l 14 -m 9 -h 1

Please Reference l3fwd-power document for all parameter except
empty-poll.


The docs should probably include empty poll parameter. Suggest 
re-wording to


Please Reference l3fwd-power document for full parameter usage




The option "l", "m", "h" are used to set the power index for
LOW, MED, HIGH power state. only is useful after enable empty-poll

--empty-poll="training_flag, med_threshold, high_threshold"

The option training_flag is used to enable/disable training mode.

The option med_threshold is used to indicate the empty poll threshold
of modest state which is customized by user.

The option high_threshold is used to indicate the empty poll threshold
of busy state which is customized by user.

Above three option default value is all 0.

Once enable empty-poll. System will apply the default parameter.
Training mode is disabled as default.


Suggest:

Once empty-poll is enabled, the system will apply the default parameters is no
other command line options are provided.




If training mode is triggered, there should not has any traffic
pass-through during training phase.


Suggest:
If training mode is enabled, the user should ensure that no traffic
is allowed to pass through the system.


When training phase complete, system transfer to normal phase.


When training phase complete, the application transfer to normal operation





System will running with modest power stat at beginning.


System will start running with the modest power mode.



If the system busyness percentage above 70%, then system will adjust
power state move to High power state. If the traffic become lower(eg. The
system busyness percentage drop below 30%), system will fallback
to the modest power state.


If the traffic goes above 70%, then system will move to High power state.
If the traffic drops below 30%, the system will fallback to the modest
power state.



Example code use master thread to monitoring worker thread busyness.
the default timer resolution is 10ms.

ChangeLog:
v2 fix some coding style issues
v3 rename the API.
v6 re-work the API.
v7 no change.
v8 disable training as default option.

Signed-off-by: Liang Ma 

Reviewed-by: Lei Yao 
---
  examples/l3fwd-power/Makefile|   3 +
  examples/l3fwd-power/main.c  | 325 +--
  examples/l3fwd-power/meson.build |   1 +
  3 files changed, 312 insertions(+), 17 deletions(-)

diff --git a/examples/l3fwd-power/Makefile b/examples/l3fwd-power/Makefile
index d7e39a3..772ec7b 100644
--- a/examples/l3fwd-power/Makefile
+++ b/examples/l3fwd-power/Makefile
@@ -23,6 +23,8 @@ CFLAGS += -O3 $(shell pkg-config --cflags libdpdk)
  LDFLAGS_SHARED = $(shell pkg-config --libs libdpdk)
  LDFLAGS_STATIC = -Wl,-Bstatic $(shell pkg-config --static --libs libdpdk)
  
+CFLAGS += -DALLOW_EXPERIMENTAL_API

+
  build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build
$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)
  
@@ -54,6 +56,7 @@ please change the definition of the RTE_TARGET environment variable)

  all:
  else
  
+CFLAGS += -DALLOW_EXPERIMENTAL_API

  CFLAGS += -O3
  CFLAGS += $(WERROR_FLAGS)
  
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c

index 68527d2..1465608 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -43,6 +43,7 @@
  #include 
  #include 
  #include 
+#include 
  
  #include "perf_core.h"

  #include "main.h"
@@ -55,6 +56,8 @@
  
  /* 100 ms interval */

  #define TIMER_NUMBER_PER_SECOND   10
+/* (10ms) */
+#define INTERVALS_PER_SECOND 100
  /* 10 us */
  #define SCALING_PERIOD(100/TIMER_NUMBER_PER_SECOND)
  #define SCALING_DOWN_TIME_RATIO_THRESHOLD 0.25
@@ -117,6 +120,11 @@
   */
  #define RTE_TEST_RX_DESC_DEFAULT 1024
  #define RTE_TEST_TX_DESC_DEFAULT 1024
+#define EMPTY_POLL_MED_THRESHOLD 35UL
+#define EMPTY_POLL_HGH_THRESHOLD 58UL


I'd suggest adding some explanation around these two numbers.
E.g.
/*
 * These two thresholds were decided on by running the training 
algorithm on
 * a 2.5GHz Xeon. These defaults can be overridden by supplying 
non-zero values

 * for the med_threshold and high_threshold parameters on the command line.
 */



+
+
+
  static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;
  static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;
  
@@ -132,6 +140,14 @@ static uint32_t enabled_port_mask = 0;

  static int promiscuous_on = 0;
  /* NUMA is enabled by default. */
  static int numa_on = 1;
+/* emptypoll is disabled by default. */
+static bool empty_poll_on;
+static bool empty_poll_train;
+volatile bool empty_poll_stop;
+static struct  ep_params *ep_params;
+static struct  ep_policy pol

Re: [dpdk-dev] [PATCH v3] port: add sym crypto port

[Dumitrescu, Cristian]

> -Original Message-
> From: Zhang, Roy Fan
> Sent: Friday, September 28, 2018 11:42 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian ; Zhang, Roy Fan
> ; Zhang
> Subject: [PATCH v3] port: add sym crypto port
> 
> From: "Zhang, Roy Fan" 
> 
> This patch adds the symmetric crypto support to port library.
> The crypto port acts as a shim layer to DPDK cryptodev library and
> supports in-place crypto workload processing.
> 
> Signed-off-by: Zhang, Roy Fan 
> Acked-by: Dumitrescu, Cristian 
> ---
> v3:
> - fixed a compile issue
> 
> v2:
> - added experimental flags
> - enabled meson build
> 
>  lib/librte_port/Makefile  |   4 +-
>  lib/librte_port/meson.build   |   8 +-
>  lib/librte_port/rte_port_sym_crypto.c | 553
> ++
>  lib/librte_port/rte_port_sym_crypto.h |  97 ++
>  lib/librte_port/rte_port_version.map  |   8 +
>  5 files changed, 666 insertions(+), 4 deletions(-)
>  create mode 100644 lib/librte_port/rte_port_sym_crypto.c
>  create mode 100644 lib/librte_port/rte_port_sym_crypto.h
> 
> diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile
> index 8df4864ed..1b83f6f2b 100644
> --- a/lib/librte_port/Makefile
> +++ b/lib/librte_port/Makefile
> @@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y)
>  LDLIBS += -lpcap
>  endif
>  LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev
> -LDLIBS += -lrte_ip_frag -lrte_sched
> +LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev
>  ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
>  LDLIBS += -lrte_kni
>  endif
> @@ -38,6 +38,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
>  SRCS-$(CONFIG_RTE_LIBRTE_PORT) += rte_port_kni.c
>  endif
>  SRCS-$(CONFIG_RTE_LIBRTE_PORT) += rte_port_source_sink.c
> +SRCS-$(CONFIG_RTE_LIBRTE_PORT) += rte_port_sym_crypto.c
> 
>  # install includes
>  SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include += rte_port.h
> @@ -53,5 +54,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
>  SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include += rte_port_kni.h
>  endif
>  SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include += rte_port_source_sink.h
> +SYMLINK-$(CONFIG_RTE_LIBRTE_PORT)-include += rte_port_sym_crypto.h
> 
>  include $(RTE_SDK)/mk/rte.lib.mk
> diff --git a/lib/librte_port/meson.build b/lib/librte_port/meson.build
> index f3d8b4434..0d11456f0 100644
> --- a/lib/librte_port/meson.build
> +++ b/lib/librte_port/meson.build
> @@ -9,7 +9,8 @@ sources = files(
>   'rte_port_ras.c',
>   'rte_port_ring.c',
>   'rte_port_sched.c',
> - 'rte_port_source_sink.c')
> + 'rte_port_source_sink.c',
> + 'rte_port_sym_crypto.c')
>  headers = files(
>   'rte_port_ethdev.h',
>   'rte_port_fd.h',
> @@ -18,8 +19,9 @@ headers = files(
>   'rte_port.h',
>   'rte_port_ring.h',
>   'rte_port_sched.h',
> - 'rte_port_source_sink.h')
> -deps += ['ethdev', 'sched', 'ip_frag']
> + 'rte_port_source_sink.h',
> + 'rte_port_sym_crypto.h')
> +deps += ['ethdev', 'sched', 'ip_frag', 'cryptodev']
> 
>  if dpdk_conf.has('RTE_LIBRTE_KNI')
>   sources += files('rte_port_kni.c')
> diff --git a/lib/librte_port/rte_port_sym_crypto.c
> b/lib/librte_port/rte_port_sym_crypto.c
> new file mode 100644
> index 0..aa3de4fdf
> --- /dev/null
> +++ b/lib/librte_port/rte_port_sym_crypto.c
> @@ -0,0 +1,553 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Intel Corporation
> + */
> +#include 
> +
> +#include 
> +#include 
> +
> +#include "rte_port_sym_crypto.h"
> +
> +/*
> + * Port Crypto Reader
> + */
> +#ifdef RTE_PORT_STATS_COLLECT
> +
> +#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_IN_ADD(port, val)
> \
> + port->stats.n_pkts_in += val
> +#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_DROP_ADD(port,
> val) \
> + port->stats.n_pkts_drop += val
> +
> +#else
> +
> +#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_IN_ADD(port, val)
> +#define RTE_PORT_SYM_CRYPTO_READER_STATS_PKTS_DROP_ADD(port,
> val)
> +
> +#endif
> +
> +struct rte_port_sym_crypto_reader {
> + struct rte_port_in_stats stats;
> +
> + uint8_t cryptodev_id;
> + uint16_t queue_id;
> + struct rte_crypto_op *ops[RTE_PORT_IN_BURST_SIZE_MAX];
> + rte_port_sym_crypto_reader_callback_fn f_callback;
> + void *arg_callback;
> +};
> +
> +static void *
> +rte_port_sym_crypto_reader_create(void *params, int socket_id)
> +{
> + struct rte_port_sym_crypto_reader_params *conf =
> + params;
> + struct rte_port_sym_crypto_reader *port;
> +
> + /* Check input parameters */
> + if (conf == NULL) {
> + RTE_LOG(ERR, PORT, "%s: params is NULL\n", __func__);
> + return NULL;
> + }
> +
> + /* Memory allocation */
> + port = rte_zmalloc_socket("PORT", sizeof(*port),
> + RTE_CACHE_LINE_SIZE, socket_id);
> + if (port == NULL) {
> + RTE_LOG(ERR, PORT, "%s: Failed to allocate port\n",
> __func__);
> + return NULL;
> + }
> +
> + /* Initialization */
> + port->cryptodev_id = conf->cryptodev_id;
> + p

Re: [dpdk-dev] [PATCH v2 0/2] CPU non-blocking delay

[Ilya Maximets]

Any thoughts on this?

Best regards, Ilya Maximets.

On 14.09.2018 14:01, Ilya Maximets wrote:
> For meson build without deprecation warnings following
> patch should be applied first:
> http://patches.dpdk.org/patch/44129/

This patch already accepted. I could rebase on latest
dpdk-next-net or dpdk-next-net-intel if required (it's trivial).

> 
> Version 2:
>   * Added comment for EINTR handling for nanosleep. [Stephen Hemminger]
> 
> Ilya Maximets (2):
>   eal: add nanosleep based delay function
>   drivers/net: use sleep delay by default for intel NICs
> 
>  drivers/net/avf/Makefile  |  1 +
>  drivers/net/avf/base/avf_osdep.h  |  4 +-
>  drivers/net/e1000/Makefile|  1 +
>  drivers/net/e1000/base/e1000_osdep.h  |  2 +-
>  drivers/net/e1000/meson.build |  2 +
>  drivers/net/i40e/base/i40e_osdep.h|  6 +--
>  drivers/net/ifc/base/ifcvf_osdep.h|  2 +-
>  drivers/net/ixgbe/base/ixgbe_osdep.h  |  2 +-
>  drivers/net/ixgbe/meson.build |  3 +-
>  lib/librte_eal/common/eal_common_timer.c  | 24 +
>  .../common/include/generic/rte_cycles.h   | 11 
>  lib/librte_eal/rte_eal_version.map|  1 +
>  test/test/autotest_data.py|  6 +++
>  test/test/meson.build |  1 +
>  test/test/test_cycles.c   | 51 ++-
>  15 files changed, 94 insertions(+), 23 deletions(-)
> 

[dpdk-dev] [PATCH v2] event/octeontx: add Tx adapter support

[pavan . bhagavatula]

From: Pavan Nikhilesh 

Add Tx adapter support and move few routines around to avoid code
duplication.

Signed-off-by: Pavan Nikhilesh 
---
 v2 Changes:
 - Fix shared build break added -lrte_ethdev to LDLIBS list.

 drivers/event/octeontx/Makefile   |  2 +-
 drivers/event/octeontx/ssovf_evdev.c  | 80 +++
 drivers/event/octeontx/ssovf_evdev.h  |  3 +
 drivers/event/octeontx/ssovf_worker.c | 44 +++
 drivers/event/octeontx/ssovf_worker.h |  1 +
 drivers/net/octeontx/octeontx_rxtx.c  | 34 
 drivers/net/octeontx/octeontx_rxtx.h  | 33 +++
 7 files changed, 162 insertions(+), 35 deletions(-)

diff --git a/drivers/event/octeontx/Makefile b/drivers/event/octeontx/Makefile
index 90ad2217f..2e07890b9 100644
--- a/drivers/event/octeontx/Makefile
+++ b/drivers/event/octeontx/Makefile
@@ -17,7 +17,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API

 LDLIBS += -lrte_eal -lrte_eventdev -lrte_common_octeontx -lrte_pmd_octeontx
 LDLIBS += -lrte_bus_pci -lrte_mempool -lrte_mbuf -lrte_kvargs
-LDLIBS += -lrte_bus_vdev
+LDLIBS += -lrte_bus_vdev -lrte_ethdev

 EXPORT_MAP := rte_pmd_octeontx_event_version.map

diff --git a/drivers/event/octeontx/ssovf_evdev.c 
b/drivers/event/octeontx/ssovf_evdev.c
index 16a3a04b8..c5e891cdb 100644
--- a/drivers/event/octeontx/ssovf_evdev.c
+++ b/drivers/event/octeontx/ssovf_evdev.c
@@ -146,6 +146,7 @@ ssovf_fastpath_fns_set(struct rte_eventdev *dev)
dev->enqueue_forward_burst = ssows_enq_fwd_burst;
dev->dequeue   = ssows_deq;
dev->dequeue_burst = ssows_deq_burst;
+   dev->txa_enqueue = sso_event_tx_adapter_enqueue;

if (edev->is_timeout_deq) {
dev->dequeue   = ssows_deq_timeout;
@@ -491,6 +492,77 @@ ssovf_eth_rx_adapter_stop(const struct rte_eventdev *dev,
return 0;
 }

+static int
+ssovf_eth_tx_adapter_caps_get(const struct rte_eventdev *dev,
+   const struct rte_eth_dev *eth_dev, uint32_t *caps)
+{
+   int ret;
+   RTE_SET_USED(dev);
+
+   ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
+   if (ret)
+   *caps = 0;
+   else
+   *caps = RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT;
+
+   return 0;
+}
+
+static int
+ssovf_eth_tx_adapter_create(uint8_t id, const struct rte_eventdev *dev)
+{
+   RTE_SET_USED(id);
+   RTE_SET_USED(dev);
+   return 0;
+}
+
+static int
+ssovf_eth_tx_adapter_free(uint8_t id, const struct rte_eventdev *dev)
+{
+   RTE_SET_USED(id);
+   RTE_SET_USED(dev);
+   return 0;
+}
+
+static int
+ssovf_eth_tx_adapter_queue_add(uint8_t id, const struct rte_eventdev *dev,
+   const struct rte_eth_dev *eth_dev, int32_t tx_queue_id)
+{
+   RTE_SET_USED(id);
+   RTE_SET_USED(dev);
+   RTE_SET_USED(eth_dev);
+   RTE_SET_USED(tx_queue_id);
+   return 0;
+}
+
+static int
+ssovf_eth_tx_adapter_queue_del(uint8_t id, const struct rte_eventdev *dev,
+   const struct rte_eth_dev *eth_dev, int32_t tx_queue_id)
+{
+   RTE_SET_USED(id);
+   RTE_SET_USED(dev);
+   RTE_SET_USED(eth_dev);
+   RTE_SET_USED(tx_queue_id);
+   return 0;
+}
+
+static int
+ssovf_eth_tx_adapter_start(uint8_t id, const struct rte_eventdev *dev)
+{
+   RTE_SET_USED(id);
+   RTE_SET_USED(dev);
+   return 0;
+}
+
+static int
+ssovf_eth_tx_adapter_stop(uint8_t id, const struct rte_eventdev *dev)
+{
+   RTE_SET_USED(id);
+   RTE_SET_USED(dev);
+   return 0;
+}
+
+
 static void
 ssovf_dump(struct rte_eventdev *dev, FILE *f)
 {
@@ -619,6 +691,14 @@ static struct rte_eventdev_ops ssovf_ops = {
.eth_rx_adapter_start = ssovf_eth_rx_adapter_start,
.eth_rx_adapter_stop = ssovf_eth_rx_adapter_stop,

+   .eth_tx_adapter_caps_get = ssovf_eth_tx_adapter_caps_get,
+   .eth_tx_adapter_create = ssovf_eth_tx_adapter_create,
+   .eth_tx_adapter_free = ssovf_eth_tx_adapter_free,
+   .eth_tx_adapter_queue_add = ssovf_eth_tx_adapter_queue_add,
+   .eth_tx_adapter_queue_del = ssovf_eth_tx_adapter_queue_del,
+   .eth_tx_adapter_start = ssovf_eth_tx_adapter_start,
+   .eth_tx_adapter_stop = ssovf_eth_tx_adapter_stop,
+
.timer_adapter_caps_get = ssovf_timvf_caps_get,

.dev_selftest = test_eventdev_octeontx,
diff --git a/drivers/event/octeontx/ssovf_evdev.h 
b/drivers/event/octeontx/ssovf_evdev.h
index 18293e96e..b1856c15b 100644
--- a/drivers/event/octeontx/ssovf_evdev.h
+++ b/drivers/event/octeontx/ssovf_evdev.h
@@ -5,6 +5,7 @@
 #ifndef __SSOVF_EVDEV_H__
 #define __SSOVF_EVDEV_H__

+#include 
 #include 
 #include 

@@ -179,6 +180,8 @@ typedef void (*ssows_handle_event_t)(void *arg, struct 
rte_event ev);
 void ssows_flush_events(struct ssows *ws, uint8_t queue_id,
ssows_handle_event_t fn, void *arg);
 void ssows_reset(struct ssows *ws);
+uint16_t sso_event_tx_adapter_enqueue(void *port,
+   struct rte_event ev[], uint16_t nb_events);
 int ssovf_info(struct ssovf_info *info);

Re: [dpdk-dev] [PATCH v2 2/2] event/dpaa: add select based event support

[Jerin Jacob]

-Original Message-
> Date: Tue, 25 Sep 2018 12:32:35 +0530
> From: Hemant Agrawal 
> To: dev@dpdk.org
> CC: jerin.ja...@caviumnetworks.com
> Subject: [PATCH v2 2/2] event/dpaa: add select based event support
> X-Mailer: git-send-email 2.7.4
> 
> 
> This patch add support to use select call with qman portal fd
> for timeout based dequeue request for eventdev.
> 
> If there is a event available qman portal fd will be set
> and the function will be awakened. If no event is available,
> it will only wait till the given timeout value.
> 
> In case of interrupt the timeout ticks are used as usecs.
> 
> Signed-off-by: Hemant Agrawal 
> ---
> Note: This patch has a dependency on following patch series:
> http://mails.dpdk.org/archives/dev/2018-September/112433.html
> which is now part of dpdk-next-net tree.

I will pull this patch when the depended patch show up on master branch.

Currently it has following build errors, I assume it is due to dependency
patch.

/export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c: In
function ‘drain_4_bytes’:
/export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:121:24:
error: implicit declaration of function ‘qman_thread_fd’; did you mean
‘qman_thread_irq’? [-Werror=implicit-function-declaration]
   ssize_t sjunk = read(qman_thread_fd(), &junk, sizeof(junk));
^~
qman_thread_irq
/export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:121:24:
error: nested extern declaration of ‘qman_thread_fd’
[-Werror=nested-externs]
/export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c: In
function ‘dpaa_event_dequeue_wait’:
/export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:148:2:
error: implicit declaration of function ‘qman_irqsource_add’; did you
mean ‘qman_reserve_fqid’? [-Werror=implicit-function-declaration]
  qman_irqsource_add(QM_PIRQ_DQRI);
  ^~
  qman_reserve_fqid
/export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:148:2:
error: nested extern declaration of ‘qman_irqsource_add’
[-Werror=nested-externs]
/export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:159:2:
error: implicit declaration of function ‘qman_irqsource_remove’; did you
mean ‘qman_reserve_pool’? [-Werror=implicit-function-declaration]
  qman_irqsource_remove(~0);
  ^
  qman_reserve_pool
/export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:159:2:
error: nested extern declaration of ‘qman_irqsource_remove’
[-Werror=nested-externs]

 
> 

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

[Bruce Richardson]

On Fri, Sep 28, 2018 at 01:40:25PM +0300, Ilya Maximets wrote:
> On 27.09.2018 11:28, Ilya Maximets wrote:
> > On 26.09.2018 10:26, Maxime Coquelin wrote:
> >> This patch opens a userfaultfd and sends it back to Qemu's
> >> VHOST_USER_POSTCOPY_ADVISE request.
> >>
> >> Signed-off-by: Dr. David Alan Gilbert 
> >> Signed-off-by: Maxime Coquelin 
> >> ---
> >>  lib/librte_vhost/vhost.h  |  2 ++
> >>  lib/librte_vhost/vhost_user.c | 37 +++
> >>  lib/librte_vhost/vhost_user.h |  3 ++-
> >>  3 files changed, 41 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> >> index 25ffd7614..21722d8a8 100644
> >> --- a/lib/librte_vhost/vhost.h
> >> +++ b/lib/librte_vhost/vhost.h
> >> @@ -363,6 +363,8 @@ struct virtio_net {
> >>int slave_req_fd;
> >>rte_spinlock_t  slave_req_lock;
> >>  
> >> +  int postcopy_ufd;
> >> +
> >>/*
> >> * Device id to identify a specific backend device.
> >> * It's set to -1 for the default software implementation.
> >> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> >> index a9b429598..bdfe2cac0 100644
> >> --- a/lib/librte_vhost/vhost_user.c
> >> +++ b/lib/librte_vhost/vhost_user.c
> >> @@ -24,9 +24,13 @@
> >>  #include 
> >>  #include 
> >>  #include 
> >> +#include 
> >> +#include 
> > 
> > Maybe we need compile time check for this header existence?
> > Otherwise, this will bump minimal kernel version for default linux build
> > to something like 4.3.
> 
> We'll need a config option here (disabled by default) and guard all
> the postcopy related code.
> Meson build will be able to detect the header file and enable
> the config if possible. Like this:
> 
> lib/librte_vhost/meson.build:
> if cc.has_header('linux/userfaultfd.h')
>dpdk_conf.set10('RTE_LIBRTE_VHOST_POSTCOPY', true)

Are you sure you want 'set10' rather than 'set'. Set is probably easier
because it ensures no define on false, while set10 has a define of 0. This
has caught me out before.

FYI, you can also avoid the if by putting the condition into the define:

dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', cc.has_header('...'))

/Bruce

[dpdk-dev] [PATCH 1/2] drivers/net: remove double assignment of driver

[Shreyansh Jain]

Removing double copy of driver information. 04664e5c8346 has shifted
that from driver's probe to bus's probe.

Fixes: 04664e5c8346 ("drivers/bus: fill driver reference after NXP probing")
Cc: tho...@monjalon.net

Signed-off-by: Shreyansh Jain 
---
 drivers/net/dpaa/dpaa_ethdev.c   | 3 +--
 drivers/net/dpaa2/dpaa2_ethdev.c | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 30eff657a..de4cf7b37 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -1371,7 +1371,7 @@ dpaa_dev_uninit(struct rte_eth_dev *dev)
 }
 
 static int
-rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,
+rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused,
   struct rte_dpaa_device *dpaa_dev)
 {
int diag;
@@ -1455,7 +1455,6 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,
}
 
eth_dev->device = &dpaa_dev->device;
-   eth_dev->device->driver = &dpaa_drv->driver;
dpaa_dev->eth_dev = eth_dev;
 
/* Invoke PMD device initialization function */
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 8d3d54bfe..880034fcf 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -2007,7 +2007,6 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv,
}
 
eth_dev->device = &dpaa2_dev->device;
-   eth_dev->device->driver = &dpaa2_drv->driver;
 
dpaa2_dev->eth_dev = eth_dev;
eth_dev->data->rx_mbuf_alloc_failed = 0;
-- 
2.17.1

[dpdk-dev] [PATCH 2/2] drivers/crypto: remove double assignment of driver

[Shreyansh Jain]

Removing double copy of driver information. 04664e5c8346 has shifted
that from driver's probe to bus's probe.

Fixes: 04664e5c8346 ("drivers/bus: fill driver reference after NXP probing")
Cc: tho...@monjalon.net

Signed-off-by: Shreyansh Jain 
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +--
 drivers/crypto/dpaa_sec/dpaa_sec.c  | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c 
b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 2a3c61c66..d5342a0ea 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -2843,7 +2843,7 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev)
 }
 
 static int
-cryptodev_dpaa2_sec_probe(struct rte_dpaa2_driver *dpaa2_drv,
+cryptodev_dpaa2_sec_probe(struct rte_dpaa2_driver *dpaa2_drv __rte_unused,
  struct rte_dpaa2_device *dpaa2_dev)
 {
struct rte_cryptodev *cryptodev;
@@ -2871,7 +2871,6 @@ cryptodev_dpaa2_sec_probe(struct rte_dpaa2_driver 
*dpaa2_drv,
 
dpaa2_dev->cryptodev = cryptodev;
cryptodev->device = &dpaa2_dev->device;
-   cryptodev->device->driver = &dpaa2_drv->driver;
 
/* init user callbacks */
TAILQ_INIT(&(cryptodev->link_intr_cbs));
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c 
b/drivers/crypto/dpaa_sec/dpaa_sec.c
index f571050b7..21c3eb622 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -2316,7 +2316,7 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev)
 }
 
 static int
-cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv,
+cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused,
struct rte_dpaa_device *dpaa_dev)
 {
struct rte_cryptodev *cryptodev;
@@ -2344,7 +2344,6 @@ cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv,
 
dpaa_dev->crypto_dev = cryptodev;
cryptodev->device = &dpaa_dev->device;
-   cryptodev->device->driver = &dpaa_drv->driver;
 
/* init user callbacks */
TAILQ_INIT(&(cryptodev->link_intr_cbs));
-- 
2.17.1

Re: [dpdk-dev] [PATCH] drivers/bus: fill driver reference after NXP probing

[Shreyansh Jain]

On Thursday 27 September 2018 06:10 PM, Thomas Monjalon wrote:

26/09/2018 10:12, Shreyansh Jain:

On Wednesday 26 September 2018 12:52 AM, Thomas Monjalon wrote:

The probing functions of NXP buses were missing to set
the driver used for successfully probing a device.

The NXP driver and the generic rte_driver are now set
in the device structures.

Signed-off-by: Thomas Monjalon 
---


A part of this was already being done in the drv->probe(), though it was
   not complete (dpaa2_dev->driver = dpaa2_drv; was not being done).

--->8---net/dpaa2/dpaa2_ethdev.c--
2008
2009 eth_dev->device = &dpaa2_dev->device;
2010 eth_dev->device->driver = &dpaa2_drv->driver;
2011
--->8---


I guess we could remove the driver assignment in NXP drivers,
after this patch applied.



Sent. I have kept fixes reference to your patch.

Re: [dpdk-dev] [PATCH v8 3/4] doc/guides/proguide/power-man: update the power API

[Hunt, David]

Hi Liang,


On 17/9/2018 2:30 PM, Liang Ma wrote:

Update the document for empty poll API.

Signed-off-by: Liang Ma 
---
  doc/guides/prog_guide/power_man.rst | 90 +
  1 file changed, 90 insertions(+)

diff --git a/doc/guides/prog_guide/power_man.rst 
b/doc/guides/prog_guide/power_man.rst
index eba1cc6..056cb12 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -106,6 +106,96 @@ User Cases
  
  The power management mechanism is used to save power when performing L3 forwarding.
  
+

+Empty Poll API
+--
+
+Abstract
+
+
+For packet processing workloads such as DPDK polling is continuous.
+This means CPU cores always show 100% busy independent of how much work
+those cores are doing. It is critical to accurately determine how busy
+a core is hugely important for the following reasons:
+
+* No indication of overload conditions
+* User do not know how much real load is on a system meaning
+  resulted in wasted energy as no power management is utilized
+
+Compared to the original l3fwd-power design, instead of going to sleep
+after detecting an empty poll, the new mechanism just lowers the core 
frequency.
+As a result, the application does not stop polling the device, which leads
+to improved handling of bursts of traffic.
+
+When the system become busy, the empty poll mechanism can also increase the 
core
+frequency (including turbo) to do best effort for intensive traffic. This gives
+us more flexible and balanced traffic awareness over the standard l3fwd-power
+application.
+
+
+Proposed Solution
+~
+The proposed solution focuses on how many times empty polls are executed.
+The less the number of empty polls, means current core is busy with processing
+workload, therefore, the higher frequency is needed. The high empty poll number
+indicates the current core not doing any real work therefore, we can lower the
+frequency to safe power.
+
+In the current implementation, each core has 1 empty-poll counter which assume
+1 core is dedicated to 1 queue. This will need to be expanded in the future to
+support multiple queues per core.
+
+Power state definition:
+^^^
+
+* LOW:  Not currently used, reserved for future use.
+
+* MED:  the frequency is used to process modest traffic workload.
+
+* HIGH: the frequency is used to process busy traffic workload.
+
+There are two phases to establish the power management system:
+^^
+* Initialization/Training phase. The training phase is necessary
+  in order to figure out the system polling baseline numbers from
+  idle to busy. The highest poll count will be during idle, where all
+  polls are empty. These poll counts will be different between
+  systems due to the many possible processor micro-arch, cache
+  and device configurations, hence the training phase.
+  In the training phase, traffic is blocked so the training algorithm
+  can average the empty-poll numbers for the LOW, MED and
+  HIGH  power states in order to create a baseline.
+  The core's counter are collected every 10ms, and the Training
+  phase will take 2 seconds.
+  Training is disabled as default configuration.
+  The default parameter is applied. Simple App still can trigger
+  training if that's needed


Suggest:

* Training phase. This phase is used to measure the optimal frequency
  change thresholds for a given system. The thresholds will differ from
  system to system due to differences in processor micro-architecture,
  cache and device configurations.
  In this phase, the user must ensure that no traffic can enter the
  system so that counts can be measured for empty polls at low, medium
  and high frequencies. Each frequency is measured for two seconds.
  Once the training phase is complete, the threshold numbers are
  displayed, and normal mode resumes, and traffic can be allowed into
  the system. These threshold number can be used on the command line
  when starting the application in normal mode to avoid re-training
  every time.



+
+* Normal phase. When the training phase is complete, traffic is
+  started. The run-time poll counts are compared with the
+  baseline and the decision will be taken to move to MED power
+  state or HIGH power state. The counters are calculated every
+  10ms.
+


Suggest:

* Normal operation. Every 10ms the run-time counters are compared
  to the supplied threshold values, and the decision will be made
  whether to move to a different power state (by adjusting the
  frequency).




+
+API Overview for Empty Poll Power Management
+
+* **State Init**: initialize the power management system.
+
+* **State Free**: free the resource hold by power management system.
+
+* **Update Empty Poll Counter**: update the empty poll counter.
+
+* **Update Valid Poll Counter**: update the valid poll counter.
+
+* **

[dpdk-dev] [PATCH v2 1/7] pipeline: add symmetric crypto to action

[Fan Zhang]

From: "Zhang, Roy Fan" 

This patch adds the symmetric crypto action support to pipeline
library. The symmetric crypto action works as the shim layer
between pipeline and DPDK cryptodev and is able to interact with
cryptodev with the control path requests such as session
creation/deletion and data path work to assemble the crypto
operations for received packets.

Signed-off-by: Zhang, Roy Fan 
Acked-by: Dumitrescu, Cristian 
---
 lib/librte_pipeline/Makefile |   2 +-
 lib/librte_pipeline/meson.build  |   2 +-
 lib/librte_pipeline/rte_pipeline_version.map |   1 +
 lib/librte_pipeline/rte_table_action.c   | 503 ++-
 lib/librte_pipeline/rte_table_action.h   | 104 ++
 5 files changed, 609 insertions(+), 3 deletions(-)

diff --git a/lib/librte_pipeline/Makefile b/lib/librte_pipeline/Makefile
index 84afe98cb..cf265503f 100644
--- a/lib/librte_pipeline/Makefile
+++ b/lib/librte_pipeline/Makefile
@@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_table
-LDLIBS += -lrte_port -lrte_meter -lrte_sched
+LDLIBS += -lrte_port -lrte_meter -lrte_sched -lrte_cryptodev
 
 EXPORT_MAP := rte_pipeline_version.map
 
diff --git a/lib/librte_pipeline/meson.build b/lib/librte_pipeline/meson.build
index dc16ab42f..04e5f5179 100644
--- a/lib/librte_pipeline/meson.build
+++ b/lib/librte_pipeline/meson.build
@@ -5,4 +5,4 @@ version = 3
 allow_experimental_apis = true
 sources = files('rte_pipeline.c', 'rte_port_in_action.c', 'rte_table_action.c')
 headers = files('rte_pipeline.h', 'rte_port_in_action.h', 'rte_table_action.h')
-deps += ['port', 'table', 'meter', 'sched']
+deps += ['port', 'table', 'meter', 'sched', 'cryptodev']
diff --git a/lib/librte_pipeline/rte_pipeline_version.map 
b/lib/librte_pipeline/rte_pipeline_version.map
index d820b22f6..420f065d6 100644
--- a/lib/librte_pipeline/rte_pipeline_version.map
+++ b/lib/librte_pipeline/rte_pipeline_version.map
@@ -72,4 +72,5 @@ EXPERIMENTAL {
rte_table_action_stats_read;
rte_table_action_time_read;
rte_table_action_ttl_read;
+   rte_table_action_crypto_sym_session_get;
 };
diff --git a/lib/librte_pipeline/rte_table_action.c 
b/lib/librte_pipeline/rte_table_action.c
index 338dcfeee..edb334021 100644
--- a/lib/librte_pipeline/rte_table_action.c
+++ b/lib/librte_pipeline/rte_table_action.c
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2010-2018 Intel Corporation
  */
-
 #include 
 #include 
 
@@ -15,6 +14,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include "rte_table_action.h"
 
@@ -1575,6 +1576,441 @@ pkt_work_time(struct time_data *data,
data->time = time;
 }
 
+
+/**
+ * RTE_TABLE_ACTION_CRYPTO
+ */
+
+#define CRYPTO_OP_MASK_CIPHER  0x1
+#define CRYPTO_OP_MASK_AUTH0x2
+#define CRYPTO_OP_MASK_AEAD0x4
+
+struct crypto_op_sym_iv_aad {
+   struct rte_crypto_op op;
+   struct rte_crypto_sym_op sym_op;
+   union {
+   struct {
+   uint8_t cipher_iv[
+   RTE_TABLE_ACTION_SYM_CRYPTO_IV_SIZE_MAX];
+   uint8_t auth_iv[
+   RTE_TABLE_ACTION_SYM_CRYPTO_IV_SIZE_MAX];
+   } cipher_auth;
+
+   struct {
+   uint8_t iv[RTE_TABLE_ACTION_SYM_CRYPTO_IV_SIZE_MAX];
+   uint8_t aad[RTE_TABLE_ACTION_SYM_CRYPTO_AAD_SIZE_MAX];
+   } aead_iv_aad;
+
+   } iv_aad;
+};
+
+struct sym_crypto_data {
+
+   union {
+   struct {
+
+   /** Length of cipher iv. */
+   uint16_t cipher_iv_len;
+
+   /** Offset from start of IP header to the cipher iv. */
+   uint16_t cipher_iv_data_offset;
+
+   /** Length of cipher iv to be updated in the mbuf. */
+   uint16_t cipher_iv_update_len;
+
+   /** Offset from start of IP header to the auth iv. */
+   uint16_t auth_iv_data_offset;
+
+   /** Length of auth iv in the mbuf. */
+   uint16_t auth_iv_len;
+
+   /** Length of auth iv to be updated in the mbuf. */
+   uint16_t auth_iv_update_len;
+
+   } cipher_auth;
+   struct {
+
+   /** Length of iv. */
+   uint16_t iv_len;
+
+   /** Offset from start of IP header to the aead iv. */
+   uint16_t iv_data_offset;
+
+   /** Length of iv to be updated in the mbuf. */
+   uint16_t iv_update_len;
+
+   /** Length of aad */
+   uint16_t aad_len;
+
+   /** Offset from start of IP header to the aad. */
+   uint16_t aad_data_o

[dpdk-dev] [PATCH v2 2/7] examples/ip_pipeline: add cryptodev

[Fan Zhang]

From: "Zhang, Roy Fan" 

This patch adds symmetric crypto device abstraction to ip_pipeline
sameple application.

Signed-off-by: Zhang, Roy Fan 
Acked-by: Dumitrescu, Cristian 
---
 examples/ip_pipeline/Makefile|   1 +
 examples/ip_pipeline/cryptodev.c | 117 +++
 examples/ip_pipeline/cryptodev.h |  43 ++
 examples/ip_pipeline/main.c  |   9 +++
 examples/ip_pipeline/meson.build |   3 +-
 5 files changed, 172 insertions(+), 1 deletion(-)
 create mode 100644 examples/ip_pipeline/cryptodev.c
 create mode 100644 examples/ip_pipeline/cryptodev.h

diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
index 3fb98ce3e..41ba7df2c 100644
--- a/examples/ip_pipeline/Makefile
+++ b/examples/ip_pipeline/Makefile
@@ -18,6 +18,7 @@ SRCS-y += swq.c
 SRCS-y += tap.c
 SRCS-y += thread.c
 SRCS-y += tmgr.c
+SRCS-y += cryptodev.c
 
 # Build using pkg-config variables if possible
 $(shell pkg-config --exists libdpdk)
diff --git a/examples/ip_pipeline/cryptodev.c b/examples/ip_pipeline/cryptodev.c
new file mode 100644
index 0..c4ba72bec
--- /dev/null
+++ b/examples/ip_pipeline/cryptodev.c
@@ -0,0 +1,117 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+#include "cryptodev.h"
+
+static struct cryptodev_list cryptodev_list;
+
+int
+cryptodev_init(void)
+{
+   TAILQ_INIT(&cryptodev_list);
+
+   return 0;
+}
+
+struct cryptodev *
+cryptodev_find(const char *name)
+{
+   struct cryptodev *cryptodev;
+
+   if (name == NULL)
+   return NULL;
+
+   TAILQ_FOREACH(cryptodev, &cryptodev_list, node)
+   if (strcmp(cryptodev->name, name) == 0)
+   return cryptodev;
+
+   return NULL;
+}
+
+struct cryptodev *
+cryptodev_next(struct cryptodev *cryptodev)
+{
+   return (cryptodev == NULL) ?
+   TAILQ_FIRST(&cryptodev_list) :
+   TAILQ_NEXT(cryptodev, node);
+}
+
+struct cryptodev *
+cryptodev_create(const char *name, struct cryptodev_params *params)
+{
+   struct rte_cryptodev_info dev_info;
+   struct rte_cryptodev_config dev_conf;
+   struct rte_cryptodev_qp_conf queue_conf;
+   struct cryptodev *cryptodev;
+   uint32_t dev_id, i;
+   uint32_t socket_id;
+   int status;
+
+   /* Check input params */
+   if ((name == NULL) ||
+   cryptodev_find(name) ||
+   (params->n_queues == 0) ||
+   (params->queue_size == 0))
+   return NULL;
+
+   if (params->dev_name) {
+   status = rte_cryptodev_get_dev_id(params->dev_name);
+   if (status == -1)
+   return NULL;
+
+   dev_id = (uint32_t)status;
+   } else {
+   if (rte_cryptodev_pmd_is_valid_dev(params->dev_id) == 0)
+   return NULL;
+
+   dev_id = params->dev_id;
+   }
+
+   socket_id = rte_cryptodev_socket_id(dev_id);
+   rte_cryptodev_info_get(dev_id, &dev_info);
+
+   if (dev_info.max_nb_queue_pairs < params->n_queues)
+   return NULL;
+   if (dev_info.feature_flags & RTE_CRYPTODEV_FF_HW_ACCELERATED)
+   return NULL;
+
+   dev_conf.socket_id = socket_id;
+   dev_conf.nb_queue_pairs = params->n_queues;
+
+   status = rte_cryptodev_configure(dev_id, &dev_conf);
+   if (status < 0)
+   return NULL;
+
+   queue_conf.nb_descriptors = params->queue_size;
+   for (i = 0; i < params->n_queues; i++) {
+   status = rte_cryptodev_queue_pair_setup(dev_id, i,
+   &queue_conf, socket_id, NULL);
+   if (status < 0)
+   return NULL;
+   }
+
+   if (rte_cryptodev_start(dev_id) < 0)
+   return NULL;
+
+   cryptodev = calloc(1, sizeof(struct cryptodev));
+   if (cryptodev == NULL) {
+   rte_cryptodev_stop(dev_id);
+   return NULL;
+   }
+
+   strlcpy(cryptodev->name, name, sizeof(cryptodev->name));
+   cryptodev->dev_id = dev_id;
+   cryptodev->n_queues = params->n_queues;
+
+   TAILQ_INSERT_TAIL(&cryptodev_list, cryptodev, node);
+
+   return cryptodev;
+}
diff --git a/examples/ip_pipeline/cryptodev.h b/examples/ip_pipeline/cryptodev.h
new file mode 100644
index 0..d06b3f2f1
--- /dev/null
+++ b/examples/ip_pipeline/cryptodev.h
@@ -0,0 +1,43 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#ifndef _INCLUDE_SYM_C_H_
+#define _INCLUDE_SYM_C_H_
+
+#include 
+#include 
+
+#include 
+
+#include "common.h"
+
+struct cryptodev {
+   TAILQ_ENTRY(cryptodev) node;
+   char name[NAME_SIZE];
+   uint16_t dev_id;
+   uint32_t n_queues;
+};
+
+TAILQ_HEAD(cryptodev_list, cryptodev);
+
+int
+cryptodev_init(void);
+
+struct cryptodev *
+cryptodev_find(const char

[dpdk-dev] [PATCH v2 0/7] pipeline: add symmetric crypto to action

[Fan Zhang]

This patchset creates an abstraction layer of DPDK Cryptodev to the pipeline
library to enable its symmetric cryptographic capability. The ip_pipeline
sample application is updated accordingly.

v2:
- Fixed bugs.
- Updated data structure.
- Updated IP-pipeline sample application.

Zhang, Roy Fan (7):
  pipeline: add symmetric crypto to action
  examples/ip_pipeline: add cryptodev
  examples/ip_pipeline: configure crypto port
  examples/ip_pipeline: add symmetric crypto action
  examples/ip_pipeline: update cli parsing
  examples/ip_pipeline: add script
  doc: update action documentation

 doc/guides/prog_guide/packet_framework.rst|  11 +-
 doc/guides/sample_app_ug/ip_pipeline.rst  |  23 +
 examples/ip_pipeline/Makefile |   1 +
 examples/ip_pipeline/action.c |  11 +
 examples/ip_pipeline/action.h |   1 +
 examples/ip_pipeline/cli.c| 577 +-
 examples/ip_pipeline/cryptodev.c  | 117 ++
 examples/ip_pipeline/cryptodev.h  |  43 ++
 examples/ip_pipeline/examples/flow_crypto.cli |  58 +++
 examples/ip_pipeline/main.c   |   9 +
 examples/ip_pipeline/meson.build  |   3 +-
 examples/ip_pipeline/pipeline.c   |  60 +++
 examples/ip_pipeline/pipeline.h   |  14 +
 examples/ip_pipeline/thread.c |  10 +
 lib/librte_pipeline/Makefile  |   2 +-
 lib/librte_pipeline/meson.build   |   2 +-
 lib/librte_pipeline/rte_pipeline_version.map  |   1 +
 lib/librte_pipeline/rte_table_action.c| 503 +-
 lib/librte_pipeline/rte_table_action.h| 104 +
 19 files changed, 1543 insertions(+), 7 deletions(-)
 create mode 100644 examples/ip_pipeline/cryptodev.c
 create mode 100644 examples/ip_pipeline/cryptodev.h
 create mode 100644 examples/ip_pipeline/examples/flow_crypto.cli

-- 
2.13.6

[dpdk-dev] [PATCH v2 3/7] examples/ip_pipeline: configure crypto port

[Fan Zhang]

From: "Zhang, Roy Fan" 

This patch adds symmetric crypto port configuration to ip_pipeline
sample application.

Signed-off-by: Zhang, Roy Fan 
Acked-by: Dumitrescu, Cristian 
---
 examples/ip_pipeline/pipeline.c | 60 +
 examples/ip_pipeline/pipeline.h | 13 +
 2 files changed, 73 insertions(+)

diff --git a/examples/ip_pipeline/pipeline.c b/examples/ip_pipeline/pipeline.c
index b2fd215b1..b23d6c09a 100644
--- a/examples/ip_pipeline/pipeline.c
+++ b/examples/ip_pipeline/pipeline.c
@@ -18,6 +18,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -36,6 +37,7 @@
 #include "tap.h"
 #include "tmgr.h"
 #include "swq.h"
+#include "cryptodev.h"
 
 #ifndef PIPELINE_MSGQ_SIZE
 #define PIPELINE_MSGQ_SIZE 64
@@ -162,6 +164,7 @@ pipeline_port_in_create(const char *pipeline_name,
struct rte_port_kni_reader_params kni;
 #endif
struct rte_port_source_params source;
+   struct rte_port_sym_crypto_reader_params sym_crypto;
} pp;
 
struct pipeline *pipeline;
@@ -295,6 +298,27 @@ pipeline_port_in_create(const char *pipeline_name,
break;
}
 
+   case PORT_IN_CRYPTODEV:
+   {
+   struct cryptodev *cryptodev;
+
+   cryptodev = cryptodev_find(params->dev_name);
+   if (cryptodev == NULL)
+   return -1;
+
+   if (params->rxq.queue_id > cryptodev->n_queues - 1)
+   return -1;
+
+   pp.sym_crypto.cryptodev_id = cryptodev->dev_id;
+   pp.sym_crypto.queue_id = params->cryptodev.queue_id;
+   pp.sym_crypto.f_callback = params->cryptodev.f_callback;
+   pp.sym_crypto.arg_callback = params->cryptodev.arg_callback;
+   p.ops = &rte_port_sym_crypto_reader_ops;
+   p.arg_create = &pp.sym_crypto;
+
+   break;
+   }
+
default:
return -1;
}
@@ -384,6 +408,7 @@ pipeline_port_out_create(const char *pipeline_name,
struct rte_port_kni_writer_params kni;
 #endif
struct rte_port_sink_params sink;
+   struct rte_port_sym_crypto_writer_params sym_crypto;
} pp;
 
union {
@@ -393,6 +418,7 @@ pipeline_port_out_create(const char *pipeline_name,
 #ifdef RTE_LIBRTE_KNI
struct rte_port_kni_writer_nodrop_params kni;
 #endif
+   struct rte_port_sym_crypto_writer_nodrop_params sym_crypto;
} pp_nodrop;
 
struct pipeline *pipeline;
@@ -548,6 +574,40 @@ pipeline_port_out_create(const char *pipeline_name,
break;
}
 
+   case PORT_OUT_CRYPTODEV:
+   {
+   struct cryptodev *cryptodev;
+
+   cryptodev = cryptodev_find(params->dev_name);
+   if (cryptodev == NULL)
+   return -1;
+
+   if (params->cryptodev.queue_id >= cryptodev->n_queues)
+   return -1;
+
+   pp.sym_crypto.cryptodev_id = cryptodev->dev_id;
+   pp.sym_crypto.queue_id = params->cryptodev.queue_id;
+   pp.sym_crypto.tx_burst_sz = params->burst_size;
+   pp.sym_crypto.crypto_op_offset = params->cryptodev.op_offset;
+
+   pp_nodrop.sym_crypto.cryptodev_id = cryptodev->dev_id;
+   pp_nodrop.sym_crypto.queue_id = params->cryptodev.queue_id;
+   pp_nodrop.sym_crypto.tx_burst_sz = params->burst_size;
+   pp_nodrop.sym_crypto.n_retries = params->retry;
+   pp_nodrop.sym_crypto.crypto_op_offset =
+   params->cryptodev.op_offset;
+
+   if (params->retry == 0) {
+   p.ops = &rte_port_sym_crypto_writer_ops;
+   p.arg_create = &pp.sym_crypto;
+   } else {
+   p.ops = &rte_port_sym_crypto_writer_nodrop_ops;
+   p.arg_create = &pp_nodrop.sym_crypto;
+   }
+
+   break;
+   }
+
default:
return -1;
}
diff --git a/examples/ip_pipeline/pipeline.h b/examples/ip_pipeline/pipeline.h
index a953a29fa..fb283e558 100644
--- a/examples/ip_pipeline/pipeline.h
+++ b/examples/ip_pipeline/pipeline.h
@@ -27,6 +27,7 @@ enum port_in_type {
PORT_IN_TAP,
PORT_IN_KNI,
PORT_IN_SOURCE,
+   PORT_IN_CRYPTODEV,
 };
 
 struct port_in_params {
@@ -48,6 +49,12 @@ struct port_in_params {
const char *file_name;
uint32_t n_bytes_per_pkt;
} source;
+
+   struct {
+   uint16_t queue_id;
+   void *f_callback;
+   void *arg_callback;
+   } cryptodev;
};
uint32_t burst_size;
 
@@ -62,6 +69,7 @@ enum port_out_type {
PORT_OUT_TAP,
PORT_OUT_KNI,
 

[dpdk-dev] [PATCH v2 4/7] examples/ip_pipeline: add symmetric crypto action

[Fan Zhang]

From: "Zhang, Roy Fan" 

This patch adds symmetric crypto action support to ip_pipeline
application.

Signed-off-by: Zhang, Roy Fan 
Acked-by: Dumitrescu, Cristian 
---
 examples/ip_pipeline/action.c   | 11 +++
 examples/ip_pipeline/action.h   |  1 +
 examples/ip_pipeline/pipeline.h |  1 +
 examples/ip_pipeline/thread.c   | 10 ++
 4 files changed, 23 insertions(+)

diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
index 20497c3c7..a0f97bee7 100644
--- a/examples/ip_pipeline/action.c
+++ b/examples/ip_pipeline/action.c
@@ -333,6 +333,17 @@ table_action_profile_create(const char *name,
}
}
 
+   if (params->action_mask & (1LLU << RTE_TABLE_ACTION_SYM_CRYPTO)) {
+   status = rte_table_action_profile_action_register(ap,
+   RTE_TABLE_ACTION_SYM_CRYPTO,
+   ¶ms->sym_crypto);
+
+   if (status) {
+   rte_table_action_profile_free(ap);
+   return NULL;
+   }
+   }
+
status = rte_table_action_profile_freeze(ap);
if (status) {
rte_table_action_profile_free(ap);
diff --git a/examples/ip_pipeline/action.h b/examples/ip_pipeline/action.h
index 417200e86..cde17e69a 100644
--- a/examples/ip_pipeline/action.h
+++ b/examples/ip_pipeline/action.h
@@ -53,6 +53,7 @@ struct table_action_profile_params {
struct rte_table_action_nat_config nat;
struct rte_table_action_ttl_config ttl;
struct rte_table_action_stats_config stats;
+   struct rte_table_action_sym_crypto_config sym_crypto;
 };
 
 struct table_action_profile {
diff --git a/examples/ip_pipeline/pipeline.h b/examples/ip_pipeline/pipeline.h
index fb283e558..b6b9dc06f 100644
--- a/examples/ip_pipeline/pipeline.h
+++ b/examples/ip_pipeline/pipeline.h
@@ -281,6 +281,7 @@ struct table_rule_action {
struct rte_table_action_ttl_params ttl;
struct rte_table_action_stats_params stats;
struct rte_table_action_time_params time;
+   struct rte_table_action_sym_crypto_params sym_crypto;
 };
 
 int
diff --git a/examples/ip_pipeline/thread.c b/examples/ip_pipeline/thread.c
index 7fc03332e..ca741952a 100644
--- a/examples/ip_pipeline/thread.c
+++ b/examples/ip_pipeline/thread.c
@@ -2476,6 +2476,16 @@ action_convert(struct rte_table_action *a,
return status;
}
 
+   if (action->action_mask & (1LLU << RTE_TABLE_ACTION_SYM_CRYPTO)) {
+   status = rte_table_action_apply(a,
+   data,
+   RTE_TABLE_ACTION_SYM_CRYPTO,
+   &action->sym_crypto);
+
+   if (status)
+   return status;
+   }
+
return 0;
 }
 
-- 
2.13.6

[dpdk-dev] [PATCH v2 7/7] doc: update action documentation

[Fan Zhang]

From: "Zhang, Roy Fan" 

Signed-off-by: Zhang, Roy Fan 
Acked-by: Dumitrescu, Cristian 
---
 doc/guides/prog_guide/packet_framework.rst | 11 ++-
 doc/guides/sample_app_ug/ip_pipeline.rst   | 23 +++
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/doc/guides/prog_guide/packet_framework.rst 
b/doc/guides/prog_guide/packet_framework.rst
index f0b485669..48d257501 100644
--- a/doc/guides/prog_guide/packet_framework.rst
+++ b/doc/guides/prog_guide/packet_framework.rst
@@ -98,6 +98,10 @@ Port Types
|   |  | character device.  
   |
|   |  |
   |

+---+--+---+
+   | 9 | Sym_crypto   | Output port used to extract DPDK Cryptodev 
operations from a fixed offset of the  |
+   |   |  | packet and then enqueue to the Cryptodev PMD. 
Input port used to dequeue the  |
+   |   |  | Cryptodev operations from the Cryptodev PMD and 
then retrieve the packets from them.  |
+   
+---+--+---+
 
 Port Interface
 ~~
@@ -1078,6 +1082,11 @@ with each table entry having its own set of enabled user 
actions and its own cop
|   |   | checksum. 
  |
|   |   |   
  |

+---+---+-+
+   | 7 | Sym Crypto| Generate Cryptodev session based 
on the user-specified algorithm|
+   |   |   | and key(s), and assemble the 
cryptodev operation based on the   |
+   |   |   | predefined offsets.   
  |
+   |   |   |   
  |
+   
+---+---+-+
 
 Multicore Scaling
 -
@@ -1133,7 +1142,7 @@ Typical devices with acceleration capabilities are:
 
 *   Inline accelerators: NICs, switches, FPGAs, etc;
 
-*   Look-aside accelerators: chipsets, FPGAs, etc.
+*   Look-aside accelerators: chipsets, FPGAs, Intel QuickAssist, etc.
 
 Usually, to support a specific functional block, specific implementation of 
Packet Framework tables and/or ports and/or actions has to be provided for each 
accelerator,
 with all the implementations sharing the same API: pure SW implementation (no 
acceleration), implementation using accelerator A, implementation using 
accelerator B, etc.
diff --git a/doc/guides/sample_app_ug/ip_pipeline.rst 
b/doc/guides/sample_app_ug/ip_pipeline.rst
index b75509a0b..447a544d5 100644
--- a/doc/guides/sample_app_ug/ip_pipeline.rst
+++ b/doc/guides/sample_app_ug/ip_pipeline.rst
@@ -304,6 +304,15 @@ Kni
 [thread ]
 
 
+Cryptodev
+~
+
+  Create cryptodev port ::
+
+   cryptodev 
+dev 
+queue  
+
 Action profile
 ~~
 
@@ -330,6 +339,8 @@ Action profile
[ttl drop | fwd
stats none | pkts]
[stats pkts | bytes | both]
+   [sym_crypto cryptodev 
+   mempool_create  mempool_init ]
[time]
 
 
@@ -471,6 +482,18 @@ Add rule to table for specific pipeline instance ::
  [ttl dec | keep]
  [stats]
  [time]
+ [sym_crypto
+encrypt | decrypt
+type
+| cipher
+   cipher_algo  cipher_key  cipher_iv 
+| cipher_auth
+   cipher_algo  cipher_key  cipher_iv 
+   auth_algo  auth_key  digest_size 
+| aead
+   aead_algo  aead_key  aead_iv  aead_aad 
+   digest_size 
+data_offset ]
 
   where:
   ::= g | y | r | drop
-- 
2.13.6

[dpdk-dev] [PATCH v2 5/7] examples/ip_pipeline: update cli parsing

[Fan Zhang]

From: "Zhang, Roy Fan" 

This patch updates the cli parsing of ip_pipeline application
with extra symmetric crypto, port, session, and action support.

Signed-off-by: Zhang, Roy Fan 
Acked-by: Dumitrescu, Cristian 
---
 examples/ip_pipeline/cli.c | 577 -
 1 file changed, 575 insertions(+), 2 deletions(-)

diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 01c37691f..3ff7caaca 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -12,6 +12,8 @@
 #include 
 
 #include "cli.h"
+
+#include "cryptodev.h"
 #include "kni.h"
 #include "link.h"
 #include "mempool.h"
@@ -785,6 +787,65 @@ cmd_kni(char **tokens,
}
 }
 
+static const char cmd_cryptodev_help[] =
+"cryptodev \n"
+"   dev  | dev_id \n"
+"   queue  \n";
+
+static void
+cmd_cryptodev(char **tokens,
+   uint32_t n_tokens,
+   char *out,
+   size_t out_size)
+{
+   struct cryptodev_params params;
+   char *name;
+
+   memset(¶ms, 0, sizeof(params));
+   if (n_tokens != 7) {
+   snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);
+   return;
+   }
+
+   name = tokens[1];
+
+   if (strcmp(tokens[2], "dev") == 0)
+   params.dev_name = tokens[3];
+   else if (strcmp(tokens[2], "dev_id") == 0) {
+   if (parser_read_uint32(¶ms.dev_id, tokens[3]) < 0) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "dev_id");
+   return;
+   }
+   } else {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "cryptodev");
+   return;
+   }
+
+   if (strcmp(tokens[4], "queue")) {
+   snprintf(out, out_size, MSG_ARG_NOT_FOUND,
+   "4");
+   return;
+   }
+
+   if (parser_read_uint32(¶ms.n_queues, tokens[5]) < 0) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "q");
+   return;
+   }
+
+   if (parser_read_uint32(¶ms.queue_size, tokens[6]) < 0) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "queue_size");
+   return;
+   }
+
+   if (cryptodev_create(name, ¶ms) == NULL) {
+   snprintf(out, out_size, MSG_CMD_FAIL, tokens[0]);
+   return;
+   }
+}
 
 static const char cmd_port_in_action_profile_help[] =
 "port in action profile \n"
@@ -968,7 +1029,10 @@ static const char cmd_table_action_profile_help[] =
 "   [ttl drop | fwd\n"
 "   stats none | pkts]\n"
 "   [stats pkts | bytes | both]\n"
-"   [time]\n";
+"   [time]\n"
+"   [sym_crypto dev  offset  "
+"   mempool_create \n"
+"   mempool_init ]\n";
 
 static void
 cmd_table_action_profile(char **tokens,
@@ -1336,6 +1400,57 @@ cmd_table_action_profile(char **tokens,
t0 += 1;
} /* time */
 
+   if ((t0 < n_tokens) && (strcmp(tokens[t0], "sym_crypto") == 0)) {
+   struct cryptodev *cryptodev;
+   struct mempool *mempool;
+
+   if (n_tokens < t0 + 9 ||
+   strcmp(tokens[t0 + 1], "dev") ||
+   strcmp(tokens[t0 + 3], "offset") ||
+   strcmp(tokens[t0 + 5], "mempool_create") ||
+   strcmp(tokens[t0 + 7], "mempool_init")) {
+   snprintf(out, out_size, MSG_ARG_MISMATCH,
+   "table action profile sym_crypto");
+   return;
+   }
+
+   cryptodev = cryptodev_find(tokens[t0 + 2]);
+   if (cryptodev == NULL) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "table action profile sym_crypto");
+   return;
+   }
+
+   p.sym_crypto.cryptodev_id = cryptodev->dev_id;
+
+   if (parser_read_uint32(&p.sym_crypto.op_offset,
+   tokens[t0 + 4]) != 0) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "table action profile sym_crypto");
+   return;
+   }
+
+   mempool = mempool_find(tokens[t0 + 6]);
+   if (mempool == NULL) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "table action profile sym_crypto");
+   return;
+   }
+   p.sym_crypto.mp_create = mempool->m;
+
+   mempool = mempool_find(tokens[t0 + 8]);
+   if (mempool == NULL) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "table action profile sym_crypto");
+   return;
+   }
+   p.sym_crypto.mp_init = mempool->m;
+
+   p.action_mask |= 1LLU << RTE_TA

[dpdk-dev] [PATCH v2 6/7] examples/ip_pipeline: add script

[Fan Zhang]

From: "Zhang, Roy Fan" 

Signed-off-by: Zhang, Roy Fan 
Acked-by: Dumitrescu, Cristian 
---
 examples/ip_pipeline/examples/flow_crypto.cli | 58 +++
 1 file changed, 58 insertions(+)
 create mode 100644 examples/ip_pipeline/examples/flow_crypto.cli

diff --git a/examples/ip_pipeline/examples/flow_crypto.cli 
b/examples/ip_pipeline/examples/flow_crypto.cli
new file mode 100644
index 0..9b639deb7
--- /dev/null
+++ b/examples/ip_pipeline/examples/flow_crypto.cli
@@ -0,0 +1,58 @@
+; SPDX-License-Identifier: BSD-3-Clause
+; Copyright(c) 2018 Intel Corporation
+
+; 
+; LINK0 RXQ0 --->||---> CRYPTO0 TXQ0
+;|  Flow  |
+; CRYPTO0 RXQ0-->| Classification |---> LINK0 TXQ0
+;||
+;|
+;+---> SINK0 (flow lookup miss)
+;
+; Input packet: Ethernet/IPv4
+;
+; Packet buffer layout:
+; #   Field Name   Offset (Bytes)   Size (Bytes)
+; 0   Mbuf 0128
+; 1   Headroom 128  128
+; 2   Ethernet header  256  14
+; 3   IPv4 header  280  20
+; 4   Packet   256  1536
+; 5   Crypto Operation 1792 160
+
+mempool MEMPOOL0 buffer 2304 pool 32K cache 256 cpu 1
+mempool MEMPOOL_SESSION0 buffer 1024 pool 1024 cache 128 cpu 1
+
+link LINK0 dev :81:00.0 rxq 1 128 MEMPOOL0 txq 1 512 promiscuous on
+
+#Cryptodev
+cryptodev CRYPTO0 dev crypto_aesni_gcm0 queue 1 1024
+
+table action profile AP0 ipv4 offset 270 fwd sym_crypto dev CRYPTO0 offset 
1792 mempool_create MEMPOOL_SESSION0 mempool_init MEMPOOL_SESSION0
+table action profile AP1 ipv4 offset 270 fwd
+
+pipeline PIPELINE0 period 10 offset_port_id 0 cpu 1
+
+pipeline PIPELINE0 port in bsz 32 link LINK0 rxq 0
+pipeline PIPELINE0 port in bsz 32 cryptodev CRYPTO0 rxq 0
+
+pipeline PIPELINE0 port out bsz 32 cryptodev CRYPTO0 txq 0 offset 1792
+pipeline PIPELINE0 port out bsz 32 link LINK0 txq 0
+pipeline PIPELINE0 port out bsz 32 sink
+
+pipeline PIPELINE0 table match hash ext key 8 mask  offset 282 
buckets 1K size 4K action AP0
+pipeline PIPELINE0 table match stub action AP1
+
+pipeline PIPELINE0 port in 0 table 0
+pipeline PIPELINE0 port in 1 table 1
+
+thread 24 pipeline PIPELINE0 enable
+
+pipeline PIPELINE0 table 0 rule add match default action fwd port 2
+
+#AES-GCM encrypt
+pipeline PIPELINE0 table 0 rule add match hash ipv4_addr 100.0.0.10 action fwd 
port 0 sym_crypto encrypt type aead aead_algo aes-gcm aead_key 
000102030405060708090a0b0c0d0e0f aead_iv 000102030405060708090a0b aead_aad 
000102030405060708090a0b0c0d0e0f digest_size 8 data_offset 290
+#AES-GCM decrypt
+#pipeline PIPELINE0 table 0 rule add match hash ipv4_addr 100.0.0.10 action 
fwd port 0 sym_crypto decrypt type aead aead_algo aes-gcm aead_key 
000102030405060708090a0b0c0d0e0f aead_iv 000102030405060708090a0b aead_aad 
000102030405060708090a0b0c0d0e0f digest_size 8 data_offset 290
+
+pipeline PIPELINE0 table 1 rule add match default action fwd port 1
-- 
2.13.6

Re: [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update

[Hunt, David]

Hi Liang,


I think section 21.4 "Running the Application" needs mention the empty 
poll feature. Maybe just add a mention


*   --empty-poll: Traffic Aware power management. See below for details.



On 25/9/2018 2:20 PM, Kovacevic, Marko wrote:

Add empty poll mode command line example

Signed-off-by: Liang Ma 
---
  doc/guides/sample_app_ug/l3_forward_power_man.rst | 29
+++
  1 file changed, 29 insertions(+)

+Empty Poll Mode
+-
+There is a new Mode which is added recently. Empty poll mode can be
+enabled by command option --empty-poll.


In a couple of years time, it won't be 'new' or 'recent' any more. :)

Suggest:

Additionally, there is a traffic aware mode of operation called "Empty
Poll" where the number of empty polls can be monitored to keep track
of how busy the application is.Empty poll mode can be enabled by the
command line option --empty-poll.


+
+See "Power Management" chapter in the DPDK Programmer's Guide for
empty poll mode details.

Can you embed the link to the Power Management chapter
:doc:`Power Management<../prog_guide/power_man>`



+.. code-block:: console
+
+./l3fwd-power -l xxx   -n 4   -w :xx:00.0 -w :xx:00.1 -- -p 0x3 -P 
--
config="(0,0,xx),(1,0,xx)" --empty-poll="0,0,0" -l 14 -m 9 -h 1
+
+Where,
+
+--empty-poll: Enable the empty poll mode instead of original algorithm
+
+--empty-poll="training_flag, med_threshold, high_threshold"
+
+* training_flag : optional, enable/disable training mode. Default value is 0.
+
+* med_threshold : optional, indicate the empty poll threshold of modest
state which is customized by user. Default value is 0.
+
+* high_threshold : optional, indicate the empty poll threshold of busy state
which is customized by user. Default value is 0.
+
+* -l : optional, set up the LOW power state frequency index
+
+* -m : optional, set up the MED power state frequency index
+
+* -h : optional, set up the HIGH power state frequency index

I think in this over all section needs a lot more explanation like what are 
valid training flags and how to get thresholds ect.

Also you could highlight the commands it looks better:  ``training_flag``


I'd suggest adding a "Empty Poll Mode Example Usage" section as a 
sub-section to the "Empty Poll Mode" section, which could contain 
something along the lines of the following:


Empty Poll Mode Example Usage

To initially obtain the ideal thresholds for the system, the training 
mode should be run first. This is achieved by running the l3fwd-power 
app with the training flage set to “1”, and the other paramaters set to 0.


./examples/l3fwd-power/build/l3fwd-power -l 1-3 -- -p 0x0f 
--config="(0,0,2),(0,1,3)" --empty-poll "1,0,0" –P


This will run the training algorithm for x seconds on each core (cores 2 
and 3), and then print out the recommended threshold values for those 
cores. The thresholds should be very similar for each core.


POWER: Bring up the Timer
POWER: set the power freq to MED
POWER: Low threshold is 230277
POWER: MED threshold is 335071
POWER: HIGH threshold is 523769
POWER: Training is Complete for 2
POWER: set the power freq to MED
POWER: Low threshold is 236814
POWER: MED threshold is 344567
POWER: HIGH threshold is 538580
POWER: Training is Complete for 3

Once the values have been measured for a particular system, the app can 
then be started without the training mode so traffic can start immediately.


./examples/l3fwd-power/build/l3fwd-power -l 1-3 -- -p 0x0f 
--config="(0,0,2),(0,1,3)" --empty-poll "0,34,54" –P

Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

[Stephen Hemminger]

In general, an API is less error prone if it only does return by value.
What about just returning fd or -1?


On Fri, Sep 28, 2018, 5:55 AM Xiaoyun Li  wrote:

> Some users want to use their own epoll instances to control both
> DPDK rxq interrupt fds and their own other fds. So added a function
> to get rxq interrupt fd based on port id and queue id.
>
> Signed-off-by: Xiaoyun Li 
> ---
>  lib/librte_ethdev/rte_ethdev.c | 37 ++
>  lib/librte_ethdev/rte_ethdev.h |  3 +++
>  2 files changed, 40 insertions(+)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.c
> b/lib/librte_ethdev/rte_ethdev.c
> index ef99f7068..c21124e32 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -3433,6 +3433,43 @@ rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd,
> int op, void *data)
> return 0;
>  }
>
> +int
> +rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id,
> +int *fd)
> +{
> +   struct rte_intr_handle *intr_handle;
> +   struct rte_eth_dev *dev;
> +   unsigned int efd_idx;
> +   uint32_t vec;
> +
> +   RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
> +
> +   dev = &rte_eth_devices[port_id];
> +
> +   if (queue_id >= dev->data->nb_rx_queues) {
> +   RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", queue_id);
> +   return -EINVAL;
> +   }
> +
> +   if (!dev->intr_handle) {
> +   RTE_ETHDEV_LOG(ERR, "RX Intr handle unset\n");
> +   return -ENOTSUP;
> +   }
> +
> +   intr_handle = dev->intr_handle;
> +   if (!intr_handle->intr_vec) {
> +   RTE_ETHDEV_LOG(ERR, "RX Intr vector unset\n");
> +   return -EPERM;
> +   }
> +
> +   vec = intr_handle->intr_vec[queue_id];
> +   efd_idx = (vec >= RTE_INTR_VEC_RXTX_OFFSET) ?
> +   (vec - RTE_INTR_VEC_RXTX_OFFSET) : vec;
> +   *fd = intr_handle->efds[efd_idx];
> +
> +   return 0;
> +}
> +
>  const struct rte_memzone *
>  rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char
> *ring_name,
>  uint16_t queue_id, size_t size, unsigned align,
> diff --git a/lib/librte_ethdev/rte_ethdev.h
> b/lib/librte_ethdev/rte_ethdev.h
> index 012577b0a..3670d7249 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -2719,6 +2719,9 @@ int rte_eth_dev_rx_intr_ctl(uint16_t port_id, int
> epfd, int op, void *data);
>  int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
>   int epfd, int op, void *data);
>
> +int rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id,
> +int *fd);
> +
>  /**
>   * Turn on the LED on the Ethernet device.
>   * This function turns on the LED on the Ethernet device.
> --
> 2.17.1
>
>

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

[Ferruh Yigit]

On 9/8/2018 12:39 AM, Thomas Monjalon wrote:
> After closing a port, it cannot be restarted.
> So there is no reason to not free all associated resources.
> 
> The last step was done with rte_eth_dev_detach() which is deprecated.
> Instead of removing the associated rte_device, the driver should check
> if no more port (ethdev, cryptodev, etc) is still open for the device.
> Then the device resources can be freed by the driver inside the
> dev_close() driver callback operation.
> 
> The last ethdev freeing (dev_private and final release), which were done
> by rte_eth_dev_detach(), are now done at the end of rte_eth_dev_close().
> 
> Signed-off-by: Thomas Monjalon 
> ---
> This patch contains only the change in the close function as RFC.
> 
> This idea was presented at Dublin during the "hotplug talk".
> ---
>  lib/librte_ethdev/rte_ethdev.c | 5 +
>  lib/librte_ethdev/rte_ethdev.h | 5 +++--
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 4c3202505..071fcbd23 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -1358,6 +1358,7 @@ void
>  rte_eth_dev_close(uint16_t port_id)
>  {
>   struct rte_eth_dev *dev;
> + struct rte_bus *bus;
>  
>   RTE_ETH_VALID_PORTID_OR_RET(port_id);
>   dev = &rte_eth_devices[port_id];
> @@ -1372,6 +1373,10 @@ rte_eth_dev_close(uint16_t port_id)
>   dev->data->nb_tx_queues = 0;
>   rte_free(dev->data->tx_queues);
>   dev->data->tx_queues = NULL;
> +
> + rte_free(dev->data->dev_private);
> +
> + rte_eth_dev_release_port(dev);

These already done in:
rte_eth_dev_pci_generic_remove()
rte_eth_dev_pci_release()

Perhaps all content of rte_eth_dev_pci_release(), including above updates,
should move to rte_eth_dev_close() and rte_eth_dev_pci_generic_remove() call
rte_eth_dev_close() directly.


Just thinking aloud,

driver->probe() called when a new device added.
Application startup can be thought as all devices added one by one. [Perhaps
this can be change in the future to add devices only when explicitly stated]

driver->remove() called when device removed.
When application terminated this path not called at all, perhaps we need a way
to remove all devices one by one on exit.

eth_dev_close(), when eth_dev removed in ethdev layer but device is not removed
in eal level,

I think it make sense for eth_dev_close():
- It does more cleanup, free resources and port_id
- but it may need to do more clean up, like call uninit() and do more driver
internal clean up too, and clean up the hw.
- so call stack can be:
  driver->remove()
rte_eth_dev_pci_generic_remove()
  eth_dev_close()
dev_uninit() [driver unint function ]


Another question, after eth_dev_close() ethdev is not usable and not able to
restart it back. So why we need eth_dev_close() in addition to dev remove, why
not directly call rte_eth_dev_detach()?


>  }
>  
>  int
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index 7070e9ab4..37a757a7a 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -1797,8 +1797,9 @@ int rte_eth_dev_set_link_down(uint16_t port_id);
>  
>  /**
>   * Close a stopped Ethernet device. The device cannot be restarted!
> - * The function frees all resources except for needed by the
> - * closed state. To free these resources, call rte_eth_dev_detach().
> + * The function frees all port resources.
> + * If there is no more port associated with the underlying device,
> + * the driver should free the device resources.
>   *
>   * @param port_id
>   *   The port identifier of the Ethernet device.
> 

Re: [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update

[Liang, Ma]

Hi Dave, 
   thanks for your feedback. I will update document in v9.

O 28 Sep 13:43, Hunt, David wrote:
> Hi Liang,
> 
> 
> I think section 21.4 "Running the Application" needs mention the empty 
> poll feature. Maybe just add a mention
> 
> *   --empty-poll: Traffic Aware power management. See below for details.
> 
> 
> 
> On 25/9/2018 2:20 PM, Kovacevic, Marko wrote:
> >>Add empty poll mode command line example
> >>
> >>Signed-off-by: Liang Ma 
> >>---
> >>  doc/guides/sample_app_ug/l3_forward_power_man.rst | 29
> >>+++
> >>  1 file changed, 29 insertions(+)
> >>
> >>+Empty Poll Mode
> >>+-
> >>+There is a new Mode which is added recently. Empty poll mode can be
> >>+enabled by command option --empty-poll.
> 
> In a couple of years time, it won't be 'new' or 'recent' any more. :)
> 
> Suggest:
> 
> Additionally, there is a traffic aware mode of operation called "Empty
> Poll" where the number of empty polls can be monitored to keep track
> of how busy the application is.Empty poll mode can be enabled by the
> command line option --empty-poll.
> 
> >>+
> >>+See "Power Management" chapter in the DPDK Programmer's Guide for
> >>empty poll mode details.
> >Can you embed the link to the Power Management chapter
> >:doc:`Power Management<../prog_guide/power_man>`
> >
> >
> >>+.. code-block:: console
> >>+
> >>+./l3fwd-power -l xxx   -n 4   -w :xx:00.0 -w :xx:00.1 -- -p 
> >>0x3 -P --
> >>config="(0,0,xx),(1,0,xx)" --empty-poll="0,0,0" -l 14 -m 9 -h 1
> >>+
> >>+Where,
> >>+
> >>+--empty-poll: Enable the empty poll mode instead of original algorithm
> >>+
> >>+--empty-poll="training_flag, med_threshold, high_threshold"
> >>+
> >>+* training_flag : optional, enable/disable training mode. Default value 
> >>is 0.
> >>+
> >>+* med_threshold : optional, indicate the empty poll threshold of modest
> >>state which is customized by user. Default value is 0.
> >>+
> >>+* high_threshold : optional, indicate the empty poll threshold of busy 
> >>state
> >>which is customized by user. Default value is 0.
> >>+
> >>+* -l : optional, set up the LOW power state frequency index
> >>+
> >>+* -m : optional, set up the MED power state frequency index
> >>+
> >>+* -h : optional, set up the HIGH power state frequency index
> >I think in this over all section needs a lot more explanation like what 
> >are valid training flags and how to get thresholds ect.
> >
> >Also you could highlight the commands it looks better:  
> >``training_flag``
> 
> I'd suggest adding a "Empty Poll Mode Example Usage" section as a 
> sub-section to the "Empty Poll Mode" section, which could contain 
> something along the lines of the following:
> 
> Empty Poll Mode Example Usage
> 
> To initially obtain the ideal thresholds for the system, the training 
> mode should be run first. This is achieved by running the l3fwd-power 
> app with the training flage set to “1”, and the other paramaters set to 
> 0.
> 
> ./examples/l3fwd-power/build/l3fwd-power -l 1-3 -- -p 0x0f 
> --config="(0,0,2),(0,1,3)" --empty-poll "1,0,0" –P
> 
> This will run the training algorithm for x seconds on each core (cores 2 
> and 3), and then print out the recommended threshold values for those 
> cores. The thresholds should be very similar for each core.
> 
> POWER: Bring up the Timer
> POWER: set the power freq to MED
> POWER: Low threshold is 230277
> POWER: MED threshold is 335071
> POWER: HIGH threshold is 523769
> POWER: Training is Complete for 2
> POWER: set the power freq to MED
> POWER: Low threshold is 236814
> POWER: MED threshold is 344567
> POWER: HIGH threshold is 538580
> POWER: Training is Complete for 3
> 
> Once the values have been measured for a particular system, the app can 
> then be started without the training mode so traffic can start immediately.
> 
> ./examples/l3fwd-power/build/l3fwd-power -l 1-3 -- -p 0x0f 
> --config="(0,0,2),(0,1,3)" --empty-poll "0,34,54" –P
> 
> 
> 

[dpdk-dev] [PATCH] compressdev: fix compression api description

[Tomasz Jozwiak]

This patch fixes descripton of API functions:
  -  rte_comp_op_raw_bulk_alloc
  -  rte_comp_op_bulk_alloc

Fixes: 96086db5a369 ("compressdev: add operation management")
Signed-off-by: Tomasz Jozwiak 
---
 lib/librte_compressdev/rte_comp.c | 4 ++--
 lib/librte_compressdev/rte_comp.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_compressdev/rte_comp.c 
b/lib/librte_compressdev/rte_comp.c
index 98ad0cf..c663be5 100644
--- a/lib/librte_compressdev/rte_comp.c
+++ b/lib/librte_compressdev/rte_comp.c
@@ -83,8 +83,8 @@ struct rte_comp_op_pool_private {
  * @param nb_ops
  *   Number of operations to allocate
  * @return
- *   - 0: Success
- *   - -ENOENT: Not enough entries in the mempool; no ops are retrieved.
+ *   - nb_ops: Success, the nb_ops requested was allocated
+ *   - 0: Not enough entries in the mempool; no ops are retrieved.
  */
 static inline int
 rte_comp_op_raw_bulk_alloc(struct rte_mempool *mempool,
diff --git a/lib/librte_compressdev/rte_comp.h 
b/lib/librte_compressdev/rte_comp.h
index ee9056e..395ce29 100644
--- a/lib/librte_compressdev/rte_comp.h
+++ b/lib/librte_compressdev/rte_comp.h
@@ -448,8 +448,8 @@ rte_comp_op_alloc(struct rte_mempool *mempool);
  * @param nb_ops
  *   Number of operations to allocate
  * @return
- *   - 0: Success
- *   - -ENOENT: Not enough entries in the mempool; no ops are retrieved.
+ *   - nb_ops: Success, the nb_ops requested was allocated
+ *   - 0: Not enough entries in the mempool; no ops are retrieved.
  */
 int __rte_experimental
 rte_comp_op_bulk_alloc(struct rte_mempool *mempool,
-- 
2.7.4

Re: [dpdk-dev] [PATCH v3] test/event: fix RSS config in eth Rx adapter test

[Jerin Jacob]

-Original Message-
> Date: Tue, 25 Sep 2018 08:45:49 +0530
> From: Jerin Jacob 
> To: Nikhil Rao 
> CC: dev@dpdk.org, sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] test/event: fix RSS config in eth Rx
>  adapter test
> User-Agent: Mutt/1.10.1 (2018-07-13)
> 
> 
> -Original Message-
> > Date: Mon, 24 Sep 2018 14:23:47 +0530
> > From: Nikhil Rao 
> > To: jerin.ja...@caviumnetworks.com
> > CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org
> > Subject: [PATCH v3] test/event: fix RSS config in eth Rx adapter test
> > X-Mailer: git-send-email 1.8.3.1
> >
> >
> > Remove RSS config as it is not required. The hardcoded RSS
> > configuration also generates an error on NICs that don't support
> > it.
> >
> > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> > CC: sta...@dpdk.org
> >
> > Signed-off-by: Nikhil Rao 
> 
> Acked-by: Jerin Jacob 
> 

Applied to dpdk-next-eventdev/master. Thanks.

> 

[dpdk-dev] [PATCH] compressdev: fix compression api description

[Tomasz Jozwiak]

This patch fixes description of API functions:
  -  rte_comp_op_raw_bulk_alloc
  -  rte_comp_op_bulk_alloc

Fixes: 96086db5a369 ("compressdev: add operation management")
Signed-off-by: Tomasz Jozwiak 
---
 lib/librte_compressdev/rte_comp.c | 4 ++--
 lib/librte_compressdev/rte_comp.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_compressdev/rte_comp.c 
b/lib/librte_compressdev/rte_comp.c
index 98ad0cf..c663be5 100644
--- a/lib/librte_compressdev/rte_comp.c
+++ b/lib/librte_compressdev/rte_comp.c
@@ -83,8 +83,8 @@ struct rte_comp_op_pool_private {
  * @param nb_ops
  *   Number of operations to allocate
  * @return
- *   - 0: Success
- *   - -ENOENT: Not enough entries in the mempool; no ops are retrieved.
+ *   - nb_ops: Success, the nb_ops requested was allocated
+ *   - 0: Not enough entries in the mempool; no ops are retrieved.
  */
 static inline int
 rte_comp_op_raw_bulk_alloc(struct rte_mempool *mempool,
diff --git a/lib/librte_compressdev/rte_comp.h 
b/lib/librte_compressdev/rte_comp.h
index ee9056e..395ce29 100644
--- a/lib/librte_compressdev/rte_comp.h
+++ b/lib/librte_compressdev/rte_comp.h
@@ -448,8 +448,8 @@ rte_comp_op_alloc(struct rte_mempool *mempool);
  * @param nb_ops
  *   Number of operations to allocate
  * @return
- *   - 0: Success
- *   - -ENOENT: Not enough entries in the mempool; no ops are retrieved.
+ *   - nb_ops: Success, the nb_ops requested was allocated
+ *   - 0: Not enough entries in the mempool; no ops are retrieved.
  */
 int __rte_experimental
 rte_comp_op_bulk_alloc(struct rte_mempool *mempool,
-- 
2.7.4

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

[Ilya Maximets]

On 28.09.2018 15:13, Bruce Richardson wrote:
> On Fri, Sep 28, 2018 at 01:40:25PM +0300, Ilya Maximets wrote:
>> On 27.09.2018 11:28, Ilya Maximets wrote:
>>> On 26.09.2018 10:26, Maxime Coquelin wrote:
 This patch opens a userfaultfd and sends it back to Qemu's
 VHOST_USER_POSTCOPY_ADVISE request.

 Signed-off-by: Dr. David Alan Gilbert 
 Signed-off-by: Maxime Coquelin 
 ---
  lib/librte_vhost/vhost.h  |  2 ++
  lib/librte_vhost/vhost_user.c | 37 +++
  lib/librte_vhost/vhost_user.h |  3 ++-
  3 files changed, 41 insertions(+), 1 deletion(-)

 diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
 index 25ffd7614..21722d8a8 100644
 --- a/lib/librte_vhost/vhost.h
 +++ b/lib/librte_vhost/vhost.h
 @@ -363,6 +363,8 @@ struct virtio_net {
int slave_req_fd;
rte_spinlock_t  slave_req_lock;
  
 +  int postcopy_ufd;
 +
/*
 * Device id to identify a specific backend device.
 * It's set to -1 for the default software implementation.
 diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
 index a9b429598..bdfe2cac0 100644
 --- a/lib/librte_vhost/vhost_user.c
 +++ b/lib/librte_vhost/vhost_user.c
 @@ -24,9 +24,13 @@
  #include 
  #include 
  #include 
 +#include 
 +#include 
>>>
>>> Maybe we need compile time check for this header existence?
>>> Otherwise, this will bump minimal kernel version for default linux build
>>> to something like 4.3.
>>
>> We'll need a config option here (disabled by default) and guard all
>> the postcopy related code.
>> Meson build will be able to detect the header file and enable
>> the config if possible. Like this:
>>
>> lib/librte_vhost/meson.build:
>> if cc.has_header('linux/userfaultfd.h')
>>dpdk_conf.set10('RTE_LIBRTE_VHOST_POSTCOPY', true)
> 
> Are you sure you want 'set10' rather than 'set'. Set is probably easier
> because it ensures no define on false, while set10 has a define of 0. This
> has caught me out before.
> 
> FYI, you can also avoid the if by putting the condition into the define:
> 
>   dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', cc.has_header('...'))

Sure, this variant looks better. Thanks for suggestions.
I just copied my version from the similar code for 'RTE_HAS_LIBNUMA'.

Best regards, Ilya Maximets.

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

[Bruce Richardson]

On Fri, Sep 28, 2018 at 04:17:34PM +0300, Ilya Maximets wrote:
> On 28.09.2018 15:13, Bruce Richardson wrote:
> > On Fri, Sep 28, 2018 at 01:40:25PM +0300, Ilya Maximets wrote:
> >> On 27.09.2018 11:28, Ilya Maximets wrote:
> >>> On 26.09.2018 10:26, Maxime Coquelin wrote:
>  This patch opens a userfaultfd and sends it back to Qemu's
>  VHOST_USER_POSTCOPY_ADVISE request.
> 
>  Signed-off-by: Dr. David Alan Gilbert 
>  Signed-off-by: Maxime Coquelin 
>  ---
>   lib/librte_vhost/vhost.h  |  2 ++
>   lib/librte_vhost/vhost_user.c | 37 +++
>   lib/librte_vhost/vhost_user.h |  3 ++-
>   3 files changed, 41 insertions(+), 1 deletion(-)
> 
>  diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
>  index 25ffd7614..21722d8a8 100644
>  --- a/lib/librte_vhost/vhost.h
>  +++ b/lib/librte_vhost/vhost.h
>  @@ -363,6 +363,8 @@ struct virtio_net {
>   int slave_req_fd;
>   rte_spinlock_t  slave_req_lock;
>   
>  +int postcopy_ufd;
>  +
>   /*
>    * Device id to identify a specific backend device.
>    * It's set to -1 for the default software implementation.
>  diff --git a/lib/librte_vhost/vhost_user.c 
>  b/lib/librte_vhost/vhost_user.c
>  index a9b429598..bdfe2cac0 100644
>  --- a/lib/librte_vhost/vhost_user.c
>  +++ b/lib/librte_vhost/vhost_user.c
>  @@ -24,9 +24,13 @@
>   #include 
>   #include 
>   #include 
>  +#include 
>  +#include 
> >>>
> >>> Maybe we need compile time check for this header existence?
> >>> Otherwise, this will bump minimal kernel version for default linux build
> >>> to something like 4.3.
> >>
> >> We'll need a config option here (disabled by default) and guard all
> >> the postcopy related code.
> >> Meson build will be able to detect the header file and enable
> >> the config if possible. Like this:
> >>
> >> lib/librte_vhost/meson.build:
> >> if cc.has_header('linux/userfaultfd.h')
> >>dpdk_conf.set10('RTE_LIBRTE_VHOST_POSTCOPY', true)
> > 
> > Are you sure you want 'set10' rather than 'set'. Set is probably easier
> > because it ensures no define on false, while set10 has a define of 0. This
> > has caught me out before.
> > 
> > FYI, you can also avoid the if by putting the condition into the define:
> > 
> > dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', cc.has_header('...'))
> 
> Sure, this variant looks better. Thanks for suggestions.
> I just copied my version from the similar code for 'RTE_HAS_LIBNUMA'.
> 

Yes, looking at that code, it could do with a clean-up to shorten it too.
[It's true that nothing embarasses a programmer more than their own code 6
months layer :-)]

/Bruce

Re: [dpdk-dev] [PATCH v2] event/octeontx: add Tx adapter support

[Jerin Jacob]

-Original Message-
> Date: Fri, 28 Sep 2018 17:11:33 +0530
> From: pavan.bhagavat...@cavium.com
> To: jerin.ja...@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh 
> Subject: [dpdk-dev] [PATCH v2] event/octeontx: add Tx adapter support
> X-Mailer: git-send-email 2.19.0
> 
> From: Pavan Nikhilesh 
> 
> Add Tx adapter support and move few routines around to avoid code
> duplication.
> 
> Signed-off-by: Pavan Nikhilesh 

Acked-by: Jerin Jacob 

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

[Maxime Coquelin]

On 09/28/2018 03:24 PM, Bruce Richardson wrote:

On Fri, Sep 28, 2018 at 04:17:34PM +0300, Ilya Maximets wrote:

On 28.09.2018 15:13, Bruce Richardson wrote:

On Fri, Sep 28, 2018 at 01:40:25PM +0300, Ilya Maximets wrote:

On 27.09.2018 11:28, Ilya Maximets wrote:

On 26.09.2018 10:26, Maxime Coquelin wrote:

This patch opens a userfaultfd and sends it back to Qemu's
VHOST_USER_POSTCOPY_ADVISE request.

Signed-off-by: Dr. David Alan Gilbert 
Signed-off-by: Maxime Coquelin 
---
  lib/librte_vhost/vhost.h  |  2 ++
  lib/librte_vhost/vhost_user.c | 37 +++
  lib/librte_vhost/vhost_user.h |  3 ++-
  3 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index 25ffd7614..21722d8a8 100644
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_vhost/vhost.h
@@ -363,6 +363,8 @@ struct virtio_net {
int slave_req_fd;
rte_spinlock_t  slave_req_lock;
  
+	int			postcopy_ufd;

+
/*
 * Device id to identify a specific backend device.
 * It's set to -1 for the default software implementation.
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index a9b429598..bdfe2cac0 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -24,9 +24,13 @@
  #include 
  #include 
  #include 
+#include 
+#include 


Maybe we need compile time check for this header existence?
Otherwise, this will bump minimal kernel version for default linux build
to something like 4.3.


We'll need a config option here (disabled by default) and guard all
the postcopy related code.
Meson build will be able to detect the header file and enable
the config if possible. Like this:

lib/librte_vhost/meson.build:
if cc.has_header('linux/userfaultfd.h')
dpdk_conf.set10('RTE_LIBRTE_VHOST_POSTCOPY', true)


Are you sure you want 'set10' rather than 'set'. Set is probably easier
because it ensures no define on false, while set10 has a define of 0. This
has caught me out before.

FYI, you can also avoid the if by putting the condition into the define:

dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', cc.has_header('...'))


Sure, this variant looks better. Thanks for suggestions.
I just copied my version from the similar code for 'RTE_HAS_LIBNUMA'.



Thanks Ilya & Bruce for the hint!
I'll do this in next version.


Yes, looking at that code, it could do with a clean-up to shorten it too.
[It's true that nothing embarasses a programmer more than their own code 6
months layer :-)]


:)

Maxime

/Bruce

Re: [dpdk-dev] [PATCH v3] eventdev: fix port id argument in Rx adapter caps API

[Jerin Jacob]

-Original Message-
> Date: Tue, 25 Sep 2018 15:19:05 +0530
> From: Nikhil Rao 
> To: jerin.ja...@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org
> Subject: [PATCH v3] eventdev: fix port id argument in Rx adapter caps API
> X-Mailer: git-send-email 1.8.3.1
> 
> Make the ethernet port id passed into
> rte_event_eth_rx_adapter_caps_get() 16 bit.
> 
> Also, update the event rx adapter test to use 16 bit
> ethernet port ids.
> 
> Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Nikhil Rao 
> Acked-by: Jerin Jacob 
> ---

Applied to dpdk-next-eventdev/master. Thanks.

[dpdk-dev] [PATCH v9 2/4] examples/l3fwd-power: simple app update for new API

[Liang Ma]

Add the support for new traffic pattern aware power control
power management API.

Example:
./l3fwd-power -l xxx   -n 4   -w :xx:00.0 -w :xx:00.1 -- -p 0x3
-P --config="(0,0,xx),(1,0,xx)" --empty-poll="0,0,0" -l 14 -m 9 -h 1

Please Reference l3fwd-power document for full parameter usage

The option "l", "m", "h" are used to set the power index for
LOW, MED, HIGH power state. Only is useful after enable empty-poll

--empty-poll="training_flag, med_threshold, high_threshold"

The option training_flag is used to enable/disable training mode.

The option med_threshold is used to indicate the empty poll threshold
of modest state which is customized by user.

The option high_threshold is used to indicate the empty poll threshold
of busy state which is customized by user.

Above three option default value is all 0.

Once enable empty-poll. System will apply the default parameter.
Training mode is disabled as default.

If training mode is triggered, there should not has any traffic
pass-through during training phase.
When training phase complete, system transfer to normal phase.

System will running with modest power stat at beginning.
If the system busyness percentage above 70%, then system will adjust
power state move to High power state. If the traffic become lower(eg. The
system busyness percentage drop below 30%), system will fallback
to the modest power state.

Example code use master thread to monitoring worker thread busyness.
the default timer resolution is 10ms.

ChangeLog:
v2 fix some coding style issues
v3 rename the API.
v6 re-work the API.
v7 no change.
v8 disable training as default option.

Signed-off-by: Liang Ma 

Reviewed-by: Lei Yao 
---
 examples/l3fwd-power/Makefile|   3 +
 examples/l3fwd-power/main.c  | 325 +--
 examples/l3fwd-power/meson.build |   1 +
 3 files changed, 312 insertions(+), 17 deletions(-)

diff --git a/examples/l3fwd-power/Makefile b/examples/l3fwd-power/Makefile
index d7e39a3..772ec7b 100644
--- a/examples/l3fwd-power/Makefile
+++ b/examples/l3fwd-power/Makefile
@@ -23,6 +23,8 @@ CFLAGS += -O3 $(shell pkg-config --cflags libdpdk)
 LDFLAGS_SHARED = $(shell pkg-config --libs libdpdk)
 LDFLAGS_STATIC = -Wl,-Bstatic $(shell pkg-config --static --libs libdpdk)
 
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+
 build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build
$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)
 
@@ -54,6 +56,7 @@ please change the definition of the RTE_TARGET environment 
variable)
 all:
 else
 
+CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 68527d2..1465608 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -43,6 +43,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "perf_core.h"
 #include "main.h"
@@ -55,6 +56,8 @@
 
 /* 100 ms interval */
 #define TIMER_NUMBER_PER_SECOND   10
+/* (10ms) */
+#define INTERVALS_PER_SECOND 100
 /* 10 us */
 #define SCALING_PERIOD(100/TIMER_NUMBER_PER_SECOND)
 #define SCALING_DOWN_TIME_RATIO_THRESHOLD 0.25
@@ -117,6 +120,11 @@
  */
 #define RTE_TEST_RX_DESC_DEFAULT 1024
 #define RTE_TEST_TX_DESC_DEFAULT 1024
+#define EMPTY_POLL_MED_THRESHOLD 35UL
+#define EMPTY_POLL_HGH_THRESHOLD 58UL
+
+
+
 static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;
 static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;
 
@@ -132,6 +140,14 @@ static uint32_t enabled_port_mask = 0;
 static int promiscuous_on = 0;
 /* NUMA is enabled by default. */
 static int numa_on = 1;
+/* emptypoll is disabled by default. */
+static bool empty_poll_on;
+static bool empty_poll_train;
+volatile bool empty_poll_stop;
+static struct  ep_params *ep_params;
+static struct  ep_policy policy;
+static long  ep_med_edpi, ep_hgh_edpi;
+
 static int parse_ptype; /**< Parse packet type using rx callback, and */
/**< disabled by default */
 
@@ -330,6 +346,13 @@ static inline uint32_t power_idle_heuristic(uint32_t 
zero_rx_packet_count);
 static inline enum freq_scale_hint_t power_freq_scaleup_heuristic( \
unsigned int lcore_id, uint16_t port_id, uint16_t queue_id);
 
+static uint8_t  freq_tlb[] = {14, 9, 1};
+
+static int is_done(void)
+{
+   return empty_poll_stop;
+}
+
 /* exit signal handler */
 static void
 signal_exit_now(int sigtype)
@@ -338,7 +361,15 @@ signal_exit_now(int sigtype)
unsigned int portid;
int ret;
 
+   RTE_SET_USED(lcore_id);
+   RTE_SET_USED(portid);
+   RTE_SET_USED(ret);
+
if (sigtype == SIGINT) {
+   if (empty_poll_on)
+   empty_poll_stop = true;
+
+
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
if (rte_lcore_is_enabled(lcore_id) == 0)
continue;
@@ -351,16 +382,19 @@ signal_exit_now(int sigtype)
   

[dpdk-dev] [PATCH v9 3/4] doc/guides/pro_guide/power-man: update the power API

[Liang Ma]

Update the document for empty poll API.

Change Logs:
v9: minor changes for syntax. Update document.

Signed-off-by: Liang Ma 
---
 doc/guides/prog_guide/power_man.rst | 86 +
 1 file changed, 86 insertions(+)

diff --git a/doc/guides/prog_guide/power_man.rst 
b/doc/guides/prog_guide/power_man.rst
index eba1cc6..68b7e8b 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -106,6 +106,92 @@ User Cases
 
 The power management mechanism is used to save power when performing L3 
forwarding.
 
+
+Empty Poll API
+--
+
+Abstract
+
+
+For packet processing workloads such as DPDK polling is continuous.
+This means CPU cores always show 100% busy independent of how much work
+those cores are doing. It is critical to accurately determine how busy
+a core is hugely important for the following reasons:
+
+* No indication of overload conditions
+* User does not know how much real load is on a system, resulting
+  in wasted energy as no power management is utilized
+
+Compared to the original l3fwd-power design, instead of going to sleep
+after detecting an empty poll, the new mechanism just lowers the core 
frequency.
+As a result, the application does not stop polling the device, which leads
+to improved handling of bursts of traffic.
+
+When the system become busy, the empty poll mechanism can also increase the 
core
+frequency (including turbo) to do best effort for intensive traffic. This gives
+us more flexible and balanced traffic awareness over the standard l3fwd-power
+application.
+
+
+Proposed Solution
+~
+The proposed solution focuses on how many times empty polls are executed.
+The less the number of empty polls, means current core is busy with processing
+workload, therefore, the higher frequency is needed. The high empty poll number
+indicates the current core not doing any real work therefore, we can lower the
+frequency to safe power.
+
+In the current implementation, each core has 1 empty-poll counter which assume
+1 core is dedicated to 1 queue. This will need to be expanded in the future to
+support multiple queues per core.
+
+Power state definition:
+^^^
+
+* LOW:  Not currently used, reserved for future use.
+
+* MED:  the frequency is used to process modest traffic workload.
+
+* HIGH: the frequency is used to process busy traffic workload.
+
+There are two phases to establish the power management system:
+^^
+* Training phase. This phase is used to measure the optimal frequency
+  change thresholds for a given system. The thresholds will differ from
+  system to system due to differences in processor micro-architecture,
+  cache and device configurations.
+  In this phase, the user must ensure that no traffic can enter the
+  system so that counts can be measured for empty polls at low, medium
+  and high frequencies. Each frequency is measured for two seconds.
+  Once the training phase is complete, the threshold numbers are
+  displayed, and normal mode resumes, and traffic can be allowed into
+  the system. These threshold number can be used on the command line
+  when starting the application in normal mode to avoid re-training
+  every time.
+
+* Normal phase. Every 10ms the run-time counters are compared
+  to the supplied threshold values, and the decision will be made
+  whether to move to a different power state (by adjusting the
+  frequency).
+
+API Overview for Empty Poll Power Management
+
+* **State Init**: initialize the power management system.
+
+* **State Free**: free the resource hold by power management system.
+
+* **Update Empty Poll Counter**: update the empty poll counter.
+
+* **Update Valid Poll Counter**: update the valid poll counter.
+
+* **Set the Fequence Index**: update the power state/frequency mapping.
+
+* **Detect empty poll state change**: empty poll state change detection 
algorithm then take action.
+
+User Cases
+--
+The mechanism can applied to any device which is based on polling. e.g. NIC, 
FPGA.
+
 References
 --
 
-- 
2.7.5

[dpdk-dev] [PATCH v9 1/4] lib/librte_power: traffic pattern aware power control

[Liang Ma]

1. Abstract

For packet processing workloads such as DPDK polling is continuous.
This means CPU cores always show 100% busy independent of how much work
those cores are doing. It is critical to accurately determine how busy
a core is hugely important for the following reasons:

   * No indication of overload conditions.

   * User does not know how much real load is on a system, resulting
 in wasted energy as no power management is utilized.

Compared to the original l3fwd-power design, instead of going to sleep
after detecting an empty poll, the new mechanism just lowers the core
frequency. As a result, the application does not stop polling the device,
which leads to improved handling of bursts of traffic.

When the system become busy, the empty poll mechanism can also increase the
core frequency (including turbo) to do best effort for intensive traffic.
This gives us more flexible and balanced traffic awareness over the
standard l3fwd-power application.

2. Proposed solution

The proposed solution focuses on how many times empty polls are executed.
The less the number of empty polls, means current core is busy with
processing workload, therefore, the higher frequency is needed. The high
empty poll number indicates the current core not doing any real work
therefore, we can lower the frequency to safe power.

In the current implementation, each core has 1 empty-poll counter which
assume 1 core is dedicated to 1 queue. This will need to be expanded in the
future to support multiple queues per core.

2.1 Power state definition:

LOW:  Not currently used, reserved for future use.

MED:  the frequency is used to process modest traffic workload.

HIGH: the frequency is used to process busy traffic workload.

2.2 There are two phases to establish the power management system:

a.Initialization/Training phase. The training phase is necessary
  in order to figure out the system polling baseline numbers from
  idle to busy. The highest poll count will be during idle, where
  all polls are empty. These poll counts will be different between
  systems due to the many possible processor micro-arch, cache
  and device configurations, hence the training phase.
  In the training phase, traffic is blocked so the training
  algorithm can average the empty-poll numbers for the LOW, MED and
  HIGH  power states in order to create a baseline.
  The core's counter are collected every 10ms, and the Training
  phase will take 2 seconds.
  Training is disabled as default configuration. The default
  parameter is applied. Sample App still can trigger training
  if that's needed. Once the training phase has been executed once on
  a system, the application can then be started with the relevant
  thresholds provided on the command line, allowing the application
  to start passing start traffic immediately

b.Normal phase. Traffic starts immediately based on the default
  thresholds, or based on the user supplied thresholds via the
  command line parameters. The run-time poll counts are compared with
  the baseline and the decision will be taken to move to MED power
  state or HIGH power state. The counters are calculated every 10ms.

3. Proposed  API

1.  rte_power_empty_poll_stat_init(struct ep_params **eptr,
uint8_t *freq_tlb, struct ep_policy *policy);
which is used to initialize the power management system.
 
2.  rte_power_empty_poll_stat_free(void);
which is used to free the resource hold by power management system.
 
3.  rte_power_empty_poll_stat_update(unsigned int lcore_id);
which is used to update specific core empty poll counter, not thread safe
 
4.  rte_power_poll_stat_update(unsigned int lcore_id, uint8_t nb_pkt);
which is used to update specific core valid poll counter, not thread safe
 
5.  rte_power_empty_poll_stat_fetch(unsigned int lcore_id);
which is used to get specific core empty poll counter.
 
6.  rte_power_poll_stat_fetch(unsigned int lcore_id);
which is used to get specific core valid poll counter.

7.  rte_empty_poll_detection(struct rte_timer *tim, void *arg);
which is used to detect empty poll state changes then take action.

ChangeLog:
v2: fix some coding style issues.
v3: rename the filename, API name.
v4: no change.
v5: no change.
v6: re-work the code layout, update API.
v7: fix minor typo and lift node num limit.
v8: disable training as default option.
v9: minor git log update.

Signed-off-by: Liang Ma 

Reviewed-by: Lei Yao 
---
 lib/librte_power/Makefile   |   6 +-
 lib/librte_power/meson.build|   5 +-
 lib/librte_power/rte_power_empty_poll.c | 539 
 lib/librte_power/rte_power_empty_poll.h | 219 +
 lib/librte_power/rte_power_version.map  |  13 +
 5 files changed, 778 insertions(+), 4 deletions(-)
 create mode 100644 li

[dpdk-dev] [PATCH v8 0/2] introduce vdpa sample

[Xiaolong Ye]

Hi,

This patchset introduces vdpa sample to demonstrate the vDPA use case.

v8 changes:
* move body of data_init to the main function
* adjust Reviewed-by/Acked-by tag postion

v7 changes:
* make vports static
* avoid unnecessary static variable initialization

v6 changes:
* improve the document according to Xiao's comments
* fix a typo, PRIu64 -> PRIx64

v5 changes:
* improve print format and correct from "PRIu64" to "PRIx64"
* use "-c 0x2" to better demonstrate app doesn't need to launch dedicated 
  worker threads for vhost enqueue/dequeue operations in vdpa.rst

v4 changes:
* add client mode support
* improve the format to list the vDPA device info and improve the vdpa.rst 
  accordingly
* remove some useless comments
* add introduction in 18.11 release note.


v3 changes:
* list cmd would show queue number and supported features of vdpa devices.
* address Xiao's review comments

v2 changes:

* fix a compilation error reported by Rosen
* improve create cmd in interactive mode and add two new cmds: list, quit
* add application documentation


Xiaolong Ye (2):
  vhost: introduce API to get vDPA device number
  examples/vdpa: introduce a new sample for vDPA

 MAINTAINERS|   2 +
 doc/guides/rel_notes/release_18_11.rst |   8 +
 doc/guides/sample_app_ug/index.rst |   1 +
 doc/guides/sample_app_ug/vdpa.rst  | 120 +++
 examples/Makefile  |   2 +-
 examples/vdpa/Makefile |  32 ++
 examples/vdpa/main.c   | 453 +
 examples/vdpa/meson.build  |  16 +
 lib/librte_vhost/rte_vdpa.h|   3 +
 lib/librte_vhost/rte_vhost_version.map |   1 +
 lib/librte_vhost/vdpa.c|   6 +
 11 files changed, 643 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/sample_app_ug/vdpa.rst
 create mode 100644 examples/vdpa/Makefile
 create mode 100644 examples/vdpa/main.c
 create mode 100644 examples/vdpa/meson.build

-- 
2.17.1

[dpdk-dev] [PATCH v8 1/2] vhost: introduce API to get vDPA device number

[Xiaolong Ye]

It's used to get number of available registered vDPA devices.

Signed-off-by: Xiaolong Ye 
Acked-by: Xiao Wang 
Reviewed-by: Maxime Coquelin 
---
 lib/librte_vhost/rte_vdpa.h| 3 +++
 lib/librte_vhost/rte_vhost_version.map | 1 +
 lib/librte_vhost/vdpa.c| 6 ++
 3 files changed, 10 insertions(+)

diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
index 90465ca26..b8223e337 100644
--- a/lib/librte_vhost/rte_vdpa.h
+++ b/lib/librte_vhost/rte_vdpa.h
@@ -84,4 +84,7 @@ rte_vdpa_find_device_id(struct rte_vdpa_dev_addr *addr);
 struct rte_vdpa_device * __rte_experimental
 rte_vdpa_get_device(int did);
 
+/* Get current available vdpa device number */
+int __rte_experimental
+rte_vdpa_get_device_num(void);
 #endif /* _RTE_VDPA_H_ */
diff --git a/lib/librte_vhost/rte_vhost_version.map 
b/lib/librte_vhost/rte_vhost_version.map
index da220dd02..ae39b6e21 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -67,6 +67,7 @@ EXPERIMENTAL {
rte_vdpa_unregister_device;
rte_vdpa_find_device_id;
rte_vdpa_get_device;
+   rte_vdpa_get_device_num;
rte_vhost_driver_attach_vdpa_device;
rte_vhost_driver_detach_vdpa_device;
rte_vhost_driver_get_vdpa_device_id;
diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
index c82fd4370..c2c5dff1d 100644
--- a/lib/librte_vhost/vdpa.c
+++ b/lib/librte_vhost/vdpa.c
@@ -113,3 +113,9 @@ rte_vdpa_get_device(int did)
 
return vdpa_devices[did];
 }
+
+int
+rte_vdpa_get_device_num(void)
+{
+   return vdpa_device_num;
+}
-- 
2.17.1

[dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample for vDPA

[Xiaolong Ye]

The vdpa sample application creates vhost-user sockets by using the
vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
virtio ring compatible devices to serve virtio driver directly to enable
datapath acceleration. As vDPA driver can help to set up vhost datapath,
this application doesn't need to launch dedicated worker threads for vhost
enqueue/dequeue operations.

Signed-off-by: Xiaolong Ye 
Acked-by: Xiao Wang 
Reviewed-by: Maxime Coquelin 
---
 MAINTAINERS|   2 +
 doc/guides/rel_notes/release_18_11.rst |   8 +
 doc/guides/sample_app_ug/index.rst |   1 +
 doc/guides/sample_app_ug/vdpa.rst  | 120 +++
 examples/Makefile  |   2 +-
 examples/vdpa/Makefile |  32 ++
 examples/vdpa/main.c   | 453 +
 examples/vdpa/meson.build  |  16 +
 8 files changed, 633 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/sample_app_ug/vdpa.rst
 create mode 100644 examples/vdpa/Makefile
 create mode 100644 examples/vdpa/main.c
 create mode 100644 examples/vdpa/meson.build

diff --git a/MAINTAINERS b/MAINTAINERS
index 5967c1dd3..5656f18e8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -683,6 +683,8 @@ F: doc/guides/sample_app_ug/vhost.rst
 F: examples/vhost_scsi/
 F: doc/guides/sample_app_ug/vhost_scsi.rst
 F: examples/vhost_crypto/
+F: examples/vdpa/
+F: doc/guides/sample_app_ug/vdpa.rst
 
 Vhost PMD
 M: Maxime Coquelin 
diff --git a/doc/guides/rel_notes/release_18_11.rst 
b/doc/guides/rel_notes/release_18_11.rst
index bc9b74ec4..dd53a9ecf 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -67,6 +67,14 @@ New Features
   SR-IOV option in Hyper-V and Azure. This is an alternative to the previous
   vdev_netvsc, tap, and failsafe drivers combination.
 
+* **Add a new sample for vDPA**
+
+  The vdpa sample application creates vhost-user sockets by using the
+  vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
+  virtio ring compatible devices to serve virtio driver directly to enable
+  datapath acceleration. As vDPA driver can help to set up vhost datapath,
+  this application doesn't need to launch dedicated worker threads for vhost
+  enqueue/dequeue operations.
 
 API Changes
 ---
diff --git a/doc/guides/sample_app_ug/index.rst 
b/doc/guides/sample_app_ug/index.rst
index 5bedf4f6f..74b12af85 100644
--- a/doc/guides/sample_app_ug/index.rst
+++ b/doc/guides/sample_app_ug/index.rst
@@ -45,6 +45,7 @@ Sample Applications User Guides
 vhost
 vhost_scsi
 vhost_crypto
+vdpa
 netmap_compatibility
 ip_pipeline
 test_pipeline
diff --git a/doc/guides/sample_app_ug/vdpa.rst 
b/doc/guides/sample_app_ug/vdpa.rst
new file mode 100644
index 0..745f196ca
--- /dev/null
+++ b/doc/guides/sample_app_ug/vdpa.rst
@@ -0,0 +1,120 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 Intel Corporation.
+
+Vdpa Sample Application
+===
+
+The vdpa sample application creates vhost-user sockets by using the
+vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
+virtio ring compatible devices to serve virtio driver directly to enable
+datapath acceleration. As vDPA driver can help to set up vhost datapath,
+this application doesn't need to launch dedicated worker threads for vhost
+enqueue/dequeue operations.
+
+Testing steps
+-
+
+This section shows the steps of how to start VMs with vDPA vhost-user
+backend and verify network connection & live migration.
+
+Build
+~
+
+To compile the sample application see :doc:`compiling`.
+
+The application is located in the ``vdpa`` sub-directory.
+
+Start the vdpa example
+~~
+
+.. code-block:: console
+
+./vdpa [EAL options]  -- [--client] [--interactive|-i] or [--iface 
SOCKET_PATH]
+
+where
+
+* --client means running vdpa app in client mode, in the client mode, QEMU 
needs
+  to run as the server mode and take charge of socket file creation.
+* --iface specifies the path prefix of the UNIX domain socket file, e.g.
+  /tmp/vhost-user-, then the socket files will be named as /tmp/vhost-user-
+  (n starts from 0).
+* --interactive means run the vdpa sample in interactive mode, currently 4
+  internal cmds are supported:
+
+  1. help: show help message
+  2. list: list all available vdpa devices
+  3. create: create a new vdpa port with socket file and vdpa device address
+  4. quit: unregister vhost driver and exit the application
+
+Take IFCVF driver for example:
+
+.. code-block:: console
+
+./vdpa -c 0x2 -n 4 --socket-mem 1024,1024 \
+-w :06:00.3,vdpa=1 -w :06:00.4,vdpa=1 \
+-- --interactive
+
+.. note::
+Here :06:00.3 and :06:00.4 refer to virtio ring compatible devices,
+and we need to bind vfio-pci to them before running vdpa sample.
+
+* modprobe vfio-pci
+* ./usertools/

Re: [dpdk-dev] [PATCH 0/7] Improve core EAL musl compatibility

[Bruce Richardson]

On Wed, Aug 29, 2018 at 12:56:14PM +0100, Anatoly Burakov wrote:
> This patchset fixes numerous issues with musl compatibility
> in the core EAL libraries. It does not fix anything beyond
> core EAL (so, PCI driver is still broken, so are a few other
> drivers), but it's a good start.
> 
> Tested on container with Alpine Linux. Alpine dependencies:
> 
> build-base bsd-compat-headers libexecinfo-dev linux-headers numactl-dev
> 
> For numactl-dev, testing repository needs to be enabled:
> 
> echo "http://dl-cdn.alpinelinux.org/alpine/edge/testing"; >> 
> /etc/apk/repositories
> 
> If successful (using a very broad definition of "success"),
> the build should fail somewhere in PCI bus driver in UIO.
> 

Disabling the kernel drivers, I get a build of EAL and the other libraries
to compile as static libraries. However, shared library builds - and
therefore meson builds fail due to missing backtrace function when linking.
There is still work to do here, but this does fix a number of build errors
on alpine.

Acked-by: Bruce Richardson 

Re: [dpdk-dev] [PATCH 1/2] drivers/net: remove double assignment of driver

[Thomas Monjalon]

28/09/2018 14:26, Shreyansh Jain:
> Removing double copy of driver information. 04664e5c8346 has shifted
> that from driver's probe to bus's probe.
> 
> Fixes: 04664e5c8346 ("drivers/bus: fill driver reference after NXP probing")
> Cc: tho...@monjalon.net
> 
> Signed-off-by: Shreyansh Jain 

For the series:
Acked-by: Thomas Monjalon 

Applied, thanks

Re: [dpdk-dev] [PATCH v4 3/4] app/test-eventdev: add Tx adapter support

[Jerin Jacob]

-Original Message-
> Date: Mon, 24 Sep 2018 13:32:19 +0530
> From: Pavan Nikhilesh 
> To: jerin.ja...@caviumnetworks.com, nikhil@intel.com,
>  anoob.jos...@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh 
> Subject: [dpdk-dev] [PATCH v4 3/4] app/test-eventdev: add Tx adapter support
> X-Mailer: git-send-email 2.18.0
> 
> Convert existing Tx service based pipeline to Tx adapter based APIs and
> simplify worker functions.
> 
> Signed-off-by: Pavan Nikhilesh 
> Acked-by: Jerin Jacob 

Series applied to dpdk-next-eventdev/master. Thanks.

[dpdk-dev] [PATCH] examples/ip_pipeline: fix ipv6 address endianness

[Reshma Pattan]

Fix ipv6 endianness from big endian to cpu order.

Fixes: a3a95b7d58 ("examples/ip_pipeline: add table entry commands")

Signed-off-by: Reshma Pattan 
---
 examples/ip_pipeline/thread.c | 40 +--
 1 file changed, 24 insertions(+), 16 deletions(-)

diff --git a/examples/ip_pipeline/thread.c b/examples/ip_pipeline/thread.c
index 7fc03332e..b00ea0653 100644
--- a/examples/ip_pipeline/thread.c
+++ b/examples/ip_pipeline/thread.c
@@ -2244,29 +2244,37 @@ match_convert(struct table_rule_match *mh,
ml->acl_add.field_value[0].mask_range.u8 =
mh->match.acl.proto_mask;
 
-   ml->acl_add.field_value[1].value.u32 = sa32[0];
+   ml->acl_add.field_value[1].value.u32 =
+   rte_be_to_cpu_32(sa32[0]);
ml->acl_add.field_value[1].mask_range.u32 =
sa32_depth[0];
-   ml->acl_add.field_value[2].value.u32 = sa32[1];
+   ml->acl_add.field_value[2].value.u32 =
+   rte_be_to_cpu_32(sa32[1]);
ml->acl_add.field_value[2].mask_range.u32 =
sa32_depth[1];
-   ml->acl_add.field_value[3].value.u32 = sa32[2];
+   ml->acl_add.field_value[3].value.u32 =
+   rte_be_to_cpu_32(sa32[2]);
ml->acl_add.field_value[3].mask_range.u32 =
sa32_depth[2];
-   ml->acl_add.field_value[4].value.u32 = sa32[3];
+   ml->acl_add.field_value[4].value.u32 =
+   rte_be_to_cpu_32(sa32[3]);
ml->acl_add.field_value[4].mask_range.u32 =
sa32_depth[3];
 
-   ml->acl_add.field_value[5].value.u32 = da32[0];
+   ml->acl_add.field_value[5].value.u32 =
+   rte_be_to_cpu_32(da32[0]);
ml->acl_add.field_value[5].mask_range.u32 =
da32_depth[0];
-   ml->acl_add.field_value[6].value.u32 = da32[1];
+   ml->acl_add.field_value[6].value.u32 =
+   rte_be_to_cpu_32(da32[1]);
ml->acl_add.field_value[6].mask_range.u32 =
da32_depth[1];
-   ml->acl_add.field_value[7].value.u32 = da32[2];
+   ml->acl_add.field_value[7].value.u32 =
+   rte_be_to_cpu_32(da32[2]);
ml->acl_add.field_value[7].mask_range.u32 =
da32_depth[2];
-   ml->acl_add.field_value[8].value.u32 = da32[3];
+   ml->acl_add.field_value[8].value.u32 =
+   rte_be_to_cpu_32(da32[3]);
ml->acl_add.field_value[8].mask_range.u32 =
da32_depth[3];
 
@@ -2308,36 +2316,36 @@ match_convert(struct table_rule_match *mh,
mh->match.acl.proto_mask;
 
ml->acl_delete.field_value[1].value.u32 =
-   sa32[0];
+   rte_be_to_cpu_32(sa32[0]);
ml->acl_delete.field_value[1].mask_range.u32 =
sa32_depth[0];
ml->acl_delete.field_value[2].value.u32 =
-   sa32[1];
+   rte_be_to_cpu_32(sa32[1]);
ml->acl_delete.field_value[2].mask_range.u32 =
sa32_depth[1];
ml->acl_delete.field_value[3].value.u32 =
-   sa32[2];
+   rte_be_to_cpu_32(sa32[2]);
ml->acl_delete.field_value[3].mask_range.u32 =
sa32_depth[2];
ml->acl_delete.field_value[4].value.u32 =
-   sa32[3];
+   rte_be_to_cpu_32(sa32[3]);
ml->acl_delete.field_value[4].mask_range.u32 =
sa32_depth[3];
 
ml->acl_delete.field_value[5].value.u32 =
- 

[dpdk-dev] [PATCH] net/softnic: fix ipv6 address from big endian to cpu order

[Reshma Pattan]

Fix ipv6 endianness from big endian to cpu order.

Fixes: ee19326a4b ("net/softnic: add command for pipeline table entries")

Signed-off-by: Reshma Pattan 
---
 drivers/net/softnic/rte_eth_softnic_thread.c | 40 
 1 file changed, 24 insertions(+), 16 deletions(-)

diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c 
b/drivers/net/softnic/rte_eth_softnic_thread.c
index 8a1509030..2be81900a 100644
--- a/drivers/net/softnic/rte_eth_softnic_thread.c
+++ b/drivers/net/softnic/rte_eth_softnic_thread.c
@@ -2202,29 +2202,37 @@ match_convert(struct softnic_table_rule_match *mh,
ml->acl_add.field_value[0].mask_range.u8 =
mh->match.acl.proto_mask;
 
-   ml->acl_add.field_value[1].value.u32 = sa32[0];
+   ml->acl_add.field_value[1].value.u32 =
+   rte_be_to_cpu_32(sa32[0]);
ml->acl_add.field_value[1].mask_range.u32 =
sa32_depth[0];
-   ml->acl_add.field_value[2].value.u32 = sa32[1];
+   ml->acl_add.field_value[2].value.u32 =
+   rte_be_to_cpu_32(sa32[1]);
ml->acl_add.field_value[2].mask_range.u32 =
sa32_depth[1];
-   ml->acl_add.field_value[3].value.u32 = sa32[2];
+   ml->acl_add.field_value[3].value.u32 =
+   rte_be_to_cpu_32(sa32[2]);
ml->acl_add.field_value[3].mask_range.u32 =
sa32_depth[2];
-   ml->acl_add.field_value[4].value.u32 = sa32[3];
+   ml->acl_add.field_value[4].value.u32 =
+   rte_be_to_cpu_32(sa32[3]);
ml->acl_add.field_value[4].mask_range.u32 =
sa32_depth[3];
 
-   ml->acl_add.field_value[5].value.u32 = da32[0];
+   ml->acl_add.field_value[5].value.u32 =
+   rte_be_to_cpu_32(da32[0]);
ml->acl_add.field_value[5].mask_range.u32 =
da32_depth[0];
-   ml->acl_add.field_value[6].value.u32 = da32[1];
+   ml->acl_add.field_value[6].value.u32 =
+   rte_be_to_cpu_32(da32[1]);
ml->acl_add.field_value[6].mask_range.u32 =
da32_depth[1];
-   ml->acl_add.field_value[7].value.u32 = da32[2];
+   ml->acl_add.field_value[7].value.u32 =
+   rte_be_to_cpu_32(da32[2]);
ml->acl_add.field_value[7].mask_range.u32 =
da32_depth[2];
-   ml->acl_add.field_value[8].value.u32 = da32[3];
+   ml->acl_add.field_value[8].value.u32 =
+   rte_be_to_cpu_32(da32[3]);
ml->acl_add.field_value[8].mask_range.u32 =
da32_depth[3];
 
@@ -2264,36 +2272,36 @@ match_convert(struct softnic_table_rule_match *mh,
mh->match.acl.proto_mask;
 
ml->acl_delete.field_value[1].value.u32 =
-   sa32[0];
+   rte_be_to_cpu_32(sa32[0]);
ml->acl_delete.field_value[1].mask_range.u32 =
sa32_depth[0];
ml->acl_delete.field_value[2].value.u32 =
-   sa32[1];
+   rte_be_to_cpu_32(sa32[1]);
ml->acl_delete.field_value[2].mask_range.u32 =
sa32_depth[1];
ml->acl_delete.field_value[3].value.u32 =
-   sa32[2];
+   rte_be_to_cpu_32(sa32[2]);
ml->acl_delete.field_value[3].mask_range.u32 =
sa32_depth[2];
ml->acl_delete.field_value[4].value.u32 =
-   sa32[3];
+   rte_be_to_cpu_32(sa32[3]);
ml->acl_delete.field_value[4].mask_range.u32 =
sa32_depth[3];
 
  

[dpdk-dev] [PATCH v3 0/4] eal: simplify devargs and hotplug functions

[Thomas Monjalon]

This is a follow-up of an idea presented at Dublin
during the "hotplug talk".

Instead of changing the existing hotplug functions, as in the RFC,
some new experimental functions are added.
The old functions lose their experimental status in order to provide
a non-experimental replacement for deprecated attach/detach functions.

It has been discussed briefly in the technical board meeting this week.


Change in v3:
  - fix null dereferencing in error path (patch 2)


Thomas Monjalon (4):
  devargs: remove deprecated functions
  devargs: simplify parameters of removal function
  eal: remove experimental flag of hotplug functions
  eal: simplify parameters of hotplug functions

 drivers/bus/ifpga/ifpga_bus.c   |  5 +-
 drivers/bus/vdev/vdev.c |  8 +-
 drivers/net/failsafe/failsafe_eal.c |  3 +-
 drivers/net/failsafe/failsafe_ether.c   |  3 +-
 lib/librte_eal/common/eal_common_dev.c  | 85 +
 lib/librte_eal/common/eal_common_devargs.c  | 41 ++
 lib/librte_eal/common/include/rte_dev.h | 35 +++--
 lib/librte_eal/common/include/rte_devargs.h | 81 +---
 lib/librte_eal/rte_eal_version.map  | 10 +--
 9 files changed, 99 insertions(+), 172 deletions(-)

-- 
2.19.0

[dpdk-dev] [PATCH v3 1/4] devargs: remove deprecated functions

[Thomas Monjalon]

rte_eal_parse_devargs_str() does not support parsing the bus name
at the start of devargs. So it has been renamed and deprecated.

rte_eal_devargs_add(), rte_eal_devargs_type_count() and
rte_eal_devargs_dump() were declared deprecated and had their
implementation body renamed.

All these functions were deprecated in release 18.05.

Signed-off-by: Thomas Monjalon 
---
The library version is not updated because it should be done
in earlier patch https://patches.dpdk.org/patch/43903/
---
 lib/librte_eal/common/eal_common_devargs.c  | 30 -
 lib/librte_eal/common/include/rte_devargs.h | 71 -
 lib/librte_eal/rte_eal_version.map  |  4 --
 3 files changed, 105 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_devargs.c 
b/lib/librte_eal/common/eal_common_devargs.c
index dac2402a4..f63d2c663 100644
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -31,36 +31,6 @@ TAILQ_HEAD(rte_devargs_list, rte_devargs);
 struct rte_devargs_list devargs_list =
TAILQ_HEAD_INITIALIZER(devargs_list);
 
-int
-rte_eal_parse_devargs_str(const char *devargs_str,
-   char **drvname, char **drvargs)
-{
-   char *sep;
-
-   if ((devargs_str) == NULL || (drvname) == NULL || (drvargs == NULL))
-   return -1;
-
-   *drvname = strdup(devargs_str);
-   if (*drvname == NULL)
-   return -1;
-
-   /* set the first ',' to '\0' to split name and arguments */
-   sep = strchr(*drvname, ',');
-   if (sep != NULL) {
-   sep[0] = '\0';
-   *drvargs = strdup(sep + 1);
-   } else {
-   *drvargs = strdup("");
-   }
-
-   if (*drvargs == NULL) {
-   free(*drvname);
-   *drvname = NULL;
-   return -1;
-   }
-   return 0;
-}
-
 static size_t
 devargs_layer_count(const char *s)
 {
diff --git a/lib/librte_eal/common/include/rte_devargs.h 
b/lib/librte_eal/common/include/rte_devargs.h
index 097a4ce7b..0eef6e9c4 100644
--- a/lib/librte_eal/common/include/rte_devargs.h
+++ b/lib/librte_eal/common/include/rte_devargs.h
@@ -66,36 +66,6 @@ struct rte_devargs {
const char *data; /**< Device string storage. */
 };
 
-/**
- * @deprecated
- * Parse a devargs string.
- *
- * For PCI devices, the format of arguments string is "PCI_ADDR" or
- * "PCI_ADDR,key=val,key2=val2,...". Examples: "08:00.1", ":5:00.0",
- * "04:00.0,arg=val".
- *
- * For virtual devices, the format of arguments string is "DRIVER_NAME*"
- * or "DRIVER_NAME*,key=val,key2=val2,...". Examples: "net_ring",
- * "net_ring0", "net_pmdAnything,arg=0:arg2=1".
- *
- * The function parses the arguments string to get driver name and driver
- * arguments.
- *
- * @param devargs_str
- *   The arguments as given by the user.
- * @param drvname
- *   The pointer to the string to store parsed driver name.
- * @param drvargs
- *   The pointer to the string to store parsed driver arguments.
- *
- * @return
- *   - 0 on success
- *   - A negative value on error
- */
-__rte_deprecated
-int rte_eal_parse_devargs_str(const char *devargs_str,
-   char **drvname, char **drvargs);
-
 /**
  * Parse a device string.
  *
@@ -201,23 +171,6 @@ rte_devargs_insert(struct rte_devargs *da);
 __rte_experimental
 int rte_devargs_add(enum rte_devtype devtype, const char *devargs_str);
 
-/**
- * @deprecated
- * Add a device to the user device list
- * See rte_devargs_parse() for details.
- *
- * @param devtype
- *   The type of the device.
- * @param devargs_str
- *   The arguments as given by the user.
- *
- * @return
- *   - 0 on success
- *   - A negative value on error
- */
-__rte_deprecated
-int rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str);
-
 /**
  * Remove a device from the user device list.
  * Its resources are freed.
@@ -251,20 +204,6 @@ __rte_experimental
 unsigned int
 rte_devargs_type_count(enum rte_devtype devtype);
 
-/**
- * @deprecated
- * Count the number of user devices of a specified type
- *
- * @param devtype
- *   The type of the devices to counted.
- *
- * @return
- *   The number of devices.
- */
-__rte_deprecated
-unsigned int
-rte_eal_devargs_type_count(enum rte_devtype devtype);
-
 /**
  * This function dumps the list of user device and their arguments.
  *
@@ -274,16 +213,6 @@ rte_eal_devargs_type_count(enum rte_devtype devtype);
 __rte_experimental
 void rte_devargs_dump(FILE *f);
 
-/**
- * @deprecated
- * This function dumps the list of user device and their arguments.
- *
- * @param f
- *   A pointer to a file for output
- */
-__rte_deprecated
-void rte_eal_devargs_dump(FILE *f);
-
 /**
  * Find next rte_devargs matching the provided bus name.
  *
diff --git a/lib/librte_eal/rte_eal_version.map 
b/lib/librte_eal/rte_eal_version.map
index 73282bbb0..3df7f9831 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -19,9 +19,6 @@ DPDK_2.0 {
 

[dpdk-dev] [PATCH v3 2/4] devargs: simplify parameters of removal function

[Thomas Monjalon]

The function rte_devargs_remove(), which is intended to be internal,
can take a devargs structure as argument.
The matching is still using string comparison of bus name and
device name.
It is simpler and may allow a different devargs matching in future.

Signed-off-by: Thomas Monjalon 
---
 drivers/bus/ifpga/ifpga_bus.c   |  5 +
 drivers/bus/vdev/vdev.c |  8 ++--
 lib/librte_eal/common/eal_common_dev.c  |  4 ++--
 lib/librte_eal/common/eal_common_devargs.c  | 11 +++
 lib/librte_eal/common/include/rte_devargs.h | 10 +++---
 5 files changed, 15 insertions(+), 23 deletions(-)

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index c54b59db2..3ef035b7e 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -361,7 +361,6 @@ static int
 ifpga_unplug(struct rte_device *dev)
 {
struct rte_afu_device *afu_dev = NULL;
-   struct rte_devargs *devargs = NULL;
int ret;
 
if (dev == NULL)
@@ -371,15 +370,13 @@ ifpga_unplug(struct rte_device *dev)
if (!afu_dev)
return -ENOENT;
 
-   devargs = dev->devargs;
-
ret = ifpga_remove_driver(afu_dev);
if (ret)
return ret;
 
TAILQ_REMOVE(&ifpga_afu_dev_list, afu_dev, next);
 
-   rte_devargs_remove(devargs->bus->name, devargs->name);
+   rte_devargs_remove(dev->devargs);
free(afu_dev);
return 0;
 
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 69dee89a8..390c2ce70 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -248,7 +248,6 @@ int
 rte_vdev_init(const char *name, const char *args)
 {
struct rte_vdev_device *dev;
-   struct rte_devargs *devargs;
int ret;
 
rte_spinlock_recursive_lock(&vdev_device_list_lock);
@@ -259,9 +258,8 @@ rte_vdev_init(const char *name, const char *args)
if (ret > 0)
VDEV_LOG(ERR, "no driver found for %s", name);
/* If fails, remove it from vdev list */
-   devargs = dev->device.devargs;
TAILQ_REMOVE(&vdev_device_list, dev, next);
-   rte_devargs_remove(devargs->bus->name, devargs->name);
+   rte_devargs_remove(dev->device.devargs);
free(dev);
}
}
@@ -289,7 +287,6 @@ int
 rte_vdev_uninit(const char *name)
 {
struct rte_vdev_device *dev;
-   struct rte_devargs *devargs;
int ret;
 
if (name == NULL)
@@ -308,8 +305,7 @@ rte_vdev_uninit(const char *name)
goto unlock;
 
TAILQ_REMOVE(&vdev_device_list, dev, next);
-   devargs = dev->device.devargs;
-   rte_devargs_remove(devargs->bus->name, devargs->name);
+   rte_devargs_remove(dev->device.devargs);
free(dev);
 
 unlock:
diff --git a/lib/librte_eal/common/eal_common_dev.c 
b/lib/librte_eal/common/eal_common_dev.c
index 678dbcac7..e81ff4258 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -186,7 +186,7 @@ int __rte_experimental rte_eal_hotplug_add(const char 
*busname, const char *devn
return 0;
 
 err_devarg:
-   if (rte_devargs_remove(busname, devname)) {
+   if (rte_devargs_remove(da)) {
free(da->args);
free(da);
}
@@ -227,7 +227,7 @@ rte_eal_hotplug_remove(const char *busname, const char 
*devname)
if (ret)
RTE_LOG(ERR, EAL, "Driver cannot detach the device (%s)\n",
dev->name);
-   rte_devargs_remove(busname, devname);
+   rte_devargs_remove(dev->devargs);
return ret;
 }
 
diff --git a/lib/librte_eal/common/eal_common_devargs.c 
b/lib/librte_eal/common/eal_common_devargs.c
index f63d2c663..d8db45a23 100644
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -266,7 +266,7 @@ rte_devargs_insert(struct rte_devargs *da)
 {
int ret;
 
-   ret = rte_devargs_remove(da->bus->name, da->name);
+   ret = rte_devargs_remove(da);
if (ret < 0)
return ret;
TAILQ_INSERT_TAIL(&devargs_list, da, next);
@@ -312,14 +312,17 @@ rte_devargs_add(enum rte_devtype devtype, const char 
*devargs_str)
 }
 
 int __rte_experimental
-rte_devargs_remove(const char *busname, const char *devname)
+rte_devargs_remove(struct rte_devargs *devargs)
 {
struct rte_devargs *d;
void *tmp;
 
+   if (devargs->bus == NULL)
+   return -1;
+
TAILQ_FOREACH_SAFE(d, &devargs_list, next, tmp) {
-   if (strcmp(d->bus->name, busname) == 0 &&
-   strcmp(d->name, devname) == 0) {
+   if (strcmp(d->bus->name, devargs->bus->name) == 0 &&
+   strcmp(d->name, devargs->name) == 0) {
TAILQ_REMOVE(&devargs_list, d, n

[dpdk-dev] [PATCH v3 4/4] eal: simplify parameters of hotplug functions

[Thomas Monjalon]

All information about a device to probe can be grouped
in a common string, which is what we usually call devargs.
An application should not have to parse this string before
calling the EAL probe function.
And the syntax could evolve to be more complex and support
matching multiple devices in one string.
That's why the bus name and device name should be removed from
rte_eal_hotplug_add().
Instead of changing this function, a simpler one is added
and used in the old one, which may be deprecated later.

When removing a device, we already know its rte_device handle
which can be directly passed as parameter of rte_eal_hotplug_remove().
If the rte_device is not known, it can be retrieved with the devargs,
by iterating in the device list (future RTE_DEV_FOREACH()).
Similarly to the probing case, a new function is added
and used in the old one, which may be deprecated later.
The new function is used in failsafe, because the replacement is easy.

Signed-off-by: Thomas Monjalon 
---
 drivers/net/failsafe/failsafe_eal.c |  3 +-
 drivers/net/failsafe/failsafe_ether.c   |  3 +-
 lib/librte_eal/common/eal_common_dev.c  | 76 -
 lib/librte_eal/common/include/rte_dev.h | 30 +-
 lib/librte_eal/rte_eal_version.map  |  2 +
 5 files changed, 80 insertions(+), 34 deletions(-)

diff --git a/drivers/net/failsafe/failsafe_eal.c 
b/drivers/net/failsafe/failsafe_eal.c
index ce1633f13..8a888b1ff 100644
--- a/drivers/net/failsafe/failsafe_eal.c
+++ b/drivers/net/failsafe/failsafe_eal.c
@@ -144,8 +144,7 @@ fs_bus_uninit(struct rte_eth_dev *dev)
int ret = 0;
 
FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) {
-   sdev_ret = rte_eal_hotplug_remove(sdev->bus->name,
-   sdev->dev->name);
+   sdev_ret = rte_dev_remove(sdev->dev);
if (sdev_ret) {
ERROR("Failed to remove requested device %s (err: %d)",
  sdev->dev->name, sdev_ret);
diff --git a/drivers/net/failsafe/failsafe_ether.c 
b/drivers/net/failsafe/failsafe_ether.c
index 5b5cb3b49..cd7b97e1f 100644
--- a/drivers/net/failsafe/failsafe_ether.c
+++ b/drivers/net/failsafe/failsafe_ether.c
@@ -265,8 +265,7 @@ fs_dev_remove(struct sub_device *sdev)
sdev->state = DEV_PROBED;
/* fallthrough */
case DEV_PROBED:
-   ret = rte_eal_hotplug_remove(sdev->bus->name,
-sdev->dev->name);
+   ret = rte_dev_remove(sdev->dev);
if (ret) {
ERROR("Bus detach failed for sub_device %u",
  SUB_ID(sdev));
diff --git a/lib/librte_eal/common/eal_common_dev.c 
b/lib/librte_eal/common/eal_common_dev.c
index a9be58edf..b40e4c0d0 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -129,46 +129,57 @@ int rte_eal_dev_detach(struct rte_device *dev)
 
 int
 rte_eal_hotplug_add(const char *busname, const char *devname,
-   const char *devargs)
+   const char *drvargs)
+{
+   char *devargs = NULL;
+   int size, length = -1;
+
+   do { /* 2 iterations: first is to know string length */
+   size = length + 1;
+   length = snprintf(devargs, size, "%s:%s,%s", busname, devname, 
drvargs);
+   if (length >= size)
+   devargs = malloc(length + 1);
+   if (devargs == NULL)
+   return -ENOMEM;
+   } while (size == 0);
+
+   return rte_dev_probe(devargs);
+}
+
+int __rte_experimental
+rte_dev_probe(const char *devargs)
 {
-   struct rte_bus *bus;
struct rte_device *dev;
struct rte_devargs *da;
int ret;
 
-   bus = rte_bus_find_by_name(busname);
-   if (bus == NULL) {
-   RTE_LOG(ERR, EAL, "Cannot find bus (%s)\n", busname);
-   return -ENOENT;
-   }
-
-   if (bus->plug == NULL) {
-   RTE_LOG(ERR, EAL, "Function plug not supported by bus (%s)\n",
-   bus->name);
-   return -ENOTSUP;
-   }
-
da = calloc(1, sizeof(*da));
if (da == NULL)
return -ENOMEM;
 
-   ret = rte_devargs_parsef(da, "%s:%s,%s",
-busname, devname, devargs);
+   ret = rte_devargs_parse(da, devargs);
if (ret)
goto err_devarg;
 
+   if (da->bus->plug == NULL) {
+   RTE_LOG(ERR, EAL, "Function plug not supported by bus (%s)\n",
+   da->bus->name);
+   ret = -ENOTSUP;
+   goto err_devarg;
+   }
+
ret = rte_devargs_insert(da);
if (ret)
goto err_devarg;
 
-   ret = bus->scan();
+   ret = da->bus->scan();
if (ret)
goto err_devarg;
 
-   dev = bus->find_device(NULL, cmp_dev_name, devname

[dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions

[Thomas Monjalon]

These functions are quite old and are the only available replacement
for the deprecated attach/detach functions.

Note: some new functions may (again) replace these hotplug functions,
in future, with better parameters.

Signed-off-by: Thomas Monjalon 
---
 lib/librte_eal/common/eal_common_dev.c  |  7 ---
 lib/librte_eal/common/include/rte_dev.h | 11 ++-
 lib/librte_eal/rte_eal_version.map  |  4 ++--
 3 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_dev.c 
b/lib/librte_eal/common/eal_common_dev.c
index e81ff4258..a9be58edf 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -127,8 +127,9 @@ int rte_eal_dev_detach(struct rte_device *dev)
return ret;
 }
 
-int __rte_experimental rte_eal_hotplug_add(const char *busname, const char 
*devname,
-   const char *devargs)
+int
+rte_eal_hotplug_add(const char *busname, const char *devname,
+   const char *devargs)
 {
struct rte_bus *bus;
struct rte_device *dev;
@@ -193,7 +194,7 @@ int __rte_experimental rte_eal_hotplug_add(const char 
*busname, const char *devn
return ret;
 }
 
-int __rte_experimental
+int
 rte_eal_hotplug_remove(const char *busname, const char *devname)
 {
struct rte_bus *bus;
diff --git a/lib/librte_eal/common/include/rte_dev.h 
b/lib/librte_eal/common/include/rte_dev.h
index b80a80598..d440c4e58 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -189,9 +189,6 @@ __rte_deprecated
 int rte_eal_dev_detach(struct rte_device *dev);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Hotplug add a given device to a specific bus.
  *
  * @param busname
@@ -204,13 +201,10 @@ int rte_eal_dev_detach(struct rte_device *dev);
  * @return
  *   0 on success, negative on error.
  */
-int __rte_experimental rte_eal_hotplug_add(const char *busname, const char 
*devname,
+int rte_eal_hotplug_add(const char *busname, const char *devname,
const char *devargs);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Hotplug remove a given device from a specific bus.
  *
  * @param busname
@@ -220,8 +214,7 @@ int __rte_experimental rte_eal_hotplug_add(const char 
*busname, const char *devn
  * @return
  *   0 on success, negative on error.
  */
-int __rte_experimental rte_eal_hotplug_remove(const char *busname,
- const char *devname);
+int rte_eal_hotplug_remove(const char *busname, const char *devname);
 
 /**
  * Device comparison function.
diff --git a/lib/librte_eal/rte_eal_version.map 
b/lib/librte_eal/rte_eal_version.map
index 3df7f9831..6bff37f4b 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -261,6 +261,8 @@ DPDK_18.08 {
 DPDK_18.11 {
global:
 
+   rte_eal_hotplug_add;
+   rte_eal_hotplug_remove;
rte_strscpy;
 
 } DPDK_18.08;
@@ -288,8 +290,6 @@ EXPERIMENTAL {
rte_devargs_remove;
rte_devargs_type_count;
rte_eal_cleanup;
-   rte_eal_hotplug_add;
-   rte_eal_hotplug_remove;
rte_fbarray_attach;
rte_fbarray_destroy;
rte_fbarray_detach;
-- 
2.19.0

[dpdk-dev] [PATCH v2 1/3] drivers/bus: move driver assignment to end of probing

[Thomas Monjalon]

The PCI mapping requires to know the PCI driver to use,
even before the probing is done. That's why the PCI driver is
referenced early inside the PCI device structure. See
1d20a073fa5e ("bus/pci: reference driver structure before mapping")

However the rte_driver does not need to be referenced in rte_device
before the device probing is done.
By moving back this assignment at the end of the device probing,
it becomes possible to make clear the status of a rte_device.

Signed-off-by: Thomas Monjalon 
---
 drivers/bus/ifpga/ifpga_bus.c   | 9 -
 drivers/bus/pci/pci_common.c| 7 +++
 drivers/bus/pci/rte_bus_pci.h   | 2 +-
 drivers/bus/vdev/vdev.c | 5 ++---
 drivers/bus/vmbus/vmbus_common.c| 5 +++--
 drivers/net/i40e/i40e_vf_representor.c  | 3 ---
 drivers/net/mlx4/mlx4.c | 1 -
 drivers/net/mlx5/mlx5.c | 1 -
 lib/librte_eal/common/include/rte_dev.h | 2 +-
 9 files changed, 14 insertions(+), 21 deletions(-)

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index 3ef035b7e..a20afb5c7 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -279,14 +279,13 @@ ifpga_probe_one_driver(struct rte_afu_driver *drv,
 
/* reference driver structure */
afu_dev->driver = drv;
-   afu_dev->device.driver = &drv->driver;
 
/* call the driver probe() function */
ret = drv->probe(afu_dev);
-   if (ret) {
+   if (ret)
afu_dev->driver = NULL;
-   afu_dev->device.driver = NULL;
-   }
+   else
+   afu_dev->device.driver = &drv->driver;
 
return ret;
 }
@@ -301,7 +300,7 @@ ifpga_probe_all_drivers(struct rte_afu_device *afu_dev)
return -1;
 
/* Check if a driver is already loaded */
-   if (afu_dev->driver != NULL)
+   if (afu_dev->device.driver != NULL)
return 0;
 
TAILQ_FOREACH(drv, &ifpga_afu_drv_list, next) {
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 7736b3f9c..a0adc99c8 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -162,14 +162,12 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
 * driver flags for adjusting configuration.
 */
dev->driver = dr;
-   dev->device.driver = &dr->driver;
 
if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
/* map resources for devices that use igb_uio */
ret = rte_pci_map_device(dev);
if (ret != 0) {
dev->driver = NULL;
-   dev->device.driver = NULL;
return ret;
}
}
@@ -178,7 +176,6 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
ret = dr->probe(dr, dev);
if (ret) {
dev->driver = NULL;
-   dev->device.driver = NULL;
if ((dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) &&
/* Don't unmap if device is unsupported and
 * driver needs mapped resources.
@@ -186,6 +183,8 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
!(ret > 0 &&
(dr->drv_flags & RTE_PCI_DRV_KEEP_MAPPED_RES)))
rte_pci_unmap_device(dev);
+   } else {
+   dev->device.driver = &dr->driver;
}
 
return ret;
@@ -246,7 +245,7 @@ pci_probe_all_drivers(struct rte_pci_device *dev)
return -1;
 
/* Check if a driver is already loaded */
-   if (dev->driver != NULL)
+   if (dev->device.driver != NULL)
return 0;
 
FOREACH_DRIVER_ON_PCIBUS(dr) {
diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h
index 0d1955ffe..984df2b37 100644
--- a/drivers/bus/pci/rte_bus_pci.h
+++ b/drivers/bus/pci/rte_bus_pci.h
@@ -62,7 +62,7 @@ struct rte_pci_device {
struct rte_mem_resource mem_resource[PCI_MAX_RESOURCE];
/**< PCI Memory Resource */
struct rte_intr_handle intr_handle; /**< Interrupt handle */
-   struct rte_pci_driver *driver;  /**< Associated driver */
+   struct rte_pci_driver *driver;  /**< PCI driver used in probing */
uint16_t max_vfs;   /**< sriov enable if not zero */
enum rte_kernel_driver kdrv;/**< Kernel driver passthrough */
char name[PCI_PRI_STR_SIZE+1];  /**< PCI location (ASCII) */
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 390c2ce70..e7f321706 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -149,10 +149,9 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)
 
if (vdev_parse(name, &driver))
return -1;
-   dev->device.driver = &driver->driver;
ret = driver->probe(dev);
-   if (ret)
-  

[dpdk-dev] [PATCH v2 0/3] eal: allow hotplug to skip an already probed device

[Thomas Monjalon]

This is a follow-up of an idea presented at Dublin
during the "hotplug talk".

The idea is to ease probing of range of ports attached
to the same rte_device.
I becomes possible to allow probing again the same device
but with a bigger range of ports in the devargs.

Instead of adding a parameter to the hotplug functions, as in the RFC,
the check of an already probed device is moved to the PMDs.
It gives flexibility to drivers for managing range of ports.


This series is based on top of
https://patches.dpdk.org/project/dpdk/list/?series=1579

Depends on: project/dpdk/list/?series=1579
(proposed syntax for dependencies)


Thomas Monjalon (3):
  drivers/bus: move driver assignment to end of probing
  eal: add function to query device status
  eal: allow probing a device again

 drivers/bus/dpaa/dpaa_bus.c|  3 +++
 drivers/bus/fslmc/fslmc_bus.c  |  3 +++
 drivers/bus/ifpga/ifpga_bus.c  | 22 +
 drivers/bus/pci/pci_common.c   | 20 +---
 drivers/bus/pci/rte_bus_pci.h  |  2 +-
 drivers/bus/vdev/vdev.c| 12 ++
 drivers/bus/vmbus/vmbus_common.c   | 28 --
 drivers/common/qat/Makefile|  3 ++-
 drivers/common/qat/meson.build |  1 +
 drivers/common/qat/qat_device.c|  3 +++
 drivers/compress/octeontx/otx_zip_pmd.c|  3 +++
 drivers/crypto/virtio/Makefile |  1 +
 drivers/crypto/virtio/meson.build  |  1 +
 drivers/crypto/virtio/virtio_cryptodev.c   |  3 +++
 drivers/event/octeontx/ssovf_probe.c   |  6 +
 drivers/event/skeleton/Makefile|  1 +
 drivers/event/skeleton/meson.build |  1 +
 drivers/mempool/octeontx/Makefile  |  1 +
 drivers/mempool/octeontx/meson.build   |  2 ++
 drivers/mempool/octeontx/octeontx_fpavf.c  |  3 +++
 drivers/net/ark/Makefile   |  1 +
 drivers/net/ark/meson.build|  1 +
 drivers/net/avf/Makefile   |  1 +
 drivers/net/avp/Makefile   |  1 +
 drivers/net/avp/meson.build|  1 +
 drivers/net/axgbe/Makefile |  1 +
 drivers/net/axgbe/meson.build  |  2 ++
 drivers/net/bnx2x/Makefile |  1 +
 drivers/net/bnx2x/meson.build  |  1 +
 drivers/net/bnxt/Makefile  |  1 +
 drivers/net/bnxt/meson.build   |  1 +
 drivers/net/cxgbe/Makefile |  1 +
 drivers/net/cxgbe/meson.build  |  2 ++
 drivers/net/e1000/Makefile |  1 +
 drivers/net/e1000/meson.build  |  2 ++
 drivers/net/enic/Makefile  |  1 +
 drivers/net/enic/meson.build   |  2 ++
 drivers/net/fm10k/Makefile |  1 +
 drivers/net/fm10k/meson.build  |  2 ++
 drivers/net/i40e/i40e_ethdev.c |  3 +++
 drivers/net/i40e/i40e_vf_representor.c |  3 ---
 drivers/net/ifc/ifcvf_vdpa.c   |  3 +++
 drivers/net/ixgbe/ixgbe_ethdev.c   |  3 +++
 drivers/net/liquidio/Makefile  |  1 +
 drivers/net/liquidio/meson.build   |  1 +
 drivers/net/mlx4/mlx4.c|  5 +++-
 drivers/net/mlx5/mlx5.c|  5 +++-
 drivers/net/netvsc/hn_ethdev.c |  9 ---
 drivers/net/nfp/Makefile   |  1 +
 drivers/net/nfp/meson.build|  1 +
 drivers/net/nfp/nfp_net.c  |  3 +++
 drivers/net/octeontx/Makefile  |  3 +--
 drivers/net/octeontx/base/meson.build  |  2 +-
 drivers/net/octeontx/base/octeontx_pkivf.c |  3 +++
 drivers/net/octeontx/base/octeontx_pkovf.c |  3 +++
 drivers/net/qede/Makefile  |  1 +
 drivers/net/qede/meson.build   |  2 ++
 drivers/net/szedata2/Makefile  |  1 +
 drivers/net/szedata2/meson.build   |  1 +
 drivers/net/szedata2/rte_eth_szedata2.c|  3 +++
 drivers/net/thunderx/Makefile  |  1 +
 drivers/net/thunderx/meson.build   |  2 ++
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c|  3 +++
 lib/librte_eal/common/eal_common_dev.c | 12 ++
 lib/librte_eal/common/include/rte_dev.h| 18 --
 lib/librte_eal/rte_eal_version.map |  1 +
 lib/librte_ethdev/rte_ethdev_pci.h |  3 +++
 lib/librte_eventdev/rte_eventdev_pmd_pci.h |  3 +++
 68 files changed, 187 insertions(+), 56 deletions(-)

-- 
2.19.0

[dpdk-dev] [PATCH v2 3/3] eal: allow probing a device again

[Thomas Monjalon]

In the devargs syntax for device representors, it is possible to add
several devices at once: -w dbdf,representor=[0-3]
It will become a more frequent case when introducing wildcards
and ranges in the new devargs syntax.

If a devargs string is provided for probing, and updated with a bigger
range for a new probing, then we do not want it to fail because
part of this range was already probed previously.
There can be new ports to create from an existing rte_device.

That's why the checks for an already probed device
are moved as PMD responsibility.
Only the PMD knows the ports attached to one rte_device.

In the case of vdev, a global check is kept in insert_vdev(),
assuming that a vdev will always have only one port.
In the case of NXP buses, the probing is done only once (no hotplug),
though a check is added at bus level for consistency.

As another consequence of being able to probe in several steps,
the field rte_device.devargs must not be considered as a full
representation of the rte_device, but only the latest probing args.
Anyway, the field rte_device.devargs is used only for probing.

Signed-off-by: Thomas Monjalon 
---
 drivers/bus/dpaa/dpaa_bus.c|  3 +++
 drivers/bus/fslmc/fslmc_bus.c  |  3 +++
 drivers/bus/ifpga/ifpga_bus.c  | 13 ++-
 drivers/bus/pci/pci_common.c   | 15 +++--
 drivers/bus/vdev/vdev.c|  5 +
 drivers/bus/vmbus/vmbus_common.c   | 25 +++---
 drivers/common/qat/Makefile|  3 ++-
 drivers/common/qat/meson.build |  1 +
 drivers/common/qat/qat_device.c|  3 +++
 drivers/compress/octeontx/otx_zip_pmd.c|  3 +++
 drivers/crypto/virtio/Makefile |  1 +
 drivers/crypto/virtio/meson.build  |  1 +
 drivers/crypto/virtio/virtio_cryptodev.c   |  3 +++
 drivers/event/octeontx/ssovf_probe.c   |  6 ++
 drivers/event/skeleton/Makefile|  1 +
 drivers/event/skeleton/meson.build |  1 +
 drivers/mempool/octeontx/Makefile  |  1 +
 drivers/mempool/octeontx/meson.build   |  2 ++
 drivers/mempool/octeontx/octeontx_fpavf.c  |  3 +++
 drivers/net/ark/Makefile   |  1 +
 drivers/net/ark/meson.build|  1 +
 drivers/net/avf/Makefile   |  1 +
 drivers/net/avp/Makefile   |  1 +
 drivers/net/avp/meson.build|  1 +
 drivers/net/axgbe/Makefile |  1 +
 drivers/net/axgbe/meson.build  |  2 ++
 drivers/net/bnx2x/Makefile |  1 +
 drivers/net/bnx2x/meson.build  |  1 +
 drivers/net/bnxt/Makefile  |  1 +
 drivers/net/bnxt/meson.build   |  1 +
 drivers/net/cxgbe/Makefile |  1 +
 drivers/net/cxgbe/meson.build  |  2 ++
 drivers/net/e1000/Makefile |  1 +
 drivers/net/e1000/meson.build  |  2 ++
 drivers/net/enic/Makefile  |  1 +
 drivers/net/enic/meson.build   |  2 ++
 drivers/net/fm10k/Makefile |  1 +
 drivers/net/fm10k/meson.build  |  2 ++
 drivers/net/i40e/i40e_ethdev.c |  3 +++
 drivers/net/ifc/ifcvf_vdpa.c   |  3 +++
 drivers/net/ixgbe/ixgbe_ethdev.c   |  3 +++
 drivers/net/liquidio/Makefile  |  1 +
 drivers/net/liquidio/meson.build   |  1 +
 drivers/net/mlx4/mlx4.c|  4 
 drivers/net/mlx5/mlx5.c|  4 
 drivers/net/netvsc/hn_ethdev.c |  9 +---
 drivers/net/nfp/Makefile   |  1 +
 drivers/net/nfp/meson.build|  1 +
 drivers/net/nfp/nfp_net.c  |  3 +++
 drivers/net/octeontx/Makefile  |  3 +--
 drivers/net/octeontx/base/meson.build  |  2 +-
 drivers/net/octeontx/base/octeontx_pkivf.c |  3 +++
 drivers/net/octeontx/base/octeontx_pkovf.c |  3 +++
 drivers/net/qede/Makefile  |  1 +
 drivers/net/qede/meson.build   |  2 ++
 drivers/net/szedata2/Makefile  |  1 +
 drivers/net/szedata2/meson.build   |  1 +
 drivers/net/szedata2/rte_eth_szedata2.c|  3 +++
 drivers/net/thunderx/Makefile  |  1 +
 drivers/net/thunderx/meson.build   |  2 ++
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c|  3 +++
 lib/librte_eal/common/eal_common_dev.c |  5 -
 lib/librte_eal/common/include/rte_dev.h|  2 +-
 lib/librte_ethdev/rte_ethdev_pci.h |  3 +++
 lib/librte_eventdev/rte_eventdev_pmd_pci.h |  3 +++
 65 files changed, 152 insertions(+), 36 deletions(-)

diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index 49cd04dbb..5be9da0fa 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -553,6 +553,9 @@ rte_dpaa_bus_probe(void)
if (ret)
continue;
 
+   if (rte_dev_is_probed(&dev->device))
+   

[dpdk-dev] [PATCH v2 2/3] eal: add function to query device status

[Thomas Monjalon]

The function rte_dev_is_probed() is added in order to improve semantic
and enforce proper check of the probing status of a device.

It will answer this rte_device query:
Is it already successfully probed or not?

Signed-off-by: Thomas Monjalon 
---
 drivers/bus/ifpga/ifpga_bus.c   |  4 ++--
 drivers/bus/pci/pci_common.c|  2 +-
 drivers/bus/vdev/vdev.c |  2 +-
 drivers/bus/vmbus/vmbus_common.c|  2 +-
 lib/librte_eal/common/eal_common_dev.c  |  9 -
 lib/librte_eal/common/include/rte_dev.h | 14 ++
 lib/librte_eal/rte_eal_version.map  |  1 +
 7 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index a20afb5c7..5ce886d13 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -300,7 +300,7 @@ ifpga_probe_all_drivers(struct rte_afu_device *afu_dev)
return -1;
 
/* Check if a driver is already loaded */
-   if (afu_dev->device.driver != NULL)
+   if (rte_dev_is_probed(&afu_dev->device))
return 0;
 
TAILQ_FOREACH(drv, &ifpga_afu_drv_list, next) {
@@ -324,7 +324,7 @@ ifpga_probe(void)
int ret = 0;
 
TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-   if (afu_dev->device.driver)
+   if (rte_dev_is_probed(&afu_dev->device))
continue;
 
ret = ifpga_probe_all_drivers(afu_dev);
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index a0adc99c8..d95410e19 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -245,7 +245,7 @@ pci_probe_all_drivers(struct rte_pci_device *dev)
return -1;
 
/* Check if a driver is already loaded */
-   if (dev->device.driver != NULL)
+   if (rte_dev_is_probed(&dev->device))
return 0;
 
FOREACH_DRIVER_ON_PCIBUS(dr) {
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index e7f321706..514d9d5c6 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -479,7 +479,7 @@ vdev_probe(void)
 * we call each driver probe.
 */
 
-   if (dev->device.driver)
+   if (rte_dev_is_probed(&dev->device))
continue;
 
if (vdev_probe_all_drivers(dev)) {
diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c
index de5548aa4..48a219f73 100644
--- a/drivers/bus/vmbus/vmbus_common.c
+++ b/drivers/bus/vmbus/vmbus_common.c
@@ -143,7 +143,7 @@ vmbus_probe_all_drivers(struct rte_vmbus_device *dev)
int rc;
 
/* Check if a driver is already loaded */
-   if (dev->device.driver != NULL) {
+   if (rte_dev_is_probed(&dev->device)) {
VMBUS_LOG(DEBUG, "VMBUS driver already loaded");
return 0;
}
diff --git a/lib/librte_eal/common/eal_common_dev.c 
b/lib/librte_eal/common/eal_common_dev.c
index b40e4c0d0..907c5c481 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -74,6 +74,13 @@ static int cmp_dev_name(const struct rte_device *dev, const 
void *_name)
return strcmp(dev->name, name);
 }
 
+int __rte_experimental
+rte_dev_is_probed(const struct rte_device *dev)
+{
+   /* The field driver should be set only when the probe is successful. */
+   return dev->driver != NULL;
+}
+
 int rte_eal_dev_attach(const char *name, const char *devargs)
 {
struct rte_bus *bus;
@@ -184,7 +191,7 @@ rte_dev_probe(const char *devargs)
goto err_devarg;
}
 
-   if (dev->driver != NULL) {
+   if (rte_dev_is_probed(dev)) {
RTE_LOG(ERR, EAL, "Device is already plugged\n");
return -EEXIST;
}
diff --git a/lib/librte_eal/common/include/rte_dev.h 
b/lib/librte_eal/common/include/rte_dev.h
index 61542c7d1..5b16ee27b 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -161,6 +161,20 @@ struct rte_device {
struct rte_devargs *devargs;  /**< Device user arguments */
 };
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
+ * Query status of a device.
+ *
+ * @param dev
+ *   Generic device pointer.
+ * @return
+ *   (int)true if already probed successfully, 0 otherwise.
+ */
+__rte_experimental
+int rte_dev_is_probed(const struct rte_device *dev);
+
 /**
  * Attach a device to a registered driver.
  *
diff --git a/lib/librte_eal/rte_eal_version.map 
b/lib/librte_eal/rte_eal_version.map
index 2ea7a870a..dddcb81ea 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -279,6 +279,7 @@ EXPERIMENTAL {
rte_dev_event_callback_unregister;
rte_dev_event_monitor_start;
rte_dev_event_monitor_stop;
+   rte_dev_is_probed;
rte_dev_iterator_init;
rte_dev_

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

[Wang, Yipeng1]

> -Original Message-
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com]
> Sent: Thursday, September 27, 2018 12:22 PM
> To: Richardson, Bruce 
> Cc: Wang, Yipeng1 ; dev@dpdk.org;
> mic...@digirati.com.br
> Subject: RE: [PATCH v2 5/7] hash: add extendable bucket feature
> 
> > > > +/* Allocate same number of extendable buckets */
> > > IMO, we are allocating too much memory to support this feature.
> > > Especially,
> > when we claim that keys ending up in the extendable table is a rare
> > occurrence. By doubling the memory we are effectively saying that the
> > main table might have 50% utilization. It will also significantly
> > increase the cycles required to iterate the complete hash table (in
> > rte_hash_iterate API) even when we expect that the extendable table
> contains very few entries.
> > >
> > > I am wondering if we can provide options to control the amount of
> > > extra
> > memory that gets allocated and make the memory allocation dynamic (or
> > on demand basis). I think this also goes well with the general
> > direction DPDK is taking - allocate resources as needed rather than
> > allocating all the resources during initialization.
> > >
> >
> > Given that adding new entries should not normally be a fast-path
> > function, how about allowing memory allocation in add itself. Why not
> > initialize with a fairly small number of extra bucket entries, and
> > then each time they are all used, double the number of entries. That
> > will give efficient resource scaling, I think.
> >
> +1
> 'small number of extra bucket entries' == 5% of total capacity requested
> (assuming cuckoo hash will provide 95% efficiency)
> 
> > /Bruce
 [Wang, Yipeng] 
Thanks for the comments.
We allocate same as table size for extendable buckets at creation
because the purpose is to provide capacity guarantee even for the worst scenario
(all keys collide in same buckets).
Applications (e.g. Telco workloads) that require 100% capacity guarantee will 
be sure
that insertion always succeeds below the specified table size.
With any dynamic memory allocation or less buckets, this guarantee is
broken (even if it is very rare). The dynamic memory allocation could fail. 

Users who do not need such behavior can disable this feature.
Given that the cuckoo algorithm already ensures
very high utilization, they usually do not need the extendable buckets.

[dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

[Luca Boccassi]

Allow users and packagers to override the default dpdk/drivers
subdirectory where the PMDs get installed under $lib.

Signed-off-by: Luca Boccassi 
---
 meson.build   | 3 ++-
 meson_options.txt | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index c9af33532d..123e3e81d6 100644
--- a/meson.build
+++ b/meson.build
@@ -15,7 +15,8 @@ dpdk_libraries = []
 dpdk_drivers = []
 dpdk_extra_ldflags = []
 
-driver_install_path = join_paths(get_option('libdir'), 'dpdk/drivers')
+driver_install_path = join_paths(get_option('libdir'),
+   get_option('drivers_install_subdir'))
 eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
 
 # configure the build, and make sure configs here and in config folder are
diff --git a/meson_options.txt b/meson_options.txt
index cb58b1b607..0834ae364e 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,5 +1,7 @@
 option('allow_invalid_socket_id', type: 'boolean', value: false,
description: 'allow out-of-range NUMA socket id\'s for platforms that 
don\'t report the value correctly')
+option('drivers_install_subdir', type: 'string', value: 'dpdk/drivers',
+   description: 'subdirectory of libdir where to install PMDs')
 option('enable_driver_mlx_glue', type: 'boolean', value: false,
description: 'Enable glue library for Mellanox ConnectX-3/4/5 NIC PMD')
 option('enable_kmods', type: 'boolean', value: true,
-- 
2.19.0

[dpdk-dev] [PATCH 0/3] add AES-CMAC support

[Tomasz Cel]

This patch add support, update QAT documentation and enable tests for AES-CMAC.

Tomasz Cel (3):
  crypto/qat: add support AES-CMAC
  test/qat: test for AES-CMAC
  doc/qat: add AES-CMAC to the QAT feature list

 doc/guides/cryptodevs/features/qat.ini   |  25 ++--
 drivers/crypto/qat/qat_sym_session.c | 190 +++
 drivers/crypto/qat/qat_sym_session.h |   3 +
 test/test/test_cryptodev_hash_test_vectors.h |  12 +-
 4 files changed, 160 insertions(+), 70 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH 2/3] test/qat: test for AES-CMAC

[Tomasz Cel]

Enable tests for AES-CMAC authentication algorithm.

Signed-off-by: Tomasz Cel 
---
 test/test/test_cryptodev_hash_test_vectors.h | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/test/test/test_cryptodev_hash_test_vectors.h 
b/test/test/test_cryptodev_hash_test_vectors.h
index cf86dbb..8b6349c 100644
--- a/test/test/test_cryptodev_hash_test_vectors.h
+++ b/test/test/test_cryptodev_hash_test_vectors.h
@@ -634,25 +634,29 @@ static const struct blockcipher_test_case 
hash_test_cases[] = {
.test_descr = "CMAC Digest 12B",
.test_data = &cmac_test_vector_12,
.op_mask = BLOCKCIPHER_TEST_OP_AUTH_GEN,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "CMAC Digest Verify 12B",
.test_data = &cmac_test_vector_12,
.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "CMAC Digest 16B",
.test_data = &cmac_test_vector,
.op_mask = BLOCKCIPHER_TEST_OP_AUTH_GEN,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "CMAC Digest Verify 16B",
.test_data = &cmac_test_vector,
.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY,
-   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB
+   .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+   BLOCKCIPHER_TEST_TARGET_PMD_QAT
}
 };
 
-- 
2.7.4

[dpdk-dev] [PATCH 3/3] doc/qat: add AES-CMAC to the QAT feature list

[Tomasz Cel]

Update the QAT documentation to show that it supports AES-CMAC.

Signed-off-by: Tomasz Cel 
---
 doc/guides/cryptodevs/features/qat.ini | 25 +
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/doc/guides/cryptodevs/features/qat.ini 
b/doc/guides/cryptodevs/features/qat.ini
index 220291b..41baa46 100644
--- a/doc/guides/cryptodevs/features/qat.ini
+++ b/doc/guides/cryptodevs/features/qat.ini
@@ -36,18 +36,19 @@ ZUC EEA3   = Y
 ; Supported authentication algorithms of the 'qat' crypto driver.
 ;
 [Auth]
-NULL = Y
-MD5 HMAC = Y
-SHA1 HMAC= Y
-SHA224 HMAC  = Y
-SHA256 HMAC  = Y
-SHA384 HMAC  = Y
-SHA512 HMAC  = Y
-AES GMAC = Y
-SNOW3G UIA2  = Y
-KASUMI F9= Y
-AES XCBC MAC = Y
-ZUC EIA3 = Y
+NULL   = Y
+MD5 HMAC   = Y
+SHA1 HMAC  = Y
+SHA224 HMAC= Y
+SHA256 HMAC= Y
+SHA384 HMAC= Y
+SHA512 HMAC= Y
+AES GMAC   = Y
+SNOW3G UIA2= Y
+KASUMI F9  = Y
+AES XCBC MAC   = Y
+ZUC EIA3   = Y
+AES CMAC (128) = Y
 
 ;
 ; Supported AEAD algorithms of the 'qat' crypto driver.
-- 
2.7.4

[dpdk-dev] [PATCH 1/3] crypto/qat: add support AES-CMAC

[Tomasz Cel]

This patch add AES-CMAC support. CMAC is a keyed hash function
that is based on a symmetric key block cipher. It is One-Key
CBC MAC improvement over XCBC-MAC. RFC 4493. NIST SP 800-38B.

Signed-off-by: Tomasz Cel 
Signed-off-by: Arek Kusztal 
---
 drivers/crypto/qat/qat_sym_session.c | 190 +--
 drivers/crypto/qat/qat_sym_session.h |   3 +
 2 files changed, 139 insertions(+), 54 deletions(-)

diff --git a/drivers/crypto/qat/qat_sym_session.c 
b/drivers/crypto/qat/qat_sym_session.c
index 1d58220..8196e23 100644
--- a/drivers/crypto/qat/qat_sym_session.c
+++ b/drivers/crypto/qat/qat_sym_session.c
@@ -498,6 +498,7 @@ qat_sym_session_configure_auth(struct rte_cryptodev *dev,
struct qat_sym_dev_private *internals = dev->data->dev_private;
uint8_t *key_data = auth_xform->key.data;
uint8_t key_length = auth_xform->key.length;
+   session->aes_cmac = 0;
 
switch (auth_xform->algo) {
case RTE_CRYPTO_AUTH_SHA1_HMAC:
@@ -518,6 +519,10 @@ qat_sym_session_configure_auth(struct rte_cryptodev *dev,
case RTE_CRYPTO_AUTH_AES_XCBC_MAC:
session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC;
break;
+   case RTE_CRYPTO_AUTH_AES_CMAC:
+   session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC;
+   session->aes_cmac = 1;
+   break;
case RTE_CRYPTO_AUTH_AES_GMAC:
if (qat_sym_validate_aes_key(auth_xform->key.length,
&session->qat_cipher_alg) != 0) {
@@ -555,7 +560,6 @@ qat_sym_session_configure_auth(struct rte_cryptodev *dev,
case RTE_CRYPTO_AUTH_SHA224:
case RTE_CRYPTO_AUTH_SHA384:
case RTE_CRYPTO_AUTH_MD5:
-   case RTE_CRYPTO_AUTH_AES_CMAC:
case RTE_CRYPTO_AUTH_AES_CBC_MAC:
QAT_LOG(ERR, "Crypto: Unsupported hash alg %u",
auth_xform->algo);
@@ -817,6 +821,8 @@ static int qat_hash_get_digest_size(enum 
icp_qat_hw_auth_algo qat_hash_alg)
return ICP_QAT_HW_SHA512_STATE1_SZ;
case ICP_QAT_HW_AUTH_ALGO_MD5:
return ICP_QAT_HW_MD5_STATE1_SZ;
+   case ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC:
+   return ICP_QAT_HW_AES_XCBC_MAC_STATE1_SZ;
case ICP_QAT_HW_AUTH_ALGO_DELIMITER:
/* return maximum digest size in this case */
return ICP_QAT_HW_SHA512_STATE1_SZ;
@@ -843,6 +849,8 @@ static int qat_hash_get_block_size(enum 
icp_qat_hw_auth_algo qat_hash_alg)
return SHA512_CBLOCK;
case ICP_QAT_HW_AUTH_ALGO_GALOIS_128:
return 16;
+   case ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC:
+   return ICP_QAT_HW_AES_BLK_SZ;
case ICP_QAT_HW_AUTH_ALGO_MD5:
return MD5_CBLOCK;
case ICP_QAT_HW_AUTH_ALGO_DELIMITER:
@@ -991,11 +999,28 @@ static int partial_hash_compute(enum icp_qat_hw_auth_algo 
hash_alg,
 #define HMAC_OPAD_VALUE0x5c
 #define HASH_XCBC_PRECOMP_KEY_NUM 3
 
+static const uint8_t AES_CMAC_SEED[ICP_QAT_HW_AES_128_KEY_SZ];
+
+static void aes_cmac_key_derive(uint8_t *base, uint8_t *derived)
+{
+   int i;
+
+   derived[0] = base[0] << 1;
+   for (i = 1; i < ICP_QAT_HW_AES_BLK_SZ ; i++) {
+   derived[i] = base[i] << 1;
+   derived[i - 1] |= base[i] >> 7;
+   }
+
+   if (base[0] & 0x80)
+   derived[ICP_QAT_HW_AES_BLK_SZ - 1] ^= QAT_AES_CMAC_CONST_RB;
+}
+
 static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg,
const uint8_t *auth_key,
uint16_t auth_keylen,
uint8_t *p_state_buf,
-   uint16_t *p_state_len)
+   uint16_t *p_state_len,
+   uint8_t aes_cmac)
 {
int block_size;
uint8_t ipad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
@@ -1003,47 +1028,91 @@ static int qat_sym_do_precomputes(enum 
icp_qat_hw_auth_algo hash_alg,
int i;
 
if (hash_alg == ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC) {
-   static uint8_t qat_aes_xcbc_key_seed[
-   ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ] = {
-   0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,
-   0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,
-   0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02,
-   0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02,
-   0x03, 0x03, 0x03, 0x03, 0x03, 0x03, 0x03, 0x03,
-   0x03, 0x03, 0x03, 0x03, 0x03, 0x03, 0x03, 0x03,
-   };
 
-   uint8_t *in = NULL;
-   uint8_t *out = p_state_buf;
-   int x;
-   AES_KEY enc_key;
+   /* CMAC */
+   if (aes_cmac) {
+   AES_KEY enc_key;
+  

[dpdk-dev] [PATCH v2 1/2] net/enic: move common Rx functions to a new header file

[John Daley]

From: Hyong Youb Kim 

Move a number of Rx functions to the header file so that the avx2
based Rx handler can use them.

Signed-off-by: Hyong Youb Kim 
---
 drivers/net/enic/enic_rxtx.c| 263 +-
 drivers/net/enic/enic_rxtx_common.h | 271 
 2 files changed, 272 insertions(+), 262 deletions(-)
 create mode 100644 drivers/net/enic/enic_rxtx_common.h

diff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rxtx.c
index 276a2e559..5189ee635 100644
--- a/drivers/net/enic/enic_rxtx.c
+++ b/drivers/net/enic/enic_rxtx.c
@@ -11,6 +11,7 @@
 #include "enic_compat.h"
 #include "rq_enet_desc.h"
 #include "enic.h"
+#include "enic_rxtx_common.h"
 #include 
 #include 
 #include 
@@ -30,268 +31,6 @@
 #define rte_packet_prefetch(p) do {} while (0)
 #endif
 
-static inline uint16_t
-enic_cq_rx_desc_ciflags(struct cq_enet_rq_desc *crd)
-{
-   return le16_to_cpu(crd->completed_index_flags) & ~CQ_DESC_COMP_NDX_MASK;
-}
-
-static inline uint16_t
-enic_cq_rx_desc_bwflags(struct cq_enet_rq_desc *crd)
-{
-   return le16_to_cpu(crd->bytes_written_flags) &
-  ~CQ_ENET_RQ_DESC_BYTES_WRITTEN_MASK;
-}
-
-static inline uint8_t
-enic_cq_rx_desc_packet_error(uint16_t bwflags)
-{
-   return (bwflags & CQ_ENET_RQ_DESC_FLAGS_TRUNCATED) ==
-   CQ_ENET_RQ_DESC_FLAGS_TRUNCATED;
-}
-
-static inline uint8_t
-enic_cq_rx_desc_eop(uint16_t ciflags)
-{
-   return (ciflags & CQ_ENET_RQ_DESC_FLAGS_EOP)
-   == CQ_ENET_RQ_DESC_FLAGS_EOP;
-}
-
-static inline uint8_t
-enic_cq_rx_desc_csum_not_calc(struct cq_enet_rq_desc *cqrd)
-{
-   return (le16_to_cpu(cqrd->q_number_rss_type_flags) &
-   CQ_ENET_RQ_DESC_FLAGS_CSUM_NOT_CALC) ==
-   CQ_ENET_RQ_DESC_FLAGS_CSUM_NOT_CALC;
-}
-
-static inline uint8_t
-enic_cq_rx_desc_ipv4_csum_ok(struct cq_enet_rq_desc *cqrd)
-{
-   return (cqrd->flags & CQ_ENET_RQ_DESC_FLAGS_IPV4_CSUM_OK) ==
-   CQ_ENET_RQ_DESC_FLAGS_IPV4_CSUM_OK;
-}
-
-static inline uint8_t
-enic_cq_rx_desc_tcp_udp_csum_ok(struct cq_enet_rq_desc *cqrd)
-{
-   return (cqrd->flags & CQ_ENET_RQ_DESC_FLAGS_TCP_UDP_CSUM_OK) ==
-   CQ_ENET_RQ_DESC_FLAGS_TCP_UDP_CSUM_OK;
-}
-
-static inline uint8_t
-enic_cq_rx_desc_rss_type(struct cq_enet_rq_desc *cqrd)
-{
-   return (uint8_t)((le16_to_cpu(cqrd->q_number_rss_type_flags) >>
-   CQ_DESC_Q_NUM_BITS) & CQ_ENET_RQ_DESC_RSS_TYPE_MASK);
-}
-
-static inline uint32_t
-enic_cq_rx_desc_rss_hash(struct cq_enet_rq_desc *cqrd)
-{
-   return le32_to_cpu(cqrd->rss_hash);
-}
-
-static inline uint16_t
-enic_cq_rx_desc_vlan(struct cq_enet_rq_desc *cqrd)
-{
-   return le16_to_cpu(cqrd->vlan);
-}
-
-static inline uint16_t
-enic_cq_rx_desc_n_bytes(struct cq_desc *cqd)
-{
-   struct cq_enet_rq_desc *cqrd = (struct cq_enet_rq_desc *)cqd;
-   return le16_to_cpu(cqrd->bytes_written_flags) &
-   CQ_ENET_RQ_DESC_BYTES_WRITTEN_MASK;
-}
-
-
-static inline uint8_t
-enic_cq_rx_check_err(struct cq_desc *cqd)
-{
-   struct cq_enet_rq_desc *cqrd = (struct cq_enet_rq_desc *)cqd;
-   uint16_t bwflags;
-
-   bwflags = enic_cq_rx_desc_bwflags(cqrd);
-   if (unlikely(enic_cq_rx_desc_packet_error(bwflags)))
-   return 1;
-   return 0;
-}
-
-/* Lookup table to translate RX CQ flags to mbuf flags. */
-static inline uint32_t
-enic_cq_rx_flags_to_pkt_type(struct cq_desc *cqd, uint8_t tnl)
-{
-   struct cq_enet_rq_desc *cqrd = (struct cq_enet_rq_desc *)cqd;
-   uint8_t cqrd_flags = cqrd->flags;
-   /*
-* Odd-numbered entries are for tunnel packets. All packet type info
-* applies to the inner packet, and there is no info on the outer
-* packet. The outer flags in these entries exist only to avoid
-* changing enic_cq_rx_to_pkt_flags(). They are cleared from mbuf
-* afterwards.
-*
-* Also, as there is no tunnel type info (VXLAN, NVGRE, or GENEVE), set
-* RTE_PTYPE_TUNNEL_GRENAT..
-*/
-   static const uint32_t cq_type_table[128] __rte_cache_aligned = {
-   [0x00] = RTE_PTYPE_UNKNOWN,
-   [0x01] = RTE_PTYPE_UNKNOWN |
-RTE_PTYPE_TUNNEL_GRENAT |
-RTE_PTYPE_INNER_L2_ETHER,
-   [0x20] = RTE_PTYPE_L3_IPV4_EXT_UNKNOWN | RTE_PTYPE_L4_NONFRAG,
-   [0x21] = RTE_PTYPE_L3_IPV4_EXT_UNKNOWN | RTE_PTYPE_L4_NONFRAG |
-RTE_PTYPE_TUNNEL_GRENAT |
-RTE_PTYPE_INNER_L2_ETHER |
-RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN |
-RTE_PTYPE_INNER_L4_NONFRAG,
-   [0x22] = RTE_PTYPE_L3_IPV4_EXT_UNKNOWN | RTE_PTYPE_L4_UDP,
-   [0x23] = RTE_PTYPE_L3_IPV4_EXT_UNKNOWN | RTE_PTYPE_L4_UDP |
-RTE_PTYPE_TUNNEL_GRENAT |
-RTE_PTYPE_INNER_L2_ETHER |
-RTE_PTYPE_INNER

[dpdk-dev] [PATCH v2 2/2] net/enic: add AVX2 based vectorized Rx handler

[John Daley]

From: Hyong Youb Kim 

Add the vectorized version of the no-scatter Rx handler. It aims to
process 8 descriptors per loop using AVX2 SIMD instructions. This
handler is in its own file enic_rxtx_vec_avx2.c, and makefile and
meson.build are modified to compile it when the compiler supports
AVX2. Under ideal conditions, the vectorized handler reduces
cycles/packet by more than 30%, when compared against the no-scatter
Rx handler. Most implementation ideas come from i40e's AVX2 based
handler, so credit goes to its authors.

At this point, the new handler is meant for field trials, and is not
selected by default. So add a new devarg enable-avx2-rx to allow the
user to request the use of the new handler. When enable-avx2-rx=1, the
driver will consider using the new handler.

Also update the guide doc and introduce the vectorized handler.

Signed-off-by: Hyong Youb Kim 
---

v2: remove bool type from stucture (found by checkpatch)

 doc/guides/nics/enic.rst  |  32 ++
 drivers/net/enic/Makefile |   7 +
 drivers/net/enic/enic.h   |   3 +
 drivers/net/enic/enic_ethdev.c|  27 +-
 drivers/net/enic/enic_main.c  |  34 +-
 drivers/net/enic/enic_rxtx_vec_avx2.c | 832 ++
 drivers/net/enic/meson.build  |   5 +
 7 files changed, 931 insertions(+), 9 deletions(-)
 create mode 100644 drivers/net/enic/enic_rxtx_vec_avx2.c

diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst
index 86941fdb2..b31f4eef9 100644
--- a/doc/guides/nics/enic.rst
+++ b/doc/guides/nics/enic.rst
@@ -351,6 +351,38 @@ suitable for others. Such applications may change the mode 
by setting
   applications such as OVS-DPDK performance benchmarks that utilize
   only the default VLAN and want to see only untagged packets.
 
+
+Vectorized Rx Handler
+-
+
+ENIC PMD includes a version of the receive handler that is vectorized using
+AVX2 SIMD instructions. It is meant for bulk, throughput oriented workloads
+where reducing cycles/packet in PMD is a priority. In order to use the
+vectorized handler, take the following steps.
+
+- Use a recent version of gcc, icc, or clang and build 64-bit DPDK. If
+  the compiler is known to support AVX2, DPDK build system
+  automatically compiles the vectorized handler. Otherwise, the
+  handler is not available.
+
+- Set ``devargs`` parameter ``enable-avx2-rx=1`` to explicitly request that
+  PMD consider the vectorized handler when selecting the receive handler.
+
+  As the current implementation is intended for field trials, by default, the
+  vectorized handler is not considerd (``enable-avx2-rx=0``).
+
+- Run on a UCS M4 or later server with CPUs that support AVX2.
+
+PMD selects the vectorized handler when the handler is compiled into
+the driver, the user requests its use via ``enable-avx2-rx=1``, CPU
+supports AVX2, and scatter Rx is not used. To verify that the
+vectorized handler is selected, enable debug logging
+(``--log-level=pmd,debug``) and check the following message.
+
+.. code-block:: console
+
+enic_use_vector_rx_handler use the non-scatter avx2 Rx handler
+
 .. _enic_limitations:
 
 Limitations
diff --git a/drivers/net/enic/Makefile b/drivers/net/enic/Makefile
index 7c6c29cc0..3ec6f9159 100644
--- a/drivers/net/enic/Makefile
+++ b/drivers/net/enic/Makefile
@@ -39,4 +39,11 @@ SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += base/vnic_intr.c
 SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += base/vnic_rq.c
 SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += base/vnic_rss.c
 
+ifeq ($(findstring 
RTE_MACHINE_CPUFLAG_AVX2,$(CFLAGS)),RTE_MACHINE_CPUFLAG_AVX2)
+# The current implementation assumes 64-bit pointers
+ifeq ($(CONFIG_RTE_ARCH_X86_64),y)
+   SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic_rxtx_vec_avx2.c
+endif
+endif
+
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index 775cd5d55..665f5668a 100644
--- a/drivers/net/enic/enic.h
+++ b/drivers/net/enic/enic.h
@@ -106,6 +106,7 @@ struct enic {
struct vnic_dev_bar bar0;
struct vnic_dev *vdev;
 
+   uint64_t mbuf_initializer;
unsigned int port_id;
bool overlay_offload;
struct rte_eth_dev *rte_dev;
@@ -128,6 +129,7 @@ struct enic {
u8 filter_actions; /* HW supported actions */
bool vxlan;
bool disable_overlay; /* devargs disable_overlay=1 */
+   uint8_t enable_avx2_rx;  /* devargs enable-avx2-rx=1 */
bool nic_cfg_chk; /* NIC_CFG_CHK available */
bool udp_rss_weak;/* Bodega style UDP RSS */
uint8_t ig_vlan_rewrite_mode; /* devargs ig-vlan-rewrite */
@@ -329,6 +331,7 @@ uint16_t enic_prep_pkts(void *tx_queue, struct rte_mbuf 
**tx_pkts,
uint16_t nb_pkts);
 int enic_set_mtu(struct enic *enic, uint16_t new_mtu);
 int enic_link_update(struct enic *enic);
+bool enic_use_vector_rx_handler(struct enic *enic);
 void enic_fdir_info(struct enic *enic);
 void enic_fdir_info_get(struct enic *enic, struct rte