Re: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being used
Hi
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad
> Sent: Thursday, July 26, 2018 5:36 PM
> To: Mordechay Haimovsky
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being
> used
>
> Hi Moti
>
> Small comment below.
>
> From: Mordechay Haimovsky
> > This patch verifies that the number of Rx queues configured for RSS is
> > supported by the device hardware.
> > RSS support in mlx4 requires contiguous chunk of QPs to be reserved,
> > there is a hardware limitation on the amount of contiguous QPs which
> > is reported by the hardware. Ignoring this value will cause Rx queues
> > creation
> to fail.
> >
> > Signed-off-by: Moti Haimovsky
> > ---
> > drivers/net/mlx4/mlx4.c | 3 +++
> > drivers/net/mlx4/mlx4.h | 1 +
> > drivers/net/mlx4/mlx4_rxq.c | 6 ++
> > 3 files changed, 10 insertions(+)
> >
> > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index
> > c67d2c0..defc0d4 100644
> > --- a/drivers/net/mlx4/mlx4.c
> > +++ b/drivers/net/mlx4/mlx4.c
> > @@ -673,6 +673,9 @@ struct mlx4_conf {
> >&device_attr_ex);
> > DEBUG("supported RSS hash fields mask: %016" PRIx64,
> > priv->hw_rss_sup);
> > + priv->hw_rss_max_qps =
> > +
> > device_attr_ex.rss_caps.max_rwq_indirection_table_size;
> > + DEBUG("MAX RSS queues %d", priv->hw_rss_max_qps);
> > priv->hw_fcs_strip = !!(device_attr_ex.raw_packet_caps &
> >
> > IBV_RAW_PACKET_CAP_SCATTER_FCS);
> > DEBUG("FCS stripping toggling is %ssupported", diff --git
> > a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h index
> > 89d8c38..e6fb934
> > 100644
> > --- a/drivers/net/mlx4/mlx4.h
> > +++ b/drivers/net/mlx4/mlx4.h
> > @@ -95,6 +95,7 @@ struct priv {
> > uint32_t hw_fcs_strip:1; /**< FCS stripping toggling is supported. */
> > uint32_t tso:1; /**< Transmit segmentation offload is supported. */
> > uint32_t tso_max_payload_sz; /**< Max supported TSO payload size.
> > */
> > + uint32_t hw_rss_max_qps; /**< Max Rx Queues supported by RSS. */
> > uint64_t hw_rss_sup; /**< Supported RSS hash fields (Verbs format). */
> > struct rte_intr_handle intr_handle; /**< Port interrupt handle. */
> > struct mlx4_drop *drop; /**< Shared resources for drop flow rules.
> > */ diff --git a/drivers/net/mlx4/mlx4_rxq.c
> > b/drivers/net/mlx4/mlx4_rxq.c index 0cd9560..e8bef1d 100644
> > --- a/drivers/net/mlx4/mlx4_rxq.c
> > +++ b/drivers/net/mlx4/mlx4_rxq.c
> > @@ -338,6 +338,12 @@ struct mlx4_rss *
> >
> > if (priv->rss_init)
> > return 0;
> > + if (priv->dev->data->nb_rx_queues > priv->hw_rss_max_qps) {
> > + ERROR("RSS does not support more than %d queues",
> > + priv->hw_rss_max_qps);
> > + rte_errno = EINVAL;
>
> What's about E2BIG ?
My mistake,
The description of E2BIG related to the argument list and not generally for too
big parameters,
so no need to change the EINVAL.
> > + return -rte_errno;
> > + }
> > /* Prepare range for RSS contexts before creating the first WQ. */
> > ret = mlx4_glue->dv_set_context_attr
> > (priv->ctx,
> > --
> > 1.8.3.1
>
> Besides that;
> Acked-by: Matan Azrad
Re: [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping
-Original Message-
> Date: Thu, 26 Jul 2018 11:35:43 +0200
> From: Thomas Monjalon
> To: Takeshi Yoshimura
> Cc: dev@dpdk.org, Anatoly Burakov
> Subject: Re: [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping
>
>
> 20/07/2018 10:13, Takeshi Yoshimura:
> > Currently, VFIO will try to map around MSI-X table in the BARs. When
> > MSI-X table (page-aligned) size is equal to (page-aligned) size of BAR,
> > VFIO will just skip the BAR.
> >
> > Recent kernel versions will allow VFIO to map the entire BAR containing
> > MSI-X tables (*), so instead of trying to map around the MSI-X vector
> > or skipping the BAR entirely if it's not possible, we can now try
> > mapping the entire BAR first. If mapping the entire BAR doesn't
> > succeed, fall back to the old behavior of mapping around MSI-X table or
> > skipping the BAR.
> >
> > (*): "vfio-pci: Allow mapping MSIX BAR",
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
> > commit/?id=a32295c612c57990d17fb0f41e7134394b2f35f6
> >
> > Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
> >
> > Signed-off-by: Takeshi Yoshimura
> > Reviewed-by: Anatoly Burakov
This change set breaks thunderx/octeontx platform with following error.(Tested
with 4.9.0 kernel)
EAL: probe driver: 177d:a034 net_thunderx
EAL: using IOMMU type 1 (Type 1)
EAL: pci_map_resource(): cannot mmap(44, 0x6020, 0x20,
0x400): Invalid argument (0x)
EAL: PCI device 0001:01:00.2 on NUMA socket 0
EAL: probe driver: 177d:a034 net_thunderx
EAL: pci_map_resource(): cannot mmap(47, 0x6060, 0x20,
0x400): Invalid argument (0x)
According Linux kernel change, user space application suppose to use
VFIO_REGION_INFO_CAP_MSIX_MAPPABLE
capability to detect this feature to work < 4.15 kernel. Right? if so, Why we
are doing this retry based logic?
>
> Applied, thanks
>
>
>
[dpdk-dev] [PATCH] net/mlx5: fix flow count action for shared counters
According to commit fb8fd96d4251 ("ethdev: add shared counter to flow
API") the counter id should be taken into account only when the shared
flag is set.
Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action")
Cc: nelio.laranje...@6wind.com
Signed-off-by: Shahaf Shuler
---
drivers/net/mlx5/mlx5_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index b94c442ec4..adda4df656 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -490,7 +490,7 @@ mlx5_flow_counter_new(struct rte_eth_dev *dev, uint32_t
shared, uint32_t id)
struct mlx5_flow_counter *cnt;
LIST_FOREACH(cnt, &priv->flow_counters, next) {
- if (cnt->shared != shared)
+ if (!cnt->shared || cnt->shared != shared)
continue;
if (cnt->id != id)
continue;
--
2.12.0
Re: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being used
Sunday, July 29, 2018 11:12 AM, Matan Azrad: > Subject: Re: [dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs > being used > > Hi Moti > > > > Small comment below. > > > > From: Mordechay Haimovsky > > > This patch verifies that the number of Rx queues configured for RSS > > > is supported by the device hardware. > > > RSS support in mlx4 requires contiguous chunk of QPs to be reserved, > > > there is a hardware limitation on the amount of contiguous QPs which > > > is reported by the hardware. Ignoring this value will cause Rx > > > queues creation > > to fail. > > > > > > Signed-off-by: Moti Haimovsky Applied to next-net-mlx (with commit title change), thanks.
[dpdk-dev] [PATCH] examples: remove Rx checksum offload
As of now, application does not check PKT_RX_*_CKSUM_* flags per
packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not.
Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few
cycles if possible.
Signed-off-by: Jerin Jacob
---
examples/ip_fragmentation/main.c| 3 +--
examples/ip_reassembly/main.c | 3 +--
examples/ipsec-secgw/ipsec-secgw.c | 3 +--
examples/l3fwd-acl/main.c | 3 +--
examples/l3fwd-power/main.c | 4 ++--
examples/l3fwd-vf/main.c| 3 +--
examples/l3fwd/main.c | 3 +--
examples/load_balancer/init.c | 3 +--
examples/multi_process/symmetric_mp/main.c | 3 +--
examples/performance-thread/l3fwd-thread/main.c | 3 +--
examples/qos_meter/main.c | 3 +--
11 files changed, 12 insertions(+), 22 deletions(-)
diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 5306d7672..7cbd5dc10 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -140,8 +140,7 @@ static struct rte_eth_conf port_conf = {
.rxmode = {
.max_rx_pkt_len = JUMBO_FRAME_MAX_SIZE,
.split_hdr_size = 0,
- .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
-DEV_RX_OFFLOAD_JUMBO_FRAME |
+ .offloads = (DEV_RX_OFFLOAD_JUMBO_FRAME |
DEV_RX_OFFLOAD_CRC_STRIP),
},
.txmode = {
diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c
index b830f67a5..7acc6b7b5 100644
--- a/examples/ip_reassembly/main.c
+++ b/examples/ip_reassembly/main.c
@@ -164,8 +164,7 @@ static struct rte_eth_conf port_conf = {
.mq_mode= ETH_MQ_RX_RSS,
.max_rx_pkt_len = JUMBO_FRAME_MAX_SIZE,
.split_hdr_size = 0,
- .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
-DEV_RX_OFFLOAD_JUMBO_FRAME |
+ .offloads = (DEV_RX_OFFLOAD_JUMBO_FRAME |
DEV_RX_OFFLOAD_CRC_STRIP),
},
.rx_adv_conf = {
diff --git a/examples/ipsec-secgw/ipsec-secgw.c
b/examples/ipsec-secgw/ipsec-secgw.c
index b45b87bde..63eef1f26 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -197,8 +197,7 @@ static struct rte_eth_conf port_conf = {
.mq_mode= ETH_MQ_RX_RSS,
.max_rx_pkt_len = ETHER_MAX_LEN,
.split_hdr_size = 0,
- .offloads = DEV_RX_OFFLOAD_CHECKSUM |
- DEV_RX_OFFLOAD_CRC_STRIP,
+ .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
},
.rx_adv_conf = {
.rss_conf = {
diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
index 7c063a8d0..c66b5b462 100644
--- a/examples/l3fwd-acl/main.c
+++ b/examples/l3fwd-acl/main.c
@@ -127,8 +127,7 @@ static struct rte_eth_conf port_conf = {
.mq_mode= ETH_MQ_RX_RSS,
.max_rx_pkt_len = ETHER_MAX_LEN,
.split_hdr_size = 0,
- .offloads = (DEV_RX_OFFLOAD_CRC_STRIP |
-DEV_RX_OFFLOAD_CHECKSUM),
+ .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
},
.rx_adv_conf = {
.rss_conf = {
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index d15cd520e..b00a8ec45 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -180,8 +180,8 @@ static struct rte_eth_conf port_conf = {
.mq_mode= ETH_MQ_RX_RSS,
.max_rx_pkt_len = ETHER_MAX_LEN,
.split_hdr_size = 0,
- .offloads = (DEV_RX_OFFLOAD_CRC_STRIP |
-DEV_RX_OFFLOAD_CHECKSUM),
+ .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
+
},
.rx_adv_conf = {
.rss_conf = {
diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c
index 5edd91a78..2a10e9d76 100644
--- a/examples/l3fwd-vf/main.c
+++ b/examples/l3fwd-vf/main.c
@@ -161,8 +161,7 @@ static struct rte_eth_conf port_conf = {
.mq_mode= ETH_MQ_RX_RSS,
.max_rx_pkt_len = ETHER_MAX_LEN,
.split_hdr_size = 0,
- .offloads = (DEV_RX_OFFLOAD_CRC_STRIP |
-DEV_RX_OFFLOAD_CHECKSUM),
+ .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
},
.rx_adv_conf = {
.rss_conf = {
diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index ab019b9e4..d4a79b23f 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -120,8 +120,7 @@ static struct rte_eth_conf port_conf = {
.mq_mode = ETH_MQ_RX_RSS,
.max_rx_pkt_len = ETHER_MAX_LEN,
.split_hdr_size = 0,
- .offloads = (DEV_RX_OFF
Re: [dpdk-dev] [PATCH] hash table: add a bucket iterator function
> On Jul 28, 2018, at 12:48 PM, Qiaobin Fu wrote:
>
> Function rte_hash_bucket_iterate() enables callers to
> incrementally iterate over the hash table bucket by bucket,
> so that it can avoid creating hiccups and thrashing the cache
> of the processor.
>
> This patch mainly deals with cases in which
> the hash table is full and one needs to decide if the incoming
> entry is more valuable than the entries already in the hash table.
>
> Signed-off-by: Qiaobin Fu
> Reviewed-by: Cody Doucette
> Reviewed-by: Michel Machado
> ---
> lib/librte_hash/rte_cuckoo_hash.c| 60 +
> lib/librte_hash/rte_hash.h | 66
> lib/librte_hash/rte_hash_version.map | 4 ++
> 3 files changed, 130 insertions(+)
>
> diff --git a/lib/librte_hash/rte_cuckoo_hash.c
> b/lib/librte_hash/rte_cuckoo_hash.c
> index a07543a29..2b90f3593 100644
> --- a/lib/librte_hash/rte_cuckoo_hash.c
> +++ b/lib/librte_hash/rte_cuckoo_hash.c
> @@ -1160,3 +1160,63 @@ rte_hash_iterate(const struct rte_hash *h, const void
> **key, void **data, uint32
>
> return position - 1;
> }
> +
> +int
> +rte_hash_get_num_buckets(struct rte_hash *h)
> +{
> + RETURN_IF_TRUE((h == NULL), -EINVAL);
> + return h->num_buckets;
> +}
> +
> +uint32_t
> +rte_hash_get_primary_bucket(const struct rte_hash *h, hash_sig_t sig)
> +{
> + return sig & h->bucket_bitmask;
> +}
> +
> +uint32_t
> +rte_hash_get_secondary_bucket(const struct rte_hash *h, hash_sig_t sig)
> +{
> + return rte_hash_secondary_hash(sig) & h->bucket_bitmask;
> +}
The above two functions should have the RETURN_IF_TRUE((h == NULL), -EINVAL);
statements just like the first one.
> +
> +int32_t
> +rte_hash_bucket_iterate(const struct rte_hash *h,
> + const void **key, void **data, uint32_t *bidx, uint32_t *next)
> +{
> + uint32_t position;
> + struct rte_hash_key *next_key;
> +
> + RETURN_IF_TRUE(((h == NULL) || (key == NULL) || (data == NULL) ||
> + (bidx == NULL) || (next == NULL)), -EINVAL);
> +
> + /* Out of bounds. */
> + if (*bidx >= h->num_buckets || *next >= RTE_HASH_BUCKET_ENTRIES)
> + goto next_bucket;
> +
> + /* If current position is empty, go to the next one. */
> + while (h->buckets[*bidx].key_idx[*next] == EMPTY_SLOT) {
> + (*next)++;
> + /* End of bucket. */
> + if (*next >= RTE_HASH_BUCKET_ENTRIES)
> + goto next_bucket;
> + }
> +
> + /* Get position of entry in key table. */
> + position = h->buckets[*bidx].key_idx[*next];
> + next_key = (struct rte_hash_key *) ((char *)h->key_store +
> + position * h->key_entry_size);
> + /* Return key and data. */
> + *key = next_key->key;
> + *data = next_key->pdata;
> +
> + /* Increment iterator. */
> + (*next)++;
> +
> + return position - 1;
> +
> +next_bucket:
> + *bidx = (*bidx + 1) >= h->num_buckets ? 0 : *bidx + 1;
> + *next = 0;
If this is an error case why are we setting *next to zero and incrementing
*bidx ?
I would expect we should not change the values on an error because they cannot
debug the values on return.
> + return -ENOENT;
> +}
> diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
> index f71ca9fbf..329bf42d6 100644
> --- a/lib/librte_hash/rte_hash.h
> +++ b/lib/librte_hash/rte_hash.h
> @@ -94,6 +94,17 @@ rte_hash_create(const struct rte_hash_parameters *params);
> */
> void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t func);
>
> +/**
> + * Get the number of buckets in the hash table.
> + * @param h
> + * Hash table for which the function queries.
> + * @return
> + * The number of buckets in the hash table h.
> + *- EINVAL - invalid parameter passed to function
> + */
> +int
Needs to change to ‘int __rte_experimental’
> +rte_hash_get_num_buckets(struct rte_hash *h);
> +
> /**
> * Find an existing hash table object and return a pointer to it.
> *
> @@ -261,6 +272,34 @@ int
> rte_hash_get_key_with_position(const struct rte_hash *h, const int32_t
> position,
> void **key);
>
> +/**
> + * Get the primary bucket index given the precomputed hash value.
> + * This operation is multi-thread safe.
> + *
> + * @param h
> + * Hash table to get the key from.
> + * @param sig
> + * Precomputed hash value.
> + * @return
> + * The primary bucket index.
Comment the error case here.
> + */
> +uint32_t
Needs to change to ‘uint32_t __rte_experimental’
> +rte_hash_get_primary_bucket(const struct rte_hash *h, hash_sig_t sig);
> +
> +/**
> + * Get the secondary bucket index given the precomputed hash value.
> + * This operation is multi-thread safe.
> + *
> + * @param h
> + * Hash table to get the key from.
> + * @param sig
> + * Precomputed hash value.
> + * @return
> + * The primary bucket index.
Comment the error case here.
> + */
> +uint32_t
Needs to change to ‘uint32_t __rte_experiment
Re: [dpdk-dev] [PATCH v2] net/i40e: fix max frame size checking
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Friday, July 27, 2018 4:13 PM
> To: Wu, Yanglong ; dev@dpdk.org
> Cc: Zhang, Qi Z ; Yao, Lei A
> Subject: RE: [PATCH v2] net/i40e: fix max frame size checking
>
>
>
> > -Original Message-
> > From: Wu, Yanglong
> > Sent: Friday, July 27, 2018 5:40 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z ; Ananyev, Konstantin
> > ; Yao, Lei A ; Wu,
> > Yanglong
> > Subject: [PATCH v2] net/i40e: fix max frame size checking
> >
> > Check patcket size according to TSO or no-TSO.
> >
> > Fixes: bfeed0262b0c ("net/i40e: check illegal packets")
> >
> > Signed-off-by: Yanglong Wu
> > ---
> > v2:
> > change as comments.
> > ---
> > drivers/net/i40e/i40e_ethdev.h | 1 +
> > drivers/net/i40e/i40e_rxtx.c | 9 +
> > 2 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > b/drivers/net/i40e/i40e_ethdev.h index cb5e5b5d8..3fffe5a55 100644
> > --- a/drivers/net/i40e/i40e_ethdev.h
> > +++ b/drivers/net/i40e/i40e_ethdev.h
> > @@ -28,6 +28,7 @@
> > #define I40E_NUM_DESC_ALIGN 32
> > #define I40E_BUF_SIZE_MIN 1024
> > #define I40E_FRAME_SIZE_MAX 9728
> > +#define I40E_TSO_FRAME_SIZE_MAX 262144
> > #define I40E_QUEUE_BASE_ADDR_UNIT 128
> > /* number of VSIs and queue default setting */
> > #define I40E_MAX_QP_NUM_PER_VF16
> > diff --git a/drivers/net/i40e/i40e_rxtx.c
> > b/drivers/net/i40e/i40e_rxtx.c index 3be87fe6a..1bbc0340b 100644
> > --- a/drivers/net/i40e/i40e_rxtx.c
> > +++ b/drivers/net/i40e/i40e_rxtx.c
> > @@ -1439,13 +1439,15 @@ i40e_prep_pkts(__rte_unused void *tx_queue,
> > struct rte_mbuf **tx_pkts,
> >
> > /* Check for m->nb_segs to not exceed the limits. */
> > if (!(ol_flags & PKT_TX_TCP_SEG)) {
> > - if (m->nb_segs > I40E_TX_MAX_MTU_SEG) {
> > + if (m->nb_segs > I40E_TX_MAX_MTU_SEG ||
> > + m->pkt_len > I40E_FRAME_SIZE_MAX) {
> > rte_errno = -EINVAL;
> > return i;
> > }
> > } else if (m->nb_segs > I40E_TX_MAX_SEG ||
> >m->tso_segsz < I40E_MIN_TSO_MSS ||
> > - m->tso_segsz > I40E_MAX_TSO_MSS) {
> > + m->tso_segsz > I40E_MAX_TSO_MSS ||
> > + m->pkt_len > I40E_TSO_FRAME_SIZE_MAX) {
> > /* MSS outside the range (256B - 9674B) are considered
> > * malicious
> > */
> > @@ -1459,8 +1461,7 @@ i40e_prep_pkts(__rte_unused void *tx_queue,
> struct rte_mbuf **tx_pkts,
> > }
> >
> > /* check the size of packet */
> > - if (m->pkt_len > I40E_FRAME_SIZE_MAX ||
> > - m->pkt_len < I40E_TX_MIN_PKT_LEN) {
> > + if (m->pkt_len < I40E_TX_MIN_PKT_LEN) {
> > rte_errno = -EINVAL;
> > return i;
> > }
> > --
>
> Acked-by: Konstantin Ananyev
Applied to dpdk-next-net-intel.
Thanks!
Qi
>
> > 2.11.0
Re: [dpdk-dev] [PATCH v3] doc: add i40e recommended matching list
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, July 24, 2018 3:29 PM > To: Li, Xiaoyun ; Mcnamara, John > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH v3] doc: add i40e recommended matching list > > > > > -Original Message- > > From: Li, Xiaoyun > > Sent: Tuesday, July 24, 2018 3:20 PM > > To: Mcnamara, John ; Xing, Beilei > > ; Zhang, Qi Z > > Cc: dev@dpdk.org; Li, Xiaoyun > > Subject: [PATCH v3] doc: add i40e recommended matching list > > > > Add suggested DPDK/kernel driver/firmware version matching list for i40e. > > > > Signed-off-by: Xiaoyun Li > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks! Qi >
Re: [dpdk-dev] [PATCH 1/3] net/virtio: remove unnecessary assignments
On Wed, Jul 25, 2018 at 03:42:06PM +0800, Tiwei Bie wrote: > Remove the unnecessary assignments in Rx functions > as they are useless and misleading. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_rxtx.c | 2 -- > 1 file changed, 2 deletions(-) Series applied to dpdk-next-virtio/master
[dpdk-dev] eventdev: method for finding out unlink status
Hi, In bug report https://bugs.dpdk.org/show_bug.cgi?id=60 we have been discussing issues related to events ending up in wrong ports after calling rte_event_port_unlink(). In addition of finding few bugs we have identified a need for a new API call (or documentation extension) for an application to be able to find out when an unlink() call has finished and no new events are scheduled anymore to the particular event port. This is required e.g. when doing clean-up after an application thread stops processing events. The bug report discussion provides more background on the subject and Harry has already proposed a new 'int32_t rte_event_unlinks_in_progress()' API as one possible solution. -Matias
