Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix minor resource leak during init
Tuesday, May 22, 2018 6:37 PM, Adrien Mazarguil:
> Subject: [PATCH 1/2] net/mlx4: fix minor resource leak during init
>
> Temporary IB device context and list are not freed in case of a successful
> initialization of the device.
>
> This issue is caused by the two following commits, the first of which causes
> initialization to return early, while the second one goes a bit overboard
> while
> switching to negative errno values; an internal variable
> (err) is needed to tell success from failure at the end of the function since
> rte_errno is not reliable enough.
>
> Fixes: f2318196c71a ("net/mlx4: remove limitation on number of instances")
> Fixes: 9d14b27308a0 ("net/mlx4: standardize on negative errno values")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Adrien Mazarguil
Series applied to next-net-mlx, thanks.
Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix errno object in probe code (minor)
Thursday, May 24, 2018 9:31 PM, Yongseok Koh:
> Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix errno object in probe code
> (minor)
>
>
> > On May 24, 2018, at 5:17 AM, Adrien Mazarguil
> wrote:
> >
> > Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values")
> > Cc: Nélio Laranjeiro
> >
> > Signed-off-by: Adrien Mazarguil
> > ---
> Acked-by: Yongseok Koh
Series applied to next-net-mlx, thanks.
>
> Thanks
Re: [dpdk-dev] [PATCH] net/mlx5: fix error message in probe function
Friday, May 25, 2018 7:46 PM, Yongseok Koh:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix error message in probe
> function
>
>
> > On May 25, 2018, at 9:16 AM, Adrien Mazarguil
> wrote:
> >
> > Error values passed to strerror() must be positive.
> >
> > Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity")
> > Cc: Shahaf Shuler
> >
> > Signed-off-by: Adrien Mazarguil
> > ---
> Acked-by: Yongseok Koh
Applied to next-net-mlx, thanks.
>
> Thanks
Re: [dpdk-dev] [PATCH v1] net/mlx5: fix pmd crash in device probe
Wednesday, June 13, 2018 5:18 PM, Adrien Mazarguil:
> Subject: Re: [PATCH v1] net/mlx5: fix pmd crash in device probe
>
> On Tue, Jun 12, 2018 at 07:38:11PM +0800, Xueming Li wrote:
> > This patch initializes counter descriptor struct before invoking Verbs
> > api to avoid segment fault.
> >
> > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
> > Cc: or...@mellanox.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Xueming Li
>
> Acked-by: Adrien Mazarguil
Applied to next-net-mlx, thanks.
>
> --
> Adrien Mazarguil
> 6WIND
Re: [dpdk-dev] [PATCH] mlx5: fix log initialization
Thursday, June 14, 2018 9:46 AM, Nélio Laranjeiro:
> Subject: Re: [dpdk-dev] [PATCH] mlx5: fix log initialization
>
> On Wed, Jun 13, 2018 at 11:46:26AM -0700, Stephen Hemminger wrote:
> > The mlx5 driver had two init functions, but this could cause log
> > initialization to be done after the other initialization. Also, the
> > name of the function does not match convention (cut/paste error?).
>
> Indeed an error in the copy/paste, sorry,
>
> > Fix by initializing log type first at start of the pmd_init.
> > This also gets rid of having two constructor functions.
> >
> > Fixes: a170a30d22a8 ("net/mlx5: use dynamic logging")
> > Signed-off-by: Stephen Hemminger
>
> Acked-by: Nelio Laranjeiro
>
Applied to next-net-mlx with few log modifications:
1. title should be net/mlx5
2. Cc: sta...@dpdk.org
Thanks.
[dpdk-dev] vmxnet3 TX TCP/UDP checksum not getting computed with L2_len > 14
Hello, Issue observed when using vmxnet3 based interface on packet with following structure is sent: Ethernet + PPPoE + PPP (22 bytes) as the Layer 2 header, IPv4 (20) UDP DNS Payload The tx offload value in this case is 0x0f0 (PKT_TX_IPV4 | PKT_TX_IP_CKSUM | PKT_TX_UDP_CKSUM) The checksum of the packet seen by the receiver shows incorrect checksum and it’s value is the pseudo checksum value that was set at the time of the TX. However the IP header checksum is correct. The same issue is not seen when the L2 header is a just the Ethernet (14 bytes). Also, with the same setup on the same hardware if we switch the driver from vmxnet3 to e1000e, all checksums are computed correctly. Is this a DPDK vmxnet3 driver bug or that of underlying esxi? The ESXi version is 6.0.0 (Build 3620759). Thanks, Padam
Re: [dpdk-dev] [PATCH v2 2/7] net/mlx5: remove redundant objects in probe code
Hi Adrien,
Small nit,
Thursday, June 14, 2018 11:35 AM, Adrien Mazarguil:
> Subject: [PATCH v2 2/7] net/mlx5: remove redundant objects in probe code
>
> This patch gets rid of redundant calls to open the device and query its
> attributes in order to simplify the code.
>
> Signed-off-by: Adrien Mazarguil
> --
> v2 changes:
>
> - Minor indent fix on existing code.
> ---
> drivers/net/mlx5/mlx5.c | 64 +---
> 1 file changed, 30 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> 3bdcb3970..1a5391e63 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -654,10 +654,10 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused, {
> struct ibv_device **list = NULL;
> struct ibv_device *ibv_dev;
> + struct ibv_context *ctx = NULL;
> + struct ibv_device_attr_ex attr;
> struct mlx5dv_context dv_attr = { .comp_mask = 0 };
> int err = 0;
> - struct ibv_context *attr_ctx = NULL;
> - struct ibv_device_attr_ex device_attr;
> unsigned int vf = 0;
> unsigned int mps;
> unsigned int cqe_comp;
> @@ -714,12 +714,12 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> PCI_DEVICE_ID_MELLANOX_CONNECTX5VF) ||
> (pci_dev->id.device_id ==
> PCI_DEVICE_ID_MELLANOX_CONNECTX5EXVF));
> - attr_ctx = mlx5_glue->open_device(list[i]);
> + ctx = mlx5_glue->open_device(list[i]);
> rte_errno = errno;
> err = rte_errno;
> break;
> }
> - if (attr_ctx == NULL) {
> + if (ctx == NULL) {
> switch (err) {
> case 0:
> DRV_LOG(ERR,
> @@ -748,7 +748,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused, #ifdef HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT
> dv_attr.comp_mask |= MLX5DV_CONTEXT_MASK_STRIDING_RQ;
> #endif
> - mlx5_glue->dv_query_device(attr_ctx, &dv_attr);
> + mlx5_glue->dv_query_device(ctx, &dv_attr);
> if (dv_attr.flags & MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED) {
> if (dv_attr.flags &
> MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW) {
> DRV_LOG(DEBUG, "enhanced MPW is supported");
> @@ -822,23 +822,20 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> DRV_LOG(WARNING, "MPLS over GRE/UDP tunnel offloading
> disabled due to"
> " old OFED/rdma-core version or firmware configuration");
> #endif
> - err = mlx5_glue->query_device_ex(attr_ctx, NULL, &device_attr);
> + err = mlx5_glue->query_device_ex(ctx, NULL, &attr);
> if (err) {
> DEBUG("ibv_query_device_ex() failed");
> goto error;
> }
> - DRV_LOG(INFO, "%u port(s) detected",
> - device_attr.orig_attr.phys_port_cnt);
> - for (i = 0; i < device_attr.orig_attr.phys_port_cnt; i++) {
> + DRV_LOG(INFO, "%u port(s) detected",
> attr.orig_attr.phys_port_cnt);
> + for (i = 0; i < attr.orig_attr.phys_port_cnt; i++) {
> char name[RTE_ETH_NAME_MAX_LEN];
> int len;
> uint32_t port = i + 1; /* ports are indexed from one */
> - struct ibv_context *ctx = NULL;
> struct ibv_port_attr port_attr;
> struct ibv_pd *pd = NULL;
> struct priv *priv = NULL;
> struct rte_eth_dev *eth_dev = NULL;
> - struct ibv_device_attr_ex device_attr_ex;
> struct ether_addr mac;
> struct mlx5_dev_config config = {
> .cqe_comp = cqe_comp,
> @@ -865,7 +862,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> len = snprintf(name, sizeof(name), PCI_PRI_FMT,
>pci_dev->addr.domain, pci_dev->addr.bus,
>pci_dev->addr.devid, pci_dev->addr.function);
> - if (device_attr.orig_attr.phys_port_cnt > 1)
> + if (attr.orig_attr.phys_port_cnt > 1)
> snprintf(name + len, sizeof(name), " port %u", i);
> if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> eth_dev = rte_eth_dev_attach_secondary(name);
> @@ -907,7 +904,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> continue;
> }
> DRV_LOG(DEBUG, "using port %u", port);
> - ctx = mlx5_glue->open_device(ibv_dev);
> + if (!ctx)
Is it really possible for ctx to be NULL on this stage?
Maybe assert is preferable?
> + ctx = mlx5_glue->open_device(ibv_dev);
> if (ctx == NULL) {
> err = ENODEV;
> goto port_error;
> @@ -949,7 +947,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> priv->ctx = ctx;
> strncpy(priv->ibdev_pat
Re: [dpdk-dev] [PATCH v2 3/7] net/mlx5: split PCI from generic probing code
Thursday, June 14, 2018 11:35 AM, Adrien Mazarguil:
> Subject: [PATCH v2 3/7] net/mlx5: split PCI from generic probing code
>
> All the generic probing code needs is an IB device. While this device is
> currently supplied by a PCI lookup, other methods will be added soon.
>
> This patch divides the original function, which has become huge over time, as
> follows:
>
> 1. PCI-specific (mlx5_pci_probe()).
> 2. All ports of a Verbs device (mlx5_dev_spawn()).
> 3. A given port of a Verbs device (mlx5_dev_spawn_one()).
>
> (Patch based on prior work from Yuanhan Liu)
>
> Signed-off-by: Adrien Mazarguil
> --
> v2 changes:
>
> - Fixed device naming. A port suffix is now appended only if several IB
> ports happen to be detected.
> - Added separate message to distinguish missing kernel drivers from other
> initialization errors, as it was confusing.
[...]
> +/**
> + * DPDK callback to register a PCI device.
> + *
> + * This function creates an Ethernet device for each port of a given
> + * PCI device.
> + *
> + * @param[in] pci_drv
> + * PCI driver structure (mlx5_driver).
> + * @param[in] pci_dev
> + * PCI device information.
> + *
> + * @return
> + * 0 on success, a negative errno value otherwise and rte_errno is set.
> + */
> +static int
> +mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
> +struct rte_pci_device *pci_dev) {
> + struct ibv_device **ibv_list;
> + struct rte_eth_dev **eth_list = NULL;
> + int vf;
> + int ret;
> +
> + assert(pci_drv == &mlx5_driver);
> + switch (pci_dev->id.device_id) {
> + case PCI_DEVICE_ID_MELLANOX_CONNECTX4VF:
> + case PCI_DEVICE_ID_MELLANOX_CONNECTX4LXVF:
> + case PCI_DEVICE_ID_MELLANOX_CONNECTX5VF:
> + case PCI_DEVICE_ID_MELLANOX_CONNECTX5EXVF:
> + vf = 1;
> + break;
> + default:
> + vf = 0;
> + }
Even though I couldn't find any functional bug, I think it is logically more
correct to determine if pci device is vf after we know this is Mellanox device.
Meaning the above block should be ...
> + errno = 0;
> + ibv_list = mlx5_glue->get_device_list(&ret);
> + if (!ibv_list) {
> + rte_errno = errno ? errno : ENOSYS;
> + DRV_LOG(ERR, "cannot list devices, is ib_uverbs loaded?");
> return -rte_errno;
> }
> - return 0;
> + while (ret-- > 0) {
> + struct rte_pci_addr pci_addr;
> +
> + DRV_LOG(DEBUG, "checking device \"%s\"", ibv_list[ret]-
> >name);
> + if (mlx5_ibv_device_to_pci_addr(ibv_list[ret], &pci_addr))
> + continue;
> + if (pci_dev->addr.domain != pci_addr.domain ||
> + pci_dev->addr.bus != pci_addr.bus ||
> + pci_dev->addr.devid != pci_addr.devid ||
> + pci_dev->addr.function != pci_addr.function)
> + continue;
> + DRV_LOG(INFO, "PCI information matches, using device
> \"%s\"",
> + ibv_list[ret]->name);
> + break;
> + }
Here.
> + if (ret >= 0)
> + eth_list = mlx5_dev_spawn(&pci_dev->device, ibv_list[ret],
> vf);
> + mlx5_glue->free_device_list(ibv_list);
> + if (!ret) {
> + DRV_LOG(WARNING,
> + "no Verbs device matches PCI device " PCI_PRI_FMT
> ","
> + " are kernel drivers loaded?",
> + pci_dev->addr.domain, pci_dev->addr.bus,
> + pci_dev->addr.devid, pci_dev->addr.function);
> + rte_errno = ENOENT;
> + ret = -rte_errno;
> + } else if (!eth_list || !*eth_list) {
> + DRV_LOG(ERR,
> + "probe of PCI device " PCI_PRI_FMT " aborted after"
> + " encountering an error: %s",
> + pci_dev->addr.domain, pci_dev->addr.bus,
> + pci_dev->addr.devid, pci_dev->addr.function,
> + strerror(rte_errno));
> + ret = -rte_errno;
> + } else {
> + for (ret = 0; eth_list[ret]; ++ret) {
> + rte_eth_copy_pci_info(eth_list[ret], pci_dev);
> + rte_eth_dev_probing_finish(eth_list[ret]);
> + }
> + ret = 0;
> + }
> + free(eth_list);
> + return ret;
> }
>
> static const struct rte_pci_id mlx5_pci_id_map[] = {
> --
> 2.11.0
Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port representors
Hi Adrien,
Saturday, June 16, 2018 11:58 AM, Xueming(Steven) Li:
> Subject: RE: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port representors
>
> > -Original Message-
> > From: dev On Behalf Of Adrien Mazarguil
> > Sent: Thursday, June 14, 2018 4:35 PM
> > To: Shahaf Shuler
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 6/7] net/mlx5: probe all port
> > representors
> >
> > Probe existing port representors in addition to their master device and
> associate them automatically.
> >
> > To avoid name collision between Ethernet devices, their names use the
> > same convention as ixgbe and i40e PMDs, that is, instead of only a PCI
> address in DBDF notation:
> >
> > - "net_{DBDF}_0" for master/switch devices.
This is breaking compatibility for application using the device names in order
to attach them to the application (e.g. OVS-DPDK).
Before this patch the naming scheme for non-representor port is "{DBDF}".
Can we preserve the compatibility and add appropriate suffix for the
representor case?
> > - "net_{DBDF}_representor_{rep}" with "rep" starting from 0 for port
> > representors.
> >
> > Both optionally suffixed with "_port_{num}" instead of " port {num}"
> > for devices that expose several Verbs ports (note this is never the case on
> mlx5, but kept for historical reasons for the time being).
> >
> > (Patch based on prior work from Yuanhan Liu)
> >
> > Signed-off-by: Adrien Mazarguil
> > --
> > v2 changes:
> >
> > - Added representor information to dev_infos_get(). DPDK port ID of
> master
> > device is now stored in the private structure to retrieve it
> > conveniently.
> > - Master device is assigned dummy representor ID value -1 to better
> > distinguish from the the first actual representor reported by
> > dev_infos_get() as those are indexed from 0.
> > - Added RTE_ETH_DEV_REPRESENTOR device flag.
> > ---
> > drivers/net/mlx5/mlx5.c| 138
> > drivers/net/mlx5/mlx5.h| 9 ++-
> > drivers/net/mlx5/mlx5_ethdev.c | 151
>
> > drivers/net/mlx5/mlx5_mac.c| 2 +-
> > drivers/net/mlx5/mlx5_stats.c | 6 +-
> > 5 files changed, 252 insertions(+), 54 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> > 498f80c89..716c9d9a5 100644
> > --- a/drivers/net/mlx5/mlx5.c
> > +++ b/drivers/net/mlx5/mlx5.c
> > @@ -304,6 +304,9 @@ mlx5_dev_close(struct rte_eth_dev *dev)
> > if (ret)
> > DRV_LOG(WARNING, "port %u some flows still remain",
> > dev->data->port_id);
> > + if (!priv->representor &&
> > + priv->domain_id != RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID)
> > + claim_zero(rte_eth_switch_domain_free(priv->domain_id));
> > memset(priv, 0, sizeof(*priv));
> > }
> >
> > @@ -648,6 +651,10 @@ mlx5_uar_init_secondary(struct rte_eth_dev
> *dev)
> > * Verbs device attributes.
> > * @param port
> > * Verbs port to use (indexed from 1).
> > + * @param master
> > + * Master device in case @p ibv_dev is a port representor.
> > + * @param rep_id
> > + * Representor identifier when @p master is non-NULL.
> > *
> > * @return
> > * A valid Ethernet device object on success, NULL otherwise and
> rte_errno
> > @@ -658,7 +665,9 @@ mlx5_dev_spawn_one(struct rte_device
> *dpdk_dev,
> >struct ibv_device *ibv_dev,
> >int vf,
> >const struct ibv_device_attr_ex *attr,
> > - unsigned int port)
> > + unsigned int port,
> > + struct rte_eth_dev *master,
> > + unsigned int rep_id)
> > {
> > struct ibv_context *ctx;
> > struct ibv_port_attr port_attr;
> > @@ -802,11 +811,14 @@ mlx5_dev_spawn_one(struct rte_device
> *dpdk_dev,
> > " old OFED/rdma-core version or firmware configuration");
> #endif
> > config.mpls_en = mpls_en;
> > - if (attr->orig_attr.phys_port_cnt > 1)
> > - snprintf(name, sizeof(name), "%s port %u",
> > -dpdk_dev->name, port);
> > + if (!master)
> > + snprintf(name, sizeof(name), "net_%s_0", dpdk_dev-
> >name);
> > else
> > - snprintf(name, sizeof(name), "%s", dpdk_dev->name);
> > + snprintf(name, sizeof(name), "net_%s_representor_%u",
> > +dpdk_dev->name, rep_id);
> > + if (attr->orig_attr.phys_port_cnt > 1)
> > + snprintf(name, sizeof(name), "%s_port_%u", name, port);
> > + DRV_LOG(DEBUG, "naming Ethernet device \"%s\"", name);
> > if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> > eth_dev = rte_eth_dev_attach_secondary(name);
> > if (eth_dev == NULL) {
> > @@ -883,6 +895,30 @@ mlx5_dev_spawn_one(struct rte_device
> *dpdk_dev,
> > priv->port = port;
> > priv->pd = pd;
> > priv->mtu = ETHER_MTU;
> > + /*
> > +* Allocate a switch domain for master devices and share it with
> > +* port representors.
> > +
Re: [dpdk-dev] [RFC v2] eventdev: event tx adapter APIs
-Original Message-
> Date: Wed, 13 Jun 2018 03:02:43 +0530
> From: Nikhil Rao
> To: jerin.ja...@caviumnetworks.com, olivier.m...@6wind.com
> CC: hemant.agra...@nxp.com, dev@dpdk.org, narender.vang...@intel.com,
> abhinandan.guj...@intel.com, gage.e...@intel.com, jia@intel.com,
> cristian.dumitre...@intel.com, Nikhil Rao
> Subject: [RFC v2] eventdev: event tx adapter APIs
> X-Mailer: git-send-email 1.8.3.1
>
> Add common APIs for the transmit stage of an event driven
> DPDK application. Also add a transmit queue field to the mbuf
> that is used by the adapter to transmit mbufs.
>
> Signed-off-by: Nikhil Rao
> ---
>
> Changelog
> =
>
> v1->v2:
> * Add the tx_adapter_enqueue function to struct rte_eventdev.
>It is set to the common Tx adapter function when creating the adapter
>if the eventdev PMD does not support it or if the
>DEV_TX_OFFLOAD_MT_LOCKFREE flag is NOT set on all ethernet devices.
> * Add the rte_event_eth_tx_adapter_enqueue() API.
> * Add the txq_id field to struct rte_mbuf.
>
Overall it looks good. Some comments inline. I think you can change it
from RFC and send the implementation.
> lib/librte_eventdev/rte_event_eth_tx_adapter.h | 380
> +
> lib/librte_eventdev/rte_eventdev.h | 7 +-
> lib/librte_mbuf/rte_mbuf.h | 20 +-
Please split mbuf changes in a separate patch.
> 3 files changed, 405 insertions(+), 2 deletions(-)
> create mode 100644 lib/librte_eventdev/rte_event_eth_tx_adapter.h
>
> diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.h
> b/lib/librte_eventdev/rte_event_eth_tx_adapter.h
> new file mode 100644
> index 000..a0e8505
> --- /dev/null
> +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.h
> @@ -0,0 +1,380 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2017 Intel Corporation.
2018
> + */
> +
> +#ifndef _RTE_EVENT_ETH_TX_ADAPTER_
> +#define _RTE_EVENT_ETH_TX_ADAPTER_
> +
> +/**
> + * @file
> + *
> + * RTE Event Ethernet Tx Adapter
> + *
> + * The event ethernet Tx adapter provides configuration and data path APIs
> + * for the transmit stage of an event driven packet processing application.
> + * These APIs abstract the implementation of the transmit stage and allow the
s/transmit stage/ethernet transmit stage/
> + * the application to use eventdev PMD support or a common implementation.
> + *
> + * In the common implementation, the application uses the adapter API to
> + * enqueue mbufs to the adapter which runs as a rte_service function. The
> + * service function deqeueues events from its event port and transmits the
s/deqeueues/dequeues
> + * mbufs referenced by these events.
> + *
> + * The ethernet Tx event adapter APIs are:
> + *
> + * - rte_event_eth_tx_adapter_create()
> + * - rte_event_eth_tx_adapter_create_ext()
> + * - rte_event_eth_tx_adapter_free()
> + * - rte_event_eth_tx_adapter_start()
> + * - rte_event_eth_tx_adapter_stop()
> + * - rte_event_eth_tx_adapter_queue_start()
> + * - rte_event_eth_tx_adapter_queue_stop()
> + * - rte_event_eth_tx_adapter_enqueue()
> + * - rte_event_eth_tx_adapter_stats_get()
> + * - rte_event_eth_tx_adapter_stats_reset()
> + *
> + * The application creates the adapter using
> + * rte_event_eth_tx_adapter_create(). The adapter may internally create an
> event
> + * port using the port configuration parameter.
> + * The adapter is responsible for linking the queue as per its
> implementation,
> + * for example in the case of the service function, the adapter links this
> queue
> + * to the event port it will dequeue events from.
> + *
> + * The application uses rte_event_eth_tx_adapter_enqueue() to send mbufs to
> the
> + * adaptervia this event queue. The ethernet port and transmit queue index to
s/adaptervia/adapter via
> + * transmit the mbuf on are specified in the mbuf.
> + *
> + * The application can start and stop the adapter using the
> + * rte_event_eth_tx_adapter_start/stop() calls.
> + *
> + * To support dynamic reconfiguration of Tx queues, the application can
> + * call rte_event_eth_tx_adapter_queue_start()/stop() to synchronize
> + * access to the Tx queue with the adapter. For example, if the application
> + * wants to reconfigure a Tx queue that could be concurrently
> + * being accessed by the adapter, it calls
> rte_event_eth_tx_adapter_queue_stop()
> + * first, reconfigures the queue and then calls
> + * rte_event_eth_tx_adapter_queue_start() which signals to the adapter
> + * that it is safe to resume access to the Tx queue.
> + *
> + * The common adapter implementation uses an EAL service function as
> described
> + * before and its execution is controlled using the rte_service APIs. The
> + * rte_event_eth_tx_adapter_service_id_get()
> + * function can be used to retrieve the adapter's service function ID.
> + */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#include
> +
> +#include "rte_eventdev.h"
> +
> +#define RTE_EVENT_ETH_TX_ADA
Re: [dpdk-dev] [PATCH v3 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev
> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Wednesday, May 16, 2018 7:05 AM
> To: De Lara Guarch, Pablo
> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu
> ; Ashish Gupta
>
> Subject: [PATCH v3 3/6] lib/cryptodev: add asymmetric crypto capability in
> cryptodev
>
> Extend cryptodev with asymmetric capability APIs and definitions.
>
> changes from v2:
> - remove redundant xform_type from asym capability struct
> - rename rte_cryptodev_get_asym_xform_enum to be more consistent with
> other API names
>
> Signed-off-by: Shally Verma
> Signed-off-by: Sunila Sahu
> Signed-off-by: Ashish Gupta
>
> ---
> User must apply patch
> "lib/cryptodev: add asymmetric algos in cryptodev" before compilation
> ---
> ---
> lib/librte_cryptodev/Makefile | 1 +
> lib/librte_cryptodev/rte_cryptodev.c | 73 +
> lib/librte_cryptodev/rte_cryptodev.h | 107
> -
> lib/librte_cryptodev/rte_cryptodev_version.map | 11 ++-
> 4 files changed, 186 insertions(+), 6 deletions(-)
>
> diff --git a/lib/librte_cryptodev/Makefile b/lib/librte_cryptodev/Makefile
> index
> 138e627dc..93f9d2d45 100644
> --- a/lib/librte_cryptodev/Makefile
> +++ b/lib/librte_cryptodev/Makefile
> @@ -12,6 +12,7 @@ LIBABIVER := 4
> # build flags
> CFLAGS += -O3
> CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -DALLOW_EXPERIMENTAL_API
I don't think this flag is needed. You are exporting experimental API, but not
using inside the library
(apps/drivers will need to use this flag, though).
> LDLIBS += -lrte_eal -lrte_mempool -lrte_ring -lrte_mbuf LDLIBS +=
> -lrte_kvargs
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.c
> b/lib/librte_cryptodev/rte_cryptodev.c
> index 4015872ed..ee76cef07 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.c
...
> +const struct rte_cryptodev_asymmetric_xfrm_capability *
s/xfrm/xform/. Same for the rest of the code.
...
> +int __rte_experimental
> +rte_cryptodev_asym_xfrm_capability_check_modlen(
> + const struct rte_cryptodev_asymmetric_xfrm_capability *capability,
> + uint16_t modlen)
> +{
> + /* handle special case of 0 which means PMD doesn't define
> + * any limit
> + */
> + if ((capability->modlen.min != 0) &&
> + ((modlen < capability->modlen.min) ||
> + (capability->modlen.increment != 0 &&
> + (modlen % (capability->modlen.increment)
> + return -1;
It is a bit difficult to read this. I think it would be better to separate this
if into multiple ones,
making it easier to review. Same with the following one.
> + if ((capability->modlen.max != 0) &&
> + ((modlen > capability->modlen.max) ||
> + (capability->modlen.increment != 0 &&
> + (modlen % (capability->modlen.increment)
> + return -1;
> +
> + return 0;
> +}
> +
>
> const char *
> rte_cryptodev_get_feature_name(uint64_t flag) diff --git
> a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
> index 623459a95..6c13d23f8 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
...
> @@ -1164,7 +1265,7 @@ int __rte_experimental
> rte_cryptodev_asym_session_set_private_data(
> struct rte_cryptodev_asym_session
> *sess,
> void *data,
> - uint16_t size)
> + uint16_t size);
Fix this in previous patch.
>
> /**
> * Get private data of a session.
> @@ -1178,7 +1279,7 @@ rte_cryptodev_asym_session_set_private_data(
> */
> void * __rte_experimental
> rte_cryptodev_asym_session_get_private_data(
> - struct rte_cryptodev_asym_session *sess)
> + struct rte_cryptodev_asym_session *sess);
>
>
> #ifdef __cplusplus
> diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map
> b/lib/librte_cryptodev/rte_cryptodev_version.map
> index 62b782444..817cf9f70 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_version.map
> +++ b/lib/librte_cryptodev/rte_cryptodev_version.map
> @@ -89,13 +89,18 @@ DPDK_17.11 {
> EXPERIMENTAL {
> global:
>
> - rte_cryptodev_asym_get_private_session_size
> + rte_cryptodev_asym_capability_get;
> + rte_cryptodev_asym_get_private_session_size;
> + rte_cryptodev_asym_get_xform_enum;
> + rte_crypto_asym_op_strings;
> rte_cryptodev_asym_session_clear;
> rte_cryptodev_asym_session_create;
> rte_cryptodev_asym_session_free;
> rte_cryptodev_asym_session_init;
> - rte_cryptodev_asym_session_get_private_data
> - rte_cryptodev_asym_session_set_private_data
> + rte_cryptodev_asym_session_get_private_data;
> + rte_cryptodev_asym_session_set_private_data;
> + rte_cryptodev_asym_xfrm_capabil
Re: [dpdk-dev] [PATCH 2/2] event/sw: support device stop flush callback
-Original Message- > Date: Thu, 14 Jun 2018 10:20:08 + > From: "Van Haaren, Harry" > To: "Eads, Gage" , "dev@dpdk.org" > CC: "jerin.ja...@caviumnetworks.com" , > "Richardson, Bruce" , "Rao, Nikhil" > , "Carrillo, Erik G" , > "Gujjar, Abhinandan S" > Subject: RE: [PATCH 2/2] event/sw: support device stop flush callback > > > > From: Eads, Gage > > Sent: Thursday, May 31, 2018 2:56 PM > > To: dev@dpdk.org > > Cc: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > > ; Richardson, Bruce > > ; > > Rao, Nikhil ; Carrillo, Erik G > > ; Gujjar, Abhinandan S > > > > Subject: [PATCH 2/2] event/sw: support device stop flush callback > > > > This commit also adds a flush callback test to the sw eventdev's selftest > > suite. > > > > Signed-off-by: Gage Eads > > > One compile warning below, with that fixed; > > Acked-by: Harry van Haaren > Applied v2 series to dpdk-next-eventdev/master. Thanks.
Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
Hi Shally,
> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Wednesday, May 16, 2018 7:05 AM
> To: De Lara Guarch, Pablo
> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu
> ; Ashish Gupta
>
> Subject: [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
>
> Add unit test case to test openssl PMD asym crypto
> operations. Test case invoke asymmetric operation on DPDK
> Openssl PMD and cross-verify results via Openssl SW library.
> Tests have been verified with openssl 1.0.2m release.
Is it possible to run these tests without using an external library to verify
the results,
like what we do with symmetric crypto? Having known answers in the test vectors?
I am not familiar with asymmetric, that's why I am asking.
Also, you are adding asymmetric support for OpenSSL PMD in the 5th patch,
So this test won't work until then.
I think it is better to change the other between patch 4 and 5.
>
> Tested for:
>
> * RSA Encrypt, Decrypt, Sign and Verify using pre-defined
> test vectors
> * Modular Inversion and Exponentiation using pre-defined
> test vectors
> * Deiffie-Hellman Public key generation using pre-defined
> private key and dynamically generated test vectors
> * Deffie-hellman private key generation using dynamically
> generated test vectors
> * Deffie-hellman private and public key pair generation
> using xform chain and using dynamically generated test
> vectors
> * Deffie-hellman shared secret compute using dynamically
> generated test vectors
> * DSA Sign and Verification
>
> Deffie-hellman testcases use run-time generated test params,
> thus may take some time for execution.
>
> Changes from v2:
> - Change test application to use the renamed APIs and
> to use xform type from capability structure
>
> Signed-off-by: Shally Verma
> Signed-off-by: Sunila Sahu
> Signed-off-by: Ashish Gupta
>
> ---
> This patch dependent on asym crypto API patches.
> Please apply them before compilation
> ---
> ---
> test/test/Makefile |3 +-
> test/test/meson.build |1 +
> test/test/test_cryptodev_asym.c | 1787
> +++
> 3 files changed, 1790 insertions(+), 1 deletion(-)
>
> diff --git a/test/test/Makefile b/test/test/Makefile
> index d1a75fe92..9526b939d 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -179,6 +179,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) +=
> test_pmd_ring_perf.c
>
> SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_blockcipher.c
> SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev.c
> +SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_asym.c
>
> ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
> SRCS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += test_compressdev.c
> @@ -205,7 +206,7 @@ CFLAGS += $(WERROR_FLAGS)
>
> CFLAGS += -D_GNU_SOURCE
>
> -LDLIBS += -lm
> +LDLIBS += -lm -lcrypto
If openssl libcrypto is actually required, I would add a check similar to
the one just below, with compressdev, to add "-lcrypto", so
users can run the test app without this, if they don't want to test asymmetric.
> ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
> ifeq ($(CONFIG_RTE_LIBRTE_COMPRESSDEV),y)
> LDLIBS += -lz
..
> +++ b/test/test/test_cryptodev_asym.c
> @@ -0,0 +1,1787 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2017-2018 Cavium Networks
> + */
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +
> +#include
> +#include
> +#include
> +#include
Move this to the top of the file (as it is an external library to DPDK).
> +
> +#include "test.h"
> +#include "test_cryptodev.h"
...
> +/** rsa xform using exponent key */
> +struct rte_crypto_asym_xform rsa_xform = {
> + .next = NULL,
> + .xform_type = RTE_CRYPTO_ASYM_XFORM_RSA,
> + .rsa = {
> + .n = {
> + .data =
> + (uint8_t *)
> +
For better consistency, could you use the format used above (0x00, 0xB3,
0xA1...)?
> ("\x00\xb3\xa1\xaf\xb7\x13\x08\x00\x0a\x35\xdc\x2b\x20\x8d"
...
> +#pragma GCC diagnostic pop
> +
> +static int
> +test_rsa(struct rsa_test_data *t)
...
> + rsa->n =
> + BN_bin2bn(
> + (const unsigned char *)rsa_xform.rsa.n.data,
> + rsa_xform.rsa.n.length,
> + rsa->n);
I am getting a compilation error:
/test/test/test_cryptodev_asym.c:322:5: error:
dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
rsa->n =
^~
My OpenSSL version is 1.1.0h.
Thanks,
Pablo
Re: [dpdk-dev] [PATCH v1 1/4] eventdev: standardize Rx adapter internal function names
-Original Message- > Date: Fri, 8 Jun 2018 23:45:14 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao > Subject: [PATCH v1 1/4] eventdev: standardize Rx adapter internal function > names > X-Mailer: git-send-email 1.8.3.1 > > Add a common prefix to function names and rename > few to better match functionality > > Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob
Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support
> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Wednesday, May 16, 2018 7:05 AM
> To: De Lara Guarch, Pablo
> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu
> ; Ashish Gupta
>
> Subject: [PATCH v3 5/6] crypto/openssl: add asym crypto support
>
> Add asymmetric crypto operation support in openssl PMD.
> Current list of supported asym xforms:
> * RSA
> * DSA
> * Deffie-hellman
> * Modular Operations
>
> changes from v2:
> - Update the pmd capability as per new capability structure
>
> changes from v1:
> - resolve new line error in dod/guides/cryptodevs/openssl.rst
>
> Signed-off-by: Shally Verma
> Signed-off-by: Sunila Sahu
> Signed-off-by: Ashish Gupta
> ---
> doc/guides/cryptodevs/features/openssl.ini | 11 +
> doc/guides/cryptodevs/openssl.rst| 1 +
> drivers/crypto/openssl/rte_openssl_pmd.c | 377 -
> drivers/crypto/openssl/rte_openssl_pmd_ops.c | 395
> ++-
> drivers/crypto/openssl/rte_openssl_pmd_private.h | 29 ++
> 5 files changed, 801 insertions(+), 12 deletions(-)
>
> diff --git a/doc/guides/cryptodevs/features/openssl.ini
> b/doc/guides/cryptodevs/features/openssl.ini
> index 691565865..bef5c7f79 100644
> --- a/doc/guides/cryptodevs/features/openssl.ini
> +++ b/doc/guides/cryptodevs/features/openssl.ini
> @@ -7,6 +7,7 @@
> Symmetric crypto = Y
> Sym operation chaining = Y
> Mbuf scatter gather= Y
> +Asymmetric crypto = Y
>
> ;
> ; Supported crypto algorithms of the 'openssl' crypto driver.
> @@ -49,3 +50,13 @@ AES GCM (256) = Y
> AES CCM (128) = Y
> AES CCM (192) = Y
> AES CCM (256) = Y
> +
> +;
> +; Supported Asymmetric algorithms of the 'openssl' crypto driver.
> +;
> +[Asymmetric]
> +RSA = Y
> +DSA = Y
> +Modular Exponentiation = Y
> +Modular Inversion = Y
> +Deffie-hellman = Y
You need to add these parameters in default.ini file,
otherwise they are not shown when building the documentation.
> diff --git a/doc/guides/cryptodevs/openssl.rst
> b/doc/guides/cryptodevs/openssl.rst
> index 427fc807c..4f90be888 100644
> --- a/doc/guides/cryptodevs/openssl.rst
> +++ b/doc/guides/cryptodevs/openssl.rst
> @@ -80,6 +80,7 @@ crypto processing.
>
> Test name is cryptodev_openssl_autotest.
> For performance test cryptodev_openssl_perftest can be used.
> +For asymmetric crypto operations testing, run
> +cryptodev_openssl_asym_autotest
>
> To verify real traffic l2fwd-crypto example can be used with this command:
>
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
> b/drivers/crypto/openssl/rte_openssl_pmd.c
> index f584d0d6f..527e42773 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
...
> + }
> + dh_key->priv_key = BN_bin2bn(op->priv_key.data,
> + op->priv_key.length,
> + dh_key->priv_key);
As on the previous patch, I am getting a compilation issue:
drivers/crypto/openssl/rte_openssl_pmd.c:1711:9: error:
dereferencing pointer to incomplete type 'DH {aka struct dh_st}'
dh_key->priv_key = BN_bin2bn(op->priv_key.data,
...
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> index 1cb87d59a..76f7410cb 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
...
> struct rte_cryptodev_ops openssl_pmd_ops = {
> .dev_configure = openssl_pmd_config,
> .dev_start = openssl_pmd_start,
> @@ -750,8 +1138,11 @@ struct rte_cryptodev_ops openssl_pmd_ops = {
> .queue_pair_count = openssl_pmd_qp_count,
>
> .session_get_size = openssl_pmd_session_get_size,
> + .asym_session_get_size =
> openssl_pmd_asym_session_get_size,
> .session_configure = openssl_pmd_session_configure,
> - .session_clear = openssl_pmd_session_clear
> + .asym_session_configure =
> openssl_pmd_asym_session_configure,
> + .session_clear = openssl_pmd_session_clear,
> + .asym_session_clear = openssl_pmd_asym_session_clear
> };
I think session_get_size, session_configure and session_clear should be renamed
to sym_session_*, to avoid confusion. Could you add another patch renaming
these?
Thanks,
Pablo
Re: [dpdk-dev] [PATCH v1 2/4] eventdev: improve err handling for Rx adapter queue add/del
-Original Message-
> Date: Fri, 8 Jun 2018 23:45:15 +0530
> From: Nikhil Rao
> To: jerin.ja...@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao
> Subject: [PATCH v1 2/4] eventdev: improve err handling for Rx adapter queue
> add/del
> X-Mailer: git-send-email 1.8.3.1
>
> The new WRR sequence applicable after queue add/del is set
> up after setting the new queue state, so a memory allocation
> failure will leave behind an incorrect state.
>
> This change separates the memory sizing + allocation for the
> Rx poll and WRR array from calculation of the WRR sequence.
> If there is a memory allocation failure, existing Rx queue
> configuration remains unchanged.
>
> Signed-off-by: Nikhil Rao
> ---
> @@ -995,7 +1177,6 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter
> *rx_adapter,
> struct rte_event_eth_rx_adapter *rx_adapter;
> struct rte_eventdev *dev;
> struct eth_device_info *dev_info;
> - int start_service;
>
> RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
> RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_dev_id, -EINVAL);
> @@ -1038,7 +1219,6 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter
> *rx_adapter,
> return -EINVAL;
> }
>
> - start_service = 0;
> dev_info = &rx_adapter->eth_devices[eth_dev_id];
>
> if (cap & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
> @@ -1072,16 +1252,13 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter
> *rx_adapter,
> ret = rxa_sw_add(rx_adapter, eth_dev_id, rx_queue_id,
> queue_conf);
> rte_spinlock_unlock(&rx_adapter->rx_lock);
> - if (ret == 0)
> - start_service =
> - !!rxa_sw_adapter_queue_count(rx_adapter);
> }
>
> if (ret)
> return ret;
>
> - if (start_service)
> - rte_service_component_runstate_set(rx_adapter->service_id, 1);
> + rte_service_component_runstate_set(rx_adapter->service_id,
> + rxa_sw_adapter_queue_count(rx_adapter));
Please move this logic under above !cap &
RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT
condition as rte_service not valid for internal ports.
>
Re: [dpdk-dev] [PATCH v3 6/6] doc: add asym crypto in cryptodev programmer guide
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Wednesday, May 16, 2018 7:05 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.go...@nxp.com; > dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v3 6/6] doc: add asym crypto in cryptodev programmer guide > > Update cryptodev programmer guide with description of asymmetric crypto > framework in lib cryptodev. > > Signed-off-by: Shally Verma > Signed-off-by: Sunila Sahu > Signed-off-by: Ashish Gupta > --- > doc/guides/prog_guide/cryptodev_lib.rst | 338 ... > + > + > +Asymmetric crypto Sample code > +- Could you change the previous section "crypto sample code" to "Symmetric crypto sample code", for more clarification? ... > -Crypto Device API > -~ > +Asymmetric Crypto Device API > + This is not specific to Asymmetric, so the name should remained "Crypto Device API", In a different section (so change "~" to "-"). > > The cryptodev Library API is described in the *DPDK API Reference* document. > -- > 2.14.3
Re: [dpdk-dev] [PATCH v1 3/4] eventdev: move Rx adapter eth receive code to separate function
-Original Message- > Date: Fri, 8 Jun 2018 23:45:16 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao > Subject: [PATCH v1 3/4] eventdev: move Rx adapter eth receive code to > separate function > X-Mailer: git-send-email 1.8.3.1 > > Create a separate function that handles eth receive and > enqueue to event buffer. This function will also be called for > interrupt driven receive queues. > > Signed-off-by: Nikhil Rao > --- There is two 3/4 patches in this series. Please remove the appropriate one.
Re: [dpdk-dev] [PATCH v1 3/4] eventdev: move Rx adapter eth Rx to separate function
-Original Message- > Date: Fri, 8 Jun 2018 23:45:17 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao > Subject: [PATCH v1 3/4] eventdev: move Rx adapter eth Rx to separate > function > X-Mailer: git-send-email 1.8.3.1 > > Create a separate function that handles eth receive and > enqueue to event buffer. This function will also be called for > interrupt driven receive queues. > > Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob
Re: [dpdk-dev] [PATCH v1 4/4] eventdev: add interrupt driven queues in Rx event adapter
-Original Message-
> Date: Fri, 8 Jun 2018 23:45:18 +0530
> From: Nikhil Rao
> To: jerin.ja...@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao
> Subject: [PATCH v1 4/4] eventdev: add interrupt driven queues in Rx event
> adapter
> X-Mailer: git-send-email 1.8.3.1
>
> Add support for interrupt driven queues when eth device is
> configured for rxq interrupts and servicing weight for the
> queue is configured to be zero.
>
> A interrupt driven packet received counter has been added to
> rte_event_eth_rx_adapter_stats.
>
> Signed-off-by: Nikhil Rao
> ---
> lib/librte_eventdev/rte_event_eth_rx_adapter.h |5 +-
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 1049
> +++-
> test/test/test_event_eth_rx_adapter.c | 261 -
Please move the testcase to separate patch.
> .../prog_guide/event_ethernet_rx_adapter.rst | 24 +
> config/common_base |1 +
This patch creates build issue with meson build.
command to reproduce:
export MESON_PARAMS='-Dwerror=true -Dexamples=all'
CC="ccache gcc" meson --default-library=shared $MESON_PARAMS gcc-shared-build
ninja -C gcc-shared-build
log:
---
../lib/librte_eventdev/rte_event_eth_rx_adapter.c: In function
‘rxa_intr_ring_check_avail’:
../lib/librte_eventdev/rte_event_eth_rx_adapter.c:916:5: error:
‘RTE_EVENT_ETH_INTR_RING_SIZE’ undeclared (first use in this function);
did you mean ‘RTE_EVENT_DEV_XSTATS_NAME_SIZE’?
RTE_EVENT_ETH_INTR_RING_SIZE) {
^~~~
RTE_EVENT_DEV_XSTATS_NAME_SIZE
../lib/librte_eventdev/rte_event_eth_rx_adapter.c:916:5: note: each
undeclared identifier is reported only once for each function it appears
in
../lib/librte_eventdev/rte_event_eth_rx_adapter.c: In function
‘rxa_intr_thread’:
../lib/librte_eventdev/rte_event_eth_rx_adapter.c:971:8: error:
‘RTE_EVENT_ETH_INTR_RING_SIZE’ undeclared (first use in this function);
did you mean ‘RTE_EVENT_DEV_XSTATS_NAME_SIZE’?
RTE_EVENT_ETH_INTR_RING_SIZE + 1, -1);
^~~~
> 6 files changed, 1296 insertions(+), 48 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> index 307b2b5..97f25e9 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> @@ -64,8 +64,7 @@
> * the service function ID of the adapter in this case.
> *
> * Note:
> - * 1) Interrupt driven receive queues are currently unimplemented.
> - * 2) Devices created after an instance of rte_event_eth_rx_adapter_create
> + * 1) Devices created after an instance of rte_event_eth_rx_adapter_create
> * should be added to a new instance of the rx adapter.
Can we remove this NOTE and add this check in the code if it is not the
case?
> */
>
> @@ -199,6 +198,8 @@ struct rte_event_eth_rx_adapter_stats {
>* block cycles can be used to compute the percentage of
>* cycles the service is blocked by the event device.
>*/
> + uint64_t rx_intr_packets;
> + /**< Received packet count for interrupt mode Rx queues */
> };
>
> /**
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 40e9bc9..d038ee4 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -2,6 +2,8 @@
> * Copyright(c) 2017 Intel Corporation.
> * All rights reserved.
> */
> +#include
> +#include
> #include
> #include
> #include
> @@ -11,6 +13,7 @@
> #include
> #include
> #include
> +#include
>
> #include "rte_eventdev.h"
> #include "rte_eventdev_pmd.h"
> @@ -24,6 +27,36 @@
> #define ETH_RX_ADAPTER_MEM_NAME_LEN 32
> +static void *
> +rxa_intr_thread(void *arg)
> +{
> + struct rte_event_eth_rx_adapter *rx_adapter = arg;
> + struct rte_epoll_event *epoll_events = rx_adapter->epoll_events;
> + int n, i;
> + uint8_t val;
> + ssize_t bytes_read;
> +
> + while (1) {
> + n = rte_epoll_wait(rx_adapter->epd, epoll_events,
> +RTE_EVENT_ETH_INTR_RING_SIZE + 1, -1);
Can you check with FreeBSD if everything is fine or not?
> + if (unlikely(n < 0))
> + RTE_EDEV_LOG_ERR("rte_epoll_wait returned error %d",
> + n);
> + for (i = 0; i < n; i++) {
> + if (epoll_events[i].fd == rx_adapter->intr_pipe.readfd)
> + goto done;
> + rxa_intr_ring_enqueue(rx_adapter,
> + epoll_events[i].epdata.data);
> + }
> + }
> +
> +done:
> +
> +static int
> +rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)
> +{
> + int err;
> + uint8_t val;
> + char thread_name[RTE_MAX_THREAD_NAME_LEN];
> +
> + if (rx_adapter->i
Re: [dpdk-dev] [PATCH] eventdev: add callback for Rx adapter SW transfers
-Original Message-
> Date: Fri, 8 Jun 2018 23:54:16 +0530
> From: Nikhil Rao
> To: jerin.ja...@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao
> Subject: [PATCH] eventdev: add callback for Rx adapter SW transfers
> X-Mailer: git-send-email 1.8.3.1
>
> Add ability for application to register a callback function
> for SW transfers, the callback can decide which packets can
> be enqueued to the event device.
>
> Signed-off-by: Nikhil Rao
> ---
> lib/librte_eventdev/rte_event_eth_rx_adapter.h | 78
> ++
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 69 +--
> .../prog_guide/event_ethernet_rx_adapter.rst | 14
> lib/librte_eventdev/rte_eventdev_version.map | 1 +
> 4 files changed, 158 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> index 97f25e9..23d2ed5 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> @@ -63,6 +63,17 @@
> * rte_event_eth_rx_adapter_service_id_get() function can be used to retrieve
> * the service function ID of the adapter in this case.
> *
> + * For SW based packet transfers, the service function temporarily enqueues
I think, you can mention this case is valid when
!RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT
> + * mbufs to an event buffer before batch enqueueing these to the event
> device.
> + * If the buffer fills up, the service function stops dequeueing packets from
> + * the ethernet device. The application may want to monitor the buffer fill
> + * level and instruct the service function to selectively buffer packets
> + * The application may also use some other criteria to decide which packets
> + * should enter the event device even when the event buffer fill level is
> low.
> + * The rte_event_eth_rx_adapter_cb_register() function allows the
> + * application to register a callback that selects which packets to enqueue
> + * to the event device.
> + *
> * Note:
> * 1) Devices created after an instance of rte_event_eth_rx_adapter_create
> * should be added to a new instance of the rx adapter.
> @@ -206,6 +217,47 @@ struct rte_event_eth_rx_adapter_stats {
> * @warning
> * @b EXPERIMENTAL: this API may change without prior notice
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * Register callback to process Rx packets, this is supported for
> + * SW based packet transfers.
> + * @see rte_event_eth_sw_rx_cb_fn
> + *
> + * @param id
> + * Adapter identifier.
> + * @param eth_dev_id
> + * Port identifier of Ethernet device.
> + * @param cb_fn
> + * Callback function.
> + * @param cb_arg
> + * Callback arg.
> + * @return
> + * - 0: Success
> + * - <0: Error code on failure.
> + */
> +int __rte_experimental
> +rte_event_eth_rx_sw_cb_register(uint8_t id,
> + uint16_t eth_dev_id,
> + rte_event_eth_rx_sw_cb_fn cb_fn,
> + void *cb_arg);
The documentation is using rte_event_eth_rx_adapter_cb_register(),
I think, it is better to keep that name. Remove *_sw_* from normative
DPDK APIs.
> +
> #ifdef __cplusplus
> }
> #endif
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map
> b/lib/librte_eventdev/rte_eventdev_version.map
> index c3f18d6..6bc81c6 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -109,4 +109,5 @@ EXPERIMENTAL {
> rte_event_crypto_adapter_stats_get;
> rte_event_crypto_adapter_stats_reset;
> rte_event_crypto_adapter_stop;
> + rte_event_eth_rx_sw_cb_register;
Use alphabetical order.
With above changes:
Acked-by: Jerin Jacob
> };
> --
> 1.8.3.1
>
Re: [dpdk-dev] [PATCH] event/octeontx: fix flush callback
-Original Message-
> Date: Fri, 15 Jun 2018 11:14:06 +0530
> From: Pavan Nikhilesh
> To: jerin.ja...@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh
> Subject: [dpdk-dev] [PATCH] event/octeontx: fix flush callback
> X-Mailer: git-send-email 2.17.1
>
> When event queues are being flushed the getwork operation used to extract
> events should be a grouped getwork operation to the specific event queue.
>
> Fixes: 8384f0e039ea ("event/octeontx: support device stop flush callback")
Cc: sta...@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh
Acked-by: Jerin Jacob
Re: [dpdk-dev] [PATCH] eventdev: update get id from name to include PCI devices
-Original Message-
> Date: Fri, 15 Jun 2018 09:15:24 +0530
> From: Pavan Nikhilesh
> To: jerin.ja...@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh
> Subject: [dpdk-dev] [PATCH] eventdev: update get id from name to include
> PCI devices
> X-Mailer: git-send-email 2.17.1
>
> Currently, rte_event_dev_get_dev_id works only for virtual devices(vdev)
> update the function to include devices probed through pci.
>
> Signed-off-by: Pavan Nikhilesh
Acked-by: Jerin Jacob
> ---
> lib/librte_eventdev/rte_eventdev.c | 15 ++-
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_eventdev.c
> b/lib/librte_eventdev/rte_eventdev.c
> index 7ca9fd145..801810edd 100644
> --- a/lib/librte_eventdev/rte_eventdev.c
> +++ b/lib/librte_eventdev/rte_eventdev.c
> @@ -57,16 +57,21 @@ int
> rte_event_dev_get_dev_id(const char *name)
> {
> int i;
> + uint8_t cmp;
>
> if (!name)
> return -EINVAL;
>
> - for (i = 0; i < rte_eventdev_globals->nb_devs; i++)
> - if ((strcmp(rte_event_devices[i].data->name, name)
> - == 0) &&
> - (rte_event_devices[i].attached ==
> - RTE_EVENTDEV_ATTACHED))
> + for (i = 0; i < rte_eventdev_globals->nb_devs; i++) {
> + cmp = (strncmp(rte_event_devices[i].data->name, name,
> + RTE_EVENTDEV_NAME_MAX_LEN) == 0) ||
> + (rte_event_devices[i].dev ? (strncmp(
> + rte_event_devices[i].dev->driver->name, name,
> + RTE_EVENTDEV_NAME_MAX_LEN) == 0) : 0);
> + if (cmp && (rte_event_devices[i].attached ==
> + RTE_EVENTDEV_ATTACHED))
> return i;
> + }
> return -ENODEV;
> }
>
> --
> 2.17.1
>
Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
Hi Pablo
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 17 June 2018 18:23
>To: Verma, Shally
>Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
>; Sahu, Sunila ;
>Gupta, Ashish
>Subject: RE: [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
>
>External Email
>
>Hi Shally,
>
>> -Original Message-
>> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
>> Sent: Wednesday, May 16, 2018 7:05 AM
>> To: De Lara Guarch, Pablo
>> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
>> dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu
>> ; Ashish Gupta
>>
>> Subject: [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
>>
>> Add unit test case to test openssl PMD asym crypto
>> operations. Test case invoke asymmetric operation on DPDK
>> Openssl PMD and cross-verify results via Openssl SW library.
>> Tests have been verified with openssl 1.0.2m release.
>
>Is it possible to run these tests without using an external library to verify
>the results,
>like what we do with symmetric crypto? Having known answers in the test
>vectors?
>I am not familiar with asymmetric, that's why I am asking.
>
[Shally] I prefer to have it cross verified using an independent library
module, that's the reason I kept design that way.
>Also, you are adding asymmetric support for OpenSSL PMD in the 5th patch,
>So this test won't work until then.
>I think it is better to change the other between patch 4 and 5.
[Shally] Ok
>
>>
//snip
>>
>> -LDLIBS += -lm
>> +LDLIBS += -lm -lcrypto
>
>If openssl libcrypto is actually required, I would add a check similar to
>the one just below, with compressdev, to add "-lcrypto", so
>users can run the test app without this, if they don't want to test asymmetric.
>
>> ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
>> ifeq ($(CONFIG_RTE_LIBRTE_COMPRESSDEV),y)
>> LDLIBS += -lz
>
[Shally] You mean add another config option for Asymmetric test?
>..
>
//snip
>> +#include
>> +#include
>> +#include
>> +#include
>
>Move this to the top of the file (as it is an external library to DPDK).
>
[Shally] Ok
>> +
>> +#include "test.h"
>> +#include "test_cryptodev.h"
>
>...
>
>> +/** rsa xform using exponent key */
>> +struct rte_crypto_asym_xform rsa_xform = {
>> + .next = NULL,
>> + .xform_type = RTE_CRYPTO_ASYM_XFORM_RSA,
>> + .rsa = {
>> + .n = {
>> + .data =
>> + (uint8_t *)
>> +
>
>For better consistency, could you use the format used above (0x00, 0xB3,
>0xA1...)?
>
>> ("\x00\xb3\xa1\xaf\xb7\x13\x08\x00\x0a\x35\xdc\x2b\x20\x8d"
[Shally] Ok.
>
>...
>
>> +#pragma GCC diagnostic pop
>> +
>> +static int
>> +test_rsa(struct rsa_test_data *t)
>
>...
>
>> + rsa->n =
>> + BN_bin2bn(
>> + (const unsigned char *)rsa_xform.rsa.n.data,
>> + rsa_xform.rsa.n.length,
>> + rsa->n);
>
>I am getting a compilation error:
>
>/test/test/test_cryptodev_asym.c:322:5: error:
>dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
> rsa->n =
> ^~
>
>My OpenSSL version is 1.1.0h.
>
[Shally] This library is tested with version 1.0.2m (mentioned above) and also
one supported by openssl PMD . So, you need to take similar version.
Thanks for review.
Shally
>Thanks,
>Pablo
Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support
Hi Pablo
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 17 June 2018 18:55
>To: Verma, Shally
>Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
>; Sahu, Sunila ;
>Gupta, Ashish
>Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support
>
>External Email
>
>> -Original Message-
>> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
>> Sent: Wednesday, May 16, 2018 7:05 AM
>> To: De Lara Guarch, Pablo
>> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
>> dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu
>> ; Ashish Gupta
>>
>> Subject: [PATCH v3 5/6] crypto/openssl: add asym crypto support
>>
>> Add asymmetric crypto operation support in openssl PMD.
>> Current list of supported asym xforms:
>> * RSA
>> * DSA
>> * Deffie-hellman
>> * Modular Operations
>>
>> changes from v2:
>> - Update the pmd capability as per new capability structure
>>
>> changes from v1:
>> - resolve new line error in dod/guides/cryptodevs/openssl.rst
>>
>> Signed-off-by: Shally Verma
>> Signed-off-by: Sunila Sahu
>> Signed-off-by: Ashish Gupta
>> ---
.. [snip] ..
>> +;
>> +; Supported Asymmetric algorithms of the 'openssl' crypto driver.
>> +;
>> +[Asymmetric]
>> +RSA = Y
>> +DSA = Y
>> +Modular Exponentiation = Y
>> +Modular Inversion = Y
>> +Deffie-hellman = Y
>
>You need to add these parameters in default.ini file,
>otherwise they are not shown when building the documentation.
>
[Shally] Ok
..[snip]..
>>
>> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
>> b/drivers/crypto/openssl/rte_openssl_pmd.c
>> index f584d0d6f..527e42773 100644
>> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
>> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
>
>...
>
>> + }
>> + dh_key->priv_key = BN_bin2bn(op->priv_key.data,
>> + op->priv_key.length,
>> + dh_key->priv_key);
>
>As on the previous patch, I am getting a compilation issue:
>
>drivers/crypto/openssl/rte_openssl_pmd.c:1711:9: error:
>dereferencing pointer to incomplete type 'DH {aka struct dh_st}'
> dh_key->priv_key = BN_bin2bn(op->priv_key.data,
>
[Shally] as I mentioned before Openssl PMD support 1.0.2 version
series(http://doc.dpdk.org/guides/cryptodevs/openssl.html) and thus the error
>...
>
>> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
>> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
>> index 1cb87d59a..76f7410cb 100644
>> --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
>> +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
>
>...
>
>> struct rte_cryptodev_ops openssl_pmd_ops = {
>> .dev_configure = openssl_pmd_config,
>> .dev_start = openssl_pmd_start,
>> @@ -750,8 +1138,11 @@ struct rte_cryptodev_ops openssl_pmd_ops = {
>> .queue_pair_count = openssl_pmd_qp_count,
>>
>> .session_get_size = openssl_pmd_session_get_size,
>> + .asym_session_get_size =
>> openssl_pmd_asym_session_get_size,
>> .session_configure = openssl_pmd_session_configure,
>> - .session_clear = openssl_pmd_session_clear
>> + .asym_session_configure =
>> openssl_pmd_asym_session_configure,
>> + .session_clear = openssl_pmd_session_clear,
>> + .asym_session_clear = openssl_pmd_asym_session_clear
>> };
>
>I think session_get_size, session_configure and session_clear should be renamed
>to sym_session_*, to avoid confusion. Could you add another patch renaming
>these?
>
[Shally] I see in latest cryptodev these typedefs are already named to
cryptodev_sym_configure_session_t, _sym_get_session_private_size_t and
_sym_free_.. so these changes would come while rebase.
or you are referring to change openssl_pmd_session_configure to
openssl_pmd_sym_session_configure and so others?
Thanks for review.
>Thanks,
>Pablo
>
Re: [dpdk-dev] vmxnet3 TX TCP/UDP checksum not getting computed with L2_len > 14
On Sun, 17 Jun 2018 14:55:06 +0530 Padam Jeet Singh wrote: > Hello, > > Issue observed when using vmxnet3 based interface on packet with following > structure is sent: > > Ethernet + PPPoE + PPP (22 bytes) as the Layer 2 header, > IPv4 (20) > UDP > DNS Payload > > The tx offload value in this case is 0x0f0 (PKT_TX_IPV4 | > PKT_TX_IP_CKSUM | PKT_TX_UDP_CKSUM) > > The checksum of the packet seen by the receiver shows incorrect checksum and > it’s value is the pseudo checksum value that was set at the time of the TX. > However the IP header checksum is correct. > > The same issue is not seen when the L2 header is a just the Ethernet (14 > bytes). > > Also, with the same setup on the same hardware if we switch the driver from > vmxnet3 to e1000e, all checksums are computed correctly. > > Is this a DPDK vmxnet3 driver bug or that of underlying esxi? The ESXi > version is 6.0.0 (Build 3620759). > > Thanks, > Padam I don't think VMWare supports IP checksum offload. Since IP checksum is trivial and in cache, the IP header checksum offload is usually not a speed up anyway. Linux for example, never does IP header checksum offload.
Re: [dpdk-dev] [PATCH v3 6/6] doc: add asym crypto in cryptodev programmer guide
HI Pablo >-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 17 June 2018 19:03 >To: Verma, Shally >Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org; >Athreya, Narayana Prasad >; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [PATCH v3 6/6] doc: add asym crypto in cryptodev programmer guide > >External Email > >Hi Shally, > >> -Original Message- >> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] >> Sent: Wednesday, May 16, 2018 7:05 AM >> To: De Lara Guarch, Pablo >> Cc: Trahe, Fiona ; akhil.go...@nxp.com; >> dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu >> ; Ashish Gupta >> >> Subject: [PATCH v3 6/6] doc: add asym crypto in cryptodev programmer guide >> //snip >> doc/guides/prog_guide/cryptodev_lib.rst | 338 > >... > >> + >> + >> +Asymmetric crypto Sample code >> +- > >Could you change the previous section "crypto sample code" to >"Symmetric crypto sample code", for more clarification? > [Shally] Will do. >... > >> -Crypto Device API >> -~ >> +Asymmetric Crypto Device API >> + > >This is not specific to Asymmetric, so the name should remained "Crypto Device >API", >In a different section (so change "~" to "-"). > [Shally] Wil do. Thanks for review. Shally >> >> The cryptodev Library API is described in the *DPDK API Reference* document. >> -- >> 2.14.3
Re: [dpdk-dev] vmxnet3 TX TCP/UDP checksum not getting computed with L2_len > 14
> On 17-Jun-2018, at 10:16 PM, Stephen Hemminger > wrote: > > On Sun, 17 Jun 2018 14:55:06 +0530 > Padam Jeet Singh wrote: > >> Hello, >> >> Issue observed when using vmxnet3 based interface on packet with following >> structure is sent: >> >> Ethernet + PPPoE + PPP (22 bytes) as the Layer 2 header, >> IPv4 (20) >> UDP >> DNS Payload >> >> The tx offload value in this case is 0x0f0 (PKT_TX_IPV4 | >> PKT_TX_IP_CKSUM | PKT_TX_UDP_CKSUM) >> >> The checksum of the packet seen by the receiver shows incorrect checksum and >> it’s value is the pseudo checksum value that was set at the time of the TX. >> However the IP header checksum is correct. >> >> The same issue is not seen when the L2 header is a just the Ethernet (14 >> bytes). >> >> Also, with the same setup on the same hardware if we switch the driver from >> vmxnet3 to e1000e, all checksums are computed correctly. >> >> Is this a DPDK vmxnet3 driver bug or that of underlying esxi? The ESXi >> version is 6.0.0 (Build 3620759). >> >> Thanks, >> Padam > > I don't think VMWare supports IP checksum offload. Since IP checksum is > trivial and in cache, > the IP header checksum offload is usually not a speed up anyway. Linux for > example, never does > IP header checksum offload. It’s not the IP checksum - it’s the TCP/UDP checksum (L4) that’s not getting computed. In fact the IP checksum is coming correctly because we are handing it in software. The driver when queried returns TX offload flags with the IP header checksum bit off, but L4 checksum (TCP & UDP) are available. The UDP checksum gets computed correctly if and only if the l2_len is 14. In case of other encapsulations, e.g. pppoe (l2_len=22), this checksum computation is being skipped and the packet is simply sent out with the pseudo checksum value of the IP header.
Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Sunday, June 17, 2018 4:01 PM
> To: De Lara Guarch, Pablo
> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> dev@dpdk.org; Athreya, Narayana Prasad
> ; Sahu, Sunila
> ; Gupta, Ashish
> Subject: RE: [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
>
> Hi Pablo
>
> >-Original Message-
> >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
> >Sent: 17 June 2018 18:23
> >To: Verma, Shally
> >Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> >dev@dpdk.org; Athreya, Narayana Prasad
> >; Sahu, Sunila
> >; Gupta, Ashish
> >Subject: RE: [PATCH v3 4/6] test/crypto: add unit testcase for asym
> >crypto
> >
> >External Email
> >
> >Hi Shally,
> >
> >> -Original Message-
> >> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> >> Sent: Wednesday, May 16, 2018 7:05 AM
> >> To: De Lara Guarch, Pablo
> >> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> >> dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu
> >> ; Ashish Gupta
> >>
> >> Subject: [PATCH v3 4/6] test/crypto: add unit testcase for asym
> >> crypto
> >>
> >> Add unit test case to test openssl PMD asym crypto operations. Test
> >> case invoke asymmetric operation on DPDK Openssl PMD and cross-verify
> >> results via Openssl SW library.
> >> Tests have been verified with openssl 1.0.2m release.
> >
> >Is it possible to run these tests without using an external library to
> >verify the results, like what we do with symmetric crypto? Having known
> answers in the test vectors?
> >I am not familiar with asymmetric, that's why I am asking.
> >
> [Shally] I prefer to have it cross verified using an independent library
> module,
> that's the reason I kept design that way.
>
> >Also, you are adding asymmetric support for OpenSSL PMD in the 5th
> >patch, So this test won't work until then.
> >I think it is better to change the other between patch 4 and 5.
> [Shally] Ok
>
> >
> >>
>
> //snip
>
> >>
> >> -LDLIBS += -lm
> >> +LDLIBS += -lm -lcrypto
> >
> >If openssl libcrypto is actually required, I would add a check similar
> >to the one just below, with compressdev, to add "-lcrypto", so users
> >can run the test app without this, if they don't want to test asymmetric.
> >
> >> ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
> >> ifeq ($(CONFIG_RTE_LIBRTE_COMPRESSDEV),y)
> >> LDLIBS += -lz
> >
> [Shally] You mean add another config option for Asymmetric test?
At least check for CRYPTODEV, but since this is enabled by default,
I think we need an RTE_CRYPTODEV_ASYM_TEST flag.
>
> >..
> >
>
> //snip
>
> >> +#include
> >> +#include
> >> +#include
> >> +#include
> >
> >Move this to the top of the file (as it is an external library to DPDK).
> >
> [Shally] Ok
>
> >> +
> >> +#include "test.h"
> >> +#include "test_cryptodev.h"
> >
> >...
> >
> >> +/** rsa xform using exponent key */
> >> +struct rte_crypto_asym_xform rsa_xform = {
> >> + .next = NULL,
> >> + .xform_type = RTE_CRYPTO_ASYM_XFORM_RSA,
> >> + .rsa = {
> >> + .n = {
> >> + .data =
> >> + (uint8_t *)
> >> +
> >
> >For better consistency, could you use the format used above (0x00, 0xB3,
> 0xA1...)?
> >
> >> ("\x00\xb3\xa1\xaf\xb7\x13\x08\x00\x0a\x35\xdc\x2b\x20\x8d"
> [Shally] Ok.
>
> >
> >...
> >
> >> +#pragma GCC diagnostic pop
> >> +
> >> +static int
> >> +test_rsa(struct rsa_test_data *t)
> >
> >...
> >
> >> + rsa->n =
> >> + BN_bin2bn(
> >> + (const unsigned char *)rsa_xform.rsa.n.data,
> >> + rsa_xform.rsa.n.length,
> >> + rsa->n);
> >
> >I am getting a compilation error:
> >
> >/test/test/test_cryptodev_asym.c:322:5: error:
> >dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
> > rsa->n =
> > ^~
> >
> >My OpenSSL version is 1.1.0h.
> >
> [Shally] This library is tested with version 1.0.2m (mentioned above) and also
> one supported by openssl PMD . So, you need to take similar version.
I'd say we should support the latest stable version of OpenSSL.
Could you get the latest 1.1.0?
Thanks,
Pablo
Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Sunday, June 17, 2018 4:48 PM
> To: De Lara Guarch, Pablo
> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> dev@dpdk.org; Athreya, Narayana Prasad
> ; Sahu, Sunila
> ; Gupta, Ashish
> Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support
>
> Hi Pablo
>
> >-Original Message-
> >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
> >Sent: 17 June 2018 18:55
> >To: Verma, Shally
> >Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> >dev@dpdk.org; Athreya, Narayana Prasad
> >; Sahu, Sunila
> >; Gupta, Ashish
> >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support
> >
> >External Email
> >
> >> -Original Message-
> >> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> >> Sent: Wednesday, May 16, 2018 7:05 AM
> >> To: De Lara Guarch, Pablo
> >> Cc: Trahe, Fiona ; akhil.go...@nxp.com;
> >> dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu
> >> ; Ashish Gupta
> >>
> >> Subject: [PATCH v3 5/6] crypto/openssl: add asym crypto support
> >>
> >> Add asymmetric crypto operation support in openssl PMD.
> >> Current list of supported asym xforms:
> >> * RSA
> >> * DSA
> >> * Deffie-hellman
> >> * Modular Operations
> >>
> >> changes from v2:
> >> - Update the pmd capability as per new capability structure
> >>
> >> changes from v1:
> >> - resolve new line error in dod/guides/cryptodevs/openssl.rst
> >>
> >> Signed-off-by: Shally Verma
> >> Signed-off-by: Sunila Sahu
> >> Signed-off-by: Ashish Gupta
> >> ---
> .. [snip] ..
>
> >> +;
> >> +; Supported Asymmetric algorithms of the 'openssl' crypto driver.
> >> +;
> >> +[Asymmetric]
> >> +RSA = Y
> >> +DSA = Y
> >> +Modular Exponentiation = Y
> >> +Modular Inversion = Y
> >> +Deffie-hellman = Y
> >
> >You need to add these parameters in default.ini file, otherwise they
> >are not shown when building the documentation.
> >
> [Shally] Ok
>
> ..[snip]..
>
> >>
> >> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
> >> b/drivers/crypto/openssl/rte_openssl_pmd.c
> >> index f584d0d6f..527e42773 100644
> >> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> >> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
> >
> >...
> >
> >> + }
> >> + dh_key->priv_key = BN_bin2bn(op->priv_key.data,
> >> + op->priv_key.length,
> >> + dh_key->priv_key);
> >
> >As on the previous patch, I am getting a compilation issue:
> >
> >drivers/crypto/openssl/rte_openssl_pmd.c:1711:9: error:
> >dereferencing pointer to incomplete type 'DH {aka struct dh_st}'
> > dh_key->priv_key = BN_bin2bn(op->priv_key.data,
> >
> [Shally] as I mentioned before Openssl PMD support 1.0.2 version
> series(http://doc.dpdk.org/guides/cryptodevs/openssl.html) and thus the error
>
> >...
> >
> >> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> >> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> >> index 1cb87d59a..76f7410cb 100644
> >> --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> >> +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> >
> >...
> >
> >> struct rte_cryptodev_ops openssl_pmd_ops = {
> >> .dev_configure = openssl_pmd_config,
> >> .dev_start = openssl_pmd_start,
> >> @@ -750,8 +1138,11 @@ struct rte_cryptodev_ops openssl_pmd_ops = {
> >> .queue_pair_count = openssl_pmd_qp_count,
> >>
> >> .session_get_size = openssl_pmd_session_get_size,
> >> + .asym_session_get_size =
> >> openssl_pmd_asym_session_get_size,
> >> .session_configure = openssl_pmd_session_configure,
> >> - .session_clear = openssl_pmd_session_clear
> >> + .asym_session_configure =
> >> openssl_pmd_asym_session_configure,
> >> + .session_clear = openssl_pmd_session_clear,
> >> + .asym_session_clear = openssl_pmd_asym_session_clear
> >> };
> >
> >I think session_get_size, session_configure and session_clear should be
> >renamed to sym_session_*, to avoid confusion. Could you add another patch
> renaming these?
> >
> [Shally] I see in latest cryptodev these typedefs are already named to
> cryptodev_sym_configure_session_t, _sym_get_session_private_size_t and
> _sym_free_.. so these changes would come while rebase.
> or you are referring to change openssl_pmd_session_configure to
> openssl_pmd_sym_session_configure and so others?
Yes, but the name is still session_configure/clear, not
sym_session_configure/clear, right?
And also, I think we should rename the OpenSSL functions, openssl_pmd_session_*,
to openssl_pmd_sym_session_*.
Pablo
>
> Thanks for review.
>
> >Thanks,
> >Pablo
> >
Re: [dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency for linking
07/06/2018 11:43, Michal Krawczyk: > ENA PMD is required to use librte_timer. The appropriate depndency must > be added ifin case the DPDK will be built as shared library. > > Signed-off-by: Michal Krawczyk > --- > drivers/net/ena/Makefile | 1 + > mk/rte.app.mk| 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile > index 43339f3b9..ff9ce315b 100644 > --- a/drivers/net/ena/Makefile > +++ b/drivers/net/ena/Makefile > @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES) > LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs > LDLIBS += -lrte_bus_pci > +LDLIBS += -lrte_timer > > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 1e32c83e7..c70bc254e 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -60,6 +60,7 @@ endif > > _LDLIBS-y += --whole-archive > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer Why is it added in rte.app.mk? It is already there, few lines below.
Re: [dpdk-dev] [PATCH] vhost: fix missing increment of log cache count
On Fri, Jun 15, 2018 at 03:48:46PM +0200, Maxime Coquelin wrote:
> The log_cache_nb_elem was never incremented, resulting
> in all dirty pages to be missed during live migration.
>
> Fixes: c16915b87109 ("vhost: improve dirty pages logging performance")
> Cc: sta...@dpdk.org
>
> Reported-by: Peng He
> Cc: Ilya Maximets
> Signed-off-by: Maxime Coquelin
> ---
> lib/librte_vhost/vhost.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 528e01c8f..786a74f64 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -429,6 +429,7 @@ vhost_log_cache_page(struct virtio_net *dev, struct
> vhost_virtqueue *vq,
>
> vq->log_cache[i].offset = offset;
> vq->log_cache[i].val = (1UL << bit_nr);
> + vq->log_cache_nb_elem++;
> }
>
> static __rte_always_inline void
> --
> 2.14.3
>
Reviewed-by: Tiwei Bie
Re: [dpdk-dev] [PATCH V2] net/thunderx: add support for hardware first skip feature
-Original Message-
> Date: Thu, 14 Jun 2018 15:06:19 +0530
> From: rkudurumalla
> To: dev@dpdk.org
> Cc: ferruh.yi...@intel.com, jerin.ja...@caviumnetworks.com, Rakesh
> Kudurumalla
> Subject: [PATCH V2] net/thunderx: add support for hardware first skip
Add [dpdk-dev] in subject.
[dpdk-dev] [PATCH v2] net/thunderx: add support for hardware first skip
> feature
> X-Mailer: git-send-email 2.7.4
>
> This feature is used to create a hole between HEADROOM
> and actual data.Size of hole is specified in bytes as
> module param to pmd
>
> Signed-off-by: Rakesh Kudurumalla
> ---
> V1: https://dpdk.org/ml/archives/dev/2018-May/103058.html
> V2: Includes changes in thunder.rst to render outupt correctly in html
>
> doc/guides/nics/thunderx.rst | 18 +
> drivers/net/thunderx/base/nicvf_hw.c | 12 ++
> drivers/net/thunderx/base/nicvf_hw.h | 1 +
> drivers/net/thunderx/nicvf_ethdev.c | 76
> +++-
> drivers/net/thunderx/nicvf_ethdev.h | 1 +
> drivers/net/thunderx/nicvf_struct.h | 1 +
> 6 files changed, 108 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/nics/thunderx.rst b/doc/guides/nics/thunderx.rst
> index 2642374..7825b43 100644
> --- a/doc/guides/nics/thunderx.rst
> +++ b/doc/guides/nics/thunderx.rst
> @@ -30,6 +30,7 @@ Features of the ThunderX PMD are:
> - SR-IOV VF
> - NUMA support
> - Multi queue set support (up to 96 queues (12 queue sets)) per port
> +- First skip support
>
> Supported ThunderX SoCs
> ---
> @@ -312,6 +313,18 @@ We will choose four secondary queue sets from the ending
> of the list (0002:01:01
>
> The nicvf thunderx driver will make use of attached secondary VFs
> automatically during the interface configuration stage.
>
> +
> +Module params
> +--
> +
Create a sub section called skip_data_bytes. Since we are referecing this
fearture as skip_data_bytes, please remove first skip instance. I have
reformatted the documention. Here is the diff. Please consider using it.
➜ [master]laptop [dpdk.org] $ git diff
diff --git a/doc/guides/nics/thunderx.rst b/doc/guides/nics/thunderx.rst
index 5b00dd5e8..e84eaafe5 100644
--- a/doc/guides/nics/thunderx.rst
+++ b/doc/guides/nics/thunderx.rst
@@ -30,7 +30,7 @@ Features of the ThunderX PMD are:
- SR-IOV VF
- NUMA support
- Multi queue set support (up to 96 queues (12 queue sets)) per port
-- First skip support
+- Skip data bytes
Supported ThunderX SoCs
---
@@ -317,13 +317,16 @@ The nicvf thunderx driver will make use of
attached secondary VFs automatically
Module params
--
-This feature is used to create a hole between HEADROOM and actual
data.Size of hole is specified
-in bytes as module param("skip_data_bytes") to pmd.
-This scheme is useful when application would like to insert vlan
header without disturbing HEADROOM
+skip_data_bytes
+~~~
+This feature is used to create a hole between HEADROOM and actual data.
Size of hole is specified
+in bytes as module param("skip_data_bytes") to pmd.
+This scheme is useful when application would like to insert vlan header
without disturbing HEADROOM.
+Example:
+ .. code-block:: console
-use ``-w pci_id,skip_data_bytes="number of bytes to skip"``
-
+ -w 0002:01:00.2,skip_data_bytes=8
Limitations
---
@@ -349,7 +352,7 @@ The ThunderX SoC family NICs support up to 12
segments per packet when working
in scatter/gather mode. So, setting MTU will result with ``EINVAL``
when the
frame size does not fit in the maximum number of segments.
-First_skip
-~~
+skip_data_bytes
+~~~
-Maximum limit on first_skip is 128 bytes and number of bytes should be
multiple of 8.
+Maximum limit of skip_data_bytes is 128 bytes and number of bytes
should be multiple of 8.
> +This feature is used to create a hole between HEADROOM and actual
> data.Size of hole is specified
> +in bytes as module param("skip_data_bytes") to pmd.
> +This scheme is useful when application would like to insert vlan header
> without disturbing HEADROOM
> +
> +
> +use ``-w pci_id,skip_data_bytes="number of bytes to skip"``
> +
> +
> Limitations
> ---
>
> @@ -335,3 +348,8 @@ Maximum packet segments
> The ThunderX SoC family NICs support up to 12 segments per packet when
> working
> in scatter/gather mode. So, setting MTU will result with ``EINVAL`` when the
> frame size does not fit in the maximum number of segments.
> +
> +First_skip
> +~~
> +
> +Maximum limit on first_skip is 128 bytes and number of bytes should be
> multiple of 8.
> diff --git a/drivers/net/thunderx/base/nicvf_hw.c
> b/drivers/net/thunderx/base/nicvf_hw.c
> index ea8092c..b07a293 100644
> --- a/drivers/net/thunderx/base/nicvf_hw.c
> +++ b/drivers/net/thunderx/base/nicvf_hw.c
> @@ -703,6 +703,18 @@ nicvf_vlan_hw_strip(struct nicvf *nic, bool enable)
> }
>
> void
> +nicvf_first_skip_config(struct
Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support
Hi Pablo
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 18 June 2018 01:09
>To: Verma, Shally
>Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
>; Sahu, Sunila ;
>Gupta, Ashish
>Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support
>
>External Email
>
//snip
>> >> struct rte_cryptodev_ops openssl_pmd_ops = {
>> >> .dev_configure = openssl_pmd_config,
>> >> .dev_start = openssl_pmd_start,
>> >> @@ -750,8 +1138,11 @@ struct rte_cryptodev_ops openssl_pmd_ops = {
>> >> .queue_pair_count = openssl_pmd_qp_count,
>> >>
>> >> .session_get_size = openssl_pmd_session_get_size,
>> >> + .asym_session_get_size =
>> >> openssl_pmd_asym_session_get_size,
>> >> .session_configure = openssl_pmd_session_configure,
>> >> - .session_clear = openssl_pmd_session_clear
>> >> + .asym_session_configure =
>> >> openssl_pmd_asym_session_configure,
>> >> + .session_clear = openssl_pmd_session_clear,
>> >> + .asym_session_clear = openssl_pmd_asym_session_clear
>> >> };
>> >
>> >I think session_get_size, session_configure and session_clear should be
>> >renamed to sym_session_*, to avoid confusion. Could you add another patch
>> renaming these?
>> >
>> [Shally] I see in latest cryptodev these typedefs are already named to
>> cryptodev_sym_configure_session_t, _sym_get_session_private_size_t and
>> _sym_free_.. so these changes would come while rebase.
>> or you are referring to change openssl_pmd_session_configure to
>> openssl_pmd_sym_session_configure and so others?
>
>Yes, but the name is still session_configure/clear, not
>sym_session_configure/clear, right?
>And also, I think we should rename the OpenSSL functions,
>openssl_pmd_session_*,
>to openssl_pmd_sym_session_*.
>
[Shally] Ok. I will look into this.
Thanks
Shally
>Pablo
>
>>
>> Thanks for review.
>>
>> >Thanks,
>> >Pablo
>> >
[dpdk-dev] [PATCH V3] net/thunderx: add support for hardware first skip feature
From: rkudurumalla
This feature is used to create a hole between HEADROOM
and actual data.Size of hole is specified in bytes as
module param to pmd
Signed-off-by: Rakesh Kudurumalla
---
V1: https://dpdk.org/ml/archives/dev/2018-May/103058.html
V2: https://mails.dpdk.org/archives/dev/2018-June/104240.html
V3: Updated code-block console with example in thunder.rst file
doc/guides/nics/thunderx.rst | 21 ++
drivers/net/thunderx/base/nicvf_hw.c | 12 ++
drivers/net/thunderx/base/nicvf_hw.h | 1 +
drivers/net/thunderx/nicvf_ethdev.c | 76 +++-
drivers/net/thunderx/nicvf_ethdev.h | 1 +
drivers/net/thunderx/nicvf_struct.h | 1 +
6 files changed, 111 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/thunderx.rst b/doc/guides/nics/thunderx.rst
index 2642374..e84eaaf 100644
--- a/doc/guides/nics/thunderx.rst
+++ b/doc/guides/nics/thunderx.rst
@@ -30,6 +30,7 @@ Features of the ThunderX PMD are:
- SR-IOV VF
- NUMA support
- Multi queue set support (up to 96 queues (12 queue sets)) per port
+- Skip data bytes
Supported ThunderX SoCs
---
@@ -312,6 +313,21 @@ We will choose four secondary queue sets from the ending
of the list (0002:01:01
The nicvf thunderx driver will make use of attached secondary VFs
automatically during the interface configuration stage.
+
+Module params
+--
+
+skip_data_bytes
+~~~
+This feature is used to create a hole between HEADROOM and actual data. Size
of hole is specified
+in bytes as module param("skip_data_bytes") to pmd.
+This scheme is useful when application would like to insert vlan header
without disturbing HEADROOM.
+
+Example:
+ .. code-block:: console
+
+ -w 0002:01:00.2,skip_data_bytes=8
+
Limitations
---
@@ -335,3 +351,8 @@ Maximum packet segments
The ThunderX SoC family NICs support up to 12 segments per packet when working
in scatter/gather mode. So, setting MTU will result with ``EINVAL`` when the
frame size does not fit in the maximum number of segments.
+
+skip_data_bytes
+~~~
+
+Maximum limit of skip_data_bytes is 128 bytes and number of bytes should be
multiple of 8.
diff --git a/drivers/net/thunderx/base/nicvf_hw.c
b/drivers/net/thunderx/base/nicvf_hw.c
index ea8092c..b07a293 100644
--- a/drivers/net/thunderx/base/nicvf_hw.c
+++ b/drivers/net/thunderx/base/nicvf_hw.c
@@ -703,6 +703,18 @@ nicvf_vlan_hw_strip(struct nicvf *nic, bool enable)
}
void
+nicvf_first_skip_config(struct nicvf *nic, uint8_t num_dwords)
+{
+ uint64_t val;
+
+ val = nicvf_reg_read(nic, NIC_VNIC_RQ_GEN_CFG);
+ val &= ~(0xfULL);
+ val |= (num_dwords & 0xf);
+
+ nicvf_reg_write(nic, NIC_VNIC_RQ_GEN_CFG, val);
+}
+
+void
nicvf_apad_config(struct nicvf *nic, bool enable)
{
uint64_t val;
diff --git a/drivers/net/thunderx/base/nicvf_hw.h
b/drivers/net/thunderx/base/nicvf_hw.h
index 284d0bd..fd13ea8 100644
--- a/drivers/net/thunderx/base/nicvf_hw.h
+++ b/drivers/net/thunderx/base/nicvf_hw.h
@@ -193,6 +193,7 @@ uint32_t nicvf_qsize_sq_roundup(uint32_t val);
void nicvf_vlan_hw_strip(struct nicvf *nic, bool enable);
void nicvf_apad_config(struct nicvf *nic, bool enable);
+void nicvf_first_skip_config(struct nicvf *nic, uint8_t dwords);
int nicvf_rss_config(struct nicvf *nic, uint32_t qcnt, uint64_t cfg);
int nicvf_rss_term(struct nicvf *nic);
diff --git a/drivers/net/thunderx/nicvf_ethdev.c
b/drivers/net/thunderx/nicvf_ethdev.c
index 99fcd51..07e6a4d 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -34,6 +34,8 @@
#include
#include
#include
+#include
+#include
#include "base/nicvf_plat.h"
@@ -1230,6 +1232,7 @@ nicvf_rxq_mbuf_setup(struct nicvf_rxq *rxq)
{
uintptr_t p;
struct rte_mbuf mb_def;
+ struct nicvf *nic = rxq->nic;
RTE_BUILD_BUG_ON(sizeof(union mbuf_initializer) != 8);
RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) % 8 != 0);
@@ -1240,7 +1243,7 @@ nicvf_rxq_mbuf_setup(struct nicvf_rxq *rxq)
RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, port) -
offsetof(struct rte_mbuf, data_off) != 6);
mb_def.nb_segs = 1;
- mb_def.data_off = RTE_PKTMBUF_HEADROOM;
+ mb_def.data_off = RTE_PKTMBUF_HEADROOM + (nic->skip_bytes);
mb_def.port = rxq->port_id;
rte_mbuf_refcnt_set(&mb_def, 1);
@@ -1260,9 +1263,19 @@ nicvf_dev_rx_queue_setup(struct rte_eth_dev *dev,
uint16_t qidx,
struct nicvf_rxq *rxq;
struct nicvf *nic = nicvf_pmd_priv(dev);
uint64_t offloads;
+ uint32_t buffsz;
+ struct rte_pktmbuf_pool_private *mbp_priv;
PMD_INIT_FUNC_TRACE();
+ /* First skip check */
+ mbp_priv = rte_mempool_get_priv(mp);
+ buffsz = mbp_priv->mbuf_data_room_size - RTE_PKTMBUF_HEADROOM;
+ if (buffsz < (uint32_t)(nic->skip_bytes)) {
+ PMD_INIT_LOG(ERR, "First skip i
Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
Hi Pablo
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 18 June 2018 01:01
>To: Verma, Shally
>Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
>; Sahu, Sunila ;
>Gupta, Ashish
>Subject: RE: [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
>
>External Email
>
//snip
>> >> ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
>> >> ifeq ($(CONFIG_RTE_LIBRTE_COMPRESSDEV),y)
>> >> LDLIBS += -lz
>> >
>> [Shally] You mean add another config option for Asymmetric test?
>
>At least check for CRYPTODEV, but since this is enabled by default,
>I think we need an RTE_CRYPTODEV_ASYM_TEST flag.
[Shally] OK. Will look into this.
>
>>
>> >..
//snip
>> >> +#pragma GCC diagnostic pop
>> >> +
>> >> +static int
>> >> +test_rsa(struct rsa_test_data *t)
>> >
>> >...
>> >
>> >> + rsa->n =
>> >> + BN_bin2bn(
>> >> + (const unsigned char *)rsa_xform.rsa.n.data,
>> >> + rsa_xform.rsa.n.length,
>> >> + rsa->n);
>> >
>> >I am getting a compilation error:
>> >
>> >/test/test/test_cryptodev_asym.c:322:5: error:
>> >dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
>> > rsa->n =
>> > ^~
>> >
>> >My OpenSSL version is 1.1.0h.
>> >
>> [Shally] This library is tested with version 1.0.2m (mentioned above) and
>> also
>> one supported by openssl PMD . So, you need to take similar version.
>
>I'd say we should support the latest stable version of OpenSSL.
>Could you get the latest 1.1.0?
[Shally] Openssl PMD uses 1.0.2h. If we move test to 1.1.0 then dpdk would need
to be set
to link to two different version of libcrypto whenever openssl PMD is enabled
which seems like a cumbersome process for users.
So I recommend for now to stick to one version.
Thanks
Shally
>
>Thanks,
>Pablo
Re: [dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency for linking
2018-06-18 0:37 GMT+02:00 Thomas Monjalon : > 07/06/2018 11:43, Michal Krawczyk: >> ENA PMD is required to use librte_timer. The appropriate depndency must >> be added ifin case the DPDK will be built as shared library. >> >> Signed-off-by: Michal Krawczyk >> --- >> drivers/net/ena/Makefile | 1 + >> mk/rte.app.mk| 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile >> index 43339f3b9..ff9ce315b 100644 >> --- a/drivers/net/ena/Makefile >> +++ b/drivers/net/ena/Makefile >> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES) >> LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring >> LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs >> LDLIBS += -lrte_bus_pci >> +LDLIBS += -lrte_timer >> >> include $(RTE_SDK)/mk/rte.lib.mk >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk >> index 1e32c83e7..c70bc254e 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -60,6 +60,7 @@ endif >> >> _LDLIBS-y += --whole-archive >> >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer > > Why is it added in rte.app.mk? It is already there, few lines below. I think that's because it wasn't present on the version I was preparing the patch (18.02) and I didn't notice that it was added meantime when I was rebasing this patch. This patch is already merged to dpdk-next-net. Should I add a patch that is reverting this change there?
Re: [dpdk-dev] [PATCH 6/6] cryptodev: replace mbuf scatter gather flag
Hi Pablo, On 6/9/2018 3:32 AM, Pablo de Lara wrote: The current mbuf scatter gatter feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not. Therefore, two new flags will replace this flag: RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER_IN and RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER_OUT. There may be a case, SG supported in input buffer and we use in-place processing and driver may support that but may not support SG for out buffers in case of OOP. How can we handle this type of case? Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst| 2 - doc/guides/rel_notes/release_18_08.rst | 4 ++ drivers/crypto/aesni_gcm/aesni_gcm_pmd.c| 2 +- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- drivers/crypto/dpaa_sec/dpaa_sec.c | 3 +- drivers/crypto/null/null_crypto_pmd.c | 3 +- drivers/crypto/openssl/rte_openssl_pmd.c| 2 +- drivers/crypto/qat/rte_qat_cryptodev.c | 3 +- lib/librte_cryptodev/rte_cryptodev.c| 6 ++- lib/librte_cryptodev/rte_cryptodev.h| 12 +++--- test/test/test_cryptodev.c | 41 ++--- test/test/test_cryptodev_blockcipher.c | 11 -- 12 files changed, 59 insertions(+), 32 deletions(-)
Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
Hi Shally,
On 6/18/2018 11:10 AM, Verma, Shally wrote:
Hi Pablo
-Original Message-
From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
Sent: 18 June 2018 01:01
To: Verma, Shally
Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
Athreya, Narayana Prasad
; Sahu, Sunila ; Gupta,
Ashish
Subject: RE: [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
External Email
//snip
ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
ifeq ($(CONFIG_RTE_LIBRTE_COMPRESSDEV),y)
LDLIBS += -lz
[Shally] You mean add another config option for Asymmetric test?
At least check for CRYPTODEV, but since this is enabled by default,
I think we need an RTE_CRYPTODEV_ASYM_TEST flag.
[Shally] OK. Will look into this.
..
//snip
+#pragma GCC diagnostic pop
+
+static int
+test_rsa(struct rsa_test_data *t)
...
+ rsa->n =
+ BN_bin2bn(
+ (const unsigned char *)rsa_xform.rsa.n.data,
+ rsa_xform.rsa.n.length,
+ rsa->n);
I am getting a compilation error:
/test/test/test_cryptodev_asym.c:322:5: error:
dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
rsa->n =
^~
My OpenSSL version is 1.1.0h.
[Shally] This library is tested with version 1.0.2m (mentioned above) and also
one supported by openssl PMD . So, you need to take similar version.
I'd say we should support the latest stable version of OpenSSL.
Could you get the latest 1.1.0?
[Shally] Openssl PMD uses 1.0.2h. If we move test to 1.1.0 then dpdk would need
to be set
to link to two different version of libcrypto whenever openssl PMD is enabled
which seems like a cumbersome process for users.
So I recommend for now to stick to one version.
OpenSSL PMD can get compiled/linked with any of the versions 1.0.2 or
1.1. We cannot control the above applications which version it is using.
So we should not add limitation for openssl version. Please check below
snippet in the PMD if this is suitable in your case.
+#if (OPENSSL_VERSION_NUMBER < 0x1010L)
+static HMAC_CTX *HMAC_CTX_new(void)
+{
+ HMAC_CTX *ctx = OPENSSL_malloc(sizeof(*ctx));
+
+ if (ctx != NULL)
+ HMAC_CTX_init(ctx);
+ return ctx;
+}
+
+static void HMAC_CTX_free(HMAC_CTX *ctx)
+{
+ if (ctx != NULL) {
+ HMAC_CTX_cleanup(ctx);
+ OPENSSL_free(ctx);
+ }
+}
+#endif
Thanks
Shally
Thanks,
Pablo
Re: [dpdk-dev] [PATCH V3] net/thunderx: add support for hardware first skip feature
-Original Message- > Date: Mon, 18 Jun 2018 11:06:24 +0530 > From: Rakesh Kudurumalla > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com, jerin.ja...@caviumnetworks.com, rkudurumalla > > Subject: [PATCH V3] net/thunderx: add support for hardware first skip > feature > X-Mailer: git-send-email 2.7.4 > > From: rkudurumalla > > This feature is used to create a hole between HEADROOM > and actual data.Size of hole is specified in bytes as > module param to pmd > > Signed-off-by: Rakesh Kudurumalla Acked-by: Jerin Jacob
Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto
Hi
>-Original Message-
>From: Akhil Goyal [mailto:akhil.go...@nxp.com]
>Sent: 18 June 2018 12:10
>To: Verma, Shally ; De Lara Guarch, Pablo
>
>Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org;
>Athreya, Narayana Prasad
>; Sahu, Sunila ;
>Gupta, Ashish
>Subject: Re: [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym
>crypto
>
//snip
>> +static int
>> +test_rsa(struct rsa_test_data *t)
>
> ...
>
>> + rsa->n =
>> + BN_bin2bn(
>> + (const unsigned char *)rsa_xform.rsa.n.data,
>> + rsa_xform.rsa.n.length,
>> + rsa->n);
>
> I am getting a compilation error:
>
> /test/test/test_cryptodev_asym.c:322:5: error:
> dereferencing pointer to incomplete type 'RSA {aka struct rsa_st}'
> rsa->n =
> ^~
>
> My OpenSSL version is 1.1.0h.
>
[Shally] This library is tested with version 1.0.2m (mentioned above) and
also
one supported by openssl PMD . So, you need to take similar version.
>>>
>>> I'd say we should support the latest stable version of OpenSSL.
>>> Could you get the latest 1.1.0?
>> [Shally] Openssl PMD uses 1.0.2h. If we move test to 1.1.0 then dpdk would
>> need to be set
>> to link to two different version of libcrypto whenever openssl PMD is
>> enabled which seems like a cumbersome process for users.
>> So I recommend for now to stick to one version.
>>
>
>OpenSSL PMD can get compiled/linked with any of the versions 1.0.2 or
>1.1. We cannot control the above applications which version it is using.
>So we should not add limitation for openssl version. Please check below
>snippet in the PMD if this is suitable in your case.
>
>+#if (OPENSSL_VERSION_NUMBER < 0x1010L)
>+static HMAC_CTX *HMAC_CTX_new(void)
>+{
>+ HMAC_CTX *ctx = OPENSSL_malloc(sizeof(*ctx));
>+
>+ if (ctx != NULL)
>+ HMAC_CTX_init(ctx);
>+ return ctx;
>+}
>+
>+static void HMAC_CTX_free(HMAC_CTX *ctx)
>+{
>+ if (ctx != NULL) {
>+ HMAC_CTX_cleanup(ctx);
>+ OPENSSL_free(ctx);
>+ }
>+}
>+#endif
>
[Shally] Are we just planning to make PMD/test compatible for all lib versions?
Won't it then be too many version compatibility checks in PMD/test and a
maintainability issue than having implementation mentioned to be compatible
with specific version?
>
>> Thanks
>> Shally
>>
>>>
>>> Thanks,
>>> Pablo
