Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds
25/05/2018 17:18, Bruce Richardson:
> On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote:
> > +default_path=$PATH
> > +
> > +# Load config options
> > +. $(dirname $(readlink -e $0))/load-devel-config
> > +
>
> Why is this needed here, it seems to be called before each individual
> config anyway.
Right, it can be removed from here.
> > +reset_env ()
> > +{
> > + export PATH=$default_path
> > + unset CROSS
> > + unset ARMV8_CRYPTO_LIB_PATH
> > + unset FLEXRAN_SDK
> > + unset LIBMUSDK_PATH
> > + unset LIBSSO_SNOW3G_PATH
> > + unset LIBSSO_KASUMI_PATH
> > + unset LIBSSO_ZUC_PATH
> > + unset PQOS_INSTALL_PATH
>
> These variables bar PATH are unused by meson build, so should be removed
> here to avoid giving the impression they are use.
Actually they should be used when compiling.
PATH can be used to allow a toolchain which is not in the standard path.
And dependencies _PATH variables can be specified only for some builds.
Example: I have libsso only for x86 64-bit, so I do not set it
for 32-bit or ARM builds. The config file reads DPDK_TARGET to know.
Note: DPDK_TARGET is not yet set correctly for every builds in this version.
> $CROSS is used by the
> script so perhaps it can be kept. However, the whole point of the
> cross-files is that you include all the needed details of your compiler
> there. I think we should move away from using the CROSS value completely,
> and use the cross-files properly.
Yes we can remove CROSS if it is redundant with config files in config/arm/.
But I do not understand why these files cannot be agnostic regarding the
name (CROSS) of the toolchain.
To me it is very strange to have the binary names hard-linked in the configs.
Anyway, this discussion is out of the scope of this script.
So I am for removing the CROSS variable and use aarch64-linux-gnu-gcc
as it is hard written in every ARM configs for now.
> > +cd $(dirname $(readlink -m $0))/..
> > +
> I don't think we should force the builds to be always put into the base
> directory. Instead of using cd, I think we should instead capture the base
> directory path and pass that to meson.
OK to not force the directory.
You want to build in the current directory?
If yes, we can just remove this "cd" and no need to pass a base directory
to meson.
> > +load_config ()
> > +{
> > + reset_env
> > + . $(dirname $(readlink -e $0))/load-devel-config
> > + MESON=${MESON:-meson}
> > +}
> Why does this need to be done each time?
Because the config could be different for each build (see above).
[dpdk-dev] [PATCH v3] devtools: add test script for meson builds
From: Bruce Richardson
To simplify testing with the meson and ninja builds, we can add a script
to set up and do multiple builds. Currently this script sets up:
* clang and gcc builds
* builds using static and shared linkage for binaries (libs are always
built as both)
* a build using the lowest instruction-set level for x86 (-march=nehalem)
* cross-builds for each cross-file listed in config/arm
Each build is configured in a directory ending in *-build, and then for
the build stage, we just call ninja in each directory in turn. [i.e. we
assume every directory starting with "build-" is a meson build, which is
probably an ok assumption].
It can use the same configuration file as for the legacy test-build.sh.
Signed-off-by: Bruce Richardson
Signed-off-by: Thomas Monjalon
---
v2: it is a rework with 3 major changes
- automatically stop on error thanks to -e
- directory name starts with "build-"
- optionally load a config file to get some environment variables
v3:
- remove forcing "cd": use current directory
- remove CROSS: use hard-written aarch64-linux-gnu-gcc
- remove config load in script start
---
MAINTAINERS | 1 +
devtools/test-meson-builds.sh | 68 +++
2 files changed, 69 insertions(+)
create mode 100755 devtools/test-meson-builds.sh
diff --git a/MAINTAINERS b/MAINTAINERS
index e56c72687..4d015fe53 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -86,6 +86,7 @@ F: devtools/get-maintainer.sh
F: devtools/git-log-fixes.sh
F: devtools/load-devel-config
F: devtools/test-build.sh
+F: devtools/test-meson-builds.sh
F: license/
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
new file mode 100755
index 0..3283dbb7f
--- /dev/null
+++ b/devtools/test-meson-builds.sh
@@ -0,0 +1,68 @@
+#! /bin/sh -e
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+# Run meson to auto-configure the various builds.
+# * all builds get put in a directory whose name starts with "build-"
+# * if a build-directory already exists we assume it was properly configured
+# Run ninja after configuration is done.
+
+default_path=$PATH
+
+reset_env ()
+{
+ export PATH=$default_path
+ unset ARMV8_CRYPTO_LIB_PATH
+ unset FLEXRAN_SDK
+ unset LIBMUSDK_PATH
+ unset LIBSSO_SNOW3G_PATH
+ unset LIBSSO_KASUMI_PATH
+ unset LIBSSO_ZUC_PATH
+ unset PQOS_INSTALL_PATH
+}
+
+load_config ()
+{
+ reset_env
+ . $(dirname $(readlink -e $0))/load-devel-config
+ MESON=${MESON:-meson}
+}
+
+build () #
+{
+ dir=$1
+ shift
+ if [ ! -d "$dir" ] ; then
+ options="--werror -Dexamples=all $*"
+ # TODO: the configuration variables $DPDK_DEP_CFLAGS
+ # and $DPDK_DEP_LDFLAGS are not handled in this script
+ echo "$MESON $options $dir"
+ $MESON $options $dir
+ unset CC
+ fi
+ echo "ninja -C $dir"
+ ninja -C $dir
+}
+
+# shared and static linked builds with gcc and clang
+for c in gcc clang ; do
+ for s in static shared ; do
+ load_config
+ export CC="ccache $c"
+ build build-$c-$s --default-library=$s
+ done
+done
+
+# test compilation with minimal x86 instruction set
+load_config
+build build-x86-default -Dmachine=nehalem
+
+# enable cross compilation if gcc cross-compiler is found
+for f in config/arm/arm*gcc ; do
+ DPDK_TARGET=$(basename $f | tr '_' '-')
+ load_config
+ if ! command -v aarch64-linux-gnu-gcc >/dev/null 2>&1 ; then
+ continue
+ fi
+ build build-$(echo $DPDK_TARGET | cut -d'-' -f-2) --cross-file $f
+done
--
2.16.2
[dpdk-dev] [PATCH v4] devtools: add test script for meson builds
From: Bruce Richardson
To simplify testing with the meson and ninja builds, we can add a script
to set up and do multiple builds. Currently this script sets up:
* clang and gcc builds
* builds using static and shared linkage for binaries (libs are always
built as both)
* a build using the lowest instruction-set level for x86 (-march=nehalem)
* cross-builds for each cross-file listed in config/arm
Each build is configured in a directory ending in *-build, and then for
the build stage, we just call ninja in each directory in turn. [i.e. we
assume every directory starting with "build-" is a meson build, which is
probably an ok assumption].
Signed-off-by: Bruce Richardson
Signed-off-by: Thomas Monjalon
---
v2: it is a rework with 3 major changes
- automatically stop on error thanks to -e
- directory name starts with "build-"
- optionally load a config file to get some environment variables
v3:
- remove forcing "cd": use current directory
- remove CROSS: use hard-written aarch64-linux-gnu-gcc
- remove config load in script start
v4:
- remove config file loading (will be improved and sent later)
- the v4 is closer to what Bruce sent as v1
---
MAINTAINERS | 1 +
devtools/test-meson-builds.sh | 43 +++
2 files changed, 44 insertions(+)
create mode 100755 devtools/test-meson-builds.sh
diff --git a/MAINTAINERS b/MAINTAINERS
index e56c72687..4d015fe53 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -86,6 +86,7 @@ F: devtools/get-maintainer.sh
F: devtools/git-log-fixes.sh
F: devtools/load-devel-config
F: devtools/test-build.sh
+F: devtools/test-meson-builds.sh
F: license/
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
new file mode 100755
index 0..78d712aea
--- /dev/null
+++ b/devtools/test-meson-builds.sh
@@ -0,0 +1,43 @@
+#! /bin/sh -e
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+# Run meson to auto-configure the various builds.
+# * all builds get put in a directory whose name starts with "build-"
+# * if a build-directory already exists we assume it was properly configured
+# Run ninja after configuration is done.
+
+MESON=${MESON:-meson}
+
+build () #
+{
+ dir=$1
+ shift
+ if [ ! -d "$dir" ] ; then
+ options="--werror -Dexamples=all $*"
+ echo "$MESON $options $dir"
+ $MESON $options $dir
+ unset CC
+ fi
+ echo "ninja -C $dir"
+ ninja -C $dir
+}
+
+# shared and static linked builds with gcc and clang
+for c in gcc clang ; do
+ for s in static shared ; do
+ export CC="ccache $c"
+ build build-$c-$s --default-library=$s
+ done
+done
+
+# test compilation with minimal x86 instruction set
+build build-x86-default -Dmachine=nehalem
+
+# enable cross compilation if gcc cross-compiler is found
+for f in config/arm/arm*gcc ; do
+ if ! command -v aarch64-linux-gnu-gcc >/dev/null 2>&1 ; then
+ continue
+ fi
+ build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f
+done
--
2.16.2
Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files
-Original Message- From: Kovacevic, Marko [mailto:marko.kovace...@intel.com] Sent: Friday, May 25, 2018 9:00 PM To: Thomas Monjalon ; Hemant Agrawal ; Yigit, Ferruh Cc: dev@dpdk.org; Mcnamara, John Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files > > > It has been recommended to add SPDX tags to release notes, with a > global copyright on behalf of all contributors, or community. > > We need a v2 of this patch, thanks. > > Hi Thomas, What exactly is the global copyright ? [Hemant] We discussed with LF foundation lawyers. It was suggested to use "Copyright 2018 The DPDK Community" Regards, Hemant
[dpdk-dev] [PATCH v2] net/mlx5: fix memory region cache init
This patch moved MR cache init from device configuration function to
probe function to make sure init only once.
Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
Cc: ys...@mellanox.com
Signed-off-by: Xueming Li
---
drivers/net/mlx5/mlx5.c| 13 +
drivers/net/mlx5/mlx5_ethdev.c | 11 ---
drivers/net/mlx5/mlx5_mr.c | 1 +
3 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index dae847493..3ef02e2d2 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1193,6 +1193,19 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
__rte_unused,
goto port_error;
}
priv->config.max_verbs_prio = verb_priorities;
+ /*
+* Once the device is added to the list of memory event
+* callback, its global MR cache table cannot be expanded
+* on the fly because of deadlock. If it overflows, lookup
+* should be done by searching MR list linearly, which is slow.
+*/
+ err = mlx5_mr_btree_init(&priv->mr.cache,
+MLX5_MR_BTREE_CACHE_N * 2,
+eth_dev->device->numa_node);
+ if (err) {
+ err = rte_errno;
+ goto port_error;
+ }
/* Add device to memory callback list. */
rte_rwlock_write_lock(&mlx5_shared_data->mem_event_rwlock);
LIST_INSERT_HEAD(&mlx5_shared_data->mem_event_cb_list,
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index f6cebae41..90488af33 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -392,17 +392,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
if (++j == rxqs_n)
j = 0;
}
- /*
-* Once the device is added to the list of memory event callback, its
-* global MR cache table cannot be expanded on the fly because of
-* deadlock. If it overflows, lookup should be done by searching MR list
-* linearly, which is slow.
-*/
- if (mlx5_mr_btree_init(&priv->mr.cache, MLX5_MR_BTREE_CACHE_N * 2,
- dev->device->numa_node)) {
- /* rte_errno is already set. */
- return -rte_errno;
- }
return 0;
}
diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c
index abb1f5179..08105a443 100644
--- a/drivers/net/mlx5/mlx5_mr.c
+++ b/drivers/net/mlx5/mlx5_mr.c
@@ -191,6 +191,7 @@ mlx5_mr_btree_init(struct mlx5_mr_btree *bt, int n, int
socket)
rte_errno = EINVAL;
return -rte_errno;
}
+ assert(!bt->table && !bt->size);
memset(bt, 0, sizeof(*bt));
bt->table = rte_calloc_socket("B-tree table",
n, sizeof(struct mlx5_mr_cache),
--
2.13.3
[dpdk-dev] [PATCH] app/testpmd: distribute queues to cores
Current topology distribute forwarding streams to lcores by port, this make unbalanced loading when port number larger than 2: lcore 0: P0Q0->P1Q0, P0Q1->P1Q1 locre 1: P1Q0->P0Q0, P1Q1->P0Q1 If only one port has traffic, only one locre get fully loaded and the other one get no forwarding. Performance is bad as only one core doing forwarding in such case. This patch distributes forwarding streams by queue, try to get streams of each port handled by different lcore: lcore 0: P0Q0->P1Q0, P1Q0->P1Q0 locre 1: P0Q1->P0Q1, P1Q1->P0Q1 Signed-off-by: Xueming Li --- app/test-pmd/config.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 97020fb3d..45b4d4f45 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2177,15 +2177,11 @@ rss_fwd_config_setup(void) fs->tx_queue = rxq; fs->peer_addr = fs->tx_port; fs->retry_enabled = retry_enabled; - rxq = (queueid_t) (rxq + 1); - if (rxq < nb_q) - continue; - /* -* rxq == nb_q -* Restart from RX queue 0 on next RX port -*/ - rxq = 0; rxp++; + if (rxp < nb_fwd_ports) + continue; + rxp = 0; + rxq++; } } -- 2.13.3
Re: [dpdk-dev] [PATCH v2] net/mlx5: fix memory region cache init
> On May 26, 2018, at 6:28 AM, Xueming Li wrote:
>
> This patch moved MR cache init from device configuration function to
> probe function to make sure init only once.
>
> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
> Cc: ys...@mellanox.com
>
> Signed-off-by: Xueming Li
> ---
Acked-by: Yongseok Koh
Thanks
Re: [dpdk-dev] [PATCH] ethdev: Add rte_tm_get_number_of_leaf_nodes to .map file
On 5/25/2018 8:59 PM, Ben Shelton wrote:
> The rte_tm_get_number_of_leaf_nodes() API function was added in DPDK
> 17.08. However, it was added to the .map file with the wrong function
> name (rte_tm_get_leaf_nodes), which was subsequently removed in commit
> 3e8ea3d ('lib: remove unused map symbols').
>
> Add it back under the 17.08 release with the correct function name.
Fixes: 5d109deffa87 ("ethdev: add traffic management API")
>
> v2: Remove Gerrit Change-Id.
>
> Signed-off-by: Ben Shelton
Reviewed-by: Ferruh Yigit
Re: [dpdk-dev] [PATCH] ethdev: Add rte_tm_get_number_of_leaf_nodes to .map file
On 5/26/2018 11:21 PM, Ferruh Yigit wrote:
> On 5/25/2018 8:59 PM, Ben Shelton wrote:
>> The rte_tm_get_number_of_leaf_nodes() API function was added in DPDK
>> 17.08. However, it was added to the .map file with the wrong function
>> name (rte_tm_get_leaf_nodes), which was subsequently removed in commit
>> 3e8ea3d ('lib: remove unused map symbols').
>>
>> Add it back under the 17.08 release with the correct function name.
>
> Fixes: 5d109deffa87 ("ethdev: add traffic management API")
>
>>
>> v2: Remove Gerrit Change-Id.
>>
>> Signed-off-by: Ben Shelton
>
> Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/master, thanks.
Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit
On Tue, May 22, 2018 at 07:35:08PM +0100, Ferruh Yigit wrote:
> vdevs detach on testpmd exit implemented as workaround to fix
> a virtio-user issue. The issue was virtio-user cleanup is not
> called and existing socket file not cleaned up which will fail
> next run.
>
> The vdev cleanup causing problems in failsafe PMD.
>
> Reduce the cleanup to only virtio-user and add a comment that this
> workaround should be converted to a proper cleanup, not something
> specific to virtio-user, and not something specific to vdev and
> testpmd.
>
> Fixes: fe890955114d ("app/testpmd: fix exit for vdevs")
>
...
> pmd_test_exit(void)
> {
> - const struct rte_bus *bus;
> struct rte_device *device;
> portid_t pt_id;
> int ret;
> @@ -2025,13 +2024,21 @@ pmd_test_exit(void)
> if (ports != NULL) {
> no_link_check = 1;
> RTE_ETH_FOREACH_DEV(pt_id) {
> - device = rte_eth_devices[pt_id].device;
> - bus = rte_bus_find_by_device(device);
> printf("\nShutting down port %d...\n", pt_id);
> fflush(stdout);
> stop_port(pt_id);
> close_port(pt_id);
> - if (bus && !strcmp(bus->name, "vdev"))
> +
> + /*
> + * This is a workaround to fix a virtio-user issue that
> + * requires to call clean-up routine to remove existing
> + * socket.
I came across this patch while I was cherry-picking patches to 17.11.4
release. And this patch seems wrong to me.
Any particular reason why the socket removal can not be done in virtio-user
pmd, say at its close method?
--yliu
> + * This workaround valid only for testpmd, needs a fix
> + * valid for all applications.
> + * TODO: Implement proper resource cleanup
> + */
> + device = rte_eth_devices[pt_id].device;
> + if (device && !strcmp(device->driver->name,
> "net_virtio_user"))
> detach_port(pt_id);
> }
> }
> --
> 2.14.3
Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro
Friday, May 25, 2018 4:20 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf > check macro > > Link: > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd > k.org%2Fml%2Farchives%2Fdev%2F2018- > April%2F099476.html&data=02%7C01%7Cshahafs%40mellanox.com%7Ccaccc > ead653640735e3308d5c1ddb6b0%7Ca652971c7d2e4d9ba6a4d149256f461b%7 > C0%7C0%7C636628080378790994&sdata=7JOFTPtuU4OYWowtwEKp3BaK5aS > 8idulFiGhLEHRIkU%3D&reserved=0 > > Signed-off-by: Yongseok Koh > --- > > v2: > * modify removal deadline and add more comments in the deprecation note > * mark deprecation on the comment of the macro in rte_mbuf.h > > doc/guides/rel_notes/deprecation.rst | 7 +++ > lib/librte_mbuf/rte_mbuf.h | 3 ++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 1e2443c76..e1630c2cf 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -42,6 +42,13 @@ Deprecation Notices >is defined in librte_sched in a non-generic way. The new generic format >will contain: queue ID, traffic class, color. Field size will not change. > > +* mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 or > +later and > + replaced with ``RTE_MBUF_CLONED()`` which is already added in v18.05. > +As > + ``EXT_ATTACHED_MBUF`` is newly introduced in v18.05, > +``RTE_MBUF_INDIRECT()`` > + can no longer be mutually exclusive with ``RTE_MBUF_DIRECT()`` if the > +new > + experimental API ``rte_pktmbuf_attach_extbuf()`` is used. Removal of > +the macro > + is to fix this semantic inconsistency. > + > * ethdev: a new Tx and Rx offload API was introduced on 17.11. >In the new API, offloads are divided into per-port and per-queue offloads. >Offloads are disabled by default and enabled per application request. > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index > e136d12b7..8e6b4d292 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -738,7 +738,8 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > #define RTE_MBUF_CLONED(mb) ((mb)->ol_flags & > IND_ATTACHED_MBUF) > > /** > - * Returns TRUE if given mbuf is indirect, or FALSE otherwise. > + * Deprecated. > + * Use RTE_MBUF_CLONED(). > */ > #define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) Acked-by: Shahaf Shuler > > -- > 2.11.0
Re: [dpdk-dev] [PATCH] net/mlx5: fix crash when configure is not called
Thursday, May 24, 2018 9:22 PM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix crash when configure is not called
>
>
> > On May 24, 2018, at 7:36 AM, Adrien Mazarguil
> wrote:
> >
> > Although uncommon, applications may destroy a device immediately after
> > probing it without going through dev_configure() first.
> >
> > This patch addresses a crash which occurs when mlx5_dev_close() calls
> > mlx5_mr_release() due to an uninitialized entry in the private structure.
> >
> > Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
> > Cc: Yongseok Koh
> >
> > Signed-off-by: Adrien Mazarguil
> > ---
> Acked-by: Yongseok Koh
Applied to next-net-mlx, thanks.
>
> Thanks
Re: [dpdk-dev] [PATCH v2] net/mlx5: fix memory region cache init
Saturday, May 26, 2018 8:08 PM, Yongseok Koh:
> Subject: Re: [PATCH v2] net/mlx5: fix memory region cache init
>
>
> > On May 26, 2018, at 6:28 AM, Xueming Li
> wrote:
> >
> > This patch moved MR cache init from device configuration function to
> > probe function to make sure init only once.
> >
> > Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
> > Cc: ys...@mellanox.com
> >
> > Signed-off-by: Xueming Li
> > ---
> Acked-by: Yongseok Koh
Applied to next-net-mlx, thanks.
>
> Thanks
Re: [dpdk-dev] [PATCH v2] net/mlx5: fix memory region cache init
Ferruh,
Sunday, May 27, 2018 8:05 AM, Shahaf Shuler:
> Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix memory region cache init
>
> Saturday, May 26, 2018 8:08 PM, Yongseok Koh:
> > Subject: Re: [PATCH v2] net/mlx5: fix memory region cache init
> >
> >
> > > On May 26, 2018, at 6:28 AM, Xueming Li
> > wrote:
> > >
> > > This patch moved MR cache init from device configuration function to
> > > probe function to make sure init only once.
> > >
> > > Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
> > > Cc: ys...@mellanox.com
> > >
> > > Signed-off-by: Xueming Li
> > > ---
> > Acked-by: Yongseok Koh
>
> Applied to next-net-mlx, thanks.
This is yet another critical fix for a bug caught recently.
This patch is to prevent deadlock when restarting the port.
Hope you will be able to pull this one in.
>
> >
> > Thanks
[dpdk-dev] 17.11.3 (LTS) patches review and test
Hi all, Here is a list of patches targeted for LTS release 17.11.3. Please help review and test. The planned date for the final release is 8th, Jun. Before that, please let me know if anyone has objections with these patches being applied. These patches are located at branch 17.11 of dpdk-stable repo: http://dpdk.org/browse/dpdk-stable/ Thanks. --yliu --- Aaron Conole (2): nfp: unlink the appropriate lock file nfp: allow for non-root user Adrien Mazarguil (1): app/testpmd: fix empty list of RSS queues for flow Ajit Khaparde (9): net/bnxt: fix LRO disable net/bnxt: fix Rx drop setting net/bnxt: set padding flags in Rx descriptor net/bnxt: fix endianness of flag net/bnxt: fix Rx checksum flags for tunnel frames net/bnxt: free memory allocated for VF filters net/bnxt: avoid invalid vnic id in set L2 Rx mask net/bnxt: fix usage of vnic id net/bnxt: fix Rx checksum flags Alejandro Lucero (5): net/nfp: fix assigning port id in mbuf net/nfp: fix barrier location net/nfp: fix link speed capabilities doc: fix NFP NIC guide grammar net/nfp: fix mbufs releasing when stop or close Allain Legacy (1): ip_frag: fix double free of chained mbufs Anatoly Burakov (4): app/crypto-perf: fix IOVA translation mem: do not use physical addresses in IOVA as VA mode vfio: do not needlessly check for IOVA mode mempool: fix virtual address population Andrew Rybchenko (6): net/sfc: add missing defines for SAL annotation net/sfc: fix mbuf data alignment calculation net/sfc/base: fix comparison always true warning mempool: fix leak when no objects are populated test/mempool: fix autotest retry net/sfc: ignore spec bits not covered by mask Andy Green (3): net/bnx2x: do not cast function pointers as a policy net/bnx2x: fix KR2 device check net/bnx2x: fix memzone name overrun Ashish Jain (1): event/dpaa2: remove link from info structure Beilei Xing (3): net/i40e: fix DDP profile DEL operation net/i40e: fix link status update net/i40e: fix failing to disable FDIR Tx queue Bin Huang (1): net/mlx5: add packet type index for TCP ack Chas Williams (5): net/vmxnet3: set the queue shared buffer at start net/bonding: fix setting VLAN ID on slave ports net/bonding: clear started state if start fails net/ixgbe: fix busy wait during checking link status net/bonding: export mode 4 slave info routine Chuhong Yao (1): net/liquidio: fix link state fetching during start Ciara Loftus (1): net/vhost: initialise device as inactive Dan Gora (1): kni: fix build on CentOS 7.4 Daniel Shelepov (1): app/testpmd: fix burst stats reporting David Hunt (4): mk: fix make defconfig on FreeBSD test/distributor: fix return type of thread function test/pipeline: fix return type of stub miss examples/performance-thread: fix return type of threads Fan Zhang (2): net/i40e: fix link update no wait crypto/scheduler: fix possible duplicated ring names Ferruh Yigit (4): pci: remove duplicated symbol from map file net/tap: fix icc build drivers/net: fix link autoneg value for virtual PMDs net/i40e: fix shifts of signed values Gaetan Rivet (2): bus/fslmc: fix find device start condition bus/pci: fix find device implementation Gowrishankar Muthukrishnan (2): eal/ppc: remove braces in SMP memory barrier macro net/bonding: fix primary slave port id storage type Harish Patil (1): net/qede: fix multicast filtering Hemant Agrawal (6): net/dpaa: fix oob access bus/dpaa: fix resource leak net/dpaa2: fix xstats app/crypto-perf: fix excess crypto device error examples/l2fwd-crypto: fix the default aead assignments crypto/dpaa2_sec: fix HMAC supported digest sizes Hyong Youb Kim (1): net/enic: allocate stats DMA buffer upfront during probe Ivan Malov (2): net/sfc: add missing Rx fini on RSS setup fail path net/sfc: process RSS settings on Rx configure step Jasvinder Singh (1): test/pipeline: fix type of table entry parameter Jerin Jacob (2): app/crypto-perf: use strcpy for allocated string app/crypto-perf: fix parameters copy John Daley (1): net/enic: fix crash on MTU update with non-setup queues Junjie Chen (2): net/vhost: fix crash when creating vdev dynamically net/vhost: fix invalid state Kirill Rybalchenko (2): crypto/scheduler: fix multicore rings re-use crypto/scheduler: fix 64-bit mask of workers cores Lee Roberts (1): kni: fix build on RHEL 7.5 Matan Azrad (10): ethdev: fix port accessing after release app/testpmd: fix slave port detection app/testpmd: fix valid ports prints app/testpmd: fix forward ports update app/testpmd: fix forward ports Rx flu
