[dpdk-dev] [PATCH] net/mlx5: add supported hash function check
Add supported RSS hash function check in device configuration to
have better error verbosity for application developers.
Signed-off-by: Xueming Li
---
drivers/net/mlx5/mlx5_ethdev.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index b73cb53..175a1ff 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -346,6 +346,14 @@ struct ethtool_link_settings {
rx_offloads, supp_rx_offloads);
return ENOTSUP;
}
+ if (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf &
+ MLX5_RSS_HF_MASK) {
+ ERROR("Some RSS hash function not supported "
+ "requested 0x%" PRIx64 " supported 0x%" PRIx64,
+ dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf,
+ (uint64_t)(~MLX5_RSS_HF_MASK));
+ return ENOTSUP;
+ }
if (use_app_rss_key &&
(dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len !=
rss_hash_default_key_len)) {
--
1.8.3.1
Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Saturday, March 17, 2018 2:48 AM
> To: Zhang, Qi Z ; tho...@monjalon.net
> Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing
> ; Lu, Wenzhuo
> Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue
> setup
>
>
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Friday, March 16, 2018 2:15 PM
> > To: Ananyev, Konstantin ;
> > tho...@monjalon.net
> > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing
> > ; Lu, Wenzhuo
> > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue
> > setup
> >
> >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > > -Original Message-
> > > > > > > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of
> > > > > > > > > > > Qi Zhang
> > > > > > > > > > > Sent: Friday, March 2, 2018 4:13 AM
> > > > > > > > > > > To: tho...@monjalon.net
> > > > > > > > > > > Cc: dev@dpdk.org; Xing, Beilei
> > > > > > > > > > > ; Wu, Jingjing
> > > > > > > > > > > ; Lu, Wenzhuo
> > > > > > > > > > > ; Zhang,
> > > > > > > > > > Qi
> > > > > > > > > > > Z
> > > > > > > > > > > Subject: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable
> > > > > > > > > > > deferred queue setup
> > > > > > > > > > >
> > > > > > > > > > > Expose the deferred queue configuration capability
> > > > > > > > > > > and enhance i40e_dev_[rx|tx]_queue_[setup|release]
> > > > > > > > > > > to handle the situation when device already started.
> > > > > > > > > > >
> > > > > > > > > > > Signed-off-by: Qi Zhang
> > > > > > > > > > > ---
> > > > > > > > > > > drivers/net/i40e/i40e_ethdev.c | 6
> > > > > > > > > > > drivers/net/i40e/i40e_rxtx.c | 62
> > > > > > > > > > --
> > > > > > > > > > > 2 files changed, 66 insertions(+), 2 deletions(-)
> > > > > > > > > > >
> > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.c index
> > > > > > > > > > > 06b0f03a1..843a0c42a
> > > > > > > > > > > 100644
> > > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > @@ -3195,6 +3195,12 @@ i40e_dev_info_get(struct
> > > > > > > > > > > rte_eth_dev
> > > > > > > > *dev,
> > > > > > > > > > struct rte_eth_dev_info *dev_info)
> > > > > > > > > > > DEV_TX_OFFLOAD_GRE_TNL_TSO |
> > > > > > > > > > > DEV_TX_OFFLOAD_IPIP_TNL_TSO |
> > > > > > > > > > > DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
> > > > > > > > > > > + dev_info->deferred_queue_config_capa =
> > > > > > > > > > > + DEV_DEFERRED_RX_QUEUE_SETUP |
> > > > > > > > > > > + DEV_DEFERRED_TX_QUEUE_SETUP |
> > > > > > > > > > > + DEV_DEFERRED_RX_QUEUE_RELEASE |
> > > > > > > > > > > + DEV_DEFERRED_TX_QUEUE_RELEASE;
> > > > > > > > > > > +
> > > > > > > > > > > dev_info->hash_key_size =
> > > > (I40E_PFQF_HKEY_MAX_INDEX +
> > > > > > 1) *
> > > > > > > > > > >
> > > > > > > > > > > sizeof(uint32_t);
> > > > > > > > > > > dev_info->reta_size = pf->hash_lut_size; diff
> > > > > > > > > > > --git a/drivers/net/i40e/i40e_rxtx.c
> > > > > > > > > > > b/drivers/net/i40e/i40e_rxtx.c index
> > > > > > > > > > > 1217e5a61..e5f532cf7 100644
> > > > > > > > > > > --- a/drivers/net/i40e/i40e_rxtx.c
> > > > > > > > > > > +++ b/drivers/net/i40e/i40e_rxtx.c
> > > > > > > > > > > @@ -1712,6 +1712,7 @@
> i40e_dev_rx_queue_setup(struct
> > > > > > > > rte_eth_dev
> > > > > > > > > > *dev,
> > > > > > > > > > > uint16_t len, i;
> > > > > > > > > > > uint16_t reg_idx, base, bsf, tc_mapping;
> > > > > > > > > > > int q_offset, use_def_burst_func = 1;
> > > > > > > > > > > + int ret = 0;
> > > > > > > > > > >
> > > > > > > > > > > if (hw->mac.type == I40E_MAC_VF || hw->mac.type
> ==
> > > > > > > > > > I40E_MAC_X722_VF) {
> > > > > > > > > > > vf =
> > > > > > I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
> > > > > > > > > > > @@ -1841,6 +1842,25 @@
> > > > > > > > > > > i40e_dev_rx_queue_setup(struct
> > > > > > > > rte_eth_dev
> > > > > > > > > > *dev,
> > > > > > > > > > > rxq->dcb_tc = i;
> > > > > > > > > > > }
> > > > > > > > > > >
> > > > > > > > > > > + if (dev->data->dev_started) {
> > > > > > > > > > > + ret = i40e_rx_queue_init(rxq);
> > > > > > > > > > > + if (ret != I40E_SUCCESS) {
> > > > > > > > > > > + PMD_DRV_LOG(ERR,
> > > > > > > > > > > + "Failed to do RX queue
> initialization");
> > > > > > > > > > > + return ret;
> > > > > > > > > > > + }
> > > > > > > > > > > + if (ad->rx_vec_allowed)
> > > > > > > > > >
> > > > > > > > > > Better to check what rx function is installed right now.
> > > > > > > > > Yes, it should be fixed, need to return fail if any
> > > > > > > > > conflict
> > > > > > > > > >
> > > > > > > > > > > + i40e_rxq_vec_setu
[dpdk-dev] [PATCH 3/4] app/eventdev: add options to configure event timer adapter
Add options to configure expiry timeout, max number of timers and number
of event timer adapters through command line paramters.
Signed-off-by: Pavan Nikhilesh
---
app/test-eventdev/evt_options.c | 65 +
app/test-eventdev/evt_options.h | 5
2 files changed, 70 insertions(+)
diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
index 05d6de88b..a04ffea8f 100644
--- a/app/test-eventdev/evt_options.c
+++ b/app/test-eventdev/evt_options.c
@@ -140,6 +140,56 @@ evt_parse_nb_pkts(struct evt_options *opt, const char *arg)
return ret;
}
+static int
+evt_parse_nb_timers(struct evt_options *opt, const char *arg)
+{
+ int ret;
+
+ ret = parser_read_uint64(&(opt->nb_timers), arg);
+
+ return ret;
+}
+
+static int
+evt_parse_bkt_tck_nsec(struct evt_options *opt, const char *arg)
+{
+ int ret;
+
+ ret = parser_read_uint64(&(opt->bkt_tck_nsec), arg);
+
+ return ret;
+}
+
+static int
+evt_parse_max_tmo_nsec(struct evt_options *opt, const char *arg)
+{
+ int ret;
+
+ ret = parser_read_uint64(&(opt->max_tmo_nsec), arg);
+
+ return ret;
+}
+
+static int
+evt_parse_nb_bkt_tcks(struct evt_options *opt, const char *arg)
+{
+ int ret;
+
+ ret = parser_read_uint64(&(opt->nb_bkt_tcks), arg);
+
+ return ret;
+}
+
+static int
+evt_parse_nb_timer_adptrs(struct evt_options *opt, const char *arg)
+{
+ int ret;
+
+ ret = parser_read_uint8(&(opt->nb_timer_adptrs), arg);
+
+ return ret;
+}
+
static int
evt_parse_pool_sz(struct evt_options *opt, const char *arg)
{
@@ -196,6 +246,11 @@ usage(char *program)
"\t in ns.\n"
"\t--prod_type_timerdev_burst : use timer device as producer\n"
"\t burst mode.\n"
+ "\t--nb_timers: number of timers to arm.\n"
+ "\t--nb_timer_adptrs : number of timer adapters to use.\n"
+ "\t--bkt_tck_nsec : timer bucket tick interval in ns.\n"
+ "\t--max_tmo_nsec : max timeout interval in ns.\n"
+ "\t--nb_bkt_tcks : number of bucket ticks for each timer\n"
);
printf("available tests:\n");
evt_test_dump_names();
@@ -259,6 +314,11 @@ static struct option lgopts[] = {
{ EVT_PROD_ETHDEV, 0, 0, 0 },
{ EVT_PROD_TIMERDEV, 0, 0, 0 },
{ EVT_PROD_TIMERDEV_BURST, 0, 0, 0 },
+ { EVT_NB_TIMERS, 1, 0, 0 },
+ { EVT_NB_TIMER_ADPTRS, 1, 0, 0 },
+ { EVT_BKT_TCK_NSEC,1, 0, 0 },
+ { EVT_MAX_TMO_NSEC,1, 0, 0 },
+ { EVT_NB_BKT_TCKS, 1, 0, 0 },
{ EVT_HELP,0, 0, 0 },
{ NULL,0, 0, 0 }
};
@@ -285,6 +345,11 @@ evt_opts_parse_long(int opt_idx, struct evt_options *opt)
{ EVT_PROD_ETHDEV, evt_parse_eth_prod_type},
{ EVT_PROD_TIMERDEV, evt_parse_timer_prod_type},
{ EVT_PROD_TIMERDEV_BURST, evt_parse_timer_prod_type_burst},
+ { EVT_NB_TIMERS, evt_parse_nb_timers},
+ { EVT_NB_TIMER_ADPTRS, evt_parse_nb_timer_adptrs},
+ { EVT_BKT_TCK_NSEC, evt_parse_bkt_tck_nsec},
+ { EVT_MAX_TMO_NSEC, evt_parse_max_tmo_nsec},
+ { EVT_NB_BKT_TCKS, evt_parse_nb_bkt_tcks},
};
for (i = 0; i < RTE_DIM(parsermap); i++) {
diff --git a/app/test-eventdev/evt_options.h b/app/test-eventdev/evt_options.h
index 03078b21b..80a9ebd8f 100644
--- a/app/test-eventdev/evt_options.h
+++ b/app/test-eventdev/evt_options.h
@@ -33,6 +33,11 @@
#define EVT_PROD_ETHDEV ("prod_type_ethdev")
#define EVT_PROD_TIMERDEV("prod_type_timerdev")
#define EVT_PROD_TIMERDEV_BURST ("prod_type_timerdev_burst")
+#define EVT_NB_TIMERS("nb_timers")
+#define EVT_NB_TIMER_ADPTRS ("nb_timer_adptrs")
+#define EVT_BKT_TCK_NSEC ("bkt_tck_nsec")
+#define EVT_MAX_TMO_NSEC ("max_tmo_nsec")
+#define EVT_NB_BKT_TCKS ("nb_bkt_tcks")
#define EVT_HELP ("help")
enum evt_prod_type {
--
2.16.2
[dpdk-dev] [PATCH 2/4] app/eventdev: add burst mode for event timer adapter
Add burst mode for event timer adapter that can be selected by passing
--prod_type_timerdev_burst.
Signed-off-by: Pavan Nikhilesh
---
app/test-eventdev/evt_options.c | 13
app/test-eventdev/evt_options.h | 2 ++
app/test-eventdev/test_perf_common.c | 61 +++-
3 files changed, 75 insertions(+), 1 deletion(-)
diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
index 49cd9c419..05d6de88b 100644
--- a/app/test-eventdev/evt_options.c
+++ b/app/test-eventdev/evt_options.c
@@ -98,6 +98,15 @@ evt_parse_timer_prod_type(struct evt_options *opt, const
char *arg __rte_unused)
return 0;
}
+static int
+evt_parse_timer_prod_type_burst(struct evt_options *opt,
+ const char *arg __rte_unused)
+{
+ opt->prod_type = EVT_PROD_TYPE_EVENT_TIMER_ADPTR;
+ opt->timdev_use_burst = 1;
+ return 0;
+}
+
static int
evt_parse_test_name(struct evt_options *opt, const char *arg)
{
@@ -185,6 +194,8 @@ usage(char *program)
"\t--prod_type_timerdev : use event timer device as producer.\n"
"\t x * bkt_tck_nsec would be the timeout\n"
"\t in ns.\n"
+ "\t--prod_type_timerdev_burst : use timer device as producer\n"
+ "\t burst mode.\n"
);
printf("available tests:\n");
evt_test_dump_names();
@@ -247,6 +258,7 @@ static struct option lgopts[] = {
{ EVT_QUEUE_PRIORITY, 0, 0, 0 },
{ EVT_PROD_ETHDEV, 0, 0, 0 },
{ EVT_PROD_TIMERDEV, 0, 0, 0 },
+ { EVT_PROD_TIMERDEV_BURST, 0, 0, 0 },
{ EVT_HELP,0, 0, 0 },
{ NULL,0, 0, 0 }
};
@@ -272,6 +284,7 @@ evt_opts_parse_long(int opt_idx, struct evt_options *opt)
{ EVT_QUEUE_PRIORITY, evt_parse_queue_priority},
{ EVT_PROD_ETHDEV, evt_parse_eth_prod_type},
{ EVT_PROD_TIMERDEV, evt_parse_timer_prod_type},
+ { EVT_PROD_TIMERDEV_BURST, evt_parse_timer_prod_type_burst},
};
for (i = 0; i < RTE_DIM(parsermap); i++) {
diff --git a/app/test-eventdev/evt_options.h b/app/test-eventdev/evt_options.h
index 37debae84..03078b21b 100644
--- a/app/test-eventdev/evt_options.h
+++ b/app/test-eventdev/evt_options.h
@@ -32,6 +32,7 @@
#define EVT_QUEUE_PRIORITY ("queue_priority")
#define EVT_PROD_ETHDEV ("prod_type_ethdev")
#define EVT_PROD_TIMERDEV("prod_type_timerdev")
+#define EVT_PROD_TIMERDEV_BURST ("prod_type_timerdev_burst")
#define EVT_HELP ("help")
enum evt_prod_type {
@@ -65,6 +66,7 @@ struct evt_options {
uint32_t fwd_latency:1;
uint32_t q_priority:1;
enum evt_prod_type prod_type;
+ uint8_t timdev_use_burst;
uint8_t timdev_cnt;
};
diff --git a/app/test-eventdev/test_perf_common.c
b/app/test-eventdev/test_perf_common.c
index 6ae146d91..072b5f8cf 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -128,6 +128,61 @@ perf_event_timer_producer(void *arg)
return 0;
}
+static inline int
+perf_event_timer_producer_burst(void *arg)
+{
+ int i;
+ struct prod_data *p = arg;
+ struct test_perf *t = p->t;
+ struct evt_options *opt = t->opt;
+ uint32_t flow_counter = 0;
+ uint64_t count = 0;
+ uint64_t arm_latency = 0;
+ const uint8_t nb_timer_adptrs = opt->nb_timer_adptrs;
+ const uint32_t nb_flows = t->nb_flows;
+ const uint64_t nb_timers = opt->nb_timers;
+ struct rte_mempool *pool = t->pool;
+ struct perf_elt *m[BURST_SIZE + 1] = {NULL};
+ struct rte_event_timer_adapter **adptr = t->timer_adptr;
+ const struct rte_event_timer tim = {
+ .ev.op = RTE_EVENT_OP_NEW,
+ .ev.queue_id = p->queue_id,
+ .ev.sched_type = t->opt->sched_type_list[0],
+ .ev.priority = RTE_EVENT_DEV_PRIORITY_NORMAL,
+ .ev.event_type = RTE_EVENT_TYPE_TIMER,
+ .timeout_ticks = (opt->nb_bkt_tcks * opt->bkt_tck_nsec) /
+ opt->optm_bkt_tck_nsec,
+ };
+
+ if (opt->verbose_level > 1)
+ printf("%s(): lcore %d\n", __func__, rte_lcore_id());
+
+ while (count < nb_timers && t->done == false) {
+ if (rte_mempool_get_bulk(pool, (void **)m, BURST_SIZE) < 0)
+ continue;
+ for (i = 0; i < BURST_SIZE; i++) {
+ rte_prefetch0(m[i + 1]);
+ m[i]->tim = tim;
+ m[i]->tim.ev.flow_id = flow_counter++ % nb_flows;
+ m[i]->tim.ev.event_ptr = m[i];
+ m[i]->timestamp = rte_get_timer_cycles();
+ }
+ rte_event_timer_arm_tmo_tick_burst(
+ adptr[fl
[dpdk-dev] [PATCH 4/4] doc: update test eventdev documentation
Update documentation to include new options added for using event timer adapter as a producer. Signed-off-by: Pavan Nikhilesh --- doc/guides/tools/testeventdev.rst | 60 +++ 1 file changed, 60 insertions(+) diff --git a/doc/guides/tools/testeventdev.rst b/doc/guides/tools/testeventdev.rst index 77480ffe9..ab07c0284 100644 --- a/doc/guides/tools/testeventdev.rst +++ b/doc/guides/tools/testeventdev.rst @@ -123,6 +123,36 @@ The following are the application command-line options: Use ethernet device as producer. +* ``--prod_type_timerdev`` + +Use event timer adapter as producer. + + * ``--prod_type_timerdev_burst`` + +Use burst mode event timer adapter as producer. + + * ``--bkt_tck_nsec`` + +Used to dictate number of nano seconds between bucket traversal of the +event timer adapter. Refer `rte_event_timer_adapter_conf`. + + * ``--max_tmo_nsec`` + +Used to configure event timer adapter max arm timeout in nano seconds. + + * ``--nb_bkt_tcks`` + +Dictate the number of bucket ticks after which the event timer expires. + + * ``--nb_timers`` + +Number of event timers each producer cores will generate. + + * ``--nb_timer_adptrs`` + +Number of event timer adapters to be used. Each adapter is used in +round robin manner by the producer cores. + Eventdev Tests -- @@ -347,6 +377,13 @@ Supported application command line options are following:: --fwd_latency --queue_priority --prod_type_ethdev +--prod_type_timerdev_burst +--prod_type_timerdev +--bkt_tck_nsec +--max_tmo_nsec +--nb_bkt_tcks +--nb_timers +--nb_timer_adptrs Example ^^^ @@ -365,6 +402,14 @@ Example command to run perf queue test with ethernet ports: sudo build/app/dpdk-test-eventdev --vdev=event_sw0 -- \ --test=perf_queue --plcores=2 --wlcore=3 --stlist=p --prod_type_ethdev +Example command to run perf queue test with event timer adapter: + +.. code-block:: console + + sudo build/app/dpdk-test-eventdev --vdev="event_octeontx" -- \ +--wlcores 4 --plcores 12 --test perf_queue --stlist=a \ +--prod_type_timerdev --fwd_latency + PERF_ATQ Test ~~~ @@ -431,6 +476,13 @@ Supported application command line options are following:: --worker_deq_depth --fwd_latency --prod_type_ethdev +--prod_type_timerdev_burst +--prod_type_timerdev +--bkt_tck_nsec +--max_tmo_nsec +--nb_bkt_tcks +--nb_timers +--nb_timer_adptrs Example ^^^ @@ -442,6 +494,14 @@ Example command to run perf ``all types queue`` test: sudo build/app/dpdk-test-eventdev --vdev=event_octeontx -- \ --test=perf_atq --plcores=2 --wlcore=3 --stlist=p --nb_pkts=0 +Example command to run perf ``all types queue`` test with event timer adapter: + +.. code-block:: console + + sudo build/app/dpdk-test-eventdev --vdev="event_octeontx" -- \ +--wlcores 4 --plcores 12 --test perf_atq --verbose 20 \ +--stlist=a --prod_type_timerdev --fwd_latency + PIPELINE_QUEUE Test ~~~ -- 2.16.2
[dpdk-dev] [PATCH 1/4] app/eventdev: add event timer adapter as a producer
Add event timer adapter as producer option that can be selected by
passing --prod_type_timerdev.
Signed-off-by: Pavan Nikhilesh
---
app/test-eventdev/evt_options.c | 54
app/test-eventdev/evt_options.h | 9 ++
app/test-eventdev/test_perf_atq.c| 10 +--
app/test-eventdev/test_perf_common.c | 166 +--
app/test-eventdev/test_perf_common.h | 7 ++
app/test-eventdev/test_perf_queue.c | 7 +-
6 files changed, 217 insertions(+), 36 deletions(-)
diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
index 9683b2224..49cd9c419 100644
--- a/app/test-eventdev/evt_options.c
+++ b/app/test-eventdev/evt_options.c
@@ -27,6 +27,11 @@ evt_options_default(struct evt_options *opt)
opt->pool_sz = 16 * 1024;
opt->wkr_deq_dep = 16;
opt->nb_pkts = (1ULL << 26); /* do ~64M packets */
+ opt->nb_timers = 1E8;
+ opt->nb_timer_adptrs = 1;
+ opt->bkt_tck_nsec = 1E3; /* 1000ns ~ 1us */
+ opt->max_tmo_nsec = 1E5; /* 100us */
+ opt->nb_bkt_tcks = 10; /* 50us */
opt->prod_type = EVT_PROD_TYPE_SYNT;
}
@@ -86,6 +91,13 @@ evt_parse_eth_prod_type(struct evt_options *opt, const char
*arg __rte_unused)
return 0;
}
+static int
+evt_parse_timer_prod_type(struct evt_options *opt, const char *arg
__rte_unused)
+{
+ opt->prod_type = EVT_PROD_TYPE_EVENT_TIMER_ADPTR;
+ return 0;
+}
+
static int
evt_parse_test_name(struct evt_options *opt, const char *arg)
{
@@ -169,7 +181,10 @@ usage(char *program)
"\t--worker_deq_depth : dequeue depth of the worker\n"
"\t--fwd_latency : perform fwd_latency measurement\n"
"\t--queue_priority : enable queue priority\n"
- "\t--prod_type_ethdev : use ethernet device as producer\n."
+ "\t--prod_type_ethdev : use ethernet device as producer.\n"
+ "\t--prod_type_timerdev : use event timer device as producer.\n"
+ "\t x * bkt_tck_nsec would be the timeout\n"
+ "\t in ns.\n"
);
printf("available tests:\n");
evt_test_dump_names();
@@ -217,22 +232,23 @@ evt_parse_sched_type_list(struct evt_options *opt, const
char *arg)
}
static struct option lgopts[] = {
- { EVT_NB_FLOWS, 1, 0, 0 },
- { EVT_DEVICE, 1, 0, 0 },
- { EVT_VERBOSE, 1, 0, 0 },
- { EVT_TEST, 1, 0, 0 },
- { EVT_PROD_LCORES, 1, 0, 0 },
- { EVT_WORK_LCORES, 1, 0, 0 },
- { EVT_SOCKET_ID,1, 0, 0 },
- { EVT_POOL_SZ, 1, 0, 0 },
- { EVT_NB_PKTS, 1, 0, 0 },
- { EVT_WKR_DEQ_DEP, 1, 0, 0 },
- { EVT_SCHED_TYPE_LIST, 1, 0, 0 },
- { EVT_FWD_LATENCY, 0, 0, 0 },
- { EVT_QUEUE_PRIORITY, 0, 0, 0 },
- { EVT_PROD_ETHDEV, 0, 0, 0 },
- { EVT_HELP, 0, 0, 0 },
- { NULL, 0, 0, 0 }
+ { EVT_NB_FLOWS,1, 0, 0 },
+ { EVT_DEVICE, 1, 0, 0 },
+ { EVT_VERBOSE, 1, 0, 0 },
+ { EVT_TEST,1, 0, 0 },
+ { EVT_PROD_LCORES, 1, 0, 0 },
+ { EVT_WORK_LCORES, 1, 0, 0 },
+ { EVT_SOCKET_ID, 1, 0, 0 },
+ { EVT_POOL_SZ, 1, 0, 0 },
+ { EVT_NB_PKTS, 1, 0, 0 },
+ { EVT_WKR_DEQ_DEP, 1, 0, 0 },
+ { EVT_SCHED_TYPE_LIST, 1, 0, 0 },
+ { EVT_FWD_LATENCY, 0, 0, 0 },
+ { EVT_QUEUE_PRIORITY, 0, 0, 0 },
+ { EVT_PROD_ETHDEV, 0, 0, 0 },
+ { EVT_PROD_TIMERDEV, 0, 0, 0 },
+ { EVT_HELP,0, 0, 0 },
+ { NULL,0, 0, 0 }
};
static int
@@ -255,11 +271,12 @@ evt_opts_parse_long(int opt_idx, struct evt_options *opt)
{ EVT_FWD_LATENCY, evt_parse_fwd_latency},
{ EVT_QUEUE_PRIORITY, evt_parse_queue_priority},
{ EVT_PROD_ETHDEV, evt_parse_eth_prod_type},
+ { EVT_PROD_TIMERDEV, evt_parse_timer_prod_type},
};
for (i = 0; i < RTE_DIM(parsermap); i++) {
if (strncmp(lgopts[opt_idx].name, parsermap[i].lgopt_name,
- strlen(parsermap[i].lgopt_name)) == 0)
+ strlen(lgopts[opt_idx].name)) == 0)
return parsermap[i].parser_fn(opt, optarg);
}
@@ -305,6 +322,7 @@ evt_options_dump(struct evt_options *opt)
evt_dump("pool_sz", "%d", opt->pool_sz);
evt_dump("master lcore", "%d", rte_get_master_lcore());
evt_dump("nb_pkts", "%"PRIu64, opt->nb_pkts);
+ evt_dump("nb_timers", "%"PRIu64, opt->nb_timers);
evt_dump_begin("available lcores");
RTE_LCORE_FOREACH(lcore_id)
printf("%d ", lcore_id);
diff --git a/app/test-eventdev/evt_options.h b/app/test-
[dpdk-dev] KNI PCIe number and VLAN Stripping
Hi. It is much appreciated if someone could answer the following questions. 1. Regarding KNI, what is the reasoning of giving the PCI device number information when setting kni I/F ? Can the data be blank or dummy ? I would like to create a virtual I/F inside my application and its corresponding kni, which may not have the corresponding physical PCIe slot. 2. the ETHER/VLAN/ARP packet looks not-supported both in mbuf_ptype(RTE_PTYPE_XXX in m->packet_type) and in PKT_RX_VLAN_STRIPPED situation. 2a. How can we encode in m->packet_type to indicate there are arp_hdr after the (ether_hdr,vlan_hdr) pair ? 2b. How can we get the next header value (i.e. ether_proto in vlan_hdr) when the vlan_hdr is stripped by the NIC ? Thanks in advance. Best regards, Yasu
Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API
Hi Rivet, > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Friday, March 16, 2018 1:19 AM > To: Wang, Xiao W > Cc: Burakov, Anatoly ; dev@dpdk.org; Wang, > Zhihong ; maxime.coque...@redhat.com; > y...@fridaylinux.org; Liang, Cunming ; Xu, Rosen > ; Chen, Junjie J ; Daly, Dan > > Subject: Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API > > On Thu, Mar 15, 2018 at 04:49:41PM +, Wang, Xiao W wrote: > > Hi Rivet, > > > > > -Original Message- > > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > Sent: Wednesday, March 14, 2018 9:31 PM > > > To: Burakov, Anatoly > > > Cc: Wang, Xiao W ; dev@dpdk.org; Wang, > Zhihong > > > ; maxime.coque...@redhat.com; > > > y...@fridaylinux.org; Liang, Cunming ; Xu, > Rosen > > > ; Chen, Junjie J ; Daly, Dan > > > > > > Subject: Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API > > > > > > Hi, > > > > > > On Wed, Mar 14, 2018 at 11:19:31AM +, Burakov, Anatoly wrote: > > > > On 09-Mar-18 11:08 PM, Xiao Wang wrote: > > > > > Some existing sysfs parsing functions are helpful for the later vDPA > > > > > driver, this patch make them global and expose them to shared lib. > > > > > > > > > > Signed-off-by: Xiao Wang > > > > > --- > > > > > drivers/bus/pci/linux/pci.c | 9 - > > > > > drivers/bus/pci/linux/pci_init.h| 8 > > > > > drivers/bus/pci/rte_bus_pci_version.map | 8 > > > > > 3 files changed, 20 insertions(+), 5 deletions(-) > > > > > > > > > > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c > > > > > index abde64119..81e5e5650 100644 > > > > > --- a/drivers/bus/pci/linux/pci.c > > > > > +++ b/drivers/bus/pci/linux/pci.c > > > > > @@ -32,7 +32,7 @@ > > > > > extern struct rte_pci_bus rte_pci_bus; > > > > > -static int > > > > > +int > > > > > pci_get_kernel_driver_by_path(const char *filename, char *dri_name) > > > > > > > > Here and in other places - shouldn't this too be prefixed with rte_? > > > > > > > > > > A public PCI function should be prefixed by rte_pci_ yes. > > > > OK, will add this prefix. > > > > > > > > Additionally, if this function was to be exposed, then there should be a > > > BSD implementation as well (shared map file). > > > > > > I don't know how BSD works, I'm not sure parsing the filesystem is the > > > way to get a PCI driver name. If so, maybe the function should be called > > > another, generic, way, that would work for both linux and BSD (and > > > ideally, having a real BSD implementation). > > > > BSD is not parsing the filesystem, it uses PCIOCGETCONF ioctl to retrieve > > PCI device information. > > This function is quite linux, especially for the API name. I'm afraid we can > > only return err on BSD for this API. > > How about renaming the function to something like > rte_pci_device_kdriver_name(); > > and allowing for a sensible BSD implementation to happen if someone > needs it? Yes, it looks more generic, and allows a BSD implementation to happen. I will rename it as below in next version. rte_pci_device_kdriver_name(const struct rte_pci_addr *addr, char *dri_name) BRs, Xiao > > -- > Gaëtan Rivet > 6WIND
Re: [dpdk-dev] [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API
Hi, Konstantin
Thanks for your feedback.
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Thursday, March 15, 2018 5:48 AM
> To: Dai, Wei ; Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API
>
> Hi Wei,
>
> > -Original Message-
> > From: Dai, Wei
> > Sent: Wednesday, March 7, 2018 1:06 PM
> > To: Lu, Wenzhuo ; Ananyev, Konstantin
> >
> > Cc: dev@dpdk.org; Dai, Wei
> > Subject: [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API
> >
> > Ethdev Rx offloads API has changed since:
> > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This
> > commit support the new Rx offloads API.
> >
> > Signed-off-by: Wei Dai
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 93 +
> > drivers/net/ixgbe/ixgbe_ipsec.c | 8 +-
> > drivers/net/ixgbe/ixgbe_rxtx.c| 163
> ++
> > drivers/net/ixgbe/ixgbe_rxtx.h| 3 +
> > drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 2 +-
> > drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 2 +-
> > 6 files changed, 205 insertions(+), 66 deletions(-)
> >
> > +uint64_t
> > +ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev) {
> > + uint64_t offloads;
> > + struct ixgbe_hw *hw =
> > +IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > +
> > + offloads = DEV_RX_OFFLOAD_HEADER_SPLIT;
>
> As I can see I ixgbe all header_split code is enabled only if
> RTE_HEADER_SPLIT_ENABLE is on.
> It is off by default and I doubt anyone really using it these days.
> So I think the best thing would be not to advertise
> DEV_RX_OFFLOAD_HEADER_SPLIT for ixgbe at all, and probably remove
> related code.
> If you'd prefer to keep it, then at least we should set that capability only
> at
> #ifdef RTE_HEADER_SPLIT_ENABLE.
> Another thing - it should be per port, not per queue.
> Thought I think better is just to remove it completely.
I will set this header splitting capability in #ifdef RTE_HEADER_SPLIT_ENABLE
in my next patch set.
I think it is a per queue capability as it can be configured on the register
IXGBE_SRRCTL of every Rx queue
In this code line: IXGBE_WRITE_REG(hw, IXGBE_SRRCTL(rxq->reg_idx), srrctl); in
ixgbe_dev_rx_init( ).
Same case is also in the code line: IXGBE_WRITE_REG(hw, IXGBE_VFSRRCTL(i),
srrctl); in ixgbevf_dev_rx_init( ).
> > +static int
> > +ixgbe_check_rx_queue_offloads(struct rte_eth_dev *dev, uint64_t
> > +requested) {
> > + uint64_t port_offloads = dev->data->dev_conf.rxmode.offloads;
> > + uint64_t queue_supported = ixgbe_get_rx_queue_offloads(dev);
> > + uint64_t port_supported = ixgbe_get_rx_port_offloads(dev);
> > +
> > + if ((requested & (queue_supported | port_supported)) != requested)
> > + return 0;
> > +
> > + if ((port_offloads ^ requested) & port_supported)
>
> Could you explain a bit more what are you cheking here?
> As I can see:
> (port_offloads ^ requested) - that's a diff between already set and newly
> requested offloads.
> Then you check if that diff consists of supported by port offloads, and if yes
> you return an error?
> Konstantin
>
This function is similar to mlx4_check_rx_queue_offloads() in mlx4 driver.
As the git log message in the commit ce17eddefc20285bbfe575bdc07f42f0b20f34cb
say
that a per port capability should has same setting (enabling or disabling) on
both port
configuration via rte_eth_dev_configure( ) and queue configuration via
rte_eth_rx_queue_setup( ).
This function check if this requirement is matched or not.
It also check offloading request is supported as a per port or a per queue
capability or not.
If above checking is pass, it return 1 else return 0.
Re: [dpdk-dev] [PATCH] net/fm10k: convert to new Rx/Tx offloads API
Hi Daiwei:
> -Original Message-
> From: Dai, Wei
> Sent: Friday, March 2, 2018 10:11 PM
> To: Zhang, Qi Z ; Wang, Xiao W
>
> Cc: dev@dpdk.org; Dai, Wei
> Subject: [PATCH] net/fm10k: convert to new Rx/Tx offloads API
>
> Ethdev Rx offloads API has changed since:
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") Ethdev Tx
> offloads API has changed since:
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This
> commit support the new Rx and Tx offloads API.
>
> Signed-off-by: Wei Dai
> ---
> drivers/net/fm10k/fm10k.h | 7 +++
> drivers/net/fm10k/fm10k_ethdev.c | 33
> -
> drivers/net/fm10k/fm10k_rxtx_vec.c | 6 +++---
> 3 files changed, 34 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/fm10k/fm10k.h b/drivers/net/fm10k/fm10k.h index
> 30dad3e..57bd533 100644
> --- a/drivers/net/fm10k/fm10k.h
> +++ b/drivers/net/fm10k/fm10k.h
> @@ -108,6 +108,11 @@
>
> #define FM10K_SIMPLE_TX_FLAG
> ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \
> ETH_TXQ_FLAGS_NOOFFLOADS)
> +#define FM10K_SIMPLE_TX_OFFLOADS
> ((uint64_t)(DEV_TX_OFFLOAD_MULTI_SEGS | \
> + DEV_TX_OFFLOAD_VLAN_INSERT | \
> + DEV_TX_OFFLOAD_SCTP_CKSUM | \
> + DEV_TX_OFFLOAD_UDP_CKSUM | \
> + DEV_TX_OFFLOAD_TCP_CKSUM))
>
> struct fm10k_macvlan_filter_info {
> uint16_t vlan_num; /* Total VLAN number */
> @@ -180,6 +185,7 @@ struct fm10k_rx_queue {
> uint8_t drop_en;
> uint8_t rx_deferred_start; /* don't start this queue in dev start. */
> uint16_t rx_ftag_en; /* indicates FTAG RX supported */
> + uint64_t offloads; /* offloads of DEV_RX_OFFLOAD_* */
> };
>
> /*
> @@ -212,6 +218,7 @@ struct fm10k_tx_queue {
> uint16_t next_dd; /* Next pos to check DD flag */
> volatile uint32_t *tail_ptr;
> uint32_t txq_flags; /* Holds flags for this TXq */
> + uint64_t offloads; /* Offloads of DEV_TX_OFFLOAD_* */
> uint16_t nb_desc;
> uint16_t port_id;
> uint8_t tx_deferred_start; /** don't start this queue in dev start. */
> diff
> --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 9423761..5105874 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -444,7 +444,7 @@ fm10k_dev_configure(struct rte_eth_dev *dev)
>
> PMD_INIT_FUNC_TRACE();
>
> - if (dev->data->dev_conf.rxmode.hw_strip_crc == 0)
> + if (dev->data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_CRC_STRIP)
> PMD_INIT_LOG(WARNING, "fm10k always strip CRC");
> /* multipe queue mode checking */
> ret = fm10k_check_mq_mode(dev);
> @@ -454,6 +454,8 @@ fm10k_dev_configure(struct rte_eth_dev *dev)
> return ret;
> }
>
> + dev->data->scattered_rx = 0;
> +
> return 0;
> }
>
> @@ -756,7 +758,7 @@ fm10k_dev_rx_init(struct rte_eth_dev *dev)
> /* It adds dual VLAN length for supporting dual VLAN */
> if ((dev->data->dev_conf.rxmode.max_rx_pkt_len +
> 2 * FM10K_VLAN_TAG_SIZE) > buf_size ||
> - dev->data->dev_conf.rxmode.enable_scatter) {
> + rxq->offloads & DEV_RX_OFFLOAD_SCATTER) {
> uint32_t reg;
> dev->data->scattered_rx = 1;
> reg = FM10K_READ_REG(hw, FM10K_SRRCTL(i)); @@
> -1389,11 +1391,17 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
> dev_info->vmdq_queue_base= 0;
> dev_info->max_vmdq_pools = ETH_32_POOLS;
> dev_info->vmdq_queue_num = FM10K_MAX_QUEUES_PF;
> + dev_info->rx_queue_offload_capa = DEV_RX_OFFLOAD_SCATTER;
> dev_info->rx_offload_capa =
> - DEV_RX_OFFLOAD_VLAN_STRIP |
> - DEV_RX_OFFLOAD_IPV4_CKSUM |
> - DEV_RX_OFFLOAD_UDP_CKSUM |
> - DEV_RX_OFFLOAD_TCP_CKSUM;
> + DEV_RX_OFFLOAD_VLAN_STRIP |
> + DEV_RX_OFFLOAD_VLAN_FILTER |
> + DEV_RX_OFFLOAD_IPV4_CKSUM |
> + DEV_RX_OFFLOAD_UDP_CKSUM |
> + DEV_RX_OFFLOAD_TCP_CKSUM |
> + DEV_RX_OFFLOAD_JUMBO_FRAME |
> + DEV_RX_OFFLOAD_CRC_STRIP |
> + DEV_RX_OFFLOAD_SCATTER;
> + dev_info->tx_queue_offload_capa = 0;
> dev_info->tx_offload_capa =
> DEV_TX_OFFLOAD_VLAN_INSERT |
> DEV_TX_OFFLOAD_IPV4_CKSUM |
> @@ -1412,6 +1420,7 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
> },
> .rx_free_thresh = FM10K_RX_FREE_THRESH_DEFAULT(0),
> .rx_drop_en = 0,
> + .offloads = 0,
> };
>
> dev_info->default_txconf = (struct rte_eth_txconf) { @@ -1423,6
> +1432,7 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
>
Re: [dpdk-dev] [DPDK] net/i40e: convert to new Rx offloads API
Hi Yanglong:
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Friday, March 2, 2018 4:20 PM
> To: dev@dpdk.org
> Cc: Dai, Wei ; Xing, Beilei ; Lu,
> Wenzhuo ; Wu, Yanglong
> Subject: [dpdk-dev] [DPDK] net/i40e: convert to new Rx offloads API
>
> Ethdev Tx offloads API has changed since:
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This
> commit support the new Tx offloads API.
>
> Signed-off-by: Yanglong Wu
> mailto:yanglong...@intel.com>>
> ---
> drivers/net/i40e/i40e_ethdev.c| 30 ++
> drivers/net/i40e/i40e_ethdev_vf.c | 22 +++---
> drivers/net/i40e/i40e_flow.c | 3 ++-
> drivers/net/i40e/i40e_rxtx.c | 32
>
> drivers/net/i40e/i40e_rxtx.h | 1 +
> 5 files changed, 68 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 508b4171c..3cfc6a5b6 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3176,6 +3176,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
>dev_info->max_rx_pktlen = I40E_FRAME_SIZE_MAX;
>dev_info->max_mac_addrs = vsi->max_macaddrs;
>dev_info->max_vfs = pci_dev->max_vfs;
> + dev_info->rx_queue_offload_capa = 0;
>dev_info->rx_offload_capa =
> DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_QINQ_STRIP |
> @@ -3183,7 +3184,13 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
> - DEV_RX_OFFLOAD_CRC_STRIP;
> +DEV_RX_OFFLOAD_CRC_STRIP |
> +DEV_RX_OFFLOAD_VLAN_EXTEND |
> +DEV_RX_OFFLOAD_VLAN_FILTER;
> +
> + if (dev_info->max_rx_pktlen > ETHER_MAX_LEN)
> +dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME;
If statement is not necessary here since, max_rx_pktlen = I40E_FRAME_SIZE_MAX
> +
>dev_info->tx_offload_capa =
> DEV_TX_OFFLOAD_VLAN_INSERT |
> DEV_TX_OFFLOAD_QINQ_INSERT |
> @@ -3210,6 +3217,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> },
> .rx_free_thresh = I40E_DEFAULT_RX_FREE_THRESH,
> .rx_drop_en = 0,
> +.offloads = 0,
>};
>
>dev_info->default_txconf = (struct rte_eth_txconf) { @@ -3329,7
> +3337,8 @@ i40e_vlan_tpid_set(struct rte_eth_dev *dev, {
>struct i40e_hw *hw =
> I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
>struct i40e_pf *pf =
> I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> -int qinq = dev->data->dev_conf.rxmode.hw_vlan_extend;
> + int qinq = dev->data->dev_conf.rxmode.offloads &
> + DEV_RX_OFFLOAD_VLAN_EXTEND;
>int ret = 0;
>
>if ((vlan_type != ETH_VLAN_TYPE_INNER && @@ -3377,9 +3386,11
> @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask) {
>struct i40e_pf *pf =
> I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
>struct i40e_vsi *vsi = pf->main_vsi;
> + struct rte_eth_rxmode *rxmode;
>
> + rxmode = &dev->data->dev_conf.rxmode;
>if (mask & ETH_VLAN_FILTER_MASK) {
> - if (dev->data->dev_conf.rxmode.hw_vlan_filter)
> +if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
> i40e_vsi_config_vlan_filter(vsi, TRUE);
> else
> i40e_vsi_config_vlan_filter(vsi, FALSE); @@ -3387,14
> +3398,14 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask)
>
>if (mask & ETH_VLAN_STRIP_MASK) {
> /* Enable or disable VLAN stripping */
> - if (dev->data->dev_conf.rxmode.hw_vlan_strip)
> +if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
> i40e_vsi_config_vlan_stripping(vsi, TRUE);
> else
> i40e_vsi_config_vlan_stripping(vsi, FALSE);
>}
>
>if (mask & ETH_VLAN_EXTEND_MASK) {
> - if (dev->data->dev_conf.rxmode.hw_vlan_extend) {
> +if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND) {
> i40e_vsi_config_double_vlan(vsi, TRUE);
> /* Set global registers with default ethertype. */
> i40e_vlan_tpid_set(dev, ETH_VLAN_TYPE_OUTER, @@
> -3641,6 +3652,7 @@ i40e_macaddr_add(struct rte_eth_dev *dev,
>struct i40e_pf *pf =
> I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
>struct i40e_mac_filter_info mac_filter;
>struct i40e_vsi *vsi;
> + struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
>int ret;
>
>/* If VMDQ not enabled or configured, return */ @@ -3659,7 +3671,7
> @@ i40e_macaddr_add(struct rte_eth_dev *dev,
>}
>
>rte_memcpy(&mac_f
Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: convert to new Tx offloads API
Hi, Konstantin
Thanks for your feedback.
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Thursday, March 15, 2018 7:19 AM
> To: Dai, Wei ; Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 4/4] net/ixgbe: convert to new Tx offloads API
>
>
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h
> > b/drivers/net/ixgbe/ixgbe_rxtx.h index 30095fa..d7f0535 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.h
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.h
> > @@ -223,6 +223,7 @@ struct ixgbe_tx_queue {
> > uint8_t hthresh; /**< Host threshold register. */
> > uint8_t wthresh; /**< Write-back threshold reg.
> */
> > uint32_t txq_flags; /**< Holds flags for this TXq */
> > + uint64_t offloads; /**< Tx offload flags of DEV_TX_OFFLOAD_* */
> > uint32_tctx_curr; /**< Hardware context states.
> */
> > /** Hardware context0 history. */
> > struct ixgbe_advctx_info ctx_cache[IXGBE_CTX_NUM]; @@ -254,6
> +255,12
> > @@ struct ixgbe_txq_ops { #define IXGBE_SIMPLE_FLAGS
> > ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \
> > ETH_TXQ_FLAGS_NOOFFLOADS)
> >
> > +#define IXGBE_SIMPLE_TX_OFFLOAD_FLAGS
> ((uint64_t)DEV_TX_OFFLOAD_MULTI_SEGS |\
> > + DEV_TX_OFFLOAD_VLAN_INSERT |\
> > + DEV_TX_OFFLOAD_SCTP_CKSUM |\
> > + DEV_TX_OFFLOAD_UDP_CKSUM |\
> > + DEV_TX_OFFLOAD_TCP_CKSUM)
>
>
> Hmm and why IP_CKSUM, TSO, OUTER_IP_CKSUM, etc. is not included into
> that macro?
> In fact do you really need that?
> As I understand right now vector TX doesn't support any offloads, so
> tx_offload != 0, should be enough for tx function selection, right?
> Konstanitn
In this patch, IXGBE_SIMPLE_TX_OFFLOAD_FLAGS is just a reverse transform of
IXGBE_SIMPLE_FLAGS which is used in old offload API.
Yes, current vector Tx doesn't support any offloads.
I will use tx_offload==0 following your guide.
>
> > +
> > /*
> > * Populate descriptors with the following info:
> > * 1.) buffer_addr = phys_addr + headroom @@ -307,6 +314,7 @@
> > uint16_t ixgbe_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf
> **tx_pkts,
> > uint16_t nb_pkts);
> > int ixgbe_txq_vec_setup(struct ixgbe_tx_queue *txq);
> >
> > +uint64_t ixgbe_get_tx_port_offlaods(struct rte_eth_dev *dev);
> > uint64_t ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev);
> > uint64_t ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev);
> >
> > --
> > 2.7.5
Re: [dpdk-dev] [PATCH v5] vfio: change to use generic multi-process channel
Hi Anatoly,
Thank you for the review. All your comments will be addressed in next version,
except for below concern which might be taken care of in another patch if it
also concerns you.
> -Original Message-
> From: Burakov, Anatoly
> Sent: Wednesday, March 14, 2018 9:27 PM
> To: Tan, Jianfeng; dev@dpdk.org
> Cc: Richardson, Bruce; Ananyev, Konstantin; tho...@monjalon.net
> Subject: Re: [PATCH v5] vfio: change to use generic multi-process channel
[...]
>
> > + mp_req.len_param = sizeof(*p);
> > + mp_req.num_fds = 0;
> > +
> > + vfio_group_fd = -1;
> > + if (rte_mp_request(&mp_req, &mp_reply, &ts) == 0 &&
> > + mp_reply.nb_received == 1) {
> > + mp_rep = &mp_reply.msgs[0];
> > + p = (struct vfio_mp_param *)mp_rep->param;
> > + if (p->result == SOCKET_OK && mp_rep->num_fds == 1) {
> > + cur_grp->group_no = iommu_group_no;
> > + vfio_group_fd = mp_rep->fds[0];
> > + cur_grp->fd = vfio_group_fd;
> > + vfio_cfg.vfio_active_groups++;
> > }
> > + free(mp_reply.msgs);
> > }
> > - return -1;
> > +
> > + if (vfio_group_fd < 0)
> > + RTE_LOG(ERR, EAL, " cannot request group fd\n");
> > + return vfio_group_fd;
>
> p->result can be SOCKET_NO_FD, in which case returned value should be
> zero. I think this is missing from this code. There probably should be
> an "else if (p->result == SOCKET_NO_FD)" clause that sets return value to 0.
>
> You should be able to test this by trying to set up a device for VFIO
> that isn't bound to VFIO driver, in a secondary process.
OK, I will fix this.
But really, "zero" could be ambiguous as a fd could, theoretically, be zero too.
Thanks,
Jianfeng
Re: [dpdk-dev] [PATCH v4] doc: add driver limitation for vhost dequeue zero copy
> -Original Message- > From: Chen, Junjie J > Sent: Thursday, March 15, 2018 12:24 AM > To: Tan, Jianfeng; maxime.coque...@redhat.com; y...@fridaylinux.org > Cc: dev@dpdk.org; Chen, Junjie J > Subject: [PATCH v4] doc: add driver limitation for vhost dequeue zero copy > > In vhost-switch example, when binding nic to vfio-pci with iommu enabled, > dequeue zero copy cannot work in VM2NIC mode due to no iommu dma > mapping > is setup for guest memory currently. > > Signed-off-by: Junjie Chen Reviewed-by: Jianfeng Tan Thanks! > --- > Changes in V4: > - make words more accurate > Changes in V3: > - update limitation to iommu > Changes in V2: > - add doc in vhost lib > doc/guides/prog_guide/vhost_lib.rst | 5 + > doc/guides/sample_app_ug/vhost.rst | 5 - > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/prog_guide/vhost_lib.rst > b/doc/guides/prog_guide/vhost_lib.rst > index 18227b6..b49e36e 100644 > --- a/doc/guides/prog_guide/vhost_lib.rst > +++ b/doc/guides/prog_guide/vhost_lib.rst > @@ -83,6 +83,11 @@ The following is an overview of some key Vhost API > functions: >of those segments, thus the fewer the segments, the quicker we will get >the mapping. NOTE: we may speed it by using tree searching in future. > > +* zero copy can not work when using vfio-pci with iommu mode currently, > this > + is because we don't setup iommu dma mapping for guest memory. If > you have > + to use vfio-pci driver, please insert vfio-pci kernel module in noiommu > + mode. > + >- ``RTE_VHOST_USER_IOMMU_SUPPORT`` > > IOMMU support will be enabled when this flag is set. It is disabled by > diff --git a/doc/guides/sample_app_ug/vhost.rst > b/doc/guides/sample_app_ug/vhost.rst > index a4bdc6a..f0bb169 100644 > --- a/doc/guides/sample_app_ug/vhost.rst > +++ b/doc/guides/sample_app_ug/vhost.rst > @@ -147,7 +147,10 @@ retries on an RX burst, it takes effect only when rx > retry is enabled. The > default value is 15. > > **--dequeue-zero-copy** > -Dequeue zero copy will be enabled when this option is given. > +Dequeue zero copy will be enabled when this option is given. it is worth to > +note that if NIC is binded to driver with iommu enabled, dequeue zero copy > +cannot work at VM2NIC mode (vm2vm=0) due to currently we don't setup > iommu > +dma mapping for guest memory. > > **--vlan-strip 0|1** > VLAN strip option is removed, because different NICs have different > behaviors > -- > 2.0.1
