Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add commands to test new Rx offload API
Thanks to Konstantin and Andrew for your feedback. I will use __builtin_ctzll() and __builtin_clzll() in my v3 patch set. I also will use strcasecmp and loop to do config_rx_offload() and config_tx_offload() following your guidance. > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 13, 2018 5:31 PM > To: Andrew Rybchenko ; Dai, Wei > ; Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add commands to test > new Rx offload API > > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew > Rybchenko > > Sent: Tuesday, March 13, 2018 7:21 AM > > To: Dai, Wei ; Lu, Wenzhuo > ; > > Wu, Jingjing > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add commands to > > test new Rx offload API > > > > On 03/13/2018 09:42 AM, Wei Dai wrote: > > > Add following testpmd run-time commands to support test of new Rx > > > offload API: > > > rx_offload get capability > > > rx_offload get configuration rx_offload enable|disable > > > per_port rx_offload enable|disable per_queue > > > > > > > > > Above last 2 commands should be run when the port is stopped. > > > And can be one of "vlan_strip", "ipv4_cksum", ... > > > > > > Signed-off-by: Wei Dai > > > --- > > > + for (single_offload = DEV_RX_OFFLOAD_VLAN_STRIP; > > > + single_offload <= DEV_RX_OFFLOAD_SECURITY; > > > > It requires attention when a new offload is added. > > Please, consider to use something like __builtin_ffsll(), print name > > of the found bit, clear it and retry. It allows to avoid boundaries > > specification. > > > > > > > > > > I was going to suggest rte_eth_dev_rx_offload_name(), strcasecmp() and > loop. > > +1 > > > It is possible to iterate on all U64 bits or add a way to get all > > offload bits from rte_ethdev. > > However it still requires list of offloads in the help below. So, it > > is not easy to get rig of offloads list completely. Just an idea. Up > > to you. > > > > > >
Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add commands to test new Rx offload API
> -Original Message-
> From: Wu, Jingjing
> Sent: Thursday, March 15, 2018 3:41 AM
> To: Dai, Wei ; Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2 1/2] app/testpmd: add commands to test new Rx
> offload API
>
> <...>
>
> > +static int
> > +config_rx_offload(const char *name, uint64_t *offload, int on) {
> > + uint64_t local = *offload;
> > +
> > + if (!strcmp(name, "vlan_strip")) {
> > + if (on)
> > + local |= DEV_RX_OFFLOAD_VLAN_STRIP;
> > + else
> > + local &= ~DEV_RX_OFFLOAD_VLAN_STRIP;
> Would it decrease the lines if move the "on" checking to the end of this
> function, just set the BIT which you want to set or mask here?
Thanks, will follow your suggestion in v3 patch set.
> <...>
>
> > +static void
> > +cmd_config_per_port_rx_offload_parsed(void *parsed_result,
> > + __attribute__((unused)) struct cmdline *cl,
> > + __attribute__((unused)) void *data) {
> > + struct cmd_config_per_port_rx_offload_result *res = parsed_result;
> > + portid_t port_id = res->port_id;
> > + struct rte_port *port = &ports[port_id];
> > + int on;
> > +
> > + if (port->port_status != RTE_PORT_STOPPED) {
> > + printf("Error: Can't config offload when Port %d "
> > + "is not stopped\n", port_id);
> > + return;
> > + }
> > +
> > + if (!strcmp(res->en_dis, "enable"))
> > + on = 1;
> > + else if (!strcmp(res->en_dis, "disable"))
> > + on = 0;
> > + else {
> > + printf("Unknown parameter: %s\n", res->en_dis);
> > + return;
> The en_dis is already defined as "enable#disable", so the else is useless
> here.
Thanks, the second if and second else can be removed and will change in v3
patch set.
>
> <...>
>
> > +static void
> > +cmd_config_per_queue_rx_offload_parsed(void *parsed_result,
> > + __attribute__((unused)) struct cmdline *cl,
> > + __attribute__((unused)) void *data) {
> > + struct cmd_config_per_queue_rx_offload_result *res = parsed_result;
> > + struct rte_eth_dev_info dev_info;
> > + portid_t port_id = res->port_id;
> > + uint16_t queue_id = res->queue_id;
> > + struct rte_port *port = &ports[port_id];
> > + int on;
> > +
> > + if (port->port_status != RTE_PORT_STOPPED) {
> > + printf("Error: Can't config offload when Port %d "
> > + "is not stopped\n", port_id);
> > + return;
> > + }
> > +
> > + if (!strcmp(res->en_dis, "enable"))
> > + on = 1;
> > + else if (!strcmp(res->en_dis, "disable"))
> > + on = 0;
> > + else {
> > + printf("Unknown parameter: %s\n", res->en_dis);
> > + return;
> Same comments as above.
> <...>
>
> > @@ -707,6 +708,17 @@ init_config(void)
> > }
> > }
> >
> > + port->rx_offloads = rte_zmalloc("testpmd: port->rx_offloads",
> > + sizeof(port->rx_offloads[0]) *
> > + port->dev_info.max_rx_queues,
> > + sizeof(port->rx_offloads[0]));
>
> When will you free it?
I will free port->rx_offloads and port->tx_offloads when testpmd is existed.
>
> > + if (port->rx_offloads == NULL)
> > + rte_exit(EXIT_FAILURE,
> > +"rte_zmalloc(%d port->rx_offload[0]) "
> > +"failed\n", port->dev_info.max_rx_queues);
> > + for (k = 0; k < port->dev_info.max_rx_queues; k++)
> > + port->rx_offloads[k] = port->dev_conf.rxmode.offloads;
> > +
> In the get configure command, the port->rx_offloads is printed.
> Here you init it to be port configuration, when will you update it?
This init_config() is only run once in the initialization stage in the main().
Port->rx_offloads[] can be changed using new testpmd command in this patch set.
Testpmd> rx_offload enable/disable per_queue
And will be applied when the command port start is run.
[dpdk-dev] [PATCH v3 2/3] app/testpmd: add commands to test new Rx offload API
Add following testpmd run-time commands to support test of
new Rx offload API:
rx_offload get capability
rx_offload get configuration
rx_offload enable|disable per_port
rx_offload enable|disable per_queue
Above last 2 commands should be run when the port is stopped.
And can be one of "vlan_strip", "ipv4_cksum", ...
Signed-off-by: Wei Dai
---
app/test-pmd/cmdline.c | 367 +
app/test-pmd/testpmd.c | 19 ++-
app/test-pmd/testpmd.h | 1 +
3 files changed, 385 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 40b31ad..0475064 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -15996,6 +15996,369 @@ cmdline_parse_inst_t cmd_ptype_mapping_update = {
},
};
+/* Get Rx offloads capability */
+struct cmd_rx_offload_get_capa_result {
+ cmdline_fixed_string_t rx_offload;
+ cmdline_fixed_string_t get;
+ cmdline_fixed_string_t capability;
+ portid_t port_id;
+};
+
+cmdline_parse_token_string_t cmd_rx_offload_get_capa_rx_offload =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_rx_offload_get_capa_result,
+rx_offload, "rx_offload");
+cmdline_parse_token_string_t cmd_rx_offload_get_capa_get =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_rx_offload_get_capa_result,
+get, "get");
+cmdline_parse_token_string_t cmd_rx_offload_get_capa_capability =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_rx_offload_get_capa_result,
+capability, "capability");
+cmdline_parse_token_num_t cmd_rx_offload_get_capa_port_id =
+ TOKEN_NUM_INITIALIZER
+ (struct cmd_rx_offload_get_capa_result,
+port_id, UINT16);
+
+static void
+print_rx_offloads(uint64_t offloads)
+{
+ uint64_t single_offload;
+ int begin;
+ int end;
+ int bit;
+
+ if (offloads == 0)
+ return;
+
+ begin = __builtin_ctzll(offloads);
+ end = sizeof(offloads) * CHAR_BIT - __builtin_clzll(offloads);
+
+ single_offload = 1 << begin;
+ for (bit = begin; bit < end; bit++) {
+ if (offloads & single_offload)
+ printf(" %s",
+ rte_eth_dev_rx_offload_name(single_offload));
+ single_offload <<= 1;
+ }
+}
+
+static void
+cmd_rx_offload_get_capa_parsed(
+ void *parsed_result,
+ __attribute__((unused)) struct cmdline *cl,
+ __attribute__((unused)) void *data)
+{
+ struct cmd_rx_offload_get_capa_result *res = parsed_result;
+ struct rte_eth_dev_info dev_info;
+ portid_t port_id = res->port_id;
+ uint64_t queue_offloads;
+ uint64_t port_offloads;
+
+ rte_eth_dev_info_get(port_id, &dev_info);
+ queue_offloads = dev_info.rx_queue_offload_capa;
+ port_offloads = dev_info.rx_offload_capa ^ queue_offloads;
+
+ printf("Rx Offloading Capabilities of port %d :\n", port_id);
+ printf(" Per Queue :");
+ print_rx_offloads(queue_offloads);
+
+ printf("\n");
+ printf(" Per Port :");
+ print_rx_offloads(port_offloads);
+ printf("\n\n");
+}
+
+cmdline_parse_inst_t cmd_rx_offload_get_capa = {
+ .f = cmd_rx_offload_get_capa_parsed,
+ .data = NULL,
+ .help_str = "rx_offload get capability ",
+ .tokens = {
+ (void *)&cmd_rx_offload_get_capa_rx_offload,
+ (void *)&cmd_rx_offload_get_capa_get,
+ (void *)&cmd_rx_offload_get_capa_capability,
+ (void *)&cmd_rx_offload_get_capa_port_id,
+ NULL,
+ }
+};
+
+/* Get Rx offloads configuration */
+struct cmd_rx_offload_get_configuration_result {
+ cmdline_fixed_string_t rx_offload;
+ cmdline_fixed_string_t get;
+ cmdline_fixed_string_t configuration;
+ portid_t port_id;
+};
+
+cmdline_parse_token_string_t cmd_rx_offload_get_configuration_rx_offload =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_rx_offload_get_configuration_result,
+rx_offload, "rx_offload");
+cmdline_parse_token_string_t cmd_rx_offload_get_configuration_get =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_rx_offload_get_configuration_result,
+get, "get");
+cmdline_parse_token_string_t cmd_rx_offload_get_configuration_configuration =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_rx_offload_get_configuration_result,
+configuration, "configuration");
+cmdline_parse_token_num_t cmd_rx_offload_get_configuration_port_id =
+ TOKEN_NUM_INITIALIZER
+ (struct cmd_rx_offload_get_configuration_result,
+port_id, UINT16);
+
+static void
+cmd_rx_offload_get_configuration_parsed(
+ void *parsed_result,
+ __attribute__((unused)) struct cmdline *cl,
+ __attribute__((unused)) void *data)
+{
+ struct cmd_rx_offload_
[dpdk-dev] [PATCH v3 3/3] app/testpmd: add commands to test new Tx offload API
Add following testpmd run-time commands to support test of
new Tx offload API:
tx_offload get capability
tx_offload get configuration
tx_offload enable|disable per_port
tx_offload enable|disable per_queue
Above last 2 commands should be run when the port is stopped.
And can be one of "vlan_insert", "udp_cksum", ...
Signed-off-by: Wei Dai
---
app/test-pmd/cmdline.c | 372 +
app/test-pmd/testpmd.c | 15 +-
app/test-pmd/testpmd.h | 1 +
3 files changed, 386 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 0475064..a142517 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -16359,6 +16359,374 @@ cmdline_parse_inst_t cmd_config_per_queue_rx_offload
= {
}
};
+/* Get Tx offloads capability */
+struct cmd_tx_offload_get_capa_result {
+ cmdline_fixed_string_t tx_offload;
+ cmdline_fixed_string_t get;
+ cmdline_fixed_string_t capability;
+ portid_t port_id;
+};
+
+cmdline_parse_token_string_t cmd_tx_offload_get_capa_tx_offload =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_tx_offload_get_capa_result,
+tx_offload, "tx_offload");
+cmdline_parse_token_string_t cmd_tx_offload_get_capa_get =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_tx_offload_get_capa_result,
+get, "get");
+cmdline_parse_token_string_t cmd_tx_offload_get_capa_capability =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_tx_offload_get_capa_result,
+capability, "capability");
+cmdline_parse_token_num_t cmd_tx_offload_get_capa_port_id =
+ TOKEN_NUM_INITIALIZER
+ (struct cmd_tx_offload_get_capa_result,
+port_id, UINT16);
+
+static void
+print_tx_offloads(uint64_t offloads)
+{
+ uint64_t single_offload;
+ int begin;
+ int end;
+ int bit;
+
+ if (offloads == 0)
+ return;
+
+ begin = __builtin_ctzll(offloads);
+ end = sizeof(offloads) * CHAR_BIT - __builtin_clzll(offloads);
+
+ single_offload = 1 << begin;
+ for (bit = begin; bit < end; bit++) {
+ if (offloads & single_offload)
+ printf(" %s",
+ rte_eth_dev_tx_offload_name(single_offload));
+ single_offload <<= 1;
+ }
+}
+
+static void
+cmd_tx_offload_get_capa_parsed(
+ void *parsed_result,
+ __attribute__((unused)) struct cmdline *cl,
+ __attribute__((unused)) void *data)
+{
+ struct cmd_tx_offload_get_capa_result *res = parsed_result;
+ struct rte_eth_dev_info dev_info;
+ portid_t port_id = res->port_id;
+ uint64_t queue_offloads;
+ uint64_t port_offloads;
+
+ rte_eth_dev_info_get(port_id, &dev_info);
+ queue_offloads = dev_info.tx_queue_offload_capa;
+ port_offloads = dev_info.tx_offload_capa ^ queue_offloads;
+
+ printf("Tx Offloading Capabilities of port %d :\n", port_id);
+ printf(" Per Queue :");
+ print_tx_offloads(queue_offloads);
+ printf("\n");
+ printf(" Per Port :");
+ print_tx_offloads(port_offloads);
+ printf("\n\n");
+}
+
+cmdline_parse_inst_t cmd_tx_offload_get_capa = {
+ .f = cmd_tx_offload_get_capa_parsed,
+ .data = NULL,
+ .help_str = "tx_offload get capability ",
+ .tokens = {
+ (void *)&cmd_tx_offload_get_capa_tx_offload,
+ (void *)&cmd_tx_offload_get_capa_get,
+ (void *)&cmd_tx_offload_get_capa_capability,
+ (void *)&cmd_tx_offload_get_capa_port_id,
+ NULL,
+ }
+};
+
+/* Get Tx offloads configuration */
+struct cmd_tx_offload_get_configuration_result {
+ cmdline_fixed_string_t tx_offload;
+ cmdline_fixed_string_t get;
+ cmdline_fixed_string_t configuration;
+ portid_t port_id;
+};
+
+cmdline_parse_token_string_t cmd_tx_offload_get_configuration_tx_offload =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_tx_offload_get_configuration_result,
+tx_offload, "tx_offload");
+cmdline_parse_token_string_t cmd_tx_offload_get_configuration_get =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_tx_offload_get_configuration_result,
+get, "get");
+cmdline_parse_token_string_t cmd_tx_offload_get_configuration_configuration =
+ TOKEN_STRING_INITIALIZER
+ (struct cmd_tx_offload_get_configuration_result,
+configuration, "configuration");
+cmdline_parse_token_num_t cmd_tx_offload_get_configuration_port_id =
+ TOKEN_NUM_INITIALIZER
+ (struct cmd_tx_offload_get_configuration_result,
+port_id, UINT16);
+
+static void
+cmd_tx_offload_get_configuration_parsed(
+ void *parsed_result,
+ __attribute__((unused)) struct cmdline *cl,
+ __attribute__((unused)) void *data)
+{
+ struct cmd_tx_offl
[dpdk-dev] [PATCH v3 0/3] app/testpmd: add new commands to test new Tx/Rx offload API
Existed testpmd commands can't support per queue offload configuration. And there are different commands to enable or disable different offloading. This patch set add following commands to support new Tx/Rx offloading API test. To get Rx offload capability of a port, please run: testpmd > rx_offload get capability To get current Rx offload per queue and per port configuration of a port, run: tesstpmd > rx_offload get configuration To enable or disable a Rx per port offloading, please run: testpmd > rx_offload enable|disable per_port vlan_strip|ipv4_cksum|... To enable or disable a Tx per port offloading, please run: testpmd > rx_offload enable|disable per_queue vlan_strip|ipv4_cksum|... Same commands like "tx_offload ..." are also added to support new Tx offload API test. --- v3: add enum rte_eth_rx_offload_type and enum rte_eth_tx_offload_type free memory of port->rx_offloads and port->tx_offloads when testpmd is existed v2: use rte_eth_dev_rx_offload_name() and rte_eth_dev_tx_offload_name(). remove static const strings of Rx/Tx offload names. Wei Dai (3): ethdev: add enum type for loop on Rx/Tx offloads app/testpmd: add commands to test new Rx offload API app/testpmd: add commands to test new Tx offload API app/test-pmd/cmdline.c| 739 ++ app/test-pmd/testpmd.c| 34 +- app/test-pmd/testpmd.h| 2 + lib/librte_ether/rte_ethdev.h | 44 +++ 4 files changed, 815 insertions(+), 4 deletions(-) -- 2.7.5
[dpdk-dev] [PATCH v3 1/3] ethdev: add enum type for loop on Rx/Tx offloads
This patch adds enum rte_eth_rx_offload_type and
enum rte_eth_tx_offload_type. For a loop on all
Rx offloads, it is convenient to begin with the
first enum member ETH_RX_OFFLOAD_FIRST_FEATURE
and to end at ETH_RX_OFFLOAD_TOTAL_NUM.
A loop on all Tx offloads can begin with
ETH_TX_OFFLOAD_FIRST_FEATURE and end at
ETH_TX_OFFLOAD_TOTAL_NUM.
Signed-off-by: Wei Dai
---
lib/librte_ether/rte_ethdev.h | 44 +++
1 file changed, 44 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 0361533..0089ea3 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -946,6 +946,27 @@ struct rte_eth_conf {
DEV_RX_OFFLOAD_VLAN_FILTER | \
DEV_RX_OFFLOAD_VLAN_EXTEND)
+enum rte_eth_rx_offload_type {
+ ETH_RX_OFFLOAD_FIRST_FEATURE = 0,
+ ETH_RX_OFFLOAD_VLAN_STRIP = ETH_RX_OFFLOAD_FIRST_FEATURE,
+ ETH_RX_OFFLOAD_IPV4_CKSUM,
+ ETH_RX_OFFLOAD_UDP_CKSUM,
+ ETH_RX_OFFLOAD_TCP_CKSUM,
+ ETH_RX_OFFLOAD_TCP_LRO,
+ ETH_RX_OFFLOAD_QINQ_STRIP,
+ ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM,
+ ETH_RX_OFFLOAD_MACSEC_STRIP,
+ ETH_RX_OFFLOAD_HEADER_SPLIT,
+ ETH_RX_OFFLOAD_VLAN_FILTER,
+ ETH_RX_OFFLOAD_VLAN_EXTEND,
+ ETH_RX_OFFLOAD_JUMBO_FRAME,
+ ETH_RX_OFFLOAD_CRC_STRIP,
+ ETH_RX_OFFLOAD_SCATTER,
+ ETH_RX_OFFLOAD_TIMESTAMP,
+ ETH_RX_OFFLOAD_SECURITY,
+ ETH_RX_OFFLOAD_TOTAL_NUM
+};
+
/*
* If new Rx offload capabilities are defined, they also must be
* mentioned in rte_rx_offload_names in rte_ethdev.c file.
@@ -981,6 +1002,29 @@ struct rte_eth_conf {
*/
#define DEV_TX_OFFLOAD_SECURITY 0x0002
+enum rte_eth_tx_offload_type {
+ ETH_TX_OFFLOAD_FIRST_FEATURE = 0,
+ ETH_TX_OFFLOAD_VLAN_INSERT = ETH_TX_OFFLOAD_FIRST_FEATURE,
+ ETH_TX_OFFLOAD_IPV4_CKSUM,
+ ETH_TX_OFFLOAD_UDP_CKSUM,
+ ETH_TX_OFFLOAD_TCP_CKSUM,
+ ETH_TX_OFFLOAD_SCTP_CKSUM,
+ ETH_TX_OFFLOAD_TCP_TSO,
+ ETH_TX_OFFLOAD_UDP_TSO,
+ ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM,
+ ETH_TX_OFFLOAD_QINQ_INSERT,
+ ETH_TX_OFFLOAD_VXLAN_TNL_TSO,
+ ETH_TX_OFFLOAD_GRE_TNL_TSO,
+ ETH_TX_OFFLOAD_IPIP_TNL_TSO,
+ ETH_TX_OFFLOAD_GENEVE_TNL_TSO,
+ ETH_TX_OFFLOAD_MACSEC_INSERT,
+ ETH_TX_OFFLOAD_MT_LOCKFREE,
+ ETH_TX_OFFLOAD_MULTI_SEGS,
+ ETH_TX_OFFLOAD_MBUF_FAST_FREE,
+ ETH_TX_OFFLOAD_SECURITY,
+ ETH_TX_OFFLOAD_TOTAL_NUM
+};
+
/*
* If new Tx offload capabilities are defined, they also must be
* mentioned in rte_tx_offload_names in rte_ethdev.c file.
--
2.7.5
[dpdk-dev] [PATCH] net/vmxnet3: keep link state consistent
From: Chas Williams
The vmxnet3 never attempts link speed negotiation. As a virtual device
the link speed is vague at best. However, it is important for certain
applications, like bonding, to see a consistent link_status. 802.3ad
requires that only links of the same cost (link speed) be enslaved.
Keeping the link status consistent in vmxnet3 avoids races with bonding
enslavement.
Author: Thomas Monjalon
Date: Fri Jan 5 18:38:55 2018 +0100
Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
Cc: sta...@dpdk.org
Signed-off-by: Chas Williams
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 426008722..48a4d4f98 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1105,7 +1105,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev,
link.link_status = ETH_LINK_UP;
link.link_duplex = ETH_LINK_FULL_DUPLEX;
link.link_speed = ETH_SPEED_NUM_10G;
- link.link_autoneg = ETH_LINK_AUTONEG;
+ link.link_autoneg = ETH_LINK_FIXED;
return rte_eth_linkstatus_set(dev, &link);
}
--
2.13.6
Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description
Friday, March 16, 2018 5:52 PM, Ferruh Yigit:
> Don't mandate API to pass port offload configuration during queue setup,
> this is unnecessary for devices that support only port level offloads.
>
> Fixes: 81ac560dc1b4 ("doc: add details on ethdev offloads API")
> Cc: shah...@mellanox.com
>
> Signed-off-by: Ferruh Yigit
> ---
> Cc: Patil, Harish
>
> Btw, this expectation from API should be clear from source code and API
> documentation (doxygen comments in header file) instead of
> documentation. Am I missing something or we are doing something wrong
> here?
> ---
> doc/guides/prog_guide/poll_mode_drv.rst | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/doc/guides/prog_guide/poll_mode_drv.rst
> b/doc/guides/prog_guide/poll_mode_drv.rst
> index e5d01874e..3247f309f 100644
> --- a/doc/guides/prog_guide/poll_mode_drv.rst
> +++ b/doc/guides/prog_guide/poll_mode_drv.rst
> @@ -303,9 +303,7 @@ Supported offloads can be either per-port or per-
> queue.
> Offloads are enabled using the existing ``DEV_TX_OFFLOAD_*`` or
> ``DEV_RX_OFFLOAD_*`` flags.
> Per-port offload configuration is set using ``rte_eth_dev_configure``.
> Per-queue offload configuration is set using ``rte_eth_rx_queue_setup``
> and ``rte_eth_tx_queue_setup``.
> -To enable per-port offload, the offload should be set on both device
> configuration and queue setup.
> -In case of a mixed configuration the queue setup shall return with an error.
> -To enable per-queue offload, the offload can be set only on the queue
> setup.
> +Per-port offloads should be set on the port configuration. Queue offloads
> should be set on the queue configuration.
> Offloads which are not enabled are disabled by default.
>
> For an application to use the Tx offloads API it should set the
> ``ETH_TXQ_FLAGS_IGNORE`` flag in the ``txq_flags`` field located in
> ``rte_eth_txconf`` struct.
I am OK with such change.
However, while documentation is good, most of the customers learn on the API
usage from the existing examples.
Currently both examples and testpmd behave according to the old approach, see
example from testpmd[1] before the rx_queue_setup.
I think a modification there is needed if we are going to change the API.
[1]
/* Apply Rx offloads configuration */
port->rx_conf.offloads = port->dev_conf.rxmode.offloads;
> --
> 2.13.6
Re: [dpdk-dev] [PATCH] doc: reduce initial offload API scope to drivers
Hi Ferruh,
Friday, March 16, 2018 5:32 PM, Ferruh Yigit:
> Subject: [PATCH] doc: reduce initial offload API scope to drivers
>
> 18.05 tagets ethdev-PMD offload API, which means switching all PMDs to
> new offloading API
>
> Next step targets ethdev-application offload API which means forcing
> applications to switch to new API
>
> Fixes: 3004d3454192 ("doc: update deprecation of ethdev offload API")
> Cc: shah...@mellanox.com
>
> Signed-off-by: Ferruh Yigit
> ---
> doc/guides/rel_notes/deprecation.rst | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 0c696f743..b40c57f28 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -97,8 +97,13 @@ Deprecation Notices
> * ethdev: a new Tx and Rx offload API was introduced on 17.11.
>In the new API, offloads are divided into per-port and per-queue offloads.
>Offloads are disabled by default and enabled per application request.
> - The old offloads API is target to be deprecated on 18.05. This includes:
> + The old offloads API between ethdev and drivers is target to be
> deprecated on 18.05.
> + This includes:
>
> + - removal of the conversion in ethdev from new offloading API to old API.
We cannot remove this part before all of the applications has moved to the new
API.
The conversion function is to help PMDs to have single control path with no
branch for both old and new application.
> +
> + In later releases the old offloading API between ethdev and
> + applications will be deprecated too, which will include:
>- removal of ``ETH_TXQ_FLAGS_NO*`` flags.
>- removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.
>- removal of the offloads bit-field from ``rte_eth_rxmode`` struct.
I am OK with postponing the deprecation to a later release and have the PMDs
conversion to the new API in the current/next one.
> --
> 2.13.6
Re: [dpdk-dev] [PATCH v3 00/10] net/mlx5: clean driver
Monday, March 5, 2018 2:21 PM, Nelio Laranjeiro: > - Removes unused SR-IOV flag. > - Adds missing documentation on some functions. > - Removes the spin-lock on the private structure. > - Standardize the return values of all functions as discussed on the mailing > list [1]. > > [1] > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdp > dk.org%2Fml%2Farchives%2Fdev%2F2018- > January%2F087991.html&data=02%7C01%7Cshahafs%40mellanox.com%7Cf0 > 6e83bf350d44ba5f8908d58293a839%7Ca652971c7d2e4d9ba6a4d149256f461b > %7C0%7C0%7C636558493060723163&sdata=mlYhk19ixx42hzEmUguXNq8rUe > H7%2F5EIAF3AJD%2F6%2FNA%3D&reserved=0 > Series applied to next-net-mlx, thanks.
Re: [dpdk-dev] [PATCH v2 0/2] net/mlx5: convert to dynamic logs
Tuesday, March 13, 2018 11:24 AM, Nelio Laranjeiro: > This series applies on top of [1] > > [1] > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdp > dk.org%2Fdev%2Fpatchwork%2Fpatch%2F35650%2F&data=02%7C01%7Csha > hafs%40mellanox.com%7Cb1ba428446e141f36ac008d588c455b7%7Ca652971c > 7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636565299208586718&sdata=IMr > WqigZCTfcJenR4bVMusWJj1nF%2FSutMW81K8Ab3hE%3D&reserved=0 > > Series applied to next-net-mlx, thanks.
