Re: [dpdk-dev] [PATCH v5] net/ixgbe: add flow parser ntuple support

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Friday, January 5, 2018 3:58 PM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5] net/ixgbe: add flow parser ntuple support
> 
> Hi,
> 
> > -Original Message-
> > From: Zhao1, Wei
> > Sent: Friday, January 5, 2018 2:14 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo ; Zhao1, Wei
> > 
> > Subject: [PATCH v5] net/ixgbe: add flow parser ntuple support
> >
> > Ixgbe ntuple filter in rte_flow need to support diversion data with
> > less than
> > 5 tuple parameters.So add this new support in parser code.This patch
> > also add parser vlan pattern code in ntuple filter in order to handle
> > some case including vlan in flow API.
> >
> > Signed-off-by: Wei Zhao 
> Acked-by: Wenzhuo Lu 
Applied into dpdk-next-net-intel. Thanks!

/Helin

Re: [dpdk-dev] [PATCH 9/9] tools: use SPDX tag for Cavium copyright files

[Hemant Agrawal]

On 1/6/2018 5:50 PM, Jerin Jacob wrote:

Signed-off-by: Jerin Jacob 
---
 devtools/build-tags.sh | 30 ++
 1 file changed, 2 insertions(+), 28 deletions(-)

diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
index 942da2bae..d775b17e9 100755
--- a/devtools/build-tags.sh
+++ b/devtools/build-tags.sh
@@ -1,35 +1,9 @@
 #!/bin/sh -e
 # Generate tags or gtags or cscope or etags files
 #
-#   BSD LICENSE
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Cavium, Inc


Hi Jerin,
   All your patches are ok except this one.
It is not aligned with the policy.
SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.

you can move the comments ("Generate tags...") after the copyrights.

Regards,
Hemant

[dpdk-dev] [Bug 7] mlx4 PMD does not receive broadcast packets in promiscuous mode.

[bugzilla]

https://dpdk.org/tracker/show_bug.cgi?id=7

Bug ID: 7
   Summary: mlx4 PMD does not receive broadcast packets in
promiscuous mode.
   Product: DPDK
   Version: 17.11
  Hardware: All
OS: Linux
Status: CONFIRMED
  Severity: major
  Priority: Normal
 Component: ethdev
  Assignee: dev@dpdk.org
  Reporter: mo...@mellanox.com
  Target Milestone: ---

Using testpmd, when configuring the mlx4 to promiscuous mode, unicast and
multicast packets are received but broadcast packets are not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [dpdk-dev] [PATCH v2 01/20] crypto/ccp: add AMD ccp crypto pmd support

[Hemant Agrawal]

Hi Ravi,

On 1/5/2018 3:09 PM, Ravi Kumar wrote:

diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile
new file mode 100644
index 000..51c5e5b
--- /dev/null
+++ b/drivers/crypto/ccp/Makefile
@@ -0,0 +1,55 @@
+#
+#   Copyright(c) 2018 Advanced Micro Devices, Inc.
+#   All rights reserved.
+#
+#   Redistribution and use in source and binary forms, with or without
+#   modification, are permitted provided that the following conditions
+#   are met:
+#
+#  * Redistributions of source code must retain the above copyright
+#  notice, this list of conditions and the following disclaimer.
+#  * Redistributions in binary form must reproduce the above copyright
+#  notice, this list of conditions and the following disclaimer in the
+#  documentation and/or other materials provided with the distribution.
+#  * Neither the name of the copyright holder nor the names of its
+#  contributors may be used to endorse or promote products derived from
+#  this software without specific prior written permission.
+#
+#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+#   HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


Will you please start using the SPDX tags instead for full license plate?

Regards,
Hemant

Re: [dpdk-dev] [PATCH v3 0/2] support PPPoE and L2TP packet types

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing
> Sent: Thursday, January 4, 2018 6:46 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Wu, Jingjing; Chilikin, Andrey
> Subject: [dpdk-dev] [PATCH v3 0/2] support PPPoE and L2TP packet types
> 
> v3 changes:
>  - reword commit log
> 
> v2 changes:
>  - change patch title
>  - rework ptype parser according to new profile meta data
> 
> Beilei Xing (2):
>   mbuf: add PPPoE and L2TP packet types
>   net/i40e: improve packet type parser
> 
>  drivers/net/i40e/i40e_ethdev.c   | 83 +-
> --
>  lib/librte_mbuf/rte_mbuf_ptype.c |  2 +  lib/librte_mbuf/rte_mbuf_ptype.h
> | 26 +
>  3 files changed, 88 insertions(+), 23 deletions(-)
> 
> --
> 2.5.5
Applied into dpdk-next-net-intel. Thanks!

/Helin

Re: [dpdk-dev] [PATCH v2] net/i40e: enable VF Tx offload

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Wednesday, December 27, 2017 4:29 PM
> To: Xing, Beilei
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: enable VF Tx offload
> 
> 
> 
> > -Original Message-
> > From: Xing, Beilei
> > Sent: Wednesday, December 27, 2017 4:27 PM
> > To: Zhang, Qi Z 
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2] net/i40e: enable VF Tx offload
> >
> > Enable VF Tx offload including outer ip checksum, TSO and tunnel TSO.
> >
> > Signed-off-by: Beilei Xing 
> > ---
> > v2 changes:
> >  - Reword commit log.
> >
> >  drivers/net/i40e/i40e_ethdev_vf.c | 8 +++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index 4927b14..a59e240 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -2227,7 +2227,13 @@ i40evf_dev_info_get(struct rte_eth_dev *dev,
> > struct rte_eth_dev_info *dev_info)
> > DEV_TX_OFFLOAD_IPV4_CKSUM |
> > DEV_TX_OFFLOAD_UDP_CKSUM |
> > DEV_TX_OFFLOAD_TCP_CKSUM |
> > -   DEV_TX_OFFLOAD_SCTP_CKSUM;
> > +   DEV_TX_OFFLOAD_SCTP_CKSUM |
> > +   DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> > +   DEV_TX_OFFLOAD_TCP_TSO |
> > +   DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
> > +   DEV_TX_OFFLOAD_GRE_TNL_TSO |
> > +   DEV_TX_OFFLOAD_IPIP_TNL_TSO |
> > +   DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
> >
> > dev_info->default_rxconf = (struct rte_eth_rxconf) {
> > .rx_thresh = {
> > --
> > 2.5.5
> 
> Acked-by: Qi Zhang 
Applied into dpdk-next-net-intel. Thanks!

/Helin

[dpdk-dev] [PATCH v2 0/6] ethdev: port ownership

[Matan Azrad]

Add ownership mechanism to DPDK Ethernet devices to avoid multiple management 
of a device by different DPDK entities.

V2:  
Synchronize ethdev port creation.
Synchronize port ownership mechanism.
Rename owner remove API to rte_eth_dev_owner_unset.
Remove "ethdev: free a port by a dedicated API" patch - passed to another 
series.
Add "ethdev: fix port data reset timing" patch.
Cahnge owner get API to return int value and to pass copy of the owner 
structure.
Adjust testpmd to the improved owner get API.
Adjust documentations.


Points:
1. rte_eth_dev_owner_claim API was suggested as a blocked API to set owner, I 
didn't find use case for this.
2. Add comments for all APIs which are required ownership setting before the 
calling - still was not done, other suggestions?  


Matan Azrad (6):
  ethdev: fix port data reset timing
  ethdev: add port ownership
  ethdev: synchronize port allocation
  net/failsafe: free an eth port by a dedicated API
  net/failsafe: use ownership mechanism to own ports
  app/testpmd: adjust ethdev port ownership

 app/test-pmd/cmdline.c  |  88 +---
 app/test-pmd/cmdline_flow.c |   2 +-
 app/test-pmd/config.c   |  37 ++---
 app/test-pmd/parameters.c   |   4 +-
 app/test-pmd/testpmd.c  |  63 ++---
 app/test-pmd/testpmd.h  |   3 +
 config/common_base  |   4 +-
 doc/guides/prog_guide/poll_mode_drv.rst |  14 +-
 drivers/net/failsafe/failsafe.c |   7 +
 drivers/net/failsafe/failsafe_eal.c |  10 ++
 drivers/net/failsafe/failsafe_ether.c   |   2 +-
 drivers/net/failsafe/failsafe_private.h |   2 +
 lib/librte_ether/rte_ethdev.c   | 243 +---
 lib/librte_ether/rte_ethdev.h   |  89 
 lib/librte_ether/rte_ethdev_version.map |  12 ++
 15 files changed, 462 insertions(+), 118 deletions(-)

-- 
1.8.3.1

[dpdk-dev] [PATCH v2 1/6] ethdev: fix port data reset timing

[Matan Azrad]

rte_eth_dev_data structure is allocated per ethdev port and can be
used to get a data of the port internally.

rte_eth_dev_attach_secondary tries to find the port identifier using
rte_eth_dev_data name field comparison and may get an identifier of
invalid port in case of this port was released by the primary process
because the port release API doesn't reset the port data.

So, it will be better to reset the port data in release time instead of
allocation time.

Move the port data reset to the port release API.

Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process 
model")
Cc: sta...@dpdk.org

Signed-off-by: Matan Azrad 
---
 lib/librte_ether/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index d1385df..684e3e8 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -233,7 +233,6 @@ struct rte_eth_dev *
return NULL;
}
 
-   memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data));
eth_dev = eth_dev_get(port_id);
snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name);
eth_dev->data->port_id = port_id;
@@ -279,6 +278,7 @@ struct rte_eth_dev *
if (eth_dev == NULL)
return -EINVAL;
 
+   memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));
eth_dev->state = RTE_ETH_DEV_UNUSED;
return 0;
 }
-- 
1.8.3.1

[dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

[Matan Azrad]

The ownership of a port is implicit in DPDK.
Making it explicit is better from the next reasons:
1. It will define well who is in charge of the port usage synchronization.
2. A library could work on top of a port.
3. A port can work on top of another port.

Also in the fail-safe case, an issue has been met in testpmd.
We need to check that the application is not trying to use a port which
is already managed by fail-safe.

A port owner is built from owner id(number) and owner name(string) while
the owner id must be unique to distinguish between two identical entity
instances and the owner name can be any name.
The name helps to logically recognize the owner by different DPDK
entities and allows easy debug.
Each DPDK entity can allocate an owner unique identifier and can use it
and its preferred name to owns valid ethdev ports.
Each DPDK entity can get any port owner status to decide if it can
manage the port or not.

The mechanism is synchronized for both the primary process threads and
the secondary processes threads to allow secondary process entity to be
a port owner.

Add a sinchronized ownership mechanism to DPDK Ethernet devices to
avoid multiple management of a device by different DPDK entities.

The current ethdev internal port management is not affected by this
feature.

Signed-off-by: Matan Azrad 
---
 doc/guides/prog_guide/poll_mode_drv.rst |  14 ++-
 lib/librte_ether/rte_ethdev.c   | 206 ++--
 lib/librte_ether/rte_ethdev.h   |  89 ++
 lib/librte_ether/rte_ethdev_version.map |  12 ++
 4 files changed, 311 insertions(+), 10 deletions(-)

diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
b/doc/guides/prog_guide/poll_mode_drv.rst
index 6a0c9f9..046cde7 100644
--- a/doc/guides/prog_guide/poll_mode_drv.rst
+++ b/doc/guides/prog_guide/poll_mode_drv.rst
@@ -156,8 +156,8 @@ concurrently on the same tx queue without SW lock. This PMD 
feature found in som
 
 See `Hardware Offload`_ for ``DEV_TX_OFFLOAD_MT_LOCKFREE`` capability probing 
details.
 
-Device Identification and Configuration

+Device Identification, Ownership and Configuration
+--
 
 Device Identification
 ~
@@ -171,6 +171,16 @@ Based on their PCI identifier, NIC ports are assigned two 
other identifiers:
 *   A port name used to designate the port in console messages, for 
administration or debugging purposes.
 For ease of use, the port name includes the port index.
 
+Port Ownership
+~~
+The Ethernet devices ports can be owned by a single DPDK entity (application, 
library, PMD, process, etc).
+The ownership mechanism is controlled by ethdev APIs and allows to 
set/remove/get a port owner by DPDK entities.
+Allowing this should prevent any multiple management of Ethernet port by 
different entities.
+
+.. note::
+
+It is the DPDK entity responsibility to set the port owner before using it 
and to manage the port usage synchronization between different threads or 
processes.
+
 Device Configuration
 
 
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 684e3e8..0e12452 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -70,7 +70,10 @@
 
 static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data";
 struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
+/* ports data array stored in shared memory */
 static struct rte_eth_dev_data *rte_eth_dev_data;
+/* next owner identifier stored in shared memory */
+static uint16_t *rte_eth_next_owner_id;
 static uint8_t eth_dev_last_created_port;
 
 /* spinlock for eth device callbacks */
@@ -82,6 +85,9 @@
 /* spinlock for add/remove tx callbacks */
 static rte_spinlock_t rte_eth_tx_cb_lock = RTE_SPINLOCK_INITIALIZER;
 
+/* spinlock for eth device ownership management stored in shared memory */
+static rte_spinlock_t *rte_eth_dev_ownership_lock;
+
 /* store statistics names and its offset in stats structure  */
 struct rte_eth_xstats_name_off {
char name[RTE_ETH_XSTATS_NAME_SIZE];
@@ -153,14 +159,18 @@ enum {
 }
 
 static void
-rte_eth_dev_data_alloc(void)
+rte_eth_dev_share_data_alloc(void)
 {
const unsigned flags = 0;
const struct rte_memzone *mz;
+   const unsigned int data_size = RTE_MAX_ETHPORTS *
+   sizeof(*rte_eth_dev_data);
 
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+   /* Allocate shared memory for port data and ownership */
mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA,
-   RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data),
+   data_size + sizeof(*rte_eth_next_owner_id) +
+   sizeof(*rte_eth_dev_ownership_lock),
rte_socket_id(), flags);
} else
mz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DAT

[dpdk-dev] [PATCH v2 3/6] ethdev: synchronize port allocation

[Matan Azrad]

Ethernet port allocation was not thread safe, means 2 threads which tried
to allocate a new port at the same time might get an identical port
identifier and caused to memory overwrite.
Actually, all the port configurations were not thread safe from ethdev
point of view.

The port ownership mechanism added to the ethdev is a good point to
redefine the synchronization rules in ethdev:

1. The port allocation and port release synchronization will be
   managed by ethdev.
2. The port usage synchronization will be managed by the port owner.
3. The port ownership synchronization will be managed by ethdev.

Add port allocation synchronization to complete the new rules.

Signed-off-by: Matan Azrad 
---
 config/common_base|  4 ++--
 lib/librte_ether/rte_ethdev.c | 39 ---
 2 files changed, 30 insertions(+), 13 deletions(-)

diff --git a/config/common_base b/config/common_base
index b8ee8f9..980ae3b 100644
--- a/config/common_base
+++ b/config/common_base
@@ -94,7 +94,7 @@ CONFIG_RTE_MAX_MEMSEG=256
 CONFIG_RTE_MAX_MEMZONE=2560
 CONFIG_RTE_MAX_TAILQ=32
 CONFIG_RTE_ENABLE_ASSERT=n
-CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO
+CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG
 CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO
 CONFIG_RTE_LOG_HISTORY=256
 CONFIG_RTE_BACKTRACE=y
@@ -136,7 +136,7 @@ CONFIG_RTE_LIBRTE_KVARGS=y
 # Compile generic ethernet library
 #
 CONFIG_RTE_LIBRTE_ETHER=y
-CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n
+CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=y
 CONFIG_RTE_MAX_ETHPORTS=32
 CONFIG_RTE_MAX_QUEUES_PER_PORT=1024
 CONFIG_RTE_LIBRTE_IEEE1588=n
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 0e12452..d30d61f 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -85,6 +85,9 @@
 /* spinlock for add/remove tx callbacks */
 static rte_spinlock_t rte_eth_tx_cb_lock = RTE_SPINLOCK_INITIALIZER;
 
+/* spinlock for shared data allocation */
+static rte_spinlock_t rte_eth_share_data_alloc = RTE_SPINLOCK_INITIALIZER;
+
 /* spinlock for eth device ownership management stored in shared memory */
 static rte_spinlock_t *rte_eth_dev_ownership_lock;
 
@@ -234,21 +237,27 @@ struct rte_eth_dev *
 rte_eth_dev_allocate(const char *name)
 {
uint16_t port_id;
-   struct rte_eth_dev *eth_dev;
+   struct rte_eth_dev *eth_dev = NULL;
+
+   /* Synchronize share data one time allocation between local threads. */
+   rte_spinlock_lock(&rte_eth_share_data_alloc);
+   if (rte_eth_dev_data == NULL)
+   rte_eth_dev_share_data_alloc();
+   rte_spinlock_unlock(&rte_eth_share_data_alloc);
+
+   /* Synchronize port creation between primary and secondary threads. */
+   rte_spinlock_lock(rte_eth_dev_ownership_lock);
 
port_id = rte_eth_dev_find_free_port();
if (port_id == RTE_MAX_ETHPORTS) {
RTE_PMD_DEBUG_TRACE("Reached maximum number of Ethernet 
ports\n");
-   return NULL;
+   goto unlock;
}
 
-   if (rte_eth_dev_data == NULL)
-   rte_eth_dev_share_data_alloc();
-
if (rte_eth_dev_allocated(name) != NULL) {
RTE_PMD_DEBUG_TRACE("Ethernet Device with name %s already 
allocated!\n",
name);
-   return NULL;
+   goto unlock;
}
 
eth_dev = eth_dev_get(port_id);
@@ -256,6 +265,8 @@ struct rte_eth_dev *
eth_dev->data->port_id = port_id;
eth_dev->data->mtu = ETHER_MTU;
 
+unlock:
+   rte_spinlock_unlock(rte_eth_dev_ownership_lock);
return eth_dev;
 }
 
@@ -268,10 +279,16 @@ struct rte_eth_dev *
 rte_eth_dev_attach_secondary(const char *name)
 {
uint16_t i;
-   struct rte_eth_dev *eth_dev;
+   struct rte_eth_dev *eth_dev = NULL;
 
+   /* Synchronize share data one time attachment between local threads. */
+   rte_spinlock_lock(&rte_eth_share_data_alloc);
if (rte_eth_dev_data == NULL)
rte_eth_dev_share_data_alloc();
+   rte_spinlock_unlock(&rte_eth_share_data_alloc);
+
+   /* Synchronize port attachment to primary port creation and release. */
+   rte_spinlock_lock(rte_eth_dev_ownership_lock);
 
for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
if (strcmp(rte_eth_dev_data[i].name, name) == 0)
@@ -281,12 +298,12 @@ struct rte_eth_dev *
RTE_PMD_DEBUG_TRACE(
"device %s is not driven by the primary process\n",
name);
-   return NULL;
+   } else {
+   eth_dev = eth_dev_get(i);
+   RTE_ASSERT(eth_dev->data->port_id == i);
}
 
-   eth_dev = eth_dev_get(i);
-   RTE_ASSERT(eth_dev->data->port_id == i);
-
+   rte_spinlock_unlock(rte_eth_dev_ownership_lock);
return eth_dev;
 }
 
-- 
1.8.3.1

[dpdk-dev] [PATCH v2 4/6] net/failsafe: free an eth port by a dedicated API

[Matan Azrad]

Call dedicated ethdev API to free port in remove time as was done in
other fail-safe places.

Signed-off-by: Matan Azrad 
---
 drivers/net/failsafe/failsafe_ether.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/failsafe/failsafe_ether.c 
b/drivers/net/failsafe/failsafe_ether.c
index 21392e5..f72f44f 100644
--- a/drivers/net/failsafe/failsafe_ether.c
+++ b/drivers/net/failsafe/failsafe_ether.c
@@ -297,7 +297,7 @@
ERROR("Bus detach failed for sub_device %u",
  SUB_ID(sdev));
} else {
-   ETH(sdev)->state = RTE_ETH_DEV_UNUSED;
+   rte_eth_dev_release_port(ETH(sdev));
}
sdev->state = DEV_PARSED;
/* fallthrough */
-- 
1.8.3.1

[dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership

[Matan Azrad]

Testpmd should not use ethdev ports which are managed by other DPDK
entities.

Set Testpmd ownership to each port which is not used by other entity and
prevent any usage of ethdev ports which are not owned by Testpmd.

Signed-off-by: Matan Azrad 
---
 app/test-pmd/cmdline.c  | 88 +++--
 app/test-pmd/cmdline_flow.c |  2 +-
 app/test-pmd/config.c   | 37 +--
 app/test-pmd/parameters.c   |  4 +--
 app/test-pmd/testpmd.c  | 63 
 app/test-pmd/testpmd.h  |  3 ++
 6 files changed, 102 insertions(+), 95 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d963..0731982 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1357,7 +1357,7 @@ struct cmd_config_speed_all {
&link_speed) < 0)
return;
 
-   RTE_ETH_FOREACH_DEV(pid) {
+   RTE_ETH_FOREACH_DEV_OWNED_BY(pid, my_owner.id) {
ports[pid].dev_conf.link_speeds = link_speed;
}
 
@@ -1851,7 +1851,7 @@ struct cmd_config_rss {
struct cmd_config_rss *res = parsed_result;
struct rte_eth_rss_conf rss_conf = { .rss_key_len = 0, };
int diag;
-   uint8_t i;
+   uint16_t pid;
 
if (!strcmp(res->value, "all"))
rss_conf.rss_hf = ETH_RSS_IP | ETH_RSS_TCP |
@@ -1885,12 +1885,12 @@ struct cmd_config_rss {
return;
}
rss_conf.rss_key = NULL;
-   for (i = 0; i < rte_eth_dev_count(); i++) {
-   diag = rte_eth_dev_rss_hash_update(i, &rss_conf);
+   RTE_ETH_FOREACH_DEV_OWNED_BY(pid, my_owner.id) {
+   diag = rte_eth_dev_rss_hash_update(pid, &rss_conf);
if (diag < 0)
printf("Configuration of RSS hash at ethernet port %d "
"failed with error (%d): %s.\n",
-   i, -diag, strerror(-diag));
+   pid, -diag, strerror(-diag));
}
 }
 
@@ -3681,10 +3681,8 @@ struct cmd_csum_result {
int hw = 0;
uint16_t mask = 0;
 
-   if (port_id_is_invalid(res->port_id, ENABLED_WARN)) {
-   printf("invalid port %d\n", res->port_id);
+   if (port_id_is_invalid(res->port_id, ENABLED_WARN))
return;
-   }
 
if (!strcmp(res->mode, "set")) {
 
@@ -4282,8 +4280,8 @@ struct cmd_gso_show_result {
 {
struct cmd_gso_show_result *res = parsed_result;
 
-   if (!rte_eth_dev_is_valid_port(res->cmd_pid)) {
-   printf("invalid port id %u\n", res->cmd_pid);
+   if (port_id_is_invalid(res->cmd_pid, ENABLED_WARN)) {
+   printf("invalid/not owned port id %u\n", res->cmd_pid);
return;
}
if (!strcmp(res->cmd_keyword, "gso")) {
@@ -5293,7 +5291,12 @@ static void cmd_create_bonded_device_parsed(void 
*parsed_result,
port_id);
 
/* Update number of ports */
-   nb_ports = rte_eth_dev_count();
+   if (rte_eth_dev_owner_set(port_id, &my_owner) != 0) {
+   printf("Error: cannot own new attached port %d\n",
+  port_id);
+   return;
+   }
+   nb_ports++;
reconfig(port_id, res->socket);
rte_eth_promiscuous_enable(port_id);
}
@@ -5402,10 +5405,8 @@ static void cmd_set_bond_mon_period_parsed(void 
*parsed_result,
struct cmd_set_bond_mon_period_result *res = parsed_result;
int ret;
 
-   if (res->port_num >= nb_ports) {
-   printf("Port id %d must be less than %d\n", res->port_num, 
nb_ports);
+   if (port_id_is_invalid(res->port_num, ENABLED_WARN))
return;
-   }
 
ret = rte_eth_bond_link_monitoring_set(res->port_num, res->period_ms);
 
@@ -5463,11 +5464,8 @@ struct cmd_set_bonding_agg_mode_policy_result {
struct cmd_set_bonding_agg_mode_policy_result *res = parsed_result;
uint8_t policy = AGG_BANDWIDTH;
 
-   if (res->port_num >= nb_ports) {
-   printf("Port id %d must be less than %d\n",
-   res->port_num, nb_ports);
+   if (port_id_is_invalid(res->port_num, ENABLED_WARN))
return;
-   }
 
if (!strcmp(res->policy, "bandwidth"))
policy = AGG_BANDWIDTH;
@@ -5726,7 +5724,7 @@ static void cmd_set_promisc_mode_parsed(void 
*parsed_result,
 
/* all ports */
if (allports) {
-   RTE_ETH_FOREACH_DEV(i) {
+   RTE_ETH_FOREACH_DEV_OWNED_BY(i, my_owner.id) {
if (enable)
rte_eth_promiscuous_enable(i);
else
@@ -5806,7 +5804,7 @@ static void cmd_set_allmulti_mode_parsed(void 
*parsed_result,
 
/* all ports */
if (allports) {
-   RTE_ETH_FOREACH

[dpdk-dev] [PATCH v2 5/6] net/failsafe: use ownership mechanism to own ports

[Matan Azrad]

Fail-safe PMD sub devices management is based on ethdev port mechanism.
So, the sub-devices management structures are exposed to other DPDK
entities which may use them in parallel to fail-safe PMD.

Use the new port ownership mechanism to avoid multiple managments of
fail-safe PMD sub-devices.

Signed-off-by: Matan Azrad 
---
 drivers/net/failsafe/failsafe.c |  7 +++
 drivers/net/failsafe/failsafe_eal.c | 10 ++
 drivers/net/failsafe/failsafe_private.h |  2 ++
 3 files changed, 19 insertions(+)

diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 6bc5aba..d413c20 100644
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -191,6 +191,13 @@
ret = failsafe_args_parse(dev, params);
if (ret)
goto free_subs;
+   ret = rte_eth_dev_owner_new(&priv->my_owner.id);
+   if (ret) {
+   ERROR("Failed to get unique owner identifier");
+   goto free_args;
+   }
+   snprintf(priv->my_owner.name, sizeof(priv->my_owner.name),
+FAILSAFE_OWNER_NAME);
ret = failsafe_eal_init(dev);
if (ret)
goto free_args;
diff --git a/drivers/net/failsafe/failsafe_eal.c 
b/drivers/net/failsafe/failsafe_eal.c
index 19d26f5..b4628fb 100644
--- a/drivers/net/failsafe/failsafe_eal.c
+++ b/drivers/net/failsafe/failsafe_eal.c
@@ -69,6 +69,16 @@
ERROR("sub_device %d init went wrong", i);
return -ENODEV;
}
+   ret = rte_eth_dev_owner_set(j, &PRIV(dev)->my_owner);
+   if (ret) {
+   /*
+* It is unexpected for a fail-safe sub-device
+* to be owned by another DPDK entity.
+*/
+   ERROR("sub_device %d owner set failed (%s)", i,
+ strerror(ret));
+   return ret;
+   }
SUB_ID(sdev) = i;
sdev->fs_dev = dev;
sdev->dev = ETH(sdev)->device;
diff --git a/drivers/net/failsafe/failsafe_private.h 
b/drivers/net/failsafe/failsafe_private.h
index d81cc3c..9936875 100644
--- a/drivers/net/failsafe/failsafe_private.h
+++ b/drivers/net/failsafe/failsafe_private.h
@@ -42,6 +42,7 @@
 #include 
 
 #define FAILSAFE_DRIVER_NAME "Fail-safe PMD"
+#define FAILSAFE_OWNER_NAME "Fail-safe"
 
 #define PMD_FAILSAFE_MAC_KVARG "mac"
 #define PMD_FAILSAFE_HOTPLUG_POLL_KVARG "hotplug_poll"
@@ -139,6 +140,7 @@ struct fs_priv {
uint32_t mac_addr_pool[FAILSAFE_MAX_ETHADDR];
/* current capabilities */
struct rte_eth_dev_info infos;
+   struct rte_eth_dev_owner my_owner; /* Unique owner. */
/*
 * Fail-safe state machine.
 * This level will be tracking state of the EAL and eth
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add devop to check removal status

[Thomas Monjalon]

19/12/2017 18:10, Matan Azrad:
> There is time between the physical removal of the device until PMDs get
> a RMV interrupt. At this time DPDK PMDs and applications still don't
> know about the removal.
> 
> Current removal detection is achieved only by registration to device RMV
> event and the notification comes asynchronously. So, there is no option
> to detect a device removal synchronously.
> Applications and other DPDK entities may want to check a device removal
> synchronously and to take an immediate decision accordingly.
> 
> Add new dev op called is_removed to allow DPDK entities to check an
> Ethernet device removal status immediately.
> 
> Signed-off-by: Matan Azrad 

Acked-by: Thomas Monjalon 

Re: [dpdk-dev] [PATCH v3 4/6] ethdev: adjust APIs removal error report

[Thomas Monjalon]

19/12/2017 18:10, Matan Azrad:
> rte_eth_dev_is_removed API was added to detect a device removal
> synchronously.
> 
> When a device removal occurs during control command execution, many
> different errors can be reported to the user.
> 
> Adjust all ethdev APIs error reports to return -EIO in case of device
> removal using rte_eth_dev_is_removed API.
> 
> Signed-off-by: Matan Azrad 

Acked-by: Thomas Monjalon 

Your git does not display the function name in @@ context.
Please update your environment. Thanks

Re: [dpdk-dev] [PATCH v2 3/6] ethdev: synchronize port allocation

[Matan Azrad]

Self-review.

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad
> Sent: Sunday, January 7, 2018 11:46 AM
> To: Thomas Monjalon ; Gaetan Rivet
> ; Jingjing Wu 
> Cc: dev@dpdk.org; Neil Horman ; Bruce
> Richardson ; Konstantin Ananyev
> 
> Subject: [dpdk-dev] [PATCH v2 3/6] ethdev: synchronize port allocation
> 
> Ethernet port allocation was not thread safe, means 2 threads which tried to
> allocate a new port at the same time might get an identical port identifier 
> and
> caused to memory overwrite.
> Actually, all the port configurations were not thread safe from ethdev point
> of view.
> 
> The port ownership mechanism added to the ethdev is a good point to
> redefine the synchronization rules in ethdev:
> 
> 1. The port allocation and port release synchronization will be
>managed by ethdev.
> 2. The port usage synchronization will be managed by the port owner.
> 3. The port ownership synchronization will be managed by ethdev.
> 
> Add port allocation synchronization to complete the new rules.
> 
> Signed-off-by: Matan Azrad 
> ---
>  config/common_base|  4 ++--
>  lib/librte_ether/rte_ethdev.c | 39 --
> -
>  2 files changed, 30 insertions(+), 13 deletions(-)
> 
> diff --git a/config/common_base b/config/common_base index
> b8ee8f9..980ae3b 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -94,7 +94,7 @@ CONFIG_RTE_MAX_MEMSEG=256
>  CONFIG_RTE_MAX_MEMZONE=2560
>  CONFIG_RTE_MAX_TAILQ=32
>  CONFIG_RTE_ENABLE_ASSERT=n
> -CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO
> +CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG
Wrong change. Will fix in the next version.
>  CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO
>  CONFIG_RTE_LOG_HISTORY=256
>  CONFIG_RTE_BACKTRACE=y
> @@ -136,7 +136,7 @@ CONFIG_RTE_LIBRTE_KVARGS=y  # Compile generic
> ethernet library  #  CONFIG_RTE_LIBRTE_ETHER=y -
> CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n
> +CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=y
Wrong change. Will fix in the next version.
>  CONFIG_RTE_MAX_ETHPORTS=32
>  CONFIG_RTE_MAX_QUEUES_PER_PORT=1024
>  CONFIG_RTE_LIBRTE_IEEE1588=n
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 0e12452..d30d61f 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -85,6 +85,9 @@
>  /* spinlock for add/remove tx callbacks */  static rte_spinlock_t
> rte_eth_tx_cb_lock = RTE_SPINLOCK_INITIALIZER;
> 
> +/* spinlock for shared data allocation */ static rte_spinlock_t
> +rte_eth_share_data_alloc = RTE_SPINLOCK_INITIALIZER;
> +
>  /* spinlock for eth device ownership management stored in shared memory
> */  static rte_spinlock_t *rte_eth_dev_ownership_lock;
> 
> @@ -234,21 +237,27 @@ struct rte_eth_dev *  rte_eth_dev_allocate(const
> char *name)  {
>   uint16_t port_id;
> - struct rte_eth_dev *eth_dev;
> + struct rte_eth_dev *eth_dev = NULL;
> +
> + /* Synchronize share data one time allocation between local threads.
> */
> + rte_spinlock_lock(&rte_eth_share_data_alloc);
> + if (rte_eth_dev_data == NULL)
> + rte_eth_dev_share_data_alloc();
> + rte_spinlock_unlock(&rte_eth_share_data_alloc);
> +
> + /* Synchronize port creation between primary and secondary
> threads. */
> + rte_spinlock_lock(rte_eth_dev_ownership_lock);
> 
>   port_id = rte_eth_dev_find_free_port();
>   if (port_id == RTE_MAX_ETHPORTS) {
>   RTE_PMD_DEBUG_TRACE("Reached maximum number of
> Ethernet ports\n");
> - return NULL;
> + goto unlock;
>   }
> 
> - if (rte_eth_dev_data == NULL)
> - rte_eth_dev_share_data_alloc();
> -
>   if (rte_eth_dev_allocated(name) != NULL) {
>   RTE_PMD_DEBUG_TRACE("Ethernet Device with name %s
> already allocated!\n",
>   name);
> - return NULL;
> + goto unlock;
>   }
> 
>   eth_dev = eth_dev_get(port_id);
> @@ -256,6 +265,8 @@ struct rte_eth_dev *
>   eth_dev->data->port_id = port_id;
>   eth_dev->data->mtu = ETHER_MTU;
> 
> +unlock:
> + rte_spinlock_unlock(rte_eth_dev_ownership_lock);
>   return eth_dev;
>  }
> 
> @@ -268,10 +279,16 @@ struct rte_eth_dev *
> rte_eth_dev_attach_secondary(const char *name)  {
>   uint16_t i;
> - struct rte_eth_dev *eth_dev;
> + struct rte_eth_dev *eth_dev = NULL;
> 
> + /* Synchronize share data one time attachment between local
> threads. */
> + rte_spinlock_lock(&rte_eth_share_data_alloc);
>   if (rte_eth_dev_data == NULL)
>   rte_eth_dev_share_data_alloc();
> + rte_spinlock_unlock(&rte_eth_share_data_alloc);
> +
> + /* Synchronize port attachment to primary port creation and release.
> */
> + rte_spinlock_lock(rte_eth_dev_ownership_lock);
> 
>   for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
>   if (strcmp(rte_eth_dev_data[i].name, name) == 0) @@ -
> 281,12 +298,12 @@ struct rte_eth_dev *
>   RTE_PMD_DEBUG_TRACE(
>

Re: [dpdk-dev] [PATCH v3 5/6] ethdev: adjust flow APIs removal error report

[Thomas Monjalon]

19/12/2017 18:10, Matan Azrad:
> rte_eth_dev_is_removed API was added to detect a device removal
> synchronously.
> 
> When a device removal occurs during flow command execution, many
> different errors can be reported to the user.
> 
> Adjust all flow APIs error reports to return -EIO in case of device
> removal using rte_eth_dev_is_removed API.
> 
> Signed-off-by: Matan Azrad 

Acked-by: Thomas Monjalon 

Re: [dpdk-dev] [PATCH v5] net/i40e: support mac loopback

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei
> Sent: Tuesday, January 2, 2018 10:47 AM
> To: Wu, Yanglong; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5] net/i40e: support mac loopback
> 
> 
> > -Original Message-
> > From: Wu, Yanglong
> > Sent: Tuesday, January 2, 2018 10:41 AM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei ; Wu, Yanglong
> > 
> > Subject: [PATCH v5] net/i40e: support mac loopback
> >
> > According to loopback mode, setup loopback link or not.
> > If loopback link is setted, packets in tx will be sent to rx directly.
> > Loopback mode can be used to support testing task
> >
> > Signed-off-by: Yanglong Wu 
> 
> Acked-by: Beilei Xing 
Applied to dpdk-next-net-intel, with minor word changes. Thanks!

/Helin

[dpdk-dev] [PATCH] net/mlx4: fix no broadcasts reception in promisc

[Moti Haimovsky]

This patch fixes the issue of mlx4 not receiving broadcast packets
when configured to work promiscuous mode.

Fixes: eacaac7bae36 ("net/mlx4: restore promisc and allmulti support")
Cc: sta...@dpdk.org

Signed-off-by: Moti Haimovsky 
---
 drivers/net/mlx4/mlx4_flow.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 69025da..ec13f5a 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -1223,9 +1223,12 @@ struct mlx4_drop {
  *
  * Various flow rules are created depending on the mode the device is in:
  *
- * 1. Promiscuous: port MAC + catch-all (VLAN filtering is ignored).
- * 2. All multicast: port MAC/VLAN + catch-all multicast.
- * 3. Otherwise: port MAC/VLAN + broadcast MAC/VLAN.
+ * 1. Promiscuous:
+ *   port MAC + broadcast + catch-all (VLAN filtering is ignored).
+ * 2. All multicast:
+ *   port MAC/VLAN + broadcast + catch-all multicast.
+ * 3. Otherwise:
+ *   port MAC/VLAN + broadcast MAC/VLAN.
  *
  * About MAC flow rules:
  *
@@ -1304,9 +1307,6 @@ struct mlx4_drop {
!priv->dev->data->promiscuous ?
&vlan_spec.tci :
NULL;
-   int broadcast =
-   !priv->dev->data->promiscuous &&
-   !priv->dev->data->all_multicast;
uint16_t vlan = 0;
struct rte_flow *flow;
unsigned int i;
@@ -1340,7 +1340,7 @@ struct mlx4_drop {
rule_vlan = NULL;
}
}
-   for (i = 0; i != RTE_DIM(priv->mac) + broadcast; ++i) {
+   for (i = 0; i != RTE_DIM(priv->mac) + 1; ++i) {
const struct ether_addr *mac;
 
/* Broadcasts are handled by an extra iteration. */
@@ -1404,7 +1404,7 @@ struct mlx4_drop {
goto next_vlan;
}
/* Take care of promiscuous and all multicast flow rules. */
-   if (!broadcast) {
+   if (priv->dev->data->promiscuous || priv->dev->data->all_multicast) {
for (flow = LIST_FIRST(&priv->flows);
 flow && flow->internal;
 flow = LIST_NEXT(flow, next)) {
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for outer IP

[Shahaf Shuler]

Wednesday, January 3, 2018 10:30 AM, Nelio Laranjeiro:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for
> outer IP
> 
> On Wed, Jan 03, 2018 at 12:06:22AM -0800, Yongseok Koh wrote:
> > Checking HW checksum offload flag for outer IP is missing. If flag is
> > set for only outer IP, this can't be set properly.
> >
> > Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for
> > tunnel packets")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Yongseok Koh 
> > Acked-by: Shahaf Shuler 
> 
> Acked-by: Nelio Laranjeiro 

Applied to next-net-mlx, thanks 

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix un-supported RSS hash fields use

[Shahaf Shuler]

Wednesday, January 3, 2018 11:14 AM,  Nelio Laranjeiro
> Subject: [dpdk-stable] [PATCH] net/mlx5: fix un-supported RSS hash fields
> use
> 
> MLX5 NIC does not support all hash fields, this patch limit by refusing
> impossible RSS combination to avoid errors.
> 
> Fixes: 2f97422e7759 ("mlx5: support RSS hash update and get")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Nelio Laranjeiro 
> Acked-by: Yongseok Koh 
> ---

Applied to next-net-mlx, thanks.

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: metering and policing CLI clean up

[Wu, Jingjing]

> -Original Message-
> From: Singh, Jasvinder
> Sent: Tuesday, November 21, 2017 12:39 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian ; Wu, Jingjing
> ; Mcnamara, John 
> Subject: [PATCH 1/3] app/testpmd: metering and policing CLI clean up
> 
> This patch updates the metering and policing CLIs as follows:
> - change name of set port meter CLI to create port meter and add meter
>   enable option, dscp table entries arguments, action mask, policer actions
>   and previous meter color option as an input color
> - set the right metering algorithm in add meter profile CLIs related to
>   srtcm(rfc2697) and trtcm(rfc2698,rfc4115)
> - change clear flag type from uint32_t to string in show meter stats CLI
> 
> Signed-off-by: Jasvinder Singh 
Acked-by: Jingjing Wu 

With minor comment: 

> +static int
> +parse_dscp_table_entries(char *str, enum rte_mtr_color *dscp_table)
> +{
> + char *token;
> + int i = 0;
> +
> + token = strtok_r(str, PARSE_DELIMITER, &str);
> + if (token == NULL)
> + return 0;
> +
> + /* Allocate memory for dscp table */
> + dscp_table = (enum rte_mtr_color *)malloc(MAX_DSCP_TABLE_ENTRIES *
> + sizeof(enum rte_mtr_color));
> +
> + while (1) {
> + if (strcmp(token, "G") == 0 ||
> + strcmp(token, "g") == 0)
> + dscp_table[i++] = RTE_MTR_GREEN;
> + else if (strcmp(token, "Y") == 0 ||
> + strcmp(token, "y") == 0)
> + dscp_table[i++] = RTE_MTR_YELLOW;
> + else if (strcmp(token, "R") == 0 ||
> + strcmp(token, "r") == 0)
> + dscp_table[i++] = RTE_MTR_RED;
> + else {
> + free(dscp_table);
> + return -1;
> + }
> + if (i == MAX_DSCP_TABLE_ENTRIES)
> + break;
Is that meaning the size dscp table must be 64, can it be less than 64?

Thanks
Jingjing

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: add CLI for metering and policing API

[Wu, Jingjing]

> -Original Message-
> From: Singh, Jasvinder
> Sent: Tuesday, November 21, 2017 12:39 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian ; Wu, Jingjing
> ; Mcnamara, John 
> Subject: [PATCH 2/3] app/testpmd: add CLI for metering and policing API
> 
> Add following CLIs to testpmd application;
> - show port metering and policing capabilities.
> - enable/disable meter of the MTR object.
> - update the MTR object dscp table entries.
> 
> Signed-off-by: Jasvinder Singh 
Acked-by: Jingjing Wu 

Re: [dpdk-dev] [PATCH v4 15/15] doc: update doc for avf driver

[Zhang, Helin]

Is there any public spec? If yes, I'd suggest to add the link to a doc for 
reference.

/Helin

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Friday, January 5, 2018 4:22 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing
> Subject: [dpdk-dev] [PATCH v4 15/15] doc: update doc for avf driver
> 
> From: Jingjing Wu 
> 
> Signed-off-by: Jingjing Wu 
> ---
>  doc/guides/nics/intel_vf.rst   | 16 ++--
>  doc/guides/rel_notes/release_18_02.rst | 16 
>  2 files changed, 30 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst index
> 1e83bf6..3adb684 100644
> --- a/doc/guides/nics/intel_vf.rst
> +++ b/doc/guides/nics/intel_vf.rst
> @@ -28,8 +28,8 @@
>  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> THE USE
>  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> 
> -I40E/IXGBE/IGB Virtual Function Driver
> -==
> +Intel Virtual Function Driver
> +=
> 
>  Supported Intel® Ethernet Controllers (see the *DPDK Release Notes* for
> details)  support the following modes of operation in a virtualized
> environment:
> @@ -93,6 +93,18 @@ and the Physical Function operates on the global
> resources on behalf of the Virt  For this out-of-band communication, an SR-
> IOV enabled NIC provides a memory buffer for each Virtual Function,  which
> is called a "Mailbox".
> 
> +Intel® Ethernet Adaptive Virtual Function
> +^
> +Adaptive Virtual Function (AVF) is a SR-IOV Virtual Function with the same
> device id (8086:1889) on different Intel Ethernet Controller.
> +AVF Driver is VF driver which supports for all future Intel devices
> +without requiring a VM update. And since this happens to be an adaptive
> +VF driver, every new drop of the VF driver would add more and more
> +advanced features that can be turned on in the VM if the underlying HW
> device supports those advanced features based on a device agnostic way
> without ever compromising on the base functionality. AVF provides generic
> hardware interface and interface between AVF driver and a compliant PF
> driver is specified.
> +
> +Intel products starting Ethernet Controller 710 Series to support Adaptive
> Virtual Function.
> +
> +The way to generate Virtual Function is like normal, and the resource of VF
> assignment depends on the NIC Infrastructure.
> +
>  The PCIE host-interface of Intel Ethernet Switch FM1 Series VF
> infrastructure
> 
> ^
> 
> diff --git a/doc/guides/rel_notes/release_18_02.rst
> b/doc/guides/rel_notes/release_18_02.rst
> index 24b67bb..0672b0e 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -41,6 +41,22 @@ New Features
>   Also, make sure to start the actual text at the margin.
>   =
> 
> +   * **Add AVF (Adaptive Virtual Function) net PMD.**
> +
> + A new net PMD has been added, which supports Intel® Ethernet
> Adaptive
> + Virtual Function (AVF) with features list below:
> +
> + * Basic Rx/Tx burst
> + * SSE vectorized Rx/Tx burst
> + * Promiscuous mode
> + * MAC/VLAN offload
> + * Checksum offload
> + * TSO offload
> + * Jumbo frame and MTU setting
> + * RSS configuration
> + * stats
> + * Rx/Tx descriptor status
> + * Link status update/event
> 
>  API Changes
>  ---
> --
> 1.9.3

Re: [dpdk-dev] [PATCH v2 04/10] app/testpmd: convert to new Ethdev Tx offloads API

[Shahaf Shuler]

Friday, January 5, 2018 8:11 PM, Maciej Czekaj:

>If the intention is to keep defaults from PMD, let's fix this...
>If not, please apply FAST_FREE flag  as in example patch v3, e.g:
>
>+rte_eth_dev_info_get(portid, &dev_info);
>+if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
>+local_port_conf.txmode.offloads |=
>+DEV_TX_OFFLOAD_MBUF_FAST_FREE;

Will take care on next version

--Shahaf

From: Maciej Czekaj [mailto:maciej.cze...@caviumnetworks.com]
Sent: Friday, January 5, 2018 8:11 PM
To: Shahaf Shuler ; ferruh.yi...@intel.com; 
jingjing...@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 04/10] app/testpmd: convert to new Ethdev Tx 
offloads API



-- Oryginal message --

Ethdev Tx offloads API has changed since:



commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")



Convert the application to use the new API.



This patch mandates the port to be stopped when configure the Tx

offloads. This is because the PMD must be aware to the offloads changes

on the device and queue configuration.



Signed-off-by: Shahaf Shuler 

---

 app/test-pmd/cmdline.c | 90 ++---

 app/test-pmd/config.c  | 55 ++-

 app/test-pmd/testpmd.c |  3 ++

 3 files changed, 124 insertions(+), 24 deletions(-)



diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c

index d8c73a9..5812583 100644

--- a/app/test-pmd/cmdline.c

+++ b/app/test-pmd/cmdline.c

@@ -3439,7 +3439,14 @@ struct cmd_tx_vlan_set_result {

 {

struct cmd_tx_vlan_set_result *res = parsed_result;



+   if (!port_is_stopped(res->port_id)) {

+   printf("Please stop port %d first\n", res->port_id);

+   return;

+   }

+

tx_vlan_set(res->port_id, res->vlan_id);

+

+   cmd_reconfig_device_queue(res->port_id, 1, 1);

 }



 cmdline_parse_token_string_t cmd_tx_vlan_set_tx_vlan =

@@ -3486,7 +3493,14 @@ struct cmd_tx_vlan_set_qinq_result {

 {

struct cmd_tx_vlan_set_qinq_result *res = parsed_result;



+   if (!port_is_stopped(res->port_id)) {

+   printf("Please stop port %d first\n", res->port_id);

+   return;

+   }

+

tx_qinq_set(res->port_id, res->vlan_id, res->vlan_id_outer);

+

+   cmd_reconfig_device_queue(res->port_id, 1, 1);

 }



 cmdline_parse_token_string_t cmd_tx_vlan_set_qinq_tx_vlan =

@@ -3592,7 +3606,14 @@ struct cmd_tx_vlan_reset_result {

 {

struct cmd_tx_vlan_reset_result *res = parsed_result;



+   if (!port_is_stopped(res->port_id)) {

+   printf("Please stop port %d first\n", res->port_id);

+   return;

+   }

+

tx_vlan_reset(res->port_id);

+

+   cmd_reconfig_device_queue(res->port_id, 1, 1);

 }



 cmdline_parse_token_string_t cmd_tx_vlan_reset_tx_vlan =

@@ -3685,11 +3706,16 @@ struct cmd_csum_result {

struct cmd_csum_result *res = parsed_result;

int hw = 0;

uint16_t mask = 0;

+   uint64_t csum_offloads = 0;



if (port_id_is_invalid(res->port_id, ENABLED_WARN)) {

printf("invalid port %d\n", res->port_id);

return;

}

+   if (!port_is_stopped(res->port_id)) {

+   printf("Please stop port %d first\n", res->port_id);

+   return;

+   }



if (!strcmp(res->mode, "set")) {



@@ -3698,22 +3724,34 @@ struct cmd_csum_result {



if (!strcmp(res->proto, "ip")) {

mask = TESTPMD_TX_OFFLOAD_IP_CKSUM;

+   csum_offloads |= DEV_TX_OFFLOAD_IPV4_CKSUM;

} else if (!strcmp(res->proto, "udp")) {

mask = TESTPMD_TX_OFFLOAD_UDP_CKSUM;

+   csum_offloads |= DEV_TX_OFFLOAD_UDP_CKSUM;

} else if (!strcmp(res->proto, "tcp")) {

mask = TESTPMD_TX_OFFLOAD_TCP_CKSUM;

+   csum_offloads |= DEV_TX_OFFLOAD_TCP_CKSUM;

} else if (!strcmp(res->proto, "sctp")) {

mask = TESTPMD_TX_OFFLOAD_SCTP_CKSUM;

+   csum_offloads |= DEV_TX_OFFLOAD_SCTP_CKSUM;

} else if (!strcmp(res->proto, "outer-ip")) {

mask = TESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM;

+   csum_offloads |= DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;

}



-   if (hw)

+   if (hw) {

ports[res->port_id].tx_ol_flags |= mask;

-   else

+   ports[res->port_id].dev_conf.txmode.offloads |=

+ csum_offloads;

+   } else {

ports[res->port_id].tx_ol_flags &= (~mask);

+   ports[res->port_id].dev_conf.txmode.offloads &=

+ (~cs

Re: [dpdk-dev] [PATCH] net/ixgbe: removed ipsec keys from private data

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty
> Sent: Wednesday, December 13, 2017 5:44 PM
> To: Nicolau, Radu; dev@dpdk.org
> Cc: Ananyev, Konstantin; Lu, Wenzhuo
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: removed ipsec keys from private
> data
> 
> On 22/11/17 11:19, Radu Nicolau wrote:
> > Signed-off-by: Radu Nicolau 
> > ---
> ...
> >
> Acked-by: Declan Doherty 
Applied into dpdk-next-net-intel, and thanks!

/Helin

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF

[Zhang, Helin]

Hi Yanglong

Please follow the comments, and get all of them well addressed.
My comments is you need to use in-reply-to when you send any
updated versions of a patch.

Regards,
Helin

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev,
> Konstantin
> Sent: Monday, November 20, 2017 6:44 PM
> To: Wu, Yanglong; dev@dpdk.org
> Cc: Wu, Yanglong
> Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF
> 
> 
> 
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu
> > Sent: Monday, November 20, 2017 2:40 AM
> > To: dev@dpdk.org
> > Cc: Wu, Yanglong 
> > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF
> >
> > L3fwd start failed on PF, for tx_q check failed.
> > That occurred when the SRIOV is active and tx_q > rx_q.
> > The tx_q is equal to nb_q_per_pool. The number of nb_q_per_pool should
> > equeal to max number of queues supported by HW not nb_rx_q.
> >
> > Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode check to
> > specific drivers)
> >
> > Signed-off-by: Yanglong Wu 
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index ae9c44421..0f0641da1 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2180,7 +2180,7 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev
> *dev, uint16_t nb_rx_q)
> > return -EINVAL;
> > }
> >
> > -   RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;
> > +   RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = 128 /
> > +RTE_ETH_DEV_SRIOV(dev).active;
> 
> Please use appropriate macros instead of constants
> (s/128/IXGBE_MAX_RX_QUEUE_NUM).
> 
> 
> > RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx = pci_dev->max_vfs *
> nb_rx_q;
> 
> 
> Shouldn't we also change that line to:
> RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx = pci_dev->max_vfs *
> RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
> ?
> 
> Konstantin
> 
> >
> > return 0;
> > --
> > 2.11.0

Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Friday, December 22, 2017 12:36 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Zhao1, Wei
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
> 
> Hi Wei:
> 
>   Please check my comment below.
>   Besides, there some line over 80 character warning need to fix
> 
> Regards
> Qi
> 
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Friday, November 24, 2017 4:43 PM
> > To: dev@dpdk.org
> > Cc: Zhao1, Wei 
> > Subject: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
> >
> > Rte_flow actually defined to include RSS, but till now, RSS is out of 
> > rte_flow.
> > This patch is to move i40e existing RSS to rte_flow.
> > This patch also enable queue region configuration using flow API for i40e.
> >
> > Signed-off-by: Wei Zhao 
> > ---
> >  drivers/net/i40e/i40e_ethdev.c |  91 +++
> > drivers/net/i40e/i40e_ethdev.h |  11 ++
> >  drivers/net/i40e/i40e_flow.c   | 336
> > +
> >  3 files changed, 438 insertions(+)

Have you addressed all the comments? Did I miss anything?
In addition, I think doc update is needed. e.g. doc/nics/i40e.rst or similar?

Thanks,
Helin

Re: [dpdk-dev] [PATCH v2] doc: add queue region feature info to release notes

[Zhang, Helin]

Hi John

Could you help to review with ACK or comments? :)

Hi Wei

'Git am' failure is as below. Please fix it on dpdk-next-net-intel sub tree. 
Thanks!

Description: [dpdk-dev,v2] doc: add queue region feature info to release notes
Applying: doc: add queue region feature info to release notes
error: patch failed: doc/guides/rel_notes/release_18_02.rst:41
error: doc/guides/rel_notes/release_18_02.rst: patch does not apply
Patch failed at 0001 doc: add queue region feature info to release notes

Regards,
Helin

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao
> Sent: Wednesday, January 3, 2018 4:13 PM
> To: dev@dpdk.org
> Cc: Mcnamara, John; Zhao1, Wei
> Subject: [dpdk-dev] [PATCH v2] doc: add queue region feature info to release
> notes
I'd suggest to use 'update release notes with queue region feature'
> 
> This patch add inforation about i40e queue region realted to release notes, it
> has been missed before in v17.11 release notes. This feature has been
> implemented in v17.11.
This patch updates the releases notes with queue region feature which was
enabled in 17.11 in silence.
> 
> Signed-off-by: Wei Zhao 
> 
> ---
> 
> v2:
> -change this information to v18.02 release notes.
> ---
>  doc/guides/rel_notes/release_18_02.rst | 17 +
>  1 file changed, 17 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_18_02.rst
> b/doc/guides/rel_notes/release_18_02.rst
> index 24b67bb..0e9f17b 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -41,6 +41,23 @@ New Features
>   Also, make sure to start the actual text at the margin.
>   =
> 
> +* **Added the i40e ethernet driver to support queue region feature.**
> +
> +  This feature enable queue regions configuration for RSS in PF,  so
> + that different traffic classes or different packet  classification
> + types can be separated to different queues in  different queue
> + regions. This feature has been implemented in v17.11.
> +
> +* **Added the testpmd app to support queue region configuration with
> +CLI.**
> +
> +  This patch add a API configuration of queue region in rss with command
> line.
> +  It can parse the parameters of region index, queue number,  queue
> + start index, user priority, traffic classes and so on.
> +  According to commands from command line, it will call i40e  private
> + API and start the process of set or flush queue region  configure. As
> + this feature is specific for i40e, so private API  will be used. Aslo
> + add a document for these new commands.
> +  This feature has been implemented in v17.11.
> 
>  API Changes
>  ---
> --
> 2.9.3

Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags

[Thomas Monjalon]

07/01/2018 07:32, Shahaf Shuler:
> Saturday, January 6, 2018 12:22 PM, Andrew Rybchenko:
> 
> [..]
> 
> > >   #define ETH_RSS_PORT   (1ULL << RTE_ETH_FLOW_PORT)
> > > +/** Enable RSS offload on VXLAN packets */
> > >   #define ETH_RSS_VXLAN  (1ULL << RTE_ETH_FLOW_VXLAN)
> > > +/** Enable RSS offload on GENEVE packets */
> > >   #define ETH_RSS_GENEVE (1ULL << RTE_ETH_FLOW_GENEVE)
> > > +/** Enable RSS offload on NVGRE packets */
> > >   #define ETH_RSS_NVGRE  (1ULL << RTE_ETH_FLOW_NVGRE)
> > >
> > >   #define ETH_RSS_IP ( \
> > 
> > These comments just decode the define name and not that useful. What
> > would be really useful here is specification of which fields of the packet
> > headers are used to calculate hash especially in the case of tunnels.
> 
> +1.
> 
> Also maybe some more clarifications, for example:
> 1. What is the expected behavior when, for example, setting the 
> ETH_RSS_IPV6_EX and regular IPv6 packet arrives? is RSS apply on it? 
> 2. What is the expected behavior from the PMD when not supporting one of the 
> RSS types? 
>  For example most of the DPDK examples uses ETH_RSS_IP [1], however very 
> few devices actually supports each and every RSS type.
>  Assuming such configuration returns with no error, what should 
> application expect when unsupported packet type arrives. 
> 
> #define ETH_RSS_IP ( \
> ETH_RSS_IPV4 | \  
> ETH_RSS_FRAG_IPV4 | \ 
> ETH_RSS_NONFRAG_IPV4_OTHER | \
> ETH_RSS_IPV6 | \  
> ETH_RSS_FRAG_IPV6 | \ 
> ETH_RSS_NONFRAG_IPV6_OTHER | \
> ETH_RSS_IPV6_EX)  

+1
We really need a detailed documentation of the exact behaviour.

It must be at least as detailed as lib/librte_mbuf/rte_mbuf_ptype.h.
Thanks

Re: [dpdk-dev] [PATCH] maintainers: claim the maintainership of a sub tree

[Thomas Monjalon]

07/01/2018 03:26, Helin Zhang:
> +Intel Networking Drivers
> +M: Helin Zhang 
> +T: git://dpdk.org/next/dpdk-next-net-intel

I think you should just add the T: line in every section
instead of creating a new overlapping section.
Thanks

> +F: drivers/net/e1000
> +F: drivers/net/ixgbe
> +F: drivers/net/i40e
> +F: drivers/net/fm10k
> +F: doc/guides/nics/ixgbe.rst
> +F: doc/guides/nics/i40e.rst
> +F: doc/guides/nics/fm10k.rst
> +F: doc/guides/nics/intel_vf.rst

[dpdk-dev] [PATCH v3] eal/x86: get hypervisor name

[Thomas Monjalon]

The CPUID instruction is caught by hypervisor which can return
a flag indicating one is running, and its name.

Suggested-by: Stephen Hemminger 
Signed-off-by: Thomas Monjalon 
Acked-by: Jerin Jacob 
---
v3 changes:
- better CPUID flag description
v2 changes:
- remove C99 style declaration
- move code in rte_hypervisor.* files
- add a function to get the name string
---
 lib/librte_eal/bsdapp/eal/Makefile |  2 ++
 lib/librte_eal/common/Makefile |  2 +-
 lib/librte_eal/common/arch/arm/rte_hypervisor.c| 11 ++
 lib/librte_eal/common/arch/ppc_64/rte_hypervisor.c | 11 ++
 lib/librte_eal/common/arch/x86/rte_cpuflags.c  | 11 ++
 lib/librte_eal/common/arch/x86/rte_cpuid.h | 19 ++
 lib/librte_eal/common/arch/x86/rte_hypervisor.c| 40 ++
 lib/librte_eal/common/eal_common_hypervisor.c  | 22 
 .../common/include/arch/x86/rte_cpuflags.h |  1 +
 lib/librte_eal/common/include/rte_hypervisor.h | 33 ++
 lib/librte_eal/linuxapp/eal/Makefile   |  2 ++
 lib/librte_eal/rte_eal_version.map | 10 +-
 12 files changed, 153 insertions(+), 11 deletions(-)
 create mode 100644 lib/librte_eal/common/arch/arm/rte_hypervisor.c
 create mode 100644 lib/librte_eal/common/arch/ppc_64/rte_hypervisor.c
 create mode 100644 lib/librte_eal/common/arch/x86/rte_cpuid.h
 create mode 100644 lib/librte_eal/common/arch/x86/rte_hypervisor.c
 create mode 100644 lib/librte_eal/common/eal_common_hypervisor.c
 create mode 100644 lib/librte_eal/common/include/rte_hypervisor.h

diff --git a/lib/librte_eal/bsdapp/eal/Makefile 
b/lib/librte_eal/bsdapp/eal/Makefile
index 3c3407b78..c6940760f 100644
--- a/lib/librte_eal/bsdapp/eal/Makefile
+++ b/lib/librte_eal/bsdapp/eal/Makefile
@@ -43,6 +43,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_memory.c
 SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_tailqs.c
 SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_errno.c
 SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_cpuflags.c
+SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_hypervisor.c
 SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_string_fns.c
 SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_hexdump.c
 SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += eal_common_devargs.c
@@ -59,6 +60,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_service.c
 
 # from arch dir
 SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_cpuflags.c
+SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_hypervisor.c
 SRCS-$(CONFIG_RTE_ARCH_X86) += rte_spinlock.c
 SRCS-y += rte_cycles.c
 
diff --git a/lib/librte_eal/common/Makefile b/lib/librte_eal/common/Makefile
index f37b9d866..a0eaeed78 100644
--- a/lib/librte_eal/common/Makefile
+++ b/lib/librte_eal/common/Makefile
@@ -15,7 +15,7 @@ INC += rte_hexdump.h rte_devargs.h rte_bus.h rte_dev.h
 INC += rte_pci_dev_feature_defs.h rte_pci_dev_features.h
 INC += rte_malloc.h rte_keepalive.h rte_time.h
 INC += rte_service.h rte_service_component.h
-INC += rte_bitmap.h rte_vfio.h
+INC += rte_bitmap.h rte_vfio.h rte_hypervisor.h
 
 GENERIC_INC := rte_atomic.h rte_byteorder.h rte_cycles.h rte_prefetch.h
 GENERIC_INC += rte_spinlock.h rte_memcpy.h rte_cpuflags.h rte_rwlock.h
diff --git a/lib/librte_eal/common/arch/arm/rte_hypervisor.c 
b/lib/librte_eal/common/arch/arm/rte_hypervisor.c
new file mode 100644
index 0..3792fe2ce
--- /dev/null
+++ b/lib/librte_eal/common/arch/arm/rte_hypervisor.c
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2017 Mellanox Technologies, Ltd.
+ */
+
+#include "rte_hypervisor.h"
+
+enum rte_hypervisor
+rte_hypervisor_get(void)
+{
+   return RTE_HYPERVISOR_UNKNOWN;
+}
diff --git a/lib/librte_eal/common/arch/ppc_64/rte_hypervisor.c 
b/lib/librte_eal/common/arch/ppc_64/rte_hypervisor.c
new file mode 100644
index 0..3792fe2ce
--- /dev/null
+++ b/lib/librte_eal/common/arch/ppc_64/rte_hypervisor.c
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2017 Mellanox Technologies, Ltd.
+ */
+
+#include "rte_hypervisor.h"
+
+enum rte_hypervisor
+rte_hypervisor_get(void)
+{
+   return RTE_HYPERVISOR_UNKNOWN;
+}
diff --git a/lib/librte_eal/common/arch/x86/rte_cpuflags.c 
b/lib/librte_eal/common/arch/x86/rte_cpuflags.c
index 2df58a917..053612d6f 100644
--- a/lib/librte_eal/common/arch/x86/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/x86/rte_cpuflags.c
@@ -7,16 +7,8 @@
 #include 
 #include 
 #include 
-#include 
 
-enum cpu_register_t {
-   RTE_REG_EAX = 0,
-   RTE_REG_EBX,
-   RTE_REG_ECX,
-   RTE_REG_EDX,
-};
-
-typedef uint32_t cpuid_registers_t[4];
+#include "rte_cpuid.h"
 
 /**
  * Struct to hold a processor feature entry
@@ -63,6 +55,7 @@ const struct feature_entry rte_cpu_feature_table[] = {
FEAT_DEF(AVX, 0x0001, 0, RTE_REG_ECX, 28)
FEAT_DEF(F16C, 0x0001, 0, RTE_REG_ECX, 29)
FEAT_DEF(RDRAND, 0x0001, 0, RTE_REG_ECX, 30)
+   FEAT_DEF(

Re: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf PMD

[Lu, Wenzhuo]

Hi Stephen,

> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Saturday, January 6, 2018 4:26 AM
> To: Lu, Wenzhuo 
> Cc: dev@dpdk.org; Wu, Jingjing 
> Subject: Re: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf
> PMD
> 
> O
> > diff --git a/drivers/net/avf/base/avf_adminq.c
> > b/drivers/net/avf/base/avf_adminq.c
> > new file mode 100644
> > index 000..616e2a9
> > --- /dev/null
> > +++ b/drivers/net/avf/base/avf_adminq.c
> > @@ -0,0 +1,1010 @@
> >
> +/**
> **
> > +***
> > +
> > +Copyright (c) 2013 - 2015, Intel Corporation All rights reserved.
> 
> SPDX instead of more boilerplate.
> Copyright 2018?
> 
> > +STATIC void avf_adminq_init_regs(struct avf_hw *hw)
> 
> Why is there a STATIC macro??
> 
> ...
> 
> > +/**
> > + *  avf_config_asq_regs - configure ASQ registers
> > + *  @hw: pointer to the hardware structure
> > + *
> > + *  Configure base address and length registers for the transmit
> > +queue  **/ STATIC enum avf_status_code avf_config_asq_regs(struct
> > +avf_hw *hw) {
> > +   enum avf_status_code ret_code = AVF_SUCCESS;
> > +   u32 reg = 0;
> > +
> > +   /* Clear Head and Tail */
> > +   wr32(hw, hw->aq.asq.head, 0);
> > +   wr32(hw, hw->aq.asq.tail, 0);
> > +
> > +   /* set starting point */
> > +#ifdef INTEGRATED_VF
> > +   if (avf_is_vf(hw))
> > +   wr32(hw, hw->aq.asq.len, (hw->aq.num_asq_entries |
> > + AVF_ATQLEN1_ATQENABLE_MASK));
> > +#else
> > +   wr32(hw, hw->aq.asq.len, (hw->aq.num_asq_entries |
> > + AVF_ATQLEN1_ATQENABLE_MASK));
> > +#endif /* INTEGRATED_VF */
> 
> No ifdef please? do it in header file if you have to.
> as in:
> #ifdef INTERGRATED_VF
> #define avf_is_vf(hw) (1)
> 
> ...
> 
> 
> > +/* internal (0x00XX) commands */
> > +
> > +/* Get version (direct 0x0001) */
> > +struct avf_aqc_get_version {
> > +   __le32 rom_ver;
> > +   __le32 fw_build;
> > +   __le16 fw_major;
> > +   __le16 fw_minor;
> > +   __le16 api_major;
> > +   __le16 api_minor;
> > +};
> 
> The use of __le16 and __le32 is a Linux kernel code style, typically not used
> in DPDK userland.
> 
> Are you trying to share code here?
> 
> ...
> 
> > +/**
> > + * virtchnl_vc_validate_vf_msg
> > + * @ver: Virtchnl version info
> > + * @v_opcode: Opcode for the message
> > + * @msg: pointer to the msg buffer
> > + * @msglen: msg length
> > + *
> > + * validate msg format against struct for each opcode  */ static
> > +inline int virtchnl_vc_validate_vf_msg(struct virtchnl_version_info
> > +*ver, u32 v_opcode,
> > +   u8 *msg, u16 msglen)
> > +{
> >
> 
> This function is way to big to be an inline.
Thanks for your comments. Let me explain. This is the base code, like what's in 
ixgbe, i40e ... We have to let it be so it's much easier for us to update it 
the next time. That's why the code style is a little different. And also some 
checkpatch problem not handled. 
We have had some discussion about the copyright license here and internally. 
But unfortunately we don't achieve a conclusion internally so we have to keep 
the long license now and may change it later.

Re: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup

[Yao, Lei A]

> -Original Message-
> From: Hu, Jiayu
> Sent: Friday, January 5, 2018 2:13 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce ; Chen, Junjie J
> ; Tan, Jianfeng ;
> step...@networkplumber.org; Yigit, Ferruh ;
> Ananyev, Konstantin ; Yao, Lei A
> ; Hu, Jiayu 
> Subject: [PATCH v4 1/2] gro: code cleanup
> 
> - Remove needless check and variants
> - For better understanding, update the programmer guide and rename
>   internal functions and variants
> - For supporting tunneled gro, move common internal functions from
>   gro_tcp4.c to gro_tcp4.h
> - Comply RFC 6864 to process the IPv4 ID field
> 
> Signed-off-by: Jiayu Hu 
> Reviewed-by: Junjie Chen 
Tested-by: Lei Yao
I have tested this patch with following traffic follow:
NIC1(In kernel)-->NIC2(pmd, GRO on)-->vhost-user->virtio-net(in VM)
The Iperf test with 1 stream show that GRO VxLAN can improve the 
performance from 6 Gbps(GRO off) to 16 Gbps(GRO on).

> ---
>  .../prog_guide/generic_receive_offload_lib.rst | 246 ---
>  doc/guides/prog_guide/img/gro-key-algorithm.svg| 223
> ++
>  lib/librte_gro/gro_tcp4.c  | 339 
> +++--
>  lib/librte_gro/gro_tcp4.h  | 253 ++-
>  lib/librte_gro/rte_gro.c   | 102 +++
>  lib/librte_gro/rte_gro.h   |  92 +++---
>  6 files changed, 750 insertions(+), 505 deletions(-)
>  create mode 100644 doc/guides/prog_guide/img/gro-key-algorithm.svg
> 
> diff --git a/doc/guides/prog_guide/generic_receive_offload_lib.rst
> b/doc/guides/prog_guide/generic_receive_offload_lib.rst
> index 22e50ec..c2d7a41 100644
> --- a/doc/guides/prog_guide/generic_receive_offload_lib.rst
> +++ b/doc/guides/prog_guide/generic_receive_offload_lib.rst
> @@ -32,128 +32,162 @@ Generic Receive Offload Library
>  ===
> 
>  Generic Receive Offload (GRO) is a widely used SW-based offloading
> -technique to reduce per-packet processing overhead. It gains performance
> -by reassembling small packets into large ones. To enable more flexibility
> -to applications, DPDK implements GRO as a standalone library. Applications
> -explicitly use the GRO library to merge small packets into large ones.
> -
> -The GRO library assumes all input packets have correct checksums. In
> -addition, the GRO library doesn't re-calculate checksums for merged
> -packets. If input packets are IP fragmented, the GRO library assumes
> -they are complete packets (i.e. with L4 headers).
> -
> -Currently, the GRO library implements TCP/IPv4 packet reassembly.
> -
> -Reassembly Modes
> -
> -
> -The GRO library provides two reassembly modes: lightweight and
> -heavyweight mode. If applications want to merge packets in a simple way,
> -they can use the lightweight mode API. If applications want more
> -fine-grained controls, they can choose the heavyweight mode API.
> -
> -Lightweight Mode
> -
> -
> -The ``rte_gro_reassemble_burst()`` function is used for reassembly in
> -lightweight mode. It tries to merge N input packets at a time, where
> -N should be less than or equal to ``RTE_GRO_MAX_BURST_ITEM_NUM``.
> -
> -In each invocation, ``rte_gro_reassemble_burst()`` allocates temporary
> -reassembly tables for the desired GRO types. Note that the reassembly
> -table is a table structure used to reassemble packets and different GRO
> -types (e.g. TCP/IPv4 GRO and TCP/IPv6 GRO) have different reassembly
> table
> -structures. The ``rte_gro_reassemble_burst()`` function uses the
> reassembly
> -tables to merge the N input packets.
> -
> -For applications, performing GRO in lightweight mode is simple. They
> -just need to invoke ``rte_gro_reassemble_burst()``. Applications can get
> -GROed packets as soon as ``rte_gro_reassemble_burst()`` returns.
> -
> -Heavyweight Mode
> -
> -
> -The ``rte_gro_reassemble()`` function is used for reassembly in
> heavyweight
> -mode. Compared with the lightweight mode, performing GRO in
> heavyweight mode
> -is relatively complicated.
> -
> -Before performing GRO, applications need to create a GRO context object
> -by calling ``rte_gro_ctx_create()``. A GRO context object holds the
> -reassembly tables of desired GRO types. Note that all update/lookup
> -operations on the context object are not thread safe. So if different
> -processes or threads want to access the same context object
> simultaneously,
> -some external syncing mechanisms must be used.
> -
> -Once the GRO context is created, applications can then use the
> -``rte_gro_reassemble()`` function to merge packets. In each invocation,
> -``rte_gro_reassemble()`` tries to merge input packets with the packets
> -in the reassembly tables. If an input packet is an unsupported GRO type,
> -or other errors happen (e.g. SYN bit is set), ``rte_gro_reassemble()``
> -returns the packet to applications. Otherwise, the input packet is either
> -merged or inserted into a reassembly table.

Re: [dpdk-dev] [PATCH] maintainers: claim the maintainership of a sub tree

[Zhang, Helin]

> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, January 8, 2018 4:50 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Yigit, Ferruh
> Subject: Re: [PATCH] maintainers: claim the maintainership of a sub tree
> 
> 07/01/2018 03:26, Helin Zhang:
> > +Intel Networking Drivers
> > +M: Helin Zhang 
> > +T: git://dpdk.org/next/dpdk-next-net-intel
> 
> I think you should just add the T: line in every section instead of creating a
> new overlapping section.
> Thanks
OK, got it and agree. I will send out an updated version. Thanks!

/Helin
> 
> > +F: drivers/net/e1000
> > +F: drivers/net/ixgbe
> > +F: drivers/net/i40e
> > +F: drivers/net/fm10k
> > +F: doc/guides/nics/ixgbe.rst
> > +F: doc/guides/nics/i40e.rst
> > +F: doc/guides/nics/fm10k.rst
> > +F: doc/guides/nics/intel_vf.rst

Re: [dpdk-dev] [PATCH v2] net/i40e: exclude LLDP packet count

[Xing, Beilei]

> -Original Message-
> From: Zhang, Qi Z
> Sent: Tuesday, December 12, 2017 2:10 AM
> To: Xing, Beilei 
> Cc: dev@dpdk.org; Zhang, Qi Z 
> Subject: [PATCH v2] net/i40e: exclude LLDP packet count
> 
> When use port stats register to calculate the packet count, LLDP packets are
> counted in statistics which is not expected, the patch exclude this number
> from total number.
> 
> Fixes: 763de290cbd1 ("net/i40e: fix packet count for PF") Cc sta...@dpdk.org
> 
> Signed-off-by: Qi Zhang 

Acked-by: Beilei Xing 

Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API

[Zhao1, Wei]

Yes, I will commit a new version today.

> -Original Message-
> From: Zhang, Helin
> Sent: Sunday, January 7, 2018 11:43 PM
> To: Zhang, Qi Z ; Zhao1, Wei ;
> dev@dpdk.org
> Cc: Zhao1, Wei 
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
> 
> 
> 
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
> > Sent: Friday, December 22, 2017 12:36 PM
> > To: Zhao1, Wei; dev@dpdk.org
> > Cc: Zhao1, Wei
> > Subject: Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
> >
> > Hi Wei:
> >
> > Please check my comment below.
> > Besides, there some line over 80 character warning need to fix
> >
> > Regards
> > Qi
> >
> > > -Original Message-
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao
> > > Sent: Friday, November 24, 2017 4:43 PM
> > > To: dev@dpdk.org
> > > Cc: Zhao1, Wei 
> > > Subject: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
> > >
> > > Rte_flow actually defined to include RSS, but till now, RSS is out of
> rte_flow.
> > > This patch is to move i40e existing RSS to rte_flow.
> > > This patch also enable queue region configuration using flow API for i40e.
> > >
> > > Signed-off-by: Wei Zhao 
> > > ---
> > >  drivers/net/i40e/i40e_ethdev.c |  91 +++
> > > drivers/net/i40e/i40e_ethdev.h |  11 ++
> > >  drivers/net/i40e/i40e_flow.c   | 336
> > > +
> > >  3 files changed, 438 insertions(+)
> 
> Have you addressed all the comments? Did I miss anything?
> In addition, I think doc update is needed. e.g. doc/nics/i40e.rst or similar?
> 
> Thanks,
> Helin

Re: [dpdk-dev] [PATCH v2] doc: add queue region feature info to release notes

[Zhao1, Wei]

Hi, helin

> -Original Message-
> From: Zhang, Helin
> Sent: Sunday, January 7, 2018 11:52 PM
> To: Zhao1, Wei ; Mcnamara, John
> 
> Cc: Zhao1, Wei ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] doc: add queue region feature info to
> release notes
> 
> Hi John
> 
> Could you help to review with ACK or comments? :)
> 
> Hi Wei
> 
> 'Git am' failure is as below. Please fix it on dpdk-next-net-intel sub tree.
> Thanks!
> 

Ok, I will updated later.


> Description: [dpdk-dev,v2] doc: add queue region feature info to release
> notes
> Applying: doc: add queue region feature info to release notes
> error: patch failed: doc/guides/rel_notes/release_18_02.rst:41
> error: doc/guides/rel_notes/release_18_02.rst: patch does not apply Patch
> failed at 0001 doc: add queue region feature info to release notes
> 
> Regards,
> Helin
> 
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Wednesday, January 3, 2018 4:13 PM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John; Zhao1, Wei
> > Subject: [dpdk-dev] [PATCH v2] doc: add queue region feature info to
> > release notes
> I'd suggest to use 'update release notes with queue region feature'
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> This patch updates the releases notes with queue region feature which was
> enabled in 17.11 in silence.
> >
> > Signed-off-by: Wei Zhao 
> >
> > ---
> >
> > v2:
> > -change this information to v18.02 release notes.
> > ---
> >  doc/guides/rel_notes/release_18_02.rst | 17 +
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/release_18_02.rst
> > b/doc/guides/rel_notes/release_18_02.rst
> > index 24b67bb..0e9f17b 100644
> > --- a/doc/guides/rel_notes/release_18_02.rst
> > +++ b/doc/guides/rel_notes/release_18_02.rst
> > @@ -41,6 +41,23 @@ New Features
> >   Also, make sure to start the actual text at the margin.
> >
> =
> >
> > +* **Added the i40e ethernet driver to support queue region feature.**
> > +
> > +  This feature enable queue regions configuration for RSS in PF,  so
> > + that different traffic classes or different packet  classification
> > + types can be separated to different queues in  different queue
> > + regions. This feature has been implemented in v17.11.
> > +
> > +* **Added the testpmd app to support queue region configuration with
> > +CLI.**
> > +
> > +  This patch add a API configuration of queue region in rss with
> > + command
> > line.
> > +  It can parse the parameters of region index, queue number,  queue
> > + start index, user priority, traffic classes and so on.
> > +  According to commands from command line, it will call i40e  private
> > + API and start the process of set or flush queue region  configure.
> > + As this feature is specific for i40e, so private API  will be used.
> > + Aslo add a document for these new commands.
> > +  This feature has been implemented in v17.11.
> >
> >  API Changes
> >  ---
> > --
> > 2.9.3

Re: [dpdk-dev] [PATCH v4 02/15] net/avf: initialization of avf PMD

[Lu, Wenzhuo]

Hi Stephen,

> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Saturday, January 6, 2018 4:30 AM
> To: Lu, Wenzhuo 
> Cc: dev@dpdk.org; Wu, Jingjing 
> Subject: Re: [dpdk-dev] [PATCH v4 02/15] net/avf: initialization of avf PMD
> 
> On Fri,  5 Jan 2018 16:21:32 +0800
> Wenzhuo Lu  wrote:
> 
> > From: Jingjing Wu 
> >
> > Signed-off-by: Jingjing Wu 
> > ---
> >  config/common_base  |   5 +
> >  drivers/net/Makefile|   1 +
> >  drivers/net/avf/Makefile|  31 +++
> >  drivers/net/avf/avf.h   | 187 ++
> >  drivers/net/avf/avf_ethdev.c| 435
> 
> >  drivers/net/avf/avf_vchnl.c | 304 ++
> >  drivers/net/avf/rte_pmd_avf_version.map |   4 +
> >  mk/rte.app.mk   |   1 +
> >  8 files changed, 968 insertions(+)
> >  create mode 100644 drivers/net/avf/Makefile  create mode 100644
> > drivers/net/avf/avf.h  create mode 100644 drivers/net/avf/avf_ethdev.c
> > create mode 100644 drivers/net/avf/avf_vchnl.c  create mode 100644
> > drivers/net/avf/rte_pmd_avf_version.map
> >
> > diff --git a/config/common_base b/config/common_base index
> > e74febe..ce4d9bb 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -226,6 +226,11 @@
> CONFIG_RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE=y
> >  CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y
> >
> >  #
> > +# Compile burst-oriented AVF PMD driver #
> CONFIG_RTE_LIBRTE_AVF_PMD=n
> 
> Why is the default not 'y' ?
> Default is yse for IXGBE, EM and I40E already.
We change it to 'y' in patch 4. But you're right, we'd better setting it to 'y' 
at the beginning. Will change it with a V5.

Re: [dpdk-dev] [PATCH 1/2] eal/arm64: modify I/O device memory barriers

[Jianbo Liu]

The 12/26/2017 20:28, Yongseok Koh wrote:
> Instead of using system-wide 'dsb' instruction for IO barriers, 'dmb' is
> sufficient and could bring better performance. Using 'dmb' with Outer
> Shareable Domain option is also consistent with linux kernel.

But in kernel dsb is used for io barriers.
https://github.com/torvalds/linux/blob/master/arch/arm64/include/asm/io.h#L109

Do you consider adding dma_*mb?
https://github.com/torvalds/linux/blob/master/arch/arm64/include/asm/barrier.h#L40

>
> Cc: Thomas Speier 
>
> Signed-off-by: Yongseok Koh 
> Acked-by: Thomas Speier 
> Acked-by: Shahaf Shuler 
> ---
>  lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h 
> b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> index 0b70d6209..8dcce6054 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> @@ -58,11 +58,11 @@ extern "C" {
>
>  #define rte_smp_rmb() dmb(ishld)
>
> -#define rte_io_mb() rte_mb()
> +#define rte_io_mb() dmb(osh)
>
> -#define rte_io_wmb() rte_wmb()
> +#define rte_io_wmb() dmb(oshst)
>
> -#define rte_io_rmb() rte_rmb()
> +#define rte_io_rmb() dmb(oshld)
>
>  #ifdef __cplusplus
>  }
> --
> 2.11.0
>

--
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

Re: [dpdk-dev] [PATCH v4 15/15] doc: update doc for avf driver

[Lu, Wenzhuo]

Hi Helin,

> -Original Message-
> From: Zhang, Helin
> Sent: Sunday, January 7, 2018 11:09 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Wu, Jingjing 
> Subject: RE: [dpdk-dev] [PATCH v4 15/15] doc: update doc for avf driver
> 
> Is there any public spec? If yes, I'd suggest to add the link to a doc for
> reference.
We do have a public spec, 
https://www.intel.com/content/dam/www/public/us/en/documents/product-specifications/ethernet-adaptive-virtual-function-hardware-spec.pdf.
I'll send a V5 for it.

> 
> /Helin

[dpdk-dev] [PATCH v5] net/ixgbe: fix l3fwd start failed on

[Yanglong Wu]

L3fwd start failed on PF, for tx_q check failed.
That occurred when the SRIOV is active and tx_q > rx_q.
The tx_q is equal to nb_q_per_pool. The number of nb_q_per_pool
should equeal to max number of queues supported by HW not nb_rx_q.

Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode check to
specific drivers)

Signed-off-by: Yanglong Wu 
---
v5:
Rework according to comments
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ff19a564a..baaeee5d9 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -95,6 +95,9 @@
 /* Timer value included in XOFF frames. */
 #define IXGBE_FC_PAUSE 0x680
 
+/*Default value of Max Rx Queue*/
+#define IXGBE_MAX_RX_QUEUE_NUM 128
+
 #define IXGBE_LINK_DOWN_CHECK_TIMEOUT 4000 /* ms */
 #define IXGBE_LINK_UP_CHECK_TIMEOUT   1000 /* ms */
 #define IXGBE_VMDQ_NUM_UC_MAC 4096 /* Maximum nb. of UC MAC addr. */
@@ -2194,9 +2197,10 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev *dev, 
uint16_t nb_rx_q)
return -EINVAL;
}
 
-   RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;
-   RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx = pci_dev->max_vfs * nb_rx_q;
-
+   RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =
+   IXGBE_MAX_RX_QUEUE_NUM / RTE_ETH_DEV_SRIOV(dev).active;
+   RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =
+   pci_dev->max_vfs * RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
return 0;
 }
 
-- 
2.11.0

[dpdk-dev] [PATCH v8 1/2] net/i40e: support input set configuration

[Beilei Xing]

This patch supports getting/setting input set info for
RSS/FDIR/FDIR flexible payload.
Also add some helper functions for input set configuration.

Signed-off-by: Beilei Xing 
Acked-by: Qi Zhang 
---
 drivers/net/i40e/rte_pmd_i40e.c   | 141 ++
 drivers/net/i40e/rte_pmd_i40e.h   | 138 +
 drivers/net/i40e/rte_pmd_i40e_version.map |  10 +++
 3 files changed, 289 insertions(+)

diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
index aeb92af..1f95f91 100644
--- a/drivers/net/i40e/rte_pmd_i40e.c
+++ b/drivers/net/i40e/rte_pmd_i40e.c
@@ -2985,3 +2985,144 @@ int rte_pmd_i40e_flow_add_del_packet_template(
 
return i40e_flow_add_del_fdir_filter(dev, &filter_conf, add);
 }
+
+int
+rte_pmd_i40e_inset_get(uint16_t port, uint8_t pctype,
+  struct rte_pmd_i40e_inset *inset,
+  enum rte_pmd_i40e_inset_type inset_type)
+{
+   struct rte_eth_dev *dev;
+   struct i40e_hw *hw;
+   uint64_t inset_reg;
+   uint32_t mask_reg[2];
+   int i;
+
+   RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
+
+   dev = &rte_eth_devices[port];
+
+   if (!is_i40e_supported(dev))
+   return -ENOTSUP;
+
+   if (pctype > 63)
+   return -EINVAL;
+
+   hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   memset(inset, 0, sizeof(struct rte_pmd_i40e_inset));
+
+   switch (inset_type) {
+   case INSET_HASH:
+   /* Get input set */
+   inset_reg =
+   i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, pctype));
+   inset_reg <<= I40E_32_BIT_WIDTH;
+   inset_reg |=
+   i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, pctype));
+   /* Get field mask */
+   mask_reg[0] =
+   i40e_read_rx_ctl(hw, I40E_GLQF_HASH_MSK(0, pctype));
+   mask_reg[1] =
+   i40e_read_rx_ctl(hw, I40E_GLQF_HASH_MSK(1, pctype));
+   break;
+   case INSET_FDIR:
+   inset_reg =
+   i40e_read_rx_ctl(hw, I40E_PRTQF_FD_INSET(pctype, 1));
+   inset_reg <<= I40E_32_BIT_WIDTH;
+   inset_reg |=
+   i40e_read_rx_ctl(hw, I40E_PRTQF_FD_INSET(pctype, 0));
+   mask_reg[0] =
+   i40e_read_rx_ctl(hw, I40E_GLQF_FD_MSK(0, pctype));
+   mask_reg[1] =
+   i40e_read_rx_ctl(hw, I40E_GLQF_FD_MSK(1, pctype));
+   break;
+   case INSET_FDIR_FLX:
+   inset_reg =
+   i40e_read_rx_ctl(hw, I40E_PRTQF_FD_FLXINSET(pctype));
+   mask_reg[0] =
+   i40e_read_rx_ctl(hw, I40E_PRTQF_FD_MSK(pctype, 0));
+   mask_reg[1] =
+   i40e_read_rx_ctl(hw, I40E_PRTQF_FD_MSK(pctype, 1));
+   break;
+   default:
+   PMD_DRV_LOG(ERR, "Unsupported input set type.");
+   return -EINVAL;
+   }
+
+   inset->inset = inset_reg;
+
+   for (i = 0; i < 2; i++) {
+   inset->mask[i].field_idx = ((mask_reg[i] >> 16) & 0x3F);
+   inset->mask[i].mask = mask_reg[i] & 0x;
+   }
+
+   return 0;
+}
+
+int
+rte_pmd_i40e_inset_set(uint16_t port, uint8_t pctype,
+  struct rte_pmd_i40e_inset *inset,
+  enum rte_pmd_i40e_inset_type inset_type)
+{
+   struct rte_eth_dev *dev;
+   struct i40e_hw *hw;
+   uint64_t inset_reg;
+   uint32_t mask_reg[2];
+   int i;
+
+   RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
+
+   dev = &rte_eth_devices[port];
+
+   if (!is_i40e_supported(dev))
+   return -ENOTSUP;
+
+   if (pctype > 63)
+   return -EINVAL;
+
+   hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   /* Clear mask first */
+   for (i = 0; i < 2; i++)
+   i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype), 0);
+
+   inset_reg = inset->inset;
+   for (i = 0; i < 2; i++)
+   mask_reg[i] = (inset->mask[i].field_idx << 16) |
+   inset->mask[i].mask;
+
+   switch (inset_type) {
+   case INSET_HASH:
+   i40e_check_write_reg(hw, I40E_GLQF_HASH_INSET(0, pctype),
+(uint32_t)(inset_reg & UINT32_MAX));
+   i40e_check_write_reg(hw, I40E_GLQF_HASH_INSET(1, pctype),
+(uint32_t)((inset_reg >>
+ I40E_32_BIT_WIDTH) & UINT32_MAX));
+   for (i = 0; i < 2; i++)
+   i40e_check_write_reg(hw, I40E_GLQF_HASH_MSK(i, pctype),
+mask_reg[i]);
+   break;
+   case INSET_FDIR:
+   i40e_check_write_reg(hw, I40E_PRTQF_FD_INSET(pctype, 0),
+   

[dpdk-dev] [PATCH v8 0/2] support input set configuration

[Beilei Xing]

The patchset adds support RSS/FDIR/FDIR flexible payload input set 
configuration for some pctype.

v8 changes:
 - Add info if NIC doesn't support the function.

v7 changes:
 - Add info if NIC doesn't support the function.
 - Add doc in testpmd_funcs.rst for the new CLIs.

v6 changes:
 - Fix DPDK version for new private API.

v5 changes:
 - Add DPDK version for new private API.

v4 changes:
 - Change testpmd command token and print info.

v3 changes:
 - Add support reset RSS/FDIR/FDIR flexible payload input set for some pctype.

v2 changes:
 - Use 'static inline' to replace 'inline'.
 - Add support get status for some filed index of input set.

Beilei Xing (2):
  net/i40e: support input set configuration
  app/testpmd: add configuration for input set

 app/test-pmd/cmdline.c  | 242 
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  16 ++
 drivers/net/i40e/rte_pmd_i40e.c | 141 
 drivers/net/i40e/rte_pmd_i40e.h | 138 
 drivers/net/i40e/rte_pmd_i40e_version.map   |  10 ++
 5 files changed, 547 insertions(+)

-- 
2.5.5

[dpdk-dev] [PATCH v8 2/2] app/testpmd: add configuration for input set

[Beilei Xing]

This patch adds command to configure input set for
RSS/flow director/flow director flexible payload.

Signed-off-by: Beilei Xing 
---
 app/test-pmd/cmdline.c  | 242 
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  16 ++
 2 files changed, 258 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d963..6b74a50 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -864,6 +864,15 @@ static void cmd_help_long_parsed(void *parsed_result,
"port config (port_id) pctype mapping update"
" (pctype_id_0[,pctype_id_1]*) (flow_type_id)\n"
"Update a flow type to pctype mapping item on a 
port\n\n"
+
+   "port config (port_id) pctype (pctype_id) hash_inset|"
+   "fdir_inset|fdir_flx_inset get|set|clear field\n"
+   " (field_idx)\n"
+   "Configure RSS|FDIR|FDIR_FLX input set for some 
pctype\n\n"
+
+   "port config (port_id) pctype (pctype_id) hash_inset|"
+   "fdir_inset|fdir_flx_inset clear all"
+   "Clear RSS|FDIR|FDIR_FLX input set completely for 
some pctype\n\n"
);
}
 
@@ -14652,6 +14661,237 @@ cmdline_parse_inst_t cmd_ddp_get_list = {
},
 };
 
+/* Configure input set */
+struct cmd_cfg_input_set_result {
+   cmdline_fixed_string_t port;
+   cmdline_fixed_string_t cfg;
+   portid_t port_id;
+   cmdline_fixed_string_t pctype;
+   uint8_t pctype_id;
+   cmdline_fixed_string_t inset_type;
+   cmdline_fixed_string_t opt;
+   cmdline_fixed_string_t field;
+   uint8_t field_idx;
+};
+
+static void
+cmd_cfg_input_set_parsed(
+   void *parsed_result,
+   __attribute__((unused)) struct cmdline *cl,
+   __attribute__((unused)) void *data)
+{
+   struct cmd_cfg_input_set_result *res = parsed_result;
+#ifdef RTE_LIBRTE_I40E_PMD
+   enum rte_pmd_i40e_inset_type inset_type = INSET_NONE;
+   struct rte_pmd_i40e_inset inset;
+#endif
+   int ret = -ENOTSUP;
+
+   if (res->port_id > nb_ports) {
+   printf("Invalid port, range is [0, %d]\n", nb_ports - 1);
+   return;
+   }
+
+   if (!all_ports_stopped()) {
+   printf("Please stop all ports first\n");
+   return;
+   }
+
+#ifdef RTE_LIBRTE_I40E_PMD
+   if (!strcmp(res->inset_type, "hash_inset"))
+   inset_type = INSET_HASH;
+   else if (!strcmp(res->inset_type, "fdir_inset"))
+   inset_type = INSET_FDIR;
+   else if (!strcmp(res->inset_type, "fdir_flx_inset"))
+   inset_type = INSET_FDIR_FLX;
+   ret = rte_pmd_i40e_inset_get(res->port_id, res->pctype_id,
+&inset, inset_type);
+   if (ret) {
+   printf("Failed to get input set.\n");
+   return;
+   }
+
+   if (!strcmp(res->opt, "get")) {
+   ret = rte_pmd_i40e_inset_field_get(inset.inset,
+  res->field_idx);
+   if (ret)
+   printf("Field index %d is enabled.\n", res->field_idx);
+   else
+   printf("Field index %d is disabled.\n", res->field_idx);
+   return;
+   } else if (!strcmp(res->opt, "set"))
+   ret = rte_pmd_i40e_inset_field_set(&inset.inset,
+  res->field_idx);
+   else if (!strcmp(res->opt, "clear"))
+   ret = rte_pmd_i40e_inset_field_clear(&inset.inset,
+res->field_idx);
+   if (ret) {
+   printf("Failed to configure input set field.\n");
+   return;
+   }
+
+   ret = rte_pmd_i40e_inset_set(res->port_id, res->pctype_id,
+&inset, inset_type);
+   if (ret) {
+   printf("Failed to set input set.\n");
+   return;
+   }
+#endif
+
+   if (ret == -ENOTSUP)
+   printf("Function not supported\n");
+}
+
+cmdline_parse_token_string_t cmd_cfg_input_set_port =
+   TOKEN_STRING_INITIALIZER(struct cmd_cfg_input_set_result,
+port, "port");
+cmdline_parse_token_string_t cmd_cfg_input_set_cfg =
+   TOKEN_STRING_INITIALIZER(struct cmd_cfg_input_set_result,
+cfg, "config");
+cmdline_parse_token_num_t cmd_cfg_input_set_port_id =
+   TOKEN_NUM_INITIALIZER(struct cmd_cfg_input_set_result,
+ port_id, UINT16);
+cmdline_parse_token_string_t cmd_cfg_input_set_pctype =
+   TOKEN_STRING_INITIALIZER(struct cmd_cfg_input_set_result,
+pctype, "pctype");
+cmdline_parse_token_num_t cmd_cfg_input_set_pctype_id =
+   TOKEN_NUM_INITIALIZER(struct cm

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: add configuration for input set

[Lu, Wenzhuo]

Hi,


> -Original Message-
> From: Xing, Beilei
> Sent: Monday, January 8, 2018 11:09 AM
> To: Wu, Jingjing ; Lu, Wenzhuo
> ; Zhang, Qi Z 
> Cc: dev@dpdk.org; Chilikin, Andrey 
> Subject: [PATCH v8 2/2] app/testpmd: add configuration for input set
> 
> This patch adds command to configure input set for RSS/flow director/flow
> director flexible payload.
> 
> Signed-off-by: Beilei Xing 
Acked-by: Wenzhuo Lu 

[dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel filter fail problem

[Wei Zhao]

Add a mode type check for tunnel mode, if fdir is
in this mode, it do not need to do Sanity check for x550.

Fixes: a2ba854ec616b ("net/ixgbe: fix MAC VLAN filter fail problem")

Signed-off-by: Wei Zhao 

---

v2:
-change fix code version hash code.
---
 drivers/net/ixgbe/ixgbe_fdir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index 9281dc1..c117647 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -1277,7 +1277,8 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
 IXGBE_ATR_FLOW_TYPE_IPV6) &&
(info->mask.src_port_mask != 0 ||
 info->mask.dst_port_mask != 0) &&
-rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
+   (rule->mode != RTE_FDIR_MODE_PERFECT_MAC_VLAN &&
+rule->mode != RTE_FDIR_MODE_PERFECT_TUNNEL)) {
PMD_DRV_LOG(ERR, "By this device,"
" IPv4 is not supported without"
" L4 protocol and ports masked!");
-- 
2.9.3

[dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Wei Zhao]

This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.

Signed-off-by: Wei Zhao 

---

v2:
-change this information to v18.02 release notes.

v3:
-rework it on dpdk-next-net-intel sub tree.
---
 doc/guides/rel_notes/release_18_02.rst | 18 ++
 1 file changed, 18 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_02.rst 
b/doc/guides/rel_notes/release_18_02.rst
index 621b8f5..d7c8b68 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -47,6 +47,24 @@ New Features
   users. According to the device configuration, it will setup TX->RX loopback
   link or not.
 
+* **Added the i40e ethernet driver to support queue region feature.**
+
+  This feature enable queue regions configuration for RSS in PF,
+  so that different traffic classes or different packet
+  classification types can be separated to different queues in
+  different queue regions. This feature has been implemented in v17.11.
+
+* **Added the testpmd app to support queue region configuration with CLI.**
+
+  This patch add a API configuration of queue region in rss with command line.
+  It can parse the parameters of region index, queue number,
+  queue start index, user priority, traffic classes and so on.
+  According to commands from command line, it will call i40e
+  private API and start the process of set or flush queue region
+  configure. As this feature is specific for i40e, so private API
+  will be used. Aslo add a document for these new commands.
+  This feature has been implemented in v17.11.
+
 API Changes
 ---
 
-- 
2.9.3

Re: [dpdk-dev] [PATCH] mempool/octeontx: use smp instead of io barrier

[santosh]

On Thursday 04 January 2018 05:09 PM, Pavan Nikhilesh wrote:
> Use smp barrier instead of IO barrier when sending mbox request as the
> write has to be reflected between cores not IO devices.
>
> Signed-off-by: Pavan Nikhilesh 
> ---

Acked-by: Santosh Shukla 

[dpdk-dev] [PATCH v2] mempool/octeontx: fix improper memory barrier

[Pavan Nikhilesh]

Use smp barrier instead of IO barrier when sending mbox request as the
write has to be reflected between cores not IO devices.

Fixes: 6da9d24574db ("event/octeontx: add mailbox support")
Cc: sta...@dpdk.org

Signed-off-by: Pavan Nikhilesh 
Acked-by: Santosh Shukla 
---
 drivers/mempool/octeontx/octeontx_mbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mempool/octeontx/octeontx_mbox.c 
b/drivers/mempool/octeontx/octeontx_mbox.c
index 9525da1aa..6c6900389 100644
--- a/drivers/mempool/octeontx/octeontx_mbox.c
+++ b/drivers/mempool/octeontx/octeontx_mbox.c
@@ -128,7 +128,7 @@ mbox_send_request(struct mbox *m, struct octeontx_mbox_hdr 
*hdr,
 
/* Write the msg header */
rte_write64(new_hdr.u64, ram_mbox_hdr);
-   rte_io_wmb();
+   rte_smp_wmb();
/* Notify PF about the new msg - write to MBOX reg generates PF IRQ */
rte_write64(0, m->reg);
 }
-- 
2.14.1

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel filter fail problem

[Lu, Wenzhuo]

Hi,

> -Original Message-
> From: Zhao1, Wei
> Sent: Monday, January 8, 2018 11:36 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Zhao1, Wei
> 
> Subject: [PATCH v2] net/ixgbe: fix tunnel filter fail problem
> 
> Add a mode type check for tunnel mode, if fdir is in this mode, it do not
> need to do Sanity check for x550.
> 
> Fixes: a2ba854ec616b ("net/ixgbe: fix MAC VLAN filter fail problem")
> 
> Signed-off-by: Wei Zhao 
Acked-by: Wenzhuo Lu 

[dpdk-dev] [PATCH v5 02/14] net/avf: initialization of avf PMD

[Wenzhuo Lu]

From: Jingjing Wu 

Signed-off-by: Jingjing Wu 
---
 config/common_base  |   5 +
 drivers/net/Makefile|   1 +
 drivers/net/avf/Makefile|  31 +++
 drivers/net/avf/avf.h   | 187 ++
 drivers/net/avf/avf_ethdev.c| 435 
 drivers/net/avf/avf_vchnl.c | 304 ++
 drivers/net/avf/rte_pmd_avf_version.map |   4 +
 mk/rte.app.mk   |   1 +
 8 files changed, 968 insertions(+)
 create mode 100644 drivers/net/avf/Makefile
 create mode 100644 drivers/net/avf/avf.h
 create mode 100644 drivers/net/avf/avf_ethdev.c
 create mode 100644 drivers/net/avf/avf_vchnl.c
 create mode 100644 drivers/net/avf/rte_pmd_avf_version.map

diff --git a/config/common_base b/config/common_base
index e74febe..f333209 100644
--- a/config/common_base
+++ b/config/common_base
@@ -226,6 +226,11 @@ CONFIG_RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE=y
 CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y
 
 #
+# Compile burst-oriented AVF PMD driver
+#
+CONFIG_RTE_LIBRTE_AVF_PMD=y
+
+#
 # Compile burst-oriented Mellanox ConnectX-3 (MLX4) PMD
 #
 CONFIG_RTE_LIBRTE_MLX4_PMD=n
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 84b137f..c2fd7f5 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -10,6 +10,7 @@ endif
 
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += af_packet
 DIRS-$(CONFIG_RTE_LIBRTE_ARK_PMD) += ark
+DIRS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf
 DIRS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += avp
 DIRS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += bnx2x
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += bonding
diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile
new file mode 100644
index 000..fb520ea
--- /dev/null
+++ b/drivers/net/avf/Makefile
@@ -0,0 +1,31 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Intel Corporation
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_avf.a
+
+CFLAGS += -O3
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
+LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
+LDLIBS += -lrte_bus_pci
+
+EXPORT_MAP := rte_pmd_avf_version.map
+
+LIBABIVER := 1
+
+VPATH += $(SRCDIR)/base
+
+#
+# all source are stored in SRCS-y
+#
+SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_adminq.c
+SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_common.c
+
+SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_ethdev.c
+SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_vchnl.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/avf/avf.h b/drivers/net/avf/avf.h
new file mode 100644
index 000..4694cc5
--- /dev/null
+++ b/drivers/net/avf/avf.h
@@ -0,0 +1,187 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017 Intel Corporation
+ */
+
+#ifndef _AVF_ETHDEV_H_
+#define _AVF_ETHDEV_H_
+
+#include 
+
+#define AVF_AQ_LEN   32
+#define AVF_AQ_BUF_SZ4096
+#define AVF_RESET_WAIT_CNT   50
+#define AVF_BUF_SIZE_MIN 1024
+#define AVF_FRAME_SIZE_MAX   9728
+#define AVF_QUEUE_BASE_ADDR_UNIT 128
+
+#define AVF_MAX_NUM_QUEUES   16
+/* Vlan table size */
+#define AVF_VLAN_TB_SIZE   (4096 / (CHAR_BIT * sizeof(uint32_t)))
+
+#define AVF_NUM_MACADDR_MAX  64
+
+#define AVF_DEFAULT_RX_PTHRESH  8
+#define AVF_DEFAULT_RX_HTHRESH  8
+#define AVF_DEFAULT_RX_WTHRESH  0
+
+#define AVF_DEFAULT_RX_FREE_THRESH  32
+
+#define AVF_DEFAULT_TX_PTHRESH  32
+#define AVF_DEFAULT_TX_HTHRESH  0
+#define AVF_DEFAULT_TX_WTHRESH  0
+
+#define AVF_DEFAULT_TX_FREE_THRESH  32
+#define AVF_DEFAULT_TX_RS_THRESH 32
+
+#define AVF_BASIC_OFFLOAD_CAPS  ( \
+   VF_BASE_MODE_OFFLOADS | \
+   VIRTCHNL_VF_OFFLOAD_WB_ON_ITR | \
+   VIRTCHNL_VF_OFFLOAD_RX_POLLING)
+
+#define AVF_MISC_VEC_IDRTE_INTR_VEC_ZERO_OFFSET
+#define AVF_RX_VEC_START   RTE_INTR_VEC_RXTX_OFFSET
+
+/* Default queue interrupt throttling time in microseconds */
+#define AVF_ITR_INDEX_DEFAULT  0
+#define AVF_QUEUE_ITR_INTERVAL_DEFAULT 32 /* 32 us */
+#define AVF_QUEUE_ITR_INTERVAL_MAX 8160 /* 8160 us */
+
+/* The overhead from MTU to max frame size.
+ * Considering QinQ packet, the VLAN tag needs to be counted twice.
+ */
+#define AVF_VLAN_TAG_SIZE   4
+#define AVF_ETH_OVERHEAD \
+   (ETHER_HDR_LEN + ETHER_CRC_LEN + AVF_VLAN_TAG_SIZE * 2)
+
+struct avf_adapter;
+struct avf_rx_queue;
+struct avf_tx_queue;
+
+/* Structure that defines a VSI, associated with a adapter. */
+struct avf_vsi {
+   struct avf_adapter *adapter; /* Backreference to associated adapter */
+   uint16_t vsi_id;
+   uint16_t nb_qps; /* Number of queue pairs VSI can occupy */
+   uint16_t nb_used_qps;/* Number of queue pairs VSI uses */
+   uint16_t max_macaddrs;   /* Maximum number of MAC addresses */
+   uint16_t base_vector;
+   uint16_t msix_intr;  /* The MSIX interrupt binds to VSI */
+};
+
+/* TODO: is that correct to assume the max number to be 16 ?*/
+#de

[dpdk-dev] [PATCH v5 00/14] add new AVF PMD

[Wenzhuo Lu]

Adaptive Virtual Function (AVF) Driver is VF driver which supports for all 
future Intel devices without requiring a VM update.
It promises the basic high speed connectivity. And since this happens to be an 
adaptive VF driver, every new drop of the VF driver would add more and more 
advanced features that can be turned on in the VM if the underlying HW device 
supports those advanced features. Most importantly in a device agnostic way 
without ever compromising on the base functionality. All the AVF's interface 
need to follow AVF spec, and AVF compliant interface is supported start from 
the Intel® Ethernet Controller 710 Series.

This patch set adds AVF PMD supporting.
 - Device initialization
 - Queue setup and Device start
 - Basic Rx and Tx.
 - MAC address offload feature
 - Vlan offload feature
 - RSS offload feature
 - Vectored Rx and Tx func
 - Bulk allocate Rx func
 - Rx interrupt support
 - Statistics query

v5:
 - some slight change for the comments.
 - merge the doc update patch.

v4:
 - update the base code to the newest.

v3:
 - change the license announcement.
 - update the related document.
 - resolve the checkpatch error, warning and some check.
 - handle the comments from the community.

v2:
 - rebase to 17.11
 - add vectored Rx and Tx func
 - add bulk allocate Rx func
 - add Rx interrupt support
 - add statistics query
 - fix coding style issue
 - remove extra compile flags in Makefile
 - add doc to list avf PMD features
 - fix lut setting when rss is disabled
 - fix log init missing
 - remove rx_descriptor_done

Jingjing Wu (12):
  net/avf/base: add base code for avf PMD
  net/avf: initialization of avf PMD
  net/avf: enable queue and device
  net/avf: enable link status update
  net/avf: support stats
  net/avf: enable ops for MAC VLAN offload
  net/avf: enable ops for RSS setting
  net/avf: enable ops for MTU setting
  net/avf: enable ops to check queue info and status
  net/i40e: support AVF basic interface
  net/avf: enable sse vector Rx Tx func
  net/avf: enable Rx interrupt support

Wenzhuo Lu (2):
  net/avf: enable basic Rx Tx func
  net/avf: enable bulk allocate Rx func

 MAINTAINERS |6 +
 config/common_base  |   10 +
 doc/guides/nics/features/avf.ini|   37 +
 doc/guides/nics/features/avf_vec.ini|   37 +
 doc/guides/nics/intel_vf.rst|   20 +-
 doc/guides/rel_notes/release_18_02.rst  |   16 +
 drivers/net/Makefile|1 +
 drivers/net/avf/Makefile|   36 +
 drivers/net/avf/avf.h   |  219 +++
 drivers/net/avf/avf_ethdev.c| 1451 
 drivers/net/avf/avf_log.h   |   44 +
 drivers/net/avf/avf_rxtx.c  | 1959 +
 drivers/net/avf/avf_rxtx.h  |  260 +++
 drivers/net/avf/avf_rxtx_vec_common.h   |  210 +++
 drivers/net/avf/avf_rxtx_vec_sse.c  |  656 +++
 drivers/net/avf/avf_vchnl.c |  812 +
 drivers/net/avf/base/README |   19 +
 drivers/net/avf/base/avf_adminq.c   | 1010 +++
 drivers/net/avf/base/avf_adminq.h   |  166 ++
 drivers/net/avf/base/avf_adminq_cmd.h   | 2842 +++
 drivers/net/avf/base/avf_alloc.h|   65 +
 drivers/net/avf/base/avf_common.c   | 1845 
 drivers/net/avf/base/avf_devids.h   |   43 +
 drivers/net/avf/base/avf_hmc.h  |  245 +++
 drivers/net/avf/base/avf_lan_hmc.h  |  200 +++
 drivers/net/avf/base/avf_osdep.h|  164 ++
 drivers/net/avf/base/avf_prototype.h|  206 +++
 drivers/net/avf/base/avf_register.h |  346 
 drivers/net/avf/base/avf_status.h   |  108 ++
 drivers/net/avf/base/avf_type.h | 2024 ++
 drivers/net/avf/base/virtchnl.h |  787 +
 drivers/net/avf/rte_pmd_avf_version.map |4 +
 drivers/net/i40e/i40e_ethdev.c  |   69 +-
 drivers/net/i40e/i40e_ethdev.h  |5 +
 drivers/net/i40e/i40e_pf.c  |  140 +-
 drivers/net/i40e/i40e_pf.h  |6 +
 mk/rte.app.mk   |1 +
 37 files changed, 16042 insertions(+), 27 deletions(-)
 create mode 100644 doc/guides/nics/features/avf.ini
 create mode 100644 doc/guides/nics/features/avf_vec.ini
 create mode 100644 drivers/net/avf/Makefile
 create mode 100644 drivers/net/avf/avf.h
 create mode 100644 drivers/net/avf/avf_ethdev.c
 create mode 100644 drivers/net/avf/avf_log.h
 create mode 100644 drivers/net/avf/avf_rxtx.c
 create mode 100644 drivers/net/avf/avf_rxtx.h
 create mode 100644 drivers/net/avf/avf_rxtx_vec_common.h
 create mode 100644 drivers/net/avf/avf_rxtx_vec_sse.c
 create mode 100644 drivers/net/avf/avf_vchnl.c
 create mode 100644 drivers/net/avf/base/README
 create mode 100644 drivers/net/avf/base/avf_adminq.c
 create mode 100644 drivers/net/avf/base/avf_adminq.h
 create mode 100644 drivers/net/avf/base/avf_adminq_cmd.h
 create mode 100644 drivers/net/avf/b

[dpdk-dev] [PATCH v5 03/14] net/avf: enable queue and device

[Wenzhuo Lu]

From: Jingjing Wu 

enable device and queue setup ops like:

 - dev_configure
 - dev_start
 - dev_stop
 - dev_close
 - dev_infos_get
 - rx_queue_start
 - rx_queue_stop
 - tx_queue_start
 - tx_queue_stop
 - rx_queue_setup
 - rx_queue_release
 - tx_queue_setup
 - tx_queue_release

Signed-off-by: Jingjing Wu 
---
 drivers/net/avf/Makefile |   1 +
 drivers/net/avf/avf.h|  18 ++
 drivers/net/avf/avf_ethdev.c | 366 +
 drivers/net/avf/avf_rxtx.c   | 616 +++
 drivers/net/avf/avf_rxtx.h   | 160 +++
 drivers/net/avf/avf_vchnl.c  | 359 -
 6 files changed, 1518 insertions(+), 2 deletions(-)
 create mode 100644 drivers/net/avf/avf_rxtx.c
 create mode 100644 drivers/net/avf/avf_rxtx.h

diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile
index fb520ea..f4f7414 100644
--- a/drivers/net/avf/Makefile
+++ b/drivers/net/avf/Makefile
@@ -27,5 +27,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_common.c
 
 SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_ethdev.c
 SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_vchnl.c
+SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_rxtx.c
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/avf/avf.h b/drivers/net/avf/avf.h
index 4694cc5..22886d4 100644
--- a/drivers/net/avf/avf.h
+++ b/drivers/net/avf/avf.h
@@ -38,6 +38,13 @@
VIRTCHNL_VF_OFFLOAD_WB_ON_ITR | \
VIRTCHNL_VF_OFFLOAD_RX_POLLING)
 
+#define AVF_RSS_OFFLOAD_ALL ( \
+   ETH_RSS_FRAG_IPV4 | \
+   ETH_RSS_NONFRAG_IPV4_TCP |  \
+   ETH_RSS_NONFRAG_IPV4_UDP |  \
+   ETH_RSS_NONFRAG_IPV4_SCTP | \
+   ETH_RSS_NONFRAG_IPV4_OTHER)
+
 #define AVF_MISC_VEC_IDRTE_INTR_VEC_ZERO_OFFSET
 #define AVF_RX_VEC_START   RTE_INTR_VEC_RXTX_OFFSET
 
@@ -184,4 +191,15 @@ struct avf_cmd_info {
 int avf_check_api_version(struct avf_adapter *adapter);
 int avf_get_vf_resource(struct avf_adapter *adapter);
 void avf_handle_virtchnl_msg(struct rte_eth_dev *dev);
+int avf_enable_vlan_strip(struct avf_adapter *adapter);
+int avf_disable_vlan_strip(struct avf_adapter *adapter);
+int avf_switch_queue(struct avf_adapter *adapter, uint16_t qid,
+bool rx, bool on);
+int avf_enable_queues(struct avf_adapter *adapter);
+int avf_disable_queues(struct avf_adapter *adapter);
+int avf_configure_rss_lut(struct avf_adapter *adapter);
+int avf_configure_rss_key(struct avf_adapter *adapter);
+int avf_configure_queues(struct avf_adapter *adapter);
+int avf_config_irq_map(struct avf_adapter *adapter);
+void avf_add_del_all_mac_addr(struct avf_adapter *adapter, bool add);
 #endif /* _AVF_ETHDEV_H_ */
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 0ed6e1c..c53f00e 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -31,6 +31,14 @@
 #include "base/avf_type.h"
 
 #include "avf.h"
+#include "avf_rxtx.h"
+
+static int avf_dev_configure(struct rte_eth_dev *dev);
+static int avf_dev_start(struct rte_eth_dev *dev);
+static void avf_dev_stop(struct rte_eth_dev *dev);
+static void avf_dev_close(struct rte_eth_dev *dev);
+static void avf_dev_info_get(struct rte_eth_dev *dev,
+struct rte_eth_dev_info *dev_info);
 
 int avf_logtype_init;
 int avf_logtype_driver;
@@ -40,9 +48,366 @@
 };
 
 static const struct eth_dev_ops avf_eth_dev_ops = {
+   .dev_configure  = avf_dev_configure,
+   .dev_start  = avf_dev_start,
+   .dev_stop   = avf_dev_stop,
+   .dev_close  = avf_dev_close,
+   .dev_infos_get  = avf_dev_info_get,
+   .rx_queue_start = avf_dev_rx_queue_start,
+   .rx_queue_stop  = avf_dev_rx_queue_stop,
+   .tx_queue_start = avf_dev_tx_queue_start,
+   .tx_queue_stop  = avf_dev_tx_queue_stop,
+   .rx_queue_setup = avf_dev_rx_queue_setup,
+   .rx_queue_release   = avf_dev_rx_queue_release,
+   .tx_queue_setup = avf_dev_tx_queue_setup,
+   .tx_queue_release   = avf_dev_tx_queue_release,
 };
 
 static int
+avf_dev_configure(struct rte_eth_dev *dev)
+{
+   struct avf_adapter *ad =
+   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+   struct avf_info *vf =  AVF_DEV_PRIVATE_TO_VF(ad);
+   struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
+
+   /* Vlan stripping setting */
+   if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN) {
+   if (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
+   avf_enable_vlan_strip(ad);
+   else
+   avf_disable_vlan_strip(ad);
+   }
+   return 0;
+}
+
+static int
+avf_init_rss(struct avf_adapter *adapter)
+{
+   struct avf_info *vf =  AVF_DEV_PRIVATE_TO_VF(adapter);
+   struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(adapter);
+   struct rte_eth_rss_conf

[dpdk-dev] [PATCH v5 05/14] net/avf: enable link status update

[Wenzhuo Lu]

From: Jingjing Wu 

Signed-off-by: Jingjing Wu 
---
 doc/guides/nics/features/avf.ini |  3 +++
 drivers/net/avf/avf.h|  2 ++
 drivers/net/avf/avf_ethdev.c | 51 +++-
 drivers/net/avf/avf_vchnl.c  | 38 +-
 4 files changed, 92 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini
index 8a294e9..77e4f53 100644
--- a/doc/guides/nics/features/avf.ini
+++ b/doc/guides/nics/features/avf.ini
@@ -4,6 +4,9 @@
 ; Refer to default.ini for the full list of available PMD features.
 ;
 [Features]
+Speed capabilities   = Y
+Link status  = Y
+Link status event= Y
 Queue start/stop = Y
 Jumbo frame  = Y
 Scattered Rx = Y
diff --git a/drivers/net/avf/avf.h b/drivers/net/avf/avf.h
index 22886d4..c97b2ee 100644
--- a/drivers/net/avf/avf.h
+++ b/drivers/net/avf/avf.h
@@ -202,4 +202,6 @@ int avf_switch_queue(struct avf_adapter *adapter, uint16_t 
qid,
 int avf_configure_queues(struct avf_adapter *adapter);
 int avf_config_irq_map(struct avf_adapter *adapter);
 void avf_add_del_all_mac_addr(struct avf_adapter *adapter, bool add);
+int avf_dev_link_update(struct rte_eth_dev *dev,
+   __rte_unused int wait_to_complete);
 #endif /* _AVF_ETHDEV_H_ */
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 4480989..7f7ddf9 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -55,6 +55,7 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
.dev_close  = avf_dev_close,
.dev_infos_get  = avf_dev_info_get,
.dev_supported_ptypes_get   = avf_dev_supported_ptypes_get,
+   .link_update= avf_dev_link_update,
.rx_queue_start = avf_dev_rx_queue_start,
.rx_queue_stop  = avf_dev_rx_queue_stop,
.tx_queue_start = avf_dev_tx_queue_start,
@@ -429,6 +430,53 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
return ptypes;
 }
 
+int
+avf_dev_link_update(struct rte_eth_dev *dev,
+   __rte_unused int wait_to_complete)
+{
+   struct rte_eth_link new_link;
+   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+
+   /* Only read status info stored in VF, and the info is updated
+*  when receive LINK_CHANGE evnet from PF by Virtchnnl.
+*/
+   switch (vf->link_speed) {
+   case VIRTCHNL_LINK_SPEED_100MB:
+   new_link.link_speed = ETH_SPEED_NUM_100M;
+   break;
+   case VIRTCHNL_LINK_SPEED_1GB:
+   new_link.link_speed = ETH_SPEED_NUM_1G;
+   break;
+   case VIRTCHNL_LINK_SPEED_10GB:
+   new_link.link_speed = ETH_SPEED_NUM_10G;
+   break;
+   case VIRTCHNL_LINK_SPEED_20GB:
+   new_link.link_speed = ETH_SPEED_NUM_20G;
+   break;
+   case VIRTCHNL_LINK_SPEED_25GB:
+   new_link.link_speed = ETH_SPEED_NUM_25G;
+   break;
+   case VIRTCHNL_LINK_SPEED_40GB:
+   new_link.link_speed = ETH_SPEED_NUM_40G;
+   break;
+   default:
+   new_link.link_speed = ETH_SPEED_NUM_NONE;
+   break;
+   }
+
+   new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
+   new_link.link_status = vf->link_up ? ETH_LINK_UP :
+ETH_LINK_DOWN;
+   new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds &
+   ETH_LINK_SPEED_FIXED);
+
+   rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link,
+   *(uint64_t *)&dev->data->dev_link,
+   *(uint64_t *)&new_link);
+
+   return 0;
+}
+
 static int
 avf_check_vf_reset_done(struct avf_hw *hw)
 {
@@ -712,7 +760,8 @@ static int eth_avf_pci_remove(struct rte_pci_device 
*pci_dev)
 /* Adaptive virtual function driver struct */
 static struct rte_pci_driver rte_avf_pmd = {
.id_table = pci_id_avf_map,
-   .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_IOVA_AS_VA,
+   .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |
+RTE_PCI_DRV_IOVA_AS_VA,
.probe = eth_avf_pci_probe,
.remove = eth_avf_pci_remove,
 };
diff --git a/drivers/net/avf/avf_vchnl.c b/drivers/net/avf/avf_vchnl.c
index 55a425a..f5da601 100644
--- a/drivers/net/avf/avf_vchnl.c
+++ b/drivers/net/avf/avf_vchnl.c
@@ -133,6 +133,41 @@
return err;
 }
 
+static void
+avf_handle_pf_event_msg(struct rte_eth_dev *dev, uint8_t *msg,
+   uint16_t msglen)
+{
+   struct virtchnl_pf_event *pf_msg =
+   (struct virtchnl_pf_event *)msg;
+   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+
+   if (msglen < sizeof(struct virtchnl_pf_event)) {
+   PMD_DRV_LOG(DEBUG, "Error event");
+  

[dpdk-dev] [PATCH v5 04/14] net/avf: enable basic Rx Tx func

[Wenzhuo Lu]

Signed-off-by: Wenzhuo Lu 
---
 MAINTAINERS  |   1 +
 config/common_base   |   4 +
 doc/guides/nics/features/avf.ini |  22 ++
 drivers/net/avf/Makefile |   3 +
 drivers/net/avf/avf_ethdev.c |  36 +-
 drivers/net/avf/avf_log.h|  21 ++
 drivers/net/avf/avf_rxtx.c   | 789 ++-
 drivers/net/avf/avf_rxtx.h   |  53 +++
 8 files changed, 919 insertions(+), 10 deletions(-)
 create mode 100644 doc/guides/nics/features/avf.ini

diff --git a/MAINTAINERS b/MAINTAINERS
index 17f15b6..17067df 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -430,6 +430,7 @@ Intel avf
 M: Jingjing Wu 
 M: Wenzhuo Lu 
 F: drivers/net/avf/
+F: doc/guides/nics/features/avf*.ini
 
 Mellanox mlx4
 M: Adrien Mazarguil 
diff --git a/config/common_base b/config/common_base
index f333209..b1f1c1c 100644
--- a/config/common_base
+++ b/config/common_base
@@ -229,6 +229,10 @@ CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y
 # Compile burst-oriented AVF PMD driver
 #
 CONFIG_RTE_LIBRTE_AVF_PMD=y
+CONFIG_RTE_LIBRTE_AVF_DEBUG_TX=n
+CONFIG_RTE_LIBRTE_AVF_DEBUG_TX_FREE=n
+CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n
+CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n
 
 #
 # Compile burst-oriented Mellanox ConnectX-3 (MLX4) PMD
diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini
new file mode 100644
index 000..8a294e9
--- /dev/null
+++ b/doc/guides/nics/features/avf.ini
@@ -0,0 +1,22 @@
+;
+; Supported features of the 'avf' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Queue start/stop = Y
+Jumbo frame  = Y
+Scattered Rx = Y
+TSO  = Y
+RSS hash = Y
+CRC offload  = Y
+VLAN offload = Y
+L3 checksum offload  = Y
+L4 checksum offload  = Y
+Packet type parsing  = Y
+Multiprocess aware   = Y
+BSD nic_uio  = Y
+Linux UIO= Y
+Linux VFIO   = Y
+x86-32   = Y
+x86-64   = Y
diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile
index f4f7414..1a673fa 100644
--- a/drivers/net/avf/Makefile
+++ b/drivers/net/avf/Makefile
@@ -13,6 +13,9 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
 LDLIBS += -lrte_bus_pci
 
+# used to dump HW descriptor for debugging
+# CFLAGS += -DDEBUG_DUMP_DESC
+
 EXPORT_MAP := rte_pmd_avf_version.map
 
 LIBABIVER := 1
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index c53f00e..4480989 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -39,6 +39,7 @@
 static void avf_dev_close(struct rte_eth_dev *dev);
 static void avf_dev_info_get(struct rte_eth_dev *dev,
 struct rte_eth_dev_info *dev_info);
+static const uint32_t *avf_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
 int avf_logtype_init;
 int avf_logtype_driver;
@@ -53,6 +54,7 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
.dev_stop   = avf_dev_stop,
.dev_close  = avf_dev_close,
.dev_infos_get  = avf_dev_info_get,
+   .dev_supported_ptypes_get   = avf_dev_supported_ptypes_get,
.rx_queue_start = avf_dev_rx_queue_start,
.rx_queue_stop  = avf_dev_rx_queue_stop,
.tx_queue_start = avf_dev_tx_queue_start,
@@ -204,9 +206,12 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
if (ret != AVF_SUCCESS)
break;
}
-   /* TODO: set rx/tx function to vector/scatter/single-segment
+   /* set rx/tx function to vector/scatter/single-segment
 * according to parameters
 */
+   avf_set_rx_function(dev);
+   avf_set_tx_function(dev);
+
return ret;
 }
 
@@ -407,6 +412,23 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
};
 }
 
+static const uint32_t *
+avf_dev_supported_ptypes_get(struct rte_eth_dev *dev)
+{
+   static const uint32_t ptypes[] = {
+   RTE_PTYPE_L2_ETHER,
+   RTE_PTYPE_L3_IPV4_EXT_UNKNOWN,
+   RTE_PTYPE_L4_FRAG,
+   RTE_PTYPE_L4_ICMP,
+   RTE_PTYPE_L4_NONFRAG,
+   RTE_PTYPE_L4_SCTP,
+   RTE_PTYPE_L4_TCP,
+   RTE_PTYPE_L4_UDP,
+   RTE_PTYPE_UNKNOWN
+   };
+   return ptypes;
+}
+
 static int
 avf_check_vf_reset_done(struct avf_hw *hw)
 {
@@ -556,7 +578,19 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
 
/* assign ops func pointer */
eth_dev->dev_ops = &avf_eth_dev_ops;
+   eth_dev->rx_pkt_burst = &avf_recv_pkts;
+   eth_dev->tx_pkt_burst = &avf_xmit_pkts;
+   eth_dev->tx_pkt_prepare = &avf_prep_pkts;
 
+   /* For secondary processes, we don't initialise any further as primary
+* has already done this work. Only check if we need a different RX
+* and T

[dpdk-dev] [PATCH v5 08/14] net/avf: enable ops for RSS setting

[Wenzhuo Lu]

From: Jingjing Wu 

Signed-off-by: Jingjing Wu 
---
 doc/guides/nics/features/avf.ini |   2 +
 drivers/net/avf/avf_ethdev.c | 142 +++
 2 files changed, 144 insertions(+)

diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini
index 1dd6114..61527d7 100644
--- a/doc/guides/nics/features/avf.ini
+++ b/doc/guides/nics/features/avf.ini
@@ -16,6 +16,8 @@ Allmulticast mode= Y
 Unicast MAC filter   = Y
 Multicast MAC filter = Y
 RSS hash = Y
+RSS key update   = Y
+RSS reta update  = Y
 VLAN filter  = Y
 CRC offload  = Y
 VLAN offload = Y
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 1ea6ec6..5a800ff 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -54,6 +54,16 @@ static int avf_dev_add_mac_addr(struct rte_eth_dev *dev,
 static int avf_dev_vlan_filter_set(struct rte_eth_dev *dev,
   uint16_t vlan_id, int on);
 static int avf_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask);
+static int avf_dev_rss_reta_update(struct rte_eth_dev *dev,
+  struct rte_eth_rss_reta_entry64 *reta_conf,
+  uint16_t reta_size);
+static int avf_dev_rss_reta_query(struct rte_eth_dev *dev,
+ struct rte_eth_rss_reta_entry64 *reta_conf,
+ uint16_t reta_size);
+static int avf_dev_rss_hash_update(struct rte_eth_dev *dev,
+  struct rte_eth_rss_conf *rss_conf);
+static int avf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
+struct rte_eth_rss_conf *rss_conf);
 static void avf_dev_set_default_mac_addr(struct rte_eth_dev *dev,
 struct ether_addr *mac_addr);
 
@@ -90,6 +100,10 @@ static void avf_dev_set_default_mac_addr(struct rte_eth_dev 
*dev,
.tx_queue_setup = avf_dev_tx_queue_setup,
.tx_queue_release   = avf_dev_tx_queue_release,
.mac_addr_set   = avf_dev_set_default_mac_addr,
+   .reta_update= avf_dev_rss_reta_update,
+   .reta_query = avf_dev_rss_reta_query,
+   .rss_hash_update= avf_dev_rss_hash_update,
+   .rss_hash_conf_get  = avf_dev_rss_hash_conf_get,
 };
 
 static int
@@ -654,6 +668,134 @@ static void avf_dev_set_default_mac_addr(struct 
rte_eth_dev *dev,
return 0;
 }
 
+static int
+avf_dev_rss_reta_update(struct rte_eth_dev *dev,
+   struct rte_eth_rss_reta_entry64 *reta_conf,
+   uint16_t reta_size)
+{
+   struct avf_adapter *adapter =
+   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(adapter);
+   uint8_t *lut;
+   uint16_t i, idx, shift;
+   int ret;
+
+   if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF))
+   return -ENOTSUP;
+
+   if (reta_size != vf->vf_res->rss_lut_size) {
+   PMD_DRV_LOG(ERR, "The size of hash lookup table configured "
+   "(%d) doesn't match the number of hardware can "
+   "support (%d)", reta_size, vf->vf_res->rss_lut_size);
+   return -EINVAL;
+   }
+
+   lut = rte_zmalloc("rss_lut", reta_size, 0);
+   if (!lut) {
+   PMD_DRV_LOG(ERR, "No memory can be allocated");
+   return -ENOMEM;
+   }
+   /* store the old lut table temporarily */
+   rte_memcpy(lut, vf->rss_lut, reta_size);
+
+   for (i = 0; i < reta_size; i++) {
+   idx = i / RTE_RETA_GROUP_SIZE;
+   shift = i % RTE_RETA_GROUP_SIZE;
+   if (reta_conf[idx].mask & (1ULL << shift))
+   lut[i] = reta_conf[idx].reta[shift];
+   }
+
+   rte_memcpy(vf->rss_lut, lut, reta_size);
+   /* send virtchnnl ops to configure rss*/
+   ret = avf_configure_rss_lut(adapter);
+   if (ret) /* revert back */
+   rte_memcpy(vf->rss_lut, lut, reta_size);
+   rte_free(lut);
+
+   return ret;
+}
+
+static int
+avf_dev_rss_reta_query(struct rte_eth_dev *dev,
+  struct rte_eth_rss_reta_entry64 *reta_conf,
+  uint16_t reta_size)
+{
+   struct avf_adapter *adapter =
+   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(adapter);
+   uint16_t i, idx, shift;
+
+   if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF))
+   return -ENOTSUP;
+
+   if (reta_size != vf->vf_res->rss_lut_size) {
+   PMD_DRV_LOG(ERR, "The size of hash lookup table configured "
+   "(%d) doesn't match the number of hardware can "
+   "support (%d)", reta_size, vf->vf_res->rss_lut_size

[dpdk-dev] [PATCH v5 06/14] net/avf: support stats

[Wenzhuo Lu]

From: Jingjing Wu 

Signed-off-by: Jingjing Wu 
---
 doc/guides/nics/features/avf.ini |  1 +
 drivers/net/avf/avf.h|  2 ++
 drivers/net/avf/avf_ethdev.c | 27 +++
 drivers/net/avf/avf_vchnl.c  | 27 +++
 4 files changed, 57 insertions(+)

diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini
index 77e4f53..af84599 100644
--- a/doc/guides/nics/features/avf.ini
+++ b/doc/guides/nics/features/avf.ini
@@ -17,6 +17,7 @@ VLAN offload = Y
 L3 checksum offload  = Y
 L4 checksum offload  = Y
 Packet type parsing  = Y
+Basic stats  = Y
 Multiprocess aware   = Y
 BSD nic_uio  = Y
 Linux UIO= Y
diff --git a/drivers/net/avf/avf.h b/drivers/net/avf/avf.h
index c97b2ee..680b117 100644
--- a/drivers/net/avf/avf.h
+++ b/drivers/net/avf/avf.h
@@ -204,4 +204,6 @@ int avf_switch_queue(struct avf_adapter *adapter, uint16_t 
qid,
 void avf_add_del_all_mac_addr(struct avf_adapter *adapter, bool add);
 int avf_dev_link_update(struct rte_eth_dev *dev,
__rte_unused int wait_to_complete);
+int avf_query_stats(struct avf_adapter *adapter,
+   struct virtchnl_eth_stats **pstats);
 #endif /* _AVF_ETHDEV_H_ */
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 7f7ddf9..bf6251b 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -40,6 +40,8 @@
 static void avf_dev_info_get(struct rte_eth_dev *dev,
 struct rte_eth_dev_info *dev_info);
 static const uint32_t *avf_dev_supported_ptypes_get(struct rte_eth_dev *dev);
+static int avf_dev_stats_get(struct rte_eth_dev *dev,
+struct rte_eth_stats *stats);
 
 int avf_logtype_init;
 int avf_logtype_driver;
@@ -56,6 +58,7 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
.dev_infos_get  = avf_dev_info_get,
.dev_supported_ptypes_get   = avf_dev_supported_ptypes_get,
.link_update= avf_dev_link_update,
+   .stats_get  = avf_dev_stats_get,
.rx_queue_start = avf_dev_rx_queue_start,
.rx_queue_stop  = avf_dev_rx_queue_stop,
.tx_queue_start = avf_dev_tx_queue_start,
@@ -478,6 +481,30 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
 }
 
 static int
+avf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
+{
+   struct avf_adapter *adapter =
+   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+   struct virtchnl_eth_stats *pstats = NULL;
+   int ret;
+
+   ret = avf_query_stats(adapter, &pstats);
+   if (ret == 0) {
+   stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
+   pstats->rx_broadcast;
+   stats->opackets = pstats->tx_broadcast + pstats->tx_multicast +
+   pstats->tx_unicast;
+   stats->imissed = pstats->rx_discards;
+   stats->oerrors = pstats->tx_errors + pstats->tx_discards;
+   stats->ibytes = pstats->rx_bytes;
+   stats->obytes = pstats->tx_bytes;
+   } else {
+   PMD_DRV_LOG(ERR, "Get statistics failed");
+   }
+   return -EIO;
+}
+
+static int
 avf_check_vf_reset_done(struct avf_hw *hw)
 {
int i, reset;
diff --git a/drivers/net/avf/avf_vchnl.c b/drivers/net/avf/avf_vchnl.c
index f5da601..e26527f 100644
--- a/drivers/net/avf/avf_vchnl.c
+++ b/drivers/net/avf/avf_vchnl.c
@@ -693,3 +693,30 @@
begin = next_begin;
} while (begin < AVF_NUM_MACADDR_MAX);
 }
+
+int
+avf_query_stats(struct avf_adapter *adapter,
+   struct virtchnl_eth_stats **pstats)
+{
+   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(adapter);
+   struct virtchnl_queue_select q_stats;
+   struct avf_cmd_info args;
+   int err;
+
+   memset(&q_stats, 0, sizeof(q_stats));
+   q_stats.vsi_id = vf->vsi_res->vsi_id;
+   args.ops = VIRTCHNL_OP_GET_STATS;
+   args.in_args = (uint8_t *)&q_stats;
+   args.in_args_size = sizeof(q_stats);
+   args.out_buffer = vf->aq_resp;
+   args.out_size = AVF_AQ_BUF_SZ;
+
+   err = avf_execute_vf_cmd(adapter, &args);
+   if (err) {
+   PMD_DRV_LOG(ERR, "fail to execute command OP_GET_STATS");
+   *pstats = NULL;
+   return err;
+   }
+   *pstats = (struct virtchnl_eth_stats *)args.out_buffer;
+   return 0;
+}
-- 
1.9.3

[dpdk-dev] [PATCH v5 07/14] net/avf: enable ops for MAC VLAN offload

[Wenzhuo Lu]

From: Jingjing Wu 

 - promiscuous_enable
 - promiscuous_disable
 - allmulticast_enable
 - allmulticast_disable
 - mac_addr_add
 - mac_addr_remove
 - mac_addr_set
 - vlan_filter_set
 - vlan_offload_set

Signed-off-by: Jingjing Wu 
---
 doc/guides/nics/features/avf.ini |   5 +
 drivers/net/avf/avf.h|   5 +
 drivers/net/avf/avf_ethdev.c | 219 +++
 drivers/net/avf/avf_vchnl.c  |  90 
 4 files changed, 319 insertions(+)

diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini
index af84599..1dd6114 100644
--- a/doc/guides/nics/features/avf.ini
+++ b/doc/guides/nics/features/avf.ini
@@ -11,7 +11,12 @@ Queue start/stop = Y
 Jumbo frame  = Y
 Scattered Rx = Y
 TSO  = Y
+Promiscuous mode = Y
+Allmulticast mode= Y
+Unicast MAC filter   = Y
+Multicast MAC filter = Y
 RSS hash = Y
+VLAN filter  = Y
 CRC offload  = Y
 VLAN offload = Y
 L3 checksum offload  = Y
diff --git a/drivers/net/avf/avf.h b/drivers/net/avf/avf.h
index 680b117..ea48310 100644
--- a/drivers/net/avf/avf.h
+++ b/drivers/net/avf/avf.h
@@ -206,4 +206,9 @@ int avf_dev_link_update(struct rte_eth_dev *dev,
__rte_unused int wait_to_complete);
 int avf_query_stats(struct avf_adapter *adapter,
struct virtchnl_eth_stats **pstats);
+int avf_config_promisc(struct avf_adapter *adapter, bool enable_unicast,
+  bool enable_multicast);
+int avf_add_del_eth_addr(struct avf_adapter *adapter,
+struct ether_addr *addr, bool add);
+int avf_add_del_vlan(struct avf_adapter *adapter, uint16_t vlanid, bool add);
 #endif /* _AVF_ETHDEV_H_ */
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index bf6251b..1ea6ec6 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -42,6 +42,20 @@ static void avf_dev_info_get(struct rte_eth_dev *dev,
 static const uint32_t *avf_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 static int avf_dev_stats_get(struct rte_eth_dev *dev,
 struct rte_eth_stats *stats);
+static void avf_dev_promiscuous_enable(struct rte_eth_dev *dev);
+static void avf_dev_promiscuous_disable(struct rte_eth_dev *dev);
+static void avf_dev_allmulticast_enable(struct rte_eth_dev *dev);
+static void avf_dev_allmulticast_disable(struct rte_eth_dev *dev);
+static int avf_dev_add_mac_addr(struct rte_eth_dev *dev,
+   struct ether_addr *addr,
+   uint32_t index,
+   uint32_t pool);
+static void avf_dev_del_mac_addr(struct rte_eth_dev *dev, uint32_t index);
+static int avf_dev_vlan_filter_set(struct rte_eth_dev *dev,
+  uint16_t vlan_id, int on);
+static int avf_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask);
+static void avf_dev_set_default_mac_addr(struct rte_eth_dev *dev,
+struct ether_addr *mac_addr);
 
 int avf_logtype_init;
 int avf_logtype_driver;
@@ -59,6 +73,14 @@ static int avf_dev_stats_get(struct rte_eth_dev *dev,
.dev_supported_ptypes_get   = avf_dev_supported_ptypes_get,
.link_update= avf_dev_link_update,
.stats_get  = avf_dev_stats_get,
+   .promiscuous_enable = avf_dev_promiscuous_enable,
+   .promiscuous_disable= avf_dev_promiscuous_disable,
+   .allmulticast_enable= avf_dev_allmulticast_enable,
+   .allmulticast_disable   = avf_dev_allmulticast_disable,
+   .mac_addr_add   = avf_dev_add_mac_addr,
+   .mac_addr_remove= avf_dev_del_mac_addr,
+   .vlan_filter_set= avf_dev_vlan_filter_set,
+   .vlan_offload_set   = avf_dev_vlan_offload_set,
.rx_queue_start = avf_dev_rx_queue_start,
.rx_queue_stop  = avf_dev_rx_queue_stop,
.tx_queue_start = avf_dev_tx_queue_start,
@@ -67,6 +89,7 @@ static int avf_dev_stats_get(struct rte_eth_dev *dev,
.rx_queue_release   = avf_dev_rx_queue_release,
.tx_queue_setup = avf_dev_tx_queue_setup,
.tx_queue_release   = avf_dev_tx_queue_release,
+   .mac_addr_set   = avf_dev_set_default_mac_addr,
 };
 
 static int
@@ -480,6 +503,202 @@ static int avf_dev_stats_get(struct rte_eth_dev *dev,
return 0;
 }
 
+static void
+avf_dev_promiscuous_enable(struct rte_eth_dev *dev)
+{
+   struct avf_adapter *adapter =
+   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(adapter);
+   int ret;
+
+   if (vf->promisc_unicast_enabled)
+   return;
+
+   ret = avf_config_promisc(adapter, TRUE, vf->promisc_multicast_enabled);
+   if (!ret)
+   vf->promisc_unic

[dpdk-dev] [PATCH v5 09/14] net/avf: enable ops for MTU setting

[Wenzhuo Lu]

From: Jingjing Wu 

Signed-off-by: Jingjing Wu 
---
 doc/guides/nics/features/avf.ini |  1 +
 drivers/net/avf/avf_ethdev.c | 30 ++
 2 files changed, 31 insertions(+)

diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini
index 61527d7..cf1b246 100644
--- a/doc/guides/nics/features/avf.ini
+++ b/doc/guides/nics/features/avf.ini
@@ -8,6 +8,7 @@ Speed capabilities   = Y
 Link status  = Y
 Link status event= Y
 Queue start/stop = Y
+MTU update   = Y
 Jumbo frame  = Y
 Scattered Rx = Y
 TSO  = Y
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 5a800ff..e4a6f35 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -64,6 +64,7 @@ static int avf_dev_rss_hash_update(struct rte_eth_dev *dev,
   struct rte_eth_rss_conf *rss_conf);
 static int avf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 struct rte_eth_rss_conf *rss_conf);
+static int avf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
 static void avf_dev_set_default_mac_addr(struct rte_eth_dev *dev,
 struct ether_addr *mac_addr);
 
@@ -104,6 +105,7 @@ static void avf_dev_set_default_mac_addr(struct rte_eth_dev 
*dev,
.reta_query = avf_dev_rss_reta_query,
.rss_hash_update= avf_dev_rss_hash_update,
.rss_hash_conf_get  = avf_dev_rss_hash_conf_get,
+   .mtu_set= avf_dev_mtu_set,
 };
 
 static int
@@ -796,6 +798,34 @@ static void avf_dev_set_default_mac_addr(struct 
rte_eth_dev *dev,
return 0;
 }
 
+static int
+avf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
+{
+   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+   uint32_t frame_size = mtu + AVF_ETH_OVERHEAD;
+   int ret = 0;
+
+   if (mtu < ETHER_MIN_MTU || frame_size > AVF_FRAME_SIZE_MAX)
+   return -EINVAL;
+
+   /* mtu setting is forbidden if port is start */
+   if (dev->data->dev_started) {
+   PMD_DRV_LOG(ERR, "port must be stopped before configuration");
+   return -EBUSY;
+   }
+
+   if (frame_size > ETHER_MAX_LEN)
+   dev->data->dev_conf.rxmode.offloads |=
+   DEV_RX_OFFLOAD_JUMBO_FRAME;
+   else
+   dev->data->dev_conf.rxmode.offloads &=
+   ~DEV_RX_OFFLOAD_JUMBO_FRAME;
+
+   dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;
+
+   return ret;
+}
+
 static void
 avf_dev_set_default_mac_addr(struct rte_eth_dev *dev,
 struct ether_addr *mac_addr)
-- 
1.9.3

[dpdk-dev] [PATCH v5 10/14] net/avf: enable ops to check queue info and status

[Wenzhuo Lu]

From: Jingjing Wu 

 - rxq_info_get
 - txq_info_get
 - rx_queue_count
 - rx_descriptor_status
 - tx_descriptor_status

Signed-off-by: Jingjing Wu 
---
 doc/guides/nics/features/avf.ini |   2 +
 drivers/net/avf/avf_ethdev.c |   5 ++
 drivers/net/avf/avf_rxtx.c   | 120 +++
 drivers/net/avf/avf_rxtx.h   |   7 +++
 4 files changed, 134 insertions(+)

diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini
index cf1b246..da4d81b 100644
--- a/doc/guides/nics/features/avf.ini
+++ b/doc/guides/nics/features/avf.ini
@@ -25,6 +25,8 @@ VLAN offload = Y
 L3 checksum offload  = Y
 L4 checksum offload  = Y
 Packet type parsing  = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
 Basic stats  = Y
 Multiprocess aware   = Y
 BSD nic_uio  = Y
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index e4a6f35..e00bb5d 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -105,6 +105,11 @@ static void avf_dev_set_default_mac_addr(struct 
rte_eth_dev *dev,
.reta_query = avf_dev_rss_reta_query,
.rss_hash_update= avf_dev_rss_hash_update,
.rss_hash_conf_get  = avf_dev_rss_hash_conf_get,
+   .rxq_info_get   = avf_dev_rxq_info_get,
+   .txq_info_get   = avf_dev_txq_info_get,
+   .rx_queue_count = avf_dev_rxq_count,
+   .rx_descriptor_status   = avf_dev_rx_desc_status,
+   .tx_descriptor_status   = avf_dev_tx_desc_status,
.mtu_set= avf_dev_mtu_set,
 };
 
diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index baccec4..0fea8f9 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -1385,3 +1385,123 @@
dev->tx_pkt_burst = avf_xmit_pkts;
dev->tx_pkt_prepare = avf_prep_pkts;
 }
+
+void
+avf_dev_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+struct rte_eth_rxq_info *qinfo)
+{
+   struct avf_rx_queue *rxq;
+
+   rxq = dev->data->rx_queues[queue_id];
+
+   qinfo->mp = rxq->mp;
+   qinfo->scattered_rx = dev->data->scattered_rx;
+   qinfo->nb_desc = rxq->nb_rx_desc;
+
+   qinfo->conf.rx_free_thresh = rxq->rx_free_thresh;
+   qinfo->conf.rx_drop_en = TRUE;
+   qinfo->conf.rx_deferred_start = rxq->rx_deferred_start;
+}
+
+void
+avf_dev_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+struct rte_eth_txq_info *qinfo)
+{
+   struct avf_tx_queue *txq;
+
+   txq = dev->data->tx_queues[queue_id];
+
+   qinfo->nb_desc = txq->nb_tx_desc;
+
+   qinfo->conf.tx_free_thresh = txq->free_thresh;
+   qinfo->conf.tx_rs_thresh = txq->rs_thresh;
+   qinfo->conf.txq_flags = txq->txq_flags;
+   qinfo->conf.tx_deferred_start = txq->tx_deferred_start;
+}
+
+/* Get the number of used descriptors of a rx queue */
+uint32_t
+avf_dev_rxq_count(struct rte_eth_dev *dev, uint16_t queue_id)
+{
+#define AVF_RXQ_SCAN_INTERVAL 4
+   volatile union avf_rx_desc *rxdp;
+   struct avf_rx_queue *rxq;
+   uint16_t desc = 0;
+
+   rxq = dev->data->rx_queues[queue_id];
+   rxdp = &rxq->rx_ring[rxq->rx_tail];
+   while ((desc < rxq->nb_rx_desc) &&
+  ((rte_le_to_cpu_64(rxdp->wb.qword1.status_error_len) &
+AVF_RXD_QW1_STATUS_MASK) >> AVF_RXD_QW1_STATUS_SHIFT) &
+  (1 << AVF_RX_DESC_STATUS_DD_SHIFT)) {
+   /* Check the DD bit of a rx descriptor of each 4 in a group,
+* to avoid checking too frequently and downgrading performance
+* too much.
+*/
+   desc += AVF_RXQ_SCAN_INTERVAL;
+   rxdp += AVF_RXQ_SCAN_INTERVAL;
+   if (rxq->rx_tail + desc >= rxq->nb_rx_desc)
+   rxdp = &(rxq->rx_ring[rxq->rx_tail +
+   desc - rxq->nb_rx_desc]);
+   }
+
+   return desc;
+}
+
+int
+avf_dev_rx_desc_status(void *rx_queue, uint16_t offset)
+{
+   struct avf_rx_queue *rxq = rx_queue;
+   volatile uint64_t *status;
+   uint64_t mask;
+   uint32_t desc;
+
+   if (unlikely(offset >= rxq->nb_rx_desc))
+   return -EINVAL;
+
+   if (offset >= rxq->nb_rx_desc - rxq->nb_rx_hold)
+   return RTE_ETH_RX_DESC_UNAVAIL;
+
+   desc = rxq->rx_tail + offset;
+   if (desc >= rxq->nb_rx_desc)
+   desc -= rxq->nb_rx_desc;
+
+   status = &rxq->rx_ring[desc].wb.qword1.status_error_len;
+   mask = rte_le_to_cpu_64((1ULL << AVF_RX_DESC_STATUS_DD_SHIFT)
+   << AVF_RXD_QW1_STATUS_SHIFT);
+   if (*status & mask)
+   return RTE_ETH_RX_DESC_DONE;
+
+   return RTE_ETH_RX_DESC_AVAIL;
+}
+
+int
+avf_dev_tx_desc_status(void *tx_queue, uint16_t offset)
+{
+   struct avf_tx_queue *txq = tx_queue;
+   volatile uint64_t *status;
+   uint6

[dpdk-dev] [PATCH v5 12/14] net/avf: enable sse vector Rx Tx func

[Wenzhuo Lu]

From: Jingjing Wu 

Signed-off-by: Jingjing Wu 
---
 config/common_base|   1 +
 doc/guides/nics/features/avf_vec.ini  |  36 ++
 drivers/net/avf/Makefile  |   1 +
 drivers/net/avf/avf.h |   4 +
 drivers/net/avf/avf_ethdev.c  |  11 +
 drivers/net/avf/avf_rxtx.c| 172 -
 drivers/net/avf/avf_rxtx.h|  36 +-
 drivers/net/avf/avf_rxtx_vec_common.h | 210 +++
 drivers/net/avf/avf_rxtx_vec_sse.c| 656 ++
 9 files changed, 1116 insertions(+), 11 deletions(-)
 create mode 100644 doc/guides/nics/features/avf_vec.ini
 create mode 100644 drivers/net/avf/avf_rxtx_vec_common.h
 create mode 100644 drivers/net/avf/avf_rxtx_vec_sse.c

diff --git a/config/common_base b/config/common_base
index b1f1c1c..f9363ff 100644
--- a/config/common_base
+++ b/config/common_base
@@ -229,6 +229,7 @@ CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y
 # Compile burst-oriented AVF PMD driver
 #
 CONFIG_RTE_LIBRTE_AVF_PMD=y
+CONFIG_RTE_LIBRTE_AVF_INC_VECTOR=y
 CONFIG_RTE_LIBRTE_AVF_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_AVF_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n
diff --git a/doc/guides/nics/features/avf_vec.ini 
b/doc/guides/nics/features/avf_vec.ini
new file mode 100644
index 000..45dd5e5
--- /dev/null
+++ b/doc/guides/nics/features/avf_vec.ini
@@ -0,0 +1,36 @@
+;
+; Supported features of the 'avf_vec' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Speed capabilities   = Y
+Link status  = Y
+Link status event= Y
+Queue start/stop = Y
+MTU update   = Y
+Jumbo frame  = Y
+Scattered Rx = Y
+TSO  = Y
+Promiscuous mode = Y
+Allmulticast mode= Y
+Unicast MAC filter   = Y
+Multicast MAC filter = Y
+RSS hash = Y
+RSS key update   = Y
+RSS reta update  = Y
+VLAN filter  = Y
+CRC offload  = Y
+VLAN offload = P
+L3 checksum offload  = P
+L4 checksum offload  = P
+Packet type parsing  = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
+Basic stats  = Y
+Multiprocess aware   = Y
+BSD nic_uio  = Y
+Linux UIO= Y
+Linux VFIO   = Y
+x86-32   = Y
+x86-64   = Y
diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile
index 1a673fa..14fa38a 100644
--- a/drivers/net/avf/Makefile
+++ b/drivers/net/avf/Makefile
@@ -31,5 +31,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_common.c
 SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_ethdev.c
 SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_vchnl.c
 SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_rxtx.c
+SRCS-$(CONFIG_RTE_LIBRTE_AVF_INC_VECTOR) += avf_rxtx_vec_sse.c
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/avf/avf.h b/drivers/net/avf/avf.h
index ea48310..b79bc5a 100644
--- a/drivers/net/avf/avf.h
+++ b/drivers/net/avf/avf.h
@@ -119,6 +119,10 @@ struct avf_adapter {
struct avf_hw hw;
struct rte_eth_dev *eth_dev;
struct avf_info vf;
+
+   /* For vector PMD */
+   bool rx_vec_allowed;
+   bool tx_vec_allowed;
 };
 
 /* AVF_DEV_PRIVATE_TO */
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index e00bb5d..127fdb5 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -121,6 +121,17 @@ static void avf_dev_set_default_mac_addr(struct 
rte_eth_dev *dev,
struct avf_info *vf =  AVF_DEV_PRIVATE_TO_VF(ad);
struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
 
+#ifdef RTE_LIBRTE_AVF_INC_VECTOR
+   /* Initialize to TRUE. If any of Rx queues doesn't meet the
+* vector Rx/Tx preconditions, it will be reset.
+*/
+   ad->rx_vec_allowed = true;
+   ad->tx_vec_allowed = true;
+#else
+   ad->rx_vec_allowed = false;
+   ad->tx_vec_allowed = false;
+#endif
+
/* Vlan stripping setting */
if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN) {
if (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index 0fea8f9..b542532 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -92,6 +92,34 @@
return 0;
 }
 
+#ifdef RTE_LIBRTE_AVF_INC_VECTOR
+static inline bool
+check_rx_vec_allow(struct avf_rx_queue *rxq)
+{
+   if (rxq->rx_free_thresh >= AVF_VPMD_RX_MAX_BURST &&
+   rxq->nb_rx_desc % rxq->rx_free_thresh == 0) {
+   PMD_INIT_LOG(DEBUG, "Vector Rx can be enabled on this rxq.");
+   return TRUE;
+   }
+
+   PMD_INIT_LOG(DEBUG, "Vector Rx cannot be enabled on this rxq.");
+   return FALSE;
+}
+
+static inline bool
+check_tx_vec_allow(struct avf_tx_queue *txq)
+{
+   if ((txq->txq_flags & AVF_SIMPLE_FLAGS) == AVF_SIMPLE_FLAGS &&
+   txq->rs_thresh >= AVF_VPMD_TX_MAX_BURST &&
+   txq->rs_thresh <= AVF_VPMD_TX_MAX_FREE_BUF) {
+   PMD_INIT_LOG(DE

[dpdk-dev] [PATCH v5 11/14] net/i40e: support AVF basic interface

[Wenzhuo Lu]

From: Jingjing Wu 

Enable Virtchnl offload Caps negotiation and RSS_PF offload
to support AVF basic interface.

Signed-off-by: Jingjing Wu 
---
 drivers/net/i40e/i40e_ethdev.c |  69 
 drivers/net/i40e/i40e_ethdev.h |   5 ++
 drivers/net/i40e/i40e_pf.c | 140 +
 drivers/net/i40e/i40e_pf.h |   6 ++
 4 files changed, 195 insertions(+), 25 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 285d92b..10bb4eb 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3649,6 +3649,7 @@ static int i40e_dev_xstats_get_names(__rte_unused struct 
rte_eth_dev *dev,
 {
struct i40e_pf *pf = I40E_VSI_TO_PF(vsi);
struct i40e_hw *hw = I40E_VSI_TO_HW(vsi);
+   uint32_t reg;
int ret;
 
if (!lut)
@@ -3665,14 +3666,22 @@ static int i40e_dev_xstats_get_names(__rte_unused 
struct rte_eth_dev *dev,
uint32_t *lut_dw = (uint32_t *)lut;
uint16_t i, lut_size_dw = lut_size / 4;
 
-   for (i = 0; i < lut_size_dw; i++)
-   lut_dw[i] = I40E_READ_REG(hw, I40E_PFQF_HLUT(i));
+   if (vsi->type == I40E_VSI_SRIOV) {
+   for (i = 0; i <= lut_size_dw; i++) {
+   reg = I40E_VFQF_HLUT1(i, vsi->user_param);
+   lut_dw[i] = i40e_read_rx_ctl(hw, reg);
+   }
+   } else {
+   for (i = 0; i < lut_size_dw; i++)
+   lut_dw[i] = I40E_READ_REG(hw,
+ I40E_PFQF_HLUT(i));
+   }
}
 
return 0;
 }
 
-static int
+int
 i40e_set_rss_lut(struct i40e_vsi *vsi, uint8_t *lut, uint16_t lut_size)
 {
struct i40e_pf *pf;
@@ -3696,8 +3705,17 @@ static int i40e_dev_xstats_get_names(__rte_unused struct 
rte_eth_dev *dev,
uint32_t *lut_dw = (uint32_t *)lut;
uint16_t i, lut_size_dw = lut_size / 4;
 
-   for (i = 0; i < lut_size_dw; i++)
-   I40E_WRITE_REG(hw, I40E_PFQF_HLUT(i), lut_dw[i]);
+   if (vsi->type == I40E_VSI_SRIOV) {
+   for (i = 0; i < lut_size_dw; i++)
+   I40E_WRITE_REG(
+   hw,
+   I40E_VFQF_HLUT1(i, vsi->user_param),
+   lut_dw[i]);
+   } else {
+   for (i = 0; i < lut_size_dw; i++)
+   I40E_WRITE_REG(hw, I40E_PFQF_HLUT(i),
+  lut_dw[i]);
+   }
I40E_WRITE_FLUSH(hw);
}
 
@@ -6669,17 +6687,20 @@ struct i40e_vsi *
I40E_WRITE_FLUSH(hw);
 }
 
-static int
+int
 i40e_set_rss_key(struct i40e_vsi *vsi, uint8_t *key, uint8_t key_len)
 {
struct i40e_pf *pf = I40E_VSI_TO_PF(vsi);
struct i40e_hw *hw = I40E_VSI_TO_HW(vsi);
+   uint16_t key_idx = (vsi->type == I40E_VSI_SRIOV) ?
+  I40E_VFQF_HKEY_MAX_INDEX :
+  I40E_PFQF_HKEY_MAX_INDEX;
int ret = 0;
 
if (!key || key_len == 0) {
PMD_DRV_LOG(DEBUG, "No key to be configured");
return 0;
-   } else if (key_len != (I40E_PFQF_HKEY_MAX_INDEX + 1) *
+   } else if (key_len != (key_idx + 1) *
sizeof(uint32_t)) {
PMD_DRV_LOG(ERR, "Invalid key length %u", key_len);
return -EINVAL;
@@ -6696,8 +6717,18 @@ struct i40e_vsi *
uint32_t *hash_key = (uint32_t *)key;
uint16_t i;
 
-   for (i = 0; i <= I40E_PFQF_HKEY_MAX_INDEX; i++)
-   i40e_write_rx_ctl(hw, I40E_PFQF_HKEY(i), hash_key[i]);
+   if (vsi->type == I40E_VSI_SRIOV) {
+   for (i = 0; i <= I40E_VFQF_HKEY_MAX_INDEX; i++)
+   I40E_WRITE_REG(
+   hw,
+   I40E_VFQF_HKEY1(i, vsi->user_param),
+   hash_key[i]);
+
+   } else {
+   for (i = 0; i <= I40E_PFQF_HKEY_MAX_INDEX; i++)
+   I40E_WRITE_REG(hw, I40E_PFQF_HKEY(i),
+  hash_key[i]);
+   }
I40E_WRITE_FLUSH(hw);
}
 
@@ -6709,6 +6740,7 @@ struct i40e_vsi *
 {
struct i40e_pf *pf = I40E_VSI_TO_PF(vsi);
struct i40e_hw *hw = I40E_VSI_TO_HW(vsi);
+   uint32_t reg;
int ret;
 
if (!key || !key_len)
@@ -6725,11 +6757,22 @@ struct i40e_vsi *
uint32_t *key_dw = (uint32_t *)key;
uint16_t i;
 
-   for (i = 0; i <= I40E_PFQF_HKEY_MAX_INDEX; i++)
-   key_dw[i] = i40

[dpdk-dev] [PATCH v5 13/14] net/avf: enable bulk allocate Rx func

[Wenzhuo Lu]

Signed-off-by: Wenzhuo Lu 
---
 drivers/net/avf/avf.h|   1 +
 drivers/net/avf/avf_ethdev.c |   1 +
 drivers/net/avf/avf_rxtx.c   | 300 +++
 drivers/net/avf/avf_rxtx.h   |   6 +
 4 files changed, 308 insertions(+)

diff --git a/drivers/net/avf/avf.h b/drivers/net/avf/avf.h
index b79bc5a..ea0f7d8 100644
--- a/drivers/net/avf/avf.h
+++ b/drivers/net/avf/avf.h
@@ -120,6 +120,7 @@ struct avf_adapter {
struct rte_eth_dev *eth_dev;
struct avf_info vf;
 
+   bool rx_bulk_alloc_allowed;
/* For vector PMD */
bool rx_vec_allowed;
bool tx_vec_allowed;
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 127fdb5..d9f7cea 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -121,6 +121,7 @@ static void avf_dev_set_default_mac_addr(struct rte_eth_dev 
*dev,
struct avf_info *vf =  AVF_DEV_PRIVATE_TO_VF(ad);
struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
 
+   ad->rx_bulk_alloc_allowed = true;
 #ifdef RTE_LIBRTE_AVF_INC_VECTOR
/* Initialize to TRUE. If any of Rx queues doesn't meet the
 * vector Rx/Tx preconditions, it will be reset.
diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index b542532..e0c4583 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -120,6 +120,27 @@
 }
 #endif
 
+static inline bool
+check_rx_bulk_allow(struct avf_rx_queue *rxq)
+{
+   int ret = TRUE;
+
+   if (!(rxq->rx_free_thresh >= AVF_RX_MAX_BURST)) {
+   PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions: "
+"rxq->rx_free_thresh=%d, "
+"AVF_RX_MAX_BURST=%d",
+rxq->rx_free_thresh, AVF_RX_MAX_BURST);
+   ret = FALSE;
+   } else if (rxq->nb_rx_desc % rxq->rx_free_thresh != 0) {
+   PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions: "
+"rxq->nb_rx_desc=%d, "
+"rxq->rx_free_thresh=%d",
+rxq->nb_rx_desc, rxq->rx_free_thresh);
+   ret = FALSE;
+   }
+   return ret;
+}
+
 static inline void
 reset_rx_queue(struct avf_rx_queue *rxq)
 {
@@ -138,6 +159,11 @@
for (i = 0; i < AVF_RX_MAX_BURST; i++)
rxq->sw_ring[rxq->nb_rx_desc + i] = &rxq->fake_mbuf;
 
+   /* for rx bulk */
+   rxq->rx_nb_avail = 0;
+   rxq->rx_next_avail = 0;
+   rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1);
+
rxq->rx_tail = 0;
rxq->nb_rx_hold = 0;
rxq->pkt_first_seg = NULL;
@@ -233,6 +259,17 @@
rxq->sw_ring[i] = NULL;
}
}
+
+   /* for rx bulk */
+   if (rxq->rx_nb_avail == 0)
+   return;
+   for (i = 0; i < rxq->rx_nb_avail; i++) {
+   struct rte_mbuf *mbuf;
+
+   mbuf = rxq->rx_stage[rxq->rx_next_avail + i];
+   rte_pktmbuf_free_seg(mbuf);
+   }
+   rxq->rx_nb_avail = 0;
 }
 
 static inline void
@@ -363,6 +400,19 @@
rxq->qrx_tail = hw->hw_addr + AVF_QRX_TAIL1(rxq->queue_id);
rxq->ops = &def_rxq_ops;
 
+   if (check_rx_bulk_allow(rxq) == TRUE) {
+   PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions are "
+"satisfied. Rx Burst Bulk Alloc function will be "
+"used on port=%d, queue=%d.",
+rxq->port_id, rxq->queue_id);
+   } else {
+   PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions are "
+"not satisfied, Scattered Rx is requested "
+"on port=%d, queue=%d.",
+rxq->port_id, rxq->queue_id);
+   ad->rx_bulk_alloc_allowed = false;
+   }
+
 #ifdef RTE_LIBRTE_AVF_INC_VECTOR
if (check_rx_vec_allow(rxq) == FALSE)
ad->rx_vec_allowed = false;
@@ -1036,6 +1086,252 @@
return nb_rx;
 }
 
+#define AVF_LOOK_AHEAD 8
+static inline int
+avf_rx_scan_hw_ring(struct avf_rx_queue *rxq)
+{
+   volatile union avf_rx_desc *rxdp;
+   struct rte_mbuf **rxep;
+   struct rte_mbuf *mb;
+   uint16_t pkt_len;
+   uint64_t qword1;
+   uint32_t rx_status;
+   int32_t s[AVF_LOOK_AHEAD], nb_dd;
+   int32_t i, j, nb_rx = 0;
+   uint64_t pkt_flags;
+   static const uint32_t ptype_tbl[UINT8_MAX + 1] __rte_cache_aligned = {
+   /* [0] reserved */
+   [1] = RTE_PTYPE_L2_ETHER,
+   /* [2] - [21] reserved */
+   [22] = RTE_PTYPE_L2_ETHER | RTE_PTYPE_L3_IPV4_EXT_UNKNOWN |
+   RTE_PTYPE_L4_FRAG,
+   [23] = RTE_PTYPE_L2_ETHER | RTE_PTYPE_L3_IPV4_EXT_UNKNOWN |
+   RTE_PTYPE_L4_NONFRAG,
+   [24] = RTE_PTYPE_L2_ETHER | RTE_PTYPE_L3_IPV4_EXT_UNKNOWN |
+ 

[dpdk-dev] [PATCH v5 14/14] net/avf: enable Rx interrupt support

[Wenzhuo Lu]

From: Jingjing Wu 

Update the doc for the AVF features either.

Signed-off-by: Jingjing Wu 
---
 doc/guides/nics/features/avf.ini   |   1 +
 doc/guides/nics/features/avf_vec.ini   |   1 +
 doc/guides/nics/intel_vf.rst   |  20 +++-
 doc/guides/rel_notes/release_18_02.rst |  16 +++
 drivers/net/avf/avf_ethdev.c   | 204 +++--
 5 files changed, 204 insertions(+), 38 deletions(-)

diff --git a/doc/guides/nics/features/avf.ini b/doc/guides/nics/features/avf.ini
index da4d81b..ccb9edd 100644
--- a/doc/guides/nics/features/avf.ini
+++ b/doc/guides/nics/features/avf.ini
@@ -7,6 +7,7 @@
 Speed capabilities   = Y
 Link status  = Y
 Link status event= Y
+Rx interrupt = Y
 Queue start/stop = Y
 MTU update   = Y
 Jumbo frame  = Y
diff --git a/doc/guides/nics/features/avf_vec.ini 
b/doc/guides/nics/features/avf_vec.ini
index 45dd5e5..8924994 100644
--- a/doc/guides/nics/features/avf_vec.ini
+++ b/doc/guides/nics/features/avf_vec.ini
@@ -7,6 +7,7 @@
 Speed capabilities   = Y
 Link status  = Y
 Link status event= Y
+Rx interrupt = Y
 Queue start/stop = Y
 MTU update   = Y
 Jumbo frame  = Y
diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst
index 1e83bf6..66f90b1 100644
--- a/doc/guides/nics/intel_vf.rst
+++ b/doc/guides/nics/intel_vf.rst
@@ -28,8 +28,8 @@
 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-I40E/IXGBE/IGB Virtual Function Driver
-==
+Intel Virtual Function Driver
+=
 
 Supported Intel® Ethernet Controllers (see the *DPDK Release Notes* for 
details)
 support the following modes of operation in a virtualized environment:
@@ -93,6 +93,22 @@ and the Physical Function operates on the global resources 
on behalf of the Virt
 For this out-of-band communication, an SR-IOV enabled NIC provides a memory 
buffer for each Virtual Function,
 which is called a "Mailbox".
 
+Intel® Ethernet Adaptive Virtual Function
+^
+Adaptive Virtual Function (AVF) is a SR-IOV Virtual Function with the same 
device id (8086:1889) on different Intel Ethernet Controller.
+AVF Driver is VF driver which supports for all future Intel devices without 
requiring a VM update. And since this happens to be an adaptive VF driver,
+every new drop of the VF driver would add more and more advanced features that 
can be turned on in the VM if the underlying HW device supports those
+advanced features based on a device agnostic way without ever compromising on 
the base functionality. AVF provides generic hardware interface and
+interface between AVF driver and a compliant PF driver is specified.
+
+Intel products starting Ethernet Controller 710 Series to support Adaptive 
Virtual Function.
+
+The way to generate Virtual Function is like normal, and the resource of VF 
assignment depends on the NIC Infrastructure.
+
+For more detail on SR-IOV, please refer to the following documents:
+
+*   `Intel® AVF HAS 
`_
+
 The PCIE host-interface of Intel Ethernet Switch FM1 Series VF 
infrastructure
 
^
 
diff --git a/doc/guides/rel_notes/release_18_02.rst 
b/doc/guides/rel_notes/release_18_02.rst
index 24b67bb..0672b0e 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -41,6 +41,22 @@ New Features
  Also, make sure to start the actual text at the margin.
  =
 
+   * **Add AVF (Adaptive Virtual Function) net PMD.**
+
+ A new net PMD has been added, which supports Intel® Ethernet Adaptive
+ Virtual Function (AVF) with features list below:
+
+ * Basic Rx/Tx burst
+ * SSE vectorized Rx/Tx burst
+ * Promiscuous mode
+ * MAC/VLAN offload
+ * Checksum offload
+ * TSO offload
+ * Jumbo frame and MTU setting
+ * RSS configuration
+ * stats
+ * Rx/Tx descriptor status
+ * Link status update/event
 
 API Changes
 ---
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index d9f7cea..13f6329 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -67,9 +67,14 @@ static int avf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 static int avf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
 static void avf_dev_set_default_mac_addr(struct rte_eth_dev *dev,
 struct ether_addr *mac_addr);
+static int avf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev,
+   uint16_t queue_id);
+static int avf_dev_rx_queue_intr_disable

[dpdk-dev] [PATCH] doc: add i40e update

[Beilei Xing]

Update release note to declare MPLSoUDP/MPLSoGRE/
GTP-U/GTP-C/PPPoE/PPPoL2TP steering support in i40e
driver.
Update i40e.rst to declare DDP support.

Signed-off-by: Beilei Xing 
---
 doc/guides/nics/i40e.rst   |  1 +
 doc/guides/rel_notes/release_18_02.rst | 31 +++
 2 files changed, 32 insertions(+)

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 2507d5f..56b4239 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -65,6 +65,7 @@ Features of the I40E PMD are:
 - Hot plug
 - IEEE1588/802.1AS timestamping
 - VF Daemon (VFD) - EXPERIMENTAL
+- Dynamic Device Personalization (DDP) - EXPERIMENTAL
 
 
 Prerequisites
diff --git a/doc/guides/rel_notes/release_18_02.rst 
b/doc/guides/rel_notes/release_18_02.rst
index 621b8f5..0114d87 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -47,6 +47,37 @@ New Features
   users. According to the device configuration, it will setup TX->RX loopback
   link or not.
 
+* **Updated i40e driver to support MPLSoUDP/MPLSoGRE.**
+
+  Updated i40e PMD to support MPLSoUDP/MPLSoGRE with MPLSoUDP/MPLSoGRE
+  supporting profiles which can be programmed by dynamic device
+  personalization (DDP) process:
+
+  * Support cloud filer of MPLSoUDP/MPLSoGRE flow base on label.
+
+  This feature was implemented in release_17_05.
+
+* **Updated i40e driver to support GTP-C/GTP-U.**
+
+  Updated i40e PMD to support GTP-C/GTP-U with GTP-C/GTP-U supporting
+  profiles which can be programmed by dynamic device personalization (DDP)
+  process:
+
+  * Support RSS of GTP-C/GTP-U flow.
+  * Support flow director of GTP-C/GTP-U flow base on TEID.
+  * Support cloud filer of GTP-C/GTP-U flow base on TEID.
+
+  This feature was implemented in release_17_11, and only GTPv1 is supported.
+
+* **Updated i40e driver to support PPPoE/PPPoL2TP.**
+
+  Updated i40e PMD to support PPPoE/PPPoL2TP with PPPoE/PPPoL2TP supporting
+  profiles which can be programmed by dynamic device personalization (DDP)
+  process:
+
+  * Support RSS of PPPoE/PPPoL2TP flow based on user defined input set.
+  * Support flow director of PPPoE/PPPoL2TP flow base on user defined input 
set.
+
 API Changes
 ---
 
-- 
2.5.5

Re: [dpdk-dev] [PATCH 9/9] tools: use SPDX tag for Cavium copyright files

[Jerin Jacob]

-Original Message-
> Date: Sun, 7 Jan 2018 14:24:11 +0530
> From: Hemant Agrawal 
> To: Jerin Jacob , dev@dpdk.org
> CC: tho...@monjalon.net
> Subject: Re: [PATCH 9/9] tools: use SPDX tag for Cavium copyright files
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
>  Thunderbird/45.8.0
> 
> On 1/6/2018 5:50 PM, Jerin Jacob wrote:
> > Signed-off-by: Jerin Jacob 
> > ---
> >  devtools/build-tags.sh | 30 ++
> >  1 file changed, 2 insertions(+), 28 deletions(-)
> > 
> > diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> > index 942da2bae..d775b17e9 100755
> > --- a/devtools/build-tags.sh
> > +++ b/devtools/build-tags.sh
> > @@ -1,35 +1,9 @@
> >  #!/bin/sh -e
> >  # Generate tags or gtags or cscope or etags files
> >  #
> > -#   BSD LICENSE
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2017 Cavium, Inc
> 
> Hi Jerin,
>All your patches are ok except this one.
> It is not aligned with the policy.
> SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.
> 
> you can move the comments ("Generate tags...") after the copyrights.

Thanks Hemant. I will move the comments and send the v2.

> 
> Regards,
> Hemant

[dpdk-dev] [PATCH v2 1/9] test: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 test/test/test_bitmap.c| 32 ++--
 test/test/test_eventdev.c  | 32 ++--
 test/test/test_eventdev_octeontx.c | 32 ++--
 test/test/test_xmmt_ops.h  | 33 ++---
 4 files changed, 8 insertions(+), 121 deletions(-)

diff --git a/test/test/test_bitmap.c b/test/test/test_bitmap.c
index 5c9eee969..05d547ed9 100644
--- a/test/test/test_bitmap.c
+++ b/test/test/test_bitmap.c
@@ -1,33 +1,5 @@
-/*
- *   BSD LICENSE
- *
- *   Copyright (C) Cavium, Inc. 2017.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- *   notice, this list of conditions and the following disclaimer in
- *   the documentation and/or other materials provided with the
- *   distribution.
- * * Neither the name of Cavium, Inc nor the names of its
- *   contributors may be used to endorse or promote products derived
- *   from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017 Cavium, Inc
  */
 
 #include 
diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
index ba39cbac8..70042e5f5 100644
--- a/test/test/test_eventdev.c
+++ b/test/test/test_eventdev.c
@@ -1,33 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2016 Cavium, Inc. All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *  * Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- *  * Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in
- *the documentation and/or other materials provided with the
- *distribution.
- *  * Neither the name of Cavium, Inc nor the names of its
- *contributors may be used to endorse or promote products derived
- *from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2016 Cavium, Inc
  */
 
 #include 
diff --git a/test/test/test_eventdev_octeontx.c 
b/test/test/test_eventdev_octeontx.c
index dbc36d948..86562fe91 100644
--- a/test/test/test_eventdev_octeontx.c
+++ b/test/test/test_eventdev_octeontx.c
@@ -1,33 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2017 Cavium, Inc. All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *  * Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- *  * Redistributions in binary form must reproduce the above copyright
- *notice, this list of con

[dpdk-dev] [PATCH v2 2/9] mk: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 mk/arch/arm64/rte.vars.mk   | 30 ++
 mk/machine/armv8a/rte.vars.mk   | 31 ++-
 mk/machine/thunderx/rte.vars.mk | 31 ++-
 mk/machine/xgene1/rte.vars.mk   | 31 ++-
 4 files changed, 8 insertions(+), 115 deletions(-)

diff --git a/mk/arch/arm64/rte.vars.mk b/mk/arch/arm64/rte.vars.mk
index 5e7ee96c2..a75b80c22 100644
--- a/mk/arch/arm64/rte.vars.mk
+++ b/mk/arch/arm64/rte.vars.mk
@@ -1,32 +1,6 @@
-#   BSD LICENSE
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2015 Cavium, Inc
 #
-#   Copyright (C) Cavium, Inc 2015. All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the above copyright
-#   notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-#   notice, this list of conditions and the following disclaimer in
-#   the documentation and/or other materials provided with the
-#   distribution.
-# * Neither the name of Cavium, Inc nor the names of its
-#   contributors may be used to endorse or promote products derived
-#   from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #
 # arch:
diff --git a/mk/machine/armv8a/rte.vars.mk b/mk/machine/armv8a/rte.vars.mk
index 500421a20..8252efbb7 100644
--- a/mk/machine/armv8a/rte.vars.mk
+++ b/mk/machine/armv8a/rte.vars.mk
@@ -1,32 +1,5 @@
-#   BSD LICENSE
-#
-#   Copyright (C) Cavium, Inc 2015. All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the above copyright
-#   notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-#   notice, this list of conditions and the following disclaimer in
-#   the documentation and/or other materials provided with the
-#   distribution.
-# * Neither the name of Cavium, Inc nor the names of its
-#   contributors may be used to endorse or promote products derived
-#   from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2015 Cavium, Inc
 #
 
 #
diff --git a/mk/machine/thunderx/rte.vars.mk b/mk/machine/thunderx/rte.vars.mk
index cae6e3e15..047741668 100644
--- a/mk/machine/thunderx/rte.vars.mk
+++ b/mk/machine/thunderx/rte.vars.mk
@@ -1,32 +1,5 @@
-#   BSD LICENSE
-#
-#   Copyright (C) Cavium, Inc 2015. All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the above copyright
-#   notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-#   notice, this list of conditions and the following disclaimer in
-#   the documentation and/or other materials provided w

[dpdk-dev] [PATCH v2 3/9] lib: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 lib/librte_acl/acl_run_neon.c  | 34 ++
 lib/librte_acl/acl_run_neon.h  | 34 ++
 lib/librte_eal/common/arch/arm/rte_cycles.c| 32 ++--
 .../common/include/arch/arm/rte_atomic_64.h| 34 ++
 .../common/include/arch/arm/rte_cpuflags_64.h  | 32 ++--
 .../common/include/arch/arm/rte_cycles_64.h| 34 ++
 lib/librte_eal/common/include/arch/arm/rte_io.h| 33 ++---
 lib/librte_eal/common/include/arch/arm/rte_io_64.h | 32 ++--
 .../common/include/arch/arm/rte_memcpy_64.h| 34 ++
 lib/librte_eal/common/include/arch/arm/rte_pause.h | 32 ++--
 .../common/include/arch/arm/rte_pause_32.h | 32 ++--
 .../common/include/arch/arm/rte_pause_64.h | 32 ++--
 .../common/include/arch/arm/rte_prefetch_64.h  | 32 ++--
 lib/librte_eal/common/include/arch/arm/rte_vect.h  | 32 ++--
 lib/librte_eal/common/include/arch/ppc_64/rte_io.h | 33 ++---
 .../common/include/arch/ppc_64/rte_pause.h | 33 ++---
 lib/librte_eal/common/include/arch/x86/rte_io.h| 33 ++---
 lib/librte_eal/common/include/arch/x86/rte_pause.h | 33 ++---
 lib/librte_eal/common/include/generic/rte_io.h | 33 ++---
 lib/librte_eal/common/include/generic/rte_pause.h  | 33 ++---
 lib/librte_efd/rte_efd_arm64.h | 32 ++--
 lib/librte_eventdev/Makefile   | 30 ++-
 lib/librte_eventdev/rte_eventdev.c | 32 ++--
 lib/librte_eventdev/rte_eventdev_pmd.h | 31 ++--
 lib/librte_eventdev/rte_eventdev_pmd_pci.h | 31 ++--
 lib/librte_eventdev/rte_eventdev_pmd_vdev.h| 31 ++--
 lib/librte_hash/rte_cmp_arm64.h| 33 ++---
 lib/librte_hash/rte_crc_arm64.h| 33 ++---
 lib/librte_net/net_crc_neon.h  | 32 ++--
 lib/librte_table/rte_lru_arm64.h   | 32 ++--
 30 files changed, 65 insertions(+), 909 deletions(-)

diff --git a/lib/librte_acl/acl_run_neon.c b/lib/librte_acl/acl_run_neon.c
index 0b1c71c03..7319d6123 100644
--- a/lib/librte_acl/acl_run_neon.c
+++ b/lib/librte_acl/acl_run_neon.c
@@ -1,34 +1,6 @@
-/*
- *   BSD LICENSE
- *
- *   Copyright (C) Cavium, Inc. 2015.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- *   notice, this list of conditions and the following disclaimer in
- *   the documentation and/or other materials provided with the
- *   distribution.
- * * Neither the name of Cavium, Inc nor the names of its
- *   contributors may be used to endorse or promote products derived
- *   from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-*/
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015 Cavium, Inc
+ */
 
 #include "acl_run_neon.h"
 
diff --git a/lib/librte_acl/acl_run_neon.h b/lib/librte_acl/acl_run_neon.h
index 37881c45b..01b9766d8 100644
--- a/lib/librte_acl/acl_run_neon.h
+++ b/lib/librte_acl/acl_run_neon.h
@@ -1,34 +1,6 @@
-/*
- *   BSD LICENSE
- *
- *   Copyright (C) Cavium, Inc. 2015.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- *

[dpdk-dev] [PATCH v2 4/9] examples: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 .../performance-thread/common/arch/arm64/ctx.c | 32 ++
 .../performance-thread/common/arch/arm64/ctx.h | 32 ++
 .../performance-thread/common/arch/arm64/stack.h   | 32 ++
 3 files changed, 6 insertions(+), 90 deletions(-)

diff --git a/examples/performance-thread/common/arch/arm64/ctx.c 
b/examples/performance-thread/common/arch/arm64/ctx.c
index d0eacaa6c..7c5c91658 100644
--- a/examples/performance-thread/common/arch/arm64/ctx.c
+++ b/examples/performance-thread/common/arch/arm64/ctx.c
@@ -1,33 +1,5 @@
-/*
- *   BSD LICENSE
- *
- *   Copyright (C) Cavium, Inc. 2017.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- *   notice, this list of conditions and the following disclaimer in
- *   the documentation and/or other materials provided with the
- *   distribution.
- * * Neither the name of Cavium, Inc nor the names of its
- *   contributors may be used to endorse or promote products derived
- *   from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017 Cavium, Inc
  */
 
 #include 
diff --git a/examples/performance-thread/common/arch/arm64/ctx.h 
b/examples/performance-thread/common/arch/arm64/ctx.h
index 38c86ce65..74c2e7a73 100644
--- a/examples/performance-thread/common/arch/arm64/ctx.h
+++ b/examples/performance-thread/common/arch/arm64/ctx.h
@@ -1,33 +1,5 @@
-/*
- *   BSD LICENSE
- *
- *   Copyright (C) Cavium, Inc. 2017.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- *   notice, this list of conditions and the following disclaimer in
- *   the documentation and/or other materials provided with the
- *   distribution.
- * * Neither the name of Cavium, Inc nor the names of its
- *   contributors may be used to endorse or promote products derived
- *   from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017 Cavium, Inc
  */
 
 #ifndef CTX_H
diff --git a/examples/performance-thread/common/arch/arm64/stack.h 
b/examples/performance-thread/common/arch/arm64/stack.h
index fa3b31e98..722c47335 100644
--- a/examples/performance-thread/common/arch/arm64/stack.h
+++ b/examples/performance-thread/common/arch/arm64/stack.h
@@ -1,33 +1,5 @@
-/*
- *   BSD LICENSE
- *
- *   Copyright (C) Cavium, Inc. 2017.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyr

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

[Guo, Jia]

thanks , matan


On 1/3/2018 1:02 AM, Matan Azrad wrote:

Hi Jeff

Maybe I'm touching in previous discussions but please see some 
comments\questions.

From: Jeff Guo:

This patch aim to add a general uevent mechanism in eal device layer,
to enable all linux kernel object hot plug monitoring, so user could use these
APIs to monitor and read out the device status info that sent from the kernel
side, then corresponding to handle it, such as detach or attach the
device, and even benefit to use it to do smoothly fail safe work.

1) About uevent monitoring:
a: add one epolling to poll the netlink socket, to monitor the uevent of
the device, add device_state in struct of rte_device, to identify the
device state machine.
b: add enum of rte_eal_dev_event_type and struct of rte_eal_uevent.
c: add below API in rte eal device common layer.
rte_eal_dev_monitor_enable
rte_dev_callback_register
rte_dev_callback_unregister
_rte_dev_callback_process
rte_dev_monitor_start
rte_dev_monitor_stop

2) About failure handler, use pci uio for example,
add pci_remap_device in bus layer and below function to process it:
rte_pci_remap_device
pci_uio_remap_resource
pci_map_private_resource
add rte_pci_dev_bind_driver to bind pci device with explicit driver.

Signed-off-by: Jeff Guo 
---
v7->v6:
a.modify vdev part according to the vdev rework
b.re-define and split the func into common and bus specific code
c.fix some incorrect issue.
b.fix the system hung after send packcet issue.
---
  drivers/bus/pci/bsd/pci.c  |  30 ++
  drivers/bus/pci/linux/pci.c|  87 +
  drivers/bus/pci/linux/pci_init.h   |   1 +
  drivers/bus/pci/pci_common.c   |  43 +++
  drivers/bus/pci/pci_common_uio.c   |  28 ++
  drivers/bus/pci/private.h  |  12 +
  drivers/bus/pci/rte_bus_pci.h  |  25 ++
  drivers/bus/vdev/vdev.c|  36 +++
  lib/librte_eal/bsdapp/eal/eal_dev.c|  64 
  .../bsdapp/eal/include/exec-env/rte_dev.h  | 106 ++
  lib/librte_eal/common/eal_common_bus.c |  30 ++
  lib/librte_eal/common/eal_common_dev.c | 169 ++
  lib/librte_eal/common/include/rte_bus.h|  69 
  lib/librte_eal/common/include/rte_dev.h|  89 ++
  lib/librte_eal/linuxapp/eal/Makefile   |   3 +-
  lib/librte_eal/linuxapp/eal/eal_alarm.c|   5 +
  lib/librte_eal/linuxapp/eal/eal_dev.c  | 356
+
  .../linuxapp/eal/include/exec-env/rte_dev.h| 106 ++
  lib/librte_eal/linuxapp/igb_uio/igb_uio.c  |   6 +
  lib/librte_pci/rte_pci.c   |  20 ++
  lib/librte_pci/rte_pci.h   |  17 +
  21 files changed, 1301 insertions(+), 1 deletion(-)
  create mode 100644 lib/librte_eal/bsdapp/eal/eal_dev.c
  create mode 100644 lib/librte_eal/bsdapp/eal/include/exec-env/rte_dev.h
  create mode 100644 lib/librte_eal/linuxapp/eal/eal_dev.c
  create mode 100644 lib/librte_eal/linuxapp/eal/include/exec-env/rte_dev.h

diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c
index b8e2178..d58dbf6 100644
--- a/drivers/bus/pci/bsd/pci.c
+++ b/drivers/bus/pci/bsd/pci.c
@@ -126,6 +126,29 @@ rte_pci_unmap_device(struct rte_pci_device *dev)
}
  }

+/* re-map pci device */
+int
+rte_pci_remap_device(struct rte_pci_device *dev)
+{
+   int ret;
+
+   if (dev == NULL)
+   return -EINVAL;
+
+   switch (dev->kdrv) {
+   case RTE_KDRV_NIC_UIO:
+   ret = pci_uio_remap_resource(dev);
+   break;
+   default:
+   RTE_LOG(DEBUG, EAL,
+   "  Not managed by a supported kernel driver,
skipped\n");
+   ret = 1;
+   break;
+   }
+
+   return ret;
+}
+
  void
  pci_uio_free_resource(struct rte_pci_device *dev,
struct mapped_pci_resource *uio_res)
@@ -678,3 +701,10 @@ rte_pci_ioport_unmap(struct rte_pci_ioport *p)

return ret;
  }
+
+int
+rte_pci_dev_bind_driver(const char *dev_name, const char *drv_type)
+{
+   return -1;
+}
+
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 5da6728..792fd2c 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -145,6 +145,38 @@ rte_pci_unmap_device(struct rte_pci_device *dev)
}
  }

+/* Map pci device */
+int
+rte_pci_remap_device(struct rte_pci_device *dev)
+{
+   int ret = -1;
+
+   if (dev == NULL)
+   return -EINVAL;
+
+   switch (dev->kdrv) {
+   case RTE_KDRV_VFIO:
+#ifdef VFIO_PRESENT
+   /* no thing to do */
+#endif
+   break;
+   case RTE_KDRV_IGB_UIO:
+   case RTE_KDRV_UIO_GENERIC:
+   if (rte_eal_using_phys_addrs()) {
+   /* map resources for devices

[dpdk-dev] [PATCH v2 6/9] app: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 app/test-eventdev/Makefile| 30 ++
 app/test-eventdev/evt_common.h| 32 ++--
 app/test-eventdev/evt_main.c  | 32 ++--
 app/test-eventdev/evt_options.c   | 32 ++--
 app/test-eventdev/evt_options.h   | 32 ++--
 app/test-eventdev/evt_test.c  | 32 ++--
 app/test-eventdev/evt_test.h  | 32 ++--
 app/test-eventdev/test_order_atq.c| 32 ++--
 app/test-eventdev/test_order_common.c | 32 ++--
 app/test-eventdev/test_order_common.h | 32 ++--
 app/test-eventdev/test_order_queue.c  | 32 ++--
 app/test-eventdev/test_perf_atq.c | 32 ++--
 app/test-eventdev/test_perf_common.c  | 32 ++--
 app/test-eventdev/test_perf_common.h  | 32 ++--
 app/test-eventdev/test_perf_queue.c   | 32 ++--
 15 files changed, 30 insertions(+), 448 deletions(-)

diff --git a/app/test-eventdev/Makefile b/app/test-eventdev/Makefile
index dcb2ac476..cfe567a6d 100644
--- a/app/test-eventdev/Makefile
+++ b/app/test-eventdev/Makefile
@@ -1,32 +1,6 @@
-#   BSD LICENSE
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Cavium, Inc
 #
-#   Copyright(c) 2017 Cavium, Inc. All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the above copyright
-#   notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-#   notice, this list of conditions and the following disclaimer in
-#   the documentation and/or other materials provided with the
-#   distribution.
-# * Neither the name of Cavium, Inc nor the names of its
-#   contributors may be used to endorse or promote products derived
-#   from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
diff --git a/app/test-eventdev/evt_common.h b/app/test-eventdev/evt_common.h
index 0fadab4a0..463e06203 100644
--- a/app/test-eventdev/evt_common.h
+++ b/app/test-eventdev/evt_common.h
@@ -1,33 +1,5 @@
-/*
- *   BSD LICENSE
- *
- *   Copyright (C) Cavium, Inc 2017.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- *   notice, this list of conditions and the following disclaimer in
- *   the documentation and/or other materials provided with the
- *   distribution.
- * * Neither the name of Cavium, Inc nor the names of its
- *   contributors may be used to endorse or promote products derived
- *   from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVI

[dpdk-dev] [PATCH v2 5/9] drivers: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 drivers/crypto/armv8/Makefile   | 32 ++-
 drivers/crypto/armv8/rte_armv8_pmd.c| 32 ++-
 drivers/crypto/armv8/rte_armv8_pmd_ops.c| 32 ++-
 drivers/crypto/armv8/rte_armv8_pmd_private.h| 32 ++-
 drivers/event/Makefile  | 31 ++
 drivers/event/octeontx/Makefile | 32 ++-
 drivers/event/octeontx/ssovf_evdev.c| 32 ++-
 drivers/event/octeontx/ssovf_evdev.h| 32 ++-
 drivers/event/octeontx/ssovf_worker.c   | 32 ++-
 drivers/event/octeontx/ssovf_worker.h   | 33 ++--
 drivers/event/skeleton/Makefile | 32 ++-
 drivers/event/skeleton/skeleton_eventdev.c  | 32 ++-
 drivers/event/skeleton/skeleton_eventdev.h  | 32 ++-
 drivers/mempool/octeontx/Makefile   | 31 ++
 drivers/mempool/octeontx/octeontx_fpavf.c   | 32 ++-
 drivers/mempool/octeontx/octeontx_fpavf.h   | 32 ++-
 drivers/mempool/octeontx/octeontx_mbox.c| 32 ++-
 drivers/mempool/octeontx/octeontx_mbox.h| 32 ++-
 drivers/mempool/octeontx/octeontx_pool_logs.h   | 32 ++-
 drivers/mempool/octeontx/octeontx_ssovf.c   | 32 ++-
 drivers/mempool/octeontx/rte_mempool_octeontx.c | 33 +++-
 drivers/net/liquidio/Makefile   | 33 ++--
 drivers/net/liquidio/base/lio_23xx_reg.h| 33 ++--
 drivers/net/liquidio/base/lio_23xx_vf.c | 33 ++--
 drivers/net/liquidio/base/lio_23xx_vf.h | 33 ++--
 drivers/net/liquidio/base/lio_hw_defs.h | 33 ++--
 drivers/net/liquidio/base/lio_mbox.c| 33 ++--
 drivers/net/liquidio/base/lio_mbox.h| 33 ++--
 drivers/net/liquidio/lio_ethdev.c   | 33 ++--
 drivers/net/liquidio/lio_ethdev.h   | 33 ++--
 drivers/net/liquidio/lio_logs.h | 33 ++--
 drivers/net/liquidio/lio_rxtx.c | 33 ++--
 drivers/net/liquidio/lio_rxtx.h | 33 ++--
 drivers/net/liquidio/lio_struct.h   | 33 ++--
 drivers/net/octeontx/Makefile   | 32 +++
 drivers/net/octeontx/base/octeontx_bgx.c| 32 ++-
 drivers/net/octeontx/base/octeontx_bgx.h| 32 ++-
 drivers/net/octeontx/base/octeontx_io.h | 32 ++-
 drivers/net/octeontx/base/octeontx_pki_var.h| 32 ++-
 drivers/net/octeontx/base/octeontx_pkivf.c  | 33 +++-
 drivers/net/octeontx/base/octeontx_pkivf.h  | 32 ++-
 drivers/net/octeontx/base/octeontx_pkovf.c  | 33 +++-
 drivers/net/octeontx/base/octeontx_pkovf.h  | 32 ++-
 drivers/net/octeontx/octeontx_ethdev.c  | 33 +++-
 drivers/net/octeontx/octeontx_ethdev.h  | 33 +++-
 drivers/net/octeontx/octeontx_logs.h| 33 +++-
 drivers/net/octeontx/octeontx_rxtx.c| 32 ++-
 drivers/net/octeontx/octeontx_rxtx.h| 32 ++-
 drivers/net/thunderx/Makefile   | 32 ++-
 drivers/net/thunderx/base/nicvf_bsvf.c  | 32 ++-
 drivers/net/thunderx/base/nicvf_bsvf.h  | 32 ++-
 drivers/net/thunderx/base/nicvf_hw.c| 32 ++-
 drivers/net/thunderx/base/nicvf_hw.h| 32 ++-
 drivers/net/thunderx/base/nicvf_hw_defs.h   | 32 ++-
 drivers/net/thunderx/base/nicvf_mbox.c  | 32 ++-
 drivers/net/thunderx/base/nicvf_mbox.h  | 32 ++-
 drivers/net/thunderx/base/nicvf_plat.h  | 32 ++-
 drivers/net/thunderx/nicvf_ethdev.c | 32 ++-
 drivers/net/thunderx/nicvf_ethdev.h | 32 ++-
 drivers/net/thunderx/nicvf_logs.h   | 32 ++-
 drivers/net/thunderx/nicvf_rxtx.c   | 32 ++-
 drivers/net/thunderx/nicvf_rxtx.h   | 32 ++-
 drivers/net/thunderx/nicvf_struct.h | 32 ++-
 drivers/net/thunderx/nicvf_svf.c  

[dpdk-dev] [PATCH v2 7/9] doc: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 doc/guides/cryptodevs/armv8.rst| 31 ++--
 doc/guides/eventdevs/octeontx.rst  | 31 ++--
 doc/guides/mempool/index.rst   | 30 ++-
 doc/guides/mempool/octeontx.rst| 30 ++-
 doc/guides/nics/build_and_test.rst | 30 ++-
 doc/guides/nics/liquidio.rst   | 31 ++--
 doc/guides/nics/octeontx.rst   | 31 ++--
 doc/guides/nics/qede.rst   | 33 ++---
 doc/guides/nics/thunderx.rst   | 31 ++--
 doc/guides/platform/index.rst  | 30 ++-
 doc/guides/platform/octeontx.rst   | 30 ++-
 doc/guides/tools/img/eventdev_order_atq_test.svg   | 34 ++
 doc/guides/tools/img/eventdev_order_queue_test.svg | 34 ++
 doc/guides/tools/img/eventdev_perf_atq_test.svg| 34 ++
 doc/guides/tools/img/eventdev_perf_queue_test.svg  | 34 ++
 doc/guides/tools/testeventdev.rst  | 31 ++--
 16 files changed, 33 insertions(+), 472 deletions(-)

diff --git a/doc/guides/cryptodevs/armv8.rst b/doc/guides/cryptodevs/armv8.rst
index b1107114d..725398daf 100644
--- a/doc/guides/cryptodevs/armv8.rst
+++ b/doc/guides/cryptodevs/armv8.rst
@@ -1,32 +1,5 @@
-..  BSD LICENSE
-Copyright (C) Cavium, Inc. 2017.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-
-  * Redistributions of source code must retain the above copyright
-notice, this list of conditions and the following disclaimer.
-  * Redistributions in binary form must reproduce the above copyright
-notice, this list of conditions and the following disclaimer in
-the documentation and/or other materials provided with the
-distribution.
-  * Neither the name of Cavium, Inc nor the names of its
-contributors may be used to endorse or promote products derived
-from this software without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2017 Cavium, Inc
 
 ARMv8 Crypto Poll Mode Driver
 =
diff --git a/doc/guides/eventdevs/octeontx.rst 
b/doc/guides/eventdevs/octeontx.rst
index cef004a20..7165f900a 100644
--- a/doc/guides/eventdevs/octeontx.rst
+++ b/doc/guides/eventdevs/octeontx.rst
@@ -1,32 +1,5 @@
-..  BSD LICENSE
-Copyright (C) Cavium, Inc. 2017.
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-
-* Redistributions of source code must retain the above copyright
-notice, this list of conditions and the following disclaimer.
-* Redistributions in binary form must reproduce the above copyright
-notice, this list of conditions and the following disclaimer in
-the documentation and/or other materials provided with the
-distribution.
-* Neither the name of Cavium, Inc nor the names of its
-contributors may be used to endorse or promote products derived
-from this software without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDIN

[dpdk-dev] [PATCH v2 9/9] tools: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 devtools/build-tags.sh | 34 +-
 1 file changed, 5 insertions(+), 29 deletions(-)

diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
index 942da2bae..78001f048 100755
--- a/devtools/build-tags.sh
+++ b/devtools/build-tags.sh
@@ -1,35 +1,11 @@
 #!/bin/sh -e
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Cavium, Inc
+#
+
+#
 # Generate tags or gtags or cscope or etags files
 #
-#   BSD LICENSE
-#
-#   Copyright 2017 Cavium, Inc
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the above copyright
-#   notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-#   notice, this list of conditions and the following disclaimer in
-#   the documentation and/or other materials provided with the
-#   distribution.
-# * Neither the name of Cavium, Inc nor the names of its
-#   contributors may be used to endorse or promote products derived
-#   from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 verbose=false
 linux=true
-- 
2.15.1

[dpdk-dev] [PATCH v2 8/9] config: use SPDX tag for Cavium copyright files

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 config/common_armv8a_linuxapp| 31 ++--
 config/defconfig_arm64-armv8a-linuxapp-clang | 31 ++--
 config/defconfig_arm64-armv8a-linuxapp-gcc   | 31 ++--
 config/defconfig_arm64-thunderx-linuxapp-gcc | 31 ++--
 config/defconfig_arm64-xgene1-linuxapp-gcc   | 31 ++--
 5 files changed, 10 insertions(+), 145 deletions(-)

diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
index 6732d1e3a..781c85423 100644
--- a/config/common_armv8a_linuxapp
+++ b/config/common_armv8a_linuxapp
@@ -1,32 +1,5 @@
-#   BSD LICENSE
-#
-#   Copyright (C) Cavium, Inc 2017. All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the above copyright
-#   notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-#   notice, this list of conditions and the following disclaimer in
-#   the documentation and/or other materials provided with the
-#   distribution.
-# * Neither the name of Cavium, Inc nor the names of its
-#   contributors may be used to endorse or promote products derived
-#   from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Cavium, Inc
 #
 
 #include "common_linuxapp"
diff --git a/config/defconfig_arm64-armv8a-linuxapp-clang 
b/config/defconfig_arm64-armv8a-linuxapp-clang
index 91c0ec74f..487714ea0 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-clang
+++ b/config/defconfig_arm64-armv8a-linuxapp-clang
@@ -1,32 +1,5 @@
-#   BSD LICENSE
-#
-#   Copyright (C) Cavium, Inc 2017. All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the above copyright
-#   notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-#   notice, this list of conditions and the following disclaimer in
-#   the documentation and/or other materials provided with the
-#   distribution.
-# * Neither the name of Cavium, Inc nor the names of its
-#   contributors may be used to endorse or promote products derived
-#   from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Cavium, Inc
 #
 
 #include "common_armv8a_linuxapp"
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc 
b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 9775ca11b..184274437 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -1,32 +1,5 @@
-#   BSD LICENSE
-#
-#   Copyright (C) Cavium, Inc 2015. All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-# * Redistributions of source code must retain the 

Re: [dpdk-dev] [PATCH] doc: add i40e update

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing
> Sent: Monday, January 8, 2018 1:13 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add i40e update
> 
> Update release note to declare MPLSoUDP/MPLSoGRE/ GTP-U/GTP-
> C/PPPoE/PPPoL2TP steering support in i40e driver.
> Update i40e.rst to declare DDP support.
> 
> Signed-off-by: Beilei Xing 
> ---
>  doc/guides/nics/i40e.rst   |  1 +
>  doc/guides/rel_notes/release_18_02.rst | 31
> +++
>  2 files changed, 32 insertions(+)
> 
> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index
> 2507d5f..56b4239 100644
> --- a/doc/guides/nics/i40e.rst
> +++ b/doc/guides/nics/i40e.rst
> @@ -65,6 +65,7 @@ Features of the I40E PMD are:
>  - Hot plug
>  - IEEE1588/802.1AS timestamping
>  - VF Daemon (VFD) - EXPERIMENTAL
> +- Dynamic Device Personalization (DDP) - EXPERIMENTAL
It is not a experimental, as I know.
> 

Re: [dpdk-dev] [PATCH v2 11/16] doc: add documents for AMD axgbe Ethernet PMD

[Kumar, Ravi1]

>On Fri,  5 Jan 2018 04:52:13 -0500
>Ravi Kumar  wrote:
>
>> Signed-off-by: Ravi Kumar 
>> ---
>>  doc/guides/nics/axgbe.rst  | 211 
>> +
>>  doc/guides/nics/features/axgbe.ini |  14 +++
>>  doc/guides/nics/index.rst  |   1 +
>>  3 files changed, 226 insertions(+)
>>  create mode 100644 doc/guides/nics/axgbe.rst  create mode 100644 
>> doc/guides/nics/features/axgbe.ini
>> 
>> diff --git a/doc/guides/nics/axgbe.rst b/doc/guides/nics/axgbe.rst new 
>> file mode 100644 index 000..e9bebb8
>> --- /dev/null
>> +++ b/doc/guides/nics/axgbe.rst
>> @@ -0,0 +1,211 @@
>> +..  Copyright (c) 2017 Advanced Micro Devices, Inc.
>> +All rights reserved.
>> +
>> +AMD 10Gb Ethernet driver
>> +
>> +This file is available to you under your choice of the following two
>> +licenses:
>> +
>> +License 1: GPLv2
>> +
>> +Copyright (c) 2017 Advanced Micro Devices, Inc.
>> +
>> +This file is free software; you may copy, re
>
>Please use SPDX indentifiers for all files.
>
>Also "Modified BSD" must be BSD 3 Clause, not some modified BSD license 
>specific to AMD.
>
Hi Stephen,

Thanks for looking at the patches. We are aware of the license issue and our 
legal team is working on it. There are more than one parties involved here 
which is why it is taking longer than expected. 
The patch-sets are uploaded to get the source reviewed in parallel.

We will also look at the spdx identifiers. 

Regards,
Ravi

Re: [dpdk-dev] [PATCH v2] net/i40e: do not turn on flexible payload on driver init

[Xing, Beilei]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kirill Rybalchenko
> Sent: Friday, January 5, 2018 1:45 AM
> To: dev@dpdk.org
> Cc: Rybalchenko, Kirill ; Chilikin, Andrey
> ; Xing, Beilei ; Wu,
> Jingjing 
> Subject: [dpdk-dev] [PATCH v2] net/i40e: do not turn on flexible payload on
> driver init
> 
> Function i40e_GLQF_reg_init() overwrites global register for flexible payload,
> forcing extraction of first 16 bytes of
> L2/L3/L4 payload to the field vector even if flexible payload is not used by 
> an
> application. Such unconditional turn on of flexible payload effectively
> disables ability to use outer IP Destination address for RSS/FDIR for 
> tunnelled
> packets, as flexible payload overwrites outer IP destination address on the
> field vector.
> 
> Now flexible payload turned on only when flow director is enabled and
> configured.
> 
> v1:
> Global registers will be set only when payload is enabled.
> They will be reset if payload is disabled or on port reset (uninit).
> 
> v2:
> dev_init and dev_close disable flexible payload by default.
> Flexible payload enabled selectively, only if appropriate PIT is set up. The
> same done for FDIR and for rte_flow API.
> 
> Signed-off-by: Kirill Rybalchenko 
> ---
>  drivers/net/i40e/i40e_ethdev.c | 29 ++---
> drivers/net/i40e/i40e_ethdev.h |  1 +
>  drivers/net/i40e/i40e_fdir.c   | 14 +++---
>  drivers/net/i40e/i40e_flow.c   |  9 -
>  4 files changed, 38 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 811cc9f..b136120 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -701,17 +701,6 @@ RTE_PMD_REGISTER_KMOD_DEP(net_i40e, "*
> igb_uio | uio_pci_generic | vfio-pci");  static inline void
> i40e_GLQF_reg_init(struct i40e_hw *hw)  {
>   /*
> -  * Force global configuration for flexible payload
> -  * to the first 16 bytes of the corresponding L2/L3/L4 paylod.
> -  * This should be removed from code once proper
> -  * configuration API is added to avoid configuration conflicts
> -  * between ports of the same device.
> -  */
> - I40E_WRITE_REG(hw, I40E_GLQF_ORT(33), 0x00E0);
> - I40E_WRITE_REG(hw, I40E_GLQF_ORT(34), 0x00E3);
> - I40E_WRITE_REG(hw, I40E_GLQF_ORT(35), 0x00E6);
> -

Please also help to change the comment in eth_i40e_dev_init where 
i40e_GLQF_reg_init is involved, since this workaround is removed.

Apart from that,
Acked-by: Beilei Xing 

[dpdk-dev] Thread safety in rte_acl

[????????]

Hi, I have two questions : 1. Is it safe that multiple threads will run 
"rte_acl_classify" in parallel  (on the same ctx )? 2. Is it safe that one 
thread will run  "rte_acl_classify" when another thread tries to add new rules 
to same ctx? thanks,

Re: [dpdk-dev] [PATCH v9] net/i40e: determine number of queues per VF during run time

[Zhang, Helin]

> -Original Message-
> From: Dai, Wei
> Sent: Tuesday, December 26, 2017 11:25 PM
> To: Wu, Jingjing; Xing, Beilei; Zhang, Helin
> Cc: dev@dpdk.org; Dai, Wei
> Subject: [PATCH v9] net/i40e: determine number of queues per VF during run
> time
> 
> Without this patch, the number of queues per i40e  VF is defined as 4 by
> CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 in config/common_base.
> It is fixed value determined in building time and can't be changed during run
> time.
> With this patch, the number of queues per i40e VF can be determinated during
> run time. For example, if the PCI address of an i40e PF is :bb.cc, with 
> the
> EAL parameter -w :bb.cc,queue-num-per-vf=8 , the number of queues per
> VF created from this PF is 8.
> If there is no "queue-num-per-vf" setting in EAL parameters, it is 4 by 
> default as
> before. And if the value after the "queue-num-per-vf"
> is invalid, it is set as 4 forcibly. The valid values include 1, 2, 4, 8, 16 .
> 
> Signed-off-by: Wei Dai 
> Acked-by: Konstantin Ananyev 
> ---
> v9:
> v9 = v8+v7, is a complete version for maintainer's convenience.
> v8:
> As v7 patch has been accepted into dpdk-next-net-intel, this patch
> is based on v7 patch.
> add description in i40e document
> fix the last member of valid_keys[] for rte_kvargs_parse( )
> add RTE_PMD_REGISTER_PARAM_STRING for this feature
> v7:
> use the macro instead of natural number
> correct git log message as the EAL parameter is only valid for PF
> v6:
> fix a small bug when detecting end character of strtoul
> v5:
> fix git log message and WARNING of coding stype
> v4:
> use rte_kvargs instead of pervious parsing function;
> use malloc/free instead of rte_zmalloc/rte_free.
> v3:
> fix WARNING of coding style issues from checkpa...@dpdk.org
> v2:
> fix WARNING of coding style issues from checkpa...@dpdk.org
> ---
>  config/common_base |  1 -
>  doc/guides/nics/i40e.rst   | 12 ---
>  drivers/net/i40e/i40e_ethdev.c | 75
> +++---
>  3 files changed, 78 insertions(+), 10 deletions(-)

BTW, I think release notes should be updated for your modifications.

Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

[Guo, Jia]

add one more comment.


On 1/3/2018 1:02 AM, Matan Azrad wrote:

Hi Jeff

Maybe I'm touching in previous discussions but please see some 
comments\questions.

From: Jeff Guo:

This patch aim to add a general uevent mechanism in eal device layer,
to enable all linux kernel object hot plug monitoring, so user could use these
APIs to monitor and read out the device status info that sent from the kernel
side, then corresponding to handle it, such as detach or attach the
device, and even benefit to use it to do smoothly fail safe work.

1) About uevent monitoring:
a: add one epolling to poll the netlink socket, to monitor the uevent of
the device, add device_state in struct of rte_device, to identify the
device state machine.
b: add enum of rte_eal_dev_event_type and struct of rte_eal_uevent.
c: add below API in rte eal device common layer.
rte_eal_dev_monitor_enable
rte_dev_callback_register
rte_dev_callback_unregister
_rte_dev_callback_process
rte_dev_monitor_start
rte_dev_monitor_stop

2) About failure handler, use pci uio for example,
add pci_remap_device in bus layer and below function to process it:
rte_pci_remap_device
pci_uio_remap_resource
pci_map_private_resource
add rte_pci_dev_bind_driver to bind pci device with explicit driver.

Signed-off-by: Jeff Guo 
---
v7->v6:
a.modify vdev part according to the vdev rework
b.re-define and split the func into common and bus specific code
c.fix some incorrect issue.
b.fix the system hung after send packcet issue.
---
  drivers/bus/pci/bsd/pci.c  |  30 ++
  drivers/bus/pci/linux/pci.c|  87 +
  drivers/bus/pci/linux/pci_init.h   |   1 +
  drivers/bus/pci/pci_common.c   |  43 +++
  drivers/bus/pci/pci_common_uio.c   |  28 ++
  drivers/bus/pci/private.h  |  12 +
  drivers/bus/pci/rte_bus_pci.h  |  25 ++
  drivers/bus/vdev/vdev.c|  36 +++
  lib/librte_eal/bsdapp/eal/eal_dev.c|  64 
  .../bsdapp/eal/include/exec-env/rte_dev.h  | 106 ++
  lib/librte_eal/common/eal_common_bus.c |  30 ++
  lib/librte_eal/common/eal_common_dev.c | 169 ++
  lib/librte_eal/common/include/rte_bus.h|  69 
  lib/librte_eal/common/include/rte_dev.h|  89 ++
  lib/librte_eal/linuxapp/eal/Makefile   |   3 +-
  lib/librte_eal/linuxapp/eal/eal_alarm.c|   5 +
  lib/librte_eal/linuxapp/eal/eal_dev.c  | 356
+
  .../linuxapp/eal/include/exec-env/rte_dev.h| 106 ++
  lib/librte_eal/linuxapp/igb_uio/igb_uio.c  |   6 +
  lib/librte_pci/rte_pci.c   |  20 ++
  lib/librte_pci/rte_pci.h   |  17 +
  21 files changed, 1301 insertions(+), 1 deletion(-)
  create mode 100644 lib/librte_eal/bsdapp/eal/eal_dev.c
  create mode 100644 lib/librte_eal/bsdapp/eal/include/exec-env/rte_dev.h
  create mode 100644 lib/librte_eal/linuxapp/eal/eal_dev.c
  create mode 100644 lib/librte_eal/linuxapp/eal/include/exec-env/rte_dev.h

diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c
index b8e2178..d58dbf6 100644
--- a/drivers/bus/pci/bsd/pci.c
+++ b/drivers/bus/pci/bsd/pci.c
@@ -126,6 +126,29 @@ rte_pci_unmap_device(struct rte_pci_device *dev)
}
  }

+/* re-map pci device */
+int
+rte_pci_remap_device(struct rte_pci_device *dev)
+{
+   int ret;
+
+   if (dev == NULL)
+   return -EINVAL;
+
+   switch (dev->kdrv) {
+   case RTE_KDRV_NIC_UIO:
+   ret = pci_uio_remap_resource(dev);
+   break;
+   default:
+   RTE_LOG(DEBUG, EAL,
+   "  Not managed by a supported kernel driver,
skipped\n");
+   ret = 1;
+   break;
+   }
+
+   return ret;
+}
+
  void
  pci_uio_free_resource(struct rte_pci_device *dev,
struct mapped_pci_resource *uio_res)
@@ -678,3 +701,10 @@ rte_pci_ioport_unmap(struct rte_pci_ioport *p)

return ret;
  }
+
+int
+rte_pci_dev_bind_driver(const char *dev_name, const char *drv_type)
+{
+   return -1;
+}
+
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 5da6728..792fd2c 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -145,6 +145,38 @@ rte_pci_unmap_device(struct rte_pci_device *dev)
}
  }

+/* Map pci device */
+int
+rte_pci_remap_device(struct rte_pci_device *dev)
+{
+   int ret = -1;
+
+   if (dev == NULL)
+   return -EINVAL;
+
+   switch (dev->kdrv) {
+   case RTE_KDRV_VFIO:
+#ifdef VFIO_PRESENT
+   /* no thing to do */
+#endif
+   break;
+   case RTE_KDRV_IGB_UIO:
+   case RTE_KDRV_UIO_GENERIC:
+   if (rte_eal_using_phys_addrs()) {
+   /* map resources for 

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel filter fail problem

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Monday, January 8, 2018 1:09 PM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel filter fail problem
> 
> Hi,
> 
> > -Original Message-
> > From: Zhao1, Wei
> > Sent: Monday, January 8, 2018 11:36 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo ; Zhao1, Wei
> > 
> > Subject: [PATCH v2] net/ixgbe: fix tunnel filter fail problem
> >
> > Add a mode type check for tunnel mode, if fdir is in this mode, it do
> > not need to do Sanity check for x550.
> >
> > Fixes: a2ba854ec616b ("net/ixgbe: fix MAC VLAN filter fail problem")
> >
> > Signed-off-by: Wei Zhao 
> Acked-by: Wenzhuo Lu 
Applied to dpdk-next-net-intel, thanks!

/Helin

Re: [dpdk-dev] [PATCH v2] net/i40e: add fdir nvgre parameters check

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Friday, December 22, 2017 2:06 PM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: add fdir nvgre parameters check
> 
> 
> 
> > -Original Message-
> > From: Zhao1, Wei
> > Sent: Friday, December 22, 2017 1:11 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z ; Zhao1, Wei 
> > Subject: [PATCH v2] net/i40e: add fdir nvgre parameters check
> >
> > Add mask parameters check in nvgre parser for flow API.
> >
> > Fixes: 30965ca341278 ("net/i40e: add NVGRE flow parsing")
> >
> > Signed-off-by: Wei Zhao 
> Acked-by: Qi Zhang 
Applied to dpdk-next-net-intel, thanks!

/Helin

Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add Tx queues setup process

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ori Kam
> Sent: Wednesday, December 27, 2017 7:53 PM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add Tx queues
> setup process
> 
> 
> 
> > -Original Message-
> > From: Wei Zhao [mailto:wei.zh...@intel.com]
> > Sent: Wednesday, December 27, 2017 10:32 AM
> > To: dev@dpdk.org
> > Cc: Ori Kam ; Wei Zhao 
> > Subject: [PATCH v2] examples/flow_filtering: add Tx queues setup
> > process
> >
> > This example do not has the process of set up tx queues, but some NIC
> > start up process will be blocked if this is no tx queue and only rx
> > queues. So add tx queues setup process in main code.
> >
> > Signed-off-by: Wei Zhao 
> >
> > ---
> >
> > v2:
> > -add support the new tx offloads.
> > ---
> >  examples/flow_filtering/main.c | 26 ++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/examples/flow_filtering/main.c
> > b/examples/flow_filtering/main.c index 7d739b4..4a07b63 100644
> > --- a/examples/flow_filtering/main.c
> > +++ b/examples/flow_filtering/main.c
> > @@ -149,7 +149,18 @@ init_port(void)
> > /**< CRC stripped by hardware */
> > .hw_strip_crc   = 1,
> > },
> > +   .txmode = {
> > +   .offloads =
> > +   DEV_TX_OFFLOAD_VLAN_INSERT |
> > +   DEV_TX_OFFLOAD_IPV4_CKSUM  |
> > +   DEV_TX_OFFLOAD_UDP_CKSUM   |
> > +   DEV_TX_OFFLOAD_TCP_CKSUM   |
> > +   DEV_TX_OFFLOAD_SCTP_CKSUM  |
> > +   DEV_TX_OFFLOAD_TCP_TSO,
> > +   },
> > };
> > +   struct rte_eth_txconf txq_conf;
> > +   struct rte_eth_dev_info dev_info;
> >
> > printf(":: initializing port: %d\n", port_id);
> > ret = rte_eth_dev_configure(port_id, @@ -173,6 +184,21 @@
> > init_port(void)
> > }
> > }
> >
> > +   rte_eth_dev_info_get(port_id, &dev_info);
> > +   txq_conf = dev_info.default_txconf;
> > +   txq_conf.offloads = port_conf.txmode.offloads;
> > +
> > +   for (i = 0; i < nr_queues; i++) {
> > +   ret = rte_eth_tx_queue_setup(port_id, i, 512,
> > +   rte_eth_dev_socket_id(port_id),
> > +   &txq_conf);
> > +   if (ret < 0) {
> > +   rte_exit(EXIT_FAILURE,
> > +   ":: Tx queue setup failed: err=%d,
> > port=%u\n",
> > +   ret, port_id);
> > +   }
> > +   }
> > +
> > rte_eth_promiscuous_enable(port_id);
> > ret = rte_eth_dev_start(port_id);
> > if (ret < 0) {
> > --
> > 2.9.3
> 
> Acked-by: Ori Kam 
Applied to dpdk-next-net-intel, thanks!

/Helin

Re: [dpdk-dev] [PATCH v4 4/8] lib/librte_eventdev: extend the eventdev capability flags

[Jerin Jacob]

-Original Message-
> Date: Fri, 22 Dec 2017 11:23:46 +
> From: Liang Ma 
> To: jerin.ja...@caviumnetworks.com
> CC: dev@dpdk.org, harry.van.haa...@intel.com, bruce.richard...@intel.com,
>  deepak.k.j...@intel.com, john.ge...@intel.com, peter.mccar...@intel.com,
>  sea...@gmail.com
> Subject: [PATCH v4 4/8] lib/librte_eventdev: extend the eventdev capability

1) eventdev patches subject should start with eventdev:

2) Please check the rendered doxygen HTML output.
Command to generate doxygen documentation:
make doc-api-html


>  flags
> X-Mailer: git-send-email 2.7.5
> 
> this commitd add three new eventdev capability flags

How about change to,

Add new capability flags to express the opdl PMD limitations.

> 
> RTE_EVENT_DEV_CAP_NONSEQ_MODE
> 
> Event device is capable of operating in none sequential mode. The path
> of the event is not necessary to be sequential. Application can change
> the path of event at runtime.if the flag is not set, then event each event
> will follow a path from queue 0 to queue 1 to queue 2 etc. If the flag is
> set, events may be sent to queues in any order.If the flag is not set, the
> eventdev will return an error when the application enqueues an event for a
> qid which is not the next in the sequence.
> 
> RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
> 
> Event device is capable of configuring the queue/port link at runtime.
> if the flag is not set, the eventdev queue/port linkis only can be

s/linkis/link is

> configured during  initialization.
> 
> RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
> 
> Event device is capable of setting up the link between multiple queue
> with single port. if  the flag is not set, the eventdev can only map a

Additional space between "if" and "the"

> single queue to each port or map a signle queue to many port.

s/signle/single

> 
> Signed-off-by: Liang Ma 
> Signed-off-by: Peter Mccarthy 
> ---
>  lib/librte_eventdev/rte_eventdev.h | 22 ++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev.h 
> b/lib/librte_eventdev/rte_eventdev.h
> index 1bbea57..91fd4ef 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -293,6 +293,28 @@ struct rte_mbuf; /* we just use mbuf pointers; no need 
> to include rte_mbuf.h */
>   * @see rte_event_dequeue_burst() rte_event_enqueue_burst()
>   */
>  
> +#define RTE_EVENT_DEV_CAP_NONSEQ_MODE (1ULL << 6)
> +/**< Event device is capable of operating in none sequential mode. The path
> + * of the event is not necessary to be sequential. Application can change
> + * the path of event at runtime.if the flag is not set, then event each event
> + * will follow a path from queue 0 to queue 1 to queue 2 etc. If the flag is
> + * set, events may be sent to queues in any order.If the flag is not set, the
> + * eventdev will return an error when the application enqueues an event for a
> + * qid which is not the next in the sequence.
> + */
> +
> +#define RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK   (1ULL << 7)
> +/**< Event device is capable of configuring the queue/port link at runtime.
> + * if the flag is not set, the eventdev queue/port link is only can be
> + * configured during  initialization.
> + */
> +
> +#define RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT (1ULL << 8)
> +/**< Event device is capable of setting up the link between multiple queue
> + * with single port. if  the flag is not set, the eventdev can only map a

Additional space between "if" and "the"

> + * single queue to each port or map a signle queue to many port.

s/signle/single

> + */
> +
>  /* Event device priority levels */
>  #define RTE_EVENT_DEV_PRIORITY_HIGHEST   0
>  /**< Highest priority expressed across eventdev subsystem
> -- 
> 2.7.5

With above changes:
Acked-by: Jerin Jacob 

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

[Zhang, Helin]

Hi Developers and maintainers

Could you help to address the comments from Igor?

Regards,
Helin

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Igor Ryzhov
> Sent: Friday, January 5, 2018 8:35 PM
> To: Olivier Matz
> Cc: dev@dpdk.org; Wu, Jingjing; Xing, Beilei; sta...@dpdk.org; Laurent Hardy
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary 
> address
> change
> 
> Thank you for the patch! Comments inline.
> 
> On Wed, Jan 3, 2018 at 5:29 PM, Olivier Matz 
> wrote:
> >
> >  drivers/net/i40e/i40e_ethdev.c | 29 +
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_
> > ethdev.c index 811cc9ffe..e7d070879 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -10818,12 +10818,41 @@ static void i40e_set_default_mac_addr(struct
> > rte_eth_dev *dev,
> >   struct ether_addr *mac_addr)  {
> > struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->
> > data->dev_private);
> > +   struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->
> > data->dev_private);
> > +   struct i40e_vsi *vsi = pf->main_vsi;
> > +   struct i40e_mac_filter_info mac_filter;
> > +   struct i40e_mac_filter *f;
> > +   int ret;
> >
> > if (!is_valid_assigned_ether_addr(mac_addr)) {
> > PMD_DRV_LOG(ERR, "Tried to set invalid MAC address.");
> > return;
> > }
> >
> >
> Is following check really necessary here?
> i40e_vsi_delete_mac(vsi, &pf->dev_addr) will do absolutely the same.
> 
> +   TAILQ_FOREACH(f, &vsi->mac_list, next) {
> > +   if (is_same_ether_addr(&pf->dev_addr,
> > &f->mac_info.mac_addr))
> > +   break;
> > +   }
> > +
> > +   if (f == NULL) {
> > +   PMD_DRV_LOG(ERR, "Failed to find filter for default mac");
> > +   return;
> > +   }
> > +
> > +   mac_filter = f->mac_info;
> > +   ret = i40e_vsi_delete_mac(vsi, &mac_filter.mac_addr);
> > +   if (ret != I40E_SUCCESS) {
> > +   PMD_DRV_LOG(ERR, "Failed to delete mac filter");
> > +   return;
> > +   }
> > +   memcpy(&mac_filter.mac_addr, mac_addr, ETH_ADDR_LEN);
> >
> 
> Shouldn't mac_filter.filter_type be set to RTE_MACVLAN_PERFECT_MATCH?
> 
> 
> > +   ret = i40e_vsi_add_mac(vsi, &mac_filter);
> > +   if (ret != I40E_SUCCESS) {
> > +   PMD_DRV_LOG(ERR, "Failed to add mac filter");
> > +   return;
> > +   }
> > +   memcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN);
> > +
> > /* Flags: 0x3 updates port address */
> >
> 
> In Linux driver I40E_AQC_WRITE_TYPE_LAA_WOL is used as a flag instead of
> 0x3.
> Shouldn't we use the same flag?
> 
> 
> > i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes,
> > NULL);  }
> > --
> > 2.11.0
> >
> >
> Best regards,
> Igor

Re: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address on i40evf

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei
> Sent: Thursday, January 4, 2018 3:40 PM
> To: Olivier Matz; dev@dpdk.org; Wu, Jingjing
> Cc: sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address on
> i40evf
> 
> 
> > -Original Message-
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Wednesday, January 3, 2018 9:34 PM
> > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei
> > 
> > Cc: sta...@dpdk.org
> > Subject: [PATCH v2] net/i40e: fix setting of MAC address on i40evf
> >
> > When setting the MAC address, the ethdev layer copies the new mac
> > address in dev->data->mac_addrs[0] before calling the dev_ops.
> >
> > Therefore, "is_same_ether_addr(mac_addr, dev->data->mac_addrs)" was
> > always true, and the MAC was never set. Remove this test to fix the issue.
> >
> > Fixes: 943c2d899a0c ("net/i40e: set VF MAC from VF")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Olivier Matz 
> 
> Acked-by: Beilei Xing , thanks for the fix.
Applied to dpdk-next-net-intel, thanks!

/Helin

Re: [dpdk-dev] [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure library

[Jerin Jacob]

-Original Message-
> Date: Fri, 22 Dec 2017 16:02:42 +
> From: Sean Harte 
> To: Liang Ma 
> Cc: jerin.ja...@caviumnetworks.com, dev@dpdk.org,
>  harry.van.haa...@intel.com, Bruce Richardson ,
>  deepak.k.j...@intel.com, john.ge...@intel.com, "Mccarthy, Peter"
>  
> Subject: Re: [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure
>  library
> 
> On 22 December 2017 at 11:23, Liang Ma  wrote:
> >
> > OPDL ring is the core infrastructure of OPDL PMD. OPDL ring library
> > provide the core data structure and core helper function set. The Ring
> > implements a single ring multi-port/stage pipelined packet distribution
> > mechanism. This mechanism has the following characteristics:
> >
> > • No multiple queue cost, therefore, latency is significant reduced.
> > • Fixed dependencies between queue/ports is more suitable for complex.
> >   fixed pipelines of stateless packet processing (static pipeline).
> > • Has decentralized distribution (no scheduling core).
> > • Packets remain in order (no reorder core(s)).
> > * Update build system to enable compilation.
> >
> > Signed-off-by: Liang Ma 
> > Signed-off-by: Peter Mccarthy 
> > ---
> >  config/common_base|6 +
> >  drivers/event/Makefile|1 +
> >  drivers/event/opdl/Makefile   |   62 +
> >  drivers/event/opdl/opdl_log.h |   59 +
> >  drivers/event/opdl/opdl_ring.c| 1252 
> > +
> >  drivers/event/opdl/opdl_ring.h|  628 +++
> >  drivers/event/opdl/rte_pmd_evdev_opdl_version.map |3 +
> >  mk/rte.app.mk |1 +
> >  mk/toolchain/gcc/rte.toolchain-compat.mk  |6 +
> >  mk/toolchain/icc/rte.toolchain-compat.mk  |6 +
> >  10 files changed, 2024 insertions(+)
> >  create mode 100644 drivers/event/opdl/Makefile
> >  create mode 100644 drivers/event/opdl/opdl_log.h
> >  create mode 100644 drivers/event/opdl/opdl_ring.c
> >  create mode 100644 drivers/event/opdl/opdl_ring.h
> >  create mode 100644 drivers/event/opdl/rte_pmd_evdev_opdl_version.map
> 
> [...]
> 
> Reviewed-by: Seán Harte 

I think, the series is not addressed all the v3 comments. I think, the
missing ones are

1) Use dynamic logging
2) Split the patches based on eventdev ops:
example:
See the example from latest dpaa eventdev driver:
http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=Sunil

3) Fix check-patch and check-git-log.sh errors.

Wrong headline format:
doc:update 18.02 release notes
Wrong headline prefix:
eventdev/opdl: opdl eventdev pmd unit test function
event/*: apply the three new capability flags for
sw/dppa2/octeontx
Wrong headline lowercase:
event/opdl: add the opdl pmd main body and helper function
eventdev/opdl: opdl eventdev pmd unit test function
event/*: apply the three new capability flags for
sw/dppa2/octeontx
maintainers: add the opdl pmd maintainer information
doc: add eventdev opdl pmd docuement
Headline too long:
event/*: apply the three new capability flags for
sw/dppa2/octeontx

### event/opdl: add the opdl ring infrastructure library

WARNING:LONG_LINE: line over 80 characters
#451: FILE: drivers/event/opdl/opdl_ring.c:260:
+   PMD_DRV_LOG(ERR, "%u entries is more than max (%u)", n,
s->num_slots);

WARNING:LONG_LINE: line over 80 characters
#1202: FILE: drivers/event/opdl/opdl_ring.c:1011:
+   ev_orig = (struct rte_event *)get_slot(t,
s->shadow_head+i);

WARNING:LONG_LINE: line over 80 characters
#1203: FILE: drivers/event/opdl/opdl_ring.c:1012:
+   if ((ev_orig->flow_id%s->nb_instance) ==
s->instance_id) {

WARNING:LONG_LINE: line over 80 characters
#1206: FILE: drivers/event/opdl/opdl_ring.c:1015:
+   if
((ev_orig->event&OPDL_EVENT_MASK) != ev_temp) {

total: 0 errors, 4 warnings, 2049 lines checked

### event/opdl: add the opdl pmd main body and helper function

WARNING:LONG_LINE: line over 80 characters
#1489: FILE: drivers/event/opdl/opdl_evdev_init.c:301:
+   opdl_ring_cas_slot(p->enq_stage_inst, &ev[i], i,
p->atomic_claim);

WARNING:LONG_LINE: line over 80 characters
#2027: FILE: drivers/event/opdl/opdl_evdev_init.c:839:
+
opdl_pmd_dev_id(port->opdl),

WARNING:LONG_LINE: line over 80 characters
#2056: FILE: drivers/event/opdl/opdl_evdev_init.c:868:
+
opdl_pmd_dev_id(port->opdl),

total: 0 errors, 3 warnings, 2309 lines checked

### eventdev/opdl: opdl eventdev pmd unit test function

WARNING:LONG_LINE: line over 80 characters
#247: FILE: drivers/event/opdl/opdl_test.c:189:
+   PMD_DRV_LOG(ERR, "%d: error creating qid %d\n ",
__LINE__, i);

WARNING:LONG_LINE: line over 80 characters
#314: FILE: drivers/event/opdl/opdl_test.c:256:
+   PMD_DRV_LOG(ERR, "%d: error mapping lb qid\n",
__LINE__);

WARNING:L

[dpdk-dev] [PATCH v2] doc: add i40e update

[Beilei Xing]

Update release note to declare MPLSoUDP/MPLSoGRE/
GTP-U/GTP-C/PPPoE/PPPoL2TP steering support in i40e
driver.
Update i40e.rst to declare DDP support and input set
configuration.

Signed-off-by: Beilei Xing 
---

v2 changes:
 - Add DDP support and input set configuration in i40e.rst.

 doc/guides/nics/i40e.rst   | 47 ++
 doc/guides/rel_notes/release_18_02.rst | 31 ++
 2 files changed, 78 insertions(+)

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 2507d5f..789d6d6 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -65,6 +65,7 @@ Features of the I40E PMD are:
 - Hot plug
 - IEEE1588/802.1AS timestamping
 - VF Daemon (VFD) - EXPERIMENTAL
+- Dynamic Device Personalization (DDP)
 
 
 Prerequisites
@@ -374,6 +375,52 @@ configuration passed on the EAL command line.
 The floating VEB functionality requires a NIC firmware version of 5.0
 or greater.
 
+Dynamic Device Personalization (DDP)
+
+
+The Intel® Ethernet Controller X*710 support a feature called "Dynamic Device
+Personalization (DDP)", which is used to configure hardware by downloading
+a profile to support protocols/filters which are not supported by default.
+The DDP functionality requires a NIC firmware version of 6.0 or greater.
+
+Current implementation supports MPLSoUDP/MPLSoGRE/GTP-C/GTP-U/PPPoE/PPPoL2TP,
+steering can be used with rte_flow API.
+
+Load a profile which supports MPLSoUDP/MPLSoGRE:
+
+.. code-block:: console
+
+   testpmd> ddp add 0 ./mpls.pkgo
+
+Delete a MPLS profile:
+
+.. code-block:: console
+
+   testpmd> ddp del 0 ./mpls.pkgo
+
+Get loaded DDP package info list:
+
+.. code-block:: console
+
+   testpmd> ddp get list 0
+
+Display information about a MPLS profile:
+
+.. code-block:: console
+
+   testpmd> ddp get info ./mpls.pkgo
+
+Input set configuration
+~~~
+Input set for any PCTYPE can be configured with user defined configuration,
+For example, to use only 48bit prefix for IPv6 src address for IPv6 TCP RSS:
+
+.. code-block:: console
+
+   testpmd> port config 0 pctype 43 hash_inset clear all
+   testpmd> port config 0 pctype 43 hash_inset set field 13
+   testpmd> port config 0 pctype 43 hash_inset set field 14
+   testpmd> port config 0 pctype 43 hash_inset set field 15
 
 Limitations or Known issues
 ---
diff --git a/doc/guides/rel_notes/release_18_02.rst 
b/doc/guides/rel_notes/release_18_02.rst
index 621b8f5..b016c54 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -47,6 +47,37 @@ New Features
   users. According to the device configuration, it will setup TX->RX loopback
   link or not.
 
+* **Updated i40e driver to support MPLSoUDP/MPLSoGRE.**
+
+  Updated i40e PMD to support MPLSoUDP/MPLSoGRE with MPLSoUDP/MPLSoGRE
+  supporting profiles which can be programmed by dynamic device
+  personalization (DDP) process:
+
+  * Support cloud filer of MPLSoUDP/MPLSoGRE flow based on MPLS label.
+
+  This feature was implemented in release_17_05.
+
+* **Updated i40e driver to support GTP-C/GTP-U.**
+
+  Updated i40e PMD to support GTP-C/GTP-U with GTP-C/GTP-U supporting
+  profiles which can be programmed by dynamic device personalization (DDP)
+  process:
+
+  * Support RSS of GTP-C/GTP-U flow.
+  * Support flow director of GTP-C/GTP-U flow based on TEID.
+  * Support cloud filer of GTP-C/GTP-U flow based on TEID.
+
+  This feature was implemented in release_17_11, and only GTPv1 is supported.
+
+* **Updated i40e driver to support PPPoE/PPPoL2TP.**
+
+  Updated i40e PMD to support PPPoE/PPPoL2TP with PPPoE/PPPoL2TP supporting
+  profiles which can be programmed by dynamic device personalization (DDP)
+  process:
+
+  * Support RSS of PPPoE/PPPoL2TP flow based on user defined input set.
+  * Support FDIR of PPPoE/PPPoL2TP flow based on user defined input set.
+
 API Changes
 ---
 
-- 
2.5.5