[dpdk-dev] [PATCH 1/2] net/mlx5: modify PMD args process
Currently the argument process is done without indication which
parameter was forced by the application and which one is on it
default value.
This becomes problematic when different features requires different
defaults. For example, Enhanced multi packet send and TSO.
This commit modifies the argument process, enabling to differ
which parameter was forced by the application.
Signed-off-by: Shahaf Shuler
Acked-by: Yongseok Koh
---
drivers/net/mlx5/mlx5.c | 72 +
1 file changed, 61 insertions(+), 11 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index b7eb9b56a..9d850dbbd 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -93,6 +93,18 @@
/* Device parameter to enable hardware TSO offload. */
#define MLX5_TSO "tso"
+/* Default PMD specific parameter value. */
+#define MLX5_UNSET (-1)
+
+struct mlx5_args {
+ int cqe_comp;
+ int txq_inline;
+ int txqs_inline;
+ int mps;
+ int mpw_hdr_dseg;
+ int inline_max_packet_sz;
+ int tso;
+};
/**
* Retrieve integer value from environment variable.
*
@@ -286,7 +298,7 @@ mlx5_dev_idx(struct rte_pci_addr *pci_addr)
static int
mlx5_args_check(const char *key, const char *val, void *opaque)
{
- struct priv *priv = opaque;
+ struct mlx5_args *args = opaque;
unsigned long tmp;
errno = 0;
@@ -296,19 +308,19 @@ mlx5_args_check(const char *key, const char *val, void
*opaque)
return errno;
}
if (strcmp(MLX5_RXQ_CQE_COMP_EN, key) == 0) {
- priv->cqe_comp = !!tmp;
+ args->cqe_comp = !!tmp;
} else if (strcmp(MLX5_TXQ_INLINE, key) == 0) {
- priv->txq_inline = tmp;
+ args->txq_inline = tmp;
} else if (strcmp(MLX5_TXQS_MIN_INLINE, key) == 0) {
- priv->txqs_inline = tmp;
+ args->txqs_inline = tmp;
} else if (strcmp(MLX5_TXQ_MPW_EN, key) == 0) {
- priv->mps = !!tmp ? priv->mps : MLX5_MPW_DISABLED;
+ args->mps = !!tmp;
} else if (strcmp(MLX5_TXQ_MPW_HDR_DSEG_EN, key) == 0) {
- priv->mpw_hdr_dseg = !!tmp;
+ args->mpw_hdr_dseg = !!tmp;
} else if (strcmp(MLX5_TXQ_MAX_INLINE_LEN, key) == 0) {
- priv->inline_max_packet_sz = tmp;
+ args->inline_max_packet_sz = tmp;
} else if (strcmp(MLX5_TSO, key) == 0) {
- priv->tso = !!tmp;
+ args->tso = !!tmp;
} else {
WARN("%s: unknown parameter", key);
return -EINVAL;
@@ -328,7 +340,7 @@ mlx5_args_check(const char *key, const char *val, void
*opaque)
* 0 on success, errno value on failure.
*/
static int
-mlx5_args(struct priv *priv, struct rte_devargs *devargs)
+mlx5_args(struct mlx5_args *args, struct rte_devargs *devargs)
{
const char **params = (const char *[]){
MLX5_RXQ_CQE_COMP_EN,
@@ -354,7 +366,7 @@ mlx5_args(struct priv *priv, struct rte_devargs *devargs)
for (i = 0; (params[i] != NULL); ++i) {
if (rte_kvargs_count(kvlist, params[i])) {
ret = rte_kvargs_process(kvlist, params[i],
-mlx5_args_check, priv);
+mlx5_args_check, args);
if (ret != 0) {
rte_kvargs_free(kvlist);
return ret;
@@ -368,6 +380,34 @@ mlx5_args(struct priv *priv, struct rte_devargs *devargs)
static struct eth_driver mlx5_driver;
/**
+ * Assign parameters from args into priv, only non default
+ * values are considered.
+ *
+ * @param[out] priv
+ * Pointer to private structure.
+ * @param[in] args
+ * Pointer to args values.
+ */
+static void
+mlx5_args_assign(struct priv *priv, struct mlx5_args *args)
+{
+ if (args->cqe_comp != MLX5_UNSET)
+ priv->cqe_comp = args->cqe_comp;
+ if (args->txq_inline != MLX5_UNSET)
+ priv->txq_inline = args->txq_inline;
+ if (args->txqs_inline != MLX5_UNSET)
+ priv->txqs_inline = args->txqs_inline;
+ if (args->mps != MLX5_UNSET)
+ priv->mps = args->mps ? priv->mps : 0;
+ if (args->mpw_hdr_dseg != MLX5_UNSET)
+ priv->mpw_hdr_dseg = args->mpw_hdr_dseg;
+ if (args->inline_max_packet_sz != MLX5_UNSET)
+ priv->inline_max_packet_sz = args->inline_max_packet_sz;
+ if (args->tso != MLX5_UNSET)
+ priv->tso = args->tso;
+}
+
+/**
* DPDK callback to register a PCI device.
*
* This function creates an Ethernet device for each port of a given
@@ -502,6 +542,15 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct
rte_pci_device *pci_dev)
struct ibv_exp_device_attr exp_device_attr;
struct ether_addr mac;
uint16_t n
[dpdk-dev] [PATCH 2/2] net/mlx5: fix PMD specific parameters defaults
With the Enhanced multi packet send addition, the defaults were made
in order to get the maximum out of the box performance.
Features like tso, don't use the enhanced send, however the defaults
are still valid. This cause Tx queue creation to fail.
Fixes: aea00c008140 ("net/mlx5: add hardware TSO support")
Signed-off-by: Shahaf Shuler
Signed-off-by: Raslan Darawsheh
Acked-by: Yongseok Koh
---
drivers/net/mlx5/mlx5.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 9d850dbbd..faf0d3926 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -610,13 +610,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct
rte_pci_device *pci_dev)
priv->pd = pd;
priv->mtu = ETHER_MTU;
priv->mps = mps; /* Enable MPW by default if supported. */
- /* Set default values for Enhanced MPW, a.k.a MPWv2. */
- if (mps == MLX5_MPW_ENHANCED) {
- priv->mpw_hdr_dseg = 0;
- priv->txqs_inline = MLX5_EMPW_MIN_TXQS;
- priv->inline_max_packet_sz = MLX5_EMPW_MAX_INLINE_LEN;
- priv->txq_inline = MLX5_WQE_SIZE_MAX - MLX5_WQE_SIZE;
- }
priv->cqe_comp = 1; /* Enable compression by default. */
priv->tunnel_en = tunnel_en;
err = mlx5_args(&args, pci_dev->device.devargs);
@@ -688,6 +681,17 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct
rte_pci_device *pci_dev)
INFO("%sMPS is %s",
priv->mps == MLX5_MPW_ENHANCED ? "Enhanced " : "",
priv->mps != MLX5_MPW_DISABLED ? "enabled" : "disabled");
+ /* Set default values for Enhanced MPW, a.k.a MPWv2. */
+ if (priv->mps == MLX5_MPW_ENHANCED) {
+ if (args.txqs_inline == MLX5_UNSET)
+ priv->txqs_inline = MLX5_EMPW_MIN_TXQS;
+ if (args.inline_max_packet_sz == MLX5_UNSET)
+ priv->inline_max_packet_sz =
+ MLX5_EMPW_MAX_INLINE_LEN;
+ if (args.txq_inline == MLX5_UNSET)
+ priv->txq_inline = MLX5_WQE_SIZE_MAX -
+ MLX5_WQE_SIZE;
+ }
/* Allocate and register default RSS hash keys. */
priv->rss_conf = rte_calloc(__func__, hash_rxq_init_n,
sizeof((*priv->rss_conf)[0]), 0);
--
2.12.0
[dpdk-dev] [PATCH] examples/vhost: fix the use of strnlen()
The return value of strnlen(s, maxlen) is never bigger than maxlen.
Signed-off-by: jiangg
---
examples/vhost/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index aa88733..e07f866 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -396,7 +396,7 @@ static int
us_vhost_parse_socket_path(const char *q_arg)
{
/* parse number string */
- if (strnlen(q_arg, PATH_MAX) > PATH_MAX)
+ if (strnlen(q_arg, PATH_MAX) == PATH_MAX)
return -1;
socket_files = realloc(socket_files, PATH_MAX * (nb_sockets + 1));
--
2.7.4
[dpdk-dev] [PATCH] examples/performance-thread: add c++ ifdefs
Signed-off-by: Keith Wiles
---
examples/performance-thread/common/arch/x86/ctx.h | 8
examples/performance-thread/common/lthread.h | 8
examples/performance-thread/common/lthread_api.h | 8
examples/performance-thread/common/lthread_cond.h | 8
examples/performance-thread/common/lthread_diag.h | 9 +
examples/performance-thread/common/lthread_diag_api.h | 8
examples/performance-thread/common/lthread_int.h | 8
examples/performance-thread/common/lthread_mutex.h| 8
examples/performance-thread/common/lthread_objcache.h | 7 +++
examples/performance-thread/common/lthread_pool.h | 7 +++
examples/performance-thread/common/lthread_queue.h| 7 +++
examples/performance-thread/common/lthread_sched.h| 7 +++
examples/performance-thread/common/lthread_timer.h| 7 +++
examples/performance-thread/common/lthread_tls.h | 7 +++
14 files changed, 107 insertions(+)
mode change 100644 => 100755 examples/performance-thread/common/arch/x86/ctx.h
diff --git a/examples/performance-thread/common/arch/x86/ctx.h
b/examples/performance-thread/common/arch/x86/ctx.h
old mode 100644
new mode 100755
index 03860508e..a41ce05a5
--- a/examples/performance-thread/common/arch/x86/ctx.h
+++ b/examples/performance-thread/common/arch/x86/ctx.h
@@ -35,6 +35,10 @@
#ifndef CTX_H
#define CTX_H
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/*
* CPU context registers
*/
@@ -54,4 +58,8 @@ void
ctx_switch(struct ctx *new_ctx, struct ctx *curr_ctx);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* RTE_CTX_H_ */
diff --git a/examples/performance-thread/common/lthread.h
b/examples/performance-thread/common/lthread.h
index 8c77af82e..5c2c1a5f0 100644
--- a/examples/performance-thread/common/lthread.h
+++ b/examples/performance-thread/common/lthread.h
@@ -62,6 +62,10 @@
#ifndef LTHREAD_H_
#define LTHREAD_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include
#include "lthread_api.h"
@@ -96,4 +100,8 @@ _lthread_init(struct lthread *lt,
void _lthread_set_stack(struct lthread *lt, void *stack, size_t stack_size);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_H_ */
diff --git a/examples/performance-thread/common/lthread_api.h
b/examples/performance-thread/common/lthread_api.h
index ec976103f..ff245a082 100644
--- a/examples/performance-thread/common/lthread_api.h
+++ b/examples/performance-thread/common/lthread_api.h
@@ -124,6 +124,10 @@
#ifndef LTHREAD_H
#define LTHREAD_H
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include
#include
#include
@@ -829,4 +833,8 @@ int lthread_cond_signal(struct lthread_cond *c);
*/
int lthread_cond_broadcast(struct lthread_cond *c);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_H */
diff --git a/examples/performance-thread/common/lthread_cond.h
b/examples/performance-thread/common/lthread_cond.h
index 5bd02a7dc..5e5f14be9 100644
--- a/examples/performance-thread/common/lthread_cond.h
+++ b/examples/performance-thread/common/lthread_cond.h
@@ -62,6 +62,10 @@
#ifndef LTHREAD_COND_H_
#define LTHREAD_COND_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include "lthread_queue.h"
#define MAX_COND_NAME_SIZE 64
@@ -74,4 +78,8 @@ struct lthread_cond {
uint64_t diag_ref; /* optional ref to user diag data */
} __rte_cache_aligned;
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_COND_H_ */
diff --git a/examples/performance-thread/common/lthread_diag.h
b/examples/performance-thread/common/lthread_diag.h
index 2877d311c..3dce8e0eb 100644
--- a/examples/performance-thread/common/lthread_diag.h
+++ b/examples/performance-thread/common/lthread_diag.h
@@ -34,6 +34,10 @@
#ifndef LTHREAD_DIAG_H_
#define LTHREAD_DIAG_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include
#include
@@ -129,4 +133,9 @@ extern uint64_t diag_mask;
#define DIAG_USED __rte_unused
#endif /* LTHREAD_DIAG */
+
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_DIAG_H_ */
diff --git a/examples/performance-thread/common/lthread_diag_api.h
b/examples/performance-thread/common/lthread_diag_api.h
index 7ee514f8b..2fda0951f 100644
--- a/examples/performance-thread/common/lthread_diag_api.h
+++ b/examples/performance-thread/common/lthread_diag_api.h
@@ -33,6 +33,10 @@
#ifndef LTHREAD_DIAG_API_H_
#define LTHREAD_DIAG_API_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include
#include
@@ -322,4 +326,8 @@ lthread_cond_diag_ref(struct lthread_cond *c);
uint64_t
lthread_mutex_diag_ref(struct lthread_mutex *m);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_DIAG_API_H_ */
diff --git a/examples/performance-thread/common/lthread_int.h
b/examples/performance-thread/common/lthread_int.h
index 031d8afc4..3f7fb92df 100644
--- a/examples/performance-thread/common/lthread_int.h
+++
[dpdk-dev] [PATCH v2] examples/performance-thread: add c++ ifdefs
Signed-off-by: Keith Wiles
---
v2 - change ctx.h to be 664 permissions.
examples/performance-thread/common/arch/x86/ctx.h | 8
examples/performance-thread/common/lthread.h | 8
examples/performance-thread/common/lthread_api.h | 8
examples/performance-thread/common/lthread_cond.h | 8
examples/performance-thread/common/lthread_diag.h | 9 +
examples/performance-thread/common/lthread_diag_api.h | 8
examples/performance-thread/common/lthread_int.h | 8
examples/performance-thread/common/lthread_mutex.h| 8
examples/performance-thread/common/lthread_objcache.h | 7 +++
examples/performance-thread/common/lthread_pool.h | 7 +++
examples/performance-thread/common/lthread_queue.h| 7 +++
examples/performance-thread/common/lthread_sched.h| 7 +++
examples/performance-thread/common/lthread_timer.h| 7 +++
examples/performance-thread/common/lthread_tls.h | 7 +++
14 files changed, 107 insertions(+)
diff --git a/examples/performance-thread/common/arch/x86/ctx.h
b/examples/performance-thread/common/arch/x86/ctx.h
index 03860508e..a41ce05a5 100644
--- a/examples/performance-thread/common/arch/x86/ctx.h
+++ b/examples/performance-thread/common/arch/x86/ctx.h
@@ -35,6 +35,10 @@
#ifndef CTX_H
#define CTX_H
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/*
* CPU context registers
*/
@@ -54,4 +58,8 @@ void
ctx_switch(struct ctx *new_ctx, struct ctx *curr_ctx);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* RTE_CTX_H_ */
diff --git a/examples/performance-thread/common/lthread.h
b/examples/performance-thread/common/lthread.h
index 8c77af82e..5c2c1a5f0 100644
--- a/examples/performance-thread/common/lthread.h
+++ b/examples/performance-thread/common/lthread.h
@@ -62,6 +62,10 @@
#ifndef LTHREAD_H_
#define LTHREAD_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include
#include "lthread_api.h"
@@ -96,4 +100,8 @@ _lthread_init(struct lthread *lt,
void _lthread_set_stack(struct lthread *lt, void *stack, size_t stack_size);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_H_ */
diff --git a/examples/performance-thread/common/lthread_api.h
b/examples/performance-thread/common/lthread_api.h
index ec976103f..ff245a082 100644
--- a/examples/performance-thread/common/lthread_api.h
+++ b/examples/performance-thread/common/lthread_api.h
@@ -124,6 +124,10 @@
#ifndef LTHREAD_H
#define LTHREAD_H
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include
#include
#include
@@ -829,4 +833,8 @@ int lthread_cond_signal(struct lthread_cond *c);
*/
int lthread_cond_broadcast(struct lthread_cond *c);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_H */
diff --git a/examples/performance-thread/common/lthread_cond.h
b/examples/performance-thread/common/lthread_cond.h
index 5bd02a7dc..5e5f14be9 100644
--- a/examples/performance-thread/common/lthread_cond.h
+++ b/examples/performance-thread/common/lthread_cond.h
@@ -62,6 +62,10 @@
#ifndef LTHREAD_COND_H_
#define LTHREAD_COND_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include "lthread_queue.h"
#define MAX_COND_NAME_SIZE 64
@@ -74,4 +78,8 @@ struct lthread_cond {
uint64_t diag_ref; /* optional ref to user diag data */
} __rte_cache_aligned;
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_COND_H_ */
diff --git a/examples/performance-thread/common/lthread_diag.h
b/examples/performance-thread/common/lthread_diag.h
index 2877d311c..3dce8e0eb 100644
--- a/examples/performance-thread/common/lthread_diag.h
+++ b/examples/performance-thread/common/lthread_diag.h
@@ -34,6 +34,10 @@
#ifndef LTHREAD_DIAG_H_
#define LTHREAD_DIAG_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include
#include
@@ -129,4 +133,9 @@ extern uint64_t diag_mask;
#define DIAG_USED __rte_unused
#endif /* LTHREAD_DIAG */
+
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_DIAG_H_ */
diff --git a/examples/performance-thread/common/lthread_diag_api.h
b/examples/performance-thread/common/lthread_diag_api.h
index 7ee514f8b..2fda0951f 100644
--- a/examples/performance-thread/common/lthread_diag_api.h
+++ b/examples/performance-thread/common/lthread_diag_api.h
@@ -33,6 +33,10 @@
#ifndef LTHREAD_DIAG_API_H_
#define LTHREAD_DIAG_API_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#include
#include
@@ -322,4 +326,8 @@ lthread_cond_diag_ref(struct lthread_cond *c);
uint64_t
lthread_mutex_diag_ref(struct lthread_mutex *m);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* LTHREAD_DIAG_API_H_ */
diff --git a/examples/performance-thread/common/lthread_int.h
b/examples/performance-thread/common/lthread_int.h
index 031d8afc4..3f7fb92df 100644
--- a/examples/performance-thread/common/lthread_int.h
+++ b/examples/performance-thread/common/lthread_int.h
@@ -62,6 +62
Re: [dpdk-dev] Q on IXGBE and I40E vector Tx processing
Hi, The reason I am asking I because I have tried different combinations of scalar and vector Tx and Rx processing for both IXGBE and I40E with following results 1. Vector Rx and Vector Tx gives best performance but can only support packet size of less than or equal to 2048 bytes 2. Scalar Rx and Scalar Tx works for all packet size but with degraded performance 3. Vector Rx and Scalar Tx (with certain PMD configuration) works fine (performance doesn't meet '1') but it has an inherent bug for packet size 8192 bytes as PMD stops packet processing >From the code I see both IXGBE and I40E can support scattered vector Rx, I am curious to know any obvious reasons scattered vector Tx support is left out and does it make sense to implement it? If it makes sense to implement scattered vector Tx and Intel team hasn't worked on it I would like to make an attempt at it so kindly let me know. Thanks. On Fri, Apr 14, 2017 at 10:35 AM, Ravi Kerur wrote: > Hi, > > We are using dpdk 16.04 and by looking at the ixgbe and > i40e(i40e_xmit_pkts_vec) and ixgbe(ixgbe_xmit_pkts_vec) driver vector tx > processing code I see they both don't handle scattered packet processing. > For any packets greater than 2048 bytes which will basically contain > multiple rte_mbuf segs vector tx processing cannot be used. > > Any reasons why vector tx for both ixgbe and i40e doesn't support > scattered or multiple mbuf segments processing? > > Thanks. >
[dpdk-dev] Verbose build output not working
When I add the V=1 on the make line it should show the compile and linker lines, but this does not seem to work any more. Did the method to show these build lines change? Regards, Keith
Re: [dpdk-dev] Q on IXGBE and I40E vector Tx processing
Hi Ravi, > > Hi, > > The reason I am asking I because I have tried different combinations of > scalar and vector Tx and Rx processing for both IXGBE and I40E with > following results > > 1. Vector Rx and Vector Tx gives best performance but can only support > packet size of less than or equal to 2048 bytes > > 2. Scalar Rx and Scalar Tx works for all packet size but with degraded > performance > > 3. Vector Rx and Scalar Tx (with certain PMD configuration) works fine > (performance doesn't meet '1') but it has an inherent bug for packet size > 8192 bytes as PMD stops packet processing > > From the code I see both IXGBE and I40E can support scattered vector Rx, I > am curious to know any obvious reasons scattered vector Tx support is left > out and does it make sense to implement it? > > If it makes sense to implement scattered vector Tx and Intel team hasn't > worked on it I would like to make an attempt at it so kindly let me know. > Yes, right now there is a tradeoff - simple TX functions (both vector and scalar) are much faster than full-featured TX function, but don't support any TX offloads or multi-segs. If you'd like to provide a patch that would add some TX offloads to the simple path without any performance degradation or either a patch that would improve performance of full-featured TX function - I am pretty sure such patches would be welcomed. Konstantin
Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset
Hi, Thomas All questions about this patch set has been answered, is it clear or not?And is there anything that I should do for it? Or it is OK for merge into 17.02-RC2? Thank you. > -Original Message- > From: Zhao1, Wei > Sent: Friday, April 14, 2017 4:03 PM > To: Thomas Monjalon > Cc: Ananyev, Konstantin ; Mcnamara, John > ; dev@dpdk.org; Lu, Wenzhuo > > Subject: RE: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port > reset > > Hi, Thomas > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > Sent: Friday, April 14, 2017 2:31 PM > > To: Zhao1, Wei > > Cc: Ananyev, Konstantin ; Mcnamara, > John > > ; dev@dpdk.org; Lu, Wenzhuo > > > > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support > > for port reset > > > > 2017-04-14 01:29, Zhao1, Wei: > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > > 2017-04-13 08:55, Zhao1, Wei: > > > > > From: Ananyev, Konstantin > > > > > > From: Zhao1, Wei > > > > > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > > > > > > 2017-04-06 02:57, Zhao1, Wei: > > > > > > > > > > /** > > > > > > > > > > > + * Reset an ethernet device when it's not working. > > > > > > > > > > > + One scenario is, after PF > > > > > > > > > > > + * port is down and up, the related VF port should be > reset. > > > > > > > > > > > + * The API will stop the port, clear the rx/tx > > > > > > > > > > > + queues, re-setup the rx/tx > > > > > > > > > > > + * queues, restart the port. > > > > > > > > > > > > > > > > > > > > s/The API/This function/ > > > > > > > > > > > > > > > > > > > > Please explain exactly the responsibility of this > > > > > > > > > > function, and how it is different from calling > > stop/configure/start. > > > > > > > > > > > > > > > > > > In this reset feature, reset function can do the calling > > > > > > > > > stop/configure/start process, but also It can also do > > > > > > > > > some restore work for the port, for example, it can > > > > > > > > > restore the added parameters of > > > > > > > > vlan, mac_addrs, promisc_unicast_enabled falg and > > > > > > > > promisc_multicast_enabled flag. > > > > > > > > > > > > Ok, but why start/stop can't do these things? > > > > > > Konstantin > > > > > > > > > > This is because in i40e PMD code, start and stop process do not > > > > > have the process of store and restore the added key parameters. > > > > > Not only i40e but also other PMD code. So, in the function > > > > > pointed to by dev_reset, > > > > we add specific function do store and restore of some of the > > > > important parameters listed above. > > > > > > > > Why store and restore cannot be implemented in start/stop functions? > > > > > > Because reset and start/stop are used for two purposes, for example: > > > Some user maybe just start/stop the port and he do not care what > > > key parameters has been configuration last time, and even worse when > > > he want to clear all the configuration last time , if we add > > > specific function do store and restore in that two function, it is > > > useless for them, > > and may cause a result that user do not expect. > > > > Is it said somewhere in the doc that the configuration is lost when > > stopping a device? > > Can we say which configuration parameter is kept and which one is lost? > > > > rte_eth_dev_config_restore() is called in rte_eth_dev_start(). > > Port reset process not only involve the rte_eth_dev_start() and > rte_eth_dev_stop(). > It also involve eth_dev_uninit() and eth_dev_init() process， > in which PMD device uninit and init. In this case, for example, data- > >mac_addrs buffer is freed so it need to add store and restore function. > BUT, if you only call stop/configure/start process, that is not strictly what > named "device reset".
Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 14, 2017 11:54 PM > To: Lu, Wenzhuo; Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print > > On 4/14/2017 11:49 AM, Ferruh Yigit wrote: > > On 4/14/2017 2:16 AM, Wenzhuo Lu wrote: > >> When receiving the unsupported AQ messages, it's taken as an error. > >> It's not appropriate and triggers too much unnecessary print. > >> > >> Signed-off-by: Wenzhuo Lu > > > > Applied to dpdk-next-net/master, thanks. > > Hi Wenzhuo, Jingjing, > > Another i40e log print, in WARNING level: > > i40e_update_default_filter_setting(): Cannot remove the default macvlan > filter > > I am getting this one always. > > If this is produced always, what do you think downgrade this one too? Or > remove completely perhaps? Checked the comment in the code, it's expected that it will fail in some scenarios. So I'll send a patch to downgrade it to "debug". > > Thanks, > ferruh
Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset
Add Thomas new mail address for this mail. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Monday, April 17, 2017 10:09 AM > To: 'Thomas Monjalon' > Cc: Ananyev, Konstantin ; Mcnamara, John > ; 'dev@dpdk.org' ; Lu, > Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port > reset > > Hi, Thomas > > All questions about this patch set has been answered, is it clear or > not?And > is there anything that I should do for it? > Or it is OK for merge into 17.02-RC2? > > Thank you. > > > -Original Message- > > From: Zhao1, Wei > > Sent: Friday, April 14, 2017 4:03 PM > > To: Thomas Monjalon > > Cc: Ananyev, Konstantin ; Mcnamara, > John > > ; dev@dpdk.org; Lu, Wenzhuo > > > > Subject: RE: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support > > for port reset > > > > Hi, Thomas > > > > > -Original Message- > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > Sent: Friday, April 14, 2017 2:31 PM > > > To: Zhao1, Wei > > > Cc: Ananyev, Konstantin ; Mcnamara, > > John > > > ; dev@dpdk.org; Lu, Wenzhuo > > > > > > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support > > > for port reset > > > > > > 2017-04-14 01:29, Zhao1, Wei: > > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > > > 2017-04-13 08:55, Zhao1, Wei: > > > > > > From: Ananyev, Konstantin > > > > > > > From: Zhao1, Wei > > > > > > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > > > > > > > 2017-04-06 02:57, Zhao1, Wei: > > > > > > > > > > > /** > > > > > > > > > > > > + * Reset an ethernet device when it's not working. > > > > > > > > > > > > + One scenario is, after PF > > > > > > > > > > > > + * port is down and up, the related VF port > > > > > > > > > > > > + should be > > reset. > > > > > > > > > > > > + * The API will stop the port, clear the rx/tx > > > > > > > > > > > > + queues, re-setup the rx/tx > > > > > > > > > > > > + * queues, restart the port. > > > > > > > > > > > > > > > > > > > > > > s/The API/This function/ > > > > > > > > > > > > > > > > > > > > > > Please explain exactly the responsibility of this > > > > > > > > > > > function, and how it is different from calling > > > stop/configure/start. > > > > > > > > > > > > > > > > > > > > In this reset feature, reset function can do the > > > > > > > > > > calling stop/configure/start process, but also It can > > > > > > > > > > also do some restore work for the port, for example, > > > > > > > > > > it can restore the added parameters of > > > > > > > > > vlan, mac_addrs, promisc_unicast_enabled falg and > > > > > > > > > promisc_multicast_enabled flag. > > > > > > > > > > > > > > Ok, but why start/stop can't do these things? > > > > > > > Konstantin > > > > > > > > > > > > This is because in i40e PMD code, start and stop process do > > > > > > not have the process of store and restore the added key > parameters. > > > > > > Not only i40e but also other PMD code. So, in the function > > > > > > pointed to by dev_reset, > > > > > we add specific function do store and restore of some of the > > > > > important parameters listed above. > > > > > > > > > > Why store and restore cannot be implemented in start/stop functions? > > > > > > > > Because reset and start/stop are used for two purposes, for example: > > > > Some user maybe just start/stop the port and he do not care what > > > > key parameters has been configuration last time, and even worse > > > > when he want to clear all the configuration last time , if we add > > > > specific function do store and restore in that two function, it > > > > is useless for them, > > > and may cause a result that user do not expect. > > > > > > Is it said somewhere in the doc that the configuration is lost when > > > stopping a device? > > > Can we say which configuration parameter is kept and which one is lost? > > > > > > rte_eth_dev_config_restore() is called in rte_eth_dev_start(). > > > > Port reset process not only involve the rte_eth_dev_start() and > > rte_eth_dev_stop(). > > It also involve eth_dev_uninit() and eth_dev_init() process， > > in which PMD device uninit and init. In this case, for example, data- > > >mac_addrs buffer is freed so it need to add store and restore function. > > BUT, if you only call stop/configure/start process, that is not > > strictly what named "device reset".
[dpdk-dev] [PATCH] net/i40e: downgrade error print
When deleting the default MAC VLAN filter, it's
expected that it may fail.
So downgrade the error print from warning to
debug.
Signed-off-by: Wenzhuo Lu
---
drivers/net/i40e/i40e_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 1773e05..ea85f6e 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -4499,8 +4499,8 @@ enum i40e_status_code
struct i40e_mac_filter *f;
struct ether_addr *mac;
- PMD_DRV_LOG(WARNING,
- "Cannot remove the default macvlan filter");
+ PMD_DRV_LOG(DEBUG,
+ "Cannot remove the default macvlan filter");
/* It needs to add the permanent mac into mac list */
f = rte_zmalloc("macv_filter", sizeof(*f), 0);
if (f == NULL) {
--
1.9.3
