Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link
Hi I am not able to reproduce the issue anymore with nvm 5.05 + 17.02-rc2 (with LSC disabled) Lesson learned: always upgrade to latest versions first. Thanks to everyone for the support Regards Ivan On 7 February 2017 at 15:56, Olivier MATZ wrote: > Hi Helin, > > On Mon, 6 Feb 2017 01:36:45 +, "Zhang, Helin" > wrote: >> Hi guys >> >> There may have firmware dependencies, new DPDK version + old firmware >> version may not work. Please refer to below link to see what type of >> firmware has been validated with 16.11 DPDK. >> http://dpdk.org/doc/guides/rel_notes/release_16_11.html#tested-nics >> Then first, you need to upgrade your firmware. Then let us know if >> the issue is still there. Thanks! >> > > I updated the firmware, and I confirm it solves my issue described > at: http://dpdk.org/ml/archives/dev/2017-January/054401.html > > Thanks, > Olivier
Re: [dpdk-dev] [PATCH] eal: fix max number of interrupt request
Hi Thomas: > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, February 10, 2017 6:19 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing > Subject: Re: [PATCH] eal: fix max number of interrupt request > > 2017-02-09 14:59, Qi Zhang: > > The max number of interrupt request is possible be changed after > > rte_intr_callback_register, so in get_max_intr, we need to check if > > nessesary to update the max_intr. > > So you are using rte_intr_enable() to update the max_intr field in the case of > VFIO_MSIX. > What about MSI, INTX and UIO cases? My thought is, even without my fix, VFIO_MSIX is already the only case that try to modify max_intr field In get_max_intr, we have: if (!src->intr_handle.max_intr) src->intr_handle.max_intr = 1; else if (src->intr_handle.max_intr > RTE_MAX_RXTX_INTR_VEC_ID) src->intr_handle.max_intr = RTE_MAX_RXTX_INTR_VEC_ID + 1; So my patch just follow this and fix some problem. Another option is I can use a local variable that assigned by max_intr with boundary check, so get_max_intr can be totally removed and max_intr in intr_source will not be modified. To me both fix are not perfect, I think the problem is in rte_intr_callback_register we just save a copy of the pci_dev->intr_handle but not the address point, so we are missing some mechanism to sync them. But since we have tight schedule on the 17.02 release and this issue does cause some example code can't work, so we need to a fix it first, we may consider improve the mechanism later. Thanks Qi
[dpdk-dev] [PATCH] rte, eal: Rename pci_update_device and make it public
The reaon is that sometimes we only like to rebound the
kernel driver or VFIO or UIO or other drivers for
this device after rte_eal_detach function. Function
rte_eal_pci_probe_one not only updates the device but
also probes the rte_eal_driver for this device, it is
not flexible.
Signed-off-by: Ziye Yang
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
lib/librte_eal/common/eal_common_pci.c | 2 +-
lib/librte_eal/common/eal_private.h | 13 -
lib/librte_eal/common/include/rte_pci.h | 14 ++
lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
5 files changed, 17 insertions(+), 16 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
b/lib/librte_eal/bsdapp/eal/eal_pci.c
index 3a5c315..052b91e 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -398,7 +398,7 @@
}
int
-pci_update_device(const struct rte_pci_addr *addr)
+rte_eal_pci_update_device(const struct rte_pci_addr *addr)
{
int fd;
struct pci_conf matches[2];
diff --git a/lib/librte_eal/common/eal_common_pci.c
b/lib/librte_eal/common/eal_common_pci.c
index 72547bd..1d5f581 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -351,7 +351,7 @@ static struct rte_devargs *pci_devargs_lookup(struct
rte_pci_device *dev)
/* update current pci device in global list, kernel bindings might have
* changed since last time we looked at it.
*/
- if (pci_update_device(addr) < 0)
+ if (rte_eal_pci_update_device(addr) < 0)
goto err_return;
TAILQ_FOREACH(dev, &pci_device_list, next) {
diff --git a/lib/librte_eal/common/eal_private.h
b/lib/librte_eal/common/eal_private.h
index 9e7d8f6..770284f 100644
--- a/lib/librte_eal/common/eal_private.h
+++ b/lib/librte_eal/common/eal_private.h
@@ -122,19 +122,6 @@
struct rte_pci_device;
/**
- * Update a pci device object by asking the kernel for the latest information.
- *
- * This function is private to EAL.
- *
- * @param addr
- * The PCI Bus-Device-Function address to look for
- * @return
- * - 0 on success.
- * - negative on error.
- */
-int pci_update_device(const struct rte_pci_addr *addr);
-
-/**
* Unbind kernel driver for this device
*
* This function is private to EAL.
diff --git a/lib/librte_eal/common/include/rte_pci.h
b/lib/librte_eal/common/include/rte_pci.h
index 8557e47..71b8309 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/librte_eal/common/include/rte_pci.h
@@ -442,6 +442,20 @@ void *pci_map_resource(void *requested_addr, int fd, off_t
offset,
void pci_unmap_resource(void *requested_addr, size_t size);
/**
+ * Update the PCI device in global list
+ *
+ * Update the driver of pci device and add it in global list,
+ * kernel bindings might have changed since last time we looked at it.
+ *
+ * @param addr
+ * The PCI Bus-Device-Function address to update.
+ * @return
+ * - 0 on success.
+ * - Negative on error.
+ */
+int rte_eal_pci_update_device(const struct rte_pci_addr *addr);
+
+/**
* Probe the single PCI device.
*
* Scan the content of the PCI bus, and find the pci device specified by pci
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
b/lib/librte_eal/linuxapp/eal/eal_pci.c
index e2fc219..5cff70e 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -378,7 +378,7 @@
}
int
-pci_update_device(const struct rte_pci_addr *addr)
+rte_eal_pci_update_device(const struct rte_pci_addr *addr)
{
char filename[PATH_MAX];
--
1.8.3.1
Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated
> -Original Message-
> From: Olivier MATZ [mailto:olivier.m...@6wind.com]
> Sent: Thursday, February 9, 2017 1:03 AM
> To: Dai, Wei
> Cc: Laurent Hardy ; Zhang, Helin
> ; Ananyev, Konstantin
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated
>
> Hi Wei,
>
> On Wed, 8 Feb 2017 15:51:42 +, "Dai, Wei" wrote:
> > > -Original Message-
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Laurent Hardy
> > > Sent: Friday, November 18, 2016 1:30 AM
> > > To: Zhang, Helin ; Ananyev, Konstantin
> > >
> > > Cc: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated
> > >
> > > In case of link speed set to 1Gb at peer side (with autoneg or with
> > > defined speed) and cable not plugged-in when device is configured
> > > and started, then link status is not updated properly with new speed
> > > as no link setup is triggered.
> > >
> > > To avoid this issue, IXGBE_FLAG_NEED_LINK_CONFIG is set to try a
> > > link setup each time link_update() is triggered and current link
> > > status is down. When cable is plugged-in, link setup will be
> > > performed via ixgbe_setup_link().
> > >
> > > Signed-off-by: Laurent Hardy
> > > ---
> > > drivers/net/ixgbe/ixgbe_ethdev.c | 20
> > > drivers/net/ixgbe/ixgbe_ethdev.h |1 +
> > > 2 files changed, 21 insertions(+)
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > index 52ebbe4..513d1d5 100644
> > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > @@ -2095,6 +2095,7 @@ ixgbe_dev_configure(struct rte_eth_dev *dev)
> > >
> > > /* set flag to update link status after init */
> > > intr->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;
> > > + intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
> > >
> > > /*
> > >* Initialize to TRUE. If any of Rx queues doesn't meet the bulk
> > > @@ -3117,8 +3118,12 @@ ixgbe_dev_link_update(struct rte_eth_dev
> > > *dev, int wait_to_complete)
> > > struct ixgbe_hw *hw =
> > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > > struct rte_eth_link link, old;
> > > ixgbe_link_speed link_speed = IXGBE_LINK_SPEED_UNKNOWN;
> > > + struct ixgbe_interrupt *intr =
> > > + IXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);
> > > int link_up;
> > > int diag;
> > > + u32 speed = 0;
> > > + bool autoneg = false;
> > >
> > > link.link_status = ETH_LINK_DOWN;
> > > link.link_speed = 0;
> > > @@ -3128,6 +3133,19 @@ ixgbe_dev_link_update(struct rte_eth_dev
> > > *dev, int wait_to_complete)
> > >
> > > hw->mac.get_link_status = true;
> > >
> > > + if (intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) {
> > > + speed = hw->phy.autoneg_advertised;
> > > + if (!speed) {
> > > + ixgbe_get_link_capabilities(hw, &speed,
> > > &autoneg);
> > > + /* setup the highest link when no autoneg
> > > */
> > > + if (!autoneg) {
> > > + if (speed &
> > > IXGBE_LINK_SPEED_10GB_FULL)
> > > + speed =
> > > IXGBE_LINK_SPEED_10GB_FULL;
> > > + }
> > > + }
> > > + ixgbe_setup_link(hw, speed, true);
> > > + }
> > > +
> > > /* check if it needs to wait to complete, if lsc interrupt is
> > > enabled */ if (wait_to_complete == 0 ||
> > > dev->data->dev_conf.intr_conf.lsc != 0) diag = ixgbe_check_link(hw,
> > > &link_speed, &link_up, 0); @@ -3145,10 +3163,12 @@
> > > ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
> > >
> > > if (link_up == 0) {
> > > rte_ixgbe_dev_atomic_write_link_status(dev, &link);
> > > + intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
> > > if (link.link_status == old.link_status)
> > > return -1;
> > > return 0;
> > > }
> > > + intr->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;
> > > link.link_status = ETH_LINK_UP;
> > > link.link_duplex = ETH_LINK_FULL_DUPLEX;
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h
> > > b/drivers/net/ixgbe/ixgbe_ethdev.h
> > > index e060c3d..9d335ba 100644
> > > --- a/drivers/net/ixgbe/ixgbe_ethdev.h
> > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
> > > @@ -43,6 +43,7 @@
> > > #define IXGBE_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)
> > > #define IXGBE_FLAG_MAILBOX (uint32_t)(1 << 1)
> > > #define IXGBE_FLAG_PHY_INTERRUPT(uint32_t)(1 << 2)
> > > +#define IXGBE_FLAG_NEED_LINK_CONFIG (uint32_t)(1 << 3)
> >
> > Now there is following macro in DPDK 17.02-rc2.
> > #define IXGBE_FLAG_MACSEC (uint32_t)(1 << 3)
> > You can redefine it as #define IXGBE_FLAG_NEED_LINK_CONFIG
> > (uint32_t)(1 << 4)
>
> Thanks, I'll send a v2.
>
> Do you agree with the rest of the patch?
So far I have no disagree opinions about the reset of this patch.
>
>
> Regards,
> Olivier
[dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all filters
All kinds of filter need to hardware mac type check
to make sure the hardware support that type of fliter.
If not, it may cause serious issue.
Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
Fixes: 672be56d76a2 ("net/ixgbe: parse n-tuple filter")
Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter")
Fixes: 429f6ebb42cc ("net/ixgbe: parse TCP SYN filter")
Signed-off-by: Wei Zhao
Signed-off-by: Wenzhuo Lu
---
drivers/net/ixgbe/ixgbe_flow.c | 129 +
1 file changed, 65 insertions(+), 64 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 5a634d3..f414fa8 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -84,11 +84,12 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr,
struct rte_eth_ntuple_filter *filter,
struct rte_flow_error *error);
static int
-ixgbe_parse_ntuple_filter(const struct rte_flow_attr *attr,
- const struct rte_flow_item pattern[],
- const struct rte_flow_action actions[],
- struct rte_eth_ntuple_filter *filter,
- struct rte_flow_error *error);
+ixgbe_parse_ntuple_filter(struct rte_eth_dev *dev,
+ const struct rte_flow_attr *attr,
+ const struct rte_flow_item pattern[],
+ const struct rte_flow_action actions[],
+ struct rte_eth_ntuple_filter *filter,
+ struct rte_flow_error *error);
static int
cons_parse_ethertype_filter(const struct rte_flow_attr *attr,
const struct rte_flow_item *pattern,
@@ -96,11 +97,12 @@ cons_parse_ethertype_filter(const struct rte_flow_attr
*attr,
struct rte_eth_ethertype_filter *filter,
struct rte_flow_error *error);
static int
-ixgbe_parse_ethertype_filter(const struct rte_flow_attr *attr,
- const struct rte_flow_item pattern[],
- const struct rte_flow_action actions[],
- struct rte_eth_ethertype_filter *filter,
- struct rte_flow_error *error);
+ixgbe_parse_ethertype_filter(struct rte_eth_dev *dev,
+const struct rte_flow_attr *attr,
+const struct rte_flow_item pattern[],
+const struct rte_flow_action actions[],
+struct rte_eth_ethertype_filter *filter,
+struct rte_flow_error *error);
static int
cons_parse_syn_filter(const struct rte_flow_attr *attr,
const struct rte_flow_item pattern[],
@@ -108,11 +110,12 @@ cons_parse_syn_filter(const struct rte_flow_attr *attr,
struct rte_eth_syn_filter *filter,
struct rte_flow_error *error);
static int
-ixgbe_parse_syn_filter(const struct rte_flow_attr *attr,
- const struct rte_flow_item pattern[],
- const struct rte_flow_action actions[],
- struct rte_eth_syn_filter *filter,
- struct rte_flow_error *error);
+ixgbe_parse_syn_filter(struct rte_eth_dev *dev,
+const struct rte_flow_attr *attr,
+const struct rte_flow_item pattern[],
+const struct rte_flow_action actions[],
+struct rte_eth_syn_filter *filter,
+struct rte_flow_error *error);
static int
cons_parse_l2_tn_filter(const struct rte_flow_attr *attr,
const struct rte_flow_item pattern[],
@@ -120,20 +123,13 @@ cons_parse_l2_tn_filter(const struct rte_flow_attr *attr,
struct rte_eth_l2_tunnel_conf *filter,
struct rte_flow_error *error);
static int
-ixgbe_validate_l2_tn_filter(struct rte_eth_dev *dev,
+ixgbe_parse_l2_tn_filter(struct rte_eth_dev *dev,
const struct rte_flow_attr *attr,
const struct rte_flow_item pattern[],
const struct rte_flow_action actions[],
struct rte_eth_l2_tunnel_conf *rule,
struct rte_flow_error *error);
static int
-ixgbe_validate_fdir_filter(struct rte_eth_dev *dev,
- const struct rte_flow_attr *attr,
- const struct rte_flow_item pattern[],
- const struct rte_flow_action actions[],
- struct ixgbe_fdir_rule *rule,
- struct rte_flow_error *error);
-static int
ixgbe_parse_fdir_filter_normal(const struct rte_flow_attr *attr,
[dpdk-dev] [PATCH 1/2] net/ixgbe: move ixgbe 2 mac type check macro
move ixgbe 2 mac type check macro to ixgbe_ethdev.h in
order to be used by filter parser functions in file
ixgbe_flow.c.
Signed-off-by: Wei Zhao
Signed-off-by: Wenzhuo Lu
---
drivers/net/ixgbe/ixgbe_ethdev.c | 12
drivers/net/ixgbe/ixgbe_ethdev.h | 12
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 5b625a3..19c9d33 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5960,13 +5960,6 @@ ixgbevf_set_default_mac_addr(struct rte_eth_dev *dev,
struct ether_addr *addr)
hw->mac.ops.set_rar(hw, 0, (void *)addr, 0, 0);
}
-#define MAC_TYPE_FILTER_SUP(type)do {\
- if ((type) != ixgbe_mac_82599EB && (type) != ixgbe_mac_X540 &&\
- (type) != ixgbe_mac_X550 && (type) != ixgbe_mac_X550EM_x &&\
- (type) != ixgbe_mac_X550EM_a)\
- return -ENOTSUP;\
-} while (0)
-
int
ixgbe_syn_filter_set(struct rte_eth_dev *dev,
struct rte_eth_syn_filter *filter,
@@ -6234,11 +6227,6 @@ ixgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t
mtu)
return 0;
}
-#define MAC_TYPE_FILTER_SUP_EXT(type)do {\
- if ((type) != ixgbe_mac_82599EB && (type) != ixgbe_mac_X540)\
- return -ENOTSUP;\
-} while (0)
-
static inline struct ixgbe_5tuple_filter *
ixgbe_5tuple_filter_lookup(struct ixgbe_5tuple_filter_list *filter_list,
struct ixgbe_5tuple_filter_info *key)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h
index 680d5d9..a1deb7a 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.h
+++ b/drivers/net/ixgbe/ixgbe_ethdev.h
@@ -139,6 +139,18 @@
#define IXGBE_MAX_FDIR_FILTER_NUM (1024 * 32)
#define IXGBE_MAX_L2_TN_FILTER_NUM 128
+#define MAC_TYPE_FILTER_SUP_EXT(type)do {\
+ if ((type) != ixgbe_mac_82599EB && (type) != ixgbe_mac_X540)\
+ return -ENOTSUP;\
+} while (0)
+
+#define MAC_TYPE_FILTER_SUP(type)do {\
+ if ((type) != ixgbe_mac_82599EB && (type) != ixgbe_mac_X540 &&\
+ (type) != ixgbe_mac_X550 && (type) != ixgbe_mac_X550EM_x &&\
+ (type) != ixgbe_mac_X550EM_a)\
+ return -ENOTSUP;\
+} while (0)
+
/*
* Information about the fdir mode.
*/
--
2.9.3
[dpdk-dev] [PATCH v2] doc: fix unreadable images
The images by below two commits are very unclear. Fix it.
Fixes: 50665deebda ("doc: add guide to use virtio-user for container
networking")
Fixes: 0ba3870e755 ("doc: add guide to use virtio-user as exceptional path")
Suggested-by: Thomas Monjalon
Signed-off-by: Jianfeng Tan
---
v2:
- Redraw the vector image instead of embedding a PNG in a svg file.
.../use_models_for_running_dpdk_in_containers.svg | 970 +
.../howto/img/virtio_user_as_exceptional_path.svg | 591 +
.../img/virtio_user_for_container_networking.svg | 893 ++-
3 files changed, 859 insertions(+), 1595 deletions(-)
diff --git a/doc/guides/howto/img/use_models_for_running_dpdk_in_containers.svg
b/doc/guides/howto/img/use_models_for_running_dpdk_in_containers.svg
index 2e3f8e2..662c226 100644
--- a/doc/guides/howto/img/use_models_for_running_dpdk_in_containers.svg
+++ b/doc/guides/howto/img/use_models_for_running_dpdk_in_containers.svg
@@ -1,574 +1,398 @@
-
-http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd";>
-http://www.w3.org/2000/svg";
- width="968.00pt" height="461.00pt" viewBox="0 0 968.00 461.00"
- preserveAspectRatio="xMidYMid meet">
-
-Created by potrace 1.13, written by Peter Selinger 2001-2015
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd";>
+
+http://www.w3.org/2000/svg";
xmlns:xlink="http://www.w3.org/1999/xlink";
xmlns:ev="http://www.w3.org/2001/xml-events";
+
xmlns:v="http://schemas.microsoft.com/visio/2003/SVGExtensions/";
width="10.6194in" height="4.55593in"
+ viewBox="0 0 764.596 328.027" xml:space="preserve"
color-interpolation-filters="sRGB" class="st19">
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ Page-1
+
+
+
+ Rectangle
+ Container
+
+
+
+
+
+
+
+
+
+ Container
+
+ Rectangle.3
+
+
+
+
+
+
+
+
+
+ Rectangle.4
+
+
+
+
+
Re: [dpdk-dev] [PATCH v2] eventdev: amend comments for events limit and threshold
On Sat, Feb 11, 2017 at 09:48:57AM +, Nipun Gupta wrote:
>
>
> > -Original Message-
> > From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com]
> > Sent: Friday, February 10, 2017 16:02
> > To: Nipun Gupta ; dev@dpdk.org
> > Cc: Hemant Agrawal ;
> > jerin.ja...@caviumnetworks.com; Richardson, Bruce
> > ; Eads, Gage
> > Subject: RE: [PATCH v2] eventdev: amend comments for events limit and
> > threshold
> >
> > > From: Nipun Gupta [mailto:nipun.gu...@nxp.com]
> > > Sent: Friday, February 10, 2017 3:50 PM
> > > To: dev@dpdk.org
> > > Cc: hemant.agra...@nxp.com; jerin.ja...@caviumnetworks.com;
> > Richardson, Bruce
> > > ; Eads, Gage ; Van
> > Haaren, Harry
> > > ; Nipun Gupta
> > > Subject: [PATCH v2] eventdev: amend comments for events limit and
> > > threshold
> > >
> > > Updated the comments on 'nb_events_limit' of 'struct rte_event_dev_config'
> > > and 'new_event_threshold' of 'struct rte_event_port_conf' for open system
> > > configuration.
> > >
> > > Signed-off-by: Nipun Gupta
> > > ---
> > > Changes for v2:
> > > - Fix errors reported by check-git-log.sh
> > >
> > > lib/librte_eventdev/rte_eventdev.h | 12 +++-
> > > 1 file changed, 7 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/lib/librte_eventdev/rte_eventdev.h
> > b/lib/librte_eventdev/rte_eventdev.h
> > > index c2f9310..171e52e 100644
> > > --- a/lib/librte_eventdev/rte_eventdev.h
> > > +++ b/lib/librte_eventdev/rte_eventdev.h
> > > @@ -404,11 +404,12 @@ struct rte_event_dev_config {
> > >* @see RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
> > >*/
> > > int32_t nb_events_limit;
> > > - /**< Applies to *closed system* event dev only. This field indicates a
> > > - * limit to ethdev-like devices to limit the number of events injected
> > > - * into the system to not overwhelm core-to-core events.
> > > + /**< In a *closed system* this field indicates a limit to ethdev-like
> > > + * devices to limit the number of events injected into the system to
> > > + * not overwhelm core-to-core events.
> > >* This value cannot exceed the *max_num_events* which previously
> > > - * provided in rte_event_dev_info_get()
> > > + * provided in rte_event_dev_info_get().
> > > + * This should be set to '-1' for *open system*.
> >
> >
> > I don't think we should mention ethdev explicitly here - it applies to any
> > port that is attempting to enqueue work into a closed-system eventdev.
> >
> > What do you think of the following wording? (Suggestion only, feel free to
> > re-word if required).
> >
> > /**< In a closed system this field is the limit on the maximum number of
> > events
> > that can be inflight in the eventdev at a given time. The limit is
> > required
> > to ensure that the finite space in a closed system is not overwhelmed.
> > The
> > value cannot exceed the *max_num_events* as provided by
> > rte_event_dev_info_get().
> > This value should be set to -1 for open systems.
> > */
>
> I agree with you Harry. For *closed systems*, this limit should be valid on
> all the
> enqueues, whether from ethdev type devices or enqueue's from core.
>
> BTW, do you use event limit both on event device and on event ports in your
> software implementation? Because I think the limit may be only per event port.
>
> Jerin,
>
> Your views on this for open systems would be very helpful. Thanks.
I think, none of the implementations can have _true_ infinite amount of inflight
buffers. In our implementation, we internal fixed size SRAM for storing
inflight events which are backed by DDR(To mimic the infinite space).
But both are fixed size and configurable.
That would translate to use only struct rte_event_dev_config.nb_events_limit in
our implementation.
If the implementation support port level configuration then it can
use struct rte_event_port_conf.new_event_threshold.
