date:20150104

[dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS

2015-01-04 Thread Liang, Cunming



> -Original Message-
> From: Ouyang, Changchun
> Sent: Wednesday, December 24, 2014 1:23 PM
> To: dev at dpdk.org
> Cc: Liang, Cunming; Cao, Waterman; Ouyang, Changchun
> Subject: [PATCH v3 5/6] ixgbe: Config VF RSS
> 
> It needs config RSS and IXGBE_MRQC and IXGBE_VFPSRTYPE to enable VF RSS.
> 
> The psrtype will determine how many queues the received packets will 
> distribute
> to,
> and the value of psrtype should depends on both facet: max VF rxq number
> which
> has been negotiated with PF, and the number of rxq specified in config on 
> guest.
> 
> Signed-off-by: Changchun Ouyang 
> ---
>  lib/librte_pmd_ixgbe/ixgbe_pf.c   | 15 +++
>  lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 92
> ++-
>  2 files changed, 97 insertions(+), 10 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c
> index cbb0145..9c9dad8 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
> @@ -187,6 +187,21 @@ int ixgbe_pf_host_configure(struct rte_eth_dev
> *eth_dev)
>   IXGBE_WRITE_REG(hw, IXGBE_MPSAR_LO(hw->mac.num_rar_entries),
> 0);
>   IXGBE_WRITE_REG(hw, IXGBE_MPSAR_HI(hw->mac.num_rar_entries),
> 0);
> 
> + /*
> +  * VF RSS can support at most 4 queues for each VF, even if
> +  * 8 queues are available for each VF, it need refine to 4
> +  * queues here due to this limitation, otherwise no queue
> +  * will receive any packet even RSS is enabled.
> +  */
> + if (eth_dev->data->dev_conf.rxmode.mq_mode ==
> ETH_MQ_RX_VMDQ_RSS) {
> + if (RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool == 8) {
> + RTE_ETH_DEV_SRIOV(eth_dev).active = ETH_32_POOLS;
> + RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 4;
> + RTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx =
> + dev_num_vf(eth_dev) * 4;
> + }
> + }
> +
>   /* set VMDq map to default PF pool */
>   hw->mac.ops.set_vmdq(hw, 0,
> RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx);
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> index f69abda..a7c17a4 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> @@ -3327,6 +3327,39 @@ ixgbe_alloc_rx_queue_mbufs(struct igb_rx_queue
> *rxq)
>  }
> 
>  static int
> +ixgbe_config_vf_rss(struct rte_eth_dev *dev)
> +{
> + struct ixgbe_hw *hw;
> + uint32_t mrqc;
> +
> + ixgbe_rss_configure(dev);
> +
> + hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +
> + /* MRQC: enable VF RSS */
> + mrqc = IXGBE_READ_REG(hw, IXGBE_MRQC);
> + mrqc &= ~IXGBE_MRQC_MRQE_MASK;
> + switch (RTE_ETH_DEV_SRIOV(dev).active) {
> + case ETH_64_POOLS:
> + mrqc |= IXGBE_MRQC_VMDQRSS64EN;
> + break;
> +
> + case ETH_32_POOLS:
> + case ETH_16_POOLS:
> + mrqc |= IXGBE_MRQC_VMDQRSS32EN;
> + break;
> +
> + default:
> + PMD_INIT_LOG(ERR, "Invalid pool number in IOV mode");
> + return -EINVAL;
> + }
> +
> + IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc);
> +
> + return 0;
> +}
> +
> +static int
>  ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
>  {
>   struct ixgbe_hw *hw =
> @@ -3358,24 +3391,38 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev
> *dev)
>   default: ixgbe_rss_disable(dev);
>   }
>   } else {
> - switch (RTE_ETH_DEV_SRIOV(dev).active) {
>   /*
>* SRIOV active scheme
>* FIXME if support DCB/RSS together with VMDq & SRIOV
>*/
> - case ETH_64_POOLS:
> - IXGBE_WRITE_REG(hw, IXGBE_MRQC,
> IXGBE_MRQC_VMDQEN);
> + switch (dev->data->dev_conf.rxmode.mq_mode) {
> + case ETH_MQ_RX_RSS:
> + case ETH_MQ_RX_VMDQ_RSS:
> + ixgbe_config_vf_rss(dev);
>   break;
> 
> - case ETH_32_POOLS:
> - IXGBE_WRITE_REG(hw, IXGBE_MRQC,
> IXGBE_MRQC_VMDQRT4TCEN);
> - break;
> + default:
> + switch (RTE_ETH_DEV_SRIOV(dev).active) {
[Liang, Cunming]  Just a minor comments. To avoid a switch branch inside 
another switch, we can have a  ixgbe_config_vf_default(),
which process all the things if no RSS/DCB required in multi-queue setting.
Then we can put all the 'switch(SRIOV(dev).active){...}'  in it.
> + case ETH_64_POOLS:
> + IXGBE_WRITE_REG(hw, IXGBE_MRQC,
> + IXGBE_MRQC_VMDQEN);
> + break;
> 
> - case ETH_16_POOLS:
> - IXGBE_WRITE_REG(hw, IXGBE_MRQC,
> IXGBE_MRQC_VMDQRT8TCEN);
> + case ETH_32_POOLS:
> + IXGBE_WRITE_REG(hw, IXGBE_MRQC,
> +

[dpdk-dev] l3fwd error, port 0 is not present on the board

2015-01-04 Thread Qiu, Michael

On 1/2/2015 11:08 PM, Lyn M wrote:
> Neil, your patch works.  I am now able to run testpmd, as well as l3fwd
> with DPDK 1.8.0 and CONFIG_RTE_BUILD_COMBINE_LIBS=y.  Thank you much!
>
> In my original post, I thought my choice of hex portmask -p 0x3 was causing
> this issue -- now I know that was not the case.  But, I am still curious
> about how the hex portmask is determined.  Since I only have two ports
> bound to igb_uio, my hex postmask will always be 0x3?  What if I choose to
> bind other ports to igb_uio?  Is there a Linux command I can run to
> determine what mask to use with the -p option?

It is simply a mask used to enable or disable ports in DPDK.
For example:
If DPDK owns two ports, -p 0x03 means all two ports are enabled.
If DPDK owns four ports, -p 0x03 means only port 0 and 1 are enabled,
port 2 and 3 are unable to use. If you want to enable all ports, you
should use -p 0x0f

0x03 is 0b11, 0x0f is 0b

Thanks,
Michael
> Happy New Year --
> Lyn
>
> On Wed, Dec 31, 2014 at 10:00 PM, Neil Horman  
> wrote:
>
>> On Wed, Dec 31, 2014 at 10:37:45PM -0500, Neil Horman wrote:
>>> On Wed, Dec 31, 2014 at 10:50:10AM -0600, Lyn M wrote:
 Neil,
 When I build DPDK 1.8.0 with the default value
>> CONFIG_RTE_BUILD_COMBINE_LIBS=n,
 I am able to run the testpmd successfully.  So, that does appear to be
>> the
 culprit.
 The objdump -t output for testpmd (with COMBINE_LIBS=n and
>> COMBINE_LIBS=y)
 files are here:

>> https://www.dropbox.com/sh/6os9yfn22jjcnmy/AAAjEV3u06XQ1t3UXdWcgru0a?dl=0
 Thanks,
 Lyn

>>> I see the problem.  none of the constructors are included in the l3fwd
>> app.  I
>>> think you might need 174572477028b7f04700389e38f87d2ba01a0adc.  Its also
>>> possible something else has gone wrong withthe COMBINE_LIBS option.  Try
>>> building with the head of the tree, and if that doesn't fix it, we can
>> start
>>> debugging in earnest.
>>> Neil
>> Found the problem.  Please try this patch
>>
>>
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index e1a0dbf..40afb2c 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -61,6 +61,10 @@ ifeq ($(NO_AUTOLIBS),)
>>
>>  LDLIBS += --whole-archive
>>
>> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
>> +LDLIBS += -l$(RTE_LIBNAME)
>> +endif
>> +
>>  ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>>
>>  ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
>> @@ -251,10 +255,6 @@ build: _postbuild
>>
>>  exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1
>>
>> -ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
>> -LDLIBS += -l$(RTE_LIBNAME)
>> -endif
>> -
>>  ifeq ($(LINK_USING_CC),1)
>>  override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))
>>  O_TO_EXE = $(CC) $(CFLAGS) $(LDFLAGS_$(@)) \
>>

[dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS

2015-01-04 Thread Ouyang, Changchun

Hi Steve,

> -Original Message-
> From: Liang, Cunming
> Sent: Sunday, January 4, 2015 10:11 AM
> To: Ouyang, Changchun; dev at dpdk.org
> Cc: Cao, Waterman
> Subject: RE: [PATCH v3 5/6] ixgbe: Config VF RSS
> 
> 
> 
> > -Original Message-
> > From: Ouyang, Changchun
> > Sent: Wednesday, December 24, 2014 1:23 PM
> > To: dev at dpdk.org
> > Cc: Liang, Cunming; Cao, Waterman; Ouyang, Changchun
> > Subject: [PATCH v3 5/6] ixgbe: Config VF RSS
> >
> > It needs config RSS and IXGBE_MRQC and IXGBE_VFPSRTYPE to enable VF
> RSS.
> >
> > The psrtype will determine how many queues the received packets will
> > distribute to, and the value of psrtype should depends on both facet:
> > max VF rxq number which has been negotiated with PF, and the number of
> > rxq specified in config on guest.
> >
> > Signed-off-by: Changchun Ouyang 
> > ---
> >  lib/librte_pmd_ixgbe/ixgbe_pf.c   | 15 +++
> >  lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 92
> > ++-
> >  2 files changed, 97 insertions(+), 10 deletions(-)
> >
> > diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c
> > b/lib/librte_pmd_ixgbe/ixgbe_pf.c index cbb0145..9c9dad8 100644
> > --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
> > @@ -187,6 +187,21 @@ int ixgbe_pf_host_configure(struct rte_eth_dev
> > *eth_dev)
> > IXGBE_WRITE_REG(hw, IXGBE_MPSAR_LO(hw-
> >mac.num_rar_entries),
> > 0);
> > IXGBE_WRITE_REG(hw, IXGBE_MPSAR_HI(hw-
> >mac.num_rar_entries),
> > 0);
> >
> > +   /*
> > +* VF RSS can support at most 4 queues for each VF, even if
> > +* 8 queues are available for each VF, it need refine to 4
> > +* queues here due to this limitation, otherwise no queue
> > +* will receive any packet even RSS is enabled.
> > +*/
> > +   if (eth_dev->data->dev_conf.rxmode.mq_mode ==
> > ETH_MQ_RX_VMDQ_RSS) {
> > +   if (RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool == 8) {
> > +   RTE_ETH_DEV_SRIOV(eth_dev).active =
> ETH_32_POOLS;
> > +   RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 4;
> > +   RTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx =
> > +   dev_num_vf(eth_dev) * 4;
> > +   }
> > +   }
> > +
> > /* set VMDq map to default PF pool */
> > hw->mac.ops.set_vmdq(hw, 0,
> > RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx);
> >
> > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > index f69abda..a7c17a4 100644
> > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > @@ -3327,6 +3327,39 @@ ixgbe_alloc_rx_queue_mbufs(struct
> igb_rx_queue
> > *rxq)
> >  }
> >
> >  static int
> > +ixgbe_config_vf_rss(struct rte_eth_dev *dev) {
> > +   struct ixgbe_hw *hw;
> > +   uint32_t mrqc;
> > +
> > +   ixgbe_rss_configure(dev);
> > +
> > +   hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > +
> > +   /* MRQC: enable VF RSS */
> > +   mrqc = IXGBE_READ_REG(hw, IXGBE_MRQC);
> > +   mrqc &= ~IXGBE_MRQC_MRQE_MASK;
> > +   switch (RTE_ETH_DEV_SRIOV(dev).active) {
> > +   case ETH_64_POOLS:
> > +   mrqc |= IXGBE_MRQC_VMDQRSS64EN;
> > +   break;
> > +
> > +   case ETH_32_POOLS:
> > +   case ETH_16_POOLS:
> > +   mrqc |= IXGBE_MRQC_VMDQRSS32EN;
> > +   break;
> > +
> > +   default:
> > +   PMD_INIT_LOG(ERR, "Invalid pool number in IOV mode");
> > +   return -EINVAL;
> > +   }
> > +
> > +   IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc);
> > +
> > +   return 0;
> > +}
> > +
> > +static int
> >  ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)  {
> > struct ixgbe_hw *hw =
> > @@ -3358,24 +3391,38 @@ ixgbe_dev_mq_rx_configure(struct
> rte_eth_dev
> > *dev)
> > default: ixgbe_rss_disable(dev);
> > }
> > } else {
> > -   switch (RTE_ETH_DEV_SRIOV(dev).active) {
> > /*
> >  * SRIOV active scheme
> >  * FIXME if support DCB/RSS together with VMDq & SRIOV
> >  */
> > -   case ETH_64_POOLS:
> > -   IXGBE_WRITE_REG(hw, IXGBE_MRQC,
> > IXGBE_MRQC_VMDQEN);
> > +   switch (dev->data->dev_conf.rxmode.mq_mode) {
> > +   case ETH_MQ_RX_RSS:
> > +   case ETH_MQ_RX_VMDQ_RSS:
> > +   ixgbe_config_vf_rss(dev);
> > break;
> >
> > -   case ETH_32_POOLS:
> > -   IXGBE_WRITE_REG(hw, IXGBE_MRQC,
> > IXGBE_MRQC_VMDQRT4TCEN);
> > -   break;
> > +   default:
> > +   switch (RTE_ETH_DEV_SRIOV(dev).active) {
> [Liang, Cunming]  Just a minor comments. To avoid a switch branch inside
> another switch, we can have a  ixgbe_config_vf_default(), which process all
> the things if no RSS/DCB required in multi-queue setting.
> Then we can put all the 'switch(SRIOV(dev).active){...}'  in it.

Yes, will resolve it in v4 patch.

> > +   case ETH_64_POOLS:
> > +

[dpdk-dev] [PATCH v4 0/6] Enable VF RSS for Niantic

2015-01-04 Thread Ouyang Changchun

This patch enables VF RSS for Niantic, which allow each VF having at most 4 
queues.
The actual queue number per VF depends on the total number of pool, which is
determined by the max number of VF at PF initialization stage and the number of
queue specified in config:
1) If the max number of VF is in the range from 1 to 32, and the number of rxq 
is 4
('--rxq 4' in testpmd), then there is totally 32 pools(ETH_32_POOLS), and each 
VF 
have 4 queues;

2)If the max number of VF is in the range from 33 to 64, and the number of rxq 
is 2
('--rxq 2' in testpmd), then there is totally 64 pools(ETH_64_POOLS), and each 
VF 
have 2 queues;

On host, to enable VF RSS functionality, rx mq mode should be set as 
ETH_MQ_RX_VMDQ_RSS
or ETH_MQ_RX_RSS mode, and SRIOV mode should be activated(max_vfs >= 1).
It also needs config VF RSS information like hash function, RSS key, RSS key 
length.

The limitation for Niantic VF RSS is:
the hash and key are shared among PF and all VF, the RETA table with 128 
entries are
also shared among PF and all VF. So it could not to provide a method to query 
the hash 
and reta content per VF on guest, while, if possible, please query them on 
host(PF) for
the shared RETA information.

v4 change:
  - Extract a function to remove embeded switch-case statement;
  - Check whether RX queue number is a valid one, otherwise return error;
  - Update the description a bit;

v3 change:
  - More cleanup;

v2 change:
  - Update the description;
  - Use receiving queue number('--rxq ') specified in config to 
determine the 
number of pool and the number of queue per VF;

v1 change:
  - Config VF RSS;

Changchun Ouyang (6):
  ixgbe: Code cleanup
  ixgbe: Negotiate VF API version
  ixgbe: Get VF queue number
  ether: Check VMDq RSS mode
  ixgbe: Config VF RSS
  testpmd: Set Rx VMDq RSS mode

 app/test-pmd/testpmd.c  |  10 +++
 lib/librte_ether/rte_ethdev.c   |  39 --
 lib/librte_pmd_ixgbe/ixgbe_ethdev.h |   1 +
 lib/librte_pmd_ixgbe/ixgbe_pf.c |  75 +++-
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c   | 138 
 5 files changed, 228 insertions(+), 35 deletions(-)

-- 
1.8.4.2

[dpdk-dev] [PATCH v4 1/6] ixgbe: Code cleanup

2015-01-04 Thread Ouyang Changchun

Put global register configuring out of loop for queue; also fix typo and indent;
Also fix typo and indent.

Signed-off-by: Changchun Ouyang 
---
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 35 ++-
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c 
b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
index 5c36bff..f69abda 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
@@ -3548,9 +3548,9 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)
IXGBE_WRITE_REG(hw, 
IXGBE_PSRTYPE(rxq->reg_idx), psrtype);
}
srrctl = ((dev->data->dev_conf.rxmode.split_hdr_size <<
-  IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
- IXGBE_SRRCTL_BSIZEHDR_MASK);
-   srrctl |= E1000_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
+   IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
+   IXGBE_SRRCTL_BSIZEHDR_MASK);
+   srrctl |= IXGBE_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
} else
 #endif
srrctl = IXGBE_SRRCTL_DESCTYPE_ADV_ONEBUF;
@@ -3985,7 +3985,7 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
struct igb_rx_queue *rxq;
struct rte_pktmbuf_pool_private *mbp_priv;
uint64_t bus_addr;
-   uint32_t srrctl;
+   uint32_t srrctl, psrtype = 0;
uint16_t buf_size;
uint16_t i;
int ret;
@@ -4039,20 +4039,10 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
 * Configure Header Split
 */
if (dev->data->dev_conf.rxmode.header_split) {
-
-   /* Must setup the PSRTYPE register */
-   uint32_t psrtype;
-   psrtype = IXGBE_PSRTYPE_TCPHDR |
-   IXGBE_PSRTYPE_UDPHDR   |
-   IXGBE_PSRTYPE_IPV4HDR  |
-   IXGBE_PSRTYPE_IPV6HDR;
-
-   IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE(i), psrtype);
-
srrctl = ((dev->data->dev_conf.rxmode.split_hdr_size <<
-  IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
- IXGBE_SRRCTL_BSIZEHDR_MASK);
-   srrctl |= E1000_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
+   IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
+   IXGBE_SRRCTL_BSIZEHDR_MASK);
+   srrctl |= IXGBE_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
} else
 #endif
srrctl = IXGBE_SRRCTL_DESCTYPE_ADV_ONEBUF;
@@ -4095,6 +4085,17 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
}
}

+#ifdef RTE_HEADER_SPLIT_ENABLE
+   if (dev->data->dev_conf.rxmode.header_split)
+   /* Must setup the PSRTYPE register */
+   psrtype = IXGBE_PSRTYPE_TCPHDR |
+   IXGBE_PSRTYPE_UDPHDR   |
+   IXGBE_PSRTYPE_IPV4HDR  |
+   IXGBE_PSRTYPE_IPV6HDR;
+#endif
+
+   IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype);
+
if (dev->data->dev_conf.rxmode.enable_scatter) {
if (!dev->data->scattered_rx)
PMD_INIT_LOG(DEBUG, "forcing scatter mode");
-- 
1.8.4.2

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

2015-01-04 Thread Ouyang Changchun

Negotiate API version with VF when receiving the IXGBE_VF_API_NEGOTIATE message.

Signed-off-by: Changchun Ouyang 
---
 lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  1 +
 lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +
 2 files changed, 26 insertions(+)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h 
b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
index ca99170..730098d 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
@@ -159,6 +159,7 @@ struct ixgbe_vf_info {
uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF];
uint16_t vlan_count;
uint8_t spoofchk_enabled;
+   uint8_t api_version;
 };

 /*
diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c
index 51da1fd..495aff5 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
@@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused 
uint32_t vf, uint32_t *ms
 }

 static int
+ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
+{
+   uint32_t api_version = msgbuf[1];
+   struct ixgbe_vf_info *vfinfo =
+   *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
+
+   switch (api_version) {
+   case ixgbe_mbox_api_10:
+   case ixgbe_mbox_api_11:
+   vfinfo[vf].api_version = (uint8_t)api_version;
+   return 0;
+   default:
+   break;
+   }
+
+   RTE_LOG(ERR, PMD, "Negotiate invalid api version %u from VF %d\n",
+   api_version, vf);
+
+   return -1;
+}
+
+static int
 ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)
 {
uint16_t mbx_size = IXGBE_VFMAILBOX_SIZE;
@@ -512,6 +534,9 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)
case IXGBE_VF_SET_VLAN:
retval = ixgbe_vf_set_vlan(dev, vf, msgbuf);
break;
+   case IXGBE_VF_API_NEGOTIATE:
+   retval = ixgbe_negotiate_vf_api(dev, vf, msgbuf);
+   break;
default:
PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", (unsigned)msgbuf[0]);
retval = IXGBE_ERR_MBX;
-- 
1.8.4.2

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

2015-01-04 Thread Ouyang Changchun

Check mq mode for VMDq RSS, handle it correctly instead of returning an error;
Also remove the limitation of per pool queue number has max value of 1, because
the per pool queue number could be 2 or 4 if it is VMDq RSS mode;

The number of rxq specified in config will determine the mq mode for VMDq RSS.

Signed-off-by: Changchun Ouyang 
---
 lib/librte_ether/rte_ethdev.c | 39 ++-
 1 file changed, 34 insertions(+), 5 deletions(-)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 95f2ceb..59ff325 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -510,8 +510,7 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t 
nb_rx_q, uint16_t nb_tx_q,

if (RTE_ETH_DEV_SRIOV(dev).active != 0) {
/* check multi-queue mode */
-   if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_RSS) ||
-   (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
+   if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
(dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB_RSS) ||
(dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB)) {
/* SRIOV only works in VMDq enable mode */
@@ -525,7 +524,6 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t 
nb_rx_q, uint16_t nb_tx_q,
}

switch (dev_conf->rxmode.mq_mode) {
-   case ETH_MQ_RX_VMDQ_RSS:
case ETH_MQ_RX_VMDQ_DCB:
case ETH_MQ_RX_VMDQ_DCB_RSS:
/* DCB/RSS VMDQ in SRIOV mode, not implement yet */
@@ -534,6 +532,39 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t 
nb_rx_q, uint16_t nb_tx_q,
"unsupported VMDQ mq_mode rx %u\n",
port_id, dev_conf->rxmode.mq_mode);
return (-EINVAL);
+   case ETH_MQ_RX_RSS:
+   PMD_DEBUG_TRACE("ethdev port_id=%" PRIu8
+   " SRIOV active, "
+   "Rx mq mode is changed from:"
+   "mq_mode %u into VMDQ mq_mode %u\n",
+   port_id,
+   dev_conf->rxmode.mq_mode,
+   dev->data->dev_conf.rxmode.mq_mode);
+   case ETH_MQ_RX_VMDQ_RSS:
+   dev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_VMDQ_RSS;
+   if (nb_rx_q < RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool) {
+   switch (nb_rx_q) {
+   case 1:
+   case 2:
+   RTE_ETH_DEV_SRIOV(dev).active =
+   ETH_64_POOLS;
+   break;
+   case 4:
+   RTE_ETH_DEV_SRIOV(dev).active =
+   ETH_32_POOLS;
+   break;
+   default:
+   PMD_DEBUG_TRACE("ethdev port_id=%d"
+   " SRIOV active, "
+   "queue number invalid\n",
+   port_id);
+   return -EINVAL;
+   }
+   RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;
+   RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =
+   dev->pci_dev->max_vfs * nb_rx_q;
+   }
+   break;
default: /* ETH_MQ_RX_VMDQ_ONLY or ETH_MQ_RX_NONE */
/* if nothing mq mode configure, use default scheme */
dev->data->dev_conf.rxmode.mq_mode = 
ETH_MQ_RX_VMDQ_ONLY;
@@ -553,8 +584,6 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t 
nb_rx_q, uint16_t nb_tx_q,
default: /* ETH_MQ_TX_VMDQ_ONLY or ETH_MQ_TX_NONE */
/* if nothing mq mode configure, use default scheme */
dev->data->dev_conf.txmode.mq_mode = 
ETH_MQ_TX_VMDQ_ONLY;
-   if (RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool > 1)
-   RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = 1;
break;
}

-- 
1.8.4.2

[dpdk-dev] [PATCH v4 5/6] ixgbe: Config VF RSS

2015-01-04 Thread Ouyang Changchun

It needs config RSS and IXGBE_MRQC and IXGBE_VFPSRTYPE to enable VF RSS.

The psrtype will determine how many queues the received packets will distribute 
to,
and the value of psrtype should depends on both facet: max VF rxq number which
has been negotiated with PF, and the number of rxq specified in config on guest.

Signed-off-by: Changchun Ouyang 

Changes in v4:
 - the number of rxq from config should be power of 2 and should not bigger 
than 
   max VF rxq number(negotiated between guest and host).

---
 lib/librte_pmd_ixgbe/ixgbe_pf.c   |  15 ++
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 103 +-
 2 files changed, 106 insertions(+), 12 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c
index cbb0145..9c9dad8 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
@@ -187,6 +187,21 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev)
IXGBE_WRITE_REG(hw, IXGBE_MPSAR_LO(hw->mac.num_rar_entries), 0);
IXGBE_WRITE_REG(hw, IXGBE_MPSAR_HI(hw->mac.num_rar_entries), 0);

+   /*
+* VF RSS can support at most 4 queues for each VF, even if
+* 8 queues are available for each VF, it need refine to 4
+* queues here due to this limitation, otherwise no queue
+* will receive any packet even RSS is enabled.
+*/
+   if (eth_dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_VMDQ_RSS) {
+   if (RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool == 8) {
+   RTE_ETH_DEV_SRIOV(eth_dev).active = ETH_32_POOLS;
+   RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 4;
+   RTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx =
+   dev_num_vf(eth_dev) * 4;
+   }
+   }
+
/* set VMDq map to default PF pool */
hw->mac.ops.set_vmdq(hw, 0, RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx);

diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c 
b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
index f69abda..e83a9ab 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
@@ -3327,6 +3327,68 @@ ixgbe_alloc_rx_queue_mbufs(struct igb_rx_queue *rxq)
 }

 static int
+ixgbe_config_vf_rss(struct rte_eth_dev *dev)
+{
+   struct ixgbe_hw *hw;
+   uint32_t mrqc;
+
+   ixgbe_rss_configure(dev);
+
+   hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   /* MRQC: enable VF RSS */
+   mrqc = IXGBE_READ_REG(hw, IXGBE_MRQC);
+   mrqc &= ~IXGBE_MRQC_MRQE_MASK;
+   switch (RTE_ETH_DEV_SRIOV(dev).active) {
+   case ETH_64_POOLS:
+   mrqc |= IXGBE_MRQC_VMDQRSS64EN;
+   break;
+
+   case ETH_32_POOLS:
+   case ETH_16_POOLS:
+   mrqc |= IXGBE_MRQC_VMDQRSS32EN;
+   break;
+
+   default:
+   PMD_INIT_LOG(ERR, "Invalid pool number in IOV mode");
+   return -EINVAL;
+   }
+
+   IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc);
+
+   return 0;
+}
+
+static int
+ixgbe_config_vf_default(struct rte_eth_dev *dev)
+{
+   struct ixgbe_hw *hw =
+   IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   switch (RTE_ETH_DEV_SRIOV(dev).active) {
+   case ETH_64_POOLS:
+   IXGBE_WRITE_REG(hw, IXGBE_MRQC,
+   IXGBE_MRQC_VMDQEN);
+   break;
+
+   case ETH_32_POOLS:
+   IXGBE_WRITE_REG(hw, IXGBE_MRQC,
+   IXGBE_MRQC_VMDQRT4TCEN);
+   break;
+
+   case ETH_16_POOLS:
+   IXGBE_WRITE_REG(hw, IXGBE_MRQC,
+   IXGBE_MRQC_VMDQRT8TCEN);
+   break;
+   default:
+   PMD_INIT_LOG(ERR,
+   "invalid pool number in IOV mode");
+   break;
+   }
+   return 0;
+}
+
+static int
 ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
 {
struct ixgbe_hw *hw =
@@ -3358,24 +3420,25 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
default: ixgbe_rss_disable(dev);
}
} else {
-   switch (RTE_ETH_DEV_SRIOV(dev).active) {
/*
 * SRIOV active scheme
-* FIXME if support DCB/RSS together with VMDq & SRIOV
+* Support RSS together with VMDq & SRIOV
 */
-   case ETH_64_POOLS:
-   IXGBE_WRITE_REG(hw, IXGBE_MRQC, IXGBE_MRQC_VMDQEN);
-   break;
-
-   case ETH_32_POOLS:
-   IXGBE_WRITE_REG(hw, IXGBE_MRQC, IXGBE_MRQC_VMDQRT4TCEN);
+   switch (dev->data->dev_conf.rxmode.mq_mode) {
+   case ETH_MQ_RX_RSS:
+   case ETH_MQ_RX_VMDQ_RSS:
+   ixgbe_config_vf_rss(dev);
break;

-   case ETH_16_POOLS:
-   IXGBE_WRITE_REG(hw, IXGBE_MRQC, IXGBE_MRQC_VMDQRT8TCEN);
-

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

2015-01-04 Thread Ouyang Changchun

Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS 
information.

Signed-off-by: Changchun Ouyang 
---
 app/test-pmd/testpmd.c | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 8c69756..6230f8b 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1708,6 +1708,16 @@ init_port_config(void)
port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
}

+   if (port->dev_info.max_vfs != 0) {
+   if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0)
+   port->dev_conf.rxmode.mq_mode =
+   ETH_MQ_RX_VMDQ_RSS;
+   else {
+   port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
+   port->dev_conf.txmode.mq_mode = ETH_MQ_TX_NONE;
+   }
+   }
+
port->rx_conf.rx_thresh = rx_thresh;
port->rx_conf.rx_free_thresh = rx_free_thresh;
port->rx_conf.rx_drop_en = rx_drop_en;
-- 
1.8.4.2

[dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number

2015-01-04 Thread Ouyang Changchun

Get the available Rx and Tx queue number when receiving IXGBE_VF_GET_QUEUES 
message from VF.

Signed-off-by: Changchun Ouyang 
---
 lib/librte_pmd_ixgbe/ixgbe_pf.c | 35 ++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c
index 495aff5..cbb0145 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
@@ -53,6 +53,8 @@
 #include "ixgbe_ethdev.h"

 #define IXGBE_MAX_VFTA (128)
+#define IXGBE_VF_MSG_SIZE_DEFAULT 1
+#define IXGBE_VF_GET_QUEUE_MSG_SIZE 5

 static inline uint16_t
 dev_num_vf(struct rte_eth_dev *eth_dev)
@@ -491,9 +493,36 @@ ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t 
vf, uint32_t *msgbuf)
 }

 static int
+ixgbe_get_vf_queues(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
+{
+   struct ixgbe_vf_info *vfinfo =
+   *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
+   uint32_t default_q = vf * RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
+
+   /* Verify if the PF supports the mbox APIs version or not */
+   switch (vfinfo[vf].api_version) {
+   case ixgbe_mbox_api_20:
+   case ixgbe_mbox_api_11:
+   break;
+   default:
+   return -1;
+   }
+
+   /* Notify VF of Rx and Tx queue number */
+   msgbuf[IXGBE_VF_RX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
+   msgbuf[IXGBE_VF_TX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
+
+   /* Notify VF of default queue */
+   msgbuf[IXGBE_VF_DEF_QUEUE] = default_q;
+
+   return 0;
+}
+
+static int
 ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)
 {
uint16_t mbx_size = IXGBE_VFMAILBOX_SIZE;
+   uint16_t msg_size = IXGBE_VF_MSG_SIZE_DEFAULT;
uint32_t msgbuf[IXGBE_VFMAILBOX_SIZE];
int32_t retval;
struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -537,6 +566,10 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)
case IXGBE_VF_API_NEGOTIATE:
retval = ixgbe_negotiate_vf_api(dev, vf, msgbuf);
break;
+   case IXGBE_VF_GET_QUEUES:
+   retval = ixgbe_get_vf_queues(dev, vf, msgbuf);
+   msg_size = IXGBE_VF_GET_QUEUE_MSG_SIZE;
+   break;
default:
PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", (unsigned)msgbuf[0]);
retval = IXGBE_ERR_MBX;
@@ -551,7 +584,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)

msgbuf[0] |= IXGBE_VT_MSGTYPE_CTS;

-   ixgbe_write_mbx(hw, msgbuf, 1, vf);
+   ixgbe_write_mbx(hw, msgbuf, msg_size, vf);

return retval;
 }
-- 
1.8.4.2

[dpdk-dev] [PATCH v4 1/6] ixgbe: Code cleanup

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 09:18, Ouyang Changchun wrote:
> Put global register configuring out of loop for queue; also fix typo and 
> indent;
> Also fix typo and indent.
>
> Signed-off-by: Changchun Ouyang 

Reviewed-by: Vlad Zolotarov 

> ---
>   lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 35 ++-
>   1 file changed, 18 insertions(+), 17 deletions(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c 
> b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> index 5c36bff..f69abda 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> @@ -3548,9 +3548,9 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)
>   IXGBE_WRITE_REG(hw, 
> IXGBE_PSRTYPE(rxq->reg_idx), psrtype);
>   }
>   srrctl = ((dev->data->dev_conf.rxmode.split_hdr_size <<
> -IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
> -   IXGBE_SRRCTL_BSIZEHDR_MASK);
> - srrctl |= E1000_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
> + IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
> + IXGBE_SRRCTL_BSIZEHDR_MASK);
> + srrctl |= IXGBE_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
>   } else
>   #endif
>   srrctl = IXGBE_SRRCTL_DESCTYPE_ADV_ONEBUF;
> @@ -3985,7 +3985,7 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
>   struct igb_rx_queue *rxq;
>   struct rte_pktmbuf_pool_private *mbp_priv;
>   uint64_t bus_addr;
> - uint32_t srrctl;
> + uint32_t srrctl, psrtype = 0;
>   uint16_t buf_size;
>   uint16_t i;
>   int ret;
> @@ -4039,20 +4039,10 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
>* Configure Header Split
>*/
>   if (dev->data->dev_conf.rxmode.header_split) {
> -
> - /* Must setup the PSRTYPE register */
> - uint32_t psrtype;
> - psrtype = IXGBE_PSRTYPE_TCPHDR |
> - IXGBE_PSRTYPE_UDPHDR   |
> - IXGBE_PSRTYPE_IPV4HDR  |
> - IXGBE_PSRTYPE_IPV6HDR;
> -
> - IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE(i), psrtype);
> -
>   srrctl = ((dev->data->dev_conf.rxmode.split_hdr_size <<
> -IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
> -   IXGBE_SRRCTL_BSIZEHDR_MASK);
> - srrctl |= E1000_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
> + IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
> + IXGBE_SRRCTL_BSIZEHDR_MASK);
> + srrctl |= IXGBE_SRRCTL_DESCTYPE_HDR_SPLIT_ALWAYS;
>   } else
>   #endif
>   srrctl = IXGBE_SRRCTL_DESCTYPE_ADV_ONEBUF;
> @@ -4095,6 +4085,17 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
>   }
>   }
>   
> +#ifdef RTE_HEADER_SPLIT_ENABLE
> + if (dev->data->dev_conf.rxmode.header_split)
> + /* Must setup the PSRTYPE register */
> + psrtype = IXGBE_PSRTYPE_TCPHDR |
> + IXGBE_PSRTYPE_UDPHDR   |
> + IXGBE_PSRTYPE_IPV4HDR  |
> + IXGBE_PSRTYPE_IPV6HDR;
> +#endif
> +
> + IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype);
> +
>   if (dev->data->dev_conf.rxmode.enable_scatter) {
>   if (!dev->data->scattered_rx)
>   PMD_INIT_LOG(DEBUG, "forcing scatter mode");

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 09:18, Ouyang Changchun wrote:
> Negotiate API version with VF when receiving the IXGBE_VF_API_NEGOTIATE 
> message.
>
> Signed-off-by: Changchun Ouyang 

Reviewed-by: Vlad Zolotarov 

> ---
>   lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  1 +
>   lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +
>   2 files changed, 26 insertions(+)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h 
> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
> index ca99170..730098d 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
> @@ -159,6 +159,7 @@ struct ixgbe_vf_info {
>   uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF];
>   uint16_t vlan_count;
>   uint8_t spoofchk_enabled;
> + uint8_t api_version;
>   };
>   
>   /*
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c
> index 51da1fd..495aff5 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
> @@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused 
> uint32_t vf, uint32_t *ms
>   }
>   
>   static int
> +ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf, uint32_t 
> *msgbuf)
> +{
> + uint32_t api_version = msgbuf[1];
> + struct ixgbe_vf_info *vfinfo =
> + *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
> +
> + switch (api_version) {
> + case ixgbe_mbox_api_10:
> + case ixgbe_mbox_api_11:
> + vfinfo[vf].api_version = (uint8_t)api_version;
> + return 0;
> + default:
> + break;
> + }
> +
> + RTE_LOG(ERR, PMD, "Negotiate invalid api version %u from VF %d\n",
> + api_version, vf);
> +
> + return -1;
> +}
> +
> +static int
>   ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)
>   {
>   uint16_t mbx_size = IXGBE_VFMAILBOX_SIZE;
> @@ -512,6 +534,9 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t 
> vf)
>   case IXGBE_VF_SET_VLAN:
>   retval = ixgbe_vf_set_vlan(dev, vf, msgbuf);
>   break;
> + case IXGBE_VF_API_NEGOTIATE:
> + retval = ixgbe_negotiate_vf_api(dev, vf, msgbuf);
> + break;
>   default:
>   PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", (unsigned)msgbuf[0]);
>   retval = IXGBE_ERR_MBX;

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 10:26, Vlad Zolotarov wrote:
>
> On 01/04/15 09:18, Ouyang Changchun wrote:
>> Negotiate API version with VF when receiving the 
>> IXGBE_VF_API_NEGOTIATE message.
>>
>> Signed-off-by: Changchun Ouyang 
>
> Reviewed-by: Vlad Zolotarov 

One small remark below.

>
>> ---
>>   lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  1 +
>>   lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +
>>   2 files changed, 26 insertions(+)
>>
>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h 
>> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>> index ca99170..730098d 100644
>> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>> @@ -159,6 +159,7 @@ struct ixgbe_vf_info {
>>   uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF];
>>   uint16_t vlan_count;
>>   uint8_t spoofchk_enabled;
>> +uint8_t api_version;
>>   };
>> /*
>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c 
>> b/lib/librte_pmd_ixgbe/ixgbe_pf.c
>> index 51da1fd..495aff5 100644
>> --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
>> +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
>> @@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev, 
>> __rte_unused uint32_t vf, uint32_t *ms
>>   }
>> static int
>> +ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf, 
>> uint32_t *msgbuf)
>> +{
>> +uint32_t api_version = msgbuf[1];
>> +struct ixgbe_vf_info *vfinfo =
>> + *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
>> +
>> +switch (api_version) {
>> +case ixgbe_mbox_api_10:
>> +case ixgbe_mbox_api_11:

Why version 2.0 is not negotiated?

>> +vfinfo[vf].api_version = (uint8_t)api_version;
>> +return 0;
>> +default:
>> +break;
>> +}
>> +
>> +RTE_LOG(ERR, PMD, "Negotiate invalid api version %u from VF %d\n",
>> +api_version, vf);
>> +
>> +return -1;
>> +}
>> +
>> +static int
>>   ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)
>>   {
>>   uint16_t mbx_size = IXGBE_VFMAILBOX_SIZE;
>> @@ -512,6 +534,9 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, 
>> uint16_t vf)
>>   case IXGBE_VF_SET_VLAN:
>>   retval = ixgbe_vf_set_vlan(dev, vf, msgbuf);
>>   break;
>> +case IXGBE_VF_API_NEGOTIATE:
>> +retval = ixgbe_negotiate_vf_api(dev, vf, msgbuf);
>> +break;
>>   default:
>>   PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", 
>> (unsigned)msgbuf[0]);
>>   retval = IXGBE_ERR_MBX;
>

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

2015-01-04 Thread Ouyang, Changchun

Hi Vlad,

> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:30 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version
> 
> 
> On 01/04/15 10:26, Vlad Zolotarov wrote:
> >
> > On 01/04/15 09:18, Ouyang Changchun wrote:
> >> Negotiate API version with VF when receiving the
> >> IXGBE_VF_API_NEGOTIATE message.
> >>
> >> Signed-off-by: Changchun Ouyang 
> >
> > Reviewed-by: Vlad Zolotarov 

Thanks for your reviewing.

> 
> One small remark below.
> 
> >
> >> ---
> >>   lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  1 +
> >>   lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +
> >>   2 files changed, 26 insertions(+)
> >>
> >> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
> >> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
> >> index ca99170..730098d 100644
> >> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
> >> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
> >> @@ -159,6 +159,7 @@ struct ixgbe_vf_info {
> >>   uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF];
> >>   uint16_t vlan_count;
> >>   uint8_t spoofchk_enabled;
> >> +uint8_t api_version;
> >>   };
> >> /*
> >> diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c
> >> b/lib/librte_pmd_ixgbe/ixgbe_pf.c index 51da1fd..495aff5 100644
> >> --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
> >> +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
> >> @@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev,
> >> __rte_unused uint32_t vf, uint32_t *ms
> >>   }
> >> static int
> >> +ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf,
> >> uint32_t *msgbuf)
> >> +{
> >> +uint32_t api_version = msgbuf[1];
> >> +struct ixgbe_vf_info *vfinfo =
> >> + *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
> >> +
> >> +switch (api_version) {
> >> +case ixgbe_mbox_api_10:
> >> +case ixgbe_mbox_api_11:
> 
> Why version 2.0 is not negotiated?
> 
Because it doesn't fully support 2.0 features yet.

Thanks
Changchun

[dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 09:18, Ouyang Changchun wrote:
> Get the available Rx and Tx queue number when receiving IXGBE_VF_GET_QUEUES 
> message from VF.
>
> Signed-off-by: Changchun Ouyang 
> ---
>   lib/librte_pmd_ixgbe/ixgbe_pf.c | 35 ++-
>   1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c
> index 495aff5..cbb0145 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
> @@ -53,6 +53,8 @@
>   #include "ixgbe_ethdev.h"
>   
>   #define IXGBE_MAX_VFTA (128)
> +#define IXGBE_VF_MSG_SIZE_DEFAULT 1
> +#define IXGBE_VF_GET_QUEUE_MSG_SIZE 5
>   
>   static inline uint16_t
>   dev_num_vf(struct rte_eth_dev *eth_dev)
> @@ -491,9 +493,36 @@ ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t 
> vf, uint32_t *msgbuf)
>   }
>   
>   static int
> +ixgbe_get_vf_queues(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
> +{
> + struct ixgbe_vf_info *vfinfo =
> + *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
> + uint32_t default_q = vf * RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
> +
> + /* Verify if the PF supports the mbox APIs version or not */
> + switch (vfinfo[vf].api_version) {
> + case ixgbe_mbox_api_20:
> + case ixgbe_mbox_api_11:
> + break;
> + default:
> + return -1;
> + }
> +
> + /* Notify VF of Rx and Tx queue number */
> + msgbuf[IXGBE_VF_RX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
> + msgbuf[IXGBE_VF_TX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool;
> +
> + /* Notify VF of default queue */
> + msgbuf[IXGBE_VF_DEF_QUEUE] = default_q;

What about IXGBE_VF_TRANS_VLAN field?

> +
> + return 0;
> +}
> +
> +static int
>   ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf)
>   {
>   uint16_t mbx_size = IXGBE_VFMAILBOX_SIZE;
> + uint16_t msg_size = IXGBE_VF_MSG_SIZE_DEFAULT;
>   uint32_t msgbuf[IXGBE_VFMAILBOX_SIZE];
>   int32_t retval;
>   struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> @@ -537,6 +566,10 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t 
> vf)
>   case IXGBE_VF_API_NEGOTIATE:
>   retval = ixgbe_negotiate_vf_api(dev, vf, msgbuf);
>   break;
> + case IXGBE_VF_GET_QUEUES:
> + retval = ixgbe_get_vf_queues(dev, vf, msgbuf);
> + msg_size = IXGBE_VF_GET_QUEUE_MSG_SIZE;

Although the msg_size semantics and motivation is clear, if u want to do 
then do it all the way - add it to all other cases too not just to 
IXGBE_VF_GET_QUEUES.
For instance, why do u write all 16 DWORDS for API negotiation (only 2 
are required) and only here u decided to get "greedy"? ;)

My point is: either drop it completely or fix all other places as well.

> + break;
>   default:
>   PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", (unsigned)msgbuf[0]);
>   retval = IXGBE_ERR_MBX;
> @@ -551,7 +584,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t 
> vf)
>   
>   msgbuf[0] |= IXGBE_VT_MSGTYPE_CTS;
>   
> - ixgbe_write_mbx(hw, msgbuf, 1, vf);
> + ixgbe_write_mbx(hw, msgbuf, msg_size, vf);
>   
>   return retval;
>   }

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 10:37, Ouyang, Changchun wrote:
> Hi Vlad,
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:30 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version
>>
>>
>> On 01/04/15 10:26, Vlad Zolotarov wrote:
>>> On 01/04/15 09:18, Ouyang Changchun wrote:
 Negotiate API version with VF when receiving the
 IXGBE_VF_API_NEGOTIATE message.

 Signed-off-by: Changchun Ouyang 
>>> Reviewed-by: Vlad Zolotarov 
> Thanks for your reviewing.
>
>> One small remark below.
>>
 ---
lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  1 +
lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +
2 files changed, 26 insertions(+)

 diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
 b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
 index ca99170..730098d 100644
 --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
 +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
 @@ -159,6 +159,7 @@ struct ixgbe_vf_info {
uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF];
uint16_t vlan_count;
uint8_t spoofchk_enabled;
 +uint8_t api_version;
};
  /*
 diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c
 b/lib/librte_pmd_ixgbe/ixgbe_pf.c index 51da1fd..495aff5 100644
 --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
 +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
 @@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev,
 __rte_unused uint32_t vf, uint32_t *ms
}
  static int
 +ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf,
 uint32_t *msgbuf)
 +{
 +uint32_t api_version = msgbuf[1];
 +struct ixgbe_vf_info *vfinfo =
 + *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
 +
 +switch (api_version) {
 +case ixgbe_mbox_api_10:
 +case ixgbe_mbox_api_11:
>> Why version 2.0 is not negotiated?
>>
> Because it doesn't fully support 2.0 features yet.

Well, it that case u should not support 2.0 in patch 3 as well.

>
> Thanks
> Changchun
>

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 09:18, Ouyang Changchun wrote:
> Check mq mode for VMDq RSS, handle it correctly instead of returning an error;
> Also remove the limitation of per pool queue number has max value of 1, 
> because
> the per pool queue number could be 2 or 4 if it is VMDq RSS mode;
>
> The number of rxq specified in config will determine the mq mode for VMDq RSS.
>
> Signed-off-by: Changchun Ouyang 
> ---
>   lib/librte_ether/rte_ethdev.c | 39 ++-
>   1 file changed, 34 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 95f2ceb..59ff325 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -510,8 +510,7 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t 
> nb_rx_q, uint16_t nb_tx_q,
>   
>   if (RTE_ETH_DEV_SRIOV(dev).active != 0) {
>   /* check multi-queue mode */
> - if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_RSS) ||
> - (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
> + if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
>   (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB_RSS) ||
>   (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB)) {
>   /* SRIOV only works in VMDq enable mode */
> @@ -525,7 +524,6 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t 
> nb_rx_q, uint16_t nb_tx_q,
>   }
>   
>   switch (dev_conf->rxmode.mq_mode) {
> - case ETH_MQ_RX_VMDQ_RSS:
>   case ETH_MQ_RX_VMDQ_DCB:
>   case ETH_MQ_RX_VMDQ_DCB_RSS:
>   /* DCB/RSS VMDQ in SRIOV mode, not implement yet */
> @@ -534,6 +532,39 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t 
> nb_rx_q, uint16_t nb_tx_q,
>   "unsupported VMDQ mq_mode rx %u\n",
>   port_id, dev_conf->rxmode.mq_mode);
>   return (-EINVAL);
> + case ETH_MQ_RX_RSS:
> + PMD_DEBUG_TRACE("ethdev port_id=%" PRIu8
> + " SRIOV active, "
> + "Rx mq mode is changed from:"
> + "mq_mode %u into VMDQ mq_mode %u\n",
> + port_id,
> + dev_conf->rxmode.mq_mode,
> + dev->data->dev_conf.rxmode.mq_mode);
> + case ETH_MQ_RX_VMDQ_RSS:
> + dev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_VMDQ_RSS;
> + if (nb_rx_q < RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool) {
> + switch (nb_rx_q) {
> + case 1:
> + case 2:
> + RTE_ETH_DEV_SRIOV(dev).active =
> + ETH_64_POOLS;
> + break;
> + case 4:
> + RTE_ETH_DEV_SRIOV(dev).active =
> + ETH_32_POOLS;
> + break;
> + default:
> + PMD_DEBUG_TRACE("ethdev port_id=%d"
> + " SRIOV active, "
> + "queue number invalid\n",
> + port_id);
> + return -EINVAL;
> + }
> + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = nb_rx_q;
> + RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =
> + dev->pci_dev->max_vfs * nb_rx_q;
> + }

Don't u need to return an error in the "else" here?

> + break;
>   default: /* ETH_MQ_RX_VMDQ_ONLY or ETH_MQ_RX_NONE */
>   /* if nothing mq mode configure, use default scheme */
>   dev->data->dev_conf.rxmode.mq_mode = 
> ETH_MQ_RX_VMDQ_ONLY;
> @@ -553,8 +584,6 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t 
> nb_rx_q, uint16_t nb_tx_q,
>   default: /* ETH_MQ_TX_VMDQ_ONLY or ETH_MQ_TX_NONE */
>   /* if nothing mq mode configure, use default scheme */
>   dev->data->dev_conf.txmode.mq_mode = 
> ETH_MQ_TX_VMDQ_ONLY;
> - if (RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool > 1)
> - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool = 1;
>   break;
>   }
>

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 09:18, Ouyang Changchun wrote:
> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS 
> information.
>
> Signed-off-by: Changchun Ouyang 
> ---
>   app/test-pmd/testpmd.c | 10 ++
>   1 file changed, 10 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 8c69756..6230f8b 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1708,6 +1708,16 @@ init_port_config(void)
>   port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
>   }
>   
> + if (port->dev_info.max_vfs != 0) {
> + if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0)
> + port->dev_conf.rxmode.mq_mode =
> + ETH_MQ_RX_VMDQ_RSS;
> + else {
> + port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
> + port->dev_conf.txmode.mq_mode = ETH_MQ_TX_NONE;

And what about the txmode.mq_mode when RSS is available (the :if" clause)?

> + }
> + }
> +
>   port->rx_conf.rx_thresh = rx_thresh;
>   port->rx_conf.rx_free_thresh = rx_free_thresh;
>   port->rx_conf.rx_drop_en = rx_drop_en;

[dpdk-dev] two tso related questions

2015-01-04 Thread Helmut Sim

Hi Alex and Olivier,

Alex, I made the test and the segmentation is not at the IP level (i.e.
each packet ip total length indicated the mss length), hence the 16 bits
total length limitation is not relevant here.
I went over the 82599 datasheet and as Olivier mentioned it is a 18 bits
field, hence allowing up to 256KB length.

Olivier, although tcp window size field is 16 bits the advertised window is
typically higher than 64KB using the TCP window scaling option (which is
the common usage today).

Hence I think that the API should allow at least up to 256KB packet length,
while finding a solution to make sure it also support lower lengths for
other NICs.

Any idea?

Sim

On Wed, Dec 17, 2014 at 3:02 PM, Olivier MATZ 
wrote:

> Hi Helmut,
>
> On 12/17/2014 08:17 AM, Helmut Sim wrote:
>
>> While working on TSO based solution I faced the following two questions:
>>
>> 1.
>> is there a maximum pkt_len to be used with TSO?, e.g. let's say if
>> seg_sz
>> is 1400 can the entire segmented pkt be 256K (higer than 64K) ?, then
>> the
>> driver gets a list of chanined mbufs while the first mbuf is set to
>> TSO
>> offload.
>>
>
> I think the limitations depend on:
>
> - the window size advertised by the peer: your stack should handle this
>   and not generate more packets that what the peer can receive
>
> - the driver: on ixgbe, the maximum payload length is 2^18. I don't know
>   if there is a limitation on number of chained descriptors.
>
> I think we should define a way to know this limitation in the API. Maybe
> a comment saying that the TSO length should not be higher than 256KB (or
> fix it to 64KB in case future drivers do not support 256KB) is enough.
>
> Regards,
> Olivier
>
>

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

2015-01-04 Thread Ouyang, Changchun

> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:40 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version
> 
> 
> On 01/04/15 10:37, Ouyang, Changchun wrote:
> > Hi Vlad,
> >
> >> -Original Message-
> >> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> >> Sent: Sunday, January 4, 2015 4:30 PM
> >> To: Ouyang, Changchun; dev at dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API
> >> version
> >>
> >>
> >> On 01/04/15 10:26, Vlad Zolotarov wrote:
> >>> On 01/04/15 09:18, Ouyang Changchun wrote:
>  Negotiate API version with VF when receiving the
>  IXGBE_VF_API_NEGOTIATE message.
> 
>  Signed-off-by: Changchun Ouyang 
> >>> Reviewed-by: Vlad Zolotarov 
> > Thanks for your reviewing.
> >
> >> One small remark below.
> >>
>  ---
> lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  1 +
> lib/librte_pmd_ixgbe/ixgbe_pf.c | 25
> +
> 2 files changed, 26 insertions(+)
> 
>  diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>  b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>  index ca99170..730098d 100644
>  --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>  +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>  @@ -159,6 +159,7 @@ struct ixgbe_vf_info {
> uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF];
> uint16_t vlan_count;
> uint8_t spoofchk_enabled;
>  +uint8_t api_version;
> };
>   /*
>  diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c
>  b/lib/librte_pmd_ixgbe/ixgbe_pf.c index 51da1fd..495aff5 100644
>  --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
>  +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
>  @@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev,
>  __rte_unused uint32_t vf, uint32_t *ms
> }
>   static int
>  +ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf,
>  uint32_t *msgbuf)
>  +{
>  +uint32_t api_version = msgbuf[1];
>  +struct ixgbe_vf_info *vfinfo =
>  +*IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
>  +
>  +switch (api_version) {
>  +case ixgbe_mbox_api_10:
>  +case ixgbe_mbox_api_11:
> >> Why version 2.0 is not negotiated?
> >>
> > Because it doesn't fully support 2.0 features yet.
> 
> Well, it that case u should not support 2.0 in patch 3 as well.
My opinion is that In patch 3, ixgbe_get_vf_queues need api_11 or api_20 to 
support it,
That mean the feature require those 2 api version, and it can't work with lower 
version like api_10.
Here the code show the pf has the capability of supporting api_10 and api_11,
I think it doesn't contradict. 
Thanks
Changchun

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

2015-01-04 Thread Ouyang, Changchun


> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:45 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode
> 
> 
> On 01/04/15 09:18, Ouyang Changchun wrote:
> > Check mq mode for VMDq RSS, handle it correctly instead of returning
> > an error; Also remove the limitation of per pool queue number has max
> > value of 1, because the per pool queue number could be 2 or 4 if it is
> > VMDq RSS mode;
> >
> > The number of rxq specified in config will determine the mq mode for
> VMDq RSS.
> >
> > Signed-off-by: Changchun Ouyang 
> > ---
> >   lib/librte_ether/rte_ethdev.c | 39
> ++-
> >   1 file changed, 34 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/librte_ether/rte_ethdev.c
> > b/lib/librte_ether/rte_ethdev.c index 95f2ceb..59ff325 100644
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> > @@ -510,8 +510,7 @@ rte_eth_dev_check_mq_mode(uint8_t port_id,
> > uint16_t nb_rx_q, uint16_t nb_tx_q,
> >
> > if (RTE_ETH_DEV_SRIOV(dev).active != 0) {
> > /* check multi-queue mode */
> > -   if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_RSS) ||
> > -   (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
> > +   if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
> > (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB_RSS)
> ||
> > (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB)) {
> > /* SRIOV only works in VMDq enable mode */ @@ -
> 525,7 +524,6 @@
> > rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t nb_rx_q,
> uint16_t nb_tx_q,
> > }
> >
> > switch (dev_conf->rxmode.mq_mode) {
> > -   case ETH_MQ_RX_VMDQ_RSS:
> > case ETH_MQ_RX_VMDQ_DCB:
> > case ETH_MQ_RX_VMDQ_DCB_RSS:
> > /* DCB/RSS VMDQ in SRIOV mode, not implement
> yet */ @@ -534,6
> > +532,39 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t
> nb_rx_q, uint16_t nb_tx_q,
> > "unsupported VMDQ mq_mode
> rx %u\n",
> > port_id, dev_conf-
> >rxmode.mq_mode);
> > return (-EINVAL);
> > +   case ETH_MQ_RX_RSS:
> > +   PMD_DEBUG_TRACE("ethdev port_id=%" PRIu8
> > +   " SRIOV active, "
> > +   "Rx mq mode is changed from:"
> > +   "mq_mode %u into VMDQ
> mq_mode %u\n",
> > +   port_id,
> > +   dev_conf->rxmode.mq_mode,
> > +   dev->data-
> >dev_conf.rxmode.mq_mode);
> > +   case ETH_MQ_RX_VMDQ_RSS:
> > +   dev->data->dev_conf.rxmode.mq_mode =
> ETH_MQ_RX_VMDQ_RSS;
> > +   if (nb_rx_q <
> RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool) {
> > +   switch (nb_rx_q) {
> > +   case 1:
> > +   case 2:
> > +   RTE_ETH_DEV_SRIOV(dev).active =
> > +   ETH_64_POOLS;
> > +   break;
> > +   case 4:
> > +   RTE_ETH_DEV_SRIOV(dev).active =
> > +   ETH_32_POOLS;
> > +   break;
> > +   default:
> > +   PMD_DEBUG_TRACE("ethdev
> port_id=%d"
> > +   " SRIOV active, "
> > +   "queue number invalid\n",
> > +   port_id);
> > +   return -EINVAL;
> > +   }
> > +   RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =
> nb_rx_q;
> > +   RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =
> > +   dev->pci_dev->max_vfs * nb_rx_q;
> > +   }
> 
> Don't u need to return an error in the "else" here?

Actually it has such a check after these code snippet, and it does return error 
for the else case,
Because it is original logic, I don't change any code around it, so it doesn't 
display here, you can check the codes.

Thanks
Changchun

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

2015-01-04 Thread Ouyang, Changchun


> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Sunday, January 4, 2015 4:50 PM
> To: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode
> 
> 
> On 01/04/15 09:18, Ouyang Changchun wrote:
> > Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS
> information.
> >
> > Signed-off-by: Changchun Ouyang 
> > ---
> >   app/test-pmd/testpmd.c | 10 ++
> >   1 file changed, 10 insertions(+)
> >
> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> > 8c69756..6230f8b 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -1708,6 +1708,16 @@ init_port_config(void)
> > port->dev_conf.rxmode.mq_mode =
> ETH_MQ_RX_NONE;
> > }
> >
> > +   if (port->dev_info.max_vfs != 0) {
> > +   if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0)
> > +   port->dev_conf.rxmode.mq_mode =
> > +   ETH_MQ_RX_VMDQ_RSS;
> > +   else {
> > +   port->dev_conf.rxmode.mq_mode =
> ETH_MQ_RX_NONE;
> > +   port->dev_conf.txmode.mq_mode =
> ETH_MQ_TX_NONE;
> 
> And what about the txmode.mq_mode when RSS is available (the :if" clause)?

I think we can keep its original value for txmode.mq_mode, so don't change its 
value. How do you think of it?
Thanks
Changchun

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 10:51, Ouyang, Changchun wrote:
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:40 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version
>>
>>
>> On 01/04/15 10:37, Ouyang, Changchun wrote:
>>> Hi Vlad,
>>>
 -Original Message-
 From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
 Sent: Sunday, January 4, 2015 4:30 PM
 To: Ouyang, Changchun; dev at dpdk.org
 Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API
 version


 On 01/04/15 10:26, Vlad Zolotarov wrote:
> On 01/04/15 09:18, Ouyang Changchun wrote:
>> Negotiate API version with VF when receiving the
>> IXGBE_VF_API_NEGOTIATE message.
>>
>> Signed-off-by: Changchun Ouyang 
> Reviewed-by: Vlad Zolotarov 
>>> Thanks for your reviewing.
>>>
 One small remark below.

>> ---
>> lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  1 +
>> lib/librte_pmd_ixgbe/ixgbe_pf.c | 25
>> +
>> 2 files changed, 26 insertions(+)
>>
>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>> index ca99170..730098d 100644
>> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h
>> @@ -159,6 +159,7 @@ struct ixgbe_vf_info {
>> uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF];
>> uint16_t vlan_count;
>> uint8_t spoofchk_enabled;
>> +uint8_t api_version;
>> };
>>   /*
>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c
>> b/lib/librte_pmd_ixgbe/ixgbe_pf.c index 51da1fd..495aff5 100644
>> --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c
>> +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c
>> @@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev,
>> __rte_unused uint32_t vf, uint32_t *ms
>> }
>>   static int
>> +ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf,
>> uint32_t *msgbuf)
>> +{
>> +uint32_t api_version = msgbuf[1];
>> +struct ixgbe_vf_info *vfinfo =
>> +*IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private);
>> +
>> +switch (api_version) {
>> +case ixgbe_mbox_api_10:
>> +case ixgbe_mbox_api_11:
 Why version 2.0 is not negotiated?

>>> Because it doesn't fully support 2.0 features yet.
>> Well, it that case u should not support 2.0 in patch 3 as well.
> My opinion is that In patch 3, ixgbe_get_vf_queues need api_11 or api_20 to 
> support it,
> That mean the feature require those 2 api version, and it can't work with 
> lower version like api_10.
> Here the code show the pf has the capability of supporting api_10 and api_11,
> I think it doesn't contradict.

After a second pass on this code and code in PATCH3 I agree that it's ok.

> Thanks
> Changchun
>

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 10:58, Ouyang, Changchun wrote:
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:45 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode
>>
>>
>> On 01/04/15 09:18, Ouyang Changchun wrote:
>>> Check mq mode for VMDq RSS, handle it correctly instead of returning
>>> an error; Also remove the limitation of per pool queue number has max
>>> value of 1, because the per pool queue number could be 2 or 4 if it is
>>> VMDq RSS mode;
>>>
>>> The number of rxq specified in config will determine the mq mode for
>> VMDq RSS.
>>> Signed-off-by: Changchun Ouyang 
>>> ---
>>>lib/librte_ether/rte_ethdev.c | 39
>> ++-
>>>1 file changed, 34 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/lib/librte_ether/rte_ethdev.c
>>> b/lib/librte_ether/rte_ethdev.c index 95f2ceb..59ff325 100644
>>> --- a/lib/librte_ether/rte_ethdev.c
>>> +++ b/lib/librte_ether/rte_ethdev.c
>>> @@ -510,8 +510,7 @@ rte_eth_dev_check_mq_mode(uint8_t port_id,
>>> uint16_t nb_rx_q, uint16_t nb_tx_q,
>>>
>>> if (RTE_ETH_DEV_SRIOV(dev).active != 0) {
>>> /* check multi-queue mode */
>>> -   if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_RSS) ||
>>> -   (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
>>> +   if ((dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) ||
>>> (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB_RSS)
>> ||
>>> (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB)) {
>>> /* SRIOV only works in VMDq enable mode */ @@ -
>> 525,7 +524,6 @@
>>> rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t nb_rx_q,
>> uint16_t nb_tx_q,
>>> }
>>>
>>> switch (dev_conf->rxmode.mq_mode) {
>>> -   case ETH_MQ_RX_VMDQ_RSS:
>>> case ETH_MQ_RX_VMDQ_DCB:
>>> case ETH_MQ_RX_VMDQ_DCB_RSS:
>>> /* DCB/RSS VMDQ in SRIOV mode, not implement
>> yet */ @@ -534,6
>>> +532,39 @@ rte_eth_dev_check_mq_mode(uint8_t port_id, uint16_t
>> nb_rx_q, uint16_t nb_tx_q,
>>> "unsupported VMDQ mq_mode
>> rx %u\n",
>>> port_id, dev_conf-
>>> rxmode.mq_mode);
>>> return (-EINVAL);
>>> +   case ETH_MQ_RX_RSS:
>>> +   PMD_DEBUG_TRACE("ethdev port_id=%" PRIu8
>>> +   " SRIOV active, "
>>> +   "Rx mq mode is changed from:"
>>> +   "mq_mode %u into VMDQ
>> mq_mode %u\n",
>>> +   port_id,
>>> +   dev_conf->rxmode.mq_mode,
>>> +   dev->data-
>>> dev_conf.rxmode.mq_mode);
>>> +   case ETH_MQ_RX_VMDQ_RSS:
>>> +   dev->data->dev_conf.rxmode.mq_mode =
>> ETH_MQ_RX_VMDQ_RSS;
>>> +   if (nb_rx_q <
>> RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool) {

Missed that before: shouldn't it be "<=" here?

>>> +   switch (nb_rx_q) {
>>> +   case 1:
>>> +   case 2:
>>> +   RTE_ETH_DEV_SRIOV(dev).active =
>>> +   ETH_64_POOLS;
>>> +   break;
>>> +   case 4:
>>> +   RTE_ETH_DEV_SRIOV(dev).active =
>>> +   ETH_32_POOLS;
>>> +   break;
>>> +   default:
>>> +   PMD_DEBUG_TRACE("ethdev
>> port_id=%d"
>>> +   " SRIOV active, "
>>> +   "queue number invalid\n",
>>> +   port_id);
>>> +   return -EINVAL;
>>> +   }
>>> +   RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =
>> nb_rx_q;
>>> +   RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =
>>> +   dev->pci_dev->max_vfs * nb_rx_q;
>>> +   }
>> Don't u need to return an error in the "else" here?
> Actually it has such a check after these code snippet, and it does return 
> error for the else case,
> Because it is original logic, I don't change any code around it, so it 
> doesn't display here, you can check the codes.

I see. The flow is a bit confusing since the switch-case above will end 
up executing a "default" clause which will set 
RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool to 1 and then the error message in 
the check u are referring will be a bit confusing.

>
> Thanks
> Changchun
> 
>

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

2015-01-04 Thread Vlad Zolotarov


On 01/04/15 11:01, Ouyang, Changchun wrote:
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Sunday, January 4, 2015 4:50 PM
>> To: Ouyang, Changchun; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode
>>
>>
>> On 01/04/15 09:18, Ouyang Changchun wrote:
>>> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS
>> information.
>>> Signed-off-by: Changchun Ouyang 
>>> ---
>>>app/test-pmd/testpmd.c | 10 ++
>>>1 file changed, 10 insertions(+)
>>>
>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
>>> 8c69756..6230f8b 100644
>>> --- a/app/test-pmd/testpmd.c
>>> +++ b/app/test-pmd/testpmd.c
>>> @@ -1708,6 +1708,16 @@ init_port_config(void)
>>> port->dev_conf.rxmode.mq_mode =
>> ETH_MQ_RX_NONE;
>>> }
>>>
>>> +   if (port->dev_info.max_vfs != 0) {
>>> +   if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0)
>>> +   port->dev_conf.rxmode.mq_mode =
>>> +   ETH_MQ_RX_VMDQ_RSS;
>>> +   else {
>>> +   port->dev_conf.rxmode.mq_mode =
>> ETH_MQ_RX_NONE;
>>> +   port->dev_conf.txmode.mq_mode =
>> ETH_MQ_TX_NONE;
>>
>> And what about the txmode.mq_mode when RSS is available (the :if" clause)?
> I think we can keep its original value for txmode.mq_mode, so don't change 
> its value. How do you think of it?

I agree that not changing a Tx mq_mode in both cases would be better.

> Thanks
> Changchun
>
>

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2015-01-04 Thread Xie, Huawei

> -Original Message-
> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
> Sent: Wednesday, December 24, 2014 12:21 AM
> To: Xie, Huawei; dev at dpdk.org
> Cc: haifeng.lin at intel.com
> Subject: Re: [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support
> 
> (2014/12/11 6:37), Huawei Xie wrote:
> > vhost-user support
> >
> >
> 
> I guess 'feature' should be filled as payload like below.
> msg.payload.u64 = features;
>

Applied. Thanks.

> Thanks,
> Tetsuya
>

[dpdk-dev] two tso related questions

2015-01-04 Thread Alex Markuze

On Sun, Jan 4, 2015 at 10:50 AM, Helmut Sim  wrote:

> Hi Alex and Olivier,
>
> Alex, I made the test and the segmentation is not at the IP level (i.e.
> each packet ip total length indicated the mss length), hence the 16 bits
> total length limitation is not relevant here.
>

Oliver thanks for reporting back, this is interesting but doesn't come as a
surprise as the headers must be correct when on the wire, what I couldn't
tell you is what happens with the identificayion/Frag off fields.

The IP length limitation comes from the send side network stack,
theoreticaly Its possible to send a packet of any size as long as your
network stack doesn't mind sending a packet with a malformed IP header(as
the length field is not defined).
  .
The send side HW recieves a single packet with the ip length of the whole
packet. Assuming that the ixgbe HW takes the packet len for its TSO
fragmentation from the TX descriptor rather then from the IP header, it
should be able to send as much as the HW supports.

> I went over the 82599 datasheet and as Olivier mentioned it is a 18 bits
> field, hence allowing up to 256KB length.
>
> Olivier, although tcp window size field is 16 bits the advertised window
> is typically higher than 64KB using the TCP window scaling option (which is
> the common usage today).
>
> Hence I think that the API should allow at least up to 256KB packet
> length, while finding a solution to make sure it also support lower lengths
> for other NICs.
>
> Any idea?
>
> Sim
>
> On Wed, Dec 17, 2014 at 3:02 PM, Olivier MATZ 
> wrote:
>
>> Hi Helmut,
>>
>> On 12/17/2014 08:17 AM, Helmut Sim wrote:
>>
>>> While working on TSO based solution I faced the following two questions:
>>>
>>> 1.
>>> is there a maximum pkt_len to be used with TSO?, e.g. let's say if
>>> seg_sz
>>> is 1400 can the entire segmented pkt be 256K (higer than 64K) ?, then
>>> the
>>> driver gets a list of chanined mbufs while the first mbuf is set to
>>> TSO
>>> offload.
>>>
>>
>> I think the limitations depend on:
>>
>> - the window size advertised by the peer: your stack should handle this
>>   and not generate more packets that what the peer can receive
>>
>> - the driver: on ixgbe, the maximum payload length is 2^18. I don't know
>>   if there is a limitation on number of chained descriptors.
>>
>> I think we should define a way to know this limitation in the API. Maybe
>> a comment saying that the TSO length should not be higher than 256KB (or
>> fix it to 64KB in case future drivers do not support 256KB) is enough.
>>
>> Regards,
>> Olivier
>>
>>
>

[dpdk-dev] two tso related questions

2015-01-04 Thread Helmut Sim

correct.
In such case, a modified api should not require to set the ip_hdr
total_length field, which is 16 bits.
The HW will assign the correct packet length for each transmitted IP packet
which is l3_len+l4_len+mss (except of the last segment which may be smaller
than mss).

Sim

On Sun, Jan 4, 2015 at 11:57 AM, Alex Markuze  wrote:

>
>
> On Sun, Jan 4, 2015 at 10:50 AM, Helmut Sim  wrote:
>
>> Hi Alex and Olivier,
>>
>> Alex, I made the test and the segmentation is not at the IP level (i.e.
>> each packet ip total length indicated the mss length), hence the 16 bits
>> total length limitation is not relevant here.
>>
>
> Oliver thanks for reporting back, this is interesting but doesn't come as
> a surprise as the headers must be correct when on the wire, what I couldn't
> tell you is what happens with the identificayion/Frag off fields.
>
> The IP length limitation comes from the send side network stack,
> theoreticaly Its possible to send a packet of any size as long as your
> network stack doesn't mind sending a packet with a malformed IP header(as
> the length field is not defined).
>   .
> The send side HW recieves a single packet with the ip length of the whole
> packet. Assuming that the ixgbe HW takes the packet len for its TSO
> fragmentation from the TX descriptor rather then from the IP header, it
> should be able to send as much as the HW supports.
>
>
>> I went over the 82599 datasheet and as Olivier mentioned it is a 18 bits
>> field, hence allowing up to 256KB length.
>>
>> Olivier, although tcp window size field is 16 bits the advertised window
>> is typically higher than 64KB using the TCP window scaling option (which is
>> the common usage today).
>>
>> Hence I think that the API should allow at least up to 256KB packet
>> length, while finding a solution to make sure it also support lower lengths
>> for other NICs.
>>
>> Any idea?
>>
>> Sim
>>
>> On Wed, Dec 17, 2014 at 3:02 PM, Olivier MATZ 
>> wrote:
>>
>>> Hi Helmut,
>>>
>>> On 12/17/2014 08:17 AM, Helmut Sim wrote:
>>>
 While working on TSO based solution I faced the following two questions:

 1.
 is there a maximum pkt_len to be used with TSO?, e.g. let's say if
 seg_sz
 is 1400 can the entire segmented pkt be 256K (higer than 64K) ?,
 then
 the
 driver gets a list of chanined mbufs while the first mbuf is set to
 TSO
 offload.

>>>
>>> I think the limitations depend on:
>>>
>>> - the window size advertised by the peer: your stack should handle this
>>>   and not generate more packets that what the peer can receive
>>>
>>> - the driver: on ixgbe, the maximum payload length is 2^18. I don't know
>>>   if there is a limitation on number of chained descriptors.
>>>
>>> I think we should define a way to know this limitation in the API. Maybe
>>> a comment saying that the TSO length should not be higher than 256KB (or
>>> fix it to 64KB in case future drivers do not support 256KB) is enough.
>>>
>>> Regards,
>>> Olivier
>>>
>>>
>>
>

[dpdk-dev] [PATCH 0/7] Move EAL common functions

2015-01-04 Thread Ravi Kerur

Hi,

I plan to work on this and would like to know if I need consider anything
else other than mentioned in the email by Olivier/Neil i.e.go with 2
directories

common-os/generic-os
common-posix

under librte_eal directory and move relevant files accordingly.

Thanks,
Ravi

On Mon, Dec 29, 2014 at 10:43 AM, Ravi Kerur  wrote:

> Thanks Olivier and Neil. I will make a note on this and will work on it
> after initial common code movement is completed.
>
>
> On Mon, Dec 29, 2014 at 5:16 AM, Olivier MATZ 
> wrote:
>
>> Hi Neil,
>>
>> On 12/29/2014 01:47 PM, Neil Horman wrote:
>> > On Mon, Dec 29, 2014 at 09:47:05AM +0100, Olivier MATZ wrote:
>> >> Trying to factorize the common code goes in the good direction.
>> >>
>> >> However I'm wondering if "common" is the proper place. Initially,
>> >> the common directory was for code common to linuxapp and baremetal.
>> >> Now that baremetal does not exist anymore, a lot of code is common
>> >> to the 2 OSes that are supported (linux and FreeBSD).
>> >>
>> >> What about moving this code in "common-posix" instead?
>> >> It would let the door open for future ports (Windows? or any
>> >> other real time OS? Or back in baremetal?).
>> >>
>> > Posix doesn't make sense IMO, in that a large segment of the functions
>> embodied
>> > in the common directory have nothing to do with posix API's, and are
>> simply just
>> > useful functions that have not OS specific dependency (the entire
>> > eal_common_memory.c file for example, to name just one).
>> >
>> > If you wanted to rename the directory, I would say generic-os would be
>> more
>> > appropriate.
>>
>> That's probably right for most of the code in the patch. I just wanted
>> to point out that "common" is sometimes a bit vague (common to archs,
>> common to OSes, common to all).
>>
>> From a quick look, these 2 files could be concerned and could go to a
>> common-posix directory:
>> - eal.c (use fopen/ftruncate/fcntl/mmap/...)
>> - eal_thread.c (use pipe/read/write)
>>
>> There's no urgency to do that now and maybe we should wait it's really
>> needed. I was just seizing the opportunity as the code is moved.
>>
>> Regards,
>> Olivier
>>
>
>

[dpdk-dev] Q on Support for I217 and I218 Intel chipsets.

2015-01-04 Thread Ravi Kerur

Hi,

We have a Gigabyte H97N motherboard which has I217 Intel chipset which uses
e100e drivers. I looked into lib/librte_pmd_e1000 directory and I do see
that e1000e code is integrated but missing some support for read/write from
flash_address and other minor things. I have made changes shown below and
have done some testing with testpmd utility and now have following questions

1. What amount of testing is required to qualify patch as successfully
tested on new chipsets

2. FreeBSD testing, currently we have Ubuntu 14.04 installed on existing
H97N motherboard and testing is done solely on Linux. We plan to get
another motherboard which will have I218 chipset and still deciding whether
to go with FreeBSD or Ubuntu. So the question I have is what amount of
testing should be done on FreeBSD? I don't think setup.sh/dpdk_nic_bind.py
works on FreeBSD yet hence the question on testing.

Thanks,
Ravi



On Sun, Jan 4, 2015 at 3:15 PM, Ravi Kerur  wrote:

> This patch adds support for I217 and I218 Intel chipsets.
> Gigabyte H97N motherboard has I217 Intel chipsets and changes
> include
>
> 1. Add relevant device-ids via RTE_PCI_DEV_ID_DECL_EM
> 2. Add support for memory mapped flash address read/write
>
> Basic testing on Ubuntu with testpmd utility.
>
> Signed-off-by: Ravi Kerur 
> ---
>  lib/librte_eal/common/include/rte_pci_dev_ids.h |  4 
>  lib/librte_pmd_e1000/e1000/e1000_api.c  | 21 +
>  lib/librte_pmd_e1000/e1000/e1000_api.h  |  1 +
>  lib/librte_pmd_e1000/e1000/e1000_osdep.h| 24
> +++-
>  lib/librte_pmd_e1000/em_ethdev.c|  7 +++
>  5 files changed, 52 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h
> b/lib/librte_eal/common/include/rte_pci_dev_ids.h
> index c922de9..712793a 100644
> --- a/lib/librte_eal/common/include/rte_pci_dev_ids.h
> +++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h
> @@ -274,6 +274,10 @@ RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL,
> E1000_DEV_ID_82572EI)
>  RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82573L)
>  RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82574L)
>  RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_82574LA)
> +RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_PCH_LPT_I217_LM)
> +RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_PCH_LPT_I217_V)
> +RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL,
> E1000_DEV_ID_PCH_LPTLP_I218_LM)
> +RTE_PCI_DEV_ID_DECL_EM(PCI_VENDOR_ID_INTEL, E1000_DEV_ID_PCH_LPTLP_I218_V)
>
>  / Physical IGB devices from e1000_hw.h
> /
>
> diff --git a/lib/librte_pmd_e1000/e1000/e1000_api.c
> b/lib/librte_pmd_e1000/e1000/e1000_api.c
> index a064565..30ed1f3 100644
> --- a/lib/librte_pmd_e1000/e1000/e1000_api.c
> +++ b/lib/librte_pmd_e1000/e1000/e1000_api.c
> @@ -1355,3 +1355,24 @@ void e1000_shutdown_fiber_serdes_link(struct
> e1000_hw *hw)
> hw->mac.ops.shutdown_serdes(hw);
>  }
>
> +/**
> + *  e1000_device_is_ich8 - Check for ICH8 device
> + *  @hw: pointer to the HW structure
> + *
> + *  return TRUE for ICH8, otherwise FALSE
> + **/
> +bool e1000_device_is_ich8(struct e1000_hw *hw)
> +{
> +   DEBUGFUNC("e1000_device_is_ich8");
> +
> +   switch (hw->device_id) {
> +   case E1000_DEV_ID_PCH_LPT_I217_LM:
> +   case E1000_DEV_ID_PCH_LPT_I217_V:
> +   case E1000_DEV_ID_PCH_LPTLP_I218_LM:
> +   case E1000_DEV_ID_PCH_LPTLP_I218_V:
> +   return 1;
> +
> +   default:
> +   return 0;
> +   }
> +}
> diff --git a/lib/librte_pmd_e1000/e1000/e1000_api.h
> b/lib/librte_pmd_e1000/e1000/e1000_api.h
> index 02b16da..f96a674 100644
> --- a/lib/librte_pmd_e1000/e1000/e1000_api.h
> +++ b/lib/librte_pmd_e1000/e1000/e1000_api.h
> @@ -49,6 +49,7 @@ extern void e1000_init_function_pointers_vf(struct
> e1000_hw *hw);
>  extern void e1000_power_up_fiber_serdes_link(struct e1000_hw *hw);
>  extern void e1000_shutdown_fiber_serdes_link(struct e1000_hw *hw);
>  extern void e1000_init_function_pointers_i210(struct e1000_hw *hw);
> +extern bool e1000_device_is_ich8(struct e1000_hw *hw);
>
>  s32 e1000_set_obff_timer(struct e1000_hw *hw, u32 itr);
>  s32 e1000_set_mac_type(struct e1000_hw *hw);
> diff --git a/lib/librte_pmd_e1000/e1000/e1000_osdep.h
> b/lib/librte_pmd_e1000/e1000/e1000_osdep.h
> index 438641e..19146a3 100644
> --- a/lib/librte_pmd_e1000/e1000/e1000_osdep.h
> +++ b/lib/librte_pmd_e1000/e1000/e1000_osdep.h
> @@ -95,13 +95,22 @@ typedef int bool;
>
>  #define E1000_PCI_REG(reg) (*((volatile uint32_t *)(reg)))
>
> +#define E1000_PCI_REG16(reg) (*((volatile uint16_t *)(reg)))
> +
>  #define E1000_PCI_REG_WRITE(reg, value) do { \
> E1000_PCI_REG((reg)) = (value); \
>  } while (0)
>
> +#define E1000_PCI_REG_WRITE16(reg, value) do { \
> +   E1000_PCI_REG16((reg)) = (value); \
> +} while (0)
> +
>  #define E1000_PCI_REG_ADDR(hw, reg) \
> ((volatile uint32_t

[dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS

[dpdk-dev] l3fwd error, port 0 is not present on the board

[dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS

[dpdk-dev] [PATCH v4 0/6] Enable VF RSS for Niantic

[dpdk-dev] [PATCH v4 1/6] ixgbe: Code cleanup

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

[dpdk-dev] [PATCH v4 5/6] ixgbe: Config VF RSS

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

[dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number

[dpdk-dev] [PATCH v4 1/6] ixgbe: Code cleanup

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

[dpdk-dev] [PATCH v4 3/6] ixgbe: Get VF queue number

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

[dpdk-dev] two tso related questions

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

[dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version

[dpdk-dev] [PATCH v4 4/6] ether: Check VMDq RSS mode

[dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

[dpdk-dev] two tso related questions

[dpdk-dev] two tso related questions

[dpdk-dev] [PATCH 0/7] Move EAL common functions

[dpdk-dev] Q on Support for I217 and I218 Intel chipsets.

30 matches

Site Navigation

Mail list logo

Footer information