[dpdk-dev] VLAN header insertion and removal

[Padam Jeet Singh]

Hello, 

I have done a simple mbuf adjust and prepend to achieve the removal and 
insertion of the vlan header and it works fine. The use case is something 
similar to the l3fwd example where one port has traffic coming in on multiple 
vlans and the other port has no vlans. The packet processing path in the middle 
inserts or removes the vlan. 

Is there an offload flag or mode where this can be done in hardware? Or is 
there a more optimized way to do this in dpdk? For sake of performance I want 
to avoid the copy ethernet header, modify mbuf, copy back the header steps. 

Thanks, 
Padam 
---
Sent from my mobile. Please excuse the brevity, spelling and punctuation. 

[dpdk-dev] [PATCH 0/6] Enable VF RSS for Niantic

[Vladislav Zolotarov]

On Dec 19, 2014 3:35 AM, "Ouyang, Changchun" 
wrote:
>
> My response as below.
>
>
>
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Thursday, December 18, 2014 9:06 PM
> To: dev at dpdk.org; Ouyang, Changchun
> Subject: Re: [PATCH 0/6] Enable VF RSS for Niantic
>
>
>
>
>
> On 12/18/14 12:11, Vlad Zolotarov wrote:
>>
>> From: Changchun Ouyang 
>>
>>
>>
>> This patch enables VF RSS for Niantic, which allow each VF having at
most 4 queues.
>>
>> The actual queue number per VF depends on the number of VF:
>>
>> VF number from 1~32: 4 queues per VF;
>>
>> VF number from 33~max vf num: 2 queues per VF;
>>
>>
>>
>> On host, to enable VF RSS functionality, mq mode should be set as
ETH_MQ_RX_VMDQ_RSS
>>
>> or ETH_MQ_RX_RSS mode, and SRIOV mode should be activated.
>>
>> It also needs config VF RSS information like hash function, RSS key, RSS
key length.
>
>
> This patch series is missing a few things:
>
> Taking into the consideration the number of Rx queues requested by a user
in the rte_eth_dev_configure().
>
> Changchun: yes, will have a v2 to consider it, as I say in my previous
response.

I must have joined the mailing list after your v2 series. I'll take a look
in the web for it.

>
> dev->dev_ops->reta_query used by a rte_eth_dev_rss_reta_query() is still
not initialized for a VF. Thus there is no way to query the RSS table
>
> Changchun: do you mean query rss table on guest?

Of course.

Niantic doesn?t have separate reta for a specific vf, the reta is shared by
pf and all vf.

AFAIK the reta is statically divided between all available functions.

So, first of all we need a way to know that is the size of a single VF
partition in order to know how many RSS queues may be configured.

Then we need an ability to query/set the contents of the corresponding reta
partition like we can for PF.

>
> Do you think of returning all reta contents for each vf make sense?  Or
any other insight here?
>
> rte_eth_dev_info_get() returns reta_size == 0 when called for a VF
function.
>
> Changchun:  same as above.
>
> Your insight here are welcome here.
>
> thanks
>
> Changchun
>
>

[dpdk-dev] VLAN header insertion and removal

[Alex Markuze]

On ingress when configuring the device
1.modify
the rte_eth_conf.rxmode.hw_vlan_strip  = 1,

On egress you need to  modify the rte_van_macip struct in the sent mbuf*.
(rte_mbuf.h)
   1. add the PKT_TX_VLAN_PKT to the
ol_flags fields.
   2. fill the plan_tci in
pkt.vlan_macip.f.vlan_tci

*This is true for dpdk 1.7, structs may have moved in 1.8

On Sat, Dec 20, 2014 at 8:39 PM, Padam Jeet Singh 
wrote:

> Hello,
>
> I have done a simple mbuf adjust and prepend to achieve the removal and
> insertion of the vlan header and it works fine. The use case is something
> similar to the l3fwd example where one port has traffic coming in on
> multiple vlans and the other port has no vlans. The packet processing path
> in the middle inserts or removes the vlan.
>
> Is there an offload flag or mode where this can be done in hardware? Or is
> there a more optimized way to do this in dpdk? For sake of performance I
> want to avoid the copy ethernet header, modify mbuf, copy back the header
> steps.
>
> Thanks,
> Padam
> ---
> Sent from my mobile. Please excuse the brevity, spelling and punctuation.
>
>