[dpdk-dev] [PATCH] librte_log: add function to retrieve log_level
Signed-off-by: Matthew Hall
---
lib/librte_eal/common/eal_common_log.c | 7 +++
lib/librte_eal/common/include/rte_log.h | 6 ++
2 files changed, 13 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_log.c
b/lib/librte_eal/common/eal_common_log.c
index e4df0b9..d979f28 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -176,6 +176,13 @@ rte_set_log_level(uint32_t level)
rte_logs.level = (uint32_t)level;
}
+/* Get global log level */
+uint32_t
+rte_get_log_level()
+{
+ return rte_logs.level;
+}
+
/* Set global log type */
void
rte_set_log_type(uint32_t type, int enable)
diff --git a/lib/librte_eal/common/include/rte_log.h
b/lib/librte_eal/common/include/rte_log.h
index 565415a..7f1c2f9 100644
--- a/lib/librte_eal/common/include/rte_log.h
+++ b/lib/librte_eal/common/include/rte_log.h
@@ -130,6 +130,12 @@ int rte_openlog_stream(FILE *f);
void rte_set_log_level(uint32_t level);
/**
+ * Get the global log level.
+ *
+ */
+uint32_t rte_get_log_level(void);
+
+/**
* Enable or disable the log type.
*
* @param type
--
1.9.1
[dpdk-dev] [PATCH] librte_log: add function to retrieve log_level
On Sun, Sep 14, 2014 at 01:34:46AM -0700, Matthew Hall wrote: > Signed-off-by: Matthew Hall > --- > lib/librte_eal/common/eal_common_log.c | 7 +++ > lib/librte_eal/common/include/rte_log.h | 6 ++ > 2 files changed, 13 insertions(+) I forgot to mention in the comments, this patch is helpful when you want outside code to cooperate with and respect log levels set in DPDK. Then you can avoid using duplicate incompatible log code in the DPDK and non-DPDK parts of the app. Matthew.
[dpdk-dev] l2fwd mmap memory failed
Hi all, The l2fwd sample application starts failed in my environment with 9 2M hugepages set up. It tells me that mmap failed: Cannot allocate memory. Is there a limited max hugepages or memory size for dpdk to mmap EAL memory? Some information as follows: 1. Environment: Host OS: Suse11 Sp3 x86_64 NIC: intel 82599 DPDK: 1.6.0r2 2. Hugepage Configuration in Kernel command line: hugepagesz=2M default_hugepagesz=2M hugepages=9 3. l2fwd command line: ./build/l2fwd -c 0x3 -n 3 --socket-mem 2048 -- -q 1 -p 3 4. cat /proc/meminfo: HugePages_Total: 9 HugePages_Free:9 HugePages_Rsvd:0 HugePages_Surp:0 Hugepagesize: 2048 kB 5. Error messages in dpdk log: Sun Sep 14 08:37:28 2014:EAL: Detected lcore 0 as core 0 on socket 0 Sun Sep 14 08:37:28 2014:EAL: Detected lcore 1 as core 1 on socket 0 Sun Sep 14 08:37:28 2014:EAL: Setting up memory... Sun Sep 14 08:38:44 2014:EAL: map_all_hugepages(): mmap failed: Cannot allocate memory Sun Sep 14 08:38:44 2014:EAL: Failed to mmap 2 MB hugepages Sun Sep 14 08:38:44 2014:EAL: Cannot init memory Sun Sep 14 08:38:44 2014:EAL: Error - exiting with code: 1 Cause: Sun Sep 14 08:38:44 2014:Invalid EAL parameters Anyone know the issue and the corresponding fix? Thanks. B.R. Jerry
[dpdk-dev] l2fwd mmap memory failed
Hi, >-Original Message- >From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of jerry >Sent: Sunday, September 14, 2014 5:01 PM >To: dev at dpdk.org >Cc: luonengjun at huawei.com >Subject: [dpdk-dev] l2fwd mmap memory failed > >Hi all, > >The l2fwd sample application starts failed in my environment with 9 2M >hugepages set up. >It tells me that mmap failed: Cannot allocate memory. >Is there a limited max hugepages or memory size for dpdk to mmap EAL >memory? > >Some information as follows: > >1. Environment: >Host OS: Suse11 Sp3 x86_64 >NIC: intel 82599 >DPDK: 1.6.0r2 > >2. Hugepage Configuration in Kernel command line: >hugepagesz=2M default_hugepagesz=2M hugepages=9 > >3. l2fwd command line: >./build/l2fwd -c 0x3 -n 3 --socket-mem 2048 -- -q 1 -p 3 > >4. cat /proc/meminfo: >HugePages_Total: 9 >HugePages_Free:9 >HugePages_Rsvd:0 >HugePages_Surp:0 >Hugepagesize: 2048 kB > >5. Error messages in dpdk log: >Sun Sep 14 08:37:28 2014:EAL: Detected lcore 0 as core 0 on socket 0 Sun Sep 14 >08:37:28 2014:EAL: Detected lcore 1 as core 1 on socket 0 Sun Sep 14 08:37:28 >2014:EAL: Setting up memory... >Sun Sep 14 08:38:44 2014:EAL: map_all_hugepages(): mmap failed: Cannot >allocate memory Sun Sep 14 08:38:44 2014:EAL: Failed to mmap 2 MB >hugepages Sun Sep 14 08:38:44 2014:EAL: Cannot init memory Sun Sep 14 >08:38:44 2014:EAL: Error - exiting with code: 1 > Cause: Sun Sep 14 08:38:44 2014:Invalid EAL parameters > > >Anyone know the issue and the corresponding fix? Thanks. It's a system mmap failure. As you have to map so many huge pages, I suggest that you check /proc/sys/vm/max_map_count to see if the map count exceeds the max value.
[dpdk-dev] [PATCH v2 0/5] support of configurable CRC stripping in VF
To support configurable CRC stripping in both PF host and VF, a new operation and a new structure are added to carry more configurations from VF to PF host. v2 changes: * Put all the renaming and code style fixes into a patch. * Put processing crc stripping configuration in PF host into a single patch. * Put setting the crc stripping into a single patch. * Put the configuring crc stripping in VF into a single patch. * Added several more code style fixes reported by checkpatch.pl. Helin Zhang (5): config: remove useless i40e items in config files i40e: renaming and code style fix i40e: support of processing crc stripping config in PF host i40e: set crc stripping in rx queue configuration i40evf: support of configurable crc stripping in VF config/common_bsdapp | 1 - config/common_linuxapp | 1 - lib/librte_pmd_i40e/i40e_ethdev_vf.c | 188 --- lib/librte_pmd_i40e/i40e_pf.c| 94 +++--- lib/librte_pmd_i40e/i40e_pf.h| 7 ++ 5 files changed, 193 insertions(+), 98 deletions(-) -- 1.8.1.4
[dpdk-dev] [PATCH v2 2/5] i40e: renaming and code style fix
Rename some local variables in i40e_pf.c and
i40e_ethdev_vf.c, to express more accurately and briefly.
Fix several issues in i40e_pf.c reported by checkpatch.pl.
Line warpping for some source lines which has more than 80
characters, and merge lines together for those source lines
which does not need any line wrapping actually.
v2 changes:
* Put all the renaming and code style fixes into a patch.
* Add several more code style fixes for i40e_pf.c.
Signed-off-by: Helin Zhang
Reviewed-by: Jingjing Wu
Reviewed-by: Jing Chen
---
lib/librte_pmd_i40e/i40e_ethdev_vf.c | 75 ++--
lib/librte_pmd_i40e/i40e_pf.c| 53 +++--
2 files changed, 61 insertions(+), 67 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c
b/lib/librte_pmd_i40e/i40e_ethdev_vf.c
index d8552ad..113bff8 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev_vf.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev_vf.c
@@ -527,27 +527,27 @@ static int
i40evf_configure_queues(struct rte_eth_dev *dev)
{
struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
- struct i40e_virtchnl_vsi_queue_config_info *queue_info;
- struct i40e_virtchnl_queue_pair_info *queue_cfg;
struct i40e_rx_queue **rxq =
(struct i40e_rx_queue **)dev->data->rx_queues;
struct i40e_tx_queue **txq =
(struct i40e_tx_queue **)dev->data->tx_queues;
- int i, len, nb_qpairs, num_rxq, num_txq;
- int err;
+ struct i40e_virtchnl_vsi_queue_config_info *vc_vqci;
+ struct i40e_virtchnl_queue_pair_info *vc_qpi;
+ int size, i, nb_qp, ret, num_rxq, num_txq;
struct vf_cmd_info args;
struct rte_pktmbuf_pool_private *mbp_priv;
- nb_qpairs = vf->num_queue_pairs;
- len = sizeof(*queue_info) + sizeof(*queue_cfg) * nb_qpairs;
- queue_info = rte_zmalloc("queue_info", len, 0);
- if (queue_info == NULL) {
- PMD_INIT_LOG(ERR, "failed alloc memory for queue_info\n");
- return -1;
+ nb_qp = vf->num_queue_pairs;
+ size = sizeof(*vc_vqci) + sizeof(*vc_qpi) * nb_qp;
+ vc_vqci = rte_zmalloc("vc_vqci", size, 0);
+ if (!vc_vqci) {
+ PMD_DRV_LOG(ERR, "Failed to allocate memory for VF "
+ "configuring queues\n");
+ return -ENOMEM;
}
- queue_info->vsi_id = vf->vsi_res->vsi_id;
- queue_info->num_queue_pairs = nb_qpairs;
- queue_cfg = queue_info->qpair;
+ vc_vqci->vsi_id = vf->vsi_res->vsi_id;
+ vc_vqci->num_queue_pairs = nb_qp;
+ vc_qpi = vc_vqci->qpair;
num_rxq = dev->data->nb_rx_queues;
num_txq = dev->data->nb_tx_queues;
@@ -557,48 +557,49 @@ i40evf_configure_queues(struct rte_eth_dev *dev)
* work that way. The solution is fills 0 with HW ring option in case
* they are not equal.
*/
- for (i = 0; i < nb_qpairs; i++) {
+ for (i = 0; i < nb_qp; i++) {
/*Fill TX info */
- queue_cfg->txq.vsi_id = queue_info->vsi_id;
- queue_cfg->txq.queue_id = i;
+ vc_qpi->txq.vsi_id = vc_vqci->vsi_id;
+ vc_qpi->txq.queue_id = i;
if (i < num_txq) {
- queue_cfg->txq.ring_len = txq[i]->nb_tx_desc;
- queue_cfg->txq.dma_ring_addr =
txq[i]->tx_ring_phys_addr;
+ vc_qpi->txq.ring_len = txq[i]->nb_tx_desc;
+ vc_qpi->txq.dma_ring_addr = txq[i]->tx_ring_phys_addr;
} else {
- queue_cfg->txq.ring_len = 0;
- queue_cfg->txq.dma_ring_addr = 0;
+ vc_qpi->txq.ring_len = 0;
+ vc_qpi->txq.dma_ring_addr = 0;
}
/* Fill RX info */
- queue_cfg->rxq.vsi_id = queue_info->vsi_id;
- queue_cfg->rxq.queue_id = i;
- queue_cfg->rxq.max_pkt_size = vf->max_pkt_len;
+ vc_qpi->rxq.vsi_id = vc_vqci->vsi_id;
+ vc_qpi->rxq.queue_id = i;
+ vc_qpi->rxq.max_pkt_size = vf->max_pkt_len;
if (i < num_rxq) {
mbp_priv = rte_mempool_get_priv(rxq[i]->mp);
- queue_cfg->rxq.databuffer_size =
mbp_priv->mbuf_data_room_size -
- RTE_PKTMBUF_HEADROOM;;
- queue_cfg->rxq.ring_len = rxq[i]->nb_rx_desc;
- queue_cfg->rxq.dma_ring_addr =
rxq[i]->rx_ring_phys_addr;;
+ vc_qpi->rxq.databuffer_size =
+ mbp_priv->mbuf_data_room_size -
+ RTE_PKTMBUF_HEADROOM;
+ vc_qpi->rxq.ring_len = rxq[i]->nb_rx_desc;
+ vc_qpi->rxq.dma_ring_addr = rxq[i]->rx_ring_phys_addr;
} else {
- qu
[dpdk-dev] [PATCH v2 3/5] i40e: support of processing crc stripping config in PF host
To support processing the extra configuration of crc stripping
in DPDK PF host, new 'struct i40e_virtchnl_queue_pair_extra_info'
and a new virtual channel operation of
'I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EX' are added, and also
functions are reworked to support configuring VSI queues with
or without crc stripping configuration.
v2 changes:
* Put processing crc stripping configuration in PF host into a
single patch.
Signed-off-by: Helin Zhang
Reviewed-by: Jingjing Wu
Reviewed-by: Jing Chen
---
lib/librte_pmd_i40e/i40e_pf.c | 38 ++
lib/librte_pmd_i40e/i40e_pf.h | 7 +++
2 files changed, 37 insertions(+), 8 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_pf.c b/lib/librte_pmd_i40e/i40e_pf.c
index 1583021..bc9bfcb 100644
--- a/lib/librte_pmd_i40e/i40e_pf.c
+++ b/lib/librte_pmd_i40e/i40e_pf.c
@@ -327,7 +327,8 @@ send_msg:
static int
i40e_pf_host_hmc_config_rxq(struct i40e_hw *hw,
struct i40e_pf_vf *vf,
- struct i40e_virtchnl_rxq_info *rxq)
+ struct i40e_virtchnl_rxq_info *rxq,
+ struct i40e_virtchnl_queue_pair_extra_info *qpei)
{
int err = I40E_SUCCESS;
struct i40e_hmc_obj_rxq rx_ctx;
@@ -411,13 +412,15 @@ i40e_pf_host_hmc_config_txq(struct i40e_hw *hw,
static int
i40e_pf_host_process_cmd_config_vsi_queues(struct i40e_pf_vf *vf,
uint8_t *msg,
- uint16_t msglen)
+ uint16_t msglen,
+ int opcode)
{
struct i40e_hw *hw = I40E_PF_TO_HW(vf->pf);
struct i40e_vsi *vsi = vf->vsi;
struct i40e_virtchnl_vsi_queue_config_info *vc_vqci =
(struct i40e_virtchnl_vsi_queue_config_info *)msg;
struct i40e_virtchnl_queue_pair_info *vc_qpi;
+ struct i40e_virtchnl_queue_pair_extra_info *vc_qpei = NULL;
int i, ret = I40E_SUCCESS;
if (msg == NULL || msglen <= sizeof(*vc_vqci) ||
@@ -428,6 +431,12 @@ i40e_pf_host_process_cmd_config_vsi_queues(struct
i40e_pf_vf *vf,
}
vc_qpi = vc_vqci->qpair;
+ if (opcode == I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EX)
+ vc_qpei = (struct i40e_virtchnl_queue_pair_extra_info *)
+ (((uint8_t *)vc_qpi) +
+ (sizeof(struct i40e_virtchnl_queue_pair_info) *
+ vc_vqci->num_queue_pairs));
+
for (i = 0; i < vc_vqci->num_queue_pairs; i++) {
if (vc_qpi[i].rxq.queue_id > vsi->nb_qps - 1 ||
vc_qpi[i].txq.queue_id > vsi->nb_qps - 1) {
@@ -435,9 +444,16 @@ i40e_pf_host_process_cmd_config_vsi_queues(struct
i40e_pf_vf *vf,
goto send_msg;
}
- /* Apply VF RX queue setting to HMC */
- if (i40e_pf_host_hmc_config_rxq(hw, vf, &vc_qpi[i].rxq)
- != I40E_SUCCESS) {
+ /*
+* Apply VF RX queue setting to HMC.
+* If the opcode is I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EX,
+* then the extra information of
+* 'struct i40e_virtchnl_queue_pair_extra_info' is needed,
+* otherwise set the last parameter to NULL.
+*/
+ if (i40e_pf_host_hmc_config_rxq(hw, vf, &vc_qpi[i].rxq,
+ (vc_qpei != NULL ? (&vc_qpei[i]) : NULL)) !=
+ I40E_SUCCESS) {
PMD_DRV_LOG(ERR, "Configure RX queue HMC failed");
ret = I40E_ERR_PARAM;
goto send_msg;
@@ -453,8 +469,8 @@ i40e_pf_host_process_cmd_config_vsi_queues(struct
i40e_pf_vf *vf,
}
send_msg:
- i40e_pf_host_send_msg_to_vf(vf, I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES,
- ret, NULL, 0);
+ i40e_pf_host_send_msg_to_vf(vf, opcode, ret, NULL, 0);
+
return ret;
}
@@ -870,7 +886,13 @@ i40e_pf_host_handle_vf_msg(struct rte_eth_dev *dev,
break;
case I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES:
PMD_DRV_LOG(INFO, "OP_CONFIG_VSI_QUEUES received\n");
- i40e_pf_host_process_cmd_config_vsi_queues(vf, msg, msglen);
+ i40e_pf_host_process_cmd_config_vsi_queues(vf, msg,
+ msglen, opcode);
+ break;
+ case I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EX:
+ PMD_DRV_LOG(INFO, "OP_CONFIG_VSI_QUEUES_EX received\n");
+ i40e_pf_host_process_cmd_config_vsi_queues(vf, msg,
+ msglen, opcode);
break;
case I40E_VIRTCHNL_OP_CONFIG_IRQ_MAP:
PMD_DRV_LOG(INFO, "OP_CONFIG_IRQ_MAP received\n");
diff --
[dpdk-dev] [PATCH v2 5/5] i40evf: support of configurable crc stripping in VF
Configurable crc stripping is supported in DPDK PF host,
while not in Linux PF host. Two functions have been
defined to talk with the those PF hosts respectively.
v2 changes:
* Put configuring crc stripping in VF into a single patch.
Signed-off-by: Helin Zhang
Reviewed-by: Jingjing Wu
Reviewed-by: Jing Chen
---
lib/librte_pmd_i40e/i40e_ethdev_vf.c | 133 +++
1 file changed, 102 insertions(+), 31 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c
b/lib/librte_pmd_i40e/i40e_ethdev_vf.c
index 113bff8..af5a0f3 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev_vf.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev_vf.c
@@ -523,8 +523,9 @@ i40evf_config_vlan_pvid(struct rte_eth_dev *dev,
return err;
}
+/* It configures VSI queues without extra configuration */
static int
-i40evf_configure_queues(struct rte_eth_dev *dev)
+i40evf_configure_vsi_queues(struct rte_eth_dev *dev)
{
struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
struct i40e_rx_queue **rxq =
@@ -533,13 +534,13 @@ i40evf_configure_queues(struct rte_eth_dev *dev)
(struct i40e_tx_queue **)dev->data->tx_queues;
struct i40e_virtchnl_vsi_queue_config_info *vc_vqci;
struct i40e_virtchnl_queue_pair_info *vc_qpi;
- int size, i, nb_qp, ret, num_rxq, num_txq;
struct vf_cmd_info args;
- struct rte_pktmbuf_pool_private *mbp_priv;
+ int size, i, nb_qp, ret;
nb_qp = vf->num_queue_pairs;
- size = sizeof(*vc_vqci) + sizeof(*vc_qpi) * nb_qp;
- vc_vqci = rte_zmalloc("vc_vqci", size, 0);
+ size = sizeof(struct i40e_virtchnl_vsi_queue_config_info) +
+ sizeof(struct i40e_virtchnl_queue_pair_info) * nb_qp;
+ vc_vqci = rte_zmalloc("queue_info", size, 0);
if (!vc_vqci) {
PMD_DRV_LOG(ERR, "Failed to allocate memory for VF "
"configuring queues\n");
@@ -547,62 +548,132 @@ i40evf_configure_queues(struct rte_eth_dev *dev)
}
vc_vqci->vsi_id = vf->vsi_res->vsi_id;
vc_vqci->num_queue_pairs = nb_qp;
- vc_qpi = vc_vqci->qpair;
- num_rxq = dev->data->nb_rx_queues;
- num_txq = dev->data->nb_tx_queues;
- /*
-* PF host driver required to configure queues in pairs, which means
-* rxq_num should equals to txq_num. The actual usage won't always
-* work that way. The solution is fills 0 with HW ring option in case
-* they are not equal.
-*/
- for (i = 0; i < nb_qp; i++) {
- /*Fill TX info */
+ for (i = 0, vc_qpi = vc_vqci->qpair; i < nb_qp; i++, vc_qpi++) {
vc_qpi->txq.vsi_id = vc_vqci->vsi_id;
vc_qpi->txq.queue_id = i;
- if (i < num_txq) {
+ if (i < dev->data->nb_tx_queues) {
vc_qpi->txq.ring_len = txq[i]->nb_tx_desc;
vc_qpi->txq.dma_ring_addr = txq[i]->tx_ring_phys_addr;
- } else {
- vc_qpi->txq.ring_len = 0;
- vc_qpi->txq.dma_ring_addr = 0;
}
- /* Fill RX info */
vc_qpi->rxq.vsi_id = vc_vqci->vsi_id;
vc_qpi->rxq.queue_id = i;
vc_qpi->rxq.max_pkt_size = vf->max_pkt_len;
- if (i < num_rxq) {
+ if (i < dev->data->nb_rx_queues) {
+ struct rte_pktmbuf_pool_private *mbp_priv;
+
+ vc_qpi->rxq.ring_len = rxq[i]->nb_rx_desc;
+ vc_qpi->rxq.dma_ring_addr = rxq[i]->rx_ring_phys_addr;
mbp_priv = rte_mempool_get_priv(rxq[i]->mp);
vc_qpi->rxq.databuffer_size =
mbp_priv->mbuf_data_room_size -
RTE_PKTMBUF_HEADROOM;
+ }
+ }
+ memset(&args, 0, sizeof(args));
+ args.ops = I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES;
+ args.in_args = (uint8_t *)vc_vqci;
+ args.in_args_size = size;
+ args.out_buffer = cmd_result_buffer;
+ args.out_size = I40E_AQ_BUF_SZ;
+ ret = i40evf_execute_vf_cmd(dev, &args);
+ if (ret)
+ PMD_DRV_LOG(ERR, "Failed to execute command of "
+ "I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES\n");
+ rte_free(vc_vqci);
+
+ return ret;
+}
+
+/* It configures VSI queues with extra configuration of crc stripping */
+static int
+i40evf_configure_vsi_queues_ex(struct rte_eth_dev *dev)
+{
+ struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+ struct i40e_rx_queue **rxq =
+ (struct i40e_rx_queue **)dev->data->rx_queues;
+ struct i40e_tx_queue **txq =
+ (struct i40e_tx_queue **)dev->data->tx_queues;
+ struct i40e_virtchnl_vsi_queue_config_info *vc_vqci;
+ struct i40e_virtchnl_queue_pair_info *vc_qpi;
+ struct i40e_virtch
[dpdk-dev] [PATCH v2 1/5] config: remove useless i40e items in config files
Remove 'CONFIG_RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC' from config files of 'common_bsdapp' and 'common_linuxapp', as nowhere uses it. Signed-off-by: Helin Zhang Reviewed-by: Jingjing Wu Reviewed-by: Jing Chen --- config/common_bsdapp | 1 - config/common_linuxapp | 1 - 2 files changed, 2 deletions(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index bf6d8a0..c62388a 100644 --- a/config/common_bsdapp +++ b/config/common_bsdapp @@ -180,7 +180,6 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_RX=n CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n -CONFIG_RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC=y CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=n CONFIG_RTE_LIBRTE_I40E_ALLOW_UNSUPPORTED_SFP=y CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n diff --git a/config/common_linuxapp b/config/common_linuxapp index 9047975..c680a63 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -203,7 +203,6 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_RX=n CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n -CONFIG_RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC=n CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y CONFIG_RTE_LIBRTE_I40E_ALLOW_UNSUPPORTED_SFP=n CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n -- 1.8.1.4
[dpdk-dev] [PATCH v2 4/5] i40e: set crc stripping in rx queue configuration
It enables/disables the crc stripping in the rx queue contexts, according to the extra configuration carried from VF. v2 changes: * Put setting the crc stripping into a single patch. Signed-off-by: Helin Zhang Reviewed-by: Jingjing Wu Reviewed-by: Jing Chen --- lib/librte_pmd_i40e/i40e_pf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_i40e/i40e_pf.c b/lib/librte_pmd_i40e/i40e_pf.c index bc9bfcb..2910fd5 100644 --- a/lib/librte_pmd_i40e/i40e_pf.c +++ b/lib/librte_pmd_i40e/i40e_pf.c @@ -357,7 +357,10 @@ i40e_pf_host_hmc_config_rxq(struct i40e_hw *hw, rx_ctx.tphdata_ena = 1; rx_ctx.tphhead_ena = 1; rx_ctx.lrxqthresh = 2; - rx_ctx.crcstrip = 1; + if (qpei) /* For DPDK PF host */ + rx_ctx.crcstrip = qpei->crcstrip ? 1 : 0; + else /* For Linux PF host */ + rx_ctx.crcstrip = 1; rx_ctx.l2tsel = 1; rx_ctx.prefena = 1; -- 1.8.1.4
