[dpdk-dev] zerocopy between userspace vhost virqueue and vmdq eth nic queu

[dpdk]

[dpdk-dev] free memory pool

[Hamid Ramazani]

Hi,

Is there any other way than freeing memory pool?
I see rte_pktmbuf_free function call in almost all examples.
can we have a ring-like memory pool without need to free it?

Thanks in advance for your consideration.

[dpdk-dev] Pcap question

[Meir Tseitlin]

Hi guys,

I am experiencing problem with compiling libpcap extension with all recent
versions:

Versions after 1.5.2r2 (1.5.2r2 up to 1.6.0r1) I get the following error
compilation error:
--

== Build lib/librte_pmd_pcap
  CC rte_eth_pcap.o
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c: In
function 'rte_pmd_init_internals':
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c:559:30:
error: dereferencing pointer to incomplete type
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c:560:15:
error: dereferencing pointer to incomplete type
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c:561:18:
error: dereferencing pointer to incomplete type
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c:603:47:
error: dereferencing pointer to incomplete type
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c: In
function 'rte_pmd_pcap_init':
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c:732:73:
error: 'dict' undeclared (first use in this function)
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c:732:73:
note: each undeclared identifier is reported only once for each function it
appears in
/home/ubuntu/libs/dpdk-1.5.2r2/lib/librte_pmd_pcap/rte_eth_pcap.c:778:1:
error: control reaches end of non-void function [-Werror=return-type]


Versions 1.5.1r1 - 1.5.2r1 I get the following error:
--

  LD testpmd
/usr/bin/ld: unrecognized option '-Wl'
/usr/bin/ld: use the --help option for usage information
collect2: error: ld returned 1 exit status
make[3]: *** [testpmd] Error 1
make[2]: *** [test-pmd] Error 2


My environment:
---
I am running Ubuntu 12.04 64 bit:
I tried GCC 4.6 and 4.7.3
I tried binutils (ld) 2.22 and 2.24
I tried libpcap 1.4.0 and 1.5.3

With libpcap 0.8 (12.04 original repository) version prior 1.5.2r2 does
compile successfully, but as mentioned in documentation it does not support
packet sending

Without libpcap enabled everything compiles fine


Help will be highly appreciated!
Meir Tseitlin


-- 
Kind regards,
*Meir Tseitlin*
Software architect*Mobile:* +972.54.7647417
*Fax:* +972.72.2812365
*Email:* meir.tech at gmail.com
 *http://il.linkedin.com/in/meirts *
*Independent consultant*

See who we know in
commonWant
a signature like
this?

[dpdk-dev] Pcap question

[Olivier MATZ]

Hi Meir,

On 03/02/2014 08:13 PM, Meir Tseitlin wrote:
> I am experiencing problem with compiling libpcap extension with all recent
> versions

Indeed, I can reproduce the compilation error on current dev version.
The cause seems to be a conflict between the patches I submitted
(rte_kvargs) and the one from Mats Liljegren which was commited the
day before:

http://dpdk.org/browse/dpdk/commit/?h=1.5.2&id=4c745617a18fc37bd2a08aad512846a416665ae3

I will submit a fix.

Olivier

[dpdk-dev] [PATCH] pcap: fix compilation error introduced by kvargs

[Olivier Matz]

Due to a merge conflict between commits 4c745617a1 and 9d5752d80,
rte_eth_pcap.c was not compiling with the following error:

rte_eth_pcap.c: In function 'rte_pmd_init_internals':
rte_eth_pcap.c:559:30: error: dereferencing pointer to incomplete type
rte_eth_pcap.c:560:15: error: dereferencing pointer to incomplete type
rte_eth_pcap.c:561:18: error: dereferencing pointer to incomplete type
rte_eth_pcap.c:603:47: error: dereferencing pointer to incomplete type
rte_eth_pcap.c: In function 'rte_pmd_pcap_init':
rte_eth_pcap.c:732:73: error: 'dict' undeclared (first use in this
  function)
rte_eth_pcap.c:732:73: note: each undeclared identifier is reported
  only once for each function it appears in

This commit replaces "struct args_dict" by "struct rte_kvargs" to fix
the compilation issue.

By the way, it also removes the declaration of these functions from
the header file as no other file in DPDK references one of them. It
avoids to include  in rte_eth_pcap.h.

Pointed-out-by: Meir Tseitlin 
Signed-off-by: Olivier Matz 
---
 lib/librte_pmd_pcap/rte_eth_pcap.c | 27 ++-
 lib/librte_pmd_pcap/rte_eth_pcap.h | 17 -
 2 files changed, 14 insertions(+), 30 deletions(-)

diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c 
b/lib/librte_pmd_pcap/rte_eth_pcap.c
index 03e6e6c..fbafd19 100644
--- a/lib/librte_pmd_pcap/rte_eth_pcap.c
+++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
@@ -549,15 +549,15 @@ rte_pmd_init_internals(const unsigned nb_rx_queues,
const unsigned numa_node,
struct pmd_internals **internals,
struct rte_eth_dev **eth_dev,
-   struct args_dict *dict)
+   struct rte_kvargs *kvlist)
 {
struct rte_eth_dev_data *data = NULL;
struct rte_pci_device *pci_dev = NULL;
unsigned k_idx;
-   struct key_value *pair = NULL;
+   struct rte_kvargs_pair *pair = NULL;

-   for (k_idx = 0; k_idx < dict->index; k_idx++) {
-   pair = &dict->pairs[k_idx];
+   for (k_idx = 0; k_idx < kvlist->count; k_idx++) {
+   pair = &kvlist->pairs[k_idx];
if (strstr(pair->key, ETH_PCAP_IFACE_ARG) != NULL)
break;
}
@@ -626,13 +626,13 @@ rte_pmd_init_internals(const unsigned nb_rx_queues,
return -1;
 }

-int
+static int
 rte_eth_from_pcaps_n_dumpers(pcap_t * const rx_queues[],
const unsigned nb_rx_queues,
pcap_dumper_t * const tx_queues[],
const unsigned nb_tx_queues,
const unsigned numa_node,
-   struct args_dict *dict)
+   struct rte_kvargs *kvlist)
 {
struct pmd_internals *internals = NULL;
struct rte_eth_dev *eth_dev = NULL;
@@ -645,7 +645,7 @@ rte_eth_from_pcaps_n_dumpers(pcap_t * const rx_queues[],
return -1;

if (rte_pmd_init_internals(nb_rx_queues, nb_tx_queues, numa_node,
-   &internals, ð_dev, dict) < 0)
+   &internals, ð_dev, kvlist) < 0)
return -1;

for (i = 0; i < nb_rx_queues; i++) {
@@ -661,13 +661,13 @@ rte_eth_from_pcaps_n_dumpers(pcap_t * const rx_queues[],
return 0;
 }

-int
+static int
 rte_eth_from_pcaps(pcap_t * const rx_queues[],
const unsigned nb_rx_queues,
pcap_t * const tx_queues[],
const unsigned nb_tx_queues,
const unsigned numa_node,
-   struct args_dict *dict)
+   struct rte_kvargs *kvlist)
 {
struct pmd_internals *internals = NULL;
struct rte_eth_dev *eth_dev = NULL;
@@ -680,7 +680,7 @@ rte_eth_from_pcaps(pcap_t * const rx_queues[],
return -1;

if (rte_pmd_init_internals(nb_rx_queues, nb_tx_queues, numa_node,
-   &internals, ð_dev, dict) < 0)
+   &internals, ð_dev, kvlist) < 0)
return -1;

for (i = 0; i < nb_rx_queues; i++) {
@@ -729,7 +729,8 @@ rte_pmd_pcap_init(const char *name, const char *params)
if (ret < 0)
return -1;

-   return rte_eth_from_pcaps(pcaps.pcaps, 1, pcaps.pcaps, 1, 
numa_node, &dict);
+   return rte_eth_from_pcaps(pcaps.pcaps, 1, pcaps.pcaps, 1,
+   numa_node, kvlist);
}

/*
@@ -770,10 +771,10 @@ rte_pmd_pcap_init(const char *name, const char *params)

if (using_dumpers)
return rte_eth_from_pcaps_n_dumpers(pcaps.pcaps, 
pcaps.num_of_rx,
-   dumpers.dumpers, dumpers.num_of_tx, numa_node, 
&dict);
+   dumpers.dumpers, dumpers.num_of_tx, numa_node, 
kvlist);

return rte_eth_from_pcaps(pcaps.pcaps, pcaps.num_of_rx, dumpers.pcaps,
-   dumpers.num_of_tx, numa_node, &dict);
+   dumpers.num_of_tx, numa_node, kvlist);

 }

diff --git a/lib/librte_pmd_pcap/rte_eth_pca