[dpdk-dev] multiple VLAN IDs for SR-IOV ports

[Patel, Rashmin N]

I haven't checked it with ip tool. But I just verified from the Niantic specs, 
and I see PFVLVF[64] and PFVLVFB[128] - 32 bit register arrays to configure 
VLAN-Pool/VF mapping.
PFVLVF[i] holds a vlan_id need to be mapped
PFVLVFB[2i] and PFVLVFB[2i+1] holds bitmap for max possible pools (64 bits) to 
map any of those pools to the PFVLVF[i].vlan_id

So technically you should be able to map it, the only thing I'm not sure if 
it's supported with ip tool or not.
If you quickly want to check it out, you can just write those registers through 
PCI bar.

Thanks,
Rashmin

-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of James Yu
Sent: Sunday, February 02, 2014 11:53 PM
To: Jose Gavine Cueto
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] multiple VLAN IDs for SR-IOV ports

Patel,

I can use the following command to add one VLAN with VID of 3 to VF 0 of
eth6

ip link set eth6 vf 0 vlan 3

Could you show me an example of adding 2 VLAN IDs such as VID of 3 and 13 to 
the same VF 0 ? I want VF 0 to pass traffic from VLAN 3 and 13. How do I do 
that ?
>From the man page of ip, I do not see it describes about adding more than one 
>VLAN IDs to the same VF port.
Can I use this ?
ip link set eth6 vf0 vlan 3,13


Thanks

James


On Sat, Feb 1, 2014 at 9:13 AM, Jose Gavine Cueto wrote:

> hi,
>
>
> On Thu, Jan 30, 2014 at 2:45 PM, James Yu  wrote:
>
>> Any one know what commands to use on the KVM host to add multiple 
>> VLAN IDs to a SR-IOV port ?
>>
>> I could only add one VLAN ID using
>>
>> ip link set ethN vf NUM vlan VLANID
>>
>
> What do you mean by "multiple VLAN IDs" ?  ethN and vf NUM here let's 
> you add more than one vlan id.
>
>
>>
>> Also do I have to call any routine on the DPDK side to add those VIDs ?
>>
>> James
>>
>
>
>
> --
> To stop learning is like to stop loving.
>

[dpdk-dev] couple of minor compilation errors in DPDK 1.6 (/lib/librte_eal/linuxapp/eal/eal_ivshmem.c)

[Jyotiswarup Raiturkar]

Hi

I downloaded DPDK 1.6 from the Intel website and ran into couple of
compilation errors with /lib/librte_eal/linuxapp/eal/eal_ivshmem.c. The
following changes seem to fix it.  Have other people seen these?

Thanks
Jyoti


@@ -472,7 +472,7 @@
  rte_snprintf(path, sizeof(path), IVSHMEM_CONFIG_PATH,
  internal_config.hugefile_prefix);

- fd = open(path, O_CREAT | O_RDWR);
+ fd = open(path, O_CREAT | O_RDWR, S_IRWXU | S_IRWXG | S_IRWXO );

  if (fd < 0) {
  RTE_LOG(ERR, EAL, "Could not open %s: %s\n", path, strerror(errno));
@@ -486,7 +486,8 @@
  return -1;
  }

- ftruncate(fd, sizeof(struct ivshmem_shared_config));
+ if (ftruncate(fd, sizeof(struct ivshmem_shared_config))) {
+close(fd); return -1;
+  }

  ivshmem_config = mmap(NULL, sizeof(struct ivshmem_shared_config),
  PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);

[dpdk-dev] How to debug packet sends to virtual functions

[Mats Liljegren]

This is my fourth mail in my desperate attempt to get DPDK running in
KVM and no comments so far, not even any "it works for me". Am I the
only one crazy enough to believe that this can be done?

Anyway, out of desperation I tried to get it running without having
ixgbe or ixgbevf kernel modules loaded in host nor guest. I followed
the instructions in the Programmer's Guide, chapter "Setting Up a KVM
Virtual Machine Monitor", using the PMD version of the instructions.

I get as far as being able to see my four virtual functions in the
guest using "lspci". But starting the DPDK application gives me the
following error:

PMD:The MAC address is not valid.
The most likely cause of this error is that the VM host
has not assigned a valid MAC address to this VF device.
Please consult the DPDK Release Notes (FAQ section) for
a possible solution to this problem.

This may be true, but without any kernel modules loaded, how am I
supposed to change any MAC addresses? Can this be done from within
DPDK?

As a side-note, I did try to load ixgbevf in the guest, but it
produced no interfaces. There was no error messages in the syslog
though.

Is it possible to get X540 working in a guest or should I switch hardware?

Since the instructions assumes I know the command line to KVM to start
my guest (which I do not), I cannot followed them precisely. I use
virsh and XML file, and maybe I've misunderstood how to translate the
pci-assign parameter to XML code. I currently use a  entry,
but I've also tried . Neither has been
working for me so far, though the  version got me as far as
being able to receive packets at least, but not transmitting.

Regards
Mats


On Mon, Feb 3, 2014 at 12:13 PM, Mats Liljegren
 wrote:
> Never mind, I was hit by the infamous MAC spoofing... I got it working
> on both the host and the guest using ixgbevf driver, so apparently the
> cables are correctly attached.
>
> Using DPDK is still no-go. It can receive packets, but when sending
> the packets the function returns success, but the driver reports
> nothing (i.e. no errors, no sent packets, no nothing, except for
> received packets of course).
>
> What could cause this behavior?
>
> Regards
> Mats
>
> On Fri, Jan 31, 2014 at 7:30 PM, Mats Liljegren
>  wrote:
>> I have a follow-up on this:
>>
>> ixgbe version 3.13.10-k
>> ixgbevf version 2.7.12-k
>>
>> (These are what was provided by Ubuntu 13.10)
>>
>> I tried the following sequence on the host, before starting the guest:
>> 1) sudo rmmod ixgbe
>> 2) sudo modprobe ixgbe max_vfs=2
>> 3) sudo ifconfig em1 up  # This is the physical function
>> 4) sudo ifconfig em1_0 192.168.2.2  # This is the virtual function
>> 5) ping 192.168.2.1
>>
>> I can see that the ping request reaches its target, and a reply is
>> sent back. But this reply is not received by the ping shell command.
>>
>> Why?
>>
>> Regards,
>> Mats
>>
>> On Wed, Jan 29, 2014 at 6:56 PM, Mats Liljegren
>>  wrote:
>>> I'm trying to get a modified version of the l2fwd example running, and
>>> have problems with packets being silently thrown away. I can receive
>>> packets, and my printf's indicates that the packets are being sent to
>>> the correct port, using correct MAC address as source address. And
>>> still, the packets are lost.
>>>
>>> Since the port is a virtual function, it seems like I cannot use
>>> tcpdump on it to see the network traffic. There is nothing coming out
>>> of the cable (activity light not flashing, the receiving end running
>>> tcpdump does not see any traffic).
>>>
>>> I'm using two X540 with two virtual functions each. The application
>>> runs in a KVM/Qemu environmen.
>>>
>>> Any suggestions how to debug this?
>>>
>>> Regards,
>>> Mats

[dpdk-dev] How to debug packet sends to virtual functions

[jigsaw]

Hi Mats,

I've tried vf with 82599EB and it works fine. As long as the VF is
visible in guest, DPDK's VF driver should work just as ixgbevf, which
shares more or less the same code.

I don't understand why you would expect DPDK at guest to work as VF,
while the host has no ixgbe loaded.
To make further debug I'd suggest compile ixgbe driver with your own
syslogs. At least you will be able to see the signalling between vf
and ixgbe drivers.

-Qinglai


On Tue, Feb 4, 2014 at 12:08 PM, Mats Liljegren
 wrote:
> This is my fourth mail in my desperate attempt to get DPDK running in
> KVM and no comments so far, not even any "it works for me". Am I the
> only one crazy enough to believe that this can be done?
>
> Anyway, out of desperation I tried to get it running without having
> ixgbe or ixgbevf kernel modules loaded in host nor guest. I followed
> the instructions in the Programmer's Guide, chapter "Setting Up a KVM
> Virtual Machine Monitor", using the PMD version of the instructions.
>
> I get as far as being able to see my four virtual functions in the
> guest using "lspci". But starting the DPDK application gives me the
> following error:
>
> PMD:The MAC address is not valid.
> The most likely cause of this error is that the VM host
> has not assigned a valid MAC address to this VF device.
> Please consult the DPDK Release Notes (FAQ section) for
> a possible solution to this problem.
>
> This may be true, but without any kernel modules loaded, how am I
> supposed to change any MAC addresses? Can this be done from within
> DPDK?
>
> As a side-note, I did try to load ixgbevf in the guest, but it
> produced no interfaces. There was no error messages in the syslog
> though.
>
> Is it possible to get X540 working in a guest or should I switch hardware?
>
> Since the instructions assumes I know the command line to KVM to start
> my guest (which I do not), I cannot followed them precisely. I use
> virsh and XML file, and maybe I've misunderstood how to translate the
> pci-assign parameter to XML code. I currently use a  entry,
> but I've also tried . Neither has been
> working for me so far, though the  version got me as far as
> being able to receive packets at least, but not transmitting.
>
> Regards
> Mats
>
>
> On Mon, Feb 3, 2014 at 12:13 PM, Mats Liljegren
>  wrote:
>> Never mind, I was hit by the infamous MAC spoofing... I got it working
>> on both the host and the guest using ixgbevf driver, so apparently the
>> cables are correctly attached.
>>
>> Using DPDK is still no-go. It can receive packets, but when sending
>> the packets the function returns success, but the driver reports
>> nothing (i.e. no errors, no sent packets, no nothing, except for
>> received packets of course).
>>
>> What could cause this behavior?
>>
>> Regards
>> Mats
>>
>> On Fri, Jan 31, 2014 at 7:30 PM, Mats Liljegren
>>  wrote:
>>> I have a follow-up on this:
>>>
>>> ixgbe version 3.13.10-k
>>> ixgbevf version 2.7.12-k
>>>
>>> (These are what was provided by Ubuntu 13.10)
>>>
>>> I tried the following sequence on the host, before starting the guest:
>>> 1) sudo rmmod ixgbe
>>> 2) sudo modprobe ixgbe max_vfs=2
>>> 3) sudo ifconfig em1 up  # This is the physical function
>>> 4) sudo ifconfig em1_0 192.168.2.2  # This is the virtual function
>>> 5) ping 192.168.2.1
>>>
>>> I can see that the ping request reaches its target, and a reply is
>>> sent back. But this reply is not received by the ping shell command.
>>>
>>> Why?
>>>
>>> Regards,
>>> Mats
>>>
>>> On Wed, Jan 29, 2014 at 6:56 PM, Mats Liljegren
>>>  wrote:
 I'm trying to get a modified version of the l2fwd example running, and
 have problems with packets being silently thrown away. I can receive
 packets, and my printf's indicates that the packets are being sent to
 the correct port, using correct MAC address as source address. And
 still, the packets are lost.

 Since the port is a virtual function, it seems like I cannot use
 tcpdump on it to see the network traffic. There is nothing coming out
 of the cable (activity light not flashing, the receiving end running
 tcpdump does not see any traffic).

 I'm using two X540 with two virtual functions each. The application
 runs in a KVM/Qemu environmen.

 Any suggestions how to debug this?

 Regards,
 Mats

[dpdk-dev] How to debug packet sends to virtual functions

[Mats Liljegren]

Hi Qinglai,

Thanks for the response!

My previous attempt was with ixgbe loaded in the host. I also needed
to load ixgbevf, but this seems to be because of a short-coming in
libvirt. Maybe loading ixgbevf and then unbind it when running the
guest is what causes my problems. I could receive packets with this
setup, but not transmit. I used extra debug to syslog, and it showed
that packets was placed in the transmit queue, but these packets was
never sent.

I'll see if I can get this working without loading ixgbevf in the host.

What instructions did you follow to get this working? Did you do any
deviation from the instructions?

Regards
Mats

On Tue, Feb 4, 2014 at 11:26 AM, jigsaw  wrote:
> Hi Mats,
>
> I've tried vf with 82599EB and it works fine. As long as the VF is
> visible in guest, DPDK's VF driver should work just as ixgbevf, which
> shares more or less the same code.
>
> I don't understand why you would expect DPDK at guest to work as VF,
> while the host has no ixgbe loaded.
> To make further debug I'd suggest compile ixgbe driver with your own
> syslogs. At least you will be able to see the signalling between vf
> and ixgbe drivers.
>
> -Qinglai
>
>
> On Tue, Feb 4, 2014 at 12:08 PM, Mats Liljegren
>  wrote:
>> This is my fourth mail in my desperate attempt to get DPDK running in
>> KVM and no comments so far, not even any "it works for me". Am I the
>> only one crazy enough to believe that this can be done?
>>
>> Anyway, out of desperation I tried to get it running without having
>> ixgbe or ixgbevf kernel modules loaded in host nor guest. I followed
>> the instructions in the Programmer's Guide, chapter "Setting Up a KVM
>> Virtual Machine Monitor", using the PMD version of the instructions.
>>
>> I get as far as being able to see my four virtual functions in the
>> guest using "lspci". But starting the DPDK application gives me the
>> following error:
>>
>> PMD:The MAC address is not valid.
>> The most likely cause of this error is that the VM host
>> has not assigned a valid MAC address to this VF device.
>> Please consult the DPDK Release Notes (FAQ section) for
>> a possible solution to this problem.
>>
>> This may be true, but without any kernel modules loaded, how am I
>> supposed to change any MAC addresses? Can this be done from within
>> DPDK?
>>
>> As a side-note, I did try to load ixgbevf in the guest, but it
>> produced no interfaces. There was no error messages in the syslog
>> though.
>>
>> Is it possible to get X540 working in a guest or should I switch hardware?
>>
>> Since the instructions assumes I know the command line to KVM to start
>> my guest (which I do not), I cannot followed them precisely. I use
>> virsh and XML file, and maybe I've misunderstood how to translate the
>> pci-assign parameter to XML code. I currently use a  entry,
>> but I've also tried . Neither has been
>> working for me so far, though the  version got me as far as
>> being able to receive packets at least, but not transmitting.
>>
>> Regards
>> Mats
>>
>>
>> On Mon, Feb 3, 2014 at 12:13 PM, Mats Liljegren
>>  wrote:
>>> Never mind, I was hit by the infamous MAC spoofing... I got it working
>>> on both the host and the guest using ixgbevf driver, so apparently the
>>> cables are correctly attached.
>>>
>>> Using DPDK is still no-go. It can receive packets, but when sending
>>> the packets the function returns success, but the driver reports
>>> nothing (i.e. no errors, no sent packets, no nothing, except for
>>> received packets of course).
>>>
>>> What could cause this behavior?
>>>
>>> Regards
>>> Mats
>>>
>>> On Fri, Jan 31, 2014 at 7:30 PM, Mats Liljegren
>>>  wrote:
 I have a follow-up on this:

 ixgbe version 3.13.10-k
 ixgbevf version 2.7.12-k

 (These are what was provided by Ubuntu 13.10)

 I tried the following sequence on the host, before starting the guest:
 1) sudo rmmod ixgbe
 2) sudo modprobe ixgbe max_vfs=2
 3) sudo ifconfig em1 up  # This is the physical function
 4) sudo ifconfig em1_0 192.168.2.2  # This is the virtual function
 5) ping 192.168.2.1

 I can see that the ping request reaches its target, and a reply is
 sent back. But this reply is not received by the ping shell command.

 Why?

 Regards,
 Mats

 On Wed, Jan 29, 2014 at 6:56 PM, Mats Liljegren
  wrote:
> I'm trying to get a modified version of the l2fwd example running, and
> have problems with packets being silently thrown away. I can receive
> packets, and my printf's indicates that the packets are being sent to
> the correct port, using correct MAC address as source address. And
> still, the packets are lost.
>
> Since the port is a virtual function, it seems like I cannot use
> tcpdump on it to see the network traffic. There is nothing coming out
> of the cable (activity light not flashing, the receiving end running
> tcpdump does not see any t

[dpdk-dev] How to debug packet sends to virtual functions

[jigsaw]

Hi Mats,

I didn't have any deviation. What I did is just loading ixgbe (with
extra params for vf, as you mentioned in your first email),
and DPDK is up and running in guest. Of course I also followed section
8.10 of the DPDK release notes.

I can switch between DPDK and ixgebvf in guest at runtime and
everything works fine.

Sorry I can't help to debug coz I have only 82599EB at hand.

-Qinglai

On Tue, Feb 4, 2014 at 12:45 PM, Mats Liljegren
 wrote:
> Hi Qinglai,
>
> Thanks for the response!
>
> My previous attempt was with ixgbe loaded in the host. I also needed
> to load ixgbevf, but this seems to be because of a short-coming in
> libvirt. Maybe loading ixgbevf and then unbind it when running the
> guest is what causes my problems. I could receive packets with this
> setup, but not transmit. I used extra debug to syslog, and it showed
> that packets was placed in the transmit queue, but these packets was
> never sent.
>
> I'll see if I can get this working without loading ixgbevf in the host.
>
> What instructions did you follow to get this working? Did you do any
> deviation from the instructions?
>
> Regards
> Mats
>
> On Tue, Feb 4, 2014 at 11:26 AM, jigsaw  wrote:
>> Hi Mats,
>>
>> I've tried vf with 82599EB and it works fine. As long as the VF is
>> visible in guest, DPDK's VF driver should work just as ixgbevf, which
>> shares more or less the same code.
>>
>> I don't understand why you would expect DPDK at guest to work as VF,
>> while the host has no ixgbe loaded.
>> To make further debug I'd suggest compile ixgbe driver with your own
>> syslogs. At least you will be able to see the signalling between vf
>> and ixgbe drivers.
>>
>> -Qinglai
>>
>>
>> On Tue, Feb 4, 2014 at 12:08 PM, Mats Liljegren
>>  wrote:
>>> This is my fourth mail in my desperate attempt to get DPDK running in
>>> KVM and no comments so far, not even any "it works for me". Am I the
>>> only one crazy enough to believe that this can be done?
>>>
>>> Anyway, out of desperation I tried to get it running without having
>>> ixgbe or ixgbevf kernel modules loaded in host nor guest. I followed
>>> the instructions in the Programmer's Guide, chapter "Setting Up a KVM
>>> Virtual Machine Monitor", using the PMD version of the instructions.
>>>
>>> I get as far as being able to see my four virtual functions in the
>>> guest using "lspci". But starting the DPDK application gives me the
>>> following error:
>>>
>>> PMD:The MAC address is not valid.
>>> The most likely cause of this error is that the VM host
>>> has not assigned a valid MAC address to this VF device.
>>> Please consult the DPDK Release Notes (FAQ section) for
>>> a possible solution to this problem.
>>>
>>> This may be true, but without any kernel modules loaded, how am I
>>> supposed to change any MAC addresses? Can this be done from within
>>> DPDK?
>>>
>>> As a side-note, I did try to load ixgbevf in the guest, but it
>>> produced no interfaces. There was no error messages in the syslog
>>> though.
>>>
>>> Is it possible to get X540 working in a guest or should I switch hardware?
>>>
>>> Since the instructions assumes I know the command line to KVM to start
>>> my guest (which I do not), I cannot followed them precisely. I use
>>> virsh and XML file, and maybe I've misunderstood how to translate the
>>> pci-assign parameter to XML code. I currently use a  entry,
>>> but I've also tried . Neither has been
>>> working for me so far, though the  version got me as far as
>>> being able to receive packets at least, but not transmitting.
>>>
>>> Regards
>>> Mats
>>>
>>>
>>> On Mon, Feb 3, 2014 at 12:13 PM, Mats Liljegren
>>>  wrote:
 Never mind, I was hit by the infamous MAC spoofing... I got it working
 on both the host and the guest using ixgbevf driver, so apparently the
 cables are correctly attached.

 Using DPDK is still no-go. It can receive packets, but when sending
 the packets the function returns success, but the driver reports
 nothing (i.e. no errors, no sent packets, no nothing, except for
 received packets of course).

 What could cause this behavior?

 Regards
 Mats

 On Fri, Jan 31, 2014 at 7:30 PM, Mats Liljegren
  wrote:
> I have a follow-up on this:
>
> ixgbe version 3.13.10-k
> ixgbevf version 2.7.12-k
>
> (These are what was provided by Ubuntu 13.10)
>
> I tried the following sequence on the host, before starting the guest:
> 1) sudo rmmod ixgbe
> 2) sudo modprobe ixgbe max_vfs=2
> 3) sudo ifconfig em1 up  # This is the physical function
> 4) sudo ifconfig em1_0 192.168.2.2  # This is the virtual function
> 5) ping 192.168.2.1
>
> I can see that the ping request reaches its target, and a reply is
> sent back. But this reply is not received by the ping shell command.
>
> Why?
>
> Regards,
> Mats
>
> On Wed, Jan 29, 2014 at 6:56 PM, Mats Liljegren
>  wrote:

[dpdk-dev] How to debug packet sends to virtual functions

[Burakov, Anatoly]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mats Liljegren
> Sent: Tuesday, February 04, 2014 10:45 AM
> To: jigsaw
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] How to debug packet sends to virtual functions
> 
> Hi Qinglai,
> 
> Thanks for the response!
> 
> My previous attempt was with ixgbe loaded in the host. I also needed to load
> ixgbevf, but this seems to be because of a short-coming in libvirt. Maybe
> loading ixgbevf and then unbind it when running the guest is what causes my
> problems. I could receive packets with this setup, but not transmit. I used
> extra debug to syslog, and it showed that packets was placed in the transmit
> queue, but these packets was never sent.
> 
> I'll see if I can get this working without loading ixgbevf in the host.
> 
> What instructions did you follow to get this working? Did you do any
> deviation from the instructions?
> 
> Regards
> Mats
> 
> On Tue, Feb 4, 2014 at 11:26 AM, jigsaw  wrote:
> > Hi Mats,
> >
> > I've tried vf with 82599EB and it works fine. As long as the VF is
> > visible in guest, DPDK's VF driver should work just as ixgbevf, which
> > shares more or less the same code.
> >
> > I don't understand why you would expect DPDK at guest to work as VF,
> > while the host has no ixgbe loaded.
> > To make further debug I'd suggest compile ixgbe driver with your own
> > syslogs. At least you will be able to see the signalling between vf
> > and ixgbe drivers.
> >
> > -Qinglai
> >
> >
> > On Tue, Feb 4, 2014 at 12:08 PM, Mats Liljegren
> >  wrote:
> >> This is my fourth mail in my desperate attempt to get DPDK running in
> >> KVM and no comments so far, not even any "it works for me". Am I the
> >> only one crazy enough to believe that this can be done?
> >>
> >> Anyway, out of desperation I tried to get it running without having
> >> ixgbe or ixgbevf kernel modules loaded in host nor guest. I followed
> >> the instructions in the Programmer's Guide, chapter "Setting Up a KVM
> >> Virtual Machine Monitor", using the PMD version of the instructions.
> >>
> >> I get as far as being able to see my four virtual functions in the
> >> guest using "lspci". But starting the DPDK application gives me the
> >> following error:
> >>
> >> PMD:The MAC address is not valid.
> >> The most likely cause of this error is that the VM host
> >> has not assigned a valid MAC address to this VF device.
> >> Please consult the DPDK Release Notes (FAQ section) for
> >> a possible solution to this problem.
> >>
> >> This may be true, but without any kernel modules loaded, how am I
> >> supposed to change any MAC addresses? Can this be done from within
> >> DPDK?
> >>
> >> As a side-note, I did try to load ixgbevf in the guest, but it
> >> produced no interfaces. There was no error messages in the syslog
> >> though.
> >>
> >> Is it possible to get X540 working in a guest or should I switch hardware?
> >>
> >> Since the instructions assumes I know the command line to KVM to
> >> start my guest (which I do not), I cannot followed them precisely. I
> >> use virsh and XML file, and maybe I've misunderstood how to translate
> >> the pci-assign parameter to XML code. I currently use a 
> >> entry, but I've also tried . Neither has
> >> been working for me so far, though the  version got me as
> >> far as being able to receive packets at least, but not transmitting.
> >>
> >> Regards
> >> Mats
> >>
> >>
> >> On Mon, Feb 3, 2014 at 12:13 PM, Mats Liljegren
> >>  wrote:
> >>> Never mind, I was hit by the infamous MAC spoofing... I got it
> >>> working on both the host and the guest using ixgbevf driver, so
> >>> apparently the cables are correctly attached.
> >>>
> >>> Using DPDK is still no-go. It can receive packets, but when sending
> >>> the packets the function returns success, but the driver reports
> >>> nothing (i.e. no errors, no sent packets, no nothing, except for
> >>> received packets of course).
> >>>
> >>> What could cause this behavior?
> >>>
> >>> Regards
> >>> Mats
> >>>
> >>> On Fri, Jan 31, 2014 at 7:30 PM, Mats Liljegren
> >>>  wrote:
>  I have a follow-up on this:
> 
>  ixgbe version 3.13.10-k
>  ixgbevf version 2.7.12-k
> 
>  (These are what was provided by Ubuntu 13.10)
> 
>  I tried the following sequence on the host, before starting the guest:
>  1) sudo rmmod ixgbe
>  2) sudo modprobe ixgbe max_vfs=2
>  3) sudo ifconfig em1 up  # This is the physical function
>  4) sudo ifconfig em1_0 192.168.2.2  # This is the virtual function
>  5) ping 192.168.2.1
> 
>  I can see that the ping request reaches its target, and a reply is
>  sent back. But this reply is not received by the ping shell command.
> 
>  Why?
> 
>  Regards,
>  Mats
> 
>  On Wed, Jan 29, 2014 at 6:56 PM, Mats Liljegren
>   wrote:
> > I'm trying to get a modified version of the l2fwd example running,
> > and have problem

[dpdk-dev] FW: couple of minor compilation errors in DPDK 1.6 (/lib/librte_eal/linuxapp/eal/eal_ivshmem.c)

[Burakov, Anatoly]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jyotiswarup 
> Raiturkar
> Sent: Tuesday, February 04, 2014 3:33 AM
> To: dev at dpdk.org
> Cc: Jyotiswarup Raiturkar
> Subject: [dpdk-dev] couple of minor compilation errors in DPDK 1.6
> (/lib/librte_eal/linuxapp/eal/eal_ivshmem.c)
> 
> Hi
> 
> I downloaded DPDK 1.6 from the Intel website and ran into couple of 
> compilation errors with /lib/librte_eal/linuxapp/eal/eal_ivshmem.c. 
> The following changes seem to fix it.  Have other people seen these?
> 
> Thanks
> Jyoti
> 
> 
> @@ -472,7 +472,7 @@
>   rte_snprintf(path, sizeof(path), IVSHMEM_CONFIG_PATH,
>   internal_config.hugefile_prefix);
> 
> - fd = open(path, O_CREAT | O_RDWR);
> + fd = open(path, O_CREAT | O_RDWR, S_IRWXU | S_IRWXG | S_IRWXO );
> 
>   if (fd < 0) {
>   RTE_LOG(ERR, EAL, "Could not open %s: %s\n", path, strerror(errno)); 
> @@ -
> 486,7 +486,8 @@
>   return -1;
>   }
> 
> - ftruncate(fd, sizeof(struct ivshmem_shared_config));
> + if (ftruncate(fd, sizeof(struct ivshmem_shared_config))) {
> +close(fd); return -1;
> +  }
> 
>   ivshmem_config = mmap(NULL, sizeof(struct ivshmem_shared_config),
>   PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);

Hi

I don't think assigning 0777 to a newly created file is a good idea, I would 
prefer 0666. Other than that, there is also another place where a call to 
close() should be added, so the correct patch would be:

@@ -443,7 +443,7 @@ create_shared_config(void)
rte_snprintf(path, sizeof(path), IVSHMEM_CONFIG_PATH,
internal_config.hugefile_prefix);

-   fd = open(path, O_CREAT | O_RDWR);
+   fd = open(path, O_CREAT | O_RDWR, 0666);

if (fd < 0) {
RTE_LOG(ERR, EAL, "Could not open %s: %s\n", path, 
strerror(errno)); @@ -462,14 +462,17 @@ create_shared_config(void)
ivshmem_config = mmap(NULL, sizeof(struct ivshmem_shared_config),
PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);

-   if (ivshmem_config == MAP_FAILED)
+   if (ivshmem_config == MAP_FAILED) {
+   close(fd);
return -1;
+   }

memset(ivshmem_config, 0, sizeof(struct ivshmem_shared_config));

/* change the exclusive lock we got earlier to a shared lock */
if (flock(fd, LOCK_SH | LOCK_NB) == -1) {
RTE_LOG(ERR, EAL, "Locking %s failed: %s \n", path, 
strerror(errno));
+   close(fd);
return -1;
}

Best regards,
Anatoly Burakov
DPDK SW Engineer
--
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole 
use of the intended recipient(s). Any review or distribution by others is 
strictly prohibited. If you are not the intended recipient, please contact the 
sender and delete all copies.

[dpdk-dev] How to debug packet sends to virtual functions

[Mats Liljegren]

Hi Qinglai,

How did you configure the PCI passthrough in KVM? Did you use command
line parameter as described in the instructions, or do you use virsh
XML files, or maybe using virt-manager?

The steps that works best (i.e. can receive but not transmit) are:

1) sudo modprobe ixgbe max_vfs=2
2) sudo ip link set em1 vf 0 mac 
3) sudo ifconfig em1 up
4) sudo modprobe pci-stub
5) echo "8086 1515" | sudo tee /sys/bus/pci/drivers/pci-stub/new_id
6) echo ":02:10.0" | sudo tee
/sys/bus/pci/devices/\:02\:10.0/driver/unbind
7) echo ":02:10.0" | sudo tee /sys/bus/pci/drivers/pci-stub/bind
8) virsh create vm vm.xml

The guest then does:

5) sudo modprobe uio
6) sudo insmod $RTE_SDK/$RTE_TARGET/kmod/igb_uio :02:10.0
7) sudo $RTE_SDK/tools/pci_unbind.py -b igb_uio
8) sudo 

The virsh xml file has the following entry for the virtual function:

  

  
  


I actually have two virtual functions and two physical functions, but
I just repeat above for each.

Regards
Mats

On Tue, Feb 4, 2014 at 12:14 PM, jigsaw  wrote:
> Hi Mats,
>
> I didn't have any deviation. What I did is just loading ixgbe (with
> extra params for vf, as you mentioned in your first email),
> and DPDK is up and running in guest. Of course I also followed section
> 8.10 of the DPDK release notes.
>
> I can switch between DPDK and ixgebvf in guest at runtime and
> everything works fine.
>
> Sorry I can't help to debug coz I have only 82599EB at hand.
>
> -Qinglai
>
> On Tue, Feb 4, 2014 at 12:45 PM, Mats Liljegren
>  wrote:
>> Hi Qinglai,
>>
>> Thanks for the response!
>>
>> My previous attempt was with ixgbe loaded in the host. I also needed
>> to load ixgbevf, but this seems to be because of a short-coming in
>> libvirt. Maybe loading ixgbevf and then unbind it when running the
>> guest is what causes my problems. I could receive packets with this
>> setup, but not transmit. I used extra debug to syslog, and it showed
>> that packets was placed in the transmit queue, but these packets was
>> never sent.
>>
>> I'll see if I can get this working without loading ixgbevf in the host.
>>
>> What instructions did you follow to get this working? Did you do any
>> deviation from the instructions?
>>
>> Regards
>> Mats
>>
>> On Tue, Feb 4, 2014 at 11:26 AM, jigsaw  wrote:
>>> Hi Mats,
>>>
>>> I've tried vf with 82599EB and it works fine. As long as the VF is
>>> visible in guest, DPDK's VF driver should work just as ixgbevf, which
>>> shares more or less the same code.
>>>
>>> I don't understand why you would expect DPDK at guest to work as VF,
>>> while the host has no ixgbe loaded.
>>> To make further debug I'd suggest compile ixgbe driver with your own
>>> syslogs. At least you will be able to see the signalling between vf
>>> and ixgbe drivers.
>>>
>>> -Qinglai
>>>
>>>
>>> On Tue, Feb 4, 2014 at 12:08 PM, Mats Liljegren
>>>  wrote:
 This is my fourth mail in my desperate attempt to get DPDK running in
 KVM and no comments so far, not even any "it works for me". Am I the
 only one crazy enough to believe that this can be done?

 Anyway, out of desperation I tried to get it running without having
 ixgbe or ixgbevf kernel modules loaded in host nor guest. I followed
 the instructions in the Programmer's Guide, chapter "Setting Up a KVM
 Virtual Machine Monitor", using the PMD version of the instructions.

 I get as far as being able to see my four virtual functions in the
 guest using "lspci". But starting the DPDK application gives me the
 following error:

 PMD:The MAC address is not valid.
 The most likely cause of this error is that the VM host
 has not assigned a valid MAC address to this VF device.
 Please consult the DPDK Release Notes (FAQ section) for
 a possible solution to this problem.

 This may be true, but without any kernel modules loaded, how am I
 supposed to change any MAC addresses? Can this be done from within
 DPDK?

 As a side-note, I did try to load ixgbevf in the guest, but it
 produced no interfaces. There was no error messages in the syslog
 though.

 Is it possible to get X540 working in a guest or should I switch hardware?

 Since the instructions assumes I know the command line to KVM to start
 my guest (which I do not), I cannot followed them precisely. I use
 virsh and XML file, and maybe I've misunderstood how to translate the
 pci-assign parameter to XML code. I currently use a  entry,
 but I've also tried . Neither has been
 working for me so far, though the  version got me as far as
 being able to receive packets at least, but not transmitting.

 Regards
 Mats


 On Mon, Feb 3, 2014 at 12:13 PM, Mats Liljegren
  wrote:
> Never mind, I was hit by the infamous MAC spoofing... I got it working
> on both the host and the guest using ixgbevf driver, so apparently the
> cable

[dpdk-dev] How to debug packet sends to virtual functions

[Mats Liljegren]

Hi Anatoly,

Thanks for the clarification. Then I can't use those instructions,
which is what I was starting to suspect. I have to find another way of
getting DPDK running in the guest then. Using ixgbevf in the guest
works fine, though.

Regards
Mats


On Tue, Feb 4, 2014 at 12:21 PM, Burakov, Anatoly
 wrote:
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mats Liljegren
>> Sent: Tuesday, February 04, 2014 10:45 AM
>> To: jigsaw
>> Cc: dev at dpdk.org
>> Subject: Re: [dpdk-dev] How to debug packet sends to virtual functions
>>
>> Hi Qinglai,
>>
>> Thanks for the response!
>>
>> My previous attempt was with ixgbe loaded in the host. I also needed to load
>> ixgbevf, but this seems to be because of a short-coming in libvirt. Maybe
>> loading ixgbevf and then unbind it when running the guest is what causes my
>> problems. I could receive packets with this setup, but not transmit. I used
>> extra debug to syslog, and it showed that packets was placed in the transmit
>> queue, but these packets was never sent.
>>
>> I'll see if I can get this working without loading ixgbevf in the host.
>>
>> What instructions did you follow to get this working? Did you do any
>> deviation from the instructions?
>>
>> Regards
>> Mats
>>
>> On Tue, Feb 4, 2014 at 11:26 AM, jigsaw  wrote:
>> > Hi Mats,
>> >
>> > I've tried vf with 82599EB and it works fine. As long as the VF is
>> > visible in guest, DPDK's VF driver should work just as ixgbevf, which
>> > shares more or less the same code.
>> >
>> > I don't understand why you would expect DPDK at guest to work as VF,
>> > while the host has no ixgbe loaded.
>> > To make further debug I'd suggest compile ixgbe driver with your own
>> > syslogs. At least you will be able to see the signalling between vf
>> > and ixgbe drivers.
>> >
>> > -Qinglai
>> >
>> >
>> > On Tue, Feb 4, 2014 at 12:08 PM, Mats Liljegren
>> >  wrote:
>> >> This is my fourth mail in my desperate attempt to get DPDK running in
>> >> KVM and no comments so far, not even any "it works for me". Am I the
>> >> only one crazy enough to believe that this can be done?
>> >>
>> >> Anyway, out of desperation I tried to get it running without having
>> >> ixgbe or ixgbevf kernel modules loaded in host nor guest. I followed
>> >> the instructions in the Programmer's Guide, chapter "Setting Up a KVM
>> >> Virtual Machine Monitor", using the PMD version of the instructions.
>> >>
>> >> I get as far as being able to see my four virtual functions in the
>> >> guest using "lspci". But starting the DPDK application gives me the
>> >> following error:
>> >>
>> >> PMD:The MAC address is not valid.
>> >> The most likely cause of this error is that the VM host
>> >> has not assigned a valid MAC address to this VF device.
>> >> Please consult the DPDK Release Notes (FAQ section) for
>> >> a possible solution to this problem.
>> >>
>> >> This may be true, but without any kernel modules loaded, how am I
>> >> supposed to change any MAC addresses? Can this be done from within
>> >> DPDK?
>> >>
>> >> As a side-note, I did try to load ixgbevf in the guest, but it
>> >> produced no interfaces. There was no error messages in the syslog
>> >> though.
>> >>
>> >> Is it possible to get X540 working in a guest or should I switch hardware?
>> >>
>> >> Since the instructions assumes I know the command line to KVM to
>> >> start my guest (which I do not), I cannot followed them precisely. I
>> >> use virsh and XML file, and maybe I've misunderstood how to translate
>> >> the pci-assign parameter to XML code. I currently use a 
>> >> entry, but I've also tried . Neither has
>> >> been working for me so far, though the  version got me as
>> >> far as being able to receive packets at least, but not transmitting.
>> >>
>> >> Regards
>> >> Mats
>> >>
>> >>
>> >> On Mon, Feb 3, 2014 at 12:13 PM, Mats Liljegren
>> >>  wrote:
>> >>> Never mind, I was hit by the infamous MAC spoofing... I got it
>> >>> working on both the host and the guest using ixgbevf driver, so
>> >>> apparently the cables are correctly attached.
>> >>>
>> >>> Using DPDK is still no-go. It can receive packets, but when sending
>> >>> the packets the function returns success, but the driver reports
>> >>> nothing (i.e. no errors, no sent packets, no nothing, except for
>> >>> received packets of course).
>> >>>
>> >>> What could cause this behavior?
>> >>>
>> >>> Regards
>> >>> Mats
>> >>>
>> >>> On Fri, Jan 31, 2014 at 7:30 PM, Mats Liljegren
>> >>>  wrote:
>>  I have a follow-up on this:
>> 
>>  ixgbe version 3.13.10-k
>>  ixgbevf version 2.7.12-k
>> 
>>  (These are what was provided by Ubuntu 13.10)
>> 
>>  I tried the following sequence on the host, before starting the guest:
>>  1) sudo rmmod ixgbe
>>  2) sudo modprobe ixgbe max_vfs=2
>>  3) sudo ifconfig em1 up  # This is the physical function
>>  4) sudo ifconfig em1_0 192.168.2.2  # This is the virtual fun

[dpdk-dev] How to debug packet sends to virtual functions

[Burakov, Anatoly]

> -Original Message-
> From: Mats Liljegren [mailto:liljegren.mats2 at gmail.com]
> Sent: Tuesday, February 04, 2014 11:48 AM
> To: Burakov, Anatoly
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] How to debug packet sends to virtual functions
> 
> Hi Anatoly,
> 
> Thanks for the clarification. Then I can't use those instructions, which is 
> what I
> was starting to suspect. I have to find another way of getting DPDK running in
> the guest then. Using ixgbevf in the guest works fine, though.
> 
> Regards
> Mats
> 

Hi Mats

Let me clarify - do you run DPDK on both host and guest? E.g. you load igb_uio 
on the host as well? If not, I don't see why you can't use those instructions - 
you're creating VF devices on the host anyway, and that's where you should set 
their MAC addresses.

Best regards,
Anatoly Burakov
DPDK SW Engineer

--
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare 
Registered Number: 308263 Business address: Dromore House, East Park, Shannon, 
Co. Clare

[dpdk-dev] How to debug packet sends to virtual functions

[jigsaw]

Hi Mats,

Yes the virsh xml is created in essentially the same way. And the
setup in host is also the same as yours.
But no PCI passthru. As I understand, in a PF-VF deployment it makes
no sense for PCI passthru, coz the PCI device must be visible and
under control of host. (Pls correct me if Im wrong).

-Qinglai

On Tue, Feb 4, 2014 at 1:31 PM, Mats Liljegren
 wrote:
> Hi Qinglai,
>
> How did you configure the PCI passthrough in KVM? Did you use command
> line parameter as described in the instructions, or do you use virsh
> XML files, or maybe using virt-manager?
>
> The steps that works best (i.e. can receive but not transmit) are:
>
> 1) sudo modprobe ixgbe max_vfs=2
> 2) sudo ip link set em1 vf 0 mac 
> 3) sudo ifconfig em1 up
> 4) sudo modprobe pci-stub
> 5) echo "8086 1515" | sudo tee /sys/bus/pci/drivers/pci-stub/new_id
> 6) echo ":02:10.0" | sudo tee
> /sys/bus/pci/devices/\:02\:10.0/driver/unbind
> 7) echo ":02:10.0" | sudo tee /sys/bus/pci/drivers/pci-stub/bind
> 8) virsh create vm vm.xml
>
> The guest then does:
>
> 5) sudo modprobe uio
> 6) sudo insmod $RTE_SDK/$RTE_TARGET/kmod/igb_uio :02:10.0
> 7) sudo $RTE_SDK/tools/pci_unbind.py -b igb_uio
> 8) sudo 
>
> The virsh xml file has the following entry for the virtual function:
> 
>   
>  />
>   
>function='0x0'/>
> 
>
> I actually have two virtual functions and two physical functions, but
> I just repeat above for each.
>
> Regards
> Mats
>
> On Tue, Feb 4, 2014 at 12:14 PM, jigsaw  wrote:
>> Hi Mats,
>>
>> I didn't have any deviation. What I did is just loading ixgbe (with
>> extra params for vf, as you mentioned in your first email),
>> and DPDK is up and running in guest. Of course I also followed section
>> 8.10 of the DPDK release notes.
>>
>> I can switch between DPDK and ixgebvf in guest at runtime and
>> everything works fine.
>>
>> Sorry I can't help to debug coz I have only 82599EB at hand.
>>
>> -Qinglai
>>
>> On Tue, Feb 4, 2014 at 12:45 PM, Mats Liljegren
>>  wrote:
>>> Hi Qinglai,
>>>
>>> Thanks for the response!
>>>
>>> My previous attempt was with ixgbe loaded in the host. I also needed
>>> to load ixgbevf, but this seems to be because of a short-coming in
>>> libvirt. Maybe loading ixgbevf and then unbind it when running the
>>> guest is what causes my problems. I could receive packets with this
>>> setup, but not transmit. I used extra debug to syslog, and it showed
>>> that packets was placed in the transmit queue, but these packets was
>>> never sent.
>>>
>>> I'll see if I can get this working without loading ixgbevf in the host.
>>>
>>> What instructions did you follow to get this working? Did you do any
>>> deviation from the instructions?
>>>
>>> Regards
>>> Mats
>>>
>>> On Tue, Feb 4, 2014 at 11:26 AM, jigsaw  wrote:
 Hi Mats,

 I've tried vf with 82599EB and it works fine. As long as the VF is
 visible in guest, DPDK's VF driver should work just as ixgbevf, which
 shares more or less the same code.

 I don't understand why you would expect DPDK at guest to work as VF,
 while the host has no ixgbe loaded.
 To make further debug I'd suggest compile ixgbe driver with your own
 syslogs. At least you will be able to see the signalling between vf
 and ixgbe drivers.

 -Qinglai


 On Tue, Feb 4, 2014 at 12:08 PM, Mats Liljegren
  wrote:
> This is my fourth mail in my desperate attempt to get DPDK running in
> KVM and no comments so far, not even any "it works for me". Am I the
> only one crazy enough to believe that this can be done?
>
> Anyway, out of desperation I tried to get it running without having
> ixgbe or ixgbevf kernel modules loaded in host nor guest. I followed
> the instructions in the Programmer's Guide, chapter "Setting Up a KVM
> Virtual Machine Monitor", using the PMD version of the instructions.
>
> I get as far as being able to see my four virtual functions in the
> guest using "lspci". But starting the DPDK application gives me the
> following error:
>
> PMD:The MAC address is not valid.
> The most likely cause of this error is that the VM host
> has not assigned a valid MAC address to this VF device.
> Please consult the DPDK Release Notes (FAQ section) for
> a possible solution to this problem.
>
> This may be true, but without any kernel modules loaded, how am I
> supposed to change any MAC addresses? Can this be done from within
> DPDK?
>
> As a side-note, I did try to load ixgbevf in the guest, but it
> produced no interfaces. There was no error messages in the syslog
> though.
>
> Is it possible to get X540 working in a guest or should I switch hardware?
>
> Since the instructions assumes I know the command line to KVM to start
> my guest (which I do not), I cannot followed them precisely. I use
> virsh and XML file, and maybe I'

[dpdk-dev] How to debug packet sends to virtual functions

[Mats Liljegren]

Hi Anatoly,

Just realized that the instructions gave two alternatives for the
host: DPDK igb_uio or ixgbe. It was the former, DPDK igb_uio that I
was referring to as being the non-working alternative.

Loading ixgbe enables me to set the mac addresses. This is also what I
tried previously, when I both got ixgbevf working in the guest as well
as receive to work in DPDK in the guest. The problem is making
transmit work in DPDK in the guest.

Regards
Mats



On Tue, Feb 4, 2014 at 12:52 PM, Burakov, Anatoly
 wrote:
>> -Original Message-
>> From: Mats Liljegren [mailto:liljegren.mats2 at gmail.com]
>> Sent: Tuesday, February 04, 2014 11:48 AM
>> To: Burakov, Anatoly
>> Cc: dev at dpdk.org
>> Subject: Re: [dpdk-dev] How to debug packet sends to virtual functions
>>
>> Hi Anatoly,
>>
>> Thanks for the clarification. Then I can't use those instructions, which is 
>> what I
>> was starting to suspect. I have to find another way of getting DPDK running 
>> in
>> the guest then. Using ixgbevf in the guest works fine, though.
>>
>> Regards
>> Mats
>>
>
> Hi Mats
>
> Let me clarify - do you run DPDK on both host and guest? E.g. you load 
> igb_uio on the host as well? If not, I don't see why you can't use those 
> instructions - you're creating VF devices on the host anyway, and that's 
> where you should set their MAC addresses.
>
> Best regards,
> Anatoly Burakov
> DPDK SW Engineer
>
> --
> Intel Shannon Limited
> Registered in Ireland
> Registered Office: Collinstown Industrial Park, Leixlip, County Kildare 
> Registered Number: 308263 Business address: Dromore House, East Park, 
> Shannon, Co. Clare
>
>

[dpdk-dev] [memnic PATCH] pmd: fix attributes

[Thomas Monjalon]

30/01/2014 12:37, Hiroshi Shimamoto:
> > Add missing "const" and remove useless "rte_unused" attributes.
> 
> Good catch. Looks fine to me.
> 
> > Signed-off-by: Olivier Matz 

Applied, thanks.

-- 
Thomas

[dpdk-dev] [memnic PATCH] pmd: use memory barrier function instead of asm volatile

[Thomas Monjalon]

30/01/2014 12:42, Hiroshi Shimamoto:
> > Use the DPDK specific function rte_mb() instead of
> > the GCC statement asm volatile ("" ::: "memory").
> >
> > Signed-off-by: Olivier Matz 
> 
> Yes, that's preferred for DPDK, I think.
> Looks okay to me.

Applied, thanks.

-- 
Thomas

[dpdk-dev] [memnic PATCH 1/3] pmd: remove symlink

[Thomas Monjalon]

30/01/2014 12:22, Hiroshi Shimamoto:
> > No need to have a symbolic link to a common file
> > when it can be simply included.
> 
> Looks fine to me.

Applied, thanks.

-- 
Thomas

[dpdk-dev] [memnic PATCH 2/3] pmd: remove useless includes

[Thomas Monjalon]

30/01/2014 12:30, Hiroshi Shimamoto:
> > Signed-off-by: Thomas Monjalon 
> 
> I'm not sure, but you're not seeing error, it's okay.
> I put it for uintxx_t series, originally.
> 
> others, fine to me.

Applied, thanks.

-- 
Thomas

[dpdk-dev] [memnic PATCH 3/3] common: remove double underscores

[Thomas Monjalon]

30/01/2014 12:32, Hiroshi Shimamoto:
> > The usage of double underscores is reserved.
> > 
> > Signed-off-by: Thomas Monjalon 
> 
> Looks fine to me.

Applied, thanks.

-- 
Thomas

[dpdk-dev] How to debug packet sends to virtual functions

[Burakov, Anatoly]

> -Original Message-
> From: Mats Liljegren [mailto:liljegren.mats2 at gmail.com]
> Sent: Tuesday, February 04, 2014 1:04 PM
> To: Burakov, Anatoly
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] How to debug packet sends to virtual functions
> 
> Hi Anatoly,
> 
> Just realized that the instructions gave two alternatives for the
> host: DPDK igb_uio or ixgbe. It was the former, DPDK igb_uio that I was
> referring to as being the non-working alternative.
> 
> Loading ixgbe enables me to set the mac addresses. This is also what I tried
> previously, when I both got ixgbevf working in the guest as well as receive to
> work in DPDK in the guest. The problem is making transmit work in DPDK in
> the guest.
> 
> Regards
> Mats
> 
> 
Hi Mats

Technically, you can use igb_uio on the host as well (DPDK PMD supports 
creating virtual devices since at least release 1.5.0), it's just that you'll 
have to set everything up yourself inside your host DPDK application (you can't 
use "ip net" to set up VF devices if you're using DPDK drivers). Unfortunately, 
I'm not familiar enough with that part of the code to comment on what exactly 
you should do to make it work with igb_uio, but I can certainly ask around if 
you want.

I also noticed that you are running KVM with virsh. We always run our VM's by 
passing QEMU command line directly, without using virsh, so unfortunately I 
cannot be of much help here as I'm not familiar with virsh. Your best bet would 
be to get whatever parameters virsh passes to QEMU and modify them to suit your 
needs and according to DPDK documentation.

Best regards,
Anatoly Burakov
DPDK SW Engineer

--
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

[dpdk-dev] [PATCH] igb/ixgbe: use ether_addr_equal()

[Aaro Koskinen]

ether_addr_equal() was added in Linux 3.5. compare_ether_addr() was
deleted in 3.14. Start using ether_addr_equal() and provide an own
implementation for older kernels.

This fixes the compilation with Linux 3.14-rc1.

Signed-off-by: Aaro Koskinen 
---
 lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 2 +-
 lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h  | 4 
 lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_main.c | 2 +-
 lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h| 4 
 4 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c 
b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
index f199133..ffb9fae 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
@@ -8399,7 +8399,7 @@ int igb_del_mac_filter(struct igb_adapter *adapter, u8* 
addr, u16 queue)
if (is_zero_ether_addr(addr))
return 0;
for (i = 0; i < hw->mac.rar_entry_count; i++) {
-   if (!compare_ether_addr(addr, adapter->mac_table[i].addr) &&
+   if (ether_addr_equal(addr, adapter->mac_table[i].addr) &&
adapter->mac_table[i].queue == queue) {
adapter->mac_table[i].state = IGB_MAC_STATE_MODIFIED;
memset(adapter->mac_table[i].addr, 0, ETH_ALEN);
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h 
b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
index 1d86c2b..1418c76 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
@@ -3049,6 +3049,10 @@ typedef netdev_features_t kni_netdev_features_t;

 /*/
 #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,5,0) )
+static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
+{
+   return !compare_ether_addr(addr1, addr2);
+}
 #else
 #define HAVE_FDB_OPS
 #endif /* < 3.5.0 */
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_main.c 
b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_main.c
index 947be44..cb56906 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_main.c
+++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_main.c
@@ -525,7 +525,7 @@ int ixgbe_del_mac_filter(struct ixgbe_adapter *adapter, u8* 
addr, u16 queue)
if (is_zero_ether_addr(addr))
return 0;
for (i = 0; i < hw->mac.num_rar_entries; i++) {
-   if (!compare_ether_addr(addr, adapter->mac_table[i].addr) &&
+   if (ether_addr_equal(addr, adapter->mac_table[i].addr) &&
adapter->mac_table[i].queue == queue) {
adapter->mac_table[i].state |= IXGBE_MAC_STATE_MODIFIED;
adapter->mac_table[i].state &= ~IXGBE_MAC_STATE_IN_USE;
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h 
b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h
index 1c4e057..57beb7f 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h
+++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h
@@ -3106,6 +3106,10 @@ typedef netdev_features_t kni_netdev_features_t;

 /*/
 #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,5,0) )
+static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
+{
+   return !compare_ether_addr(addr1, addr2);
+}
 #else
 #define HAVE_FDB_OPS
 #endif /* < 3.5.0 */
-- 
1.8.5.1

[dpdk-dev] [PATCH 00/11] add rte_kvargs library: a key/value args parser

[Thomas Monjalon]

28/01/2014 17:06, Olivier Matz:
> The topic of this patchset is to add a new rte_kvargs library that
> can be used as a helper to parse key/value arguments. The code will
> be based on rte_eth_pcap_arg_parser and reworked with documentation
> and tests. It also fix some minor issues of the original code.
> 
> These commits will allow another library (like pmd_ring) to parse
> arguments in an easier way without duplicating the code.
> 
> Olivier Matz (11):
>   kvargs: add a new library to parse key/value arguments
>   kvargs: use the new library in pmd_pcap
>   kvargs: remove driver name in arguments
>   kvargs: remove useless size field
>   kvargs: rework API to fix memory leak
>   kvargs: simpler parsing and allow duplicated keys
>   kvargs: be strict when matching a key
>   kvargs: add const attribute in handler parameters
>   kvargs: add the key in handler pameters
>   kvargs: make the NULL key to match all entries
>   kvargs: add test case in app/test

All is applied. Thanks for this cleanup effort.

-- 
Thomas

[dpdk-dev] [PATCH] igb/ixgbe: use ether_addr_equal()

[Thomas Monjalon]

04/02/2014 14:59, Aaro Koskinen:
> ether_addr_equal() was added in Linux 3.5. compare_ether_addr() was
> deleted in 3.14. Start using ether_addr_equal() and provide an own
> implementation for older kernels.
> 
> This fixes the compilation with Linux 3.14-rc1.
> 
> Signed-off-by: Aaro Koskinen 

Looks good.

Acked and applied with this title:
kni: fix build with kernel 3.14

Thank you
-- 
Thomas

[dpdk-dev] [PATCH 00/16] recipes for RPM packages

[Thomas Monjalon]

The goal of this patch serie is to be able to package DPDK
for RPM-based distributions.

Note that there is neither DKMS nor AKMOD support and
that rpmlint complains about few things.
But it is a first step to start thinking about packaging.

-- 
Thomas

[dpdk-dev] [PATCH 01/16] tools: rename pci_unbind script

[Thomas Monjalon]

In order to make this tool available among other system commands,
the name must be more specific.

Signed-off-by: Thomas Monjalon 
---
 tools/igb_uio_bind.py |  485 +
 tools/pci_unbind.py   |  485 -
 tools/setup.sh|   16 +-
 3 files changed, 493 insertions(+), 493 deletions(-)
 create mode 100755 tools/igb_uio_bind.py
 delete mode 100755 tools/pci_unbind.py

diff --git a/tools/igb_uio_bind.py b/tools/igb_uio_bind.py
new file mode 100755
index 000..528999a
--- /dev/null
+++ b/tools/igb_uio_bind.py
@@ -0,0 +1,485 @@
+#! /usr/bin/python
+#
+#   BSD LICENSE
+# 
+#   Copyright(c) 2010-2013 Intel Corporation. All rights reserved.
+#   All rights reserved.
+# 
+#   Redistribution and use in source and binary forms, with or without
+#   modification, are permitted provided that the following conditions
+#   are met:
+# 
+# * Redistributions of source code must retain the above copyright
+#   notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in
+#   the documentation and/or other materials provided with the
+#   distribution.
+# * Neither the name of Intel Corporation nor the names of its
+#   contributors may be used to endorse or promote products derived
+#   from this software without specific prior written permission.
+# 
+#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+
+import sys, os, getopt, subprocess
+from os.path import exists, abspath, dirname, basename
+
+
+# The PCI device class for ETHERNET devices
+ETHERNET_CLASS = "0200"
+
+# global dict ethernet devices present. Dictionary indexed by PCI address.
+# Each device within this is itself a dictionary of device properties
+devices = {}
+# list of vendor:device pairs (again stored as dictionary) supported by igb_uio
+module_dev_ids = []
+
+def usage():
+'''Print usage information for the program'''
+argv0 = basename(sys.argv[0])
+print """
+Usage:
+--
+
+ %(argv0)s [options] DEVICE1 DEVICE2 
+
+where DEVICE1, DEVICE2 etc, are specified via PCI "domain:bus:slot.func" syntax
+or "bus:slot.func" syntax. For devices bound to Linux kernel drivers, they may
+also be referred to by Linux interface name e.g. eth0, eth1, em0, em1, etc.
+
+Options:
+--help, --usage:
+Display usage information and quit
+
+--status:
+Print the current status of all known network interfaces.
+For each device, it displays the PCI domain, bus, slot and function,
+along with a text description of the device. Depending upon whether the
+device is being used by a kernel driver, the igb_uio driver, or no
+driver, other relevant information will be displayed:
+* the Linux interface name e.g. if=eth0
+* the driver being used e.g. drv=igb_uio
+* any suitable drivers not currently using that device 
+e.g. unused=igb_uio 
+NOTE: if this flag is passed along with a bind/unbind option, the 
status
+display will always occur after the other operations have taken place.
+
+-b driver, --bind=driver: 
+Select the driver to use or \"none\" to unbind the device
+
+-u, --unbind: 
+Unbind a device (Equivalent to \"-b none\")
+
+--force:
+By default, devices which are used by Linux - as indicated by having
+routes in the routing table - cannot be modified. Using the --force
+flag overrides this behavior, allowing active links to be forcibly
+unbound. 
+WARNING: This can lead to loss of network connection and should be used
+with caution.
+
+Examples:
+-
+
+To display current device status:
+%(argv0)s --status
+
+To bind eth1 from the current driver and move to use igb_uio
+%(argv0)s --bind=igb_uio eth1
+
+To unbind :01:00.0 from using any driver
+%(argv0)s -u :01:00.0
+
+To bind :02:00.0 and :02:00.1 to the ixgbe kernel driver
+%(argv0)s -b i

[dpdk-dev] [PATCH 02/16] virtio: rename library

[Thomas Monjalon]

In order to distinguish clearly this implementation from the extension
virtio-net-pmd, it is renamed to reflect its usage of uio framework.

Signed-off-by: Thomas Monjalon 
---
 lib/librte_pmd_virtio/Makefile |2 +-
 mk/rte.app.mk  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_pmd_virtio/Makefile b/lib/librte_pmd_virtio/Makefile
index 764d8e8..a60c5f4 100644
--- a/lib/librte_pmd_virtio/Makefile
+++ b/lib/librte_pmd_virtio/Makefile
@@ -34,7 +34,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
 #
 # library name
 #
-LIB = librte_pmd_virtio.a
+LIB = librte_pmd_virtio_uio.a

 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 1652029..6432f17 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -73,7 +73,7 @@ LDLIBS += -lrte_pmd_ixgbe
 endif

 ifeq ($(CONFIG_RTE_LIBRTE_VIRTIO_PMD),y)
-LDLIBS += -lrte_pmd_virtio
+LDLIBS += -lrte_pmd_virtio_uio
 endif

 ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y)
-- 
1.7.10.4

[dpdk-dev] [PATCH 03/16] pkg: add recipe for RPM

[Thomas Monjalon]

Packages can be built with:
RPM_BUILD_NCPUS=8 rpmbuild -ta dpdk-1.5.2r2.tar.gz

There are packages for runtime, static libraries and development.
Once devel package installed, it can be used like this:
make -C /usr/share/dpdk/examples/helloworld RTE_SDK=/usr/share/dpdk

Signed-off-by: Thomas Monjalon 
---
 pkg/rpm.spec |  143 ++
 1 file changed, 143 insertions(+)
 create mode 100644 pkg/rpm.spec

diff --git a/pkg/rpm.spec b/pkg/rpm.spec
new file mode 100644
index 000..d806d55
--- /dev/null
+++ b/pkg/rpm.spec
@@ -0,0 +1,143 @@
+# Copyright 2014 6WIND S.A.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# - Redistributions of source code must retain the above copyright
+#   notice, this list of conditions and the following disclaimer.
+#
+# - Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in
+#   the documentation and/or other materials provided with the
+#   distribution.
+#
+# - Neither the name of 6WIND S.A. nor the names of its
+#   contributors may be used to endorse or promote products derived
+#   from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+# OF THE POSSIBILITY OF SUCH DAMAGE.
+
+Name: dpdk
+Version: 1.5.2r1
+Release: 1
+Packager: packaging at 6wind.com
+URL: http://dpdk.org
+Source: http://dpdk.org/browse/dpdk/snapshot/dpdk-%{version}.tar.gz
+
+Summary: Intel(r) Data Plane Development Kit
+Group: System Environment/Libraries
+License: BSD and LGPLv2 and GPLv2
+
+ExclusiveArch: i686, x86_64
+%define target %{_arch}-default-linuxapp-gcc
+%define machine default
+
+BuildRequires: kernel-devel, kernel-headers, doxygen
+
+%description
+Dummy main package. Make only subpackages.
+
+%package core-runtime
+Summary: Intel(r) Data Plane Development Kit core for runtime
+%description core-runtime
+Intel(r) DPDK runtime includes kernel modules, core libraries and tools.
+testpmd application allows to test fast packet processing environments
+on x86 platforms. For instance, it can be used to check that environment
+can support fast path applications such as 6WINDGate, pktgen, rumptcpip, etc.
+More libraries are available as extensions in other packages.
+
+%package core-static
+Requires: %{name}-core-runtime
+Summary: Intel(r) Data Plane Development Kit core as static libraries
+%description core-static
+Intel(r) DPDK static provides static version of the core libraries
+for fast packet processing on x86 platforms.
+More libraries are available as extensions in other packages.
+
+%package core-devel
+Requires: %{name}-core-static
+Summary: Intel(r) Data Plane Development Kit core for development
+%description core-devel
+Intel(r) DPDK devel is a set of makefiles, headers, examples and documentation
+for fast packet processing on x86 platforms.
+More libraries are available as extensions in other packages.
+
+# debuginfo packaging is broken
+%define debug_package %{nil}
+
+%define destdir %{buildroot}%{_prefix}
+%define moddir  /lib/modules/%(uname -r)/extra
+%define datadir %{_datadir}/%{name}
+%define docdir  %{_docdir}/%{name}
+
+%prep
+%setup -q
+
+%build
+make O=%{target} T=%{target} config
+sed -ri 's,(RTE_MACHINE=).*,\1%{machine},' %{target}/.config
+sed -ri 's,(RTE_APP_TEST=).*,\1n,' %{target}/.config
+sed -ri 's,(RTE_BUILD_SHARED_LIB=).*,\1y,' %{target}/.config
+make O=%{target} %{?_smp_mflags}
+cp %{target}/lib/*.so %{target}
+sed -ri 's,(RTE_BUILD_SHARED_LIB=).*,\1n,' %{target}/.config
+make O=%{target} %{?_smp_mflags}
+make O=%{target} doc
+
+%install
+rm -rf %{buildroot}
+make   O=%{target} DESTDIR=%{destdir}
+mkdir -p   %{buildroot}%{moddir}
+mv%{destdir}/%{target}/kmod/*.ko   %{buildroot}%{moddir}
+rmdir %{destdir}/%{target}/kmod
+mkdir -p   %{buildroot}%{_sbindir}
+ln -s %{datadir}/tools/igb_uio_bind.py %{buildroot}%{_sbindir}/igb_uio_bind
+mkdir -p   %{buildroot}%{_bindir}
+mv%{destdir}/%{target}/app/testpmd %{buildroot}%{_bindir}
+rmdir %{destdir}/%{target}/ap

[dpdk-dev] [vmxnet3-usermap PATCH 04/16] pmd: add make help

[Thomas Monjalon]

Add help for quick tips.
Also define CC and remove RTE_CONFIG variable.

Signed-off-by: Thomas Monjalon 
---
 pmd/Makefile |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/pmd/Makefile b/pmd/Makefile
index 994851c..d8eff33 100644
--- a/pmd/Makefile
+++ b/pmd/Makefile
@@ -1,4 +1,4 @@
-# Copyright 2013 6WIND S.A.
+# Copyright 2013-2014 6WIND S.A.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -29,24 +29,33 @@
 # ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 # OF THE POSSIBILITY OF SUCH DAMAGE.

+SOLIB = librte_pmd_vmxnet3.so
+
+CC = $(CROSS)gcc
 override CPPFLAGS += -Wall -Wextra -Werror
 override CFLAGS   += -fPIC
 override LDFLAGS  += -shared

 KMOD_INCLUDE ?= ../kmod
-RTE_CONFIG = $(RTE_INCLUDE)/rte_config.h
-SOLIB = librte_pmd_vmxnet3.so

 all :
 ifeq '$(RTE_INCLUDE)' ''
@ echo 'ERROR: RTE_INCLUDE is not set' && false
 endif
-   $(CROSS)gcc $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
-   -I$(RTE_INCLUDE) -include $(RTE_CONFIG) \
+   $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
+   -I$(RTE_INCLUDE) -include $(RTE_INCLUDE)/rte_config.h \
-I$(KMOD_INCLUDE) -I$(KMOD_INCLUDE)/shared \
-o $(SOLIB) vmxnet3.c

 clean :
rm -f $(SOLIB)

-.PHONY : all clean
+help :
+   @ echo 'rules:'
+   @ echo 'all (default)'
+   @ echo 'clean'
+   @ echo 'build variables:'
+   @ echo 'RTE_INCLUDE (e.g. ../dpdk/build/include),'
+   @ echo 'CPPFLAGS, CFLAGS, LDFLAGS'
+
+.PHONY : all clean help
-- 
1.7.10.4

[dpdk-dev] [vmxnet3-usermap PATCH 05/16] pmd: allow to build outside of the source directory

[Thomas Monjalon]

S specify source directory (when not already in).
O specify output directory (when different of current one).

Signed-off-by: Thomas Monjalon 
---
 pmd/Makefile |   21 -
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/pmd/Makefile b/pmd/Makefile
index d8eff33..2d66fb7 100644
--- a/pmd/Makefile
+++ b/pmd/Makefile
@@ -36,19 +36,29 @@ override CPPFLAGS += -Wall -Wextra -Werror
 override CFLAGS   += -fPIC
 override LDFLAGS  += -shared

-KMOD_INCLUDE ?= ../kmod
+KMOD_INCLUDE ?= $S/../kmod
+S ?= .
+O ?= .

-all :
+all : $O/$(SOLIB)
+
+$O :
+   mkdir -p $@
+
+$O/$(SOLIB) : $S/vmxnet3.c | $O
 ifeq '$(RTE_INCLUDE)' ''
@ echo 'ERROR: RTE_INCLUDE is not set' && false
 endif
$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
-I$(RTE_INCLUDE) -include $(RTE_INCLUDE)/rte_config.h \
-I$(KMOD_INCLUDE) -I$(KMOD_INCLUDE)/shared \
-   -o $(SOLIB) vmxnet3.c
+   -o $@ $<

 clean :
-   rm -f $(SOLIB)
+   - rm -f $O/$(SOLIB)
+ifneq '$(abspath $O)' '$(CURDIR)'
+   - rmdir -p $O 2>&-
+endif

 help :
@ echo 'rules:'
@@ -56,6 +66,7 @@ help :
@ echo 'clean'
@ echo 'build variables:'
@ echo 'RTE_INCLUDE (e.g. ../dpdk/build/include),'
-   @ echo 'CPPFLAGS, CFLAGS, LDFLAGS'
+   @ echo 'CPPFLAGS, CFLAGS, LDFLAGS,'
+   @ echo 'S (source directory), O (build directory)'

 .PHONY : all clean help
-- 
1.7.10.4

[dpdk-dev] [vmxnet3-usermap PATCH 06/16] pmd: allow to install lib and doc

[Thomas Monjalon]

Signed-off-by: Thomas Monjalon 
---
 pmd/Makefile |   28 +++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/pmd/Makefile b/pmd/Makefile
index 2d66fb7..759800e 100644
--- a/pmd/Makefile
+++ b/pmd/Makefile
@@ -30,6 +30,7 @@
 # OF THE POSSIBILITY OF SUCH DAMAGE.

 SOLIB = librte_pmd_vmxnet3.so
+DOC = dpdk-vmxnet3-usermap.rst

 CC = $(CROSS)gcc
 override CPPFLAGS += -Wall -Wextra -Werror
@@ -40,6 +41,12 @@ KMOD_INCLUDE ?= $S/../kmod
 S ?= .
 O ?= .

+prefix ?= /usr/local
+exec_prefix ?= $(prefix)
+libdir ?= $(exec_prefix)/lib
+datarootdir ?= $(prefix)/share
+docdir ?= $(datarootdir)/doc/dpdk
+
 all : $O/$(SOLIB)

 $O :
@@ -54,19 +61,38 @@ endif
-I$(KMOD_INCLUDE) -I$(KMOD_INCLUDE)/shared \
-o $@ $<

+install : $(DESTDIR)$(libdir)/$(SOLIB)
+$(DESTDIR)$(libdir)/$(SOLIB): $O/$(SOLIB)
+   install -D -m 644 $< $@
+
+install : $(DESTDIR)$(docdir)/$(DOC)
+$(DESTDIR)$(docdir)/$(DOC) : $S/../README.rst
+   install -D -m 644 $< $@
+
 clean :
- rm -f $O/$(SOLIB)
 ifneq '$(abspath $O)' '$(CURDIR)'
- rmdir -p $O 2>&-
 endif

+uninstall :
+   - rm -f $(DESTDIR)$(libdir)/$(SOLIB)
+   - rmdir -p $(DESTDIR)$(libdir) 2>&-
+   - rm -f $(DESTDIR)$(docdir)/$(DOC)
+   - rmdir -p $(DESTDIR)$(docdir) 2>&-
+
 help :
@ echo 'rules:'
@ echo 'all (default)'
@ echo 'clean'
+   @ echo 'install'
+   @ echo 'uninstall'
@ echo 'build variables:'
@ echo 'RTE_INCLUDE (e.g. ../dpdk/build/include),'
@ echo 'CPPFLAGS, CFLAGS, LDFLAGS,'
@ echo 'S (source directory), O (build directory)'
+   @ echo 'install variables:'
+   @ echo 'DESTDIR (optional),'
+   @ echo 'prefix, exec_prefix, libdir, datarootdir, docdir'

-.PHONY : all clean help
+.PHONY : all clean install uninstall help
-- 
1.7.10.4

[dpdk-dev] [vmxnet3-usermap PATCH 07/16] pkg: add recipe for RPM

[Thomas Monjalon]

Package can be built with:
rpmbuild -ta vmxnet3-usermap-1.2.tar.gz

Signed-off-by: Thomas Monjalon 
---
 pkg/rpm.spec |   76 ++
 1 file changed, 76 insertions(+)
 create mode 100644 pkg/rpm.spec

diff --git a/pkg/rpm.spec b/pkg/rpm.spec
new file mode 100644
index 000..495189f
--- /dev/null
+++ b/pkg/rpm.spec
@@ -0,0 +1,76 @@
+# Copyright 2014 6WIND S.A.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# - Redistributions of source code must retain the above copyright
+#   notice, this list of conditions and the following disclaimer.
+#
+# - Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in
+#   the documentation and/or other materials provided with the
+#   distribution.
+#
+# - Neither the name of 6WIND S.A. nor the names of its
+#   contributors may be used to endorse or promote products derived
+#   from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+# OF THE POSSIBILITY OF SUCH DAMAGE.
+
+Name: dpdk-vmxnet3
+Version: 1.1
+Release: 1
+Packager: packaging at 6wind.com
+URL: http://dpdk.org/doc/vmxnet3-usermap
+Source: 
http://dpdk.org/browse/vmxnet3-usermap/snapshot/vmxnet3-usermap-%{version}.tar.gz
+
+Summary: vmxnet3 driver for Intel(r) Data Plane Development Kit
+Group: System Environment/Libraries
+License: BSD and GPLv2
+
+ExclusiveArch: i686, x86_64
+%define target %{_arch}-default-linuxapp-gcc
+
+BuildRequires: dpdk-core-devel, kernel-devel, kernel-headers
+Requires: dpdk-core-runtime
+
+%description
+vmxnet3 is a paravirtualized network interface initially used in VMware ESXi,
+and has been introduced as PMD by 6WIND. It avoids security risk by not using
+UIO framework.
+
+%define datadir   %{_datadir}/dpdk
+%define docdir%{_docdir}/dpdk
+%define modroot   /lib/modules/%(uname -r)
+%define kerneldir %{modroot}/build
+%define moddir%{modroot}/extra
+
+%prep
+%setup -qn vmxnet3-usermap-%{version}
+
+%build
+make %{?_smp_mflags} -C pmd RTE_INCLUDE=%{datadir}/%{target}/include
+make %{?_smp_mflags} -C kmod HEADER_DIR=%{kerneldir}/include
+
+%install
+rm -rf %{buildroot}
+make install -C pmd DESTDIR=%{buildroot} libdir=%{_libdir} docdir=%{docdir}
+make modules_install -C %{kerneldir} M=$(pwd)/kmod 
INSTALL_MOD_PATH=%{buildroot}
+rm -f %{buildroot}%{modroot}/modules.*
+
+%files
+%{moddir}/*
+%{_libdir}/*
+%doc %{docdir}
-- 
1.7.10.4

[dpdk-dev] [virtio-net-pmd PATCH 08/16] pmd: fix initialization of Tx queue header

[Thomas Monjalon]

A typo was found by gcc-4.8:
virtio_user.c:744:15: error: argument to 'sizeof' in 'memset' call is the
same expression as the destination; did you mean to dereference it?
[-Werror=sizeof-pointer-memaccess]
 sizeof(tq->tx_hdrs[sz - 1].header));
   ^

Signed-off-by: Thomas Monjalon 
---
 virtio_user.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/virtio_user.c b/virtio_user.c
index 1074bd8..a5f81df 100644
--- a/virtio_user.c
+++ b/virtio_user.c
@@ -1,5 +1,5 @@
 /*
- * Copyright 2013 6WIND S.A.
+ * Copyright 2013-2014 6WIND S.A.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -741,7 +741,7 @@ virtio_alloc_txq(struct virtio_net_vring* tq, int sz)
}
/* Reserve a NULL header for NO OP on hypervisor side. */
memset(tq->tx_hdrs[sz - 1].header, 0,
-  sizeof(tq->tx_hdrs[sz - 1].header));
+  sizeof(*tq->tx_hdrs[sz - 1].header));
return 0;
 }

-- 
1.7.10.4

[dpdk-dev] [virtio-net-pmd PATCH 09/16] mk: minor fixes

[Thomas Monjalon]

Fix help.
Also define CC and remove RTE_CONFIG variable.

Signed-off-by: Thomas Monjalon 
---
 Makefile |   17 +
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index d90f23e..4b51057 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@
-# Copyright 2013 6WIND S.A.
+# Copyright 2013-2014 6WIND S.A.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -29,19 +29,19 @@
 # ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 # OF THE POSSIBILITY OF SUCH DAMAGE.

+SOLIB = librte_pmd_virtio.so
+
+CC = $(CROSS)gcc
 override CPPFLAGS += -Wall -Wextra -Werror
 override CFLAGS   += -fPIC
 override LDFLAGS  += -shared

-RTE_CONFIG = $(RTE_INCLUDE)/rte_config.h
-SOLIB = librte_pmd_virtio.so
-
 all :
 ifeq '$(RTE_INCLUDE)' ''
@ echo 'ERROR: RTE_INCLUDE is not set' && false
 endif
-   $(CROSS)gcc $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
-   -I$(RTE_INCLUDE) -include $(RTE_CONFIG) \
+   $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
+   -I$(RTE_INCLUDE) -include $(RTE_INCLUDE)/rte_config.h \
-o $(SOLIB) virtio_user.c

 clean :
@@ -52,6 +52,7 @@ help :
@ echo 'all (default)'
@ echo 'clean'
@ echo 'variables:'
-   @ echo 'RTE_INCLUDE (e.g. ../dpdk/build/include)'
+   @ echo 'RTE_INCLUDE (e.g. ../dpdk/build/include),'
+   @ echo 'CPPFLAGS, CFLAGS, LDFLAGS'

-.PHONY : all clean
+.PHONY : all clean help
-- 
1.7.10.4

[dpdk-dev] [virtio-net-pmd PATCH 10/16] mk: allow to build outside of the source directory

[Thomas Monjalon]

S specify source directory (when not already in).
O specify output directory (when different of current one).

Signed-off-by: Thomas Monjalon 
---
 Makefile |   20 
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 4b51057..4ff4c1d 100644
--- a/Makefile
+++ b/Makefile
@@ -36,16 +36,27 @@ override CPPFLAGS += -Wall -Wextra -Werror
 override CFLAGS   += -fPIC
 override LDFLAGS  += -shared

-all :
+S ?= .
+O ?= .
+
+all : $O/$(SOLIB)
+
+$O :
+   mkdir -p $@
+
+$O/$(SOLIB) : $S/virtio_user.c | $O
 ifeq '$(RTE_INCLUDE)' ''
@ echo 'ERROR: RTE_INCLUDE is not set' && false
 endif
$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
-I$(RTE_INCLUDE) -include $(RTE_INCLUDE)/rte_config.h \
-   -o $(SOLIB) virtio_user.c
+   -o $@ $<

 clean :
-   rm -f $(SOLIB)
+   - rm -f $O/$(SOLIB)
+ifneq '$(abspath $O)' '$(CURDIR)'
+   - rmdir -p $O 2>&-
+endif

 help :
@ echo 'rules:'
@@ -53,6 +64,7 @@ help :
@ echo 'clean'
@ echo 'variables:'
@ echo 'RTE_INCLUDE (e.g. ../dpdk/build/include),'
-   @ echo 'CPPFLAGS, CFLAGS, LDFLAGS'
+   @ echo 'CPPFLAGS, CFLAGS, LDFLAGS,'
+   @ echo 'S (source directory), O (build directory)'

 .PHONY : all clean help
-- 
1.7.10.4

[dpdk-dev] [virtio-net-pmd PATCH 11/16] mk: allow to install lib and doc

[Thomas Monjalon]

Signed-off-by: Thomas Monjalon 
---
 Makefile |   30 --
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 4ff4c1d..100864d 100644
--- a/Makefile
+++ b/Makefile
@@ -30,6 +30,7 @@
 # OF THE POSSIBILITY OF SUCH DAMAGE.

 SOLIB = librte_pmd_virtio.so
+DOC = dpdk-virtio-net-pmd.rst

 CC = $(CROSS)gcc
 override CPPFLAGS += -Wall -Wextra -Werror
@@ -39,6 +40,12 @@ override LDFLAGS  += -shared
 S ?= .
 O ?= .

+prefix ?= /usr/local
+exec_prefix ?= $(prefix)
+libdir ?= $(exec_prefix)/lib
+datarootdir ?= $(prefix)/share
+docdir ?= $(datarootdir)/doc/dpdk
+
 all : $O/$(SOLIB)

 $O :
@@ -52,19 +59,38 @@ endif
-I$(RTE_INCLUDE) -include $(RTE_INCLUDE)/rte_config.h \
-o $@ $<

+install : $(DESTDIR)$(libdir)/$(SOLIB)
+$(DESTDIR)$(libdir)/$(SOLIB): $O/$(SOLIB)
+   install -D -m 644 $< $@
+
+install : $(DESTDIR)$(docdir)/$(DOC)
+$(DESTDIR)$(docdir)/$(DOC) : $S/README.rst
+   install -D -m 644 $< $@
+
 clean :
- rm -f $O/$(SOLIB)
 ifneq '$(abspath $O)' '$(CURDIR)'
- rmdir -p $O 2>&-
 endif

+uninstall :
+   - rm -f $(DESTDIR)$(libdir)/$(SOLIB)
+   - rmdir -p $(DESTDIR)$(libdir) 2>&-
+   - rm -f $(DESTDIR)$(docdir)/$(DOC)
+   - rmdir -p $(DESTDIR)$(docdir) 2>&-
+
 help :
@ echo 'rules:'
@ echo 'all (default)'
@ echo 'clean'
-   @ echo 'variables:'
+   @ echo 'install'
+   @ echo 'uninstall'
+   @ echo 'build variables:'
@ echo 'RTE_INCLUDE (e.g. ../dpdk/build/include),'
@ echo 'CPPFLAGS, CFLAGS, LDFLAGS,'
@ echo 'S (source directory), O (build directory)'
+   @ echo 'install variables:'
+   @ echo 'DESTDIR (optional),'
+   @ echo 'prefix, exec_prefix, libdir, datarootdir, docdir'

-.PHONY : all clean help
+.PHONY : all clean install uninstall help
-- 
1.7.10.4

[dpdk-dev] [virtio-net-pmd PATCH 12/16] pkg: add recipe for RPM

[Thomas Monjalon]

Package can be built with:
rpmbuild -ta virtio-net-pmd-1.2.tar.gz

Signed-off-by: Thomas Monjalon 
---
 pkg/rpm.spec |   69 ++
 1 file changed, 69 insertions(+)
 create mode 100644 pkg/rpm.spec

diff --git a/pkg/rpm.spec b/pkg/rpm.spec
new file mode 100644
index 000..4768e91
--- /dev/null
+++ b/pkg/rpm.spec
@@ -0,0 +1,69 @@
+# Copyright 2014 6WIND S.A.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# - Redistributions of source code must retain the above copyright
+#   notice, this list of conditions and the following disclaimer.
+#
+# - Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in
+#   the documentation and/or other materials provided with the
+#   distribution.
+#
+# - Neither the name of 6WIND S.A. nor the names of its
+#   contributors may be used to endorse or promote products derived
+#   from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+# OF THE POSSIBILITY OF SUCH DAMAGE.
+
+Name: dpdk-virtio
+Version: 1.1
+Release: 1
+Packager: packaging at 6wind.com
+URL: http://dpdk.org/doc/virtio-net-pmd
+Source: 
http://dpdk.org/browse/virtio-net-pmd/snapshot/virtio-net-pmd-%{version}.tar.gz
+
+Summary: virtio-net driver for Intel(r) Data Plane Development Kit
+Group: System Environment/Libraries
+License: BSD
+
+ExclusiveArch: i686, x86_64
+%define target %{_arch}-default-linuxapp-gcc
+
+BuildRequires: dpdk-core-devel, kernel-headers
+Requires: dpdk-core-runtime
+
+%description
+virtio-net is a paravirtualized network interface based on virtio framework,
+and has been introduced as PMD by 6WIND. It avoids security risk by not using
+UIO framework.
+
+%define datadir %{_datadir}/dpdk
+%define docdir  %{_docdir}/dpdk
+
+%prep
+%setup -qn virtio-net-pmd-%{version}
+
+%build
+make %{?_smp_mflags} RTE_INCLUDE=%{datadir}/%{target}/include
+
+%install
+rm -rf %{buildroot}
+make install DESTDIR=%{buildroot} libdir=%{_libdir} docdir=%{docdir}
+
+%files
+%{_libdir}/*
+%doc %{docdir}
-- 
1.7.10.4

[dpdk-dev] [memnic PATCH 13/16] pmd: rename doc when installing

[Thomas Monjalon]

MEMNIC doc may be installed with other DPDK docs.
So more descriptive naming is required.

A rule is created in order to have the same rule style for lib and doc.

Signed-off-by: Thomas Monjalon 
---
 pmd/Makefile |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/pmd/Makefile b/pmd/Makefile
index 7f96af1..1e24a15 100644
--- a/pmd/Makefile
+++ b/pmd/Makefile
@@ -33,6 +33,7 @@ PKG = librte_pmd_memnic_copy

 RTE_CONFIG = $(RTE_INCLUDE)/rte_config.h
 SOLIB = $(PKG).so
+DOC = dpdk-memnic.rst

 S ?= .
 O ?= .
@@ -46,7 +47,7 @@ prefix ?= /usr/local
 exec_prefix ?= $(prefix)
 libdir ?= $(exec_prefix)/lib
 datarootdir ?= $(prefix)/share
-docdir ?= $(datarootdir)/doc/$(PKG)
+docdir ?= $(datarootdir)/doc/dpdk

 all : $O/$(SOLIB)

@@ -62,11 +63,13 @@ endif
-I$S/../common -o $@ $<

 install : $(DESTDIR)$(libdir)/$(SOLIB)
-   install -D -m 644 $S/README.rst $(DESTDIR)$(docdir)/README.rst
-
 $(DESTDIR)$(libdir)/$(SOLIB): $O/$(SOLIB)
install -D -m 644 $< $@

+install : $(DESTDIR)$(docdir)/$(DOC)
+$(DESTDIR)$(docdir)/$(DOC) : $S/README.rst
+   install -D -m 644 $< $@
+
 clean :
- rm -f $O/$(SOLIB)
 ifneq '$(abspath $O)' '$(CURDIR)'
-- 
1.7.10.4

[dpdk-dev] [memnic PATCH 14/16] pmd: fix doc uninstalling

[Thomas Monjalon]

Signed-off-by: Thomas Monjalon 
---
 pmd/Makefile |2 ++
 1 file changed, 2 insertions(+)

diff --git a/pmd/Makefile b/pmd/Makefile
index 1e24a15..730b126 100644
--- a/pmd/Makefile
+++ b/pmd/Makefile
@@ -79,6 +79,8 @@ endif
 uninstall :
- rm -f $(DESTDIR)$(libdir)/$(SOLIB)
- rmdir -p $(DESTDIR)$(libdir) 2>&-
+   - rm -f $(DESTDIR)$(docdir)/$(DOC)
+   - rmdir -p $(DESTDIR)$(docdir) 2>&-

 help :
@ echo 'rules:'
-- 
1.7.10.4

[dpdk-dev] [memnic PATCH 15/16] pmd: remove useless makefile variables

[Thomas Monjalon]

Signed-off-by: Thomas Monjalon 
---
 pmd/Makefile |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/pmd/Makefile b/pmd/Makefile
index 730b126..5edc44e 100644
--- a/pmd/Makefile
+++ b/pmd/Makefile
@@ -29,10 +29,7 @@
 # ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 # OF THE POSSIBILITY OF SUCH DAMAGE.

-PKG = librte_pmd_memnic_copy
-
-RTE_CONFIG = $(RTE_INCLUDE)/rte_config.h
-SOLIB = $(PKG).so
+SOLIB = librte_pmd_memnic_copy.so
 DOC = dpdk-memnic.rst

 S ?= .
@@ -59,7 +56,7 @@ ifeq '$(RTE_INCLUDE)' ''
@ echo 'ERROR: RTE_INCLUDE is not set' && false
 endif
$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
-   -I$(RTE_INCLUDE) -include $(RTE_CONFIG) \
+   -I$(RTE_INCLUDE) -include $(RTE_INCLUDE)/rte_config.h \
-I$S/../common -o $@ $<

 install : $(DESTDIR)$(libdir)/$(SOLIB)
-- 
1.7.10.4

[dpdk-dev] [memnic PATCH 16/16] pkg: add recipe for RPM

[Thomas Monjalon]

Packages can be built with:
rpmbuild -ta memnic-1.1.tar.gz

There are packages for kernel module and PMD versions.

Signed-off-by: Thomas Monjalon 
---
 pkg/rpm.spec |   95 ++
 1 file changed, 95 insertions(+)
 create mode 100644 pkg/rpm.spec

diff --git a/pkg/rpm.spec b/pkg/rpm.spec
new file mode 100644
index 000..a5183f0
--- /dev/null
+++ b/pkg/rpm.spec
@@ -0,0 +1,95 @@
+# Copyright 2014 6WIND S.A.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# - Redistributions of source code must retain the above copyright
+#   notice, this list of conditions and the following disclaimer.
+#
+# - Redistributions in binary form must reproduce the above copyright
+#   notice, this list of conditions and the following disclaimer in
+#   the documentation and/or other materials provided with the
+#   distribution.
+#
+# - Neither the name of 6WIND S.A. nor the names of its
+#   contributors may be used to endorse or promote products derived
+#   from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+# OF THE POSSIBILITY OF SUCH DAMAGE.
+
+Name: memnic
+Version: 1.0
+Release: 1
+Packager: packaging at 6wind.com
+URL: http://dpdk.org/doc/memnic-pmd
+Source: http://dpdk.org/browse/memnic/snapshot/memnic-%{version}.tar.gz
+
+Summary: MEMNIC
+Group: System Environment/Libraries
+License: BSD and GPLv2
+
+ExclusiveArch: i686, x86_64
+%define target %{_arch}-default-linuxapp-gcc
+
+%description
+Dummy main package. Make only subpackages.
+
+%package -n dpdk-memnic
+BuildRequires: dpdk-core-devel
+Requires: dpdk-core-runtime
+Summary: MEMNIC driver for Intel(r) Data Plane Development Kit
+%description -n dpdk-memnic
+MEMNIC is a paravirtualized network interface (PMD) based
+on memory copy and introduced by NEC.
+It has similar concepts to virtio-net, but does not use the vring framework.
+Instead, it is based on a queue of mailboxed packets which are copied
+in IVSHMEM between the host and the guest.
+
+%define datadir   %{_datadir}/dpdk
+%define docdir%{_docdir}/dpdk
+
+%package kmod
+BuildRequires: kernel-devel
+Summary: MEMNIC kernel driver
+%description kmod
+MEMNIC is a paravirtualized network interface (netdevice driver) based
+on memory copy and introduced by NEC.
+It has similar concepts to virtio-net, but does not use the vring framework.
+Instead, it is based on a queue of mailboxed packets which are copied
+in IVSHMEM between the host and the guest.
+
+%define modroot   /lib/modules/%(uname -r)
+%define kerneldir %{modroot}/build
+%define moddir%{modroot}/extra
+
+%prep
+%setup -q
+
+%build
+make %{?_smp_mflags} -C pmd RTE_INCLUDE=%{datadir}/%{target}/include
+make %{?_smp_mflags} -C %{kerneldir} M=$(pwd)/linux
+
+%install
+rm -rf %{buildroot}
+make install -C pmd DESTDIR=%{buildroot} libdir=%{_libdir} docdir=%{docdir}
+make modules_install -C %{kerneldir} M=$(pwd)/linux 
INSTALL_MOD_PATH=%{buildroot}
+rm -f %{buildroot}%{modroot}/modules.*
+
+%files -n dpdk-memnic
+%{_libdir}/*
+%doc %{docdir}
+
+%files kmod
+%{moddir}/*
-- 
1.7.10.4

[dpdk-dev] Sending modified pcap packets from pktgen.

[Banashankar KV]

Hi,
I am trying to send out modified pcap packets in a loop as shown below.I am
trying to modify source IP and source port.

for each *packet[12 in number]*
for each *sip[2 in number]*
for each *port[10 in number]*
change to *port *and *sip *in *packet*
ret = rte_eth_tx_burst(.)

For the 6th packet, 80% of the  packets sent out are same wrong packet and
other time i see the same other packet 2-3 times instead of the correct
packet. But if I place a breakpoint and send the packets one after the
other, all the packets have their respective modified port and source IP.
I am not able to figure out why it's behaving like this.
is there any caching of the packets or something like that?
In rte_mempool_create I see  its passing 0 for cache size.


Thanks
Banashankar