[GitHub] [incubator-doris] imay opened a new pull request #1162: Add support column reference in LOAD statement
imay opened a new pull request #1162: Add support column reference in LOAD statement URL: https://github.com/apache/incubator-doris/pull/1162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1162: Add support column reference in LOAD statement
EmmyMiao87 commented on a change in pull request #1162: Add support column reference in LOAD statement URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284153537 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -198,7 +198,7 @@ terminal String KW_ADD, KW_ADMIN, KW_AFTER, KW_AGGREGATE, KW_ALL, KW_ALTER, KW_A KW_DATA, KW_DATABASE, KW_DATABASES, KW_DATE, KW_DATETIME, KW_DECIMAL, KW_DECOMMISSION, KW_DEFAULT, KW_DESC, KW_DESCRIBE, KW_DELETE, KW_DISTINCT, KW_DISTINCTPC, KW_DISTINCTPCSA, KW_DISTRIBUTED, KW_DISTRIBUTION, KW_BUCKETS, KW_DIV, KW_DOUBLE, KW_DROP, KW_DROPP, KW_DUPLICATE, KW_ELSE, KW_END, KW_ENGINE, KW_ENGINES, KW_ENTER, KW_ERRORS, KW_EVENTS, KW_EXISTS, KW_EXPORT, KW_EXTERNAL, KW_EXTRACT, -KW_FALSE, KW_FOLLOWER, KW_FOLLOWING, KW_FREE, KW_FROM, KW_FIRST, KW_FLOAT, KW_FOR, KW_FRONTEND, KW_FRONTENDS, KW_FULL, KW_FUNCTION, +KW_FALSE, KW_FOLLOWER, KW_FOLLOWING, KW_FREE, KW_FROM, KW_FIRST, KW_FLOAT, KW_FOR, KW_FORMAT, KW_FRONTEND, KW_FRONTENDS, KW_FULL, KW_FUNCTION, Review comment: you need to add the kw_format into keyword which we allow for identifiers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1162: Add support column reference in LOAD statement
EmmyMiao87 commented on a change in pull request #1162: Add support column
reference in LOAD statement
URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284156312
##
File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java
##
@@ -216,6 +244,12 @@ private void checkColumnMapping() throws
AnalysisException {
parsedExprMap.put(column, child1);
+if (!(child1 instanceof FunctionCallExpr)) {
+// only just for pass later check
+columnToFunction.put(column, Pair.create("__slot_ref",
Lists.newArrayList()));
Review comment:
```suggestion
columnToFunction.put(column, Pair.create("slot_ref",
Lists.newArrayList()));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1162: Add support column reference in LOAD statement
EmmyMiao87 commented on a change in pull request #1162: Add support column
reference in LOAD statement
URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284158524
##
File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroup.java
##
@@ -129,10 +131,13 @@ public void parse(Database db) throws DdlException {
if (lineDelimiter == null) {
lineDelimiter = "\n";
}
+
+fileFormat = dataDescription.getFileFormat();
+
isNegative = dataDescription.isNegative();
// FilePath
-filePathes = dataDescription.getFilePathes();
+filePaths = dataDescription.getFilePathes();
Review comment:
```suggestion
filePaths = dataDescription.getFilePaths();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1163: Add some logs for compaction process
morningman opened a new pull request #1163: Add some logs for compaction process URL: https://github.com/apache/incubator-doris/pull/1163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #1163: Add some logs for compaction process
morningman closed pull request #1163: Add some logs for compaction process URL: https://github.com/apache/incubator-doris/pull/1163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1163: Add some logs for compaction process
morningman opened a new pull request #1163: Add some logs for compaction process URL: https://github.com/apache/incubator-doris/pull/1163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1164: Modify dockerfile
morningman opened a new pull request #1164: Modify dockerfile URL: https://github.com/apache/incubator-doris/pull/1164 New docker image includes new thirdparties This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #1164: Modify dockerfile
imay merged pull request #1164: Modify dockerfile URL: https://github.com/apache/incubator-doris/pull/1164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #1162: Add support column reference in LOAD statement
imay commented on a change in pull request #1162: Add support column reference
in LOAD statement
URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284191766
##
File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroup.java
##
@@ -129,10 +131,13 @@ public void parse(Database db) throws DdlException {
if (lineDelimiter == null) {
lineDelimiter = "\n";
}
+
+fileFormat = dataDescription.getFileFormat();
+
isNegative = dataDescription.isNegative();
// FilePath
-filePathes = dataDescription.getFilePathes();
+filePaths = dataDescription.getFilePathes();
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #1162: Add support column reference in LOAD statement
imay commented on a change in pull request #1162: Add support column reference in LOAD statement URL: https://github.com/apache/incubator-doris/pull/1162#discussion_r284191640 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -198,7 +198,7 @@ terminal String KW_ADD, KW_ADMIN, KW_AFTER, KW_AGGREGATE, KW_ALL, KW_ALTER, KW_A KW_DATA, KW_DATABASE, KW_DATABASES, KW_DATE, KW_DATETIME, KW_DECIMAL, KW_DECOMMISSION, KW_DEFAULT, KW_DESC, KW_DESCRIBE, KW_DELETE, KW_DISTINCT, KW_DISTINCTPC, KW_DISTINCTPCSA, KW_DISTRIBUTED, KW_DISTRIBUTION, KW_BUCKETS, KW_DIV, KW_DOUBLE, KW_DROP, KW_DROPP, KW_DUPLICATE, KW_ELSE, KW_END, KW_ENGINE, KW_ENGINES, KW_ENTER, KW_ERRORS, KW_EVENTS, KW_EXISTS, KW_EXPORT, KW_EXTERNAL, KW_EXTRACT, -KW_FALSE, KW_FOLLOWER, KW_FOLLOWING, KW_FREE, KW_FROM, KW_FIRST, KW_FLOAT, KW_FOR, KW_FRONTEND, KW_FRONTENDS, KW_FULL, KW_FUNCTION, +KW_FALSE, KW_FOLLOWER, KW_FOLLOWING, KW_FREE, KW_FROM, KW_FIRST, KW_FLOAT, KW_FOR, KW_FORMAT, KW_FRONTEND, KW_FRONTENDS, KW_FULL, KW_FUNCTION, Review comment: Yes, you are right This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #1163: Add some logs for compaction process
morningman merged pull request #1163: Add some logs for compaction process URL: https://github.com/apache/incubator-doris/pull/1163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #1162: Add support column reference in LOAD statement
imay merged pull request #1162: Add support column reference in LOAD statement URL: https://github.com/apache/incubator-doris/pull/1162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new issue #1165: Routine load task thread block in BE
morningman opened a new issue #1165: Routine load task thread block in BE URL: https://github.com/apache/incubator-doris/issues/1165 **Describe the bug** Routine load task thread block, and following tasks can not be scheduled. **How to resolve** Data consumer group should wait all data consumers to be finished before return This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #1166: Fix bug that routine load task may be blocked due to premature deconstruction
morningman opened a new pull request #1166: Fix bug that routine load task may be blocked due to premature deconstruction URL: https://github.com/apache/incubator-doris/pull/1166 ISSUE: #1165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #1166: Fix bug that routine load task may be blocked due to premature deconstruction
morningman commented on a change in pull request #1166: Fix bug that routine
load task may be blocked due to premature deconstruction
URL: https://github.com/apache/incubator-doris/pull/1166#discussion_r284560064
##
File path: be/src/runtime/routine_load/routine_load_task_executor.cpp
##
@@ -41,6 +41,11 @@ Status RoutineLoadTaskExecutor::submit_task(const
TRoutineLoadTask& task) {
return Status::OK;
}
+if (_thread_pool.get_queue_size() > 100) {
+LOG(INFO) << "too much task in queue: " <<
_thread_pool.get_queue_size() << ", reject task: " << UniqueId(task.id);
Review comment:
```suggestion
LOG(INFO) << "too many tasks in queue: " <<
_thread_pool.get_queue_size() << ", reject task: " << UniqueId(task.id);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
