[GitHub] morningman closed pull request #414: Fix compile failure in RLTaskTxnCommitAttachment

2018-12-11 Thread GitBox 
morningman closed pull request #414: Fix compile failure in 
RLTaskTxnCommitAttachment
URL: https://github.com/apache/incubator-doris/pull/414
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/fe/src/main/java/org/apache/doris/load/routineload/RLTaskTxnCommitAttachment.java
 
b/fe/src/main/java/org/apache/doris/load/routineload/RLTaskTxnCommitAttachment.java
index e35d88a4..71f58a0a 100644
--- 
a/fe/src/main/java/org/apache/doris/load/routineload/RLTaskTxnCommitAttachment.java
+++ 
b/fe/src/main/java/org/apache/doris/load/routineload/RLTaskTxnCommitAttachment.java
@@ -19,7 +19,6 @@
 
 import org.apache.doris.common.io.Text;
 import org.apache.doris.thrift.TRLTaskTxnCommitAttachment;
-import org.apache.doris.thrift.TRoutineLoadTaskTxnExtra;
 import org.apache.doris.transaction.TxnCommitAttachment;
 
 import java.io.DataInput;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

[GitHub] lide-reed opened a new pull request #415: Fix compile error in run-fe-ut.sh

2018-12-11 Thread GitBox 
lide-reed opened a new pull request #415: Fix compile error in run-fe-ut.sh
URL: https://github.com/apache/incubator-doris/pull/415
 
 
   1. Fix JMX link error when compiling by run-fe-ut.sh.
   2. Fix build error of run-ut.sh.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

[GitHub] morningman closed pull request #415: Fix compile error in run-fe-ut.sh

2018-12-11 Thread GitBox 
morningman closed pull request #415: Fix compile error in run-fe-ut.sh
URL: https://github.com/apache/incubator-doris/pull/415
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index e4c94e94..45664813 100644
--- a/README.md
+++ b/README.md
@@ -79,14 +79,14 @@ GCC 5.3.1+, Oracle JDK 1.8+, Python 2.7+, Apache Maven 
3.5+, CMake 3.4.3+
 * For Ubuntu: 
 
 ```
-sudo apt-get install g++ ant cmake zip byacc flex automake libtool 
binutils-dev libiberty-dev bison python2.7 libncurses5-dev
+sudo apt-get install g++ cmake zip byacc flex automake libtool binutils-dev 
libiberty-dev bison python2.7 libncurses5-dev
 sudo updatedb
 ```
 
 * For CentOS:
 
 ```
-sudo yum install gcc-c++ libstdc++-static ant cmake byacc flex automake 
libtool binutils-devel bison ncurses-devel
+sudo yum install gcc-c++ libstdc++-static cmake byacc flex automake libtool 
binutils-devel bison ncurses-devel
 sudo updatedb
 ```
 
@@ -96,7 +96,7 @@ If your GCC version is less than 5.3.1, you can run:
 sudo yum install devtoolset-4-toolchain -y
 ```
 
-and then, set the path of gcc (e.g /opt/rh/devtoolset-4/root/usr/bin) to the 
environment variabl PATH.
+and then, set the path of GCC (e.g /opt/rh/devtoolset-4/root/usr/bin) to the 
environment variable PATH.
 
 
  Compile and install
diff --git 
a/fe/src/test/java/org/apache/doris/analysis/CancelAlterStmtTest.java 
b/fe/src/test/java/org/apache/doris/analysis/CancelAlterStmtTest.java
index 7456dfa1..b5c3c592 100644
--- a/fe/src/test/java/org/apache/doris/analysis/CancelAlterStmtTest.java
+++ b/fe/src/test/java/org/apache/doris/analysis/CancelAlterStmtTest.java
@@ -36,7 +36,7 @@
 import org.powermock.modules.junit4.PowerMockRunner;
 
 @RunWith(PowerMockRunner.class)
-@PowerMockIgnore("org.apache.log4j.*")
+@PowerMockIgnore({ "org.apache.log4j.*", "javax.management.*" })
 @PrepareForTest({ Catalog.class, ConnectContext.class })
 public class CancelAlterStmtTest {
 
diff --git a/fe/src/test/java/org/apache/doris/analysis/DescribeStmtTest.java 
b/fe/src/test/java/org/apache/doris/analysis/DescribeStmtTest.java
index b8c7c121..01a40a44 100644
--- a/fe/src/test/java/org/apache/doris/analysis/DescribeStmtTest.java
+++ b/fe/src/test/java/org/apache/doris/analysis/DescribeStmtTest.java
@@ -33,7 +33,7 @@
 import org.powermock.modules.junit4.PowerMockRunner;
 
 @RunWith(PowerMockRunner.class)
-@PowerMockIgnore("org.apache.log4j.*")
+@PowerMockIgnore({ "org.apache.log4j.*", "javax.management.*" })
 @PrepareForTest({ Catalog.class, ConnectContext.class })
 public class DescribeStmtTest {
 private Analyzer analyzer;
@@ -79,4 +79,4 @@ public void testAllNormal() throws AnalysisException, 
UserException {
 Assert.assertEquals("testCluster:testDb", stmt.getDb());
 Assert.assertEquals("testTbl", stmt.getTableName());
 }
-}
\ No newline at end of file
+}
diff --git a/fe/src/test/java/org/apache/doris/analysis/ShowAlterStmtTest.java 
b/fe/src/test/java/org/apache/doris/analysis/ShowAlterStmtTest.java
index 53468920..1260f23f 100644
--- a/fe/src/test/java/org/apache/doris/analysis/ShowAlterStmtTest.java
+++ b/fe/src/test/java/org/apache/doris/analysis/ShowAlterStmtTest.java
@@ -33,7 +33,7 @@
 import org.powermock.modules.junit4.PowerMockRunner;
 
 @RunWith(PowerMockRunner.class)
-@PowerMockIgnore("org.apache.log4j.*")
+@PowerMockIgnore({ "org.apache.log4j.*", "javax.management.*" })
 @PrepareForTest(Catalog.class)
 public class ShowAlterStmtTest {
 private Analyzer analyzer;
@@ -86,4 +86,4 @@ public void testNoDb() throws UserException, 
AnalysisException {
 stmt.analyze(analyzer);
 Assert.fail("No exception throws.");
 }
-}
\ No newline at end of file
+}
diff --git a/fe/src/test/java/org/apache/doris/analysis/ShowLoadStmtTest.java 
b/fe/src/test/java/org/apache/doris/analysis/ShowLoadStmtTest.java
index d0627c9b..cb48c206 100644
--- a/fe/src/test/java/org/apache/doris/analysis/ShowLoadStmtTest.java
+++ b/fe/src/test/java/org/apache/doris/analysis/ShowLoadStmtTest.java
@@ -34,7 +34,7 @@
 import org.powermock.modules.junit4.PowerMockRunner;
 
 @RunWith(PowerMockRunner.class)
-@PowerMockIgnore("org.apache.log4j.*")
+@PowerMockIgnore({ "org.apache.log4j.*", "javax.management.*" })
 @PrepareForTest(Catalog.class)
 public class ShowLoadStmtTest {
 private Analyzer analyzer;
@@ -86,4 +86,4 @@ public void testNoDb() throws UserException, 
AnalysisException {
 stmt.analyze(analyzer);
 Assert.fail("No exception throws.");
 }
-}
\ No newline at end of file
+}
diff --git a/fe/src/test/java/org/apache/doris/catalog/BackendTest.java 
b/fe/src/test/java/org/apache/doris/catalog/BackendTest.java
index 9177b1fd..f07d1dbf 100644
--- a/fe/src/test/java/org/apache/doris/catalog/BackendTest.java
+++ b/f

[VOTE] Release Apache Doris 0.9.0-incubating-rc01

2018-12-11 Thread 德 李 
Hi All,

I've prepared a release for 0.9.0-rc01.

The source code can be found at:
https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
/apache-doris-0.9.0.rc01-incubating-src.tar.gz

The release candidate has been tagged in GitHub as 0.9.0-rc01, available
here:
https://github.com/apache/incubator-doris/releases/tag/0.9.0-rc01

Thanks to everyone who has contributed to this release, and the release
notes can be found here:
https://github.com/apache/incubator-doris/issues/406

The SHA-512 checksum is:
c376d90785e92941164e8ab479362f19c17091f59ea658e4e7bab31748352457c5ad9606fb03
e263ce3e5542839364925cae5132c9baf2b41d5030f40a55ed5a
which can can be found via:
https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
/apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512

The signature can be found via:
https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
/apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc

KEYS file is available here:
https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS

Please vote on releasing this package as Apache Doris 0.9.0-incubating.

The vote will be open for at least 72 hours.
[ ] +1 Approve the release
[ ] +0 No opinion 
[ ] -1 Do not release this package because ...

Checklist for reference:
[ ] Download links are valid.
[ ] Checksums and PGP signatures are valid.
[ ] DISCLAIMER is included.
[ ] Source code artifacts have correct names matching the current release.
[ ] LICENSE and NOTICE files are correct for each OpenWhisk repository.
[ ] All files have license headers if necessary.
[ ] No compiled archives bundled in source archive.


Best Regards,
Reed

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2018-12-11 Thread Zhao Chun 
+1
Good job, thank you Reed.

Thanks,
ZHAO Chun



德 李  于2018年12月11日周二 下午7:16写道：

> Hi All,
>
> I've prepared a release for 0.9.0-rc01.
>
> The source code can be found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> /apache-doris-0.9.0.rc01-incubating-src.tar.gz
> 
>
> The release candidate has been tagged in GitHub as 0.9.0-rc01, available
> here:
> https://github.com/apache/incubator-doris/releases/tag/0.9.0-rc01
>
> Thanks to everyone who has contributed to this release, and the release
> notes can be found here:
> https://github.com/apache/incubator-doris/issues/406
>
> The SHA-512 checksum is:
>
> c376d90785e92941164e8ab479362f19c17091f59ea658e4e7bab31748352457c5ad9606fb03
> e263ce3e5542839364925cae5132c9baf2b41d5030f40a55ed5a
> which can can be found via:
>
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> /apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512
> 
>
> The signature can be found via:
>
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> /apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc
> 
>
> KEYS file is available here:
> https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS
>
> Please vote on releasing this package as Apache Doris 0.9.0-incubating.
>
> The vote will be open for at least 72 hours.
> [ ] +1 Approve the release
> [ ] +0 No opinion
> [ ] -1 Do not release this package because ...
>
> Checklist for reference:
> [ ] Download links are valid.
> [ ] Checksums and PGP signatures are valid.
> [ ] DISCLAIMER is included.
> [ ] Source code artifacts have correct names matching the current release.
> [ ] LICENSE and NOTICE files are correct for each OpenWhisk repository.
> [ ] All files have license headers if necessary.
> [ ] No compiled archives bundled in source archive.
>
>
> Best Regards,
> Reed
>
>
>
>

[GitHub] yiguolei opened a new pull request #416: Move txn related task to txn manager

2018-12-11 Thread GitBox 
yiguolei opened a new pull request #416: Move txn related task to txn manager
URL: https://github.com/apache/incubator-doris/pull/416
 
 
   move txn related task from storage engine to txn manager


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

[GitHub] chaoyli commented on a change in pull request #416: Move txn related task to txn manager

2018-12-11 Thread GitBox 
chaoyli commented on a change in pull request #416: Move txn related task to 
txn manager
URL: https://github.com/apache/incubator-doris/pull/416#discussion_r240595515
 
 

 ##
 File path: be/src/olap/storage_engine.cpp
 ##
 @@ -918,95 +918,36 @@ OLAPStatus StorageEngine::add_tablet(TTabletId 
tablet_id, SchemaHash schema_hash
 OLAPStatus StorageEngine::add_transaction(
 
 Review comment:
   transaction and txn is the same. Using one variable name may be better. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Re:[VOTE] Release Apache Doris 0.9.0-incubating-rc01

2018-12-11 Thread 陈明雨 
+1 Good work!





--
此致！Best Regards
陈明雨 Mingyu Chen

Email:
morning...@163.com;
morningman@gmail.com



At 2018-12-11 19:15:56, "德 李"  wrote:
>Hi All,
>
>I've prepared a release for 0.9.0-rc01.
>
>The source code can be found at:
>https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
>/apache-doris-0.9.0.rc01-incubating-src.tar.gz
>
>The release candidate has been tagged in GitHub as 0.9.0-rc01, available
>here:
>https://github.com/apache/incubator-doris/releases/tag/0.9.0-rc01
>
>Thanks to everyone who has contributed to this release, and the release
>notes can be found here:
>https://github.com/apache/incubator-doris/issues/406
>
>The SHA-512 checksum is:
>c376d90785e92941164e8ab479362f19c17091f59ea658e4e7bab31748352457c5ad9606fb03
>e263ce3e5542839364925cae5132c9baf2b41d5030f40a55ed5a
>which can can be found via:
>https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
>/apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512
>
>The signature can be found via:
>https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
>/apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc
>
>KEYS file is available here:
>https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS
>
>Please vote on releasing this package as Apache Doris 0.9.0-incubating.
>
>The vote will be open for at least 72 hours.
>[ ] +1 Approve the release
>[ ] +0 No opinion 
>[ ] -1 Do not release this package because ...
>
>Checklist for reference:
>[ ] Download links are valid.
>[ ] Checksums and PGP signatures are valid.
>[ ] DISCLAIMER is included.
>[ ] Source code artifacts have correct names matching the current release.
>[ ] LICENSE and NOTICE files are correct for each OpenWhisk repository.
>[ ] All files have license headers if necessary.
>[ ] No compiled archives bundled in source archive.
>
>
>Best Regards,
>Reed
>
>
>

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2018-12-11 Thread Li,Chaoyong 
+1
Excellent Job. 

Thanks. 
Li Chaoyong

在 2018/12/11 下午8:00，“Zhao Chun” 写入:

+1
Good job, thank you Reed.

Thanks,
ZHAO Chun



德 李  于2018年12月11日周二 下午7:16写道：

> Hi All,
>
> I've prepared a release for 0.9.0-rc01.
>
> The source code can be found at:
>
> 
https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> /apache-doris-0.9.0.rc01-incubating-src.tar.gz
> 

>
> The release candidate has been tagged in GitHub as 0.9.0-rc01, available
> here:
> https://github.com/apache/incubator-doris/releases/tag/0.9.0-rc01
>
> Thanks to everyone who has contributed to this release, and the release
> notes can be found here:
> https://github.com/apache/incubator-doris/issues/406
>
> The SHA-512 checksum is:
>
> 
c376d90785e92941164e8ab479362f19c17091f59ea658e4e7bab31748352457c5ad9606fb03
> e263ce3e5542839364925cae5132c9baf2b41d5030f40a55ed5a
> which can can be found via:
>
> 
https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> /apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512
> 

>
> The signature can be found via:
>
> 
https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> /apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc
> 

>
> KEYS file is available here:
> https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS
>
> Please vote on releasing this package as Apache Doris 0.9.0-incubating.
>
> The vote will be open for at least 72 hours.
> [ ] +1 Approve the release
> [ ] +0 No opinion
> [ ] -1 Do not release this package because ...
>
> Checklist for reference:
> [ ] Download links are valid.
> [ ] Checksums and PGP signatures are valid.
> [ ] DISCLAIMER is included.
> [ ] Source code artifacts have correct names matching the current release.
> [ ] LICENSE and NOTICE files are correct for each OpenWhisk repository.
> [ ] All files have license headers if necessary.
> [ ] No compiled archives bundled in source archive.
>
>
> Best Regards,
> Reed
>
>
>
>

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2018-12-11 Thread Willem Jiang 
As the member of PPMC , we need to go through the checklist and post
the result instead of +1.
Please spend some time to verify the kit and build the source.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Tue, Dec 11, 2018 at 8:00 PM Zhao Chun  wrote:
>
> +1
> Good job, thank you Reed.
>
> Thanks,
> ZHAO Chun
>
>
>
> 德 李  于2018年12月11日周二 下午7:16写道：
>
> > Hi All,
> >
> > I've prepared a release for 0.9.0-rc01.
> >
> > The source code can be found at:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> > /apache-doris-0.9.0.rc01-incubating-src.tar.gz
> > 
> >
> > The release candidate has been tagged in GitHub as 0.9.0-rc01, available
> > here:
> > https://github.com/apache/incubator-doris/releases/tag/0.9.0-rc01
> >
> > Thanks to everyone who has contributed to this release, and the release
> > notes can be found here:
> > https://github.com/apache/incubator-doris/issues/406
> >
> > The SHA-512 checksum is:
> >
> > c376d90785e92941164e8ab479362f19c17091f59ea658e4e7bab31748352457c5ad9606fb03
> > e263ce3e5542839364925cae5132c9baf2b41d5030f40a55ed5a
> > which can can be found via:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> > /apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512
> > 
> >
> > The signature can be found via:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> > /apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc
> > 
> >
> > KEYS file is available here:
> > https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS
> >
> > Please vote on releasing this package as Apache Doris 0.9.0-incubating.
> >
> > The vote will be open for at least 72 hours.
> > [ ] +1 Approve the release
> > [ ] +0 No opinion
> > [ ] -1 Do not release this package because ...
> >
> > Checklist for reference:
> > [ ] Download links are valid.
> > [ ] Checksums and PGP signatures are valid.
> > [ ] DISCLAIMER is included.
> > [ ] Source code artifacts have correct names matching the current release.
> > [ ] LICENSE and NOTICE files are correct for each OpenWhisk repository.
> > [ ] All files have license headers if necessary.
> > [ ] No compiled archives bundled in source archive.
> >
> >
> > Best Regards,
> > Reed
> >
> >
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2018-12-11 Thread 德 李 
Hi, please verify this release, following checklist for reference:

1. [ ] Download links are valid.
2. [ ] Checksums and PGP signatures are valid.
3. [ ] DISCLAIMER is included.
4. [ ] Source code artifacts have correct names matching the current
release.
5. [ ] LICENSE and NOTICE files are correct for the repository.
6. [ ] All files have license headers if necessary.
7. [ ] No compiled archives bundled in source archive.
8. [ ] Building is OK.

For 2, the verify way is:

```
gpg --import KEYS
gpg --verify apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc
apache-doris-0.9.0.rc01-incubating-src.tar.gz
sha512sum --check apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512
```

For 6, the verify way is:

Given your source dir is apache-doris-0.9.0.rc01-incubating-src.

```
wget 
http://mirrors.shu.edu.cn/apache//creadur/apache-rat-0.12/apache-rat-0.12-b
in.tar.bz2
tar jxvf apache-rat-0.12-bin.tar.bz2
java -jar apache-rat-0.12/apache-rat-0.12.jar -a -d
apache-doris-0.9.0.rc01-incubating-src -e *.md *.MD .gitignore .gitmodules
.travis.yml manifest **vendor** **licenses** | grep File: | grep -v
"test_data" | grep -v "gutil" | grep -v "json" | grep -v "patch" | grep -v
"xml" | grep -v "conf" | grep -v "svg"
```

For 8, the building way is:

```
sh build.sh
```


Best Regards,
Reed


On 2018/12/12 上午10:21， "Willem Jiang"  wrote:

>As the member of PPMC , we need to go through the checklist and post
>the result instead of +1.
>Please spend some time to verify the kit and build the source.
>
>Willem Jiang
>
>Twitter: willemjiang
>Weibo: 姜宁willem
>
>On Tue, Dec 11, 2018 at 8:00 PM Zhao Chun  wrote:
>>
>> +1
>> Good job, thank you Reed.
>>
>> Thanks,
>> ZHAO Chun
>>
>>
>>
>> 德 李  于2018年12月11日周二 下午7:16写道：
>>
>> > Hi All,
>> >
>> > I've prepared a release for 0.9.0-rc01.
>> >
>> > The source code can be found at:
>> >
>> > 
>>https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-r
>>c01
>> > /apache-doris-0.9.0.rc01-incubating-src.tar.gz
>> > 
>>>rc01/apache-doris-0.9.0.rc01-incubating-src.tar.gz>
>> >
>> > The release candidate has been tagged in GitHub as 0.9.0-rc01,
>>available
>> > here:
>> > https://github.com/apache/incubator-doris/releases/tag/0.9.0-rc01
>> >
>> > Thanks to everyone who has contributed to this release, and the
>>release
>> > notes can be found here:
>> > https://github.com/apache/incubator-doris/issues/406
>> >
>> > The SHA-512 checksum is:
>> >
>> > 
>>c376d90785e92941164e8ab479362f19c17091f59ea658e4e7bab31748352457c5ad9606f
>>b03
>> > e263ce3e5542839364925cae5132c9baf2b41d5030f40a55ed5a
>> > which can can be found via:
>> >
>> > 
>>https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-r
>>c01
>> > /apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512
>> > 
>>>rc01/apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512>
>> >
>> > The signature can be found via:
>> >
>> > 
>>https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-r
>>c01
>> > /apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc
>> > 
>>>rc01/apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc>
>> >
>> > KEYS file is available here:
>> > https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS
>> >
>> > Please vote on releasing this package as Apache Doris
>>0.9.0-incubating.
>> >
>> > The vote will be open for at least 72 hours.
>> > [ ] +1 Approve the release
>> > [ ] +0 No opinion
>> > [ ] -1 Do not release this package because ...
>> >
>> > Checklist for reference:
>> > [ ] Download links are valid.
>> > [ ] Checksums and PGP signatures are valid.
>> > [ ] DISCLAIMER is included.
>> > [ ] Source code artifacts have correct names matching the current
>>release.
>> > [ ] LICENSE and NOTICE files are correct for each OpenWhisk
>>repository.
>> > [ ] All files have license headers if necessary.
>> > [ ] No compiled archives bundled in source archive.
>> >
>> >
>> > Best Regards,
>> > Reed
>> >
>> >
>> >
>> >
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
>For additional commands, e-mail: dev-h...@doris.apache.org
>



-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

[GitHub] chaoyli opened a new pull request #417: Fix compaction and ingestion core

2018-12-11 Thread GitBox 
chaoyli opened a new pull request #417: Fix compaction and ingestion core
URL: https://github.com/apache/incubator-doris/pull/417
 
 
   Error occurs when reading data by compaction and ingestion.
   Under the circumstance, the two operation should stop and return error.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

[GitHub] imay closed pull request #417: Fix compaction and ingestion core

2018-12-11 Thread GitBox 
imay closed pull request #417: Fix compaction and ingestion core
URL: https://github.com/apache/incubator-doris/pull/417
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/be/src/olap/merger.cpp b/be/src/olap/merger.cpp
index 3a84b0b8..dfb425d2 100644
--- a/be/src/olap/merger.cpp
+++ b/be/src/olap/merger.cpp
@@ -106,6 +106,11 @@ OLAPStatus Merger::merge(const vector& 
olap_data_arr,
 ++_row_count;
 }
 
+if (has_error) {
+LOG(WARNING) << "base compaction failed.";
+return OLAP_ERR_OTHER_ERROR;
+}
+
 if (OLAP_SUCCESS != writer->finalize()) {
 OLAP_LOG_WARNING("fail to finalize writer. [table='%s']",
 _table->full_name().c_str());
diff --git a/be/src/olap/push_handler.cpp b/be/src/olap/push_handler.cpp
index a51c7950..9bfaa266 100644
--- a/be/src/olap/push_handler.cpp
+++ b/be/src/olap/push_handler.cpp
@@ -664,6 +664,11 @@ OLAPStatus PushHandler::_convert(
 }
 }
 
+if (res != OLAP_SUCCESS) {
+LOG(WARNING) << "ingest data failed. res" << res;
+break;
+}
+
 if (OLAP_SUCCESS != (res = writer->finalize())) {
 OLAP_LOG_WARNING("fail to finalize writer. [res=%d]", res);
 break;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

[GitHub] yiguolei commented on a change in pull request #416: Move txn related task to txn manager

2018-12-11 Thread GitBox 
yiguolei commented on a change in pull request #416: Move txn related task to 
txn manager
URL: https://github.com/apache/incubator-doris/pull/416#discussion_r240887282
 
 

 ##
 File path: be/src/olap/storage_engine.cpp
 ##
 @@ -918,95 +918,36 @@ OLAPStatus StorageEngine::add_tablet(TTabletId 
tablet_id, SchemaHash schema_hash
 OLAPStatus StorageEngine::add_transaction(
 
 Review comment:
   transaction related method in storage engine will be removed in the future. 
They will be replaced with create_xxx_task. Txn related method will not be 
called outside.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Re: [VOTE] Release Apache Doris 0.9.0-incubating-rc01

2018-12-11 Thread Zhao Chun 
Thank Willem for your advise.

+1

I checked:
1. download links are valid.
2. building is OK, running unit test is OK too
3. DISCLAIMER is included
4. checksum and signatures are valid
5. all source files have ASF like headers
6. compiled archives not found


Thanks,
ZHAO Chun



Willem Jiang  于2018年12月12日周三 上午10:21写道：

> As the member of PPMC , we need to go through the checklist and post
> the result instead of +1.
> Please spend some time to verify the kit and build the source.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Tue, Dec 11, 2018 at 8:00 PM Zhao Chun  wrote:
> >
> > +1
> > Good job, thank you Reed.
> >
> > Thanks,
> > ZHAO Chun
> >
> >
> >
> > 德 李  于2018年12月11日周二 下午7:16写道：
> >
> > > Hi All,
> > >
> > > I've prepared a release for 0.9.0-rc01.
> > >
> > > The source code can be found at:
> > >
> > >
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> > > /apache-doris-0.9.0.rc01-incubating-src.tar.gz
> > > <
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01/apache-doris-0.9.0.rc01-incubating-src.tar.gz
> >
> > >
> > > The release candidate has been tagged in GitHub as 0.9.0-rc01,
> available
> > > here:
> > > https://github.com/apache/incubator-doris/releases/tag/0.9.0-rc01
> > >
> > > Thanks to everyone who has contributed to this release, and the release
> > > notes can be found here:
> > > https://github.com/apache/incubator-doris/issues/406
> > >
> > > The SHA-512 checksum is:
> > >
> > >
> c376d90785e92941164e8ab479362f19c17091f59ea658e4e7bab31748352457c5ad9606fb03
> > > e263ce3e5542839364925cae5132c9baf2b41d5030f40a55ed5a
> > > which can can be found via:
> > >
> > >
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> > > /apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512
> > > <
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01/apache-doris-0.9.0.rc01-incubating-src.tar.gz.sha512
> >
> > >
> > > The signature can be found via:
> > >
> > >
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01
> > > /apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc
> > > <
> https://dist.apache.org/repos/dist/dev/incubator/doris/0.9.0-incubating-rc01/apache-doris-0.9.0.rc01-incubating-src.tar.gz.asc
> >
> > >
> > > KEYS file is available here:
> > > https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS
> > >
> > > Please vote on releasing this package as Apache Doris 0.9.0-incubating.
> > >
> > > The vote will be open for at least 72 hours.
> > > [ ] +1 Approve the release
> > > [ ] +0 No opinion
> > > [ ] -1 Do not release this package because ...
> > >
> > > Checklist for reference:
> > > [ ] Download links are valid.
> > > [ ] Checksums and PGP signatures are valid.
> > > [ ] DISCLAIMER is included.
> > > [ ] Source code artifacts have correct names matching the current
> release.
> > > [ ] LICENSE and NOTICE files are correct for each OpenWhisk repository.
> > > [ ] All files have license headers if necessary.
> > > [ ] No compiled archives bundled in source archive.
> > >
> > >
> > > Best Regards,
> > > Reed
> > >
> > >
> > >
> > >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
> For additional commands, e-mail: dev-h...@doris.apache.org
>
>

[GitHub] chaoyli opened a new pull request #418: Fix compaction and ingestion core

2018-12-11 Thread GitBox 
chaoyli opened a new pull request #418: Fix compaction and ingestion core
URL: https://github.com/apache/incubator-doris/pull/418
 
 
   Error occurs when reading data by compaction and ingestion.
   Under the circumstance, the two operation should stop and return error.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

[GitHub] chaoyli closed pull request #418: Fix compaction and ingestion core

2018-12-11 Thread GitBox 
chaoyli closed pull request #418: Fix compaction and ingestion core
URL: https://github.com/apache/incubator-doris/pull/418
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/be/src/olap/merger.cpp b/be/src/olap/merger.cpp
index 3a84b0b8..dfb425d2 100644
--- a/be/src/olap/merger.cpp
+++ b/be/src/olap/merger.cpp
@@ -106,6 +106,11 @@ OLAPStatus Merger::merge(const vector& 
olap_data_arr,
 ++_row_count;
 }
 
+if (has_error) {
+LOG(WARNING) << "base compaction failed.";
+return OLAP_ERR_OTHER_ERROR;
+}
+
 if (OLAP_SUCCESS != writer->finalize()) {
 OLAP_LOG_WARNING("fail to finalize writer. [table='%s']",
 _table->full_name().c_str());
diff --git a/be/src/olap/push_handler.cpp b/be/src/olap/push_handler.cpp
index a51c7950..9bfaa266 100644
--- a/be/src/olap/push_handler.cpp
+++ b/be/src/olap/push_handler.cpp
@@ -664,6 +664,11 @@ OLAPStatus PushHandler::_convert(
 }
 }
 
+if (res != OLAP_SUCCESS) {
+LOG(WARNING) << "ingest data failed. res" << res;
+break;
+}
+
 if (OLAP_SUCCESS != (res = writer->finalize())) {
 OLAP_LOG_WARNING("fail to finalize writer. [res=%d]", res);
 break;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

[GitHub] chaoyli closed pull request #416: Move txn related task to txn manager

2018-12-11 Thread GitBox 
chaoyli closed pull request #416: Move txn related task to txn manager
URL: https://github.com/apache/incubator-doris/pull/416
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/be/src/olap/CMakeLists.txt b/be/src/olap/CMakeLists.txt
index eb4a42ba..a61b7f19 100644
--- a/be/src/olap/CMakeLists.txt
+++ b/be/src/olap/CMakeLists.txt
@@ -80,6 +80,7 @@ add_library(Olap STATIC
 tablet.cpp
 tablet_meta.cpp
 tablet_meta_manager.cpp
+txn_manager.cpp
 types.cpp 
 utils.cpp
 wrapper_field.cpp
diff --git a/be/src/olap/storage_engine.cpp b/be/src/olap/storage_engine.cpp
index 49846b78..de2ad46c 100644
--- a/be/src/olap/storage_engine.cpp
+++ b/be/src/olap/storage_engine.cpp
@@ -117,7 +117,8 @@ StorageEngine::StorageEngine(const EngineOptions& options)
 _tablet_stat_cache_update_time_ms(0),
 _snapshot_base_id(0),
 _is_report_disk_state_already(false),
-_is_report_tablet_already(false) {
+_is_report_tablet_already(false),
+_txn_mgr() {
 if (_s_instance == nullptr) {
 _s_instance = this;
 }
@@ -747,7 +748,6 @@ OLAPStatus StorageEngine::clear() {
 SAFE_DELETE(_index_stream_lru_cache);
 
 _tablet_map.clear();
-_transaction_tablet_map.clear();
 _global_tablet_id = 0;
 
 return OLAP_SUCCESS;
@@ -918,95 +918,36 @@ OLAPStatus StorageEngine::add_tablet(TTabletId tablet_id, 
SchemaHash schema_hash
 OLAPStatus StorageEngine::add_transaction(
 TPartitionId partition_id, TTransactionId transaction_id,
 TTabletId tablet_id, SchemaHash schema_hash, const PUniqueId& load_id) {
-
-pair key(partition_id, transaction_id);
-TabletInfo tablet_info(tablet_id, schema_hash);
-WriteLock wrlock(&_transaction_tablet_map_lock);
-auto it = _transaction_tablet_map.find(key);
-if (it != _transaction_tablet_map.end()) {
-auto load_info = it->second.find(tablet_info);
-if (load_info != it->second.end()) {
-for (PUniqueId& pid : load_info->second) {
-if (pid.hi() == load_id.hi() && pid.lo() == load_id.lo()) {
-LOG(WARNING) << "find transaction exists when add to 
engine."
-<< "partition_id: " << key.first
-<< ", transaction_id: " << key.second
-<< ", tablet: " << tablet_info.to_string();
-return OLAP_ERR_PUSH_TRANSACTION_ALREADY_EXIST;
-}
-}
-}
-}
-
-_transaction_tablet_map[key][tablet_info].push_back(load_id);
-VLOG(3) << "add transaction to engine successfully."
-<< "partition_id: " << key.first
-<< ", transaction_id: " << key.second
-<< ", tablet: " << tablet_info.to_string();
-return OLAP_SUCCESS;
+
+OLAPStatus status = _txn_mgr.add_txn(partition_id, transaction_id, 
+tablet_id, schema_hash, load_id);
+return status;
 }
 
 void StorageEngine::delete_transaction(
 TPartitionId partition_id, TTransactionId transaction_id,
 TTabletId tablet_id, SchemaHash schema_hash, bool delete_from_tablet) {
 
-pair key(partition_id, transaction_id);
-TabletInfo tablet_info(tablet_id, schema_hash);
-WriteLock wrlock(&_transaction_tablet_map_lock);
-
-auto it = _transaction_tablet_map.find(key);
-if (it != _transaction_tablet_map.end()) {
-VLOG(3) << "delete transaction to engine successfully."
-<< ",partition_id: " << key.first
-<< ", transaction_id: " << key.second
-<< ", tablet: " << tablet_info.to_string();
-it->second.erase(tablet_info);
-if (it->second.empty()) {
-_transaction_tablet_map.erase(it);
-}
-
-// delete transaction from tablet
-if (delete_from_tablet) {
-TabletSharedPtr tablet = get_tablet(tablet_info.tablet_id, 
tablet_info.schema_hash);
-if (tablet.get() != nullptr) {
-tablet->delete_pending_data(transaction_id);
-}
+// call txn manager to delete txn from memory
+OLAPStatus res = _txn_mgr.delete_txn(partition_id, transaction_id, 
+tablet_id, schema_hash);
+// delete transaction from tablet
+if (res == OLAP_SUCCESS && delete_from_tablet) {
+TabletSharedPtr tablet = get_tablet(tablet_id, schema_hash);
+if (tablet.get() != nullptr) {
+tablet->delete_pending_data(transaction_id);
 }
 }
 }
 
 void StorageEngine::get_transactions_by_tablet(TabletSharedPtr tablet, 
int64_t* partition_id,
 set* transaction_ids) {
-if (tablet.get() == nullptr || partition_id == nullptr || transaction_ids 
== nullptr) {
-OLAP_LOG_WARNING("par