Re: [PR] CXF-9085: Java features should be preferred to Guava [cxf]
ffang commented on PR #2160: URL: https://github.com/apache/cxf/pull/2160#issuecomment-2493827953 Hi @Riggs333 , We can't compile with your PR. Seems java.nio.file.Files.createTempDirectory method requires a parameter list while com.google.common.io.Files.createTempDir method doesn't. Do you mind revising your PR accordingly? Thanks! Freeman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.puppycrawl.tools:checkstyle from 10.18.2 to 10.20.1 [cxf]
reta merged PR #2159: URL: https://github.com/apache/cxf/pull/2159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update Apache HttpClient5 to 5.4.1 and Apache HttpCore5 to 5.3.1 [cxf]
reta merged PR #2161: URL: https://github.com/apache/cxf/pull/2161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump cxf.hibernate.em.version from 6.5.2.Final to 6.6.2.Final [cxf]
reta commented on PR #2157: URL: https://github.com/apache/cxf/pull/2157#issuecomment-2494569893 Should be addressed by https://github.com/apache/cxf/pull/2162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CXF-9085: Java features should be preferred to Guava [cxf]
Riggs333 commented on PR #2160: URL: https://github.com/apache/cxf/pull/2160#issuecomment-2494022541 I'm very sorry, @ffang, for my stupid mistake. 🤦🏻 I just pushed some changes, those were suggested by applying the OpenRewrite recipe: https://docs.openrewrite.org/recipes/java/migrate/guava/noguavacreatetempdir (The root of my mistake was this: The `mvn install` run on my local Linux machine with a fresh git checkout of the `main` branch was not running some tests successfully. Therefore I tried using the Github online codespaces IDE. With that I didn't see the compile error. I was very naive. 😓) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CXF-9085: Java features should be preferred to Guava [cxf]
ffang commented on PR #2160: URL: https://github.com/apache/cxf/pull/2160#issuecomment-2494050246 No worries @Riggs333 , the PR looks good to me now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CXF-9085: Java features should be preferred to Guava [cxf]
ffang merged PR #2160: URL: https://github.com/apache/cxf/pull/2160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
