Re: [PR] Upgrade jaxb runtime to 4.0.5 [cxf]
jimma commented on PR #2031: URL: https://github.com/apache/cxf/pull/2031#issuecomment-2314846129 It seems it's some javadoc wrong expectation issue in https://github.com/apache/cxf-xjc-utils/pull/135. Can we simply fix the JavadocPluginTest ? ``` ERROR] Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.933 s <<< FAILURE! -- in org.apache.cxf.xjc.javadoc.JavadocPluginTest [ERROR] org.apache.cxf.xjc.javadoc.JavadocPluginTest.testDocumentationOnPropertiesIsOverwrittenByJAXBBindings -- Time elapsed: 0.071 s <<< FAILURE! java.lang.AssertionError: Expected: not javadoc contains given comment: Some documentation of element but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:964) at org.junit.Assert.assertThat(Assert.java:930) at org.apache.cxf.xjc.javadoc.JavadocPluginTest.testDocumentationOnPropertiesIsOverwrittenByJAXBBindings(JavadocPluginTest.java:127) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-surefire-report-plugin from 3.3.1 to 3.5.0 [cxf]
reta merged PR #2032: URL: https://github.com/apache/cxf/pull/2032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-site-plugin from 3.12.1 to 3.20.0 [cxf]
reta merged PR #2033: URL: https://github.com/apache/cxf/pull/2033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade jaxb runtime to 4.0.5 [cxf]
reta commented on PR #2031: URL: https://github.com/apache/cxf/pull/2031#issuecomment-2315085414 > It seems it's some javadoc wrong expectation issue in [apache/cxf-xjc-utils#135](https://github.com/apache/cxf-xjc-utils/pull/135). Can we simply fix the JavadocPluginTest ? Correct, I briefly looked at the test case before, it expects some overrides to be respected, that was working fine pre-4.0.5 but breaks with new version. I will try to take a look shortly, thanks @jimma ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump jaxb-runtime-version from 4.0.3 to 4.0.5 [cxf-xjc-utils]
reta commented on code in PR #135:
URL: https://github.com/apache/cxf-xjc-utils/pull/135#discussion_r1735259964
##
javadoc/src/test/java/org/apache/cxf/xjc/javadoc/JavadocPluginTest.java:
##
@@ -124,11 +124,11 @@ public void
testDocumentationOnPropertiesIsOverwrittenByJAXBBindings() throws Ex
CompilationUnit compilationUnit =
parseSourceFile("ComplexTypeWithDocumentedProperties.java");
Javadoc fieldJavadoc = getJavadocOfField(compilationUnit,
"documentedElement");
-assertThat(fieldJavadoc, not(javadocContains("Some documentation of
element")));
+assertThat(fieldJavadoc, javadocContains("Some documentation of
element"));
Review Comment:
Seems like https://github.com/eclipse-ee4j/jaxb-ri/issues/1708 was fixed and
test needs adjustment now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump jaxb-runtime-version from 4.0.3 to 4.0.5 [cxf-xjc-utils]
reta merged PR #135: URL: https://github.com/apache/cxf-xjc-utils/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade jaxb runtime to 4.0.5 [cxf]
reta commented on PR #2031: URL: https://github.com/apache/cxf/pull/2031#issuecomment-2316216260 I think we should be good to go, I pinpointed the change in question and merged https://github.com/apache/cxf-xjc-utils/pull/135, thanks @jimma ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-jar-plugin from 3.4.1 to 3.4.2 [cxf-xjc-utils]
dependabot[bot] opened a new pull request, #158: URL: https://github.com/apache/cxf-xjc-utils/pull/158 Bumps [org.apache.maven.plugins:maven-jar-plugin](https://github.com/apache/maven-jar-plugin) from 3.4.1 to 3.4.2. Release notes Sourced from https://github.com/apache/maven-jar-plugin/releases";>org.apache.maven.plugins:maven-jar-plugin's releases. 3.4.2 ð Bug Fixes https://issues.apache.org/jira/browse/MJAR-310";>[MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces (https://redirect.github.com/apache/maven-jar-plugin/pull/86";>#86) https://github.com/jansohn";>@âjansohn ð» Maintenance Build with Maven 4 (https://redirect.github.com/apache/maven-jar-plugin/pull/88";>#88) https://github.com/slawekjaranowski";>@âslawekjaranowski Commits https://github.com/apache/maven-jar-plugin/commit/95007e86d205703d898aa0fb5d24ae3df0c25789";>95007e8 [maven-release-plugin] prepare release maven-jar-plugin-3.4.2 https://github.com/apache/maven-jar-plugin/commit/99584ce9cff9d87d73c12df81d40a982d75845ff";>99584ce Build with Maven 4 https://github.com/apache/maven-jar-plugin/commit/e9c98a4dd95b79088fe5264d3e5dbba1342ddb80";>e9c98a4 [MJAR-310] fixed toolchain version detection when toolchain paths contain whi... https://github.com/apache/maven-jar-plugin/commit/a5554bb21e9528b3f3dfa5b97473f2af99045e73";>a5554bb [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-jar-plugin/compare/maven-jar-plugin-3.4.1...maven-jar-plugin-3.4.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-jar-plugin from 3.4.1 to 3.4.2 [cxf-xjc-utils]
reta merged PR #158: URL: https://github.com/apache/cxf-xjc-utils/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-install-plugin from 3.1.2 to 3.1.3 [cxf]
dependabot[bot] opened a new pull request, #2034: URL: https://github.com/apache/cxf/pull/2034 Bumps [org.apache.maven.plugins:maven-install-plugin](https://github.com/apache/maven-install-plugin) from 3.1.2 to 3.1.3. Release notes Sourced from https://github.com/apache/maven-install-plugin/releases";>org.apache.maven.plugins:maven-install-plugin's releases. 3.1.3 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317524&version=12354620";>Release Notes - Maven Install Plugin - Version 3.1.3 What's Changed Build with Maven 4 by https://github.com/slawekjaranowski";>@âslawekjaranowski in https://redirect.github.com/apache/maven-install-plugin/pull/66";>apache/maven-install-plugin#66 [MINSTALL-203] Use parent POM 43 by https://github.com/cstamas";>@âcstamas in https://redirect.github.com/apache/maven-install-plugin/pull/83";>apache/maven-install-plugin#83 [MINSTALL-196] Consider packaging in install-file mojo by https://github.com/cstamas";>@âcstamas in https://redirect.github.com/apache/maven-install-plugin/pull/81";>apache/maven-install-plugin#81 Full Changelog: https://github.com/apache/maven-install-plugin/compare/maven-install-plugin-3.1.2...maven-install-plugin-3.1.3";>https://github.com/apache/maven-install-plugin/compare/maven-install-plugin-3.1.2...maven-install-plugin-3.1.3 Commits https://github.com/apache/maven-install-plugin/commit/8bc98ab2edd3254e48dd14b78a2cefd9f1e47e00";>8bc98ab [maven-release-plugin] prepare release maven-install-plugin-3.1.3 https://github.com/apache/maven-install-plugin/commit/e3fd8773049cb56c89e391334c843bb1a9acf9c2";>e3fd877 Remove deprecation warnings: https://github.com/apache/maven-install-plugin/commit/49abeeb34fe2926ea8496c2b5ec79633252f9555";>49abeeb [MINSTALL-196] Consider packaging in install-file mojo (https://redirect.github.com/apache/maven-install-plugin/issues/81";>#81) https://github.com/apache/maven-install-plugin/commit/30ca28e4d949d0aad99b9087e0819a915b79f838";>30ca28e [MINSTALL-203] Upgrade parent 43 (https://redirect.github.com/apache/maven-install-plugin/issues/83";>#83) https://github.com/apache/maven-install-plugin/commit/75955fbc4629909be07d947eba6f0fabbb8eef8f";>75955fb Build with Maven 4 https://github.com/apache/maven-install-plugin/commit/4fe1f05f40e42b7545b261907ad082e186fd2d4d";>4fe1f05 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-install-plugin/compare/maven-install-plugin-3.1.2...maven-install-plugin-3.1.3";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-plugin-plugin from 3.14.0 to 3.15.0 [cxf]
dependabot[bot] opened a new pull request, #2035: URL: https://github.com/apache/cxf/pull/2035 Bumps [org.apache.maven.plugins:maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.14.0 to 3.15.0. Commits https://github.com/apache/maven-plugin-tools/commit/8e22d5ad1d15edd45a4ceebce0e6dd0e018ddc6e";>8e22d5a [maven-release-plugin] prepare release maven-plugin-tools-3.15.0 https://github.com/apache/maven-plugin-tools/commit/663511476a041b2067b47d5b37e19baefab7cc2e";>6635114 [MPLUGIN-501] Upgrade to Doxia 2.0.0 Milestone Stack https://github.com/apache/maven-plugin-tools/commit/15206546e79d82a146fe009ac8c12831a0ed78c8";>1520654 [MPLUGIN-528] Tone done report plugin console output https://github.com/apache/maven-plugin-tools/commit/810a5bdd69c1ab8a1d87e22af0f0f78d083f3c33";>810a5bd Bump org.apache.maven:maven-parent from 42 to 43 https://github.com/apache/maven-plugin-tools/commit/e4c3aa5b764ed7b4298faba00db87a0453670275";>e4c3aa5 Bump org.hamcrest:hamcrest from 2.2 to 3.0 https://github.com/apache/maven-plugin-tools/commit/6ba823511188bd9e71f677655dcffef4b1ee1420";>6ba8235 [MPLUGIN-530] Deprecate o.a.m.plugins.annotations.Component https://github.com/apache/maven-plugin-tools/commit/f1acf76556e57632a36634f4ad683186786d4ed9";>f1acf76 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.14.0...maven-plugin-tools-3.15.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
