date:20221130

Re: CXF 4.0.0 jakarta release

2022-11-30 Thread Jim Ma

Thanks Andriy and Dan !

On Mon, Nov 28, 2022 at 10:28 PM Andrey Redko  wrote:

> Works for me, thanks a lot Dan!
>
> Best Regards,
> Andriy Redko
>
> On Mon, Nov 28, 2022, 8:45 AM Daniel Kulp  wrote:
>
> >
> > >
> > > I don't think anything blocking is left, +1 to move forward! @Colm @Dan
> > do
> > > we want to drop 4.0.0 only or make 3.4.x / 3.5.x releases as well? With
> > > 4.0.0 out and 3.6.0 getting ready to be out soon (hopefully), the 3.4.x
> > is
> > > approaching EOL quickly, could be the last release.
> >
> >
> > I was definitely planning on doing 3.4/3.5 releases sometime before the
> > end of the year.  Thus, we could do a full set of releases.   I have a
> > bunch of things happening this week, but would next Monday work for
> > everyone?  That would give a week to get any final updates in.
> >
> > Dan
> >
> >
> > >
> > > Thank you guys!
> > >
> > >
> > > Best Regards,
> > >Andriy Redko
> > >
> > > On Sun, Nov 27, 2022, 10:27 PM Jim Ma  wrote:
> > >
> > >> Hi Andriy,
> > >> Can we start the release work if there isn't the major thing left we
> > need
> > >> to include in CXF 4.0.0 release ?
> > >>
> > >> @Daniel Kulp  Can you please help do the release
> when
> > >> it's convenient for you?
> > >>
> > >> Thanks,
> > >> Jim
> > >>
> > >>
> > >>
> > >>
> > >> On Mon, Nov 14, 2022 at 1:18 PM Jean-Baptiste Onofré  >
> > >> wrote:
> > >>
> > >>> +1 to release 4.0.0 even partial release.
> > >>>
> > >>> Regards
> > >>> JB
> > >>>
> > >>> On Mon, Nov 7, 2022 at 9:19 AM Jim Ma  wrote:
> > 
> >  Hi all,
> >  After 9 months of work, we finally fixed/worked around all issues
> for
> >  Jakarta support. Now all the cxf tests are passed:
> >  https://ci-builds.apache.org/job/CXF/job/CXF-JDK17/848/ and we can
> > say
> > >>> that
> >  CXF successfully migrated to Jakarta namespace(and support Jakarta
> > >>> EE9.1).
> >  To get cxf jakarta artifacts/binary available for the CXF community
> >  especially the user who asked for this jakarta artifacts like [1]
> and
> > >>> get
> >  more feedback from our community, do you think it's time to release
> > the
> > >>> CXF
> >  4.0.0 and what else do you think we should have in this new jakarta
> > >>> release
> >  ?
> > 
> >  [1]https://lists.apache.org/thread/kwfg2s5gj72tkgn5c5vdcsvtgdkdm6dl
> > 
> >  Thanks,
> >  Jim
> > >>>
> > >>
> >
> > --
> > Daniel Kulp
> > dk...@apache.org 
> > Talend - https://talend.com 
> >
> >
>

Re: CXF 4.0.0 jakarta release

2022-11-30 Thread Colm O hEigeartaigh

It works for me as well. I'm coordinating with @Andriy Redko  on two
fixes that remain for 3.5.x/3.4.x and then we should be good to go.

Colm.

On Wed, Nov 30, 2022 at 10:10 AM Jim Ma  wrote:
>
> Thanks Andriy and Dan !
>
> On Mon, Nov 28, 2022 at 10:28 PM Andrey Redko  wrote:
>
> > Works for me, thanks a lot Dan!
> >
> > Best Regards,
> > Andriy Redko
> >
> > On Mon, Nov 28, 2022, 8:45 AM Daniel Kulp  wrote:
> >
> > >
> > > >
> > > > I don't think anything blocking is left, +1 to move forward! @Colm @Dan
> > > do
> > > > we want to drop 4.0.0 only or make 3.4.x / 3.5.x releases as well? With
> > > > 4.0.0 out and 3.6.0 getting ready to be out soon (hopefully), the 3.4.x
> > > is
> > > > approaching EOL quickly, could be the last release.
> > >
> > >
> > > I was definitely planning on doing 3.4/3.5 releases sometime before the
> > > end of the year.  Thus, we could do a full set of releases.   I have a
> > > bunch of things happening this week, but would next Monday work for
> > > everyone?  That would give a week to get any final updates in.
> > >
> > > Dan
> > >
> > >
> > > >
> > > > Thank you guys!
> > > >
> > > >
> > > > Best Regards,
> > > >Andriy Redko
> > > >
> > > > On Sun, Nov 27, 2022, 10:27 PM Jim Ma  wrote:
> > > >
> > > >> Hi Andriy,
> > > >> Can we start the release work if there isn't the major thing left we
> > > need
> > > >> to include in CXF 4.0.0 release ?
> > > >>
> > > >> @Daniel Kulp  Can you please help do the release
> > when
> > > >> it's convenient for you?
> > > >>
> > > >> Thanks,
> > > >> Jim
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> On Mon, Nov 14, 2022 at 1:18 PM Jean-Baptiste Onofré  > >
> > > >> wrote:
> > > >>
> > > >>> +1 to release 4.0.0 even partial release.
> > > >>>
> > > >>> Regards
> > > >>> JB
> > > >>>
> > > >>> On Mon, Nov 7, 2022 at 9:19 AM Jim Ma  wrote:
> > > 
> > >  Hi all,
> > >  After 9 months of work, we finally fixed/worked around all issues
> > for
> > >  Jakarta support. Now all the cxf tests are passed:
> > >  https://ci-builds.apache.org/job/CXF/job/CXF-JDK17/848/ and we can
> > > say
> > > >>> that
> > >  CXF successfully migrated to Jakarta namespace(and support Jakarta
> > > >>> EE9.1).
> > >  To get cxf jakarta artifacts/binary available for the CXF community
> > >  especially the user who asked for this jakarta artifacts like [1]
> > and
> > > >>> get
> > >  more feedback from our community, do you think it's time to release
> > > the
> > > >>> CXF
> > >  4.0.0 and what else do you think we should have in this new jakarta
> > > >>> release
> > >  ?
> > > 
> > >  [1]https://lists.apache.org/thread/kwfg2s5gj72tkgn5c5vdcsvtgdkdm6dl
> > > 
> > >  Thanks,
> > >  Jim
> > > >>>
> > > >>
> > >
> > > --
> > > Daniel Kulp
> > > dk...@apache.org 
> > > Talend - https://talend.com 
> > >
> > >
> >

[GitHub] [cxf] aziubin commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

2022-11-30 Thread GitBox



aziubin commented on PR #1033:
URL: https://github.com/apache/cxf/pull/1033#issuecomment-1331969825

   @reta thanks. I have verified that last change and it work OK for me too.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

2022-11-30 Thread GitBox



reta commented on PR #1033:
URL: https://github.com/apache/cxf/pull/1033#issuecomment-1332149388

   @dkulp @coheigea guys I am wondering if you have any comments / concerns here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta commented on a diff in pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-11-30 Thread GitBox



reta commented on code in PR #960:
URL: https://github.com/apache/cxf/pull/960#discussion_r1036059188


##
core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java:
##
@@ -546,24 +550,46 @@ public static Attachment createMtomAttachmentFromDH(
 }
 
 public static DataSource getAttachmentDataSource(String contentId, 
Collection atts) {
-// Is this right? - DD
+//
+// RFC-2392 (https://datatracker.ietf.org/doc/html/rfc2392) says:
+//
+// A "cid" URL is converted to the corresponding Content-ID message
+// header [MIME] by removing the "cid:" prefix, converting the % 
encoded
+// character to their equivalent US-ASCII characters, and enclosing the
+// remaining parts with an angle bracket pair, "<" and ">".  
+//
 if (contentId.startsWith("cid:")) {
 try {
 contentId = URLDecoder.decode(contentId.substring(4), 
StandardCharsets.UTF_8.name());
 } catch (UnsupportedEncodingException ue) {
 contentId = contentId.substring(4);
 }
-return loadDataSource(contentId, atts);
-} else if (contentId.indexOf("://") == -1) {
-return loadDataSource(contentId, atts);
-} else {
-try {
-return new URLDataSource(new URL(contentId));
-} catch (MalformedURLException e) {
-throw new Fault(e);
+
+// href attribute information item: MUST be a valid URI per the 
cid: URI scheme (RFC 2392), 
+// for example:
+//
+//   
+// 
+// See please https://www.w3.org/TR/xop10/
+//
+if (contentId.indexOf("://") == -1) {
+return loadDataSource(contentId, atts);
+} else {
+try {
+final String followUrls = SystemPropertyAction
+.getProperty(ATTACHMENT_XOP_FOLLOW_URLS_PROPERTY, 
"false");
+if ("true".equals(followUrls)) {

Review Comment:
   Certainly, thanks @coheigea , changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] coheigea commented on a diff in pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-11-30 Thread GitBox



coheigea commented on code in PR #960:
URL: https://github.com/apache/cxf/pull/960#discussion_r1036106931


##
core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java:
##
@@ -546,24 +550,46 @@ public static Attachment createMtomAttachmentFromDH(
 }
 
 public static DataSource getAttachmentDataSource(String contentId, 
Collection atts) {
-// Is this right? - DD
+//
+// RFC-2392 (https://datatracker.ietf.org/doc/html/rfc2392) says:
+//
+// A "cid" URL is converted to the corresponding Content-ID message
+// header [MIME] by removing the "cid:" prefix, converting the % 
encoded
+// character to their equivalent US-ASCII characters, and enclosing the
+// remaining parts with an angle bracket pair, "<" and ">".  
+//
 if (contentId.startsWith("cid:")) {
 try {
 contentId = URLDecoder.decode(contentId.substring(4), 
StandardCharsets.UTF_8.name());
 } catch (UnsupportedEncodingException ue) {
 contentId = contentId.substring(4);
 }
-return loadDataSource(contentId, atts);
-} else if (contentId.indexOf("://") == -1) {
-return loadDataSource(contentId, atts);
-} else {
-try {
-return new URLDataSource(new URL(contentId));
-} catch (MalformedURLException e) {
-throw new Fault(e);
+
+// href attribute information item: MUST be a valid URI per the 
cid: URI scheme (RFC 2392), 
+// for example:
+//
+//   
+// 
+// See please https://www.w3.org/TR/xop10/
+//
+if (contentId.indexOf("://") == -1) {
+return loadDataSource(contentId, atts);
+} else {
+try {
+final String followUrls = SystemPropertyAction
+.getProperty(ATTACHMENT_XOP_FOLLOW_URLS_PROPERTY, 
"false");
+if ("true".equals(followUrls)) {

Review Comment:
   Did you push the update @reta ?
   Also this test is failing for me:
   
   [ERROR] Failures:
   [ERROR]   MtomServerTest.testURLBasedAttachment:196 expected:<1> but was:<0>
   [INFO]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta commented on a diff in pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-11-30 Thread GitBox



reta commented on code in PR #960:
URL: https://github.com/apache/cxf/pull/960#discussion_r1036114943


##
core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java:
##
@@ -546,24 +550,46 @@ public static Attachment createMtomAttachmentFromDH(
 }
 
 public static DataSource getAttachmentDataSource(String contentId, 
Collection atts) {
-// Is this right? - DD
+//
+// RFC-2392 (https://datatracker.ietf.org/doc/html/rfc2392) says:
+//
+// A "cid" URL is converted to the corresponding Content-ID message
+// header [MIME] by removing the "cid:" prefix, converting the % 
encoded
+// character to their equivalent US-ASCII characters, and enclosing the
+// remaining parts with an angle bracket pair, "<" and ">".  
+//
 if (contentId.startsWith("cid:")) {
 try {
 contentId = URLDecoder.decode(contentId.substring(4), 
StandardCharsets.UTF_8.name());
 } catch (UnsupportedEncodingException ue) {
 contentId = contentId.substring(4);
 }
-return loadDataSource(contentId, atts);
-} else if (contentId.indexOf("://") == -1) {
-return loadDataSource(contentId, atts);
-} else {
-try {
-return new URLDataSource(new URL(contentId));
-} catch (MalformedURLException e) {
-throw new Fault(e);
+
+// href attribute information item: MUST be a valid URI per the 
cid: URI scheme (RFC 2392), 
+// for example:
+//
+//   
+// 
+// See please https://www.w3.org/TR/xop10/
+//
+if (contentId.indexOf("://") == -1) {
+return loadDataSource(contentId, atts);
+} else {
+try {
+final String followUrls = SystemPropertyAction
+.getProperty(ATTACHMENT_XOP_FOLLOW_URLS_PROPERTY, 
"false");
+if ("true".equals(followUrls)) {

Review Comment:
   Oops, sorry, just did @coheigea (was fixing exactly this test)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta merged pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-11-30 Thread GitBox



reta merged PR #960:
URL: https://github.com/apache/cxf/pull/960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] reta opened a new pull request, #1037: CXF-8774: Migration path for jaxb2-basics (to hisrc-basicjaxb)

2022-11-30 Thread GitBox



reta opened a new pull request, #1037:
URL: https://github.com/apache/cxf/pull/1037

   Migration path for jaxb2-basics to hisrc-basicjaxb


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cxf] jimma commented on a diff in pull request #1037: CXF-8774: Migration path for jaxb2-basics (to hisrc-basicjaxb)

2022-11-30 Thread GitBox



jimma commented on code in PR #1037:
URL: https://github.com/apache/cxf/pull/1037#discussion_r1036651630


##
tools/wadlto/jaxrs/pom.xml:
##
@@ -59,6 +59,12 @@
 junit
 test
 
+
+org.patrodyne.jvnet
+hisrc-basicjaxb-plugins
+2.0.0

Review Comment:
   Very minor thing.  Add this to dependency management in parent pom ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: CXF 4.0.0 jakarta release

Re: CXF 4.0.0 jakarta release

[GitHub] [cxf] aziubin commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

[GitHub] [cxf] reta commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

[GitHub] [cxf] reta commented on a diff in pull request #960: CXF-8706: CXF MTOM handler allow content injection

[GitHub] [cxf] coheigea commented on a diff in pull request #960: CXF-8706: CXF MTOM handler allow content injection

[GitHub] [cxf] reta commented on a diff in pull request #960: CXF-8706: CXF MTOM handler allow content injection

[GitHub] [cxf] reta merged pull request #960: CXF-8706: CXF MTOM handler allow content injection

[GitHub] [cxf] reta opened a new pull request, #1037: CXF-8774: Migration path for jaxb2-basics (to hisrc-basicjaxb)

[GitHub] [cxf] jimma commented on a diff in pull request #1037: CXF-8774: Migration path for jaxb2-basics (to hisrc-basicjaxb)

10 matches

Site Navigation

Mail list logo

Footer information