[GitHub] [cxf] coheigea commented on a diff in pull request #944: NPE fix in addClaims() method
coheigea commented on code in PR #944:
URL: https://github.com/apache/cxf/pull/944#discussion_r867801220
##
rt/ws/security/src/main/java/org/apache/cxf/ws/security/trust/AbstractSTSClient.java:
##
@@ -1453,7 +1453,7 @@ protected void addClaims(XMLStreamWriter writer) throws
Exception {
if (claimsToSerialize instanceof Element) {
StaxUtils.copy((Element)claimsToSerialize, writer);
} else if (claimsToSerialize instanceof ClaimCollection) {
-ClaimCollection claimCollection = (ClaimCollection)claims;
+ClaimCollection claimCollection =
(ClaimCollection)claimsToSerialize;
Review Comment:
I'll add the test to the STS systests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cxf] coheigea merged pull request #944: NPE fix in addClaims() method
coheigea merged PR #944: URL: https://github.com/apache/cxf/pull/944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] jgreffe commented on pull request #945: [CXF-8699] Abillity to set sensitive filters on LoggingFeature
jgreffe commented on PR #945: URL: https://github.com/apache/cxf/pull/945#issuecomment-1120878542 @reta , @coheigea , pushed changes, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta merged pull request #945: [CXF-8699] Abillity to set sensitive filters on LoggingFeature
reta merged PR #945: URL: https://github.com/apache/cxf/pull/945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #947: Cxf 8371
reta commented on code in PR #947: URL: https://github.com/apache/cxf/pull/947#discussion_r867983746 ## parent/pom.xml: ## @@ -247,7 +247,8 @@ 1.2.18_1 1.2.4 3.0.7 -2.0.1 +1.0.0 + 1.0.0 Review Comment: Typo? `activition` -> `activation`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] jimma commented on a diff in pull request #947: Cxf 8371
jimma commented on code in PR #947: URL: https://github.com/apache/cxf/pull/947#discussion_r867989247 ## parent/pom.xml: ## @@ -247,7 +247,8 @@ 1.2.18_1 1.2.4 3.0.7 -2.0.1 +1.0.0 + 1.0.0 Review Comment: Thanks for review @reta ! Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
jimma commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121078678 @reta @coheigea Should we update the version to 5.0.0-SNAPSHOT ? If there is no objection,I'll start to update version number tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121084102 > @reta @coheigea Should we update the version to 5.0.0-SNAPSHOT ? If there is no objection,I'll start to update version number tomorrow. @jimma why 5.0.0? As we discussed, 4.0 is Jakarta, the 3.x would be the `javax.*` line, the thread is there [1] [1] https://www.mail-archive.com/dev@cxf.apache.org/msg17023.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
jimma commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121160155 > > @reta @coheigea Should we update the version to 5.0.0-SNAPSHOT ? If there is no objection,I'll start to update version number tomorrow. > > @jimma why 5.0.0? As we discussed, 4.0 is Jakarta, the 3.x would be the `javax.*` line, the thread is there [1] > > [1] https://www.mail-archive.com/dev@cxf.apache.org/msg17023.html @reta CXF master is now 4.0.0-SNAPSHOT : https://github.com/apache/cxf/blob/master/pom.xml#L24 There are still a lot of changes/fixes on this branch. So there is no plan to tag a 4.0.0 and following 4.x release, right ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121176481 > > > @reta @coheigea Should we update the version to 5.0.0-SNAPSHOT ? If there is no objection,I'll start to update version number tomorrow. > > > > > > @jimma why 5.0.0? As we discussed, 4.0 is Jakarta, the 3.x would be the `javax.*` line, the thread is there [1] > > [1] https://www.mail-archive.com/dev@cxf.apache.org/msg17023.html > > @reta CXF master is now 4.0.0-SNAPSHOT : https://github.com/apache/cxf/blob/master/pom.xml#L24 There are still a lot of changes/fixes on this branch. So there is no plan to tag a 4.0.0 and following 4.x release, right ? Correct, as far as I remember, we decided to keep master on 4.x (Jakarta) branch. We should probably branch of 3.6.x-fixes (from the `master`) soon so continue the 3.x line development, makes sense? @coheigea wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
jimma commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121181976 @reta If we'll change the master 4.0 to jakarta, I think we can plan some Alpha or milestone release to include the things already work. At least we make the CI work, and community can easily contribute patch and improve the jakarta CXF, and we don't maintain more branches. WDYT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121196246 > @reta If we'll change the master 4.0 to jakarta, I think we can plan some Alpha or milestone release to include the things already work. At least we make the CI work, and community can easily contribute patch and improve the jakarta CXF, and we don't maintain more branches. WDYT ? @jimma sorry, lost a bit here: master is 4.0.0 / `Jakarta` (we just have the changes behind the pull request but I think we could go ahead and merge them soon). The `javax.*` still has to be supported (as we discussed), logically leading to 2 main branches: jakarta.* and javax.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] reta merged pull request #947: Cxf 8371
reta merged PR #947: URL: https://github.com/apache/cxf/pull/947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+
jimma commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121825190 @reta I meant when can we merge the CXF-8371 to master ? And we probably need plan some Alpha or Milestone release in the jakarta 4.x CXF and make CI work , then we don 't need to maintain the CXF-8371 branch anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
