Re: Copied classes in cxf-rt-management.jar with JDK11
Hi Jim, I took another look, we actually don't need JVM option --add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED to build CXF management module with JDK 9+, because CXF management module now doesn't use JDK internal API sun.rmi.registry anymore(CXF-8250 made this change). So we don't need it even for CXF 3.4.x and 3.5.x. So please remove that profile from CXF 3.4.x to CXF 4.x Thanks! Freeman On Thu, Apr 21, 2022 at 2:20 AM Jim Ma wrote: > I think we can remove this profile from 3.4.x and 3.5.x too. There is no > reason we should still keep this, right ? > I tried to build 3.4.x/3.5.x with jdk11, and the Export-Package entry in > META-INF is generated as expected. > > > On Thu, Apr 21, 2022 at 10:25 AM Freeman Fang > wrote: > >> Hi Jim, >> >> I mean remove it from CXF 4.x which is JDK11 minimum. >> >> Freeman >> >> On Wed, Apr 20, 2022 at 8:45 PM Jim Ma wrote: >> >>> Hi Freeman, >>> Are you saying we can remove this java9-plus profile completely from >>> 3.4.x to 4.x? >>> >>> Cheers, >>> Jim >>> >>> On Wed, Apr 20, 2022 at 10:45 PM Freeman Fang >>> wrote: >>> Hi Jim, Without it, on JDK11 we will see META-INF.versions.11 from the export package part, and we don't want it. And this META-INF.versions.11 thing is from the maven-compiler-plugin in java9-plus profile. The expected Export-Package should be like Export-Package: org.apache.cxf.tracing;version="4.0.0", org.apache.cxf.management.jmx;version="4.0.0", org.apache.cxf.management.jmx.type;version="4.0.0", org.apache.cxf.management.jmx.export.runtime;version="4.0.0", org.apache.cxf.management.utils;version="4.0.0", org.apache.cxf.management.persistence;version="4.0.0", org.apache.cxf.management.counters;version="4.0.0", org.apache.cxf.management.interceptor;version="4.0.0" >>> The mystery in this profile was introduced in the first place to both support JDK8 and JDK11. Since for CXF 4.x the minimum JDK version is JDK11(don't need to consider JDK8 compatible anymore), I believe we are safe to remove java9-plus profile in management/pom.xml all together. Cheers Freeman On Tue, Apr 19, 2022 at 10:34 PM Jim Ma wrote: > Hi Freeman, > Do you know why we don't require this with JDK8 and only for JDK9 and > plus ? > I see the Export package info in META-INF built with JDK11 without > this configuration already has this > export package entry : > > Export-Package: org.apache.cxf.tracing;version="3.5.3",org.apache.cxf. > management.jmx;version="3.5.3",org.apache.cxf.management.jmx.type;ver > sion="3.5.3",org.apache.cxf.management.jmx.export.runtime;version="3. > 5.3",org.apache.cxf.management.utils;version="3.5.3",org.apache.cxf.m > anagement.persistence;version="3.5.3",org.apache.cxf.management.count > ers;version="3.5.3",org.apache.cxf.management.interceptor;version="3. > 5.3",META-INF.versions.11.org.apache.cxf.tracing;version="3.5.3",META > -INF.versions.11.org.apache.cxf.management.jmx;version="3.5.3",META-I > NF.versions.11.org.apache.cxf.management.jmx.type;version="3.5.3",MET > A-INF.versions.11.org.apache.cxf.management.jmx.export.runtime;versio > n="3.5.3",META-INF.versions.11.org.apache.cxf.management.utils;versio > n="3.5.3",META-INF.versions.11.org.apache.cxf.management.persistence; > version="3.5.3",META-INF.versions.11.org.apache.cxf.management.counte > rs;version="3.5.3",META-INF.versions.11.org.apache.cxf.management.int > erceptor;version="3.5.3" > > > Cheers, > Jim > > > On Wed, Apr 20, 2022 at 3:04 AM Freeman Fang > wrote: > >> Hi Jim, >> >> Please change the rt/management/pom.xml like this. >> >> >> NONE >> >> - >> >> org.apache.cxf.management*,org.apache.cxf.tracing* >> + >> + >> org.apache.cxf.management.counters, >> + >> org.apache.cxf.management.interceptor, >> + >> org.apache.cxf.management.persistence, >> + >> org.apache.cxf.management.utils, >> + >> org.apache.cxf.management.jmx, >> + >> org.apache.cxf.management.jmx.export.runtime, >> + >> org.apache.cxf.tracing* >> + >> >> true >> >> This fine-grained export package can avoid including the package from >> cxf-core module. >> >> Best Regards >> Freeman >> >> On Mon, Apr 18, 2022 at 11:50 PM Jim Ma wrote: >> >>> Thanks Andriy. Jira is filled : >>> https://issues.apache.org/jira/browse/CXF-8695 >>> and PRs are sent. >>> >>> >>> On Sun, Apr 17, 2022 at 9:28 AM Andriy Redko >>> wrote: >>> >>> > Hey Jim, >>>
[GitHub] [cxf] reta commented on a diff in pull request #940: Migrate to ActiveMQ Artemis (2-nd attempt)
reta commented on code in PR #940:
URL: https://github.com/apache/cxf/pull/940#discussion_r855677308
##
rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/util/MessageListenerTest.java:
##
@@ -174,33 +183,21 @@ private void testTransactionalBehaviour(Connection
connection, Queue dest) throw
}
private static Connection createConnection(String name) throws
JMSException {
-ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory("vm://" +
name
- +
"?broker.persistent=false");
-cf.setRedeliveryPolicy(redeliveryPolicy());
+ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory("vm://" +
name);
Connection connection = cf.createConnection();
connection.start();
return connection;
}
private static Connection createXAConnection(String name,
TransactionManager tm) throws JMSException {
-ActiveMQXAConnectionFactory cf = new
ActiveMQXAConnectionFactory("vm://" + name
- +
"?broker.persistent=false&jms.xaAckMode=1");
-cf.setRedeliveryPolicy(redeliveryPolicy());
-XaPooledConnectionFactory cfp = new XaPooledConnectionFactory(cf);
-cfp.setTransactionManager(tm);
-cfp.setConnectionFactory(cf);
-Connection connection = cfp.createConnection();
+ActiveMQXAConnectionFactory cf = new
ActiveMQXAConnectionFactory("vm://" + name);
+ConnectionFactory cf1 = new ConnectionFactoryProxy(cf, new
TransactionHelperImpl(tm));
Review Comment:
@ehsavoie I found a simpler way to integrate with JTA using
`ConnectionFactoryProxy` and `TransactionHelperImpl`, the tests are passing
right now (except `testConnectionProblemXA`, it has different cause)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #940: Migrate to ActiveMQ Artemis (2-nd attempt)
reta commented on code in PR #940:
URL: https://github.com/apache/cxf/pull/940#discussion_r855677308
##
rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/util/MessageListenerTest.java:
##
@@ -174,33 +183,21 @@ private void testTransactionalBehaviour(Connection
connection, Queue dest) throw
}
private static Connection createConnection(String name) throws
JMSException {
-ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory("vm://" +
name
- +
"?broker.persistent=false");
-cf.setRedeliveryPolicy(redeliveryPolicy());
+ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory("vm://" +
name);
Connection connection = cf.createConnection();
connection.start();
return connection;
}
private static Connection createXAConnection(String name,
TransactionManager tm) throws JMSException {
-ActiveMQXAConnectionFactory cf = new
ActiveMQXAConnectionFactory("vm://" + name
- +
"?broker.persistent=false&jms.xaAckMode=1");
-cf.setRedeliveryPolicy(redeliveryPolicy());
-XaPooledConnectionFactory cfp = new XaPooledConnectionFactory(cf);
-cfp.setTransactionManager(tm);
-cfp.setConnectionFactory(cf);
-Connection connection = cfp.createConnection();
+ActiveMQXAConnectionFactory cf = new
ActiveMQXAConnectionFactory("vm://" + name);
+ConnectionFactory cf1 = new ConnectionFactoryProxy(cf, new
TransactionHelperImpl(tm));
Review Comment:
@ehsavoie I found a simpler way to integrate with JTA using
`ConnectionFactoryProxy` and `TransactionHelperImpl`, the tests are passing
right now (except `testConnectionProblemXA`, it has different cause).
```
[ERROR] Failures:
[ERROR]
JMSDestinationTest.testDoNotCreateSecurityContext:545->testSecurityContext:558->AbstractJMSTester.waitForReceiveDestMessage:278
Can't receive the Destination message in 10 seconds
[ERROR]
JMSDestinationTest.testProperty:424->verifyRequestResponseHeaders:303 The
message encoding should be equal expected: but was:
[ERROR] JMSDestinationTest.testRoundTripDestination:316 SecurityContext
should be set in message received by JMSDestination
[ERROR] JMSDestinationTest.testSecurityContext:538 SecurityContext should
be set in message received by JMSDestination
[ERROR] JMSDestinationTest.testTemporaryQueueDeletionUponReset:511
Expected: <1>
but: was <0>
[ERROR] MessageListenerTest.testConnectionProblemXA:104
Expected: a string containing "Wrapped exception."
but: was "Connection is closed"
[INFO]
[ERROR] Tests run: 65, Failures: 6, Errors: 0, Skipped: 1
[INFO]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: Copied classes in cxf-rt-management.jar with JDK11
Thanks Freeman. I updated my PRs to remove this profile completely from CXF 3.4.x to 4.x. Please review. On Thu, Apr 21, 2022 at 9:45 PM Freeman Fang wrote: > Hi Jim, > > I took another look, we actually don't need JVM option > --add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED > to build CXF management module with JDK 9+, because CXF management module > now doesn't use JDK internal API sun.rmi.registry anymore(CXF-8250 made > this change). So we don't need it even for CXF 3.4.x and 3.5.x. > > So please remove that profile from CXF 3.4.x to CXF 4.x > > Thanks! > Freeman > > On Thu, Apr 21, 2022 at 2:20 AM Jim Ma wrote: > >> I think we can remove this profile from 3.4.x and 3.5.x too. There is no >> reason we should still keep this, right ? >> I tried to build 3.4.x/3.5.x with jdk11, and the Export-Package entry in >> META-INF is generated as expected. >> >> >> On Thu, Apr 21, 2022 at 10:25 AM Freeman Fang >> wrote: >> >>> Hi Jim, >>> >>> I mean remove it from CXF 4.x which is JDK11 minimum. >>> >>> Freeman >>> >>> On Wed, Apr 20, 2022 at 8:45 PM Jim Ma wrote: >>> Hi Freeman, Are you saying we can remove this java9-plus profile completely from 3.4.x to 4.x? Cheers, Jim On Wed, Apr 20, 2022 at 10:45 PM Freeman Fang wrote: > Hi Jim, > > Without it, on JDK11 we will see META-INF.versions.11 from the export > package part, and we don't want it. And this META-INF.versions.11 thing is > from the maven-compiler-plugin in java9-plus profile. > The expected Export-Package should be like > Export-Package: > org.apache.cxf.tracing;version="4.0.0", > org.apache.cxf.management.jmx;version="4.0.0", > org.apache.cxf.management.jmx.type;version="4.0.0", > org.apache.cxf.management.jmx.export.runtime;version="4.0.0", > org.apache.cxf.management.utils;version="4.0.0", > org.apache.cxf.management.persistence;version="4.0.0", > org.apache.cxf.management.counters;version="4.0.0", > org.apache.cxf.management.interceptor;version="4.0.0" > > The mystery in this profile was introduced in the first place to both > support JDK8 and JDK11. Since for CXF 4.x the minimum JDK version is > JDK11(don't need to consider JDK8 compatible anymore), I believe we are > safe to remove java9-plus profile in management/pom.xml all together. > > Cheers > Freeman > > On Tue, Apr 19, 2022 at 10:34 PM Jim Ma wrote: > >> Hi Freeman, >> Do you know why we don't require this with JDK8 and only for JDK9 and >> plus ? >> I see the Export package info in META-INF built with JDK11 without >> this configuration already has this >> export package entry : >> >> Export-Package: org.apache.cxf.tracing;version="3.5.3",org.apache.cxf. >> management.jmx;version="3.5.3",org.apache.cxf.management.jmx.type;ver >> sion="3.5.3",org.apache.cxf.management.jmx.export.runtime;version="3. >> 5.3",org.apache.cxf.management.utils;version="3.5.3",org.apache.cxf.m >> anagement.persistence;version="3.5.3",org.apache.cxf.management.count >> ers;version="3.5.3",org.apache.cxf.management.interceptor;version="3. >> 5.3",META-INF.versions.11.org.apache.cxf.tracing;version="3.5.3",META >> -INF.versions.11.org.apache.cxf.management.jmx;version="3.5.3",META-I >> NF.versions.11.org.apache.cxf.management.jmx.type;version="3.5.3",MET >> A-INF.versions.11.org.apache.cxf.management.jmx.export.runtime;versio >> n="3.5.3",META-INF.versions.11.org.apache.cxf.management.utils;versio >> n="3.5.3",META-INF.versions.11.org.apache.cxf.management.persistence; >> version="3.5.3",META-INF.versions.11.org.apache.cxf.management.counte >> rs;version="3.5.3", >> META-INF.versions.11.org.apache.cxf.management.int >> erceptor;version="3.5.3" >> >> >> Cheers, >> Jim >> >> >> On Wed, Apr 20, 2022 at 3:04 AM Freeman Fang >> wrote: >> >>> Hi Jim, >>> >>> Please change the rt/management/pom.xml like this. >>> >>> >>> NONE >>> >>> - >>> >>> org.apache.cxf.management*,org.apache.cxf.tracing* >>> + >>> + >>> org.apache.cxf.management.counters, >>> + >>> org.apache.cxf.management.interceptor, >>> + >>> org.apache.cxf.management.persistence, >>> + >>> org.apache.cxf.management.utils, >>> + >>> org.apache.cxf.management.jmx, >>> + >>> org.apache.cxf.management.jmx.export.runtime, >>> + >>> org.apache.cxf.tracing* >>> + >>> >>> true >>> >>> This fine-grained export package can avoid including the package >>> from cxf-core module. >>> >>> Best Regards >>> Fre
[GitHub] [cxf] jimma merged pull request #937: [CXF-8695]:Remove duplicate copied class from cxf-core in cxf-rt-mana…
jimma merged PR #937: URL: https://github.com/apache/cxf/pull/937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
