[GitHub] [cxf] reta merged pull request #927: Merge Opensaml4 to Jakarta EE branch
reta merged PR #927: URL: https://github.com/apache/cxf/pull/927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Systest failures with wss4j-3.0.0-SNAPSHOT
Hey Jim, Colm, I merged the Opensaml + WSSJ4 changes [1] into the Jakarta branch [2], there is still an issue with non-existing artifact(s): [ERROR] Failed to execute goal on project cxf-rt-security-saml: Could not resolve dependencies for project org.apache.cxf:cxf-rt-security-saml:bundle:4.0.0-SNAPSHOT: Could not find artifact org.apache.wss4j:wss4j-ws-security-dom:jar:3.0.0-SNAPSHOT in spring.milestone (https://repo.spring.io/milestone/) -> [Help 1] It seems like wss4j-ws-security-dom is gone in 3.x [3], any replacement we could use? Thanks! [1] https://github.com/apache/cxf/pull/927 [2] https://github.com/apache/cxf/pull/912 [3] https://repository.apache.org/content/repositories/snapshots/org/apache/wss4j/wss4j-ws-security-dom/ Best Regards, Andriy Redko JM> Thanks for the merge, Andriy. JM> I just checked this test with this merge, I still get the same failure. JM> On Sat, Mar 26, 2022 at 11:46 PM Andriy Redko wrote: >> Hey Jim, Colm, >> I have created this pull request [1] to merge changes from OpenSaml4 to >> Jakarta >> branch, looks like everything is in, @Colm could you please take a look? >> Thank you! >> [1] https://github.com/apache/cxf/pull/927/files >> JM> Hi Colm, >> JM> You are right. My working branch missed several commits. >> JM> This is a good idea to merge these missed things to jakarta branch. >> I'll >> JM> have a test again >> JM> after @Andriy Redko merge these changes. >> JM> Thanks, >> JM> Jim >> JM> On Thu, Mar 24, 2022 at 4:31 PM Colm O hEigeartaigh < >> cohei...@apache.org> >> JM> wrote: >> >> Hi Jim, >> >> Your branch is behind CXF master with regards several commits. I think >> >> it would be better if we just worked off one official branch at CXF. >> >> @Andriy Redko maybe we should just incorporate >> >> https://github.com/apache/cxf/tree/opensaml4 into your Jakarta branch >> >> so that I can look at what's failing with WSS4J 3.0.0? >> >> Colm. >> >> On Wed, Mar 23, 2022 at 12:42 PM Jim Ma wrote: >> >> > >> >> > Thanks for the quick fix, Colm. >> >> > >> >> > It seems there is another failure under >> services/sts/systests/advanced: >> >> > >> >> > [INFO] Running org.apache.cxf.systest.sts.renew.SAMLRenewTest >> >> > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time >> elapsed: >> >> 10.297 s <<< FAILURE! - in >> org.apache.cxf.systest.sts.renew.SAMLRenewTest >> >> > [ERROR] >> >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens >> Time >> >> elapsed: 9.671 s <<< ERROR! >> >> > jakarta.xml.ws.soap.SOAPFaultException: A security error was >> encountered >> >> when verifying the message >> >> > at >> >> >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.doubleIt(SAMLRenewTest.java:145) >> >> > at >> >> >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens(SAMLRenewTest.java:116) >> >> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was >> >> encountered when verifying the message >> >> > at >> >> >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.doubleIt(SAMLRenewTest.java:145) >> >> > at >> >> >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens(SAMLRenewTest.java:116) >> >> > >> >> > I checked these spring configuration files and other places, and >> didn't >> >> find the place we need to change to the jakarta namespace. >> >> > Is there anything else we need to check ? >> >> > >> >> > >> >> > >> >> > On Wed, Mar 23, 2022 at 7:15 PM Colm O hEigeartaigh < >> cohei...@apache.org> >> >> wrote: >> >> >> >> >> >> The SAML failures were caused by a hard-coded String in SAMLUtils, I >> >> >> fixed it in CXF master here: >> >> >> >> >> >> https://github.com/apache/cxf/commit/1e90f53f720b76c2dbac910e58ef0b291f98c032 >> >> >> >> >> >> Colm. >> >> >> >> >> >> On Tue, Mar 22, 2022 at 12:48 PM Jim Ma >> wrote: >> >> >> > >> >> >> > Hi Colm, >> >> >> > >> >> >> > Please checkout my working branch : >> >> https://github.com/jimma/cxf/tree/wss4j-30-jakarta >> >> >> > Build all cxf artifacts first with: mvn clean install -Pfastinstall >> >> >> > then go to systests/ws-security, run these tests and you'll get >> these >> >> test failures. >> >> >> > Please let me know if you have other issues when trying this out. >> >> >> > >> >> >> > Thanks, >> >> >> > Jim >> >> >> > >> >> >> > On Tue, Mar 22, 2022 at 5:18 PM Colm O hEigeartaigh < >> >> cohei...@apache.org> wrote: >> >> >> >> >> >> >> >> Hi Jim, >> >> >> >> >> >> >> >> Which branch are you testing this on in CXF? >> >> >> >> >> >> >> >> Colm. >> >> >> >> >> >> >> >> On Mon, Mar 21, 2022 at 7:26 AM Jim Ma >> wrote: >> >> >> >> > >> >> >> >> > Hi Colm, >> >> >> >> > After I upgraded wss4j version to 3.0.0-SNAPSHOT(jakarta >> version) >> >> in CXF, >> >> >> >> > I got the following ws-security systests failures. >> >> >> >> > Could you please help look at if there is still something we >> need >> >> to fix in >> >> >> >> > wss4j ? Or we need to fix it in CXF ? >> >> >> >> > >> >> >> >> > Thanks, >> >> >> >> > Jim >>
Re: Systest failures with wss4j-3.0.0-SNAPSHOT
Hey Andriy, I think it's what I said on the PR, that the Jakarta profile in the root pom doesn't have the Apache snapshot repo to get the WSS4J SNAPSHOTs. Colm. On Sun, Apr 17, 2022 at 3:21 PM Andriy Redko wrote: > > Hey Jim, Colm, > > I merged the Opensaml + WSSJ4 changes [1] into the Jakarta branch [2], there > is still an issue with non-existing artifact(s): > > [ERROR] Failed to execute goal on project cxf-rt-security-saml: Could not > resolve dependencies for project > org.apache.cxf:cxf-rt-security-saml:bundle:4.0.0-SNAPSHOT: Could not find > artifact org.apache.wss4j:wss4j-ws-security-dom:jar:3.0.0-SNAPSHOT in > spring.milestone (https://repo.spring.io/milestone/) -> [Help 1] > > It seems like wss4j-ws-security-dom is gone in 3.x [3], any replacement we > could use? > Thanks! > > [1] https://github.com/apache/cxf/pull/927 > [2] https://github.com/apache/cxf/pull/912 > [3] > https://repository.apache.org/content/repositories/snapshots/org/apache/wss4j/wss4j-ws-security-dom/ > > Best Regards, > Andriy Redko > > JM> Thanks for the merge, Andriy. > JM> I just checked this test with this merge, I still get the same failure. > > > JM> On Sat, Mar 26, 2022 at 11:46 PM Andriy Redko wrote: > > >> Hey Jim, Colm, > > >> I have created this pull request [1] to merge changes from OpenSaml4 to > >> Jakarta > >> branch, looks like everything is in, @Colm could you please take a look? > >> Thank you! > > >> [1] https://github.com/apache/cxf/pull/927/files > > >> JM> Hi Colm, > >> JM> You are right. My working branch missed several commits. > >> JM> This is a good idea to merge these missed things to jakarta branch. > >> I'll > >> JM> have a test again > >> JM> after @Andriy Redko merge these changes. > > >> JM> Thanks, > >> JM> Jim > > >> JM> On Thu, Mar 24, 2022 at 4:31 PM Colm O hEigeartaigh < > >> cohei...@apache.org> > >> JM> wrote: > > >> >> Hi Jim, > > >> >> Your branch is behind CXF master with regards several commits. I think > >> >> it would be better if we just worked off one official branch at CXF. > >> >> @Andriy Redko maybe we should just incorporate > >> >> https://github.com/apache/cxf/tree/opensaml4 into your Jakarta branch > >> >> so that I can look at what's failing with WSS4J 3.0.0? > > >> >> Colm. > > >> >> On Wed, Mar 23, 2022 at 12:42 PM Jim Ma wrote: > >> >> > > >> >> > Thanks for the quick fix, Colm. > >> >> > > >> >> > It seems there is another failure under > >> services/sts/systests/advanced: > >> >> > > >> >> > [INFO] Running org.apache.cxf.systest.sts.renew.SAMLRenewTest > >> >> > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time > >> elapsed: > >> >> 10.297 s <<< FAILURE! - in > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest > >> >> > [ERROR] > >> >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens > >> Time > >> >> elapsed: 9.671 s <<< ERROR! > >> >> > jakarta.xml.ws.soap.SOAPFaultException: A security error was > >> encountered > >> >> when verifying the message > >> >> > at > >> >> > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.doubleIt(SAMLRenewTest.java:145) > >> >> > at > >> >> > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens(SAMLRenewTest.java:116) > >> >> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was > >> >> encountered when verifying the message > >> >> > at > >> >> > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.doubleIt(SAMLRenewTest.java:145) > >> >> > at > >> >> > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens(SAMLRenewTest.java:116) > >> >> > > >> >> > I checked these spring configuration files and other places, and > >> didn't > >> >> find the place we need to change to the jakarta namespace. > >> >> > Is there anything else we need to check ? > >> >> > > >> >> > > >> >> > > >> >> > On Wed, Mar 23, 2022 at 7:15 PM Colm O hEigeartaigh < > >> cohei...@apache.org> > >> >> wrote: > >> >> >> > >> >> >> The SAML failures were caused by a hard-coded String in SAMLUtils, I > >> >> >> fixed it in CXF master here: > >> >> >> > >> >> > >> https://github.com/apache/cxf/commit/1e90f53f720b76c2dbac910e58ef0b291f98c032 > >> >> >> > >> >> >> Colm. > >> >> >> > >> >> >> On Tue, Mar 22, 2022 at 12:48 PM Jim Ma > >> wrote: > >> >> >> > > >> >> >> > Hi Colm, > >> >> >> > > >> >> >> > Please checkout my working branch : > >> >> https://github.com/jimma/cxf/tree/wss4j-30-jakarta > >> >> >> > Build all cxf artifacts first with: mvn clean install -Pfastinstall > >> >> >> > then go to systests/ws-security, run these tests and you'll get > >> these > >> >> test failures. > >> >> >> > Please let me know if you have other issues when trying this out. > >> >> >> > > >> >> >> > Thanks, > >> >> >> > Jim > >> >> >> > > >> >> >> > On Tue, Mar 22, 2022 at 5:18 PM Colm O hEigeartaigh < > >> >> cohei...@apache.org> wrote: > >> >> >> >> > >> >> >> >> Hi Jim, > >> >> >> >> > >> >> >> >> Which branch are you testing this on in CXF? > >> >> >> >> > >> >> >> >> Colm. >
Re: Systest failures with wss4j-3.0.0-SNAPSHOT
Sorry, I should have checked first - it looks like the Jenkins build is broken, I manually deploy a SNAPSHOT for now. Colm. On Sun, Apr 17, 2022 at 7:46 PM Colm O hEigeartaigh wrote: > > Hey Andriy, > > I think it's what I said on the PR, that the Jakarta profile in the > root pom doesn't have the Apache snapshot repo to get the WSS4J > SNAPSHOTs. > > Colm. > > On Sun, Apr 17, 2022 at 3:21 PM Andriy Redko wrote: > > > > Hey Jim, Colm, > > > > I merged the Opensaml + WSSJ4 changes [1] into the Jakarta branch [2], > > there is still an issue with non-existing artifact(s): > > > > [ERROR] Failed to execute goal on project cxf-rt-security-saml: Could not > > resolve dependencies for project > > org.apache.cxf:cxf-rt-security-saml:bundle:4.0.0-SNAPSHOT: Could not find > > artifact org.apache.wss4j:wss4j-ws-security-dom:jar:3.0.0-SNAPSHOT in > > spring.milestone (https://repo.spring.io/milestone/) -> [Help 1] > > > > It seems like wss4j-ws-security-dom is gone in 3.x [3], any replacement we > > could use? > > Thanks! > > > > [1] https://github.com/apache/cxf/pull/927 > > [2] https://github.com/apache/cxf/pull/912 > > [3] > > https://repository.apache.org/content/repositories/snapshots/org/apache/wss4j/wss4j-ws-security-dom/ > > > > Best Regards, > > Andriy Redko > > > > JM> Thanks for the merge, Andriy. > > JM> I just checked this test with this merge, I still get the same failure. > > > > > > JM> On Sat, Mar 26, 2022 at 11:46 PM Andriy Redko wrote: > > > > >> Hey Jim, Colm, > > > > >> I have created this pull request [1] to merge changes from OpenSaml4 to > > >> Jakarta > > >> branch, looks like everything is in, @Colm could you please take a look? > > >> Thank you! > > > > >> [1] https://github.com/apache/cxf/pull/927/files > > > > >> JM> Hi Colm, > > >> JM> You are right. My working branch missed several commits. > > >> JM> This is a good idea to merge these missed things to jakarta branch. > > >> I'll > > >> JM> have a test again > > >> JM> after @Andriy Redko merge these changes. > > > > >> JM> Thanks, > > >> JM> Jim > > > > >> JM> On Thu, Mar 24, 2022 at 4:31 PM Colm O hEigeartaigh < > > >> cohei...@apache.org> > > >> JM> wrote: > > > > >> >> Hi Jim, > > > > >> >> Your branch is behind CXF master with regards several commits. I think > > >> >> it would be better if we just worked off one official branch at CXF. > > >> >> @Andriy Redko maybe we should just incorporate > > >> >> https://github.com/apache/cxf/tree/opensaml4 into your Jakarta branch > > >> >> so that I can look at what's failing with WSS4J 3.0.0? > > > > >> >> Colm. > > > > >> >> On Wed, Mar 23, 2022 at 12:42 PM Jim Ma wrote: > > >> >> > > > >> >> > Thanks for the quick fix, Colm. > > >> >> > > > >> >> > It seems there is another failure under > > >> services/sts/systests/advanced: > > >> >> > > > >> >> > [INFO] Running org.apache.cxf.systest.sts.renew.SAMLRenewTest > > >> >> > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time > > >> elapsed: > > >> >> 10.297 s <<< FAILURE! - in > > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest > > >> >> > [ERROR] > > >> >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens > > >> Time > > >> >> elapsed: 9.671 s <<< ERROR! > > >> >> > jakarta.xml.ws.soap.SOAPFaultException: A security error was > > >> encountered > > >> >> when verifying the message > > >> >> > at > > >> >> > > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.doubleIt(SAMLRenewTest.java:145) > > >> >> > at > > >> >> > > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens(SAMLRenewTest.java:116) > > >> >> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error > > >> >> > was > > >> >> encountered when verifying the message > > >> >> > at > > >> >> > > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.doubleIt(SAMLRenewTest.java:145) > > >> >> > at > > >> >> > > >> org.apache.cxf.systest.sts.renew.SAMLRenewTest.testRenewExpiredTokens(SAMLRenewTest.java:116) > > >> >> > > > >> >> > I checked these spring configuration files and other places, and > > >> didn't > > >> >> find the place we need to change to the jakarta namespace. > > >> >> > Is there anything else we need to check ? > > >> >> > > > >> >> > > > >> >> > > > >> >> > On Wed, Mar 23, 2022 at 7:15 PM Colm O hEigeartaigh < > > >> cohei...@apache.org> > > >> >> wrote: > > >> >> >> > > >> >> >> The SAML failures were caused by a hard-coded String in SAMLUtils, > > >> >> >> I > > >> >> >> fixed it in CXF master here: > > >> >> >> > > >> >> > > >> https://github.com/apache/cxf/commit/1e90f53f720b76c2dbac910e58ef0b291f98c032 > > >> >> >> > > >> >> >> Colm. > > >> >> >> > > >> >> >> On Tue, Mar 22, 2022 at 12:48 PM Jim Ma > > >> wrote: > > >> >> >> > > > >> >> >> > Hi Colm, > > >> >> >> > > > >> >> >> > Please checkout my working branch : > > >> >> https://github.com/jimma/cxf/tree/wss4j-30-jakarta > > >> >> >> > Build all cxf artifacts first with: mvn clean install > > >> >> >> > -Pfastinstall > > >>
