[GitHub] [cxf] ilgrosso commented on a change in pull request #926: [CXF-8680] Encapsulating getter method resolution in ClientProxyImpl
ilgrosso commented on a change in pull request #926: URL: https://github.com/apache/cxf/pull/926#discussion_r831828614 ## File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java ## @@ -407,6 +410,23 @@ protected static int getBodyIndex(MultivaluedMap map, return index; } +protected static Optional getBeanGetter( Review comment: After looking again at the code, I remember why did I set the new method as `protected static`: there are already a few like * `protected static Annotation[] getMethodAnnotations(Method aMethod, int bodyIndex)` * `protected static void reportInvalidResourceMethod(Method m, String name)` * `protected static int getBodyIndex(MultivaluedMap map,OperationResourceInfo ori)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] ilgrosso commented on a change in pull request #926: [CXF-8680] Encapsulating getter method resolution in ClientProxyImpl
ilgrosso commented on a change in pull request #926: URL: https://github.com/apache/cxf/pull/926#discussion_r831828614 ## File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java ## @@ -407,6 +410,23 @@ protected static int getBodyIndex(MultivaluedMap map, return index; } +protected static Optional getBeanGetter( Review comment: After looking again at the code, I remember why I did set the new method as `protected static`: there are already a few like * `protected static Annotation[] getMethodAnnotations(Method aMethod, int bodyIndex)` * `protected static void reportInvalidResourceMethod(Method m, String name)` * `protected static int getBodyIndex(MultivaluedMap map,OperationResourceInfo ori)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Systest failures with wss4j-3.0.0-SNAPSHOT
Hi Jim,
Which branch are you testing this on in CXF?
Colm.
On Mon, Mar 21, 2022 at 7:26 AM Jim Ma wrote:
>
> Hi Colm,
> After I upgraded wss4j version to 3.0.0-SNAPSHOT(jakarta version) in CXF,
> I got the following ws-security systests failures.
> Could you please help look at if there is still something we need to fix in
> wss4j ? Or we need to fix it in CXF ?
>
> Thanks,
> Jim
>
>
> [ERROR]
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:dom]
> Time elapsed: 0.076 s <<< ERROR!
> jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
> when verifying the message
> at
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
> encountered when verifying the message
> at
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>
> [ERROR]
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:streaming]
> Time elapsed: 0.069 s <<< ERROR!
> jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
> when verifying the message
> at
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
> encountered when verifying the message
> at
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>
> [ERROR]
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:dom]
> Time elapsed: 0.048 s <<< ERROR!
> jakarta.xml.ws.soap.SOAPFaultException:
> javax.xml.stream.XMLStreamException:
> org.apache.wss4j.common.ext.WSSecurityException: A security error was
> encountered when verifying the message
> at
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> Caused by: org.apache.cxf.binding.soap.SoapFault:
> javax.xml.stream.XMLStreamException:
> org.apache.wss4j.common.ext.WSSecurityException: A security error was
> encountered when verifying the message
> at
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
>
> [ERROR]
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:streaming]
> Time elapsed: 0.062 s <<< ERROR!
> jakarta.xml.ws.soap.SOAPFaultException:
> javax.xml.stream.XMLStreamException:
> org.apache.wss4j.common.ext.WSSecurityException: A security error was
> encountered when verifying the message
> at
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> Caused by: org.apache.cxf.binding.soap.SoapFault:
> javax.xml.stream.XMLStreamException:
> org.apache.wss4j.common.ext.WSSecurityException: A security error was
> encountered when verifying the message
> at
> org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> [INFO] Running org.apache.cxf.systest.ws.xkms.XKMSTest
> [ERROR] Tests run: 12, Failures: 0, Errors: 12, Skipped: 0, Time elapsed:
> 1.006 s <<< FAILURE! - in org.apache.cxf.systest.ws.xkms.XKMSTest
> [ERROR]
> org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest[14087:dom]
> Time elapsed: 0.079 s <<< ERROR!
> jakarta.xml.ws.WebServiceException:
> org.apache.cxf.service.factory.ServiceConstructionException: Could not find
> portType named {http://xkms_wsdl._03._2002.w3.org/}XKMSPortType
> at
> org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest(XKMSTest.java:135)
> Caused by: org.apache.cxf.service.factory.ServiceConstructionException:
> Could not find portType named {http://xkms_wsdl._03._
> 2002.w3.org/}XKMSPortType
> at
> org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest(XKMSTest.java:135)
>
> [ERROR]
> org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding[14087:dom]
> Time elapsed: 0.051 s <<< ERROR!
> jakarta.xml.ws.soap.SOAPFaultException: XKMS locate call fails for
> certificate: [application: PKIX; id: CN=bob, OU=eng, O=apache.org]. Error:
> Could not find wsdl:binding operation info for web method locate.
> at
> org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding(XKMSTest.java:211)
> Caused by: org.apache.cxf.xkms.exception.XKMSLocateException: XKMS locate
> call fails for certificate: [application: PKIX; id: CN=bob, OU=eng, O=
> apache.org]. Error: Could not find wsdl:binding operation info for web
> method locate.
> at
> org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding(XKMSTest.java:211)
> Caused by: jakarta.xml.ws.WebServiceException: Could not find wsdl:binding
> operation info for web method locate.
> at
> org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding(XKMSTest.java:211)
>
> [ERROR]
> org.apache.cxf.systest.ws.xkms.XKMSTest.testAsymmetricBinding[14
[GitHub] [cxf] reta commented on a change in pull request #926: [CXF-8680] Encapsulating getter method resolution in ClientProxyImpl
reta commented on a change in pull request #926: URL: https://github.com/apache/cxf/pull/926#discussion_r832066799 ## File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java ## @@ -407,6 +410,23 @@ protected static int getBodyIndex(MultivaluedMap map, return index; } +protected static Optional getBeanGetter( Review comment: 👍 sounds good, LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] ilgrosso merged pull request #926: [CXF-8680] Encapsulating getter method resolution in ClientProxyImpl
ilgrosso merged pull request #926: URL: https://github.com/apache/cxf/pull/926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] ilgrosso commented on pull request #926: [CXF-8680] Encapsulating getter method resolution in ClientProxyImpl
ilgrosso commented on pull request #926: URL: https://github.com/apache/cxf/pull/926#issuecomment-1075067910 Thanks for review @reta ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Systest failures with wss4j-3.0.0-SNAPSHOT
Hi Colm,
Please checkout my working branch :
https://github.com/jimma/cxf/tree/wss4j-30-jakarta
Build all cxf artifacts first with: mvn clean install -Pfastinstall
then go to systests/ws-security, run these tests and you'll get these test
failures.
Please let me know if you have other issues when trying this out.
Thanks,
Jim
On Tue, Mar 22, 2022 at 5:18 PM Colm O hEigeartaigh
wrote:
> Hi Jim,
>
> Which branch are you testing this on in CXF?
>
> Colm.
>
> On Mon, Mar 21, 2022 at 7:26 AM Jim Ma wrote:
> >
> > Hi Colm,
> > After I upgraded wss4j version to 3.0.0-SNAPSHOT(jakarta version) in
> CXF,
> > I got the following ws-security systests failures.
> > Could you please help look at if there is still something we need to fix
> in
> > wss4j ? Or we need to fix it in CXF ?
> >
> > Thanks,
> > Jim
> >
> >
> > [ERROR]
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:dom]
> > Time elapsed: 0.076 s <<< ERROR!
> > jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
> > when verifying the message
> > at
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
> > encountered when verifying the message
> > at
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >
> > [ERROR]
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:streaming]
> > Time elapsed: 0.069 s <<< ERROR!
> > jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
> > when verifying the message
> > at
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> > Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
> > encountered when verifying the message
> > at
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >
> > [ERROR]
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:dom]
> > Time elapsed: 0.048 s <<< ERROR!
> > jakarta.xml.ws.soap.SOAPFaultException:
> > javax.xml.stream.XMLStreamException:
> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
> > encountered when verifying the message
> > at
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> > Caused by: org.apache.cxf.binding.soap.SoapFault:
> > javax.xml.stream.XMLStreamException:
> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
> > encountered when verifying the message
> > at
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> >
> > [ERROR]
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:streaming]
> > Time elapsed: 0.062 s <<< ERROR!
> > jakarta.xml.ws.soap.SOAPFaultException:
> > javax.xml.stream.XMLStreamException:
> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
> > encountered when verifying the message
> > at
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> > Caused by: org.apache.cxf.binding.soap.SoapFault:
> > javax.xml.stream.XMLStreamException:
> > org.apache.wss4j.common.ext.WSSecurityException: A security error was
> > encountered when verifying the message
> > at
> > org.apache.cxf.systest.ws
> .saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
> > [INFO] Running org.apache.cxf.systest.ws.xkms.XKMSTest
> > [ERROR] Tests run: 12, Failures: 0, Errors: 12, Skipped: 0, Time elapsed:
> > 1.006 s <<< FAILURE! - in org.apache.cxf.systest.ws.xkms.XKMSTest
> > [ERROR]
> > org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest[14087:dom]
> > Time elapsed: 0.079 s <<< ERROR!
> > jakarta.xml.ws.WebServiceException:
> > org.apache.cxf.service.factory.ServiceConstructionException: Could not
> find
> > portType named {http://xkms_wsdl._03._2002.w3.org/}XKMSPortType
>
> > at
> > org.apache.cxf.systest.ws
> .xkms.XKMSTest.testRegisterUnitTest(XKMSTest.java:135)
> > Caused by: org.apache.cxf.service.factory.ServiceConstructionException:
> > Could not find portType named {http://xkms_wsdl._03._
> > 2002.w3.org/}XKMSPortType
> > at
> > org.apache.cxf.systest.ws
> .xkms.XKMSTest.testRegisterUnitTest(XKMSTest.java:135)
> >
> > [ERROR]
> > org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding[14087:dom]
> > Time elapsed: 0.051 s <<< ERROR!
> > jakarta.xml.ws.soap.SOAPFaultException: XKMS locate call fails for
> > certificate: [application: PKIX; id: CN=bob, OU=eng, O=apache.org].
> Error:
> > Could not find wsdl:binding operation info for web meth
