Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-21 Thread Jim Ma
Hi Colm,
After I upgraded wss4j version to 3.0.0-SNAPSHOT(jakarta version)  in CXF,
I got the following ws-security systests failures.
Could you please help look at if there is still something we need to fix in
wss4j ? Or we need to fix it in CXF ?

Thanks,
Jim


[ERROR]
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:dom]
 Time elapsed: 0.076 s  <<< ERROR!
jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
when verifying the message
at
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
encountered when verifying the message
at
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)

[ERROR]
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14036:streaming]
 Time elapsed: 0.069 s  <<< ERROR!
jakarta.xml.ws.soap.SOAPFaultException: A security error was encountered
when verifying the message
at
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
Caused by: org.apache.cxf.binding.soap.SoapFault: A security error was
encountered when verifying the message
at
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)

[ERROR]
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:dom]
 Time elapsed: 0.048 s  <<< ERROR!
jakarta.xml.ws.soap.SOAPFaultException:
javax.xml.stream.XMLStreamException:
org.apache.wss4j.common.ext.WSSecurityException: A security error was
encountered when verifying the message
at
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
Caused by: org.apache.cxf.binding.soap.SoapFault:
javax.xml.stream.XMLStreamException:
org.apache.wss4j.common.ext.WSSecurityException: A security error was
encountered when verifying the message
at
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)

[ERROR]
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName[14037:streaming]
 Time elapsed: 0.062 s  <<< ERROR!
jakarta.xml.ws.soap.SOAPFaultException:
javax.xml.stream.XMLStreamException:
org.apache.wss4j.common.ext.WSSecurityException: A security error was
encountered when verifying the message
at
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
Caused by: org.apache.cxf.binding.soap.SoapFault:
javax.xml.stream.XMLStreamException:
org.apache.wss4j.common.ext.WSSecurityException: A security error was
encountered when verifying the message
at
org.apache.cxf.systest.ws.saml.SamlTokenTest.testAudienceRestrictionServiceName(SamlTokenTest.java:1194)
[INFO] Running org.apache.cxf.systest.ws.xkms.XKMSTest
[ERROR] Tests run: 12, Failures: 0, Errors: 12, Skipped: 0, Time elapsed:
1.006 s <<< FAILURE! - in org.apache.cxf.systest.ws.xkms.XKMSTest
[ERROR]
org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest[14087:dom]
 Time elapsed: 0.079 s  <<< ERROR!
jakarta.xml.ws.WebServiceException:
org.apache.cxf.service.factory.ServiceConstructionException: Could not find
portType named {http://xkms_wsdl._03._2002.w3.org/}XKMSPortType
at
org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest(XKMSTest.java:135)
Caused by: org.apache.cxf.service.factory.ServiceConstructionException:
Could not find portType named {http://xkms_wsdl._03._
2002.w3.org/}XKMSPortType
at
org.apache.cxf.systest.ws.xkms.XKMSTest.testRegisterUnitTest(XKMSTest.java:135)

[ERROR]
org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding[14087:dom]
 Time elapsed: 0.051 s  <<< ERROR!
jakarta.xml.ws.soap.SOAPFaultException: XKMS locate call fails for
certificate: [application: PKIX; id: CN=bob, OU=eng, O=apache.org]. Error:
Could not find wsdl:binding operation info for web method locate.
at
org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding(XKMSTest.java:211)
Caused by: org.apache.cxf.xkms.exception.XKMSLocateException: XKMS locate
call fails for certificate: [application: PKIX; id: CN=bob, OU=eng, O=
apache.org]. Error: Could not find wsdl:binding operation info for web
method locate.
at
org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding(XKMSTest.java:211)
Caused by: jakarta.xml.ws.WebServiceException: Could not find wsdl:binding
operation info for web method locate.
at
org.apache.cxf.systest.ws.xkms.XKMSTest.testSymmetricBinding(XKMSTest.java:211)

[ERROR]
org.apache.cxf.systest.ws.xkms.XKMSTest.testAsymmetricBinding[14087:dom]
 Time elapsed: 0.047 s  <<< ERROR!
jakarta.xml.ws.soap.SOAPFaultException: XKMS locate call fails for
certificate: [application: PKIX; id: CN=bob, OU=eng, O=apache.org]. Error:
Could not find wsdl:binding operation info for web method locate.
at
org.apache.cxf.systest.ws.xkms.XKMSTest.testAsymmetricB

[GitHub] [cxf] reta commented on pull request #919: Switching to ActiveMQ Artemis

2022-03-21 Thread GitBox


reta commented on pull request #919:
URL: https://github.com/apache/cxf/pull/919#issuecomment-1073808986


   > @reta I tried to build the jms with the Artemis change. There are couple 
of test failures :
   > 
   > > [ERROR] Failures:
   > > [ERROR]   
JMSDestinationTest.testDoNotCreateSecurityContext:545->testSecurityContext:558->AbstractJMSTester.waitForReceiveDestMessage:278
 Can't receive the Destination message in 10 seconds
   > > [ERROR]   
JMSDestinationTest.testProperty:424->verifyRequestResponseHeaders:303 The 
message encoding should be equal expected: but was:
   > > [ERROR]   JMSDestinationTest.testRoundTripDestination:316 
SecurityContext should be set in message received by JMSDestination
   > > [ERROR]   JMSDestinationTest.testSecurityContext:538 SecurityContext 
should be set in message received by JMSDestination
   > > [ERROR]   JMSDestinationTest.testTemporaryQueueDeletionUponReset:511
   > > Expected: <1>
   > > but: was <0>
   > > [ERROR]   MessageListenerTest.testConnectionProblemXA:98
   > > [ERROR]   
MessageListenerTest.testLocalTransaction:158->testTransactionalBehaviour:176->assertNumMessagesInQueue:212
 Should be rolled back -> number of messages on queue expected:<1> but was:<0>
   > > [ERROR]   
MessageListenerTest.testWithJTA:117->testTransactionalBehaviour:176->assertNumMessagesInQueue:212
 Should be rolled back -> number of messages on queue expected:<1> but was:<0>
   > > [INFO]
   > > [ERROR] Tests run: 65, Failures: 8, Errors: 0, Skipped: 1
   > 
   > Are these some behaviors change or we need to fix the these tests ?
   
   @jimma thank you, those are expected, I mentioned TODOs 
https://github.com/apache/cxf/pull/919#issuecomment-1067260885 a few tests are 
failing but I was planning to address them later on (however we reverted).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cxf] reta commented on a change in pull request #926: [CXF-8680] Encapsulating getter method resolution in ClientProxyImpl

2022-03-21 Thread GitBox


reta commented on a change in pull request #926:
URL: https://github.com/apache/cxf/pull/926#discussion_r83142



##
File path: 
rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java
##
@@ -407,6 +410,23 @@ protected static int 
getBodyIndex(MultivaluedMap map,
 return index;
 }
 
+protected static Optional getBeanGetter(

Review comment:
   Super minor, may be just `getGetter` as a bit more generic name, but no 
strong opinion here. On the other subject, the method is `static` which 
prevents it to be overridden by subclasses, it is by design? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cxf] ilgrosso commented on a change in pull request #926: [CXF-8680] Encapsulating getter method resolution in ClientProxyImpl

2022-03-21 Thread GitBox


ilgrosso commented on a change in pull request #926:
URL: https://github.com/apache/cxf/pull/926#discussion_r831432625



##
File path: 
rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java
##
@@ -407,6 +410,23 @@ protected static int 
getBodyIndex(MultivaluedMap map,
 return index;
 }
 
+protected static Optional getBeanGetter(

Review comment:
   No strong opinion either, about naming.
   I've set it static since it is not accessing anything local in the instance. 
I wasn't aware there is some actual use of subclassing, no issues to remove 
static.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cxf] reta commented on a change in pull request #926: [CXF-8680] Encapsulating getter method resolution in ClientProxyImpl

2022-03-21 Thread GitBox


reta commented on a change in pull request #926:
URL: https://github.com/apache/cxf/pull/926#discussion_r831446414



##
File path: 
rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java
##
@@ -407,6 +410,23 @@ protected static int 
getBodyIndex(MultivaluedMap map,
 return index;
 }
 
+protected static Optional getBeanGetter(

Review comment:
   Gotcha, let's make it `private` than, wdyt? 

##
File path: 
rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java
##
@@ -407,6 +410,23 @@ protected static int 
getBodyIndex(MultivaluedMap map,
 return index;
 }
 
+protected static Optional getBeanGetter(

Review comment:
   Gotcha, let's make it `private static` than, wdyt? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org