Re: [VOTE] cordova-cli 11.0.0 Release

2021-12-18 Thread Niklas Merz
I vote +1:

I checked:

* signature and hash ok
* license and notice look good
* headers look good
* basic tests with cli successfull
* latest android, ios and electron platforms default

On December 17, 2021, Erisu  wrote:
> Please review and vote on this cordova-cli release v11.0.0
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
>
>  https://dist.apache.org/repos/dist/dev/cordova/cli-11.0.0
>
> The package was published from its corresponding git tag:
>
>  cordova-cli: 11.0.0 (94a5b68075)
>
> Upon a successful vote I will upload the archive to dist/, publish it
> to npm, and post the blog post.
>
> Voting guidelines: https://github.com/apache/cordova-
> coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
>
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and sub-
> dependencies have Apache-compatible licenses
> * Ensured the continuous build was green when repo was tagged
> * Ran `npm test`
>
> * Ran `npm audit`
>  8 moderate severity vulnerabilities
>  Five of the vulnerabilities are related to the "insight" dependency,
> a production dependency.
>  The suggested solution by npm, to downgrade to `insight@0.8.4`, is
> not a viable solution. The current version which we are using
> introduced macOS Monteray support. Downgrading will break support for
> macOS users.
>
> * Ran various `cordova` test w/ sample app:
>  * `cordova`
>  * `cordova -v`
>  * `cordova create`
>  * `cordova info`
>  * `cordova help`
>  * `cordova config ls`
>  * `cordova requirements`
>  * `cordova telemetry`
>  * `cordova plugin`
>  * `cordova plugin add`
>  * `cordova plugin rm`
>  * `cordova platform`
>  * `cordova platform add`
>  * `cordova platform rm`
>  * `cordova build`
>  * `cordova prepare`
>  * `cordova compile`
>  * `cordova run`
>  * `cordova serve`


Re: [VOTE] cordova-cli 11.0.0 Release

2021-12-18 Thread pieter van poyer
I vote +1:

* changes look good.

Kind regards
Pieter Van Poyer

Op za 18 dec. 2021 om 13:09 schreef Niklas Merz :

> I vote +1:
>
> I checked:
>
> * signature and hash ok
> * license and notice look good
> * headers look good
> * basic tests with cli successfull
> * latest android, ios and electron platforms default
>
> On December 17, 2021, Erisu  wrote:
> > Please review and vote on this cordova-cli release v11.0.0
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> >
> >  https://dist.apache.org/repos/dist/dev/cordova/cli-11.0.0
> >
> > The package was published from its corresponding git tag:
> >
> >  cordova-cli: 11.0.0 (94a5b68075)
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > Voting guidelines: https://github.com/apache/cordova-
> > coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> >
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and sub-
> > dependencies have Apache-compatible licenses
> > * Ensured the continuous build was green when repo was tagged
> > * Ran `npm test`
> >
> > * Ran `npm audit`
> >  8 moderate severity vulnerabilities
> >  Five of the vulnerabilities are related to the "insight" dependency,
> > a production dependency.
> >  The suggested solution by npm, to downgrade to `insight@0.8.4`, is
> > not a viable solution. The current version which we are using
> > introduced macOS Monteray support. Downgrading will break support for
> > macOS users.
> >
> > * Ran various `cordova` test w/ sample app:
> >  * `cordova`
> >  * `cordova -v`
> >  * `cordova create`
> >  * `cordova info`
> >  * `cordova help`
> >  * `cordova config ls`
> >  * `cordova requirements`
> >  * `cordova telemetry`
> >  * `cordova plugin`
> >  * `cordova plugin add`
> >  * `cordova plugin rm`
> >  * `cordova platform`
> >  * `cordova platform add`
> >  * `cordova platform rm`
> >  * `cordova build`
> >  * `cordova prepare`
> >  * `cordova compile`
> >  * `cordova run`
> >  * `cordova serve`
>