Re: [discuss] plugins release

[Kelvin Dart]

I will make these pulls later this afternoon. I'll respond here with the
PRs when raised.

Kelvin


Best regards,
Kelvin

On 18 October 2017 at 00:25, Steven Gill  wrote:

> Going to try to start it later this week. Still waiting on a few prs to
> come in around removing compat. May just make some of those changes myself.
> Going to look at doing a larger release this time.
>
> I know the following definitely need to go out.
>
> cordova-plugin-status-bar
> cordova-plugin-file-transfer
>
> Post the PRs i should be looking at.
>

Re: [discuss] plugins release

[julio cesar sanchez]

I have some PRs that I've not merged because of Android tests failing (any
of my PRs is for Android), not sure if it's ok to merge them.

https://github.com/apache/cordova-plugin-camera/pull/291
https://github.com/apache/cordova-plugin-geolocation/pull/94
https://github.com/apache/cordova-plugin-media-capture/pull/83
https://github.com/apache/cordova-plugin-media/pull/148
https://github.com/apache/cordova-plugin-statusbar/pull/89


2017-10-18 9:33 GMT+02:00 Kelvin Dart :

> I will make these pulls later this afternoon. I'll respond here with the
> PRs when raised.
>
> Kelvin
>
>
> Best regards,
> Kelvin
>
> On 18 October 2017 at 00:25, Steven Gill  wrote:
>
> > Going to try to start it later this week. Still waiting on a few prs to
> > come in around removing compat. May just make some of those changes
> myself.
> > Going to look at doing a larger release this time.
> >
> > I know the following definitely need to go out.
> >
> > cordova-plugin-status-bar
> > cordova-plugin-file-transfer
> >
> > Post the PRs i should be looking at.
> >
>

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[zaq962]

Github user zaq962 commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
how can i resove it, I have the same problem


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[OminousWater]

Github user OminousWater commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
@zaq962 if you apply the changes in my pull request (it's just one file) to 
your local checkout, it should work fine. The only reason it doesn't pass the 
continuous integration test is that 'package' is a reserved keyword, which 
eslint doesn't like. I've been experimenting with fixing the problem on the 
plugman side, by renaming the 'package' keyword there, which would be a better 
fix arguably. If I get that working then I'll re-open the pull request against 
the plugman source.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[OminousWater]

Github user OminousWater commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
@zaq962 I think I have the "correct" fix now, am about to open another pull 
request.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[OminousWater]

Github user OminousWater commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
OK I understand the problem better now. init-package-json (a separate npm 
module) initialises the global variable 'package' in init-package-json.js. So 
ideally init-package-json would use a different variable name, but I guess the 
maintainers of that package might not have as strict a requirement as the 
cordova-lib maintainers. I've opened a separate pull request with a compromise 
solution here: https://github.com/npm/init-package-json/pull/74, hopefully they 
will accept (or have a better solution).


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ANNOUNCE] Cordova iOS Release

[Suraj Pindoria]

Tweet: https://twitter.com/apachecordova/status/920748921080594432
Blog: https://cordova.apache.org/announcements/2017/10/16/ios-release.html

Re: [discuss] plugins release

[Kelvin Dart]

cordova-plugin-compat has been removed and PRs for relevant plugins has been 
raised here:

https://github.com/apache/cordova-plugin-camera/pull/293 

https://github.com/apache/cordova-plugin-contacts/pull/156 

https://github.com/apache/cordova-plugin-file/pull/220 

https://github.com/apache/cordova-plugin-file-transfer/pull/192 

https://github.com/apache/cordova-plugin-geolocation/pull/96 

https://github.com/apache/cordova-plugin-media/pull/151 

https://github.com/apache/cordova-plugin-media-capture/pull/85 


Kelvin

> On 18 Oct 2017, at 08:57, julio cesar sanchez  wrote:
> 
> I have some PRs that I've not merged because of Android tests failing (any
> of my PRs is for Android), not sure if it's ok to merge them.
> 
> https://github.com/apache/cordova-plugin-camera/pull/291
> https://github.com/apache/cordova-plugin-geolocation/pull/94
> https://github.com/apache/cordova-plugin-media-capture/pull/83
> https://github.com/apache/cordova-plugin-media/pull/148
> https://github.com/apache/cordova-plugin-statusbar/pull/89
> 
> 
> 2017-10-18 9:33 GMT+02:00 Kelvin Dart :
> 
>> I will make these pulls later this afternoon. I'll respond here with the
>> PRs when raised.
>> 
>> Kelvin
>> 
>> 
>> Best regards,
>> Kelvin
>> 
>> On 18 October 2017 at 00:25, Steven Gill  wrote:
>> 
>>> Going to try to start it later this week. Still waiting on a few prs to
>>> come in around removing compat. May just make some of those changes
>> myself.
>>> Going to look at doing a larger release this time.
>>> 
>>> I know the following definitely need to go out.
>>> 
>>> cordova-plugin-status-bar
>>> cordova-plugin-file-transfer
>>> 
>>> Post the PRs i should be looking at.
>>> 
>> 

Re: [discuss] plugins release

[Steven Gill]

Yay! I'll review soon and make sure they make it in for the release

On Wed, Oct 18, 2017 at 4:17 PM, Kelvin Dart  wrote:

> cordova-plugin-compat has been removed and PRs for relevant plugins has
> been raised here:
>
> https://github.com/apache/cordova-plugin-camera/pull/293 <
> https://github.com/apache/cordova-plugin-camera/pull/293>
> https://github.com/apache/cordova-plugin-contacts/pull/156 <
> https://github.com/apache/cordova-plugin-contacts/pull/156>
> https://github.com/apache/cordova-plugin-file/pull/220 <
> https://github.com/apache/cordova-plugin-file/pull/220>
> https://github.com/apache/cordova-plugin-file-transfer/pull/192 <
> https://github.com/apache/cordova-plugin-file-transfer/pull/192>
> https://github.com/apache/cordova-plugin-geolocation/pull/96 <
> https://github.com/apache/cordova-plugin-geolocation/pull/96>
> https://github.com/apache/cordova-plugin-media/pull/151 <
> https://github.com/apache/cordova-plugin-media/pull/151>
> https://github.com/apache/cordova-plugin-media-capture/pull/85 <
> https://github.com/apache/cordova-plugin-media-capture/pull/85>
>
> Kelvin
>
> > On 18 Oct 2017, at 08:57, julio cesar sanchez 
> wrote:
> >
> > I have some PRs that I've not merged because of Android tests failing
> (any
> > of my PRs is for Android), not sure if it's ok to merge them.
> >
> > https://github.com/apache/cordova-plugin-camera/pull/291
> > https://github.com/apache/cordova-plugin-geolocation/pull/94
> > https://github.com/apache/cordova-plugin-media-capture/pull/83
> > https://github.com/apache/cordova-plugin-media/pull/148
> > https://github.com/apache/cordova-plugin-statusbar/pull/89
> >
> >
> > 2017-10-18 9:33 GMT+02:00 Kelvin Dart :
> >
> >> I will make these pulls later this afternoon. I'll respond here with the
> >> PRs when raised.
> >>
> >> Kelvin
> >>
> >>
> >> Best regards,
> >> Kelvin
> >>
> >> On 18 October 2017 at 00:25, Steven Gill 
> wrote:
> >>
> >>> Going to try to start it later this week. Still waiting on a few prs to
> >>> come in around removing compat. May just make some of those changes
> >> myself.
> >>> Going to look at doing a larger release this time.
> >>>
> >>> I know the following definitely need to go out.
> >>>
> >>> cordova-plugin-status-bar
> >>> cordova-plugin-file-transfer
> >>>
> >>> Post the PRs i should be looking at.
> >>>
> >>
>
>

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/597
  
I think turning it back to `package` in plugman is the way to go. We can 
add an eslint exception for it I hope


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #518 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #518 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/518/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org