[GitHub] cordova-plugin-file-transfer issue #163: CB-12100 (ios) Fixed test plugin in...

2016-11-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/163
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts pull request #139: CB-11975 iOS: Search on contacts'...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer issue #164: Removed warning

2016-11-02 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/164
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request #164: Removed warning

2016-11-02 Thread lucatorella
GitHub user lucatorella opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/164

Removed warning

### Platforms affected
iOS

### What does this PR do?
Remove a warning

### What testing has been done on this change?
Run unit tests

### Checklist
- [] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.

Just a small change to avoid a warning

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lucatorella/cordova-plugin-file-transfer 
patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #164


commit b47fb35771230058002b58e803b03aef1e1b0d93
Author: Luca Torella 
Date:   2016-11-02T08:24:47Z

Removed warning

Just a small change to avoid a warning




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows issue #208: CB-12071 Fix for CB-11825 breaks usage of InProc...

2016-11-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/208
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request #163: CB-12100 (ios) Fixed test pl...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/163


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request #208: CB-12071 Fix for CB-11825 breaks usage of...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/208


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [NODE] Can we drop node 0.x support?

2016-11-02 Thread Alexander Sorokin (Akvelon)
Hey guys,

Where are we with dropping node 0.x support? Can we start removing Travis and 
AppVeryor configs for it and using the features Node 4+ provides?

Thanks,
Alexander Sorokin

-Original Message-
From: Shazron [mailto:shaz...@gmail.com] 
Sent: Monday, August 15, 2016 11:59 AM
To: dev@cordova.apache.org
Subject: Re: [NODE] Can we drop node 0.x support?

Also node.js 6.3.0 now supports the --inspect option, which means we can debug 
cordova using Chrome Dev Tools:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fmobile.twitter.com%2fnodejs%2fstatus%2f763782055788445696&data=01%7c01%7cv-alsoro%40microsoft.com%7c747bf3b25ba64dc7003908d3c4ea885d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yl2QTEK2DRe6RXoz2lRvAmYAayW1OdUMlrM08MGJIm0%3d
 (although the flag is deemed "experimental")

On Mon, Aug 15, 2016 at 1:30 AM, Shazron  wrote:

> Sorry, I meant to say Node 7 will be "current" in Oct 2016, this year 
> -- not 2017.
>
> On Mon, Aug 15, 2016 at 1:29 AM, Shazron  wrote:
>
>> Our docs just specify "Download and install Node.js" which points to 
>> the LTS version 4.4.7 at 
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fnode
>> js.org%2fen%2fdownload%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c747bf3b25ba64dc7003908d3c4ea885d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Lx3NlDxS7UdkDCBhmAvZkyFReTj3rzT71I2qK45QiP0%3d
>>  . If we want to support Node 6 (current version as of this email), we need 
>> to point that to 
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fnodejs.org%2fen%2fdownload%2fcurrent%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c747bf3b25ba64dc7003908d3c4ea885d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cvrZc1crnrCyTa6IP4ODA5NKzjl4ky5Pmb%2bG6Gnicw8%3d
>>  instead.
>>
>> Since our code all works on Node 6 already, I would say we should 
>> jump to version 6 as a requirement, and update the docs to point to 
>> Node 6. Node 4 LTS ends 2018-04-01 while Node 6 LTS starts this Oct 
>> 2016 and ends 2019-04-01. Since Node 6 will LTS pretty soon, we 
>> should just jump to that straight away.
>>
>> Consequently Node 7 will be "current" in Oct 2017. One of the 
>> significant things about Node 7 is, according to 
>> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fnode.
>> green%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c747bf3b25ba64dc700
>> 3908d3c4ea885d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=r91acKoSh
>> 6MGQdMZwkgiGyHv2bEqxcGVeodfAkHtCzQ%3d, 99% ES6
>> (ES2015) support and 100% ES7 (ES2016) support.
>>
>> I can setup the JIRA issues to update all our Travis and Appveyor 
>> versions required.
>>
>>
>>
>> On Sun, Aug 14, 2016 at 11:41 PM, Vladimir Kotikov (Akvelon) < 
>> v-vlk...@microsoft.com> wrote:
>>
>>> There should not be any problems AFAIK.
>>> Last problems have been resolved in cordova@6.2.0 (
>>> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcord
>>> ova.apache.org%2fnews%2f2016%2f05%2f24%2ftools-release.html&data=01%
>>> 7c01%7cv-alsoro%40microsoft.com%7c747bf3b25ba64dc7003908d3c4ea885d%7
>>> c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yYvNrFxxoIc9KDpKTrcj1r09
>>> 3PPZqGWh4mM0%2fxuJY4g%3d)
>>>
>>> -
>>> Best regards, Vladimir
>>>
>>>
>>> -Original Message-
>>> From: Victor Sosa [mailto:sosah.vic...@gmail.com]
>>> Sent: Sunday, August 14, 2016 8:41 PM
>>> To: dev@cordova.apache.org
>>> Subject: Re: [NODE] Can we drop node 0.x support?
>>>
>>> +1
>>> Also, I've been away from Cordova lately. Does already support v6.x? 
>>> As far as I recall there were problems with it.
>>>
>>> On Sun, Aug 14, 2016, 12:40 AM Steven Gill 
>>> wrote:
>>>
>>> > Yay!
>>> >
>>> > On Aug 12, 2016 9:57 PM, "Simon MacDonald" 
>>> > 
>>> > wrote:
>>> >
>>> > > +1
>>> > >
>>> > >
>>> > > Simon Mac Donald
>>> > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
>>> > > hi.i
>>> > > m%2fsimonmacdonald&data=01%7c01%7cv-vlkoti%40microsoft.com%7c233
>>> > > e798 
>>> > > 4d03f4caf0d8f08d3c46a3753%7c72f988bf86f141af91ab2d7cd011db47%7c1
>>> > > &sda ta=XC6xDMaKyUdqWxzRd8s6uBdSO5Mtr0r7MdhOuU%2f1dFw%3d
>>> > >
>>> > > On Fri, Aug 12, 2016 at 10:26 PM, Kerri Shotts 
>>> > > 
>>> > > wrote:
>>> > >
>>> > > > +1 as well
>>> > > > Kerri
>>> > > >
>>> > > >
>>> > > >
>>> > > > On Fri, Aug 12, 2016 at 8:18 PM -0500, "Jesse" <
>>> > purplecabb...@gmail.com>
>>> > > > wrote:
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > > +1
>>> > > > Please!
>>> > > >
>>> > > > > On Aug 12, 2016, at 5:43 PM, Shazron  wrote:
>>> > > > >
>>> > > > > cordova-lib engine says we still do support 0.x:
>>> > > > > https://github.com/apache/cordova-lib/blob/
>>> > > > 2a178662acfad9c779114fddd815e484fc1b6f1d/cordova-lib/package.j
>>> > > > son#
>>> > > > L16
>>> > > > >
>>> > > > > Can we drop support? Seems time.
>>> > > > >
>>> > > > > See:
>>> > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%
>>> > > > > 2f%2
>>> > > > > ftwitter.com%2ffeross

RE: Nightly build #204 for cordova has failed

2016-11-02 Thread Alexander Sorokin (Akvelon)
The builds should be green now. I've enabled the email notifications again.

-Original Message-
From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] 
Sent: Tuesday, November 1, 2016 4:53 PM
To: dev@cordova.apache.org
Subject: RE: Nightly build #204 for cordova has failed

I am taking a look at the failure.

This time it seems to be the npm issue. I've disabled the email notifications 
until I sort it out.

Thanks,
Alexander Sorokin

-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Tuesday, November 1, 2016 1:37 PM
To: Vladimir Kotikov (Akvelon) ; dev@cordova.apache.org
Subject: Nightly build #204 for cordova has failed

Nightly build #204 for cordova has failed.

Please check failure details on build details page at 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.apache.org%2Fjob%2Fcordova-nightly%2F204%2F&data=02%7C01%7Cv-alsoro%40microsoft.com%7C2f8702bc697349f1bcdd08d402431c28%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636135934644369476&sdata=RcTP8JK4eS5H9Pq5D4NY9kMjZmYYjsT1Gpu2POdlULc%3D&reserved=0
You can also take a look at build console: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.apache.org%2Fjob%2Fcordova-nightly%2F204%2FconsoleFull&data=02%7C01%7Cv-alsoro%40microsoft.com%7C2f8702bc697349f1bcdd08d402431c28%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636135934644369476&sdata=qULG5XUMBdsaSXreotxW0h0t%2Bsui3jt74Mc5cd0%2BP7Q%3D&reserved=0

-
Jenkins for Apache Cordova
Т�ХF�
V�7V'67&�&R�R���âFWb�V�7V'67&�&T6�&F�f�6�R��&pФf�"FF�F����6����G2�R���âFWbֆV�6�&F�f�6�R��&p


[GitHub] cordova-plugin-file-transfer issue #164: Removed warning

2016-11-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/164
  
Test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer issue #164: Removed warning

2016-11-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/164
  
CI, ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts issue #136: CB-11028 android: Allow to set custom la...

2016-11-02 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/136
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/136/commits/256f8393c441aa16d9a1272e9ef8ed4b3ffceaaa)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/50//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts issue #136: CB-11028 android: Allow to set custom la...

2016-11-02 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/136
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/136/commits/13e968e6096e024fceb7460e8ddc04ad286b75c2)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/51//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts issue #136: CB-11028 android: Allow to set custom la...

2016-11-02 Thread alsorokin
Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/136
  
Disregard these two comments, it was just me removing extra builds from the 
queue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts issue #136: CB-11028 android: Allow to set custom la...

2016-11-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/136
  
@alsorokin to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts issue #136: CB-11028 android: Allow to set custom la...

2016-11-02 Thread alsorokin
Github user alsorokin commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/136
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts issue #136: CB-11028 android: Allow to set custom la...

2016-11-02 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/136
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/136/commits/76f695ef9d151638c80d13ac1b4e2cbc9a781589)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/52//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts pull request #136: CB-11028 android: Allow to set cu...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/136


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[DISCUSS] Cordova-Android 6.1 Release

2016-11-02 Thread Joe Bowser
Hey

While people have been talking about how critical their fix is for Cordova,
I actually found a critical issue that we missed in Cordova w.r.t builds
failing with Android Studio based projects, so I rushed some commits in for
Cordova-Android 6.1 release.

The reason that this is 6.1 and 6.01 is because we're also bumping the API
level to 25 so that we can support the latest version of Android out in the
wild, which is on the Google Pixel.  There's no real difference between the
two, and the current beta is actually 7.1.1.

BTW, it would be helpful if more people tested this release before we go
and vote on it so we don't have to do a 6.1.1.  The Apache process makes
releasing time-intensive, and I'd rather be working instead of waiting
around for things to be released over and over again.

What are people's thoughts on this?

Joe


[GitHub] cordova-plugin-camera issue #235: CB-11625: Fixes Camera issue w.r.t. conten...

2016-11-02 Thread samuelt1
Github user samuelt1 commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/235
  
i tried to run your fix, but got this after building the code

`Error: 
/Users/samuel/Documents/Apps/neurosurgery-app/platforms/android/gradlew: 
Command failed with exit code 1 Error output:
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

/Users/samuel/Documents/Apps/neurosurgery-app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:32:
 error: cannot find symbol
import org.apache.cordova.BuildHelper;
 ^
  symbol:   class BuildHelper
  location: package org.apache.cordova

/Users/samuel/Documents/Apps/neurosurgery-app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:140:
 error: cannot find symbol
this.applicationId = (String) 
BuildHelper.getBuildConfigValue(cordova.getActivity(), "APPLICATION_ID");
  ^
  symbol:   variable BuildHelper
  location: class CameraLauncher
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or 
--debug option to get more log output.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera issue #235: CB-11625: Fixes Camera issue w.r.t. conten...

2016-11-02 Thread infil00p
Github user infil00p commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/235
  
@samuelt1 cordova-plugin-compat has not been released, and you need the 
BuildHelper class to use this plugin so that the FilesProvider can actually 
work.  This is done so that the plugin can work on 5.x and 6.0 versions of 
Cordova.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device-orientation pull request #31: CB-9179 (ios) Fixed true...

2016-11-02 Thread alsorokin
GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-device-orientation/pull/31

CB-9179 (ios) Fixed trueHeading being always 0

### Platforms affected
iOS

### What does this PR do?
Fixes https://issues.apache.org/jira/browse/CB-9179
trueHeading is always 0 on iOS

### What testing has been done on this change?
Tested manually on iPhone 6S Plus

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change. - 
_added manual test_



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-device-orientation 
CB-9179

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device-orientation/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit c33285c165231f06c7ac85929fb157c29bccd6c9
Author: alsorokin 
Date:   2016-11-02T16:03:01Z

CB-9179 (ios) Fixed trueHeading being always 0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera issue #241: Make the path support Android N.

2016-11-02 Thread samuelt1
Github user samuelt1 commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/241
  
i get the following when i run your code

`Attempt to invoke virtual method 'android.content.res.XmlResourceParser 
android.content.pm.PackageItemInfo.loadXmlMetaData(android.content.pm.PackageManager,
 java.lang.String)' on a null object reference`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Android 6.1 Release

2016-11-02 Thread Steven Gill
+1

On Wed, Nov 2, 2016 at 9:06 AM, Joe Bowser  wrote:

> Hey
>
> While people have been talking about how critical their fix is for Cordova,
> I actually found a critical issue that we missed in Cordova w.r.t builds
> failing with Android Studio based projects, so I rushed some commits in for
> Cordova-Android 6.1 release.
>
> The reason that this is 6.1 and 6.01 is because we're also bumping the API
> level to 25 so that we can support the latest version of Android out in the
> wild, which is on the Google Pixel.  There's no real difference between the
> two, and the current beta is actually 7.1.1.
>
> BTW, it would be helpful if more people tested this release before we go
> and vote on it so we don't have to do a 6.1.1.  The Apache process makes
> releasing time-intensive, and I'd rather be working instead of waiting
> around for things to be released over and over again.
>
> What are people's thoughts on this?
>
> Joe
>


Re: [DISCUSS] Cordova-Android 6.1 Release

2016-11-02 Thread Shazron
+1
For those not using Android daily, also give us guidance on testing areas
of focus

On Wed, Nov 2, 2016 at 9:06 AM, Joe Bowser  wrote:

> Hey
>
> While people have been talking about how critical their fix is for Cordova,
> I actually found a critical issue that we missed in Cordova w.r.t builds
> failing with Android Studio based projects, so I rushed some commits in for
> Cordova-Android 6.1 release.
>
> The reason that this is 6.1 and 6.01 is because we're also bumping the API
> level to 25 so that we can support the latest version of Android out in the
> wild, which is on the Google Pixel.  There's no real difference between the
> two, and the current beta is actually 7.1.1.
>
> BTW, it would be helpful if more people tested this release before we go
> and vote on it so we don't have to do a 6.1.1.  The Apache process makes
> releasing time-intensive, and I'd rather be working instead of waiting
> around for things to be released over and over again.
>
> What are people's thoughts on this?
>
> Joe
>


Re: [DISCUSS] Cordova-Android 6.1 Release

2016-11-02 Thread Simon MacDonald
Sounds good Joe. Can you re-post the official process/doc on how to verify
a cordova-android release for those who may be doing it for the first time?


Simon Mac Donald
http://simonmacdonald.com

On Wed, Nov 2, 2016 at 2:12 PM, Shazron  wrote:

> +1
> For those not using Android daily, also give us guidance on testing areas
> of focus
>
> On Wed, Nov 2, 2016 at 9:06 AM, Joe Bowser  wrote:
>
> > Hey
> >
> > While people have been talking about how critical their fix is for
> Cordova,
> > I actually found a critical issue that we missed in Cordova w.r.t builds
> > failing with Android Studio based projects, so I rushed some commits in
> for
> > Cordova-Android 6.1 release.
> >
> > The reason that this is 6.1 and 6.01 is because we're also bumping the
> API
> > level to 25 so that we can support the latest version of Android out in
> the
> > wild, which is on the Google Pixel.  There's no real difference between
> the
> > two, and the current beta is actually 7.1.1.
> >
> > BTW, it would be helpful if more people tested this release before we go
> > and vote on it so we don't have to do a 6.1.1.  The Apache process makes
> > releasing time-intensive, and I'd rather be working instead of waiting
> > around for things to be released over and over again.
> >
> > What are people's thoughts on this?
> >
> > Joe
> >
>


[GitHub] cordova-plugin-device-orientation issue #31: CB-9179 (ios) Fixed trueHeading...

2016-11-02 Thread cordova-qa
Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/31
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-device-orientation/pull/31/commits/c33285c165231f06c7ac85929fb157c29bccd6c9)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/16//PLATFORM=android/artifact/)
 |
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Android 6.1 Release

2016-11-02 Thread Joe Bowser
Hey

Look under "What to Test" on this document to see the basics of What to
Test:
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md

However, this will obviously not catch everything, so people who actually
use the CLI to do development should probably try to make an app with the
new version once it's up for voting, or even before by checking out the
repository and installing it.

On Wed, Nov 2, 2016 at 11:26 AM, Simon MacDonald 
wrote:

> Sounds good Joe. Can you re-post the official process/doc on how to verify
> a cordova-android release for those who may be doing it for the first time?
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Wed, Nov 2, 2016 at 2:12 PM, Shazron  wrote:
>
> > +1
> > For those not using Android daily, also give us guidance on testing areas
> > of focus
> >
> > On Wed, Nov 2, 2016 at 9:06 AM, Joe Bowser  wrote:
> >
> > > Hey
> > >
> > > While people have been talking about how critical their fix is for
> > Cordova,
> > > I actually found a critical issue that we missed in Cordova w.r.t
> builds
> > > failing with Android Studio based projects, so I rushed some commits in
> > for
> > > Cordova-Android 6.1 release.
> > >
> > > The reason that this is 6.1 and 6.01 is because we're also bumping the
> > API
> > > level to 25 so that we can support the latest version of Android out in
> > the
> > > wild, which is on the Google Pixel.  There's no real difference between
> > the
> > > two, and the current beta is actually 7.1.1.
> > >
> > > BTW, it would be helpful if more people tested this release before we
> go
> > > and vote on it so we don't have to do a 6.1.1.  The Apache process
> makes
> > > releasing time-intensive, and I'd rather be working instead of waiting
> > > around for things to be released over and over again.
> > >
> > > What are people's thoughts on this?
> > >
> > > Joe
> > >
> >
>


[GitHub] cordova-plugin-camera issue #235: CB-11625: Fixes Camera issue w.r.t. conten...

2016-11-02 Thread samuelt1
Github user samuelt1 commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/235
  
@infil00p I got it working now thanks alot!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #343: CB-12077: Fix paths for Android icons/splashscre...

2016-11-02 Thread mattroth
Github user mattroth commented on the issue:

https://github.com/apache/cordova-android/pull/343
  
Does anyone have a work around?  How can I update cordova-android on my 
development machine with this above fix prior to the next release?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request #347: CB-12111: rewrite to use retro js

2016-11-02 Thread purplecabbage
GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-android/pull/347

CB-12111: rewrite to use retro js



### Platforms affected
Android

### What does this PR do?
fixes JS tooling so it will still run in node v0.10 + v0.12

### What testing has been done on this change?
npm test + jshint on the affected file

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-android CB-12111

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #347


commit 6c285e0a8c4ad268637fa7252df2e9566af01a50
Author: Jesse MacFadyen 
Date:   2016-11-02T22:17:53Z

rewrite to use retro js




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[VOTE] cordova-plugin-compat@1.1.0 Release

2016-11-02 Thread Steven Gill
Please review and vote on the release of this cordova-plugin-compat release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-12110

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-12110/

The packages were published from their corresponding git tags:
cordova-plugin-compat: 1.1.0 (dd416cc807)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran mobile-spec


Re: [VOTE] cordova-plugin-compat@1.1.0 Release

2016-11-02 Thread Joe Bowser
I vote +1
* Ran coho check-licence
* Ran coho verify-archive
* Ran mobile-spec

On Wed, Nov 2, 2016 at 3:36 PM, Steven Gill  wrote:

> Please review and vote on the release of this cordova-plugin-compat release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-12110
>
> The plugins have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-12110/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-compat: 1.1.0 (dd416cc807)
>
> Upon a successful vote I will upload the archives to dist/, upload
> them to npm, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> How to vote on a plugins release at
> https://github.com/apache/cordova-coho/blob/master/docs/
> plugins-release-process.md#voting
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran mobile-spec
>


[GitHub] cordova-android pull request #347: CB-12111: rewrite to use retro js

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/347


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



How to setup cordova mobilespec with CLI

2016-11-02 Thread Fu, Junwei

Hi All,

The steps of following the 
documentation are too complex 
and All of repos need to pull the master branch, Do we have steps to build 
mobile spec with released CLI.


$ git clone https://github.com/apache/cordova-mobile-spec.git

$ git clone https://github.com/apache/cordova-lib.git

$ git clone https://github.com/apache/cordova-cli.git

$ git clone https://github.com/apache/cordova-plugman.git

$ git clone https://github.com/apache/cordova-js.git

$ git clone https://github.com/apache/cordova-coho.git

$ git clone https://github.com/apache/cordova-android.git

$ cordova-mobile-spec/createmobilespec/createmobilespec.js -android

$ cd mobilespec

$./cordova run android



Thanks,

Junwei.




Re: How to setup cordova mobilespec with CLI

2016-11-02 Thread Joe Bowser
Hey

You should start with coho, then use that to fetch the rest of the
directories as found here:
https://github.com/apache/cordova-coho

It's our repo-management tool for dealing with all the git repositories.
It's similar to how repo is used with AOSP, but a bit different in that
it's more focused on fetching repos and processing releases with Javascript.

BTW: Our master branch isn't on github, it's actually on the ASF
repositories which GitHub mirrors.  Here's an example of the git-web
interface for Cordova Android:
https://git1-us-west.apache.org/repos/asf?p=cordova-android.git

But Coho pulls those, and changes happen directly on that repository and
find their way back to the GitHub mirrors.  We use the github mirrors to
process patches.

It would be a very good idea for the mobilespec documentation to be
updated, since it seems to be misleading.


On Wed, Nov 2, 2016 at 6:37 PM, Fu, Junwei  wrote:

>
> Hi All,
>
> The steps of following the documentation com/apache/cordova-mobile-spec> are too complex and All of repos need to
> pull the master branch, Do we have steps to build mobile spec with released
> CLI.
>
>
> $ git clone https://github.com/apache/cordova-mobile-spec.git
>
> $ git clone https://github.com/apache/cordova-lib.git
>
> $ git clone https://github.com/apache/cordova-cli.git
>
> $ git clone https://github.com/apache/cordova-plugman.git
>
> $ git clone https://github.com/apache/cordova-js.git
>
> $ git clone https://github.com/apache/cordova-coho.git
>
> $ git clone https://github.com/apache/cordova-android.git
>
> $ cordova-mobile-spec/createmobilespec/createmobilespec.js -android
>
> $ cd mobilespec
>
> $./cordova run android
>
>
>
> Thanks,
>
> Junwei.
>
>
>


Re: How to setup cordova mobilespec with CLI

2016-11-02 Thread Joe Bowser
I just realized that it's not the whole answer.  Once you fetch the
repositories and clone them down all in a cordova directory, you should
then be able to run the command, since you'll have all the repositories
locally.  You should also make sure to get the cordova-plugin-compat plugin
that allows plugins to work with earlier Cordova versions temporarily until
we move the classes directly into Cordova proper.

BTW: This is a bit off-topic, but is there any update on when we can use
Crosswalk with Android Studio?  We're currently using a flag to allow it to
keep compiling with Cordova, but it would be good to be able to debug a
project in Android Studio that uses Crosswalk.

On Wed, Nov 2, 2016 at 6:47 PM, Joe Bowser  wrote:

> Hey
>
> You should start with coho, then use that to fetch the rest of the
> directories as found here:
> https://github.com/apache/cordova-coho
>
> It's our repo-management tool for dealing with all the git repositories.
> It's similar to how repo is used with AOSP, but a bit different in that
> it's more focused on fetching repos and processing releases with Javascript.
>
> BTW: Our master branch isn't on github, it's actually on the ASF
> repositories which GitHub mirrors.  Here's an example of the git-web
> interface for Cordova Android:
> https://git1-us-west.apache.org/repos/asf?p=cordova-android.git
>
> But Coho pulls those, and changes happen directly on that repository and
> find their way back to the GitHub mirrors.  We use the github mirrors to
> process patches.
>
> It would be a very good idea for the mobilespec documentation to be
> updated, since it seems to be misleading.
>
>
> On Wed, Nov 2, 2016 at 6:37 PM, Fu, Junwei  wrote:
>
>>
>> Hi All,
>>
>> The steps of following the documentation> om/apache/cordova-mobile-spec> are too complex and All of repos need to
>> pull the master branch, Do we have steps to build mobile spec with released
>> CLI.
>>
>>
>> $ git clone https://github.com/apache/cordova-mobile-spec.git
>>
>> $ git clone https://github.com/apache/cordova-lib.git
>>
>> $ git clone https://github.com/apache/cordova-cli.git
>>
>> $ git clone https://github.com/apache/cordova-plugman.git
>>
>> $ git clone https://github.com/apache/cordova-js.git
>>
>> $ git clone https://github.com/apache/cordova-coho.git
>>
>> $ git clone https://github.com/apache/cordova-android.git
>>
>> $ cordova-mobile-spec/createmobilespec/createmobilespec.js -android
>>
>> $ cd mobilespec
>>
>> $./cordova run android
>>
>>
>>
>> Thanks,
>>
>> Junwei.
>>
>>
>>
>


Nightly build #215 for cordova has succeeded!

2016-11-02 Thread Apache Jenkins Server
Nightly build #215 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/215/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: How to setup cordova mobilespec with CLI

2016-11-02 Thread Fu, Junwei
The Cordova project of Crosswalk plugin can be compiled with the documentation 
http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#opening-a-project-in-android-studio
 , it also can be debugged for Java code with Android studio.  So how do you 
use Crosswalk with Android Studio?

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Thursday, November 03, 2016 9:52 AM
To: dev
Subject: Re: How to setup cordova mobilespec with CLI

I just realized that it's not the whole answer.  Once you fetch the 
repositories and clone them down all in a cordova directory, you should then be 
able to run the command, since you'll have all the repositories locally.  You 
should also make sure to get the cordova-plugin-compat plugin that allows 
plugins to work with earlier Cordova versions temporarily until we move the 
classes directly into Cordova proper.

BTW: This is a bit off-topic, but is there any update on when we can use 
Crosswalk with Android Studio?  We're currently using a flag to allow it to 
keep compiling with Cordova, but it would be good to be able to debug a project 
in Android Studio that uses Crosswalk.

On Wed, Nov 2, 2016 at 6:47 PM, Joe Bowser  wrote:

> Hey
>
> You should start with coho, then use that to fetch the rest of the 
> directories as found here:
> https://github.com/apache/cordova-coho
>
> It's our repo-management tool for dealing with all the git repositories.
> It's similar to how repo is used with AOSP, but a bit different in 
> that it's more focused on fetching repos and processing releases with 
> Javascript.
>
> BTW: Our master branch isn't on github, it's actually on the ASF 
> repositories which GitHub mirrors.  Here's an example of the git-web 
> interface for Cordova Android:
> https://git1-us-west.apache.org/repos/asf?p=cordova-android.git
>
> But Coho pulls those, and changes happen directly on that repository 
> and find their way back to the GitHub mirrors.  We use the github 
> mirrors to process patches.
>
> It would be a very good idea for the mobilespec documentation to be 
> updated, since it seems to be misleading.
>
>
> On Wed, Nov 2, 2016 at 6:37 PM, Fu, Junwei  wrote:
>
>>
>> Hi All,
>>
>> The steps of following the documentation> om/apache/cordova-mobile-spec> are too complex and All of repos need 
>> to pull the master branch, Do we have steps to build mobile spec with 
>> released CLI.
>>
>>
>> $ git clone https://github.com/apache/cordova-mobile-spec.git
>>
>> $ git clone https://github.com/apache/cordova-lib.git
>>
>> $ git clone https://github.com/apache/cordova-cli.git
>>
>> $ git clone https://github.com/apache/cordova-plugman.git
>>
>> $ git clone https://github.com/apache/cordova-js.git
>>
>> $ git clone https://github.com/apache/cordova-coho.git
>>
>> $ git clone https://github.com/apache/cordova-android.git
>>
>> $ cordova-mobile-spec/createmobilespec/createmobilespec.js -android
>>
>> $ cd mobilespec
>>
>> $./cordova run android
>>
>>
>>
>> Thanks,
>>
>> Junwei.
>>
>>
>>
>


Re: [VOTE] cordova-plugin-compat@1.1.0 Release

2016-11-02 Thread Shazron
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran coho verify-archive

On Wed, Nov 2, 2016 at 3:36 PM, Steven Gill  wrote:

> Please review and vote on the release of this cordova-plugin-compat release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-12110
>
> The plugins have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-12110/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-compat: 1.1.0 (dd416cc807)
>
> Upon a successful vote I will upload the archives to dist/, upload
> them to npm, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> How to vote on a plugins release at
> https://github.com/apache/cordova-coho/blob/master/docs/
> plugins-release-process.md#voting
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran mobile-spec
>


RE: How to setup cordova mobilespec with CLI

2016-11-02 Thread Fu, Junwei
Can we pull the released tag of those cloned repos?
coho repo-clone -r plugins -r mobile-spec -r android -r ios -r cli

I want to test the released plugins with the latest CLI.

Thanks,
Junwei.

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Thursday, November 03, 2016 9:52 AM
To: dev
Subject: Re: How to setup cordova mobilespec with CLI

I just realized that it's not the whole answer.  Once you fetch the 
repositories and clone them down all in a cordova directory, you should then be 
able to run the command, since you'll have all the repositories locally.  You 
should also make sure to get the cordova-plugin-compat plugin that allows 
plugins to work with earlier Cordova versions temporarily until we move the 
classes directly into Cordova proper.

BTW: This is a bit off-topic, but is there any update on when we can use 
Crosswalk with Android Studio?  We're currently using a flag to allow it to 
keep compiling with Cordova, but it would be good to be able to debug a project 
in Android Studio that uses Crosswalk.

On Wed, Nov 2, 2016 at 6:47 PM, Joe Bowser  wrote:

> Hey
>
> You should start with coho, then use that to fetch the rest of the 
> directories as found here:
> https://github.com/apache/cordova-coho
>
> It's our repo-management tool for dealing with all the git repositories.
> It's similar to how repo is used with AOSP, but a bit different in 
> that it's more focused on fetching repos and processing releases with 
> Javascript.
>
> BTW: Our master branch isn't on github, it's actually on the ASF 
> repositories which GitHub mirrors.  Here's an example of the git-web 
> interface for Cordova Android:
> https://git1-us-west.apache.org/repos/asf?p=cordova-android.git
>
> But Coho pulls those, and changes happen directly on that repository 
> and find their way back to the GitHub mirrors.  We use the github 
> mirrors to process patches.
>
> It would be a very good idea for the mobilespec documentation to be 
> updated, since it seems to be misleading.
>
>
> On Wed, Nov 2, 2016 at 6:37 PM, Fu, Junwei  wrote:
>
>>
>> Hi All,
>>
>> The steps of following the documentation> om/apache/cordova-mobile-spec> are too complex and All of repos need 
>> to pull the master branch, Do we have steps to build mobile spec with 
>> released CLI.
>>
>>
>> $ git clone https://github.com/apache/cordova-mobile-spec.git
>>
>> $ git clone https://github.com/apache/cordova-lib.git
>>
>> $ git clone https://github.com/apache/cordova-cli.git
>>
>> $ git clone https://github.com/apache/cordova-plugman.git
>>
>> $ git clone https://github.com/apache/cordova-js.git
>>
>> $ git clone https://github.com/apache/cordova-coho.git
>>
>> $ git clone https://github.com/apache/cordova-android.git
>>
>> $ cordova-mobile-spec/createmobilespec/createmobilespec.js -android
>>
>> $ cd mobilespec
>>
>> $./cordova run android
>>
>>
>>
>> Thanks,
>>
>> Junwei.
>>
>>
>>
>