[GitHub] cordova-plugin-dialogs issue #69: Added options to customize keyboard for pr...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/69 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/69/commits/f959f15749909fcc252ca5b10eeb36d79de178db) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/34//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs issue #69: Added options to customize keyboard for pr...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/69 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/69/commits/23824d0c1e3990c5194db01c03020ee30c6390b4) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/35//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs issue #69: Added options to customize keyboard for pr...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/69 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/69/commits/dae3ef6f45485dafe43646d3e33653c9a49f387f) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/36//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [iOS] Feature change - updates in config.xml
Found it: https://github.com/apache/cordova-lib/blob/3654a11abc51ab3aead47a9c02ebc135424777b1/cordova-lib/src/cordova/util.js#L43 On Tue, Aug 30, 2016 at 7:24 PM, Shazron wrote: > Filed https://github.com/apache/cordova-ios/pull/246 > > I'm not sure if I should be hardcoding `cordova` in there. How do we > dynamically get the CLI tool name? > > On Mon, Aug 29, 2016 at 1:57 AM, julio cesar sanchez < > jcesarmob...@gmail.com> wrote: > >> +1 >> >> 2016-08-29 10:51 GMT+02:00 Shazron : >> >> > Due to lazy consensus, I will proceed with this change. >> > >> > On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts >> > wrote: >> > >> > > +1; totally fine with this. :-) >> > > >> > > ~ Kerri >> > > >> > > > On Aug 24, 2016, at 20:30, Shazron wrote: >> > > > >> > > > More details and discussion in: >> > > > https://issues.apache.org/jira/browse/CB-11712 >> > > > >> > > > In brief, the proposed change is: >> > > > changes in config.xml will not be allowed, and cordova will >> > print >> > > an >> > > > error, with instructions on what to do instead. The instructions >> will >> > > tell >> > > > the user to do a `cordova platform rm ios` then a `cordova platform >> add >> > > > ios`. This should be pretty quick since we cache platforms. >> > > > >> > > > Before hitting "Reply" to this email with your comment, check out >> the >> > > issue >> > > > where we discuss this in length. >> > > >> > > >> > >> > >
[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 @kerrishots, I have assigned CB-10288 to you as you have real devices to test it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #633: Fix minor typo "fist" -> "first"
GitHub user jonathandotchin opened a pull request: https://github.com/apache/cordova-docs/pull/633 Fix minor typo "fist" -> "first" You can merge this pull request into a Git repository by running: $ git pull https://github.com/jonathandotchin/cordova-docs patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/633.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #633 commit af11187f1b5d817b7e1c1d2d35fbbf9ba2fa19c6 Author: jonathandotchin Date: 2016-09-02T13:56:47Z Fix minor typo "fist" -> "first" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #328: Nougat update - Updates required for API Level 2...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/328 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/328?src=pr) is 33.78% (diff: 100%) > Merging [#328](https://codecov.io/gh/apache/cordova-android/pull/328?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage ```diff @@ master #328 diff @@ == Files11 11 Lines 965965 Methods 197197 Messages 0 0 Branches157157 == Hits326326 Misses 639639 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [047ed52...451be26](https://codecov.io/gh/apache/cordova-android/compare/047ed52d608742fbfcb7919011c7b4344e65e862...451be26325bfd89fb9d136e9a1be4d23334b3e7e?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Discuss] Cordova-Android 6.0.x
https://github.com/apache/cordova-android/blob/master/.travis.yml#L9 @purplecabbage risingj.com On Thu, Sep 1, 2016 at 10:59 AM, Joe Bowser wrote: > BTW: The nougat update has been added, but this broke our CI > > https://travis-ci.org/apache/cordova-android/builds/156860827 > > Can we get android-24 added to Travis? > > > > On Thu, Sep 1, 2016 at 8:48 AM, Joe Bowser wrote: > > > Sounds good! > > > > On Thu, Sep 1, 2016 at 8:48 AM, julio cesar sanchez < > > jcesarmob...@gmail.com> wrote: > > > >> You asked for a reason to NOT do it, so if there is no answer you can do > >> it. > >> > >> > >> > >> 2016-09-01 17:44 GMT+02:00 Joe Bowser : > >> > >> > BUMP!!! > >> > > >> > This is a major version! Are people getting my e-mails? > >> > > >> > On Wed, Aug 31, 2016 at 12:44 PM, Joe Bowser > wrote: > >> > > >> > > Hey > >> > > > >> > > This week, I'm going to start merging things that will break certain > >> > APIs, > >> > > such as the Third Party WebView. This is done so we can have solid > >> > > compatibility with Nougat, as well as fix some threading issues that > >> > people > >> > > are having when embedding CordovaWebView in native projects. Before > >> I do > >> > > this, I need to know whether there's any reason to NOT do this. > >> > > > >> > > Does anyone have any objections to me starting to merge the 6.0.x > >> changes > >> > > in and prepping for a 6.0.x release sometime in September with > Cordova > >> > > targeting API 24, and having compatibility fixes? > >> > > > >> > > Joe > >> > > > >> > > >> > > > > >
Re: [Discuss] Cordova-Android 6.0.x
Yeah, I already added android-24 to that line, and now the error is even more explicit and it's telling me straight up to install it. I need someone to install android-24 on Travis. On Fri, Sep 2, 2016 at 11:19 AM, Jesse wrote: > https://github.com/apache/cordova-android/blob/master/.travis.yml#L9 > > > @purplecabbage > risingj.com > > On Thu, Sep 1, 2016 at 10:59 AM, Joe Bowser wrote: > > > BTW: The nougat update has been added, but this broke our CI > > > > https://travis-ci.org/apache/cordova-android/builds/156860827 > > > > Can we get android-24 added to Travis? > > > > > > > > On Thu, Sep 1, 2016 at 8:48 AM, Joe Bowser wrote: > > > > > Sounds good! > > > > > > On Thu, Sep 1, 2016 at 8:48 AM, julio cesar sanchez < > > > jcesarmob...@gmail.com> wrote: > > > > > >> You asked for a reason to NOT do it, so if there is no answer you can > do > > >> it. > > >> > > >> > > >> > > >> 2016-09-01 17:44 GMT+02:00 Joe Bowser : > > >> > > >> > BUMP!!! > > >> > > > >> > This is a major version! Are people getting my e-mails? > > >> > > > >> > On Wed, Aug 31, 2016 at 12:44 PM, Joe Bowser > > wrote: > > >> > > > >> > > Hey > > >> > > > > >> > > This week, I'm going to start merging things that will break > certain > > >> > APIs, > > >> > > such as the Third Party WebView. This is done so we can have > solid > > >> > > compatibility with Nougat, as well as fix some threading issues > that > > >> > people > > >> > > are having when embedding CordovaWebView in native projects. > Before > > >> I do > > >> > > this, I need to know whether there's any reason to NOT do this. > > >> > > > > >> > > Does anyone have any objections to me starting to merge the 6.0.x > > >> changes > > >> > > in and prepping for a 6.0.x release sometime in September with > > Cordova > > >> > > targeting API 24, and having compatibility fixes? > > >> > > > > >> > > Joe > > >> > > > > >> > > > >> > > > > > > > > >
[GitHub] cordova-android pull request #329: Use android-24
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-android/pull/329 Use android-24 Testing travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/329.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #329 commit e8e4ad360ef5c05e93b45221557ff62d9e5bf36d Author: Jesse MacFadyen Date: 2016-09-02T18:33:08Z Use android-24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #329: Use android-24
Github user purplecabbage closed the pull request at: https://github.com/apache/cordova-android/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #478: CB-11607 breakout cordova-create from cordova...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request #259: CB-11607 breakout cordova-create from cordova...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests
Reviving this thread: So, it seems that a lot of us thought that the plugin.xml changes would fix our problem, in fact they haven't because of what Julio just mentioned. Right now a lot of the PRs that we're getting are to add extra settings. I'm tempted to just merge them since we still don't have a solution to this. Does someone want to come up with something, or should I just do it. On Thu, Jul 21, 2016 at 2:34 PM, julio cesar sanchez wrote: > That issue is about adding an attribute to an existing element of the > AndroidManifest from plugin.xml, this topic is about adding the whole > functionality of writing/editing the .xml/.plist files from config.xml > instead of using a "silly" plugin > > 2016-07-21 23:24 GMT+02:00 Jesse : > > > CB-11023 is what it was submitted under. afaik > > > > > > > > > > > > @purplecabbage > > risingj.com > > > > On Thu, Jul 21, 2016 at 2:22 PM, julio cesar sanchez < > > jcesarmob...@gmail.com > > > wrote: > > > > > We still don't have an issue for this, right? > > > > > > I've been searching and found those three: > > > > > > https://issues.apache.org/jira/browse/CB-7232 (iOS) > > > https://issues.apache.org/jira/browse/CB-11604 (Android) > > > https://issues.apache.org/jira/browse/CB-10832 (Windows) > > > > > > > > > > > > 2016-04-29 17:13 GMT+02:00 Karen Tran : > > > > > > > Can I get someone to review my PR? > > > > https://github.com/apache/cordova-lib/pull/432 > > > > > > > > Thanks, > > > > Karen Tran > > > > > > > > On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) < > > > > v-vlk...@microsoft.com> wrote: > > > > > > > > > Exactly. Multiple tags is also possible with this syntax. > > > > > > > > > > - > > > > > Best regards, Vladimir > > > > > > > > > > -Original Message- > > > > > From: Karen Tran [mailto:ktop...@gmail.com] > > > > > Sent: Thursday, April 21, 2016 5:20 PM > > > > > To: dev@cordova.apache.org > > > > > Subject: Re: [Android] Need a solution to config.xml and > > > > > AndroidManifest.xml feature requests > > > > > > > > > > @Vladimir, in your suggestion, is this what you were going for? > Being > > > > able > > > > > to add multiple attributes to any direct children node of the > parent? > > > > > > > > > > > > attr="true"> > > > > > > > > android:debuggable="true" > > > > > /> > > > > > > > > > > > > > > > > > > > > > > > > > Regards, > > > > > Karen Tran > > > > > > > > > > On Thu, Apr 21, 2016 at 3:58 AM, Vladimir Kotikov (Akvelon) < > > > > > v-vlk...@microsoft.com> wrote: > > > > > > > > > > > Another proposal about syntax which allows to specify multiple > > > > > > attributes at once and does not require parsing attributes from > > plain > > > > > text: > > > > > > > > > > > > > > > attr="true"> > > > > > > > > > > > > > > > > > > > Also I've took a quick look at the implementation and it looks > good > > > > > > apart from one minor issue - when we're grafting attributes we > > > > > > probably do not need to create an element to graft attributes to > if > > > it > > > > > > doesn't exist, otherwise after adding and then removing the > plugin > > > > > > created xml element will remain in modified file. > > > > > > > > > > > > - > > > > > > Best regards, Vladimir > > > > > > > > > > > > -Original Message- > > > > > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] > > > > > > Sent: Thursday, April 21, 2016 3:24 AM > > > > > > To: dev@cordova.apache.org > > > > > > Subject: RE: [Android] Need a solution to config.xml and > > > > > > AndroidManifest.xml feature requests > > > > > > > > > > > > Oh great! I have not taken a close look at the implementation > > itself. > > > > > > Perhaps you already had some of this in mind. > > > > > > > > > > > > As for the syntax for changing attributes, I would recommend > > > something > > > > > > like this: > > > > > > > > > > > > > > > parent="/manifest/application" > > > > > > attributeName="android:name" attirbuteValue="MyApplication"/> > > > > > > > > > > > > Also, we should always prioritize config.xml edits over > plugin.xml > > > > > > (giving the end developer the full control). In case of > conflicts, > > > > > > between plugins & config.xml we should warn and mention which one > > we > > > > > > picked (config.xml) > > > > > > > > > > > > Thanks, > > > > > > Nikhil > > > > > > > > > > > > -Original Message- > > > > > > From: Karen Tran [mailto:ktop...@gmail.com] > > > > > > Sent: Wednesday, April 20, 2016 12:40 PM > > > > > > To: dev@cordova.apache.org > > > > > > Subject: Re: [Android] Need a solution to config.xml and > > > > > > AndroidManifest.xml feature requests > > > > > > > > > > > > Hi, > > > > > > > > > > > > I made an attempt at the functionality of being able to add > > > attributes > > > > > > with the config-file tag. It's not completed yet, but I wanted to > > get > > > > > > some review before I proceed. > > > > > > With my changes, you can add an attribute through the config-file > > tag > > > > > > i
About CB-10036 bug fix
Initially it was to add save command instruction. It has fixed and merged. But in the example section it is not mentioned. Is it not necessary to give example for save command ?
[GitHub] cordova-windows issue #157: TypeScript Error
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-windows/pull/157 Can this be closed? Please confirm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] cordova-create 1.0.1 release
updated the tests and removed code that was removing all listeners on events.
Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests
I'm confused what's not being covered? The edit-config tag which can be used from either plugin.xml or config.xml should be able to add new tags into an xml document as well as edit existing tags/attributes in an xml document. Simon Mac Donald http://hi.im/simonmacdonald On Fri, Sep 2, 2016 at 5:00 PM, Joe Bowser wrote: > Reviving this thread: > > So, it seems that a lot of us thought that the plugin.xml changes would fix > our problem, in fact they haven't because of what Julio just mentioned. > Right now a lot of the PRs that we're getting are to add extra settings. > I'm tempted to just merge them since we still don't have a solution to > this. Does someone want to come up with something, or should I just do it. > > On Thu, Jul 21, 2016 at 2:34 PM, julio cesar sanchez < > jcesarmob...@gmail.com > > wrote: > > > That issue is about adding an attribute to an existing element of the > > AndroidManifest from plugin.xml, this topic is about adding the whole > > functionality of writing/editing the .xml/.plist files from config.xml > > instead of using a "silly" plugin > > > > 2016-07-21 23:24 GMT+02:00 Jesse : > > > > > CB-11023 is what it was submitted under. afaik > > > > > > > > > > > > > > > > > > @purplecabbage > > > risingj.com > > > > > > On Thu, Jul 21, 2016 at 2:22 PM, julio cesar sanchez < > > > jcesarmob...@gmail.com > > > > wrote: > > > > > > > We still don't have an issue for this, right? > > > > > > > > I've been searching and found those three: > > > > > > > > https://issues.apache.org/jira/browse/CB-7232 (iOS) > > > > https://issues.apache.org/jira/browse/CB-11604 (Android) > > > > https://issues.apache.org/jira/browse/CB-10832 (Windows) > > > > > > > > > > > > > > > > 2016-04-29 17:13 GMT+02:00 Karen Tran : > > > > > > > > > Can I get someone to review my PR? > > > > > https://github.com/apache/cordova-lib/pull/432 > > > > > > > > > > Thanks, > > > > > Karen Tran > > > > > > > > > > On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) < > > > > > v-vlk...@microsoft.com> wrote: > > > > > > > > > > > Exactly. Multiple tags is also possible with this syntax. > > > > > > > > > > > > - > > > > > > Best regards, Vladimir > > > > > > > > > > > > -Original Message- > > > > > > From: Karen Tran [mailto:ktop...@gmail.com] > > > > > > Sent: Thursday, April 21, 2016 5:20 PM > > > > > > To: dev@cordova.apache.org > > > > > > Subject: Re: [Android] Need a solution to config.xml and > > > > > > AndroidManifest.xml feature requests > > > > > > > > > > > > @Vladimir, in your suggestion, is this what you were going for? > > Being > > > > > able > > > > > > to add multiple attributes to any direct children node of the > > parent? > > > > > > > > > > > > > > > attr="true"> > > > > > > > > > > android:debuggable="true" > > > > > > /> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Regards, > > > > > > Karen Tran > > > > > > > > > > > > On Thu, Apr 21, 2016 at 3:58 AM, Vladimir Kotikov (Akvelon) < > > > > > > v-vlk...@microsoft.com> wrote: > > > > > > > > > > > > > Another proposal about syntax which allows to specify multiple > > > > > > > attributes at once and does not require parsing attributes from > > > plain > > > > > > text: > > > > > > > > > > > > > > > > > > attr="true"> > > > > > > > > > > > > > > > > > > > > > > > Also I've took a quick look at the implementation and it looks > > good > > > > > > > apart from one minor issue - when we're grafting attributes we > > > > > > > probably do not need to create an element to graft attributes > to > > if > > > > it > > > > > > > doesn't exist, otherwise after adding and then removing the > > plugin > > > > > > > created xml element will remain in modified file. > > > > > > > > > > > > > > - > > > > > > > Best regards, Vladimir > > > > > > > > > > > > > > -Original Message- > > > > > > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] > > > > > > > Sent: Thursday, April 21, 2016 3:24 AM > > > > > > > To: dev@cordova.apache.org > > > > > > > Subject: RE: [Android] Need a solution to config.xml and > > > > > > > AndroidManifest.xml feature requests > > > > > > > > > > > > > > Oh great! I have not taken a close look at the implementation > > > itself. > > > > > > > Perhaps you already had some of this in mind. > > > > > > > > > > > > > > As for the syntax for changing attributes, I would recommend > > > > something > > > > > > > like this: > > > > > > > > > > > > > > > > > > parent="/manifest/application" > > > > > > > attributeName="android:name" attirbuteValue="MyApplication"/> > > > > > > > > > > > > > > Also, we should always prioritize config.xml edits over > > plugin.xml > > > > > > > (giving the end developer the full control). In case of > > conflicts, > > > > > > > between plugins & config.xml we should warn and mention which > one > > > we > > > > > > > picked (config.xml) > > > > > > > > > > > > > > Thanks, > > > > > > > Nikhil > > > > > > > > > > > > > > -Original M
Nightly build #134 for cordova has succeeded!
Nightly build #134 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/134/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
