RE: [validator] Collections 4

2024-09-11 Thread Josh Fenlason
I was looking through the jira items for validator.

I see one item that looks like it would be necessary for a Validator 2.X 
release, VALIDATOR-390, for updating to Commons Collections 4.  I see a 
relatively recent PR, https://github.com/apache/commons-validator/pull/53, for 
that though.  I know that breaks binary compatibility an would therefore 
require a new Validator 2 release.  Since it looks like there is momentum for 
that, is the plan to accept that PR?  Or is a different solution necessary for 
that?

One other thing is that I believe the convention is for new major releases to 
bump the version in the package name, refactoring from 
"org.apache.commons.validator" to "org.apache.commons.validator2", correct?  I 
am not seeing a jira item for that.  Did I miss it?  Would it be helpful for me 
to create a PR with that refactoring?

Thanks,
Josh.

-Original Message-
From: Gary D. Gregory  
Sent: Wednesday, September 4, 2024 8:32 AM
To: dev@commons.apache.org
Subject: RE: [validator] Collections 4


CAUTION: This email originated from outside the organization. Do not click 
links or open attachments unless you recognize the sender and know the content 
is safe. If you believe this is a phishing email, use the Report to 
Cybersecurity icon in Outlook.



On 2024/09/03 19:54:05 Josh Fenlason wrote:
> That is great to hear!  Is there anything I can do to assist with that?

Watch this list and test builds and release candidates when they become 
available.

You can also scan Jira and pull requests on GitHub and see if anything catches 
your eye.

Gary

>
> -Original Message-
> From: Gary Gregory 
> Sent: Tuesday, September 3, 2024 2:53 PM
> To: Commons Developers List 
> Subject: Re: [validator] Collections 4
>
>
> CAUTION: This email originated from outside the organization. Do not click 
> links or open attachments unless you recognize the sender and know the 
> content is safe. If you believe this is a phishing email, use the Report to 
> Cybersecurity icon in Outlook.
>
>
>
> I am planning on what will likely be a new major version as we cannot break 
> binary compatibility. Maybe within the next few weeks.
>
> Gary
>
> On Tue, Sep 3, 2024, 3:10 PM Josh Fenlason 
>  wrote:
>
> > I have requirements to eliminate collections3 from my project.
> > The latest Validator released is dependent on collections3 though.
> > What are the chances of a new Validator release that is dependent on 
> > collections4?  What could I do to assist with making that happen?
> > Thanks,
> > Josh.
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org


[collection] AbstractLinkedListForJava21 ?

2024-09-11 Thread Gary D. Gregory
Hi All:

Added in 4.5.0-M2, I see a new class called AbstractLinkedListForJava21 with 
the Javadoc: "This is a copy of AbstractLinkedList"

Copied from where? 
What was the license of the source? 

If we cannot validate that this is copied from a source file with a compatible 
license, we will have to remove it.

TY!
Gary

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [collection] AbstractLinkedListForJava21 ?

2024-09-11 Thread Alex Herbert
It was copied from the same package. The current AbstractLinkedList is
source incompatible with JDK 21 due to new default methods added to
the List interface. So Collections does not compile on JDK 21. Anyone
using the AbstractLinkedList and compiling on JDK 21 must switch their
source to use AbstractLinkedListForJava21.

If this is not clear from the javadoc and linked issue in the commit
log then we should do a better job explaining this.

Alex

On Wed, 11 Sept 2024 at 21:52, Gary D. Gregory  wrote:
>
> Hi All:
>
> Added in 4.5.0-M2, I see a new class called AbstractLinkedListForJava21 with 
> the Javadoc: "This is a copy of AbstractLinkedList"
>
> Copied from where?
> What was the license of the source?
>
> If we cannot validate that this is copied from a source file with a 
> compatible license, we will have to remove it.
>
> TY!
> Gary
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org