Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-12 Thread Alex Herbert
My +1

Another review would be appreciated.

On Thu, 11 Jul 2024 at 21:13, Alex Herbert  wrote:

> RC2 is still ok. Only nits with the site generation so far.
>
> On Thu, 11 Jul 2024, 19:31 Gary Gregory,  wrote:
>
>> Is RC2 still alive or are there changes coming due to this discussion?
>>
>> TY,
>> Gary
>>
>> On Thu, Jul 11, 2024, 2:05 PM Rob Tompkins  wrote:
>>
>> >
>> >
>> > > On Jul 11, 2024, at 1:57 PM, Alex Herbert 
>> > wrote:
>> > >
>> > > Hi Gilles,
>> > >
>> > > Thanks for the feedback. It seems that revapi is not a robust plugin,
>> but
>> > > japicmp also has issues without the packaged jars. I'll make a note in
>> > the
>> > > RNG release guide to suggest the command to build the site.
>> > >
>> > > On Thu, 11 Jul 2024 at 17:27, Gilles Sadowski > > > wrote:
>> > >
>> > >> Hello.
>> > >>
>> > >> Le mar. 9 juil. 2024 à 14:22, Alex Herbert > > > a écrit :
>> > >>>
>> > >>> We have fixed a few bugs and added enhancements since Apache Commons
>> > RNG
>> > >>> 1.5 was released, so I would like to release Apache Commons RNG 1.6.
>> > >>>
>> > >>> Apache Commons RNG 1.6 RC2 is available for review here:
>> > >>>https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2 (svn
>> > >>> revision 70197)
>> > >>>
>> > >>> The Git tag commons-rng-1.6-RC2 commit for this RC is
>> > commons-rng-1.6-RC2
>> > >>> which you can browse here:
>> > >>>
>> > >>>
>> > >>
>> >
>> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.6-RC2
>> > >>> You may checkout this tag using:
>> > >>>git clone https://gitbox.apache.org/repos/asf/commons-rng.git
>> > >> --branch
>> > >>> commons-rng-1.6-RC2 commons-rng-1.6-RC2
>> > >>>
>> > >>> Maven artifacts are here:
>> > >>>
>> > >>>
>> > >>
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1755/org/apache/commons/commons-rng/1.6/
>> > >>>
>> > >>> These are the artifacts and their hashes:
>> > >>>
>> > >>> #Release SHA-512s
>> > >>> #Tue Jul 09 12:29:41 BST 2024
>> > >>>
>> > >>
>> >
>> commons-rng-1.6-bin.tar.gz=ede8acdf030d658d5ee2164185cb4e4e3b402f3b7032202d29016df76946f1355c0e968677fcae6eafcff3a8d6439c70e3514013c07fa34048c3f33e2005e7e4
>> > >>>
>> > >>
>> >
>> commons-rng-1.6-bin.zip=6011e1ea66226592168e6fb67d0c2740cf537edc0d4b549423e5ba7761084cb7222982fdf09ef9a6b8ea29c45e4a6cd09137d4d9ffd20172008f26a8a0804486
>> > >>>
>> > >>
>> >
>> commons-rng-1.6-src.tar.gz=8cb6e78b7a27aaf9492f549848465987838fd490a97996c5f7d516a648093db777d63544cd4be7550de22d69b80b070fdfa5e1f6dd143c2e75c70db684a39e2e
>> > >>>
>> > >>
>> >
>> commons-rng-1.6-src.zip=57e999f5f76155046cde915eaf33781f6361588a5e0d8776d4451149eca4d07fcf2b49612c5e6829181b75ad697e60f6243c0fedff0d932130315e44fe0a3237
>> > >>>
>> > >>> Signatures may be validated on a system supporting a bash Unix
>> shell by
>> > >>> executing:
>> > >>>svn co
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2/
>> > >>>cd 1.6-RC2
>> > >>>chmod +x ./signature-validator.sh
>> > >>>for m in client-api core simple sampling bom; do
>> > >>> ./signature-validator.sh
>> > >>>
>> > >>
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1755/org/apache/commons/commons-rng-${m}/1.6/
>> > >> ;
>> > >>> done
>> > >>
>> > >> It would be worth reminding that a copy/paste of the above on the
>> > >> command-line will not work (although the script outputs both "ERROR"
>> > >> and "SUCCESSFUL VALIDATION" which is confusing/misleading).
>> > >>
>> > >> Couldn't the script be auto-generated (rather than just copied I
>> > presume)
>> > >> to also contain the "for-loop" specific to each component?
>> > >>
>> > >
>> > > Maybe. There is a lot that could be improved in the release plugin for
>> > > multi-module releases. I added that line manually to the vote email. I
>> > > added a lot of other things too. The loop worked when copy and pasted
>> > from
>> > > my source email. Maybe line wrapping has broken it.
>> > >
>> >
>> > Agreed that the plugin doesn’t support multi-module builds as well as
>> > single module builds. Sorry for that….hard to manage multmodule builds.
>> >
>> > > If we are not going to suggest using the signature validator, then
>> why do
>> > > we even bother generating it? It seems strange, which is why I made an
>> > > attempt to suggest using it.
>> >
>> > The signature validator is a script that (for single module projects)
>> > downloads all of the artifacts and verifies all of the signatures….multi
>> > module builds are far harder to manage because you have to traverse
>> nexus
>> > carefully and download all of the different jars from different url’s.
>> >
>> > Maybe we shouldn’t generate it for multi-module builds….regardless, it
>> > should do signature validation on the real release artifacts, those
>> checked
>> > into the distribution area.
>> >
>> >
>> >
>> > >
>> > >
>> > >>
>> > >>> The source code contains examples that are not part of the public
>> API.
>> > >>> Th

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-12 Thread Gary D. Gregory
+1

I tested the src zip file:
- SHA512 OK
- ASC OK
- Running 'mvn' (default goal) OK, BUT:

[INFO] --- javadoc:3.7.0:javadoc (default-cli) @ commons-rng-docs ---
[ERROR] Error fetching link: 
C:\Users\ggregory\rc\commons-rng-1.6-src\commons-rng-client-api\target\apidocs. 
Ignored it.
[ERROR] Error fetching link: 
C:\Users\ggregory\rc\commons-rng-1.6-src\commons-rng-core\target\apidocs. 
Ignored it.
[ERROR] Error fetching link: 
C:\Users\ggregory\rc\commons-rng-1.6-src\commons-rng-simple\target\apidocs. 
Ignored it.
[ERROR] Error fetching link: 
C:\Users\ggregory\rc\commons-rng-1.6-src\commons-rng-sampling\target\apidocs. 
Ignored it.
[INFO] No previous run data found, generating javadoc.

Using:

Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: C:\java\apache-maven-3.9.8
Java version: 17.0.11, vendor: Eclipse Adoptium, runtime: C:\Program 
Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary

On 2024/07/09 12:21:56 Alex Herbert wrote:
> We have fixed a few bugs and added enhancements since Apache Commons RNG
> 1.5 was released, so I would like to release Apache Commons RNG 1.6.
> 
> Apache Commons RNG 1.6 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2 (svn
> revision 70197)
> 
> The Git tag commons-rng-1.6-RC2 commit for this RC is commons-rng-1.6-RC2
> which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.6-RC2
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> commons-rng-1.6-RC2 commons-rng-1.6-RC2
> 
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1755/org/apache/commons/commons-rng/1.6/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Tue Jul 09 12:29:41 BST 2024
> commons-rng-1.6-bin.tar.gz=ede8acdf030d658d5ee2164185cb4e4e3b402f3b7032202d29016df76946f1355c0e968677fcae6eafcff3a8d6439c70e3514013c07fa34048c3f33e2005e7e4
> commons-rng-1.6-bin.zip=6011e1ea66226592168e6fb67d0c2740cf537edc0d4b549423e5ba7761084cb7222982fdf09ef9a6b8ea29c45e4a6cd09137d4d9ffd20172008f26a8a0804486
> commons-rng-1.6-src.tar.gz=8cb6e78b7a27aaf9492f549848465987838fd490a97996c5f7d516a648093db777d63544cd4be7550de22d69b80b070fdfa5e1f6dd143c2e75c70db684a39e2e
> commons-rng-1.6-src.zip=57e999f5f76155046cde915eaf33781f6361588a5e0d8776d4451149eca4d07fcf2b49612c5e6829181b75ad697e60f6243c0fedff0d932130315e44fe0a3237
> 
> Signatures may be validated on a system supporting a bash Unix shell by
> executing:
> svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2/
> cd 1.6-RC2
> chmod +x ./signature-validator.sh
> for m in client-api core simple sampling bom; do
> ./signature-validator.sh
> https://repository.apache.org/content/repositories/orgapachecommons-1755/org/apache/commons/commons-rng-${m}/1.6/;
> done
> 
> The source code contains examples that are not part of the public API.
> These examples contain Java 11 modules and are enabled using a profile (see
> below).
> 
> Note: Testing randomness using statistical thresholds results in failures
> at a given probability. The 'maven-surefire-plugin' is configured to re-run
> tests that fail, and pass the build if they succeed within the allotted
> number of reruns (the test will be marked as 'flaky' in the report).
> 
> I have tested this with 'mvn clean install' and 'mvn clean package site
> site:stage -Pcommons-rng-examples' using:
> 
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /Users/ah403/software/apache-maven-3
> Java version: 11.0.23, vendor: Eclipse Adoptium, runtime:
> /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"
> 
> 
> Details of changes since 1.5 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/rng/1.6-RC2/RELEASE-NOTES.txt
> 
> https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/changes-report.html
> 
> Site:
> https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/index.html
> (note some *relative* links are broken and the 1.6 directories are not
> yet created - these will be OK once the site is deployed.)
> 
> The site has been staged in a personal Apache space as it includes the
> examples modules documentation. These are not
> staged to the SVN dev staging area as these are not part of the official
> release artifacts.
> 
> JApiCmp Report (compared to 1.5):
> 
> https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/commons-rng-client-api/japicmp.html
> 
> https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/commons-rng-core/japicmp.html
> 
> https://home.apache.org/~aherbert/commons-rng-1.6-RC2-site/commons-rng-simple/japicmp.html
> 

[VOTE] Release Apache Commons Codec 1.17.1 based on RC1

2024-07-12 Thread Gary Gregory
We have added one enhancement and updated some dependencies since
Apache Commons Codec 1.17.0 was released, so I would like to release
Apache Commons Codec 1.17.1.

Apache Commons Codec 1.17.1 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/codec/1.17.1-RC1
(svn revision 70271)

The Git tag commons-codec-1.17.1-RC1 commit for this RC is
965109705c5236b05011e1c45f47d991abfa521e which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-codec.git;a=commit;h=965109705c5236b05011e1c45f47d991abfa521e
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-codec.git
--branch commons-codec-1.17.1-RC1 commons-codec-1.17.1-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1756/commons-codec/commons-codec/1.17.1/

These are the artifacts and their hashes:

#Release SHA-512s
#Fri Jul 12 16:20:56 UTC 2024
commons-codec-1.17.1-bin.tar.gz=6b7f60cc545b7524c8145ea2894983445db216feb06559809606c2fa274ab05cae72e9bd85fa1ae6f6f9997c13f940e18c5d6ac3019acfd77fcbb90f92402b5b
commons-codec-1.17.1-bin.zip=2733187cbb65cea05bbd92b09f175c85440db594b5021505d71f580600e9e50a3aeb0d389f8c109ed3227c34ca395a34a764a4f4799fcc86d4ab174829b2aff5
commons-codec-1.17.1-bom.json=8990802e9d665e8c151b0650268bbe767a1877349a8ab4b6fc271c19594c4304d6bab8250b13d8f1e67a4e01b49db83d10359c49d0597e3d8aceb0a69f697cd5
commons-codec-1.17.1-bom.xml=0fd310815ceb760981120732a3e71d92fe5aff4f36e076a4341618019d2e6540bdfdb2bbb7e2c9e3865791156a26868707c3e3bd6bc576b6212f4264b341d36e
commons-codec-1.17.1-javadoc.jar=67ed6f8748842fc81789e96ab6081344950b0986a36b512bfc3502ac696e5142fad6a29d5b27d581dd55e1892c7d99bb478ffa88d25dc0612b067c9a3a2796fc
commons-codec-1.17.1-sources.jar=91853458bdc6d6cf9a1f344b30218ca28e9270341346a5431b714007456e8f08be700fd8fb7cc509afda69d996dde20e1f01022c59240428f5b41e3db2cf20c0
commons-codec-1.17.1-src.tar.gz=c98456664396d4d9cb794c185a479e6bb4a5055ed1f526a8e358fe3a59409c057dbb16f59c251bb52976995dbca14d8f15857074c9d19fbc7bdfed625a13abf0
commons-codec-1.17.1-src.zip=8375246b08c7c7c9f4f8d07f229c7b4dcc2eed8c1e9f2f7d59319a755c4b8f2b81e8ec5b0de995f239246f06e9b8ca373ae1563c385a5bb2a2377249b2662690
commons-codec-1.17.1-test-sources.jar=d1fe18cffa43fec7e12f6d9e367872cad2539b1c6e9befd4dbbd7cc097137f780a0d86d0d15e6c921494f22a37077df94ee4c008fe395f76d9041cc8df86fed5
commons-codec-1.17.1-tests.jar=52bfb28dad735490444a4f8ff96102013d23d9ecb22236aa0fb30d060113953105f65083eb831d34162b11bcc1de9c89a0a02b78e0582d04789182f8fd559aec
commons-codec_commons-codec-1.17.1.spdx.json=402887cb1d559aa75efe3546c1d50e6a8e632339ff0fe66447878cbbd487df822232582d49c5b385e44cfd3adb0d6e06029ae561844f4d0eed1172441e853102

I have tested this with 'mvn' and 'mvn -e -V -Prelease -Ptest-deploy
-P jacoco -P japicmp clean package site deploy' using:

openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)

Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: /usr/local/Cellar/maven/3.9.8/libexec
Java version: 17.0.11, vendor: Homebrew, runtime:
/usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"

Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64

Details of changes since 1.17.0 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/codec/1.17.1-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/codec/1.17.1-RC1/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/codec/1.17.1-RC1/site/index.html
(note some *relative* links are broken and the 1.17.1 directories
are not yet created - these will be OK once the site is deployed.)

JApiCmp Report (compared to 1.17.0):

https://dist.apache.org/repos/dist/dev/commons/codec/1.17.1-RC1/site/japicmp.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/codec/1.17.1-RC1/site/rat-report.html

KEYS:
  https://downloads.apache.org/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

The following is intended as a helper and refresher for reviewers.

Validating a release candidate
==

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1a) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-codec.git
--branch commons-codec-1.17.1-RC1 commons-codec-1.17.1-RC1
cd commons-cod