[VOTE] Release Apache Commons BCEL 6.8.2 based on RC1

2024-02-21 Thread Gary D. Gregory 
We have fixed a few bugs since Apache Commons BCEL 6.8.1 was released, so I 
would like to release Apache Commons BCEL 6.8.2.

Apache Commons BCEL 6.8.2 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.2-RC1 (svn revision 
67482)

The Git tag commons-bcel-6.8.2-RC1 commit for this RC is 
749d99c14180afb991dca2d02c1ad75fd97f417f which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=749d99c14180afb991dca2d02c1ad75fd97f417f
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch 
commons-bcel-6.8.2-RC1 commons-bcel-6.8.2-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1691/org/apache/bcel/bcel/6.8.2/

These are the artifacts and their hashes:

#Release SHA-512s
#Wed Feb 21 17:43:58 EST 2024
bcel-6.8.2-tests.jar=9e4643c904b2187791b1b419e6fd0cc8b75471487c505993f7ebb48f366b21889dac14af01b4a21bd798b16b2f5754bb70e9484a1b2bb096f7a56f83c73706c1
bcel-6.8.2-src.zip=9d362d26cb1c52514636c993e3d13f3424ff1aaf5dd897c1ef8d9f7745b069e7ff29d0924261ab1b071d0f11c73baa1052fd780a55d5995e50b3acc49d42f252
bcel-6.8.2-javadoc.jar=98ea3681c849e8a2515c111db9360d50d1ed7c0fe0f8257f3536baadbfb2de131c3110ecb1823ea073185cfbc01360d523d5fdfe580511f1efe3456a7e63fcd7
bcel-6.8.2-bin.tar.gz=f8ea95821f983be06988f8008c4e402dd48b702547b1d58251b91d544735f8f7370cdda78353c84d7b5932323c1113205fa1e3e9b6235d6dcf2f8e10f3671742
bcel-6.8.2-src.tar.gz=17e18323651274bd54c8fc631b27e9460bb7389b3736aac6645da52a6a1ca1d4d5a48b9c987065356bdcd62ddf20f7ec4e563424e3ad504e46495237e254cef6
org.apache.bcel_bcel-6.8.2.spdx.json=a2bc9d6da822bc5ec607bf98b26b42f04e663bfd707eb863166052a21f517c0309f25658aded35638219846204385dd37a84eb4fb4f4e21ac6bfed1ddbb484c8
bcel-6.8.2-bom.json=65980e4ae082b66c51dd1d774e6d2337a2c6c661c826c4180c1ca948e11feb25b1e9f1707520a555acdb04cd68caede65bf3fc7d8e9628948b862656e0d89d50
bcel-6.8.2-bom.xml=8d712f1220bcde65ade4362de1f3a6bb7e66cf8423c83951070bc151ba07c50013dab86fd855b4598dc957458f1c498ac2715758202261f857ce26429563e205
bcel-6.8.2-sources.jar=df2ce9772ff98f53b5d00c7ed650a16deb45b573262e2692f91cf34071ad791f126b54706b4ab94385e2fa5deaac81910205668750b304249e119ca7efe7
bcel-6.8.2-test-sources.jar=441a271c831da3c73d6dfa6b7fa041ed6c8253528d8ab43ed1fbb9ba88945519ce12dc9b84a38e8b04f869dc37c5f7f5098d5ce0586497eea6b366d67166e054
bcel-6.8.2-bin.zip=69a04f10a5e69cea2d6cd54488f0dbe73ed1b46b214cb4e06a9acc7901845a3cd0e89f12d1034b2670ab442eae9957775c61d8fb7a0d7fb77574223deb89468f

I have tested this with:

mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy

Using:

Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: C:\java\apache-maven-3.9.6
Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program 
Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Microsoft Windows [Version 10.0.19045.3930]

Details of changes since 6.8.1 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.2-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.2-RC1/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.2-RC1/site/index.html
(note some *relative* links are broken and the 6.8.2 directories are not 
yet created - these will be OK once the site is deployed.)

JApiCmp Report (compared to 6.8.1):

https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.2-RC1/site/japicmp.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.2-RC1/site/rat-report.html

KEYS:
  https://downloads.apache.org/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1a) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch 
commons-bcel-6.8.2-RC1 commons-bcel-6.8.2-RC1
cd commons-bcel-6.8.2-RC1

1b) Download and unpack the source archive from:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.2-RC1/source

2) Check Apache licenses

This step is not required if the site includes a RAT report page which you then 
must check.

mvn apache-rat:check

3) Check binary compatibility

Older components still use Apache Clirr:

This step is not required if the site includes a Clirr report page which you 
then must check.

mvn cl

Re: commons-compress 1.26.0 breaks a lot of Apache POI tests

2024-02-21 Thread Gary Gregory 
Are you guys all squared away?

Gary

On Tue, Feb 20, 2024, 8:35 AM PJ Fanning  wrote:

> It looks like the tests that were failing related to some invalid files
> (deliberate test cases for these invalid files). The POI code catches the
> ZipException and checks the Exception message - and the message has changed.
>
> I have updated the POI code to check for the new message as well as the
> old message.
>
> I think this should be enough. Apologies for the noise.
>
>
>
> On 2024/02/20 15:59:12 PJ Fanning wrote:
> > Hi everyone,
> >
> > I upgraded Apache POI to use the latest commons-compress 1.26.0 release.
> POI processes Microsoft format files like xlsx and docs files - these
> formats are basically zip files with XML and other files contained within.
> >
> > The issue seems to be that commons-compress 1.26.0 requires signatures.
> >
> > We get exceptions like this:
> >
> > java.util.zip.ZipException: Cannot find zip signature within the file
> >
> > Most of the test files that have were created by Excel or Word or
> Powerpoint.
> >
> > Is there a way to disable this zip signature check? Any advice would be
> appreciated.
> >
> > Regards,
> > PJ
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>