[Math-1651] neuralnet : removing flaky test NetworkTest#testIterationOrder

[Dahiya, Anant]

Hi,

This is regarding the Issue Math-1651. The order of neurons in the neuron is 
non deterministic as it uses a ConcurrentHashMap which does not store the 
elements in any specific order.

The junit org.apache.commons.math4.neuralnet.NetworkTest#testIterationOrder in 
commons-math-neuralnet contradicts this behavior and checks if the neurons in 
the neuron map are ordered in increasing order. It would be best to remove this 
flaky test.

I have raised a PR for the same : 
https://github.com/apache/commons-math/pull/213
[https://opengraph.githubassets.com/c766c85f43f29469acf1494ebeb40b6eb190b2bd072e8c61f589758f5be68866/apache/commons-math/pull/213]
[MATH-1651] fix flaky test in commons-math-neuralnet by anantdahiya8 · Pull 
Request #213 · 
apache/commons-math
ConcurrentHashMap does not guarantee the order of elements. Replacing it with 
Collections.synchronizedMap which guarantees the order of the elements. Test 
which were failing : org.apache.commons.ma...
github.com


Thanks & Regards,
Anant Dahiya

Re: [Math-1651] neuralnet : removing flaky test NetworkTest#testIterationOrder

[Gilles Sadowski]

Hello.

Le jeu. 3 nov. 2022 à 11:51, Dahiya, Anant  a écrit :
>
> Hi,
>
> This is regarding the Issue Math-1651. The order of neurons in the neuron is 
> non deterministic as it uses a ConcurrentHashMap which does not store the 
> elements in any specific order.

Thanks for reporting the incorrect test.

>
> The junit org.apache.commons.math4.neuralnet.NetworkTest#testIterationOrder 
> in commons-math-neuralnet contradicts this behavior and checks if the neurons 
> in the neuron map are ordered in increasing order. It would be best to remove 
> this flaky test.
>
> I have raised a PR for the same : 
> https://github.com/apache/commons-math/pull/213
> [https://opengraph.githubassets.com/c766c85f43f29469acf1494ebeb40b6eb190b2bd072e8c61f589758f5be68866/apache/commons-math/pull/213]
> [MATH-1651] fix flaky test in commons-math-neuralnet by anantdahiya8 · Pull 
> Request #213 · 
> apache/commons-math
> ConcurrentHashMap does not guarantee the order of elements. Replacing it with 
> Collections.synchronizedMap which guarantees the order of the elements. Test 
> which were failing : org.apache.commons.ma...
> github.com

If I remember correctly, the intent of the test was to verify how the
identifiers were created (starting from 0 and incrementing by 1).
I've changed the test accordingly; please have a look at commit
50977290cdda79896ccb6304067341486fe104d2 (in "master").

Best regards,
Gilles

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCEMENT] Apache Commons BCEL 6.6.1

[Gary Gregory]

The Apache Commons BCEL team is pleased to announce the release of
Apache Commons BCEL 6.6.1-SNAPSHOT!

The Byte Code Engineering Library (BCEL) is intended to give users a
convenient
way to analyze, create, and manipulate compiled .class files. Classes are
represented by objects containing all the symbolic information of the given
class: methods, fields and byte code instructions.

Maintenance and bug fix release.

FIXED BUGS:
===

o   Keep ConstantPool.getConstant(int) backward compatible with
6.5.0 #157. Thanks to Kengo TODA, Gary Gregory.

CHANGES:


o   Bump actions/setup-java from 3.5.1 to 3.6.0 #159. Thanks to
Dependabot.
o   Bump spotbugs from 4.7.2 to 4.7.3. Thanks to Gary Gregory.
o   Bump pmd from 6.50.0 to 6.51.0. Thanks to Gary Gregory.


Historical list of changes:
https://commons.apache.org/proper/commons-bcelchanges-report.html

For complete information on Apache Commons BCEL, including instructions on
how to submit bug reports,
patches, or suggestions for improvement, see the Apache Apache Commons BCEL
website:

https://commons.apache.org/proper/commons-bcel

Download it from
https://commons.apache.org/proper/commons-bcel/download_bcel.cgi

Have fun!
-Apache Commons BCEL team

Feedback


Open source works best when you give feedback:

https://commons.apache.org/proper/commons-bcel

Please direct all bug reports to JIRA:

https://issues.apache.org/jira/browse/BCEL

Or subscribe to the commons-user mailing list

Gary Gregory, on behalf of
The Apache Commons Team

Re: [ANNOUNCEMENT] Apache Commons BCEL 6.6.1

[Bruno Kinoshita]

I think by accident the announcement email message has SNAPSHOT in the
version.

The subject has the correct version.

Thanks for RM'ing Gary!

Bruno

On Thu, 3 Nov 2022, 11:17 pm Gary Gregory,  wrote:

> The Apache Commons BCEL team is pleased to announce the release of
> Apache Commons BCEL 6.6.1-SNAPSHOT!
>
> The Byte Code Engineering Library (BCEL) is intended to give users a
> convenient
> way to analyze, create, and manipulate compiled .class files. Classes are
> represented by objects containing all the symbolic information of the given
> class: methods, fields and byte code instructions.
>
> Maintenance and bug fix release.
>
> FIXED BUGS:
> ===
>
> o   Keep ConstantPool.getConstant(int) backward compatible with
> 6.5.0 #157. Thanks to Kengo TODA, Gary Gregory.
>
> CHANGES:
> 
>
> o   Bump actions/setup-java from 3.5.1 to 3.6.0 #159. Thanks to
> Dependabot.
> o   Bump spotbugs from 4.7.2 to 4.7.3. Thanks to Gary Gregory.
> o   Bump pmd from 6.50.0 to 6.51.0. Thanks to Gary Gregory.
>
>
> Historical list of changes:
> https://commons.apache.org/proper/commons-bcelchanges-report.html
>
> For complete information on Apache Commons BCEL, including instructions on
> how to submit bug reports,
> patches, or suggestions for improvement, see the Apache Apache Commons BCEL
> website:
>
> https://commons.apache.org/proper/commons-bcel
>
> Download it from
> https://commons.apache.org/proper/commons-bcel/download_bcel.cgi
>
> Have fun!
> -Apache Commons BCEL team
>
> Feedback
> 
>
> Open source works best when you give feedback:
>
> https://commons.apache.org/proper/commons-bcel
>
> Please direct all bug reports to JIRA:
>
> https://issues.apache.org/jira/browse/BCEL
>
> Or subscribe to the commons-user mailing list
>
> Gary Gregory, on behalf of
> The Apache Commons Team
>

Re: [ANNOUNCEMENT] Apache Commons BCEL 6.6.1

[Gary Gregory]

Darn, sorry about that.

Gary

On Thu, Nov 3, 2022 at 6:57 PM Bruno Kinoshita  wrote:
>
> I think by accident the announcement email message has SNAPSHOT in the
> version.
>
> The subject has the correct version.
>
> Thanks for RM'ing Gary!
>
> Bruno
>
> On Thu, 3 Nov 2022, 11:17 pm Gary Gregory,  wrote:
>
> > The Apache Commons BCEL team is pleased to announce the release of
> > Apache Commons BCEL 6.6.1-SNAPSHOT!
> >
> > The Byte Code Engineering Library (BCEL) is intended to give users a
> > convenient
> > way to analyze, create, and manipulate compiled .class files. Classes are
> > represented by objects containing all the symbolic information of the given
> > class: methods, fields and byte code instructions.
> >
> > Maintenance and bug fix release.
> >
> > FIXED BUGS:
> > ===
> >
> > o   Keep ConstantPool.getConstant(int) backward compatible with
> > 6.5.0 #157. Thanks to Kengo TODA, Gary Gregory.
> >
> > CHANGES:
> > 
> >
> > o   Bump actions/setup-java from 3.5.1 to 3.6.0 #159. Thanks to
> > Dependabot.
> > o   Bump spotbugs from 4.7.2 to 4.7.3. Thanks to Gary Gregory.
> > o   Bump pmd from 6.50.0 to 6.51.0. Thanks to Gary Gregory.
> >
> >
> > Historical list of changes:
> > https://commons.apache.org/proper/commons-bcelchanges-report.html
> >
> > For complete information on Apache Commons BCEL, including instructions on
> > how to submit bug reports,
> > patches, or suggestions for improvement, see the Apache Apache Commons BCEL
> > website:
> >
> > https://commons.apache.org/proper/commons-bcel
> >
> > Download it from
> > https://commons.apache.org/proper/commons-bcel/download_bcel.cgi
> >
> > Have fun!
> > -Apache Commons BCEL team
> >
> > Feedback
> > 
> >
> > Open source works best when you give feedback:
> >
> > https://commons.apache.org/proper/commons-bcel
> >
> > Please direct all bug reports to JIRA:
> >
> > https://issues.apache.org/jira/browse/BCEL
> >
> > Or subscribe to the commons-user mailing list
> >
> > Gary Gregory, on behalf of
> > The Apache Commons Team
> >

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org