[all] multi-module project aggregate javadoc
Currently the multi-module projects RNG, Math, Numbers, and Geometry create a site that has the javadocs spread through the various site modules. However, in each project the modules are possible to use altogether. So it would be useful to have an aggregate javadoc somewhere on their sites. Note this is in contrast to VFS where there is a link on the site at the top level to the javadoc for the core vfs2 module that contains the API. I believe the other modules are implementations of the API and so the concept of an aggregate API is not applicable. I have updated RNG to allow the docs module (previously used for coverage reporting) to be included in the site. This generates an aggregate javadoc report. The complete RNG API can then be viewed from the docs module. The module is currently included via a profile: > mvn clean package site -Pdocs site:stage > open target/staging/commons-rng-docs/index.html Or to view the module only: > cd commons-rng-docs > mvn site > open target/site/index.html A link to the aggregate javadoc can be added to the top level site page; this requires the docs module to be included in the reactor to avoid a dead link from the top level site descriptor (site.xml). I suggest changing the docs module from optional to be included in the reactor. Currently the 'mvn install' command takes around 6-8 seconds to execute in the module as most of the standard build plugins are disabled. So this has a low impact on total build time. This would allow a site build to always assume the module is present and so add a link at the top level site to the aggregate javadoc. I can make a similar change to the other multi-module projects. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [all] multi-module project aggregate javadoc
I like the idea of an aggregate Javadoc, even for VFS :-) You never know that something is documented until you see it! Gary On Tue, Oct 25, 2022 at 6:36 AM Alex Herbert wrote: > > Currently the multi-module projects RNG, Math, Numbers, and Geometry > create a site that has the javadocs spread through the various site > modules. However, in each project the modules are possible to use > altogether. So it would be useful to have an aggregate javadoc > somewhere on their sites. > > Note this is in contrast to VFS where there is a link on the site at > the top level to the javadoc for the core vfs2 module that contains > the API. I believe the other modules are implementations of the API > and so the concept of an aggregate API is not applicable. > > I have updated RNG to allow the docs module (previously used for > coverage reporting) to be included in the site. This generates an > aggregate javadoc report. The complete RNG API can then be viewed from > the docs module. The module is currently included via a profile: > > > mvn clean package site -Pdocs site:stage > > open target/staging/commons-rng-docs/index.html > > Or to view the module only: > > > cd commons-rng-docs > > mvn site > > open target/site/index.html > > A link to the aggregate javadoc can be added to the top level site > page; this requires the docs module to be included in the reactor to > avoid a dead link from the top level site descriptor (site.xml). > > I suggest changing the docs module from optional to be included in the > reactor. Currently the 'mvn install' command takes around 6-8 seconds > to execute in the module as most of the standard build plugins are > disabled. So this has a low impact on total build time. This would > allow a site build to always assume the module is present and so add a > link at the top level site to the aggregate javadoc. > > I can make a similar change to the other multi-module projects. > > Alex > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[daemon] kill child processes recursively; PR #64
Thoughts and reviews for https://github.com/apache/commons-daemon/pull/64 are needed. TY! Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1
On Mon, Oct 24, 2022 at 4:19 PM Alex Herbert wrote: > > On Sun, 23 Oct 2022 at 14:09, Gary D. Gregory wrote: > > > > Ah, well, let's have you review git master now and feel free to refactor. I > > think we are close if not done for another RC. WDYT? > > Since this thread was for the RC1 vote I started a new thread titled: > > [csv] validation of duplicate headers (was [VOTE] Release Apache > Commons CSV 1.10.0 based on RC1) > > I found one bug in the implementation is master which I fixed for > CSVFormat. There is still some inconsistent behaviour by CSVParser > that I discuss in the new thread that should be fixed, or current > behaviour documented, before an RC2. Thanks Alex for putting in the time and effort, needs careful consideration... Gary > > Alex > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC1
Ping ;-) On 2022/10/23 14:58:05 Gary Gregory wrote: > We have fixed one bug since Apache Commons BCEL 6.6.0 was released, so > I would like to release Apache Commons BCEL 6.6.1. This will help > SpotBugs migrate from 6.5.0. > > Apache Commons BCEL 6.6.1 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1 (svn > revision 57519) > > The Git tag commons-bcel-6.6.1-RC1 commit for this RC is > ec208052baf4c596f7e8cfacc281d3e2408809ac which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=ec208052baf4c596f7e8cfacc281d3e2408809ac > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > --branch commons-bcel-6.6.1-RC1 commons-bcel-6.6.1-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1602/org/apache/bcel/bcel/6.6.1/ > > These are the artifacts and their hashes: > > #Release SHA-512s > #Sun Oct 23 10:44:36 EDT 2022 > Apache\ Commons\ > BCEL-6.6.1.spdx.rdf.xml=f07a9526a013c6c700e84005f45eb3f582b105756486b665b084be1accf147179e22db752c370dd2cf2c779a2c9188b2fec431fc7de56f0cfc355c26ea25d2fe > bcel-6.6.1-bin.tar.gz=4358ab0a7103e33bf4d0774cdeab11c4b32a7ef65944e08602b6a5c2da7ac1e8f04edc1603b458381e29c9341c32f1679521bb544eb4a081c351d82b646d6024 > bcel-6.6.1-bin.zip=1acd0c776c06d50e7f2a4c5d6f7ea90374cdb9f0d6ddc994eb5d8a6eb3632ac10327167b372567456b0b83c0ebd99652f0f69c39e3ba57d31b87b32063eb223d > bcel-6.6.1-bom.json=e51e003589f1de2e73d1fbc3dfdff6f30e85df2aca036b9bcdf5dffe5eb6915adbbb8ab72aed63ff5dcd32b9db51316a088c2b89e8ad54657170c21feae404a8 > bcel-6.6.1-bom.xml=f00ddbf5a93d88209e781a71de7067897005e36ca88d5be10f105af87f8ae7cabe07e6373f166def2de4c7d72b30e25e8f20a6f17827260754ed870480647049 > bcel-6.6.1-javadoc.jar=35d2dc3daaa7adefd17561f4dc896dbdce5fb0530c8d867fc8178bdab8c9d21afd27b4429b9650281d8692a62039739795b642e9ff5c317a73b1089661aab491 > bcel-6.6.1-sources.jar=3ecf109550cd8837dba586570e33c73fa81efccc69e2b68cc03b53756947e4c9f95575e77b751181cf934f20f5e078654f343400b8184ab414e89b316f7f33f4 > bcel-6.6.1-src.tar.gz=bb4283d1ebcdeaef7f3530826f16681cad7a53508056178d63621f7a17321df3bbc11914e75dd7b81f967723c8b6bc4009853dc80bb4707de2f5f6db26eb8f7a > bcel-6.6.1-src.zip=a62790a65ecb2f69f260f683d9f75a3a4ef98abfbec5a37efbe10ad7d5fd9c33771ff5cba305c3f18c336f8495a1ce5c5ab43ecb9124973e2728742d634b6288 > bcel-6.6.1-test-sources.jar=0f4dd1c7652b564b1343cc2731118c3575d351022f2811d3049f9eccda77b9fb05779691996ddb6396717fa75699e8a407f5c654bf75d5a7aca50bd1a2e9d95f > bcel-6.6.1-tests.jar=1a06e51f00d8de83c4128ddfaf3a318a2afca8e5e67739cfb05956d4c4fce02028d3a93ca3288fc494b46ca08d6e707544b5cc5401c12396cde4a0dc25d49136 > > I have tested this with 'mvn' (the default goal) and 'mvn -V > -Duser.name=$my_apache_id -Prelease -Ptest-deploy -P jacoco -P japicmp > clean package site deploy' using: > > Darwin 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 > PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64 > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > Maven home: /usr/local/Cellar/maven/3.8.6/libexec > Java version: 1.8.0_345, vendor: Homebrew, runtime: > /usr/local/Cellar/openjdk@8/1.8.0+345/libexec/openjdk.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "12.6", arch: "x86_64", family: "mac" > > Details of changes since 6.6.0 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/index.html > (note some *relative* links are broken and the 6.6.1 directories > are not yet created - these will be OK once the site is deployed.) > > JApiCmp Report (compared to 6.6.0): > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/japicmp.html > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/rat-report.html > > KEYS: > https://downloads.apache.org/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > == > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > --branch commons-bcel-6.6.1-RC1 commons-bcel-6.6.1-RC1 > cd commons-bcel-
Re: [csv] validation of duplicate headers (was [VOTE] Release Apache Commons CSV 1.10.0 based on RC1)
On Sun, 23 Oct 2022 at 19:44, Alex Herbert wrote: > > Summary: > > 1. Should CSVParser treat null and blank headers as the same when > checking for duplicates, i.e. all are considered an 'empty' name? This > is current CSVFormat behaviour. > 2. Should CSVFormat respect ignoreHeaderCase when checking for > duplicates? This is current CSVParser behaviour. > 3. Should blank column names be sanitised to the empty string ""? This > is not current behaviour but is the logical behaviour for checking > duplicates in CSVFormat. I have proposed a fix for this in PR #279 [1]. It maintains a flag that notes when any type of missing header name has occurred, Thus it now throws when a duplicate null is found when using DuplicateHeaderMode.DISALLOW. I marked the PR as a WIP. It should probably have an associated Jira ticket to track this change if merged. Or it could be added to CSV-264 as further details of that fix [2]. I have not updated the documentation for ignoreHeaderCase to address item 2. The functionality with regard to the header map is unchanged since the header map does not store null headers, and any missing headers are not modified (i.e. they are not all sanitised to the empty string ""). Alex [1] https://github.com/apache/commons-csv/pull/279 [2] https://issues.apache.org/jira/browse/CSV-264 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC1
+1 Tested with: Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /Users/matt/.sdkman/candidates/maven/current Java version: 1.8.0_322, vendor: Azul Systems, Inc., runtime: /Users/matt/.sdkman/candidates/java/8.0.322-zulu/zulu-8.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "12.6", arch: "aarch64", family: "mac" — Matt Sicker > On Oct 23, 2022, at 09:58, Gary Gregory wrote: > > We have fixed one bug since Apache Commons BCEL 6.6.0 was released, so > I would like to release Apache Commons BCEL 6.6.1. This will help > SpotBugs migrate from 6.5.0. > > Apache Commons BCEL 6.6.1 RC1 is available for review here: >https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1 (svn > revision 57519) > > The Git tag commons-bcel-6.6.1-RC1 commit for this RC is > ec208052baf4c596f7e8cfacc281d3e2408809ac which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=ec208052baf4c596f7e8cfacc281d3e2408809ac > You may checkout this tag using: >git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > --branch commons-bcel-6.6.1-RC1 commons-bcel-6.6.1-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1602/org/apache/bcel/bcel/6.6.1/ > > These are the artifacts and their hashes: > > #Release SHA-512s > #Sun Oct 23 10:44:36 EDT 2022 > Apache\ Commons\ > BCEL-6.6.1.spdx.rdf.xml=f07a9526a013c6c700e84005f45eb3f582b105756486b665b084be1accf147179e22db752c370dd2cf2c779a2c9188b2fec431fc7de56f0cfc355c26ea25d2fe > bcel-6.6.1-bin.tar.gz=4358ab0a7103e33bf4d0774cdeab11c4b32a7ef65944e08602b6a5c2da7ac1e8f04edc1603b458381e29c9341c32f1679521bb544eb4a081c351d82b646d6024 > bcel-6.6.1-bin.zip=1acd0c776c06d50e7f2a4c5d6f7ea90374cdb9f0d6ddc994eb5d8a6eb3632ac10327167b372567456b0b83c0ebd99652f0f69c39e3ba57d31b87b32063eb223d > bcel-6.6.1-bom.json=e51e003589f1de2e73d1fbc3dfdff6f30e85df2aca036b9bcdf5dffe5eb6915adbbb8ab72aed63ff5dcd32b9db51316a088c2b89e8ad54657170c21feae404a8 > bcel-6.6.1-bom.xml=f00ddbf5a93d88209e781a71de7067897005e36ca88d5be10f105af87f8ae7cabe07e6373f166def2de4c7d72b30e25e8f20a6f17827260754ed870480647049 > bcel-6.6.1-javadoc.jar=35d2dc3daaa7adefd17561f4dc896dbdce5fb0530c8d867fc8178bdab8c9d21afd27b4429b9650281d8692a62039739795b642e9ff5c317a73b1089661aab491 > bcel-6.6.1-sources.jar=3ecf109550cd8837dba586570e33c73fa81efccc69e2b68cc03b53756947e4c9f95575e77b751181cf934f20f5e078654f343400b8184ab414e89b316f7f33f4 > bcel-6.6.1-src.tar.gz=bb4283d1ebcdeaef7f3530826f16681cad7a53508056178d63621f7a17321df3bbc11914e75dd7b81f967723c8b6bc4009853dc80bb4707de2f5f6db26eb8f7a > bcel-6.6.1-src.zip=a62790a65ecb2f69f260f683d9f75a3a4ef98abfbec5a37efbe10ad7d5fd9c33771ff5cba305c3f18c336f8495a1ce5c5ab43ecb9124973e2728742d634b6288 > bcel-6.6.1-test-sources.jar=0f4dd1c7652b564b1343cc2731118c3575d351022f2811d3049f9eccda77b9fb05779691996ddb6396717fa75699e8a407f5c654bf75d5a7aca50bd1a2e9d95f > bcel-6.6.1-tests.jar=1a06e51f00d8de83c4128ddfaf3a318a2afca8e5e67739cfb05956d4c4fce02028d3a93ca3288fc494b46ca08d6e707544b5cc5401c12396cde4a0dc25d49136 > > I have tested this with 'mvn' (the default goal) and 'mvn -V > -Duser.name=$my_apache_id -Prelease -Ptest-deploy -P jacoco -P japicmp > clean package site deploy' using: > > Darwin 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 > PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64 > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > Maven home: /usr/local/Cellar/maven/3.8.6/libexec > Java version: 1.8.0_345, vendor: Homebrew, runtime: > /usr/local/Cellar/openjdk@8/1.8.0+345/libexec/openjdk.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "12.6", arch: "x86_64", family: "mac" > > Details of changes since 6.6.0 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/index.html >(note some *relative* links are broken and the 6.6.1 directories > are not yet created - these will be OK once the site is deployed.) > > JApiCmp Report (compared to 6.6.0): > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/japicmp.html > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1/site/rat-report.html > > KEYS: > https://downloads.apache.org/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) > > For following is intended as a helper and refresher for reviewers. > > Valid
[VOTE] Release Apache Commons Compress 1.22 based on RC1
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Compress 1.21 was released, so I would like to release Apache Commons Compress 1.22. Apache Commons Compress 1.22 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1 (svn revision 57596) The Git tag commons-compress-1.22-RC1 commit for this RC is 5183d0b08c0897e6f0c41a038487b7c795136425 which you can browse here: https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=5183d0b08c0897e6f0c41a038487b7c795136425 You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-compress.git --branch commons-compress-1.22-RC1 commons-compress-1.22-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1603/org/apache/commons/commons-compress/1.22/ These are the artifacts and their hashes: #Release SHA-512s #Tue Oct 25 14:46:59 CDT 2022 Apache\ Commons\ Compress-1.22.spdx.rdf.xml=aef6cc68bff93fe66c70ffb486a3f9e5709ada04e51c8eb5901368eb9e7ce627885b367123c3db86912b3625d374d0bf02610edb86fe223ae974bab2fa60bec2 commons-compress-1.22-bin.tar.gz=81f0f1e75797d7199e8eb399f26571955f27040b4255859ec4df73714a2edd0d7238823201ffd486bf18f1cbf80ff7f28dbd4f5ad4655826468775ceec224d55 commons-compress-1.22-bin.zip=ccfeaa45ba257d6895fd849a1d31f88498d4ada23502318dd94747f00e9662e6ca335ab458b12436024c4cb25cef723393e0336534c6fc978b27aaa4b0e82650 commons-compress-1.22-bom.json=24dcbf472caf173e1ed4151867451bd457b581c86e1cd24a045ddbe3e4a139916598dbf51b87d3f299f30d0029f62a65981e42e48dd74efb44fa1068cde0fdc0 commons-compress-1.22-bom.xml=8e19c58886ff57ff078c88e90d6b1dcb21b48dc43df1ab69e7727ff11a5374e16e6f2dfc32fc5ed37ba4a0ccc065b6a41bdb00a60fd9789fb6d7b82094bb28ec commons-compress-1.22-javadoc.jar=f7d10749afd6574cb6189d5701d310d5a7aae029d6d6b8a879d8dda4d9435f815fb671437c876f0f74cf7d8ebd219b04a2c903cc83a2bd8ddf63225f69add06c commons-compress-1.22-sources.jar=94c2a396e831cdfcee438958a58fe5ca70b53b4884cd665568805ad0519f8ca12e960e2ce92ea73d70e414c6dd4a5f8c562bc758e19f5bffb06b696fb5589b6d commons-compress-1.22-src.tar.gz=7d9e34d9a23e81778574fce2e637b380ef5027f3fc262f2583ec9568cfd16b766ec591a025f78987e2290a4a193992f4621c3ca05104e8e17a9cc32efdde8487 commons-compress-1.22-src.zip=fa8fec592d255f5ef23ce27491db9523222ed90113e7efd02fd9cc126d5e2df3d9caa578d049df0cca1f299e54d416295002b7f9c24e87b4b77b5c54658013bb commons-compress-1.22-test-sources.jar=703e5a7b203505f42e69257952640594a1d0fdc14311e8028728d9bc5c27e65554767b6ea0583cc23e91a400ea595210890773395cfb807afbf3468604bf38ce commons-compress-1.22-tests.jar=771d1ad4757e65993d75c629f206eecb7e99765eb01e4da621a405cc068e5cade8332f57fb3d19d5cb273aec54e1ea85c24a3053c0cb61c386ec2f64770b868f I have tested this with ***'mvn clean install site'*** using: Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /Users/matt/.sdkman/candidates/maven/current Java version: 1.8.0_322, vendor: Azul Systems, Inc., runtime: /Users/matt/.sdkman/candidates/java/8.0.322-zulu/zulu-8.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "12.6", arch: "aarch64", family: "mac" Darwin matt1max.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64 Details of changes since 1.21 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/index.html (note some *relative* links are broken and the 1.22 directories are not yet created - these will be OK once the site is deployed.) *** JApiCmp Report (compared to 1.21): https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/japicmp.html *** Note that the above report notes several errors. These are considered OK for the reasons stated below. These exceptions are also noted in the Changes and Release Notes. Errors reported: - removal of checked exceptions in various methods *** RAT Report: https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Matt Sicker, Release Manager (using key 0x031EE010CA15D1EE) For following is intended as a helper and refresher for reviewers. Validating a release candidate == These guidelines are NOT complete. Requirements: Git, Java, Maven. You can validate a release from a release candidate (RC) tag as follows. 1) Clone and checkout the RC tag
Re: [VOTE] Release Apache Commons Compress 1.22 based on RC1
Matt, You are suppose to edit what is in between ××× ... Gary On Tue, Oct 25, 2022, 16:05 Matt Sicker wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Compress 1.21 was released, so I would like to release > Apache Commons Compress 1.22. > > Apache Commons Compress 1.22 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1 (svn > revision 57596) > > The Git tag commons-compress-1.22-RC1 commit for this RC is > 5183d0b08c0897e6f0c41a038487b7c795136425 which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=5183d0b08c0897e6f0c41a038487b7c795136425 > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-compress.git > --branch commons-compress-1.22-RC1 commons-compress-1.22-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1603/org/apache/commons/commons-compress/1.22/ > > These are the artifacts and their hashes: > > #Release SHA-512s > #Tue Oct 25 14:46:59 CDT 2022 > Apache\ Commons\ > Compress-1.22.spdx.rdf.xml=aef6cc68bff93fe66c70ffb486a3f9e5709ada04e51c8eb5901368eb9e7ce627885b367123c3db86912b3625d374d0bf02610edb86fe223ae974bab2fa60bec2 > > commons-compress-1.22-bin.tar.gz=81f0f1e75797d7199e8eb399f26571955f27040b4255859ec4df73714a2edd0d7238823201ffd486bf18f1cbf80ff7f28dbd4f5ad4655826468775ceec224d55 > > commons-compress-1.22-bin.zip=ccfeaa45ba257d6895fd849a1d31f88498d4ada23502318dd94747f00e9662e6ca335ab458b12436024c4cb25cef723393e0336534c6fc978b27aaa4b0e82650 > > commons-compress-1.22-bom.json=24dcbf472caf173e1ed4151867451bd457b581c86e1cd24a045ddbe3e4a139916598dbf51b87d3f299f30d0029f62a65981e42e48dd74efb44fa1068cde0fdc0 > > commons-compress-1.22-bom.xml=8e19c58886ff57ff078c88e90d6b1dcb21b48dc43df1ab69e7727ff11a5374e16e6f2dfc32fc5ed37ba4a0ccc065b6a41bdb00a60fd9789fb6d7b82094bb28ec > > commons-compress-1.22-javadoc.jar=f7d10749afd6574cb6189d5701d310d5a7aae029d6d6b8a879d8dda4d9435f815fb671437c876f0f74cf7d8ebd219b04a2c903cc83a2bd8ddf63225f69add06c > > commons-compress-1.22-sources.jar=94c2a396e831cdfcee438958a58fe5ca70b53b4884cd665568805ad0519f8ca12e960e2ce92ea73d70e414c6dd4a5f8c562bc758e19f5bffb06b696fb5589b6d > > commons-compress-1.22-src.tar.gz=7d9e34d9a23e81778574fce2e637b380ef5027f3fc262f2583ec9568cfd16b766ec591a025f78987e2290a4a193992f4621c3ca05104e8e17a9cc32efdde8487 > > commons-compress-1.22-src.zip=fa8fec592d255f5ef23ce27491db9523222ed90113e7efd02fd9cc126d5e2df3d9caa578d049df0cca1f299e54d416295002b7f9c24e87b4b77b5c54658013bb > > commons-compress-1.22-test-sources.jar=703e5a7b203505f42e69257952640594a1d0fdc14311e8028728d9bc5c27e65554767b6ea0583cc23e91a400ea595210890773395cfb807afbf3468604bf38ce > > commons-compress-1.22-tests.jar=771d1ad4757e65993d75c629f206eecb7e99765eb01e4da621a405cc068e5cade8332f57fb3d19d5cb273aec54e1ea85c24a3053c0cb61c386ec2f64770b868f > > > > I have tested this with ***'mvn clean install site'*** using: > > Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) > Maven home: /Users/matt/.sdkman/candidates/maven/current > Java version: 1.8.0_322, vendor: Azul Systems, Inc., runtime: > /Users/matt/.sdkman/candidates/java/8.0.322-zulu/zulu-8.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "12.6", arch: "aarch64", family: "mac" > Darwin matt1max.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 > 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64 > > Details of changes since 1.21 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/index.html > (note some *relative* links are broken and the 1.22 directories are > not yet created - these will be OK once the site is deployed.) > > *** JApiCmp Report (compared to 1.21): > > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/japicmp.html > > *** > Note that the above report notes several errors. > These are considered OK for the reasons stated below. > These exceptions are also noted in the Changes and Release Notes. > > Errors reported: > - removal of checked exceptions in various methods > *** > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Matt Sicker, > Release Manager (using key 0x031EE010CA15D1EE) > > For following is intended as a helper and ref
Re: [csv] validation of duplicate headers (was [VOTE] Release Apache Commons CSV 1.10.0 based on RC1)
On Tue, 25 Oct 2022 at 17:29, Alex Herbert wrote: > > On Sun, 23 Oct 2022 at 19:44, Alex Herbert wrote: > > > > Summary: > > > > 1. Should CSVParser treat null and blank headers as the same when > > checking for duplicates, i.e. all are considered an 'empty' name? This > > is current CSVFormat behaviour. > > 2. Should CSVFormat respect ignoreHeaderCase when checking for > > duplicates? This is current CSVParser behaviour. > > 3. Should blank column names be sanitised to the empty string ""? This > > is not current behaviour but is the logical behaviour for checking > > duplicates in CSVFormat. > > I have proposed a fix for this in PR #279 [1]. It maintains a flag > that notes when any type of missing header name has occurred, Thus it > now throws when a duplicate null is found when using > DuplicateHeaderMode.DISALLOW. > > I marked the PR as a WIP. It should probably have an associated Jira > ticket to track this change if merged. Or it could be added to CSV-264 > as further details of that fix [2]. > > I have not updated the documentation for ignoreHeaderCase to address item 2. > > The functionality with regard to the header map is unchanged since the > header map does not store null headers, and any missing headers are > not modified (i.e. they are not all sanitised to the empty string ""). > > Alex > > [1] https://github.com/apache/commons-csv/pull/279 > [2] https://issues.apache.org/jira/browse/CSV-264 PR now updated with: - Documentation of the parser specific flag 'ignore header case' - CSVDuplicateHeaderTest to have test cases using the case insensitive duplicates I believe this to be all that is required to fix the issues with handling duplicate header names. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[All] no more Travis
Note that we no longer will support using Travis, Apache wide. For GitHub, and Deamon and Crypto, that means we need help to get the C bits building. Gary
Re: [VOTE] Release Apache Commons Compress 1.22 based on RC1
I did; I just forgot to remove the markers. — Matt Sicker > On Oct 25, 2022, at 15:43, Gary Gregory wrote: > > Matt, > > You are suppose to edit what is in between ××× ... > > Gary > > On Tue, Oct 25, 2022, 16:05 Matt Sicker wrote: > >> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons Compress 1.21 was released, so I would like to release >> Apache Commons Compress 1.22. >> >> Apache Commons Compress 1.22 RC1 is available for review here: >>https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1 (svn >> revision 57596) >> >> The Git tag commons-compress-1.22-RC1 commit for this RC is >> 5183d0b08c0897e6f0c41a038487b7c795136425 which you can browse here: >> >> https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=5183d0b08c0897e6f0c41a038487b7c795136425 >> You may checkout this tag using: >>git clone https://gitbox.apache.org/repos/asf/commons-compress.git >> --branch commons-compress-1.22-RC1 commons-compress-1.22-RC1 >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1603/org/apache/commons/commons-compress/1.22/ >> >> These are the artifacts and their hashes: >> >> #Release SHA-512s >> #Tue Oct 25 14:46:59 CDT 2022 >> Apache\ Commons\ >> Compress-1.22.spdx.rdf.xml=aef6cc68bff93fe66c70ffb486a3f9e5709ada04e51c8eb5901368eb9e7ce627885b367123c3db86912b3625d374d0bf02610edb86fe223ae974bab2fa60bec2 >> >> commons-compress-1.22-bin.tar.gz=81f0f1e75797d7199e8eb399f26571955f27040b4255859ec4df73714a2edd0d7238823201ffd486bf18f1cbf80ff7f28dbd4f5ad4655826468775ceec224d55 >> >> commons-compress-1.22-bin.zip=ccfeaa45ba257d6895fd849a1d31f88498d4ada23502318dd94747f00e9662e6ca335ab458b12436024c4cb25cef723393e0336534c6fc978b27aaa4b0e82650 >> >> commons-compress-1.22-bom.json=24dcbf472caf173e1ed4151867451bd457b581c86e1cd24a045ddbe3e4a139916598dbf51b87d3f299f30d0029f62a65981e42e48dd74efb44fa1068cde0fdc0 >> >> commons-compress-1.22-bom.xml=8e19c58886ff57ff078c88e90d6b1dcb21b48dc43df1ab69e7727ff11a5374e16e6f2dfc32fc5ed37ba4a0ccc065b6a41bdb00a60fd9789fb6d7b82094bb28ec >> >> commons-compress-1.22-javadoc.jar=f7d10749afd6574cb6189d5701d310d5a7aae029d6d6b8a879d8dda4d9435f815fb671437c876f0f74cf7d8ebd219b04a2c903cc83a2bd8ddf63225f69add06c >> >> commons-compress-1.22-sources.jar=94c2a396e831cdfcee438958a58fe5ca70b53b4884cd665568805ad0519f8ca12e960e2ce92ea73d70e414c6dd4a5f8c562bc758e19f5bffb06b696fb5589b6d >> >> commons-compress-1.22-src.tar.gz=7d9e34d9a23e81778574fce2e637b380ef5027f3fc262f2583ec9568cfd16b766ec591a025f78987e2290a4a193992f4621c3ca05104e8e17a9cc32efdde8487 >> >> commons-compress-1.22-src.zip=fa8fec592d255f5ef23ce27491db9523222ed90113e7efd02fd9cc126d5e2df3d9caa578d049df0cca1f299e54d416295002b7f9c24e87b4b77b5c54658013bb >> >> commons-compress-1.22-test-sources.jar=703e5a7b203505f42e69257952640594a1d0fdc14311e8028728d9bc5c27e65554767b6ea0583cc23e91a400ea595210890773395cfb807afbf3468604bf38ce >> >> commons-compress-1.22-tests.jar=771d1ad4757e65993d75c629f206eecb7e99765eb01e4da621a405cc068e5cade8332f57fb3d19d5cb273aec54e1ea85c24a3053c0cb61c386ec2f64770b868f >> >> >> >> I have tested this with ***'mvn clean install site'*** using: >> >> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) >> Maven home: /Users/matt/.sdkman/candidates/maven/current >> Java version: 1.8.0_322, vendor: Azul Systems, Inc., runtime: >> /Users/matt/.sdkman/candidates/java/8.0.322-zulu/zulu-8.jdk/Contents/Home/jre >> Default locale: en_US, platform encoding: UTF-8 >> OS name: "mac os x", version: "12.6", arch: "aarch64", family: "mac" >> Darwin matt1max.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 >> 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64 >> >> Details of changes since 1.21 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/RELEASE-NOTES.txt >> >> https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/changes-report.html >> >> Site: >> >> https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/index.html >>(note some *relative* links are broken and the 1.22 directories are >> not yet created - these will be OK once the site is deployed.) >> >> *** JApiCmp Report (compared to 1.21): >> >> https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/japicmp.html >> >>*** >>Note that the above report notes several errors. >>These are considered OK for the reasons stated below. >>These exceptions are also noted in the Changes and Release Notes. >> >>Errors reported: >>- removal of checked exceptions in various methods >>*** >> >> RAT Report: >> >> https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/rat-report.html >> >> KEYS: >> https://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner than 72 hours from now. >> >> [ ] +1 Release these
Re: [VOTE] Release Apache Commons Compress 1.22 based on RC1
Roger that, thanks Matt. Gary On Tue, Oct 25, 2022, 19:50 Matt Sicker wrote: > I did; I just forgot to remove the markers. > — > Matt Sicker > > > On Oct 25, 2022, at 15:43, Gary Gregory wrote: > > > > Matt, > > > > You are suppose to edit what is in between ××× ... > > > > Gary > > > > On Tue, Oct 25, 2022, 16:05 Matt Sicker wrote: > > > >> We have fixed quite a few bugs and added some significant enhancements > >> since Apache Commons Compress 1.21 was released, so I would like to > release > >> Apache Commons Compress 1.22. > >> > >> Apache Commons Compress 1.22 RC1 is available for review here: > >>https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1 > (svn > >> revision 57596) > >> > >> The Git tag commons-compress-1.22-RC1 commit for this RC is > >> 5183d0b08c0897e6f0c41a038487b7c795136425 which you can browse here: > >> > >> > https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=5183d0b08c0897e6f0c41a038487b7c795136425 > >> You may checkout this tag using: > >>git clone https://gitbox.apache.org/repos/asf/commons-compress.git > >> --branch commons-compress-1.22-RC1 commons-compress-1.22-RC1 > >> > >> Maven artifacts are here: > >> > >> > https://repository.apache.org/content/repositories/orgapachecommons-1603/org/apache/commons/commons-compress/1.22/ > >> > >> These are the artifacts and their hashes: > >> > >> #Release SHA-512s > >> #Tue Oct 25 14:46:59 CDT 2022 > >> Apache\ Commons\ > >> > Compress-1.22.spdx.rdf.xml=aef6cc68bff93fe66c70ffb486a3f9e5709ada04e51c8eb5901368eb9e7ce627885b367123c3db86912b3625d374d0bf02610edb86fe223ae974bab2fa60bec2 > >> > >> > commons-compress-1.22-bin.tar.gz=81f0f1e75797d7199e8eb399f26571955f27040b4255859ec4df73714a2edd0d7238823201ffd486bf18f1cbf80ff7f28dbd4f5ad4655826468775ceec224d55 > >> > >> > commons-compress-1.22-bin.zip=ccfeaa45ba257d6895fd849a1d31f88498d4ada23502318dd94747f00e9662e6ca335ab458b12436024c4cb25cef723393e0336534c6fc978b27aaa4b0e82650 > >> > >> > commons-compress-1.22-bom.json=24dcbf472caf173e1ed4151867451bd457b581c86e1cd24a045ddbe3e4a139916598dbf51b87d3f299f30d0029f62a65981e42e48dd74efb44fa1068cde0fdc0 > >> > >> > commons-compress-1.22-bom.xml=8e19c58886ff57ff078c88e90d6b1dcb21b48dc43df1ab69e7727ff11a5374e16e6f2dfc32fc5ed37ba4a0ccc065b6a41bdb00a60fd9789fb6d7b82094bb28ec > >> > >> > commons-compress-1.22-javadoc.jar=f7d10749afd6574cb6189d5701d310d5a7aae029d6d6b8a879d8dda4d9435f815fb671437c876f0f74cf7d8ebd219b04a2c903cc83a2bd8ddf63225f69add06c > >> > >> > commons-compress-1.22-sources.jar=94c2a396e831cdfcee438958a58fe5ca70b53b4884cd665568805ad0519f8ca12e960e2ce92ea73d70e414c6dd4a5f8c562bc758e19f5bffb06b696fb5589b6d > >> > >> > commons-compress-1.22-src.tar.gz=7d9e34d9a23e81778574fce2e637b380ef5027f3fc262f2583ec9568cfd16b766ec591a025f78987e2290a4a193992f4621c3ca05104e8e17a9cc32efdde8487 > >> > >> > commons-compress-1.22-src.zip=fa8fec592d255f5ef23ce27491db9523222ed90113e7efd02fd9cc126d5e2df3d9caa578d049df0cca1f299e54d416295002b7f9c24e87b4b77b5c54658013bb > >> > >> > commons-compress-1.22-test-sources.jar=703e5a7b203505f42e69257952640594a1d0fdc14311e8028728d9bc5c27e65554767b6ea0583cc23e91a400ea595210890773395cfb807afbf3468604bf38ce > >> > >> > commons-compress-1.22-tests.jar=771d1ad4757e65993d75c629f206eecb7e99765eb01e4da621a405cc068e5cade8332f57fb3d19d5cb273aec54e1ea85c24a3053c0cb61c386ec2f64770b868f > >> > >> > >> > >> I have tested this with ***'mvn clean install site'*** using: > >> > >> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) > >> Maven home: /Users/matt/.sdkman/candidates/maven/current > >> Java version: 1.8.0_322, vendor: Azul Systems, Inc., runtime: > >> > /Users/matt/.sdkman/candidates/java/8.0.322-zulu/zulu-8.jdk/Contents/Home/jre > >> Default locale: en_US, platform encoding: UTF-8 > >> OS name: "mac os x", version: "12.6", arch: "aarch64", family: "mac" > >> Darwin matt1max.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 > >> 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64 > >> > >> Details of changes since 1.21 are in the release notes: > >> > >> > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/RELEASE-NOTES.txt > >> > >> > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/changes-report.html > >> > >> Site: > >> > >> > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/index.html > >>(note some *relative* links are broken and the 1.22 directories are > >> not yet created - these will be OK once the site is deployed.) > >> > >> *** JApiCmp Report (compared to 1.21): > >> > >> > https://dist.apache.org/repos/dist/dev/commons/compress/1.22-RC1/site/japicmp.html > >> > >>*** > >>Note that the above report notes several errors. > >>These are considered OK for the reasons stated below. > >>These exceptions are also noted in the Changes and Release Notes. > >> > >>Errors reported: > >>- removal of checked exceptions in various methods > >>*** > >> > >> RAT Report: > >> >
