Re: [COMPRESS] Pack200 support in pack200 branch

2020-11-02 Thread Peter Lee
> So we could do 1.21 as is followed by 1.22 with pack200 support.
>

+1

Lee
On 11, 1, 2020, at 11:59, Gary Gregory  wrote:
> It's been quite a while since this thread started so I will review my
> branch today but might wait for 1.22.
>
> While we indicated that we would address building and running pack200 in
> some way on Java 14+ for 1.21, an option is to release 1.21 as is since
> there are quite a few changes there already and we are updating to Java 8.
>
> So we could do 1.21 as is followed by 1.22 with pack200 support.
> One step at time.
> Gary
> On Sun, Aug 30, 2020, 18:58 Gary Gregory  wrote:
> > Hi All,
> >
> > As the next step in the pack200 branch, I've renamed the package
> > org.apache.harmony to org.apache.commons.compress.harmony to more easily
> > track potential future changes. If this looks acceptable, it can be merged
> > and documented.
> >
> > The builds are green here
> > https://github.com/apache/commons-compress/actions/runs/231719106
> >
> > Gary
> >
> >
> > On Mon, Aug 24, 2020 at 11:14 AM Gary Gregory 
> > wrote:
> >
> >> Thanks Peter, I updated the branch and the build passes for me locally,
> >> the CI is building now here
> >> https://github.com/apache/commons-compress/actions/runs/19115
> >>
> >> Gary
> >>
> >>
> >> On Sun, Aug 23, 2020 at 11:40 PM Peter Lee  wrote:
> >>
> >>> After some debugging I found this at
> >>> org.apache.harmony.pack200.Archive#171 :
> >>>
> >>> if (classes.size() > 0 && files.size() > 0) {
> >>> segmentUnitList.add(new SegmentUnit(classes, files));
> >>> }
> >>> Seems the Pack200 implementation in harmony requires existing of both
> >>> classes AND files at the same time. The tests are passing if I modified a
> >>> little bit here :
> >>>
> >>> if (classes.size() > 0 || files.size() > 0)
> >>> Not sure if this is a problem, cause I'm not familiar with Pack200 and
> >>> Apache Harmony.
> >>>
> >>> Lee
> >>> On 8 23 2020, at 11:27 , Gary Gregory  wrote:
> >>> > Hi All,
> >>> >
> >>> > I created a branch called *pack200* which contains the Apache Harmony
> >>> > Pack200 code.
> >>> >
> >>> > If there are 2 failing unit test ATM if anyone wants to help out.
> >>> > Gary
> >>
> >>
>



[JEXL] Switching from Cobertura to Jacoco

2020-11-02 Thread Henri Biestro
A recent commit in the code line (no pr btw) broke JEXL site's generation 
ability since Cobertura does not support Java 8 lambda constructs. I've thus 
been trying to switch to Jacoco as the coverage tool.
I've removed the cobertura.profile, added the jacoco.profile in the conf dir, 
removed all Cobertura references from the pom.xml and ... nothing. The 'site' 
target does not produce any coverage report anymore. I've looked at other 
commons pom (vfs, collections, net), I've seen no explicit mention of Jacoco 
anywhere besides through the file. The only thing I get in the best case is the 
cryptic 'unable to read execution file'. 
Any hints to what I'm obviously overlooking ?
Thanks

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org