Re: [math] Proposal: logsumexp

[Ahmed Fasih]

Gilles, thanks for writing!, and sorry for the delay in responding.

> However, you should be aware that some of its functionality is in the
> process of being transferred to more focused components:
>   * Commons Numbers
>   * Commons RNG
>   * Commons Statistics
>   * Commons Geometry
> 
> In particular, a method such as you describe could perhaps have its
> place in the "commons-numbers-arrays" module of "Numbers".[1]

Thank you, this is very interesting! What is the plan for Commons Math—will it 
go away and all its functionality be split between these packages? Or will it 
coexist with these other packages? How will the overlap in functionality be 
handled?

I saw that the Commons Numbers package hasn't yet had a formal release. Do you 
know if the team has a timeline on releasing it?

I ask all these questions because I'm wondering what my next steps should be 
towards getting `logsumexp` into either Commons Math or Commons Numbers or both.

Any insight you have will be appreciated! Thanks,

Ahmed

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [math] Proposal: logsumexp

[Gilles]

Hello.

On Wed, 21 Nov 2018 09:54:58 -0500, Ahmed Fasih wrote:

Gilles, thanks for writing!, and sorry for the delay in responding.

However, you should be aware that some of its functionality is in 
the

process of being transferred to more focused components:
  * Commons Numbers
  * Commons RNG
  * Commons Statistics
  * Commons Geometry

In particular, a method such as you describe could perhaps have its
place in the "commons-numbers-arrays" module of "Numbers".[1]


Thank you, this is very interesting! What is the plan for Commons
Math—will it go away and all its functionality be split between these
packages?


It will depend on how much work contributors are willing to
put into the refactoring.  [Help is certainly needed even for
finalizing an initial round that actually started more than
3 years ago...]


Or will it coexist with these other packages? How will the
overlap in functionality be handled?


Ideally, there is no overlap:  Whatever exists in the new
components has been deleted (or will be) from Commons Math.
What will remain in the next release of Commons Math is either
 * truly high-level functionality (e.g. package "ode") or
 * some large chunks of code that require a lot of work to be
   worth moving into its own component (e.g. package "linear") or
 * widely useful functionality that lack a "porting team" (e.g.
   package "stat")

[Mostly these categories overlap, making CM a nightmare to
maintain.  Hence the only way forward being new components
with more focused scopes.]


I saw that the Commons Numbers package hasn't yet had a formal
release. Do you know if the team has a timeline on releasing it?


Realistically, no.
A lot of work has already gone into it, but we lack contributors
to review and fix the new found issues.
I was contemplating making a release of a selected set of components
but even so, review is needed to make the choice on a sound basis.


I ask all these questions because I'm wondering what my next steps


Want to join the "team"? :-)


should be towards getting `logsumexp`
into either Commons Math


Since the last release, only bug fixes go into Commons Math.


or
Commons Numbers


Would be a good fit for the "commons-numbers-arrays" module.
What remains to be seen is whether some minimal "framework"
can be designed in order to make such functionality easy to
use with newer JDKs (functional interface, streams, ...).


or both.


:-/

Regards,
Gilles



Any insight you have will be appreciated! Thanks,

Ahmed



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rng pull request #15: RNG-62: Added a CombinationSampler

[aherbert]

GitHub user aherbert opened a pull request:

https://github.com/apache/commons-rng/pull/15

RNG-62: Added a CombinationSampler

Complements the PermutationSampler as the sample order is C(n, k) rather
than P(n, k). Can be used for faster subset sampling if the subset order
is not important.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aherbert/commons-rng feature-RNG-62

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rng/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 974b86453c986b2564afe8f1b58d5dec820e574a
Author: Alex Herbert 
Date:   2018-11-21T15:15:28Z

RNG-62: Added a CombinationSampler

Complements the PermutationSampler as the sample order is C(n, k) rather
than P(n, k). Can be used for faster subset sampling if the subset order
is not important.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rng issue #15: RNG-62: Added a CombinationSampler

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-rng/pull/15
  

[![Coverage 
Status](https://coveralls.io/builds/20226871/badge)](https://coveralls.io/builds/20226871)

Coverage increased (+0.04%) to 97.391% when pulling 
**974b86453c986b2564afe8f1b58d5dec820e574a on aherbert:feature-RNG-62** into 
**bb8a75ae4a3e77d2af5d05f2d1ec3f864d4610c0 on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [IO] Provenance of copied code in InfiniteCircularInputStream

[Mark Struberg]

+1. This is so trivial that it doesn't pass the threshold of originality.

LieGrue,
strub

> Am 19.11.2018 um 18:15 schrieb Mark Thomas :
> 
> I'd image the comment is referring to the use of "... & 0xFF" but it
> seems to be a fairly pointless comment as that is just the standard way
> to switch from signed byte to 'unsigned' int values.
> 
> I can't see what else it could possibly be referring to.
> 
> I don't see any IP issue here.
> 
> I'd suggest simply removing the comment but with a fairly verbose commit
> message to help anyone looking into this in the future.
> 
> Mark
> 
> 
> On 19/11/2018 16:57, Pascal Schumacher wrote:
>> Hi everybody,
>> 
>> the code is from a pull request which I merged:
>> 
>> https://github.com/apache/commons-io/pull/8
>> 
>> I did not author the code.
>> 
>> The comment seems incorrect because I do not think there is a field
>> "repeatedContent" in java.io.ByteArrayInputStream. The current OpenJDK
>> implementation looks pretty different:
>> 
>> http://hg.openjdk.java.net/jdk/jdk/file/49e0f711bb2b/src/java.base/share/classes/java/io/ByteArrayInputStream.java#l146
>> 
>> 
>> -Pascal
>> 
>> Am 19.11.2018 um 16:59 schrieb Gary Gregory:
>>> Hi All and Pascal S.,
>>> 
>>> Sharon (Eclipse) has pointed out to me that
>>> in org.apache.commons.io.input.InfiniteCircularInputStream.read() [1],
>>> we have:
>>> 
>>> @Override
>>> public int read() {
>>> position = (position + 1) % repeatedContent.length;
>>> return repeatedContent[position] & 0xff; // copied from
>>>  // java.io.ByteArrayInputStream.read()
>>> }
>>> 
>>> Where does the code originate? Oracle JRE? OpenJDK? Where? Such a
>>> comment needs to show better provenance since I am pretty sure we are
>>> NOT allowed to copy code from Oracle.
>>> 
>>> The code was added with the commit
>>> 
>>> https://github.com/apache/commons-io/commit/699d6f0eca65837501d7ab7a92ae2c614f8e6cbf#diff-5cdd5f292c77ae5feee8f3f101ded473
>>> 
>>> 
>>> With this authorship:
>>> 
>>> @piotrturski @PascalSchumacher
>>> 
>>> piotrturski
>>>  authored
>>> and PascalSchumacher
>>>  
>>> committed
>>> on Dec 1, 2015
>>> 
>>> Gary
>>> 
>>> [1]
>>> https://github.com/apache/commons-io/blob/3ad22fe3d689781a76a92908d0bbc119b2c68892/src/main/java/org/apache/commons/io/input/InfiniteCircularInputStream.java#L48-L49
>>> 
>>> 
>> 
>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[Lang]

[Aleksander Ściborek]

Hi
I've just created pull request
 for CheeckedFunction
interface. This is an example of utils I would like to add in order to
simplify usage of java Stream.
Aleksander