Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

2018-08-27 Thread Benedikt Ritter 
Hi,

- sigs and hashes are good
- builds fine with maven 3.5.4 from src distribution
- website looks good
- release notes look good
- there are some differences between the src distribution and release tag:

~/w/a/r/r/t/jcs git:(upstream ⚡ master) > diff -r commons-jcs-2.2.1-RC4/
commons-jcs-2.2.1-src
Only in commons-jcs-2.2.1-RC4/: .gitignore
Only in commons-jcs-2.2.1-RC4/: .svn
Only in commons-jcs-2.2.1-RC4/: .travis.yml
Only in commons-jcs-2.2.1-src: LICENSE
Only in commons-jcs-2.2.1-RC4/: LICENSE.txt
Only in commons-jcs-2.2.1-src: NOTICE
Only in commons-jcs-2.2.1-RC4/: NOTICE.txt
Only in commons-jcs-2.2.1-RC4/: auxiliary-builds
Only in commons-jcs-2.2.1-RC4/: checkstyle.xml
Only in commons-jcs-2.2.1-RC4/: commons-jcs-sandbox
Only in commons-jcs-2.2.1-RC4/: init-git-svn.sh
Only in commons-jcs-2.2.1-RC4/: jcache-fast.sh
Only in commons-jcs-2.2.1-RC4/: maven-eclipse-codestyle.xml

This should be fixed for the next release.

+1

Regards,
Benedikt

Am Do., 23. Aug. 2018 um 17:32 Uhr schrieb Thomas Vandahl :

> I would like to make another attempt to release Apache Commons JCS 2.2.1
> (a bugfix release)
>
> Apache Commons JCS 2.2.1 RC4 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 28918)
>
> The SVN tag commons-jcs-2.2.1-RC4 commit for this RC4 is here:
>
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2.1-RC4
> (r1838700
> 
> )
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1373
>
> I have built and tested this using:
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T20:33:14+02:00)
> Maven home: /Users/thomas/Dev/apache-maven-3.5.4
> Java version: 1.8.0_144, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
>
> Details of changes since 2.2 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/RELEASE-NOTES.txt
>
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/changes-report.html
>
> Site:
> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/
>
> CLIRR Report (compared to 2.2):
>
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/clirr-report.html
>
> RAT Report:
>
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Bye, Thomas.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

2018-08-27 Thread sebb 
On 27 August 2018 at 17:12, Benedikt Ritter  wrote:
> Hi,
>
> - sigs and hashes are good
> - builds fine with maven 3.5.4 from src distribution
> - website looks good
> - release notes look good
> - there are some differences between the src distribution and release tag:
>
> ~/w/a/r/r/t/jcs git:(upstream ⚡ master) > diff -r commons-jcs-2.2.1-RC4/
> commons-jcs-2.2.1-src
> Only in commons-jcs-2.2.1-RC4/: .gitignore
> Only in commons-jcs-2.2.1-RC4/: .svn

I don't think that can be fixed.

> Only in commons-jcs-2.2.1-RC4/: .travis.yml
> Only in commons-jcs-2.2.1-src: LICENSE
> Only in commons-jcs-2.2.1-RC4/: LICENSE.txt
> Only in commons-jcs-2.2.1-src: NOTICE
> Only in commons-jcs-2.2.1-RC4/: NOTICE.txt
> Only in commons-jcs-2.2.1-RC4/: auxiliary-builds
> Only in commons-jcs-2.2.1-RC4/: checkstyle.xml
> Only in commons-jcs-2.2.1-RC4/: commons-jcs-sandbox
> Only in commons-jcs-2.2.1-RC4/: init-git-svn.sh
> Only in commons-jcs-2.2.1-RC4/: jcache-fast.sh
> Only in commons-jcs-2.2.1-RC4/: maven-eclipse-codestyle.xml
>
> This should be fixed for the next release.

I agree the rest should be fixed.

> +1
>
> Regards,
> Benedikt
>
> Am Do., 23. Aug. 2018 um 17:32 Uhr schrieb Thomas Vandahl :
>
>> I would like to make another attempt to release Apache Commons JCS 2.2.1
>> (a bugfix release)
>>
>> Apache Commons JCS 2.2.1 RC4 is available for review here:
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 28918)
>>
>> The SVN tag commons-jcs-2.2.1-RC4 commit for this RC4 is here:
>>
>>
>> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2.1-RC4
>> (r1838700
>> 
>> )
>>
>> Maven artifacts are here:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1373
>>
>> I have built and tested this using:
>>
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> 2018-06-17T20:33:14+02:00)
>> Maven home: /Users/thomas/Dev/apache-maven-3.5.4
>> Java version: 1.8.0_144, vendor: Oracle Corporation, runtime:
>> /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre
>> Default locale: de_DE, platform encoding: UTF-8
>> OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
>>
>> Details of changes since 2.2 are in the release notes:
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/RELEASE-NOTES.txt
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/changes-report.html
>>
>> Site:
>> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/
>>
>> CLIRR Report (compared to 2.2):
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/clirr-report.html
>>
>> RAT Report:
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/rat-report.html
>>
>> KEYS:
>> https://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>> Bye, Thomas.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-27 Thread Pascal Schumacher 

At least RAT and clirr/japicmp should be part of default goal.

I'm personally prefer checkstyle and findbugs/spotbugs (although I 
prefer error-prone nowadays) to be part of the default goal.


On Java 8+ it is also helpful to make javadoc part of the default goal.

I think it is very convenient to be able to execute everything with 
"mvn" before committing and have the build fail if there are any 
violations. It is also helpful for pull request, because travis can run 
the default goal too.


By the way: lang and text already have all these as default goal and io 
is just missing findbugs.


Cheers,
Pascal

Am 20.08.2018 um 21:06 schrieb Gary Gregory:

The RAT check should be turned on by default IMO.

Gary

On Mon, Aug 20, 2018 at 12:45 AM Benedikt Ritter  wrote:


Hi,

one thing I always have to do when preparing a release is to fix all the
checkstyle and findbugs errors. This step could be eliminated if we added
checkstyle:check and findbugs:check to the maven default goal. This way it
would be executed on CI builds and we would see failing checkstyle/findbugs
right away.

WDYT?
Benedikt




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-27 Thread Rob Tompkins 



> On Aug 27, 2018, at 2:33 PM, Pascal Schumacher  
> wrote:
> 
> At least RAT and clirr/japicmp should be part of default goal.
> 
> I'm personally prefer checkstyle and findbugs/spotbugs (although I prefer 
> error-prone nowadays) to be part of the default goal.
> 
> On Java 8+ it is also helpful to make javadoc part of the default goal.
> 
> I think it is very convenient to be able to execute everything with "mvn" 
> before committing and have the build fail if there are any violations. It is 
> also helpful for pull request, because travis can run the default goal too.
> 
> By the way: lang and text already have all these as default goal and io is 
> just missing findbugs.
> 
> Cheers,
> Pascal

I’m a +1 to this idea. 

-Rob

> 
>> Am 20.08.2018 um 21:06 schrieb Gary Gregory:
>> The RAT check should be turned on by default IMO.
>> 
>> Gary
>> 
>>> On Mon, Aug 20, 2018 at 12:45 AM Benedikt Ritter  wrote:
>>> 
>>> Hi,
>>> 
>>> one thing I always have to do when preparing a release is to fix all the
>>> checkstyle and findbugs errors. This step could be eliminated if we added
>>> checkstyle:check and findbugs:check to the maven default goal. This way it
>>> would be executed on CI builds and we would see failing checkstyle/findbugs
>>> right away.
>>> 
>>> WDYT?
>>> Benedikt
>>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org