Re: [codec] Releasing 1.11 and the binary "cli" jar

[Benedikt Ritter]

Hi,

> Am 12.10.2017 um 23:42 schrieb Gary Gregory :
> 
> Hi all,
> 
> I starting preparing RC1 to release 1.11 and I see a "cli" jar being
> generated as documented in the POM:
> 
>  
> 
> But the cli jar _is_ deployed when I run 'mvn clean deploy -Prelease':
> 
> [INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @
> commons-codec ---
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar
> (333 kB at 79 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom
> (19 kB at 11 kB/s)
> Downloading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/maven-metadata.xml
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/maven-metadata.xml
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/maven-metadata.xml
> (304 B at 204 B/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar
> (473 kB at 111 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-sources.jar
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-sources.jar
> (341 kB at 81 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-test-sources.jar
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-test-sources.jar
> (193 kB at 63 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-tests.jar
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-tests.jar
> (283 kB at 78 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-cli.jar
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-cli.jar
> (18 kB at 3.8 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.tar.gz
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.tar.gz
> (1.7 MB at 176 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.zip
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.zip
> (2.0 MB at 127 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.tar.gz
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.tar.gz
> (370 kB at 93 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.zip
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.zip
> (611 kB at 126 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar.asc
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar.asc
> (499 B at 1.0 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom.asc
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom.asc
> (499 B at 1.0 kB/s)
> Uploading:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar.asc
> Uploaded:
> https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/c

Re: [codec] Releasing 1.11 and the binary "cli" jar

[Pascal Schumacher]

Am 13.10.2017 um 13:28 schrieb Benedikt Ritter:

Hi,


Am 12.10.2017 um 23:42 schrieb Gary Gregory :

Hi all,

I starting preparing RC1 to release 1.11 and I see a "cli" jar being
generated as documented in the POM:

  

But the cli jar _is_ deployed when I run 'mvn clean deploy -Prelease':

[INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @
commons-codec ---
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar
(333 kB at 79 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom
(19 kB at 11 kB/s)
Downloading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/maven-metadata.xml
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/maven-metadata.xml
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/maven-metadata.xml
(304 B at 204 B/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar
(473 kB at 111 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-sources.jar
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-sources.jar
(341 kB at 81 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-test-sources.jar
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-test-sources.jar
(193 kB at 63 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-tests.jar
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-tests.jar
(283 kB at 78 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-cli.jar
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-cli.jar
(18 kB at 3.8 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.tar.gz
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.tar.gz
(1.7 MB at 176 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.zip
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.zip
(2.0 MB at 127 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.tar.gz
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.tar.gz
(370 kB at 93 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.zip
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.zip
(611 kB at 126 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar.asc
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar.asc
(499 B at 1.0 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom.asc
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom.asc
(499 B at 1.0 kB/s)
Uploading:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar.asc
Uploaded:
https://repository.apache.org/service/local/staging/deploy/maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar.asc
(499 B at 1.0 kB/s)
Uploading:
https://repository.apache.org/service/loca

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

[vamsi-kavuri]

Github user vamsi-kavuri commented on the issue:

https://github.com/apache/commons-collections/pull/29
  
@PascalSchumacher Thanks for the feedback. I haven't thought of german 
locale. good catch. I will update it in a different PR.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCEMENT] Commons Configuration 2.2 Released

[Oliver Heger]

The Apache Commons Team is pleased to announce the availability of
Apache Commons Configuration 2.2.

The Apache Commons Configuration software library provides a generic
configuration interface which enables an application to read
configuration data from a variety of sources.

Version 2.2 is another maintenance release for the Configuration 2.x
series. It contains a number of bug fixes and also some new features.
Among the highlights is the new support for JSON and YAML
configurations. The release is fully source and binary compatible with
version 2.1.1.

A full list of all changes can be found in the release notes at
  http://www.apache.org/dist/commons/configuration/RELEASE-NOTES.txt

A user's guide describing all the features of Configuration 2.x can be
found at
  http://commons.apache.org/configuration/userguide/user_guide.html

Source and binary distributions are available for download from the
Apache Commons download site:

http://commons.apache.org/proper/commons-configuration/download_configuration.cgi

Please verify signatures using the KEYS file available at the above
location when downloading the release.

For complete information on Commons Configuration, including
instructions on how to submit bug reports, patches, or suggestions for
improvement, see the Apache Commons Configuration website:

http://commons.apache.org/proper/commons-configuration/

Oliver Heger, on behalf of the Apache Commons community

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-collections/pull/29
  
Thanks! Looking forward to the pull request!


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-io pull request #42: [IO-546] ClosedOutputStream#flush should throw

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-io/pull/42


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-io pull request #46: IO-507: Rename ByteOrderUtils class to ByteOrde...

[britter]

GitHub user britter opened a pull request:

https://github.com/apache/commons-io/pull/46

IO-507: Rename ByteOrderUtils class to ByteOrderParser and remove some

logic for parsing strings "big" and "little", after discussions on the
ML.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/britter/commons-io IO-507

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-io/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #46


commit 7532f2c5ee58581dc6d18ab13bc0c432c6d49c96
Author: Benedikt Ritter 
Date:   2017-10-13T17:19:26Z

IO-507: Rename ByteOrderUtils class to ByteOrderParser and remove some
logic for parsing strings "big" and "little", after discussions on the
ML.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-bcel pull request #16: BCEL-296: correct empty constructor comments

[markro49]

GitHub user markro49 opened a pull request:

https://github.com/apache/commons-bcel/pull/16

BCEL-296: correct empty constructor comments



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markro49/commons-bcel bcel296

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-bcel/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit d06e3fee133eef460289455a3a82f9c3ec525306
Author: Mark Roberts 
Date:   2017-10-13T17:30:02Z

correct empty constructor comments




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [codec] Releasing 1.11 and the binary "cli" jar

[Gary Gregory]

What I am saying is that this jar should not even exist. The main jar is
only ~300 KB, do we really need another jar to save a few bytes, I think
not.

Unless I hear otherwise, I plan on removing this extra jar. Turning [codec]
into a multi-module project is not worth it (IMO again).

Thoughts?

Gary

On Fri, Oct 13, 2017 at 5:28 AM, Benedikt Ritter  wrote:

> Hi,
>
> > Am 12.10.2017 um 23:42 schrieb Gary Gregory :
> >
> > Hi all,
> >
> > I starting preparing RC1 to release 1.11 and I see a "cli" jar being
> > generated as documented in the POM:
> >
> >  
> >
> > But the cli jar _is_ deployed when I run 'mvn clean deploy -Prelease':
> >
> > [INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @
> > commons-codec ---
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar
> > (333 kB at 79 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.pom
> > (19 kB at 11 kB/s)
> > Downloading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/maven-metadata.xml
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/maven-metadata.xml
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/maven-metadata.xml
> > (304 B at 204 B/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-javadoc.jar
> > (473 kB at 111 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-sources.jar
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-sources.jar
> > (341 kB at 81 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-
> test-sources.jar
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-
> test-sources.jar
> > (193 kB at 63 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-tests.jar
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-tests.jar
> > (283 kB at 78 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-cli.jar
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-cli.jar
> > (18 kB at 3.8 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.tar.gz
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.tar.gz
> > (1.7 MB at 176 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.zip
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-bin.zip
> > (2.0 MB at 127 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.tar.gz
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.tar.gz
> > (370 kB at 93 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.zip
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11-src.zip
> > (611 kB at 126 kB/s)
> > Uploading:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-codec/1.11/commons-codec-1.11.jar.asc
> > Uploaded:
> > https://repository.apache.org/service/local/staging/deploy/
> maven2/commons-codec/commons-cod

[GitHub] commons-bcel pull request #17: BCEL-295 fix local variable live range length...

[markro49]

GitHub user markro49 opened a pull request:

https://github.com/apache/commons-bcel/pull/17

BCEL-295 fix local variable live range length; add test case



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markro49/commons-bcel bcel295

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-bcel/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit 9bda4c39979c184c4aa73bf99c93387f30d1
Author: Mark Roberts 
Date:   2017-10-13T20:06:11Z

fix local variable live range length; add test case




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [codec] Releasing 1.11 and the binary "cli" jar

[Pascal Schumacher]

Am 13.10.2017 um 21:27 schrieb Gary Gregory:

What I am saying is that this jar should not even exist. The main jar is
only ~300 KB, do we really need another jar to save a few bytes, I think
not.
What exactly is in the cli jar? Looks like there is just a single small 
cli class 
https://github.com/apache/commons-codec/blob/b5c399eb3cb65fb6591865e1ee346e197b0882b8/src/main/java/org/apache/commons/codec/cli/Digest.java


That sure is not worth the effort of a multi-module build. Imho this can 
be part of the jar (not sure if is actually very useful and should be 
shipped at all).



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [codec] Releasing 1.11 and the binary "cli" jar

[Gary Gregory]

There is more than one class IIRC, still not worth it IMO.

Gary

On Oct 13, 2017 15:09, "Pascal Schumacher"  wrote:

> Am 13.10.2017 um 21:27 schrieb Gary Gregory:
>
>> What I am saying is that this jar should not even exist. The main jar is
>> only ~300 KB, do we really need another jar to save a few bytes, I think
>> not.
>>
> What exactly is in the cli jar? Looks like there is just a single small
> cli class https://github.com/apache/commons-codec/blob/b5c399eb3cb65fb
> 6591865e1ee346e197b0882b8/src/main/java/org/apache/commons/
> codec/cli/Digest.java
>
> That sure is not worth the effort of a multi-module build. Imho this can
> be part of the jar (not sure if is actually very useful and should be
> shipped at all).
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[GitHub] commons-io pull request #47: Add an IfStatement to check the return value of...

[BruceKuiLiu]

GitHub user BruceKuiLiu opened a pull request:

https://github.com/apache/commons-io/pull/47

Add an IfStatement to check the return value of lockFile.delete().

This statement returns a value that is not checked.
The return value should be checked since it can indicate an unusual or 
unexpected function execution.
The statement returns false if the destination file could not be 
successfully deleted (rather than throwing an Exception).
If you don't check the result, you won't notice if the statement signals an 
unexpected behavior by returning an atypical return value.

http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BruceKuiLiu/commons-io master2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-io/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #47


commit 83c39ae5001e579af89d34dc8dc9d72b302f453d
Author: Kui LIU 
Date:   2017-10-13T23:06:19Z

Add an IfStatement to check the return value of lockFile.delete().

This statement returns a value that is not checked.
The return value should be checked since it can indicate an unusual or 
unexpected function execution.
The statement returns false if the destination file could not be 
successfully deleted (rather than throwing an Exception).
If you don't check the result, you won't notice if the statement signals an 
unexpected behavior by returning an atypical return value.

http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [jcs] No access to assign an issue in JIRA (JCS-184)

[Gary Gregory]

Well, crud, when I look at the list of JIRA projects I can administer, I do
not see Commons JCS.

Anyone else?

Gary

On Thu, Oct 12, 2017 at 1:21 AM, Bruno P. Kinoshita <
brunodepau...@yahoo.com.br.invalid> wrote:

> Hi,
>
> I was working on JCS-184, a low hanging fruit in JCS. After writing the
> patch to fix it, and adding the changes.xml entry, I was going to check the
> Fix Version and assign the issue in JIRA, but then realised I had no access
> to alter the ticket.
>
> Tried JCS-183 and other issues in JCS, and also could not alter it. Does
> anyone know if there is anything special about JCS? Do I need to ask
> someone in Infra to get karma for JCS, or was I not supposed to touch it?
>
> COLLECTIONS, VALIDATOR, TEXT, LANG, IO, etc, all seem to be working fine
> for me. Just the JCS is not.
>
> Cheers
> Bruno
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [COLLECTIONS] Test failures on Windows

[Gary Gregory]

OK, I should have that fixed up in the tests. Please give it a go.

Gary

On Thu, Oct 12, 2017 at 2:23 AM, Pascal Schumacher  wrote:

> With current master on windows 10 (java 7, 8, 9; german locale) the
> occasional failures have been replace by constant failures:
>
> Failed tests:
>   MapUtilsTest.testgetDoubleValue:956 expected:<20.0> but was:<2.0>
>   MapUtilsTest.testgetFloatValue:974 expected:<20.0> but was:<2.0>
>
> These are new tests added in https://github.com/apache/comm
> ons-collections/pull/29
>
> Looks like these tests fail when run on a locale that does not use the
> point character as a decimal separator.
>
>
> Am 12.10.2017 um 08:30 schrieb Bruno P. Kinoshita:
>
>> It was merged in https://github.com/apache/c
>> ommons-collections/commit/eed8a7adb3de7441751e846f4a75d110dd205f23.
>> I closed the pull request.
>> Thanks to all that helped testing & troubleshooting this interesting
>> issue!
>> I believe Commons Collections should now be in a state ready for a
>> release.
>> CheersBruno
>>From: Benedikt Ritter 
>>   To: Commons Developers List 
>>   Sent: Thursday, 12 October 2017 7:23 PM
>>   Subject: Re: [COLLECTIONS] Test failures on Windows
>> Awesome, let’s merge this!
>>
>> Am 11.10.2017 um 13:06 schrieb Andreas Kuhtz :
>>>
>>> Hi,
>>>
>>> Tested with the changes of your PR multiple times with Win7-64bit and
>>> JDK7
>>> and JDK8 without any issues.
>>>
>>> Cheers
>>> Andreas
>>>
>>>
>>>
>>> 2017-10-11 10:03 GMT+02:00 Bruno P. Kinoshita <
>>> brunodepau...@yahoo.com.br.invalid>:
>>>
>>> Done.
 https://github.com/apache/commons-collections/pull/28

 Tested on Windows 10 + JDK8, and Ubuntu LTS + JDK8.
 Would be good if someone else with a Windows version could try it too,
 and
 if others could have a look at the suggested solution in the pull
 request
 to see if there's a better way of doing it.
 CheersBruno
From: Bruno P. Kinoshita 
 To: Commons Developers List 
 Sent: Wednesday, 11 October 2017 12:43 PM
 Subject: Re: [COLLECTIONS] Test failures on Windows

 Still investigating. Trying to isolate the problem
 https://github.com/kinow/commons-collections/tree/COLLECTIONS-661-1

 No luck so far. I have an environment where it happens over 90% of the
 time. Tried debugging a few times, adding some sysout statements to see
 if
 there was anything suspect... yesterday enabled findbugs in test to look
 for any issue in the test classes. Nothing yet.

 Bruno

From: Gary Gregory 
 To: Commons Developers List 
 Sent: Wednesday, 11 October 2017 12:13 PM
 Subject: Re: [COLLECTIONS] Test failures on Windows

 Where are we on this one?

 Gary

 On Mon, Oct 2, 2017 at 3:34 AM, Pascal Schumacher <
 pascalschumac...@gmx.net>
 wrote:

 Looks like the random failures are not limited to window. The travis
>
 build

> (ubuntu), just failed with 44 failures, e.g.
>
> AbstractMultiValuedMapTest$TestMultiValuedMapAsMap>AbstractM
> apTest.testMapToString:745->AbstractMapTest.verify:1947->
>
 AbstractMapTest.verifyMap:1958

> hashCodes should be the same expected:<205172737> but was:<9372706>
>
>
> see: https://travis-ci.org/apache/commons-collections/jobs/282169803
>
>
> Am 28.09.2017 um 20:23 schrieb Andreas Kuhtz:
>
> Hi,
>>
>> 2017-09-27 22:28 GMT+02:00 Bruno P. Kinoshita :
>>
>> Forgot to mention something important. When I was debugging the hash
>>
>>> tests, they would pretty much always pass.
>>>
>>> But if I ran the tests normally in maven or eclipse they would always
>>> fail.
>>>
>>> Debugging adds a small overhead I think, that could be slowing down
>>>
>> some

> part of the code with a concurrency issue?
>>>
>>> That's an explanation. If I start a Virtualbox instance that prepares
>>>
>> some
>> load I can see the tests pass under Java 9 ... I had the Virtualbox
>> running
>> yesterday when the tests passed.
>>
>>
>> Just in case it helps...
>>
>>> Interesting this surefire configuration Andreas. Do you have more
>>> information about it? Is it something we may have to worry about in
>>> components that use locale and jvm 9?
>>>
>>> I ran into an issue with the language selection dialog of izpack and
>>>
>> found
>> that this configuration solved the problem there.
>> It's noted in the release notes of Java 9:
>> http://www.oracle.com/technetwork/java/javase/9-relnote-
>> issues-3704069.html#JDK-8008577
>>
>> Cheers,
>> Andreas
>>
>>
>> Cheers
>>
>>> Bruno
>>>
>>> Sent from Yahoo Mail on Android
>>> 
>>>
>>> On Thu, 28 Sep 2017 at 4:45, Andreas Kuhtz
>>>  wrote:
>>> Hi,
>>>
>>>

[GitHub] commons-collections pull request #31: Update test cases

[vamsi-kavuri]

GitHub user vamsi-kavuri opened a pull request:

https://github.com/apache/commons-collections/pull/31

Update test cases

Update test cases and correct locale issue mentioned in #29 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vamsi-kavuri/commons-collections unit-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-collections/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit cad0ca273ba667e701bcd358d7843a9237002a3c
Author: Kavuri, Vamsi 
Date:   2017-10-14T02:44:54Z

correct locale issue

commit d4137820b1116c98659d643f7cf45255abeded21
Author: Kavuri, Vamsi 
Date:   2017-10-14T02:53:27Z

update

commit 38f60c2542866b980c2b5ea19025d24c9253960f
Author: Kavuri, Vamsi 
Date:   2017-10-14T02:57:11Z

update




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #31: Update test cases

[vamsi-kavuri]

Github user vamsi-kavuri closed the pull request at:

https://github.com/apache/commons-collections/pull/31


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #31: Update test cases

[vamsi-kavuri]

Github user vamsi-kavuri closed the pull request at:

https://github.com/apache/commons-collections/pull/31


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

[vamsi-kavuri]

Github user vamsi-kavuri commented on the issue:

https://github.com/apache/commons-collections/pull/29
  
@PascalSchumacher I am late by an hour. Decimal separators are added by 
gregory

https://github.com/apache/commons-collections/commit/641aa1c663ebead0189bf001a06ee56463070ddb



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org