date:20170504

Re: [Math] Fails on Jenkins, succeeds on Travis

2017-05-04 Thread sebb

On 4 May 2017 at 00:48, Gilles  wrote:
> Same commit, different behaviour...

Travis and Jenkins check different things...

> https://travis-ci.org/apache/commons-math/
> https://builds.apache.org/job/Commons%20Math%20MasterBranch/34/console

 Exit code: 1 - javadoc: error - invalid flag: --allow-script-in-comments


> Regards,
> Gilles
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Math] Fails on Jenkins, succeeds on Travis

2017-05-04 Thread Gilles


On Thu, 4 May 2017 09:19:49 +0100, sebb wrote:

On 4 May 2017 at 00:48, Gilles  wrote:

Same commit, different behaviour...


Travis and Jenkins check different things...


https://travis-ci.org/apache/commons-math/

https://builds.apache.org/job/Commons%20Math%20MasterBranch/34/console


 Exit code: 1 - javadoc: error - invalid flag: 
--allow-script-in-comments


I knew that it was caused by my adding this flag in the POM file.
Without this flag, the build fails with Java 8; with the flag, it
fails with Java 7.




Regards,
Gilles





-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Math] Fails on Jenkins, succeeds on Travis

2017-05-04 Thread sebb

On 4 May 2017 at 09:57, Gilles  wrote:
> On Thu, 4 May 2017 09:19:49 +0100, sebb wrote:
>>
>> On 4 May 2017 at 00:48, Gilles  wrote:
>>>
>>> Same commit, different behaviour...
>>
>>
>> Travis and Jenkins check different things...
>>
>>> https://travis-ci.org/apache/commons-math/
>>>
>>> https://builds.apache.org/job/Commons%20Math%20MasterBranch/34/console
>>
>>
>>  Exit code: 1 - javadoc: error - invalid flag: --allow-script-in-comments
>
>
> I knew that it was caused by my adding this flag in the POM file.
> Without this flag, the build fails with Java 8; with the flag, it
> fails with Java 7.

If the flag is really necessary for Java 8 (i.e. the Javadoc cannot
readily be adjusted to avoid the problem) then obviously the flag
setting will need to depend on the Java version being used to compile
the code.

The Commons Parent pom has some examples of settings that are
conditional upon the Java version.

>
>>
>>> Regards,
>>> Gilles
>>>
>>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [all][osgi] how to deal with non-bundle dependencies?

2017-05-04 Thread Matt Sicker

Without a container, the "easy" way would be to embed Felix and start up
the OSGi framework itself. The easiest way to do this in unit tests would
be using something like Pax Exam <
https://ops4j1.jira.com/wiki/display/PAXEXAM4/Pax+Exam>.

On 4 May 2017 at 01:11, Stefan Bodewig  wrote:

> On 2017-05-02, Matt Sicker wrote:
>
> > Apache ServiceMix tends to repackage a lot of 3rd party libraries as
> > bundles, so that's one method. End users can use things like bnd to
> > generate a manifest for 3rd party jars (e.g., installing jars using the
> > "wrap:" URI in Apache Karaf), though that's kind of similar to
> automodules
> > in JPMS which isn't the best thing.
>
> In our case with org.brotli:dec at Compress the "automodules" approach
> would be good enough. The whole library has a single public class and no
> dependencies, the bundle definition would be trivial.
>
> We've now marked the dependency with "resolution:=optional" and hope
> this allows Compress to remain a valid bundle. Do you know whether there
> is an easy way to test whether a library would work as a bundle without
> actually trying to deploy an application using it into a container?
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
Matt Sicker

Re: [all][osgi] how to deal with non-bundle dependencies?

2017-05-04 Thread Bertrand Delacretaz

On Thu, May 4, 2017 at 4:11 PM, Matt Sicker  wrote:
> ...The easiest way to do this in unit tests would
> be using something like Pax Exam...

We're doing that a lot in Sling, see
https://svn.apache.org/repos/asf/sling/trunk/bundles/commons/org.apache.sling.commons.messaging.mail
for a simple example.

The trick is loading the bundle that you're building in the same Maven
module, in that example we use the bundle.filename system property for
that.

-Bertrand

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-compress pull request #22: COMPRESS-390: Expose stream offsets and s...

2017-05-04 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-compress/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #36: Test

2017-05-04 Thread Imdapro

GitHub user Imdapro opened a pull request:

https://github.com/apache/commons-rdf/pull/36

Test

A jacoco mÅ±kÃ¶dik.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Imdapro/commons-rdf test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rdf/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit cd052213432cdea872bc9c281903082ff4dc0798
Author: csaba.kothencz 
Date:   2017-04-19T12:46:29Z

made attribute transient

commit 93d2f8e5c3d0cc10be075474bd7cc6474a8ea40d
Author: csaba.kothencz 
Date:   2017-04-19T12:47:53Z

replaced double quotes to simples

commit 1b01abbb5b1bb06eb05190dbf22f0e10ce1f9b75
Author: csaba.kothencz 
Date:   2017-04-19T12:49:10Z

replaced Optional<> nullcheck to isPresent() check

commit d8d8d9b1db2aafc8d44562b63903a2d38aa1e9b2
Author: csaba.kothencz 
Date:   2017-04-19T12:50:20Z

replaced null return to Optional.empty()

commit 01ebc496dfefd0da29c299f1846922ae6fdcee05
Author: csaba.kothencz 
Date:   2017-04-19T12:56:18Z

removed unnecessary IllegalArgumentException declarations

commit 03193884e65f2c4c24a4fbdf2288ad6edb6b1bd7
Author: csaba.kothencz 
Date:   2017-04-19T12:57:52Z

replaced lambdas with method references

commit 868bd65853f3ca58aabeb13e3299b29d9611ba7c
Author: csaba.kothencz 
Date:   2017-04-19T12:59:15Z

moved variables to their right places

commit 9d89d249a868b72d9a91b8f5c5c72673ac44755e
Author: csaba.kothencz 
Date:   2017-04-19T13:05:04Z

corrected javadoc (deprecated)

commit cbba0db986cd9117346125c2a3c4d0e07b6de008
Author: csaba.kothencz 
Date:   2017-04-19T13:07:08Z

removed unnecessary IllegalArgumentException declaration

commit f5dd857c2bd4d0598d4304ca65ce8a91a2c5ecdd
Author: csaba.kothencz 
Date:   2017-04-19T13:11:57Z

removed close, overridden method without body

commit 7f095a5f348b0645984728840c6cb94ab9050c73
Author: csaba.kothencz 
Date:   2017-04-19T13:13:13Z

simplified condition

commit 2798c64ba19c531681f45361e708e15051c81eac
Author: csaba.kothencz 
Date:   2017-04-19T13:14:10Z

removed unnecessary UnsupportedOperationException declaration

commit d86af7db8ff8340e4495d5dd4250c94b18908e14
Author: csaba.kothencz 
Date:   2017-04-19T13:15:46Z

renamed field with right cases

commit 6011ee958af6d803e6d7645d707198e3bf863d68
Author: csaba.kothencz 
Date:   2017-04-19T13:20:03Z

removed deprecated RDF_PLAINLITERAL type

commit 1295b4c7240c9ed98faf66ccf20717108a6c3fc8
Author: csaba.kothencz 
Date:   2017-04-19T13:20:59Z

removed commented-out code

commit 27ba6e8838464fe6a6701608d9d835c9e7abc377
Author: csaba.kothencz 
Date:   2017-04-19T13:21:58Z

removed unnecessary TODO

commit c2ab58d0ffd98efc15f9faaf8e02d7b6574315c7
Author: csaba.kothencz 
Date:   2017-04-19T13:22:40Z

removed commented-out code #2

commit 7a9562e9dbb3884d7cb16e91d403d69d16380645
Author: csaba.kothencz 
Date:   2017-04-19T13:32:59Z

removed unnecessary IllegalStateException declaration

commit d2ca306ca6e4799eeac2fb4f73fe586b6a93abac
Author: kcsombi 
Date:   2017-04-19T19:11:55Z

Merge pull request #1 from Imdapro/sonarbranch

sonarbranch

commit 569cb5790c5eeae9f03a011166e4add4c4f6a1fb
Author: Imdapro 
Date:   2017-05-04T00:11:45Z

Branch kÃ©szÃtve a tesztekhez, illetve lefedettsÃ©g vizsgÃ¡lathoz.
A jacoco hozzÃ¡adva a projekthez.
A "mvn -Dmaven.javadoc.skip=true clean package" paranccsal futtassÃ¡tok, 
mivel a kÃ³d javadoc comment hibÃ¡kat tartalmaz.

commit a4351c28eb38b8997e209b5bd60500779dd02ce6
Author: Imdapro 
Date:   2017-05-04T02:47:03Z

Az API ban mÃ³dosÃtani kellett az AbstractDatasetTest-et, hogy ne legyenek 
hibÃ¡k/testfailure-k, hogy a simple kÃ¶nyvtÃ¡rat tudjuk tesztelni.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf issue #36: Test

2017-05-04 Thread Imdapro

Github user Imdapro commented on the issue:

https://github.com/apache/commons-rdf/pull/36
  
I've not meant to create it in this project. 
Delete this request pls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #36: Test

2017-05-04 Thread Imdapro

Github user Imdapro closed the pull request at:

https://github.com/apache/commons-rdf/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Math] Fails on Jenkins, succeeds on Travis

2017-05-04 Thread Gilles


On Thu, 4 May 2017 11:02:59 +0100, sebb wrote:

On 4 May 2017 at 09:57, Gilles  wrote:

On Thu, 4 May 2017 09:19:49 +0100, sebb wrote:


On 4 May 2017 at 00:48, Gilles  
wrote:


Same commit, different behaviour...



Travis and Jenkins check different things...


https://travis-ci.org/apache/commons-math/


https://builds.apache.org/job/Commons%20Math%20MasterBranch/34/console



 Exit code: 1 - javadoc: error - invalid flag: 
--allow-script-in-comments



I knew that it was caused by my adding this flag in the POM file.
Without this flag, the build fails with Java 8; with the flag, it
fails with Java 7.


If the flag is really necessary for Java 8 (i.e. the Javadoc cannot
readily be adjusted to avoid the problem) then obviously the flag
setting will need to depend on the Java version being used to compile
the code.

The Commons Parent pom has some examples of settings that are
conditional upon the Java version.


Finally, I configured Jenkins so that the job will skip the javadoc
generation. Good enough until Jenkins will *require* Java 8.

Regards,
Gilles








Regards,
Gilles








-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-compress pull request #24: COMPRESS-391: Allow alignment on zip cont...

2017-05-04 Thread kvr000

GitHub user kvr000 opened a pull request:

https://github.com/apache/commons-compress/pull/24

COMPRESS-391: Allow alignment on zip content



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kvr000/commons-compress 
feature/COMPRESS-391-allow-entries-alignment

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit e42d33b01848cd46c87739bf92c33a6c0f136f32
Author: Zbynek Vyskovsky 
Date:   2017-05-05T03:44:44Z

COMPRESS-391: Allow alignment on zip content




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content

2017-05-04 Thread coveralls

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/24
  

[![Coverage 
Status](https://coveralls.io/builds/11383081/badge)](https://coveralls.io/builds/11383081)

Coverage increased (+0.05%) to 84.279% when pulling 
**e42d33b01848cd46c87739bf92c33a6c0f136f32 on 
kvr000:feature/COMPRESS-391-allow-entries-alignment** into 
**092bcac5be680480860dbddae4217347b8b14fab on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: commons-compress git commit: [COMPRESS-392] Add Brotli decoder based on the Google Brotli library.

2017-05-04 Thread Stefan Bodewig

On 2017-05-04, Stefan Bodewig wrote:

> On 2017-05-03, Gary Gregory wrote:

>> Maybe a PR would help ;-)

> dec probably doesn't really use Maven to build even though there is a
> POM.

Turns out a patch to the POM has been good enough :-)

https://github.com/google/brotli/pull/545

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: commons-compress git commit: [COMPRESS-392] Add Brotli decoder based on the Google Brotli library.

2017-05-04 Thread Gary Gregory

On Thu, May 4, 2017 at 8:58 PM, Stefan Bodewig  wrote:

> On 2017-05-04, Stefan Bodewig wrote:
>
> > On 2017-05-03, Gary Gregory wrote:
>
> >> Maybe a PR would help ;-)
>
> > dec probably doesn't really use Maven to build even though there is a
> > POM.
>
> Turns out a patch to the POM has been good enough :-)
>

Nice :-)

Gary

>
> https://github.com/google/brotli/pull/545
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [Math] Fails on Jenkins, succeeds on Travis

Re: [Math] Fails on Jenkins, succeeds on Travis

Re: [Math] Fails on Jenkins, succeeds on Travis

Re: [all][osgi] how to deal with non-bundle dependencies?

Re: [all][osgi] how to deal with non-bundle dependencies?

[GitHub] commons-compress pull request #22: COMPRESS-390: Expose stream offsets and s...

[GitHub] commons-rdf pull request #36: Test

[GitHub] commons-rdf issue #36: Test

[GitHub] commons-rdf pull request #36: Test

Re: [Math] Fails on Jenkins, succeeds on Travis

[GitHub] commons-compress pull request #24: COMPRESS-391: Allow alignment on zip cont...

[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content

Re: commons-compress git commit: [COMPRESS-392] Add Brotli decoder based on the Google Brotli library.

Re: commons-compress git commit: [COMPRESS-392] Add Brotli decoder based on the Google Brotli library.

14 matches

Site Navigation

Mail list logo

Footer information