[GitHub] commons-compress pull request: Pkware headers

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-compress/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-compress pull request: Pkware headers

[bodewig]

Github user bodewig commented on the pull request:

https://github.com/apache/commons-compress/pull/5#issuecomment-164276454
  
Thanks

I've merged you patch have a few questions - and would like to see tests 
:-)  Not sure whether you'd prefer to discuss this here, inside a new PR or on 
the dev list.

I'm note sure why you've introduced the base class `PKWareExtraHeader`. It 
might be useful as a container but I don't see why the others inherit from it.

Second, don't you want to register the new classes `ExtraFieldUtils`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[COMPRESS] PKWare header questions

[Bear Giles]

1. I created the PKWareExtraHeader as a marker - it should make it clear
that the headers will only be present in PKWare-created files and everyone
else can ignore them. This is in contract to other headers that are much
more standard. It was an oversight if this got lost when I had to refork
the project.

2. ExtraFieldUtils and Tests - I'm not that familiar with the code since
I'm more focused on the crypto than the general functionality. The former
is an oversight. The latter is something that stumped me. During
development I had System.out statements that verified I was reading the
expected values but we obviously don't want to leave that in the final
code. Is there a way to read a file and then inspect all of the headers
within the test framework?

Bear

Re: [COMPRESS] PKWare header questions

[Stefan Bodewig]

On 2015-12-13, Bear Giles wrote:

> 1. I created the PKWareExtraHeader as a marker - it should make it clear
> that the headers will only be present in PKWare-created files and everyone
> else can ignore them.

OK, understood. I'll add a few sentences as javadocs.

> 2. ExtraFieldUtils and Tests - I'm not that familiar with the code since
> I'm more focused on the crypto than the general functionality. The former
> is an oversight.

OK, easily fixed ;-)

> The latter is something that stumped me. During development I had
> System.out statements that verified I was reading the expected values
> but we obviously don't want to leave that in the final code. Is there
> a way to read a file and then inspect all of the headers within the
> test framework?

I wouldn't call our tests a framework, they've somewhat grown into
existence. You may want to look at the existing extra field tests. Some
of then mainly parse byte[] and try to verify roudtrips work (if they
can be read and written). Some are accompanied by small ZIP archives
that get read.  X5455_ExtendedTimestampTest is an example that performs
both kinds of tests.

If you've got an archive to share that exhibits all the headers we now
can parse thanks to your code, then it should be straight forward to
assert their contents mich the same way
X5455_ExtendedTimestampTest#testSampleFile works.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Jenkins build is back to normal : Commons-Compress #35

[Apache Jenkins Server]

See 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org