date:20121012

[GUMP@vmgump]: Project commons-dbcp (in module commons-dbcp-1.x) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-dbcp has an issue affecting its community integration.
This issue affects 18 projects,
 and has been outstanding for 126 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbcp :  Object Pooling
- db-ddlutils :  Easy-to-use component for working with Database Definition 
(...
- jakarta-tomcat-4.0 :  Servlet 2.3 and JSP 1.2 Reference Implementation
- jakarta-tomcat-catalina :  Servlet 2.4 Reference Implementation
- jakarta-tomcat-dbcp :  Servlet 2.4 and JSP 2.0 Reference Implementation
- jakarta-tomcat-jk :  Connectors to various web servers
- javax.el :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...
- javax.servlet :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation 
(for ...
- javax.servlet.jsp :  Java Servlet 2.5 & Server Pages JSP 2.1 
implementation (for ...
- solr :  Java Based Search Engine
- solr-test :  Java Based Search Engine
- tomcat-tc6 :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...
- tomcat-tc7.0.x :  Tomcat 7.x, a web server implementing Java Servlet 3.0,
...
- tomcat-tc7.0.x-dbcp :  Tomcat 7.x, a web server implementing Java Servlet 
3.0,
...
- tomcat-tc7.0.x-test :  Tomcat 7.x, a web server implementing Java Servlet 
3.0,
...
- tomcat-trunk :  Tomcat 8.x, a web server implementing Java Servlet 3.1,
...
- tomcat-trunk-dbcp :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...
- tomcat-trunk-test :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/commons-dbcp-1.x/commons-dbcp/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-dbcp.jar] identifier set to project name
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/commons-dbcp-1.x/commons-dbcp/gump_work/build_commons-dbcp-1.x_commons-dbcp.html
Work Name: build_commons-dbcp-1.x_commons-dbcp (Type: Build)
Work ended in a state of : Failed
Elapsed: 9 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
dist 
[Working Directory: /srv/gump/public/workspace/commons-dbcp-1.x]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/junit/dist/junit-12102012.jar:/srv/gump/public/workspace/junit/dist/junit-dep-12102012.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar:/srv/gump/public/workspace/commons-pool-1.x/dist/commons-pool-1.6.1-SNAPSHOT.jar
-
[javac]^
[javac]   where T is a type-variable:
[javac] T extends Object declared in method 
getObject(String,Class)
[javac] 
/srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingConnection.java:65:
 error: DelegatingConnection is not abstract and does not override abstract 
method getNetworkTimeout() in Connection
[javac] public class DelegatingConnection extends AbandonedTrace
[javac]^
[javac] 
/srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java:38:
 error: DelegatingDatabaseMetaData is not abstract and does not override 
abstract method generatedKeyAlwaysReturned() in DatabaseMetaData
[javac] public class DelegatingDatabaseMetaData extends AbandonedTrace
[javac]^
[javac] 
/srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:61:
 error: DelegatingResultSet is not abstract and does not override abstract 
method getObject(String,Class) in ResultSet
[javac] public class DelegatingResultSet extends Aba

[GUMP@vmgump]: Project commons-dbcp2 (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-dbcp2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 126 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbcp2 :  Database Connection Pool


Full details are available at:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbcp2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-dbcp2-*[0-9T].jar] identifier set to project 
name
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbcp2/gump_work/build_apache-commons_commons-dbcp2.html
Work Name: build_apache-commons_commons-dbcp2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 10 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
dist 
[Working Directory: /srv/gump/public/workspace/apache-commons/dbcp]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/apache-commons/dbcp/dist/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar:/srv/gump/packages/jdbc2_0/jdbc2_0-stdext.jar:/srv/gump/public/workspace/junit/dist/junit-12102012.jar:/srv/gump/public/workspace/junit/dist/junit-dep-12102012.jar:/srv/gump/public/workspace/apache-commons/pool/dist/commons-pool2-2.0-SNAPSHOT.jar
-
[mkdir] Created dir: 
/srv/gump/public/workspace/apache-commons/dbcp/build/classes
[javac] Compiling 52 source files to 
/srv/gump/public/workspace/apache-commons/dbcp/build/classes
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/BasicDataSource.java:52:
 error: BasicDataSource is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource
[javac] public class BasicDataSource implements DataSource {
[javac]^
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingConnection.java:65:
 error: DelegatingConnection is not abstract and does not override abstract 
method getNetworkTimeout() in Connection
[javac] public class DelegatingConnection extends AbandonedTrace
[javac]^
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingStatement.java:46:
 error: DelegatingStatement is not abstract and does not override abstract 
method isCloseOnCompletion() in Statement
[javac] public class DelegatingStatement extends AbandonedTrace implements 
Statement {
[javac]^
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java:57:
 error: DelegatingPreparedStatement is not abstract and does not override 
abstract method isCloseOnCompletion() in Statement
[javac] public class DelegatingPreparedStatement extends DelegatingStatement
[javac]^
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java:58:
 error: DelegatingCallableStatement is not abstract and does not override 
abstract method getObject(String,Class) in CallableStatement
[javac] public class DelegatingCallableStatement extends 
DelegatingPreparedStatement
[javac]^
[javac]   where T is a type-variable:
[javac] T extends Object declared in method 
getObject(String,Class)
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingDatabaseMetaData.java:36:
 error: DelegatingDatabaseMetaData is not abstract and does not override 
abstract method generatedKeyAlwaysReturned() in DatabaseMetaData
[javac] public cla

[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-digester3 has an issue affecting its community integration.
This issue affects 2 projects,
 and has been outstanding for 131 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-digester3 :  XML to Java Object Configuration
- commons-digester3-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-digester3/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-digester3-*[0-9T].jar] identifier set to 
project name
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/digester/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/apache-commons/digester/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-digester3/gump_work/build_apache-commons_commons-digester3.html
Work Name: build_apache-commons_commons-digester3 (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 min 3 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/apache-commons/digester/gump_mvn_settings.xml 
package 
[Working Directory: /srv/gump/public/workspace/apache-commons/digester]
M2_HOME: /opt/maven2
-
[INFO] [remote-resources:process {execution: default}]
[INFO] [buildnumber:create {execution: default}]
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor && svn 
--non-interactive info
[INFO] Working directory: 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor
[INFO] Storing buildNumber: ?? at timestamp: 1350039112612
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor && svn 
--non-interactive info
[INFO] Working directory: 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor
[INFO] Storing buildScmBranch: UNKNOWN_BRANCH
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] Copying 2 resources to META-INF
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 5 source files to 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/target/classes
[INFO] [bundle:manifest {execution: bundle-manifest}]
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/src/test/resources
[INFO] Copying 0 resource to META-INF
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 3 source files to 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/target/test-classes
>@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern="rss/channel")
>@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern="rss/channel/image")
>@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern="rss/channel/item")
>
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
[ERROR] error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
[INFO] 2 errors 
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure

error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.

[GUMP@vmgump]: Project commons-chain2 (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-chain2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 148 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-chain2 :  GoF "Chain of Responsibility" pattern


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-chain2-*[0-9T].jar] identifier set to project 
name
 -DEBUG- Sole pom output [pom.xml] identifier set to project name
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/chain/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/chain/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/gump_work/build_apache-commons_commons-chain2.html
Work Name: build_apache-commons_commons-chain2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 min 1 sec
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/chain/gump_mvn_settings.xml package 
[Working Directory: /srv/gump/public/workspace/apache-commons/chain]
M2_HOME: /opt/maven2
-
[INFO] Building war: 
/srv/gump/public/workspace/apache-commons/chain/apps/cookbook-examples/target/chain-cookbook-examples-2.0-SNAPSHOT.war
[INFO] 
[INFO] Building Apache Commons Chain :: Distribution Packages
[INFO]task-segment: [package]
[INFO] 
[INFO] snapshot org.apache.commons:commons-chain2-configuration:2.0-SNAPSHOT: 
checking for updates from apache.snapshots
Downloading: 
http://localhost:8192/repo/m2-snapshot-repository/org/apache/commons/commons-chain2-configuration/2.0-SNAPSHOT/commons-chain2-configuration-2.0-SNAPSHOT.pom
[INFO] Unable to find resource 
'org.apache.commons:commons-chain2-configuration:pom:2.0-SNAPSHOT' in 
repository apache.snapshots (http://repository.apache.org/snapshots)
Downloading: 
http://localhost:8192/repo/m2-snapshot-repository/org/apache/commons/commons-chain2-configuration/2.0-SNAPSHOT/commons-chain2-configuration-2.0-SNAPSHOT.jar
[INFO] Unable to find resource 
'org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT' in 
repository apache.snapshots (http://repository.apache.org/snapshots)
[INFO] 
[ERROR] BUILD ERROR
[INFO] 
[INFO] Failed to resolve artifact.

Missing:
--
1) org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT

  Try downloading the file manually from the project website.

  Then, install it using the command: 
  mvn install:install-file -DgroupId=org.apache.commons 
-DartifactId=commons-chain2-configuration -Dversion=2.0-SNAPSHOT 
-Dpackaging=jar -Dfile=/path/to/file

  Alternatively, if you host your own repository you can deploy the file there: 
  mvn deploy:deploy-file -DgroupId=org.apache.commons 
-DartifactId=commons-chain2-configuration -Dversion=2.0-SNAPSHOT 
-Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]

  Path to dependency: 
1) org.apache.commons:commons-chain2:pom:2.0-SNAPSHOT
2) org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT

--
1 required artifact is missing.

for artifact: 
  org.apache.commons:commons-chain2:pom:2.0-SNAPSHOT

from the specified remote repositories:
  gump-central (http://localhost:8192/maven2),
  gump-apache.snapshots (http://localhost:8192/repo/m2-snapshot-repository)



[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] 
[INFO] Total time: 59 seconds
[INFO] Finished at: Fri Oct 12 12:08:28 UTC 2012
[INFO] Final Memory: 115M/241M
[INFO] 
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Benedikt Ritter

Hi

2012/10/12  :
> Author: ggregory
> Date: Fri Oct 12 12:12:44 2012
> New Revision: 1397534
>
> URL: http://svn.apache.org/viewvc?rev=1397534&view=rev
> Log:
> Refactor magic strings into constants.
>
> Modified:
> 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>
> Modified: 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java?rev=1397534&r1=1397533&r2=1397534&view=diff
> ==
> --- 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java 
> (original)
> +++ 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java 
> Fri Oct 12 12:12:44 2012
> @@ -25,6 +25,12 @@ import java.io.IOException;
>   */
>  public class CSVPrinter {
>
> +private static final char COMMENT = '#';

How about COMMENT_START ?

Benedikt

> +private static final String EMPTY = "";
> +private static final char SP = ' ';
> +private static final char CR = '\r';
> +private static final char LF = '\n';
> +
>  /** The place that the values get written. */
>  private final Appendable out;
>  private final CSVFormat format;
> @@ -106,19 +112,19 @@ public class CSVPrinter {
>  println();
>  }
>  out.append(format.getCommentStart());
> -out.append(' ');
> +out.append(SP);
>  for (int i = 0; i < comment.length(); i++) {
>  final char c = comment.charAt(i);
>  switch (c) {
> -case '\r':
> -if (i + 1 < comment.length() && comment.charAt(i + 1) == 
> '\n') {
> +case CR:
> +if (i + 1 < comment.length() && comment.charAt(i + 1) == LF) 
> {
>  i++;
>  }
>  //$FALL-THROUGH$ break intentionally excluded.
> -case '\n':
> +case LF:
>  println();
>  out.append(format.getCommentStart());
> -out.append(' ');
> +out.append(SP);
>  break;
>  default:
>  out.append(c);
> @@ -159,14 +165,14 @@ public class CSVPrinter {
>
>  while (pos < end) {
>  char c = value.charAt(pos);
> -if (c == '\r' || c == '\n' || c == delim || c == escape) {
> +if (c == CR || c == LF || c == delim || c == escape) {
>  // write out segment up until this char
>  if (pos > start) {
>  out.append(value, start, pos);
>  }
> -if (c == '\n') {
> +if (c == LF) {
>  c = 'n';
> -} else if (c == '\r') {
> +} else if (c == CR) {
>  c = 'r';
>  }
>
> @@ -212,7 +218,7 @@ public class CSVPrinter {
>  if (first && (c < '0' || (c > '9' && c < 'A') || (c > 'Z' && c < 
> 'a') || (c > 'z'))) {
>  quote = true;
>  // } else if (c == ' ' || c == '\f' || c == '\t') {
> -} else if (c <= '#') {
> +} else if (c <= COMMENT) {
>  // Some other chars at the start of a value caused the 
> parser to fail, so for now
>  // encapsulate if we start in anything less than '#'. We are 
> being conservative
>  // by including the default comment char too.
> @@ -220,7 +226,7 @@ public class CSVPrinter {
>  } else {
>  while (pos < end) {
>  c = value.charAt(pos);
> -if (c == '\n' || c == '\r' || c == encapsulator || c == 
> delim) {
> +if (c == LF || c == CR || c == encapsulator || c == 
> delim) {
>  quote = true;
>  break;
>  }
> @@ -233,7 +239,7 @@ public class CSVPrinter {
>  // if (c == ' ' || c == '\f' || c == '\t') {
>  // Some other chars at the end caused the parser to 
> fail, so for now
>  // encapsulate if we end in anything less than ' '
> -if (c <= ' ') {
> +if (c <= SP) {
>  quote = true;
>  }
>  }
> @@ -280,7 +286,7 @@ public class CSVPrinter {
>  public void print(String value, final boolean checkForEscape) throws 
> IOException {
>  if (value == null) {
>  // null values are considered empty
> -value = "";
> +value = EMPTY;
>  }
>
>  if (!checkForEscape) {
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Gary Gregory

On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter wrote:

> Hi
>
> 2012/10/12  :
> > Author: ggregory
> > Date: Fri Oct 12 12:12:44 2012
> > New Revision: 1397534
> >
> > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev
> > Log:
> > Refactor magic strings into constants.
> >
> > Modified:
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >
> > Modified:
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java?rev=1397534&r1=1397533&r2=1397534&view=diff
> >
> ==
> > ---
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> (original)
> > +++
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> Fri Oct 12 12:12:44 2012
> > @@ -25,6 +25,12 @@ import java.io.IOException;
> >   */
> >  public class CSVPrinter {
> >
> > +private static final char COMMENT = '#';
>
> How about COMMENT_START ?
>

I would say yes only /if/ there were a COMMENT_END.

Gary


> Benedikt
>
> > +private static final String EMPTY = "";
> > +private static final char SP = ' ';
> > +private static final char CR = '\r';
> > +private static final char LF = '\n';
> > +
> >  /** The place that the values get written. */
> >  private final Appendable out;
> >  private final CSVFormat format;
> > @@ -106,19 +112,19 @@ public class CSVPrinter {
> >  println();
> >  }
> >  out.append(format.getCommentStart());
> > -out.append(' ');
> > +out.append(SP);
> >  for (int i = 0; i < comment.length(); i++) {
> >  final char c = comment.charAt(i);
> >  switch (c) {
> > -case '\r':
> > -if (i + 1 < comment.length() && comment.charAt(i + 1)
> == '\n') {
> > +case CR:
> > +if (i + 1 < comment.length() && comment.charAt(i + 1)
> == LF) {
> >  i++;
> >  }
> >  //$FALL-THROUGH$ break intentionally excluded.
> > -case '\n':
> > +case LF:
> >  println();
> >  out.append(format.getCommentStart());
> > -out.append(' ');
> > +out.append(SP);
> >  break;
> >  default:
> >  out.append(c);
> > @@ -159,14 +165,14 @@ public class CSVPrinter {
> >
> >  while (pos < end) {
> >  char c = value.charAt(pos);
> > -if (c == '\r' || c == '\n' || c == delim || c == escape) {
> > +if (c == CR || c == LF || c == delim || c == escape) {
> >  // write out segment up until this char
> >  if (pos > start) {
> >  out.append(value, start, pos);
> >  }
> > -if (c == '\n') {
> > +if (c == LF) {
> >  c = 'n';
> > -} else if (c == '\r') {
> > +} else if (c == CR) {
> >  c = 'r';
> >  }
> >
> > @@ -212,7 +218,7 @@ public class CSVPrinter {
> >  if (first && (c < '0' || (c > '9' && c < 'A') || (c > 'Z'
> && c < 'a') || (c > 'z'))) {
> >  quote = true;
> >  // } else if (c == ' ' || c == '\f' || c == '\t') {
> > -} else if (c <= '#') {
> > +} else if (c <= COMMENT) {
> >  // Some other chars at the start of a value caused the
> parser to fail, so for now
> >  // encapsulate if we start in anything less than '#'.
> We are being conservative
> >  // by including the default comment char too.
> > @@ -220,7 +226,7 @@ public class CSVPrinter {
> >  } else {
> >  while (pos < end) {
> >  c = value.charAt(pos);
> > -if (c == '\n' || c == '\r' || c == encapsulator ||
> c == delim) {
> > +if (c == LF || c == CR || c == encapsulator || c ==
> delim) {
> >  quote = true;
> >  break;
> >  }
> > @@ -233,7 +239,7 @@ public class CSVPrinter {
> >  // if (c == ' ' || c == '\f' || c == '\t') {
> >  // Some other chars at the end caused the parser to
> fail, so for now
> >  // encapsulate if we end in anything less than ' '
> > -if (c <= ' ') {
> > +if (c <= SP) {
> >  quote = true;
> >  }
> >  }
> > @@ -280,7 +286,7 @@ public class CSVPrinter {
> >  public void print(String value, final boolean checkForEscape)
> throws IOException {
> >  if (value == null) {
> >  // null values are consi

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-proxy-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 131 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-proxy-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -WARNING- Overriding Maven settings: 
[/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml]
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/proxy/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/proxy/target/surefire-reports



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/gump_work/build_apache-commons_commons-proxy-test.html
Work Name: build_apache-commons_commons-proxy-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml test 
[Working Directory: /srv/gump/public/workspace/apache-commons/proxy]
M2_HOME: /opt/maven2
-
Running org.apache.commons.proxy.provider.TestBeanProvider
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.037 sec

Results :

Tests in error: 
  
testMethodInvocationImplementation(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  
testSerialization(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  
testMethodInterception(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  testInvalidHandlerName(org.apache.commons.proxy.invoker.TestXmlRpcInvoker)
  
testMethodInvocation(org.apache.commons.proxy.invoker.TestInvocationHandlerAdapter)
  testCreateNullObject(org.apache.commons.proxy.TestProxyUtils)
  testCreateNullObjectWithClassLoader(org.apache.commons.proxy.TestProxyUtils)
  
testInterceptorEquals(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerEquals(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorWithSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerWithSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testProxiesWithClashingFinalMethodInSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorHashCode(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerHashCode(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testBooleanInterceptorParameter(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testChangingArguments(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testCreateInterceptorProxy(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptingProxyClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptingProxySerializable(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorProxyWithCheckedException(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorProxyWithUncheckedException(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxy(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxyClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxySerializable(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationDuplicateMethods(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationImplementation(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testWithNonAccessibleTargetType(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)

Tests run: 179, Failures: 0, Errors: 28, Skipped: 0

[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] There are te

[GUMP@vmgump]: Project commons-dbutils (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-dbutils has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 126 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbutils :  Commons DbUtils


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-dbutils/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-dbutils-*[0-9T].jar] identifier set to 
project name
 -INFO- Optional dependency mockito failed with reason build failed
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/dbutils/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/dbutils/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/dbutils/target/surefire-reports
 -WARNING- No directory 
[/srv/gump/public/workspace/apache-commons/dbutils/target/surefire-reports]
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbutils/gump_work/build_apache-commons_commons-dbutils.html
Work Name: build_apache-commons_commons-dbutils (Type: Build)
Work ended in a state of : Failed
Elapsed: 16 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/dbutils/gump_mvn_settings.xml package 
[Working Directory: /srv/gump/public/workspace/apache-commons/dbutils]
M2_HOME: /opt/maven2
-
1K downloaded  (mockito-core-1.9.0.pom)
Downloading: 
http://localhost:8192/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.pom
479b downloaded  (hamcrest-all-1.1.pom)
Downloading: 
http://localhost:8192/maven2/org/mockito/mockito-core/1.9.0/mockito-core-1.9.0.jar
Downloading: 
http://localhost:8192/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.jar
273K downloaded  (hamcrest-all-1.1.jar)
1381K downloaded  (mockito-core-1.9.0.jar)
[INFO] [antrun:run {execution: javadoc.resources}]
[INFO] Executing tasks

main:
 [copy] Copying 2 files to 
/srv/gump/public/workspace/apache-commons/dbutils/target/apidocs/META-INF
[INFO] Executed tasks
[WARNING] The parameter expression: 'project.build.resources' used in mojo: 
'process' has been deprecated. Use 'project.resources' instead.
[INFO] [remote-resources:process {execution: default}]
[INFO] [buildnumber:create {execution: default}]
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/dbutils && svn --non-interactive info
[INFO] Working directory: /srv/gump/public/workspace/apache-commons/dbutils
[INFO] Storing buildNumber: ?? at timestamp: 1350046214062
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/dbutils && svn --non-interactive info
[INFO] Working directory: /srv/gump/public/workspace/apache-commons/dbutils
[INFO] Storing buildScmBranch: UNKNOWN_BRANCH
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/apache-commons/dbutils/src/main/resources
[INFO] Copying 2 resources to META-INF
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 29 source files to 
/srv/gump/public/workspace/apache-commons/dbutils/target/classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/srv/gump/public/workspace/apache-commons/dbutils/src/main/java/org/apache/commons/dbutils/DbUtils.java:[334,25]
 error: DriverProxy is not abstract and does not override abstract method 
getParentLogger() in Driver
[INFO] 1 error
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
/srv/gump/public/workspace/apache-commons/dbutils/src/main/java/org/apache/commons/dbutils/DbUtils.java:[334,25]
 error: DriverProxy is not abstract and does not override abstract method 
getParentLogger() in Driver

[INFO] 
[INFO] For more information, run Mav

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread sebb

On 12 October 2012 13:38, Gary Gregory  wrote:
> On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter wrote:
>
>> Hi
>>
>> 2012/10/12  :
>> > Author: ggregory
>> > Date: Fri Oct 12 12:12:44 2012
>> > New Revision: 1397534
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev
>> > Log:
>> > Refactor magic strings into constants.
>> >
>> > Modified:
>> >
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >
>> > Modified:
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> > URL:
>> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java?rev=1397534&r1=1397533&r2=1397534&view=diff
>> >
>> ==
>> > ---
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> (original)
>> > +++
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> Fri Oct 12 12:12:44 2012
>> > @@ -25,6 +25,12 @@ import java.io.IOException;
>> >   */
>> >  public class CSVPrinter {
>> >
>> > +private static final char COMMENT = '#';
>>
>> How about COMMENT_START ?
>>
>
> I would say yes only /if/ there were a COMMENT_END.

INLINE_COMMENT_INTRODUCER ?

> Gary
>
>
>> Benedikt
>>
>> > +private static final String EMPTY = "";
>> > +private static final char SP = ' ';
>> > +private static final char CR = '\r';
>> > +private static final char LF = '\n';
>> > +
>> >  /** The place that the values get written. */
>> >  private final Appendable out;
>> >  private final CSVFormat format;
>> > @@ -106,19 +112,19 @@ public class CSVPrinter {
>> >  println();
>> >  }
>> >  out.append(format.getCommentStart());
>> > -out.append(' ');
>> > +out.append(SP);
>> >  for (int i = 0; i < comment.length(); i++) {
>> >  final char c = comment.charAt(i);
>> >  switch (c) {
>> > -case '\r':
>> > -if (i + 1 < comment.length() && comment.charAt(i + 1)
>> == '\n') {
>> > +case CR:
>> > +if (i + 1 < comment.length() && comment.charAt(i + 1)
>> == LF) {
>> >  i++;
>> >  }
>> >  //$FALL-THROUGH$ break intentionally excluded.
>> > -case '\n':
>> > +case LF:
>> >  println();
>> >  out.append(format.getCommentStart());
>> > -out.append(' ');
>> > +out.append(SP);
>> >  break;
>> >  default:
>> >  out.append(c);
>> > @@ -159,14 +165,14 @@ public class CSVPrinter {
>> >
>> >  while (pos < end) {
>> >  char c = value.charAt(pos);
>> > -if (c == '\r' || c == '\n' || c == delim || c == escape) {
>> > +if (c == CR || c == LF || c == delim || c == escape) {
>> >  // write out segment up until this char
>> >  if (pos > start) {
>> >  out.append(value, start, pos);
>> >  }
>> > -if (c == '\n') {
>> > +if (c == LF) {
>> >  c = 'n';
>> > -} else if (c == '\r') {
>> > +} else if (c == CR) {
>> >  c = 'r';
>> >  }
>> >
>> > @@ -212,7 +218,7 @@ public class CSVPrinter {
>> >  if (first && (c < '0' || (c > '9' && c < 'A') || (c > 'Z'
>> && c < 'a') || (c > 'z'))) {
>> >  quote = true;
>> >  // } else if (c == ' ' || c == '\f' || c == '\t') {
>> > -} else if (c <= '#') {
>> > +} else if (c <= COMMENT) {
>> >  // Some other chars at the start of a value caused the
>> parser to fail, so for now
>> >  // encapsulate if we start in anything less than '#'.
>> We are being conservative
>> >  // by including the default comment char too.
>> > @@ -220,7 +226,7 @@ public class CSVPrinter {
>> >  } else {
>> >  while (pos < end) {
>> >  c = value.charAt(pos);
>> > -if (c == '\n' || c == '\r' || c == encapsulator ||
>> c == delim) {
>> > +if (c == LF || c == CR || c == encapsulator || c ==
>> delim) {
>> >  quote = true;
>> >  break;
>> >  }
>> > @@ -233,7 +239,7 @@ public class CSVPrinter {
>> >  // if (c == ' ' || c == '\f' || c == '\t') {
>> >  // Some other chars at the end caused the parser to
>> fail, so for now
>> >  // encapsulate if we end in anything less than ' '
>> > -if (c <= ' ') {
>> > +if (c <= SP) {
>> >  quote = true;
>> >  }
>> >  }
>> > @@ -2

Re: svn commit: r1397556 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2012-10-12 Thread sebb

On 12 October 2012 14:15,   wrote:
> Author: ggregory
> Date: Fri Oct 12 13:15:30 2012
> New Revision: 1397556
>
> URL: http://svn.apache.org/viewvc?rev=1397556&view=rev
> Log:
> More constants clean ups.
>
> Modified:
> 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java
> 
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
> 
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVParserTest.java
>
> Modified: 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java?rev=1397556&r1=1397555&r2=1397556&view=diff
> ==
> --- 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java 
> (original)
> +++ 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java 
> Fri Oct 12 13:15:30 2012
> @@ -18,7 +18,7 @@
>  package org.apache.commons.csv;
>
>  import static org.apache.commons.csv.Constants.COMMA;
> -import static org.apache.commons.csv.Constants.CR;
> +import static org.apache.commons.csv.Constants.CRLF;
>  import static org.apache.commons.csv.Constants.DOUBLE_QUOTE;
>  import static org.apache.commons.csv.Constants.ESCAPE;
>  import static org.apache.commons.csv.Constants.LF;
> @@ -36,13 +36,8 @@ import java.io.StringWriter;
>   */
>  public class CSVFormat implements Serializable {
>
> -private static final String LF_STR = "" + LF;
> -
>  private static final long serialVersionUID = 1L;
>
> -/** According to RFC 4180, line breaks are delimited by CRLF */
> -public static final String CRLF = "" + CR + LF;
> -
>  private final char delimiter;
>  private final char encapsulator;
>  private final char commentStart;
> @@ -136,7 +131,7 @@ public class CSVFormat implements Serial
>  PRISTINE
>  .withDelimiter(TAB)
>  .withEscape(ESCAPE)
> -.withLineSeparator(LF_STR);
> +.withLineSeparator(LF);
>
>  /**
>   * Creates a customized CSV format.
> @@ -413,6 +408,19 @@ public class CSVFormat implements Serial
>   *
>   * @return A copy of this format using the specified output line 
> separator
>   */
> +public CSVFormat withLineSeparator(final char lineSeparator) {
> +return new CSVFormat(delimiter, encapsulator, commentStart, escape, 
> ignoreSurroundingSpaces,
> +ignoreEmptyLines, String.valueOf(lineSeparator), header);
> +}
> +
> +/**
> + * Returns a copy of this format using the specified output line 
> separator.
> + *
> + * @param lineSeparator
> + *the line separator to be used for output.
> + *
> + * @return A copy of this format using the specified output line 
> separator
> + */
>  public CSVFormat withLineSeparator(final String lineSeparator) {
>  return new CSVFormat(delimiter, encapsulator, commentStart, escape, 
> ignoreSurroundingSpaces,
>  ignoreEmptyLines, lineSeparator, header);
>
> Modified: 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java?rev=1397556&r1=1397555&r2=1397556&view=diff
> ==
> --- 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java 
> (original)
> +++ 
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java 
> Fri Oct 12 13:15:30 2012
> @@ -39,6 +39,10 @@ class Constants {
>
>  /** Undefined state for the lookahead char */
>  static final int UNDEFINED = -2;
> +
> +/** According to RFC 4180, line breaks are delimited by CRLF */
> +public static final String CRLF = EMPTY + CR + LF;

That looks very awkward; not particularly easy to read either.

Why not use:

public static final String CRLF = "\r\n";

> +
>
>
>  }
>
> Modified: 
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java?rev=1397556&r1=1397555&r2=1397556&view=diff
> ==
> --- 
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
>  (original)
> +++ 
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
>  Fri Oct 12 13:15:30 2012
> @@ -17,6 +17,7 @@
>
>  package org.apache.commons.csv;
>
> +import static org.apache.commons.csv.Constants.CRLF;
>  import static org.junit.Assert.assertEquals;
>  import static org.junit.Assert.assertFalse;
>

Re: svn commit: r1397556 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2012-10-12 Thread Gary Gregory

On Fri, Oct 12, 2012 at 9:44 AM, sebb  wrote:

> On 12 October 2012 14:15,   wrote:
> > Author: ggregory
> > Date: Fri Oct 12 13:15:30 2012
> > New Revision: 1397556
> >
> > URL: http://svn.apache.org/viewvc?rev=1397556&view=rev
> > Log:
> > More constants clean ups.
> >
> > Modified:
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> >
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java
> >
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
> >
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVParserTest.java
> >
> > Modified:
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java?rev=1397556&r1=1397555&r2=1397556&view=diff
> >
> ==
> > ---
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> (original)
> > +++
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> Fri Oct 12 13:15:30 2012
> > @@ -18,7 +18,7 @@
> >  package org.apache.commons.csv;
> >
> >  import static org.apache.commons.csv.Constants.COMMA;
> > -import static org.apache.commons.csv.Constants.CR;
> > +import static org.apache.commons.csv.Constants.CRLF;
> >  import static org.apache.commons.csv.Constants.DOUBLE_QUOTE;
> >  import static org.apache.commons.csv.Constants.ESCAPE;
> >  import static org.apache.commons.csv.Constants.LF;
> > @@ -36,13 +36,8 @@ import java.io.StringWriter;
> >   */
> >  public class CSVFormat implements Serializable {
> >
> > -private static final String LF_STR = "" + LF;
> > -
> >  private static final long serialVersionUID = 1L;
> >
> > -/** According to RFC 4180, line breaks are delimited by CRLF */
> > -public static final String CRLF = "" + CR + LF;
> > -
> >  private final char delimiter;
> >  private final char encapsulator;
> >  private final char commentStart;
> > @@ -136,7 +131,7 @@ public class CSVFormat implements Serial
> >  PRISTINE
> >  .withDelimiter(TAB)
> >  .withEscape(ESCAPE)
> > -.withLineSeparator(LF_STR);
> > +.withLineSeparator(LF);
> >
> >  /**
> >   * Creates a customized CSV format.
> > @@ -413,6 +408,19 @@ public class CSVFormat implements Serial
> >   *
> >   * @return A copy of this format using the specified output line
> separator
> >   */
> > +public CSVFormat withLineSeparator(final char lineSeparator) {
> > +return new CSVFormat(delimiter, encapsulator, commentStart,
> escape, ignoreSurroundingSpaces,
> > +ignoreEmptyLines, String.valueOf(lineSeparator),
> header);
> > +}
> > +
> > +/**
> > + * Returns a copy of this format using the specified output line
> separator.
> > + *
> > + * @param lineSeparator
> > + *the line separator to be used for output.
> > + *
> > + * @return A copy of this format using the specified output line
> separator
> > + */
> >  public CSVFormat withLineSeparator(final String lineSeparator) {
> >  return new CSVFormat(delimiter, encapsulator, commentStart,
> escape, ignoreSurroundingSpaces,
> >  ignoreEmptyLines, lineSeparator, header);
> >
> > Modified:
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java?rev=1397556&r1=1397555&r2=1397556&view=diff
> >
> ==
> > ---
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java
> (original)
> > +++
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Constants.java
> Fri Oct 12 13:15:30 2012
> > @@ -39,6 +39,10 @@ class Constants {
> >
> >  /** Undefined state for the lookahead char */
> >  static final int UNDEFINED = -2;
> > +
> > +/** According to RFC 4180, line breaks are delimited by CRLF */
> > +public static final String CRLF = EMPTY + CR + LF;
>
> That looks very awkward; not particularly easy to read either.
>
> Why not use:
>
> public static final String CRLF = "\r\n";
>

Done.

Gary


>
> > +
> >
> >
> >  }
> >
> > Modified:
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java?rev=1397556&r1=1397555&r2=1397556&view=diff
> >
> ==
> > ---
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
> (original)
> > +++
> commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
> Fri Oct

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Gary Gregory

On Fri, Oct 12, 2012 at 9:39 AM, sebb  wrote:

> On 12 October 2012 13:38, Gary Gregory  wrote:
> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter  >wrote:
> >
> >> Hi
> >>
> >> 2012/10/12  :
> >> > Author: ggregory
> >> > Date: Fri Oct 12 12:12:44 2012
> >> > New Revision: 1397534
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev
> >> > Log:
> >> > Refactor magic strings into constants.
> >> >
> >> > Modified:
> >> >
> >>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >> >
> >> > Modified:
> >>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >> > URL:
> >>
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java?rev=1397534&r1=1397533&r2=1397534&view=diff
> >> >
> >>
> ==
> >> > ---
> >>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >> (original)
> >> > +++
> >>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >> Fri Oct 12 12:12:44 2012
> >> > @@ -25,6 +25,12 @@ import java.io.IOException;
> >> >   */
> >> >  public class CSVPrinter {
> >> >
> >> > +private static final char COMMENT = '#';
> >>
> >> How about COMMENT_START ?
> >>
> >
> > I would say yes only /if/ there were a COMMENT_END.
>
> INLINE_COMMENT_INTRODUCER ?
>

IS_IT_APRIL_1?

I do not know you well enough to read you ;)

G


> > Gary
> >
> >
> >> Benedikt
> >>
> >> > +private static final String EMPTY = "";
> >> > +private static final char SP = ' ';
> >> > +private static final char CR = '\r';
> >> > +private static final char LF = '\n';
> >> > +
> >> >  /** The place that the values get written. */
> >> >  private final Appendable out;
> >> >  private final CSVFormat format;
> >> > @@ -106,19 +112,19 @@ public class CSVPrinter {
> >> >  println();
> >> >  }
> >> >  out.append(format.getCommentStart());
> >> > -out.append(' ');
> >> > +out.append(SP);
> >> >  for (int i = 0; i < comment.length(); i++) {
> >> >  final char c = comment.charAt(i);
> >> >  switch (c) {
> >> > -case '\r':
> >> > -if (i + 1 < comment.length() && comment.charAt(i + 1)
> >> == '\n') {
> >> > +case CR:
> >> > +if (i + 1 < comment.length() && comment.charAt(i + 1)
> >> == LF) {
> >> >  i++;
> >> >  }
> >> >  //$FALL-THROUGH$ break intentionally excluded.
> >> > -case '\n':
> >> > +case LF:
> >> >  println();
> >> >  out.append(format.getCommentStart());
> >> > -out.append(' ');
> >> > +out.append(SP);
> >> >  break;
> >> >  default:
> >> >  out.append(c);
> >> > @@ -159,14 +165,14 @@ public class CSVPrinter {
> >> >
> >> >  while (pos < end) {
> >> >  char c = value.charAt(pos);
> >> > -if (c == '\r' || c == '\n' || c == delim || c == escape)
> {
> >> > +if (c == CR || c == LF || c == delim || c == escape) {
> >> >  // write out segment up until this char
> >> >  if (pos > start) {
> >> >  out.append(value, start, pos);
> >> >  }
> >> > -if (c == '\n') {
> >> > +if (c == LF) {
> >> >  c = 'n';
> >> > -} else if (c == '\r') {
> >> > +} else if (c == CR) {
> >> >  c = 'r';
> >> >  }
> >> >
> >> > @@ -212,7 +218,7 @@ public class CSVPrinter {
> >> >  if (first && (c < '0' || (c > '9' && c < 'A') || (c > 'Z'
> >> && c < 'a') || (c > 'z'))) {
> >> >  quote = true;
> >> >  // } else if (c == ' ' || c == '\f' || c == '\t') {
> >> > -} else if (c <= '#') {
> >> > +} else if (c <= COMMENT) {
> >> >  // Some other chars at the start of a value caused
> the
> >> parser to fail, so for now
> >> >  // encapsulate if we start in anything less than '#'.
> >> We are being conservative
> >> >  // by including the default comment char too.
> >> > @@ -220,7 +226,7 @@ public class CSVPrinter {
> >> >  } else {
> >> >  while (pos < end) {
> >> >  c = value.charAt(pos);
> >> > -if (c == '\n' || c == '\r' || c == encapsulator
> ||
> >> c == delim) {
> >> > +if (c == LF || c == CR || c == encapsulator || c
> ==
> >> delim) {
> >> >  quote = true;
> >> >  break;
> >> >  }
> >> > @@ -233,7 +239,7 @@ public class CSVPrinter {
> >> >  // if (c == ' ' || c ==

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread sebb

On 12 October 2012 14:50, Gary Gregory  wrote:
> On Fri, Oct 12, 2012 at 9:39 AM, sebb  wrote:
>
>> On 12 October 2012 13:38, Gary Gregory  wrote:
>> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter > >wrote:
>> >
>> >> Hi
>> >>
>> >> 2012/10/12  :
>> >> > Author: ggregory
>> >> > Date: Fri Oct 12 12:12:44 2012
>> >> > New Revision: 1397534
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev
>> >> > Log:
>> >> > Refactor magic strings into constants.
>> >> >
>> >> > Modified:
>> >> >
>> >>
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >> >
>> >> > Modified:
>> >>
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java?rev=1397534&r1=1397533&r2=1397534&view=diff
>> >> >
>> >>
>> ==
>> >> > ---
>> >>
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >> (original)
>> >> > +++
>> >>
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >> Fri Oct 12 12:12:44 2012
>> >> > @@ -25,6 +25,12 @@ import java.io.IOException;
>> >> >   */
>> >> >  public class CSVPrinter {
>> >> >
>> >> > +private static final char COMMENT = '#';
>> >>
>> >> How about COMMENT_START ?
>> >>
>> >
>> > I would say yes only /if/ there were a COMMENT_END.
>>
>> INLINE_COMMENT_INTRODUCER ?
>>
>
> IS_IT_APRIL_1?

No.

But I agree it's not an ideal name.

It's just that COMMENT on its own is not ideal either.

Maybe the solution is to add Javadoc to explain how the # is used to
introduce comments.


> I do not know you well enough to read you ;)
>
> G
>
>
>> > Gary
>> >
>> >
>> >> Benedikt
>> >>
>> >> > +private static final String EMPTY = "";
>> >> > +private static final char SP = ' ';
>> >> > +private static final char CR = '\r';
>> >> > +private static final char LF = '\n';
>> >> > +
>> >> >  /** The place that the values get written. */
>> >> >  private final Appendable out;
>> >> >  private final CSVFormat format;
>> >> > @@ -106,19 +112,19 @@ public class CSVPrinter {
>> >> >  println();
>> >> >  }
>> >> >  out.append(format.getCommentStart());
>> >> > -out.append(' ');
>> >> > +out.append(SP);
>> >> >  for (int i = 0; i < comment.length(); i++) {
>> >> >  final char c = comment.charAt(i);
>> >> >  switch (c) {
>> >> > -case '\r':
>> >> > -if (i + 1 < comment.length() && comment.charAt(i + 1)
>> >> == '\n') {
>> >> > +case CR:
>> >> > +if (i + 1 < comment.length() && comment.charAt(i + 1)
>> >> == LF) {
>> >> >  i++;
>> >> >  }
>> >> >  //$FALL-THROUGH$ break intentionally excluded.
>> >> > -case '\n':
>> >> > +case LF:
>> >> >  println();
>> >> >  out.append(format.getCommentStart());
>> >> > -out.append(' ');
>> >> > +out.append(SP);
>> >> >  break;
>> >> >  default:
>> >> >  out.append(c);
>> >> > @@ -159,14 +165,14 @@ public class CSVPrinter {
>> >> >
>> >> >  while (pos < end) {
>> >> >  char c = value.charAt(pos);
>> >> > -if (c == '\r' || c == '\n' || c == delim || c == escape)
>> {
>> >> > +if (c == CR || c == LF || c == delim || c == escape) {
>> >> >  // write out segment up until this char
>> >> >  if (pos > start) {
>> >> >  out.append(value, start, pos);
>> >> >  }
>> >> > -if (c == '\n') {
>> >> > +if (c == LF) {
>> >> >  c = 'n';
>> >> > -} else if (c == '\r') {
>> >> > +} else if (c == CR) {
>> >> >  c = 'r';
>> >> >  }
>> >> >
>> >> > @@ -212,7 +218,7 @@ public class CSVPrinter {
>> >> >  if (first && (c < '0' || (c > '9' && c < 'A') || (c > 'Z'
>> >> && c < 'a') || (c > 'z'))) {
>> >> >  quote = true;
>> >> >  // } else if (c == ' ' || c == '\f' || c == '\t') {
>> >> > -} else if (c <= '#') {
>> >> > +} else if (c <= COMMENT) {
>> >> >  // Some other chars at the start of a value caused
>> the
>> >> parser to fail, so for now
>> >> >  // encapsulate if we start in anything less than '#'.
>> >> We are being conservative
>> >> >  // by including the default comment char too.
>> >> > @@ -220,7 +226,7 @@ public class CSVPrinter {
>> >> >  } else {
>> >> >  while (pos < end) {
>> >> >  c = value.charAt(pos);
>> >> > -if (c == '\

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Gary Gregory

On Fri, Oct 12, 2012 at 9:56 AM, sebb  wrote:

> On 12 October 2012 14:50, Gary Gregory  wrote:
> > On Fri, Oct 12, 2012 at 9:39 AM, sebb  wrote:
> >
> >> On 12 October 2012 13:38, Gary Gregory  wrote:
> >> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter <
> benerit...@gmail.com
> >> >wrote:
> >> >
> >> >> Hi
> >> >>
> >> >> 2012/10/12  :
> >> >> > Author: ggregory
> >> >> > Date: Fri Oct 12 12:12:44 2012
> >> >> > New Revision: 1397534
> >> >> >
> >> >> > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev
> >> >> > Log:
> >> >> > Refactor magic strings into constants.
> >> >> >
> >> >> > Modified:
> >> >> >
> >> >>
> >>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >> >> >
> >> >> > Modified:
> >> >>
> >>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >> >> > URL:
> >> >>
> >>
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java?rev=1397534&r1=1397533&r2=1397534&view=diff
> >> >> >
> >> >>
> >>
> ==
> >> >> > ---
> >> >>
> >>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >> >> (original)
> >> >> > +++
> >> >>
> >>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
> >> >> Fri Oct 12 12:12:44 2012
> >> >> > @@ -25,6 +25,12 @@ import java.io.IOException;
> >> >> >   */
> >> >> >  public class CSVPrinter {
> >> >> >
> >> >> > +private static final char COMMENT = '#';
> >> >>
> >> >> How about COMMENT_START ?
> >> >>
> >> >
> >> > I would say yes only /if/ there were a COMMENT_END.
> >>
> >> INLINE_COMMENT_INTRODUCER ?
> >>
> >
> > IS_IT_APRIL_1?
>
> No.
>
> But I agree it's not an ideal name.
>
> It's just that COMMENT on its own is not ideal either.
>
> Maybe the solution is to add Javadoc to explain how the # is used to
> introduce comments.
>

Roger that. I added a comment.

G


>
>
> > I do not know you well enough to read you ;)
> >
> > G
> >
> >
> >> > Gary
> >> >
> >> >
> >> >> Benedikt
> >> >>
> >> >> > +private static final String EMPTY = "";
> >> >> > +private static final char SP = ' ';
> >> >> > +private static final char CR = '\r';
> >> >> > +private static final char LF = '\n';
> >> >> > +
> >> >> >  /** The place that the values get written. */
> >> >> >  private final Appendable out;
> >> >> >  private final CSVFormat format;
> >> >> > @@ -106,19 +112,19 @@ public class CSVPrinter {
> >> >> >  println();
> >> >> >  }
> >> >> >  out.append(format.getCommentStart());
> >> >> > -out.append(' ');
> >> >> > +out.append(SP);
> >> >> >  for (int i = 0; i < comment.length(); i++) {
> >> >> >  final char c = comment.charAt(i);
> >> >> >  switch (c) {
> >> >> > -case '\r':
> >> >> > -if (i + 1 < comment.length() && comment.charAt(i
> + 1)
> >> >> == '\n') {
> >> >> > +case CR:
> >> >> > +if (i + 1 < comment.length() && comment.charAt(i
> + 1)
> >> >> == LF) {
> >> >> >  i++;
> >> >> >  }
> >> >> >  //$FALL-THROUGH$ break intentionally excluded.
> >> >> > -case '\n':
> >> >> > +case LF:
> >> >> >  println();
> >> >> >  out.append(format.getCommentStart());
> >> >> > -out.append(' ');
> >> >> > +out.append(SP);
> >> >> >  break;
> >> >> >  default:
> >> >> >  out.append(c);
> >> >> > @@ -159,14 +165,14 @@ public class CSVPrinter {
> >> >> >
> >> >> >  while (pos < end) {
> >> >> >  char c = value.charAt(pos);
> >> >> > -if (c == '\r' || c == '\n' || c == delim || c ==
> escape)
> >> {
> >> >> > +if (c == CR || c == LF || c == delim || c == escape) {
> >> >> >  // write out segment up until this char
> >> >> >  if (pos > start) {
> >> >> >  out.append(value, start, pos);
> >> >> >  }
> >> >> > -if (c == '\n') {
> >> >> > +if (c == LF) {
> >> >> >  c = 'n';
> >> >> > -} else if (c == '\r') {
> >> >> > +} else if (c == CR) {
> >> >> >  c = 'r';
> >> >> >  }
> >> >> >
> >> >> > @@ -212,7 +218,7 @@ public class CSVPrinter {
> >> >> >  if (first && (c < '0' || (c > '9' && c < 'A') || (c >
> 'Z'
> >> >> && c < 'a') || (c > 'z'))) {
> >> >> >  quote = true;
> >> >> >  // } else if (c == ' ' || c == '\f' || c == '\t')
> {
> >> >> > -} else if (c <= '#') {
> >> >> > +} else if (c <= COMMENT) {
> >> >> >  // Some other chars at the start of a value caused
> >> the
> >> >> parser to fail, so for

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Benedikt Ritter

2012/10/12 Gary Gregory :
> On Fri, Oct 12, 2012 at 9:56 AM, sebb  wrote:
>
>> On 12 October 2012 14:50, Gary Gregory  wrote:
>> > On Fri, Oct 12, 2012 at 9:39 AM, sebb  wrote:
>> >
>> >> On 12 October 2012 13:38, Gary Gregory  wrote:
>> >> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter <
>> benerit...@gmail.com
>> >> >wrote:
>> >> >
>> >> >> Hi
>> >> >>
>> >> >> 2012/10/12  :
>> >> >> > Author: ggregory
>> >> >> > Date: Fri Oct 12 12:12:44 2012
>> >> >> > New Revision: 1397534
>> >> >> >
>> >> >> > URL: http://svn.apache.org/viewvc?rev=1397534&view=rev
>> >> >> > Log:
>> >> >> > Refactor magic strings into constants.
>> >> >> >
>> >> >> > Modified:
>> >> >> >
>> >> >>
>> >>
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >> >> >
>> >> >> > Modified:
>> >> >>
>> >>
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >> >> > URL:
>> >> >>
>> >>
>> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java?rev=1397534&r1=1397533&r2=1397534&view=diff
>> >> >> >
>> >> >>
>> >>
>> ==
>> >> >> > ---
>> >> >>
>> >>
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >> >> (original)
>> >> >> > +++
>> >> >>
>> >>
>> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java
>> >> >> Fri Oct 12 12:12:44 2012
>> >> >> > @@ -25,6 +25,12 @@ import java.io.IOException;
>> >> >> >   */
>> >> >> >  public class CSVPrinter {
>> >> >> >
>> >> >> > +private static final char COMMENT = '#';
>> >> >>
>> >> >> How about COMMENT_START ?
>> >> >>
>> >> >
>> >> > I would say yes only /if/ there were a COMMENT_END.
>> >>
>> >> INLINE_COMMENT_INTRODUCER ?
>> >>
>> >
>> > IS_IT_APRIL_1?
>>
>> No.
>>
>> But I agree it's not an ideal name.
>>
>> It's just that COMMENT on its own is not ideal either.
>>
>> Maybe the solution is to add Javadoc to explain how the # is used to
>> introduce comments.
>>
>
> Roger that. I added a comment.
>
> G
>

Or how about COMMENT_MARKER?

>
>>
>>
>> > I do not know you well enough to read you ;)
>> >
>> > G
>> >
>> >
>> >> > Gary
>> >> >
>> >> >
>> >> >> Benedikt
>> >> >>
>> >> >> > +private static final String EMPTY = "";
>> >> >> > +private static final char SP = ' ';
>> >> >> > +private static final char CR = '\r';
>> >> >> > +private static final char LF = '\n';
>> >> >> > +
>> >> >> >  /** The place that the values get written. */
>> >> >> >  private final Appendable out;
>> >> >> >  private final CSVFormat format;
>> >> >> > @@ -106,19 +112,19 @@ public class CSVPrinter {
>> >> >> >  println();
>> >> >> >  }
>> >> >> >  out.append(format.getCommentStart());
>> >> >> > -out.append(' ');
>> >> >> > +out.append(SP);
>> >> >> >  for (int i = 0; i < comment.length(); i++) {
>> >> >> >  final char c = comment.charAt(i);
>> >> >> >  switch (c) {
>> >> >> > -case '\r':
>> >> >> > -if (i + 1 < comment.length() && comment.charAt(i
>> + 1)
>> >> >> == '\n') {
>> >> >> > +case CR:
>> >> >> > +if (i + 1 < comment.length() && comment.charAt(i
>> + 1)
>> >> >> == LF) {
>> >> >> >  i++;
>> >> >> >  }
>> >> >> >  //$FALL-THROUGH$ break intentionally excluded.
>> >> >> > -case '\n':
>> >> >> > +case LF:
>> >> >> >  println();
>> >> >> >  out.append(format.getCommentStart());
>> >> >> > -out.append(' ');
>> >> >> > +out.append(SP);
>> >> >> >  break;
>> >> >> >  default:
>> >> >> >  out.append(c);
>> >> >> > @@ -159,14 +165,14 @@ public class CSVPrinter {
>> >> >> >
>> >> >> >  while (pos < end) {
>> >> >> >  char c = value.charAt(pos);
>> >> >> > -if (c == '\r' || c == '\n' || c == delim || c ==
>> escape)
>> >> {
>> >> >> > +if (c == CR || c == LF || c == delim || c == escape) {
>> >> >> >  // write out segment up until this char
>> >> >> >  if (pos > start) {
>> >> >> >  out.append(value, start, pos);
>> >> >> >  }
>> >> >> > -if (c == '\n') {
>> >> >> > +if (c == LF) {
>> >> >> >  c = 'n';
>> >> >> > -} else if (c == '\r') {
>> >> >> > +} else if (c == CR) {
>> >> >> >  c = 'r';
>> >> >> >  }
>> >> >> >
>> >> >> > @@ -212,7 +218,7 @@ public class CSVPrinter {
>> >> >> >  if (first && (c < '0' || (c > '9' && c < 'A') || (c >
>> 'Z'
>> >> >> && c < 'a') || (c > 'z'))) {
>> >> >> >  quote = true;
>> >> >> >  // } else if (c == ' ' || c == '\f' || c == '\t')
>>

[GUMP@vmgump]: Project commons-vfs2-test (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-vfs2-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 7 runs.
The current state of this project is 'Failed', with reason 'Build Timed Out'.
For reference only, the following projects are affected by this:
- commons-vfs2-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-vfs2-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -WARNING- Overriding Maven settings: 
[/srv/gump/public/workspace/apache-commons/vfs/gump_mvn_settings.xml]
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/vfs/gump_mvn_settings.xml
 -INFO- Failed with reason build timed out
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/vfs/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/vfs/core/target/surefire-reports



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-vfs2-test/gump_work/build_apache-commons_commons-vfs2-test.html
Work Name: build_apache-commons_commons-vfs2-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 60 mins
Command Line: /opt/maven3/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/vfs/gump_mvn_settings.xml package 
[Working Directory: /srv/gump/public/workspace/apache-commons/vfs]
M2_HOME: /opt/maven3
-
Running org.apache.commons.vfs2.FileSystemExceptionTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec
Running org.apache.commons.vfs2.FileTypeSelectorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec
Running org.apache.commons.vfs2.FileIteratorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.027 sec
Running org.apache.commons.vfs2.cache.LRUFilesCacheTestCase
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.194 sec
Running org.apache.commons.vfs2.cache.NullFilesCacheTestCase
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.126 sec
Running org.apache.commons.vfs2.util.DelegatingFileSystemOptionsBuilderTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.124 sec
Running org.apache.commons.vfs2.util.EncryptDecryptTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.627 sec
Running org.apache.commons.vfs2.provider.zip.test.NestedZipTestCase
Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.491 sec
Running org.apache.commons.vfs2.provider.zip.test.ZipProviderTestCase
Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.244 sec
Running org.apache.commons.vfs2.provider.jar.test.JarAttributesTestCase
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.022 sec
Running org.apache.commons.vfs2.provider.jar.test.NestedJarTestCase
Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.242 sec
Running org.apache.commons.vfs2.provider.jar.test.JarProviderTestCase
Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.232 sec
Running org.apache.commons.vfs2.provider.ftp.test.FtpProviderTestCase
Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.702 sec
Running org.apache.commons.vfs2.provider.ftp.test.MultipleConnectionTestCase
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.057 sec
Running org.apache.commons.vfs2.provider.test.GenericFileNameTestCase
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec
Running org.apache.commons.vfs2.provider.test.VirtualProviderTestCase
Tests run: 75, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.398 sec
Running org.apache.commons.vfs2.provider.test.FileObjectSortTestCase
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec
Running org.apache.commons.vfs2.provider.url.test.UrlHttpProviderTestCase
Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.326 sec
Running org.apache.commons.vfs2.provider.url.test.UrlProviderTestCase
Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.426 sec
Running org.apache.commons.vfs2.provider.url.test.UrlProviderHttpTestCase
created threads still running:
#1: system  Keep-Alive-Timerdaemon  class 
sun.net.www.http.KeepAliveCache

Tests run: 73, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.911 sec
Running org.apache.commons.vfs2.provider.http.test.GetContentInfoFunctionalTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.2 sec
Running org.apache.commons.vfs2.provider.http.test.HttpFilesCacheTestCase
Tests run: 1,

[RESULT][VOTE] Apache Commons as Sponsor for BeanShell in Incubator

2012-10-12 Thread Simone Tripodi

Hi all,

more than 72 hours have passed and the VOTE can be considered closed
and passes with following resolution:

Thirteen +1 binding votes from following PMCs:

 * Simone Tripodi
 * Sebb
 * Oliver Heger
 * Phil Steitz
 * Christian Grobmeier
 * Ralph Goers
 * Luc Maisonobe
 * Rony G. Flatscher
 * Jörg Schaible
 * Thomas Neidhart
 * Gary Gregory
 * James Carman
 * Thomas Vandahl

No other votes have been casted.

So, the Commons PMC is sponsoring BeanShell to join the incubator!

Thanks everybody who took part to the VOTE, have a nice weekend!
All the best,
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Tue, Oct 9, 2012 at 3:12 PM, Simone Tripodi  wrote:
> Hi all,
>
> (following up the discussion from private@)
>
> I prepared the BeanShell[1] proposal to be submitted to the ASF
> incubator and, as already discussed time ago with interested people
> and the original author, we agreed Commons should be the best place
> for BeanShell where living.
>
> So, I'm here to call for a vote for Commons PMC be the BeanShell
> Sponsor, please cast your votes
>
> [ ] +1
> [ ] +/- 0
> [ ] -1, because...
>
> We already collected ten +1 votes from following PMCs:
>
>  * Simone Tripodi
>  * Sebb
>  * Oliver Heger
>  * Phil Steitz
>  * Christian Grobmeier
>  * Ralph Goers
>  * Luc Maisonobe
>  * Rony G. Flatscher
>  * Jörg Schaible
>  * Thomas Neidhart
>
> PMCs that already expressed their vote don't need to express it again.
>
> This vote is open for at least 72hours and will close on ~October 12th
> at 01:00pm GMT
>
> Many thanks in advance, have a nice day!
> Simo
>
> [1] http://wiki.apache.org/incubator/BeanShellProposal
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2012-10-12 Thread Jörg Schaible

Gary Gregory wrote:

> On Fri, Oct 12, 2012 at 9:39 AM, sebb  wrote:
> 
>> On 12 October 2012 13:38, Gary Gregory  wrote:
>> > On Fri, Oct 12, 2012 at 8:22 AM, Benedikt Ritter > >wrote:

[snip]

>> >> >
>> >> > +private static final char COMMENT = '#';
>> >>
>> >> How about COMMENT_START ?
>> >>
>> >
>> > I would say yes only /if/ there were a COMMENT_END.
>>
>> INLINE_COMMENT_INTRODUCER ?
>>
> 
> IS_IT_APRIL_1?
> 
> I do not know you well enough to read you ;)

Thanks, you made my day :D

- Jörg


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-scxml-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 131 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-scxml-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -WARNING- Overriding Maven settings: 
[/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml]
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/scxml/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/scxml/target/surefire-reports



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/gump_work/build_apache-commons_commons-scxml-test.html
Work Name: build_apache-commons_commons-scxml-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -Dsimplelog.defaultlog=info 
--settings 
/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml test 
[Working Directory: /srv/gump/public/workspace/apache-commons/scxml]
M2_HOME: /opt/maven2
-
[INFO] SimpleSCXMLListener - /s2/s2.1/e1.2
[INFO] SimpleSCXMLListener - /s2/s2.1/e1.2
[INFO] SimpleSCXMLListener - /s2/s2.1
[INFO] SimpleSCXMLListener - /s2
[INFO] SimpleSCXMLListener - transition (event = s2.1.done, cond = null, from = 
/s2, to = /s3)
[INFO] SimpleSCXMLListener - /s3
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.253 sec
Running org.apache.commons.scxml.issues.Issue64Test
[INFO] SCXMLSemantics - null: Begin transition bug test ...
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SCXMLSemantics - null: somedata
[INFO] SCXMLSemantics - null: *somedata
[INFO] SimpleSCXMLListener - transition (event = show.bug, cond = null, from = 
/tranbug, to = /end)
[INFO] SimpleSCXMLListener - /end
[WARN] SCXMLParser - Ignoring element  in namespace 
"http://www.w3.org/2005/07/scxml"; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:30:21
 and digester match "scxml/datamodel/misplaced"
[WARN] SCXMLParser - Ignoring element  in namespace 
"http://www.w3.org/2005/07/scxml"; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:36:19
 and digester match "scxml/state/onentry/foo"
[WARN] SCXMLParser - Ignoring element  in namespace 
"http://my.foo.example/"; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:37:22
 and digester match "scxml/state/onentry/bar"
[WARN] SCXMLParser - Ignoring element  in namespace 
"http://www.w3.org/2005/07/scxml"; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:41:21
 and digester match "scxml/state/transition/datamodel"
[WARN] SCXMLParser - Ignoring element  in namespace 
"http://www.w3.org/2005/07/scxml"; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:42:41
 and digester match "scxml/state/transition/datamodel/data"
[WARN] SCXMLParser - Ignoring element  in namespace 
"http://my.foo.example/"; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:49:14
 and digester match "scxml/baz"
[INFO] SCXMLSemantics - null: Begin transition bug test ...
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SCXMLSemantics - null: null
[WARN] SimpleErrorReporter - EXPRESSION_ERROR (eval(''*' + dummy'):null): 
[INFO] SimpleSCXMLListener - transition (event = show.bug, cond = null, from = 
/tranbug, to = /end)
[INFO] SimpleSCXMLListener - /end
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.07 sec

Results :

Failed tests: 
  testCustomActionCallbacks(org.apache.commons.scxml.model.CustomActionTest)

Tests run: 229, Failures: 1, Errors: 0, Skipped: 0

[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO]

[GUMP@vmgump]: Project commons-jelly-tags-sql (in module commons-jelly) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-jelly-tags-sql has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 59 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-sql :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-sql/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-jelly-tags-sql-12102012.jar] identifier set 
to project name
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -DEBUG- Dependency on commons-jexl-1.x exists, no need to add for property 
maven.jar.commons-jexl.
 -DEBUG- (Apache Gump generated) Apache Maven Properties in: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/project.xml
 -DEBUG- Maven project properties in: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/project.properties
 -INFO- Project Reports in: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/target/test-reports
 -WARNING- No directory 
[/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/target/test-reports]
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-sql/gump_work/build_commons-jelly_commons-jelly-tags-sql.html
Work Name: build_commons-jelly_commons-jelly-tags-sql (Type: Build)
Work ended in a state of : Failed
Elapsed: 6 secs
Command Line: maven --offline jar 
[Working Directory: /srv/gump/public/workspace/commons-jelly/jelly-tags/sql]
-
 __  __
|  \/  |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|  v. 1.0.2

You are working offline so the build will continue, but 
commons-jelly-1.1-SNAPSHOT.jar may be out of date!
build:start:

java:prepare-filesystem:
[mkdir] Created dir: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/target/classes

java:compile:
[echo] Compiling to 
/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/target/classes
[javac] Compiling 18 source files to 
/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/target/classes
[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 1.5
[javac] 
/srv/gump/public/workspace/commons-jelly/jelly-tags/sql/src/java/org/apache/commons/jelly/tags/sql/DataSourceWrapper.java:38:
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource
[javac] public class DataSourceWrapper implements DataSource {
[javac]^
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 error
[javac] 1 warning

BUILD FAILED
File.. /home/gump/.maven/cache/maven-java-plugin-1.5/plugin.jelly
Element... ant:javac
Line.. 63
Column 48
Compile failed; see the compiler error output for details.
Total time: 6 seconds
Finished at: Fri Oct 12 16:44:57 UTC 2012

-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-sql/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-sql/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 08000612102012, vmgump.apache.org:vmgump:08000612102012
Gump E-mail Identifier (unique within run) #61.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [configuration] POC new reloading approach

2012-10-12 Thread Oliver Heger


Am 11.10.2012 22:22, schrieb Honton, Charles:

So the Configuration is immutable and consistent.


Currently, the Configuration interface allows manipulating property 
values. So there still has to be synchronization for readers and 
writers. An immutable configuration interface has already been discussed 
and would certainly make a good addition.


With the existing reloading implementation there is the problem that it 
is very tightly integrated into configuration implementations. All 
access methods have to check whether reloading is required. This also 
means that a Configuration object can change its content at any time. It 
is very hard to get this correctly synchronized in an efficient way.




Can the Builder clients listen for change events?


Clients can register listeners for property changes at a configuration 
and for resets of the builder. Listeners of the latter kind are notified 
when a reload is required, so they can request a new Configuration object.




Is there a separate interface to the Builder to change the configuration
state and fire persist events?


The builder stores the location from which the Configuration was loaded. 
This can be used to persist changes. However, there is not yet a persist 
event. Could you give a use case for such a notification?


Thank you for the feedback!
Oliver



Thanks,
chas

On 10/11/12 1:09 PM, "Oliver Heger"  wrote:


Hi,

in the last few days I have worked on a new approach for handling
reloading in a more generic and loosely coupled way. To get a better
base for discussion, I created some code (mainly in the reloading and
the new builder packages).

The basic idea is that reloading is no more handled by the Configuration
object, but by a ConfigurationBuilder. Fully initialized configurations
can be obtained from corresponding builder objects.

A new class ReloadingController is responsible for reload operations. It
has a ReloadingDetector for monitoring a specific configuration source.
When a change is detected it just fires an event. The controller has a
method for triggering the check for changes. It has to be called by an
external component whenever a check is to be done. This could be done
for instance by a timer task.

A special reloading builder (ReloadingFileBasedConfigurationBuilder) is
associated with such a controller and receives change notifications. On
receiving an event it is reset so that on next access a new
configuration has to be created.

So when following this approach, for applications a reference to the
builder is more important than a Configuration object. When
configuration data is needed, the Configuration is obtained from the
builder and accessed; this instance will not be changed by a reload
operation. In [1] I have already described the pros and cons of this
approach as I see them.

Feedback is welcome!

Oliver

[1] http://www.mail-archive.com/dev@commons.apache.org/msg33669.html

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GUMP@vmgump]: Project commons-dbcp (in module commons-dbcp-1.x) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-dbcp has an issue affecting its community integration.
This issue affects 18 projects,
 and has been outstanding for 127 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbcp :  Object Pooling
- db-ddlutils :  Easy-to-use component for working with Database Definition 
(...
- jakarta-tomcat-4.0 :  Servlet 2.3 and JSP 1.2 Reference Implementation
- jakarta-tomcat-catalina :  Servlet 2.4 Reference Implementation
- jakarta-tomcat-dbcp :  Servlet 2.4 and JSP 2.0 Reference Implementation
- jakarta-tomcat-jk :  Connectors to various web servers
- javax.el :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...
- javax.servlet :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation 
(for ...
- javax.servlet.jsp :  Java Servlet 2.5 & Server Pages JSP 2.1 
implementation (for ...
- solr :  Java Based Search Engine
- solr-test :  Java Based Search Engine
- tomcat-tc6 :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...
- tomcat-tc7.0.x :  Tomcat 7.x, a web server implementing Java Servlet 3.0,
...
- tomcat-tc7.0.x-dbcp :  Tomcat 7.x, a web server implementing Java Servlet 
3.0,
...
- tomcat-tc7.0.x-test :  Tomcat 7.x, a web server implementing Java Servlet 
3.0,
...
- tomcat-trunk :  Tomcat 8.x, a web server implementing Java Servlet 3.1,
...
- tomcat-trunk-dbcp :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...
- tomcat-trunk-test :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/commons-dbcp-1.x/commons-dbcp/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-dbcp.jar] identifier set to project name
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/commons-dbcp-1.x/commons-dbcp/gump_work/build_commons-dbcp-1.x_commons-dbcp.html
Work Name: build_commons-dbcp-1.x_commons-dbcp (Type: Build)
Work ended in a state of : Failed
Elapsed: 8 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
dist 
[Working Directory: /srv/gump/public/workspace/commons-dbcp-1.x]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/junit/dist/junit-13102012.jar:/srv/gump/public/workspace/junit/dist/junit-dep-13102012.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar:/srv/gump/public/workspace/commons-pool-1.x/dist/commons-pool-1.6.1-SNAPSHOT.jar
-
[javac]^
[javac]   where T is a type-variable:
[javac] T extends Object declared in method 
getObject(String,Class)
[javac] 
/srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingConnection.java:65:
 error: DelegatingConnection is not abstract and does not override abstract 
method getNetworkTimeout() in Connection
[javac] public class DelegatingConnection extends AbandonedTrace
[javac]^
[javac] 
/srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java:38:
 error: DelegatingDatabaseMetaData is not abstract and does not override 
abstract method generatedKeyAlwaysReturned() in DatabaseMetaData
[javac] public class DelegatingDatabaseMetaData extends AbandonedTrace
[javac]^
[javac] 
/srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:61:
 error: DelegatingResultSet is not abstract and does not override abstract 
method getObject(String,Class) in ResultSet
[javac] public class DelegatingResultSet extends Aba

[GUMP@vmgump]: Project commons-dbcp2 (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-dbcp2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 127 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbcp2 :  Database Connection Pool


Full details are available at:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbcp2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-dbcp2-*[0-9T].jar] identifier set to project 
name
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbcp2/gump_work/build_apache-commons_commons-dbcp2.html
Work Name: build_apache-commons_commons-dbcp2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 8 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
dist 
[Working Directory: /srv/gump/public/workspace/apache-commons/dbcp]
CLASSPATH: 
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/apache-commons/dbcp/dist/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar:/srv/gump/packages/jdbc2_0/jdbc2_0-stdext.jar:/srv/gump/public/workspace/junit/dist/junit-13102012.jar:/srv/gump/public/workspace/junit/dist/junit-dep-13102012.jar:/srv/gump/public/workspace/apache-commons/pool/dist/commons-pool2-2.0-SNAPSHOT.jar
-
[mkdir] Created dir: 
/srv/gump/public/workspace/apache-commons/dbcp/build/classes
[javac] Compiling 52 source files to 
/srv/gump/public/workspace/apache-commons/dbcp/build/classes
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/BasicDataSource.java:52:
 error: BasicDataSource is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource
[javac] public class BasicDataSource implements DataSource {
[javac]^
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingConnection.java:65:
 error: DelegatingConnection is not abstract and does not override abstract 
method getNetworkTimeout() in Connection
[javac] public class DelegatingConnection extends AbandonedTrace
[javac]^
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingStatement.java:46:
 error: DelegatingStatement is not abstract and does not override abstract 
method isCloseOnCompletion() in Statement
[javac] public class DelegatingStatement extends AbandonedTrace implements 
Statement {
[javac]^
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java:57:
 error: DelegatingPreparedStatement is not abstract and does not override 
abstract method isCloseOnCompletion() in Statement
[javac] public class DelegatingPreparedStatement extends DelegatingStatement
[javac]^
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java:58:
 error: DelegatingCallableStatement is not abstract and does not override 
abstract method getObject(String,Class) in CallableStatement
[javac] public class DelegatingCallableStatement extends 
DelegatingPreparedStatement
[javac]^
[javac]   where T is a type-variable:
[javac] T extends Object declared in method 
getObject(String,Class)
[javac] 
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingDatabaseMetaData.java:36:
 error: DelegatingDatabaseMetaData is not abstract and does not override 
abstract method generatedKeyAlwaysReturned() in DatabaseMetaData
[javac] public clas

[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-digester3 has an issue affecting its community integration.
This issue affects 2 projects,
 and has been outstanding for 132 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-digester3 :  XML to Java Object Configuration
- commons-digester3-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-digester3/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-digester3-*[0-9T].jar] identifier set to 
project name
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/digester/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/apache-commons/digester/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-digester3/gump_work/build_apache-commons_commons-digester3.html
Work Name: build_apache-commons_commons-digester3 (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 min 1 sec
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/apache-commons/digester/gump_mvn_settings.xml 
package 
[Working Directory: /srv/gump/public/workspace/apache-commons/digester]
M2_HOME: /opt/maven2
-
[INFO] [remote-resources:process {execution: default}]
[INFO] [buildnumber:create {execution: default}]
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor && svn 
--non-interactive info
[INFO] Working directory: 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor
[INFO] Storing buildNumber: ?? at timestamp: 1350100366930
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor && svn 
--non-interactive info
[INFO] Working directory: 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor
[INFO] Storing buildScmBranch: UNKNOWN_BRANCH
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] Copying 2 resources to META-INF
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 5 source files to 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/target/classes
[INFO] [bundle:manifest {execution: bundle-manifest}]
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/src/test/resources
[INFO] Copying 0 resource to META-INF
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 3 source files to 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/target/test-classes
>@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern="rss/channel")
>@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern="rss/channel/image")
>@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern="rss/channel/item")
>
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
[ERROR] error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
[INFO] 2 errors 
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure

error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.a

[GUMP@vmgump]: Project commons-chain2 (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-chain2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 149 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-chain2 :  GoF "Chain of Responsibility" pattern


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-chain2-*[0-9T].jar] identifier set to project 
name
 -DEBUG- Sole pom output [pom.xml] identifier set to project name
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/chain/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/chain/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/gump_work/build_apache-commons_commons-chain2.html
Work Name: build_apache-commons_commons-chain2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 58 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/chain/gump_mvn_settings.xml package 
[Working Directory: /srv/gump/public/workspace/apache-commons/chain]
M2_HOME: /opt/maven2
-
[INFO] Building war: 
/srv/gump/public/workspace/apache-commons/chain/apps/cookbook-examples/target/chain-cookbook-examples-2.0-SNAPSHOT.war
[INFO] 
[INFO] Building Apache Commons Chain :: Distribution Packages
[INFO]task-segment: [package]
[INFO] 
[INFO] snapshot org.apache.commons:commons-chain2-configuration:2.0-SNAPSHOT: 
checking for updates from apache.snapshots
Downloading: 
http://localhost:8192/repo/m2-snapshot-repository/org/apache/commons/commons-chain2-configuration/2.0-SNAPSHOT/commons-chain2-configuration-2.0-SNAPSHOT.pom
[INFO] Unable to find resource 
'org.apache.commons:commons-chain2-configuration:pom:2.0-SNAPSHOT' in 
repository apache.snapshots (http://repository.apache.org/snapshots)
Downloading: 
http://localhost:8192/repo/m2-snapshot-repository/org/apache/commons/commons-chain2-configuration/2.0-SNAPSHOT/commons-chain2-configuration-2.0-SNAPSHOT.jar
[INFO] Unable to find resource 
'org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT' in 
repository apache.snapshots (http://repository.apache.org/snapshots)
[INFO] 
[ERROR] BUILD ERROR
[INFO] 
[INFO] Failed to resolve artifact.

Missing:
--
1) org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT

  Try downloading the file manually from the project website.

  Then, install it using the command: 
  mvn install:install-file -DgroupId=org.apache.commons 
-DartifactId=commons-chain2-configuration -Dversion=2.0-SNAPSHOT 
-Dpackaging=jar -Dfile=/path/to/file

  Alternatively, if you host your own repository you can deploy the file there: 
  mvn deploy:deploy-file -DgroupId=org.apache.commons 
-DartifactId=commons-chain2-configuration -Dversion=2.0-SNAPSHOT 
-Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]

  Path to dependency: 
1) org.apache.commons:commons-chain2:pom:2.0-SNAPSHOT
2) org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT

--
1 required artifact is missing.

for artifact: 
  org.apache.commons:commons-chain2:pom:2.0-SNAPSHOT

from the specified remote repositories:
  gump-central (http://localhost:8192/maven2),
  gump-apache.snapshots (http://localhost:8192/repo/m2-snapshot-repository)



[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] 
[INFO] Total time: 56 seconds
[INFO] Finished at: Sat Oct 13 05:03:09 UTC 2012
[INFO] Final Memory: 113M/241M
[INFO] 
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/rss.xml
- Atom: 
http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/atom

Re: RSS?

2012-10-12 Thread Gary Gregory

It seems like Rome development has staled. Is the library fully baked?

I am going to churn through a lot of data, and I see that Rome still
depends on JDom 1.0, not even 1.1.x (well 1.1.1 in trunk as of >1 year ago)
and I know 2.x has many performance improvement.

Before I fork this baby on my own, I wonder if there is any interest in
having [net] implement some kind of RSS API, or even copying Rome in and
maintaining and growing it it here (it is ASL 2.0).

Thoughts?

Gary

On Fri, Oct 12, 2012 at 7:02 PM, Mark Fortner  wrote:

> Hi Gary,
> I use Rome in my projects.  It supports all of the formats that I need.
>
> Mark
>
>
>
>
> On Fri, Oct 12, 2012 at 2:31 PM, Gary Gregory  >wrote:
>
> > Hi All:
> >
> > We have no RSS code in [net].
> >
> > What do you folks use to do RSS clients?
> >
> > Rome?
> >
> > --
> > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> > JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> > Spring Batch in Action: http://bit.ly/bqpbCK
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
Spring Batch in Action: http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-proxy-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 132 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-proxy-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -WARNING- Overriding Maven settings: 
[/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml]
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/proxy/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/proxy/target/surefire-reports



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/gump_work/build_apache-commons_commons-proxy-test.html
Work Name: build_apache-commons_commons-proxy-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 16 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml test 
[Working Directory: /srv/gump/public/workspace/apache-commons/proxy]
M2_HOME: /opt/maven2
-
Running org.apache.commons.proxy.provider.TestBeanProvider
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.02 sec

Results :

Tests in error: 
  
testMethodInvocationImplementation(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  
testSerialization(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  
testMethodInterception(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  testInvalidHandlerName(org.apache.commons.proxy.invoker.TestXmlRpcInvoker)
  
testMethodInvocation(org.apache.commons.proxy.invoker.TestInvocationHandlerAdapter)
  testCreateNullObject(org.apache.commons.proxy.TestProxyUtils)
  testCreateNullObjectWithClassLoader(org.apache.commons.proxy.TestProxyUtils)
  
testInterceptorEquals(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerEquals(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorWithSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerWithSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testProxiesWithClashingFinalMethodInSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorHashCode(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerHashCode(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testBooleanInterceptorParameter(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testChangingArguments(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testCreateInterceptorProxy(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptingProxyClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptingProxySerializable(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorProxyWithCheckedException(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorProxyWithUncheckedException(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxy(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxyClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxySerializable(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationDuplicateMethods(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationImplementation(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testWithNonAccessibleTargetType(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)

Tests run: 179, Failures: 0, Errors: 28, Skipped: 0

[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] There are tes

[GUMP@vmgump]: Project commons-dbutils (in module apache-commons) failed

2012-10-12 Thread Gump

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-dbutils has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 127 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbutils :  Commons DbUtils


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-dbutils/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-dbutils-*[0-9T].jar] identifier set to 
project name
 -INFO- Optional dependency mockito failed with reason build failed
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/dbutils/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/dbutils/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/dbutils/target/surefire-reports
 -WARNING- No directory 
[/srv/gump/public/workspace/apache-commons/dbutils/target/surefire-reports]
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbutils/gump_work/build_apache-commons_commons-dbutils.html
Work Name: build_apache-commons_commons-dbutils (Type: Build)
Work ended in a state of : Failed
Elapsed: 14 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/dbutils/gump_mvn_settings.xml package 
[Working Directory: /srv/gump/public/workspace/apache-commons/dbutils]
M2_HOME: /opt/maven2
-
1K downloaded  (mockito-core-1.9.0.pom)
Downloading: 
http://localhost:8192/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.pom
479b downloaded  (hamcrest-all-1.1.pom)
Downloading: 
http://localhost:8192/maven2/org/mockito/mockito-core/1.9.0/mockito-core-1.9.0.jar
Downloading: 
http://localhost:8192/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.jar
273K downloaded  (hamcrest-all-1.1.jar)
1381K downloaded  (mockito-core-1.9.0.jar)
[INFO] [antrun:run {execution: javadoc.resources}]
[INFO] Executing tasks

main:
 [copy] Copying 2 files to 
/srv/gump/public/workspace/apache-commons/dbutils/target/apidocs/META-INF
[INFO] Executed tasks
[WARNING] The parameter expression: 'project.build.resources' used in mojo: 
'process' has been deprecated. Use 'project.resources' instead.
[INFO] [remote-resources:process {execution: default}]
[INFO] [buildnumber:create {execution: default}]
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/dbutils && svn --non-interactive info
[INFO] Working directory: /srv/gump/public/workspace/apache-commons/dbutils
[INFO] Storing buildNumber: ?? at timestamp: 1350106757673
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/dbutils && svn --non-interactive info
[INFO] Working directory: /srv/gump/public/workspace/apache-commons/dbutils
[INFO] Storing buildScmBranch: UNKNOWN_BRANCH
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/apache-commons/dbutils/src/main/resources
[INFO] Copying 2 resources to META-INF
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 29 source files to 
/srv/gump/public/workspace/apache-commons/dbutils/target/classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/srv/gump/public/workspace/apache-commons/dbutils/src/main/java/org/apache/commons/dbutils/DbUtils.java:[334,25]
 error: DriverProxy is not abstract and does not override abstract method 
getParentLogger() in Driver
[INFO] 1 error
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
/srv/gump/public/workspace/apache-commons/dbutils/src/main/java/org/apache/commons/dbutils/DbUtils.java:[334,25]
 error: DriverProxy is not abstract and does not override abstract method 
getParentLogger() in Driver

[INFO] 
[INFO] For more information, run Mav

Re: RSS?

2012-10-12 Thread Maurizio Cucchiara

I have used digester in the past [1] and a sun implementation (but IIRC
there was some licence issue)

[1] http://commons.apache.org/digester/commons-digester-2.1/annotations.html

Sent from my mobile device, so please excuse typos and brevity.

Maurizio Cucchiara
Il giorno 13/ott/2012 07.12, "Gary Gregory"  ha
scritto:

> It seems like Rome development has staled. Is the library fully baked?
>
> I am going to churn through a lot of data, and I see that Rome still
> depends on JDom 1.0, not even 1.1.x (well 1.1.1 in trunk as of >1 year ago)
> and I know 2.x has many performance improvement.
>
> Before I fork this baby on my own, I wonder if there is any interest in
> having [net] implement some kind of RSS API, or even copying Rome in and
> maintaining and growing it it here (it is ASL 2.0).
>
> Thoughts?
>
> Gary
>
> On Fri, Oct 12, 2012 at 7:02 PM, Mark Fortner  wrote:
>
> > Hi Gary,
> > I use Rome in my projects.  It supports all of the formats that I need.
> >
> > Mark
> >
> >
> >
> >
> > On Fri, Oct 12, 2012 at 2:31 PM, Gary Gregory  > >wrote:
> >
> > > Hi All:
> > >
> > > We have no RSS code in [net].
> > >
> > > What do you folks use to do RSS clients?
> > >
> > > Rome?
> > >
> > > --
> > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> > > JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> > > Spring Batch in Action: http://bit.ly/bqpbCK
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> > >
> >
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>

[GUMP@vmgump]: Project commons-dbcp (in module commons-dbcp-1.x) failed

[GUMP@vmgump]: Project commons-dbcp2 (in module apache-commons) failed

[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed

[GUMP@vmgump]: Project commons-chain2 (in module apache-commons) failed

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

[GUMP@vmgump]: Project commons-dbutils (in module apache-commons) failed

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

Re: svn commit: r1397556 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

Re: svn commit: r1397556 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

[GUMP@vmgump]: Project commons-vfs2-test (in module apache-commons) failed

[RESULT][VOTE] Apache Commons as Sponsor for BeanShell in Incubator

Re: svn commit: r1397534 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed

[GUMP@vmgump]: Project commons-jelly-tags-sql (in module commons-jelly) failed

Re: [configuration] POC new reloading approach

[GUMP@vmgump]: Project commons-dbcp (in module commons-dbcp-1.x) failed

[GUMP@vmgump]: Project commons-dbcp2 (in module apache-commons) failed

[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed

[GUMP@vmgump]: Project commons-chain2 (in module apache-commons) failed

Re: RSS?

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

[GUMP@vmgump]: Project commons-dbutils (in module apache-commons) failed

Re: RSS?

29 matches

Site Navigation

Mail list logo

Footer information