Re: [PR] vm,metrics: note about behaviour across hypervisors [cloudstack-documentation]

2024-07-18 Thread via GitHub


blueorangutan commented on PR #413:
URL: 
https://github.com/apache/cloudstack-documentation/pull/413#issuecomment-2238067178

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/413. 
(QA-JID 244)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] vm,metrics: note about behaviour across hypervisors [cloudstack-documentation]

2024-07-18 Thread via GitHub


sureshanaparti merged PR #413:
URL: https://github.com/apache/cloudstack-documentation/pull/413


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add section about Domain VPCs [cloudstack-documentation]

2024-07-18 Thread via GitHub


kiranchavala commented on code in PR #410:
URL: 
https://github.com/apache/cloudstack-documentation/pull/410#discussion_r1683857518


##
source/adminguide/networking/virtual_private_cloud_config.rst:
##
@@ -1444,6 +1444,26 @@ Editing, Restarting, and Removing a Virtual Private Cloud
|restart-vpc.png|
 
 
+Working with Domain VPCs
+
+
+The functionality of domain VPCs allows operators to aggregate multiple
+tiers from distinct users on the same VPC, reducing the number of virtual
+routers necessary in the environment, and consequently, decreasing the
+amount of public IP addresses consumed. All tiers added to the VPC share
+the same VR, but each one has their own broadcast domain and features
+implemented by the VPC, such as DHCP, NAT, and so on.
+
+In order to utilize this functionality, a new tier must be included to an
+existing VPC by inputing the respective data for the account and the VPC
+on the **'createNetwork'** API. It is important to note that, in order
+for a tier of a different account to be created on the VPC, the account
+that creates the tier must have access to both the account that owns the
+VPC and the account that owns the tier. The owner of the VPC must also
+have access to the account that owns the network, however, the opposite

Review Comment:
   @GaOrtiga could you please change it to network tiers as in vpc UI and docs 
we are referring it as network-tier



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add section about Domain VPCs [cloudstack-documentation]

2024-07-19 Thread via GitHub


DaanHoogland commented on code in PR #410:
URL: 
https://github.com/apache/cloudstack-documentation/pull/410#discussion_r1683950582


##
source/adminguide/networking/virtual_private_cloud_config.rst:
##
@@ -1444,6 +1444,26 @@ Editing, Restarting, and Removing a Virtual Private Cloud
|restart-vpc.png|
 
 
+Working with Domain VPCs
+
+
+The functionality of domain VPCs allows operators to aggregate multiple
+tiers from distinct users on the same VPC, reducing the number of virtual
+routers necessary in the environment, and consequently, decreasing the
+amount of public IP addresses consumed. All tiers added to the VPC share
+the same VR, but each one has their own broadcast domain and features
+implemented by the VPC, such as DHCP, NAT, and so on.
+
+In order to utilize this functionality, a new tier must be included to an
+existing VPC by inputing the respective data for the account and the VPC
+on the **'createNetwork'** API. It is important to note that, in order
+for a tier of a different account to be created on the VPC, the account
+that creates the tier must have access to both the account that owns the
+VPC and the account that owns the tier. The owner of the VPC must also
+have access to the account that owns the network, however, the opposite

Review Comment:
   I think if it is clear that we are constantly talking about network-tier, I 
don't think we need an extra example. But please avoid the use of either 
"network" and possible "tier". We are not writing proza and though prozaic 
value is never wrong, in this case it may be somewhat confusing indeed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add section about Domain VPCs [cloudstack-documentation]

2024-07-19 Thread via GitHub


sureshanaparti commented on PR #410:
URL: 
https://github.com/apache/cloudstack-documentation/pull/410#issuecomment-2238462764

   ping @GaOrtiga  can you check/address the outstanding comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] 4.19.1.0 release notes updates [cloudstack-documentation]

2024-07-19 Thread via GitHub


sureshanaparti opened a new pull request, #415:
URL: https://github.com/apache/cloudstack-documentation/pull/415

   4.19.1.0 release notes updates


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] 4.19.1.0 release notes updates [cloudstack-documentation]

2024-07-19 Thread via GitHub


sureshanaparti commented on PR #415:
URL: 
https://github.com/apache/cloudstack-documentation/pull/415#issuecomment-2238795135

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] 4.19.1.0 release notes updates [cloudstack-documentation]

2024-07-19 Thread via GitHub


blueorangutan commented on PR #415:
URL: 
https://github.com/apache/cloudstack-documentation/pull/415#issuecomment-2238797029

   @sureshanaparti a Jenkins job has been kicked to build the document. I'll 
keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] 4.19.1.0 release notes updates [cloudstack-documentation]

2024-07-19 Thread via GitHub


blueorangutan commented on PR #415:
URL: 
https://github.com/apache/cloudstack-documentation/pull/415#issuecomment-2238798731

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/415. 
(QA-JID 245)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] 4.19.1.0 release notes updates [cloudstack-documentation]

2024-07-19 Thread via GitHub


sureshanaparti merged PR #415:
URL: https://github.com/apache/cloudstack-documentation/pull/415


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add section about Domain VPCs [cloudstack-documentation]

2024-07-19 Thread via GitHub


GaOrtiga commented on PR #410:
URL: 
https://github.com/apache/cloudstack-documentation/pull/410#issuecomment-2239224752

   @DaanHoogland @kiranchavala @sureshanaparti 
   
   Thank you for the reviews, I have changed all mentions of `tiers` or 
`network` to `Network Tiers`.
   
   Are there any other concerns regarding the text?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] work on expanding Quota api [cloudstack-go]

2024-07-22 Thread via GitHub


tonymmm1 opened a new pull request, #90:
URL: https://github.com/apache/cloudstack-go/pull/90

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub


nvazquez commented on code in PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686667880


##
cloudstack_loadbalancer.go:
##
@@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId 
string, publicPort int, pr
return true, err
 }
 
+func (lb *loadBalancer) updateNetworkACL(publicPort int, protocol 
LoadBalancerProtocol, networkId string) (bool, error) {
+   network, _, err := lb.Network.GetNetworkByID(networkId)
+   if err != nil {
+   return false, fmt.Errorf("error fetching Network with ID: %v, 
due to: %s", networkId, err)
+   }
+
+   // create ACL rule
+   acl := lb.NetworkACL.NewCreateNetworkACLParams(protocol.CSProtocol())
+   acl.SetAclid(network.Aclid)
+   acl.SetAction("Allow")

Review Comment:
   Can you make these values parametrized? (action, cidr, trafficType) - it 
looks like you currently want them for adding the default ACL allow but it can 
be reused later if parameters are used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub


nvazquez commented on code in PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686667880


##
cloudstack_loadbalancer.go:
##
@@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId 
string, publicPort int, pr
return true, err
 }
 
+func (lb *loadBalancer) updateNetworkACL(publicPort int, protocol 
LoadBalancerProtocol, networkId string) (bool, error) {
+   network, _, err := lb.Network.GetNetworkByID(networkId)
+   if err != nil {
+   return false, fmt.Errorf("error fetching Network with ID: %v, 
due to: %s", networkId, err)
+   }
+
+   // create ACL rule
+   acl := lb.NetworkACL.NewCreateNetworkACLParams(protocol.CSProtocol())
+   acl.SetAclid(network.Aclid)
+   acl.SetAction("Allow")

Review Comment:
   Can you make these values parametrized? (action, cird, trafficType) - it 
looks like you currently want them for adding the default ACL allow but it can 
be reused later if parameters are used



##
cloudstack_loadbalancer.go:
##
@@ -299,9 +320,29 @@ func (cs *CSCloud) EnsureLoadBalancerDeleted(ctx 
context.Context, clusterName st
if err != nil {
klog.Errorf("Error parsing port: %v", err)
} else {
-   _, err = 
lb.deleteFirewallRule(lbRule.Publicipid, int(port), protocol)
+   networkId, err := 
cs.getNetworkIDFromIPAddress(lb.ipAddrID)
if err != nil {
-   klog.Errorf("Error deleting firewall 
rule: %v", err)
+   return err
+   }
+   network, count, err := 
lb.Network.GetNetworkByID(networkId, cloudstack.WithProject(lb.projectID))
+   if err != nil {
+   if count == 0 {
+   klog.Errorf("No network found")

Review Comment:
   Minor one: can you also add the network ID on the message?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub


Pearl1594 commented on code in PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686689894


##
cloudstack_loadbalancer.go:
##
@@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId 
string, publicPort int, pr
return true, err
 }
 
+func (lb *loadBalancer) updateNetworkACL(publicPort int, protocol 
LoadBalancerProtocol, networkId string) (bool, error) {
+   network, _, err := lb.Network.GetNetworkByID(networkId)
+   if err != nil {
+   return false, fmt.Errorf("error fetching Network with ID: %v, 
due to: %s", networkId, err)
+   }
+
+   // create ACL rule
+   acl := lb.NetworkACL.NewCreateNetworkACLParams(protocol.CSProtocol())
+   acl.SetAclid(network.Aclid)
+   acl.SetAction("Allow")

Review Comment:
   ideally should be required. Because, these rules correspond to the LB 
service created when on Kubernetes side. So these would ideally be fixed to 
action: "allow" and traffictype: "Ingress"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub


Pearl1594 commented on code in PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686689894


##
cloudstack_loadbalancer.go:
##
@@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId 
string, publicPort int, pr
return true, err
 }
 
+func (lb *loadBalancer) updateNetworkACL(publicPort int, protocol 
LoadBalancerProtocol, networkId string) (bool, error) {
+   network, _, err := lb.Network.GetNetworkByID(networkId)
+   if err != nil {
+   return false, fmt.Errorf("error fetching Network with ID: %v, 
due to: %s", networkId, err)
+   }
+
+   // create ACL rule
+   acl := lb.NetworkACL.NewCreateNetworkACLParams(protocol.CSProtocol())
+   acl.SetAclid(network.Aclid)
+   acl.SetAction("Allow")

Review Comment:
   ideally should not be required. Because, these rules correspond to the LB 
service created on Kubernetes side. So these would ideally be fixed to action: 
"allow" and traffictype: "Ingress"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub


weizhouapache commented on code in PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686729279


##
cloudstack_loadbalancer.go:
##
@@ -828,6 +913,42 @@ func (lb *loadBalancer) deleteFirewallRule(publicIpId 
string, publicPort int, pr
return deleted, err
 }
 
+// Delete Network ACLs deletes the Network ACL rule associated with the 
ip:port:protocol combo
+func (lb *loadBalancer) deleteNetworkACLRule(publicPort int, protocol 
LoadBalancerProtocol, networkID string) (bool, error) {
+   p := lb.NetworkACL.NewListNetworkACLsParams()
+   p.SetListall(true)
+   p.SetNetworkid(networkID)
+   if lb.projectID != "" {
+   p.SetProjectid(lb.projectID)
+   }
+
+   r, err := lb.NetworkACL.ListNetworkACLs(p)
+   if err != nil {
+   return false, fmt.Errorf("error fetching Network ACL rules 
Network ID %v: %v", networkID, err)
+   }
+
+   // filter by proto:port
+   filtered := make([]*cloudstack.NetworkACL, 0, 1)
+   for _, rule := range r.NetworkACLs {
+   if rule.Protocol == protocol.IPProtocol() && rule.Startport == 
strconv.Itoa(publicPort) && rule.Endport == strconv.Itoa(publicPort) {
+   filtered = append(filtered, rule)
+   }
+   }
+
+   // delete all rules
+   deleted := false
+   ruleToBeDeleted := filtered[0]

Review Comment:
   is it possible that this throws a out-of-bound exception, if `filtered` is 
empty ?



##
cloudstack_loadbalancer.go:
##
@@ -828,6 +913,42 @@ func (lb *loadBalancer) deleteFirewallRule(publicIpId 
string, publicPort int, pr
return deleted, err
 }
 
+// Delete Network ACLs deletes the Network ACL rule associated with the 
ip:port:protocol combo
+func (lb *loadBalancer) deleteNetworkACLRule(publicPort int, protocol 
LoadBalancerProtocol, networkID string) (bool, error) {
+   p := lb.NetworkACL.NewListNetworkACLsParams()
+   p.SetListall(true)
+   p.SetNetworkid(networkID)
+   if lb.projectID != "" {
+   p.SetProjectid(lb.projectID)
+   }
+
+   r, err := lb.NetworkACL.ListNetworkACLs(p)
+   if err != nil {
+   return false, fmt.Errorf("error fetching Network ACL rules 
Network ID %v: %v", networkID, err)
+   }
+
+   // filter by proto:port
+   filtered := make([]*cloudstack.NetworkACL, 0, 1)
+   for _, rule := range r.NetworkACLs {
+   if rule.Protocol == protocol.IPProtocol() && rule.Startport == 
strconv.Itoa(publicPort) && rule.Endport == strconv.Itoa(publicPort) {
+   filtered = append(filtered, rule)
+   }
+   }
+
+   // delete all rules

Review Comment:
   delete the first filtered rule ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub


Pearl1594 commented on code in PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686748302


##
cloudstack_loadbalancer.go:
##
@@ -828,6 +913,42 @@ func (lb *loadBalancer) deleteFirewallRule(publicIpId 
string, publicPort int, pr
return deleted, err
 }
 
+// Delete Network ACLs deletes the Network ACL rule associated with the 
ip:port:protocol combo
+func (lb *loadBalancer) deleteNetworkACLRule(publicPort int, protocol 
LoadBalancerProtocol, networkID string) (bool, error) {
+   p := lb.NetworkACL.NewListNetworkACLsParams()
+   p.SetListall(true)
+   p.SetNetworkid(networkID)
+   if lb.projectID != "" {
+   p.SetProjectid(lb.projectID)
+   }
+
+   r, err := lb.NetworkACL.ListNetworkACLs(p)
+   if err != nil {
+   return false, fmt.Errorf("error fetching Network ACL rules 
Network ID %v: %v", networkID, err)
+   }
+
+   // filter by proto:port
+   filtered := make([]*cloudstack.NetworkACL, 0, 1)
+   for _, rule := range r.NetworkACLs {
+   if rule.Protocol == protocol.IPProtocol() && rule.Startport == 
strconv.Itoa(publicPort) && rule.Endport == strconv.Itoa(publicPort) {
+   filtered = append(filtered, rule)
+   }
+   }
+
+   // delete all rules
+   deleted := false
+   ruleToBeDeleted := filtered[0]

Review Comment:
   addressed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] work on expanding Quota api [cloudstack-go]

2024-07-22 Thread via GitHub


tonymmm1 commented on PR #90:
URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2243989711

   Requesting a review if any mistakes/issues in implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-23 Thread via GitHub


nvazquez commented on code in PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1688116891


##
cloudstack_loadbalancer.go:
##
@@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId 
string, publicPort int, pr
return true, err
 }
 
+func (lb *loadBalancer) updateNetworkACL(publicPort int, protocol 
LoadBalancerProtocol, networkId string) (bool, error) {
+   network, _, err := lb.Network.GetNetworkByID(networkId)
+   if err != nil {
+   return false, fmt.Errorf("error fetching Network with ID: %v, 
due to: %s", networkId, err)
+   }
+
+   // create ACL rule
+   acl := lb.NetworkACL.NewCreateNetworkACLParams(protocol.CSProtocol())
+   acl.SetAclid(network.Aclid)
+   acl.SetAction("Allow")

Review Comment:
   Ok, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] work on expanding Quota api [cloudstack-go]

2024-07-23 Thread via GitHub


tonymmm1 commented on PR #90:
URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246638950

   I noticed that the listApis.json was missing the api functions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] work on expanding Quota api [cloudstack-go]

2024-07-23 Thread via GitHub


tonymmm1 commented on PR #90:
URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246696439

   quotaUpdate that was generated has additional response fields in the struct 
when the documentation states it should only show "updated_on".
   
   ```
   type QuotaUpdateResponse struct {
JobID  string `json:"jobid"`
Jobstatus  int`json:"jobstatus"`
Updated_on string `json:"updated_on"`
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] update listApis.json and update Quota API [cloudstack-go]

2024-07-23 Thread via GitHub


tonymmm1 commented on PR #90:
URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246719750

   ```user@linux make mocks
   user1@s1-desktopt1 go test -v ./...
   # github.com/apache/cloudstack-go/v2/cloudstack
   cloudstack/QuotaService.go:235:5: v declared and not used
   cloudstack/QuotaService.go:241:5: v declared and not used
   cloudstack/QuotaService.go:849:5: v declared and not used
   cloudstack/QuotaService.go:1418:5: v declared and not used
   FAILgithub.com/apache/cloudstack-go/v2/cloudstack [build failed]
   FAILgithub.com/apache/cloudstack-go/v2/examples [build failed]
   ?   github.com/apache/cloudstack-go/v2/generate [no test files]
   FAILgithub.com/apache/cloudstack-go/v2/test [build failed]
   FAIL
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] update listApis.json and update Quota API [cloudstack-go]

2024-07-23 Thread via GitHub


tonymmm1 commented on PR #90:
URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246736045

   seems to be an issue with generator.go on double types


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] update listApis.json and update Quota API [cloudstack-go]

2024-07-23 Thread via GitHub


tonymmm1 commented on PR #90:
URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246743626

   Fixed the double/float type generation.
   
   ```Running Suite: Encoding Suite - /home/user1/git/cloudstack-go/test
   ==
   Random Seed: 1721788077
   
   Will run 4 of 4 specs
   
   
   Ran 4 of 4 Specs in 0.000 seconds
   SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 0 Skipped
   --- PASS: TestEncodeValues (0.00s)
   === RUN   TestUUID
   --- PASS: TestUUID (0.00s)
   PASS
   ok  github.com/apache/cloudstack-go/v2/test 0.044s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] system vm destroy behaviour [cloudstack-documentation]

2024-07-23 Thread via GitHub


rajujith opened a new pull request, #416:
URL: https://github.com/apache/cloudstack-documentation/pull/416

   Adding a note on how system vm expunging is handled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Added missing file for oauth 2.0 [cloudstack-documentation]

2024-07-24 Thread via GitHub


harikrishna-patnala opened a new pull request, #417:
URL: https://github.com/apache/cloudstack-documentation/pull/417

   In the OAuth documentation, registration image is missing 
   
   
https://docs.cloudstack.apache.org/en/4.19.1.0/adminguide/accounts.html#using-oauth2-authentication-for-users
   
   ![Screenshot 2024-07-24 at 4 26 14 
PM](https://github.com/user-attachments/assets/ecd10bec-f2df-4c21-88b9-6cfe40a39d82)
   
   Added that file in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added missing file for oauth 2.0 [cloudstack-documentation]

2024-07-24 Thread via GitHub


harikrishna-patnala commented on PR #417:
URL: 
https://github.com/apache/cloudstack-documentation/pull/417#issuecomment-2247605819

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added missing file for oauth 2.0 [cloudstack-documentation]

2024-07-24 Thread via GitHub


blueorangutan commented on PR #417:
URL: 
https://github.com/apache/cloudstack-documentation/pull/417#issuecomment-2247607742

   @harikrishna-patnala a Jenkins job has been kicked to build the document. 
I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added missing file for oauth 2.0 [cloudstack-documentation]

2024-07-24 Thread via GitHub


blueorangutan commented on PR #417:
URL: 
https://github.com/apache/cloudstack-documentation/pull/417#issuecomment-2247609647

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/417. 
(QA-JID 246)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added missing file for oauth 2.0 [cloudstack-documentation]

2024-07-24 Thread via GitHub


harikrishna-patnala commented on PR #417:
URL: 
https://github.com/apache/cloudstack-documentation/pull/417#issuecomment-2247614590

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added missing file for oauth 2.0 [cloudstack-documentation]

2024-07-24 Thread via GitHub


blueorangutan commented on PR #417:
URL: 
https://github.com/apache/cloudstack-documentation/pull/417#issuecomment-2247615323

   @harikrishna-patnala a Jenkins job has been kicked to build the document. 
I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added missing file for oauth 2.0 [cloudstack-documentation]

2024-07-24 Thread via GitHub


blueorangutan commented on PR #417:
URL: 
https://github.com/apache/cloudstack-documentation/pull/417#issuecomment-2247617081

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/417. 
(QA-JID 247)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-07-24 Thread via GitHub


CodeBleu commented on PR #113:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2248687105

   > @fabiomatavelli @CodeBleu since we recently had a TF release, the next one 
we can target for Q3/Q4 this year. If you're blocked then let us know, 
otherwise due to our $dayjobs and other community work (the release work for 
example), our engagement and responses may be delayed.
   
   CC @kiranchavala @vishesh92 
   
   With the release of Cloudstack 4.19.1 now out, I'm hoping we can get this PR 
across the line.  I feel like this should be just a matter of clicking the 
"merge" button, as there have been a lot of back and forth on this one and the 
last concern about it, had that piece removed to make it easier to proceed with 
merging this.
   
   I think this PR for the new plugin framework is a pretty important one to 
get merged in, so that efforts can be made to start porting all of the data and 
resources over to the new framework.
   
   I appreciate all you are doing for the community and know your busy, but 
thought it was worth getting this one merged.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-07-24 Thread via GitHub


rohityadavcloud commented on PR #113:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2249362878

   Fine by me, but since I'm less of a developer these days - let's wait from 
@vishesh92 and/or @kiranchavala to advise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-07-24 Thread via GitHub


vishesh92 merged PR #113:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-07-24 Thread via GitHub


CodeBleu commented on PR #113:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2249373038

   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Registry 404 error - failed to │ retrieve authentication checksums for provider [cloudstack-terraform-provider]

2024-07-24 Thread via GitHub


ProemSports-Harshit commented on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-2249427673

   I am also facing the same issue while doing `terraform init`.
   
   ```
   Initializing provider plugins...
   - Finding snowplow-devops/snowplow versions matching ">= 0.4.0"...
   - Finding hashicorp/aws versions matching ">= 3.45.0, >= 3.72.0, >= 4.0.0"...
   - Finding hashicorp/random versions matching ">= 3.0.0"...
   - Installing hashicorp/aws v5.59.0...
   - Installed hashicorp/aws v5.59.0 (signed by HashiCorp)
   - Installing hashicorp/random v3.6.2...
   - Installed hashicorp/random v3.6.2 (signed by HashiCorp)
   ╷
   │ Error: Failed to install provider
   │
   │ Error while installing snowplow-devops/snowplow v0.7.3: could not query 
provider registry for
   │ registry.terraform.io/snowplow-devops/snowplow: failed to retrieve 
authentication checksums for provider: the request 
   │ failed after 2 attempts, please try again later
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Registry 404 error - failed to │ retrieve authentication checksums for provider [cloudstack-terraform-provider]

2024-07-24 Thread via GitHub


ProemSports-Harshit commented on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-2249465323

   From past 2 days, I was facing this issue. Changing the network to my mobile 
hotspots fix this issue. It look like my previous network has some network 
restriction


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] update listApis.json, Quota API, and fixed double url value handling [cloudstack-go]

2024-07-27 Thread via GitHub


tonymmm1 commented on PR #90:
URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2254195056

   As of cloudstack 14.19.0.2 it seems like the quotaBalance response object 
does not match listApis.json from cmk-cli.
   
   
   Is the object I am receiving from cloudstack api.
   
   ```
   {
 "quotabalanceresponse": {
   "balance": {
 "startquota": 0,
 "credits": [],
 "startdate": "2024-07-27T11:32:15-0500",
 "currency": "$"
   }
 }
   }
   ```
   
   Is the generated type.
   
   ```
   type QuotaBalance struct {
Account   string  `json:"account"`
Accountid int64   `json:"accountid"`
Domainint64   `json:"domain"`
JobID string  `json:"jobid"`
Jobstatus int `json:"jobstatus"`
Name  string  `json:"name"`
Quota float64 `json:"quota"`
Type  int `json:"type"`
Unit  string  `json:"unit"`
   }
   ```
   
   There seems to be no correlation between these types?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] update listApis.json, Quota API, and fixed double url value handling [cloudstack-go]

2024-07-27 Thread via GitHub


tonymmm1 commented on PR #90:
URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2254212671

   Implemented overrides for quotaBalance and quotaStatement that should work. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-29 Thread via GitHub


Pearl1594 commented on PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#issuecomment-2255697209

   @kiranchavala I don't think the issue is wrt to this PR, but in general 
there's an issue with vmware. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] ci: update terraform, opentofu and cloudstack versions [cloudstack-terraform-provider]

2024-07-30 Thread via GitHub


rohityadavcloud merged PR #130:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] ci: update terraform, opentofu and cloudstack versions [cloudstack-terraform-provider]

2024-07-30 Thread via GitHub


rohityadavcloud commented on PR #130:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/130#issuecomment-2257641298

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes #117 - Allow Multiple SSH Keypairs [cloudstack-terraform-provider]

2024-07-30 Thread via GitHub


rohityadavcloud merged PR #122:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/122


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Allow multiple SSH Keypairs [cloudstack-terraform-provider]

2024-07-30 Thread via GitHub


rohityadavcloud closed issue #117: Allow multiple SSH Keypairs
URL: https://github.com/apache/cloudstack-terraform-provider/issues/117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix: remove user-data conditional size [cloudstack-terraform-provider]

2024-07-30 Thread via GitHub


rohityadavcloud merged PR #121:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-31 Thread via GitHub


nvazquez commented on PR #69:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#issuecomment-2260460474

   LGTM - thanks @Pearl1594 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-31 Thread via GitHub


nvazquez merged PR #69:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/69


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Update image tag [cloudstack-kubernetes-provider]

2024-07-31 Thread via GitHub


Pearl1594 opened a new pull request, #71:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/71

   Update  image tag version for intermediate release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Update image tag [cloudstack-kubernetes-provider]

2024-07-31 Thread via GitHub


Pearl1594 closed pull request #71: Update image tag
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] release 1.1.1 for playtika [cloudstack-kubernetes-provider]

2024-07-31 Thread via GitHub


Pearl1594 closed pull request #72: release 1.1.1 for playtika
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/72


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] chore(deps): bump github.com/hashicorp/terraform-plugin-testing from 1.7.0 to 1.9.0 [cloudstack-terraform-provider]

2024-07-31 Thread via GitHub


dependabot[bot] opened a new pull request, #132:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/132

   Bumps 
[github.com/hashicorp/terraform-plugin-testing](https://github.com/hashicorp/terraform-plugin-testing)
 from 1.7.0 to 1.9.0.
   
   Release notes
   Sourced from https://github.com/hashicorp/terraform-plugin-testing/releases";>github.com/hashicorp/terraform-plugin-testing's
 releases.
   
   v1.9.0
   ENHANCEMENTS:
   
   knownvalue: Add Int32Exact check for int32 value testing. 
(https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/356";>#356)
   knownvalue: Add Float32Exact check for float32 value 
testing. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/356";>#356)
   
   v1.8.0
   FEATURES:
   
   plancheck: Added  ExpectDeferredChange and 
ExpectNoDeferredChanges checks for experimental deferred action 
support. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/331";>#331)
   tfversion: Added SkipIfNotPrerelease version check for 
testing experimental features of prerelease Terraform builds. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/331";>#331)
   
   ENHANCEMENTS:
   
   helper/acctest: Improve scope of IPv4/IPv6 random address generation in 
RandIpAddress() (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/305";>#305)
   knownvalue: Add TupleExact, TuplePartial and 
TupleSizeExact checks for dynamic value testing. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/312";>#312)
   tfversion: Ensured Terraform CLI prerelease versions are considered 
semantically equal to patch versions in built-in checks to match the Terraform 
CLI versioning policy (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/303";>#303)
   helper/resource: Added (TestCase).AdditionalCLIOptions with 
AllowDeferral option for plan and apply commands. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/331";>#331)
   
   BUG FIXES:
   
   helper/resource: Fix panic in output state shimming when a tuple is 
present. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/310";>#310)
   tfversion: Fixed RequireBelow ignoring equal versioning to 
fail a test (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/303";>#303)
   
   
   
   
   Changelog
   Sourced from https://github.com/hashicorp/terraform-plugin-testing/blob/main/CHANGELOG.md";>github.com/hashicorp/terraform-plugin-testing's
 changelog.
   
   1.9.0 (July 09, 2024)
   ENHANCEMENTS:
   
   knownvalue: Add Int32Exact check for int32 value testing. 
(https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/356";>#356)
   knownvalue: Add Float32Exact check for float32 value 
testing. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/356";>#356)
   
   1.8.0 (May 17, 2024)
   FEATURES:
   
   plancheck: Added  ExpectDeferredChange and 
ExpectNoDeferredChanges checks for experimental deferred action 
support. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/331";>#331)
   tfversion: Added SkipIfNotPrerelease version check for 
testing experimental features of prerelease Terraform builds. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/331";>#331)
   
   ENHANCEMENTS:
   
   helper/acctest: Improve scope of IPv4/IPv6 random address generation in 
RandIpAddress() (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/305";>#305)
   knownvalue: Add TupleExact, TuplePartial and 
TupleSizeExact checks for dynamic value testing. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/312";>#312)
   tfversion: Ensured Terraform CLI prerelease versions are considered 
semantically equal to patch versions in built-in checks to match the Terraform 
CLI versioning policy (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/303";>#303)
   helper/resource: Added (TestCase).AdditionalCLIOptions with 
AllowDeferral option for plan and apply commands. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/331";>#331)
   
   BUG FIXES:
   
   helper/resource: Fix panic in output state shimming when a tuple is 
present. (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/310";>#310)
   tfversion: Fixed RequireBelow ignoring equal versioning to 
fail a test (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/303";>#303)
   
   
   
   
   Commits
   
   https://github.com/hashicorp/terraform-plugin-testing/commit/5cb292c91e051a588928e0081fc5b09bb64875e0";>5cb292c
 Update changelog
   https://github.com/hashicorp/terraform-plugin-testing/commit/0448ecc770330fcca9372d5f0f068cd4e292d40a";>0448ecc
 build(deps): Bump golang.org/x/crypto from 0.24.0 to 0.25.0 (https://redirect.github.com/hashicorp/terraform-plugin-testing/issues/358";>#358)
   https://github.com/hashicorp/terraform-plugin-te

[PR] added kafaka and rabbitmq info [cloudstack-documentation]

2024-08-01 Thread via GitHub


kiranchavala opened a new pull request, #418:
URL: https://github.com/apache/cloudstack-documentation/pull/418

   Added a example for kafaka configuration  and rabbitmq  routing key 
configuration 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-01 Thread via GitHub


weizhouapache opened a new pull request, #419:
URL: https://github.com/apache/cloudstack-documentation/pull/419

   This is the doc for https://github.com/apache/cloudstack/pull/9470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-04 Thread via GitHub


abh1sar opened a new pull request, #420:
URL: https://github.com/apache/cloudstack-documentation/pull/420

   Documentation PR for https://github.com/apache/cloudstack/pull/9208


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-04 Thread via GitHub


abh1sar commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2267657063

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-04 Thread via GitHub


blueorangutan commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2267657312

   @abh1sar a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-04 Thread via GitHub


blueorangutan commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2267657532

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/420. 
(QA-JID 248)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Document network support for configdrive [cloudstack-documentation]

2024-08-05 Thread via GitHub


vladimirpetrov commented on code in PR #412:
URL: 
https://github.com/apache/cloudstack-documentation/pull/412#discussion_r1703663472


##
source/adminguide/networking/dns_and_dhcp.rst:
##
@@ -17,6 +17,13 @@
 DNS and DHCP
 
 
-The Virtual Router provides DNS and DHCP services to the guests. It
-proxies DNS requests to the DNS server configured on the Availability
-Zone.
+The Virtual Router & ConfigDrive (since Apache CloudStack 4.20) provides
+DNS and DHCP services to the guests. It proxies DNS requests to the DNS
+server configured on the Availability Zone.
+
+.. note::
+   In case of a network with ConfigDrive, adding/removing nic to/from an
+   instance or updating the ip address of a nic will not be reflected in the
+   instance if the instance is already running. To do so, run

Review Comment:
   I was definitely able to see the changes when adding/removing NICs only by 
executing stop/start VM sequence (not restart). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-08 Thread via GitHub


abh1sar commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2276605860

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-08 Thread via GitHub


blueorangutan commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2276607559

   @abh1sar a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-08 Thread via GitHub


blueorangutan commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2276609103

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/420. 
(QA-JID 249)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-09 Thread via GitHub


shwstppr commented on code in PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#discussion_r1711048699


##
source/adminguide/storage.rst:
##
@@ -1381,6 +1381,107 @@ Deleting objects from a bucket
 
 2. Click on the |delete-button.png| button to delete the selected files from 
the bucket.
 
+File Shares
+---
+
+Cloudstack offers fully managed NFS File Shares to all users.
+This section gives technical details on how to create/manage a File Share
+using basic lifecycle operations and also some implementation details.
+
+Creating a New File Share 
+~
+
+#. Log in to the CloudStack UI as a user or administrator.
+
+#. In the left navigation bar, click Storage.
+
+#. In the Select View, choose File Shares.
+
+Click on Create File Share, provide the following details and then click OK.
+
+#. Name
+#. Description
+#. Zone
+#. Format: Filesystem format (XFS, EXT4) which will be installed on the File 
Share.
+#. Network: Guest network to which the File Share will be attached.
+#. Compute offering: Offering using which the File Share VM will be deployed.
+#. Disk offering: Offering used by the underlying data volume.
+#. Size, MinIops and MaxIos: Displayed only when the disk offering takes 
custom size and custom iops.
+
+|create-fileshare.png|
+
+Admins will see extra fields in the create form where they can specify the
+account, domain and the project which will be owning the fileshare.
+|create-fileshare-admin.png|
+
+.. note:: 
+   This feature is available only on advanced zones without security groups.
+
+Access
+~~
+The File Share can be mounted by using the information given on the Access Tab.
+|fileshare-access-tab.png|
+
+Lifecycle Operations 
+
+
+Supported lifecycle operations are :
+
+#. Update File Share's Name and Description

Review Comment:
   ```suggestion
   #. Update name and description of the File Share
   ```



##
source/adminguide/storage.rst:
##
@@ -1381,6 +1381,107 @@ Deleting objects from a bucket
 
 2. Click on the |delete-button.png| button to delete the selected files from 
the bucket.
 
+File Shares
+---
+
+Cloudstack offers fully managed NFS File Shares to all users.

Review Comment:
   ```suggestion
   CloudStack offers fully managed NFS File Shares to all users.
   ```



##
source/conceptsandterminology/concepts.rst:
##
@@ -516,6 +516,16 @@ Users can create buckets within the object storage pool.
 The basic storage units of Object Store are objects. Any type of data, 
regardless of content type, is stored as an object.
 Buckets are logical containers for storing objects.
 
+About File Shares
+~
+Cloudstack users can setup Cloudstack managed NFS File Shares. Users can choose

Review Comment:
   ```suggestion
   CloudStack users can setup CloudStack managed NFS File Shares. Users can 
choose
   ```



##
source/adminguide/storage.rst:
##
@@ -1381,6 +1381,107 @@ Deleting objects from a bucket
 
 2. Click on the |delete-button.png| button to delete the selected files from 
the bucket.
 
+File Shares
+---
+
+Cloudstack offers fully managed NFS File Shares to all users.
+This section gives technical details on how to create/manage a File Share
+using basic lifecycle operations and also some implementation details.
+
+Creating a New File Share 
+~
+
+#. Log in to the CloudStack UI as a user or administrator.
+
+#. In the left navigation bar, click Storage.
+
+#. In the Select View, choose File Shares.
+
+Click on Create File Share, provide the following details and then click OK.
+
+#. Name
+#. Description
+#. Zone
+#. Format: Filesystem format (XFS, EXT4) which will be installed on the File 
Share.
+#. Network: Guest network to which the File Share will be attached.
+#. Compute offering: Offering using which the File Share VM will be deployed.
+#. Disk offering: Offering used by the underlying data volume.
+#. Size, MinIops and MaxIos: Displayed only when the disk offering takes 
custom size and custom iops.
+
+|create-fileshare.png|
+
+Admins will see extra fields in the create form where they can specify the
+account, domain and the project which will be owning the fileshare.
+|create-fileshare-admin.png|
+
+.. note:: 
+   This feature is available only on advanced zones without security groups.

Review Comment:
   should we move this to top for clarity



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Updating security group documentation [cloudstack-documentation]

2024-08-09 Thread via GitHub


rajujith opened a new pull request, #421:
URL: https://github.com/apache/cloudstack-documentation/pull/421

   Correcting the documentation about security groups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-13 Thread via GitHub


abh1sar commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2285683353

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-13 Thread via GitHub


blueorangutan commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2285685439

   @abh1sar a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Documentation for Storage Filesystem as a First Class Feature [cloudstack-documentation]

2024-08-13 Thread via GitHub


blueorangutan commented on PR #420:
URL: 
https://github.com/apache/cloudstack-documentation/pull/420#issuecomment-2285687550

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/420. 
(QA-JID 250)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-14 Thread via GitHub


CodeBleu commented on PR #77:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2289085537

   @fabiomatavelli @rohityadavcloud @poddm  Can we come to an agreement on 
service_offerings between this PR and what @fabiomatavelli had worked on here 
#113  and move forward with one of these solutions?  This is starting to become 
an issue for me to be able to manage service offerings for our customers and 
this would be a huge help to be able to create less offerings because of being 
able to have offerings that are more dynamic to use.
   
   P.S. @rohityadavcloud  I would like to see a new release this quarter (end 
of Aug would be nice :smile: )  What can we do to help move the release of a 
version?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-14 Thread via GitHub


poddm commented on PR #77:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2289153210

   I can remove `cloudstack_disk_offering` to not conflict with the other 
changes.
   
   I'd like to keep the separate types to align the GUI presentation and make 
it easier to understand what fields are required.

   - cloudstack_service_offering_constrained
   - cloudstack_service_offering_unconstrained
   - cloudstack_service_offering_fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Update docs about volume snapshots on KVM [cloudstack-documentation]

2024-08-16 Thread via GitHub


JoaoJandre opened a new pull request, #423:
URL: https://github.com/apache/cloudstack-documentation/pull/423

   Updated the description on how snapshots are created, and added some info on 
incremental snapshots.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-19 Thread via GitHub


shwstppr commented on PR #419:
URL: 
https://github.com/apache/cloudstack-documentation/pull/419#issuecomment-2298072863

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-19 Thread via GitHub


shwstppr commented on code in PR #419:
URL: 
https://github.com/apache/cloudstack-documentation/pull/419#discussion_r1722756161


##
source/adminguide/networking/dynamic_static_routing.rst:
##
@@ -0,0 +1,260 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information#
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+
+
+Dynamic and Static Routing
+-
+
+For VMs on Isolated networks, the IP of VMs are not publicly accessible.
+To access the VMs from the Internet, Users need to create Load balanceing 
rules,
+Port Forwarding rules, enable Static NAT, or enable VPN.
+
+The IPv6 static routing feature has been introduced in Apache CloudStack 
4.17.0.0, so that
+users are able to access the IPv6 address of guest VMs on Isolated networks 
from the Internet or public network.
+For more information, see `“IPv6 support for isolated networks and VPC Network 
Tiers” <../plugins/ipv6.html#isolated-network-and-vpc-network-tier>`_.
+
+From Apache CloudStack 4.20.0.0, users are able to create isolated networks 
and VPCs with ROUTED mode.
+
+- Manage IPv4 subnets for Zones (ROOT admin/operator only)
+- Create Networks with Static Routing for IPv4
+- Manage IPv4 Routing Firewall for Networks
+- Manage AS number and BPG peers for Dynamic Routing (ROOT admin only)
+- Create Networks with Dynamic Routing for IPv4 and IPv6
+
+
+About Network Mode
+~~
+
+Network mode indicates the mode with which the isolated network or VPC will 
operate.
+There are two valid options
+
+- NATTED. This is the default network mode of isolated networks. The VR of 
isolated networks and VPCs provides Source NAT services, as well as Static NAT, 
Load Balancer, Port Forwarding, Vpn if the network offering supports.
+- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports 
Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported 
services are Dns, Dhcp, Userdata, Firewall (for isolated networks) and Network 
ACL (for vpc and vpc networks).
+
+
+About Routing mode
+~~
+
+Routing mode indicates how routing will operate with the isolated networks 
with ROUTED network mode.
+There are two valid options
+
+- Static. The operators need to add the static routes to the isolated networks 
or VPCs in the upstream router manually.
+- Dynamic. The AS number will be automatically allocated, and BGP peer 
sessions will be set up automatically in the VR of the isolated networks or 
VPCs. The operators need to add the AS number ranges and BGP peers for each 
zone before creating network with Dynamic routing mode.
+
+
+Manage IPv4 Subnets for Zone
+~~
+
+Like IPv6 prefixes, operators need to configure the IPv4 subnets for zone, 
which will be eventually used by guest networks.
+
+Supported CloudStack API for operators to manage the IPv4 subnets for zone are:
+
+- **createIpv4SubnetForZone** : create an IPv4 subnet for zone
+- **dedicateIpv4SubnetForZone** : dedicate an IPv4 subnet for zone to a domain 
or an account
+- **deleteIpv4SubnetForZone** : delete an IPv4 subnet for zone
+- **listIpv4SubnetsForZone** : list IPv4 subnets for zone
+- **releaseIpv4SubnetForZone** : release a dedicated IPv4 subnet for zone from 
a domain or an account
+- **updateIpv4SubnetForZone** : update an IPv4 subnet for zone
+
+Operators (root admins) can manage the IPv4 subnets for zone by navigating to 
Infrastructure -> Zones -> IPv4 Subnets
+|manage-ipv4-subnets-for-zone.png|
+
+
+Manage IPv4 Subnets for Guest Networks
+~~
+
+Unlike IPv6 (each isolated network with IPv6 support gets a /64 IPv6 network), 
operators need to manage IPv4 subnets for guest networks.
+An IPv4 subnet for guest networks is created from its parent which is a IPv4 
subnet for zone.
+
+There are some global settings which can be set for each account. See below
+
+.. cssclass:: table-striped table-bordered table-hover
+
+= 
+Configuration   Description
+= 
+routed.ipv4.network.cidr.auto.allocation.enabledwhether the 
auto-allocation of net

Re: [PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-19 Thread via GitHub


blueorangutan commented on PR #419:
URL: 
https://github.com/apache/cloudstack-documentation/pull/419#issuecomment-2298073642

   @shwstppr a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-19 Thread via GitHub


blueorangutan commented on PR #419:
URL: 
https://github.com/apache/cloudstack-documentation/pull/419#issuecomment-2298075197

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/419. 
(QA-JID 251)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-20 Thread via GitHub


weizhouapache commented on code in PR #419:
URL: 
https://github.com/apache/cloudstack-documentation/pull/419#discussion_r1722793752


##
source/adminguide/networking/advanced_zone_config.rst:
##
@@ -64,6 +64,8 @@ configure the base guest Network:
-  **Netmask**: The netmask in use on the subnet the Guest Instances
   will use.
 
+   -  **CIDR Size**: The cidrsize of the subnet the Guest Instances will use. 
The applies on networks with ROUTED mode only.

Review Comment:
   ```suggestion
  -  **CIDR Size**: The cidrsize of the subnet the Guest Instances will 
use. Available only when the selected Network offering supports ROUTED mode.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-20 Thread via GitHub


weizhouapache commented on code in PR #419:
URL: 
https://github.com/apache/cloudstack-documentation/pull/419#discussion_r1722794895


##
source/adminguide/networking/dynamic_static_routing.rst:
##
@@ -0,0 +1,260 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information#
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+
+
+Dynamic and Static Routing
+-
+
+For VMs on Isolated networks, the IP of VMs are not publicly accessible.
+To access the VMs from the Internet, Users need to create Load balanceing 
rules,
+Port Forwarding rules, enable Static NAT, or enable VPN.
+
+The IPv6 static routing feature has been introduced in Apache CloudStack 
4.17.0.0, so that
+users are able to access the IPv6 address of guest VMs on Isolated networks 
from the Internet or public network.
+For more information, see `“IPv6 support for isolated networks and VPC Network 
Tiers” <../plugins/ipv6.html#isolated-network-and-vpc-network-tier>`_.
+
+From Apache CloudStack 4.20.0.0, users are able to create isolated networks 
and VPCs with ROUTED mode.
+
+- Manage IPv4 subnets for Zones (ROOT admin/operator only)
+- Create Networks with Static Routing for IPv4
+- Manage IPv4 Routing Firewall for Networks
+- Manage AS number and BPG peers for Dynamic Routing (ROOT admin only)
+- Create Networks with Dynamic Routing for IPv4 and IPv6
+
+
+About Network Mode
+~~
+
+Network mode indicates the mode with which the isolated network or VPC will 
operate.
+There are two valid options
+
+- NATTED. This is the default network mode of isolated networks. The VR of 
isolated networks and VPCs provides Source NAT services, as well as Static NAT, 
Load Balancer, Port Forwarding, Vpn if the network offering supports.
+- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports 
Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported 
services are Dns, Dhcp, Userdata, Firewall (for isolated networks) and Network 
ACL (for vpc and vpc networks).
+
+
+About Routing mode
+~~
+
+Routing mode indicates how routing will operate with the isolated networks 
with ROUTED network mode.
+There are two valid options
+
+- Static. The operators need to add the static routes to the isolated networks 
or VPCs in the upstream router manually.
+- Dynamic. The AS number will be automatically allocated, and BGP peer 
sessions will be set up automatically in the VR of the isolated networks or 
VPCs. The operators need to add the AS number ranges and BGP peers for each 
zone before creating network with Dynamic routing mode.
+
+
+Manage IPv4 Subnets for Zone
+~~
+
+Like IPv6 prefixes, operators need to configure the IPv4 subnets for zone, 
which will be eventually used by guest networks.
+
+Supported CloudStack APIs for operators to manage the IPv4 subnets for zone 
are:
+
+- **createIpv4SubnetForZone** : create an IPv4 subnet for zone
+- **dedicateIpv4SubnetForZone** : dedicate an IPv4 subnet for zone to a domain 
or an account
+- **deleteIpv4SubnetForZone** : delete an IPv4 subnet for zone
+- **listIpv4SubnetsForZone** : list IPv4 subnets for zone
+- **releaseIpv4SubnetForZone** : release a dedicated IPv4 subnet for zone from 
a domain or an account
+- **updateIpv4SubnetForZone** : update an IPv4 subnet for zone
+
+Operators (root admins) can manage the IPv4 subnets for zone by navigating to 
Infrastructure -> Zones -> IPv4 Subnets
+|manage-ipv4-subnets-for-zone.png|
+
+
+Manage IPv4 Subnets for Guest Networks
+~~
+
+Unlike IPv6 (each isolated network with IPv6 support gets a /64 IPv6 network), 
operators need to manage IPv4 subnets for guest networks.
+An IPv4 subnet for guest networks is created from its parent which is a IPv4 
subnet for zone.
+
+There are some global settings which can be set for each account. See below
+
+.. cssclass:: table-striped table-bordered table-hover
+
+= 
+Configuration   Description
+= 
+routed.ipv4.network.cidr.auto.allocation.enabledWhether the 
auto-allocation

Re: [PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-20 Thread via GitHub


weizhouapache commented on code in PR #419:
URL: 
https://github.com/apache/cloudstack-documentation/pull/419#discussion_r1722796342


##
source/adminguide/networking/dynamic_static_routing.rst:
##
@@ -0,0 +1,260 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information#
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+
+
+Dynamic and Static Routing
+-
+
+For VMs on Isolated networks, the IP of VMs are not publicly accessible.
+To access the VMs from the Internet, Users need to create Load balanceing 
rules,
+Port Forwarding rules, enable Static NAT, or enable VPN.
+
+The IPv6 static routing feature has been introduced in Apache CloudStack 
4.17.0.0, so that
+users are able to access the IPv6 address of guest VMs on Isolated networks 
from the Internet or public network.
+For more information, see `“IPv6 support for isolated networks and VPC Network 
Tiers” <../plugins/ipv6.html#isolated-network-and-vpc-network-tier>`_.
+
+From Apache CloudStack 4.20.0.0, users are able to create isolated networks 
and VPCs with ROUTED mode.
+
+- Manage IPv4 subnets for Zones (ROOT admin/operator only)
+- Create Networks with Static Routing for IPv4
+- Manage IPv4 Routing Firewall for Networks
+- Manage AS number and BPG peers for Dynamic Routing (ROOT admin only)
+- Create Networks with Dynamic Routing for IPv4 and IPv6
+
+
+About Network Mode
+~~
+
+Network mode indicates the mode with which the isolated network or VPC will 
operate.
+There are two valid options
+
+- NATTED. This is the default network mode of isolated networks. The VR of 
isolated networks and VPCs provides Source NAT services, as well as Static NAT, 
Load Balancer, Port Forwarding, Vpn if the network offering supports.
+- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports 
Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported 
services are Dns, Dhcp, Userdata, Firewall (for isolated networks) and Network 
ACL (for vpc and vpc networks).
+
+
+About Routing mode
+~~
+
+Routing mode indicates how routing will operate with the isolated networks 
with ROUTED network mode.
+There are two valid options
+
+- Static. The operators need to add the static routes to the isolated networks 
or VPCs in the upstream router manually.
+- Dynamic. The AS number will be automatically allocated, and BGP peer 
sessions will be set up automatically in the VR of the isolated networks or 
VPCs. The operators need to add the AS number ranges and BGP peers for each 
zone before creating network with Dynamic routing mode.
+
+
+Manage IPv4 Subnets for Zone
+~~
+
+Like IPv6 prefixes, operators need to configure the IPv4 subnets for zone, 
which will be eventually used by guest networks.
+
+Supported CloudStack APIs for operators to manage the IPv4 subnets for zone 
are:
+
+- **createIpv4SubnetForZone** : create an IPv4 subnet for zone
+- **dedicateIpv4SubnetForZone** : dedicate an IPv4 subnet for zone to a domain 
or an account
+- **deleteIpv4SubnetForZone** : delete an IPv4 subnet for zone
+- **listIpv4SubnetsForZone** : list IPv4 subnets for zone
+- **releaseIpv4SubnetForZone** : release a dedicated IPv4 subnet for zone from 
a domain or an account
+- **updateIpv4SubnetForZone** : update an IPv4 subnet for zone
+
+Operators (root admins) can manage the IPv4 subnets for zone by navigating to 
Infrastructure -> Zones -> IPv4 Subnets
+|manage-ipv4-subnets-for-zone.png|
+
+
+Manage IPv4 Subnets for Guest Networks
+~~
+
+Unlike IPv6 (each isolated network with IPv6 support gets a /64 IPv6 network), 
operators need to manage IPv4 subnets for guest networks.
+An IPv4 subnet for guest networks is created from its parent which is a IPv4 
subnet for zone.
+
+There are some global settings which can be set for each account. See below
+
+.. cssclass:: table-striped table-bordered table-hover
+
+= 
+Configuration   Description
+= 
+routed.ipv4.network.cidr.auto.allocation.enabledWhether the 
auto-allocation

[PR] KVM volume migration changes [cloudstack-documentation]

2024-08-21 Thread via GitHub


harikrishna-patnala opened a new pull request, #424:
URL: https://github.com/apache/cloudstack-documentation/pull/424

   Updated the document regarding the support of volume migrations in case of 
KVM 
   
   Brief changes that are done in the PR
   
   - Volume migrations are allowed for stopped VMs and detached Volumes
   - For running VMs, it has to be done using migrateVirtualMachineWithVolumes 
operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KVM volume migration changes [cloudstack-documentation]

2024-08-21 Thread via GitHub


harikrishna-patnala commented on PR #424:
URL: 
https://github.com/apache/cloudstack-documentation/pull/424#issuecomment-2301285885

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KVM volume migration changes [cloudstack-documentation]

2024-08-21 Thread via GitHub


blueorangutan commented on PR #424:
URL: 
https://github.com/apache/cloudstack-documentation/pull/424#issuecomment-2301287325

   @harikrishna-patnala a Jenkins job has been kicked to build the document. 
I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KVM volume migration changes [cloudstack-documentation]

2024-08-21 Thread via GitHub


blueorangutan commented on PR #424:
URL: 
https://github.com/apache/cloudstack-documentation/pull/424#issuecomment-2301289098

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/424. 
(QA-JID 252)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Doc for Dynamic and Static routing [cloudstack-documentation]

2024-08-21 Thread via GitHub


weizhouapache commented on code in PR #419:
URL: 
https://github.com/apache/cloudstack-documentation/pull/419#discussion_r1724655272


##
source/adminguide/networking/dynamic_static_routing.rst:
##
@@ -0,0 +1,260 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information#
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+
+
+Dynamic and Static Routing
+-
+
+For VMs on Isolated networks, the IP of VMs are not publicly accessible.
+To access the VMs from the Internet, Users need to create Load balanceing 
rules,
+Port Forwarding rules, enable Static NAT, or enable VPN.
+
+The IPv6 static routing feature has been introduced in Apache CloudStack 
4.17.0.0, so that
+users are able to access the IPv6 address of guest VMs on Isolated networks 
from the Internet or public network.
+For more information, see `“IPv6 support for isolated networks and VPC Network 
Tiers” <../plugins/ipv6.html#isolated-network-and-vpc-network-tier>`_.
+
+From Apache CloudStack 4.20.0.0, users are able to create isolated networks 
and VPCs with ROUTED mode.
+
+- Manage IPv4 subnets for Zones (ROOT admin/operator only)
+- Create Networks with Static Routing for IPv4
+- Manage IPv4 Routing Firewall for Networks
+- Manage AS number and BPG peers for Dynamic Routing (ROOT admin only)
+- Create Networks with Dynamic Routing for IPv4 and IPv6
+
+
+About Network Mode
+~~
+
+Network mode indicates the mode with which the isolated network or VPC will 
operate.
+There are two valid options
+
+- NATTED. This is the default network mode of isolated networks. The VR of 
isolated networks and VPCs provides Source NAT services, as well as Static NAT, 
Load Balancer, Port Forwarding, Vpn if the network offering supports.
+- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports 
Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported 
services are Dns, Dhcp, Userdata, Firewall (for isolated networks) and Network 
ACL (for vpc and vpc networks).
+
+
+About Routing mode
+~~
+
+Routing mode indicates how routing will operate with the isolated networks 
with ROUTED network mode.
+There are two valid options
+
+- Static. The operators need to add the static routes to the isolated networks 
or VPCs in the upstream router manually.
+- Dynamic. The AS number will be automatically allocated, and BGP peer 
sessions will be set up automatically in the VR of the isolated networks or 
VPCs. The operators need to add the AS number ranges and BGP peers for each 
zone before creating network with Dynamic routing mode.
+
+
+Manage IPv4 Subnets for Zone
+~~
+
+Like IPv6 prefixes, operators need to configure the IPv4 subnets for zone, 
which will be eventually used by guest networks.
+
+Supported CloudStack APIs for operators to manage the IPv4 subnets for zone 
are:
+
+- **createIpv4SubnetForZone** : create an IPv4 subnet for zone
+- **dedicateIpv4SubnetForZone** : dedicate an IPv4 subnet for zone to a domain 
or an account
+- **deleteIpv4SubnetForZone** : delete an IPv4 subnet for zone
+- **listIpv4SubnetsForZone** : list IPv4 subnets for zone
+- **releaseIpv4SubnetForZone** : release a dedicated IPv4 subnet for zone from 
a domain or an account
+- **updateIpv4SubnetForZone** : update an IPv4 subnet for zone
+
+Operators (root admins) can manage the IPv4 subnets for zone by navigating to 
Infrastructure -> Zones -> IPv4 Subnets
+|manage-ipv4-subnets-for-zone.png|
+
+
+Manage IPv4 Subnets for Guest Networks
+~~
+
+Unlike IPv6 (each isolated network with IPv6 support gets a /64 IPv6 network), 
operators need to manage IPv4 subnets for guest networks.
+An IPv4 subnet for guest networks is created from its parent which is a IPv4 
subnet for zone.
+
+There are some global settings which can be set for each account. See below
+
+.. cssclass:: table-striped table-bordered table-hover
+
+= 
+Configuration   Description
+= 
+routed.ipv4.network.cidr.auto.allocation.enabledWhether the 
auto-allocation

[I] CLI returned "Unauthorised" when API calls contain * (asterisk) characters [cloudstack-cloudmonkey]

2024-08-21 Thread via GitHub


kennylls opened a new issue, #154:
URL: https://github.com/apache/cloudstack-cloudmonkey/issues/154

   When creating project role permissions and I wanted to enter wildcard "*", 
CLI returned "unauthorised" despite that my API key has the root admin 
permission, it seems to be similar to urllib module in python.
   
   
https://docs.cloudstack.apache.org/projects/archived-cloudstack-getting-started/en/latest/dev.html
   
   "Note
   If you have API calls which contain * (asterisk) characters, you will need 
to add the option “safe = ‘*’” for the URL encoding. The reason is that 
Python’s urllib will encode * characters by default, while CloudStack’s 
internal encoder does not encode them; this results in an authentication 
failure for your API call. In the above you would replace 
“urllib.quote_plus(request[k])” with “urllib.quote_plus(request[k], safe=’*’)”."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-21 Thread via GitHub


rohityadavcloud commented on PR #77:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2303854174

   @poddm @fabiomatavelli I was on vacation so couldn't reply earlier.
   
   Longer term, since you're both active contributors and if you want to main 
and drive releases yourselves I can propose you both as committers after which 
you can propose yourself to be release managers (did some write up here on the 
typical release process: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BDRAFT%5D+How+to+Become+a+CloudStack+Release+Manager
 ) - let me know if you're interested to do that.
   
   Looking at $dayjob pile and on-going community work, I think most of us will 
busy this/next month working towards the upcoming ACS 4.20 and other misc 
releases. We'll be available most likely in end of Q3 or in Q4 for the next ACS 
Terraform (Tofu) Provider releases.
   
   Meanwhile, feel free to work on stabilising the PRs & overall main branch to 
be ready for release work and continue to build/use the snapshots as required. 
I've pinged @kiranchavala @vishesh92 who can assist with review related queries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Issue: Create Account and Attach to Specified Domain [cloudstack-terraform-provider]

2024-08-21 Thread via GitHub


ndoskacharov opened a new issue, #133:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/133

   Hello,
   
   I am trying to create an account within a specified domain using the 
CloudStack Terraform Provider. However, I'm unable to find a clear way to 
attach the newly created account directly to a particular domain.
   
   **Expected Behavior:**
   - I should be able to create an account and specify the domain to which the 
account should be attached during the creation process.
   
   **Actual Behavior:**
- Currently, the documentation and resources do not clearly outline how to 
associate an account with a specific domain at the time of creation.

   **Use Case:**
- Currently, the documentation and resources do not clearly outline how to 
associate an account with a specific domain at the time of creation.
   
   **Proposed Solution:**
- It would be helpful to have a parameter or an example in the 
documentation that demonstrates how to specify the domain when creating an 
account.
   
   Could you please guide me on how to achieve this, or consider adding this 
functionality/documentation in a future release?
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-22 Thread via GitHub


poddm commented on PR #77:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2304969221

   @rohityadavcloud, I'm interested. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-23 Thread via GitHub


vishesh92 commented on PR #77:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2306812361

   @poddm The build is failing. Please check. 
   Also, I am not sure about removing existing resource types. This can cause 
issues for users during an upgrade. I haven't completely checked, but the end 
user who will be upgrading the provider will have to migrate his existing 
terraform setup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Command line option for additional kvm primary storage [cloudstack-documentation]

2024-08-23 Thread via GitHub


dredknight opened a new pull request, #425:
URL: https://github.com/apache/cloudstack-documentation/pull/425

   - fixed: Typo in "Manually adding Local Storage Pool"
   - added: Description on how to add additional kvm storage via command line 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] service and disk offerings [cloudstack-terraform-provider]

2024-08-23 Thread via GitHub


CodeBleu commented on PR #77:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/77#issuecomment-2307047908

   > @poddm The build is failing. Please check. Also, I am not sure about 
removing existing resource types. This can cause issues for users during an 
upgrade. I haven't completely checked, but the end user who will be upgrading 
the provider will have to migrate his existing terraform setup.
   
   @vishesh92 I don't believe the comment about "removing existing resource 
types" is what you think.  I understood it to mean he would remove his changes 
in this PR that are not related to the "service offerings" resource.
   
   Also, @poddm if we are moving forward with your approach, can we use the new 
terraform plugin framework approach? #113   I think we should start moving to 
using that for new/updated resources.  Then eventually we can get to upgrading 
the rest to use the new framework.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Document network support for configdrive [cloudstack-documentation]

2024-08-26 Thread via GitHub


DaanHoogland merged PR #412:
URL: https://github.com/apache/cloudstack-documentation/pull/412


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Correcting typo [cloudstack-documentation]

2024-08-26 Thread via GitHub


rajujith opened a new pull request, #426:
URL: https://github.com/apache/cloudstack-documentation/pull/426

   Correcting typo "KVM wite CEPH/RBD'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Correcting typo [cloudstack-documentation]

2024-08-26 Thread via GitHub


sureshanaparti commented on PR #426:
URL: 
https://github.com/apache/cloudstack-documentation/pull/426#issuecomment-2311629684

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Correcting typo [cloudstack-documentation]

2024-08-26 Thread via GitHub


blueorangutan commented on PR #426:
URL: 
https://github.com/apache/cloudstack-documentation/pull/426#issuecomment-2311631124

   @sureshanaparti a Jenkins job has been kicked to build the document. I'll 
keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Correcting typo [cloudstack-documentation]

2024-08-26 Thread via GitHub


blueorangutan commented on PR #426:
URL: 
https://github.com/apache/cloudstack-documentation/pull/426#issuecomment-2311632307

   QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/426. 
(QA-JID 253)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Correcting typo [cloudstack-documentation]

2024-08-26 Thread via GitHub


sureshanaparti commented on PR #426:
URL: 
https://github.com/apache/cloudstack-documentation/pull/426#issuecomment-2311667678

   Verified change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Correcting typo [cloudstack-documentation]

2024-08-26 Thread via GitHub


sureshanaparti merged PR #426:
URL: https://github.com/apache/cloudstack-documentation/pull/426


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Fix typo XVLAN [cloudstack-documentation]

2024-08-28 Thread via GitHub


rajujith opened a new pull request, #427:
URL: https://github.com/apache/cloudstack-documentation/pull/427

   Fix typo XVLAN


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] fixed incorrect apt-get invocation in upgrade manuals [cloudstack-documentation]

2024-08-29 Thread via GitHub


ugenk opened a new pull request, #428:
URL: https://github.com/apache/cloudstack-documentation/pull/428

   In upgrade manuals, in all debian/ubuntu examples there is incorrect apt-get 
command used.
   `apt-get upgrade` by itself does not requires any parameters.
   Upgrade of particular package is done by `apt-get install package-name`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fixed incorrect apt-get invocation in upgrade manuals [cloudstack-documentation]

2024-08-29 Thread via GitHub


DaanHoogland commented on PR #428:
URL: 
https://github.com/apache/cloudstack-documentation/pull/428#issuecomment-2317199022

   @ugenk I think  the proper way is to `apt-get update ` actually, 
what do you think? `apt-get install `  would assume it is a new 
package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   3   4   5   6   7   8   9   10   >