Re: Unable to start secondary storage in DevCloud
Thanks for your reply Tariq. I fiddled around with the settings a bit but the problem still persisted. I then saw that the primary storage was scoped for the HOST instead of CLUSTER or ZONE. I added one more primary storage and then restarted management server and the secondary storage came up. Though I do not know if it was the combination of the over-provisioning settings and adding primary storage. But still that is some progress :) I am now getting a different message of console proxy manager not being able to start because of insufficient capacity. What does this VM do? Do you have any settings to recommend that I can fiddle around and make this VM come up though I do not know what exactly this is used for. Thanks for your help. I was able to get something working. Thanks -Syed WARN [cloud.consoleproxy.ConsoleProxyManagerImpl] (consoleproxy-1:) Exception while trying to start console proxy com.cloud.exception.InsufficientServerCapacityException: Unable to create a deployment for VM[ConsoleProxy|v-40-VM]Scope=interface com.cloud.dc.DataCenter; id=1 at com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:820) at com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:557) at com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:550) at com.cloud.consoleproxy.ConsoleProxyManagerImpl.startProxy(ConsoleProxyManagerImpl.java:556) at com.cloud.consoleproxy.ConsoleProxyManagerImpl.allocCapacity(ConsoleProxyManagerImpl.java:927) at com.cloud.consoleproxy.ConsoleProxyManagerImpl.expandPool(ConsoleProxyManagerImpl.java:1664) at com.cloud.consoleproxy.ConsoleProxyManagerImpl.expandPool(ConsoleProxyManagerImpl.java:157) at com.cloud.vm.SystemVmLoadScanner.loadScan(SystemVmLoadScanner.java:111) at com.cloud.vm.SystemVmLoadScanner.access$100(SystemVmLoadScanner.java:33) at com.cloud.vm.SystemVmLoadScanner$1.reallyRun(SystemVmLoadScanner.java:81) at com.cloud.vm.SystemVmLoadScanner$1.run(SystemVmLoadScanner.java:72) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) On Tue 09 Jul 2013 09:12:14 AM EDT, Tariq Iqbal wrote: Hi Syed, You could try increasing the overprovisiong factor for storage (storage.overprovisioning.factor). You'll find it under Global Settings -> search for 'factor' storage.overprovisioning.factor There is also the CPU and Memory over provisioning factors there as well. Once you change any of these settings, you will need to restart the cloudstack managemeent service for the changes to take affect. Kind Regards, Tariq Iqbal Senior Consultant S: +44(0)20 3603 0540 | M: +44(0)790 9911600 tariq.iq...@shapeblue.com | www.shapeblue.com | Twitter:@shapeBlue ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS ____ From: Syed Mushtaq Sent: 09 July 2013 04:42 To: dev@cloudstack.apache.org Subject: Unable to start secondary storage in DevCloud Hi, I was trying to setup DevCloud by following https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud on my ubuntu machine. I have the xenserver vm running and I see that the secondary storage is being exported as NFS and I am able to mount it on the host machine. However it is not being picked up by cloudstack. I get the InsufficientServerCapacityException exception. I have given 4GB of RAM and 4 CPU cores to the VM. Can you guys please help me figure this out? Here is the complete stacktrace from the log WARN [storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:) Exception while trying to start secondary storage vm com.cloud.exception.InsufficientServerCapacityException: Unable to create a deployment for VM[SecondaryStorageVm|s-109-VM]Scope=interface com.cloud.dc.DataCenter; id=1 at com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:820) at com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:557) at com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:550) at com.cloud.storage.secondary.SecondaryStorageManagerImpl.startSecStorageVm(SecondaryStorageManagerImpl.java:260) at com.cloud.storage.secondary.SecondaryStorageManagerImpl.allocCapacity(SecondaryStorageManagerImpl
[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1951 @rhtyd If I understand correctly if we add the DB changes in 4.9.2->4.9.3 then after forward merging, upgrade from 4.9.2->4.10.0 should not have any problems with idempotency correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1829 @anshul1886 it looks like #672 is closed so that leaves us with #1941 , Are we targeting it for 4.10? If yes, then there are some comments there which you might want to address there. If we do make it into 4.10 then we can close this and use #1941 instead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1768 I agree with @DaanHoogland , as @marcaurele mentioned, the only file we need to worry about is `schema-481to490-cleanup.sql` the rest of them are either empty or change the configuration where the order of execution doesn't really matter. Looking at it briefly it looks like it modifies `ovs_tunnel_network` table which is used to manage OVS tunnels when using non-vxlan isolation. I've never seen anyone use this in production. Would be useful if we can find someone who has used this before. Or if no one is using, it is LGTM from me as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1962 CLOUDSTACK-9798 - Resizing root disk fails when using SolidFire This one is easy to reproduce: 1. Create a VM with where the root disk goes to the managed solidfire 2. Stop the VM 3. Resize the ROOT disk 4. Error @mike-tutkowski Would you be able to review this? You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack sf_root_resize_bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1962.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1962 commit d5a0ad8eeba111810e3e37721a05576b0c0f8ba3 Author: Syed Date: 2017-02-22T21:09:17Z Check for null when verifying pool capacity --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1963 CLOUDSTACK-9799 - Unable to create volume from snapshots with "_" in solidfire Steps to reproduce: 1. Create a volume using the SolidFire plugin 2. Take a snpshot of the volume 3. Create volume from snapshot with "_" in the name 4. Error @mike-tutkowski This as well :) You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack sf_vol_from_snapshot_bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1963.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1963 commit d3d41335bc241a15a4c281cab6b7d2099f24f002 Author: Syed Date: 2017-02-22T21:16:44Z Escape the volume name when creating volume from snapshot on SolidFire --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1962 @mike-tutkowski This happens when you don't specify IOPS in the service offering for the VM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1962 CLOUDSTACK-9798 - Resizing root disk fails when using SolidFire This one is easy to reproduce: 1. Create a VM with where the root disk goes to the managed solidfire 2. Stop the VM 3. Resize the ROOT disk 4. Error @mike-tutkowski Would you be able to review this? You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack sf_root_resize_bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1962.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1962 commit 2aefba819930ee9669810a23efe5908e1897d2ab Author: Syed Date: 2017-02-22T23:05:26Z Check for null when verifying pool capacity --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1963 @mike-tutkowski If you already have this in your PR, I can close this. Let me know! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1963#discussion_r102798055
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -711,6 +711,7 @@ private void
handleCreateVolumeFromSnapshotBothOnStorageSystem(SnapshotInfo snap
}
catch (Exception ex) {
errMsg = ex.getMessage() != null ? ex.getMessage() : "Copy
operation failed in
'StorageSystemDataMotionStrategy.handleCreateVolumeFromSnapshotBothOnStorageSystem'";
+copyCmdAnswer = new CopyCmdAnswer(errMsg);
--- End diff --
That would be great @mike-tutkowski. That makes sure that the snapshot goes
back to a good state if the storage driver operation fails. I will close this
request then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1951 Thanks @rhtyd for confirming. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1829 @rhtyd @anshul1886 I suggest merging this first as the changes here are very limited and tested. We can refactor the change out from #1941 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1962 @mike-tutkowski If you already have incorporated these changes, I'll close this one. If possible, please add me as reviewer when you open the other PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not clea...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1740 Thanks @yvsubhash Did the code review and it LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Stor...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/876#discussion_r109299000
--- Diff:
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
---
@@ -359,7 +359,7 @@ public boolean attachCluster(DataStore store,
ClusterScope scope) {
PrimaryDataStoreInfo primarystore = (PrimaryDataStoreInfo) store;
// Check if there is host up in this cluster
-List allHosts =
_resourceMgr.listAllUpAndEnabledHosts(Host.Type.Routing,
primarystore.getClusterId(), primarystore.getPodId(),
primarystore.getDataCenterId());
+List allHosts =
_resourceMgr.listAllUpHosts(Host.Type.Routing, primarystore.getClusterId(),
primarystore.getPodId(), primarystore.getDataCenterId());
--- End diff --
What about hosts which are in maintenance? Do we expect to add an SR to
those hosts as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164469053 @DaanHoogland I agree, someone must have kept this limit way back and forgot about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-170667305 Hi Guys ( @bhaisaab, @DaanHoogland, @remibergsma ).Did you get a chance to look at this? I think we can remove this safely. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1331 Fix Sync of template.properties in Swift When using Swift as a secondary storage, we create a template.properties file which stores the metadata about the template. Currently the data which is present in the file is incorrect which leads to templates becoming unavailable after they are downloaded. This fix makes sure that the template.properties has the correct "path" set so that templates are available. I've also done a bit of cleanup and made the code bit more clean. You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack swift-restart-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1331 commit 1b9ff622f2b9a38e65e31c7f803fd8d283f5d36f Author: Syed Date: 2015-12-14T22:37:28Z Fix Sync of template.properties in Swift --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1332 Add ability to download templates in Swift This PR adds the ability to download templates when using Swift as a secondary storage. Uses the "temp_url" feature of Swift so that tempates can be downloaded without authenticaiton. You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack swift-download Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1332.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1332 commit 0015d94f4ef185ecee94c00a4b8cf1e019b62276 Author: Syed Date: 2015-12-14T22:32:56Z Add ability to download templates in Swift --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1331#discussion_r50443906
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -942,6 +931,83 @@ protected Answer copyFromNfsToS3(CopyCommand cmd) {
}
}
+protected boolean swiftUploadMetadataFile(SwiftTO swift, File srcFile,
String containerName) throws IOException {
+
+
+//create a template.properties for Swift with its correct unique
name
--- End diff --
Thanks for the suggestion. I finally was able to get some time to work on
this again. I'll send a new PR soon with your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1331#discussion_r50446719
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -942,6 +931,83 @@ protected Answer copyFromNfsToS3(CopyCommand cmd) {
}
}
+protected boolean swiftUploadMetadataFile(SwiftTO swift, File srcFile,
String containerName) throws IOException {
+
+
+//create a template.properties for Swift with its correct unique
name
+File uniqDir = _storage.createUniqDir();
+String metaFileName = uniqDir.getAbsolutePath() + File.separator +
"template.properties";
+_storage.create(uniqDir.getAbsolutePath(), "template.properties");
+
+String uniqueName = FilenameUtils.getBaseName(srcFile.getName());
+File metaFile = new File(metaFileName);
+FileWriter writer = new FileWriter(metaFile);
+BufferedWriter bufferWriter = new BufferedWriter(writer);
+bufferWriter.write("uniquename=" + uniqueName);
+bufferWriter.write("\n");
+bufferWriter.write("filename=" + srcFile.getName());
+bufferWriter.write("\n");
+bufferWriter.write("size=" + srcFile.length());
+bufferWriter.write("\n");
+bufferWriter.write("virtualsize=" + getVirtualSize(srcFile,
getTemplateFormat(srcFile.getName(;
+bufferWriter.close();
+writer.close();
+
+SwiftUtil.putObject(swift, metaFile, containerName, _tmpltpp);
+metaFile.delete();
+uniqDir.delete();
+
+return true;
+}
+
+
+protected Answer copyFromNfsToSwift(CopyCommand cmd) {
+
+final DataTO srcData = cmd.getSrcTO();
+final DataTO destData = cmd.getDestTO();
+
+DataStoreTO srcDataStore = srcData.getDataStore();
+NfsTO srcStore = (NfsTO)srcDataStore;
+DataStoreTO destDataStore = destData.getDataStore();
+File srcFile = getFile(srcData.getPath(), srcStore.getUrl());
+
+SwiftTO swift = (SwiftTO)destDataStore;
+
+try {
+
+String containerName =
SwiftUtil.getContainerName(destData.getObjectType().toString(),
destData.getId());
+String swiftPath = SwiftUtil.putObject(swift, srcFile,
containerName, srcFile.getName());
+
+
+DataTO retObj = null;
+if (destData.getObjectType() == DataObjectType.TEMPLATE) {
+swiftUploadMetadataFile(swift, srcFile, containerName);
+TemplateObjectTO newTemplate = new TemplateObjectTO();
+newTemplate.setPath(swiftPath);
+newTemplate.setSize(getVirtualSize(srcFile,
getTemplateFormat(srcFile.getName(;
+newTemplate.setPhysicalSize(srcFile.length());
+
newTemplate.setFormat(getTemplateFormat(srcFile.getName()));
+retObj = newTemplate;
+} else if (destData.getObjectType() == DataObjectType.VOLUME) {
+VolumeObjectTO newVol = new VolumeObjectTO();
+newVol.setPath(containerName);
+newVol.setSize(srcFile.length());
--- End diff --
Good catch @pdube. That should be the virtual size (not the physical)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-173678575 Jira ticket : [CLOUDSTACK-9247](https://issues.apache.org/jira/browse/CLOUDSTACK-9247) I've tested this on our local setup and it works as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r50451763
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public DataStoreTO getStoreTO(DataStore store) {
@Override
public String createEntityExtractUrl(DataStore store, String
installPath, ImageFormat format, DataObject dataObject) {
-throw new UnsupportedServiceException("Extract entity url is not
yet supported for Swift image store provider");
+
+SwiftTO swiftTO = (SwiftTO)store.getTO();
+String tempKey = UUID.randomUUID().toString();
+boolean result = SwiftUtil.setTempKey(swiftTO, tempKey);
+
+if (!result) {
+s_logger.error("Unable to set Temp-Key: " + tempKey);
+return "";
--- End diff --
Fixed. Throwing exception instead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r50451895
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public DataStoreTO getStoreTO(DataStore store) {
@Override
public String createEntityExtractUrl(DataStore store, String
installPath, ImageFormat format, DataObject dataObject) {
-throw new UnsupportedServiceException("Extract entity url is not
yet supported for Swift image store provider");
+
+SwiftTO swiftTO = (SwiftTO)store.getTO();
+String tempKey = UUID.randomUUID().toString();
+boolean result = SwiftUtil.setTempKey(swiftTO, tempKey);
+
+if (!result) {
+s_logger.error("Unable to set Temp-Key: " + tempKey);
+return "";
+}
+
+String containerName =
SwiftUtil.getContainerName(dataObject.getType().toString(), dataObject.getId());
+String objectName = installPath.split("\\/")[1];
+// Get extract url expiration interval set in global configuration
(in seconds)
+int urlExpirationInterval =
Integer.parseInt(_configDao.getValue(Config.ExtractURLExpirationInterval.toString()));
+
+URL swiftUrl = SwiftUtil.generateTempUrl(swiftTO, containerName,
objectName, tempKey, urlExpirationInterval);
+if (swiftUrl != null) {
+s_logger.info("Swift temp-url: " + swiftUrl.toString());
--- End diff --
changed to DEBUG
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r50452491
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
command.execute(parser);
return true;
}
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
+
+Map tempKeyMap = new HashMap<>();
+tempKeyMap.put("Temp-URL-Key", tempKey);
+return postMeta(cfg, "", "", tempKeyMap);
+
+}
+
+public static URL generateTempUrl(SwiftClientCfg cfg, String
container, String object, String tempKey, int urlExpirationInterval) {
+
+int currentTime = (int) (System.currentTimeMillis() / 1000L);
+int expirationSeconds = currentTime + urlExpirationInterval;
+
+try {
+
+URL endpoint = new URL(cfg.getEndPoint());
+String method = "GET";
+String path = String.format("/v1/AUTH_%s/%s/%s",
cfg.getAccount(), container, object);
+
+//sign the request
+String hmacBody = String.format("%s\n%d\n%s", method,
expirationSeconds, path);
+String signature = calculateRFC2104HMAC(hmacBody, tempKey);
+path += String.format("?temp_url_sig=%s&temp_url_expires=%d",
signature, expirationSeconds);
+
+//generate the temp url
+URL tempUrl = new URL(endpoint.getProtocol(),
endpoint.getHost(), endpoint.getPort(), path);
+
+return tempUrl;
+
+} catch (Exception e) {
+logger.error("Unable to generate temperoary URL " +
e.getMessage());
--- End diff --
rethrowing exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-173688390 JIRA: [CLOUDSTACK-9248](https://issues.apache.org/jira/browse/CLOUDSTACK-9248) Tested this on our local setup. Created a template and generated the download link. Verified the download and it is the same as the template. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-176289614 Added unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51153892
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
command.execute(parser);
return true;
}
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
+
+Map tempKeyMap = new HashMap<>();
+tempKeyMap.put("Temp-URL-Key", tempKey);
+return postMeta(cfg, "", "", tempKeyMap);
+
+}
+
+public static URL generateTempUrl(SwiftClientCfg cfg, String
container, String object, String tempKey, int urlExpirationInterval) {
+
+int currentTime = (int) (System.currentTimeMillis() / 1000L);
+int expirationSeconds = currentTime + urlExpirationInterval;
+
+try {
+
+URL endpoint = new URL(cfg.getEndPoint());
+String method = "GET";
+String path = String.format("/v1/AUTH_%s/%s/%s",
cfg.getAccount(), container, object);
+
+//sign the request
+String hmacBody = String.format("%s\n%d\n%s", method,
expirationSeconds, path);
+String signature = calculateRFC2104HMAC(hmacBody, tempKey);
+path += String.format("?temp_url_sig=%s&temp_url_expires=%d",
signature, expirationSeconds);
+
+//generate the temp url
+URL tempUrl = new URL(endpoint.getProtocol(),
endpoint.getHost(), endpoint.getPort(), path);
+
+return tempUrl;
+
+} catch (Exception e) {
+logger.error(e.getMessage());
+throw new CloudRuntimeException(e.getMessage());
+}
+
+}
+
+
+private static String calculateRFC2104HMAC(String data, String key)
+throws SignatureException, NoSuchAlgorithmException,
InvalidKeyException {
+
+SecretKeySpec signingKey = new SecretKeySpec(key.getBytes(),
HMAC_SHA1_ALGORITHM);
+Mac mac = Mac.getInstance(HMAC_SHA1_ALGORITHM);
+mac.init(signingKey);
+return toHexString(mac.doFinal(data.getBytes()));
+
+}
+
+private static String toHexString(byte[] bytes) {
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51153916
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
command.execute(parser);
return true;
}
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
+
+Map tempKeyMap = new HashMap<>();
+tempKeyMap.put("Temp-URL-Key", tempKey);
+return postMeta(cfg, "", "", tempKeyMap);
+
+}
+
+public static URL generateTempUrl(SwiftClientCfg cfg, String
container, String object, String tempKey, int urlExpirationInterval) {
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51153907
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
command.execute(parser);
return true;
}
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
+
+Map tempKeyMap = new HashMap<>();
+tempKeyMap.put("Temp-URL-Key", tempKey);
+return postMeta(cfg, "", "", tempKeyMap);
+
+}
+
+public static URL generateTempUrl(SwiftClientCfg cfg, String
container, String object, String tempKey, int urlExpirationInterval) {
+
+int currentTime = (int) (System.currentTimeMillis() / 1000L);
+int expirationSeconds = currentTime + urlExpirationInterval;
+
+try {
+
+URL endpoint = new URL(cfg.getEndPoint());
+String method = "GET";
+String path = String.format("/v1/AUTH_%s/%s/%s",
cfg.getAccount(), container, object);
+
+//sign the request
+String hmacBody = String.format("%s\n%d\n%s", method,
expirationSeconds, path);
+String signature = calculateRFC2104HMAC(hmacBody, tempKey);
+path += String.format("?temp_url_sig=%s&temp_url_expires=%d",
signature, expirationSeconds);
+
+//generate the temp url
+URL tempUrl = new URL(endpoint.getProtocol(),
endpoint.getHost(), endpoint.getPort(), path);
+
+return tempUrl;
+
+} catch (Exception e) {
+logger.error(e.getMessage());
+throw new CloudRuntimeException(e.getMessage());
+}
+
+}
+
+
+private static String calculateRFC2104HMAC(String data, String key)
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51154027
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
command.execute(parser);
return true;
}
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
--- End diff --
I don't think I can write a unit test for this as it relies on an external
script to work to give the correct output. I could mock the output but that
would defeat the purpose of the unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add ability to download templates in Swif...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-179502412 Can we get this merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-181507090 Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-182023310 @DaanHoogland I'm not sure why the tests are failing. My changes shouldn't have affected that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-184250180 LGTM. I've also been testing this in my dev environment with no issues so far --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/10 Import error when running cloudmonkey The cloudmonkey install from pip does not run and gives an import error because the latest `requests` package dropped the `requests.packages.urllib3`. I am removing an import which tries to access that. Note that even after removing that line, I still get import errors because `requests_toolbelt` uses `requests.packages.urllib3`. They have fixed it in their master but haven't yet pushed onto PyPi. I have also opened a bug with them for the same. You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack-cloudmonkey master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-cloudmonkey/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 48d33885d2cdf6f3ad8dca94fca8a5fea556e58e Author: Syed Date: 2015-10-03T02:49:15Z Removing urllib3 import and unused urllib2 imports --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...
Github user syed commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/10#issuecomment-145297866 This was a problem with my setup where I had multiple versions of `request`. Closing as not a bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...
Github user syed closed the pull request at: https://github.com/apache/cloudstack-cloudmonkey/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1112 Fix Instance creation with swift as Secondary Storage [CLOUDSTACK-9061] Swift is currently broken when used as Secondary storage. This fix does the right thing when creating directories on the NFS staging server. We should think of a better solution as this should have been common code path between S3 and Swift. We should also make the "Object Storage as Secondary Storage" interface generic so that we can add other object stores too. -Syed You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1112 commit ecc93bbded2cde8f1a0fccd8ac86b8079a85db09 Author: Syed Date: 2015-11-23T19:14:14Z Fix Instance creation with swift as Secondary Storage [CLOUDSTACK-9061] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1112#issuecomment-160187393 Guys, I am closing this and opening this request against 4.6.1 as I have been told that it is the new way now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix secondary storage not working with sw...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1133 Fix secondary storage not working with swift Original PR and discussion at #1112 You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack 4.6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1133 commit 1e67a5d2c89009daabdcded86e9844824ec7d1ed Author: Syed Date: 2015-11-27T18:48:18Z Fix secondary storage not working with swift --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1223 Remove template ulimit from createtmplt.sh and createvolume.sh Both createvolume.sh and createtmplt.sh have a 40GB hardcoded limit for the size of the template that gets created. I could not find any justification of that. I am just removing them as they caused us a huge headache when we tried to create bigger templates and they failed without any good error. You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack remove_template_ulimit Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1223 commit ecc93bbded2cde8f1a0fccd8ac86b8079a85db09 Author: Syed Date: 2015-11-23T19:14:14Z Fix Instance creation with swift as Secondary Storage [CLOUDSTACK-9061] commit a046b7e4de43cc1958331e1f1312f372be7d7235 Author: Syed Date: 2015-12-02T15:08:03Z Merge branch 'master' of https://github.com/apache/cloudstack commit c87cf9878663e2255eaee08441f395f3abf559dd Author: Syed Date: 2015-12-11T17:52:53Z Merge branch 'master' of https://github.com/apache/cloudstack commit 14868c2102c0e88c7253a82ec3e14cdfd8e1b564 Author: Syed Date: 2015-12-11T18:17:20Z Remove 40GB filesize limit from SSVM scripts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164039298 @remibergsma Done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219160595 @swill looks like jenkins failed because of some licence issue in one file. I've checked all the files that I have changed and every one seems to have the correct licence. I don't have access but is it possible to check `/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/target/rat.txt` which has more info. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219162095 @swill I got the file from jenkins and it points to `utils/testsmallfileinactive` ... I have no idea where this file came from --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219163000 https://builds.apache.org/job/cloudstack-pr-analysis/1323/artifact/target/rat.txt here is the link to the file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219166142 @DaanHoogland sure ... doesn't hurt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1331 Fix Sync of template.properties in Swift When using Swift as a secondary storage, we create a template.properties file which stores the metadata about the template. Currently the data which is present in the file is incorrect which leads to templates becoming unavailable after they are downloaded. This fix makes sure that the template.properties has the correct "path" set so that templates are available. I've also done a bit of cleanup and made the code bit more clean. You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack swift-restart-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1331 commit f3b8c7e0f2720639f1db77b15e0791ec70537a29 Author: Syed Date: 2015-12-14T22:37:28Z Fix Sync of template.properties in Swift --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack ipsec-start-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1423 commit e9b184ca1fbe4337eea6826179429407ea993303 Author: Syed Date: 2016-02-23T15:14:33Z [CLOUDSTACK-9296] Start ipsec for client VPN --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack ipsec-start-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1423 commit dfa555f2ad775ee3177efcd675e37b8c46201af6 Author: Syed Date: 2016-02-23T15:14:33Z [CLOUDSTACK-9296] Start ipsec for client VPN --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack ipsec-start-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1423 commit dfa555f2ad775ee3177efcd675e37b8c46201af6 Author: Syed Date: 2016-02-23T15:14:33Z [CLOUDSTACK-9296] Start ipsec for client VPN --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack ipsec-start-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1423 commit dfa555f2ad775ee3177efcd675e37b8c46201af6 Author: Syed Date: 2016-02-23T15:14:33Z [CLOUDSTACK-9296] Start ipsec for client VPN --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1552#issuecomment-220349481 Can cofirm the dhcp folder on Ubuntu Trusty LTS (14.04) LGTM. ``` $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 14.04.1 LTS Release:14.04 Codename: trusty $ls /var/lib/dhcp/ dhclient.leases ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1424 [CLOUDSTACK-8973] Fix create template from snapshot returning null in case of region store This PR fixes a case where when we create a template from a snpashot in a region wide store, we don't set the cross zone flag which causes a null response to be returned Tests: Before fix ``` (local) � > create template snapshotid=33aa3f3b-5a47-4d2a-8d27-12952c01ebed displaytext=t2 ostypeid=20c8ead6-d750-11e5-9f8c-0652427c name=t9 accountid = 1b13d7c2-d750-11e5-9f8c-0652427c cmd = org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin created = 2016-02-23T16:09:24+ jobid = 4f9f5ff9-e7f0-4af6-999c-799431fd47de jobinstanceid = a08a9711-bd31-43bb-80a2-49cf9d722a19 jobinstancetype = Template jobprocstatus = 0 jobresult: null: crossZones = False isfeatured = False ispublic = False isready = False tags: jobresultcode = 0 jobresulttype = object jobstatus = 1 userid = 1b140f08-d750-11e5-9f8c-0652427c ``` See the *null* in response After fix: ``` (local) � > create template snapshotid=33aa3f3b-5a47-4d2a-8d27-12952c01ebed displaytext=t2 ostypeid=20c8ead6-d750-11e5-9f8c-0652427c name=t11 accountid = 1b13d7c2-d750-11e5-9f8c-0652427c cmd = org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin created = 2016-02-25T21:47:03+ jobid = 1b74209b-b3c1-4168-a243-f559aa0c081b jobinstanceid = 06ecee5a-b1f2-4e67-80fb-f0f44b0aa198 jobinstancetype = Template jobprocstatus = 0 jobresult: template: id = 06ecee5a-b1f2-4e67-80fb-f0f44b0aa198 name = t11 account = admin created = 2016-02-25T21:47:03+ crossZones = True displaytext = t2 domain = ROOT domainid = 1b13ab80-d750-11e5-9f8c-0652427c format = VHD hypervisor = XenServer isdynamicallyscalable = False isextractable = True isfeatured = False ispublic = False isready = True ostypeid = 20c8ead6-d750-11e5-9f8c-0652427c ostypename = CentOS 5 (64-bit) passwordenabled = False size = 21474836480 sourcetemplateid = 1af0f0cc-d750-11e5-9f8c-0652427c sshkeyenabled = False status = Download Complete tags: templatetype = USER jobresultcode = 0 jobresulttype = object jobstatus = 1 userid = 1b140f08-d750-11e5-9f8c-0652427c ``` Works correctly You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack create-template-api-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1424 commit 7b5d5648d80a603d68a1232f663127819799c89a Author: Syed Date: 2016-02-25T21:29:58Z Fix create template from snapshot returning null in case of region store --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack ipsec-start-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1423 commit dfa555f2ad775ee3177efcd675e37b8c46201af6 Author: Syed Date: 2016-02-23T15:14:33Z [CLOUDSTACK-9296] Start ipsec for client VPN --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack ipsec-start-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1423 commit 26227768a10c4a7ced0fc08d0ce567b6ffcc31ea Author: Syed Date: 2016-02-23T15:14:33Z [CLOUDSTACK-9296] Start ipsec for client VPN --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1584 LGTM based on the code review. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1598 [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the `VHDProcessor` incorrectly calculates the virutal size leading to the template being useless. This fix tries to guess the virtual size by partially decompressing it and falls back to a sensible default which is the size of the file. Before the fix: template.properties on Swift ``` uniquename=routing-1 filename=routing-1.vhd size=263417314 virtualsize=2894447637315205059 ``` After the fix ``` uniquename=routing-1 filename=routing-1.vhd size=263417314 virtualsize=3145728000 ``` Look at the `virutalsize` in both cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack vhd-compressed-size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1598.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1598 commit 841783f3359ebe58683613bb0481c3de38153923 Author: Syed Date: 2016-06-27T20:11:14Z [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1598: [CLOUDSTACK-9423] Add ability to get virtual size of...
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1598
Yes @swill I've tested this on my local setup.
On Mon, Jun 27, 2016 at 5:16 PM, Will Stevens
wrote:
> @syed <https://github.com/syed> my understanding is that you have tested
> this fix with swift in our lab. That is correct?
>
> I will get CI run against it to make sure this does not break anything
> outside swift.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cloudstack/pull/1598#issuecomment-228878063>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe/AADaLukgRTWegA80eHmB9lgg9QMRZxv3ks5qQD2mgaJpZM4I_d12>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1597: added constant for magic code
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1597 Looks like there are some trailing space problems. Can you please fix that @vcharmcaster ``` /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:25: error: Line has trailing spaces. /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:26:1: error: Line contains a tab character. /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:27: error: Line has trailing spaces. /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:27:1: error: Line contains a tab character. /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:28:1: error: Line contains a tab character. /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:29: error: Line has trailing spaces. /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:29:1: error: Line contains a tab character. ``` Also, can you rebase your commits into a single commit? Otherwise, the code LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1595: ui: show resize volume button to all users
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1595 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1598: [CLOUDSTACK-9423] Add ability to get virtual size of...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1598 @swill. I've fixed the whitespaces and rebased everything. Should be good now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1597: added constant for magic code
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1597 @vcharmcaster it looks like your commit still did not fix the problems. Can you check the problems I mentioned in my previous comments. There are some trailing spaces and tabs which need to be fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1598: [CLOUDSTACK-9423] Add ability to get virtual size of...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1598 @swill if you can merge this before you cut the release, it would be awesome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1598 [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the `VHDProcessor` incorrectly calculates the virutal size leading to the template being useless. This fix tries to guess the virtual size by partially decompressing it and falls back to a sensible default which is the size of the file. Before the fix: template.properties on Swift ``` uniquename=routing-1 filename=routing-1.vhd size=263417314 virtualsize=2894447637315205059 ``` After the fix ``` uniquename=routing-1 filename=routing-1.vhd size=263417314 virtualsize=3145728000 ``` Look at the `virutalsize` in both cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack vhd-compressed-size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1598.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1598 commit b0247b53f99ff97fd05d4d8528115ed6e7d497c0 Author: Syed Date: 2016-06-27T20:11:14Z [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1600 Support Backup of Snapshots for Managed Storage This PR adds an ability to Pass a new parameter, locationType, to the âcreateSnapshotâ API command. Depending on the locationType, we decide where the snapshot should go in case of managed storage. There are two possible values for the locationType param 1) `Standard`: The standard operation for managed storage is to keep the snapshot on the device. For non-managed storage, this will be to upload it to secondary storage. This option will be the default. 2) `Archive`: Applicable only to managed storage. This will keep the snapshot on the secondary storage. For non-managed storage, this will result in an error. The reason for implementing this feature is to avoid a single point of failure for primary storage. Right now in case of managed storage, if the primary storage goes down, there is no easy way to recover data as all snapshots are also stored on the primary. This features allows us to mitigate that risk. You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack snapshot-archive-pr Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1600.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1600 commit 252942f29c5c485b7d60b6ae8be33165db1b0cfb Author: Syed Date: 2016-06-30T17:37:33Z Support Backup of Snapshots for Managed Storage This PR adds an ability to Pass a new parameter, locationType, to the âcreateSnapshotâ API command. Depending on the locationType, we decide where the snapshot should go in case of managed storage. There are two possible values for the locationType param 1) `Standard`: The standard operation for managed storage is to keep the snapshot on the device. For non-managed storage, this will be to upload it to secondary storage. This option will be the default. 2) `Archive`: Applicable only to managed storage. This will keep the snapshot on the secondary storage. For non-managed storage, this will result in an error. The reason for implementing this feature is to avoid a single point of failure for primary storage. Right now in case of managed storage, if the primary storage goes down, there is no easy way to recover data as all snapshots are also stored on the primary. This features allows us to mitigate that risk. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 This was done in two parts: The work to add the API parameter was done by @mike-tutkowski and the work to enable this on the backend was done by me. The rebase destroyed history but I would like to correctly credit the contributors :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1598 [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the `VHDProcessor` incorrectly calculates the virutal size leading to the template being useless. This fix tries to guess the virtual size by partially decompressing it and falls back to a sensible default which is the size of the file. Before the fix: template.properties on Swift ``` uniquename=routing-1 filename=routing-1.vhd size=263417314 virtualsize=2894447637315205059 ``` After the fix ``` uniquename=routing-1 filename=routing-1.vhd size=263417314 virtualsize=3145728000 ``` Look at the `virutalsize` in both cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed/cloudstack vhd-compressed-size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1598.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Good catch @mike-tutkowski. I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular VMware vms creation as ful...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 @nvazquez is there a use case where you would want some VMWare hypervisors to not do a full clone? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Sure @mike-tutkowski --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 A bit of background on how this feature works. When locationType is specified as `Archve`, a snaphsot is taken at the storage, but the copy to seconday storage is done via the hypervisor as it is able to correctly attach the LUN and extract the underlying virtual disk. This was done as an alternative to taking the snapshot on the hypervisor and upload it to secondary storage directly becuse, we've seen cases where hypervisor snapshots cause a significant delay in read/write performance and snapshot on storage device allows us to take snaspots without sacrificing performance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski , the list snapshot already returns the `loacationType`. I think you've already added that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1602: CLOUDSTACK-9422: Granular 'vmware.create.full...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r69485338
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -1353,6 +1363,20 @@ public void prepare(VirtualMachineProfile vm,
DeployDestination dest) throws Sto
disk.setDetails(getDetails(volumeInfo, dataStore));
vm.addDisk(disk);
+
+// If hypervisor is vSphere, check for clone type setting.
+if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
--- End diff --
Does this need to be specific to VMWare? I can see a use case where this
can be useful for XenServer as well. IIRC for XenServer, the volumes are
`linked`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1602: CLOUDSTACK-9422: Granular 'vmware.create.full...
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r69486019
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -1353,6 +1363,20 @@ public void prepare(VirtualMachineProfile vm,
DeployDestination dest) throws Sto
disk.setDetails(getDetails(volumeInfo, dataStore));
vm.addDisk(disk);
+
+// If hypervisor is vSphere, check for clone type setting.
+if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
--- End diff --
So the idea is, instead of creating a clone which is linked to a parent, we
would create a full clone of the disk. I can see this being useful when you
don't want to have the overhead of nested reads/writes. Am I correct?
So there are reasons to use a `linked` clone as pointed out by @serg38 and
there are reasons to use a full clone as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1604: improvement: systemvm slow operations
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1604#discussion_r69583623
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -228,7 +228,7 @@ def processCLItem(self, num, nw_type):
if('localgw' in self.qFile.data['cmd_line']):
dp['gateway'] = self.qFile.data['cmd_line']['localgw']
else:
-dp['gateway'] = 'None'
+dp['gateway'] = self.qFile.data['cmd_line'].get('gateway',
'None')
--- End diff --
there could be a possibility of having an ipv6 gateway, in that case, we
would be looking at `ip6gateway`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1604: improvement: systemvm slow operations
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 @romain-dartigues do we know why the `arping` is failing? Ideally, if the vif is configured correctly, the arping should go through properly. If the `arping` fails, do we still know that the connectivity is correct/establised? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks @serg38 my question is more along the lines of can this `fullClone`/ `linkedClone` functionality be extended to other hypervisors, in that case, we can make the code hypervisor agnostic. If not then I am happy with the current implementation as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1586 agree with @yvsubhash. I don't see an need to set the name-label to `detached` the code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I've fixed the problem where the volume was not being detached after the copy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks guys. The code LGTM based on the code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1604: improvement: systemvm slow operations
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 Thanks @romain-dartigues based on your comments the code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1604: improvement: systemvm slow operations
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 we do have to remember that arping is ipv4 only so we need to fix this for ipv6 too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I think the `Destroyed` state should suffice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Thanks @karuturi for your comments, I will get to them as soon as I have some free cycles. Right now this is only supported for XenServer as this requires the backend to be able to do native snapshots. If there is need, we can add VMWare/KVM support as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1642: System VMs on Managed Storage
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski the code LGTM. We have a managed storage in-house. I will run it there and report if I see any problems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
