[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-5943: added doc for...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/9 CLOUDSTACK-5943: added doc for the Palo Alto Networks firewall integration I have added documentation for the Palo Alto Networks firewall integration. This change should also be cherry picked back into the 4.3 branch. I have created it in its own file and included it in the networking2.rst file. I have tested the build and the menu system and doc is building as expected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudops/cloudstack-docs-admin master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-admin/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 4b49450452939d72ca0e628e4f6dbc468d5608e0 Author: Will Stevens Date: 2014-05-12T16:56:36Z CLOUDSTACK-5943: added doc for the Palo Alto Networks firewall integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1907 I have squash merged the changes that @ustcweizhou requested. Would you mind reviewing again so we can get this important fix into 4.10. Thanks... @rafaelweingartner, it looks like I lost your code review in the process of doing the squashed commit. Can you review and confirm your previous review? Thanks guys... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1907
@rafaelweingartner the only change was to remove the extra gateway
verification if it was a 'guest' network because this is now handled by the
code in #1871.
```
+guest_gw = self.config.cmdline().get_guest_gw()
+logging.info("Interface has the following gateway ==> %s",
guest_gw)
+
+if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
```
The rest of the code is the same as the original pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRout...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1966 I can't see what branch this is opened against on my phone. What version of ACS is this opened against and which version do you have a problem in. The reason I ask is because #1741 was added in master to upgrade from openswan to strongswan. . Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1907 This has the required reviews and both @remibergsma (sbp) and us (cloud.ca) have been using this fix in production. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2003: fixed an issue if the dev is not in the datab...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack/pull/2003 fixed an issue if the dev is not in the databag Defend against the specified dev not being in the databag. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swill/cloudstack cs_ip_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2003.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2003 commit 6cde7cdaef5082446872c8858392f54fc11dba92 Author: Will Stevens Date: 2017-03-13T19:37:54Z fixed an issue if the dev is not in the databag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 @ustcweizhou the `else` case did not change from the original code: https://github.com/apache/cloudstack/pull/1741/files#diff-a7d6f7150cca74029f23c19b72ad0622L49 @karuturi I have updated the PR title and I updated the commit message to include the jira ticket. @borisstoyanov do we have a run of these tests just against master recently to review the difference in output? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 I have to admit, I am not sure how the IP was found when looping through the list initially, but then when trying to update the index for the IP that was found, it is not there. The only way I can think of that would cause this is if the IP <-> dev mapping is broken somehow. It found the matching IP, but apparently that IP is not on the dev defined by the `nic_dev_id` (which comes from either: `nic_dev_id = address['nic_dev_id']` (from the databag), which can then be overridden by `nic_dev_id = ip['nic_dev_id']` (from the passed in IP) ). Yes, I think you are right that the `else` case does not work right now. This is because we are appending the IP to this dev, but we never removed it from the other dev it was apparently found in. This logic is SUPPOSED to find the existing IP's index and then if found, update that index with the updated info. The old logic which just removed all "found" IPs and then re-added them, did not preserve the order, so the source nat IP could get reconfigured as a secondary IP on a nic instead of it being primary. This reordering of the IPs on VR reboot caused the VPN to fail because the source nat IP was no longer the primary IP. So we know that removing all found IPs and then adding them does not work because it changes the order of the IPs causing the source nat IP to become a secondary IP on the nic. The error described in CLOUDSTACK-9811 seems to be a situation where the IP is found on one nic, but then for some reason the dev which the IP is associated with is changed (I don't know why this would be happening), causing the index where the IP was found to not be valid because the IP is actually on a different dev. To know how to fix this correctly, we need to understand why/how an IP can be associated with one dev (index found) and then get changed to be associated with a different dev. We need to find a way to preserve IP order while being able to update the IP configurations. @remibergsma do you have any ideas on this? Anyone else have ideas here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 On the Jira ticket, Wei Zhou mentioned that this could potentially happen if you have two different public IP ranges. So if you associate a public IP which is in a different range than the source nat, a new nic will be created. If you disassociate it, that nic will be removed. I guess my question is. Why is it not on the`dbag`variable then associated with that dev? I think Wei is probably right in terms of context, but I am not sure how exactly to solve this yet. @borisstoyanov can you confirm that you have two different public IP ranges in your setup? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 @borisstoyanov we are still trying to understand how the IP was found when looping through the `dbag` but it is not associated with the expected dev when we try to update the index which it was found on. The only way I can see this could happen is if the dev requested it be configured on is different from the dev it is actually configured on. I still have not figured out how that case exists. @ustcweizhou has some good ideas on this front, but I don't think we have gotten to a point where we understand how this problem is happening. @borisstoyanov is there a chance you can post the `ips.json` and `ip_association.json` files in your environment so we can start to understand what the config is that is causing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 @borisstoyanov I have a suspicion that the ip_association.json is a transient file which may be short lived. I am not sure because I have not seen it either, but it was the file being processed when you had your original error. I will review your ips.json and see what I can find. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
This `ips.json` file confuses the hell out of me. From what I can tell
both `eth2` and `eth3` both have the ip `10.1.35.83` twice for each (for a
total of the IP being configured 4 times over two interfaces).
How was this IP configured?
```
"eth2": [
{
"add": true,
"broadcast": "10.1.63.255",
"cidr": "10.1.35.83/19",
"device": "eth2",
"gateway": "10.1.63.254",
"netmask": "255.255.224.0",
"network": "10.1.32.0/19",
"nic_dev_id": "2",
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.1.35.83",
"size": "19",
"source_nat": false
},
{
"add": true,
"broadcast": "10.1.63.255",
"cidr": "10.1.35.83/19",
"device": "eth2",
"gateway": "10.1.63.254",
"netmask": "255.255.224.0",
"network": "10.1.32.0/19",
"nic_dev_id": "2",
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.1.35.83",
"size": "19",
"source_nat": false
}
],
"eth3": [
{
"add": true,
"broadcast": "10.1.63.255",
"cidr": "10.1.35.83/19",
"device": "eth3",
"first_i_p": true,
"gateway": "10.1.63.254",
"netmask": "255.255.224.0",
"network": "10.1.32.0/19",
"new_nic": true,
"nic_dev_id": 3,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.1.35.83",
"size": "19",
"source_nat": true,
"vif_mac_address": "06:ee:46:00:00:03"
},
{
"add": true,
"broadcast": "10.1.63.255",
"cidr": "10.1.35.83/19",
"device": "eth3",
"first_i_p": true,
"gateway": "10.1.63.254",
"netmask": "255.255.224.0",
"network": "10.1.32.0/19",
"new_nic": true,
"nic_dev_id": 3,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.1.35.83",
"size": "19",
"source_nat": true,
"vif_mac_address": "06:a4:80:00:00:03"
}
],
```
I will see if I can get to the bottom of this, but this is pretty
confusing. Do you have a sequence of events which produced this configuration?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 So... Looking at this with a different perspective. If there is a bug elsewhere which would cause an IP to be duplicated in the `dbag`, the old implementation would have cleaned up this bug and would have removed all the duplicates (including the real one) and then would have only added back the real one. My implementation did not assume that I was having to clean up duplicates in the `dbag` variable and only focused on adding if it didn't exist or updating the existing entry if it did exist. I will have to think about this more... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 Ya, I am not sure where the problem is stemming from. The fact that my code is not defensive around this problem is a problem. That is for sure. But given my understanding of the moving parts here, I feel like there is something else going on as well. I will see if I can get an environment up and running tomorrow so I can do some more testing on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Does anyone know what `first_i_p` represents in the `ips.json` dbag? I am
assuming it is the Source NAT IP, but I can't find it represented anywhere in
the code (other than in a test). If it does represent the Source NAT, then we
can use it to maintain the order and keep the Source NAT IP as the primary IP
on the Nic. That was the bug I was trying to fix in my #1741 PR.
Example with: 1) source nat 2) port forwarding 3) static nat 4) load
balancer
```
"eth2": [
{
"add": true,
"broadcast": "192.168.80.255",
"cidr": "192.168.80.8/24",
"device": "eth2",
"first_i_p": true,
"gateway": "192.168.80.5",
"netmask": "255.255.255.0",
"network": "192.168.80.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "192.168.80.8",
"size": "24",
"source_nat": true,
"vif_mac_address": "06:00:44:00:00:23"
},
{
"add": true,
"broadcast": "192.168.80.255",
"cidr": "192.168.80.9/24",
"device": "eth2",
"first_i_p": false,
"gateway": "192.168.80.5",
"netmask": "255.255.255.0",
"network": "192.168.80.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "192.168.80.9",
"size": "24",
"source_nat": false,
"vif_mac_address": "06:34:d1:00:00:23"
},
{
"add": true,
"broadcast": "192.168.80.255",
"cidr": "192.168.80.10/24",
"device": "eth2",
"first_i_p": false,
"gateway": "192.168.80.5",
"netmask": "255.255.255.0",
"network": "192.168.80.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": true,
"public_ip": "192.168.80.10",
"size": "24",
"source_nat": false,
"vif_mac_address": "06:34:d1:00:00:23"
},
{
"add": true,
"broadcast": "192.168.80.255",
"cidr": "192.168.80.11/24",
"device": "eth2",
"first_i_p": false,
"gateway": "192.168.80.5",
"netmask": "255.255.255.0",
"network": "192.168.80.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "192.168.80.11",
"size": "24",
"source_nat": false,
"vif_mac_address": "06:34:d1:00:00:23"
}
],
```
@ustcweizhou @murali-reddy @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 I am considering changing my implementation to be the same as the old implementation (which removed the IP from the dbag in the initial loop of the merge), but if `source_nat` is present and it is `true` and the `len(dbag[ip['device']]) > 0` (with all the checking required), then prepend else append. This should ensure that the source nat ip is the primary ip on the nic which the StrongSwan feature depends on. If I do this and there is a bug elsewhere that will duplicate the IPs in the databag, then this will clean that up (as I assume it was doing before). Not sure this will fix @borisstoyanov's current problem, but I think it is probably a safer implementation to keep the source nat IP as the first IP. I will update this PR with that change later today... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 Thanks @remibergsma. I am going to use `source_nat` as it better represents what it is I am trying to establish and it seems to always be in the object where `first_i_p` does not always seem to be present (look at @borisstoyanov's output above for example). @borisstoyanov I will work on getting you the new implementation today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 @borisstoyanov alright, this is ready for you to start testing. Can you kick off CI on this as well? I will be doing testing of this locally as well. This implementation is very similar to how it was implemented before my original change. See: https://github.com/apache/cloudstack/pull/1741/files#diff-a7d6f7150cca74029f23c19b72ad0622L19 The only change from the original was that if the IP is a `source_nat` IP and there are already IPs associated with that dev, it will `prepend` instead of `append` so the source nat ip is set as the primary ip on the nic (required for VPN). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 thank you sir. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 I think #2011 fixes the observed issue, but this PR improves the IP ordering fix originally added to the strongswan pr. This implementation ensures (again) that duplicate public ips will not be saved to the data bag while ensuring the source nature ip is primary on its nic. In short, I think both PRs are worth merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-admin pull request: Split the 'networking and traf...
Github user swill commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/11#issuecomment-43383883 One other note: I deleted the 'managing_networks.rst' file after verifying that it did not include any additional detail to what was in 'networkin2.rst'. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-admin pull request: Split the 'networking and traf...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/11 Split the 'networking and traffic' section into includes and cleaned up formatting I created a 'networking' folder and split the 'networking2' file up into includes of the different sections now located in the 'networking' folder. I also renamed 'networking2' to 'networking_and_traffic' to better reflect the title of the section. I cleaned up all of the list formatting issues in the networking section. I did not make any changes to the content other than some minor formatting changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudops/cloudstack-docs-admin master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-admin/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 4b49450452939d72ca0e628e4f6dbc468d5608e0 Author: Will Stevens Date: 2014-05-12T16:56:36Z CLOUDSTACK-5943: added doc for the Palo Alto Networks firewall integration commit 62c0205463dd71976f577c36e1023095914ca1a6 Author: Will Stevens Date: 2014-05-16T14:46:55Z Merge remote-tracking branch 'upstream/master' commit af5e726fa28f798f08c4dcb89ce254d5aef6aa28 Author: Will Stevens Date: 2014-05-16T21:35:52Z split the networking2 file into multiple includes and renamed it to 'networking_and_traffic' commit 15b439c28ffddaf26da4e5f933c56fa0bd5add2e Author: Will Stevens Date: 2014-05-16T21:36:23Z Merge remote-tracking branch 'upstream/master' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-admin pull request: Fixed the formatting of lists ...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/12 Fixed the formatting of lists and notes and such for all files I fixed the following: - extra line breaks in all lists - correctly wrapped 'note' blocks - put 2 line breaks above all titles (unless a parent title is directly above it) to make the sections more visible when editing the files - fixed the indenting of code blocks and and such You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudops/cloudstack-docs-admin master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-admin/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 4b49450452939d72ca0e628e4f6dbc468d5608e0 Author: Will Stevens Date: 2014-05-12T16:56:36Z CLOUDSTACK-5943: added doc for the Palo Alto Networks firewall integration commit 62c0205463dd71976f577c36e1023095914ca1a6 Author: Will Stevens Date: 2014-05-16T14:46:55Z Merge remote-tracking branch 'upstream/master' commit af5e726fa28f798f08c4dcb89ce254d5aef6aa28 Author: Will Stevens Date: 2014-05-16T21:35:52Z split the networking2 file into multiple includes and renamed it to 'networking_and_traffic' commit 15b439c28ffddaf26da4e5f933c56fa0bd5add2e Author: Will Stevens Date: 2014-05-16T21:36:23Z Merge remote-tracking branch 'upstream/master' commit 53f7237cd05aef663fb85adea5ede3265a57bfa6 Author: Will Stevens Date: 2014-05-20T15:05:35Z Merge remote-tracking branch 'upstream/master' commit 7f1ef288a2e21cd8b4acc0c13cea4231727fa98c Author: Will Stevens Date: 2014-05-20T16:33:17Z fixed formatting of all the files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-admin pull request: added better instructions to t...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/13 added better instructions to the 'contribute' section of the README these instructions describe how to modify the documentation and create a pull request for the changes to be committed to the official documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudops/cloudstack-docs-admin dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-admin/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 8aa35b9f46a959566d7a42a87a660bc2bb1e4e36 Author: Will Stevens Date: 2014-05-26T16:19:43Z added better instructions to the 'contribute' section of the README --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-rn pull request: improved the 'contribute' instruc...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/12 improved the 'contribute' instructions I added the contribution workflow to the README.rst file so it is easier for people to know how to contribute to the documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swill/cloudstack-docs-rn dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-rn/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 50efcf59ebe4ca1824497f8c205b0bf0c20fb9d3 Author: Will Stevens Date: 2014-05-26T16:59:28Z improved the 'contribute' instructions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-install pull request: improved the 'contribute' in...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-install/pull/12 improved the 'contribute' instructions in the README.rst this update makes it easier for people to understand the flow for updating the documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swill/cloudstack-docs-install dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-install/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit fc63a7a05fbe0723e8b86cb0be8e22342eabb543 Author: Will Stevens Date: 2014-05-26T17:15:16Z improved the 'contribute' instructions in the README.rst --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs pull request: Added instructions for how to contri...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs/pull/3 Added instructions for how to contribute I removed the README.md file because it did not have anything useful in it and we might as well keep the documentation files in RST. I created a README.rst file in the root directory and added details for how to fork and contribute to the documentation. I also modified the README.rst file in the `rtd` directory to refer to the root README.rst file for how to contribute to the documentation. I think it is important to have a README in the root with contribution instructions so users see it right away when they navigate to the repo page on GitHub. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swill/cloudstack-docs dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs/pull/3.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3 commit 351e87f5109243a492714e5fda67534a411cbe92 Author: Will Stevens Date: 2014-05-26T20:35:59Z Added instructions for how to contribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-install pull request: cleaned up formatting in all...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-install/pull/13 cleaned up formatting in all the files In addition to cleaning up the formatting in all the files, I also removed the deprecated 'managing_networks.rst' file. I did not make any content changes, only formatting changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudops/cloudstack-docs-install swill Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-install/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit d1f729f21d8c320db5af4ad261b21a250355aa60 Author: Will Stevens Date: 2014-05-27T20:41:54Z cleaned up formatting in all the files and removed the deprecated 'managing_networks.rst' file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-admin pull request: updated the conf file so the l...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/14 updated the conf file so the local theme is the same as the online theme this helps document contributors know exactly what the themed doc will look like online. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudops/cloudstack-docs-admin swill Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-admin/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit dea0bf5a127f7e6367b5d72b471d01b1d6832fc1 Author: Will Stevens Date: 2014-05-27T20:47:49Z updated the conf file so the theme is the same when you build locally as it is online --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs pull request: fixed the formatting in all the file...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs/pull/4 fixed the formatting in all the files and added the license to each file I updated the formatting to match the other documentation projects. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudops/cloudstack-docs swill Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs/pull/4.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4 commit afd83832342a759610c07d7f5f248a6c83ceed25 Author: Will Stevens Date: 2014-05-28T16:25:35Z fixed the formatting in all the files and added the license to each file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-rn pull request: updated formatting to be consiste...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/14 updated formatting to be consistent with the rest of the docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudops/cloudstack-docs-rn swill Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-rn/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 03770d3d826079b8d67eff145b2d5b1a2165c315 Author: Will Stevens Date: 2014-05-29T15:48:17Z updated formatting to be consistent with the rest of the docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Added the CONTRIBUTING.md doc to the proj...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack/pull/141 Added the CONTRIBUTING.md doc to the project root Added instructions for how contributors should submit code changes via GitHub Pull Requests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swill/cloudstack contrib_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit dc84b5b4d728821b892e212b5e5183c2548a5294 Author: Will Stevens Date: 2015-04-01T20:24:48Z Added the CONTRIBUTING.md doc to the project root --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-179964783 Should Jenkins and CI checks be succeeding or is it because the tests do not have access to a Swift instance to test and succeed? The code looks good to me. I have not tested because I do not have access to a different Swift installation than the others who have tested already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-www pull request: developer page: fixed some repo links...
GitHub user swill opened a pull request: https://github.com/apache/cloudstack-www/pull/21 developer page: fixed some repo links and new tab for external links Fixed repo links as they were broken before. I also changed the external links on this page to be opened in new tabs so it preserves the flow for the developer as they go through the guide and click to learn more about different topics as they work their way through the guide. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swill/cloudstack-www master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-www/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 9bc1391770d4cdb6c38a9b2a0ebb2c9bd7573526 Author: Will Stevens Date: 2015-12-03T14:46:08Z developer page: fixed some repo links and now opening external links in a new tab for better flow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Notify listeners when a host has been add...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218354565 Can you re-push to try to get Jenkins green. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-218356331 Sorry to do this to you @rhtyd, but I just merged like 10 PRs and we now have merge conflicts. Can you resolve the merge conflicts and re-push. When you resolve the merge conflicts, would you mind not squashing the fixes to the merge conflicts so we can more easily review the changes required to resolve the merge conflicts. This will help me know if I need to re-run CI before I merge this. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-218356736 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 3 Errors: 0 Duration: 6h 24m 57s ``` **Summary of the problem(s):** ``` FAIL: Test redundant router internals -- Traceback (most recent call last): File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false "Attempt to retrieve google.com index page should be successful once rule is added!" AssertionError: Attempt to retrieve google.com index page should be successful once rule is added! -- Additional details in: /tmp/MarvinLogs/test_network_GDLRM8/results.txt ``` ``` FAIL: test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) -- Traceback (most recent call last): File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 253, in test_02_vpc_privategw_static_routes self.performVPCTests(vpc_off) File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 324, in performVPCTests self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress) File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 559, in check_pvt_gw_connectivity "Ping to outside world from VM should be successful" AssertionError: Ping to outside world from VM should be successful -- Additional details in: /tmp/MarvinLogs/test_network_GDLRM8/results.txt ``` ``` FAIL: test_03_vpc_privategw_restart_vpc_cleanup (integration.smoke.test_privategw_acl.TestPrivateGwACL) -- Traceback (most recent call last): File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 265, in test_03_vpc_privategw_restart_vpc_cleanup self.performVPCTests(vpc_off, True) File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 331, in performVPCTests self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress) File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 559, in check_pvt_gw_connectivity "Ping to outside world from VM should be successful" AssertionError: Ping to outside world from VM should be successful -- Additional details in: /tmp/MarvinLogs/test_network_GDLRM8/results.txt ``` **Associated Uploads** **`/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_39_49_I0OP3U:`** * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_39_49_I0OP3U/dc_entries.obj) * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_39_49_I0OP3U/failed_plus_exceptions.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_39_49_I0OP3U/runinfo.txt) **`/tmp/MarvinLogs/test_network_GDLRM8:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/test_network_GDLRM8/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/test_network_GDLRM8/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/test_network_GDLRM8/runinfo.txt) **`/tmp/MarvinLogs/test_vpc_routers_WTWRQD:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/test_vpc_routers_WTWRQD/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/test_vpc_routers_WTWRQD/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR880/tmp/MarvinLogs/test_vpc_routers_WTWRQD/runinfo.txt) Uploads will be available until `2016-07-11 02:00:00 +0200 CEST` *Comment created by [`upr comment`](https://github.com/cloudops/upr).* --- If your pr
[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-218356820 These connectivity issues are unrelated to this PR. I will merge this now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-218358102 thank you sir. can you repush right away again. jenkins already failed and I like to make sure everything is green before i merge stuff. thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-218359137 Thank you. I am really trying to avoid that, but lets see what happens. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218362729 Can someone with a VMware environment validate this PR is functional? I don't think running CI is going to give us anything on this one since I only have KVM and this is only a DB change. Thoughts??? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CPU socket count reporting correction
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-218365187 @NuxRo can you close and reopen this PR to force Jenkins to kick off a run. It has been hung in this state for days. I know you can't easily `amend` and force push, so closing and reopening the PR will let you kick it off again through the UI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218365323 @remibergsma just a reminder to squash and re-push so we can get jenkins green. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218365435 @jburwell can I get your final review on this one? I think that is the only thing we are missing on this one. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-218365520 I am going to merge this one. I am confident with the change and I have verification from @remibergsma, so I think we are good to go on this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218366133 @DaanHoogland can you force push this one again so we can kick off Jenkins again. It has been stuck in this state for a week. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-218366572 @sudhansu7 can you force push again to kick off Jenkins and Travis again? Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1455#issuecomment-218366880 Bump... @sanju1010 can you please follow up on @DaanHoogland's comments. This one is ready to go otherwise, so it would be great if you could follow up with us on this @sanju1010. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: L10n update master 20160127
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-218367016 #1515 has now been merged (sorry for the delay). Once you have a chance to fix the merge conflicts, I can get this merged. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9199: Fixed deployVirtualMachi...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1280#issuecomment-218367282 @anshul1886 can you please review and address the comments in this PR? Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218367555
### CI RESULTS
```
Tests Run: 94
Skipped: 0
Failed: 2
Errors: 0
Duration: 7h 45m 13s
```
**Summary of the problem(s):**
```
FAIL: Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test
Network GC Nics
--
Traceback (most recent call last):
File
"/data/git/cs2/cloudstack/test/integration/smoke/test_vpc_redundant.py", line
605, in test_04_rvpc_network_garbage_collector_nics
self.check_routers_state(status_to_check="BACKUP", expected_count=2)
File
"/data/git/cs2/cloudstack/test/integration/smoke/test_vpc_redundant.py", line
353, in check_routers_state
self.fail("Expected '%s' routers at state '%s', but found '%s'!" %
(expected_count, status_to_check, cnts[vals.index(status_to_check)]))
AssertionError: Expected '2' routers at state 'BACKUP', but found '1'!
--
Additional details in: /tmp/MarvinLogs/test_network_BG7UFE/results.txt
```
```
FAIL: test_04_rvpc_privategw_static_routes
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
File
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line
277, in test_04_rvpc_privategw_static_routes
self.performVPCTests(vpc_off)
File
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line
324, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
File
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line
559, in check_pvt_gw_connectivity
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_network_BG7UFE/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_40_27_1Z9M75:`**
*
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_40_27_1Z9M75/dc_entries.obj)
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_40_27_1Z9M75/failed_plus_exceptions.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/DeployDataCenter__May_10_2016_19_40_27_1Z9M75/runinfo.txt)
**`/tmp/MarvinLogs/test_network_BG7UFE:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_network_BG7UFE/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_network_BG7UFE/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_network_BG7UFE/runinfo.txt)
**`/tmp/MarvinLogs/test_privategw_acl_JUTOR4:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_privategw_acl_JUTOR4/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_privategw_acl_JUTOR4/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_privategw_acl_JUTOR4/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_009P6U:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_vpc_routers_009P6U/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_vpc_routers_009P6U/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR/tmp/MarvinLogs/test_vpc_routers_009P6U/runinfo.txt)
Uploads will be available until `2016-07-11 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218367932 I reran the tests that failed and they succeeded the second time, so CI is in a good place on this one. I need one more code review on this one. @marcaurele can you please force push this PR to kick of Jenkins again so when we get another code review we can merge right away. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218456049 Thank you sir. Unfortunately travis failed this time. Would you mind trying it again. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Notify listeners when a host has been add...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218456885 @mike-tutkowski unfortunately it failed again. :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: 4.9/master bountycastle changes
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218458113 the travis logs seem to indicate that something is not working... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9199: Fixed deployVirtualMachi...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1280#issuecomment-218462063 @anshul1886 I think the ask is that it get extracted as a method and a test be written for it. @pedro-martins and @alexandrelimassantana, I feel that this might be a bit overkill. Can you explain what the test would be validating? As for the backwards compatibility issue, I am not entirely sure I understand the concern. Can someone help me understand what that concern is? Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Notify listeners when a host has been add...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218465085 I have seen this happen periodically and it does not seem to be consistently telling us the truth. This happens sometimes when only a single line of code changes, so I am not sure what the deal is here. Just re-push and lets see what happens. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Handle private gateways more reliably
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-218465795 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 4h 32m 05s ``` **Associated Uploads** **`/tmp/MarvinLogs/DeployDataCenter__May_11_2016_06_54_42_3CPRW6:`** * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/DeployDataCenter__May_11_2016_06_54_42_3CPRW6/dc_entries.obj) * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/DeployDataCenter__May_11_2016_06_54_42_3CPRW6/failed_plus_exceptions.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/DeployDataCenter__May_11_2016_06_54_42_3CPRW6/runinfo.txt) **`/tmp/MarvinLogs/test_network_TS9WMA:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/test_network_TS9WMA/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/test_network_TS9WMA/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/test_network_TS9WMA/runinfo.txt) **`/tmp/MarvinLogs/test_vpc_routers_M1AWH1:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/test_vpc_routers_M1AWH1/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/test_vpc_routers_M1AWH1/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1474/tmp/MarvinLogs/test_vpc_routers_M1AWH1/runinfo.txt) Uploads will be available until `2016-07-11 02:00:00 +0200 CEST` *Comment created by [`upr comment`](https://github.com/cloudops/upr).* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Handle private gateways more reliably
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-218466093 I need one more code review and this one should be ready to merge. @kiwiflyer did you have a chance to review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218464050 @nvazquez this seems to have broken travis for everyone. We have this issue showing up in pretty much all travis runs right now `ContextSuite context=TestListIdsParams>:teardown`. Can you investigate? Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218469220 @serg38 I had a bunch of people re-push PRs last night and this morning to get everything green and 3 or 4 are failing with this. Here are a couple off the top of my head: #1502, #1376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218483641
### CI RESULTS
```
Tests Run: 7
Skipped: 0
Failed: 4
Errors: 0
Duration: 0h 37m 50s
```
**Summary of the problem(s):**
```
FAIL: Test restart network with cleanup
--
Traceback (most recent call last):
File
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line
2851, in test_restart_network_with_cleanup
self.validateResult(result)
File
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line
2749, in validateResult
self.fail("IP is missing from vpcVR")
AssertionError: IP is missing from vpcVR
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt
```
```
FAIL: Test network rules after starting a VpcVr that
--
Traceback (most recent call last):
File
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line
2465, in test_02_start_vm_network_gc
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt
```
```
FAIL: Test Stop all the Vms that are part of the a Network
--
Traceback (most recent call last):
File
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line
2557, in test_03_restart_vpcvr
(self.public_ip_1.ipaddress.ipaddress, e))
AssertionError: Failed to SSH into VM - 192.168.23.54, SSH connection has
Failed. Waited 600s. Error is SSH Connection Failed
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt
```
```
FAIL: Test update Network that is part of a VPC to a network
--
Traceback (most recent call last):
File
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line
1910, in test_01_network_services_upgrade
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_11_2016_08_32_17_9O5EIE:`**
*
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__May_11_2016_08_32_17_9O5EIE/dc_entries.obj)
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__May_11_2016_08_32_17_9O5EIE/failed_plus_exceptions.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__May_11_2016_08_32_17_9O5EIE/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_network_14GQ49:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_14GQ49/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_14GQ49/runinfo.txt)
Uploads will be available until `2016-07-11 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-218483982 The added test fails, but lots of tests failed. I will rebuild my environment and test again to see if anything changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218489998 Can you create a new PR to fix this and we will get it tested right away. Thanks for being on top of this. ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Notify listeners when a host has been add...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218489553 I think we are definitely having issues with it not cleaning correctly. I have seen a couple cases where we get the "unable to update index" when it tries to do a git checkout because of problems with cleanup, so that is possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218500189 Thank you, I will merge it assuming Jenkins and Travis come back clean. Thx... ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: 4.9/master bountycastle changes
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218503116 @DaanHoogland well a timeout in combination with a connection is not being able to be established seems relevant since it is related to the code that has changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218503981 I am testing now... ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218505040 @DaanHoogland it finished!!! :P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218519246 @nvazquez I don't think #1539 is related to this PR. I think this one has completely separate issues... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218522071 No worries. ð I am really short on sleep, but I was pretty confident. :P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply static routes on change to master s...
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218577635
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 9h 06m 23s
```
**Summary of the problem(s):**
```
FAIL: Test redundant router internals
--
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py",
line 478, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
result = check_router_command(virtual_machine, nat_rule.ipaddress,
ssh_command, check_string, self)
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py",
line 61, in check_router_command
test_case.fail("Failed to SSH into the Virtual Machine: %s" % e)
AssertionError: Failed to SSH into the Virtual Machine: [Errno 110]
Connection timed out
--
Additional details in: /tmp/MarvinLogs/test_network_KAUTZA/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_29_07_UR1IBW:`**
*
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_29_07_UR1IBW/dc_entries.obj)
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_29_07_UR1IBW/failed_plus_exceptions.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_29_07_UR1IBW/runinfo.txt)
**`/tmp/MarvinLogs/test_network_KAUTZA:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/test_network_KAUTZA/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/test_network_KAUTZA/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/test_network_KAUTZA/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_N2UD4H:`**
*
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/test_vpc_routers_N2UD4H/failed_plus_exceptions.txt)
*
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/test_vpc_routers_N2UD4H/results.txt)
*
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1472/tmp/MarvinLogs/test_vpc_routers_N2UD4H/runinfo.txt)
Uploads will be available until `2016-07-11 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218578631
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 24
Errors: 10
Duration: 10h 46m 24s
```
**Summary of the problem(s):**
```
ERROR: Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test
Network GC Nics
--
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line
281, in tearDown
raise Exception("Warning: Exception during cleanup : %s" % e)
Exception: Warning: Exception during cleanup : Execute cmd:
deletenetworkoffering failed, due to: errorCode: 431, errorText:Can't delete
network offering 22 as its used by 1 networks. To make the network offering
unavaiable, disable it
--
Additional details in: /tmp/MarvinLogs/test_network_JPKNVA/results.txt
```
```
ERROR: Test iptables default INPUT/FORWARD policies on VPC router
--
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_iptables_default_policy.py",
line 302, in test_01_single_VPC_iptables_policies
self.entity_manager.do_vpc_test()
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_iptables_default_policy.py",
line 490, in do_vpc_test
self.check_ssh_into_vm(vm.get_vm(), vm.get_ip())
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_routers_iptables_default_policy.py",
line 525, in check_ssh_into_vm
raise Exception("Failed to SSH into VM - %s" %
(public_ip.ipaddress.ipaddress))
Exception: Failed to SSH into VM - 192.168.23.9
--
Additional details in: /tmp/MarvinLogs/test_network_JPKNVA/results.txt
```
```
ERROR: test suite for
--
Traceback (most recent call last):
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
228, in run
self.tearDown()
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
351, in tearDown
self.teardownContext(ancestor)
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line
367, in teardownContext
try_run(context, names)
File
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471,
in try_run
return func()
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_router_dhcphosts.py",
line 169, in tearDownClass
raise Exception("Warning: Exception during cleanup : %s" % e)
Exception: Warning: Exception during cleanup : Job failed: {jobprocstatus :
0, created : u'2016-05-11T10:18:25+0200', jobresult : {errorcode : 530,
errortext : u'Failed to delete network'}, cmd :
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid :
u'c8508137-1732-11e6-923a-5254001daa61', jobstatus : 2, jobid :
u'5b50924d-00dc-44dc-b23a-70d11c529b6a', jobresultcode : 530, jobresulttype :
u'object', jobinstancetype : u'Network', accountid :
u'c8506953-1732-11e6-923a-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_JPKNVA/results.txt
```
```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
--
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line
763, in test_03_vpc_internallb_haproxy_stats_on_all_interfaces
self.execute_internallb_haproxy_tests(vpc_offering)
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line
838, in execute_internallb_haproxy_tests
applb.sourceipaddress, self.get_ssh_client(vm, 5), settings)
File
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line
497, in get_ssh_client
self.fail("Unable to create ssh connection: " % e)
TypeError: not all arguments converted during string formatting
--
Additional details in: /tmp/MarvinLogs/test_network_JPKNVA/results.txt
```
```
ERROR: Test to verify access to loa
[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-218579019 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 9h 12m 09s ``` **Summary of the problem(s):** ``` FAIL: Test redundant router internals -- Traceback (most recent call last): File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false "Attempt to retrieve google.com index page should be successful once rule is added!" AssertionError: Attempt to retrieve google.com index page should be successful once rule is added! -- Additional details in: /tmp/MarvinLogs/test_network_F298R0/results.txt ``` **Associated Uploads** **`/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_51_52_QTWNUF:`** * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_51_52_QTWNUF/dc_entries.obj) * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_51_52_QTWNUF/failed_plus_exceptions.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/DeployDataCenter__May_11_2016_00_51_52_QTWNUF/runinfo.txt) **`/tmp/MarvinLogs/test_network_F298R0:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_F298R0/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_F298R0/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_network_F298R0/runinfo.txt) **`/tmp/MarvinLogs/test_vpc_routers_6U8HTX:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_6U8HTX/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_6U8HTX/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1444/tmp/MarvinLogs/test_vpc_routers_6U8HTX/runinfo.txt) Uploads will be available until `2016-07-11 02:00:00 +0200 CEST` *Comment created by [`upr comment`](https://github.com/cloudops/upr).* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-218579831 I think this one is pretty much ready. I have one code review on this one. Can I get one more person to look over this for me? Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-218591057 @syed can you have a look at this one. I am not sure why, but I am having a lot of trouble with this PR. I have not been able to get a test run to actually works. I have tried to run CI on this 3 times and I always get the following: ``` INFO [c.c.r.ResourceManagerImpl] (ApiServer-1:ctx-7bf8070e ctx-cdcb3f39) (logid:2044d020) Trying to add a new host at http://kvm1 in data center 1 INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-412302f9) (logid:5b139200) Begin cleanup expired async-jobs INFO [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:ctx-412302f9) (logid:5b139200) End cleanup expired async-jobs INFO [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-a52a3147) (logid:86cda124) NetworkGarbageCollector uses '10' seconds for GC interval. INFO [c.c.h.k.d.LibvirtServerDiscoverer] (ApiServer-1:ctx-7bf8070e ctx-cdcb3f39) (logid:2044d020) cloudstack agent setup command failed: cloudstack-setup-agent -m 192.168.22.61 -z 1 -p 1 -c 1 -g 57acd541-cd37-34ea-af6a-dc6ecd007325 -a --pubNic=cloudbr0 --prvNic=cloudbr1 --guestNic=cloudbr0 --hypervisor=kvm WARN [c.c.r.ResourceManagerImpl] (ApiServer-1:ctx-7bf8070e ctx-cdcb3f39) (logid:2044d020) Unable to find the server resources at http://kvm1 INFO [c.c.u.e.CSExceptionErrorCode] (ApiServer-1:ctx-7bf8070e ctx-cdcb3f39) (logid:2044d020) Could not find exception: com.cloud.exception.DiscoveryException in error code list for exceptions WARN [o.a.c.a.c.a.h.AddHostCmd] (ApiServer-1:ctx-7bf8070e ctx-cdcb3f39) (logid:2044d020) Exception: com.cloud.exception.DiscoveryException: Unable to add the host at com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:802) at com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:597) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at com.sun.proxy.$Proxy159.discoverHosts(Unknown Source) at org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) at com.cloud.api.ApiServer.queueCommand(ApiServer.java:698) at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) at com.cloud.api.ApiServer.handle(ApiServer.java:434) at org.apache.http.protocol.HttpService.doService(HttpService.java:423) at org.apache.http.protocol.HttpService.handleRequest(HttpService.java:341) at com.cloud.api.ApiServer$WorkerTask.runInContext(ApiServer.java:1236) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) INFO [c.c.a.ApiServer] (ApiServer-1:ctx-7bf8070e ctx-cdcb3f39) (logid:2044d020) Unable to add the host ``` The fact that both Jenkins and Travis are failing may also be relevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis
[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-218596132 The additional run of these tests in a new environment gives the same results. I think this needs some work still... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply static routes on change to master s...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218597071 @rafaelweingartner yes, it will be forward merged. Sorry I only just got around to answering your question. I need one more code review on this one. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-218597484 I think this one is good to go... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218648555 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 6h 07m 12s ``` **Summary of the problem(s):** ``` FAIL: Test redundant router internals -- Traceback (most recent call last): File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true "Attempt to retrieve google.com index page should be successful!" AssertionError: Attempt to retrieve google.com index page should be successful! -- Additional details in: /tmp/MarvinLogs/test_network_RIXF85/results.txt ``` **Associated Uploads** **`/tmp/MarvinLogs/DeployDataCenter__May_11_2016_18_25_27_MFQRAL:`** * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/DeployDataCenter__May_11_2016_18_25_27_MFQRAL/dc_entries.obj) * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/DeployDataCenter__May_11_2016_18_25_27_MFQRAL/failed_plus_exceptions.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/DeployDataCenter__May_11_2016_18_25_27_MFQRAL/runinfo.txt) **`/tmp/MarvinLogs/test_network_RIXF85:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_network_RIXF85/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_network_RIXF85/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_network_RIXF85/runinfo.txt) **`/tmp/MarvinLogs/test_vpc_routers_SQ90BE:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_vpc_routers_SQ90BE/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_vpc_routers_SQ90BE/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1537/tmp/MarvinLogs/test_vpc_routers_SQ90BE/runinfo.txt) Uploads will be available until `2016-07-12 02:00:00 +0200 CEST` *Comment created by [`upr comment`](https://github.com/cloudops/upr).* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218648825 This one is ready other than Jenkins. @PaulAngus, can you please either force push the PR or close and reopen it so it kicks off Jenkins so we can get this PR all green. It is ready to merge otherwise... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-218648913 Thanks for the hard work @remibergsma. ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Handle private gateways more reliably
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-218649126 Thank you sir. I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply static routes on change to master s...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218649198 Thanks gents. I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-218649383 @dsclose can you force push or close and reopen the PR to kick off travis and jenkins again? Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-218649701 I need some code review on this one. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218651517 Does this require a change to the system VM template? I am pulling this in for testing now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218654451 Sorry for the delay getting to this. I think this probably works in all cases, but I suspect it will not clean up correctly always. Because this was working sometimes and failing sometimes, I believe that means that the cleanup of `account` does not always clean up the snapshots (otherwise it would have never worked). I think the code should be like this to make sure it cleans up everything up and does not fail. ``` cls._cleanup = [ cls.snapshot_1, cls.snapshot_2, cls.snapshot_3, cls.disk_offering, cls.account, cls.service_offering ] ``` Does this make sense to you guys? This way it will remove the snapshots first and then it will clean up everything else. I could be wrong, but since the current code ever worked, I think this guarantees that the cleanup of everything will happen and the `account` won't error when it tries to clean up. I guess if the account keeps a reference to the snapshot after it is deleted, that could cause the account deletion to fail. Feedback please... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63011147 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [ cls.disk_offering, cls.account, -cls.service_offering, -cls.snapshot_1, -cls.snapshot_2, -cls.snapshot_3 +cls.service_offering --- End diff -- I agree with your order. @nvazquez can you update the order to what rohit posted in his commit. @rhtyd is there a reason you added this to your PR? Will you just remove it from that PR once this is updated and merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218742950 Once I get #1539 merged, I will ask you to re-push since we are working to fix the issue that is causing Travis to fail in that PR right now. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-218743823 Can I get one more review on this one? @remibergsma are you choosing not to squash because you are not the original author of some of the commits? If that is the case, I understand and am fine with it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r63012011 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [ cls.disk_offering, cls.account, -cls.service_offering, -cls.snapshot_1, -cls.snapshot_2, -cls.snapshot_3 +cls.service_offering --- End diff -- Haha. Ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1503#issuecomment-218745932 @DaanHoogland & @olivierlemasle thanks for the heads up guys. I will get CI run against this today... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218774260 @rhtyd I have had a couple independant reports of CPU going to 100% with this patch and the problem not existing if they revert this PR (along with #1534). Due to the upcoming freeze, I am considering reverting this PR (and #1534) until we can isolate the problem and get it tested again and verify the problem is resolved. I won't revert it today to give you, @kiwiflyer and others a chance to try to isolate the problem and test a fix. If we have not been able to resolve this by tomorrow, I will revert it and we can continue testing in a new PR. Thanks for the work on this guys... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218789994 @nvazquez, @rhtyd's commit has been merged as part of his larger PR at #1502, so we can close this PR since the result of this PR has already been merged. Thanks everyone... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove extraneous log directory and add c...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218790646 @PaulAngus I just pushed a fix for the Travis problems you experienced. Can you please re-push this PR so we can try to get it all green so we can get it merged. Thanks again for the support... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove classes with no references
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-218791773 Can I get one more code review on this one??? Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-218792730 @dsclose we have pushed fixes to both Jenkins and Travis today. Can you please do a force push or close and reopen this PR in order to kick off Jenkins and Travis again. I think this one is pretty close... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CPU socket count reporting correction
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-218793268 @NuxRo I have pushed fixes to both Jenkins and Travis this morning. Can you close and reopen the PR to kick off the Jenkins and Travis runs again. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218794307 @remibergsma can you re-push this one. Jenkins and Travis should be fixed now, so we should be able to get this green with a new push. I am missing one code review on this one. @kiwiflyer and @dmabry did you guys happen to check this one already? I know you guys have been reviewing stuff in this space. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
