[GitHub] cloudstack pull request #1563: CLOUDSTACK-9389:[automation]updating test_rou...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/1563


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...

[nitt10prashant]

Github user nitt10prashant commented on the issue:

https://github.com/apache/cloudstack/pull/1563
  
Not needed 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1573: CLOUDSTACK-9396:fixing issue related to scrip...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/1573


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1573: CLOUDSTACK-9396:fixing issue related to script test_...

[nitt10prashant]

Github user nitt10prashant commented on the issue:

https://github.com/apache/cloudstack/pull/1573
  
not needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1048#issuecomment-164736785
  
can you please share test result ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1048#issuecomment-164740710
  
LGTM based on code review and test case result 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1199#issuecomment-172463466
  
LGTM
based on code review 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1190#issuecomment-172466590
  
LGTM 
Test revert snapshot on XenServer ... === 
TestName:test_01_check_revert_snapshot | Status SUCCESS ===
ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-182784773
  
LGTM ..based on code review and result .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/1417

CLOUDSTACK-9289:Automation for feature deploy vm from vmsnapshot

Automation for deploy vm from snapshot .
1-Test to create VM from vm snapshots without data disk
2-Deploy vm from snapshot , ssh and verify data
3-Seed template and then deploy vm and check if timeis same for vm 
deployment
4-Create volume from vmshnapshot and verify usage
5-Create volume from vm snapshot and download
6-Create volume from snapshot and attach to vm
test result
===
create volume from vmshnapshot and verify usage ... === TestName: 
test_01_create_volume_from_vmsnapshot | Status : SUCCESS ===
ok
create volume from vm snapshot and download ... === TestName: 
test_02_create_volume_from_vmsnapshot | Status : SUCCESS ===
ok
create volume from snapshot and attach to vm ... === TestName: 
test_03_create_volume_from_vmsnapshot | Status : SUCCESS ===
ok
Test to create VM from vm snapshots without data disk ... === TestName: 
test_01_create_vm_from_vmsnapshots | Status : SUCCESS ===
ok
deploy vm from snaphsot , ssh and verify data ... === TestName: 
test_02_create_vm_from_vmsnapshots_and_verify_data | Status : SUCCESS ===
ok
Seed template and then deploy vm and check if time ... === TestName: 
test_03_seed_template_from_vmsnapshot | Status : SUCCESS ===
ok

--
Ran 6 tests in 1781.242s

OK

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack deploy_vm_from_snp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1417.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1417


commit 9d89229942436d98f4897d8030f95cbcb8702cbf
Author: nitt10prashant 
Date:   2016-02-17T04:30:07Z

CLOUDSTACK-9289:Automation for feature deploy vm from vmsnapshot

changing script location from smoke to component

formatting to pep8




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1031#discussion_r53300709
  
--- Diff: test/integration/testpaths/testpath_storage_migration.py ---
@@ -248,6 +248,11 @@ def setUpClass(cls):
 DomainName=cls.account.domain
 )
 # Create Service offering
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"]
+)
+
--- End diff --

please add cls._cleanup.append(cls.service_offering)  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8439:Automation for feature CP...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/226

CLOUDSTACK-8439:Automation for feature CPU/Memory overcommit

Tested on xen,kvm,vmware environments 

Test result:
--
enge cpu/mem.overprovisioning.factor at cluster level and  v ... === 
TestName: test_01_cluster_settings | Status : SUCCESS ===
ok
change mem.overprovisioning.factor and verify vm memory ... === TestName: 
test_02_Overcommit_factor | Status : SUCCESS ===
ok
change cpu/mem.overprovisioning.factor at cluster level and ... === 
TestName: test_03_cluste_capacity_check | Status : SUCCESS ===
ok
change cpu/mem.overprovisioning.factor at cluster level for ... === 
TestName: test_04_zone_capacity_check | Status : SUCCESS ===
ok

--
Ran 4 tests in 1785.972s

OK


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack pkm

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #226


commit a757134921099c92f35685fd3095160970e0ae24
Author: nitt10prashant 
Date:   2015-05-04T06:43:52Z

CLOUDSTACK-8439:Automation for feature CPU/Memory overcommit




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Automation for feature Enable configuring...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/252

Automation for feature Enable configuring local storage use for system VMs 
at zone level



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack ssvmstorage

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit 508f10527fc199a45900e456899893fb776e50da
Author: wilderrodrigues 
Date:   2015-04-22T09:35:57Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtStopCommandWrapper
  - LibvirtRequestWrapper
  - 1 unit tests

Refactored the RequestWrapper to make it better.
  - Changes also applied to the CitrixRequestWrapper

commit 7086d64387fd0fb6381e4dbb63d46361d619b948
Author: wilderrodrigues 
Date:   2015-04-22T12:53:28Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtGetVmStatsCommandWrapper
  - 3 unit tests

Refactored the LibvirtConnectiobn by surrounding it with an wrapper.
  - Make it easier to cover the static/native calls
  - Added better coverage to StopCommand tests

commit 51093afcf11ef37b3d54c5430b955e87e17d2be2
Author: wilderrodrigues 
Date:   2015-04-22T13:05:59Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtGetVmDiskStatsCommandWrapper
  - 1 unit test

Added getConnection() to LibvirtConnectionWrapper

commit 7a90c018fbba0419c55c245aa1cb3488472d2a62
Author: wilderrodrigues 
Date:   2015-04-22T14:06:43Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtRebootCommandWrapper and LibVirtRebootRouterCommandWrapper
  - 2 unit tests added
  - KVM hypervisor with 10.5% coverage

commit 6e568125fc282a3d0984f59fa0755b087e29cf7f
Author: wilderrodrigues 
Date:   2015-04-23T08:30:13Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtGetHosStatsCommandWrapper
  - 1 unit test added
  - KVM hypervisor with 10.5% coverage

Tests are a bit limited on this one becuause of the current implementation. 
Would clean it up later in a separate branch

commit 54f68f519fc3baefe435f9b37f028ff2cca9106f
Author: wilderrodrigues 
Date:   2015-04-23T08:45:57Z

Removing the CheckStateCommand form the IF statement on 
LibvirtComputingResource
- It's not used and if so would cause an infinite loop.

commit d730efb86681b2206b82cbacc828e77e1204367b
Author: wilderrodrigues 
Date:   2015-04-23T09:36:38Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtCheckHealthCommandWrapper and 
LibvirtPrepareForMigrationCommandWrapper
  - 2 unit tests added
  - KVM hypervisor plugin with 10.8% coverage

commit 28e55462f15bdd8699e97b668c4ffc01735a533d
Author: wilderrodrigues 
Date:   2015-04-23T11:31:58Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtMigrateCommandWrapper
  - 1 unit tests added
  - KVM hypervisor plugin with 10.9% coverage

commit be1e5176156d9b7eb78e53c703b48d679ad52f56
Author: wilderrodrigues 
Date:   2015-04-23T11:57:13Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtPingTestCommandWrapper
  - 3 unit tests added
  - KVM hypervisor plugin with 11.2% coverage

commit 4d216f1a6382c42cf94a947aa5432f4d18782811
Author: wilderrodrigues 
Date:   2015-04-23T12:24:53Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtAttachIsoCommandWrapper, LibvirtAttachIsoCommandWrapper 
and LibvirtAttachIsoCommandWrapper
  - 7 unit tests added
  - KVM hypervisor plugin with 11.5% coverage

commit 40886b337c953378b93c03c899f801bb24e3aff6
Author: wilderrodrigues 
Date:   2015-04-23T12:44:13Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtAttachVolumeCommandWrapper
  - 3 unit tests added
  - KVM hypervisor plugin with 11.7% coverage

commit 08a9523dcdd5b4d736c4ef29b9ea93daa2b6e400
Author: wilderrodrigues 
Date:   2015-04-23T12:46:09Z

Fixing assertion on the tests that are execting exceptions

commit 7319a12600a7823aef8167348ee66a74a43ede8b
Author: wilderrodrigues 
Date:   2015-04-24T09:49:00Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtCheckConsoleProxyLoadCommandWrapper, 
LibvirtConsoleProxyLoadCommandWrapper, 
LibvirtWatchConsoleProxyLoadCommandWrapperand 
CitrixConsoleProxyLoadCommandWrapper
  - 2 unit tests added
  - KVM hypervisor plugin with 12% coverage

Refactored the CommandWrapper interface in order to remove the 
esecuteProxyLoadScan, which is now
implemented bu subclasses.

commit f14c7c207494c1c01d73713f6a2c4ab5452d07e9
Author: wilderrodrigues 
Date:   2015-04-24T11:17:58Z

Refactoring the LibvirtComputingResource
  - Adding LibvirtGetVncPortCommandWr

[GitHub] cloudstack pull request: Automation for feature Enable configuring...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/252


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8471:Automation for feature En...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/253

CLOUDSTACK-8471:Automation for feature Enable configuring local storage use 
for system VMs at zone level

CLOUDSTACK-8471

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack CLOUDSTACK-8301

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #253


commit cc93b151123ee0da79d263b37674d1a8f181ea80
Author: nitt10prashant 
Date:   2015-05-14T11:32:23Z

CLOUDSTACK-8471:Automation for feature Enable configuring local storage use 
for system VMs at zone level




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack-8301

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/263#issuecomment-104206860
  
List service offerings for systemvms and verify there should be two ... === 
TestName: test_01_list_system_offerngs_1_consoleproxy | Status : SUCCESS ===
ok
List service offerings for systemvms and verify there should be two ... === 
TestName: test_01_list_system_offerngs_2_secondarystoragevm | Status : SUCCESS 
===
ok
List service offerings for systemvms and verify there should be two ... === 
TestName: test_01_list_system_offerngs_3_domainrouter | Status : SUCCESS ===
ok
List service offerings for systemvms and verify there should be two ... === 
TestName: test_01_list_system_offerngs_4_internalloadbalancervm | Status : 
SUCCESS ===
ok
Check if system vms are honouring zone level setting ... === TestName: 
test_02_system_vm_storage_1_consoleproxy | Status : SUCCESS ===
ok
Check if system vms are honouring zone level setting ... === TestName: 
test_02_system_vm_storage_2_secondarystoragevm | Status : SUCCESS ===
ok
update global setting with system offering and check if it is being ... === 
TestName: test_03_custom_so_1_consoleproxy | Status : SUCCESS ===
ok
update global setting with system offering and check if it is being ... === 
TestName: test_03_custom_so_2_secondarystoragevm | Status : SUCCESS ===
ok
Check if router  vm is honouring zone level setting ... === TestName: 
test_04_router_vms | Status : SUCCESS ===
ok

--
Ran 9 tests in 3201.200s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/507

CLOUDSTACK-8577: fixing script  testpath_disable_enable_zone

disable enable cluster ... === TestName: test_01_disable_enable_cluster | 
Status : SUCCESS ===
ok
disable enable host ... === TestName: test_01_disable_enable_host | Status 
: SUCCESS ===
ok
disable enable Pod ... === TestName: test_01_disable_enable_pod | Status : 
SUCCESS ===
ok
disable enable zone ... === TestName: test_01_disable_enable_zone | Status 
: SUCCESS ===
ok

--
Ran 4 tests in 2818.119s

OK

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack enable_zone

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #507


commit 4554ae7eb793ad1a519e5b96d938f380218a18fa
Author: nitt10prashant 
Date:   2015-06-22T12:55:39Z

CLOUDSTACK-8577: fixing script  testpath_disable_enable_zone




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8583 :fixing issue related to ...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/518

CLOUDSTACK-8583 :fixing issue related to script test_stopped_vm

ested

Test Deploy Virtual Machine with startVM=true parameter ... === TestName: 
test_02_deploy_vm_startvm_true | Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false and attach volume already 
attached to different machine ... === TestName: test_08_deploy_attached_volume 
| Status : SUCCESS ===
ok
Test Deploy Virtual Machine with startVM=false & enabledpassword in ... === 
TestName: test_deploy_vm_password_enabled | Status : SUCCESS ===
ok

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack stop_vm

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #518


commit 4577af7206f57497a529f43f4ab18a212a144d6b
Author: nitt10prashant 
Date:   2015-06-24T07:01:23Z

CLOUDSTACK-8583 :fixing issue related to script test_stopped_vm




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/960

CLOUDSTACK-8975:skip test case if niciraNvp settings are not available in 
config file

root/cloudstack/test/integration/smoke/test_nicira_controller.py is failing 
if niciraNvp settings are not available in config file. Modifying script to 
skip test case if settings are not available 

test result
===
test_01_nicira_controller 
(integration.smoke.test_nicira_controller.TestNiciraContoller) ... SKIP: nicira 
settings not found in config file
Nicira clusters will redirect clients (in this case ACS) to the master 
node. ... SKIP: nicira settings not found in config file

--
Ran 2 tests in 0.001s

OK (SKIP=2)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack nicira

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #960


commit 07b32dfa61cdaa5ed7140ce577cce2fdcfaf79e0
Author: nitt10prashant 
Date:   2015-10-21T10:39:47Z

CLOUDSTACK-8975:skip test case if niciraNvp settings are not available in 
config file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/960#issuecomment-150161922
  
@miguelaferreira  i  was going though mail thread and found this 
"I think the test should fail if the config is not right, or otherwise be 
excluded if the indentation is to not run them." 
My comment 
1-For not right nicira settings , test case will fail
2-It will skip only if nicira settings are not present in config file

skipping test case or excluding it from a run ?
I would prefer skipping based on config file with proper message in test 
results .
To exclude  test file  you  have to  modify the job which will be painful 
if i have to do it for a number of test scripts .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/960#issuecomment-150501158
  
@runseb
"I personally fail to see the benefit of skipped tests versus a failed test"
If i may ,
skip  is a type of failure where you know in advance  about failure  , 
since you know about the failure you just Handle them  in order to 
differentiate from a general failure(may be product issue).So its all about 
categorizing  the failure  like expected failure and unexpected failure 

Its about how you see reports 
If you accept skip as known failure then 100% success on BVT ~ 20% of 
skipped =80% success with 20% of known failure ,at least not a product issue 
which you can say  without looking at particular script .
Without skip  you have to analyze each and every failure then you may come 
up with % of product  issue and % of failure due to setup an all

    "While @nitt10prashant and @pvr9711 you seem to want 100% success on BVT 
even if it includes some tests that are actually not run."
My comment:
1-Not run test cases are  the  one which are not picked up by runner may be 
coz of different tags and those test cases will not appear  in your report 
2-skipped test case are the one which are picked up by runner but due to 
non availability of configurations or some other reasons  could not run 
completely  and they will appear in your report .
3-I want 100% success on BVT  without any skip  if all the setup config is 
available .incase they are not i would prefer to skip them in order to find out 
real failure  which does not include any failure because of setup/configuration 
 just by looking at my report .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/960#issuecomment-151720250
  
based on discussion closing the PR 
Thanks @remibergsma @runseb @miguelaferreira @pvr9711  for great discussion 
.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/960


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-153285936
  
LGTM based on code review.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-153287076
  
LGTM  Based on code understanding

One line change  if attribute is there then proceed to cleanup  if 
hasattr(self, "data_volume_created"): 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/1153

CLOUDSTACK-9087:adding projectid parameter to create method of class 
VmSnapshot

Adding projectid parameter to class VmSnapshot of base.py .

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack mvr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1153


commit bf24ad8099366a3f17bc4e3a94236a75a2e673de
Author: nitt10prashant 
Date:   2015-11-26T10:57:15Z

CLOUDSTACK-9087:adding projectid parameter to create method of class 
VmSnapshot




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1153#issuecomment-161931625
  
@pdube you are right projectid is not required , i did check API doc but 
got confused with UI and took it as doc bug.
when createVMSnapshot is being called from UI it passes projectid which is 
ignored by API.

http://*.*.*.*:8080/client/api?command=createVMSnapshot&virtualmachineid=cdf1991b-211c-4d18-a2c8-bbeb3dc23110&snapshotmemory=false&quiescevm=false&name=sd&response=json&projectid=a899bd21-7be6-4113-8cc2-e81771e0c0a1&_=1449223237150

thank , i am closing it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/1153


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/507


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

[nitt10prashant]

GitHub user nitt10prashant reopened a pull request:

https://github.com/apache/cloudstack/pull/507

CLOUDSTACK-8577: fixing script  testpath_disable_enable_zone

disable enable cluster ... === TestName: test_01_disable_enable_cluster | 
Status : SUCCESS ===
ok
disable enable host ... === TestName: test_01_disable_enable_host | Status 
: SUCCESS ===
ok
disable enable Pod ... === TestName: test_01_disable_enable_pod | Status : 
SUCCESS ===
ok
disable enable zone ... === TestName: test_01_disable_enable_zone | Status 
: SUCCESS ===
ok

--
Ran 4 tests in 2818.119s

OK

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack enable_zone

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #507


commit 4554ae7eb793ad1a519e5b96d938f380218a18fa
Author: nitt10prashant 
Date:   2015-06-22T12:55:39Z

CLOUDSTACK-8577: fixing script  testpath_disable_enable_zone

commit 10afc3bba339084d10abafa16ec7dccaacfb81c5
Author: nitt10prashant 
Date:   2015-06-22T13:05:40Z

 CLOUDSTACK-8577: fixing script  testpath_disable_enable_zone




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/507


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/565

CLOUDSTACK-8615 :skip all tests in test_ps_limits.py for lxc

issue
---
All test cases are failing due to unsupported storage type

solution
---
skip test if supported storage type(for lxc hyp) is not present

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack ps

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #565


commit 238aca38f208aecd40dcb90d33a1559e38c3a8b7
Author: nitt10prashant 
Date:   2015-07-07T11:30:19Z

CLOUDSTACK-8615 :skip all tests in test_ps_limits.py for lxc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/565#issuecomment-119188008
  
Test assign Vm to different account ... SKIP: unsupported storage type
Test assign Vm to different account ... SKIP: unsupported storage type
Stop attach and detach volume from VM ... SKIP: unsupported storage type
Stop attach and detach volume from VM ... SKIP: unsupported storage type
Test create multiple volumes ... SKIP: unsupported storage type
Test create multiple volumes ... SKIP: unsupported storage type
Test create snapshot and templates from volume ... SKIP: unsupported 
storage type
Test create snapshot and templates from volume ... SKIP: unsupported 
storage type
Test Deploy multiple VMs with & verify the usage ... SKIP: unsupported 
storage type
Test Deploy multiple VMs with & verify the usage ... SKIP: unsupported 
storage type
Test delete and recover instance ... SKIP: skip
Test delete and recover instance ... SKIP: skip
Test Deploy VM with 5 GB volume & verify the usage ... SKIP: unsupported 
storage type
Test Deploy VM with 5 GB volume & verify the usage ... SKIP: unsupported 
storage type

--
Ran 14 tests in 2.833s

OK (SKIP=14)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/567

CLOUDSTACK-8583 : fixing issue related to script test/integration/com…

issue
---
Few testcases are failing  because of unsupported storage type .Deploy vm 
with data disk is failing.

solution
--
Deploying vm without data disk for the test cases which does not required 
data disk. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack stop_vm

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/567.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #567


commit c35a869985c7f37ccc438d1a144c1b3e0fa5c14c
Author: nitt10prashant 
Date:   2015-07-08T09:12:24Z

CLOUDSTACK-8583 : fixing issue related to script 
test/integration/component/test_stopped_vm.py




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Privtmpl

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/566#discussion_r34134668
  
--- Diff: test/integration/component/test_project_template.py ---
@@ -0,0 +1,172 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from marvin.codes import FAILED, PASS
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import Account, VirtualMachine, 
ServiceOffering,Project,Network,NetworkOffering,Domain,Volume,Template
+from marvin.lib.common import get_zone, get_domain, get_template
+from marvin.lib.utils import cleanup_resources
+from nose.plugins.attrib import attr
+
+
+
+class TestProjectPrivateTemplate(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestProjectPrivateTemplate, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.cleanup = []
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = template.id
+
+cls.services["medium"]["zoneid"] = cls.zone.id
+cls.services["medium"]["template"] = template.id
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+)
+
+cls.new_domain = Domain.create(
+   cls.apiclient,
+   cls.services["domain"],
+   )
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.new_domain.id
+)
+
+cls.debug(cls.account.id)
+#Fetch an api client with the user account created
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+@attr(tags=["advanced"])
+def test_project_private_template(self):
+self.api_client = 
self.testClient.getUserApiClient(UserName=self.account.name, 
DomainName=self.account.domain)
+
+#Create a new project using the account created
+self.project = 
Project.create(self.api_client,self.services["project"],account=self.account.name,domainid=self.new_domain.id)
+self.debug("The project has been created")
+
+self.network_offering = NetworkOffering.create(
+self.apiclient,
+self.services["network_offering"],
+)
+# Enable Network offering
+self.network_offering.update(self.apiclient, state='Enabled')
+
+self.services["network"]["networkoffering"] = 
self.network_offering.id
+
+
+
+   

[GitHub] cloudstack pull request: Privtmpl

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/566#discussion_r34134700
  
--- Diff: test/integration/component/test_project_template.py ---
@@ -0,0 +1,172 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from marvin.codes import FAILED, PASS
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import Account, VirtualMachine, 
ServiceOffering,Project,Network,NetworkOffering,Domain,Volume,Template
+from marvin.lib.common import get_zone, get_domain, get_template
+from marvin.lib.utils import cleanup_resources
+from nose.plugins.attrib import attr
+
+
+
+class TestProjectPrivateTemplate(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestProjectPrivateTemplate, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.cleanup = []
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = template.id
+
+cls.services["medium"]["zoneid"] = cls.zone.id
+cls.services["medium"]["template"] = template.id
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+)
+
+cls.new_domain = Domain.create(
+   cls.apiclient,
+   cls.services["domain"],
+   )
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.new_domain.id
+)
+
+cls.debug(cls.account.id)
+#Fetch an api client with the user account created
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+@attr(tags=["advanced"])
+def test_project_private_template(self):
+self.api_client = 
self.testClient.getUserApiClient(UserName=self.account.name, 
DomainName=self.account.domain)
+
+#Create a new project using the account created
+self.project = 
Project.create(self.api_client,self.services["project"],account=self.account.name,domainid=self.new_domain.id)
+self.debug("The project has been created")
+
+self.network_offering = NetworkOffering.create(
+self.apiclient,
+self.services["network_offering"],
+)
+# Enable Network offering
+self.network_offering.update(self.apiclient, state='Enabled')
+
+self.services["network"]["networkoffering"] = 
self.network_offering.id
+
+
+
+   

[GitHub] cloudstack pull request: Privtmpl

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/566#discussion_r34134758
  
--- Diff: test/integration/component/test_user_taglisting.py ---
@@ -0,0 +1,129 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ NetworkOffering,
+ Network,
+ Tag
+)
+from marvin.lib.common import (get_domain,
+get_zone,
+get_template)
+from marvin.lib.utils import cleanup_resources
+from marvin.cloudstackAPI import *
+from nose.plugins.attrib import attr
+from marvin.codes import FAILED, PASS
+
+class TestDeployVMWithTags(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.apiclient = cls.testClient.getApiClient()
+cls.dbclient = cls.testClient.getDbConnection()
+cls.cleanup = []
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.cleanup.append(cls.account)
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = template.id
+
+cls.services["medium"]["zoneid"] = cls.zone.id
+cls.services["medium"]["template"] = template.id
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+)
+
+cls.cleanup.append(cls.service_offering)
+cls.api_client = 
cls.testClient.getUserApiClient(UserName=cls.account.name, 
DomainName=cls.account.domain)
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+@attr(tags=["advanced","sg"])
+def test_deploy_vm_with_tags(self):
+"""Test Deploy Virtual Machine
+"""
+# Validate the following:
+# 1. User tags are created for VM
+# 2. listing the tags for the VM will list the tag only once and 
doesn't list the same tag multiple times
+self.virtual_machine = VirtualMachine.create(
+self.api_client,
+self.services["small"],
+serviceofferingid=self.service_offering.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+zoneid=self.zone.id
+)
+
+tag1 = Tag.create(
+self.apiclient,
   

[GitHub] cloudstack pull request: Privtmpl

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/566#discussion_r34134916
  
--- Diff: test/integration/component/test_project_template.py ---
@@ -0,0 +1,172 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from marvin.codes import FAILED, PASS
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import Account, VirtualMachine, 
ServiceOffering,Project,Network,NetworkOffering,Domain,Volume,Template
+from marvin.lib.common import get_zone, get_domain, get_template
+from marvin.lib.utils import cleanup_resources
+from nose.plugins.attrib import attr
+
+
+
+class TestProjectPrivateTemplate(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestProjectPrivateTemplate, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.cleanup = []
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = template.id
+
+cls.services["medium"]["zoneid"] = cls.zone.id
+cls.services["medium"]["template"] = template.id
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+)
+
+cls.new_domain = Domain.create(
+   cls.apiclient,
+   cls.services["domain"],
+   )
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.new_domain.id
+)
+
+cls.debug(cls.account.id)
+#Fetch an api client with the user account created
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+@attr(tags=["advanced"])
+def test_project_private_template(self):
+self.api_client = 
self.testClient.getUserApiClient(UserName=self.account.name, 
DomainName=self.account.domain)
+
+#Create a new project using the account created
+self.project = 
Project.create(self.api_client,self.services["project"],account=self.account.name,domainid=self.new_domain.id)
+self.debug("The project has been created")
+
+self.network_offering = NetworkOffering.create(
+self.apiclient,
+self.services["network_offering"],
+)
+# Enable Network offering
+self.network_offering.update(self.apiclient, state='Enabled')
+
+self.services["network"]["networkoffering"] = 
self.network_offering.id
+
+
+
+   

[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/570

CLOUDSTACK-8620 :skip test cases if rbd storage is not available in l…

skipping tests based on storage for lxc hype and fixing pep8 issues 
test result
=
Test increasing volume size within the account limit and verify primary 
storage usage ... SKIP: unsupported storage type
Test increasing volume size above the account limit ... SKIP: unsupported 
storage type
Test increasing volume size above the domain limit ... SKIP: unsupported 
storage type

--
Ran 3 tests in 2.236s

OK (SKIP=3)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack lxc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/570.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #570


commit 7486f6fcb247a35ab7f139713796dc6647f80c09
Author: nitt10prashant 
Date:   2015-07-09T09:09:51Z

CLOUDSTACK-8620 :skip test cases if rbd storage is not available in lxc 
setup




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/569#issuecomment-119887574
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/569#discussion_r34238492
  
--- Diff: test/integration/component/test_blocker_bugs.py ---
@@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self):
 #all it's services should resume
 
 # Find router associated with user account
-list_router_response = list_routers(
--- End diff --

Since list  router vm is getting called multiple time based on zone 
networking type  , can we use a function which list router vm based on 
networking type .
Please ignore the comment if you feel it is not required .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/569#issuecomment-119913350
  
LGTM 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8626 :[Automation]fixing test/...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/579

CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_p…

…s_max_limits.py for lxc hypervisor

test results

Test Try to deploy VM with admin account where account has used ... === 
TestName: test_02_deploy_vm_account_limit_reached | Status : SUCCESS ===
ok
Test TTry to deploy VM with admin account where account has not used ... 
=== TestName: test_03_deploy_vm_project_limit_reached | Status : SUCCESS ===
ok

--
Ran 2 tests in 579.271s

OK


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack ps_mx_limits

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/579.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #579


commit 85235d89dfa66c675b964ceebbb49a61c1205f8b
Author: nitt10prashant 
Date:   2015-07-13T05:31:11Z

CLOUDSTACK-8626 :[Automation]fixing 
test/integration/component/test_ps_max_limits.py for lxc hypervisor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/585

CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limit…

test result

Test Try to deploy VM with admin account where account has not used ... === 
TestName: test_01_deploy_vm_domain_limit_reached | Status : SUCCESS ===
ok
Test Try to deploy VM with admin account where account has used ... === 
TestName: test_02_deploy_vm_account_limit_reached | Status : SUCCESS ===
ok
Test TTry to deploy VM with admin account where account has not used ... 
=== TestName: test_03_deploy_vm_project_limit_reached | Status : SUCCESS ===
ok

--
Ran 3 tests in 440.349s


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack ss_mx_limits

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #585


commit 6d8cf3109195a896f2161a02f20d9401a3a67683
Author: nitt10prashant 
Date:   2015-07-14T09:38:58Z

CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limits.py




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/585#issuecomment-121210527
  
its there in ticket

On Tue, Jul 14, 2015 at 5:03 PM, sanju1010  wrote:

> Can you please specify the reason for changing the if condition for the
> benefit of others?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/585#issuecomment-121210285>.
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/595

CLOUDSTACK-8639:fixing calculation mistakes in component/test_ss_doma…

test result
=
Test secondary storage limit of domain and its sub-domains ... === 
TestName: test_04_create_template_delete_account | Status : SUCCESS ===
ok

--
Ran 1 test in 175.563s

OK

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack ss_domain_limit

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #595


commit 2b0261fd87eb0e8d9f770cb989adbcb586d215cc
Author: nitt10prashant 
Date:   2015-07-15T13:03:00Z

CLOUDSTACK-8639:fixing calculation mistakes in 
component/test_ss_domain_limits.py




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8659: Verify presentation of v...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/613#discussion_r35197771
  
--- Diff: test/integration/testpaths/testpath_uuid_event.py ---
@@ -0,0 +1,198 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test cases to verify presentation of volume id in events table 
+for 'SNAPSHOT.CREATE' type.
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+ validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ Snapshot,
+ VirtualMachine,
+Configurations
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+  )
+
+from marvin.codes import PASS
+
+
+
+
+class TestVerifyEventsTable(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestVerifyEventsTable, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+try:
+
+cls.unsupportedHypervisor = False
+if cls.hypervisor.lower() in ['hyperv', 'lxc', 'kvm']:
+   if cls.hypervisor.lower() == 'kvm':
+   configs = Configurations.list(
+   cls.apiclient,
+   name='kvm.snapshot.enabled'
+   )
--- End diff --

use of validateList  required


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/619#issuecomment-125107406
  
LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/638#issuecomment-126589627
  
can you post test results ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/638#issuecomment-126656909
  
LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed "medium" dictionary from test_dat...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/644#issuecomment-127186217
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/158#issuecomment-127891937
  
 enabled = enabled if enabled else 'true' 
 will set enable to true if  enable is false or None  which is unexpected,
 ideally  enable should be false if it is false in config file else true 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/671#issuecomment-129401139
  
Looks Good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/675#discussion_r36731289
  
--- Diff: test/integration/testpaths/testpath_usage.py ---
@@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self):
 # aggregation period and current period will give the network usage
 return
 
+@attr(tags=["advanced", "basic"], required_hardware="false")
+def test_08_checkNewVolumein_listUsageRecords(self):
+""" Test case to check if new volume crated after
+restore VM is listed in listUsageRecords
+# 1. Launch a VM
+# 2. Restore the VM
+# 3. Check if the new volume created is listed in listUsageRecords 
API
+"""
+
+# Step 1
+vm_cluster = VirtualMachine.create(
+self.userapiclient,
+self.testdata["small"],
+templateid=self.template.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+)
+
+volumes_root_list = list_volumes(
+self.apiclient,
+virtualmachineid=vm_cluster.id,
+type='ROOT',
+listall=True
+)
--- End diff --

use validate list  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/675#discussion_r36732367
  
--- Diff: test/integration/testpaths/testpath_usage.py ---
@@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self):
 # aggregation period and current period will give the network usage
 return
 
+@attr(tags=["advanced", "basic"], required_hardware="false")
+def test_08_checkNewVolumein_listUsageRecords(self):
+""" Test case to check if new volume crated after
+restore VM is listed in listUsageRecords
+# 1. Launch a VM
+# 2. Restore the VM
+# 3. Check if the new volume created is listed in listUsageRecords 
API
+"""
+
+# Step 1
+vm_cluster = VirtualMachine.create(
+self.userapiclient,
+self.testdata["small"],
+templateid=self.template.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+)
+
+volumes_root_list = list_volumes(
+self.apiclient,
+virtualmachineid=vm_cluster.id,
+type='ROOT',
+listall=True
+)
+
+root_volume = volumes_root_list[0]
+
+# Step 2
+vm_cluster.restore(self.apiclient)
+
+qresultset = self.dbclient.execute(
+"select id from volumes where name='%s' and state='Ready';" %
+root_volume.name)
+
+self.assertNotEqual(
+len(qresultset),
+0,
+"Check DB Query result set"
+)
+
+volumeCheck = "Volume Id: " + str(qresultset[0][0]) + " usage time"
+
+response = self.listUsageRecords(usagetype=6)
+self.assertEqual(response[0], PASS, response[1])
+UsageRecords = [record for record in response[1]
+if volumeCheck in record.description]
+# Step 3
+self.assertNotEqual(
--- End diff --

even  if  UsageRecords is empty test case will pass , is that we are 
expecting ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-129836794
  
can we get test result ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/667#discussion_r36733719
  
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""
+Test restore running VM on VMWare with one cluster having 2 Primary Storage
+"""
+
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+   list_virtual_machines
+   )
+
+from marvin.codes import CLUSTERTAG1, ROOT
+import time
+
+
+class TestRestoreVM(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestRestoreVM, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+try:
+cls.skiptest = False
+if cls.hypervisor.lower() not in ["vmware"]:
+cls.skiptest = True
+return
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_cwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=CLUSTERTAG1
+)
+cls._cleanup.append(cls.service_offering_cwps)
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("This test is to be checked on VMWare only \
+Hence, skip for %s" % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+
+@attr(tags=["advanced", "basic"], required_hardware="true")
+def te

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-129837984
  
can we get test results ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36733882
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test case for Multiple Volume Snapshot in ZWPS
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s" % self.hypervisor)
+
+self.apicli

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36734207
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test case for Multiple Volume Snapshot in ZWPS
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s" % self.hypervisor)
+
+self.apicli

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36734361
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test case for Multiple Volume Snapshot in ZWPS
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s" % self.hypervisor)
+
+self.apicli

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36735392
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test case for Multiple Volume Snapshot in ZWPS
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s" % self.hypervisor)
+
+self.apicli

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-129846827
  
can you update test results ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/683#discussion_r36845123
  
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,264 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackAPI import *
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ Volume,
+ DiskOffering,
+ )
+from marvin.lib.common import (get_domain,
+get_zone,
+get_template,
+find_storage_pool_type)
+from marvin.codes import (
+PASS,
+FAILED,
+JOB_FAILED,
+JOB_CANCELLED,
+JOB_SUCCEEDED
+)
+from nose.plugins.attrib import attr
+import time
+
+
+class TestMultipleVolumeAttach(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeAttach, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls._cleanup = []
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = testClient.getHypervisorInfo()
+cls.invalidStoragePoolType = False
+#for LXC if the storage pool of type 'rbd' ex: ceph is not 
available, skip the test
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.apiclient, 
storagetype='rbd'):
+# RBD storage type is required for data volumes for LXC
+cls.invalidStoragePoolType = True
+return
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.services["disk_offering"]
+)
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services["ostype"]
+
+cls.services["domainid"] = cls.domain.id
+cls.services["zoneid"] = cls.zone.id
+cls.services["template"] = template.id
+cls.services["diskofferingid"] = cls.disk_offering.id
+
+# Create VMs, VMs etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=cls.domain.id
+)
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+
cls.services["service_offering"]
+)
+cls.virtual_machine = VirtualMachine.create(
+cls.apiclient,
+cls.services,
+accountid=cls.account.name,
+domainid=cls.account

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/683#discussion_r36845173
  
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,264 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackAPI import *
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ Volume,
+ DiskOffering,
+ )
+from marvin.lib.common import (get_domain,
+get_zone,
+get_template,
+find_storage_pool_type)
+from marvin.codes import (
+PASS,
+FAILED,
+JOB_FAILED,
+JOB_CANCELLED,
+JOB_SUCCEEDED
+)
+from nose.plugins.attrib import attr
+import time
+
+
+class TestMultipleVolumeAttach(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeAttach, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls._cleanup = []
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = testClient.getHypervisorInfo()
+cls.invalidStoragePoolType = False
+#for LXC if the storage pool of type 'rbd' ex: ceph is not 
available, skip the test
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.apiclient, 
storagetype='rbd'):
+# RBD storage type is required for data volumes for LXC
+cls.invalidStoragePoolType = True
+return
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.services["disk_offering"]
+)
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services["ostype"]
+
+cls.services["domainid"] = cls.domain.id
+cls.services["zoneid"] = cls.zone.id
+cls.services["template"] = template.id
+cls.services["diskofferingid"] = cls.disk_offering.id
+
+# Create VMs, VMs etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=cls.domain.id
+)
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+
cls.services["service_offering"]
+)
+cls.virtual_machine = VirtualMachine.create(
+cls.apiclient,
+cls.services,
+accountid=cls.account.name,
+domainid=cls.account

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/683#discussion_r36940905
  
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,256 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackAPI import *
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ Volume,
+ DiskOffering,
+ )
+from marvin.lib.common import (get_domain,
+get_zone,
+get_template,
+find_storage_pool_type)
+from marvin.codes import (
+PASS,
+FAILED,
+JOB_FAILED,
+JOB_CANCELLED,
+JOB_SUCCEEDED
+)
+from nose.plugins.attrib import attr
+import time
+
+
+class TestMultipleVolumeAttach(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeAttach, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls._cleanup = []
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = testClient.getHypervisorInfo()
+cls.invalidStoragePoolType = False
+#for LXC if the storage pool of type 'rbd' ex: ceph is not 
available, skip the test
+if cls.hypervisor.lower() == 'lxc':
+if not find_storage_pool_type(cls.apiclient, 
storagetype='rbd'):
+# RBD storage type is required for data volumes for LXC
+cls.invalidStoragePoolType = True
+return
+cls.disk_offering = DiskOffering.create(
+cls.apiclient,
+cls.services["disk_offering"]
+)
+
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services["ostype"]
+
+cls.services["domainid"] = cls.domain.id
+cls.services["zoneid"] = cls.zone.id
+cls.services["template"] = template.id
+cls.services["diskofferingid"] = cls.disk_offering.id
+
+# Create VMs, VMs etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=cls.domain.id
+)
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+
cls.services["service_offering"]
+)
+cls.virtual_machine = VirtualMachine.create(
+cls.apiclient,
+cls.services,
+accountid=cls.account.name,
+domainid=cls.account

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/683#issuecomment-130587552
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: test case automated for list template pag...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/646#issuecomment-130588174
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/713

CLOUDSTACK-8745 : verify usage after root disk migration

put storage in maintenance mode and start ha vm and check usage ... === 
TestName: test_ha_with_storage_maintenance | Status : SUCCESS ===
ok

--
Ran 1 test in 842.294s

OK

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack pool_maint

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/713.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #713


commit d276a3579f7f055b5431575a5bb498d96dfc9f45
Author: nitt10prashant 
Date:   2015-08-18T11:23:54Z

CLOUDSTACK-8745 : verify usage after root disk migration




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/713#discussion_r37379373
  
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (enableStorageMaintenance,
+  cancelStorageMaintenance
+  )
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ Cluster,
+ StoragePool,
+ Volume)
+from marvin.lib.common import (get_zone,
+   get_domain,
+   get_template,
+   list_hosts
+   )
+from marvin.codes import PASS
+
+
+def maintenance(self, storageid):
+"""enables maintenance mode of a Storage pool"""
+
+cmd = enableStorageMaintenance.enableStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.enableStorageMaintenance(cmd)
+
--- End diff --

those methods can be used only with storage pool class object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/713#discussion_r37379426
  
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (enableStorageMaintenance,
+  cancelStorageMaintenance
+  )
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ Cluster,
+ StoragePool,
+ Volume)
+from marvin.lib.common import (get_zone,
+   get_domain,
+   get_template,
+   list_hosts
+   )
+from marvin.codes import PASS
+
+
+def maintenance(self, storageid):
+"""enables maintenance mode of a Storage pool"""
+
+cmd = enableStorageMaintenance.enableStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.enableStorageMaintenance(cmd)
+
+
+def cancelmaintenance(self, storageid):
+"""cancel maintenance mode of a Storage pool"""
+
+cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.cancelStorageMaintenance(cmd)
+
+
+class testHaPoolMaintenance(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+try:
+cls._cleanup = []
+cls.testClient = super(
+testHaPoolMaintenance,
+cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Domain, Zone, Template
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(
+cls.api_client,
+cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["virtual_machine"]["template"] = cls.template.id
+cls.clusterWithSufficientPool = None
+clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id)
+
+if not validateList(clusters)[0]:
+
+cls.debug(
+"check list cluster response for zone id %s" %
+cls.zone.id)
+
+for cluster in clusters:
+cls.pool = StoragePool.list(cls.api_client,
+clusterid=cluster.id,
+keyword="NetworkFilesystem"
+)
+
+if not validateList(cls.pool)[0]:
+
+cls.debug(
+"check list cluster response for zone id %s" %
+cls.zone.id)
+
+if len(cls.pool) >= 2:
+cls.clusterWithSufficientPool = clu

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/713#discussion_r37379748
  
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (enableStorageMaintenance,
+  cancelStorageMaintenance
+  )
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ Cluster,
+ StoragePool,
+ Volume)
+from marvin.lib.common import (get_zone,
+   get_domain,
+   get_template,
+   list_hosts
+   )
+from marvin.codes import PASS
+
+
+def maintenance(self, storageid):
+"""enables maintenance mode of a Storage pool"""
+
+cmd = enableStorageMaintenance.enableStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.enableStorageMaintenance(cmd)
+
+
+def cancelmaintenance(self, storageid):
+"""cancel maintenance mode of a Storage pool"""
+
+cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.cancelStorageMaintenance(cmd)
+
+
+class testHaPoolMaintenance(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+try:
+cls._cleanup = []
+cls.testClient = super(
+testHaPoolMaintenance,
+cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Domain, Zone, Template
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(
+cls.api_client,
+cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["virtual_machine"]["template"] = cls.template.id
+cls.clusterWithSufficientPool = None
+clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id)
+
+if not validateList(clusters)[0]:
+
+cls.debug(
+"check list cluster response for zone id %s" %
+cls.zone.id)
+
+for cluster in clusters:
+cls.pool = StoragePool.list(cls.api_client,
+clusterid=cluster.id,
+keyword="NetworkFilesystem"
+)
+
+if not validateList(cls.pool)[0]:
+
+cls.debug(
+"check list cluster response for zone id %s" %
+cls.zone.id)
+
+if len(cls.pool) >= 2:
+cls.clusterWithSufficientPool = clu

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/713#discussion_r37380762
  
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (enableStorageMaintenance,
+  cancelStorageMaintenance
+  )
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ Cluster,
+ StoragePool,
+ Volume)
+from marvin.lib.common import (get_zone,
+   get_domain,
+   get_template,
+   list_hosts
+   )
+from marvin.codes import PASS
+
+
+def maintenance(self, storageid):
+"""enables maintenance mode of a Storage pool"""
+
+cmd = enableStorageMaintenance.enableStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.enableStorageMaintenance(cmd)
+
+
+def cancelmaintenance(self, storageid):
+"""cancel maintenance mode of a Storage pool"""
+
+cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.cancelStorageMaintenance(cmd)
+
+
+class testHaPoolMaintenance(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+try:
+cls._cleanup = []
+cls.testClient = super(
+testHaPoolMaintenance,
+cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Domain, Zone, Template
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(
+cls.api_client,
+cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["virtual_machine"]["template"] = cls.template.id
+cls.clusterWithSufficientPool = None
+clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id)
+
+if not validateList(clusters)[0]:
+
+cls.debug(
+"check list cluster response for zone id %s" %
+cls.zone.id)
+
+for cluster in clusters:
+cls.pool = StoragePool.list(cls.api_client,
+clusterid=cluster.id,
+keyword="NetworkFilesystem"
+)
+
+if not validateList(cls.pool)[0]:
+
+cls.debug(
+"check list cluster response for zone id %s" %
+cls.zone.id)
+
+if len(cls.pool) >= 2:
+cls.clusterWithSufficientPool = clu

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/713#discussion_r37380740
  
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (enableStorageMaintenance,
+  cancelStorageMaintenance
+  )
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ Cluster,
+ StoragePool,
+ Volume)
+from marvin.lib.common import (get_zone,
+   get_domain,
+   get_template,
+   list_hosts
+   )
+from marvin.codes import PASS
+
+
+def maintenance(self, storageid):
+"""enables maintenance mode of a Storage pool"""
+
+cmd = enableStorageMaintenance.enableStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.enableStorageMaintenance(cmd)
+
+
+def cancelmaintenance(self, storageid):
+"""cancel maintenance mode of a Storage pool"""
+
+cmd = cancelStorageMaintenance.cancelStorageMaintenanceCmd()
+cmd.id = storageid
+return self.api_client.cancelStorageMaintenance(cmd)
+
+
+class testHaPoolMaintenance(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+try:
+cls._cleanup = []
+cls.testClient = super(
+testHaPoolMaintenance,
+cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Domain, Zone, Template
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(
+cls.api_client,
+cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["virtual_machine"]["template"] = cls.template.id
+cls.clusterWithSufficientPool = None
+clusters = Cluster.list(cls.api_client, zoneid=cls.zone.id)
+
+if not validateList(clusters)[0]:
+
+cls.debug(
+"check list cluster response for zone id %s" %
+cls.zone.id)
+
+for cluster in clusters:
+cls.pool = StoragePool.list(cls.api_client,
+clusterid=cluster.id,
+keyword="NetworkFilesystem"
+)
+
+if not validateList(cls.pool)[0]:
+
+cls.debug(
+"check list cluster response for zone id %s" %
+cls.zone.id)
+
+if len(cls.pool) >= 2:
+cls.clusterWithSufficientPool = clu

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/713#issuecomment-132476722
  
test result of enough storage is not available to perform test 

put storage in maintenance mode and start ha vm and check usage ... SKIP: 
sufficient storage not available in any cluster for zone 
90d85d89-01c4-4a91-b76e-eedf947b40f6

--
Ran 1 test in 4.059s

OK (SKIP=1)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-132583048
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Customer escalations

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/724#discussion_r37625731
  
--- Diff: test/integration/component/test_escalations_routers.py ---
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" P1 tests for alert receiving from VR on service failure in VR
+"""
+# Import Local Modules
+# import marvin
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (get_process_status, validateList,
+  cleanup_resources)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine)
+from marvin.lib.common import (list_hosts,
+   list_routers,
+   get_zone,
+   get_domain,
+   get_template)
+from nose.plugins.attrib import attr
+from marvin.codes import FAILED
+from marvin.codes import PASS
+
+_multiprocess_shared_ = True
+
+
+class TestVR(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls._cleanup = []
+cls.testClient = super(
+TestVR,
+cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+domain = get_domain(cls.api_client)
+cls.services['mode'] = cls.zone.networktype
+
+template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+
+if template == FAILED:
+assert False, "get_template() failed to return template with \
+   description %s" % cls.services["ostype"]
+# Set Zones and disk offerings ??
--- End diff --

remove  "??" .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [Automation]Volume migration between pool...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/742

[Automation]Volume migration between pools times out in ACS, but  but the 
migration completes on Xenserve


Ticket :CLOUDSTACK-8771

description:
Volume migration between pools times out in ACS, but the migration 
completes on Xenserver

steps:
-

test results

put storage in maintenance mode and start ha vm and check usage ... === 
TestName: test_migrate_volume_timeout | Status : SUCCESS ===
ok

--
Ran 1 test in 250.958s

OK


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack migrate_volume

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/742.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #742


commit d7f1f4b0c0b95f127be8353854e8d3d1cb609fb6
Author: nitt10prashant 
Date:   2015-08-25T12:25:11Z

CLOUDSTACK-8771:[Automation]Volume migration between pools times out in 
ACS, but the migration completes on Xenserver

Adding descriptions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/688#issuecomment-134972409
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/728#issuecomment-139530956
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [Automation]Volume migration between pool...

[nitt10prashant]

Github user nitt10prashant closed the pull request at:

https://github.com/apache/cloudstack/pull/742


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142493294
  
LGTM!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142820449
  
@remibergsma Next time sure  I will add some details .for this PR i have 
updated my comments .



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1417#issuecomment-220521199
  
@swill  i do not see any comment on parent ticket CLOUDSTACK-8676 , i have 
asked Sateesh to update the ticket , will update the PR as soon as i hear from 
him.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9389:changing check_string fro...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/1563

CLOUDSTACK-9389:changing check_string from 3 packets received to 3 re…



test cases were failing due to invalid check_string so changing 
check_string from "3 packets received" to "3 received" based on ping reply in 
centos vm.

[root@BPKxDmS ~]# ping -c 3 8.8.8.8
PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.
64 bytes from 8.8.8.8: icmp_seq=1 ttl=52 time=16.9 ms
64 bytes from 8.8.8.8: icmp_seq=2 ttl=52 time=16.7 ms
64 bytes from 8.8.8.8: icmp_seq=3 ttl=52 time=17.0 ms

— 8.8.8.8 ping statistics —
3 packets transmitted, 3 received, 0% packet loss, time 2020ms
rtt min/avg/max/mdev = 16.720/16.896/17.015/0.196 ms


test results
---
Prashants-MacBook-Pro:test_routers_network_ops_L62AAM prashant$ cat 
results.txt 
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok

--
Ran 2 tests in 1003.374s

OK


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack CI

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1563.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1563


commit a182376c34b5e59de7a0cd82949480b2b3ed5c94
Author: nitt10prashant 
Date:   2016-05-26T10:47:51Z

CLOUDSTACK-9389:changing check_string from 3 packets received to 3 received




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1563#issuecomment-222438208
  
test result

Prashants-MacBook-Pro:test_routers_network_ops_TWUWR8 prashant$ cat 
results.txt 
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok

--
Ran 5 tests in 1752.174s

OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1563#issuecomment-222439377
  
@swill i don't see any issue in my setup , please checktest result 
[results.txt](https://github.com/apache/cloudstack/files/289139/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/289140/runinfo.txt)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1563#issuecomment-222635435
  
@koushik-das as you have asked done following 
1- moved check_string to test_data.py
2-provided test result  
can you review changes .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9396:fixing issue related to s...

[nitt10prashant]

GitHub user nitt10prashant opened a pull request:

https://github.com/apache/cloudstack/pull/1573

CLOUDSTACK-9396:fixing issue related to script test_dhcphosts

fixing following
1-issue related to check_String:changed check string to "3 received" and 
use test_data
2-ssh to router based on hypervisor type : check if it is vmware ssh to ms 
else ssh to host
3-rename method : because of test_ methods were getting picked up as a test 
cases ,renamed them not to get picked up as a test method

test result
-
Prashants-MacBook-Pro:test_router_dhcphosts_YDZJFT prashant$ cat 
results.txt 
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok

--
Ran 1 test in 385.178s

OK
[results.txt](https://github.com/apache/cloudstack/files/290716/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/290717/runinfo.txt)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitt10prashant/cloudstack CI1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1573


commit 051f9aa09c25ab201857dee8584e66fea1307beb
Author: nitt10prashant 
Date:   2016-05-31T09:20:41Z

CLOUDSTACK-9396:fixing issue related to script test_dhcphosts




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test_routers_n...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1563
  
@swill  My MS is running on Rhel6.3 , in script we are doing ssh to guest 
vm and then trying to ping 8.8.8.8 so ping is dependent on guest template OS , 
in my case i am using default temple which is CentOS 6.5.

code snippet 
 ssh_command = "ping -c 3 8.8.8.8"
check_string = "3  received"
result = check_router_command(virtual_machine, nat_rule.ipaddress, 
ssh_command, check_string, self)

self.assertEqual(
 result,
 expected,
 "Ping to outside world from VM should be 
successful!"
 )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test_routers_n...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1563
  
@swill  Thinking about 3(.*?) received  , i have placed check_string in 
test_data.py , which can be modified depend on guest OS type . I followed cent 
os ping pattern since most of us use default template.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...

[nitt10prashant]

Github user nitt10prashant commented on the issue:

https://github.com/apache/cloudstack/pull/1563
  
-->I think it is important that the test data does not need to be changed 
for our automated(ish) CI to show the tests are passing
@swill  i think test-data meant to be changed depend on your local 
environment and every one should have local copy of their own test data .



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...

[nitt10prashant]

Github user nitt10prashant commented on the issue:

https://github.com/apache/cloudstack/pull/1563
  
@swill just curious  to know Which guest OS you are using ? Since Cent OS 
template is default in ACS i modified test_data for cent OS.  

Regx should be consider ?
->I Agree with you, will push changes for regx  to make sure it work for 
both ping pattern .

What do you think? Sorry, I don't mean to be combative here, but this is a 
good opertunity for us to review the way we handle OS specific test data.
->Yes this should be  discussed thoroughly and should be documented  
properly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1377#issuecomment-188173843
  
this is redundant case , and checking time to create vmsnapshot is not 
required for this bug.
I have talked to @sarathkouk , he understood the issue and agreed to modify 
the PR to CATH this specific bug.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/713#issuecomment-191098254
  
sure 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1417#discussion_r55160105
  
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Import Local Modules
+from marvin.codes import FAILED, PASS
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import seedTemplateFromVmSnapshot
+from marvin.lib.utils import cleanup_resources, validateList
+from marvin.lib.base import (Account,
+ DiskOffering,
+ ServiceOffering,
+ VirtualMachine,
+ VmSnapshot,
+ Volume)
+from marvin.lib.common import (get_zone,
+   get_domain,
+   get_template)
+import urllib
+import tempfile
+import os
+import time
+from functools import reduce
+
+
+class TestDeployVm(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVm, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls._cleanup = []
+cls.unsupportedHypervisor = False
+cls.hypervisor = testClient.getHypervisorInfo()
+if not cls.hypervisor.lower() in "vmware":
+cls.unsupportedHypervisor = True
+return
+
+cls.services = testClient.getParsedTestDataConfig()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+template = get_template(
--- End diff --

@GabrielBrascher  thanks for reviewing it 
1-ExtractVolumeFromVmSnapshot class uses cls.template because 
test_03_create_volume_from_vmsnapshot uses the self.template, but in class 
TestDeployVm i am not using template to deploy vm in any test cases thats why i 
did not declare it as a class variable 
2-Agreed on redundant code in 
test_02_create_vm_from_vmsnapshots_and_verify_data , ill push modified code as 
soon as i get some time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1417#issuecomment-198314365
  
@GabrielBrascher  @sanju1010  i have removed redundant code 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60531171
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
--- End diff --

utils.py have a method validateList to check the response and instance type 
, can please you use it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

[nitt10prashant]

Github user nitt10prashant commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60531417
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
--- End diff --

if vm_respone is empty addressing zeroth element will error out,Can you 
please use validate list and provide proper debug message 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1501#issuecomment-212767179
  
LGTM  based on code review @mike-tutkowski can you provide  test results 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---