[GitHub] cloudstack-docs-install pull request: doc for enabling CSP support...

2014-05-05 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/9

doc for enabling CSP support on xenserver 6.1

https://issues.apache.org/jira/browse/CLOUDSTACK-6574

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs-install patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit caef894287994bb28bb34f2f556dc026536c61ae
Author: Rajani Karuturi 
Date:   2014-05-05T11:02:42Z

doc for enabling CSP support on xenserver 6.1

https://issues.apache.org/jira/browse/CLOUDSTACK-6574




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@sateesh-chodapuneedi can you take a look at the test failures as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
@rhtyd missed this one. Thanks for reminding. merging now.
@milamberspace  Thanks for keeping the translations updated for every 
release :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
@milamberspace  Should the merge to master be an empty merge? Meaning is 
this only for 4.9??


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@nvazquez Are you looking at the test failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #865: CLOUDSTACK-8856 Primary Storage Used(type tag with va...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/865
  
merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #838: CLOUDSTACK-8857 listProjects doesn't return tags vmst...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/838
  
good fix. merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/927
  
@serg38 Thanks for filtering the error :) My tests run has been with 
encryption disabled. I think trillion runs with db encryption enabled. I will 
check on how I can decrypt the value in tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@DaanHoogland Can you post test results?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1927: ipv6: Set IPv6 CIDR and Gateway in 'nic' profile

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1927
  
merging this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
@ustcweizhou can you review the updated code? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
@rhtyd @borisstoyanov can you run tests on this pr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
@blueorangutan @rhtyd @borisroman vmware tests please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov can you post test results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
@priyankparihar can you run internal CI and post @cloudmonger test results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
after code changes, suresh requested for another test run on vmware.
@rhtyd @borisroman can you run vmware tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
Actually, BVT is not going to verify this as this is db upgrade related and 
travis would have tested it. 
I am merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
Both #1829 and #1941 are merged and is causing build failures. I am 
creating new PR with the revert.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1976: Revert "Merge pull request #1829 from syed/hv...

2017-02-27 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/1976

Revert "Merge pull request #1829 from syed/hvm-volume-attach-restart-fix"


This reverts commit d9bd01266ffb23f591283c058beff6e65d1cc4aa, reversing
changes made to ea7c48cf6127aeb73c1d25d7bcee52120ab85204.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack revert-1829

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1976.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1976


commit 0a18d19e8cb30ecfd546d34afb0b0bfaa05c9c80
Author: Rajani Karuturi 
Date:   2017-02-28T06:21:46Z

Revert "Merge pull request #1829 from syed/hvm-volume-attach-restart-fix"

This reverts commit d9bd01266ffb23f591283c058beff6e65d1cc4aa, reversing
changes made to ea7c48cf6127aeb73c1d25d7bcee52120ab85204.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1976: Revert "Merge pull request #1829 from syed/hv...

2017-02-27 Thread karuturi
Github user karuturi closed the pull request at:

https://github.com/apache/cloudstack/pull/1976


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1976: Revert "Merge pull request #1829 from syed/hvm-volum...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1976
  
This is not going to fix the build issue. The issue is different. I will 
open a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/1977

fixed the merge conflict on merging #1941



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack build-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1977.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1977


commit 8402ee635c089a07230cfbe7f971451f959d46ba
Author: Rajani Karuturi 
Date:   2017-02-28T07:03:47Z

fixed an issue due to the merge conflict on merging #1941




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1977
  
Thanks for the review anshul.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1977
  
PR #1975 has the same fix. closing this in favour of #1975 as jenkins 
already passed there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi closed the pull request at:

https://github.com/apache/cloudstack/pull/1977


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-28 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
Thanks everyone. merging this now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1832: CLOUDSTACK-9652 Job framework - Cancelling async job...

2017-02-28 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1832
  
> @karuturi Ok thanks for the clarifications, and it's the scenario I 
thought about too. That being said, I'm currently thinking of a new approach 
for the command sequencer because having implemented the live migration, the 
non-parallel commands isn't optimal at all when you have long running 
sequential commands on a hypervisor. And I tend to think that's the reason 
behind your PR, isn't it?

Yes, thats right.

> The way it's currently done is too simple (if a job cannot be run in 
parallel on the HV, it will put in 
> So don't you think we're better of rewriting the sequencer to let more 
commands being executed in parallel to avoid this bottleneck on the 
AgentAttache? It would normally make the cancellation not needed in the way you 
implemented it since less jobs will be queued.
> 

As you already said, with todays design it isn't possible. Rewriting is 
obviously better. But, thats a bigger job. In the current design, this was the 
only possible way to allow cloudstack to process queued up jobs.

> If we wish to be able to cancel a job, IMHO it should cancel the job down 
on the hypervisor too, thus clearing normally the resources involved as if the 
execution didn't go well.
> 

I agree. But, thats a huge task given the number of hypervisors we support 
and their versions.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-03-02 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
code LGTM.
@nitin-maharana Please initiate internal CI run on @cloudmonger.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@wido Can you please update the systemvm templates at 
http://cloudstack.apt-get.eu/systemvm ?
You can use the one from 
https://builds.cloudstack.org/job/build-master-systemvm/148/ 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@kishankavala can you use the templates from 
http://cloudstack.apt-get.eu/systemvm/4.10/ ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1991
  
@borisstoyanov can you start the tests on this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1982: CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade chan...

2017-03-07 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1982
  
@rhtyd sorry for the confusion. ASF owns it(INFRA-13617). I asked him to 
use these urls to avoid multiple updates.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-08 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1991
  
I manually verified this. merging this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-12 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
@nvazquez I think any of the existing marvin tests didnt catch this bug. Is 
it possible to add a marvin test for it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1967: CLOUDSTACK-9638 Problems caused when inputting doubl...

2017-03-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1967
  
@bvbharat can you start internal CI and post results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

2017-03-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Thanks Will. Can you please add bug id(CLOUDSTACK-9811) to the PR and 
commit message?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-14 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
Hi @DaanHoogland Are you planning to change the url to 
download.cloudstack.org?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-14 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
systemvm template is now updated to 4.10 
http://download.cloudstack.org/systemvm/4.10/ with pr #1982 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2007: CLOUDSTACK-9834: prepareTemplate API call doe...

2017-03-15 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/2007

CLOUDSTACK-9834: prepareTemplate API call doesn't work well with XenServer 
& Local SR (Db_exn.Uniqueness_constraint_violation)

removed the host uuid from SR label so that any host which has access to
the SR(all the hosts in the same pool) can reuse the same SR

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9834

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2007


commit 8a976d27350cec2417b596dba311628de56ed13c
Author: Rajani Karuturi 
Date:   2017-03-15T10:29:06Z

CLOUDSTACK-9834: prepareTemplate API call doesn't work well
with XenServer & Local SR (Db_exn.Uniqueness_constraint_violation)

removed the host uuid from SR label so that any host which has access to
the SR(all the hosts in the same pool) can reuse the same SR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-16 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@DaanHoogland any update? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-16 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
@nvazquez any update? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-17 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/2009

CLOUDSTACK-9369 Fixed Ldap regression

Ldap auto creation of accounts is broken due to the security fix for
CLOUDSTACK-9369.
There was an explicit check to not allow login incase the
user doesnt exist.  removed the same.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9369

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2009.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2009


commit e2efebadaa9d7e7ec7be3f9638f48c7b97394f5e
Author: Rajani Karuturi 
Date:   2017-02-09T18:43:13Z

Bug-ID:CLOUDSTACK-9369 Fixed Ldap regression

Ldap auto creation of accounts is broken due to the security fix for
CLOUDSTACK-9369.
There was an explicit check to not allow login incase the
user doesnt exist.  removed the same.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-17 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2009
  
@rhtyd Can you review the fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-19 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
I want this to be updated to use download.cloudstack.org instead of 
cloudstack.apt-get.eu. 
I will send a PR with URL changes to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-19 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
Thanks @nvazquez Waiting for LGTMs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-19 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
I see that its already using download.cloudstack.org. Its merge ready. Will 
merge once I do some tests. Thanks @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-19 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@borisstoyanov Can you run @blueorangutan tests on this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-20 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/2009#discussion_r106854397
  
--- Diff: 
server/src/com/cloud/api/auth/DefaultLoginAPIAuthenticatorCmd.java ---
@@ -166,7 +166,7 @@ public String authenticate(String command, Map params, HttpSes
 throw new CloudAuthenticationException("Unable to find 
the domain from the path " + domain);
 }
 final UserAccount userAccount = 
_accountService.getActiveUserAccount(username[0], domainId);
-if (userAccount == null || 
!(User.Source.UNKNOWN.equals(userAccount.getSource()) || 
User.Source.LDAP.equals(userAccount.getSource( {
+if (userAccount != null && User.Source.SAML2 == 
userAccount.getSource()) {
--- End diff --

in case of LDAP, account will be created if it doesnt already exist.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP%3A+Trust+AD+and+Auto+Import


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-20 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2009
  
I am seeing the same Travis timeout on all the PRs. Will force push again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-20 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
When debugging, I have seen issues with humongous commits with little or no 
history. They are very difficult to understand.
This is a feature and it need not be backported. so, backporting to 
previous releases is out of question. up-porting automatically happens.
If we want to revert the feature, we revert the merge which is very easy to 
do.
Also, reverting (for feature stability reasons) is just temporary. 
I agree that the number of commits is high. But, the amount of code is also 
high and from different authors who wants to keep it this way.
I am +1 with keeping it as is. 
I prefer merges with proper history and small logical units.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-21 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
I was one of the RM for 4.6. We never made such a decision nor did we 
follow. There were multiple discussions on ML already about squashing vs 
merging and we never concluded to do squashing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-21 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@borisstoyanov can you post the results?
@DaanHoogland After deploying from this PR, I am seeing the below values in 
vm_template table. I think LXC, KVM and Xen values below aren't right.

$ > select id,unique_name,name,type,url,updated,created from vm_template 
where type='SYSTEM';

| id | unique_name | name  | type   | url   

   | updated | created 
|-|-||-|-|
| 1 | routing-1   | SystemVM Template (XenServer) | SYSTEM | 
http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-4.6.0-xen.vhd.bz2
 | NULL| 2017-03-21 07:11:27
|  3 | routing-3   | SystemVM Template (KVM)   | SYSTEM |   

   | NULL| 
2017-03-21 07:11:27 |
|  8 | routing-8   | SystemVM Template (vSphere)   | SYSTEM | 
https://download.cloudstack.org/systemvm/4.10/systemvm64template-master-4.10.0-vmware.ova
| NULL| 
2017-03-21 07:11:27 |
|  9 | routing-9   | SystemVM Template (HyperV)| SYSTEM | 
https://download.cloudstack.org/systemvm/4.10/systemvm64template-master-4.10.0-hyperv.vhd.zip
| NULL| 
2017-03-21 07:11:27 |
| 10 | routing-10  | SystemVM Template (LXC)   | SYSTEM | 
http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2 
 | NULL 
   | 2017-03-21 07:11:48 |
| 12 | routing-12  | SystemVM Template (Ovm3)  | SYSTEM | 
http://download.cloudstack.org/systemvm/4.6/systemvm64template-4.6.0-ovm.raw.bz2
 | NULL 
   | 2017-03-21 07:12:26 |



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@ustcweizhou can you also review this fix? Is pr #2011 still required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@DaanHoogland ok. This is not mergeable yet. I will see what are the 
conflicts with #1982. It  might require new changes.
@borisstoyanov do you see the same template values as I posted. Just want 
to confirm if its my environment issue. As per the above template data, if you 
run KVM tests, it should fail as it doesnt have the system vm template url for 
kvm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-22 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
@mike-tutkowski can you do a final review please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-23 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
ok. Thanks everyone. I am merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-23 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
ok. Thanks everyone. I am merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-27 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
Thank you all. I will merge #1961 and #1994 now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-30 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2019
  
merging now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2021: CLOUDSTACK-9854: Fix test_primary_storage test failu...

2017-03-30 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2021
  
@nvazquez PR #2019 is merged. Can you force push and kick travis again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...

2017-03-30 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2022
  
I requested @sateesh-chodapuneedi for a review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

2017-03-30 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2023
  
code LGTM. Need to check why xenserver and KVM still have wrong urls on PR 
https://github.com/apache/cloudstack/pull/1582#issuecomment-288310796 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2021: CLOUDSTACK-9854: Fix test_primary_storage test failu...

2017-03-30 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2021
  
Wonderful. Seeing green travis after a long time :) 👍  
Thanks @nvazquez and @SudharmaJain 
merging now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-04-05 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit  travis is failing. Can you rebase with master and force push?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...

2017-04-05 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2022
  
@rhtyd can you check on the failures if they are related?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-04-05 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
merging now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...

2017-04-05 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@swill @rhtyd can you review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-04-06 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
master is broken after the merge. Pom version changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2032: CLOUDSTACK-9783: corrected the version number...

2017-04-06 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/2032

CLOUDSTACK-9783: corrected the version number in metrics pom

master is broken after fwd-merging metrics PR #1944 from 4.9
This is due to the incorrect parent version number in the metrics pom.
Corrected the same to reflect master version number.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack master-fix-after-1944

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2032.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2032


commit e1c76dcc235fd350f87725adaf359619331db278
Author: Rajani Karuturi 
Date:   2017-04-07T04:22:27Z

CLOUDSTACK-9783: corrected the version number in metrics pom

master is broken after fwd-merging metrics PR #1944 from 4.9
This is due to the incorrect parent version number in the metrics pom.
Corrected the same to reflect master version number.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix systemvmtemp...

2017-04-09 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2022
  
@rhtyd can you check on the failures? I think there are more failures on 
this PR. I usually see three failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix systemvmtemp...

2017-04-11 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2022
  
ok. merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-04-11 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@rhtyd at this stage, I am not looking at more PRs/features for 4.10. I 
need help on fixing the blockers for releasing 4.10 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2033: [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 1...

2017-04-11 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2033
  
@rhtyd Can you add "This closes #1950" to the description of this PR?
can you force push to make jenkins happy? 

@ustcweizhou can you review please?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2025: [4.10-blocker] Fix error in restart network in 4.10....

2017-04-11 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2025
  
merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2017-04-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1836
  
@rhtyd Thanks for running the tests and the report. I might request you 
again once the blockers are fixed :)
@serg38 Thanks for finding the PR. I will try and request the PR author to 
fix this. But, if there is no response, not sure what can be done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-04-13 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
@anshul1886 There is a test regression due to this PR. Details are at 
https://github.com/apache/cloudstack/pull/1836#issuecomment-293897257
Can you take a look please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-04-14 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
Thanks! will take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2043: CLOUDSTACK-9876: Removed test test_01_test_vm_volume...

2017-04-14 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2043
  
@rhtyd @serg38 can you review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-install pull request: corrected the java version t...

2014-06-17 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs-install/pull/15

corrected the java version to 1.7

changed java package and JAVA_HOME to 1.7

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs-install patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-install/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 3a22e8356627df230df59c9fe2ffe9c5f207f612
Author: Rajani Karuturi 
Date:   2014-06-18T05:44:58Z

corrected the java version to 1.7

changed java package and JAVA_HOME to 1.7




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-rn pull request: removed 'CloudStack on Windows' f...

2014-07-22 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs-rn/pull/16

removed 'CloudStack on Windows' from 4.4.0 RN

http://markmail.org/message/n7rkzugnjtnmpb2a

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs-rn patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-rn/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit fdaf30633f42aaecfd3a3997b46ab7bec647651c
Author: Rajani Karuturi 
Date:   2014-07-23T04:54:53Z

removed 'CloudStack on Windows' from 4.4.0 RN




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs pull request: updated instructions to install jdk1...

2014-08-19 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs/pull/6

updated instructions to install jdk1.7

for apt-get and yum corrected the java install commands to install jdk1.7

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 8f17a2fecd70341dad7dd585d318d7cbbc526cce
Author: Rajani Karuturi 
Date:   2014-08-19T09:56:51Z

updated instructions to install jdk1.7

for apt-get and yum corrected the java install commands to install jdk1.7




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-6634

2014-08-19 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/15

CLOUDSTACK-6634

updated the ldap section in admin guide

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs-admin 4.3-ldap-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 145a0bbf2a73aeac4a61012eb358c20034a9bf63
Author: Rajani Karuturi 
Date:   2014-08-19T10:57:43Z

CLOUDSTACK-6634

updated the ldap section in admin guide




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-6634

2014-08-19 Thread karuturi
Github user karuturi commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/15#issuecomment-52734745
  
closing it as it is merged to upstream 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-6634

2014-08-19 Thread karuturi
Github user karuturi closed the pull request at:

https://github.com/apache/cloudstack-docs-admin/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-admin pull request: moved ldap.firstname.attribute...

2014-08-26 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/17

moved ldap.firstname.attribute to the correct section.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs-admin 4.3-ldap-format

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit 4955c529b62e49f75ab952fe09a2a526a1429ba0
Author: Rajani Karuturi 
Date:   2014-08-27T04:30:36Z

moved ldap.firstname.attribute to the correct section.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix CLOUDSTACK-7476: always pass along $J...

2014-09-04 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/15#issuecomment-54590261
  
If JAVA_HOME is not set, setJavaHome()(cloud-usage.rc:49)  method is trying 
to find it from default java available using something like 
`JAVA_HOME=$(dirname $(dirname $(readlink -e $(which java ` and exits if 
couldn't find anything.
wouldn't that work in this case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix CLOUDSTACK-7476: always pass along $J...

2014-09-05 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/15#issuecomment-54608409
  
ok. understood. Thanks.

I am committing this to master. Do you want this in any other branch? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fix CLOUDSTACK-7476: always pass along $J...

2014-09-05 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/15#issuecomment-54612516
  
committed 
https://github.com/apache/cloudstack/commit/0ec36e128bb06704bfe4e9b115aaf4680ee61a43




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

2014-09-07 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/17#issuecomment-54777280
  
4.4:packaging/debian/init/cloud-usage already has the new logic to set 
$JAVA_HOME (e77da80e01b0774951e5c2ab1b23539af002b8b4) 

Given that it is already in 4.3(3bf4c294313eb0bdb9597f0af2cf6b81a8b4) 
and master(c468228fe807c621decc5919dadae9bcbb38c753), I think we should port 
the change to the file 4.4:packaging/centos63/cloud-usage.rc as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-6634: added more de...

2014-09-09 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/20

CLOUDSTACK-6634: added more details for ldap ssl



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack-docs-admin patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 34ec5acc24ec4f665aa355414483e0bb10432178
Author: Rajani Karuturi 
Date:   2014-09-10T05:38:56Z

CLOUDSTACK-6634: added more details for ldap ssl




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8197 create MinVRVersion confi...

2015-02-03 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/69#issuecomment-72786877
  
Should we also raise another defect to fix this properly as outlined by you 
here?  http://markmail.org/message/cr4bfzvl6eyfisb5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8215: SAML changing date calcu...

2015-02-05 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/71#issuecomment-73023911
  
Just a personal preference: using [Joda](http://www.joda.org/joda-time/) 
DateTime might make it more readable :)

```
DateTime now = DateTime.now(DateTimeZone.UTC);
certGen.setNotBefore(now.minusDays(1).toDate());
certGen.setNotAfter(now.plusYears(3).toDate());
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: mvn on buildslaves that don't have it in ...

2015-02-19 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/82#issuecomment-75036256
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: listDirectory method updated to use Objec...

2015-03-03 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/25#issuecomment-77108227
  
There was one conflict in pom.xml for aws.sdk.version. This commit wanted 
it to be 1.9.1 (earlier value 1.3.22) which it was already changed to 1.9.8 
with commit fac7bfc5

I am going ahead with the merge without the pom change as we already have 
the latest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Update ConsoleProxyPasswordBasedEncryptor...

2015-03-04 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/10#issuecomment-77123920
  
I dont think the main methods are required. Looks like they are there only 
for testing. may be we should just delete the main methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: listDirectory method updated to use Objec...

2015-03-04 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/25#issuecomment-77317485
  
I added two commits on top of this 
checkstyle issues fix: c5c1b1d4628c5fc7a402586325c7bf937f42766e
PMD issues fix: debcbcc1454789936407583fe0aba8e158b16cad


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...

2015-03-09 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/100#issuecomment-77817353
  
I dont think this fixes the issue. we are specifying a version number. 
maven will not check for snapshots.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: systemvm: correct sftp subsystem path of ...

2015-03-09 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/104#issuecomment-77996504
  
@resmo May I know how you discovered this? 
AFAIK, scp and sftp are working fine from ssvm and we do not need sftp 
server on ssvm
Can we remove this subsystem? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: systemvm: correct sftp subsystem path of ...

2015-03-10 Thread karuturi
Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/104#issuecomment-78021815
  
@resmo Thanks for the explanation. 
+1 for the sftp-server if it makes it faster :) 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


  1   2   3   4   5   6   7   8   9   10   >