[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...
GitHub user jiangyt opened a pull request: https://github.com/apache/cloudstack/pull/114 Fix the bug when build apidoc under windows crygwin environment. Currently, when building apidoc under windows error occured caused by python can not understand the directory of gen_toc.py file. Besides gen_toc.py can not receive large parameter.The commit works fine with 4.4.1 and 4.4.2 should works fine with other branches. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiangyt/cloudstack apidoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/114.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #114 commit afd2172201dee8570c2c6e0f60314ff8ae85c905 Author: Yitao Jiang Date: 2015-03-12T06:23:43Z Fix the bug when build apidoc under windows crygin environment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...
Github user jiangyt commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/114#discussion_r26299243 --- Diff: tools/apidoc/build-apidoc.sh --- @@ -62,7 +62,18 @@ set -e sed -e 's,%API_HEADER%,Root Admin API,g' "$thisdir/generatetoc_header.xsl" >generatetocforadmin.xsl sed -e 's,%API_HEADER%,Domain Admin API,g' "$thisdir/generatetoc_header.xsl" >generatetocfordomainadmin.xsl - python "$thisdir/gen_toc.py" $(find . -type f) + WINOS=`uname -s|grep -i WIN` + gen_toc_file='' + if [ "x$WINOS" != "x" ]; then + gen_toc_file="`cygpath -w $thisdir`\\gen_toc.py" + else + gen_toc_file="$thisdir/gen_toc.py" + fi + + argfiles=`find . -type f` --- End diff -- @bhaisaab Argument list too long erro will triger under windows , so i split the argument. Don't know if it exists under other distros.Can you check it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
