[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220615734 LGTM :) It seems to work correctly on my 4.8.0 setup. Thanks. Best regards, Aurélien --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-221324378 Hum, please wait a bit before merging, it seems that in certain cases, a problem occurs; I'm not sure yet, but there may be more to it. I'll double check what exactly is occurring (got agent disconnections on SSVM, not sure why, maybe unrelated). Upon restarting the service, got the following: `` 2016-05-24 16:13:00,805 WARN [utils.script.Script] (agentRequest-Handler-4:null) Timed out: /usr/local/cloud/systemvm/config_ssl.sh -i 1.2.3.4 -h s-400-VM -k /tmp/prvkey8397704182155251777.tmp -p /tmp/pubcert3668437820792344314.tmp -t /tmp/certchain6337729082886052511.tmp -u /tmp/rootcert3605556222455908935.tmp . Output is: Certificate was added to keystoreExisting entry alias debian:pscprocert.pem exists, overwrite? [no]: adding rewrite rules to file: /etc/apache2/sites-available/default-ssl `` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Github user footplus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64432411 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -204,6 +203,7 @@ if [ -f "$customCACert" ] then keytool -delete -alias $aliasName -keystore $keyStore -storepass $storepass -noprompt keytool -import -alias $aliasName -keystore $keyStore -storepass $storepass -noprompt -file $customCACert + keytool -importkeystore -srckeystore $defaultJavaKeyStoreFile -destkeystore $keyStore -srcstorepass $defaultJavaKeyStorePass -deststorepass $storepass --- End diff -- It seems that we absolutely need a -noprompt option here, since re-applying the configuration will lead to keytool prompting whether to overwrite or not, and freezing the Agent then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-221572152 LGTM ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221876586 @wido I have the 255-chars problems here too, and this particular table is empty; did you add a patch on the API too to unlock the API limitation to 255 chars ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221893016 Maybe you meant to change on this table: `` alter table `vm_template` modify column `url` varchar(2048) DEFAULT NULL COMMENT 'the url where the template exists externally'; `` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9238: Fix URL length to 2048 f...
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1567#issuecomment-222140436 Seems to break the registerIso command here... Will check exactly why. `` 2016-05-27 15:01:14,211 ERROR [c.c.a.ApiServer] (catalina-exec-1:ctx-56423a5c ctx-9b38033e) (logid:68ac142d) unhandled exception executing api command: [Ljava.lang.String;@475199b7 java.lang.NullPointerException at com.cloud.template.TemplateAdapterBase.prepare(TemplateAdapterBase.java:149) at com.cloud.template.TemplateAdapterBase.prepare(TemplateAdapterBase.java:317) at com.cloud.template.HypervisorTemplateAdapter.prepare(HypervisorTemplateAdapter.java:124) at com.cloud.template.TemplateManagerImpl.registerIso(TemplateManagerImpl.java:299) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at com.sun.proxy.$Proxy179.registerIso(Unknown Source) at org.apache.cloudstack.api.command.user.iso.RegisterIsoCmd.execute(RegisterIsoCmd.java:192) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) at com.cloud.api.ApiServer.queueCommand(ApiServer.java:698) at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:297) at com.cloud.api.ApiServlet$1.run(ApiServlet.java:127) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:124) at com.cloud.api.ApiServlet.doGet(ApiServlet.java:86) at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) at javax.servlet.http.HttpServlet.service(HttpServlet.java:723) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:600) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:299) at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:889) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:732) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2274) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) `` --- If your project is set up for it, you can reply to this email and have your reply appear on
[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-191264802 Hello, I was able to confirm this patch works on CloudStack 4.8.0. The only thing is to take care of removing the systemvm-4.8.0.iso from the secondary storage, and destroy the consoleproxy VM. This will cause CloudStack to reprovision the ISO from the package, and then when the consoleproxy is back, this works. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-213389763 @swill this is completely a LGTM :) We have this working on CS 4.8 in production. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
