from:"dmabry"

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-21 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@serbaut Can you do a force push to kick off jenkins again.  I'm guessing 
Jenkins just had an issue and not the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-21 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
tag:mergeready



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-22 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-22 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
LGTM.  tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
@rhtyd Sure, no problem.  How would you like to handle the back porting?  
Do you want me to open PRs against 4.8 and 4.9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1973: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-02-27 Thread dmabry

GitHub user dmabry opened a pull request:

https://github.com/apache/cloudstack/pull/1973

CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for 
vpcrouter

[BACKPORT PR1954]

moved logrotate from cron.daily to cron.hourly for vpcrouter in 
cloud-early-config. This brings 'vpcrouter' inline with 'router'. We are having 
issues with cloud.log not rotating fast enough, which filled up /var/log and 
ultimately caused the VR to stop functioning in such a way that it prevented 
new VMs from being deployed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myENA/cloudstack bug/4.8-vpc-vr-logrotate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1973.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1973


commit 825cb5a0b68ddbf3195ba591ac433bac10189495
Author: David Mabry 
Date:   2017-02-27T20:44:57Z

Backport of PR 1954 [CLOUDSTACK-9795]




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1974: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-02-27 Thread dmabry

GitHub user dmabry opened a pull request:

https://github.com/apache/cloudstack/pull/1974

CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for 
vpcrouter

[BACKPORT PR1954]

moved logrotate from cron.daily to cron.hourly for vpcrouter in 
cloud-early-config. This brings 'vpcrouter' inline with 'router'. We are having 
issues with cloud.log not rotating fast enough, which filled up /var/log and 
ultimately caused the VR to stop functioning in such a way that it prevented 
new VMs from being deployed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myENA/cloudstack bug/4.9-vpc-vr-logrotate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1974


commit f1ae0d3bdde3317f6be34f09a656b7c50779e3be
Author: David Mabry 
Date:   2017-02-27T20:53:33Z

Backport of PR 1954 [CLOUDSTACK-9795]




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
@rhtyd I have created PRs for 4.8 and 4.9.  They are PR #1973 and PR #1974 
respectively.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1974
  
@rafaelweingartner No problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1974
  
Done.  I'll also do a cherry pick on the other PR.  Thanks for the guidance 
@rafaelweingartner. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1973
  
Did a git cherry-pick as suggested by @rafaelweingartner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-03-02 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1974
  
shall I close this PR or do you guys need it open to make sure the 
cherry-pick happens?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-03-02 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1973
  
Closing PR as it will be cherry-picked from master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1973: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-03-02 Thread dmabry

Github user dmabry closed the pull request at:

https://github.com/apache/cloudstack/pull/1973


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-03-03 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1974
  
Thanks @rhtyd!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1974: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-03-03 Thread dmabry

Github user dmabry closed the pull request at:

https://github.com/apache/cloudstack/pull/1974


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-22 Thread dmabry

GitHub user dmabry opened a pull request:

https://github.com/apache/cloudstack/pull/966

Added support for KVM teamd devices to LibvirtComputingResource.java

This will allow KVM users to utilize teamd nic teaming devices named team*.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dmabry/cloudstack feature_support_nic_teaming

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/966.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #966


commit e1a401c0232928109330cc4670e54b6a80a97de4
Author: David Mabry 
Date:   2015-10-22T15:19:50Z

Added support for KVM teamd devices to LibvirtComputingResource.java.  This 
will allow users to utilze teamd nic teaming devices named team*.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/966#issuecomment-150582452
  
I'll take a look at #812 and see about combining them into this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/966#issuecomment-150588016
  
@DaanHoogland Sounds good.  I'll hold off.  Thanks for the help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Interface pattern check

2015-10-23 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/973#issuecomment-150641877
  
Agreed.  Thanks for taking care of this @DaanHoogland.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-11 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1472#issuecomment-218600092
  
LGTM.  We tested this in our Lab on HW and all static routes on each PG 
came up as expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-12 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1513#issuecomment-218764129
  
Also, tested in a 4.8 lab and I was able to migrate VMs between hosts when 
using VXLAN Guest Isolated  network.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

2016-05-12 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1483#issuecomment-218765751
  
I tested this in our 4.8 HW Lab and it worked as expected.  I found the 
MASTER VR for a TEST VPC with a private gateway configured.  I started a ping 
to the private gateway from an instance.  Finally I ran virsh destroy against 
r-XX-VM and only dropped a few pings before the private gateway was moved to 
the new VR.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-17 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-219764564
  
@swill: pulling this into a 4.7 lab now.  I will manually test and verify 
as soon as I can.  What's my deadline?  I should be able to have this tested 
before EOB.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-18 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220065889
  
@swill sorry for the late reply.  I pulled this patch into a 4.7 bubble and 
manually tested it and it worked as expected.  LGTM based on manual testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1548: Compabitility fix for Docker >= 1.11 (docker/docker#...

2016-06-09 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1548
  
LGTM based code review.  This is a very straight forward change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...

2016-06-09 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1581
  
I just kicked off a build that includes this PR.  I'm going to push this to 
our lab for testing and report back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...

2016-06-09 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1581
  
I tested this in our lab with advanced networking verified the patch is 
working as expected.  I used the following test process.

1. Created an acl and applied it to 1 VPC Network Tier.
``` 
10  192.168.10.0/24 Allow   ALL Ingress  
20  192.168.20.0/24 Allow   ALL Ingress 
30  192.168.30.0/24 Allow   ALL Ingress 
```
2. iptables looked like the following on the VPC VR
```
Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination 
ACCEPT all  --  0.0.0.0/0225.0.0.50  
ACCEPT all  --  0.0.0.0/0224.0.0.18  
ACCEPT all  --  192.168.10.0/24  0.0.0.0/0   
ACCEPT all  --  192.168.20.0/24  0.0.0.0/0   
ACCEPT all  --  192.168.30.0/24  0.0.0.0/0   
DROP   all  --  0.0.0.0/00.0.0.0/0   
```
3. I added an additional rule of:
```
40  192.168.40.0/24 Allow   TCP 80  80  
Ingress 
```
4. iptables looked like the following on the VPC VR
```
Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination 
ACCEPT all  --  0.0.0.0/0225.0.0.50  
ACCEPT all  --  0.0.0.0/0224.0.0.18  
ACCEPT all  --  192.168.10.0/24  0.0.0.0/0   
ACCEPT all  --  192.168.20.0/24  0.0.0.0/0   
ACCEPT all  --  192.168.30.0/24  0.0.0.0/0   
ACCEPT tcp  --  192.168.40.0/24  0.0.0.0/0tcp dpt:80
DROP   all  --  0.0.0.0/00.0.0.0/0   
```

In summary, it looks like this patch works verified by manual testing in my 
lab.

In short, LGTM based on testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...

2016-06-10 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1581
  
@pdube No problem.  Think you could kick this off again and see if Travis 
comes back green?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1590: Ena vpc acl fix

2016-06-13 Thread dmabry

GitHub user dmabry opened a pull request:

https://github.com/apache/cloudstack/pull/1590

Ena vpc acl fix

This includes the patch from PR 1581 by pdube.  I have manually tested and 
verified that it works.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myENA/cloudstack ENA-VPC-ACL-FIX

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1590.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1590


commit 50651a161348e7adbe5907b0dfc1d2deff30ab27
Author: Simon Weller 
Date:   2016-04-04T17:12:27Z

8302 9285 9300 9296 9283

commit cc22fe60d719c43af3e0fbb46afdc25fedbfe008
Author: Simon Weller 
Date:   2016-04-04T17:32:15Z

9287

commit 9e7183c186961ca1f30f119dfba79c9c4680a634
Author: Simon Weller 
Date:   2016-04-04T17:36:08Z

PRI 1402

commit cc16c5094b5340687bdb8814f8063f6e30be2736
Author: Simon Weller 
Date:   2016-04-04T17:46:49Z

PR 1449 - Speed up iptables setup

commit 7cba31e8aaa544faecc794882f821b30a556441c
Author: Simon Weller 
Date:   2016-04-05T16:48:57Z

Updated pom version

commit 65d182c62eba58e4c20d75c451b044a85e6d3c4d
Author: Simon Weller 
Date:   2016-04-05T22:30:44Z

Adding additional debugging for Cloudstack 9285

commit a6c7c4c200cc4c0c4a100c07c6221e27cfe025dc
Author: Simon Weller 
Date:   2016-04-05T22:56:20Z

format fixes

commit f9ba60c77d9a51afa4e0530e35943b001f2bb45c
Author: Simon Weller 
Date:   2016-04-05T22:58:08Z

format fixes

commit ff8d31b1a3320e3fa479fe22794ebf883fe29096
Author: Simon Weller 
Date:   2016-04-06T21:06:28Z

update pom to 4.8.1 and added database ha to plugins pom

commit 5bf36f27ecaa30cfc93cceb9c5c1ce4c29a0b701
Author: Simon Weller 
Date:   2016-04-13T15:24:35Z

Allow root volume detach for KVM and fix volume.getId()

commit f215b1760d91705965f675525f03dff2fcba0f78
Author: Simon Weller 
Date:   2016-04-13T15:34:03Z

Revert "Allow root volume detach for KVM and fix volume.getId()"

This reverts commit 5bf36f27ecaa30cfc93cceb9c5c1ce4c29a0b701.

commit 05be6b31453f6a5784a961e044519ff3259ead4e
Author: Simon Weller 
Date:   2016-04-13T15:37:50Z

detach root vol for KVM + volume reference fix

commit e8c61f8682e89c3ca49b20d181389bffc191f167
Author: Simon Weller 
Date:   2016-04-27T14:00:58Z

Updated RBD Snapshot deletion patch

commit bc4ab0ba3bb25c226e94e13336f2dfea15084f04
Author: Simon Weller 
Date:   2016-04-27T15:28:13Z

Fixed format

commit e0629d5b5e157fc85d801a3d5387eda391276222
Author: Simon Weller 
Date:   2016-04-27T17:58:19Z

formatting

commit 7d95e88c72c8169e2760cd37720899373b2415f9
Author: Simon Weller 
Date:   2016-04-28T17:16:22Z

Api async jobid

commit 21003b330feed3d1f7b07dfd494cbabe4c23666a
Author: Simon Weller 
Date:   2016-04-28T17:18:03Z

Fix PG PR 1474

commit f12a93e040d0d3882cd1c2370e39dab57ea8dbc7
Author: Simon Weller 
Date:   2016-04-28T18:08:15Z

Fix DNSMasq PR 1514

commit 66be38ec48169d3e38c645dfed849d66f6ac4afc
Author: Simon Weller 
Date:   2016-04-30T20:34:50Z

Fix plugging ip addresses to the wrong interface PR 1524

commit f8057e9f3964571fba918e866e64535845db4c96
Author: Simon Weller 
Date:   2016-05-02T16:50:10Z

Revert "Fix plugging ip addresses to the wrong interface PR 1524"

This reverts commit 66be38ec48169d3e38c645dfed849d66f6ac4afc.
Remi pulled it, I'm taking it out until we have a change to look at it.

commit 6f0bd6ab9ccf5d1c71890beb80d817ae09c7a351
Author: Simon Weller 
Date:   2016-05-02T17:09:03Z

SSL NIO MT PR 1493

commit 902b36b119d8e164c713f5ddb2b2392dbe94d73c
Author: Simon Weller 
Date:   2016-05-03T00:51:56Z

VXLAN migration fix for libvirt hook PR 1513

commit def0bbf41bfc55c5a11cbd1d5e823ac9d72c3a3f
Author: Simon Weller 
Date:   2016-05-03T20:51:38Z

PR 1520 Fix CPU count for NUMA

commit 3414657d6b73c6964b7a2552c1f22759fd487c76
Author: Simon Weller 
Date:   2016-05-03T20:56:38Z

PR 1470 Make the generated json files unique to prevent concurrency

commit b612991209db71e7329f952bbadf15a7680e24b5
Author: Simon Weller 
Date:   2016-05-03T21:08:03Z

Fix formatting

commit a95ff9d5e028e44255618e58381dc5cdae81a7bf
Author: Simon Weller 
Date:   2016-05-03T21:16:50Z

Fix formatting

commit cc277c8efff96ff86f48dcf1d7c83e83fc3272bb
Author: Simon Weller 
Date:   2016-05-05T21:40:34Z

PR1534 Nio fixes and test case
;

commit 03f0706aa615ed3c0a6e271ea4f2c66c4a5689fb
Author: Simon Weller 
Date:   2016-05-05T21:46:08Z

PR1472 - apply static routes on change to master state

commit 897d94dba76dbf90c65e623babe897f30518ee62
Author: Nathan Johnson 
Date:   2016-05-08T00:38:58Z

Allow hidden configuration parameters to be shown under certain conditions

If the listConfigurations endpoint is called with the showhidden=tr

[GitHub] cloudstack pull request #1590: Ena vpc acl fix

2016-06-13 Thread dmabry

Github user dmabry closed the pull request at:

https://github.com/apache/cloudstack/pull/1590


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1590: Ena vpc acl fix

2016-06-13 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1590
  
Sorry, I put this pull request against the wrong tree.  That's what I get 
for being in a rush on a Monday morning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-07 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1428#issuecomment-193407327
  
@remibergsma , We loaded up the management server with this patch and it 
appears to work just fine on 4.7.1 with db.ha.enable=false and db.cloud.slaves 
left blank.  See logs below:

```
2016-03-07 13:09:47,721 INFO  [c.c.u.d.T.Transaction] 
(localhost-startStop-1:null) (logid:) Is Data Base High Availiability enabled? 
Ans : false
2016-03-07 13:09:47,867 DEBUG [c.c.u.d.ConnectionConcierge] 
(localhost-startStop-1:null) (logid:) Registering a database connection for 
LockMaster1
2016-03-07 13:09:47,867 INFO  [c.c.u.d.Merovingian2] 
(localhost-startStop-1:null) (logid:) Cleaning up locks for 233845178587501
2016-03-07 13:09:47,873 INFO  [c.c.u.d.Merovingian2] 
(localhost-startStop-1:null) (logid:) Released 0 locks for 233845178587501
2016-03-07 13:09:47,897 INFO  [o.a.c.s.l.CloudStackExtendedLifeCycle] 
(localhost-startStop-1:null) (logid:) Running system integrity checker 
com.cloud.upgrade.DatabaseUpgradeChecker@6fd77398
2016-03-07 13:09:47,898 INFO  [c.c.u.DatabaseUpgradeChecker] 
(localhost-startStop-1:null) (logid:) Grabbing lock to check for database 
upgrade.
2016-03-07 13:09:47,942 DEBUG [c.c.u.d.VersionDaoImpl] 
(localhost-startStop-1:null) (logid:) Checking to see if the database is at a 
version before it was the version table is created
2016-03-07 13:09:47,960 INFO  [c.c.u.DatabaseUpgradeChecker] 
(localhost-startStop-1:null) (logid:) DB version = 4.7.1 Code Version = 4.7.1
2016-03-07 13:09:47,961 INFO  [c.c.u.DatabaseUpgradeChecker] 
(localhost-startStop-1:null) (logid:) DB version and code version matches so no 
upgrade needed.
2016-03-07 13:09:47,961 INFO  [o.a.c.s.l.CloudStackExtendedLifeCycle] 
(localhost-startStop-1:null) (logid:) Configuring CloudStack Components
2016-03-07 13:09:47,963 INFO  [o.a.c.s.l.CloudStackExtendedLifeCycle] 
(localhost-startStop-1:null) (logid:) Done Configuring CloudStack Components
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349

2016-04-18 Thread dmabry

GitHub user dmabry opened a pull request:

https://github.com/apache/cloudstack/pull/1500

CLOUDSTACK-9349

This PR addresses the KVM detach/attach ROOT disks from VMs 
(CLOUDSTACK-9349).  In short, this allows the KVM Hypervisor, and I added the 
Simulator as a valid hypervisor for ease of development and testing of marvin, 
to detach a root volume and the reattach a root volume using the deviceid=0 
flag to the attachVolume API.  I have also written a marvin integration test 
that verifies this feature works for both KVM and the Simulator.

Below is the marvin results files of the full marvin test_volumes.py.  All 
tests pass, including the new root detach/attach, on our KVM lab running with 
the patches in this PR.


[test_volumes_KIR4G3.zip](https://github.com/apache/cloudstack/files/223799/test_volumes_KIR4G3.zip)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myENA/cloudstack KVM_root_detach

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1500


commit 48ce76344040de2ab8014f76292abe0421d42f85
Author: Simon Weller 
Date:   2016-03-24T19:55:34Z

Merge pull request #4 from apache/4.7

4.7 PR

commit d0a02640dfd4878da81a2e59588c4b5ff2a06401
Author: Simon Weller 
Date:   2016-04-14T13:28:37Z

Let hypervisor type KVM detach root volumes

commit 7807955433cea390bb7358e3bb90dbc9cc06bbea
Author: David Mabry 
Date:   2016-04-15T12:30:07Z

updated test_volumes.py to include a test for detaching and reattaching a 
root volume from a vm.  I also had to update base.py to all attach_volume to 
have the parameter deviceid to be passed as needed.

commit d7d55630daff4a5e17c9a374dc2e9bc478dff808
Author: David Mabry 
Date:   2016-04-18T02:41:29Z

Added Simulator as valid hypervisor for root detach




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349

2016-04-18 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-21138
  
Here is a manual test using cloudmonkey against our KVM lab.

`(local) ðµ > list volumes 
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 listall=true
count = 1
volume:
id = 6bd1cf36-2225-4f9c-a378-fe2959142912
name = ROOT-42
account = admin-2177
created = 2016-04-14T07:54:23-0500
destroyed = False
deviceid = 0
displayvolume = True
domain = 2177
domainid = cf23158e-d33c-40c2-b176-0db4a163a93f
hypervisor = KVM
isextractable = False
path = 6bd1cf36-2225-4f9c-a378-fe2959142912
provisioningtype = thin
quiescevm = False
serviceofferingdisplaytext = Small Instance
serviceofferingid = b85e77fd-b897-4471-8fce-1190e71e5156
serviceofferingname = Small Instance
size = 5368709120
state = Ready
storage = rbd1
storageid = f0dbafaa-52a3-3077-bc53-d7ad3a5ac132
storagetype = shared
tags:
templatedisplaytext = Base CentOS 7
templateid = cf02d86b-145b-4777-999c-7f37b16c945b
templatename = Linux_CentOS_7-Minimal
type = ROOT
virtualmachineid = f2870d90-d294-474b-b7da-95bad01e6c09
vmdisplayname = VM-381
vmname = VM-f2870d90-d294-474b-b7da-95bad01e6c09
vmstate = Stopped
zoneid = f58958e8-d24f-4a52-9a9f-8ae11cf4a3b0
zonename = Zone1
(local) ðµ > detach volume id=6bd1cf36-2225-4f9c-a378-fe2959142912
 
accountid = 6b00c3ed-fc3f-11e5-9789-000c29b79f06
cmd = org.apache.cloudstack.api.command.admin.volume.DetachVolumeCmdByAdmin
created = 2016-04-16T13:45:56-0500
jobid = 8d499364-6c4a-49be-bc43-3a80ea800ffa
jobinstanceid = 6bd1cf36-2225-4f9c-a378-fe2959142912
jobinstancetype = Volume
jobprocstatus = 0
jobresult:
volume:
id = 6bd1cf36-2225-4f9c-a378-fe2959142912
name = ROOT-42
account = admin-2177
created = 2016-04-14T07:54:23-0500
destroyed = False
displayvolume = True
domain = 2177
domainid = cf23158e-d33c-40c2-b176-0db4a163a93f
hypervisor = KVM
isextractable = True
jobid = 8d499364-6c4a-49be-bc43-3a80ea800ffa
jobstatus = 0
path = 6bd1cf36-2225-4f9c-a378-fe2959142912
provisioningtype = thin
quiescevm = False
serviceofferingdisplaytext = Small Instance
serviceofferingid = b85e77fd-b897-4471-8fce-1190e71e5156
serviceofferingname = Small Instance
size = 5368709120
state = Ready
storage = rbd1
storageid = f0dbafaa-52a3-3077-bc53-d7ad3a5ac132
storagetype = shared
tags:
templatedisplaytext = Base CentOS 7
templateid = cf02d86b-145b-4777-999c-7f37b16c945b
templatename = Linux_CentOS_7-Minimal
type = DATADISK
zoneid = f58958e8-d24f-4a52-9a9f-8ae11cf4a3b0
zonename = Zone1
jobresultcode = 0
jobresulttype = object
jobstatus = 1
userid = 6b00cc09-fc3f-11e5-9789-000c29b79f06
(local) ðµ > 
(local) ðµ > 
(local) ðµ > list volumes 
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 listall=true
(local) ðµ > 
(local) ðµ > 
(local) ðµ > attach volume id=6bd1cf36-2225-4f9c-a378-fe2959142912 
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 
deviceid=  filter=id=virtualmachineid=  
(local) ðµ > attach volume id=6bd1cf36-2225-4f9c-a378-fe2959142912 
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 deviceid=0
 
accountid = 6b00c3ed-fc3f-11e5-9789-000c29b79f06
cmd = org.apache.cloudstack.api.command.admin.volume.AttachVolumeCmdByAdmin
created = 2016-04-16T13:46:43-0500
jobid = 8b36e694-376a-457e-b2be-dc71872177ca
jobinstanceid = 6bd1cf36-2225-4f9c-a378-fe2959142912
jobinstancetype = Volume
jobprocstatus = 0
jobresult:
volume:
id = 6bd1cf36-2225-4f9c-a378-fe2959142912
name = ROOT-42
account = admin-2177
attached = 2016-04-16T13:46:44-0500
created = 2016-04-14T07:54:23-0500
destroyed = False
deviceid = 0
displayvolume = True
domain = 2177
domainid = cf23158e-d33c-40c2-b176-0db4a163a93f
hypervisor = KVM
isextractable = False
jobid = 8b36e694-376a-457e-b2be-dc71872177ca
jobstatus = 0
path = 6bd1cf36-2225-4f9c-a378-fe2959142912
provisioningtype = thin
quiescevm = False
serviceofferingdisplaytext = Small Instance
serviceofferingid = b85e77fd-b897-4471-8fce-1190e71e5156
serviceofferingname = Small Instance
size = 5368709120
state = Ready
storage = rbd1
storageid = f0dbafaa-52a3-3077-bc53-d7ad3a5ac132
storagetype = shared
tags:
templatedisplaytext = Base CentOS 7
templateid = cf02d86b-145b-4777-999c-7f37b16c945b
templatename = Linux_CentOS_7-Minimal
type = ROOT
virtualmachineid = f2870d90-d294-474b-b7da-95bad01e6c09
vmdisplayname = VM-381
vmname = VM-f2870d90-d294-474b-b7da-95bad01e6c09
vmstate = Stopped

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-19 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60222132
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Check for root volume
+# 3. Stop VM
+# 4. Detach root volume
+# 5. Verify root volume detached
+# 6. Attach root volume
+# 7. Start VM
+
+try:
+# Check for root volume
--- End diff --

@shwetaag Thanks for the feedback.  You are absolutely right, I should test 
to ensure the hypervisor supports Root Volume detach.  Root Volume detach is 
currently supported by a number of hypervisors, so I will put in an if block 
that will make sure that it only tests the supported hypervisors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-19 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60222679
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Check for root volume
+# 3. Stop VM
+# 4. Detach root volume
+# 5. Verify root volume detached
+# 6. Attach root volume
+# 7. Start VM
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+
+# Start VM
+self.virtual_machine.start(self.apiclient)
+# Sleep to ensure that VM is in ready state
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+# Verify VM response to check whether VM deployment was 
successful
+self.assertEqual(
+isinstance(vm_response, list),
+True,
+"Check list VM response for valid list"

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-19 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60225742
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"])
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Check for root volume
+# 3. Stop VM
+# 4. Detach root volume
+# 5. Verify root volume detached
+# 6. Attach root volume
+# 7. Start VM
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+
+# Start VM
+self.virtual_machine.start(self.apiclient)
+# Sleep to ensure that VM is in ready state
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+# Verify VM response to check whether VM deployment was 
successful
+self.assertEqual(
+isinstance(vm_response, list),
+True,
+"Check list VM response for valid list"

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-19 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-212085924
  
Ok, I have made the requested changes.  Please review and let me know if 
there is anything else I need to change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-20 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-212426369
  
@koushik-das - Thanks for the feedback.  I have added the 
require_hardware="false" as you suggested and pushed a new commit to the branch.

If all looks good, I'll squash the commits in prep for the final merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-21 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60581671
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
--- End diff --

@nitt10prashant - Thanks for the feedback.  I was merely following an 
established pattern that I observed earlier in the file.  Please look at lines 
499 - 510 as an example.  I have put the code below for your convenience.  
Should that code be refactored as well? I just want to understand if my 
situation that I'm testing is different than the code I'm referencing below.  
In the end, I'm happy to make the change.  Thanks again for the feedback.

`
# Check List Volume response for newly created volume
list_volume_response = Volume.list(
self.apiclient,
id=volume.id
)
self.assertNotEqual(
list_volume_response,
None,
"Check if volume exists in ListVolumes")
self.assertEqual(
isinstance(list_volume_response, list),
True,
"Check list volumes response for valid list")`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-21 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60582064
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
--- End diff --

Understood.  I'll make the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-21 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60582709
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-21 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60584441
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-21 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60585058
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-21 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60602140
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
--- End diff --

I have made this change and I'm validating this now in my lab.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-21 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60602084
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
--- End diff --

I have implemented this change and I'm validating it now in my lab.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-21 Thread dmabry

Github user dmabry commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1500#discussion_r60602700
  
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
 "Check the state of VM"
 )
 except Exception as e:
-self.fail("Exception occuered: %s" % e)
+self.fail("Exception occurred: %s" % e)
+return
+
+@attr(tags=["advanced", "advancedns"], required_hardware="false")
+def test_02_root_volume_attach_detach(self):
+"""Test Root Volume attach/detach to VM
+"""
+
+# Validate the following
+# 1. Deploy a VM
+# 2. Verify that we are testing a supported hypervisor
+# 3. Check for root volume
+# 4. Stop VM
+# 5. Detach root volume
+# 6. Verify root volume detached
+# 7. Attach root volume
+# 8. Start VM
+
+# Verify we are using a supported hypervisor
+if (self.hypervisor.lower() == 'vmware'
+or self.hypervisor.lower() == 'kvm'
+or self.hypervisor.lower() == 'simulator'
+or self.hypervisor.lower() == 'xenserver'):
+
+try:
+# Check for root volume
+root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(root_volume_response, list),
+True,
+"Check list volumes response for valid list"
+)
+# Grab the root volume for later use
+root_volume = root_volume_response[0]
+
+# Stop VM
+self.debug("Stopping the VM: %s" % self.virtual_machine.id)
+self.virtual_machine.stop(self.apiclient)
+
+# Ensure VM is stopped before detaching the root volume
+time.sleep(self.services["sleep"])
+
+vm_response = VirtualMachine.list(
+self.apiclient,
+id=self.virtual_machine.id,
+)
+vm = vm_response[0]
+self.assertEqual(
+vm.state,
+'Stopped',
+"Check the state of VM"
+)
+
+# Detach root volume from VM
+self.virtual_machine.detach_volume(
+self.apiclient,
+root_volume
+)
+
+# Verify that root disk is gone
+no_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertEqual(
+no_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+
+# Attach root volume to VM
+self.virtual_machine.attach_volume(
+self.apiclient,
+root_volume,
+0
+)
+
+# Check for root volume
+new_root_volume_response = Volume.list(
+self.apiclient,
+virtualmachineid=self.virtual_machine.id,
+type='ROOT',
+listall=True
+)
+self.assertNotEqual(
+new_root_volume_response,
+None,
+"Check if root volume exists in ListVolumes"
+)
+self.assertEqual(
+isinstance(new_root_volume_response, list),

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-23 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-213853837
  
I made all requested changes.  I'm going to run a full bubble CI test 
against this PR and I will post the results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-27 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-215083560
  
Ok, I have run this through my lab again and specifically ran the 
test_volumes.py file.  All tests passed.  See below.  I have also attached the 
results dir as a zip file for review.

Test Volume attach/detach to VM (5 data volumes) ... === TestName: 
test_01_volume_attach_detach | Status : SUCCESS ===
ok
Test Root Volume attach/detach to VM ... === TestName: 
test_02_root_volume_attach_detach | Status : SUCCESS ===
ok
Test Attach volumes (max capacity) ... === TestName: test_01_volume_attach 
| Status : SUCCESS ===
ok
Test attach volumes (more than max) to an instance ... === TestName: 
test_02_volume_attach_max | Status : SUCCESS ===
ok
Test custom disk sizes beyond range ... === TestName: 
test_deployVmWithCustomDisk | Status : SUCCESS ===
ok
Attach a created Volume to a Running VM ... === TestName: 
test_01_attach_volume | Status : SUCCESS ===
ok
Detach a Volume attached to a VM ... === TestName: test_02_detach_volume | 
Status : SUCCESS ===
ok
Delete a Volume unattached to an VM ... === TestName: 
test_03_delete_detached_volume | Status : SUCCESS ===
ok
Create a volume under a non-root domain as non-root-domain user ... === 
TestName: test_create_volume_under_domain | Status : SUCCESS ===
ok

--
Ran 9 tests in 539.126s

OK

@swill - Looking at the standard bubble test suite that is run, it doesn't 
even run this test, so I thought it prudent in this case to run it specifically 
and post the results.  Once we get the bubble stuff standardized, I'm happy to 
run the full test and post those results.  Until then, I would like to submit 
this PR for code review again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-27 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-215084188
  

[test_volumes_NV6XFO.zip](https://github.com/apache/cloudstack/files/238694/test_volumes_NV6XFO.zip)

Here is the zip file containing the test results.

Thanks in advance for the reviews!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-27 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-215103808
  
Yea, I saw that jenkins failed pulling 4.7 branch, so I kicked it off 
again.  I'm going to keep an eye on travis and jenkins.  There is no reason 
those tests should fail.  Hopefully, I'll get a green this time around.  ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-27 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-215120369
  
OK, all checks have passed!  ;)  Looking for another LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-05 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1428#issuecomment-217321289
  
I ran this in our lab and tested the failover and works as expected.  LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

2016-05-05 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1529#issuecomment-217322431
  
I know it doesn't really need my LGTM, but this commit definitely improves 
the accuracy, and possibly the performance, of marvin and I'd personally like 
to see this one merged.  I have run a few Marvin tests that use this code and 
it does work as designed.

@swill CI Test good, 2+ reviews. This is Ready to Merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-06 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1428#issuecomment-217482136
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-06 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1520#issuecomment-217485432
  
We have rolled this patch in our lab and verified that it does indeed 
report the number of sockets correctly.  Based on testing this LGTM.

Please do a force push to kick off jenkins and travis again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-06 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1472#issuecomment-217552585
  
So, Si (@kiwiflyer) and I have been testing this functionality against VPCs 
in our lab and we verified that static routes are indeed loaded when a VR goes 
from BACKUP to MASTER.  The relevant logs showing that is works are below.  We 
are however still having problems with the static routes not getting added on 
demand to the current MASTER VR.  Has anyone else had this issue while running 
this commit?

```
2016-05-06 20:32:20,795 DEBUG{u'config': {u'router_id': u'2', 
u'baremetalnotificationapikey': 
u'QtWfDPFOrqddFe3iofWCS6Yhf6g2cCTwR6n3-L7TaaKl3ReBI4219jckJ0AfdX878jo2DpW4ohhNG_6Hlad62g',
 u'baremetalnotificationsecuritykey': 
u'B99mUf0oWKL7ATA5WF9iMb17nk1ePQ6kgg3YgWA0kJE2vCaGH52Z65EWDAyCaOYiZB1YPr40pWiwTlBt7_TTmg',
 u'name': u'r-28-VM', u'eth0mask': u'255.255.0.0', u'type': u'vpcrouter', 
u'dns1': u'207.191.191.90', u'privategateway': u'192.168.4.4', u'vpccidr': 
u'10.15.0.0/22', u'domain': u'cs2cloud.internal', u'redundant_state': 'BACKUP', 
u'host': u'10.150.0.201', u'disable_rp_filter': u'true', u'redundant_router': 
u'true', u'router_password': 
u'3838383966687309145665215760380045387957133810480803993986340699863084083818544695063990662780164604461468366180051318649230056294824943648327772148445755',
 u'redundant_master': False, u'port': u'8080', u'eth0ip': u'169.254.3.21', 
u'template': u'domP'}, u'id': u'cmdline'}
2016-05-06 20:32:20,796 DEBUGLoading data bag type ips
2016-05-06 20:32:20,796 DEBUGSetting router to master
2016-05-06 20:32:20,796 INFO Will proceed configuring device ==> eth2
2016-05-06 20:32:20,797 DEBUGExecuting: ip link set eth2 up
2016-05-06 20:32:20,800 INFO Bringing public interface eth2 up
2016-05-06 20:32:20,800 INFO Adding gateway ==> 192.168.4.1 to device 
==> eth2
2016-05-06 20:32:20,801 INFO Will proceed configuring device ==> eth1
2016-05-06 20:32:20,801 DEBUGExecuting: ip link set eth1 up
2016-05-06 20:32:20,804 INFO Bringing public interface eth1 up
2016-05-06 20:32:20,804 INFO Adding gateway ==> 10.152.0.1 to device 
==> eth1
2016-05-06 20:32:20,804 INFO Checking if default ipv4 route is present
2016-05-06 20:32:20,804 DEBUGExecuting: ip -4 route list 0/0
2016-05-06 20:32:20,807 WARNING  No default route found!
2016-05-06 20:32:20,807 INFO Adding default route
2016-05-06 20:32:20,807 DEBUGExecuting: ip route show default via 
10.152.0.1
2016-05-06 20:32:20,810 INFO Add default via 10.152.0.1
2016-05-06 20:32:20,810 DEBUGExecuting: ip route add default via 
10.152.0.1
2016-05-06 20:32:20,812 DEBUGConfiguring static routes
2016-05-06 20:32:20,813 DEBUGLoading data bag type staticroutes
2016-05-06 20:32:20,813 DEBUGProcessing CsStaticRoutes file ==> {u'id': 
u'staticroutes', u'10.87.0.0/16': {u'revoke': False, u'ip_address': 
u'192.168.4.4', u'gateway': u'192.168.4.1', u'network': u'10.87.0.0/16'}}
2016-05-06 20:32:20,813 DEBUGExecuting: ip route show | grep 
10.87.0.0/16 | awk '{print $1, $3}'
2016-05-06 20:32:20,818 DEBUGExecuting: ip route add 10.87.0.0/16 via 
192.168.4.1
2016-05-06 20:32:20,821 DEBUGExecuting: /usr/sbin/conntrackd -C 
/etc/conntrackd/conntrackd.conf -c
2016-05-06 20:32:20,824 DEBUGExecuting: /usr/sbin/conntrackd -C 
/etc/conntrackd/conntrackd.conf -f
2016-05-06 20:32:20,828 DEBUGExecuting: /usr/sbin/conntrackd -C 
/etc/conntrackd/conntrackd.conf -R
2016-05-06 20:32:20,831 DEBUGExecuting: /usr/sbin/conntrackd -C 
/etc/conntrackd/conntrackd.conf -B
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1943: CLOUDSTACK-9339: Send correct network type to router...

2017-02-15 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1943
  
LGTM based on code review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
Agreed with @leprechau .  I don't think just changing logrotate to compress 
and rotate at smaller size intervals will not completely solve our issues here. 
 We really need to adjust logrotate to run every hour, or make cloud.log less 
verbose by default.  I'm looking into seeing if it would be viable to make 
logrotate run every hour, but I believe that will require changing how the 
systemvm image is built by moving logrotate from cron.daily to cron.hourly.  
Not a huge deal, but I think it might be right approach over all since we have 
limited disk space in /var/log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@ustcweizhou - Thanks for the +1 on cron.hourly move.  From looking at the 
code, it looks like non-redundant VRs are already moving to cron.hourly, but 
vpcrouter isn't.  In our case, we are using vpcrouter.  I'm working on a PR 
against master that will fix the vpcrouter flavor of this code.  I'll link the 
PR here when I'm done testing.

I'd also like to understand why you would prefer 'size' over 'maxsize'.  I 
know the difference is subtle and it really won't apply to anything that is set 
to "hourly", but it could impact the dailys.  In the VR case with a limited 
/var/log partition size, I would think that the 'maxsize' option would be 
preferable.  It would keep run away log files in check by rotating them even 
before their interval is reached.

```size size
  Log files are rotated only if they grow bigger then size 
bytes.
  If size is followed by k, the size is assumed to  be  in  
kilo-
  bytes.  If the M is used, the size is in megabytes, and if G 
is
  used, the size is in gigabytes. So size 100,  size  100k,  
size
  100M and size 100G are all valid.
maxsize size
  Log files are rotated when they grow bigger than size bytes 
even before
  the additionally specified time interval (daily, weekly, 
monthly, 
  or yearly).  The related size option is  similar  except  
that  it 
  is mutually exclusive with the time interval options, and it 
causes
  log files to be rotated without regard for the last rotation 
time.  
  When maxsize is used, both the size and timestamp of a log 
file are  
  considered.
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@serbaut Just curious, are you using VPC routers?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1954: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-02-20 Thread dmabry

GitHub user dmabry opened a pull request:

https://github.com/apache/cloudstack/pull/1954

CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for 
vpcrouter

 in cloud-early-config

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myENA/cloudstack bug/vpc-vr-logrotate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1954


commit 450deed8472c06c4fec88e045bef28091502c638
Author: David Mabry 
Date:   2017-02-20T15:06:46Z

moved logrotate from cron.daily to cron.hourly for vpcrouter in 
cloud-early-config




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-20 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
I have submitted a PR against master that fixes cloud-early-config.
https://github.com/apache/cloudstack/pull/1954



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-20 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@ustcweizhou Thanks for taking the time to test as well.  I confirm in our 
testing over the weekend that we were able to consistently 
create/destroy/expunge VMs every 2 minutes without issue.  Before the PR 
https://github.com/apache/cloudstack/pull/1954 and this PR, we were having the 
VPC VR fall over ~8 hours into the test.

In summary, this PR with the one I submitted this morning solved our issues.

Thanks again for the help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-21 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@serbaut I agree with @ustcweizhou.  Please remove delaycompress and up to 
10.  I'd like to get this PR in as it is the second part of the problem 
resolution for my issue.  After that LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-21 Thread dmabry

Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
We are deploying this to our QA environment right now and hope to have it 
tested in a few days.  Great work @kiwiflyer and @nathanejohnson.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

67 matches

Mail list logo