Github user amoghv commented on the pull request:
https://github.com/apache/cloudstack/commit/35b741a1c93f525e52eb178db7496e4ec443b4a2#commitcomment-10349520
Sorry my bad, forgot about the SQL update file.
Yes, it would override the user's config when the upgrade path is called.
Had written this patch long ago, so don't remember the exact context around it.
But I think the idea was that not many folks use the field, plus its easy to
reset the field via UI if needed.
Thanks
Amogh
From: Rohit Yadav
mailto:notificati...@github.com>>
Reply-To: apache/cloudstack
mailto:re...@reply.github.com>>
Date: Monday, March 23, 2015 12:32 AM
To: apache/cloudstack
mailto:cloudst...@noreply.github.com>>
Cc: Amogh Vasekar
mailto:amogh.vase...@citrix.com>>
Subject: Re: [cloudstack] excluded plain text authenticator (35b741a)
@karuturi<https://github.com/karuturi> @amoghv<https://github.com/amoghv>
should we do a check/append, what if users already have PLAINTEXT and other
authenticators in user.authenticators.exclude - this will simply overwrite and
remove their configs.
â
Reply to this email directly or view it on
GitHub<https://github.com/apache/cloudstack/commit/35b741a1c93f525e52eb178db7496e4ec443b4a2#commitcomment-10338680>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
