Re: Review Request: BUG-ID: CLOUDSTACK-1713, CLOUDSTACK-1719
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10047/ --- (Updated March 22, 2013, 6:26 a.m.) Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den Hollander, and Noa Resare. Changes --- This patch is not yet submitted on master. The same is submitted on 4.1 branch. Hence, reopening this review request with the updated diff. Description --- BUG-ID: CLOUDSTACK-1713, CLOUDSTACK-1719 Summary: EC2 REST API: AWS APIs are not getting translated on the CloudStack Management Server and AWS API Installation Problems. This fixes the above two defects and other packaging related issues. Signed-off-by: Pradeep Diffs (updated) - awsapi-setup/setup/cloud-setup-bridge d25072d packaging/centos63/cloud.spec 16c3602 python/lib/cloudutils/serviceConfigServer.py a08ce02 Diff: https://reviews.apache.org/r/10047/diff/ Testing --- Packaging went through with the fixes. Thanks, Pradeep Soundararajan
RE: [ACS41] Review request for the fix - failed to download default template
https://reviews.apache.org/r/9900/ Please find it. Thanks, Pradeep S -Original Message- From: srivatsav.prasa...@gmail.com [mailto:srivatsav.prasa...@gmail.com] On Behalf Of prasanna Sent: Friday, March 22, 2013 1:53 PM To: dev@cloudstack.apache.org Subject: Re: [ACS41] Review request for the fix - failed to download default template On 22 March 2013 02:45, Sudha Ponnaganti wrote: > Hi, > > Can anyone pick up the review for defect > https://issues.apache.org/jira/browse/CLOUDSTACK-1252 > We need this fix today > There is a lot of discussion on the JIRA ticket that I couldn't follow. It seems this is a non-oss packaging issue? Someone pass me the review request please.
Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9900/ --- (Updated March 22, 2013, 10:21 a.m.) Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido den Hollander, and Noa Resare. Changes --- Updated the patch. It is for 4.1 only, let me create a patch for master. Description --- BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware Proposing to modify package.sh script. Package as per OSS or NONOSS arguments. Signed-off-by: Pradeep -- Now package.sh will act based on the below usage i.e. with or without arguments: ./package.sh -h usage: ./package.sh [-p|--pack] [-h|--help] [ARGS] The commonly used Arguments are: oss|OSS To package OSS specific nonoss|NONOSS To package NONOSS specific Examples: ./package.sh -p|--pack oss|OSS ./package.sh -p|--pack nonoss|NONOSS ./package.sh (Default OSS) --- Diffs (updated) - packaging/centos63/cloud.spec a7a6927 packaging/centos63/package.sh 2515ecb Diff: https://reviews.apache.org/r/9900/diff/ Testing --- I have tested these changes. They are working well. Please review and submit it if you are fine. In future, we can even change the mvn commands as per our need from cloud.spec. Thanks, Pradeep Soundararajan
RE: Cloudstack git repositories
Have this repo has been added in review board " https://reviews.apache.org"; repo server list? Thanks, Pradeep S -Original Message- From: Murali Reddy [mailto:murali.re...@citrix.com] Sent: Thursday, March 21, 2013 1:23 PM To: dev@cloudstack.apache.org; cloudstack Subject: Re: Cloudstack git repositories On 21/03/13 12:39 PM, "Sateesh Chodapuneedi" wrote: >Unable to access Cloudstack git repositories. >Seems infra is migrating our git repos off incubator. > >Regards, >Sateesh > Change the .git config to refer "git-wip-us.apache.org/repos/asf/cloudstack.git"
Review Request: BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10079/ --- Review request for cloudstack, Chip Childers, Prasanna Santhanam, Hugo Trippaers, and Wido den Hollander. Description --- BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware Proposing to modify package.sh script. Package as per OSS or NONOSS arguments. Signed-off-by: Pradeep -- Now package.sh will act based on the below usage i.e. with or without arguments: ./package.sh -h usage: ./package.sh [-p|--pack] [-h|--help] [ARGS] The commonly used Arguments are: oss|OSS To package OSS specific nonoss|NONOSS To package NONOSS specific Examples: ./package.sh -p|--pack oss|OSS ./package.sh -p|--pack nonoss|NONOSS ./package.sh (Default OSS) --- Diffs - packaging/centos63/cloud.spec 16c3602 packaging/centos63/package.sh 2515ecb Diff: https://reviews.apache.org/r/10079/diff/ Testing --- Thanks, Pradeep Soundararajan
[ACS41][PatchRequest] CLOUDSTACK-1252: Failed to download default template in VMware
Could you please add this in 4.1? Commit 01ea7232d9a7e956277f03c8471d8d4e2b60d699 in branch refs/heads/master from Prasanna Santhanam mailto:t...@apache.org>> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=01ea723 ] CLOUDSTACK-1252: Failed to download default template in VMware Proposing to modify package.sh script. Package as per OSS or NONOSS arguments. Thanks, Pradeep S
RE: Cloudstack git repositories
Yes, I am unable to send reviews using post-review tool. I am able to send it manually. >>> RBTools 0.4.1 >>> Home = /home/pradeep-ubuntu >>> HTTP GETting api/ >>> HTTP GETting https://reviews.apache.org/api/info/ >>> Using the new web API >>> Attempting to create review request on >>> https://git-wip-us.apache.org/repos/asf/cloudstack.git for None >>> HTTP POSTing to https://reviews.apache.org/api/review-requests/: >>> {'repository': 'https://git-wip-us.apache.org/repos/asf/cloudstack.git'} >>> Got API Error 206 (HTTP code 400): The repository path specified is not in >>> the list of known repositories >>> Error data: {'stat': 'fail', 'repository': >>> 'https://git-wip-us.apache.org/repos/asf/cloudstack.git', 'err': {'msg': >>> 'The repository path specified is not in the list of known repositories', >>> 'code': 206}} There was an error creating this review request. The repository path "https://git-wip-us.apache.org/repos/asf/cloudstack.git"; is not in the list of known repositories on the server. Ask the administrator to add this repository to the Review Board server. For information on adding repositories, please read http://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/ Thanks, Pradeep S -----Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Friday, March 22, 2013 6:23 PM To: dev@cloudstack.apache.org Cc: cloudstack Subject: Re: Cloudstack git repositories On Fri, Mar 22, 2013 at 6:44 AM, Pradeep Soundararajan wrote: > Have this repo has been added in review board " https://reviews.apache.org"; > repo server list? > > Thanks, > Pradeep S > We did some basic testing yesterday. Are you running into problems? --David
RE: [ACS41][PatchRequest] CLOUDSTACK-1252: Failed to download default template in VMware
Chip, I have reopened the one for you in 4.1. https://reviews.apache.org/r/9900/ This applies well in 4.1. Let me know if you still see any issue. Thanks, Pradeep S -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Friday, March 22, 2013 8:53 PM To: Pradeep Soundararajan Cc: cloudstack-...@incubator.apache.org; Wido den Hollander; Prasanna Santhanam; Hugo Trippaers Subject: Re: [ACS41][PatchRequest] CLOUDSTACK-1252: Failed to download default template in VMware On Fri, Mar 22, 2013 at 11:40:04AM +, Pradeep Soundararajan wrote: > Could you please add this in 4.1? > > > Commit 01ea7232d9a7e956277f03c8471d8d4e2b60d699 in branch > refs/heads/master from Prasanna Santhanam > mailto:t...@apache.org>> > > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=01ea723 ] > > > > CLOUDSTACK-1252: Failed to download default template in VMware > > > > Proposing to modify package.sh script. Package as per OSS or NONOSS arguments. > > Thanks, > Pradeep S > Cherry-pick has conflicts. Please provide a clean patch to work with. Conflict is in cloud.spec as below: <<<<<<< HEAD mvn -P awsapi package -Dsystemvm === if [ "%{_ossnoss}" == "NONOSS" -o "%{_ossnoss}" == "nonoss" ] ; then echo "Packaging nonoss components" mvn -Pawsapi,systemvm -Dnonoss package else echo "Packaging oss components" mvn -Pawsapi package -Dsystemvm fi >>>>>>> 01ea723... CLOUDSTACK-1252: Failed to download default template >>>>>>> in VMware
Review Request: EC2 REST API: AWS APIs are not getting translated on the CloudStack Management Server and AWS API Installation Problems
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10135/ --- Review request for cloudstack, Chip Childers, Prachi Damle, Likitha Shetty, Hugo Trippaers, and Wido den Hollander. Description --- BUG-ID: CLOUDSTACK-1713, CLOUDSTACK-1719 Summary: EC2 REST API: AWS APIs are not getting translated on the CloudStack Management Server and AWS API Installation Problems. Fixing the class not found exception, key not found and other issues as mentioned in the above two defects. Signed-off-by: Pradeep Diffs - awsapi/src/com/cloud/bridge/util/EncryptionSecretKeyCheckerUtil.java 0a652212b3eff91fdf950b189681713a7468a0b0 packaging/centos63/cloud.spec db37afc475ff95315f4d18a08656a7ce86537487 utils/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java 2be274921cce305b1a78513ad405c4ca895fc384 utils/src/com/cloud/utils/crypt/EncryptionSecretKeyChecker.java 5ffa14f30888924a5d26a2e70b23251d474743d5 Diff: https://reviews.apache.org/r/10135/diff/ Testing --- Tested the build + packaging with this patch. Thanks, Pradeep Soundararajan
RE: [ACS41] Bugs blocking our 4.1 release
Resolved --- CLOUDSTACK-1719 EC2 REST API: AWS APIs are not getting translated on the CloudStack Management Server Pradeep Soundararajan Unable to reproduce with the steps I have mentioned in the defect. Hence, dropping from Blocker --- CLOUDSTACK-1694 Issues to start/access Management Server after upgrade from 4.0 to 4.1 Pradeep Soundararajan Closed by Sangeetha as this is being tracked as part of CLOUDSTACK-1694 --- CLOUDSTACK-1802 Upgrade 4.0 -> 4.1 - Not able to strat management server becasue of missing /etc/cloudstack/management/tomcat6.conf file. Pradeep Soundararajan Thanks, Pradeep S -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Tuesday, March 26, 2013 1:45 AM To: dev@cloudstack.apache.org Subject: [ACS41] Bugs blocking our 4.1 release Hi all, The following bugs need to be either (1) resolved or (2) triaged as not being as high a priority as they are now before I cut the RC. Can folks take a moment to review and update / fix accordingly please? CLOUDSTACK-1694 Issues to start/access Management Server after upgrade from 4.0 to 4.1 Pradeep Soundararajan CLOUDSTACK-1719 EC2 REST API: AWS APIs are not getting translated on the CloudStack Management Server Pradeep Soundararajan CLOUDSTACK-1772 the change in vnc listening port will cause live migration doesn't work edison su CLOUDSTACK-1795 Customize AOP to fully support legacy CloudStack @DB and @ActionEvent semantics Kelven Yang CLOUDSTACK-1664 Action Events are not logged due to spring changes Kelven Yang CLOUDSTACK-1673 AWS Regions - Events - User disable event does not include the UUID of the user that was disabled. Murali Reddy CLOUDSTACK-1740 Failed to view console Rajesh Battala CLOUDSTACK-1755 IPv6 - When Vm is part of Dual network , /etc/reslov.conf does not have ipv6 router ipaddress and ipv6 external dns.Sheng Yang CLOUDSTACK-1789 Unable to download templates to Primary Storage if a host is in maintenance edison su CLOUDSTACK-1802 Upgrade 4.0 -> 4.1 - Not able to strat management server becasue of missing /etc/cloudstack/management/tomcat6.conf file. Pradeep Soundararajan I'd also like us to resolve https://issues.apache.org/jira/browse/CLOUDSTACK-1796 - which is a Japanese docs building issue. Sebastien, can you please review the latest from Transifex (per latest comment from Hiroaki)? -chip
RE: [ACS41][QA] Has anyone upgraded from 4.0 to 4.1
These are my observations I have captured during my testing: 1) 'service cloudstack-management start' is failing for the first time since it did not find tomcat6.conf and server.xml. This will get created (symb links) only if you execute "cloudstack-setup-management" for the first time after the upgrade since this will be treated as a fresh install because rpm names and locations have been changed from 4.1. I have found the symb links are getting updated during the upgrade only if the upgrade path is present already. In our situation upgrade path is pretty new. 2) I have observed db.properties of 4.1 is different from 4.0. I have observed there is an issue with db.properties initially, that is the reason I have tried to redploy DB and launched 4.1 MS. But realized and got to know from QA that we should not redploy db after the upgrade. Let me know how to handle the situation if db.properties are changed in 4.1. I was trying to keep a check in cloud.spec incase cloud-client is present in the system or not. Then I was trying to provide the symb link of the files which are needed for the upgrade like db.properties, tomcat6.conf etc from the old path /etc/cloud/management to the new path /etc/cloudstack/management. I have tried these below in cloud.spec but went in vain: %define _rpm_check_ver %(`rpm -q cloud-client-4.0.0 > /dev/null`) %if "%{?_rpm_check_ver}" != "0" Obsoletes: cloud-client < 4.1.0 %endif I hope Marcus is looking at this now. Let's wait for his feedback. Thanks, Pradeep S -Original Message- From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com] Sent: Tuesday, March 26, 2013 2:45 AM To: dev@cloudstack.apache.org Subject: [ACS41][QA] Has anyone upgraded from 4.0 to 4.1 Hi, Requesting help to resolve the following issue, if you have done upgrade. https://issues.apache.org/jira/browse/CLOUDSTACK-1694 Upgrade is failing - if there is anyone that can take a look at it during US time zone that would be great. Thanks /Sudha
MASTER NONOSS BUILD FAILURE
[INFO] Apache CloudStack Server .. FAILURE [36.121s] . . [INFO] BUILD FAILURE [INFO] [INFO] Total time: 1:39.509s [INFO] Finished at: Thu Mar 28 15:56:08 PDT 2013 [INFO] Final Memory: 30M/303M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12:test (default-test) on project cloud-server: There are test failures. [ERROR] [ERROR] Please refer to /root/jenkins/build/workspace/ASF-build-master-nonoss-rhel63/server/target/surefire-reports for the individual test results. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :cloud-server Build step 'Execute shell' marked build as failure
RE: MASTER NONOSS BUILD FAILURE
Please find the surefire report https://www.dropbox.com/s/vyq610sdqzs7pt9/surefire-reports.zip As discussed, I will create a new node for master-nonoss build in Jenkins.cs.o once I am free. Thanks, Pradeep S -Original Message- From: prasanna [mailto:srivatsav.prasa...@gmail.com] On Behalf Of Prasanna Santhanam Sent: Friday, March 29, 2013 12:36 PM To: dev@cloudstack.apache.org Subject: Re: MASTER NONOSS BUILD FAILURE This will need the stacktrace from the maven-surefire report in server. Can you post those? Also - there should've been a job on jenkins.cs.o looking at the nonoss build. Can you refresh that with your latest nonoss jars? I've given you access on jenkins. If the job's running it'll be easier to track these build breaks. -- Prasanna., On Fri, Mar 29, 2013 at 06:50:24AM +, Pradeep Soundararajan wrote: > [INFO] Apache CloudStack Server .. FAILURE > [36.121s] > > > [ERROR] Please refer to > /root/jenkins/build/workspace/ASF-build-master-nonoss-rhel63/server/target/surefire-reports > for the individual test results. >
Re: Review Request: BUG-ID: CLOUDSTACK-1689
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9946/ --- (Updated March 29, 2013, 10:41 a.m.) Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, and Wido den Hollander. Changes --- I have noticed this patch has not been applied. Please apply it. Description --- BUG-ID: CLOUDSTACK-1689 Summary: KVM agent install.sh should install ipset command Added ipset in cloud.spec as part of agent install. Signed-off-by: Pradeep Diffs (updated) - packaging/centos63/cloud.spec e10ae1e Diff: https://reviews.apache.org/r/9946/diff/ Testing --- Packaging ipset properly after this change. Thanks, Pradeep Soundararajan
RE: 4.1 Patches on review board
9946Referenced bug is fixed Pradeep Update the patch with commit details and mark the patch as submitted This patch has not been applied. I have sent the request once again with the latest diff to apply it. Thanks, Pradeep S -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Friday, March 29, 2013 11:41 AM To: dev@cloudstack.apache.org Subject: 4.1 Patches on review board I was reviewing the patches on the review board and following 4.1 patch needs some action from the submitters? Kelven, Kishan, Pradeep please review your action items. Review# Status Who to take Action Action Item 9860Committed Kelven Mark as submitted 9888Referenced bug is fixed Kelven Is the patch still needed 10145 Committed in 4.1Kelven Mark as submitted and commit changes to master 10059 Not applied, pending submitter response Kishan Is this needed for 4.1 9946Referenced bug is fixed Pradeep Update the patch with commit details and mark the patch as submitted Thanks Animesh
RE: 4.1 Patches on review board
Sure, thanks Prasanna. -Original Message- From: prasanna [mailto:srivatsav.prasa...@gmail.com] On Behalf Of Prasanna Santhanam Sent: Friday, March 29, 2013 4:46 PM To: dev@cloudstack.apache.org Subject: Re: 4.1 Patches on review board On Fri, Mar 29, 2013 at 10:43:12AM +, Pradeep Soundararajan wrote: > 9946 Referenced bug is fixed Pradeep > Update the > patch with commit details and mark the patch as submitted > > This patch has not been applied. I have sent the request once again > with the latest diff to apply it. Thanks Pradeep, Applied to master and 4.1. Be sure to remind the list when the patch hasn't recieved attention within a week. -- Prasanna.,
Review Request: debian: adding ipset as part of agent install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10216/ --- Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den Hollander, and Noa Resare. Description --- debian: adding ipset as part of agent install as per Chip. Signed-off-by: Pradeep Diffs - debian/control 8f82fc3ab2faefa1bc41e45a79abf376c0f2bc2a Diff: https://reviews.apache.org/r/10216/diff/ Testing --- Debian packaging went through. Thanks, Pradeep Soundararajan
Re: Review Request: BUG-ID: CLOUDSTACK-1689
> On March 29, 2013, 12:46 p.m., ASF Subversion and Git Services wrote: > > Commit 5a66ec35ad08ff3313e72b54eba7e1754868eee4 in branch refs/heads/bvt > > from Prasanna Santhanam > > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5a66ec3 ] > > > > CLOUDSTACK-1689: KVM agent install.sh should install ipset command > > > > Added ipset in cloud.spec as part of agent install. > > > > Signed-off-by: Pradeep > > Signed-off-by: Prasanna Santhanam > > I hope I have added as part of debian agent install. Chip, please review this https://reviews.apache.org/r/10216 - Pradeep --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9946/#review18508 ------- On March 29, 2013, 10:41 a.m., Pradeep Soundararajan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9946/ > --- > > (Updated March 29, 2013, 10:41 a.m.) > > > Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, > and Wido den Hollander. > > > Description > --- > > BUG-ID: CLOUDSTACK-1689 > > Summary: KVM agent install.sh should install ipset command > > Added ipset in cloud.spec as part of agent install. > > Signed-off-by: Pradeep > > > Diffs > - > > packaging/centos63/cloud.spec e10ae1e > > Diff: https://reviews.apache.org/r/9946/diff/ > > > Testing > --- > > Packaging ipset properly after this change. > > > Thanks, > > Pradeep Soundararajan > >
https://cwiki.apache.org is down
Could someone look into this? Thanks, Pradeep S